From nobody Fri May 2 00:03:25 2025
Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com
[209.85.218.52])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863DA213E6A
for <linux-kernel@vger.kernel.org>; Wed, 9 Apr 2025 20:37:34 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.218.52
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1744231058; cv=none;
b=gJA4sK3duYuiVEDhePk2Yeya2iDf02HRO2KZmKmq4jx1JWD5ALVXkmQ89vFQ51HDsaiwTXdzkXu7MDQ1fCOHr6o6Lay+T1cgt2PeDl+hIbQHZ0sKLAelL8LIN30xpcbEP9VI/KaS//x490oVR0Dyugm/iymBBmq1sH6J5QJaCfE=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1744231058; c=relaxed/simple;
bh=oKsUOZVVIPJ0FZ1hRtLGE+U8FMFNMZ/Ejmjo0fiUpc0=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
In-Reply-To:To:Cc;
b=Gyf+btNL8QtEJgWQ1g49XBgqxDN6IwKi4zlj4uul237KueHxKo1QLOierSzetfOBaVEd0h3nqmvn13wwl3pPOzTz9ZYoylwt4gaNK69ca1RL8gl3MlKBEycTJO0NaPA+/ywpFUm/8AeStbD5TV5XiwLHZPW5lArx44oNs2cRuxI=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=P4nuTEp/; arc=none smtp.client-ip=209.85.218.52
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="P4nuTEp/"
Received: by mail-ej1-f52.google.com with SMTP id
a640c23a62f3a-ac41514a734so19031166b.2
for <linux-kernel@vger.kernel.org>;
Wed, 09 Apr 2025 13:37:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1744231052; x=1744835852;
darn=vger.kernel.org;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=K4jcXi1XTosiHhMqSSsNm0hu0JnYFeJKR1d2RSvQQcw=;
b=P4nuTEp//DciYDHu3tCnU+YAs5wD2T3rCQs86x6Ng0rrx0L/7ffORpOspH5UG/7NEM
QWHNggAKGBBqqkE1AxHz+/BoNwjLje4MywJTwZX9btBfwOOpdlRvWv2vRxi7SjaRQGex
be9G48KhEn4OaWVscU0ufcQeAgr01jFn4/dVrdkC4oTk3MAHwRhu/Vm76JGxBXiK/lMJ
nlzDUbMBuO0KwAYXMGbv7cKXt+Yfac4J5ZgfRKKweWxXHc38OJ3pLKPG3NlErzthEayx
+M8oj/jP7OWVn3KDCEYq4oBhxhHTw7AZLVxivOLq8h4dPahArkV7BccgZb26sWQoFwDF
nvIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744231052; x=1744835852;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=K4jcXi1XTosiHhMqSSsNm0hu0JnYFeJKR1d2RSvQQcw=;
b=DGmMyncO0n6TUILZEjancb49aWh90wmUph2yYfR/5ilS+F5mnKrLGF/6TxcvxmcCvB
TGGWcq5Q64oOQekmz6I8ZOsQ6rN6VKF4XMmC1sou4vDYhkShsmDVPCeAaNEX6VEgj8YW
jUz0fPTdbOsGvY5ImrMzvIm5OShyBfoywQc0rhFuNfXr1/D4AvkD6/2JYGj4oC3bJyY8
Xxmaq91dWNd4cVaxIDbBg/Mo666oYIl8GwyJ5gTGVGos8ot6Fi+MxGMfBqxUMnYDurvQ
HBuw5fvxsMbSj1oLtvWmWFQ7AKmDGKqB2tueYxwcabVVMoL09tWmX8rgwdt/dDTPoVg+
OFeA==
X-Forwarded-Encrypted: i=1;
AJvYcCUGHN8Zo/m0aoUxH5d5bNQFG1xuu5A9nlyti/1+PXxZprv3Tod1A0BBKMXJ1Va19kXO227U9IB9usHdGpM=@vger.kernel.org
X-Gm-Message-State: AOJu0YyqIJbXbuSAnKTdmHrgmerFiijt211kDtMwm80XtEsPoZvSCpTt
EIkZJ78bX+uOYO+7zgLfLnFLkwNKwdBkXTXhfJqf5tZRQ7e4Lih3usaWNXLP+ts=
X-Gm-Gg: ASbGncsDRhk5weTPbV/RS3ofCf8COteohN24+PlmyEoAZKeNIHEY3hEjYmjv++pPEPY
Z65ZPLENZDCIRjnqEXGoXF43XLexWua7TB0XP69pysIuc3qYkQzkmVrtbKiV2Dszm6JXAeTMhSo
LvW54jjN0LR0uNt5aKXn6+LHf0ZUt0WOkShaRm1b6RAwlLBKV1qJ5yVyhfcTg/FCAUPA4qX6M09
CzVrCWn3yjCJKamF5vlvxRAHMkAo/j3ENQlLXRS1JaFgmO12mZh444TVgWaha/ei3yRpzdR54HG
+1UzXAY+5j8ZRqRFRLHr8dXpTPhS1x2etu/aviBgYOKJFsRZiYJcOlcuCddVI3B40CyX/B2+ES3
rnJTwqggbszDIv7PlUrcfN3tFlcBrk4cyUexiJg==
X-Google-Smtp-Source:
AGHT+IGwqRhQoC3fOMayfmVAcj7UA23NDr6Q3DFxxTe6qZCKM345xZ2mndUpMT12OV06uBa0ucpMZQ==
X-Received: by 2002:a17:907:3e1b:b0:ac7:cdaa:8946 with SMTP id
a640c23a62f3a-acabd181303mr9820366b.11.1744231052442;
Wed, 09 Apr 2025 13:37:32 -0700 (PDT)
Received: from puffmais.c.googlers.com
(40.162.204.35.bc.googleusercontent.com. [35.204.162.40])
by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 09 Apr 2025 13:37:32 -0700 (PDT)
From: =?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Date: Wed, 09 Apr 2025 21:37:27 +0100
Subject: [PATCH v4 06/32] mfd: sec: Update includes to add missing and
remove superfluous ones
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <20250409-s2mpg10-v4-6-d66d5f39b6bf@linaro.org>
References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>, kernel-team@android.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
=?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
X-Mailer: b4 0.14.2
This driver misses to include some of the respective headers of some of
the APIs used. It also includes headers that aren't needed (e.g. due to
previous driver rework where includes weren't updated).
It is good practice to directly include all headers used, which avoids
implicit dependencies and spurious build breakage if someone rearranged
headers, as this could cause the implicit includes to be dropped.
Include the relevant headers explicitly and drop superfluous ones.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Andr=C3=A9 Draszik <andre.draszik@linaro.org>
---
drivers/mfd/sec-core.c | 7 +++----
drivers/mfd/sec-irq.c | 5 ++++-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index e31b3a6fbc8922e04a8bfcb78c85b6dbaf395e37..b12020c416aa8bf552f3d3b7829=
f6a38a773f674 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -3,9 +3,9 @@
// Copyright (c) 2012 Samsung Electronics Co., Ltd
// http://www.samsung.com
=20
+#include <linux/device.h>
#include <linux/err.h>
#include <linux/i2c.h>
-#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/mfd/core.h>
#include <linux/mfd/samsung/core.h>
@@ -17,13 +17,12 @@
#include <linux/mfd/samsung/s2mps15.h>
#include <linux/mfd/samsung/s2mpu02.h>
#include <linux/mfd/samsung/s5m8767.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
-#include <linux/mutex.h>
#include <linux/of.h>
+#include <linux/pm.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
-#include <linux/slab.h>
=20
static const struct mfd_cell s5m8767_devs[] =3D {
{ .name =3D "s5m8767-pmic", },
diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c
index 5c0d949aa1a20f5538d8baf7a8aefc1160ffa14c..3ed2902c3a2634a6ea656d890ec=
ea934053bd192 100644
--- a/drivers/mfd/sec-irq.c
+++ b/drivers/mfd/sec-irq.c
@@ -3,7 +3,10 @@
// Copyright (c) 2011-2014 Samsung Electronics Co., Ltd
// http://www.samsung.com
=20
-#include <linux/device.h>
+#include <linux/array_size.h>
+#include <linux/build_bug.h>
+#include <linux/dev_printk.h>
+#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/mfd/samsung/core.h>
--=20
2.49.0.604.gff1f9ca942-goog