From nobody Fri May 2 15:03:31 2025
Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com
[209.85.218.42])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id AECD7213E61
for <linux-kernel@vger.kernel.org>; Wed, 9 Apr 2025 20:37:52 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.218.42
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1744231078; cv=none;
b=ZQKIkjZdQn8+D0KngqCyMJYIyo8FQnaojmHy+AJXNedrWR1dDNC6R3op2wsViMQtBC72g+pkgVfh2LGt8OyFw1hS+uBLzkmNngvxB4K7PeZV1sdBkvdwdbCd8JjYdwpqO5ix9iEzbcNhDxF5c6jF7AUc5YKOST94pDtHG19M/Dw=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1744231078; c=relaxed/simple;
bh=9E57e45BxMl50555VhXLsBvSd4mm5Cl4BbZdxjc19jQ=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
In-Reply-To:To:Cc;
b=BZ23P7BXu7zUAy3VySFcAEoUuGVdzCEj2m3OsTfkUlBgrfKFEHMYVMC5akadDCn6QCXVWO4sQkWF+aTWNyLWmYZs2BUP9DiStNyatrOqWRnS1qfeFO59Skxr8Ner7b8m1msIATmER8v2lixOpElZOABKi4xW2YRmy13g2yFJVTc=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=dis10PpJ; arc=none smtp.client-ip=209.85.218.42
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="dis10PpJ"
Received: by mail-ej1-f42.google.com with SMTP id
a640c23a62f3a-abbb12bea54so19173966b.0
for <linux-kernel@vger.kernel.org>;
Wed, 09 Apr 2025 13:37:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1744231065; x=1744835865;
darn=vger.kernel.org;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=aro3/v5oHaDdhAQCIG1fg5IWgisO7nOka33BpVTMzSM=;
b=dis10PpJJhuLLHNlk8a/obGOaMJdSRYCXYh2upQuJb1jcQzWrlAC664y+VpfySvmQr
UhVSEfDuvh0XFFSrh5FmL5wPe8zbp4Lj5rp2B6yWHqVJR3PEx9V+R7heoaSkq+ORV52i
0Dr2NtbM6ALIb9Id10LekqdVU/hAp93o1u13B4MDR40LjI/j9BvYyqTWBvdA3qF3Td2g
i+HFFQKseSUf0O9Pm9Hqg53z0nIBE6PGQls62GsR5T5JM/17Jf9EVDUiInOpdlMdl4QB
0F7JmlU376JsFX6T1tAV8xZEVqKqSVWz/u1t86zWJtZbFbSK5QqTYkucdOA7k9hZkpBS
mcPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744231065; x=1744835865;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=aro3/v5oHaDdhAQCIG1fg5IWgisO7nOka33BpVTMzSM=;
b=obdVqmVSsAhd4zWesfDLtF2MA5p/JW44IzjqslEPCtK4qtqfUebSK1x/joDfcDYqrj
1kAcxfaFgMJtIeWA8qHOSp6bIN0LH5HAfPDZN8HEVgCP9+xcTQ/tPA/g3AbLaAfOVTvh
PaoFFR1ng8NmnaHZSx+R7YeTA43gEFdJ/7PCmAJTLsV6sjTDLo4QuKI09vP/v8INmodk
bIBb5DHYsGlhxZoT0LPhF80ckfSfstiIbpN2QvhrWUeII2ZLpq6stNaRrGnb/P5AwJ8C
2/entkWah8KpMxykKCIUy8XE5gZ9o6JaXA0NsN7B+0BJ/kj1rIHbxqGROeb0V0ZBl8It
85Pg==
X-Forwarded-Encrypted: i=1;
AJvYcCW9p9LvBEz85feKBEb7DK+oBQqFta9AcE76dKQUgZeZEK5+GLsNdEkEJl00PjdmUCvGCZRVQf4yHSV0iRs=@vger.kernel.org
X-Gm-Message-State: AOJu0YwdAq2KOhqdvLBai9Bn1IpbIP7ykjTgbFt4BD23rvVL9yRrXHAo
SVcyThuGCg2zxiCdNneEWU79WCCLZf8asduvVV9nyg1inErACl0dMlSjwNTKLfk=
X-Gm-Gg: ASbGncsIVDr9ArBLv+zVSHh47PsJlqGrB26k0ZqHvfz4+BNRcr0LTthpRG6o1Qzibui
/rzgIyexpY6UWy+h85xuNa72t7H/WrEjA/26WfXMPFbtCI9Me0t3p+ONW66x1f40PrSRmLm4fOv
RWCDWQztp0Zx+YXYlNIIsMMnVzKmwRIYUTrg5n4+JvdnzhRDPbbJ4xWG3sqCVJtZ4XmxSsWvZUR
rxUD/PHH2H/WT/RFpl8GA+vaBU19E+4hE6ObkgngZDN+GoMf79p2WB0xIK99l12GqveTA6HuoiT
HoP55sK02RplOmqnasv+XgohhLO4VBYtNQGud0716g8/LtTG9FMG/epkGFKpd0i2ES+a2bc5Org
sZWsB55jGinCRMcj1PNXPfS9k1jw=
X-Google-Smtp-Source:
AGHT+IEdkkXow6n79ZWPbZRhN5XFCjydXvQNxgGlSC/PrHUaOACC0tp9PiBCaVoIN+0xJ5YXvd/Wlg==
X-Received: by 2002:a17:907:3e0f:b0:ac7:391a:e159 with SMTP id
a640c23a62f3a-acabd4d8449mr5988466b.60.1744231065076;
Wed, 09 Apr 2025 13:37:45 -0700 (PDT)
Received: from puffmais.c.googlers.com
(40.162.204.35.bc.googleusercontent.com. [35.204.162.40])
by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.44
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 09 Apr 2025 13:37:44 -0700 (PDT)
From: =?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Date: Wed, 09 Apr 2025 21:37:51 +0100
Subject: [PATCH v4 30/32] rtc: s5m: replace regmap_update_bits with
regmap_clear/set_bits
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <20250409-s2mpg10-v4-30-d66d5f39b6bf@linaro.org>
References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>, kernel-team@android.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
=?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
X-Mailer: b4 0.14.2
The regmap_clear_bits() and regmap_set_bits() helper macros state the
intention a bit more obviously.
Use those.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Andr=C3=A9 Draszik <andre.draszik@linaro.org>
---
drivers/rtc/rtc-s5m.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index f4caed953efdd23fd0132d74d5199dec9cdfd294..27115523b8c25794a9f3ac8e734=
bb1ed998e9518 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -338,8 +338,8 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_inf=
o *info)
=20
/* On S2MPS13 the AUDR is not auto-cleared */
if (info->device_type =3D=3D S2MPS13X)
- regmap_update_bits(info->regmap, info->regs->udr_update,
- S2MPS13_RTC_AUDR_MASK, 0);
+ regmap_clear_bits(info->regmap, info->regs->udr_update,
+ S2MPS13_RTC_AUDR_MASK);
=20
return ret;
}
@@ -351,10 +351,8 @@ static int s5m_rtc_read_time(struct device *dev, struc=
t rtc_time *tm)
int ret;
=20
if (info->regs->read_time_udr_mask) {
- ret =3D regmap_update_bits(info->regmap,
- info->regs->udr_update,
- info->regs->read_time_udr_mask,
- info->regs->read_time_udr_mask);
+ ret =3D regmap_set_bits(info->regmap, info->regs->udr_update,
+ info->regs->read_time_udr_mask);
if (ret) {
dev_err(dev,
"Failed to prepare registers for time reading: %d\n",
--=20
2.49.0.604.gff1f9ca942-goog