From nobody Sat May 3 22:15:53 2025
Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com
[209.85.208.42])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84EC021CFFA
for <linux-kernel@vger.kernel.org>; Wed, 9 Apr 2025 20:37:52 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.208.42
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1744231078; cv=none;
b=YM95BGa2N6Ug1+WsZargmosBzCLl8nKTyBJ9/PJ4lmWnzkR0qTeUCBJaIRXAkAQLy+DrDwHbHl5Hhx3IDpLJ8XTz2JB4bpTpb+hKF/trEBY9dwntvp5bvIkZ0OhF2b4f0buuWIS6aSQ7NFSN5wmf88C1Bk4gnXOq0OXqSVq3U/o=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1744231078; c=relaxed/simple;
bh=AQOh1SAmTjWO6vzJ8CZkmZ+2uws48CsZYe/GOw/fK5s=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
In-Reply-To:To:Cc;
b=i9R26e2uielB0YyLDUOE2KRE3Fg8fHPIHWlE5aO2TvR0oJ2VRpfRYS0waaShaara2pIbTEOWHKVjkKZblzcUrNEDvfih9TztYQIddyWEEt8fJxjg2gpPWcF24OQBepKfF/wH8vYkIgl9nFKUIQJgpqIF/08yQHvpjB5xLzc9s84=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=qWvQaglg; arc=none smtp.client-ip=209.85.208.42
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="qWvQaglg"
Received: by mail-ed1-f42.google.com with SMTP id
4fb4d7f45d1cf-5e60cfef9cfso191714a12.2
for <linux-kernel@vger.kernel.org>;
Wed, 09 Apr 2025 13:37:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1744231064; x=1744835864;
darn=vger.kernel.org;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=+zcRydoPq0e3uOYwLlj7ABnDIgPKatAxdb7+TG8s1Ss=;
b=qWvQaglgLv2lTaKwxS+lfEzU8PLEEPSwpZhB8yOV5+a4qJvgRYG4O37f5tzZWZPqla
OLTr20EO3qW96L7iGj2qKI9Z9Q5MmG15dYUtsP5VwoWnpbv2X5ruOon3QunQk7ETp/OA
F1ZmsA7OcDzf89HOaPwm5sTZqgClRg/869lniWKsBIRbOtHwpxCoYq2IcvUZTYHZfg4Z
Tq+4WppFDucsk2p9QNhttj8dx1ft47D7ul0UJYq6yRtWis3rI8DGw7QcTrm3wZkAm3yr
Sd/jKbmTmBUHGH0ui3/QIMCs1chenKUEb/PUVwr2lQwLlVCMW+cY7U31W2TlImumNmGm
v5HA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744231064; x=1744835864;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=+zcRydoPq0e3uOYwLlj7ABnDIgPKatAxdb7+TG8s1Ss=;
b=uYOk8fYeT916zW3ZAnflD+W6FdXKkTkjQAOFAp+rdYinHJPAEFUW4UqC8PIB/NBjxI
hb3eOzGpdJkPAYaT1tNcqHFi91yHJxROvzilIXYaPBjDWVuiZUy6PL9f1QK1orR4coQ3
x3qnNfKrV0T6CibeM3CPX2lLYR+ATOh7cGhKnZgvX0bfzkb5GeNbvRjumurh/aVdCP5/
CsJzaIszqplGpGyOXu9dFe8Woolr4ILfg77ERpld2HzcBR4EM9fTZa7Qq0gQrXB0ie3l
JLE4p++gpDIdPEvavcwZSTObTMnR39IOGYvU8svhYugB++J/D4igcvjvzaksfwidZNGU
3COQ==
X-Forwarded-Encrypted: i=1;
AJvYcCXG6ywOasGw9xldUAP7NgCPQII1QYWMYOYBhKl4rfF4qzuIJYvIQwpgOXOVaShe871rKrE5W4E7YU7f9xY=@vger.kernel.org
X-Gm-Message-State: AOJu0Yxcg7j1XaGtjJ+mVGDACRnCtM3zlHTI8BBX88Wef41mCLHIpo8H
jLzVzjq2E6GT8+IADYiZUwMxcmA3HVI1oVKWwb0VBf1UeiplvZgXtjIy5eLEKdk=
X-Gm-Gg: ASbGnct+FxzXU/a5fMMhckDymx8iLr4twEV0TFuGDI/rTK9x8A6mkjYD5BFfAccsBUX
1kKRajrV7wpTD2rFlvPZWMoRX8+x1JIYCA74vEUTSU4UqNrbDesKuiV5HChgPZTiOnQXEHOEYmX
yHoPi4FjDQmNRwTE5BOrrSopYTJSwKu+yTZH2fPFd/o3dRAuaBe56H2WMqvcqIuLUcWK9W6hXW2
gWHzlhyuhBIu5dmFE56jOm/HZVCsoUAoxE+a0ePpK6D1sft6wZm4rPn5zGWOqjNpLQ6pU7fJIfD
2BMMGymX3hlj7jiqVLGXzV5707Di+xgbQfyuMS4P5VhY52ZfmPcOnVx3MDSE84Lnm/VcukoPOcI
kNcvfaLdoM/tlci1Sv0kIa/nJGx4=
X-Google-Smtp-Source:
AGHT+IGvuuLoVK2j6sMyyQsZa8p1VCqZY8y0EZ8duJvRWZG85z91U/cgYPqYUZihq20x9iTbe4XZTg==
X-Received: by 2002:a17:907:7203:b0:ac7:19f0:aa5a with SMTP id
a640c23a62f3a-acabd2517dcmr7867666b.27.1744231064521;
Wed, 09 Apr 2025 13:37:44 -0700 (PDT)
Received: from puffmais.c.googlers.com
(40.162.204.35.bc.googleusercontent.com. [35.204.162.40])
by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.44
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 09 Apr 2025 13:37:44 -0700 (PDT)
From: =?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Date: Wed, 09 Apr 2025 21:37:50 +0100
Subject: [PATCH v4 29/32] rtc: s5m: switch to devm_device_init_wakeup
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <20250409-s2mpg10-v4-29-d66d5f39b6bf@linaro.org>
References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>, kernel-team@android.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
=?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
X-Mailer: b4 0.14.2
To release memory allocated by device_init_wakeup(true), drivers have
to call device_init_wakeup(false) in error paths and unbind.
Switch to the new devres managed version devm_device_init_wakeup() to
plug this memleak.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Andr=C3=A9 Draszik <andre.draszik@linaro.org>
---
drivers/rtc/rtc-s5m.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index 095b090ec3949e0e8074cc344105daa00b795245..f4caed953efdd23fd0132d74d51=
99dec9cdfd294 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -779,7 +779,11 @@ static int s5m_rtc_probe(struct platform_device *pdev)
return dev_err_probe(&pdev->dev, ret,
"Failed to request alarm IRQ %d\n",
info->irq);
- device_init_wakeup(&pdev->dev, true);
+
+ ret =3D devm_device_init_wakeup(&pdev->dev);
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "Failed to init wakeup\n");
}
=20
if (of_device_is_system_power_controller(pdev->dev.parent->of_node) &&
--=20
2.49.0.604.gff1f9ca942-goog