From nobody Fri May 2 00:14:33 2025
Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com
[209.85.208.42])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id B669321B18C
for <linux-kernel@vger.kernel.org>; Wed, 9 Apr 2025 20:37:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.208.42
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1744231075; cv=none;
b=iDv6shS5OFZd/y8WMDKF6rf9dROqbU64TTKfgIqWXkkUt6RRtcwm1aJPGgOS3mRJ7gBL5IVviI7Jz/YEBN2EKCWK+xCl/72jZwDah8De1E9igDu3ufQE8u3gZmDJ4183AEh8Avl6LGWlFh7EnbvpesXJdBf4+5rYJhvcL8DAlhc=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1744231075; c=relaxed/simple;
bh=6MAg2XALis+Rtua2lDVBlN4I/q6DE1qmn9E7X0+PP3U=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
In-Reply-To:To:Cc;
b=iffRP+ysrRsEtQDkqUELqv6/k/dGbhtDvGv2NniKvBdSYpI6cI0ojjMVCxkRSWu6ttlGMREtOT09kAydMkKhhSFZhvYV5gOBw/cPwq5J1bSEw93D8zkVHo8KwIhx+k8MzEkNsEeN9wSP6fFaRaDJsI130EmpgZ8wssKDRnZLes4=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=chJUj7jt; arc=none smtp.client-ip=209.85.208.42
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="chJUj7jt"
Received: by mail-ed1-f42.google.com with SMTP id
4fb4d7f45d1cf-5e6f4b3ebe5so222421a12.0
for <linux-kernel@vger.kernel.org>;
Wed, 09 Apr 2025 13:37:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1744231063; x=1744835863;
darn=vger.kernel.org;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=Tv6T8/JtNiPh/U9srmK1zriSPC7xSek3blAJnMyaQM0=;
b=chJUj7jt/pif+O5xRFfOatyWKBZw/6diXVoYp0SXWS1x331yT9skOKjatRp4SdNUSp
cJKmKB7bzAN+2Wze7f8f696SZ29+W0g9Jcv9xLo/hf3DNunDmyQruInM5o4zFpQuQB2j
mNslGTWvdTbX3tuZTdAJLY85aeovWqypgJuxq6ss+3W7saEcSa17bskOL7SZcrFf/e8G
2YW05s/0c2xLkLVeI9kasQ14JV5u5sxAhEHuxvx6ozXV6/MtsvkZsOGij+NLoJUNqBMZ
o7fHpVbcv6uBOPL7FYjUmimL9oIP8BNBwyHWQ6p/HwaNDXr44C3ILG3MwgzxKTc7Qt7B
E5og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744231063; x=1744835863;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Tv6T8/JtNiPh/U9srmK1zriSPC7xSek3blAJnMyaQM0=;
b=Sc2V5J2BRyfulB5jxGftnKL9fIjB5EhUo7PmH6hNnaXDsmxlxmMNQK7BN2ozgmPQue
jEEwOAqZEe6qZhEYvDaZuwRqPrwQU9GT6KdMQQbaa7HA1NcHKw4EpU1GyOG9j3ABsEKp
Z5njABoeWtz6W9TVMNdWJDxfGaq3BaHP56pPGj0iEyYc112n7lc27inknVziI12QVaDt
zCmB1j3ImH4xOC2AUSfQRK6ek6jNOFnT51XDw8lz18t4gtA3W/1se6BjB2llXOFoxnys
J958RdHHz4T8zJQyCZZVcZt7XanbHTottDlLUz9+4e4IxCQHUZQlDoChPrj5tw1FZXA4
H41g==
X-Forwarded-Encrypted: i=1;
AJvYcCU462HINKQzxKRqvJq08T2It5P2UicD700bF9RFTS67RK0g6BBmxRAI1RVThcfJzkFTnLZNlMgTWGWbukY=@vger.kernel.org
X-Gm-Message-State: AOJu0YxSIcVOva4m7NC35QH8qBxK8jEsqF6rPzHgUTxrwZrAAZSvX2WJ
50TfClMCCbt3Un3fkjLZ6u1fa+NqJPAGNpczwReSaef/vq3B95i7HTj6vx++C84=
X-Gm-Gg: ASbGncswEnFzfxGQ8m1CU9bHbCT1Qh9JYzPOtnVWuLbvOKHOYcMLIzLyrN2wWvCJ8Up
v2jn27TodxJPDFcziRTUNW8traNCS284r0N+XfLnMHnlMtL6VVZ2rMIYPn67L9fytKkquqd0ib7
PXo44V/oa15/HQV+o4aZnd+8lKcNdOWpxXEPL5/WXSGiN/YUQSzVhvXhqwmh7BxfwNd9t4UOMbJ
0wpiT6gOvaAVmRmEH+me1hi7A22xR0WapGeA3h+a4Pkxlf3NSiqRQcYdm9Y07od50ZyIsQrLngP
CW61NHkuqAPKrN05anKUkMtFN4g4YTPqKtgyWrzBsbpuVkct4ZTTNkhezkqGwm5kkY3IxLd60mQ
AsOqxKDK9Kus+P9Ve/4wQZQvXpyGeTpPxKmZJgg==
X-Google-Smtp-Source:
AGHT+IHuFxbIJJjU+odGQEb+Z2z7HvoeRr2IGwkfZgpVlPcf92trUW7rJVrEbL1uMQYZ7TzU/wGXvA==
X-Received: by 2002:a17:907:608d:b0:ac3:8895:2776 with SMTP id
a640c23a62f3a-acabd12c4b4mr7347566b.5.1744231063463;
Wed, 09 Apr 2025 13:37:43 -0700 (PDT)
Received: from puffmais.c.googlers.com
(40.162.204.35.bc.googleusercontent.com. [35.204.162.40])
by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.43
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 09 Apr 2025 13:37:43 -0700 (PDT)
From: =?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Date: Wed, 09 Apr 2025 21:37:48 +0100
Subject: [PATCH v4 27/32] rtc: s5m: add support for S2MPG10 RTC
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <20250409-s2mpg10-v4-27-d66d5f39b6bf@linaro.org>
References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>, kernel-team@android.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
=?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
X-Mailer: b4 0.14.2
Add support for Samsung's S2MPG10 PMIC RTC, which is similar to the
existing PMIC RTCs supported by this driver.
S2MPG10 doesn't use I2C, so we expect the core driver to have created a
regmap for us.
Additionally, it can be used for doing a cold-reset. If requested to do
so (via DT), S2MPG10 is programmed with a watchdog configuration that
will perform a full power cycle upon watchdog expiry.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Andr=C3=A9 Draszik <andre.draszik@linaro.org>
---
v4:
- keep headers as alphabetical as possible (Krzysztof)
---
drivers/rtc/rtc-s5m.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++=
++++
1 file changed, 60 insertions(+)
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index f8abcdee8611d1181fb575aeb8d094360538ca7e..c6394faaee860427e8b84e9c6df=
2d8229cf06d93 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -10,6 +10,7 @@
#include <linux/module.h>
#include <linux/i2c.h>
#include <linux/bcd.h>
+#include <linux/reboot.h>
#include <linux/regmap.h>
#include <linux/rtc.h>
#include <linux/platform_device.h>
@@ -53,6 +54,7 @@ enum {
* Device | Write time | Read time | Write alarm
* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
* S5M8767 | UDR + TIME | | UDR
+ * S2MPG10 | WUDR | RUDR | AUDR
* S2MPS11/14 | WUDR | RUDR | WUDR + RUDR
* S2MPS13 | WUDR | RUDR | WUDR + AUDR
* S2MPS15 | WUDR | RUDR | AUDR
@@ -99,6 +101,20 @@ static const struct s5m_rtc_reg_config s5m_rtc_regs =3D=
{
.write_alarm_udr_mask =3D S5M_RTC_UDR_MASK,
};
=20
+/* Register map for S2MPG10 */
+static const struct s5m_rtc_reg_config s2mpg10_rtc_regs =3D {
+ .regs_count =3D 7,
+ .time =3D S2MPG10_RTC_SEC,
+ .ctrl =3D S2MPG10_RTC_CTRL,
+ .alarm0 =3D S2MPG10_RTC_A0SEC,
+ .alarm1 =3D S2MPG10_RTC_A1SEC,
+ .udr_update =3D S2MPG10_RTC_UPDATE,
+ .autoclear_udr_mask =3D S2MPS15_RTC_WUDR_MASK | S2MPS15_RTC_AUDR_MASK,
+ .read_time_udr_mask =3D S2MPS_RTC_RUDR_MASK,
+ .write_time_udr_mask =3D S2MPS15_RTC_WUDR_MASK,
+ .write_alarm_udr_mask =3D S2MPS15_RTC_AUDR_MASK,
+};
+
/* Register map for S2MPS13 */
static const struct s5m_rtc_reg_config s2mps13_rtc_regs =3D {
.regs_count =3D 7,
@@ -238,6 +254,7 @@ static int s5m_check_peding_alarm_interrupt(struct s5m_=
rtc_info *info,
ret =3D regmap_read(info->regmap, S5M_RTC_STATUS, &val);
val &=3D S5M_ALARM0_STATUS;
break;
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -300,6 +317,7 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_inf=
o *info)
case S5M8767X:
data &=3D ~S5M_RTC_TIME_EN_MASK;
break;
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -351,6 +369,7 @@ static int s5m_rtc_read_time(struct device *dev, struct=
rtc_time *tm)
=20
switch (info->device_type) {
case S5M8767X:
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -374,6 +393,7 @@ static int s5m_rtc_set_time(struct device *dev, struct =
rtc_time *tm)
=20
switch (info->device_type) {
case S5M8767X:
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -411,6 +431,7 @@ static int s5m_rtc_read_alarm(struct device *dev, struc=
t rtc_wkalrm *alrm)
=20
switch (info->device_type) {
case S5M8767X:
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -449,6 +470,7 @@ static int s5m_rtc_stop_alarm(struct s5m_rtc_info *info)
=20
switch (info->device_type) {
case S5M8767X:
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -487,6 +509,7 @@ static int s5m_rtc_start_alarm(struct s5m_rtc_info *inf=
o)
=20
switch (info->device_type) {
case S5M8767X:
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -524,6 +547,7 @@ static int s5m_rtc_set_alarm(struct device *dev, struct=
rtc_wkalrm *alrm)
=20
switch (info->device_type) {
case S5M8767X:
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -604,6 +628,7 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *in=
fo)
ret =3D regmap_raw_write(info->regmap, S5M_ALARM0_CONF, data, 2);
break;
=20
+ case S2MPG10:
case S2MPS15X:
case S2MPS14X:
case S2MPS13X:
@@ -634,6 +659,25 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *i=
nfo)
return ret;
}
=20
+static int s5m_rtc_restart_s2mpg10(struct sys_off_data *data)
+{
+ struct s5m_rtc_info *info =3D data->cb_data;
+ int ret;
+
+ if (data->mode !=3D REBOOT_COLD && data->mode !=3D REBOOT_HARD)
+ return NOTIFY_DONE;
+
+ /*
+ * Arm watchdog with maximum timeout (2 seconds), and perform full reset
+ * on expiry.
+ */
+ ret =3D regmap_set_bits(info->regmap, S2MPG10_RTC_WTSR,
+ (S2MPG10_WTSR_COLDTIMER | S2MPG10_WTSR_COLDRST
+ | S2MPG10_WTSR_WTSRT | S2MPG10_WTSR_WTSR_EN));
+
+ return ret ? NOTIFY_BAD : NOTIFY_DONE;
+}
+
static int s5m_rtc_probe(struct platform_device *pdev)
{
struct sec_pmic_dev *s5m87xx =3D dev_get_drvdata(pdev->dev.parent);
@@ -689,6 +733,9 @@ static int s5m_rtc_probe(struct platform_device *pdev)
if (IS_ERR(info->regmap))
return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap),
"Failed to allocate regmap\n");
+ } else if (device_type =3D=3D S2MPG10) {
+ info->regs =3D &s2mpg10_rtc_regs;
+ alarm_irq =3D S2MPG10_IRQ_RTCA0;
} else {
return dev_err_probe(&pdev->dev, -ENODEV,
"Unsupported device type %d\n",
@@ -735,6 +782,18 @@ static int s5m_rtc_probe(struct platform_device *pdev)
device_init_wakeup(&pdev->dev, true);
}
=20
+ if (of_device_is_system_power_controller(pdev->dev.parent->of_node) &&
+ info->device_type =3D=3D S2MPG10) {
+ ret =3D devm_register_sys_off_handler(&pdev->dev,
+ SYS_OFF_MODE_RESTART,
+ SYS_OFF_PRIO_HIGH + 1,
+ s5m_rtc_restart_s2mpg10,
+ info);
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret,
+ "Failed to register restart handler\n");
+ }
+
return devm_rtc_register_device(info->rtc_dev);
}
=20
@@ -766,6 +825,7 @@ static SIMPLE_DEV_PM_OPS(s5m_rtc_pm_ops, s5m_rtc_suspen=
d, s5m_rtc_resume);
=20
static const struct platform_device_id s5m_rtc_id[] =3D {
{ "s5m-rtc", S5M8767X },
+ { "s2mpg10-rtc", S2MPG10 },
{ "s2mps13-rtc", S2MPS13X },
{ "s2mps14-rtc", S2MPS14X },
{ "s2mps15-rtc", S2MPS15X },
--=20
2.49.0.604.gff1f9ca942-goog