From nobody Sat May 3 08:32:11 2025
Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com
[209.85.208.51])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8031A21A94F
for <linux-kernel@vger.kernel.org>; Wed, 9 Apr 2025 20:37:45 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.208.51
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1744231071; cv=none;
b=JYKVBKxUCCM0k9GrpOMKDCJZafM4Ujq+m0RYd0xr12uKEMMiattKKjWvxsCsrqDyaXzNoOOCp399KyeaslkuJ1yWn5aX85vVKOFMFu323BXj4sYB9ZHwZ8T+Hd7Ai29E5iC4E49TeY0LKPSf0L3TiiQvphZjydhQbh2YJox4vz4=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1744231071; c=relaxed/simple;
bh=qSv5/qRfekv1BXqCAyoLS9fhjEPlxat67lwDh+L/ZJw=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
In-Reply-To:To:Cc;
b=PwKT5NzBoyjR02M6NJ6aAs58A3vc9fVYQUP93bR2ZtMb+3OSyZ+HbYY33MCugEXtdcQ4N+bvfm7M5IylxZMMVCTBVMKKhh050zVOKx9tDUXKde88Kmie7iIeOOimb15pZK2dmUt9XWexucWtXqIR6Kl8kYK1VGLOUpFn9uJ2nRo=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=fgT8kvhz; arc=none smtp.client-ip=209.85.208.51
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="fgT8kvhz"
Received: by mail-ed1-f51.google.com with SMTP id
4fb4d7f45d1cf-5ed1ac116e3so157930a12.3
for <linux-kernel@vger.kernel.org>;
Wed, 09 Apr 2025 13:37:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1744231062; x=1744835862;
darn=vger.kernel.org;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=Yvl4l0Ok5PkRG0EWi21Y82ldA8DtM3z/BsTax0kidDk=;
b=fgT8kvhztDK9j2B9NsFMoMoAPRlJ2/YjAyQuCPArIwJ2Nt87a9nP6Sgn+V/2kAIuts
GWy/ZrxjXDgTeW6Qb0JZK0zvvwhbXpCV/vdZZSs1N6bFRIJoeVkGIy8SJ2uuQ7v4cBmv
I4zXU6W4VJFK1mRaTPqXllhJ6zE+gFaRo62S7u7EeudWjinb8zfBnMJkaWqM/5SMFf6t
sIJIQO6ihhYbT2yIOlCdnBJO7hfjcmG5skj9Vhn5LruF8yMMm9odJpb5po+5QWNRmeti
rX5iwXDJegPHB6rYdcSCU74JzIKlb6eaMXJui5IVDwP61o2VrxOkF05vTTSrMF2VPu/V
ofAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1744231062; x=1744835862;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Yvl4l0Ok5PkRG0EWi21Y82ldA8DtM3z/BsTax0kidDk=;
b=ohxNiDdhOve1apgDJcjxaw9W2bOFXCwxHwW1ghjG+o4e3HCzfuFnm6S+aKP6uhMT6F
gHe+Gsoxbq8LitGq7Fu5dRVYp2Nk0ijGTjQIRAGGvW+LvKAQuP9vh6Ltz9eJtDDzNLUw
DiyN9BsyxCogp9RY9mOYwVhyUJCcrSPXp1QDxfoEsyY+SjxayDWuK7X+zCbwGO5xRLCc
SmRU2woyxQTLYjUGbHcLG7/49nKig/Xew1PxL28OGhlXRRLBRz2DurUhE31Li3lVdQB0
auaXyvGF79m6ihznnC+Eyc4l6wcsV2CGGjB2dmY58ETa9KyMmfuxyN1WvUJtCD9utwfC
wpxQ==
X-Forwarded-Encrypted: i=1;
AJvYcCXuzyIkN6/IaA1mDkS0FY9QNBEMMqP72TuFpqGSF46GhBhkxNZfouwgVa+y+arqtzsHRcG+uUvL2/95zCk=@vger.kernel.org
X-Gm-Message-State: AOJu0YyAMLrm+R5P1Rmv8wd9UVLBW2qQtwgQnzfrlXd20xkfKOdftJ7h
RaS+tARI5/yWnZNsLlVaOdZo8gjzs7/LXRGt1+4rh+gnEdqdK56E2oGQ+FyGSGo=
X-Gm-Gg: ASbGncv/sQ8xn3g1XOhXehEXGtYnALtzJDtwTtCZ9fVJZyhHd6e94VlHY9RdCRMxJ/e
zOWxSTmdWTadWc8PxiEhtVIDO+GuIOce1iejxa/UOe76/fURuiD0G49nRMBPCl5HibFGtgzlZDB
aygXo5IMsrICjUbA9zz+f+Ihs0cppSe7PyfZC2/50S+8r5hMecdBrQVVtwn3Rnp6w1rWMz4p4SL
O8kJZuszQ5IWZVACayAcn2d8aF9Byz7JyVqYeOaIGNRlpdxd/44tozVdylTXeswnM0MzwJKKBB1
IcouyzZ3L5C26eWohdHF6LG/qpUh+/1TH2l8UN9VHtdGk52He4OKwqRxO9wyGzw+vqeQV9vDXVi
lWWajo8SU4dM/gorunULSeWOyOu0=
X-Google-Smtp-Source:
AGHT+IHbuLfVklw/YEV595LIDXkT6NJfGZ8tsFxVvFej7hgAnnMJK0l8IFDXzmywh/fHAbSmWr9RuQ==
X-Received: by 2002:a17:906:dc89:b0:aaf:103a:e6e3 with SMTP id
a640c23a62f3a-acabd3c36a7mr7622566b.43.1744231062434;
Wed, 09 Apr 2025 13:37:42 -0700 (PDT)
Received: from puffmais.c.googlers.com
(40.162.204.35.bc.googleusercontent.com. [35.204.162.40])
by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.42
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 09 Apr 2025 13:37:42 -0700 (PDT)
From: =?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Date: Wed, 09 Apr 2025 21:37:46 +0100
Subject: [PATCH v4 25/32] rtc: s5m: cache device type during probe
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <20250409-s2mpg10-v4-25-d66d5f39b6bf@linaro.org>
References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>, kernel-team@android.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
=?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
X-Mailer: b4 0.14.2
platform_get_device_id() is called mulitple times during probe to
retrieve the device type. This makes the code harder to read than
necessary.
Just get the type once, which also trims the lengths of the lines
involved.
Signed-off-by: Andr=C3=A9 Draszik <andre.draszik@linaro.org>
---
v4:
- cache the driver data, i.e. the enum type (Krzysztof)
---
drivers/rtc/rtc-s5m.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index db5c9b641277213aa1371776c63e2eda3f223465..c7636738b797b8087a0ed6844df=
62d47427e33b8 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -637,6 +637,8 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *in=
fo)
static int s5m_rtc_probe(struct platform_device *pdev)
{
struct sec_pmic_dev *s5m87xx =3D dev_get_drvdata(pdev->dev.parent);
+ enum sec_device_type device_type =3D
+ platform_get_device_id(pdev)->driver_data;
struct s5m_rtc_info *info;
struct i2c_client *i2c;
const struct regmap_config *regmap_cfg;
@@ -646,7 +648,7 @@ static int s5m_rtc_probe(struct platform_device *pdev)
if (!info)
return -ENOMEM;
=20
- switch (platform_get_device_id(pdev)->driver_data) {
+ switch (device_type) {
case S2MPS15X:
regmap_cfg =3D &s2mps14_rtc_regmap_config;
info->regs =3D &s2mps15_rtc_regs;
@@ -669,8 +671,8 @@ static int s5m_rtc_probe(struct platform_device *pdev)
break;
default:
return dev_err_probe(&pdev->dev, -ENODEV,
- "Device type %lu is not supported by RTC driver\n",
- platform_get_device_id(pdev)->driver_data);
+ "Device type %d is not supported by RTC driver\n",
+ device_type);
}
=20
i2c =3D devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter,
@@ -686,7 +688,7 @@ static int s5m_rtc_probe(struct platform_device *pdev)
=20
info->dev =3D &pdev->dev;
info->s5m87xx =3D s5m87xx;
- info->device_type =3D platform_get_device_id(pdev)->driver_data;
+ info->device_type =3D device_type;
=20
if (s5m87xx->irq_data) {
info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq);
--=20
2.49.0.604.gff1f9ca942-goog