From nobody Mon Feb 9 00:26:26 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDB2E1DF749 for ; Wed, 9 Apr 2025 09:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744190303; cv=none; b=u5b9ixmqgcHUqO2toX6BqNd7HiSfisq1Rv3We1ANdzJoc0PVgPzG2qLeZiFrX7ui16adJe9HgA4IAem3Vndpvc6UFO49UgwxkO0aU9XdMjqPnhU1LEE43yA9jNr2mzfKADGGiHZhMfxCWIxohzMHCgOGe3mWY8+tNx+5Rz7lmII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744190303; c=relaxed/simple; bh=VGmVlLv/g0NSChA5cTCx5HI2+YgjvT8aXwQeEVYqWkw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lXmufX9g0SREfiVlZ+QZxEvDoqhKl1EIVGe1Xtj107VA9eH1Bu8QM0je/OpdSI047kXQzo8XEoMDFz8RSv77Reg6drt+sqgCNMbDYJizSN4cA1cUGVaPpXsrS7Gt8fpEtHQwz2jE1lrLxfe6q3H7QVbrxedJs8jQCunJTmGehKw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=yFcxRibb; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="yFcxRibb" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-39d83782ef6so292749f8f.0 for ; Wed, 09 Apr 2025 02:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744190300; x=1744795100; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uNsJvlRDFjThPSOtGOteiq+PCHwiQFN7KKK0wuA2YaI=; b=yFcxRibbiRPLTEKr8P7PzYqJSta1PzmE/3EvV9ZUgMQNN55yg9RyIDzfekoyR8jiNh E4ePOnN7eKcw0GoC/yLyioGTzKLa29DsZeFarpYCRt1bJdLG929RQA7Av8VOpV/Q04/A mmvWPBE0iWgTRIjdNgLGhZ26S784FGqaZVCoZdyjInqF1KXhl7qGKhJLCKILy/Ae+Fh4 c94gFfvpwcKGyo1XaSE0azu0PzxU3Qmu4hYjntjhdpkLIsrmq06hC9/yNKsGBsgd4fpd cilVfRWZF7WTlwr4g4LV11gbg6fTfyxodXFNufgsIj2jIvEP4SZA+YbUcrEaQyykc8dC tLAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744190300; x=1744795100; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uNsJvlRDFjThPSOtGOteiq+PCHwiQFN7KKK0wuA2YaI=; b=Wqwkkajoo+U+4tR94vvNVZZwH7HbW48f8ITbvwVO+L14xd0JJg12nrStTukXbIDP2l /8Mc5cSzTdY/E8J/nk6AJCq9tYcZ/eIGLAyffBgogZZpft4c7qDaSgFoYqNOuQoyDs+9 nrMugryH+Sa9I9OGlaJ0sa9Qj3T0hhPrlkppqg26TMQl4Fdv9UZLFKE3YtASv+O2OLEB otZzehPYwOqqKrbmIA+rCStnbS00YQArrxRiPTPc4bum+fNqy/kjYgGPggiLo6dIc+pc nNhkfD29bp8NfSIxI9XMF3VtveIE3aZEwwgMrzYnZm83GQMG2c+lZbYHvBEmhj63sADa iPEg== X-Forwarded-Encrypted: i=1; AJvYcCX/qaa6oSTG5Rt0iTlIrC4HDWy+NcxpqFMUGfbnv3Ld2IPXJYF9lYfwXIcPhMBR0e1Gzr2jufd2XsneVhc=@vger.kernel.org X-Gm-Message-State: AOJu0YwWc4mlMdREuWzIp8RVRptwVDVQ4fNUgzd7/MEO1SWxR0ITeNXc 8/U5xbehSkU4YYipylEY4JmghqBt0/bHUAvI3mwefwC5XXzGIszroc+UEQT71YFDU/x9F75c7F2 Z X-Gm-Gg: ASbGnctTH5vvZpTTg76hdxbzLpAjmbAG1/18RLDEdjfRN4udllcUrydqmu2EM2LqGsa rhYHVt+nrSI8s6BOP7two54NnEEiAj5W8VuEVKzxopHjITBEn0bZGinfqVjiOP6v152AgL1ie8b 32SZaEfdgIT3d76i8CxlyS91tVtxDNuyUux9eNYSLUFfA8kTQrySU8jwkMPdZUneUqmtFeSpEVI bLoIN7syw57rsbs/CmKMjDeRUo9NwIgrr22Gt3qTHSTvodKCaQsD0YKbdpzTrbXlNXhPY14tFW6 qGT6Rv8Ev5MkVSzqYkA1o0DCy6fN1Yp6zbFDCKOPGOzDnM04SCY9DQfw49S1azYzOnSeNRuwNX4 wWL6ii4KAUtoHwKZDWA== X-Google-Smtp-Source: AGHT+IFT9E4x39vToBiKUhyXzFBNHuX1M+gngkWvQuAa7nVGL2fuwhZZLclr4C7DEzRMZaVvnYJ7CA== X-Received: by 2002:a5d:5f93:0:b0:38d:e0a9:7e5e with SMTP id ffacd0b85a97d-39d820a3dc6mr4896719f8f.6.1744190299971; Wed, 09 Apr 2025 02:18:19 -0700 (PDT) Received: from [192.168.0.2] (host-87-15-70-119.retail.telecomitalia.it. [87.15.70.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938b7afsm1069482f8f.58.2025.04.09.02.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 02:18:19 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 09 Apr 2025 11:16:54 +0200 Subject: [PATCH v2 1/2] iio: dac: adi-axi-dac: fix bus read Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250409-ad3552r-fix-bus-read-v2-1-34d3b21e8ca0@baylibre.com> References: <20250409-ad3552r-fix-bus-read-v2-0-34d3b21e8ca0@baylibre.com> In-Reply-To: <20250409-ad3552r-fix-bus-read-v2-0-34d3b21e8ca0@baylibre.com> To: Nuno Sa , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1333; i=adureghello@baylibre.com; h=from:subject:message-id; bh=9pHPKsKzptvjYiQOA8UzTeuM77FIRRsobVc0fiDL1Ac=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYkj/Zs13fbkTy0wpduvtApn7d1hVtBbc/ivRrvDYkGF6y cR+qaU7O0pZGMS4GGTFFFnqEiNMQm+HSikvYJwNM4eVCWQIAxenAExknxbD/xAO1WMX3uZO9Da8 08VTts92WebTEwul8oTa5724+2ZhWirDPwtvq6+bT9hWZ9pbXcxe03hY2f3bOTvFxftqDAXca2Y 94QQA X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Fix bus read function. Testing the driver, on a random basis, wrong reads was detected, mainly by a wrong DAC chip ID read at first boot. Before reading the expected value from the AXI regmap, need always to wait for busy flag to be cleared. Fixes: e61d7178429a ("iio: dac: adi-axi-dac: extend features") Signed-off-by: Angelo Dureghello Reviewed-by: Nuno S=C3=A1 --- drivers/iio/dac/adi-axi-dac.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c index 8ed5ad1fa24cef649056bc5f4ca80abbf28b9323..5ee077c58d7f9730aec8a9c9dff= 5b84108b3a47e 100644 --- a/drivers/iio/dac/adi-axi-dac.c +++ b/drivers/iio/dac/adi-axi-dac.c @@ -760,6 +760,7 @@ static int axi_dac_bus_reg_read(struct iio_backend *bac= k, u32 reg, u32 *val, { struct axi_dac_state *st =3D iio_backend_get_priv(back); int ret; + u32 ival; =20 guard(mutex)(&st->lock); =20 @@ -772,6 +773,13 @@ static int axi_dac_bus_reg_read(struct iio_backend *ba= ck, u32 reg, u32 *val, if (ret) return ret; =20 + ret =3D regmap_read_poll_timeout(st->regmap, + AXI_DAC_UI_STATUS_REG, ival, + FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, ival) =3D=3D 0, + 10, 100 * KILO); + if (ret) + return ret; + return regmap_read(st->regmap, AXI_DAC_CUSTOM_RD_REG, val); } =20 --=20 2.49.0 From nobody Mon Feb 9 00:26:26 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47D5F25C706 for ; Wed, 9 Apr 2025 09:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744190305; cv=none; b=E4OCO/eoj/T+KDbLqh6UMx3914NzeSfUBbcTPXPAMxVMtLncUCrNZwbkavsMuWMwFExtuz2f6b0l/4tOKhmmiYSDcedkqALj+4oY/cRf6N9jSCb4Co0LhMMIVx4dBKU2wpGTKzSklaxxS8Lw7KI8KnZXR1AYpb70FzjCUmOPc+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744190305; c=relaxed/simple; bh=NG1MiZ8QoHdfM4LL/T1Mwz1rfI46rSp8UGN1xISLuOo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YY5SVI/OkM6dyfgsU1RDXpQgh4PWyyPgC98TlNPzYPINS+jSVPotZ6/ut46Xa9Y6d6+YsSPMX4J0bKv6HTKd03A5IDmdVUCI/EMvnN0xd/qo7T8XsOegqqZXBwZkMWO0+swcCGsylb24P6sQzvqsx0tt3mGrtpd60huA+Y90zck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Vq4FT1kf; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Vq4FT1kf" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so58813815e9.0 for ; Wed, 09 Apr 2025 02:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744190301; x=1744795101; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZlPB95+nNbpSrQR/17f9mkYUcS57VR6pMZGMLuAt+fI=; b=Vq4FT1kfawyd2KPpYUCemNyhSXrXtS6aatHNhGayNURjQX5Xw3wk25wDHFgrpV/dh1 2aioFYqitvQgjGg4T0b/mKF1w/tEj9DK9QrmijrP0fw8AeeCFaulpMNM3YvyQ212l5tZ OXpuAAufGd0xyAOSvuNzNHb/DVHc9Ga5/z4WcwxMYMkXNz13Rdf7wF29tyZ1d+Gw5OD2 l7Rk5Bdv4AvLqJjKsAkHOEMxCLgacKdiXMDxT2qp6MYSJBMPcE3aHYYYvUJo+fx5awWJ JGNhefATYyIDD26C1OGSUz63XfchqQzUelWf4P84nmAzs4cBxP4C5ZuAIo9Edi4T/HTm tXGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744190301; x=1744795101; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZlPB95+nNbpSrQR/17f9mkYUcS57VR6pMZGMLuAt+fI=; b=ZBCfkiAVM6EWwHEqClPuxOrC3KC7KFpuOBsUSziCm7KJMZcPT50wOPQdKA7ecPTgG2 Muq/5o86LcySqayMZFs79XdeKSMNDWrikZfeBAADHH3HZedrlpGuBIc2imAMgdlsoUNU WVmsjbs/ThztR+Uz3iWSxsrdO5Jq7x8JxC17UekCZuaOiKoaXdkKeMrzB5ap38dHvypQ VZ+A+LduUoZGCb1QH+Jt8kMo7B6l0e7NGxs+UC4GJqqDmlS6kmqIgmNB0y68Md91sJXA Sc3J0RN+Wo0mjl2taQnkIwIXV2xtEj9phJaeMchl/9YPt010hhe+ZXEYSIuhzQvSmmto VUQA== X-Forwarded-Encrypted: i=1; AJvYcCWunwBsoEadGZEVMcWSe7UKIlxBsRaTiUe80UfqkqLnt8FQNMEp9PXv6gQyLjCmIYL+Wl+hufvyS2hh9fE=@vger.kernel.org X-Gm-Message-State: AOJu0YxFLuCfqc6vXqJAuR6UcImncD4x/vWMkVaSdWe1GN+lGUqd33rM HKTrHaxK8SraJ+D65xMfSQz/Hk6BCYTNwWPgMVm46sNrlIEzMO7CIZd2QZUxw1ZXnz8mj9RTWiZ O X-Gm-Gg: ASbGncvpS4BkDc7lJKWKC/Arx714elU9/k0iP8HSbNt8lfE5BIeyVVS9MQZn6H9lp+o qE4wxewehuB2afCjlgjcpegz84Fn3cFwLdzJzAh/2y5BNATd5yBDGV3qfcbqTDHc+2M8/1PNAwW X3LvHeywCnjIFTxaZcmedoAPbKYRMZJNfDL18w5nTMhXp8qvAt0EttXGdm0f4svUP3L58jhQh4l wusNpVZBQHSwu5FV/HHPtiDcfv0XRvZkM9QRsxCHx7bD1vJ069Z/ZosVOIyjv5xHEs5SexBXp4t KlBt55/0O81TRWGgbAed2HTpEh74irjhuJxzB5Yt0/UTvIv9K6ZtcQjWt82x+e6eID4s+Vn64Hh 09uRMLvxnmh9/z8bRwA== X-Google-Smtp-Source: AGHT+IHBgHm7S+F2IYQk1anaMogHD/QOIQQpmEO8FEr2SU2kU7dz99RQQgB2BRWWmRKjCZv3j9FE0w== X-Received: by 2002:a05:600c:46cc:b0:43d:94:cff0 with SMTP id 5b1f17b1804b1-43f1fe842c1mr14689485e9.19.1744190301444; Wed, 09 Apr 2025 02:18:21 -0700 (PDT) Received: from [192.168.0.2] (host-87-15-70-119.retail.telecomitalia.it. [87.15.70.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938b7afsm1069482f8f.58.2025.04.09.02.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 02:18:20 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 09 Apr 2025 11:16:55 +0200 Subject: [PATCH v2 2/2] iio: dac: adi-axi-dac: use unique bus free check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250409-ad3552r-fix-bus-read-v2-2-34d3b21e8ca0@baylibre.com> References: <20250409-ad3552r-fix-bus-read-v2-0-34d3b21e8ca0@baylibre.com> In-Reply-To: <20250409-ad3552r-fix-bus-read-v2-0-34d3b21e8ca0@baylibre.com> To: Nuno Sa , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3184; i=adureghello@baylibre.com; h=from:subject:message-id; bh=snSdIkD56Gw2eWhp5aB0J9MJe2j1bu6zf+pLUOWWZYw=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYkj/Zs13zvdtw5l//AdzJ/vJNXEkTFryfmJIJ7tRZmvEs Ztm1r+WdpSyMIhxMciKKbLUJUaYhN4OlVJewDgbZg4rE8gQBi5OAZhIaDHDX8FQ9hma+14+EAiz 67vjtHS+wGXt3u0Tr+n9ELbpOjmpX4/hn1FP0S7d1AlN90P/zX48r9iK3bL23v4FomUz+y77Lv9 awgAA X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Use a unique function for the bus free check by polling, to reduce duplicated code. An error is always thrown in case of timeout. Signed-off-by: Angelo Dureghello Reviewed-by: Nuno S=C3=A1 --- drivers/iio/dac/adi-axi-dac.c | 42 ++++++++++++++++++++++-----------------= --- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c index 5ee077c58d7f9730aec8a9c9dff5b84108b3a47e..c90068693e9989a49e4c035eecb= 69606bdcbb196 100644 --- a/drivers/iio/dac/adi-axi-dac.c +++ b/drivers/iio/dac/adi-axi-dac.c @@ -635,15 +635,26 @@ static int axi_dac_ddr_disable(struct iio_backend *ba= ck) AXI_DAC_CNTRL_2_SDR_DDR_N); } =20 +static int axi_dac_wait_bus_free(struct axi_dac_state *st) +{ + u32 val; + int ret; + + ret =3D regmap_read_poll_timeout(st->regmap, AXI_DAC_UI_STATUS_REG, val, + FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) =3D=3D -1, 10, + 100 * KILO); + if (ret =3D=3D -ETIMEDOUT) + dev_err(st->dev, "AXI bus timeout\n"); + + return ret; +} + static int axi_dac_data_stream_enable(struct iio_backend *back) { struct axi_dac_state *st =3D iio_backend_get_priv(back); - int ret, val; + int ret; =20 - ret =3D regmap_read_poll_timeout(st->regmap, - AXI_DAC_UI_STATUS_REG, val, - FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) =3D=3D 0, - 10, 100 * KILO); + ret =3D axi_dac_wait_bus_free(st); if (ret) return ret; =20 @@ -734,12 +745,9 @@ static int __axi_dac_bus_reg_write(struct iio_backend = *back, u32 reg, if (ret) return ret; =20 - ret =3D regmap_read_poll_timeout(st->regmap, - AXI_DAC_UI_STATUS_REG, ival, - FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, ival) =3D=3D 0, - 10, 100 * KILO); - if (ret =3D=3D -ETIMEDOUT) - dev_err(st->dev, "AXI read timeout\n"); + ret =3D axi_dac_wait_bus_free(st); + if (ret) + return ret; =20 /* Cleaning always AXI_DAC_CUSTOM_CTRL_TRANSFER_DATA */ return regmap_clear_bits(st->regmap, AXI_DAC_CUSTOM_CTRL_REG, @@ -760,7 +768,6 @@ static int axi_dac_bus_reg_read(struct iio_backend *bac= k, u32 reg, u32 *val, { struct axi_dac_state *st =3D iio_backend_get_priv(back); int ret; - u32 ival; =20 guard(mutex)(&st->lock); =20 @@ -773,10 +780,7 @@ static int axi_dac_bus_reg_read(struct iio_backend *ba= ck, u32 reg, u32 *val, if (ret) return ret; =20 - ret =3D regmap_read_poll_timeout(st->regmap, - AXI_DAC_UI_STATUS_REG, ival, - FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, ival) =3D=3D 0, - 10, 100 * KILO); + ret =3D axi_dac_wait_bus_free(st); if (ret) return ret; =20 @@ -787,7 +791,7 @@ static int axi_dac_bus_set_io_mode(struct iio_backend *= back, enum ad3552r_io_mode mode) { struct axi_dac_state *st =3D iio_backend_get_priv(back); - int ival, ret; + int ret; =20 if (mode > AD3552R_IO_MODE_QSPI) return -EINVAL; @@ -800,9 +804,7 @@ static int axi_dac_bus_set_io_mode(struct iio_backend *= back, if (ret) return ret; =20 - return regmap_read_poll_timeout(st->regmap, AXI_DAC_UI_STATUS_REG, ival, - FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, ival) =3D=3D 0, 10, - 100 * KILO); + return axi_dac_wait_bus_free(st); } =20 static void axi_dac_child_remove(void *data) --=20 2.49.0