From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0C60157A72 for ; Tue, 8 Apr 2025 22:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151826; cv=none; b=Pm8vKu0nYjMSiYfQ0IFfr3Br57dKR/IZ9Rsg8zmH3/BnNx0ElQBMP/SidIi1KRvX96o4fPDnZxEplfCoMYXV5R9NRQQsEWCXcbDqC51IRaNznMkzpMkmYVWhcZSs/H1fQrOm2DQWLhu804rxnbu6iy257/AoZ5W/Ry7gb3ovgoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151826; c=relaxed/simple; bh=LOomkHuTmEbqkD9S71jgpPwKhCrIEWuwQa+giNptrIA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g/KB+HCyKZcljMoMblEuXiAj27COuF4QGLvHMxXG7XaLhzIelv+mYqi8CnsMfnR1PGRcUxqXOhTpgXYzoxLbyA8jf9xhHI4nJOANzwQ+B+CCHwSy39P44HKVXmtXBPm71+EAuZR7BhPdKcq8WFJpojLZphbfRE+KMpDZA1WkvLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=WzYXX+44; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="WzYXX+44" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-223fd89d036so74413805ad.1 for ; Tue, 08 Apr 2025 15:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151824; x=1744756624; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AP2PXK6Ju2JXIsqif6BfWbW1iCsIHOY8pmyx9+/+GvM=; b=WzYXX+444G64TI7LUtQwrgBZiGS0vyC5zt7f4uWUOafCV10xplfXo9+i/6qQi3orqu Znoj0FBUwpq/o+H9js2m72e2p3hr46whHc/Bfp+xiTkhVtvGUYB0dkR6SIv+JC3NR3TB OZqb/Kh3JMRRMAS6kZ4OLBf2nmuTHZ8ktagZjnD0UuYfwBjSKmgWci9eOKMHDmU3FZtz o9wiqc219fojYsrfzDQzqJUZwgYtKfwOhIPAGk0z0vtsVUURwmcfJpuVslGJvZsTdkVx IB9ArqDiduZP6V1UL/H4O7UpVeWuvnfwMK9wlPcGRrm//Z/psgiJUyX0Mnbqg7ai5Jk/ P96A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151824; x=1744756624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AP2PXK6Ju2JXIsqif6BfWbW1iCsIHOY8pmyx9+/+GvM=; b=swrABMRKynff84UDkvvEpoUYa4uiAWnHS9rjt3gtut/z+meiV9cG62+6iSb5yPH58s 9eNypCnuxQ0CvYCrBioVSancFx8km56jItzxFIQHVdxP0nNkepOhgv/ja7cf3mIxdh1R ojbQ2Jygi4eFCGXSXcI6NFIFI9VFppGwXvJKhS+ZjplNdpli21I4OH97C0Yvew2qvU/3 okUSPRZHKEKap5U0W8OL6tFXvbYD+tgCXXWSr7hDpUtUnVc6+NVreCGnbDkiLHWvHoh4 Jc7SjyoeBkk8LWfeEK3R5jbNRV7J47nlQyXHHcblHIwLYyvuXMv7r86YlFCDvLsSL+DY szVA== X-Forwarded-Encrypted: i=1; AJvYcCX1QwxJQIv4OEBO4SO7H5VuWykhsyQobhrm4SA71i5DrDl84W1WBrp/zfGmzqRHs9jNwFnk+sa4MexFyTE=@vger.kernel.org X-Gm-Message-State: AOJu0YyAsjqtzGDh0zsO4zxu/4DZ2G4XD1N5xmZj9wez5RTmKj4tDNki +lx85iJGZq1tBlB0UuGGclRuBoMfzFfaF7oz8ZyONVrAZGvEixZPaMlctaOHFg== X-Gm-Gg: ASbGncuqjYyUmqSSBn4R1qiJspEQCh5V/km0bInAJveegM5VizsH2TiDK9KlXtdMxmP a/95gRUfe/3WvrroeDzz0kh7X1+mEU3yQu9hPJN2GY34vFNO4ZL79J1hngdqFaifAXRZxSFntJK VkbRL0Q+yrjgGhtjidgPQsJX0qOdUNua/HyvG0yHIMucp6litwbGlhSNVIQgKDVNG7CAlp2mvC/ LXVAWq8HO9VDQwog9jvv+yacSQGi3cmu31oaLUZRS1bJunJt2ibSy3bmrcS/IhLTDH11Zpm41K0 rlDRxIiGD8p31XwbfDwfbyv5OfcQ2hz539O3AkryWJxGtC1dYVO10g/qxsifUZgO04a8WxZgZHp b/J9soqpfo3XMMBZNZRWv X-Google-Smtp-Source: AGHT+IGKvEnsdRS5hL6YZmLxvku7FG2molMRR7QZI4ydjjytO0nD6yliVmHOsuIfTe6xa6XFkMqxLw== X-Received: by 2002:a17:902:ebc7:b0:21f:4c8b:c514 with SMTP id d9443c01a7336-22ac400e787mr5352735ad.45.1744151824093; Tue, 08 Apr 2025 15:37:04 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785c0223sm106106375ad.73.2025.04.08.15.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:03 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 01/18] staing: gpib: struct typing for gpib_board_config Date: Tue, 8 Apr 2025 22:36:41 +0000 Message-ID: <20250408223659.187109-2-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for gpib_board_config struct in .h to allow drivers = to migrate. Adhering to Linux code style. In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Reported by CheckPatch WARNING: do not add new typedefs Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index a5c21ac6affc..1c641f17bdeb 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -23,9 +23,10 @@ #include =20 struct gpib_board; +typedef struct gpib_board_config gpib_board_config_t; =20 /* config parameters that are only used by driver attach functions */ -typedef struct { +struct gpib_board_config { /* firmware blob */ void *init_data; int init_data_length; @@ -48,7 +49,7 @@ typedef struct { char *device_path; /* serial number of hardware to attach */ char *serial_number; -} gpib_board_config_t; +}; =20 struct gpib_interface { /* name of board */ --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE002505D2 for ; Tue, 8 Apr 2025 22:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151827; cv=none; b=re6HrzQy6ggC35pTnAp4OY04E65P3u6GiaW8tk89g4ECvyrBFcqjHIRHDDMKH4qjFBAAbC7SKlMPJAOkqsQfeCGOxPRGUrWQcy9aWZYOLCCcmLLxEga12e3GrkAc0WeGpUVZvn3GkPO/9L8ORu0P1lSX4gYhZ3QmkgnqPtAFLXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151827; c=relaxed/simple; bh=MtZ3pwfafxNRz2P+XhgMUZBfB7smsR8XiJQ1pvxPL/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RllhVXmc+k/vpGuQyo750OD33fPq+vNtTKJEQEqHPT6znsyR+Z65dWoyQEy++WQfhFuTLxZ3gF2CbZUPlsmC2zPcxbVXuzWAz4Bj5NSPaHTiMKtfRmLIZPxhq3Ad00rtcv3dCSFT7caTzYiBJX9X2X44Uw8EHNJ13Re2oZYbIU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=c4ssQOBv; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="c4ssQOBv" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-225477548e1so58571265ad.0 for ; Tue, 08 Apr 2025 15:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151825; x=1744756625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k5QgrCJAQQZVGHYnGyP5Rqa3k3tzQutVKd7yDOG3Sy0=; b=c4ssQOBvx9EeSES3txNmWr5MxPYPSI+T6xanMeAsvFZI7W3oHv37WhV0U0djUo138D 14hTwSKLJWgwtCvKa53ZfnoF7qqhJ/YrHpTdSNCDtpYfY9nLcI3CaLE/93Rak83UyBYX HdjJHHT4ay+/gBtCq0InM7SOcnwRN3Wd8BFpZeZu4y/bDi5quaXckaU3BZSGws6x04/6 I9oaDb5+DddO0DSTaLS0fGnNR4kq+TiK3GaTPETj5uoYheyuXtu6h387aYiWohFauxbr TkXU1OVDbqSlk8g5yJtvrwIn5HdqZFMxSPY+y2/sOiPYBjTOFo4NL1QROlL197K9X6mr RDOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151825; x=1744756625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k5QgrCJAQQZVGHYnGyP5Rqa3k3tzQutVKd7yDOG3Sy0=; b=icR8O4a6aO9yUFLBZE58DSVvyFbE5/d2aWBNvOI7gBv5eAoCog03xIbCWtd5/W+vvr +74Rks4is7uUH4qFl/teA0jbGRjpaG8SoKKPc0vaBrgpXajGn5O+y/F+L8sftik81djW QJ947Gwy1groy2eFdOEdKTQZXBc0lX+7Urcz9WGZli1AOS2fmbHEjDoBwZqybmgDOKDu lvw44M9CIDCRFaSQLd6z0JX+t9eBC+ovsZdgPv2UAe0u4i27CzdTZHF+DsHBDDaYOjQq DVjOOvXbZWg1rkL5EQjBUCEScqjWtiuxKp2G0oLJxX6IwJTQjf6D9GHL3abZ+dUh32Fi VUlg== X-Forwarded-Encrypted: i=1; AJvYcCXu4XMDUMFjemzBlD43XkD5wRqSlFEVE/mDnjFGhinxxZFpJfdnRNKjGl30P8BNkkaBIREps4HV51nk0tY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6N4odWg1DExirfoz30sG53zIYy+c+KTddLq2oefPZAmykbczD UApYXxozr2NL2h1y3cKgYuhIgqvXgXK9EJjgUXa0SvIylsWtREXOO5X8nHZY2A== X-Gm-Gg: ASbGncuuOXw3JLnGeZ130Ug2KkjJINFBhnhg0QczpXZK7ztmsrUYFH+hpKlAIlhb+DN nF1Ccuy8ctr3pDbAyp54PerbYMZulIpkEtToHFJLmRRNWYDjuEry26RfNiMPFtSZmZdhQm4AQw4 hyCNttyPuwO7xuoobSMF5qmyhjMn4PrXBlQNjHzfBLxvhnZa1OnhapbkaO1oVMGXx50dRYVUW4s mWPCkba2cTcQaVgD3QlbBP0vINYHvWVRePk1tamNT5Tvqw/7GGw8oZIQooeCvTjc35Jq8U92L9w +Ily6AmBDKywG/kanJ0f4B4WLTzeWS6JyPqzRmhz0j5lSInPk3pxZuweKjNOZJbpJr8Pz8LPtUv flE//qdpyOmdbQpOciSSR X-Google-Smtp-Source: AGHT+IGdJru4JHcvDVy0T5okzA05M3CIgR90mRA5qF5Fv4cVuCDOBKVQREsR8eV+lmu3XXvmeHzJNw== X-Received: by 2002:a17:902:e550:b0:223:39ae:a98 with SMTP id d9443c01a7336-22ac299d473mr11858275ad.22.1744151825210; Tue, 08 Apr 2025 15:37:05 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297865dffcsm106264455ad.127.2025.04.08.15.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:05 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 02/18] staging: gpib: agilent_82350b: gpib_board_config Date: Tue, 8 Apr 2025 22:36:42 +0000 Message-ID: <20250408223659.187109-3-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 3880d4a23eea..901f7182502b 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -492,7 +492,7 @@ static void agilent_82350b_free_private(struct gpib_boa= rd *board) } =20 static int init_82350a_hardware(struct gpib_board *board, - const gpib_board_config_t *config) + const struct gpib_board_config *config) { struct agilent_82350b_priv *a_priv =3D board->private_data; static const unsigned int firmware_length =3D 5302; @@ -587,7 +587,7 @@ static int test_sram(struct gpib_board *board) } =20 static int agilent_82350b_generic_attach(struct gpib_board *board, - const gpib_board_config_t *config, + const struct gpib_board_config *config, int use_fifos) =20 { @@ -730,13 +730,13 @@ static int agilent_82350b_generic_attach(struct gpib_= board *board, } =20 static int agilent_82350b_unaccel_attach(struct gpib_board *board, - const gpib_board_config_t *config) + const struct gpib_board_config *config) { return agilent_82350b_generic_attach(board, config, 0); } =20 static int agilent_82350b_accel_attach(struct gpib_board *board, - const gpib_board_config_t *config) + const struct gpib_board_config *config) { return agilent_82350b_generic_attach(board, config, 1); } --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23274255E27 for ; Tue, 8 Apr 2025 22:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151828; cv=none; b=Cmx9lxW+oKY52M+dTnKpUKUt6BddfgODxMU3NMQxcIuZt6qpjZwYzMwvrtjTYJwyA+M9oBF3vINqLMBsErb1kUo2sDVy2TTmOHIYXpDRlgjsyo80H9FH2xZFGanGdwoJMUEraRctZAl+qeA5/saIMHKPrIOhXsObA66ZAW9hrlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151828; c=relaxed/simple; bh=ZLk8GslpxSlsrtMxBElb3wimefBQ759wHGmHWLKEtjY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ENuKvyTHaA57TlngEyrCDDPTgFk+0mWJ2+c31dt4Tprd2hB/ZcbGtn92CkPHESt4Dwqxbxx1uG4So494zDgFwDL8mCcetn1sXyyqXed/zOoac2GYihPRuJfiR/QCzcR1uGZGZgQCVokMLpb9GoLlKvBSx1AuwW0jiFTeQ7l9R9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=SdQCLOss; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="SdQCLOss" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ff6cf448b8so7232877a91.3 for ; Tue, 08 Apr 2025 15:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151826; x=1744756626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+GaKb0l6WtN6m4tMcZM1SociJ/kaCRWmZW8SSNvMkBc=; b=SdQCLOss+WrElcHFB7xaU4qsAQZ04NOENqAuCSuyEkuD5527BNuqMdPuzV6KJCxdog uy8gzmVIdu2CJiDHsfUBzsYBJrbgxZNe5Vux0tpC6PcYJ7BpqfTNZB6fwqud4GrZhQQn zlzLe4kTOM7U7TgXy43EDFW+BYZVpC54V6ZfnXlYJi+4urexg1NrkpfQffABAjRsG1mS v75cRhHX5xjzPo3hxGcE1VWLeUBFoyvg0kT8ddGOO2u/UR7gX3LdxE6oZtl6cJhhoHsX isVFi9d74TjLOWzBc8zo2B+AiieocU6giHfh8NMlVP2VzN7x/GkORz0BnWp8irgOOAaK 1XFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151826; x=1744756626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+GaKb0l6WtN6m4tMcZM1SociJ/kaCRWmZW8SSNvMkBc=; b=LI159Z8tgvxe5DejJhinSNlyfB0s2DedLk67XGlKzLud5VM7/GKoocqpp2cWtoz0ig 1H2CKJHbrz6EVPXvCufEJKNbb/LZdrIwwEMuKpQRwze3+ddx+7qFQNdcpXXJ3WIBxv23 cmr1UhxmYzKVuAQkvFU1H1/sX+AmEYJpfqss/GmaWeKMbNyXgbfcJgzg/fiKo5z63yI1 tlm4/YAVSrH/jIf6PmKZiNaF/I1Z3fCKoYNBLRKJZdTyRi0eaqP0yfcs4Du3sb122Yj4 X0O4Fk70RUB0SGJW9bkXeoOkbGqjwLthk5KIqHYa4WHpKWkFdj8UT/DbGA627xwuY8as eDJQ== X-Forwarded-Encrypted: i=1; AJvYcCUDZRW5yGzxGlFtgDBn5QLmbrYSUv53M89Px9GeVMCXWb3mpYLR2Ax7sNHcADNX6SGOpZimtFoHH22Hn+A=@vger.kernel.org X-Gm-Message-State: AOJu0YxTGs8UNtseisHHdSmqdq0isSC8egv7q8dNq9NBpYejIHDMdspH F7IZtMlTBYpCtR7B7l769ns525QZX1Ucu3uYiY+hdB8qBE1Casly6TzO0pijLw== X-Gm-Gg: ASbGnct4h2+Q+EPqlAUhhdOOU3mb8+df3UGmmRpvLUP7VuygXc/4vyQTWqlYJVfh3e1 a129/b422HptJZMMXEdo3biYfeH1S0pXgqeA3Of+GR+RVjTaR2Bc6OOA20YjquVDpE5Rv+JukXQ TX1LCAXxCycmnkPiCh/MSF2OuLOBeLv9GG+fmmm3HdX+dD3LNNI/ARwYBnX5/6P8SRM/fmwgQ4y nGecK/r8oD4VWAlY0CDU+XgUM/SICmvr41ufrR9kxlxdxT02wl7ZgcvxcHufL6JV3HWhcN7i8b1 IvEL33c0IQY8HqiQNrSNdj+LU5uSS0q2g+2iJw9JGdtzSB0v2P9Q9w5aliNVQ4BVKdKQCszxgf6 I3yPIYbPilw== X-Google-Smtp-Source: AGHT+IGrPMXPOwwtImIdhnJkimYrLfyFGrVUekqyPsAsS35wEYdQ6vRnnwJcB5BtTLUD6D09rfpyfA== X-Received: by 2002:a17:90b:5241:b0:301:1c11:aa74 with SMTP id 98e67ed59e1d1-306dbc2bf38mr1120900a91.28.1744151826420; Tue, 08 Apr 2025 15:37:06 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229787778c7sm106350885ad.255.2025.04.08.15.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:06 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 03/18] staging: gpib: agilent_82357a: gpib_board_config Date: Tue, 8 Apr 2025 22:36:43 +0000 Message-ID: <20250408223659.187109-4-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index 29c390b4f4e4..baa8f149024c 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1292,7 +1292,7 @@ static int agilent_82357a_init(struct gpib_board *boa= rd) } =20 static inline int agilent_82357a_device_match(struct usb_interface *interf= ace, - const gpib_board_config_t *config) + const struct gpib_board_config *config) { struct usb_device * const usbdev =3D interface_to_usbdev(interface); =20 @@ -1305,7 +1305,7 @@ static inline int agilent_82357a_device_match(struct = usb_interface *interface, return 1; } =20 -static int agilent_82357a_attach(struct gpib_board *board, const gpib_boar= d_config_t *config) +static int agilent_82357a_attach(struct gpib_board *board, const struct gp= ib_board_config *config) { int retval; int i; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E01913C8E8 for ; Tue, 8 Apr 2025 22:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151830; cv=none; b=pryERzNFBZDZ3KKBtt5NxHAtjZ6/nWDdgKwhKBQeqKfSMTmQ5Y+Qjo8lm2wKslFjs3nxsLrCrjAvrp/PPinslwyDWpy//PZg12UR7JmnY5DNnai0W+qkUtDPgwZ6h2I62Yz3sZjKRDIUnuCabFt1rsc0jieWkoNHAlxHQrK7tyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151830; c=relaxed/simple; bh=mUmAeGXRbQ7VAok4KoJS5eLp8Gt4hMGUusX407z9K20=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=befVyg+O3tq3z1PubQXpG0N/YqeocFXv1M5S9+tN/RDFtpuvpwCVrE31nMgWecvL6t9U/LHIORojwwXwPSGrnP6zBhI8JDCsOE5mjZeRpoNjZo9YZLPsi0ihO2/un3TzYpj5H6FusAQM49wA1wKBopRTxPg0D4SPgSOrRl4qz2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=HX9riiqy; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="HX9riiqy" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7369ce5d323so4886631b3a.1 for ; Tue, 08 Apr 2025 15:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151828; x=1744756628; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eBJz86+Ff7rBhAwfla9Zgu4g4QbDvxGnEKapVf5XDjc=; b=HX9riiqyBP2+nDs48vERHRobmZXZH4K/KxA6okbOvlVv+w1iwKN93JPnViYB/RUa6u GeiRawE5u3YNUjEdAaxSQLqTtAQYj4bhN7W/jB3UMtjnpmgwyxQb0qKs7KE8Et6j9GtU zaxaJ1dYSbbUgq5S+E/VGFCEe878AVDfb9CrVMhRyr/ACUEA51BlnPJ6gWqU6Z0zA9Y6 sWilEVAzo5RFpBa7y4sippWOKYhe1YJKjYi0sryy8m7Fsz5zoxJaH6RQpBetlOCvLHKF JjMLjG8nPh5M8Tnch0sJP71IhIUy/oBhqjw38eI4AZ+10AB1UPncSJo4grUeXf8Rmng9 J4Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151828; x=1744756628; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eBJz86+Ff7rBhAwfla9Zgu4g4QbDvxGnEKapVf5XDjc=; b=qJeqCN2389FPzo2AUrMohVtkwaQSCF5Nm/FJ45cQdWSTpzJH+MwzEtlZRRarTAtwP1 cOYTwpB4hVrBTmHKdce3zs1QBtc6C5ZwW90exSYwwe3HLt7KOV2iQNAzWd/0VuZ5TvGx VRehR6HSg8g1gsLViOSQVXmDOzEi8uC+6w0Qmi13cwacgagWWT0bWT5aY3oCQk+kPwTW lrRloMJRa/1nZVaKv5Wb0NREcaOFs2amtn3YnoQTfXN0ByCZMVGyY7qRZOI3zIg5PD/q SGLHTpZZf/LoPq8MPPHqq78vDOaVkz3HGUP1MBirdzgeOwkH1wnU1lLAEqO/Y+t1qBA+ yEoQ== X-Forwarded-Encrypted: i=1; AJvYcCVvZmqZ1Osik0yaXaX4noXdP+CLz6ozamZyEygHPH/Ix7H1qtTA3xB1b7zUJBZFXahqnZm88BhjzT2MVSg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7hzwqG9BrGRgkkRKz/sVfIbiCZhfAptJ3fKGmCDX0JU5qDXiQ gyGp0xrRQF65ULLoUP3XpnUrR0d+xtQiaySt+1I7mR8eN/ftxkYnmUkM15UFecAGaFVaeFjT2sA = X-Gm-Gg: ASbGncsQZnq5/9ZmK67PZv2lgvsr3MW5xxsvRNR+xG8unJjtQZFJfC/kS0FJUQaJDoX Y0CMm35dIGfM9yZGkWu2PdV8aWgarfxYHRO6LhMJKLndHl8e+yERIDAj1WBYZPJPbsmcr36qs+5 pa4Zv8g0K52TfBPckenvTDomOSjTxhSskdBPE1fRc0APoeXvhom77V6EIKISTp9Sv4V4KnKKQlw IBCY+8rK5VdznWfXmVSRfa3Hl0aTcqfcso+m+ODxYap9gEK7pphFdMjkFp0amIwTaULeHJzIVJJ F2uIONM7meBp0k56LM9kqa50+JhmRn20uv7PRspL2dYY9eBameO0agK+A2B/+iOvkHxKO5v+HH+ KEF3veLmWjw== X-Google-Smtp-Source: AGHT+IEjSpIyp7em7ovcxLcNfFL+AzYoBn298I5r8R5h68flLK0yC72ZCxAQfyO2IyGuzaaEdjbSCA== X-Received: by 2002:a05:6a00:194a:b0:736:6279:ca25 with SMTP id d2e1a72fcca58-73bae5528b7mr942741b3a.24.1744151827617; Tue, 08 Apr 2025 15:37:07 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739da0b4317sm11499762b3a.148.2025.04.08.15.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:07 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 04/18] staging: gpib: cb7210: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:44 +0000 Message-ID: <20250408223659.187109-5-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cb7210/cb7210.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb= 7210/cb7210.c index 20cea66d6557..a8549718b425 100644 --- a/drivers/staging/gpib/cb7210/cb7210.c +++ b/drivers/staging/gpib/cb7210/cb7210.c @@ -533,8 +533,8 @@ static irqreturn_t cb7210_interrupt(int irq, void *arg) return cb7210_internal_interrupt(arg); } =20 -static int cb_pci_attach(struct gpib_board *board, const gpib_board_config= _t *config); -static int cb_isa_attach(struct gpib_board *board, const gpib_board_config= _t *config); +static int cb_pci_attach(struct gpib_board *board, const struct gpib_board= _config *config); +static int cb_isa_attach(struct gpib_board *board, const struct gpib_board= _config *config); =20 static void cb_pci_detach(struct gpib_board *board); static void cb_isa_detach(struct gpib_board *board); @@ -926,7 +926,7 @@ static int cb7210_init(struct cb7210_priv *cb_priv, str= uct gpib_board *board) return 0; } =20 -static int cb_pci_attach(struct gpib_board *board, const gpib_board_config= _t *config) +static int cb_pci_attach(struct gpib_board *board, const struct gpib_board= _config *config) { struct cb7210_priv *cb_priv; struct nec7210_priv *nec_priv; @@ -1031,7 +1031,7 @@ static void cb_pci_detach(struct gpib_board *board) cb7210_generic_detach(board); } =20 -static int cb_isa_attach(struct gpib_board *board, const gpib_board_config= _t *config) +static int cb_isa_attach(struct gpib_board *board, const struct gpib_board= _config *config) { int isr_flags =3D 0; struct cb7210_priv *cb_priv; @@ -1133,7 +1133,7 @@ static struct pci_driver cb7210_pci_driver =3D { =20 static int cb_gpib_config(struct pcmcia_device *link); static void cb_gpib_release(struct pcmcia_device *link); -static int cb_pcmcia_attach(struct gpib_board *board, const gpib_board_con= fig_t *config); +static int cb_pcmcia_attach(struct gpib_board *board, const struct gpib_bo= ard_config *config); static void cb_pcmcia_detach(struct gpib_board *board); =20 /* @@ -1417,7 +1417,7 @@ static struct gpib_interface cb_pcmcia_accel_interfac= e =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static int cb_pcmcia_attach(struct gpib_board *board, const gpib_board_con= fig_t *config) +static int cb_pcmcia_attach(struct gpib_board *board, const struct gpib_bo= ard_config *config) { struct cb7210_priv *cb_priv; struct nec7210_priv *nec_priv; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 695D02566EC for ; Tue, 8 Apr 2025 22:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151830; cv=none; b=B7u/jnRR4WHmTezzOd6oJ6Mx+uYTb+HuVrIdS9dh2QvnbohTG+Ra4wDA2e/3vbNc9cDDy0frEAgKkHJFnLD6lbxXahUrX5UWz5Fvm8YycY0uNuAU4618y1ifZswz65LJQ9JRkJE0O+Bspjwn8i8KeEyP/LxOmV9stIabQ7yIAIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151830; c=relaxed/simple; bh=uO0WEOl3NJdo8eeK/l2yzXWRkzHpMAOj27lRaFN0xC4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eInzu3tWnKgx7o0UiXzknaUp6grU6bI7osBnmCFXqgoGExQikZlh2XiTHqojxgA7Mk4geu2KNSfBdPYCH9rNAfst/Utl5ff6eWHlkYkh4HHYSm3TFvzmSR4TOYTCNCDFM8das8V679pXovBV6sVIqdDeBPfX3FBBaBrv4euDwRA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=FQHIkp4k; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="FQHIkp4k" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7340e6f3ce1so4820943b3a.0 for ; Tue, 08 Apr 2025 15:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151829; x=1744756629; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TMoJ0GicUz0RLtgfdlS2esbiLZrZHMdlYnOr8+kJvrw=; b=FQHIkp4kr1SnWFpkgbSY3r72Zx715HfGaFRAxW2QhiRPhju5b3WpSy+VFRvjdeZmxk KzHlE5xRFKP/DMUjFxEYgEz/lJcVaPnOykszqFI/vorcNGIkxQydagw8SqbyqOr4I4kF MoCok47ne/K/0LcxF33GFvc/pkP7pK3FhKlA0iav/WgHfWw26HlP6k27ylCEDWN7fS+t koUFOFBb6TP62sHpfOFLa0FFnXD+FbO2CJUCFt3UHA7IUd2rqzYgcgIlOn/52/sx7Fu/ CQx3mNCGhIXUcZpvVS0mV+OFAUrgao6wjtp8ABf+9eqQD6bMzl4jRBlQJsQAUzlXSFYl IDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151829; x=1744756629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TMoJ0GicUz0RLtgfdlS2esbiLZrZHMdlYnOr8+kJvrw=; b=fRopsd8NXmgLZ3Qz6GCsCPnRX9mc4T17BltIa8zPXnfqu8wMa1Vb28avboKA6NfX+i 8cb5ilV2YfUliasQ9axasCAuDaAh4bXjBbLZMXqwwkw1bG6VGW5lv1IuPgvEjJXttOB4 SCfsUJg/PrSMz3xRHUt3Iek3yrWiLbv64Dk8WTCtrBxQJfAbvPUXbkYxL1/rEwAAFtIP 6vONiovZxzyiM9CEpM4/Fa177/9fZ9kbL4qdA2Y0POCtjDpCPs1J/27bdw1CKDgDbG77 j1fZUt4pvc2TBbrLg9jw4T+g9qGLTohNht/bSnn3KVFgIAAYAYY1swq2Z0zm10Dfp8SM G1+g== X-Forwarded-Encrypted: i=1; AJvYcCUxoWCI6nBzH/BZVtrn/A57someaLZzfLDe6Uz97MtKqFfw3NQo9wDlVmykghAxe/FAbFWnwDyYDu9iVws=@vger.kernel.org X-Gm-Message-State: AOJu0YwPqtsn4dQjQQBrMcScI83+Fx6idkGkvg0z8hHyxPQ6tc1nGs0u YVEEls9KiEZXUBhYwRWP/5bt0hzzZNdyOBlE4kkAzNkpXDVw4EgsyzLo0lfSYQ== X-Gm-Gg: ASbGncvd8FojR0DmLkkl+ISQ9jXyaH6IXqAQ8Zp6aN0KWhlXawIHlsFUbIAlQcMervg jPkD48b1xKJqJRatRKyOjlTbi8E73ZcWTdW8Cl/FMYC6ERohi37nug9rpJ/99+NnhwypGKb/mnS KjGeDfpSgcOukAnrMeUQVlWf76wmS7s4q2ifDYdl7lMHnqDLxmkEMPmdLTLAW9SGuZYcHLBQk1H /c0JW37QhbkonvEWtZ/fi/KGRpnwJEJmcaMlr+OY/dXMA81X1FTynofMJwdrkLT0k8pJcBox3It rYu09gyEDGwyWYPGAItvN1XWN7An8yACs1xJNLROtIEMKujViS/0yJYeRt6IPTkmVkMZyLJdBG5 2qKVPgDm8GQ== X-Google-Smtp-Source: AGHT+IEcFqKl2v/rldxmVTFJB42fvEpdpDtJ/GW+jfXpR2xPqh4+7znLLqZf0ROtRe4CiK2GHp+/Xw== X-Received: by 2002:a05:6a00:4606:b0:736:9fa2:bcbb with SMTP id d2e1a72fcca58-73bafd708c5mr276174b3a.24.1744151828779; Tue, 08 Apr 2025 15:37:08 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d9e9dcc6sm11505636b3a.99.2025.04.08.15.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:08 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 05/18] staging: gpib: cec: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:45 +0000 Message-ID: <20250408223659.187109-6-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cec/cec_gpib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec= /cec_gpib.c index dfc718de1532..1b02222881b9 100644 --- a/drivers/staging/gpib/cec/cec_gpib.c +++ b/drivers/staging/gpib/cec/cec_gpib.c @@ -40,7 +40,7 @@ static irqreturn_t cec_interrupt(int irq, void *arg) #define CEC_DEV_ID 0x5cec #define CEC_SUBID 0x9050 =20 -static int cec_pci_attach(struct gpib_board *board, const gpib_board_confi= g_t *config); +static int cec_pci_attach(struct gpib_board *board, const struct gpib_boar= d_config *config); =20 static void cec_pci_detach(struct gpib_board *board); =20 @@ -265,7 +265,7 @@ static void cec_init(struct cec_priv *cec_priv, const s= truct gpib_board *board) nec7210_board_online(nec_priv, board); } =20 -static int cec_pci_attach(struct gpib_board *board, const gpib_board_confi= g_t *config) +static int cec_pci_attach(struct gpib_board *board, const struct gpib_boar= d_config *config) { struct cec_priv *cec_priv; struct nec7210_priv *nec_priv; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A130F256C96 for ; Tue, 8 Apr 2025 22:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151834; cv=none; b=NlwtFdeKmMzUXrCWpCmjtC3aaIiaxJDi1p/Y/bAII0ZS186kDDdTNjC/AucLLtT2Tq8SVKeqEFT25v/dDm6kRtQ2mpkHow4DWKOFc1chiDMWVdLj0Pj/pZzNUzqXZax4MoMOZH1Dd84YHaNhVztdUfGwhnjmD+9CajZ6kkdd2Uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151834; c=relaxed/simple; bh=9jnj8JCPLNJB7Y8bWf2v76OtUtjBvHVIvX7+JBZZ3HU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K2BjiB3lNC0ok2MM5rSNh+96m7PjHR/b6HKQvA1bRmGC0u9BFW6x3xqVzAkhs8hNFZmAd0wO5lKEdTilF5/jdnwVaZkgZCD32gWdyi1hyVKa8EF93Yq9QE7YjaJt2PwMmkTrs0zY0C0vMNH2Ia3R077kxyarnlVwIVlTp8V9Gyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=HBs2bE76; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="HBs2bE76" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-aee773df955so111109a12.1 for ; Tue, 08 Apr 2025 15:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151830; x=1744756630; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XWMnH0Did5XyzW5jfPrUxbx63YMfVnoGAwbN881GRAA=; b=HBs2bE76HmgHlCQ2rPeqdDv8/VtrE0fzY2ZY1NJ54BYmPKUpa8/VpgAwqC1j9OzX8q rm/b3MCXt1kao35uPw4jtQbEsw9DNrvlQw9d7T5YnKV+ieCebhG11nbpWQFIRi8q1Pul kOoceTQUe9oFIKHz3Cm2jjKVpV0MTBMtxlo65CexDNqrNYYbfG8cbjG2E5IYRXrkxw98 dapPjKeZsGt3glj/RuRwyUpOBXruBoUCj8cvfNqxknb2W9p6b8EDTTU/s/IgWwmEuvRZ l6aHHwbNZEY51L2eTtHLCPpN5oA3YVghQMKeFLujFfp9bgOrwT6umpmdmrcQqvax8KhC XuVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151830; x=1744756630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XWMnH0Did5XyzW5jfPrUxbx63YMfVnoGAwbN881GRAA=; b=dbG6Jp1u9dboA2FsyrczhYOe7UlH2iuNMoevR+6jJm2ryRuZ2Oh3wwsmzT/Xk2JL1G 2xoew3c3sMFu4JmU7QJ9u+o1vMpZznDQsSgA+ZK6Q7VqynOwv9dY8wjMSZnPs9qiFJRR y37JkbbI0fNgqqE1PiuVOV8/pyxpnLkEY9MF51h8TKnCsFluWG471zvlbA9PMNyXdapV akHblmUAMMphLSDJPcKpcBYs+E2XrPYpK6UjL4m2Otz5+q8hImn6OISbF/XKEZiLponE BMYb2j502IBcnjrYJDNixn74WBGuA/4JiPUK43GKGF3DFdhCvgUUpDWlc3zjUd5xkvfl mCIg== X-Forwarded-Encrypted: i=1; AJvYcCVrUYQQO9vYShI2cvdYvxiT2EQ0QD5ciJ995eIuFktLMJdaxZ4bW90p0tPggbscRe1AojZpYiAV8xdybWY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywcr3Q1eW5Gsc2OrKBQeoigJMEdpyJgZv/JgKHxxJBdEjO9gJKQ luF03mJgB9PJmPYU6vIhszo+I+MgEv7ALDUiOZE5677B9ay3HAtt2HiF4RFzuQ== X-Gm-Gg: ASbGncs2boCOrOcjupoCbyoMZTYuJBOWnqWBCJmpE4E2lMYPlbshp4mwgoHrgG0ctNf KCbRTfA9bTKCrmOnlztKTxrBcLMIBcT5qJ1mkPZgtGtSIE4wHcyG92ZJYhDM4r66ImXC6nj9O6I 8WCNL9kAoyWv/NCUmTdBNHchs7oUTwDSUBdgMl7jGrkjNfVwQQj12yNTDC428Ek6roGkNySBMmt 57Nx6ON/UItfe2XxZMz+3HI8M3+0gezI8FmUa/eGDFFGo4mCU9Uu2NTSQwg0kF7AyzdXKHXYJkX hOXOFz202Eoml9Q1ISfrgrIVxr7ogP0ZipB/BAxfPdA83VAXFD8bmxshWxlidJUx5kWmtAYOrC3 fdjy418AaBA== X-Google-Smtp-Source: AGHT+IHYwI5R9KBRqVHiDJeq7AElYZCltjRwDzA4lymP8T/15XjM0s5gRterfVSjI9Y2OBeLz0wGVg== X-Received: by 2002:a17:90a:f944:b0:2ff:53d6:2b82 with SMTP id 98e67ed59e1d1-306d0d1d6e8mr7027966a91.11.1744151829879; Tue, 08 Apr 2025 15:37:09 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30584761e65sm11641716a91.13.2025.04.08.15.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:09 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 06/18] staging: gpib: common: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:46 +0000 Message-ID: <20250408223659.187109-7-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 28 +++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 940ea05ba478..f2216768d8bd 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -50,9 +50,9 @@ static int sad_ioctl(struct gpib_board *board, gpib_file_= private_t *file_priv, static int eos_ioctl(struct gpib_board *board, unsigned long arg); static int request_service_ioctl(struct gpib_board *board, unsigned long a= rg); static int request_service2_ioctl(struct gpib_board *board, unsigned long = arg); -static int iobase_ioctl(gpib_board_config_t *config, unsigned long arg); -static int irq_ioctl(gpib_board_config_t *config, unsigned long arg); -static int dma_ioctl(gpib_board_config_t *config, unsigned long arg); +static int iobase_ioctl(struct gpib_board_config *config, unsigned long ar= g); +static int irq_ioctl(struct gpib_board_config *config, unsigned long arg); +static int dma_ioctl(struct gpib_board_config *config, unsigned long arg); static int autospoll_ioctl(struct gpib_board *board, gpib_file_private_t *= file_priv, unsigned long arg); static int mutex_ioctl(struct gpib_board *board, gpib_file_private_t *file= _priv, @@ -65,8 +65,8 @@ static int set_local_ppoll_mode_ioctl(struct gpib_board *= board, unsigned long ar static int get_local_ppoll_mode_ioctl(struct gpib_board *board, unsigned l= ong arg); static int query_board_rsv_ioctl(struct gpib_board *board, unsigned long a= rg); static int interface_clear_ioctl(struct gpib_board *board, unsigned long a= rg); -static int select_pci_ioctl(gpib_board_config_t *config, unsigned long arg= ); -static int select_device_path_ioctl(gpib_board_config_t *config, unsigned = long arg); +static int select_pci_ioctl(struct gpib_board_config *config, unsigned lon= g arg); +static int select_device_path_ioctl(struct gpib_board_config *config, unsi= gned long arg); static int event_ioctl(struct gpib_board *board, unsigned long arg); static int request_system_control_ioctl(struct gpib_board *board, unsigned= long arg); static int t1_delay_ioctl(struct gpib_board *board, unsigned long arg); @@ -1542,7 +1542,7 @@ static int request_service2_ioctl(struct gpib_board *= board, unsigned long arg) request_service2_cmd.new_reason_for_service); } =20 -static int iobase_ioctl(gpib_board_config_t *config, unsigned long arg) +static int iobase_ioctl(struct gpib_board_config *config, unsigned long ar= g) { u64 base_addr; int retval; @@ -1561,7 +1561,7 @@ static int iobase_ioctl(gpib_board_config_t *config, = unsigned long arg) return 0; } =20 -static int irq_ioctl(gpib_board_config_t *config, unsigned long arg) +static int irq_ioctl(struct gpib_board_config *config, unsigned long arg) { unsigned int irq; int retval; @@ -1578,7 +1578,7 @@ static int irq_ioctl(gpib_board_config_t *config, uns= igned long arg) return 0; } =20 -static int dma_ioctl(gpib_board_config_t *config, unsigned long arg) +static int dma_ioctl(struct gpib_board_config *config, unsigned long arg) { unsigned int dma_channel; int retval; @@ -1793,7 +1793,7 @@ static int interface_clear_ioctl(struct gpib_board *b= oard, unsigned long arg) return ibsic(board, usec_duration); } =20 -static int select_pci_ioctl(gpib_board_config_t *config, unsigned long arg) +static int select_pci_ioctl(struct gpib_board_config *config, unsigned lon= g arg) { select_pci_ioctl_t selection; int retval; @@ -1811,7 +1811,7 @@ static int select_pci_ioctl(gpib_board_config_t *conf= ig, unsigned long arg) return 0; } =20 -static int select_device_path_ioctl(gpib_board_config_t *config, unsigned = long arg) +static int select_device_path_ioctl(struct gpib_board_config *config, unsi= gned long arg) { select_device_path_ioctl_t *selection; int retval; @@ -2069,9 +2069,9 @@ void gpib_unregister_driver(struct gpib_interface *in= terface) } EXPORT_SYMBOL(gpib_unregister_driver); =20 -static void init_gpib_board_config(gpib_board_config_t *config) +static void init_gpib_board_config(struct gpib_board_config *config) { - memset(config, 0, sizeof(gpib_board_config_t)); + memset(config, 0, sizeof(struct gpib_board_config)); config->pci_bus =3D -1; config->pci_slot =3D -1; } @@ -2212,7 +2212,7 @@ int gpib_match_device_path(struct device *dev, const = char *device_path_in) } EXPORT_SYMBOL(gpib_match_device_path); =20 -struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, uns= igned int vendor_id, +struct pci_dev *gpib_pci_get_device(const struct gpib_board_config *config= , unsigned int vendor_id, unsigned int device_id, struct pci_dev *from) { struct pci_dev *pci_device =3D from; @@ -2231,7 +2231,7 @@ struct pci_dev *gpib_pci_get_device(const gpib_board_= config_t *config, unsigned } EXPORT_SYMBOL(gpib_pci_get_device); =20 -struct pci_dev *gpib_pci_get_subsys(const gpib_board_config_t *config, uns= igned int vendor_id, +struct pci_dev *gpib_pci_get_subsys(const struct gpib_board_config *config= , unsigned int vendor_id, unsigned int device_id, unsigned int ss_vendor, unsigned int ss_device, struct pci_dev *from) --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73EE256C9A for ; Tue, 8 Apr 2025 22:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151833; cv=none; b=BpcOwKU5XT5/NkXf0Nk5Th4ATIBNhRspaYHbaxDAGcbWnksdoXxejgCVNJzvAToL7BjmI9x0t4XVpB2uPbCswAqkznFbHRjyhjdaKzB4mt4zu4bsJUUdd15XTtanePABwjjKpYhMvLCKdO2I6xK2nDqIT4Vji5BFmX2/NvQneJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151833; c=relaxed/simple; bh=X2KhSNYsB2/23tHVl1psd3ZQKbNsc1BjZp9JQ+vPiUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qfEUbxVihmbic579Rvx+rvnfRzGp4jxUtgFSsQTFMLhTZzo3Y+yLG0qPseD0rMId9pkW4JgwmcVLZG3jO+aOuFGD9qp73OZ7ShaoUcDg0LTe8z9NYCYkj2ANmHVd5YISiVpVVLeZTS8SBHUqO+A9Mo8gS3YTErUT4JfXTuYLaRM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=APCcDVp0; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="APCcDVp0" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-739525d4e12so5552049b3a.3 for ; Tue, 08 Apr 2025 15:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151831; x=1744756631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4KxdZYlQTl7PeDblUTMa5/yJKQsZIFffGHGPPKkxlHI=; b=APCcDVp0JYdZyHKx8PfGaqFryyGrVJzeK2RBX8sH5M5Ktcz86WCPshOGAQ/W+c2NOq mfly39eDjDD6MJoJGu0oAaBcNEFXeU8Kv4Od5ntrQq3QYF4zB6RSV7HC0k+ZP9zdbcsI FNkCJmWs/dxxG9V9br1y5wmd/fGkksUzLbmOAotXwVcOAMRjA2TYATKtyEs5lChg4IEE PvjIH606F7UiDp/DRLpobNZSzr4WFTfuOXv9xHK5SQm4bDgBXqz2AxUD+Z83v6N940e4 9adDKKs08CDo8XgULihU5DDcaq6JZnoycUzeX4rDw4yfE+roMgHEvsFqB1FUG5dqcUM4 xENg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151831; x=1744756631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4KxdZYlQTl7PeDblUTMa5/yJKQsZIFffGHGPPKkxlHI=; b=GDmhh42YsJxYRAyDN+E1oXjrnkrTFe19SV8sjPTchJT6HWc345VWOkJ78SJWF6kzl8 XeVU9P7enYBAmPclto5iFb6Sl1XU2LlSC11TqsEZg56OjWd0zuLmM/gnJX+JfW+CvsKC 1Pbty3EG2MYbnxOQVluv4MSI+rGp/X/0aVwD6PTxtPUQW2d/1WITtELbvtQgUpveldGL DkT9nB8HA2VAIaucfcdOYSZ0IyhvpulFqi6jwhvZnDyPq1oDQOHw0OXJPP3ViDDnlTH/ 1+TuhmZrmXNFGM+zS+CGgIvpV3d7WQW7Kwi4NsLn9VzVqJ0W8Ws1C+MGAw9pwuy/bbiE bwrg== X-Forwarded-Encrypted: i=1; AJvYcCXC7qPN6fq4BFYs1ccZNJCk8EE08oo7nyOwWZtEt+H9fDIRgw8kY+45n3Y7lK5RMvgUKwM/RFXCH7cdfpI=@vger.kernel.org X-Gm-Message-State: AOJu0YyydaOiyS5fJi5Dm1CY5Kky2wxua/CGFgHVnHTpvXCQC4xpAeXf pAaJInUy/NKFejSMT5IEqwkcEMBKyM8GUetdrdPatJW+90SX+T2O+lE17+PNXw== X-Gm-Gg: ASbGncsGaQvCf11758eD+s9TYRc5Oz7lzUq1ILjx7DKWm8DeaXy7BKjnkyy+yZ1itBr e3Pwwj4Wq8Ljtnhq++v2+gq7m0Cm1aEu/OqdB4ELTYq7aq6Ix45Obsft2JuqJhVjVFKBcJF6qrX /1nHahnGKMeu/sGAGIu8SmkPW+Nw8M1cNbfz6Uqx/HdZVno8BaaBLN+FASP5I8JgU7/MRjM0Ezt fxwoeJSfAqukQOc4TQeoN7XnqH91lJi8o1Dgvw8OKIdHvE6mbA7UI5+lhjy1BYnTpJ0/ddgLCD7 yBDzEwcYNZ6MQzHLE8+BdUJHvuA9HO4jyOg2fHEv077Bt44OTC0aa5AGEybPwxMTimsriri9oCV bt92lnxXybA== X-Google-Smtp-Source: AGHT+IELnbIS31LEPqBsQyZVs/Pf5TPwyZfntfuAq7loIQm+HN4BwTJihQ4iJwPvkxGmFogIT1uUNA== X-Received: by 2002:a05:6a21:a34c:b0:1f5:82ae:69d1 with SMTP id adf61e73a8af0-201591ce35emr970643637.20.1744151831029; Tue, 08 Apr 2025 15:37:11 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc41af71sm7939275a12.75.2025.04.08.15.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:10 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 07/18] staging: gpib: eastwood: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:47 +0000 Message-ID: <20250408223659.187109-8-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/eastwood/fluke_gpib.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index 68f888a75edc..e1f8598e4e04 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -24,8 +24,10 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("GPIB Driver for Fluke cda devices"); =20 -static int fluke_attach_holdoff_all(struct gpib_board *board, const gpib_b= oard_config_t *config); -static int fluke_attach_holdoff_end(struct gpib_board *board, const gpib_b= oard_config_t *config); +static int fluke_attach_holdoff_all(struct gpib_board *board, + const struct gpib_board_config *config); +static int fluke_attach_holdoff_end(struct gpib_board *board, + const struct gpib_board_config *config); static void fluke_detach(struct gpib_board *board); static int fluke_config_dma(struct gpib_board *board, int output); static irqreturn_t fluke_gpib_internal_interrupt(struct gpib_board *board); @@ -943,7 +945,7 @@ static bool gpib_dma_channel_filter(struct dma_chan *ch= an, void *filter_param) return chan->chan_id =3D=3D 0; } =20 -static int fluke_attach_impl(struct gpib_board *board, const gpib_board_co= nfig_t *config, +static int fluke_attach_impl(struct gpib_board *board, const struct gpib_b= oard_config *config, unsigned int handshake_mode) { struct fluke_priv *e_priv; @@ -1049,12 +1051,12 @@ static int fluke_attach_impl(struct gpib_board *boa= rd, const gpib_board_config_t return fluke_init(e_priv, board, handshake_mode); } =20 -int fluke_attach_holdoff_all(struct gpib_board *board, const gpib_board_co= nfig_t *config) +int fluke_attach_holdoff_all(struct gpib_board *board, const struct gpib_b= oard_config *config) { return fluke_attach_impl(board, config, HR_HLDA); } =20 -int fluke_attach_holdoff_end(struct gpib_board *board, const gpib_board_co= nfig_t *config) +int fluke_attach_holdoff_end(struct gpib_board *board, const struct gpib_b= oard_config *config) { return fluke_attach_impl(board, config, HR_HLDE); } --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99F62571B9 for ; Tue, 8 Apr 2025 22:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151834; cv=none; b=UIj5rZfw+GZEwe31s34YPpCYndgv12lyrTn8g2bQFv0o/DXc2vj2bGqjA5qeOU3w74IuiWgSJLh4LeJjFgIb4RQ4x6OSmIA17rQWd7MvJeBbSgxPlLWxh27QXYwFFxCwGA4jZTbZtPYt8P626qdpz4FdVTNs6xNhBIPaJRHvaS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151834; c=relaxed/simple; bh=oA4pyrX24y1bCy2gqUioXPrzN6EHIu1R3/OUBiH3obw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JXyfW6+iEsHx2bxaRY7tOm1TQDSP7vm47l7Vs+L2w3oYsHUjPAKTcjDmHs6TEjhcQz07RSlnVWgIdHPFotjOqzxGxe2wniyu7Y49lAQzTFrvCc8XKqUX9GBxr48Xatkzj7QyPpAdq34kfbIfMvlm2mjcbIjkjpv0O9hn7JdXKj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Q9Pi3gjY; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Q9Pi3gjY" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2243803b776so85484705ad.0 for ; Tue, 08 Apr 2025 15:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151832; x=1744756632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=48CnxiwOG1VbFBlXoNHKj2YQK9a79sPTwkYUOXtTir0=; b=Q9Pi3gjY3DMBimJbLCBOxMyaVNS8ovQSE53Uj3ilCtu98ElF7e8/QlrDCW5HysMmbq VvdZYocJNCCgWgyqE2drxRfIKpxiG2o9aM4u9rI01QBgJ15g/VzNkp5+kZdxkrcDVRDd dmuHs4AJ44Wee3snHEXKGu3jI3usNiDBFOYA+mKDoXELu+Tf5NhnH5AFlzBurpx/Gism K6sz6ReuJDDCPAU04aGvoDuey1k2Qbific5S8LKRIZNutQnhWPUi3wi4QKHQLfHH9Fhw tDB/s0xtZnHqY4fsYIXGVTTEQZJC0qi8UdRMXlPikMlHPIpdTlbmxhev0QEsH1/WpdXg /cPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151832; x=1744756632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=48CnxiwOG1VbFBlXoNHKj2YQK9a79sPTwkYUOXtTir0=; b=p4hR009o/aV9NahxSEIKhbT3eOpmk4OZte4NTVebmgEQEatRdh8+gnKd9bK/JCUGsO xHeI7JAF6VVWnDLN+Mj2IQBvSyK2qW8wVKO5HIavpo8UjL+JI/uQxIpHVdyl3QoUdCzY r8dnmbvDdcswIVP4cchL+4oJg30FSTDXVZUpzImT1W8URfKC1RHVlZC1zSblRMOcVW3Q qdn+rE3Zxj1PUEme2o9GdN3/vfEBdJbVAImo/ImK6h/2elI2bGZTYyBT+3KIc8HO1pva UDl+5oCtATyZcMz9r0wwJrREMoD9bXYJlcHAK7HF9Tcu32KzO7utBfydAbD0NTZh2Q4I 1Bsw== X-Forwarded-Encrypted: i=1; AJvYcCW79zbtXUa5D+WWH+jI/Npmh5ABZfIvKxbBb9Ya7FP6Zp2IallhrFJ4/OZXir++NLmcHANvTPziaVCOpzI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr/6SQbQMpz4wiYAD5r9PNBzngogHn95t1AG7SBFk7mHMN2VUh 523xvuXz9bq+cVt6MyO7JiMtpfyP4rIH7ZsiqtodTwLXfgFnYmRG8uiDMLY9gsukGmCwf5IDWP0 = X-Gm-Gg: ASbGncstH2QXCoLxccgzN2WmIIYcunvASCbVLiK35PF14xJ+ay5tKMhpS7VdhewsnDz yiBXASyx32kdFMC3B88g36TUwi3pyOYI3LljquCHsIaPlTWEQvHLLoHvMqNdrswgMUtsBNrSDcw 95m0DA+MO1bxbMfShqb8xKGbNWcm4oVK08a3JJF4fwnUCNkoh5uMjFZryXwG+5jubhkjaLYtw2e TD6vpZzfMunfQAyy+Y66+5vJxG0BTt5eglW7JIhqc5b82Z/sxl7rJRtWLNavx7h/RRyzeFh+YsB b9F5urZOvltDlo6vRX0YYmkw888C3mycS0fV2viUPvuWDcbvwnWw7K6oaoObt2MsDqWuIUy8f2R iCAiwMFZt0g== X-Google-Smtp-Source: AGHT+IE7laCrDlkJfZ2SLpK5B8rdk0gdRJBXS0kMSGA9v+TVbdwQ5sHhRHKe4IAEWaIN+FjdabLoGw== X-Received: by 2002:a17:902:f686:b0:224:256e:5e3f with SMTP id d9443c01a7336-22ac29bc2b8mr9927275ad.25.1744151832207; Tue, 08 Apr 2025 15:37:12 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297866e132sm106704155ad.177.2025.04.08.15.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:12 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 08/18] staging: gpib: fmh: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:48 +0000 Message-ID: <20250408223659.187109-9-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 27 ++++++++++++++---------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpi= b/fmh_gpib/fmh_gpib.c index b2c379ce4c88..30fbf1065de2 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -32,13 +32,15 @@ MODULE_DESCRIPTION("GPIB Driver for fmh_gpib_core"); MODULE_AUTHOR("Frank Mori Hess "); =20 static irqreturn_t fmh_gpib_interrupt(int irq, void *arg); -static int fmh_gpib_attach_holdoff_all(struct gpib_board *board, const gpi= b_board_config_t *config); -static int fmh_gpib_attach_holdoff_end(struct gpib_board *board, const gpi= b_board_config_t *config); +static int fmh_gpib_attach_holdoff_all(struct gpib_board *board, + const struct gpib_board_config *config); +static int fmh_gpib_attach_holdoff_end(struct gpib_board *board, + const struct gpib_board_config *config); static void fmh_gpib_detach(struct gpib_board *board); static int fmh_gpib_pci_attach_holdoff_all(struct gpib_board *board, - const gpib_board_config_t *config); + const struct gpib_board_config *config); static int fmh_gpib_pci_attach_holdoff_end(struct gpib_board *board, - const gpib_board_config_t *config); + const struct gpib_board_config *config); static void fmh_gpib_pci_detach(struct gpib_board *board); static int fmh_gpib_config_dma(struct gpib_board *board, int output); static irqreturn_t fmh_gpib_internal_interrupt(struct gpib_board *board); @@ -1335,7 +1337,7 @@ static int fmh_gpib_init(struct fmh_priv *e_priv, str= uct gpib_board *board, int /* Match callback for driver_find_device */ static int fmh_gpib_device_match(struct device *dev, const void *data) { - const gpib_board_config_t *config =3D data; + const struct gpib_board_config *config =3D data; =20 if (dev_get_drvdata(dev)) return 0; @@ -1351,7 +1353,7 @@ static int fmh_gpib_device_match(struct device *dev, = const void *data) return 1; } =20 -static int fmh_gpib_attach_impl(struct gpib_board *board, const gpib_board= _config_t *config, +static int fmh_gpib_attach_impl(struct gpib_board *board, const struct gpi= b_board_config *config, unsigned int handshake_mode, int acquire_dma) { struct fmh_priv *e_priv; @@ -1454,12 +1456,12 @@ static int fmh_gpib_attach_impl(struct gpib_board *= board, const gpib_board_confi return fmh_gpib_init(e_priv, board, handshake_mode); } =20 -int fmh_gpib_attach_holdoff_all(struct gpib_board *board, const gpib_board= _config_t *config) +int fmh_gpib_attach_holdoff_all(struct gpib_board *board, const struct gpi= b_board_config *config) { return fmh_gpib_attach_impl(board, config, HR_HLDA, 0); } =20 -int fmh_gpib_attach_holdoff_end(struct gpib_board *board, const gpib_board= _config_t *config) +int fmh_gpib_attach_holdoff_end(struct gpib_board *board, const struct gpi= b_board_config *config) { return fmh_gpib_attach_impl(board, config, HR_HLDE, 1); } @@ -1497,7 +1499,8 @@ void fmh_gpib_detach(struct gpib_board *board) fmh_gpib_generic_detach(board); } =20 -static int fmh_gpib_pci_attach_impl(struct gpib_board *board, const gpib_b= oard_config_t *config, +static int fmh_gpib_pci_attach_impl(struct gpib_board *board, + const struct gpib_board_config *config, unsigned int handshake_mode) { struct fmh_priv *e_priv; @@ -1570,12 +1573,14 @@ static int fmh_gpib_pci_attach_impl(struct gpib_boa= rd *board, const gpib_board_c return fmh_gpib_init(e_priv, board, handshake_mode); } =20 -int fmh_gpib_pci_attach_holdoff_all(struct gpib_board *board, const gpib_b= oard_config_t *config) +int fmh_gpib_pci_attach_holdoff_all(struct gpib_board *board, + const struct gpib_board_config *config) { return fmh_gpib_pci_attach_impl(board, config, HR_HLDA); } =20 -int fmh_gpib_pci_attach_holdoff_end(struct gpib_board *board, const gpib_b= oard_config_t *config) +int fmh_gpib_pci_attach_holdoff_end(struct gpib_board *board, + const struct gpib_board_config *config) { int retval; struct fmh_priv *e_priv; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15D322571DB for ; Tue, 8 Apr 2025 22:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151835; cv=none; b=CZBwfEzbM3MvLnCQFMEfo7WNFbWfUCbKA3hbYbwq6hvbE8uADX4S4/6GWeHmKqhsB7N6GQcKmtPacb4qcWlsXbVvFjDzlYTMOsO/GMj9bV9S3DAe2gDRfza8c0VcMe7KR6f5SH8ATzsObAEGPMgCpqtx8k8l6jkvf54eoEwUSLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151835; c=relaxed/simple; bh=q9zf1c2z0k8nf25Gcd0LQ9hAl8FQJe2qwvY1PlNvQ7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fLvOZy4qpk+R3snylhYj6rXdV+a4vORALRJYZLcghJ5R4Jnb7NfKOpCrrscZuqwBp8mDS6CZ8gxcFEow5lMhZqvC31pe/qmxO6xAiZIF0szCixQj2U9iTZ/SR7D1bQAXIH26w9PyveFrXTIxtCX25GmopOkTHFFF/YqMZz9ZYvM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=JdiBaGX5; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="JdiBaGX5" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-736c1138ae5so6057873b3a.3 for ; Tue, 08 Apr 2025 15:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151833; x=1744756633; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FjpQj5oY//AbdRKOiO0HjQ1j1RxhGsiWjsuoiFTCEiM=; b=JdiBaGX5JVHx1wJqKZrPR//AqecEoZtMhV1ZEipusBYrwiO9e23fMf1CPbeJxugRCz q9EF0a/SppA4LTvLqA/NVIPHSosRsB8vL5GWF5ZhCDwfGMC1irXBlzY5dW5MaQwutdS5 Qe9qAqKiREP+YXMFmwLm13OGLsTkeY/pRQDVOsVAm7YbLHaVKcpzBNtbYMlIWhvEtfWv NPZt1ITqg2SVn2Y2FBijL2Fc3wI4caDPguh3kXZwd0Ls0tCoNXW7zSs0QO20Z6/0k5Wy xayea4mG7U6uO0iixVmtaDe49OTte5tMAX2sFMvp+4KD32SotET9kmojXwQVlXPtVx6U 3UVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151833; x=1744756633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FjpQj5oY//AbdRKOiO0HjQ1j1RxhGsiWjsuoiFTCEiM=; b=eMSRJwDnvp2yoz0rzZRN5DxH5wDofR9oV2WsEZxjW/umWV8F3SCCd75542QFJymoTP knn/ZOeUvHwQEHeJRVmiqxEn3qtQZz5hPEslxhdQTBAXvphzXZNwO1TS2P5jz4LZWmAT ZZvBtwtNd/ZOwBHammjVcVAIOS2SX9MdId8WREE74U90SZll8Bgzy8toW/0Usr2I6FCL 9TPpI4wFte3rlznSwyZU7aOLPguYpdxYOPsf0N4W+dGYD9zqMCj9CSNm6vAjDa8s7Duk FKK6EJ13wnFpFjSvbokaNpzDRqZGfZrC34r5NIdP+bwG4J6OeS/S3qQyJMTNiEHBYyiH Mo7g== X-Forwarded-Encrypted: i=1; AJvYcCXxVz9N+uCukX1R24msewo9njf7ITs/3yad4UXDAtR+KQAkEQrJqEv1wlgN/YxaKvUAI6q4xT4a6YQ/5SA=@vger.kernel.org X-Gm-Message-State: AOJu0YzNV1TKBTcdztBcI0Hovnn4YoeoUyR30P+2+Dt4152nTLNZ+8/K 3v4eXOV8LKirm0SbvAfvcqJwDmQS9K+9dAaTW15V62TO8kqoqgVdxWfuSt+dzA== X-Gm-Gg: ASbGncutN6soKzrYYlVA9NauEw5aNRe4yJUP4wGqBD7b084CoOr/gnRwIwjsP1Sofwy 5HhSbAI9Q2cFkLUiIA0aohDMDVgQsGT/gUz0dqrJ9jJ8eQ1wsoXhhtA72pf0f4Xkp45xGa7t+2Z sBlG60/l8CBOcYWvqVkF5XJpzjhOkaVnVT5mGZ2TeFOj9ALw6nm99q+Jaw3x4pso+4fPT4WuBzG ycfCDQKpvoCRq9FEai5U5bgPncY7qZYfxuudLxy0ywMS63rPv+sq59mFhrh4C6VLowSzIv/xvux 0vluM/qgzQhBoJs6hHD+2+b/RlJY8SsghKX2syAkNJVFnzAXtgcpUTaIoKkfRZCly0/UQ8aifJi fNcWmpcyF7S7I7RRsbFPJ X-Google-Smtp-Source: AGHT+IHcbqmqqD36HkzOjtk/zQqU6ShjZ7AuFw14mbVyYAOl6TqLnbSExYECmxIE4cpFwf43ts+GVQ== X-Received: by 2002:a05:6a21:3103:b0:1f5:6a1a:3284 with SMTP id adf61e73a8af0-2015b01ffa4mr230407637.40.1744151833350; Tue, 08 Apr 2025 15:37:13 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d9ea15d6sm11164546b3a.89.2025.04.08.15.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:13 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 09/18] staging: gpib: gpio: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:49 +0000 Message-ID: <20250408223659.187109-10-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 7e85dd29ef93..c586f739c251 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -1206,7 +1206,7 @@ static void bb_detach(struct gpib_board *board) free_private(board); } =20 -static int bb_attach(struct gpib_board *board, const gpib_board_config_t *= config) +static int bb_attach(struct gpib_board *board, const struct gpib_board_con= fig *config) { struct bb_priv *priv; int retval =3D 0; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B1F25745F for ; Tue, 8 Apr 2025 22:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151838; cv=none; b=ud16ZLdpgfDMKb37f1jw6/vyG1n7XASwptxASw7ctvXDsDjnaDSFWuJJ6GEy5tX1ZIlvqXt/2/O2s1SZwY6kLWTAyOasN4yh6sHb5DkTd7EnLPGzMxTf4DscajWupMYCSq985E9bud7qTngr0wtRHh7o7CD/CQ4CucIaSJN6AVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151838; c=relaxed/simple; bh=PXVgHVPYegdRX7cYC838pfew04kJcnGdwL8MrqFnLUk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pc07L8cchwQchboRb4SQp0lGIOBO++OgXUP/WiSLGP3Ubm+5u/RlUYWXNh8aICpHvFIkR80soO23w65f9uynkhQ6OKg2DCWDmGMRhLDCmcxjfPJQoJgBhLIdZnz9Fq4y0ZYFL8q70zSHyKj6+7J33e/bze2TJ0w5h5IAM5KmToU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Q6cn3Ad0; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Q6cn3Ad0" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-736dd9c4b40so130896b3a.0 for ; Tue, 08 Apr 2025 15:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151834; x=1744756634; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U5psd4uyYELxSqHEi4JcOM6XflshtV89daX4C/MP4ds=; b=Q6cn3Ad0cEIdD0Qjb0uHtr+Cj62oQJsgRIdvPStcY5x2Zt1/RQDIGT0yjQmSdgbR9J lQisxMMFj67C4gqoCmqbiLWtwrgShqSpKaiM+SoLf52mC32xlZkEFhSjSYTHM9isl96X UyI8+eKyUer4IxrUhPiYXW4wiDkxwUo5RyDMdApAoDoo/mu4/Tr2qIORkGCapR1IVyT3 2apTs9RTMUJGFAfWRqJ9CNL2br34vpaJEduswx3sR31yO9/nZCUodLansydK+Ak76SJN P6HjRXQPxrhn8LKykqR7r5zwq88rFHiYwSFr7c1LtY/p8uRXZh5ag3zoa5TZP7IeIfa8 9myw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151834; x=1744756634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U5psd4uyYELxSqHEi4JcOM6XflshtV89daX4C/MP4ds=; b=jUF0FgBHsDVJ3o7PRFKTh/JRC8xSLv/ndT8pZ9m7r+w2+CGwwm10W6iqinZMc8rROr SKRm3SYrvlxTNljf5f5Xuc+n1hrHYlF4R3XJI4q/h2B7atr8LIfUHWrBhA8ZpP0hYHUE wMEqBDkpmgOEUMyRKWfKmYWwTgv4x/hrxmermCYt37ccat7pe7FfFpbj9YkWXIBigLgD HORHMS+2butZFruRbZ/nh6ey7y9xI0NSR2r/7UWNPZQyEd2+6ddEvIyOpmxwcJWgnG3N +A2ojF+3XDPWQJgg34KkCKyxzPfKGopezUCA43c2pFPv0OxFw0l7ss4Mfx/wSPT3JnPi GrYw== X-Forwarded-Encrypted: i=1; AJvYcCWcU/5XYjl6yUNZOJKSfsTi4Pt1ahdygCPM+wJd2Kb7JnBWh52PF7I7CxfKFZZfe8FBK7Re0TEVQu1LF8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyqNf5M/27n/X2eSbkb+ts7/U5jrBAwuKx4nkIcxQkvDW41RQV8 H6ElALeMsPPtE/+zIzUwB6cDnAQzvwDmQ7QzfqMSd6W2Gg3Zfuh0ulWZKlf+0R27tVNzNp++QNc = X-Gm-Gg: ASbGncvGiYwSDzQETDRsBwxQtLoxX1nk1SdHpFZ6pciviw0vdZgrD17oqnMokaoRz2l fI1Ttb5nytV3ninkSW/bwDDYH8sZ2+AAFAuNiMZM1BL7RoCaUo8NMoKev0DILdZbeQX/HfvLOds 58K99H4/6wJ/r32ZAuDNve9W4a60qxDlpSrxRLNLc/VPsnnlZcqKERh7xchkHAfdoj5rmB3BMkg oiJti7KkvPlxSbInpONnndk3CwVMPyGC5liFf6qMkccLTqGVTElLgygs+Y5KVW/v2hgP5glR5Ez yLpY+FD6evfiSsqEBSdrgWc3YeI8Y2oa5JJhDIWcDPCuMsqWlnxoThRCGRHbASzgojjX1rIGg/a MOh7BmeAaBr03mumN9166 X-Google-Smtp-Source: AGHT+IH5nHu6Q9oriNtPHT59BEfzZVatsCeFr84A/ulxraBO/exrM7YRAFjTVfIAYkkRu95gUGqlrA== X-Received: by 2002:a05:6a21:910c:b0:1db:822f:36d8 with SMTP id adf61e73a8af0-20158d9ae12mr1016266637.3.1744151834543; Tue, 08 Apr 2025 15:37:14 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc34eefesm9539344a12.36.2025.04.08.15.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:14 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 10/18] staging: gpib: hp_82335: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:50 +0000 Message-ID: <20250408223659.187109-11-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82335/hp82335.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib= /hp_82335/hp82335.c index 1a93a456f7bd..32b3aba673d9 100644 --- a/drivers/staging/gpib/hp_82335/hp82335.c +++ b/drivers/staging/gpib/hp_82335/hp82335.c @@ -24,7 +24,7 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("GPIB driver for HP 82335 interface cards"); =20 -static int hp82335_attach(struct gpib_board *board, const gpib_board_confi= g_t *config); +static int hp82335_attach(struct gpib_board *board, const struct gpib_boar= d_config *config); static void hp82335_detach(struct gpib_board *board); static irqreturn_t hp82335_interrupt(int irq, void *arg); =20 @@ -243,7 +243,7 @@ static void hp82335_clear_interrupt(struct hp82335_priv= *hp_priv) writeb(0, tms_priv->mmiobase + HPREG_INTR_CLEAR); } =20 -static int hp82335_attach(struct gpib_board *board, const gpib_board_confi= g_t *config) +static int hp82335_attach(struct gpib_board *board, const struct gpib_boar= d_config *config) { struct hp82335_priv *hp_priv; struct tms9914_priv *tms_priv; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B83257AC1 for ; Tue, 8 Apr 2025 22:37:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151837; cv=none; b=G3uAa1h1KdctadLc7fUmJWzMh+Na09gTYA5MuTpNh7FZsQtELXDsk+2Y9cSCWUWuFXidH4nH5FA2jF7zL0QgVPfM1Gcw30Fb5zrrpD/J2GY9nVCD9klVMDurtLUBFE9lKZg/+PreFCr4yZVVqu3mdSgDG34KrQohOVsLngBJdkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151837; c=relaxed/simple; bh=3gUtVacJwPKBgpo4kagQdtl4FHHCzSx2FeviI3WLXV4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ui2Ova+Kup9DHzUlNgndLMDVrWJ8375MtpOVjfcrfQCmBT/I9nzFXDfHNMNwCpa0PR4EQCrH6/6bZnc3ifXAV2R+3PxiAl602KjBpCiu1Ts2pv0uIzdKB9beBRt19Wnx2b7pOGBBCpc/Ilg5kJedWEBm2Zk1FJ7xYuN35uBuxiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=hh+xHzU+; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="hh+xHzU+" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7390d21bb1cso5967330b3a.2 for ; Tue, 08 Apr 2025 15:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151835; x=1744756635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0HA0A/F9wdD3qtvPDerH40ZSpT7NQGhe4df1MFgMzz4=; b=hh+xHzU++UhATjLjQwUNgR2O4ZozQp25dulQHSOj1Sre6V5//nTYQqXjm+zNqdwABm RU48ZJpaOb3JZ6m3+MSK/mchOeD/M5L20Su1KeAMTjg/jItm1vrvT2sFSYS0frjIayQK KR+SNlZgU1rec+ibALWyQKvwk6PmVrNYajc+VZQuDhTZt7jh0BRHkY88I6fiosjQw4od uV9xltshO7EFMYDlNHOFfdj+Zg54LZLT+rt4OubhOIVNhPPmABojoByER45nGG9UGKy5 nfHuxy9u+h+CeVEk/0ZLABAcNOaCOO14kSGJimE4MLg4u+iLFqbcgKEnznvkwV+pL99R VXSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151835; x=1744756635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0HA0A/F9wdD3qtvPDerH40ZSpT7NQGhe4df1MFgMzz4=; b=S7tkcqJ/9qL42trKaQiE0T7iBw871yKvOt294Kcw5ILIE2/lAgsS/2UYlR1oNRuDVC 5Ofgf+eZP0BQU/m+zvRWciTD1ONDhyFyfiXtw1Adyyu1DmT/0KxmzyDXvxeWvx2dfDHL 2JbGk6G1j6JSSlI1OThbY7Tu5dkJvuOLraCRdYZVZ2ExxTvtzIDZA31DE6vSA6efsn9a loraa4n/m3waVxjOcckC8exkfp8+1hdJ/KHD9M/RF6zrGOKl8WLF77n9J1djtBgQu5Ob TXqxKrOVBbdJdU5jmqvWhIDnvt8ZDNdaXL68vK5sE9r7pWtjZi4pjT3NbQUxqb5V1cLC 8kaA== X-Forwarded-Encrypted: i=1; AJvYcCUA4ooa/OaXVCN88dAxQ/ykyWjys5t/2nBEOQrNWeYI/DCTGXk06Cc9WbS4ekErG/pqJAeqD8qoCj5MztE=@vger.kernel.org X-Gm-Message-State: AOJu0YwQUOSuPZi3T2p+5gk5qFPZnEsk65/dKn8tOeSBfZBqqUYTv8w9 GeAb1kDvTcASwDMYHD3qXcvfS9jDNjov1yzOZNa880K15rOdXwuDeZZqGedt7g== X-Gm-Gg: ASbGncswO/KXgd5FD6mejMMwArpeJbwOWeKLNw3980XrzOjDg+6Nvhm8fsSQUmf12r1 IJ/KTHnCn2z7jEfsyuDpMaFlAL10b5NT9MfzdE5CnJM6AcTFl/NVctseRECICQy3f9ZAeF78la5 mqRF03GJXnp4iN/j3l0yUIOnIhRIGZwCNnc7qxy9ZJh1rBahG02YK4RvaTtsJ7GEEza3WESL54Y HQjJYS6PolaPM3qStNRsP4AjN1j5cliA30Z795kn1/Ow4dbLmMsEYhmPMyJlhv4d7CSrE147yTu XMJVwiDfQSBnNcEPKLqi+Zkcee0odHTDq8yKJIL1xh9wzIfXGaiwWGveBpiG1HB/htXkNyBs2zC BZkNUba+E2Q== X-Google-Smtp-Source: AGHT+IEDi/FjKYvlTIxDwvfbDp3AA+CHNnv8e0pqSC+FVoN7hv3SGTobPGucbuwf9xOEIMYmPPYxig== X-Received: by 2002:a05:6a20:6f90:b0:1f3:3690:bf32 with SMTP id adf61e73a8af0-20159190bd2mr954354637.18.1744151835638; Tue, 08 Apr 2025 15:37:15 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc2cffffsm9592187a12.13.2025.04.08.15.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:15 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 11/18] staging: gpib: hp_82341: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:51 +0000 Message-ID: <20250408223659.187109-12-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82341/hp_82341.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpi= b/hp_82341/hp_82341.c index 775103d744ba..f2306245ce4c 100644 --- a/drivers/staging/gpib/hp_82341/hp_82341.c +++ b/drivers/staging/gpib/hp_82341/hp_82341.c @@ -250,7 +250,7 @@ static int hp_82341_accel_write(struct gpib_board *boar= d, uint8_t *buffer, size_ return 0; } =20 -static int hp_82341_attach(struct gpib_board *board, const gpib_board_conf= ig_t *config); +static int hp_82341_attach(struct gpib_board *board, const struct gpib_boa= rd_config *config); =20 static void hp_82341_detach(struct gpib_board *board); =20 @@ -619,7 +619,8 @@ static int hp_82341_load_firmware_array(struct hp_82341= _priv *hp_priv, return 0; } =20 -static int hp_82341_load_firmware(struct hp_82341_priv *hp_priv, const gpi= b_board_config_t *config) +static int hp_82341_load_firmware(struct hp_82341_priv *hp_priv, + const struct gpib_board_config *config) { if (config->init_data_length =3D=3D 0) { if (xilinx_done(hp_priv)) @@ -686,7 +687,7 @@ static int clear_xilinx(struct hp_82341_priv *hp_priv) return 0; } =20 -static int hp_82341_attach(struct gpib_board *board, const gpib_board_conf= ig_t *config) +static int hp_82341_attach(struct gpib_board *board, const struct gpib_boa= rd_config *config) { struct hp_82341_priv *hp_priv; struct tms9914_priv *tms_priv; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F419257AFB for ; Tue, 8 Apr 2025 22:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151838; cv=none; b=BZ01keKaLJpKvBW0vOTaQtU6QchXcnvt/U/IVM+UmfEbRKKipmIBDcgV4sj4fuC2QYlNSPGipa0ZaWvXaFSpjezuJjrCyxvFzGI+8BRXe2HGs1H9m1LM5UOKjfHEbQTcFj29JoOXWDViN/s+Y0Nkl1gtJqxhYkTJN0gqETkncqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151838; c=relaxed/simple; bh=9iwshM7hWyj+34mNfcFVZWAX9kiRF0QdbJ5coR1x4Z0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LbtRarhNA1WrDqU9L9elbP01+qqoHhppP1jhrZLNvH+4P8wZ26kb0Pfn5AiAF0EvTzxfkFCk3IMyTET6QyYLHmaAQuTvuynLZxr0qkGiMqXiNQ3HrPCJ8wCp3ugCCGTfPnLTAPRFqn0GX69eAH5mRbPvHhHXkcxskbKCtJJzLA8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=IypTDVvX; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="IypTDVvX" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-736bfa487c3so5214386b3a.1 for ; Tue, 08 Apr 2025 15:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151837; x=1744756637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jxc+vuThRPlr4vVmJwstL+y+K8nrAD8PwkhX56e3dqU=; b=IypTDVvXNP+RNk0cvr0zujoPiC+iLzx1YmyyslsCgEGOnsy4OSrpPH/IYDHYj8yLS+ 3hHdH/p23NiBv5XaSG/v0nSjbyPKY2a4Mlu5A9hF3OE7U4jPtdGrm3gwjnRc1xIC/Otp VdJnm5c5Gm4qBX7WHwIHCSm4a23cbbbF5MS9cdtQfEGnG8jmMtXRtWYUkYGQMp/oejN8 urKb8Vu5/fWE6GQnbRftZv/vpd+OGSDwooXKyXMOAuoj3Op7KriBRULMa1LUPf5pBUkN GNcb+LOB1peN7InuGjuhptaE3ijf/9JWjzgZ8IymDgTLskG+SBIaabuKhm6Tq55KhQVp XwJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151837; x=1744756637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jxc+vuThRPlr4vVmJwstL+y+K8nrAD8PwkhX56e3dqU=; b=MXbnH+tqh5I23na+Y0OxJp9XCPFiT/eLYSMwIXwxlHmxv7l94USJw/H5zFYlLjF/DI d7Hoxgk8GIuSbMD7vcsYfdF+vb1hUO2xgnaMf+ay2MYOCgDv4rr+drTJ9xJzHSG/2ER/ 3oXUv7L0vKw3FGFsa/hEbVNsI7ntqMCxzF64q0VKs2VKK8V/gabg+TQ/1DWyC7VIjrZX VVO1snfo72JXakp8A3dWXcXI8WlR+A7lZ+uvcA15TOpfc/zhC0daJsMsrvaKMuDmz1cP 0DrT/meF5nwdmx148mm0cYlQ4FYRmmAbywqcC0AqwcwC48FpMihz/ZVW6F/3D4woH2wP BSzQ== X-Forwarded-Encrypted: i=1; AJvYcCU6F4oEOIFWWRZCxWg9F0/Zv4nZ8Mqd2g2ozV+EA/X5bfD2R6mTyBUxHoh6KmwF2Qu64EpVqMgnA3yeuUE=@vger.kernel.org X-Gm-Message-State: AOJu0YzAI696IFj8xhdzAz747vSuXhrk6DTJUEfQhGANnXhNZAXcUUuw /qxOFXxCQ9psgjucDwyuaoE5pxFwGCDqqwQiAqvjMoRgEhalhiT5FpbHUoh/lQ== X-Gm-Gg: ASbGncv9MvyZ7gc0PzjRlxMsGlpnr97jZ4jZmLlX8F0ra5vvLb/cJaarhmI8BqHDYch 3uMpDF70UUyxcnVIoLQt0LMamdseKoDvYRHTYXEE7O+PuVJtwwM0ZOFx6sUC7u/6fOEubrzmr7J BFiCAZqRzQO3EaV6SCAfrUyd+yFqpiwvR2dk8zil4UExRD8i5iF/K6PIhsSPCLQ9G6Ilde5yvFB +cX7TLxalOczTMHUxclp1YJ/LwQLwlvHerCF6wmtInFmJvAFdlZDyjSVbRFyVEpGo3D+2v6RE1d j1Df1upnmw4aJxZ7ramY6UbqnL+p6Ct6WEnH1XKV5ESoQme5u5G0Pt1HTNMBFWh0J//Ss2F3ivx u/HijH/Mnww== X-Google-Smtp-Source: AGHT+IHPoxf9asXBsP5DpMwhkaYv3aLdgjJ1ArC1Vg1k1/0iauyZJVN+qs3CvfAuWNHRW1id8Z6R4g== X-Received: by 2002:a05:6a00:238a:b0:730:9946:5973 with SMTP id d2e1a72fcca58-73bafbc6a32mr234006b3a.5.1744151836772; Tue, 08 Apr 2025 15:37:16 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739da0e3745sm11527953b3a.172.2025.04.08.15.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:16 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 12/18] staging: gpib: gpibP: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:52 +0000 Message-ID: <20250408223659.187109-13-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpibP.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/in= clude/gpibP.h index 82627ca838e2..c9cd1dbd7e6f 100644 --- a/drivers/staging/gpib/include/gpibP.h +++ b/drivers/staging/gpib/include/gpibP.h @@ -20,9 +20,9 @@ =20 int gpib_register_driver(struct gpib_interface *interface, struct module *= mod); void gpib_unregister_driver(struct gpib_interface *interface); -struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, uns= igned int vendor_id, +struct pci_dev *gpib_pci_get_device(const struct gpib_board_config *config= , unsigned int vendor_id, unsigned int device_id, struct pci_dev *from); -struct pci_dev *gpib_pci_get_subsys(const gpib_board_config_t *config, uns= igned int vendor_id, +struct pci_dev *gpib_pci_get_subsys(const struct gpib_board_config *config= , unsigned int vendor_id, unsigned int device_id, unsigned int ss_vendor, unsigned int ss_device, struct pci_dev *from); unsigned int num_gpib_events(const gpib_event_queue_t *queue); --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A396D2586C8 for ; Tue, 8 Apr 2025 22:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151841; cv=none; b=nKvVdNESCSchkBaBbojmmR1NMqsP83gFjloCYJKLYP0zIPaId0Q47ap1SoJj6NQrKo4b4i9k58wtSYBLi8ghMVaiYUK7UBVk7AploRnfVygzwL5mdJTL0o8t8ZQPpDYFEtOKquBsyytCgs+JnT+nkTU5mPqh5XlkQ2lYlWwwTT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151841; c=relaxed/simple; bh=RW9AE3t0A0nclxnXdLPGn5ZCeaheNjUQ/Msgs2FG9JA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e1s61KAK6zseszk4IwzqfgZ4aEXDEmk5lxj5Hws38k7a9RwHc9bKv4ZfPQD9hZHGWEvg3I5G0lyMazalpIOjcWu4HyP8RzJEJmsL254JaTl2gyzL+JNKvxPYHyvVYy1/Xgv73jFLf2iW6u7RcZXcbtrNn4kiRQIDpbVqa0Bn6W8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=LAQ3PbuA; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="LAQ3PbuA" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7376dd56f60so4483332b3a.3 for ; Tue, 08 Apr 2025 15:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151838; x=1744756638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=stUd2WZ8fQWzt1BDAw39EfCCVY0bEu1A4avlNZzjbAc=; b=LAQ3PbuAaE7L3KfNv1j8v/cargK/xbBzOs9IJnimJ7WBpB/Gz5SVSNBXAey0616Jtn d+0fQHDpY4IKjSXlB9QqR870zuV0yIbQ7PqVIbs3f+gKMEYWJNgATS0C8A97/bDk+MPV Q3Z7NWLyFIlce13MYjn7dlTf5OgM7c2/U1/lIF95gBNyNrasJFNV0iXvwHe2dzuDAOe3 jdWBTrIkw24ujGtRBhoghWKECW0Ep4uEwZv+NukqtB3fuAwlP7JXC/D/hiajhw47nRG4 ArV/6aE9466wpMqIJoRZ+QtrASwiisO88Pnn4YEZIQINfLicEEUwyG1zLv+LQ02B7K2Z Ammw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151838; x=1744756638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=stUd2WZ8fQWzt1BDAw39EfCCVY0bEu1A4avlNZzjbAc=; b=oUWW0fpqgTdJr+E9CO3/BeMf90Aisna98KwmSlt38amoDeutqSPcBe6/5AKGJiMlwH 0KOn8Li46AdWH5MFTpVkprgyJn2ToTKsVeG/qPYoIumRmYo4Tvg4gwpvz1oXQoaJwwmf Dz9ZIlSvBmeaagtv3XkQi3DyzuGT4KE+BAmsUiqY5WSBsoiojpUVGx+mGodgOJ7kOPug jB2yqgBePdNMh4lKM7usdEAfsQcetbJtw0On9yLIJ4tu684gBlCskRBZIs+hpqtEX7qE o5sEnaTzEsmt6EyyAOP9IjnDqn4daETU9ERYXKvBYd1lY2zwYs7i5wi0+qSXgp/Rm3ju LYtw== X-Forwarded-Encrypted: i=1; AJvYcCUWiucM0J2fmHuPtgt963RnLmo+EinYG2rJNgeo1oMDyINYC+4QWiwjO8K8YeZ62uGr+omdn/t/3FwMw74=@vger.kernel.org X-Gm-Message-State: AOJu0YyZJ+CVqGsHe3IiPpQw8WQe58u19wBuoDdtXPJkp8htOOUSY27L 7o2i5t+p3+M8w3WdJTTfjhBi0itdMfFhfUnWWdPTwDC96PH1JjcxZGF2bTs14Q== X-Gm-Gg: ASbGnctal2DHi/mLN/5qY75Eal4xh9cAVjwA6L3LEei1oCBRm/ih94bpJbg+RdUky0w ynlt8fzD+a16CRHhGRRRsPBO0eCqlnqAk/BwPp4H9RzeXDA8ol9VUirfmfmmCKyfdR4vGOSdrUF lpz0HzIdOppG148yKBa+kqmZMwxUN4qfOAQvNTNH+DwdpIAYkA9RpadfknUtPq+xa2eQT/8lbKO AOggS9nCpMuUxVrrXiGmpXOpKxnpy2KFa/ALT2kGqyHHHNVhqohsCaoJF33OA/WY21NGS8cUo5i W9onP+QkGHaMppFH58qE+TKjY885+Wpp2QPbtlHe36tospnOQJ7RLc2JNLv2pvxmZ4jYoSH0UKb D3Xem9wWWevx8fgU9b/q0 X-Google-Smtp-Source: AGHT+IEIYVhP2MSndFPC+gXp2gzhNla26uI6gXcVMRyQXuC0vBzRQHC29Z3GNUYLJzjclt3EoRCFjw== X-Received: by 2002:a05:6a21:78e:b0:1f5:8f65:a6e4 with SMTP id adf61e73a8af0-2015914ca0bmr1080103637.7.1744151837884; Tue, 08 Apr 2025 15:37:17 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee7a0sm11100513b3a.41.2025.04.08.15.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:17 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 13/18] staging: gpib: ines: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:53 +0000 Message-ID: <20250408223659.187109-14-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ines/ines_gpib.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/i= nes/ines_gpib.c index 7d53f6592845..3b7c8fc0f2e8 100644 --- a/drivers/staging/gpib/ines/ines_gpib.c +++ b/drivers/staging/gpib/ines/ines_gpib.c @@ -313,9 +313,9 @@ irqreturn_t ines_interrupt(struct gpib_board *board) return IRQ_HANDLED; } =20 -static int ines_pci_attach(struct gpib_board *board, const gpib_board_conf= ig_t *config); -static int ines_pci_accel_attach(struct gpib_board *board, const gpib_boar= d_config_t *config); -static int ines_isa_attach(struct gpib_board *board, const gpib_board_conf= ig_t *config); +static int ines_pci_attach(struct gpib_board *board, const struct gpib_boa= rd_config *config); +static int ines_pci_accel_attach(struct gpib_board *board, const struct gp= ib_board_config *config); +static int ines_isa_attach(struct gpib_board *board, const struct gpib_boa= rd_config *config); =20 static void ines_pci_detach(struct gpib_board *board); static void ines_isa_detach(struct gpib_board *board); @@ -724,7 +724,7 @@ void ines_online(struct ines_priv *ines_priv, const str= uct gpib_board *board, in nec7210_set_reg_bits(nec_priv, IMR1, HR_DOIE | HR_DIIE, 0); } =20 -static int ines_common_pci_attach(struct gpib_board *board, const gpib_boa= rd_config_t *config) +static int ines_common_pci_attach(struct gpib_board *board, const struct g= pib_board_config *config) { struct ines_priv *ines_priv; struct nec7210_priv *nec_priv; @@ -852,7 +852,7 @@ static int ines_common_pci_attach(struct gpib_board *bo= ard, const gpib_board_con return 0; } =20 -int ines_pci_attach(struct gpib_board *board, const gpib_board_config_t *c= onfig) +int ines_pci_attach(struct gpib_board *board, const struct gpib_board_conf= ig *config) { struct ines_priv *ines_priv; int retval; @@ -867,7 +867,7 @@ int ines_pci_attach(struct gpib_board *board, const gpi= b_board_config_t *config) return 0; } =20 -int ines_pci_accel_attach(struct gpib_board *board, const gpib_board_confi= g_t *config) +int ines_pci_accel_attach(struct gpib_board *board, const struct gpib_boar= d_config *config) { struct ines_priv *ines_priv; int retval; @@ -884,7 +884,7 @@ int ines_pci_accel_attach(struct gpib_board *board, con= st gpib_board_config_t *c =20 static const int ines_isa_iosize =3D 0x20; =20 -int ines_isa_attach(struct gpib_board *board, const gpib_board_config_t *c= onfig) +int ines_isa_attach(struct gpib_board *board, const struct gpib_board_conf= ig *config) { struct ines_priv *ines_priv; struct nec7210_priv *nec_priv; @@ -1000,8 +1000,9 @@ static const int ines_pcmcia_iosize =3D 0x20; =20 static int ines_gpib_config(struct pcmcia_device *link); static void ines_gpib_release(struct pcmcia_device *link); -static int ines_pcmcia_attach(struct gpib_board *board, const gpib_board_c= onfig_t *config); -static int ines_pcmcia_accel_attach(struct gpib_board *board, const gpib_b= oard_config_t *config); +static int ines_pcmcia_attach(struct gpib_board *board, const struct gpib_= board_config *config); +static int ines_pcmcia_accel_attach(struct gpib_board *board, + const struct gpib_board_config *config); static void ines_pcmcia_detach(struct gpib_board *board); static irqreturn_t ines_pcmcia_interrupt(int irq, void *arg); static int ines_common_pcmcia_attach(struct gpib_board *board); @@ -1345,7 +1346,7 @@ int ines_common_pcmcia_attach(struct gpib_board *boar= d) return 0; } =20 -int ines_pcmcia_attach(struct gpib_board *board, const gpib_board_config_t= *config) +int ines_pcmcia_attach(struct gpib_board *board, const struct gpib_board_c= onfig *config) { struct ines_priv *ines_priv; int retval; @@ -1360,7 +1361,7 @@ int ines_pcmcia_attach(struct gpib_board *board, cons= t gpib_board_config_t *conf return 0; } =20 -int ines_pcmcia_accel_attach(struct gpib_board *board, const gpib_board_co= nfig_t *config) +int ines_pcmcia_accel_attach(struct gpib_board *board, const struct gpib_b= oard_config *config) { struct ines_priv *ines_priv; int retval; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB200258CCC for ; Tue, 8 Apr 2025 22:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151842; cv=none; b=irecrt7GZWVbX3Ff9ggmAXOqdMjpJ3snxaKpZ4ihGqjA8vDi2z+z5EW7GHF8y07g5Q2mPrfzbHGnP5PF0jSP5B70m18Ey90EXmrUgO/Ry5DQWBQngsuUJVjeOdDMvHdSI0qSSGoZoa070s2saMOhGZcTDcYGSEPKP+XaX6Ewo3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151842; c=relaxed/simple; bh=7F6FhaL4ogWcnxhKShNpnm/dYuOadJGedBmOtrq5hbw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cTJ49nVrEi5rHXqGCXGir51paarN645VD4MhZon7X6vZd/6aplsaR5NqWPULgv2Z8Qc1sb4Lcf+sZjIr+nQKxP7r+yBJosgDh+6sYDyCQbeTUXUS3H8WcGWC4QBc2CXBCy/yrQ/svsj/Y5p0h2aB7Z03Mito7/ZX+OCA5Su0BKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=nIM4EUgv; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="nIM4EUgv" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-736e52948ebso7147473b3a.1 for ; Tue, 08 Apr 2025 15:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151839; x=1744756639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O+kyrdUmFMRxwM7TLfTUq/Q5pqKH9DQRyxYg9eWRSlc=; b=nIM4EUgvUtyeeqTNSpnTYKHu4TS4y5fupONmvxG5cPMi4Axrh6PckcesYZjdtxrKl6 Mak5HIlGVB7KVOwRS4KFpmbSh21GiGdJBC18OgDcHOYdPYXMu0jwliffggit2luqXblM 6/LUKMmqj+RHrd+TSvprjYynzHg8liua26AnFjRRRKM/dJcWznO7HhjftgcO/crD3/Ar yRAQbjQdLTXpBfg7rkkGKAH5gDMMjA/t/JORTmswS5epBWEJ75dM5bXU79EgLxXgzbQY ZLV3kAiO1u5/xtjm3ixjrKQx3jV7V7Dn3S94ljz85wiKBjEwXSUPQMhaJmHebKjwBEGb F0tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151839; x=1744756639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+kyrdUmFMRxwM7TLfTUq/Q5pqKH9DQRyxYg9eWRSlc=; b=NS4kTs1F3GO9NO6hhFygEvrKUo+9pMgWXg7LUaHSfuAdzglVwoHZNyPzNHdqbUpbRj jlwUg2v9T8x4rPJatUSsisARonbvVL4o60DBf+aqN1a08ze21fCJC2RBRmFbF5MP84hT y4ckg60sYS8ihRLx1V42W0Oj3bx7XNAn2XpdCPpAnpBCBIowpVTwxF0+jDEr/0l5rSvk T5w8JGOugnxgHpFKqtg2aYPUgOJmQkYzGxrYNzx9zTetCB0Ath1Add8OIxfbUT77DcPW JmAxF44qEfabbgLBZlp+sUGBTYbCvtobRc4DeytDqNW/yZRUrtHykjxrao0vgQPAUV2J JnGw== X-Forwarded-Encrypted: i=1; AJvYcCVbhqgdydQCeZngpoZKqUqEjRLDWxG28QLtfHF3fVRDuKk3fmcu/DjqTu0aMz2JIGWeHebXj7ul7h/97dQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx28s0ZUy5Eack6SIO2Fj1UPnke9gqAyfCvl4koyixlOdDITzsf O6w+lQkJauiKCIaz/r9Tk8q1AhIMecH9Fwa3Wb/G/FppZlqF4ItS0Et13KCHEg== X-Gm-Gg: ASbGncuyk2kg+NRxIfW7tzXVCZbDNWFkZgKCxYfjFt5nUi+Kc2DMpa4cLc2YR3vMqmQ CweeH4mcukZGH0dReLxb7mStWKcfliZZQF/qDIShibaHxg8BuCXsEodiuTT0U7cy7Ecp7mJU4GS ma6QOrzQBa/e58zOZyljmdnHME2A57XYYFHxri+Pi/sl3+L9DpzWTSN/Umf0V3V2GAe8jRoizRg lgNyBIYJM/m/+SlXaFPPVupis62BNcrIqIgFZWaqXpXM17vr9z9dVtruCS/eoKvJ8uYyFdEF2ur gtE/jCD7jM43gj13KSil7uoz79MyWaDhEZv9Bb8y+W8jhvO0xEH41+h9H8gY42IBy0r5abLjUc6 04/4K9uUWkJrqs1DsPyF+ X-Google-Smtp-Source: AGHT+IEHQS9JC2mKiQHcrs2AcKO96cjryH9ihDw9UUcv5vUP+SgmmoGFg6vz1axdsS/RsAHlHf0rXg== X-Received: by 2002:a05:6a00:ace:b0:736:4b85:ee05 with SMTP id d2e1a72fcca58-73bae4d84f6mr799363b3a.11.1744151839039; Tue, 08 Apr 2025 15:37:19 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee90asm11550584b3a.57.2025.04.08.15.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:18 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 14/18] staging: gpib: lpvo_usb: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:54 +0000 Message-ID: <20250408223659.187109-15-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index a4bfa95357bd..fa185171cc69 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -384,7 +384,7 @@ static void set_timeout(struct gpib_board *board) * detach() will be called. Always. */ =20 -static int usb_gpib_attach(struct gpib_board *board, const gpib_board_conf= ig_t *config) +static int usb_gpib_attach(struct gpib_board *board, const struct gpib_boa= rd_config *config) { int retval, j; u32 base =3D config->ibbase; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C73CB258CD1 for ; Tue, 8 Apr 2025 22:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151842; cv=none; b=pXBZUzLCvOvgVajduM5ytCi1wz2HX3LgDRJM5/gFY9VC46SGVOAR/dzSPD3wrw1WYHZwcdzQ4PLf5NQJoqehYrkOZZcf8CkIQWsk4SirsySRx9ABYGUcpDDtVsWWfYPWzRKwWJrCIDuI2nYQCdPwLLgth4PqcmKfIxn1wWR68dg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151842; c=relaxed/simple; bh=Kue1YlVh5HQ6MZ9KbyBy0zFILN9rzFtinUOFKsVUXPg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IAlIu4eeFlQpjAHnZOBX6BRJrZyWLfHIUovyCcR6TJeF+VMFHl3FKLfrNii6iMULvf5WY1MJOf4yyKkK8jYDef4ysPCXALsTBSlsx5gcuAe2Xf0FIzA+x+AiijQXYMVRQWwkdqBUA82mJAcsR9SBkfFSOjoAPEMx5LnW5dLdod4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=EogeYUMb; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="EogeYUMb" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-223fb0f619dso62025745ad.1 for ; Tue, 08 Apr 2025 15:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151840; x=1744756640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kB2MgTLPOg3pPg2tpudFygtBvxmFhbXJLI5jNKtriLI=; b=EogeYUMbBFQfqpka1eIGPmtODDh+EqAw0dCUWlvx/FG8K/K5NBw18eDf+ikwuAU7px thBkumhI5Cnij36PayCHdFP/irlqsc5nDx/NCZt68aKfRUjcotin9+0h9H9anGNHbmxo qv2Hlsoj3vEgrKLC0zJn12uyT0WbjVB9/TYs/qYvQyoai54KsttF/DeQoXX43ZhVDXGI wK8NwnpqMYa6W7ZGTpcoIoKWp+oJKefuN5P1BKJK0m0jBhQ23Ffdu9UNBF0U8P8Qt1aN Z9gh43v1Qz7ma1FN/KD8xMkQJ4EcTP33ZM+DOf058lBq4UE6yacPKbPPS4pZrzE7A8vB lbKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151840; x=1744756640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kB2MgTLPOg3pPg2tpudFygtBvxmFhbXJLI5jNKtriLI=; b=MVL4SEg25CiqSqy2yByDCh3lhbG1zrW7CVT2RVgPjqyivpkjvMG2i8waVf68JZzehK 6msA1fW6LVTmR01+ZisXkbnGVZdnPIPX2dMfcgI6JFWNnzS0Vli+hR6+9YeAmE8qxCPs fZLVpTg0e+2Jxt9Ew9igdqS/VVQZCo5NYEDUSQc696U4ACqmvuwKlBW4kmvp6I2J+nap DkHHIabPdwHqR0+tpmPEo+NH55zDtWpppNsxr0i1DEtULNxlLZtCOvCVjajkZGUo4kkM T4p46SkSMOIFzrjFRCM3OQ/8WAJIKf2x736uiVfQf1gjDsHks3nr0UFujowpJHLjgEQR nn1g== X-Forwarded-Encrypted: i=1; AJvYcCXPaRA7f1OYJhmxcbH5JS5doph+zZooMLU1c8dnCJPQs+FepGzkySdbYmIKNuCZi7W2TeJW98kaxAnrmJg=@vger.kernel.org X-Gm-Message-State: AOJu0YwGkT1zdBrAWQQtR6hszOePGjsT5nWQ05Dw4cN9WfEASnCjDnyj p8EhLwBwNTWRlQVWflasZWk70UDS9SEL/TewDyamOJ3fNQ8rvL/wL+k0UxXRvw== X-Gm-Gg: ASbGncsVg2dJXb0oFMcnyV8OkpuE1NlpXnMMldmMrwCS5YBoiVU68Uo1dhS1VGob0Um 3QYQjF/+gcnGjfE1pRkHCpS1QxFdqQJYiIGsoANntRsvCCSTUpxRPdonE7NjDnUXPzYQRT5RTLe T3fMekNlSqyYad8GxG+EIhefil8ZmIcKR7M4Ce1A2pJnYUQW/U/dSWYpgT5CgitepDcGa5kb3SE Qxkc+7UVzC0SQziykHfEW21nyF3rQru3xRX7WhrcRI+EmN73yP63LkVwAbDKpDGzZPoaaNv0pZ3 msZYL6DPA3zgYWsrHO3YvVNAFhBuGefwrkqlp9VJhOelprga0D62JCAfB6sQQU2D/bYA0Q1ot/x oYgBQHhF8ng== X-Google-Smtp-Source: AGHT+IF/LhpWwMnphsjseFvk30r3OAklQBg0/w4MfdfcQxpCTgbt/coJs3EOaBBq1W77mCq/aWFuVA== X-Received: by 2002:a17:902:f60c:b0:220:fce7:d3a6 with SMTP id d9443c01a7336-22ac29ad1b1mr12606075ad.23.1744151840150; Tue, 08 Apr 2025 15:37:20 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785adaf9sm106830845ad.27.2025.04.08.15.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:19 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 15/18] staging: gpib: ni_usb: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:55 +0000 Message-ID: <20250408223659.187109-16-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.c index 715848a3bb75..93975cd7e5b6 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -2198,14 +2198,14 @@ static int ni_usb_hs_plus_extra_init(struct ni_usb_= priv *ni_priv) } =20 static inline int ni_usb_device_match(struct usb_interface *interface, - const gpib_board_config_t *config) + const struct gpib_board_config *config) { if (gpib_match_device_path(&interface->dev, config->device_path) =3D=3D 0) return 0; return 1; } =20 -static int ni_usb_attach(struct gpib_board *board, const gpib_board_config= _t *config) +static int ni_usb_attach(struct gpib_board *board, const struct gpib_board= _config *config) { int retval; int i, index; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F29CF258CEE for ; Tue, 8 Apr 2025 22:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151843; cv=none; b=ceLr7/LMBv72J8uEwrrh7b2gaxeXrODIYbZuOAB07aqyWnOxH59Bxah0v1f8WVIr3S6eHUGwM//9bVOS+iS7WIybQjP0c8kl8JmqqxMZ68rmVZxRLdp0AVbGROll6QZ0sc+pwgHX/s3/O5SZVwMdMvm7QQVX16HQUlUbFfsOSI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151843; c=relaxed/simple; bh=Wdr5k+Zv79hAW36cz3jZ7Cu4GyzR4W+0t8T3mR5lLAI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HBRh6njVXNRYKmra2J20/+Q0VVaEJHdpLoZRUBLFUu/j1gInBbv354GBgdeUVHrpxZXLLTqETxuK933jmQKwodMS+Q897d75FsW/neQeeEoSiRp16QmnXUUuTq9dJilFRKirVzy2zUvJ7SWYl8Y4jv7Yys5MfVGr5LoDddUvvOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=l1VvtCb2; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="l1VvtCb2" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7376dd56f8fso7432149b3a.2 for ; Tue, 08 Apr 2025 15:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151841; x=1744756641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6i6f/xDaRTJj1UsiXR+TSptxMr+Xb9FeptF6tQymOsg=; b=l1VvtCb2X0dEYIttL0F8lI24V2hXzSKcLkCidXHnRR7cULoTGq5aOyoQyyNPlidKFw gFSfhco31yK71E12wj85u5vMzLAiEORlDadQNXKIy9P0NsO51Y87db3aDIjBFvEddsC1 jOuWE6nzRbEFaPBJ2rNTe+xisbWokwV8zR+2sEcQ3UIML02Jh3c1CMNQPDtQXc/yCj3y XG7B+JlK6lfwrSgBw22TgwqJaypmske+bnX5/0pfDvu5yfs9YGC6VO71X6xgccadeuhv m9C4AjT6v/thd+xpoJf0G8Lmw3/WI4vrcMLO0EQE/9MuW6Ozc3xo67j3ea5MwzCrtgR/ sO/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151841; x=1744756641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6i6f/xDaRTJj1UsiXR+TSptxMr+Xb9FeptF6tQymOsg=; b=AbaPAyJMsU0Z54X4PSZ8HtpbffrBtUOyxiJp6syebx/dsuNzN673r2XQ1ab0Qh3nS3 T6+Uq7crlOBdd8lhyAPBKWOsJFvIW6XysOQ9RdjqR3rreyyoWEUxrSPVOMW0UgbLyYdt qomjSigOCCjWetSdYYp411tJ8Cofn/0oyAK54DuZ513RJ5opM7ei8sEI5tyybET3eVvw 0en6DySJSi+zblb7FaGSaFZLJ9eFKLVpHU/IxqMndjOJWW+rl+U34DmvtwcWJnETL75I Rmd7hWn93kfCBRr1ayFsrdesbv1C2Ct78JhUUDawVaWwCHUaiRwRzTJDWF7IuddojKf4 Jt1w== X-Forwarded-Encrypted: i=1; AJvYcCUcGw+5APU2aFgeNvPjp9mf7gTRTLpsrwxOlbXVJwIpCY1p+KahzVdFBB1At0w1SpxnDBjAYnH7YCjJiyk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz81q0zDQ5ux7vACQVs9/mNbyznJemabRtm4wRq0hktYOgK/OiI mhLnKxgpTO9PIVV6eWQmZE5VPJFk6jn0obUjr0Aq6XlAmFfbildpfr8M2mNkPQ== X-Gm-Gg: ASbGncsAWoqDEvM3axZbjnV/XrRihkeEqiUGzyiktiQM8LE2gxe1IFHN8bY+K83YL7C tkcsncVILHaEHG35dXtkvQiLHwcZstCGONymnSUb05iiT9zlPnJnheVO7QlUHzgyjovNzPVj5E0 QfHAqhyXt2RNgTsvQeokCG6YbclBNkwqlfKlDX9lGR31O2c+Vyj4ZeJ3ypQxEgleritDYnaWYWK zF7yOS6oQRlRKg9Ci8N1NMKaFzqVZ2qNP++5/BXf83Pn1639aR7R7FlhJspKReO2LEzxPJkotJx m/C0kSgmuCY+yWjl8ntgZTio4gJT3rdnC/pgAQOxGb1c6/ZHcSIliLnzz3pHsVubqzMuldEddv+ tO21tb8oFNa17gz0p6IY8 X-Google-Smtp-Source: AGHT+IFoBZxGkWgw7INqwMHfuyYPpHaT2GDl7uvAaPAvZ6mUMh+2oVqoE62mf4cAVTQRTXJT9OpxiA== X-Received: by 2002:a05:6a21:478a:b0:1f5:a98d:3d8a with SMTP id adf61e73a8af0-201592d96ddmr970106637.40.1744151841276; Tue, 08 Apr 2025 15:37:21 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc41af71sm7939369a12.75.2025.04.08.15.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:21 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 16/18] staging: gpib: pc2: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:56 +0000 Message-ID: <20250408223659.187109-17-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/pc2/pc2_gpib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2= /pc2_gpib.c index b0b19e2d4782..a33ebd951e79 100644 --- a/drivers/staging/gpib/pc2/pc2_gpib.c +++ b/drivers/staging/gpib/pc2/pc2_gpib.c @@ -252,7 +252,7 @@ static void free_private(struct gpib_board *board) board->private_data =3D NULL; } =20 -static int pc2_generic_attach(struct gpib_board *board, const gpib_board_c= onfig_t *config, +static int pc2_generic_attach(struct gpib_board *board, const struct gpib_= board_config *config, enum nec7210_chipset chipset) { struct pc2_priv *pc2_priv; @@ -295,7 +295,7 @@ static int pc2_generic_attach(struct gpib_board *board,= const gpib_board_config_ return 0; } =20 -static int pc2_attach(struct gpib_board *board, const gpib_board_config_t = *config) +static int pc2_attach(struct gpib_board *board, const struct gpib_board_co= nfig *config) { int isr_flags =3D 0; struct pc2_priv *pc2_priv; @@ -366,7 +366,7 @@ static void pc2_detach(struct gpib_board *board) free_private(board); } =20 -static int pc2a_common_attach(struct gpib_board *board, const gpib_board_c= onfig_t *config, +static int pc2a_common_attach(struct gpib_board *board, const struct gpib_= board_config *config, unsigned int num_registers, enum nec7210_chipset chipset) { unsigned int i, j; @@ -460,17 +460,17 @@ static int pc2a_common_attach(struct gpib_board *boar= d, const gpib_board_config_ return 0; } =20 -static int pc2a_attach(struct gpib_board *board, const gpib_board_config_t= *config) +static int pc2a_attach(struct gpib_board *board, const struct gpib_board_c= onfig *config) { return pc2a_common_attach(board, config, pc2a_iosize, NEC7210); } =20 -static int pc2a_cb7210_attach(struct gpib_board *board, const gpib_board_c= onfig_t *config) +static int pc2a_cb7210_attach(struct gpib_board *board, const struct gpib_= board_config *config) { return pc2a_common_attach(board, config, pc2a_iosize, CB7210); } =20 -static int pc2_2a_attach(struct gpib_board *board, const gpib_board_config= _t *config) +static int pc2_2a_attach(struct gpib_board *board, const struct gpib_board= _config *config) { return pc2a_common_attach(board, config, pc2_2a_iosize, NAT4882); } --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24414259499 for ; Tue, 8 Apr 2025 22:37:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151844; cv=none; b=szGjLRaCWxuNGhrz2yCtvpvqcb5RC73sF1Hm0JLp/lPsKkuM67fYrwOxFFujOtQ+ZV4VO6VyOrp3qOFJwfq9SN2mwCyddwaM6hS0SRtyi8cjG0pA3YKdOq2HLb8qcUVf27c4pIfcnfNcKUWgb5dl45WrUsD0SgcYx5B2Ym2tavY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151844; c=relaxed/simple; bh=WNuWDTs6pDN1wV8Z6wrXTCiZTEWWOXryJgb1fzU3VnU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GLC2jbuPLYnzcJZBcVCmQ2aH62v6B8biqDfmY/V4FMn3vhOZEFuKKNHj2LaFwz8o1eF5zxqH0UyhP3YZJEDrhcz+FHgZvWOtujTJiiHkIIzOd6u6dIYcfFS6Xxk1bVnTX29Q/oZVEwPN9g0Pne3AIe2sHR4jEB3iNB3G95glIQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=gT0Lvj8M; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="gT0Lvj8M" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-22a976f3131so34839205ad.3 for ; Tue, 08 Apr 2025 15:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151842; x=1744756642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXhVa1CITV/B2cRl+KjgT7xJ1CjyHiHMABslu29MRHk=; b=gT0Lvj8Mg7EHv2R8vxQZr0TqEf2SjCmVSdGjBVuwkCSmkFeU53tTmDdeAx9Gz7gxeD 6l80/4UiY3y1qsJXQpbqJJYJUvw9vLrk8/XOaO07kSb6FuF1KPb2qI82kWI/43f3M6I5 SshmpLguyJ6x6+i82FlcjRpuroKfDEd7DxHtfD+yY0LBwQpFo8SeSdVq1IiNe4N6Z7Sk wCPM77hFLcPktIiw38+xYV1W3WbeKCzcXgY2IGMd94Gz+ghlogl8bQMi4khY59/eQ/nX jONQlh7UzMBqlMvkjG40MagaZq9MPx9Cs/zs7iJ1AqiZVM9bORFKRr7aiG+iSU8OWp8w nyUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151842; x=1744756642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eXhVa1CITV/B2cRl+KjgT7xJ1CjyHiHMABslu29MRHk=; b=wU2gtXGNeca4J5ffuI2dXi07DbR7g2naPf54EImhOdh+Z6FNk8ixO1QyVh1JHIhRhH cpu/4cVanOhhbx74qh0SBgSw1xkvazpTLzwvUOjnHZHq6yL+khoVHDFQ8N3RE/mJDino 1DY3xOLT/FDj+xJiRq8rEIFxmFKDlEcNrKVtUs+bC4+zvjJ/jjMPTk1kR5jWwghuTQRv LADgvPDDsMCJoWADP8r3bapItBstQFl1tJXVO3c7PwuO94e2LMn+v6r9ZIZm+snDRaMA f0YFwd10WiBfG8NEStuCagojGq/YRyTJ+kjyOPRiivFW08/mlK2PuAN5lVvK/mp5/V+n blLg== X-Forwarded-Encrypted: i=1; AJvYcCWEUq4Qm+XG89J83u6X1A08OpTN79MH7VM3HOcLB6DiPfsMoi4EEOFUfuGcWJhD6MwliDmlcXjFGTpQzME=@vger.kernel.org X-Gm-Message-State: AOJu0YyflhbTLG3t0mZJiAyFaFXjpCIXuaBiimBQjloVkNf2YkBsBhy9 JpEvQgJPi18bYxtDolRGPXwOJVYD1v+bIqOiBR+mP99ZmUSIe/ukFXlT2wdn2w== X-Gm-Gg: ASbGncsKqR/3FoEyTv8njy3diN0gC1fMZgzgj1hFKh+8uiU3gX0BrwFtSRgSmGV6cIA tFnPZ8/rpVROuIqnVqLI6oTATRiJqndC5Ip32gIiFWsGqMMKuHh7iEHgZPQmiYr3XpeH2QGIudl g9tBinC8f6Eycn+C71iURiVN8+iqJfHeJ+qWyZ3EPSER/F+E+6lsZ0UBiy4W+a38zKR4oEOq73R fhRSGrUH1F+RU81xWYTqItCEQgnDLJ6Ku4BxejOzVtNdfIijOGGyALwc8CN5eOAZkYo+i2VPlqn GtAQExWgIAPnI9a/kPAXQTf65GenZcgbhtK7qjau7Z3KzyPXZi7OSY3D1D0uuZ4KjPH/SBIC+aK PBdFNtre5Ng== X-Google-Smtp-Source: AGHT+IF87QspVFPBUI3zb4uLBU7ReB8xysVdKaGFAEW7LgmIq8HFVxrT5mQ3f2ij8cR94DO4zpRATw== X-Received: by 2002:a17:902:d4c8:b0:215:b75f:a1cb with SMTP id d9443c01a7336-22ac298fabbmr9724015ad.9.1744151842428; Tue, 08 Apr 2025 15:37:22 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229787764e9sm106480495ad.243.2025.04.08.15.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:22 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 17/18] staging: gpib: tnt4882: struct gpib_board_config Date: Tue, 8 Apr 2025 22:36:57 +0000 Message-ID: <20250408223659.187109-18-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_board_config Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/= gpib/tnt4882/tnt4882_gpib.c index 596e2fa40dcd..f123d427f835 100644 --- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c @@ -898,7 +898,7 @@ static void tnt4882_init(struct tnt4882_priv *tnt_priv,= const struct gpib_board tnt_writeb(tnt_priv, tnt_priv->imr0_bits, IMR0); } =20 -static int ni_pci_attach(struct gpib_board *board, const gpib_board_config= _t *config) +static int ni_pci_attach(struct gpib_board *board, const struct gpib_board= _config *config) { struct tnt4882_priv *tnt_priv; struct nec7210_priv *nec_priv; @@ -1019,7 +1019,7 @@ static int ni_isapnp_find(struct pnp_dev **dev) return 0; } =20 -static int ni_isa_attach_common(struct gpib_board *board, const gpib_board= _config_t *config, +static int ni_isa_attach_common(struct gpib_board *board, const struct gpi= b_board_config *config, enum nec7210_chipset chipset) { struct tnt4882_priv *tnt_priv; @@ -1075,17 +1075,17 @@ static int ni_isa_attach_common(struct gpib_board *= board, const gpib_board_confi return 0; } =20 -static int ni_tnt_isa_attach(struct gpib_board *board, const gpib_board_co= nfig_t *config) +static int ni_tnt_isa_attach(struct gpib_board *board, const struct gpib_b= oard_config *config) { return ni_isa_attach_common(board, config, TNT4882); } =20 -static int ni_nat4882_isa_attach(struct gpib_board *board, const gpib_boar= d_config_t *config) +static int ni_nat4882_isa_attach(struct gpib_board *board, const struct gp= ib_board_config *config) { return ni_isa_attach_common(board, config, NAT4882); } =20 -static int ni_nec_isa_attach(struct gpib_board *board, const gpib_board_co= nfig_t *config) +static int ni_nec_isa_attach(struct gpib_board *board, const struct gpib_b= oard_config *config) { return ni_isa_attach_common(board, config, NEC7210); } @@ -1702,7 +1702,7 @@ static void __exit exit_ni_gpib_cs(void) =20 static const int pcmcia_gpib_iosize =3D 32; =20 -static int ni_pcmcia_attach(struct gpib_board *board, const gpib_board_con= fig_t *config) +static int ni_pcmcia_attach(struct gpib_board *board, const struct gpib_bo= ard_config *config) { struct local_info_t *info; struct tnt4882_priv *tnt_priv; --=20 2.43.0 From nobody Sun Feb 8 19:55:25 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4461C25A2AA for ; Tue, 8 Apr 2025 22:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151846; cv=none; b=NuWViWZZSZQN1VMYMWCAGvlmErY9nvqpLFGegCxArjGzDd3qPCWpis6jUzoo5EorqClRgKIJNROqxqVngLbuIQVxT/WSJlFjLPJTSsCK6LCYqe9AqJzCK2k5pI9oEDysxi7D4eyXQaTZ/kIOJXmmrJcvgOewLLeeX09IG/tqCak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151846; c=relaxed/simple; bh=EDe/v+ceS3a7mNmvmw5sWy6oiSYKVkUiKcSfABJrvLI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=USWIE2cFGtKQZtFgH3LSxQ1JJSdTPl8TssQ2+7Xom2aO8T6Kp8KXK6yKp9N3Iy3bTsAxwthxWOTcAp0YmtmIaLNCe8lkjK2cHMUvWpZxBu2WvAgfRsPBBWXekBIsb/WODJ+YSUnBqO4L2Vbi88lxRWdqgpWz4xLGNcwSNjV7ruY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Tqv+a1h9; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Tqv+a1h9" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-736aaeed234so5180809b3a.0 for ; Tue, 08 Apr 2025 15:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151843; x=1744756643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HafV7m212oxhd9ZR4mr+TfwYqRBb6sb8NYg6QNI6i1I=; b=Tqv+a1h9HfV3b7o+P+G5QTdpZHPiSw3mZeU6WwqlExBgRn88IhITe29FXy3YlqJIdT CNgO+2XQcUGy8GFC402eOBfiNhaMMlouY3wdzIAqGFBaJQRxYIRrFwzh8DCa/aFK3vxC AYoep3D+92HjpqVvYueZ+LBZxolJcXOrtPLCxKMH1tts1ZCfJYkFjl2K4g+qjmMz5dnU /onHycyudfPwWyiK4kkgJYjoBKlZZjEDNKXwVjlRIypuGE8hnlugSUBRyskgg1+RH6tb 7gglWheLLLVFPbfEOU14O8pjXL17pQ4uLnnPMG8umzf5Mu/5ls6yQ92+966rpISbrC/k FJvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151843; x=1744756643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HafV7m212oxhd9ZR4mr+TfwYqRBb6sb8NYg6QNI6i1I=; b=avm/pd9C/9xPnH4n5I0cgwOmonM9y9d4HBsu5z4WXv0Pssr6cvMBgnJ84MXsXHFkli vpfR3z+hzP7TZvwDUY6VFit4tLZostbuNUa+PxNYI6SQFShJlHpraV2ZSCZwlbPBD2hg n6PNAEin5n79/bpoX9W9KiDVb2cx9c+Ug/KEsqie2kQZGYOQogFXPFu081UimgmWy3gN zzMS1pZz7YfeE+DSByxIlmSaNtQdkPtj7k6Ha49kjQgpwCVNmnWDnL69/jDsiSLPqrkJ FY12LrzqKC0zPxOThE5HJbsQZh21Nqp8s+RQlj5hyzQZjE1XgfoHBWIKJovruEqqT1Rs Ktng== X-Forwarded-Encrypted: i=1; AJvYcCVSDI1Rouf+93jU/LrCkMlrZkAGPi+Yb21ON6t86eZ/uoH+CkRiURKUVGsHFJxVcDhz+GFw5zgHjqe+l80=@vger.kernel.org X-Gm-Message-State: AOJu0YwWGF4E62yI1zIki0BUYrArevuDAg6OkU/mHeP15XVJY4VEU+gP Q3nN6+m1KHNQGZhBLWR/kVvSxzmRxMBPMtwvfa+mqTuijBUrX1/jBZQXb46bIg== X-Gm-Gg: ASbGncssNsKz8JEn6kJFmFJmv75w2L/UoCk6esLWMdM4cpG5bWFiU973BibIyk7JERW IDGf8BVGhEGbnILVyprwH1qo1WdqYZNA+fU5xl7S56o6ZypWwq7faao0yr7iZHL/iFDIdCPIpWI z1i41R1BxAASHdbCvD1aGnxPyOXhZ+2AcUX/8yNOdaA34guufKblmHC4HF16+cYLhBEXrvEOkih QPf9zn4NlNIDHpUb7/DMMOGsm/QafpT9rUinvxML7GYLu1eZ8vcMA9q4VJLqTUv7HJnq+9gW5vq YyDv9bJ3Wzf7jIpdi5+Vho8AHHl/wnu8OjRJQsXZkVZqdw/TaZDlZ2/NmfmM6RmWhBFQIfN0SSZ Hpj+4Qs5zAIGVU6qefZKT X-Google-Smtp-Source: AGHT+IG8o+6R23mHGAHJzEyRzY5w9h+Av8Ahw5BDr+ZVDin1/+zjf4sgEVTD8dOoEDFUTBUNzC5pkw== X-Received: by 2002:a17:90b:2d0d:b0:2f9:c144:9d13 with SMTP id 98e67ed59e1d1-306dbc29f06mr1214429a91.24.1744151843610; Tue, 08 Apr 2025 15:37:23 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297865e5d7sm105919855ad.124.2025.04.08.15.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:37:23 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 18/18] staging: gpib: Removing typedef gpib_board_config Date: Tue, 8 Apr 2025 22:36:58 +0000 Message-ID: <20250408223659.187109-19-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org> References: <20250408223659.187109-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removing gpib_interface_t to adhere to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 1c641f17bdeb..0253ef2c94a3 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -23,7 +23,6 @@ #include =20 struct gpib_board; -typedef struct gpib_board_config gpib_board_config_t; =20 /* config parameters that are only used by driver attach functions */ struct gpib_board_config { @@ -55,7 +54,7 @@ struct gpib_interface { /* name of board */ char *name; /* attach() initializes board and allocates resources */ - int (*attach)(struct gpib_board *board, const gpib_board_config_t *config= ); + int (*attach)(struct gpib_board *board, const struct gpib_board_config *c= onfig); /* detach() shuts down board and frees resources */ void (*detach)(struct gpib_board *board); /* read() should read at most 'length' bytes from the bus into @@ -291,7 +290,7 @@ struct gpib_board { struct gpib_pseudo_irq pseudo_irq; /* error dong autopoll */ atomic_t stuck_srq; - gpib_board_config_t config; + struct gpib_board_config config; /* Flag that indicates whether board is system controller of the bus */ unsigned master : 1; /* individual status bit */ --=20 2.43.0