From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 192CF2550CE for ; Tue, 8 Apr 2025 22:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151113; cv=none; b=N06pcOM4l6VSJHymXBsMJpVKuQ+kggVcTa19RvsWaLllsyBcAKf6VyetQbKc3qHlZy1OEYraHKBjXxpDPvk0Of+EwHY2HvbcrD9TJFIyEq39pf7YQKggOsaw3BbEwJp0DBEW9tFOPzbYwsstcq45FZS5ZG4Jhgo4c4f4vPz2d+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151113; c=relaxed/simple; bh=zBaT4vEsCW9WabioGiD3eVnIPOZk+030v6c65zQMLr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NjDITlCKZLGC1Rk/tHNQVXUfwCqnxGugxuRMKNJgYbJeYJHZ6/dFGASZXfhlC6TOr8w9Sh3aBPaHWw76lgNpp2JD4Y9vT1snTP4z/sYTVL3p7+qjhjiAp07dnVNLWEsoaze0G/LjBLdjf15tf/RKRp3iOy7QYTsHL7DW/8smfqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Yp5jrxh4; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Yp5jrxh4" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-af50f56b862so4200484a12.1 for ; Tue, 08 Apr 2025 15:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151110; x=1744755910; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y+6UevCyLnjvsWBFbzNWa3AXPSyQaeuqdYb/dtZs/F4=; b=Yp5jrxh4YSsSmXgxMWb7aPR7FFMaCzTqh/lAzyrhFOrcYvIA2uquw0N3LuQieGGP4g m3svAs1OaML6vII/iS1jRY5e+ydtOnnu/U2nCK3mOWaDOeY/bKXWXRznf/yXLByRLe1E NLEyJhujtS5jiO9818tO/4S0B9BzTTqMws1KgrLPKsBVLNi9gxhJdgsPx8Z7FNx0HRNg PpMJmJ50lz7wrBXQwLPTgoTl0XIwDRDq4Mm9fKc5GYrUzSrygHOlvkuViqKcnuu7vGOO CCKn+5umgPVKl7SpUBoK4/9+ile6iNET6ifeMO9cRLU90sefFvTMHN1FBXpQkRZuKoUY 4RGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151110; x=1744755910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+6UevCyLnjvsWBFbzNWa3AXPSyQaeuqdYb/dtZs/F4=; b=ZMBwtTyzLKS/5mCFBO7zSxQhddDH4CZL01YY3fZ9+OC27M/mUqpgkW0rcFmKg6bwo2 7Pwp0iCMTVnSTFFikttu4GiWUC/t9IxFeExyuW8iOhrg2TC/2M9bGtSFeB6mPGmR3Ozl JdTb3/gd5VH6P/E3112Xe7Hey+d4HxRrJvxJdXLpEpktRi5nb/j4PG3HZ3IKNeKE0g/j iBV+WvUXoa4pcYqwx5YA/42TbV8u4vyzjNI6V7Q2RiWbsOylAuGkX6fhlairqxaaCwQS 501RvbhpVU2uUHIHbgXKpG9E5c0iJ+SMt4/77EWAouAmzOGEuiN+5yVzw537eGK/92ej NJsA== X-Forwarded-Encrypted: i=1; AJvYcCW5SGWidnybtt4S5qKF6EgU6LAWy+0FQrPkQVYKXxbRJsPsrrzImnoPy/1JpCDUJbHepboCjjh2jZ4hxEw=@vger.kernel.org X-Gm-Message-State: AOJu0YwYXnEzQE7+WD0V4C08W/0XgUvLQtGKPdzCt3h3Nbl4MrEw7xwr UAtFzFpVuRCc7tDmy2DBjEGcHFsa/voXK879oPqAXN+iJKMN2/s6NbMdsea5qg== X-Gm-Gg: ASbGnctCPmY/ATfBeQnQVvcG2psrHIzJSqegpSslScyyhFJSLoqecBa8iCQ/N8df7DS fv17XR0M3s0rx7WIb3HSVcgBQ7i44Zrx1hFvqR/MkRV/H039VXjPUUkvjEi9UOfebAfERViTvfI NVxHC1FabITkXl86GSs/mutq+D2eN7SdCWTVhfMJkjn4Nzpp/i1UsEI2Dm/Vx0CTo/jpRdAa77Z A/ijgEHz31+OnsFMk4TyJ+dr41RFB6tsIxmndUjcpkq3COn4q1YerT7pdhruyCCIVneuiXBACvo HzrE39jpkP4go4wEtWlxGWM06NK51mvS/tDQDYO+Uwxx6nHOOrcOeMoKkeWl692nFV6n8FxBCo7 DEIIxpVc7hA== X-Google-Smtp-Source: AGHT+IE+BRpGJQpWMRHPf266YMAqNBHhYQqHdf7mDGI2jGj+pgqv++XJKzlr2H/xRmZNYQI9+lIlcw== X-Received: by 2002:a17:90b:4d0b:b0:2ef:19d0:2261 with SMTP id 98e67ed59e1d1-306dd52cademr217788a91.16.1744151110296; Tue, 08 Apr 2025 15:25:10 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd12b4bdsm92176a91.27.2025.04.08.15.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:10 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 01/18] staging: gpib: struct typing for gpib_interface Date: Tue, 8 Apr 2025 22:24:47 +0000 Message-ID: <20250408222504.186992-2-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for gpib_interface struct in .h to allow drivers to migrate. Adhering to Linux code style. In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Reported by CheckPatch WARNING: do not add new typedefs Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 2d9b9be683f8..10d8776ef425 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -22,7 +22,7 @@ #include #include =20 -typedef struct gpib_interface_struct gpib_interface_t; +typedef struct gpib_interface gpib_interface_t; struct gpib_board; =20 /* config parameters that are only used by driver attach functions */ @@ -51,7 +51,7 @@ typedef struct { char *serial_number; } gpib_board_config_t; =20 -struct gpib_interface_struct { +struct gpib_interface { /* name of board */ char *name; /* attach() initializes board and allocates resources */ --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AE8F2550D0 for ; Tue, 8 Apr 2025 22:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151113; cv=none; b=ci1y2LNJDxRiFKysXi4E4wQJjOX/FgWU+dbwHWw2cyemT9mK+Uo2hnzmqd9CFVYDPYIayPJkdYuksWNMKviINFgynKgy6nlyplQW9yMwNoyYWuH7uO4Hp6URiUf9c8hdQpqVVbAz/wwFRFXpeG4DA5aKPGoa3lXhCEZbbHM/ed0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151113; c=relaxed/simple; bh=oM57btuNW3ekRvgTbROwRISV6vnniljWeMeAhyibHMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mvRC9kaMIbV65u5/2QyURLi6SHzT9EGQe3nKFzdfI/4xsMd5PnszxLm+hMlxzDjjE6Yn5pyUkBPg6NuNOl3o2ObZYS9VgKkJyn2OE3MZL4/kU8Cu3mYLtXpm/vSYovF6tz9kC8Z2AbymDxJfUEoiFQ6OCf60IrSee2QyVdNAjvg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=d9w9Diwb; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="d9w9Diwb" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-227b650504fso55904005ad.0 for ; Tue, 08 Apr 2025 15:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151111; x=1744755911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DJII3lwxwEP6btEtokn6sH1x6OEQH5WFvfcqyI8vPWg=; b=d9w9DiwbPdzNxtU0eNxjs1VLBTiMkcX8v9hGHn5qAxkZq2hUkILB7nAhimghcantpb BID8C4/fQW//oRyxhZhl46u0wOKREvq5FqBlpZIZrYX4HvODrKUvTSffBPdda7ZgAw8U 3whNnB+tsw1YutouanREa9VnevIDJPqzfHDHBiu1Nk9PnEj/9cFCtr43EqBEenhLrbxS KvZzGNnrFzszIm676lsdUYTx6SssCsgCIccy0q7DG/wGZR9aieimDtR3sP3n9CeBTuQi Dv0jnPgwQov/DfbdX9vtLG6TWgBkGMZNF1IPSO46cGHk7NHyfG9ThEI9/f0Hw3QdyupD KyQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151111; x=1744755911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJII3lwxwEP6btEtokn6sH1x6OEQH5WFvfcqyI8vPWg=; b=BThGX99JYgVtRvhjSI4mO/GNwCk4k7d3oHNaOcftSQdonC7UN8uNYfxJ13u2nZn8pL kJyGKuQLldwYnIK4tTCmJP7mI1otLU80cJwUB1stgCDXZKMDQwH9yFR5ZSCi/zQ+T+JX cwk7BoHa1HaLjmPYPaCLDABbqf7HG4vdRHHYSbAtsJMQ8RTzbVJiCr4f4vYfisK+5oXs /RV9jSnwR+pC2OCZB2hWH/6vwWR3KoajBij3lnn/7DxsWI3WfgVnxxbuNNu1F/huYTUr CsZXdtPNF5EWi/vbfUoVC3HvrnJhlS4hAtQfzTtAFZBOVaSN1/H4Hin1L4lwj10a30wi 4BMg== X-Forwarded-Encrypted: i=1; AJvYcCWo8FfTNRn4tnu1rAiviIY/m1orJj4/8eJ6L1yCeQhWh8fflR8PeuxsyJzBlA7xKHBzQ698+wx3vFDEixs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf+DzUzO5ioLQlQ0FzJlU7mSkzfO/xwmozVqX7kEObeG36af2Q isz33AIDVQAMkq3TxySsdR0N53yk+3CKyc9IfADKSK+6rnR03CTVL34JUyAfgg== X-Gm-Gg: ASbGnctRGtUa9flG1KG5cWy14xvL45ofgGAUpI5+Mnxi9E9sFO96L4V19SbHzCSbj0x nrU96Ru1KitlFmtwicv3491PbjLcuaJ2/6GeXDZMmzH7V1HDEeYqeDPij6cozhKX36tJwy75TPE IwAL+Ia52lcMMMMIkw7PUxXfN37ebwOLIVQ/UkD8dr5H9jDDAi7HPspH4DI96q+pxZFXX5WYs7B FBRk+vycH1R0VkUCjSwLvvZrjVziJt6Dm7KPoGiJL8dxIFX5jHMvwVlmAssrPh8uz4R++qgea4J 5UadulVRi21ntqu5fTNkXhk935yO5TJz3ioKT6me0WWvXSfj3lDtbxn/U/AmqmONrxtBCMmOJfz iNqjJWrvheg== X-Google-Smtp-Source: AGHT+IGGBaJsq6ra1J2TD6QhHEFEL49tTMqBX3rGuKBOfmUq0C4kINeHdNJZOfurJQ52gP0Ji/nVZw== X-Received: by 2002:a17:903:1c5:b0:223:619e:71e9 with SMTP id d9443c01a7336-22ac3f2e04emr4578645ad.11.1744151111495; Tue, 08 Apr 2025 15:25:11 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785bfeb2sm105911555ad.74.2025.04.08.15.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:11 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 02/18] staging: gpib: agilent_82350b: gpib_interface Date: Tue, 8 Apr 2025 22:24:48 +0000 Message-ID: <20250408222504.186992-3-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 445b9380ff98..3880d4a23eea 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -773,7 +773,7 @@ static void agilent_82350b_detach(struct gpib_board *bo= ard) agilent_82350b_free_private(board); } =20 -static gpib_interface_t agilent_82350b_unaccel_interface =3D { +static struct gpib_interface agilent_82350b_unaccel_interface =3D { .name =3D "agilent_82350b_unaccel", .attach =3D agilent_82350b_unaccel_attach, .detach =3D agilent_82350b_detach, @@ -801,7 +801,7 @@ static gpib_interface_t agilent_82350b_unaccel_interfac= e =3D { .return_to_local =3D agilent_82350b_return_to_local, }; =20 -static gpib_interface_t agilent_82350b_interface =3D { +static struct gpib_interface agilent_82350b_interface =3D { .name =3D "agilent_82350b", .attach =3D agilent_82350b_accel_attach, .detach =3D agilent_82350b_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBEC255E31 for ; Tue, 8 Apr 2025 22:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151116; cv=none; b=AO2nyHtD6o9vjWFeoS2i5Fko5JrJqggCH93/pnLN7hWLcTWsAkFM8rdNtM9JqPCQatkSNGBUlXAy/MhIcg5Uz8vkyjHMzl9MoiFSYdoqwC2ElOUgtAs63/kZyCM0CaBOoi32aLMOpnfDjLbsjKbr8VTnqP9F7FwXYL4jTe+MaNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151116; c=relaxed/simple; bh=XpQnO5Ofq3tGrrrR9Kobf5JUhGGWsse+RF8ttHkWB7Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qfj1VfyXcizRFfqpb3m0OLbbqVbQUZ0Bxh3Uf0isUUSqpWLSq0naaNTzI4wtXhTNa5Jx7eAYkqY+O/9EeruZgwCnsV74D1FiTEjHvROXHnrY6SsqW7Rx2g/0eoaLvTU/Babvfd3ypwMDhNKLwnw4LHrZ5r+Yk0Lnxh+szZQdf8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=RAEWgIHH; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="RAEWgIHH" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-736c1cf75e4so5288751b3a.2 for ; Tue, 08 Apr 2025 15:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151112; x=1744755912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TyqM9XA3qJ7OWA2S+2KUpQ5OJtWynztvm40wi9YyoYI=; b=RAEWgIHH53j0MKlMUuqigddEtzloFH30aTms6eVC2EoTTyAjDJq0vlAE66/4dh+9OA BxbUc/IGerFv3u4Os0Ata5oYUGvbNbiD9C4xzC7bMocXv9SlHrbZHYZXGTnYnsFwYqi7 VuSEGy+AB/G/0ymkHFjfF4/lqYqxIElID19Ni91NM+1ILTrDn7BSH5oBtttoxjh7Y4/R 0Y4180Idyr7KWsx2VV90oUlLkybSaLd3VlKsntOsoVZHrteirN4gsvSM8eu9zIFDRyEM kXaZV7EcZGtATDSuTQCWc/DorKHNBTNW6OzryJJauqTTeYu1UlZl2uQvK5iH72SiMkbY VwBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151112; x=1744755912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TyqM9XA3qJ7OWA2S+2KUpQ5OJtWynztvm40wi9YyoYI=; b=GO0N0TlxWsSSD47zGCyzQy82Po+e48IJPs0/Hp0qxCGgfeKuBQcVcb530Nd3OKCRlP 5/KsAeSdlIoK9NHO8AehMxoH4krVzneJnEXjbVgd4MqVDLfE1iC8/p7jBM8b1hwXxURI Z/XJ9zQvfT17hyx0Xq/yXwzGO5BeF8fXOsiE3U2PNVU9HmEdUAjDja+NRzwG2+I7FvwE p7B7tBrB8UQcj39gK1i7r5l/6EtUULpQwlprizskf0EdNPRZPgBJnoA9t1LqhyR1Wx/w ej9Q13CzlsiMV33PwWpprbrahnMtu5pNqiHzxcPvIEdZi0oTeM7KIt+/Z4yMNPNydo8b RrLA== X-Forwarded-Encrypted: i=1; AJvYcCVuvXJjX2Bma/p7pXYD4Il8luUMwkCW973uUa1pXHEps7ChPVS1IzzDep56mP2yooOTh9a0gkQhxuzuqGs=@vger.kernel.org X-Gm-Message-State: AOJu0YwdDBcdPDM6IsvRR+TkClrp5no64j+8L5oT0FsIDChkU/Pa0AgZ c9kRE3LhwiGW7O9LslDJBNTlRtuIHhO1OoNYEvJNR8OxB/fHq+t7q7ymI7w8JQ== X-Gm-Gg: ASbGncurqJ5zKH/ILIA1/UwWxpOgvSUlB2cXubGDcFUe5532sEJOgie7aboBmhAoTTu oufDg44OaACEnHpp77ce18MjDHhEkciVrPmBLUoUlGPGZT5LGVQIUQ06U2c3vKu4i/9xZZao/gQ YkMD30fENQdjXH5TMLGu7KZn9zdquH/PFezMio+PWfw1qjRUnKx/0Mxv1cSzcvq2mCMFrbukSrK pO+X6nAOoCHCK2c8+GEsXABoOt/W8Fyni+ZHpPNU179Tx01e1O5yiNgUVczZ2k0U7v0LtRuY+2S 6EclT+Jqb9fTQf5tWFsma3K5gYa8QSKtaAA/TWe1kMpdEVsOqix0yQ+EEkXkxJNVLA86cIRBdUv 5lHWAByShBOPjNgQypF3T X-Google-Smtp-Source: AGHT+IFo5C/bNlvwWLyFe/tTHf2NO6zN6WDrzML5vLTbWDntGXERUV1aoOEuI3e6EbBITuA5yljX8A== X-Received: by 2002:a05:6a21:174d:b0:1f5:5a0b:4768 with SMTP id adf61e73a8af0-201591ca8a0mr889636637.21.1744151112694; Tue, 08 Apr 2025 15:25:12 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc2cfbc9sm9615323a12.9.2025.04.08.15.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:12 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 03/18] staging: gpib: agilent_82357a: gpib_interface Date: Tue, 8 Apr 2025 22:24:49 +0000 Message-ID: <20250408222504.186992-4-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index 16cc5333beba..29c390b4f4e4 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1432,7 +1432,7 @@ static void agilent_82357a_detach(struct gpib_board *= board) mutex_unlock(&agilent_82357a_hotplug_lock); } =20 -static gpib_interface_t agilent_82357a_gpib_interface =3D { +static struct gpib_interface agilent_82357a_gpib_interface =3D { .name =3D "agilent_82357a", .attach =3D agilent_82357a_attach, .detach =3D agilent_82357a_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 933C82561D3 for ; Tue, 8 Apr 2025 22:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151116; cv=none; b=griF4JG6cKlUFoMP9elmdm88Ef5fP8aL7ZVn429ImVRWYugr+iLihe/O1knWld17DLSmxeXG2ONI0m3WWbm7/rT075Y6Km8PiP+qc3LJeDkBUQ+dDvUVz+XeQnHdHsrdH8pbPPKEiseS/SPkx434+E/9/WjwlBbi8V+JMo5JslU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151116; c=relaxed/simple; bh=O5+RhG5ge74kMkJH0h6KdnV7xnNERQlJFnrKnXJqKg4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZfjgDkruDovQnEStQ0yOVlkCdS+62q+QFXOKY4F4bgCKpLttGmwowk9I2kCdh/EXM1liFBl/y+QdAq+5dnHqEWNmRBhOu6f0ttfC7yBXUgIsQDrB9jvl3SCFfKrjBpJYLZ+BgD7MGHL19aRZZHceT9YjsHfM4XZRR1b/s6Sp5ZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=KMVRBd6f; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="KMVRBd6f" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2264aefc45dso78196175ad.0 for ; Tue, 08 Apr 2025 15:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151114; x=1744755914; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eFx9w/yMhxB8IB6NL0DBl9+YzkxzqjDcwxAFXBMcOfU=; b=KMVRBd6fZyhdijuisOzaChdN5u8wpViRlHRh93OkSr2TWbI782aWxiV4sWDkkUXTLd GyMQ7HYtL2MaqH3vpDQWbAKtHTF8PYoxflgF95GmLTV95IKdxc6yd4NAatadn1XpbvvX XVAqb35+oyaRFy+6pGvzEOJT+5HWgbMahedAQZAxx/Vx+Exvv5wPAYE0e5+WbYGubl2+ ay4focjr2IdJxRQ6V4UKqYuuCTnaf45tB0VWpCvWMUKxR69k6/DLASYcRJh1Bye5IKFf 8I/tmcFMebsE67IBrVW/ftC2iA9LeAd/+g4HfHZ9fjU5HyMJdz4Ujasr/fVM/2ge9hWa z42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151114; x=1744755914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFx9w/yMhxB8IB6NL0DBl9+YzkxzqjDcwxAFXBMcOfU=; b=eySVxTqhxUWGNfp8K0ViJtsRbSud/I9RF0Ta/pplQPgD56guxJSEZz28iLgVS0SyDf pWkG8fK1n1hClne5oMycYKvPucGw/7EY1gswnyPyNILrRbsu9kcGjaP9DpGCdIrcZtYx XARaWD5nZi1EAYsIueSQhPbP8AUWdL3weefV17SP2C2bW8djo5hCxt5bTK3DGYN3/gsg y+6vK82GwCk6jJ6rKWs4yTMYTUCEzlGcYPJWEvWdhXKRipHzlk9xpWmSRW4hXj1Ub2QD AUoGbPevXH26e30HXF98sWVqFszIVRgTOQ5BaLpYvN17rj5RMtTrgom91hTM1YZ6pmxw 9Yug== X-Forwarded-Encrypted: i=1; AJvYcCWTA3Q4JDyIhdiWak63eGXSMs98YQ/HuPoSHfEmqpiaLrn/lzFtJaiq5EpPUh8Xg8PvlvrzZJLvUukcmHU=@vger.kernel.org X-Gm-Message-State: AOJu0Yycy4IqGFmN+bbDuXRxguMcM3Q6ClUTbqjsR96k7EXfEzDQVtco F+fOBoRM80ggV6Mcc14caDoZ/tJqTwTFdD3/jvP+zqzd/OZflSa73jYPyfTeLQ== X-Gm-Gg: ASbGncvOb/O2uIdhdCB7zJJ3SJFxvOYVr0OS/4HRIoRSskVuKuGtLiPlMza+g70O2bV r72oNNQ7SAI0sV4Or3q8m0JmgTwdwYlQOzI73QZn46pGhXVz1AwSBrjOpMgMrNz9Qe8N/Vsmm84 Q9uEFVLsnG1vXHXHqTNTKIhc+/trQZXTcU5h2TenseZ5vbDOYswjHFlzKX6oVreJJdc0Dv9gS0K Blk08XJp9Ys3x3JBP6+HEC56v3YSInO57KeqFIF9vmGZNxx+ksIRJKjJGnlsg5m6rDqctF7KqZ8 n/9horrCMgc3qN9ONtuOK6k5xPH1VHiyQp61MstjzIY+HO4nqo36L6sKFtQUsqz5sPLoa/QYW4X yBFvaAL/arQ== X-Google-Smtp-Source: AGHT+IHybuhz2+2wE/bIEAPIYc3Trj44vmkOCDCJUldt1nC/a5V165jljjhXhyKbx8BpNV7FK79R+A== X-Received: by 2002:a17:903:2ecb:b0:223:faf3:b9c2 with SMTP id d9443c01a7336-22ac29b051cmr13402905ad.27.1744151113816; Tue, 08 Apr 2025 15:25:13 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d9ea09a5sm11572355b3a.107.2025.04.08.15.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:13 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 04/18] staging: gpib: cb7210: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:50 +0000 Message-ID: <20250408222504.186992-5-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cb7210/cb7210.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb= 7210/cb7210.c index 6b22a33a8c4f..20cea66d6557 100644 --- a/drivers/staging/gpib/cb7210/cb7210.c +++ b/drivers/staging/gpib/cb7210/cb7210.c @@ -686,7 +686,7 @@ static void cb7210_return_to_local(struct gpib_board *b= oard) write_byte(nec_priv, AUX_RTL, AUXMR); } =20 -static gpib_interface_t cb_pci_unaccel_interface =3D { +static struct gpib_interface cb_pci_unaccel_interface =3D { .name =3D "cbi_pci_unaccel", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -714,7 +714,7 @@ static gpib_interface_t cb_pci_unaccel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pci_accel_interface =3D { +static struct gpib_interface cb_pci_accel_interface =3D { .name =3D "cbi_pci_accel", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -742,7 +742,7 @@ static gpib_interface_t cb_pci_accel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pci_interface =3D { +static struct gpib_interface cb_pci_interface =3D { .name =3D "cbi_pci", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -769,7 +769,7 @@ static gpib_interface_t cb_pci_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_unaccel_interface =3D { +static struct gpib_interface cb_isa_unaccel_interface =3D { .name =3D "cbi_isa_unaccel", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -797,7 +797,7 @@ static gpib_interface_t cb_isa_unaccel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_interface =3D { +static struct gpib_interface cb_isa_interface =3D { .name =3D "cbi_isa", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -824,7 +824,7 @@ static gpib_interface_t cb_isa_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_accel_interface =3D { +static struct gpib_interface cb_isa_accel_interface =3D { .name =3D "cbi_isa_accel", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -1333,7 +1333,7 @@ static void cb_pcmcia_cleanup_module(void) pcmcia_unregister_driver(&cb_gpib_cs_driver); } =20 -static gpib_interface_t cb_pcmcia_unaccel_interface =3D { +static struct gpib_interface cb_pcmcia_unaccel_interface =3D { .name =3D "cbi_pcmcia_unaccel", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, @@ -1361,7 +1361,7 @@ static gpib_interface_t cb_pcmcia_unaccel_interface = =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pcmcia_interface =3D { +static struct gpib_interface cb_pcmcia_interface =3D { .name =3D "cbi_pcmcia", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, @@ -1389,7 +1389,7 @@ static gpib_interface_t cb_pcmcia_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pcmcia_accel_interface =3D { +static struct gpib_interface cb_pcmcia_accel_interface =3D { .name =3D "cbi_pcmcia_accel", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC37B256C8D for ; Tue, 8 Apr 2025 22:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151118; cv=none; b=Ztmlh5VmTlL+k07jVrkCzsMjmNiepiTVPGjPZZJSc5YWaN1fX6b8cyKE3hltm5M+zpS8BmFqeZkZC4qkiixP+S5GBNniTWkMTosBUIKOZaVGKDLXCAYNU5vIj4grTueVH2eI/0O77LaVVoGNRVgefVYhFAvwXDpRGri6bn7yiyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151118; c=relaxed/simple; bh=fjSwQt/2PS0/uHpddp/9VfHp8MHyRBleAOyBrzxHfS4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B8eOK0bOnmlU5z5IO9UWNBrG4Sn4MnfhSpy2eTo74BxjdlkfJQVttqU9qD9w25HWo2JhMCBvuecbw+zqorijS82goBPh+qTbIiyyYR4LR6AA5kXwQW9VLlrPC/QYPgw+neKDV9ysXWtPtX8D1g0FG1a4jYiRWDm7sZRbYOjT6pk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=QPeAOV/1; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="QPeAOV/1" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-739b3fe7ce8so5413158b3a.0 for ; Tue, 08 Apr 2025 15:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151115; x=1744755915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=89A+ZPD0F+3yWuCAaFy/tofDasEkWjCiUmF02vN16R4=; b=QPeAOV/1hSflQF8S/M0C228T5waNFCeh4280IakAUdMUZQABWhmWPHM3kpidpXjzfW ZiT6c27IJmbe4/x9pkEITebp4Y/c4VN3uF4SZo4ZEUfL39jotKE+dk65gJiVAfdPsrTA YlUOSjiXpx7HzTTCYh/kpqrWH/OpcH2xmvTDtIcKBaJ5btqu5pTsDz3uHqGN8zkSNeQx DQQ0zSzElwl5z+lztYF/yHTIXv2sRkN9rqX8ZU2ouUEdP/gsuCvL7pwzeYBG3lUUIaEx 20EJemBO1NI7bzYbgpN5c5xQjeM8hZr04YFle/Sf1dK67Kpk4QPlRxSu4Zm9ivMSIIAW AwbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151115; x=1744755915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=89A+ZPD0F+3yWuCAaFy/tofDasEkWjCiUmF02vN16R4=; b=gru1xqHNLNC/CqsMGHSK5BoFKh/Iud9TXyZxCH9tAI0uz8h4FzyH0p2snIxHiaH4lt vKLb6/JbDFtmztvoQcbktRO6n8pxkapsh4qKinXp/Vo+8klaubNNaeRoC2onMvhugzAH peEXyfAtQlrgATmKZcTwkeI981hk/mpPPZUMWUHVMHIJSFOiTMhS6uBoHyNRDlSGD2L0 9Zq1yKEFeosU2tdkMhXsSdKFayZKeN49yxlvrHQ6Kkr3egPksMYImsqOrQmX8U81p8H1 Hj7fil1LAhZYjdgkMH6AS+cBzKPZrEQDyjfBXk1WHG/tsSQlWI/f8uelDa/Ekg4SLJ0T zalg== X-Forwarded-Encrypted: i=1; AJvYcCXKjMZrDdLQoaPPJrAAGmJMz976zJ8IQ8+HHIonYmcNWiy34QxO7+TKXBtGPy4XS+tQ7hkkmZ3M+5Xh8CQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2nYcJTQx9mol4AyEKxvhPXGHGG9vhIbD4NaNidHPkJySQhp57 nRj9F5OGN8NN9hmWrSEtWK68v14eJCcDpkyUMSN0ARDb4d7wzS6ktPElvvj7vg== X-Gm-Gg: ASbGnctfqMFwyD70swaghACgtm6EPKNCATxmQuvxPVSUch9kHMWG7ds4WpdBBrwy7xO h72pGXrKfIXkqhon7lbJcjC7fpS7ZD+gaZ+QWI0Y4GP7UmoFxX5kX5wiH1XfKeTZ25F9ao28HCl V6HeDIP3NONTu9jqxLtmFDseZvMeyMu5GJyTGg8QMHESNEc5W9WZXqqWRfEIDJc5f3QkemjVFOM CgfjPN3S8egxwrQGB7NWRiJfuJVlCmGU5tIVK82PIlHtF8IWof2SOvauOEY1EkCXOcY3uhqMtTF cslxBRS1wmHS9bwidHS/ZdZxi9o5xf9bI1D6DmQVE+Z+NmQwYOXTTpXJcmjS7fWc//UeMTRcep2 XGuXnNIfryg== X-Google-Smtp-Source: AGHT+IG5juhMHsu1LskHss9Nad7vpK7FAPNQDk6C1pXafcAf9b9xsbrt4eBAxXA/2nIyF2WtAbUalA== X-Received: by 2002:a05:6a20:e306:b0:1f5:8678:1832 with SMTP id adf61e73a8af0-20159195629mr923643637.11.1744151115097; Tue, 08 Apr 2025 15:25:15 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739da0b9608sm11165505b3a.154.2025.04.08.15.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:14 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 05/18] staging: gpib: cec: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:51 +0000 Message-ID: <20250408222504.186992-6-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cec/cec_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec= /cec_gpib.c index a822fa428cd0..dfc718de1532 100644 --- a/drivers/staging/gpib/cec/cec_gpib.c +++ b/drivers/staging/gpib/cec/cec_gpib.c @@ -188,7 +188,7 @@ static void cec_return_to_local(struct gpib_board *boar= d) nec7210_return_to_local(board, &priv->nec7210_priv); } =20 -static gpib_interface_t cec_pci_interface =3D { +static struct gpib_interface cec_pci_interface =3D { .name =3D "cec_pci", .attach =3D cec_pci_attach, .detach =3D cec_pci_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 051B22550D0 for ; Tue, 8 Apr 2025 22:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151118; cv=none; b=grJHVbAhq80Nx/vsmk/A6SozbAdZYCnMvP9bL0GSf4oU4Ie5wIMKzojVZFbAwdb9/Z8N85vFI3w1RJG4s3ALhC6KuFL5sD3Tdevc+46kwAGmMhvmwh3PFXukwoGJER6u+OoJfhIE9uM55nHI6V1f/7afWZJOOmokvbKNuNskrno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151118; c=relaxed/simple; bh=9JfNG0tTkd+044z4jFaJqkunmng+TdBPIb7IlEomLco=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jdzmJe8ECJ1xmO777MFaYiHTVXyBnCOJhM5xFFM4DiXEU8217u17UKQiU3Un9yw3YDltP858YFwhWzT9IuUQuUObHZS6L+uTOEDWTsEvKYkIuPc/ebZPl5QVH/4v7qqdV+yz/7ZfrE1w4u+/miEf6Lemk2M6MwuYDio85tiPf6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=mF7qoPvh; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="mF7qoPvh" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-73712952e1cso5644242b3a.1 for ; Tue, 08 Apr 2025 15:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151116; x=1744755916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8IorxkgKO3HdtKHUOTo23PvfS93pIvPvComCrtQir2w=; b=mF7qoPvhQnDH2Ur33xzZEZQNO3tYt5BR9k/SR7+0/s0HfrX5ju3TINHMqNEgJAOg/0 4Qv6DG2PmMZggcV5BupXffSc5ehWSpielCoR3wEMNSl9ZbzNM96lt11zrQbZ3URyxZku nVsZcns8pIjopPb087ADqlavdNDY1otClXnCSYGrtPNEEu84L+okbq5hEdduy1zIMcXN VUAwZxz8NhaBuWPTFtxCUtWCsSk6TOZ9fE5FKiS6Drft2IXQkUEgwhvkbpeWEaDSnxXz cokX9YMyDnJ5j9P49UM8rAn7XJbQ9SxcGQOiKfFt4+u/tHNLgiloMtTcAL4OnRR8U/2k ztPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151116; x=1744755916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8IorxkgKO3HdtKHUOTo23PvfS93pIvPvComCrtQir2w=; b=HsDmguTOCQFQnmtf8QvcIpY91e5+m/QsGBU/FwNwFhcxidVTUUM3EJye+VzZ0g85F5 f7eNQ25QQlQs9f7y3p/IV2HcBsgM50uvzQbwqtUbf8XwCu12R3AZTvVVRkvIwb2NCTv5 RXg1ObGYHuN8fssxkVUeFDVoyugopKTUampg/QKUW7f0KIV+CXsqGvfAWl25JPCHYree /u0CdZhebW+Kjir5m4ZAUb0bHt6wU4nkCeHQ7KmLH6aUrIFwoDRZp035ycOnLAmvZocq JmjAbqmI5XPcEG2oBOJYbx2MyA+gGxDq5a4uPVdiaRaYHH++lP+EiKbYlLAS4+tejGTt 4nSA== X-Forwarded-Encrypted: i=1; AJvYcCXH3qGbREoYkRBa5av9UahAvXfcwpAah506i6AIVW5PSbB33VJ5ExdSUxeBP1D10m/L8IBCRqVAorF0XVA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8Y7wOzV0XDdgowXFtAzY8kB/MfnNLyayodwAfNxDJMQvwTrxT 7/xuZvEjURSQAHxO/Bh72OKqHFBvp/xNvvyh4vWOkEy88iJOektLDnpXH1IdQg== X-Gm-Gg: ASbGncvBjEU0N7QRiFZY9yPOrvp+asjmTkHnTE3YNE9Tjgb/auw21sfaOuPEF0YgUBi ZRCN3Clfya48Qo2i+VQbWLiKP3FMHDWUiOnInH6w9kreixD+v/mq/e6AQRGD8i5xgbFfAjZ1X56 uQOAcd+PX/lBzQEDnKRKc0GT67JNdJHodOVVi3PaTePBZw4bG8bd6AZE4pZTnh1X6eBa1ifh9b0 4Thy1QcaOKuirZEYXmHZC/EbV6jhzBtYKWyCnB+bYdHEhZnOY4n262XxQsCdMWl8zltbsBVOucM Nv6GxfBhHRacAhskmh+qy52g0RR+40YBLyAisIutqbRqkCObLOSc0QqGrtP1ZqvjiILRn4BCk5v 5Krwk8vwj5w== X-Google-Smtp-Source: AGHT+IGnaxbU3fKPUw5RdhpztQ0HR7stoYxmD/se0+wQgNf+H1qiPEO5WKH1/T+a2ZSl51CROOyq0g== X-Received: by 2002:a05:6a20:c992:b0:1fe:90c5:7ceb with SMTP id adf61e73a8af0-2015b00eff7mr182726637.40.1744151116304; Tue, 08 Apr 2025 15:25:16 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739da0b3f5asm11475713b3a.131.2025.04.08.15.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:16 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 06/18] staging: gpib: common: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:52 +0000 Message-ID: <20250408222504.186992-7-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 711e99b1581a..940ea05ba478 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -2024,7 +2024,7 @@ void init_gpib_descriptor(gpib_descriptor_t *desc) atomic_set(&desc->io_in_progress, 0); } =20 -int gpib_register_driver(gpib_interface_t *interface, struct module *provi= der_module) +int gpib_register_driver(struct gpib_interface *interface, struct module *= provider_module) { struct gpib_interface_list_struct *entry; =20 @@ -2040,7 +2040,7 @@ int gpib_register_driver(gpib_interface_t *interface,= struct module *provider_mo } EXPORT_SYMBOL(gpib_register_driver); =20 -void gpib_unregister_driver(gpib_interface_t *interface) +void gpib_unregister_driver(struct gpib_interface *interface) { int i; struct list_head *list_ptr; --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48AAE257426 for ; Tue, 8 Apr 2025 22:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151120; cv=none; b=Z9FlDZeVIKCRchd1hFZ9MHYtpSG0MxLGNmKLS7CZwmgnmVSp0AL5/cgEK1NVl4QqQdndEFNvWwnJF7XpG0NyeRtEs5ObsocbQwZenBwOHGnxmW9H/daULqdhvJdNeDLOuMlmJPoVvB1z9ZpXU2RAXoSA8y++FyCcsMjiaa8i3Fo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151120; c=relaxed/simple; bh=3NFxLnV/Nr46EF/TSVSMp/zsoWxRG8qXMctW8XQ54xA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=onz+0f6aSrvkyH2BrX41yfvXGN92n+lrEjZVQRqNBICqjAnNa6slGIK9piyuGG34mypHeYMdvRyMGz972m8w3RVpwIaDkh1kfYUhWej1xWh6iiC1oSgQwFqo5i2YD/agVn5ii5iKkF3YWtOZPO3aHNTsgDAhr7y++QvZsamDFVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Zaywn9qS; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Zaywn9qS" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-306bf444ba2so2657754a91.1 for ; Tue, 08 Apr 2025 15:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151117; x=1744755917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RYR6o/fptDL97JakFYXVuOyKREpmT1G7Kb7stf7FxQc=; b=Zaywn9qSrLnWmxSlrZzmGzUPR1y4ZKheRVU+0XlonVPWwf6zhY8KD9w2q70OuXKz+b rOxaoDCzxGXgBaq/87FZpI2ZphOwpprStVQ+fcABFF2Oi/4EEEdRod1LK3P6ILHDDzEo /AbyKVGgHAScHUwRygc/Sqv3lxSiP7k3PzspuWhxyq1CVD2NPWrJkhGEGXRrh3F+NTF+ TaxzJUeGV5ZQqAfl5fcKcVW7GWbOEUhFKIR/HkY8lS/3GIM7mDxqhNxNaK/rxgOPJrNt BytK19EZJdrJPKqahMFXlMehUzjKLIIpNvmOPTcBLyBZmmZcrkUg+XfiBM0zxMnhy6Sf V7Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151117; x=1744755917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RYR6o/fptDL97JakFYXVuOyKREpmT1G7Kb7stf7FxQc=; b=WBVwdSROdps/tvTE6xa7mcUIl2rUuDasXKLsPosn6F8VMjtj7seGFvG95cE/vDXc7H aR0vUUJA58gRwxZckQ7CY7WdHz0A4iwtfMUhSrc1s28F/OcNBQWXhC9CwUV0IYLOwY/o SrtRwG26dPaPLHqQZDcBtsqtUmbYcEooTAwTVWFFoj4+EuJks861aVgD2zhkbhRqqwtz UpPRJcP+NtC/sCRVL0/V88aXkrKPkpw18nsdPyBfhOPQxnFSIjn3IU7PN6pVnu2J+8lD lp3nA0q3jarwzsNgAdAPpdfIt/GYfBdHaz/oxFP4hUAqu7Skmclm2ilNubbdutaGUi2b mV1g== X-Forwarded-Encrypted: i=1; AJvYcCVv+QPgjZBR8gCC4d1zQ230s0nqJKTTiJA4d1gOZSjFfyHDzF8EBHbjbrg5BD++we9s+ouOMk95zrAgCMM=@vger.kernel.org X-Gm-Message-State: AOJu0YyH6773oaFN0ACpd/DLVWTccS/cxLkhmvEf1esEGAWcuiQfSjeD gtz1zE8N7CzFg5w1FlnaUmwgNOoPx/E+Ut95y2dUZE067NGqSiSRtHVLGaup+w== X-Gm-Gg: ASbGncvMZGat8MQKXvZHQuKtUbqslY6ba8B/lD9hdSqK6lE1O06AdG8SNxt6C5bOqgA pv7ClWiJLnvvG/dnH3xTmjy7mriUchHSAfF+ypodjrTbRkFtjxnUgrZ/RMDJoPR0ZaZkQud3C5E 9TQGOpY28/s9pbzysh8ZNYTNEdEb4GGz7akib1ZmwZjTlsZ2oW+Cq+jebpD6OOqDhSNnXM/k2bq 4AIvY5sYAGOOMQwJQO4vpG9YznB46ZtrqdGyf9FKEKUXge6vJ++cnOeg9qA0FXtHR/PRsL3HCoX z6JVU+kqQDjEjcRo2SEyZac1MOgd2sznLIhSnzm+TfdN7BfpvLtc5Hp2bnUyk2M41r6DLk8zj6t qdU1gdKCMxA== X-Google-Smtp-Source: AGHT+IFWBmW88BT8r/eam6USK7inexLdwGM3Z31rYrUeQeHbRtEtsiN5hyH6X7Vw4VoTv+K3XMkRSQ== X-Received: by 2002:a17:90b:2dca:b0:305:2d28:e435 with SMTP id 98e67ed59e1d1-306dbb8e7d2mr1251536a91.7.1744151117487; Tue, 08 Apr 2025 15:25:17 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-305827d70a4sm11626033a91.3.2025.04.08.15.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:17 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 07/18] staging: gpib: fluke: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:53 +0000 Message-ID: <20250408222504.186992-8-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/eastwood/fluke_gpib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index d289c321c153..68f888a75edc 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -698,7 +698,7 @@ static int fluke_accel_read(struct gpib_board *board, u= int8_t *buffer, size_t le return retval; } =20 -static gpib_interface_t fluke_unaccel_interface =3D { +static struct gpib_interface fluke_unaccel_interface =3D { .name =3D "fluke_unaccel", .attach =3D fluke_attach_holdoff_all, .detach =3D fluke_detach, @@ -733,7 +733,7 @@ static gpib_interface_t fluke_unaccel_interface =3D { * register just as the dma controller is also doing a read. */ =20 -static gpib_interface_t fluke_hybrid_interface =3D { +static struct gpib_interface fluke_hybrid_interface =3D { .name =3D "fluke_hybrid", .attach =3D fluke_attach_holdoff_all, .detach =3D fluke_detach, @@ -760,7 +760,7 @@ static gpib_interface_t fluke_hybrid_interface =3D { .return_to_local =3D fluke_return_to_local, }; =20 -static gpib_interface_t fluke_interface =3D { +static struct gpib_interface fluke_interface =3D { .name =3D "fluke", .attach =3D fluke_attach_holdoff_end, .detach =3D fluke_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E6A825742F for ; Tue, 8 Apr 2025 22:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151121; cv=none; b=YA9n1WS+1Vg039vVNy0waGcDrRGAh/UcmaX9TEJp4VnQCZLUPOkiEZ2BkC82OgqMS+HO1qCrAwgFQXuTZef+NfDhhv4UAVLw3fORH3eSJRcAnZwWJ9llO40YKBrxFbxyD5z6JrJ8JzIyjktptFOLFef26KrsYtwfdnrKpmBohj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151121; c=relaxed/simple; bh=+zRK44sFZdwIvc4vU9sKnG1BcKymUzbd0L6oa969Zxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l35WbRuEyJ7I0t8S7i+kIjG+gV/hDRQ7Y0b6Apa1tG70KlTZHpD1utDSpAnCuiBqt2qeMJEwDmvow4QH7r3tLyUJrcFtLlIGQq1KZFh7j2m+x6/qyatftNHtsURBReCybW4vC76n4z/t5oQXnQ7Dtq42PsJJcoFy9rMZ0kStVAI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=mpLWW2wX; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="mpLWW2wX" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7fd581c2bf4so4707514a12.3 for ; Tue, 08 Apr 2025 15:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151119; x=1744755919; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XUL7ykty5njGdegmOhjg8oPPUwbsVjeLq2w2Q/Kqzw0=; b=mpLWW2wXuksFR/R3J3+RL+0U0uo4y+kFtFvrDOEUCmO/Rq3Cdaz5gSugcNFal0QW41 RCh4V0itmqvoSnhrtReaB/Hc1GYaI189NWnx1fudn6xTQPQn6oyt8oqZ8eIPCSggFaKw tMzdbfVs38fxsP5wO4oqwVaZY5wcel5ERuAdz4PR8Oxp5ccYhV1Y0BwV243+a5sGaCGd t3VM/tcyUnaHMpaQkNpyWUnP03RkyUp0d1FrDY7qcEaScLrwIsQp3d+ZjPVRGC3TqbE4 RDIXebCxoNvtZdTC1x+qFqLN/8l2mV2Lf9zuUuhbypfKN1Bs5Ul1HGpXmpJdaG6LXTVv 6Nzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151119; x=1744755919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XUL7ykty5njGdegmOhjg8oPPUwbsVjeLq2w2Q/Kqzw0=; b=PFx8k6x/kZKQ01bKEFuOBpU8h9gn4VAfC/dWQMRnj+nPSRWkGYYw9ATelqWweeQf2a of68N4O4H+ckPVDaLN69A2RKulfedlPK9ufR/6TKTRXFSQ+Sq4D9OoZQOfBwpwTX7Ixr HQU/eQDJjjemWPNG3BzCNfutoV52cia3lf0iX1nMndwyqHoyjGJSEQfpMP2tkrkY+6/Q qsnLfPFh+bInTjIUS82u/UbAyN5aVXCthzfIJ6/y8ZZmwWcA9/QHDAWnQMoqmt6YKQ7g GyBAbrgdx6DtnzVnNCVfsHOnKp7XgYjreRqxiQPQ1YuY5Bu48m8GF1hmpX64MhZ6hix5 EBlQ== X-Forwarded-Encrypted: i=1; AJvYcCUBMJK+ptv4V2AnTwNqitckdwhuIXAYYATjn5v9TaUYK0yuOX0yYOeQuCOYtBDPeBuvs2ExbA5whj1+PjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzLOv1WjzRuLQfePiVD72FmAqTpz21jUBqG+tOX1yee2oBB3GFF u1MSe3SOnuP6VQXOGCwhIw3Z+AIDjeMbZ/1BfvVsKAKsVgrMow1YLFBlHRXsnA== X-Gm-Gg: ASbGncswWUWLDBfr/LjlxQE2iR9UP34HtKZ4PvLKDfmCcmHG1hgS/kZgIbbyDqSnTA3 9noYfy+isacha62pfOsegJ2/jf//nDrQLwEJXGtj0HxIzhX2ay8A2eSsHFutHSNIYVxO8X2ADKT BhEBtgGQBOMVDLP4l8Nbyd9tZ4jnz8BFRTg44RXe//0tvZPj+m0B1OUk0BIFgh9THFfWNfeUdZj pLOHLqvp9UbYn1KieHvgxctjWKlwtAkUyfVGulXyxs93XTL+lH/KnROgzlZ8zZUJ5w9nL67b7yd DI+4fT8vn6SOX4JWb0QpAmN2UwlVbne7Y1N1f8MM7m5ojU/TTZMOnLtqYjlevAO1fqkcMk59zhv U/3hnYv1zia0D2NSZKErm X-Google-Smtp-Source: AGHT+IFOv7l3SpdOls75EIztcizBRUqY2SsFnO0yo4hxoGcc1mnpzvAVTB9qXSAHu7nc58jKJZnDXQ== X-Received: by 2002:a17:902:ce8d:b0:223:54aa:6d15 with SMTP id d9443c01a7336-22ac29a96ccmr12494055ad.12.1744151118768; Tue, 08 Apr 2025 15:25:18 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ad982sm105915625ad.25.2025.04.08.15.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:18 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 08/18] staging: gpib: fmh: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:54 +0000 Message-ID: <20250408222504.186992-9-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpi= b/fmh_gpib/fmh_gpib.c index 733433d7fc3f..b2c379ce4c88 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -1011,7 +1011,7 @@ static int fmh_gpib_fifo_read(struct gpib_board *boar= d, uint8_t *buffer, size_t return retval; } =20 -static gpib_interface_t fmh_gpib_unaccel_interface =3D { +static struct gpib_interface fmh_gpib_unaccel_interface =3D { .name =3D "fmh_gpib_unaccel", .attach =3D fmh_gpib_attach_holdoff_all, .detach =3D fmh_gpib_detach, @@ -1039,7 +1039,7 @@ static gpib_interface_t fmh_gpib_unaccel_interface = =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_interface =3D { +static struct gpib_interface fmh_gpib_interface =3D { .name =3D "fmh_gpib", .attach =3D fmh_gpib_attach_holdoff_end, .detach =3D fmh_gpib_detach, @@ -1067,7 +1067,7 @@ static gpib_interface_t fmh_gpib_interface =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_pci_interface =3D { +static struct gpib_interface fmh_gpib_pci_interface =3D { .name =3D "fmh_gpib_pci", .attach =3D fmh_gpib_pci_attach_holdoff_end, .detach =3D fmh_gpib_pci_detach, @@ -1095,7 +1095,7 @@ static gpib_interface_t fmh_gpib_pci_interface =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_pci_unaccel_interface =3D { +static struct gpib_interface fmh_gpib_pci_unaccel_interface =3D { .name =3D "fmh_gpib_pci_unaccel", .attach =3D fmh_gpib_pci_attach_holdoff_all, .detach =3D fmh_gpib_pci_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE6DB257458 for ; Tue, 8 Apr 2025 22:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151122; cv=none; b=pjlEDsA9f1b7H5qb59xMvHH+tFBcx7+3JFeYC2tLPr2IGSxdYk0y+3ihzQ4XvpME6ffthblR5vLmZI4cTwCjbyDDZwAsXFrrsXe5QYNUcFXokcj3yi3QQbafNMPn5PVwhDoVoBnoBiQLYiHD9372tCVwiqVaUTgaySLMhliST9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151122; c=relaxed/simple; bh=svD6c9dO0UVlCIVTddePdMduVpdHWbHw4LzAwR+m9OI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JuZkYmbsHF2r/neJfEb2LjCKTpCVGzzGQ9EX1l5LqBZTLP/lMiuWpM8EcrZxvgju8MuvSN5ZHr4qYzXv8UtO5IzgWnr4xEC8CLC9bi6SQZP3Pm54Y6T+Pnca9qcd6OIXUrtZHln+vv8Q7WO3RT89/x93+QsUkm0jqvtUVAbR7G8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=QnaNG36Q; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="QnaNG36Q" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-223fd89d036so74336045ad.1 for ; Tue, 08 Apr 2025 15:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151120; x=1744755920; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FOUuQo/ZBOK4e2pJspysWYksCtSOwA8ABZzWMkqa/TU=; b=QnaNG36QFUT9DvxUFYCxBxhUuVpppkKXjEhDxRYNxL785vUWDfckUDUbroaQpI+sZ5 TAfOKZr9PD8Gp1tSeVazfTYoPdur5+QbVqIS5E+vvQPRKoHC8HMYVATlw2YS28y4N5Bs qB/aPcTjiVYGTY0Ri5ui+xAvQkIt66CJ3xFRcqykHRHdtVhaS12EMz18xANctc0C2F++ nWby3voYl/f7ahvdOfS9Hp4Xotb2uC3Hc2Tgez8sYjlWENOZK5D/1jefLsfopcmgCRe/ tKdrSgnT7q2Qf+cuYrWibJZgh+jrpLLAXzrcBfy63nnPna9TXdlfk89jNJTD8hEGtXvD zzNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151120; x=1744755920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FOUuQo/ZBOK4e2pJspysWYksCtSOwA8ABZzWMkqa/TU=; b=ABG/GdoBxjjXy+Vmq9+NvLn8dU4jw28QT0ANR2a8Mdz2RlS9WaK37/njeQ5pReqZEM k9yqEdUlS4K0A5Rz3UO0tdUAYeFVuyG+2I8lampUJ1Ex+PGQLHXK7ZaJ79z1CZWfoWZB O3WA4Yo413WIlYYVrplksDsg/s89s5dKe42Hkth1MmFxE/yhwDACmulJws0g8SS01qyX QTaQGeGH9o9yXuOeDB5sse+IjlrGR4o7OrRJNemxMYYDO2pEvT3Z6CUMiQqRDKQT0bAD uiJRN3Tz/eyB0Dxx+Q2Nvi35DiCmFu53NV1fJtzWj5AvV/khqGl8GbsQMXJ6Q6FYYbHf tN3A== X-Forwarded-Encrypted: i=1; AJvYcCU6RjcGMlcnS0byby/jJTtF/YMV4BOLaTEsALAKfv5RuIcGaE6SEb733NVs/QfV7lUzWcI0RuLdHBnGxvg=@vger.kernel.org X-Gm-Message-State: AOJu0YxvpjsyGat1BuK03zbGOmv5fkzr6eBURJ1ZHCuwuDYpLEhThY1y 7PHlxJxb3+zRvFjo3G7rXTQvIsZUp6qpBU5xO30O5PHdqwIk2GGA63kesjA2VV3T8ur2PdFvNjk = X-Gm-Gg: ASbGncs1bf5/rwsTOJ+c0hrZ0rpOqz7prcTWpU7D5dEak9UqgOmeTvTR7fCP23PsuVm aGQy/pRtKZ0D0waRohpTiu0PUGqm2k2rWedkcYZyUCuQj6iLecMZGhZoXjWNiKcD9Iwb6FHec29 RO3y7Fw+/OYcAnH2DJRJdZKUGqEfOEkMLba8Tve62L8BBmlvN86+Yoqi/Q6eMu+ZnseRs/KmjmK dHfR37RKmS78K3q+VBXphTeTFFEjdyBNl9es8vCIZBbknEu9YnBqIryHLUwD2kbTy2TpOFAK2ks PM4D9e6JVSRMfXDgCt1LAkWLj6l0g/eUVWdvOUJ3B5JgBShS9CYkIDKpx+L9CHC5nL0mJSvfFSS aUECfVl+lm7rGsrutaq4P X-Google-Smtp-Source: AGHT+IGpQMTVAyxJa9CK2SFGohMZaktmVvVgc2/bQ92j0F5OJwvRHayzQvbnJzUIL7peYa7lBWAoEw== X-Received: by 2002:a17:902:e943:b0:224:26f2:97d6 with SMTP id d9443c01a7336-22ac3f9beafmr6540105ad.28.1744151119965; Tue, 08 Apr 2025 15:25:19 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785bfe9asm106872595ad.55.2025.04.08.15.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:19 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 09/18] staging: gpib: gpio: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:55 +0000 Message-ID: <20250408222504.186992-10-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 86bdd381472a..7e85dd29ef93 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -1306,7 +1306,7 @@ static int bb_attach(struct gpib_board *board, const = gpib_board_config_t *config return retval; } =20 -static gpib_interface_t bb_interface =3D { +static struct gpib_interface bb_interface =3D { .name =3D NAME, .attach =3D bb_attach, .detach =3D bb_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BF58255E2A for ; Tue, 8 Apr 2025 22:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151123; cv=none; b=HRdaCA/hSPfUu5cm6hF59V02VXvhrnVuDztNWzV7zGjjXA66D2xqp3HUL/dPgtRwYGvcvsqcNTi1fyPUlzqoaj37YMH/Q7pFN2MewC90NJ+jJhg7a1LzlEXJqofI2+SemFE5Mko09Xt8a+2M+BeYDzSYiZU1cNAc/pcy9ZoODnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151123; c=relaxed/simple; bh=se3YZvKLgPAHLR+BdipUhIdfwA1QSNs3G/9/cqRGo60=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AqmA+WdZlgb3ddAOH63xYxCtskLb4ldYnoOaEPnfF+bko1l+7A0jsKg/hTZwfrQ1YgPf6DxVmTDaIUNFQNSX+E+dgoJztC1ibOoB1StfG+Tb3tZ17+JrSVQ4r3c+ptbBQnp5eND2CCFX3sgbQ8uh/GC/WUfnuVwdRoGdtCEMBjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=OVVsprla; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="OVVsprla" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-ae727e87c26so4063559a12.0 for ; Tue, 08 Apr 2025 15:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151121; x=1744755921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4C+lWNdknUJZlypfGnCZDNz6KdZ6zmn7ch4eG88+8lE=; b=OVVsprlaubvDlTbEX5b3ViCen0ULIxiKS+Ukk/YKJQhOjzgUmS41wYANQlzfsxqw9F VBdnwsPJOnrDTYd2KTG07mK1ahz/87FMyxraFZofDiax8A/Od1K90biynlDjQ03LnzBj 2Je4891VuR76BTJxI+XSoQyJF7HU7/NHoW1uPccmGrxfMsGlHdDeWT1lgodx5EM7mWhS 6WD4N4caMzEVuQRRoZl2ZNPSUFqi28S7yzWJv5G9l33n7lTIIDGzGmPm3Lz3HgdKItCS rR6kJbaxxiiIY+qsRGijtqfnocfv3xXKDjQ7mzP0ZJBnxMrgoIn4HsVI8NUqQgatLLFG iktw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151121; x=1744755921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4C+lWNdknUJZlypfGnCZDNz6KdZ6zmn7ch4eG88+8lE=; b=qmScoBIG9pY9H2ae/VBHBqfSZqmoHYv7dePprP1yiSgQGspCEK52oqyAZrHhbokwWH QfEo/M9I/1ZXDjUo6X+kbgxi4pnCrx1OlyuStDOeHldQXA4wmXv9gXoUnlkpD77w1F3a 75TpHgJ41b5Au1aYW/Zr8RCUKjQuBHhNqxqavUj+8zoJrFbDKDl/LfsZlcV4Mf4OmKkY BUMEkiu8pV3KSyAHoI9nPKzli2RwCrmXwDsIyElMg+t342SP5/iv53cRVZlF0bkS+Jiw AUQ8synGfdZXJMjfYx5m0BlqBv1Wx7YjGSfBDKPN9zXeV9dIy+4y5uXtuKSVWGbSiOty i0Fw== X-Forwarded-Encrypted: i=1; AJvYcCWEjO+hGFi9G3WImF1GlCqTGmWrUPDBaqQU/Nf1AWD7oQhCCDUR5JlEZ3NOhHrNWTugJTwCX6w4Rwqk3tg=@vger.kernel.org X-Gm-Message-State: AOJu0YxjlFbg6oecwCeDbs39zkSNBIKYAaTru4bpkzm2lWdGkJ4CQE6H ArSoMlWgvxdXvrUaCBn3q31diS7o2W1ZFOpDl/RLPdXfUSM3vUw3KY74EuekBA== X-Gm-Gg: ASbGncvZgqOF9MedHER9cM14ao1vDDgL+JTqoPBwsL1Q9O8hOBY6ieo8iF9iI4DP81q TbYVgf5ElSv18TMrtyzWsBtUVn7QTCWbU5WweH4y0DROAHze+oJy9gSWUqCf1/AJhHjG5DCcQP9 PAaLU3B7b/kcIByCN8I8ryBrzNN51jD22LBk8uwH5ga+AamtxCZcU9XbAn0TOqHdI863alMLZTc 7BzeMTXv3F7dX0vbT50iiA3BQWro2vnOxLQyNoOjVs46CCtAc/ZNxJ5P+duzBszXvXPKZKBnE7r xnhJ852kCdwa3SkJsi7eb/FcIMUbydnbn0XMMaxn7Jl5Utp6tSvCFiU5sb64vctwVxYK0qdBmiR ny58QhgVd2g== X-Google-Smtp-Source: AGHT+IGyeoiqqphPpKL5Sn7eKU4nhD0G7aTXKtNfs0fA6Ybtm7sOFRaFnTq6ISHfRriprZbTNWKv+w== X-Received: by 2002:a17:902:d546:b0:221:7eae:163b with SMTP id d9443c01a7336-22ac2a2e867mr11925265ad.46.1744151121190; Tue, 08 Apr 2025 15:25:21 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297866e6a9sm105819055ad.202.2025.04.08.15.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:20 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 10/18] staging: gpib: hp_82335: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:56 +0000 Message-ID: <20250408222504.186992-11-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82335/hp82335.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib= /hp_82335/hp82335.c index fd23b1cb80f9..1a93a456f7bd 100644 --- a/drivers/staging/gpib/hp_82335/hp82335.c +++ b/drivers/staging/gpib/hp_82335/hp82335.c @@ -179,7 +179,7 @@ static void hp82335_return_to_local(struct gpib_board *= board) tms9914_return_to_local(board, &priv->tms9914_priv); } =20 -static gpib_interface_t hp82335_interface =3D { +static struct gpib_interface hp82335_interface =3D { .name =3D "hp82335", .attach =3D hp82335_attach, .detach =3D hp82335_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39062586DA for ; Tue, 8 Apr 2025 22:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151124; cv=none; b=kX+i13Zm9a2zMxSHvbquAhE1xTB9H+tKSawuNnsYOPNGRv9zkyLwtDdYZtMNE+HQRAL1JgUkHVUB6b4/GY0zwVqVSla3wNkt7scHmDOnMaRby/SsM9D725/RaK74rrccnbuatETe3ylHyrsH2fn6xZFTvIuPhy5uVxw3lmuYr24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151124; c=relaxed/simple; bh=5NwJeDoAtrf0Tx8RIS/c29EngE2LsKm8AYPS+TzPKUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VGPbjx78QH3z9achOn9AnntbK0BC7sBK5kip3J/Ttu4TJi7Dd971ObjBDV+7rYaYIf0NphB3a63hhcAN1R8sqnAf9AmfODVQeHkTZNkxJ3lFNj1MSEGT18tKMYGMYetI4zqNMAz1W3PvfjvcSN4+oVJIMRPNkaHybS8ISgMklEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=YFxTTE8u; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="YFxTTE8u" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3011737dda0so4592357a91.1 for ; Tue, 08 Apr 2025 15:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151122; x=1744755922; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ed/nYTgwq2fOD1wKZMkQ0lXU9nmr1lfpOmDa3UEGBR0=; b=YFxTTE8uFa23NYAfanx77oa4SUqYIvmaPkTFzhh5ZwdVJuhm+q5yO8GD72Py+VF2SP aaD51vrXVuuOTCL+hX6qHCs185YpYl5nv08x1tAfE7mKB9JDFEC3eeJqdH02JSYDx03o XqeTVp+oz5THYfEuBTY8AL9Flmr8u2CXp4g66trj7rFx/tybxPyhBGrWlm4ipKCttdlc Z7RebVoeVHzdlkWhio3xZpqD+crVxKoHVcB1kaJsWsvVwRccIrN4RkbI2pwFcXcpyRgF VmMDn3FY/4f0ZVMGsDtLnJasERy3HQIfIog/ZAZQpePYLNzPLrAIYiT09TxD9UNrFtHA L6aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151122; x=1744755922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ed/nYTgwq2fOD1wKZMkQ0lXU9nmr1lfpOmDa3UEGBR0=; b=n8ErqOHhlXJ3Lbh0LrVHXJoLE0QaMvvuHIPbG/Q7/xhgxFUFVHarN4nuNjjdpr2sVk yUTU85v0snvaZlUNNzmj93QSyxAhXgrybEq/Jy//kwaSYkpJrJ9eqN+MuuB1JC5hlz/T Y33JwSsWu7Eq8Nx0BfH8JvWDc2M/xDd06+fdvYBlBwl+ZzTMmcuXo0iHm5uYywtPDOVS mRRNEFBis33mdIOfUiiqCxp4bhHD8toPwy6qhNZU/xAjQOCUxz4x5FZFqdC37YN0rK+b jFBULmNSQiEpBZkEKeypyA18uq7CJoC3dZDSN/nq1EUlOkGq882efRGP7jt8j0Bf0bgb zLdA== X-Forwarded-Encrypted: i=1; AJvYcCU9kIEQlT6Z4OYWGW8lfpKPVYvoHY9C1JZi1fpLSnOZsGCnOFcmy+90ulHb6/ao1hVxrVPopYrU9GlRkf0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzevxc+wNAi1VcKdOIBXYjFVCjM7WrXMiZ3EsRQOLcuCOlr9Zgu k3WqFfz9pjc//exOYNA4ideJSTTQiwfv6JmVzZ0wYzqm3ChGpnL1U3+7wsQMI9tVxErmmm5WUdM = X-Gm-Gg: ASbGnct7gwnp237F8LGugzhZEu3+fHbPgN/2SLNY8zJhT8IweKEWnWQ/cVh27UZdc0N +sCK858UYsbYPtzTSqj22QMayw7qFr9inMLYQesruzPavglw5HN/uaEfylr/1nADMmnnrmcccA/ /L/m0U6N4dzKeFIl4bJNUX9shkp8wr7bI6liRALFTneGodFAMzz70ps/1222PhZrbah5fJ3n2e1 VE+TTL5oM+bVzy3epNNo5ZpcntG9O5S9PWnB47ba10OG1H6NXawKUzVZdfEbWEqkIuzuPat59ie eJ4gbLyHLhnCUx00D30oMtQogYwXl5fas5V/j8S1pjlLejld2gkvwIw8o+183CHZ3lKnwD6ABTJ ROQzkBQxkQoOWY795fXFC X-Google-Smtp-Source: AGHT+IEluinBJ/WzRKg68aXx+kL4SHWDvkm0+46g2cXPGj3iEdxubNX0IJJK30XCGqi85flc99q6Tg== X-Received: by 2002:a17:90b:528a:b0:2ee:e113:815d with SMTP id 98e67ed59e1d1-306dd51da88mr230912a91.8.1744151122327; Tue, 08 Apr 2025 15:25:22 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd04e9a8sm105050a91.0.2025.04.08.15.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:22 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 11/18] staging: gpib: hp2341: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:57 +0000 Message-ID: <20250408222504.186992-12-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82341/hp_82341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpi= b/hp_82341/hp_82341.c index f52e673dc869..775103d744ba 100644 --- a/drivers/staging/gpib/hp_82341/hp_82341.c +++ b/drivers/staging/gpib/hp_82341/hp_82341.c @@ -410,7 +410,7 @@ static void hp_82341_return_to_local(struct gpib_board = *board) tms9914_return_to_local(board, &priv->tms9914_priv); } =20 -static gpib_interface_t hp_82341_unaccel_interface =3D { +static struct gpib_interface hp_82341_unaccel_interface =3D { .name =3D "hp_82341_unaccel", .attach =3D hp_82341_attach, .detach =3D hp_82341_detach, @@ -438,7 +438,7 @@ static gpib_interface_t hp_82341_unaccel_interface =3D { .return_to_local =3D hp_82341_return_to_local, }; =20 -static gpib_interface_t hp_82341_interface =3D { +static struct gpib_interface hp_82341_interface =3D { .name =3D "hp_82341", .attach =3D hp_82341_attach, .detach =3D hp_82341_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F61F2594B9 for ; Tue, 8 Apr 2025 22:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151125; cv=none; b=O7m+07kXo9JRtw5qQThQO47YPfSN8+zEch1VEwkO0655R6NLHg5unCZEU1Ct4J4KYQz7Xmao8x1hxxxRQ19XgCjnfIEUv/kdkS0pD9fi+mGNapruaLGJx7+09o/dtx5WxOLbU8+45LjqfeGbnh4lyqTBmWXLlKwmR7IcKheBAR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151125; c=relaxed/simple; bh=ywl14+VR0rQwTc8R0tz8Vziem1U2C1o3dk1jlyk5DE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kNwQ0CsvKktGgdUJukHh6XitIYLn43wPJViFmZU5mvtZolVm8cTUXVw9QFA/v+fhH91CrQBRviG2zVxMykquwc0EfhEDIStTHWLjTFc9GaeCgIaEj8eyrtWpGmM1QSeztk/owu0zG/etIQ2X9Bo9T1iKmeWFZ+BVyqdIAGoKtPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=cSnfJj60; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="cSnfJj60" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-736ee709c11so5125552b3a.1 for ; Tue, 08 Apr 2025 15:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151123; x=1744755923; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MvVYl1QVax1j5pUd57ASVBJzAMz2KKqzNiWOQ8Iq0P4=; b=cSnfJj60NcQ2XMrnQM48Z1nvBYgnV1fkVT9wDNruKSquZ2df71NJwuIf6SXcLtnBlh ZuQX/30RcXuFAVX2QfqpNY1qB/NpQ5zDar/pqxnX9pyeR9tjGPel0q/KKCJuGN9nsKJl qMP6Po5JQH8rMpxHUy0WXU7EXobOshfOLBvnlAHM5FyO9zUhft8YCwu68Pml0fAzLP2V j2e+I9LUJuvv48F8KPrq3U4O7tiYzxqo9NvxrT59I9Ka1QJf9ZdDTeme/Ew87vkUhkSp khdktWAx1OBMGWl9XfBM/R2n6GX0VZQoNyqmUEECj2R7P091gQt81YMAiAp/rwgUegeS jQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151123; x=1744755923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MvVYl1QVax1j5pUd57ASVBJzAMz2KKqzNiWOQ8Iq0P4=; b=FY4vyq0KVKNADVVcun1Yy+HihcHq35oTHVfz8hvLUplC+Hd0JrCBX2/TVTi7soJrbl PoVJwGRMCszRNSh2zvfRS0KRpQ6HDRvYzDz8doAad2UhUWjnjl8moiDZQub9aM9UP7De T5NBmQWa2qu6+gfH5tZGncaNAjlXRx2wy0iFU6PQPfjzQqId2gQATNOnSCcbjn3RWgu7 SaXffJWtEnx6N7UFxDl5qhH/D2RzWZLn2p7ueB6+Ur2Lohgl01x+7JKLvnEqnKgXlrj5 dmXmz+nitI6XFX/p6Ogce/Km45bj8F6rMYxg8f6esoLLHzxseqfBCy47+fYuAEzGOc5i 4Xwg== X-Forwarded-Encrypted: i=1; AJvYcCU851ObhnRfDF0d5dpUpqaIG1HOvNy3n4g6WaermCDMG4SbjvDjkMEWlakrnkA+MKPYma+gnPCPhQZbfv0=@vger.kernel.org X-Gm-Message-State: AOJu0YzC+CVvU+fyT8LemSm1QegNB121QWEiDbCVccTE5DKYxcJhIps3 lSY1VKp4uKdqX1y6eJ4K4lVprjg7WETt4WxTdJqlZ8Yzk9TjCMOvebayQuSsVQ== X-Gm-Gg: ASbGncsSGO1AHaL1UzldPSHUBCH5Cz+mVVx+RGToPzHM8kXDkO5opHQinl+ubBQi1rd eZkRYMmwpLdxGlbEayh7fGkssfw1yp0FRwuRN8lPfexaqePi/J9az7uoDVcP9nX9xA0WLY2Vxzx 2wYETVufq8YnfAV+u/yZCcA6J2Lma1dVeq5tu0PCw5ucj/WN4n8NOcUU791W3rbplhhBPN7kqW8 dYkjY4Q+CUgtVPXVKoBzl97X+eKgVi+YAszoP3vPZ8PCFNp7gvIejhM7RDMolqjT0KCxYOEOnba IDGXTnJpDLs4c0CViAxaFhFdZCdm1Czo1jSOViMAs870XckbkXpUI6YwbdRdCAwdOAHNyJNH49A vKj4ZOA6zxg== X-Google-Smtp-Source: AGHT+IEJFm7YyHd4JvHyy5TwKXxWEM5gOTs98uM11nmzNLPeSawj7eF+IRJv8cTyjxveJT1FNyiTZQ== X-Received: by 2002:a05:6a00:1941:b0:739:3f55:b23f with SMTP id d2e1a72fcca58-73bae4d12a4mr754636b3a.14.1744151123476; Tue, 08 Apr 2025 15:25:23 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d9ea0801sm11117438b3a.119.2025.04.08.15.25.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:23 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 12/18] staging: gpib: gpibP: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:58 +0000 Message-ID: <20250408222504.186992-13-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpibP.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/in= clude/gpibP.h index 0c71a038e444..82627ca838e2 100644 --- a/drivers/staging/gpib/include/gpibP.h +++ b/drivers/staging/gpib/include/gpibP.h @@ -18,8 +18,8 @@ #include #include =20 -int gpib_register_driver(gpib_interface_t *interface, struct module *mod); -void gpib_unregister_driver(gpib_interface_t *interface); +int gpib_register_driver(struct gpib_interface *interface, struct module *= mod); +void gpib_unregister_driver(struct gpib_interface *interface); struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, uns= igned int vendor_id, unsigned int device_id, struct pci_dev *from); struct pci_dev *gpib_pci_get_subsys(const gpib_board_config_t *config, uns= igned int vendor_id, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 898D225A2B3 for ; Tue, 8 Apr 2025 22:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151127; cv=none; b=YTt2zPmaXsK2mTqoXG6JRlXCCtN42jukKzMUI/4W16FWh4n46bmrMCpMeI08ec3o0U3odGE5W31xjWSsrNoEqlPGYZezdvgMOUcOL3twRdZWPr79UOAGHi4ELw6AME4pOcN1XlTfKOGUkXCFODt5SNkaFvQSf3KEwk81v6BQenM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151127; c=relaxed/simple; bh=mpMwcjyONGIh2W3fVzcXGp1Kfrhk7hvQoz9ErvoRi6s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AF9vZKXqcCNWhFJtSYEaJkOSRX0LaxwW3Yq2Y+FIyqq2QOxODyc2VvhPXqoj2KNaFUYJLtU0QyGSwiWf9n54otdlgSJEbo9dj/N/AxesuqROaoZ6h6F/eXyhh5L++y/4D6tlWrKlApwsm75FXfjfQyR59YpEojP80C4c+YCNWdA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=mMunDyRp; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="mMunDyRp" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-736c062b1f5so5161318b3a.0 for ; Tue, 08 Apr 2025 15:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151125; x=1744755925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n6YenbA8rChcDXkNNV4VK3Kvq4f7lRGg9TAK9we71Y8=; b=mMunDyRpRMl0SSik8PLIkOaVQQ+AYGeZnrTN8QzbOPF9BX7Y8BWQxFX7phcMsLkwgB 6GHVNrTHUjzSMC6Ia9vWYeBkeiSxNjNZjqxXY9TD23ISCuAOYOoDFHxf800RMLHflXx4 ehaYcGP1oOIL3lHNTzNVObsBK/VfNZlAo3A7BR8TVRiUWH324rPHt7bWYGJNT/0/gN44 X+plYCBRfoYoXP2HXf7iG6G0Q2Jcig0lODyUbYNGa9asvW5e2/85gWMpofOncpYpCrCf lVjsdgXgwJ7I52SChYXso20m4hXSvoLhuBvf62xUbrHCrimGhQJ53j1EgErx/rD8mSQH NEPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151125; x=1744755925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n6YenbA8rChcDXkNNV4VK3Kvq4f7lRGg9TAK9we71Y8=; b=oFvV2FAjoJtD/n0thKWJQozy3AjxcdgUhlPmONnLNyvbyOQonvAVUO3K5UK3QjzFTV TdgQCAJCYckp/uIpHlhNlBOHWCBAsOvW/Bbm1uwo9BPu9PCVIF82+aEU2AEY55TNjdKJ hTcQaEofGyM8uT9geWQQePHQ/gXGg9NLDu0FR5LeeFBI/gm55wOBE3ba6XciScTXPHMM rsxmUKwzpJcnDnAGTqhYKMDj1wIOfLEaY8hkTeuFY0MBockGQ8Q38fg/6QHYZAtMyO1O ZZ4Gj8qQhetUMJttEqNBhtMIQlvCMpLyg/vXhzXbOJXF+t9jJvu1R2uu/5W/7mDrSWWj 6otA== X-Forwarded-Encrypted: i=1; AJvYcCUyqq/SecEmrFawWyXKUBkcojoZF1uFosRWWcfKyLSSNZA53a87oEdpyQx1lYjyM8KgVmyPeSODvqm0FuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzPdyNbuxLFbEzYZhj9feRTMHozAM7MLM8lNJx4RTQ90DleKNVQ ZDjNLZbn0BZPW/XFnLKB6mIxR/WvSPq4ODtK93Ya+uQxMOVnjCymS04FtHGQDQ== X-Gm-Gg: ASbGncsW1lRS4c2s693U/n+I9IXTDOyh4Pjw87+R2Y4+V2aqX96XxLlx3D2UKXPmvcI wHp4enSl6LEfLHiETJNekLNHAAQaHm1+dPcF7RBr4tx1k88NG8gJtFjMKpnKBCwaADEUnrMl0sZ IZLEojjSHJp6B2ByVyk5R486p1t50nbeUWta5XyJrFa3S0rDb5hKBacxrnV2WxQTYPF66qEivbj 7uMAWrJfCfVRkvatT/GsYbuelKJaO8PmRn9ILeaJm1WcMC54n8nZwAkpWSxNoziiRto1wCnWh9W 8a9/x+JR+SbnqSax05iFzO3iTBZasDZ7L6nJ8uMvls1Vd35nI61nOPQJ0RcX6b2p+ZJAqLmHjR+ I38RceOZtnQ== X-Google-Smtp-Source: AGHT+IG+i9FqESkEDkmuuTUSiEQCuG7Ql/F71HjHIc2UYj78Q5uhMp68wFWb/XNYqyLoS71h+/Argg== X-Received: by 2002:a05:6a00:4c94:b0:739:b288:13e7 with SMTP id d2e1a72fcca58-73bae527674mr835294b3a.15.1744151124687; Tue, 08 Apr 2025 15:25:24 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d9ea09a5sm11572528b3a.107.2025.04.08.15.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:24 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 13/18] staging: gpib: ines: struct gpib_interface Date: Tue, 8 Apr 2025 22:24:59 +0000 Message-ID: <20250408222504.186992-14-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ines/ines_gpib.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/i= nes/ines_gpib.c index 93897088f6f2..7d53f6592845 100644 --- a/drivers/staging/gpib/ines/ines_gpib.c +++ b/drivers/staging/gpib/ines/ines_gpib.c @@ -539,7 +539,7 @@ void ines_return_to_local(struct gpib_board *board) nec7210_return_to_local(board, &priv->nec7210_priv); } =20 -static gpib_interface_t ines_pci_unaccel_interface =3D { +static struct gpib_interface ines_pci_unaccel_interface =3D { .name =3D "ines_pci_unaccel", .attach =3D ines_pci_attach, .detach =3D ines_pci_detach, @@ -567,7 +567,7 @@ static gpib_interface_t ines_pci_unaccel_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pci_interface =3D { +static struct gpib_interface ines_pci_interface =3D { .name =3D "ines_pci", .attach =3D ines_pci_accel_attach, .detach =3D ines_pci_detach, @@ -595,7 +595,7 @@ static gpib_interface_t ines_pci_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pci_accel_interface =3D { +static struct gpib_interface ines_pci_accel_interface =3D { .name =3D "ines_pci_accel", .attach =3D ines_pci_accel_attach, .detach =3D ines_pci_detach, @@ -623,7 +623,7 @@ static gpib_interface_t ines_pci_accel_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_isa_interface =3D { +static struct gpib_interface ines_isa_interface =3D { .name =3D "ines_isa", .attach =3D ines_isa_attach, .detach =3D ines_isa_detach, @@ -1215,7 +1215,7 @@ void ines_pcmcia_cleanup_module(void) pcmcia_unregister_driver(&ines_gpib_cs_driver); } =20 -static gpib_interface_t ines_pcmcia_unaccel_interface =3D { +static struct gpib_interface ines_pcmcia_unaccel_interface =3D { .name =3D "ines_pcmcia_unaccel", .attach =3D ines_pcmcia_attach, .detach =3D ines_pcmcia_detach, @@ -1243,7 +1243,7 @@ static gpib_interface_t ines_pcmcia_unaccel_interface= =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pcmcia_accel_interface =3D { +static struct gpib_interface ines_pcmcia_accel_interface =3D { .name =3D "ines_pcmcia_accel", .attach =3D ines_pcmcia_accel_attach, .detach =3D ines_pcmcia_detach, @@ -1271,7 +1271,7 @@ static gpib_interface_t ines_pcmcia_accel_interface = =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pcmcia_interface =3D { +static struct gpib_interface ines_pcmcia_interface =3D { .name =3D "ines_pcmcia", .attach =3D ines_pcmcia_accel_attach, .detach =3D ines_pcmcia_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796EE25A2DE for ; Tue, 8 Apr 2025 22:25:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151128; cv=none; b=nXeWQg+Ec06BhKgZZ3NbmmZKpiVBZ/2vYmWpURa10mcKsY3qsjzmduA3T/o+sF8He1at6CyAwwHg3QPg+NSMIAQ6JUFy0VjhMX3oDw1mioxj/P6L0AcZhFff+T2/2W4OQ1Oq+tHC4a4UYba/DMZo+TGaBKfB4OcV3QUAFF2vqw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151128; c=relaxed/simple; bh=aotjQhayfde11pBuCYSMkPo/542taqwscZUcYD4hF4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KvAXYQuvYE41tQWSW0bBY/+3T3FVajfRqunYZ9pARjXmcgNVGEp5QEKzFalUNk/6gRnbRBKNpwiinpubZYQOXMYCRoSD++HxicvrqlDmyqMtZvLXDqwEyM53H2xM6ySqOwPqsdyDhAKuY86+JnW0EUHgSc/Zd77Uz12A5YgvBEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=mKGcIMCK; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="mKGcIMCK" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2243803b776so85384305ad.0 for ; Tue, 08 Apr 2025 15:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151126; x=1744755926; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+y3vOzvRwsIdZi2JyqyS7+haX78zm+EDNg0eHrvZINY=; b=mKGcIMCK6fLU7beHVea2t6te9Fs0e81hjbnJ4QTTG4VbRM7jhlzooKsyzw93aND6hT ci48Txhtw2W7iHVhscBVgcmiJliuTUN5Su81yoDEca2S7NPOdOt3hEELjJVbj7AuhnCk AynmTVyu24iIr7gQAtTVwLvdFslmauaN4GySLLke2DkgR5iU8JArA/Xbqq8HgbKRueKs sdSnBQ0Dp5tOJasmTMK3KBg8K6VOWajoer3QBxHXFLtEwyD/rH/ZBekuYcAJIkS4tPtI ysaEdI00ahg88+vOKcNwBYrkMISVIssZqZNdl50hSpY1z3pWPUtAeO3nUmwqo41IoVQ8 sOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151126; x=1744755926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+y3vOzvRwsIdZi2JyqyS7+haX78zm+EDNg0eHrvZINY=; b=CyHg+vBgXpGt0vErEOhbSIclSACGEmq5gOaD+OdGJMQOIydHU8KUmKk418PZe1fA7z RibeUY6OvfBlBrFFqW0iS/vp93o25rm3hmpxOPqsDnxrlWJTM+wC7PhgY+Nv5cZjMnVb qaxX7eGVR22AO64sS1hVg0EmIXggxocrKYHXRgjnyzcxOmu/1KfiErvSDgZoG7lRao8+ YYYsFzpMXJ0AmQFVba1/gd4V5Wk6t+CQ0Gi5p1oECgA4lAtPCEZ6YHek7FIbDvEFnne7 hpLSw7WCMSH0vfN56cKiTVFsqQUuVqZRzfyutUywA3pK9kxI3Dt7Cx9ibM1ofTEClrJU 6Gfw== X-Forwarded-Encrypted: i=1; AJvYcCXLnx6271rEJS/9UBnisbItCZCHLCywP8GA0/5JD4B5mXfJoe7fereVSzEMViZYjzPOINawGzJlnD2k1H4=@vger.kernel.org X-Gm-Message-State: AOJu0YxZLTzXel6r3sPnWXAh75OQe7O2rt2eMkHpKMLA13wj3TiTKl1k H+Fws4heqvx65y5Jyd+sMozPbHfXreKXYPyfqgB1VGSDOjGt0wJW8KW4nnb78BksdoZeLsyjYpc = X-Gm-Gg: ASbGncsRG1xOPRxb+7lincElVSd84lxoKduHXvjtN+Q0n6zEh94mNlue09uJp8fJQMd irR4AhoLWiXv/i4RhfgB4gMBBGpTavvBg/X868eomAEXRiNA/iur3ygOF6p+FHkyTycyUxWjGTt r+fI1ddz1/yVIgzwOFJNqYIsINK9aknTXQlkJAmUHeYeXWxt1ZC00IyjsyvV8/lRaRzVzsoq1fS sh45k1dtClAXq+kucgrZhgyekUmbJFpl4e1EGeAwONnYbiKAp68YXHssCH7n7lXy9dcv6QGQ54x ojJKqCED5fGX5Ei5E0Vz8LCp3U1ccCAGesS8eHsQXH7BAbKvYNm2UdgDqtrZ7zyb0UKMA/lkj5D OoX4RCN227g== X-Google-Smtp-Source: AGHT+IEFsOIdLyZPCOfJFwBag4ZcDio9PNzxGSt0K1n7La2fdzlWclz3+1UZj0jjYvhUX09Xbu6XrQ== X-Received: by 2002:a17:902:f64b:b0:223:65a9:ab86 with SMTP id d9443c01a7336-22ac29a59b0mr13846235ad.12.1744151125867; Tue, 08 Apr 2025 15:25:25 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297866e3ecsm106501235ad.198.2025.04.08.15.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:25 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 14/18] staging: gpib: lpvo_usb: struct gpib_interface Date: Tue, 8 Apr 2025 22:25:00 +0000 Message-ID: <20250408222504.186992-15-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index faf96e9cc4a1..a4bfa95357bd 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -1053,7 +1053,7 @@ static int usb_gpib_t1_delay(struct gpib_board *board= , unsigned int nano_sec) * *** module dispatch table and init/exit functions *** */ =20 -static gpib_interface_t usb_gpib_interface =3D { +static struct gpib_interface usb_gpib_interface =3D { .name =3D NAME, .attach =3D usb_gpib_attach, .detach =3D usb_gpib_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB4525A33F for ; Tue, 8 Apr 2025 22:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151129; cv=none; b=MNK8JQEuU6uY1g6akxxMu4tHfJmAS/ef5HFLQ2dl646UYQ3ikL4hwjNcVRoWa1s6Rvsk0ktR4M4Rll5yNea9BSygfDQpci8LT+8Fl4JU14ilD3ptCGRu6gOitMoUZW1n3Zw/KFSvPyIiCtAHJmlYEyQnO4V52QyGeKQmHzcpDmc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151129; c=relaxed/simple; bh=pwMACUUFlk6EJPa4bMjnzbX97hafZSOHuPR4dKrIeeY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UTDa27YT4jxLlFnkrAEjLvfaeylYFLTbGkZgqfVtAQ70evs3zFTNe6sSVng+0llZCHBTmPI5c55gMUNYRZulOgSSUUMQ91caFlrCy6tbUqLqxUXAmL1vtuLkaf9/D3BnIGXwHGXSj0WK1vLmbtRAbIlhr0c9YmW/zf0KiDFAhm4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=bDOisnJO; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="bDOisnJO" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7396f13b750so6291395b3a.1 for ; Tue, 08 Apr 2025 15:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151127; x=1744755927; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H6DPxOlzhlYllRH/6vmFWTeCTxnNAuVnsmGi0YRNeL4=; b=bDOisnJOt6CrythuQwjq9U4Y2dCNFIa2n/tZaNZJpaIVohHQMH+80mEMPt0CfqLQqN SIna8jWMADj2jH5P1WKGxFnidpNfkGTzApvxpZx9qXdY/U6+Jb85f3/+M1U+EJC7nc0X ZqFm+ly7POg8LRGd9BJjPJPxtQx1NoI9DXL9yccxs0Vvl2usugi9n4Lu2OUCV5E3I9Yf T7FnM6OqapJRFyMuC01RUdBWyonXEG9g8fKhUYqdhajK8bojCnEbpPxTwypXuT7IHJl+ A9phmG0TvffPPPAa4fc6tFEdvC/O+M1JK8sLel1No4JFgVhFAAr9hO9jdBgp1+4dgGGa V8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151127; x=1744755927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H6DPxOlzhlYllRH/6vmFWTeCTxnNAuVnsmGi0YRNeL4=; b=BNKJtlw7mQPuQvU1E2snisE9Je2v0i/v+fabFaPEkcfmXVEgVT9HYb5jLyrVBsDsDe K2ZF0Di9vTw9aTMhPWAp8D4a8O2N4qCjGWwFJo1j60PP3eY1lAoK4kvSm9c7c7NpJdtv hxixkARGKMOjhjs4Qi3DSRHC+kVEiY+rvtlZSOnivOgaAhKIH0/mV4esmoemIzpAfHcS I6bJFXBCa+9drbi5KrtvpbInbN+GPl5On/S2Rtk4u7INdYal24WucUFvnHodjEYk8qz0 pNFP/dIkzUFtcYrq0/m8bcOQ+RPeBO0doH4H9bcIX2ljTs6LTuqubuC8pXMzNstc5+O8 +s6Q== X-Forwarded-Encrypted: i=1; AJvYcCVOnY86yiA/EZ2kyToUGiel2+FY1jhBiylfR7eAsALd5pX0edpbRDaaX6+JZkZUeXvl8UmyrqwKH/oVPNY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4rn9NkmOfblTZ+7e9no0fjgCFGojOow3Pq85TccTunNTvefrD s6MavUbHEQ2OmNbkrtZkCVaRBRn5y4Q50V1/lAh2uYKCtMl9BwRjMFsqqhZh9w== X-Gm-Gg: ASbGncuUYBSOKhLixIRfW1HMdiG/ql3fYiRz2dRcQ7r6jV/vAFx8SRfxZoYqI8oDzSO 48jh8zeC9Q1WNjLAZVo1wO7IAYpCdeEP4vNa32pA0q5K3uwvKSmlEvDsMfXjf4uC3r6Oj1bZR6K bhX9uyMmtt1AHyKYT+0zAoChH9P5Ighc6fukZZu+n5+zf6IH6sNLC6Dy7DTZan9BpCOSXlvJOIT dXK+dF434WMX8cWfBJcyYn1n2ggrZ8Z6veEEQoBCw2NS5NlN0sT7wUH+xWJfP1jwYzasR4MBS14 sEnCzHfioXpgjpgJDkxu1eh7SonieabMS7JTfO7VlRs02a8apx6QSD7g6BWE6p8qoPtHPtjbImL PXPVE0tSHrQ== X-Google-Smtp-Source: AGHT+IFdRcMhc9cN/ofWKCjwvcJpIKZ/rH97I+mHfxpG86JlK/ig74gEs6cZ8zLKxi7JsG/vNcg/Vg== X-Received: by 2002:a05:6a00:2e0f:b0:736:eb7e:df39 with SMTP id d2e1a72fcca58-73bae55140fmr865204b3a.24.1744151126998; Tue, 08 Apr 2025 15:25:26 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739da0b3009sm11133766b3a.123.2025.04.08.15.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:26 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 15/18] staging: gpib: ni_usb: struct gpib_interface Date: Tue, 8 Apr 2025 22:25:01 +0000 Message-ID: <20250408222504.186992-16-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.c index 14f7049a8e5e..715848a3bb75 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -2361,7 +2361,7 @@ static void ni_usb_detach(struct gpib_board *board) mutex_unlock(&ni_usb_hotplug_lock); } =20 -static gpib_interface_t ni_usb_gpib_interface =3D { +static struct gpib_interface ni_usb_gpib_interface =3D { .name =3D "ni_usb_b", .attach =3D ni_usb_attach, .detach =3D ni_usb_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C727525A353 for ; Tue, 8 Apr 2025 22:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151130; cv=none; b=heIo8ndPsiMrpTEiV6uJS/AbY6/NfeAm57A292QniSXZ7VdWoD8gnzBkUR4oGucQiWzfZHXKaVO/MUkvnpJFnJvWFM8Fvs6kFP7HRxTUARLHJvgZFM1emHgAw+ezFgq5lIFL4GZrmEiZtEOdukYqFOgq4ZqTi0SNxDgIt20Ghl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151130; c=relaxed/simple; bh=/JUAqAmra1E7oPDlGlfnYHBsae3aHwZcq3xJ5pyOY0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hNRLPDXR/sM9FvpTr9eldWGc19tR/rTqellXRqUI2MOrEVg6BpgQ1JcgS0JRVFWpGDnbDc4uUg8LxZU2F5gb6fg9k3LU9OLAv97KZcpMpJXIHKByKIN56WJgKWgy0DbOb8kTAsGqN+L9W95G9PYE++HnGxjX4czrIwbC/GP2iSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=BuXJd2Yk; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="BuXJd2Yk" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-736b98acaadso6073870b3a.1 for ; Tue, 08 Apr 2025 15:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151128; x=1744755928; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jy+kPEqBIyOomigqq8ELaZaIXgSLvhQ1H1rYxS1Gxp4=; b=BuXJd2YkqGapW3iLLHecPVLJHsckENcrLOQmJWOwYClYfguqsiABG7df1mDcu9ErsH 2x2/2EJoH2CaW1HphZEvVQsofROnOZzT3iz3EJ2P7J6BSOYCywJBkylSX3aaQVmli2r9 Wkk9RDGC2JVR4YFbV1e+IUYEVdUziVmveGvGjf76rMNANxnl9jQSEcfzrQMtnlC8Tunv CdJQ4NLGtkuHRYqQO6dM7yoRFbplH4dnfeucB1T+HBiXwiOoJo2rvDKxGeW04WJGWQOM ggs8l7KKjv8Bg9XKzCoW0DpXqxXnWerXogXo0SV8JYNlzWhVqLhbMIkJ9lJk5wyYhsZR /4aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151128; x=1744755928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jy+kPEqBIyOomigqq8ELaZaIXgSLvhQ1H1rYxS1Gxp4=; b=rGa100cfQyzUGwjzBUdzfRFpZBxrlBVCguWpoymYiwrb+kRVeU8qc3QxRDt6Dgw9bs m6f6zYomRDh69VdN0lVuSEhWN01qDaywpQLAvw3z7wO202kF0MV85g+LeECxRMgLfnn6 gLK5GsTmQXMMJU6hfSYd8gSxkT/2kZjZVlC21vGKhUQ9Nixe33elRc3iYyKh4SOZFLzo 65f65Soazh2z3uYte+r3QG9SMWFgfdTIP+QzHXzcWFHPZQxROq9szD2hRW0kODa92yyx kGE4FR3/CG3nvYL2qCgBLwszdhWf4+50x2T/5fDySqygwBSfrAUNa/tFE7yT9Hev+BQz Tywg== X-Forwarded-Encrypted: i=1; AJvYcCVAsyVA9EJ+6YmNShhhf1Zar+y0vVCi96eBYBD/xFjoV5Ic7VW6/D/WmWxhMF41FV21k2M63P/LxN2cDs4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx8TdO/6V8yTVMxqQeQkS/ldpC/7eA+7Abym940s5jMXaFYNhR XIob5Xrvo3e9cCo4y8ECL5uK9BQeobNtm7aDrOOkpAqdgGFl8sM3VKYwATHL7g== X-Gm-Gg: ASbGncsO7a8tjhjHZPDVamzcciTFRVOkkcHgemuR+/nN191m8O/fdxwtVM9/Ndjwemu P/a4IwpNShOXJ2nGrU8bzzkevH5CLzaNG5ojzSgdzbctx778TJJU88N9jBuHHDQm/9Xq86U1WS8 VYw9OPtjSyD5vnMXrZdbbPGrKw0z8e/gST79RU0EGitESMn/oXFwREeN5nKvQ4EBZccGV013DwT vnWuBBx1vpxt7SVBO7TG544fOu3IcFKEWHAjXOFlMr7jBDPPt1BIzJLzOpK/sZ5Cvxq7HQ0072d wVHUr6lDizL/B8PJXGfbOjOMJ/gLXIpN9JQtvaZK7VdksDsyif1NKjdCCMDCEEs3OjpSAPKeSJy 4lA+B6yhLjA== X-Google-Smtp-Source: AGHT+IGYcDiGfn//VUp80eK8CC0HS5yxbKQ4gMtbUnVfAKbMWSzcyk8g2p+esNPfkcUEnZ/yPM4+eQ== X-Received: by 2002:a05:6a21:350d:b0:1f5:75a9:5257 with SMTP id adf61e73a8af0-20159195c99mr930918637.13.1744151128164; Tue, 08 Apr 2025 15:25:28 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc2cfbc9sm9615527a12.9.2025.04.08.15.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:27 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 16/18] staging: gpib: pc2: struct gpib_interface Date: Tue, 8 Apr 2025 22:25:02 +0000 Message-ID: <20250408222504.186992-17-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/pc2/pc2_gpib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2= /pc2_gpib.c index 5ff1d52c14e3..b0b19e2d4782 100644 --- a/drivers/staging/gpib/pc2/pc2_gpib.c +++ b/drivers/staging/gpib/pc2/pc2_gpib.c @@ -518,7 +518,7 @@ static void pc2_2a_detach(struct gpib_board *board) pc2a_common_detach(board, pc2_2a_iosize); } =20 -static gpib_interface_t pc2_interface =3D { +static struct gpib_interface pc2_interface =3D { .name =3D "pcII", .attach =3D pc2_attach, .detach =3D pc2_detach, @@ -546,7 +546,7 @@ static gpib_interface_t pc2_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2a_interface =3D { +static struct gpib_interface pc2a_interface =3D { .name =3D "pcIIa", .attach =3D pc2a_attach, .detach =3D pc2a_detach, @@ -574,7 +574,7 @@ static gpib_interface_t pc2a_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2a_cb7210_interface =3D { +static struct gpib_interface pc2a_cb7210_interface =3D { .name =3D "pcIIa_cb7210", .attach =3D pc2a_cb7210_attach, .detach =3D pc2a_detach, @@ -602,7 +602,7 @@ static gpib_interface_t pc2a_cb7210_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2_2a_interface =3D { +static struct gpib_interface pc2_2a_interface =3D { .name =3D "pcII_IIa", .attach =3D pc2_2a_attach, .detach =3D pc2_2a_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CB1325A645 for ; Tue, 8 Apr 2025 22:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151131; cv=none; b=Be8+nuowUU0FGNHrog3GpzUDFLIbzzCEajg4Do/SvGq+RJaJ5gZkA7AeWBudd0ZbBNm4a2qDywBpmmnPxb0jglTguFHSU4gmpD38agv2nryQGc/AFjH9a9oRjFmOLkJZ/Ucws094ynKxgXCV79iwZ2+q7oMUTxsoTT6bDgL9xg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151131; c=relaxed/simple; bh=CTkuchpWwxVlAy9Q3huxyw74RcuiMEQlO21k2/y3xtM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dvENKn4zYcDz3L84qX5Pw80RS5BRqY6qAbLVJyC+Nab3XYSYbg6+/MA8npSKbEoRQww/KSou+HrpryyKj2jghf1C2ZeR7IdcZJbJOjjXI7WHZ+Q/9qvDXv9RaQ46AOLT7dmJqo/xQslLbJLY8OfGfFyh5utN0+zpYJgx/Xb+FvY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=cjWyM7sx; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="cjWyM7sx" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ff69365e1dso4858924a91.3 for ; Tue, 08 Apr 2025 15:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151129; x=1744755929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BpuF8/8p8vziE36GXyTG1Lw6cnZL+l12I1BHpvDEYzA=; b=cjWyM7sxcIjJ3/wWMdv6xGD+dV53mj7cPNA205+CUlXfGz/iQi8WW3QPwMc0BUpbB0 m7438JLjA/BIosjMKKlL622VpBFo/eczJBaXj6AgIZQTMQB33rrvhGCZladdTxVU4JsL QUGySdtrzeT4V0bEjXr+uI/F+LP/HP4QgEBOKUmXdjuI2PxmwzgeQauqnXyVh+U2vAKS bn5Lo3WMeXWFhKd7K4N8nxNxxPDNwU7aCOYVBA/TLNcQJq7Dt4Jg1dJXVPr0ZIjhJhq+ 7LhBqmaiQ9woDXGd928n4Cth4T4yUrkbjqbWry1ULKLlmn7V9XDj99qZEotGNwylDK8f r5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151129; x=1744755929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BpuF8/8p8vziE36GXyTG1Lw6cnZL+l12I1BHpvDEYzA=; b=X9ZZZfiH+eVk2wjxwOF5TYzpn7MdbJ/suRPMmNMJceUv6fAlQ0zGDW0G0BOvI+rJjY DabGyNjYoqWQfLp2CeS4C0fViBrdkrkEiGKYFT7P/esOKQvx0E1KdFOgfQcBVALEBP3t JXAocIUz7meFSRcCuYZk2SLug76pIAhOWxlPoup9NfN0gdrvCHBL8YR7NUWGLuqYKRp+ zEnXh+MRNRZxknBMxwLaftDIIc5Nk3n/ICoNWKNXvgfJYIGJ4B9ZFc5ZBIhGjeByLz83 9b3Jyjac2X3y+o1PQVov3ClXGXCv4ghIArrn5l4hzbIp9q8qFs9sEqA2o69ZjBAsYy8F 0S7w== X-Forwarded-Encrypted: i=1; AJvYcCUdVASCo5MDs6G6s2vKrPDEm5WqklohDhQsYF8lDOWUua9jwXHksuznDMEMYQe9GnUV3i/uFLqhPj/KJj8=@vger.kernel.org X-Gm-Message-State: AOJu0YxDEGMlRdb2vXOEuFqhYRhMHmIA7aM/im2YQCLu+CU1A2CiCEPN Afyv1N3TrKHLoRNud6QNa1BCkEPf0CSFwVCq/DYaKi0Yn12wxDK1prvAGAQQ9GOdm3w2Odb5w+0 = X-Gm-Gg: ASbGnct7vXtGSOVdQ8T6RbLSCAQV0P6THL8aTuFaIb3fm/GUsPUQ+vZZ9n9h8ugA6/y zXpZ4EJZUhFM3eUsJWza17Qyw8ejhwObCuN3EbJwEDijGmLifKn7/E6hhGdxFVAJrU5I0v3U53t pxXmSeJmii6RQHv5BnvhRezFoRfpn5f+90oO17y4Xo2c+IRvuLrcgXgYYPbGpQ9GM5dezw4ZVoo XLNbAWGy0Kvgf/9RAGQ/9a0yUjoWOlABPwZ6+wZIve5trzWqQRsSDtnyT2L99xrZL/GdGZT8GUF vzAG/IB8FJSfdzTX6byMGYUhhpvH6TarRsw2AV/SHvSTBgUetnLoCzu6keqdUK1yjPwd0gLofAu dkq/ys1jrWA== X-Google-Smtp-Source: AGHT+IHAwKj9OOar9R8OAylcpYrbMoIxJRIVpH7LfgstnadVPEuA6wrPm4E6cjggnU4E9R3aFZUfcg== X-Received: by 2002:a17:90b:17d1:b0:2ee:a583:e616 with SMTP id 98e67ed59e1d1-306dd51c13cmr275559a91.9.1744151129312; Tue, 08 Apr 2025 15:25:29 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3058494a3ecsm11592364a91.18.2025.04.08.15.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:29 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 17/18] staging: gpib: tnt4882: struct gpib_interface Date: Tue, 8 Apr 2025 22:25:03 +0000 Message-ID: <20250408222504.186992-18-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 24 ++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/= gpib/tnt4882/tnt4882_gpib.c index 3b29f541fd49..596e2fa40dcd 100644 --- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c @@ -1116,7 +1116,7 @@ static int tnt4882_pci_probe(struct pci_dev *dev, con= st struct pci_device_id *id return 0; } =20 -static gpib_interface_t ni_pci_interface =3D { +static struct gpib_interface ni_pci_interface =3D { .name =3D "ni_pci", .attach =3D ni_pci_attach, .detach =3D ni_pci_detach, @@ -1144,7 +1144,7 @@ static gpib_interface_t ni_pci_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_pci_accel_interface =3D { +static struct gpib_interface ni_pci_accel_interface =3D { .name =3D "ni_pci_accel", .attach =3D ni_pci_attach, .detach =3D ni_pci_detach, @@ -1172,7 +1172,7 @@ static gpib_interface_t ni_pci_accel_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_isa_interface =3D { +static struct gpib_interface ni_isa_interface =3D { .name =3D "ni_isa", .attach =3D ni_tnt_isa_attach, .detach =3D ni_isa_detach, @@ -1200,7 +1200,7 @@ static gpib_interface_t ni_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nat4882_isa_interface =3D { +static struct gpib_interface ni_nat4882_isa_interface =3D { .name =3D "ni_nat4882_isa", .attach =3D ni_nat4882_isa_attach, .detach =3D ni_isa_detach, @@ -1228,7 +1228,7 @@ static gpib_interface_t ni_nat4882_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nec_isa_interface =3D { +static struct gpib_interface ni_nec_isa_interface =3D { .name =3D "ni_nec_isa", .attach =3D ni_nec_isa_attach, .detach =3D ni_isa_detach, @@ -1256,7 +1256,7 @@ static gpib_interface_t ni_nec_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_isa_accel_interface =3D { +static struct gpib_interface ni_isa_accel_interface =3D { .name =3D "ni_isa_accel", .attach =3D ni_tnt_isa_attach, .detach =3D ni_isa_detach, @@ -1284,7 +1284,7 @@ static gpib_interface_t ni_isa_accel_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nat4882_isa_accel_interface =3D { +static struct gpib_interface ni_nat4882_isa_accel_interface =3D { .name =3D "ni_nat4882_isa_accel", .attach =3D ni_nat4882_isa_attach, .detach =3D ni_isa_detach, @@ -1312,7 +1312,7 @@ static gpib_interface_t ni_nat4882_isa_accel_interfac= e =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nec_isa_accel_interface =3D { +static struct gpib_interface ni_nec_isa_accel_interface =3D { .name =3D "ni_nec_isa_accel", .attach =3D ni_nec_isa_attach, .detach =3D ni_isa_detach, @@ -1371,8 +1371,8 @@ MODULE_DEVICE_TABLE(pnp, tnt4882_pnp_table); #endif =20 #ifdef CONFIG_GPIB_PCMCIA -static gpib_interface_t ni_pcmcia_interface; -static gpib_interface_t ni_pcmcia_accel_interface; +static struct gpib_interface ni_pcmcia_interface; +static struct gpib_interface ni_pcmcia_accel_interface; static int __init init_ni_gpib_cs(void); static void __exit exit_ni_gpib_cs(void); #endif @@ -1769,7 +1769,7 @@ static void ni_pcmcia_detach(struct gpib_board *board) tnt4882_free_private(board); } =20 -static gpib_interface_t ni_pcmcia_interface =3D { +static struct gpib_interface ni_pcmcia_interface =3D { .name =3D "ni_pcmcia", .attach =3D ni_pcmcia_attach, .detach =3D ni_pcmcia_detach, @@ -1797,7 +1797,7 @@ static gpib_interface_t ni_pcmcia_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_pcmcia_accel_interface =3D { +static struct gpib_interface ni_pcmcia_accel_interface =3D { .name =3D "ni_pcmcia_accel", .attach =3D ni_pcmcia_attach, .detach =3D ni_pcmcia_detach, --=20 2.43.0 From nobody Sun Feb 8 09:32:15 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4052425B692 for ; Tue, 8 Apr 2025 22:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151132; cv=none; b=ctN6TAIZx2LVF8B9USMFklHIvoY++uzRkhYTCrirWpnFFRASZVr5Vb6B27g1byziOdzmSPclNn5iQnNl7V2yOcKVKb8Fxf5gVnzm84m/ks+XLCp5mhFGmxCOPhIeybOMD9G2iBjEgq5mSRJS/y4q+9Wx8o/+U8aMSZhwMLD6odI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744151132; c=relaxed/simple; bh=IV33bcMgVBe5I6EM7iwIC0bbwdNio1NkiOrIO9AbCT8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ClyjgM7zB58glliJd/NqkaossL2B6ooT0JBEwdvy2Jyj4NlnwB2Z27wtd0OgYLcrfXCyh71jCtmuD4F4EJhaudIGP5WZdiUEipYN3j3yhwVOFfGx5yRlM06g7J9z76ThvKCa+1xUZqTxQzbIZa/FI9ihBrnHc708ckIhsk5FNSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=ZeEMGw3g; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="ZeEMGw3g" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2ff85fec403so117638a91.1 for ; Tue, 08 Apr 2025 15:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744151130; x=1744755930; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9abTSO9nZ3GBHkjnW8Fgqsuv8V0aGDcD6sa8F+6ju9w=; b=ZeEMGw3gKItlErqgprWDXjJqFTbI3xZ0TN9xAl8TyAMeshkX9MTxTf52vhUGw3XeaC aeAAfY3koRTEBcD1nVXG/sMJhpOQz2T200w9IyvAPYgeY+pC9ijbEyTjylh84jNb5z0j DXKiLbp7Lo8e/LqtqP0wCGoIUFxBnWyaO7LOCqC2drzjLvjy+mZYt2uqL0ErWtw/gb+K EdEdi0yFMguWwH4zlK7Xu++JQP1uCKdQMx+zHj21ve/dvSGdAOpUp3E1QrAFgBOOMC9k Ovpgvy3z6P7cbSA2KlbzlYjkHNqHqTchtnXMghzF/rETAW3ASmYcR+fbaQASKGL1r7xI fOOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744151130; x=1744755930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9abTSO9nZ3GBHkjnW8Fgqsuv8V0aGDcD6sa8F+6ju9w=; b=FnLJOtKfF1X0/TNfjztNDfj65Zpnd5kiNd111MCMVwDM8EpCWDC9Ux9c9Lmcbbox+v GdTZROsQ6oJj6NHib0HjrU5RorCTB9XTMroOAcjamHls0w6mNFtl9F7EgovFH5O1pXTO rMQ4afMKQa0gf7f/meZy655idueBspStEOOmkfZvs/XVZa4sN+mzTRpAoEiUWjl0LHWD AIMcC+3BFB3/EyQ9ijtVBc/7gRHHOqSb+nP0cjvPOW2iyR1ynzFoviE9eqBC2sKlBEPw phGXgXImQoT1o060h+lFDieWEYE9nllffe1ASx8Jjhf2D6tSCVv8vVSZe1GZeGE4qhui N3pQ== X-Forwarded-Encrypted: i=1; AJvYcCU664JhN30OBzVhHjdruGq7p/Nbx9RxAhbIOZeBvPptLklGnorkgcZJQvy8FTQWP634yE3kPKg1y9MzjXU=@vger.kernel.org X-Gm-Message-State: AOJu0YzpLSGJ44XT9ATaZH7Z0dH7hnflg8LVhE2mMYYC7dZKktyIvAx+ o7UQKQ+IbWlUSSJfftWzBe4KVmlpLLr4r5b7IEFR4fogOL6mpcmV7OnBjuAASA== X-Gm-Gg: ASbGncvvOiBQUqbiw58nECFMEAIoXMd3TfKaFpOjZL1Q0FY4UxAwOXZshpiS/2Vg+uT 4OPv2V5eYzUvZifXztsCWCigzzoMiFGbYJBLSarS3OwJ6fI9NHu3oGseqduxKSjsozdTuFa7ZVw GMd8cd95bv6HMENlCwWEL4MSnvtM154ZucDDPSRqMG/qVloqAukf7nr8lHiPV5nRfi/XcCeewWx NCdSrm3LPbFGYaahjhxGFgltIky1wofbhwvwLrxAxGtM1xXtE3hGuPr9OhGc0gvQjBAfCg9uPvH jvB+a7b6feSMN1y3eRUkMPFEzAyfMdTKsjYwqJkXNYTMS1WH+lu0Yxk+q9+jth1/fMBHds44bz5 Gdyymak5ROA== X-Google-Smtp-Source: AGHT+IHMn1TPpOHHBZRpWsG38siKEoVe+9cV6YunkxSqefSZsDaEv+3mbT22wiTe0ySfjGWQ7y8VSw== X-Received: by 2002:a17:90b:2d88:b0:2e2:c2b0:d03e with SMTP id 98e67ed59e1d1-306dc0452dfmr964780a91.5.1744151130434; Tue, 08 Apr 2025 15:25:30 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-305983b9924sm11542551a91.39.2025.04.08.15.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 15:25:30 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Michael Rubin Subject: [PATCH v1 18/18] staging: gpib: Removing typedef gpib_interface_t Date: Tue, 8 Apr 2025 22:25:04 +0000 Message-ID: <20250408222504.186992-19-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408222504.186992-1-matchstick@neverthere.org> References: <20250408222504.186992-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removing gpib_interface_t to adhere to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 10d8776ef425..a5c21ac6affc 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -8,7 +8,7 @@ #define _GPIB_TYPES_H =20 #ifdef __KERNEL__ -/* gpib_interface_t defines the interface +/* gpib_interface defines the interface * between the board-specific details dealt with in the drivers * and generic interface provided by gpib-common. * This really should be in a different header file. @@ -22,7 +22,6 @@ #include #include =20 -typedef struct gpib_interface gpib_interface_t; struct gpib_board; =20 /* config parameters that are only used by driver attach functions */ @@ -212,7 +211,7 @@ static inline void init_gpib_pseudo_irq(struct gpib_pse= udo_irq *pseudo_irq) /* list so we can make a linked list of drivers */ typedef struct gpib_interface_list_struct { struct list_head list; - gpib_interface_t *interface; + struct gpib_interface *interface; struct module *module; } gpib_interface_list_t; =20 @@ -222,7 +221,7 @@ typedef struct gpib_interface_list_struct { */ struct gpib_board { /* functions used by this board */ - gpib_interface_t *interface; + struct gpib_interface *interface; /* Pointer to module whose use count we should increment when * interface is in use */ --=20 2.43.0