From nobody Thu Dec 18 22:17:50 2025 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED5F825F78E; Tue, 8 Apr 2025 03:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744083241; cv=none; b=Z0UAgxaYA/BZcLXk8RagVYLw+p14OPnoCrLmFwDOIdEDvaCLn7D2X1J9SeaNdtdOrD9TUkxgNiAZm/v//W1u13EHpwWqZA6g6YxJ7HIE4sjXf3+xSeODpz5a4Kd4S6HPgBV9eOGigNYSiTtIb8NkRBO+XOhEcxIC8bqYvFE/y7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744083241; c=relaxed/simple; bh=YQ+b/bhi69UBQWKqRH5lunv3v2mmTjva+ZVRrFt+1qw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G1rHhOgF5mNbLpNN+BuX0TAg3eP7Qd16ZYNyK3wNNpQ9Q4Sd3rQnpckVNpvmIauSDFrOopHLv1FIl1MPa4L8vxPKq4RvA1kOYJJIbGnlw/JOoUZYpWHU8Waz5iaOgB9RdJGdhZ1F/y8av/epfDz1XRefkJ4gbl4tBlu4hDnF+uI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JdZ758F6; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JdZ758F6" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7c5e1b40f68so564671185a.1; Mon, 07 Apr 2025 20:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744083239; x=1744688039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/w/7RKMvsV/vR6GoA+QxM0o+xL/6IxF4Q5WJvbupo38=; b=JdZ758F6pQKaQIr+2EF0znIsTqP6d4awVcsELRI83RujY7fXmgdMWC3W7qyV/8MgBc 2Mblnf7/863vd/lQgO3c6jdMUYVyFt2l7ejxhjVy/Y+tt4rLt0aa1DZ9GbfSiQX+WVP7 CifEjnMFBIp9Z7MYXo1cClVjNlzBfAPOAw87wDdb9D3zl12G9fRCy0FyuML54Vb51qZP v0NUkiH58pZ3c0YleXKlqigrEekREte+FVNoQ4XxQZGfNfMlaBNa14UBeJnG4copN128 3TsVFYRzZdr0R5rmQixjIibMRlo+M5eHVhB0Pe+ELbry2BsxVbZ5Do66N1zSPsEvRn0W KfAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744083239; x=1744688039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/w/7RKMvsV/vR6GoA+QxM0o+xL/6IxF4Q5WJvbupo38=; b=p2INhLedrkVPz4yJ6ETOwna9HJx5t8sDvMpqtwsej1ULQpVwzd2q7FTUkkeLRefFAz QIUNBzQP8Wa59ww6gkcunsNdn+Fm5JvdE9GezRSLPeAObHBtRVT1FUxh6QnnanGKD1L3 6zeHF+tgmZCGgQd7OvyD6RxarQjLKd1bE8aHGQwXQ27PeEweWT5OUWK8r+MnyKD/okv4 kRczqpz7QSxnDwS96l9yLUcWnaqJn6QKkL8itjblzGzsqc5PxZNyJqnSgXkE8lsj7c5w CVNFejd/SlFtZLgpY5GUccePqzTH+mixrNNHlYx9OvaCgYKaEen1Iaj4oNi5+8POss9U p7RA== X-Forwarded-Encrypted: i=1; AJvYcCV5TF/h8zlcqIM+h1oF4PcOncSbbKQ/ApOmwE438GSDcqnfzmZjAaXvDLggSWvfsDIRNxq+vjDTgYEvUtY=@vger.kernel.org X-Gm-Message-State: AOJu0YyPKdtT4ERLTsn5/PBqsH+upPDTuLJGP4SFNj77X4/kBYlcnSkY M/GOKx6lCuQf9AzqhijlPkaR7ri39uJVpd8RBlToIeh0KxuQBvcP X-Gm-Gg: ASbGncuW2WSObWYg3DDyGnw2+QI6vYF/jSxqXxVuI3w6wXxN2dFL3ZLI84kL4Wf3bjg Gj9Jwy3VdP6J2g2GpEHhNtFRow7HWScwC163HtFNJ461oELMeXISWIX9X+F8vRTlAzWZwxyKBsu 8R5a0t3kSUBMxsSH4k4O9KK8UhWquQGSLdvkjg/o1B+QCWRfhZnQvA59+ME+9CNAXiSXDJ6+yAS 6o2MdhHN9kysZoBLrATmmUzhT6oArvqkgMGIhdN4gFwat8hYQuq+AGcA/RGbyKt9DY+8D7cYi5Y ZMDrEiEx0iix3oQkFf+yyV5KR2hJc2bez5MwpVikX2WgMRvsRNcexoHHHgg= X-Google-Smtp-Source: AGHT+IH4yoOkBSDU8zbVRjQJzoFeihuOwQlL7rWdsWi+rYAbSeqEbWnXNnqH6+54t740gKYG9q987Q== X-Received: by 2002:a05:620a:424c:b0:7c5:4eee:5405 with SMTP id af79cd13be357-7c775ade724mr2027033085a.35.1744083238837; Mon, 07 Apr 2025 20:33:58 -0700 (PDT) Received: from theriatric.mshome.net ([73.123.232.110]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c76ea82d48sm692759585a.101.2025.04.07.20.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 20:33:58 -0700 (PDT) From: Gabriel Shahrouzi To: Coly Li , Kent Overstreet Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, kernelmentees@lists.linuxfoundation.org, gshahrouzi@gmail.com Subject: [PATCH 1/2] bcache: Fix undeclared symbol warning for bcache_is_reboot Date: Mon, 7 Apr 2025 23:33:21 -0400 Message-ID: <20250408033322.401680-2-gshahrouzi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408033322.401680-1-gshahrouzi@gmail.com> References: <20250408033322.401680-1-gshahrouzi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add extern declaration for bcache_is_reboot to bcache.h. Ensure proper visibility for use across multiple files (super.c, sysfs.c) and follow the declaration pattern for other forward declarations. Signed-off-by: Gabriel Shahrouzi --- drivers/md/bcache/bcache.h | 1 + drivers/md/bcache/sysfs.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h index 785b0d9008fac..531933351b8b8 100644 --- a/drivers/md/bcache/bcache.h +++ b/drivers/md/bcache/bcache.h @@ -1007,6 +1007,7 @@ extern struct workqueue_struct *bch_journal_wq; extern struct workqueue_struct *bch_flush_wq; extern struct mutex bch_register_lock; extern struct list_head bch_cache_sets; +extern bool bcache_is_reboot; =20 extern const struct kobj_type bch_cached_dev_ktype; extern const struct kobj_type bch_flash_dev_ktype; diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index e8f696cb58c05..47ef0167b9d23 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -17,8 +17,6 @@ #include #include =20 -extern bool bcache_is_reboot; - /* Default is 0 ("writethrough") */ static const char * const bch_cache_modes[] =3D { "writethrough", --=20 2.43.0 From nobody Thu Dec 18 22:17:50 2025 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4484125F981; Tue, 8 Apr 2025 03:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744083243; cv=none; b=RuFO3tLFFXmiAOti2BwKHI8h5ZSwR4FM1r4nFAnts7qtDRgaAs0dxMCTwubeoyK0eztpQaBW+6DL+zDXR0IytH4jdLP0beQgViewb+n2pmbwOS0gbr8wcSww6gG/cl4TNh0LX65YITqezh7VATayQJKwaqdk4JOnjpJDwDV3WCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744083243; c=relaxed/simple; bh=imYro8UTdpYAOtprQsP7qTkt/JH320aZZld/QkLjJCI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BnDqefDAORKbG76FUgEiMTUSeuSsV29X6RIn7uX6SPNu41nSmlYvuE2L7P8EZVxwp++X2MoMF0gKB9RTSOYq4HFC1ZOW8BGWmBEU5vJ4GXUgpWM/N8hGiTN0rELla6bXxQOMAcOd0JwJQe2247/2EP8qwyCLEGpDK6W+tTIq39w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H69c+cSw; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H69c+cSw" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7c5f720c717so633563185a.0; Mon, 07 Apr 2025 20:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744083241; x=1744688041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e7jb0oaxWwuHrFion4GHXoqaHsrx3lftzE+OrY+WHKs=; b=H69c+cSwvinFJaW9v2qYR2fDgReaYRzbgWetJsaAYDvH9Kx1TFyH3RAsa3vyUGx67p xUAc7SPsYuJBheHB/gPHtfsuL3i1xGUrasHH9c/vTWx8qMCq1d168j+EA6M1e6jftjnd 9VTYNaxsqGHL1Uf41A6q2UL50yBIUqcx5zlBJIFuBOr7lQNCq3v1RsBCYOTNU5a3uS1n Gy9ZerwlJli3YJGvXGNibGOzA9mg2D/ZuSZeRqxCXfYmDxCIV+9dcdcuQL7MJ4xpTUeU mN+8VsZTjiW26q6/EiVgSJqxgFdKYbjX0KeyNjG6ALjdjiRY4vLio+9+YTXGeugMJjsC gDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744083241; x=1744688041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e7jb0oaxWwuHrFion4GHXoqaHsrx3lftzE+OrY+WHKs=; b=coSqZX3fJfVgP8UgAe+Sx1zwS3EpmWShzvq+c16SoXs37vIGnbzdSzpIK2b9ZApI5I XTIz0GKTnbZZa/EIEPeV+9ImMHXNx6kStOCIJMg4HhB9riPySDIagcsmy65k6uCb2ygz YsjjPlSEcIvyg0+xwhN2v6Z7UaLkIh5KKLkbkdxUU7TGAiCS6Rd7t7UUomEVUFA8sVgc gptLemfIxngYAplE4JqK8Ix6tBeVPeqgCbHSrSKx7NwreNL6zD25EB+LMhsa1e6i1VX3 7cR+YaWb5IGJCOJY2NUPVT01zOxZJkA192ArJF7nbNlLZN3fsxltzwGV1elrLBkvrxrI iHrA== X-Forwarded-Encrypted: i=1; AJvYcCUt9eDZs6BhwI22/70eCXvk8yQTtnDVi42/RSe2elGsrw3GYpOCEJF+hefxN86exWEyxdwnwr6k0BbyXCA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh7cVE22PH0lAE3zgBRDrrVhKTcoG4o/lWewnY+EN61rtX1OTa 4U3mIXW+0dlQmFs/hjL05PRCPH/tWamggWXQq3s5Qj0kyYsDDII6 X-Gm-Gg: ASbGncsyYFK+JKsEPCtaAi3mqDa94nqBBycShTQBDLcbSOXCpPpiyJMzuUYqL1avRLf HkKym3g/hWAb52pi7ZxbghjzhlNBIPPxIZVTrdNiV5pU03GXxP9Ni9mBthlTfoO4JsYeZrq+JPk ln2IfHqUmW26ubWQNu25nEsaVB9AbulNa0+RC/kO66QGQXKtX7TX3mwu/KZPu63uTzHqllbRfhP ZjCBb9IIYoQ5ADXwvq1GomRYkMLrT/iaaLm79eGCsIgnJQ7CLHtRQrKDU+GPj+24sLKlXSE6fR6 eJwsvBTw9zWj+TtRi0xl5MRCjGsmHe53MDFPomv3NCuxS+gSNBKF7T2ezrI= X-Google-Smtp-Source: AGHT+IHmwcGuxP7t1DnvwSICv3jBk4SiEIhe8/2ozWDOEBtbHw+zVeYb1Ehvr8edr5eMVImfJY0MgQ== X-Received: by 2002:a05:620a:3189:b0:7bc:de68:e932 with SMTP id af79cd13be357-7c7940d7cadmr305690985a.23.1744083241068; Mon, 07 Apr 2025 20:34:01 -0700 (PDT) Received: from theriatric.mshome.net ([73.123.232.110]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c76ea82d48sm692759585a.101.2025.04.07.20.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 20:34:00 -0700 (PDT) From: Gabriel Shahrouzi To: Coly Li , Kent Overstreet Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, kernelmentees@lists.linuxfoundation.org, gshahrouzi@gmail.com Subject: [PATCH 2/2] bcache: Fix warnings for incorrect type in assignments Date: Mon, 7 Apr 2025 23:33:22 -0400 Message-ID: <20250408033322.401680-3-gshahrouzi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250408033322.401680-1-gshahrouzi@gmail.com> References: <20250408033322.401680-1-gshahrouzi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unnecessary cpu_to_le16() and cpu_to_le32() conversions when assigning values (priorities, timestamps) to native integer type members. Prevent incorrect byte ordering for big-endian systems. Signed-off-by: Gabriel Shahrouzi --- drivers/md/bcache/super.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index e42f1400cea9d..c4c5ca17fb600 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -648,7 +648,7 @@ int bch_prio_write(struct cache *ca, bool wait) for (b =3D ca->buckets + i * prios_per_bucket(ca); b < ca->buckets + ca->sb.nbuckets && d < end; b++, d++) { - d->prio =3D cpu_to_le16(b->prio); + d->prio =3D b->prio; d->gen =3D b->gen; } =20 @@ -721,7 +721,7 @@ static int prio_read(struct cache *ca, uint64_t bucket) d =3D p->data; } =20 - b->prio =3D le16_to_cpu(d->prio); + b->prio =3D d->prio; b->gen =3D b->last_gc =3D d->gen; } =20 @@ -832,7 +832,7 @@ static void bcache_device_detach(struct bcache_device *= d) =20 SET_UUID_FLASH_ONLY(u, 0); memcpy(u->uuid, invalid_uuid, 16); - u->invalidated =3D cpu_to_le32((u32)ktime_get_real_seconds()); + u->invalidated =3D (u32)ktime_get_real_seconds(); bch_uuid_write(d->c); } =20 @@ -1188,7 +1188,7 @@ void bch_cached_dev_detach(struct cached_dev *dc) int bch_cached_dev_attach(struct cached_dev *dc, struct cache_set *c, uint8_t *set_uuid) { - uint32_t rtime =3D cpu_to_le32((u32)ktime_get_real_seconds()); + uint32_t rtime =3D (u32)ktime_get_real_seconds(); struct uuid_entry *u; struct cached_dev *exist_dc, *t; int ret =3D 0; @@ -1230,7 +1230,7 @@ int bch_cached_dev_attach(struct cached_dev *dc, stru= ct cache_set *c, (BDEV_STATE(&dc->sb) =3D=3D BDEV_STATE_STALE || BDEV_STATE(&dc->sb) =3D=3D BDEV_STATE_NONE)) { memcpy(u->uuid, invalid_uuid, 16); - u->invalidated =3D cpu_to_le32((u32)ktime_get_real_seconds()); + u->invalidated =3D (u32)ktime_get_real_seconds(); u =3D NULL; } =20 @@ -1591,7 +1591,7 @@ int bch_flash_dev_create(struct cache_set *c, uint64_= t size) =20 get_random_bytes(u->uuid, 16); memset(u->label, 0, 32); - u->first_reg =3D u->last_reg =3D cpu_to_le32((u32)ktime_get_real_seconds(= )); + u->first_reg =3D u->last_reg =3D (u32)ktime_get_real_seconds(); =20 SET_UUID_FLASH_ONLY(u, 1); u->sectors =3D size >> 9; --=20 2.43.0