From nobody Thu Dec 18 22:18:33 2025 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FC4246348; Tue, 8 Apr 2025 01:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075711; cv=none; b=KeHNZnkf5eUcJtv/B8p8TxMNBtYfMhHgL1LgV7ahbgvM77300pjw6z89U/gmPK8PLJ47Vx84tTXgcT2FJZKzekoAKdyoO4r5vUKLH3zbi47JwCMKgjll+xlWJqs1RmKxebTPYyAmO7ZXknacHJzlk8q1ld0XMOwBbBUX0WP73mE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075711; c=relaxed/simple; bh=3FkIdlqFugDHZWH3s0we5Xow5hZweujHLBxEMHL0czM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OubptUDWbh1TitOBnWmgWoeCprVPmGjdKffaAHdvgAQVYMBQoRL674kFA5JPmiuL+ADCrf9SlHiZwzFyGfvNnZxBEQuRqwB844VSp8rdMiwmH4SpxrtWSXeMPSJH+VcrtY4RyfEGYhakfbLLKWLIEh/e3pPW1YPH6U9wQAEEk2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nq5kkvvx; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nq5kkvvx" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-af51e820336so4679516a12.1; Mon, 07 Apr 2025 18:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744075709; x=1744680509; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3ffBUxhJJO8Wj5J5xDbXwSYiLrQjKHTIlQfc8rR9n5o=; b=nq5kkvvxdpc4fnd+GG9P+1/RF0bC3w12GdI1QMKHeyXDZdVudVp1fgwMPHzEiPNjCC MgYlgJUkQNan6IbHxu3WTXbM7st/IPwBYWxyCiwnOG498y2G88gg+89WPOTX/2BNwrkR mGfm36lKqScQ6v9eiFL5PN9fHSux8e108iw1MOAUjMHC7pSwurtmVJ1spXRnSFeojy1Y 9oBZJbPHcVsrsskaB8xPNfWbYUbitCnWQnpv9NTm+6ZTv7SwZFaSrHpc2g6aaOIqk+k0 RbbZK4wNjZLF1ge6rgZlyoCcpAmuJ6FUYN3xEfdSe9qq9/iGtKC4g8ehN4yK3hzZ/CHv Bp+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744075709; x=1744680509; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ffBUxhJJO8Wj5J5xDbXwSYiLrQjKHTIlQfc8rR9n5o=; b=WKeZjdUgXd0Z+YvGb8+hz+CJhKK7v45CQ8CYIOXXLX67MnGxZVyLf9JEFCJmZLZ8tT OdqsdjzBdZ/s5P0x5G9td+Yqfb+DI4wPpSXfyHZMrr5UE8tdEox0nUzSUuxkZRjg+ItD EI6IY2bv/NmEproodTUtIgbbGXsfFjJ/hBWaQ/gtQjY0Px/JYdiLgmDvprGucYHjM74e FdvSPBRuCDXjCo5pbCRmDU9Ah/toKJ9I+JCOtQqFSSZE8EJDqiiihVt0c7b39DK7eLBU jhZ4rTapnTMjuti4IMaP/b6x8l56pv03/XRBNFiNuc4pY3YC0lXd+D9qwv3ZmBpEWtSt squg== X-Forwarded-Encrypted: i=1; AJvYcCWS4tQjDh0STKV4BXjm7vNH1dODi3QskTPU5J7+goIr8alYFqzbw0o/+udW3J9k+TSAe2pUt8AIGp8=@vger.kernel.org, AJvYcCX0HQByldUc6pZSmisjME1Z51Gq/EiD8eTT2QBYiyL56zRSoFdC4lNqrFxUIJZxp0c15hjqZzcSFqRQoJWPulU94UAAag==@vger.kernel.org, AJvYcCXJUVnYKT0I5yqBxN+X/mzVWz5Er6j89287Kz/xr6/op0JJck9/fzOFZCnAtt5Y+L8ed2XJPSdZqeZY2vg5@vger.kernel.org X-Gm-Message-State: AOJu0YwB9fxt/Iy4B/P9Blhpwa1xXFvJnjyL7wjIzB3EvztH0xYVVa8L dsb1DeoSpbc5bxKL92RnD79g6QKU7lXlcUUkhgYxuDWVMeyHVnt0 X-Gm-Gg: ASbGncu4xEmdIYCWPWKZYITgowj/4ey2/xgQKt0QYHtHoqtMHSTmydS4uhY+552mvC0 3Gta2xFZTZyxl8Bf1mSV3QHTOhM/xXU4k93UmvFoD5szXuigr+jzZIp+h/zR4raBpiJUeIo+wz+ ka5sx5zwm7atpjbeqR+ka848y7zaBDAy2v9RwF2bruSIO0ZINdWVJkjHNx0hsC6inYIfvDzUgjN Vt1eMHuMfTihjAFYRm0SBVFafrGtciwJAuljph9YwP6UpM1U8YEsrVo/EYxFM027Yd0Wi85dIsN yhvxhkVDpqafr/LYzQDuZaypbiLR9PvgomG03NTSj454C04kp0nM00dNXhnbOh4jQb8TAC2cJBC kcsBqSrYkQd3w+PVY9U8dhvoLNFe4JF4xI3yPqZFWkJc= X-Google-Smtp-Source: AGHT+IGw03iUxPardgCkPjqol170uVJDmcqPtZ2bPGzZFsaH3b0OCen01jnNWdclmZasNxl0J1DYlg== X-Received: by 2002:a17:902:e5d1:b0:227:e74a:a057 with SMTP id d9443c01a7336-22a95589520mr169093075ad.44.1744075708510; Mon, 07 Apr 2025 18:28:28 -0700 (PDT) Received: from localhost.localdomain (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785c39c1sm87901255ad.85.2025.04.07.18.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 18:28:28 -0700 (PDT) From: "Derek J. Clark" To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Armin Wolf , Jonathan Corbet , Mario Limonciello , Luke Jones , Xino Ni , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Cody T . -H . Chiu" , John Martens , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mario Limonciello Subject: [PATCH v5 1/6] platform/x86: Add lenovo-wmi-* driver Documentation Date: Mon, 7 Apr 2025 18:28:10 -0700 Message-ID: <20250408012815.1032357-2-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408012815.1032357-1-derekjohn.clark@gmail.com> References: <20250408012815.1032357-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds documentation for new lenovo-wmi drivers. Reviewed-by: Mario Limonciello Signed-off-by: Derek J. Clark Reviewed-by: Armin Wolf Suggested-by: Mario Limonciello --- v5: - Fix extra spaces in lenovo-wmi-gamezone.rst. - Fix monospace for GUID's. v4: - Fixed MOF formatting issues. - Fixed spelling mistakes. - Updated description of balanced-performance profile for Gamezone. - Updated description of thermal mode event GUID for Gamezone. v3: - Split documentation into multiple files, one for each parent driver for the Gamezone and Other Mode WMI interfaces. - Add MOF data for all parent and child interfaces. - Remove lenovo-wmi-camera.c driver from v2 documentation. v2: - Update description of Custom Profile to include the need to manually set it. - Remove all references to Legion hardware. - Add section for lenovo-wmi-camera.c driver as it follows the same naming convention. --- .../wmi/devices/lenovo-wmi-gamezone.rst | 202 ++++++++++++++++++ .../wmi/devices/lenovo-wmi-other-method.rst | 108 ++++++++++ MAINTAINERS | 7 + 3 files changed, 317 insertions(+) create mode 100644 Documentation/wmi/devices/lenovo-wmi-gamezone.rst create mode 100644 Documentation/wmi/devices/lenovo-wmi-other-method.rst diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst b/Documentat= ion/wmi/devices/lenovo-wmi-gamezone.rst new file mode 100644 index 000000000000..ec4130c4d490 --- /dev/null +++ b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst @@ -0,0 +1,202 @@ +.. SPDX-License-Identifier: GPL-2.0-or-later + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D +Lenovo WMI Interface Gamezone Driver (lenovo-wmi-gamezone) +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D + +Introduction +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +The Lenovo WMI gamezone interface is broken up into multiple GUIDs, +The priamry "Gamezone" GUID provides advanced features such as fan +profiles and overclocking. It is paired with multiple event GUIDs +and data block GUIDs that provide context for the various methods. + +Gamezone Data +------------- + +WMI GUID ``887B54E3-DDDC-4B2C-8B88-68A26A8835D0`` + +The Gamezone Data WMI interface provides platform-profile and fan curve +settings for devices that fall under the "Gaming Series" of Lenovo devices. +It uses a notifier chain to inform other Lenovo WMI interface drivers of t= he +current platform profile when it changes. + +The following platform profiles are supported: + - low-power + - balanced + - balanced-performance* + - performance + - custom + +Balanced-Performance +~~~~~~~~~~~~~~~~~~~~ +Some newer Lenovo "Gaming Series" laptops have an "Extreme Mode" profile +enabled in their BIOS. For these devices, the performance platform profile +will correspond to the BIOS Extreme Mode, while the balanced-performance +platform profile will correspond to the BIOS Performance mode. For legacy +devices, the performance platform profile will correspond with the BIOS +Performance mode. For some newer devices the "Extreme Mode" profile is +incomplete in the BIOS and setting it will cause undefined behavior. A +BIOS bug quirk table is provided to ensure these devices cannot set +"Extreme Mode" from the driver. + +Custom Profile +~~~~~~~~~~~~~~ +The custom profile represents a hardware mode on Lenovo devices that enabl= es +user modifications to Package Power Tracking (PPT) and fan curve settings. +When an attribute exposed by the Other Mode WMI interface is to be modifie= d, +the Gamezone driver must first be switched to the "custom" profile manuall= y, +or the setting will have no effect. If another profile is set from the list +of supported profiles, the BIOS will override any user PPT settings when +switching to that profile. + +Gamezone Thermal Mode Event +--------------------------- + +WMI GUID ``D320289E-8FEA-41E0-86F9-911D83151B5F`` + +The Gamezone Thermal Mode Event interface notifies the system when the pla= tform +profile has changed, either through the hardware event (Fn+Q for laptops or +Legion + Y for Go Series), or through the Gamezone WMI interface. This eve= nt is +implemented in the Lenovo WMI Events driver (lenovo-wmi-events). + + +WMI interface description +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D + +The WMI interface description can be decoded from the embedded binary MOF = (bmof) +data using the `bmfdec `_ utility: + +:: + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LE= NOVO_GAMEZONE_DATA class"), guid("{887B54E3-DDDC-4B2C-8B88-68A26A8835D0}")] + class LENOVO_GAMEZONE_DATA { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiMethodId(4), Implemented, Description("Is SupportGpu OverClock")] = void IsSupportGpuOC([out, Description("Is SupportGpu OverClock")] uint32 Da= ta); + [WmiMethodId(11), Implemented, Description("Get AslCode Version")] voi= d GetVersion ([out, Description("AslCode version")] UINT32 Data); + [WmiMethodId(12), Implemented, Description("Fan cooling capability")] = void IsSupportFanCooling([out, Description("Fan cooling capability")] UINT3= 2 Data); + [WmiMethodId(13), Implemented, Description("Set Fan cooling on/off")] = void SetFanCooling ([in, Description("Set Fan cooling on/off")] UINT32 Data= ); + [WmiMethodId(14), Implemented, Description("cpu oc capability")] void = IsSupportCpuOC ([out, Description("cpu oc capability")] UINT32 Data); + [WmiMethodId(15), Implemented, Description("bios has overclock capabil= ity")] void IsBIOSSupportOC ([out, Description("bios has overclock capabili= ty")] UINT32 Data); + [WmiMethodId(16), Implemented, Description("enable or disable overcloc= k in bios")] void SetBIOSOC ([in, Description("enable or disable overclock = in bios")] UINT32 Data); + [WmiMethodId(18), Implemented, Description("Get CPU temperature")] voi= d GetCPUTemp ([out, Description("Get CPU temperature")] UINT32 Data); + [WmiMethodId(19), Implemented, Description("Get GPU temperature")] voi= d GetGPUTemp ([out, Description("Get GPU temperature")] UINT32 Data); + [WmiMethodId(20), Implemented, Description("Get Fan cooling on/off sta= tus")] void GetFanCoolingStatus ([out, Description("Get Fan cooling on/off = status")] UINT32 Data); + [WmiMethodId(21), Implemented, Description("EC support disable windows= key capability")] void IsSupportDisableWinKey ([out, Description("EC suppo= rt disable windows key capability")] UINT32 Data); + [WmiMethodId(22), Implemented, Description("Set windows key disable/en= able")] void SetWinKeyStatus ([in, Description("Set windows key disable/ena= ble")] UINT32 Data); + [WmiMethodId(23), Implemented, Description("Get windows key disable/en= able status")] void GetWinKeyStatus ([out, Description("Get windows key dis= able/enable status")] UINT32 Data); + [WmiMethodId(24), Implemented, Description("EC support disable touchpa= d capability")] void IsSupportDisableTP ([out, Description("EC support disa= ble touchpad capability")] UINT32 Data); + [WmiMethodId(25), Implemented, Description("Set touchpad disable/enabl= e")] void SetTPStatus ([in, Description("Set touchpad disable/enable")] UIN= T32 Data); + [WmiMethodId(26), Implemented, Description("Get touchpad disable/enabl= e status")] void GetTPStatus ([out, Description("Get touchpad disable/enabl= e status")] UINT32 Data); + [WmiMethodId(30), Implemented, Description("Get Keyboard feature list"= )] void GetKeyboardfeaturelist ([out, Description("Get Keyboard feature lis= t")] UINT32 Data); + [WmiMethodId(31), Implemented, Description("Get Memory OC Information"= )] void GetMemoryOCInfo ([out, Description("Get Memory OC Information")] UI= NT32 Data); + [WmiMethodId(32), Implemented, Description("Water Cooling feature capa= bility")] void IsSupportWaterCooling ([out, Description("Water Cooling feat= ure capability")] UINT32 Data); + [WmiMethodId(33), Implemented, Description("Set Water Cooling status")= ] void SetWaterCoolingStatus ([in, Description("Set Water Cooling status")]= UINT32 Data); + [WmiMethodId(34), Implemented, Description("Get Water Cooling status")= ] void GetWaterCoolingStatus ([out, Description("Get Water Cooling status")= ] UINT32 Data); + [WmiMethodId(35), Implemented, Description("Lighting feature capabilit= y")] void IsSupportLightingFeature ([out, Description("Lighting feature cap= ability")] UINT32 Data); + [WmiMethodId(36), Implemented, Description("Set keyboard light off or = on to max")] void SetKeyboardLight ([in, Description("keyboard light off or= on switch")] UINT32 Data); + [WmiMethodId(37), Implemented, Description("Get keyboard light on/off = status")] void GetKeyboardLight ([out, Description("Get keyboard light on/o= ff status")] UINT32 Data); + [WmiMethodId(38), Implemented, Description("Get Macrokey scan code")] = void GetMacrokeyScancode ([in, Description("Macrokey index")] UINT32 idx, [= out, Description("Scan code")] UINT32 scancode); + [WmiMethodId(39), Implemented, Description("Get Macrokey count")] void= GetMacrokeyCount ([out, Description("Macrokey count")] UINT32 Data); + [WmiMethodId(40), Implemented, Description("Support G-Sync feature")] = void IsSupportGSync ([out, Description("Support G-Sync feature")] UINT32 Da= ta); + [WmiMethodId(41), Implemented, Description("Get G-Sync Status")] void = GetGSyncStatus ([out, Description("Get G-Sync Status")] UINT32 Data); + [WmiMethodId(42), Implemented, Description("Set G-Sync Status")] void = SetGSyncStatus ([in, Description("Set G-Sync Status")] UINT32 Data); + [WmiMethodId(43), Implemented, Description("Support Smart Fan feature"= )] void IsSupportSmartFan ([out, Description("Support Smart Fan feature")] = UINT32 Data); + [WmiMethodId(44), Implemented, Description("Set Smart Fan Mode")] void= SetSmartFanMode ([in, Description("Set Smart Fan Mode")] UINT32 Data); + [WmiMethodId(45), Implemented, Description("Get Smart Fan Mode")] void= GetSmartFanMode ([out, Description("Get Smart Fan Mode")] UINT32 Data); + [WmiMethodId(46), Implemented, Description("Get Smart Fan Setting Mode= ")] void GetSmartFanSetting ([out, Description("Get Smart Setting Mode")] U= INT32 Data); + [WmiMethodId(47), Implemented, Description("Get Power Charge Mode")] v= oid GetPowerChargeMode ([out, Description("Get Power Charge Mode")] UINT32 = Data); + [WmiMethodId(48), Implemented, Description("Get Gaming Product Info")]= void GetProductInfo ([out, Description("Get Gaming Product Info")] UINT32 = Data); + [WmiMethodId(49), Implemented, Description("Over Drive feature capabil= ity")] void IsSupportOD ([out, Description("Over Drive feature capability")= ] UINT32 Data); + [WmiMethodId(50), Implemented, Description("Get Over Drive status")] v= oid GetODStatus ([out, Description("Get Over Drive status")] UINT32 Data); + [WmiMethodId(51), Implemented, Description("Set Over Drive status")] v= oid SetODStatus ([in, Description("Set Over Drive status")] UINT32 Data); + [WmiMethodId(52), Implemented, Description("Set Light Control Owner")]= void SetLightControlOwner ([in, Description("Set Light Control Owner")] UI= NT32 Data); + [WmiMethodId(53), Implemented, Description("Set DDS Control Owner")] v= oid SetDDSControlOwner ([in, Description("Set DDS Control Owner")] UINT32 D= ata); + [WmiMethodId(54), Implemented, Description("Get the flag of restore OC= value")] void IsRestoreOCValue ([in, Description("Clean this flag")] UINT3= 2 idx, [out, Description("Restore oc value flag")] UINT32 Data); + [WmiMethodId(55), Implemented, Description("Get Real Thremal Mode")] v= oid GetThermalMode ([out, Description("Real Thremal Mode")] UINT32 Data); + [WmiMethodId(56), Implemented, Description("Get the OC switch status i= n BIOS")] void GetBIOSOCMode ([out, Description("OC Mode")] UINT32 Data); + [WmiMethodId(59), Implemented, Description("Get hardware info support = version")] void GetHardwareInfoSupportVersion ([out, Description("version")= ] UINT32 Data); + [WmiMethodId(60), Implemented, Description("Get Cpu core 0 max frequen= cy")] void GetCpuFrequency ([out, Description("frequency")] UINT32 Data); + [WmiMethodId(62), Implemented, Description("Check the Adapter type fit= for OC")] void IsACFitForOC ([out, Description("AC check result")] UINT32 = Data); + [WmiMethodId(63), Implemented, Description("Is support IGPU mode")] vo= id IsSupportIGPUMode ([out, Description("IGPU modes")] UINT32 Data); + [WmiMethodId(64), Implemented, Description("Get IGPU Mode Status")] vo= id GetIGPUModeStatus([out, Description("IGPU Mode Status")] UINT32 Data); + [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetI= GPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description= ("return code")] UINT32 Data); + [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void= NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Des= cription("return code")] UINT32 Data); + [WmiMethodId(67), Implemented, Description("Is changed Y log")] void I= sChangedYLog([out, Description("Is changed Y Log")] UINT32 Data); + [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] v= oid GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("De= finition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C62= 8FBD2}")] + class LENOVO_GAMEZONE_CPU_OC_DATA { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("OC tune id.")] uint32 Tuneid; + [WmiDataId(2), read, Description("Default value.")] uint32 DefaultValu= e; + [WmiDataId(3), read, Description("OC Value.")] uint32 OCValue; + [WmiDataId(4), read, Description("Min Value.")] uint32 MinValue; + [WmiDataId(5), read, Description("Max Value.")] uint32 MaxValue; + [WmiDataId(6), read, Description("Scale Value.")] uint32 ScaleValue; + [WmiDataId(7), read, Description("OC Order id.")] uint32 OCOrderid; + [WmiDataId(8), read, Description("NON-OC Order id.")] uint32 NOCOrderi= d; + [WmiDataId(9), read, Description("Delay time in ms.")] uint32 Interval; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("De= finition of GPU OC parameter list"), guid("{887B54E2-DDDC-4B2C-8B88-68A26A8= 835D0}")] + class LENOVO_GAMEZONE_GPU_OC_DATA { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID; + [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID; + [WmiDataId(3), read, Description("Default value.")] uint32 defaultvalu= e; + [WmiDataId(4), read, Description("OC Offset freqency.")] uint32 OCOffs= etFreq; + [WmiDataId(5), read, Description("OC Min offset value.")] uint32 OCMin= Offset; + [WmiDataId(6), read, Description("OC Max offset value.")] uint32 OCMax= Offset; + [WmiDataId(7), read, Description("OC Offset Scale.")] uint32 OCOffsetS= cale; + [WmiDataId(8), read, Description("OC Order id.")] uint32 OCOrderid; + [WmiDataId(9), read, Description("NON-OC Order id.")] uint32 NOCOrderi= d; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Fa= ncooling finish event"), guid("{BC72A435-E8C1-4275-B3E2-D8B8074ABA59}")] + class LENOVO_GAMEZONE_FAN_COOLING_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Fancooling clean finish event")] uin= t32 EventId; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Sm= art Fan mode change event"), guid("{D320289E-8FEA-41E0-86F9-611D83151B5F}")] + class LENOVO_GAMEZONE_SMART_FAN_MODE_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Smart Fan Mode change event")] uint3= 2 mode; + [WmiDataId(2), read, Description("version of FN+Q")] uint32 version; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Sm= art Fan setting mode change event"), guid("{D320289E-8FEA-41E1-86F9-611D831= 51B5F}")] + class LENOVO_GAMEZONE_SMART_FAN_SETTING_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Smart Fan Setting mode change event"= )] uint32 mode; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("PO= WER CHARGE MODE Change EVENT"), guid("{D320289E-8FEA-41E0-86F9-711D83151B5F= }")] + class LENOVO_GAMEZONE_POWER_CHARGE_MODE_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("POWER CHARGE MODE Change EVENT")] ui= nt32 mode; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Th= ermal Mode Real Mode change event"), guid("{D320289E-8FEA-41E0-86F9-911D831= 51B5F}")] + class LENOVO_GAMEZONE_THERMAL_MODE_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Thermal Mode Real Mode")] uint32 mod= e; + }; diff --git a/Documentation/wmi/devices/lenovo-wmi-other-method.rst b/Docume= ntation/wmi/devices/lenovo-wmi-other-method.rst new file mode 100644 index 000000000000..d7928b8dfb4b --- /dev/null +++ b/Documentation/wmi/devices/lenovo-wmi-other-method.rst @@ -0,0 +1,108 @@ +.. SPDX-License-Identifier: GPL-2.0-or-later + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +Lenovo WMI Interface Other Mode Driver (lenovo-wmi-other) +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Introduction +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +Lenovo WMI Other Mode interface is broken up into multiple GUIDs, +The primary Other Mode interface provides advanced power tuning features +such as Package Power Tracking (PPT). It is paired with multiple data block +GUIDs that provide context for the various methods. + + +Other Mode +---------- + +WMI GUID ``DC2A8805-3A8C-41BA-A6F7-092E0089CD3B`` + +The Other Mode WMI interface uses the firmware_attributes class to expose +various WMI attributes provided by the interface in the sysfs. This enables +CPU and GPU power limit tuning as well as various other attributes for +devices that fall under the "Gaming Series" of Lenovo devices. Each +attribute exposed by the Other Mode interface has corresponding +capability data blocks which allow the driver to probe details about the +attribute. Each attribute has multiple pages, one for each of the platform +profiles managed by the Gamezone interface. Attributes are exposed in sysfs +under the following path: + +:: + + /sys/class/firmware-attributes/lenovo-wmi-other/attributes// + +LENOVO_CAPABILITY_DATA_01 +------------------------- + +WMI GUID ``7A8F5407-CB67-4D6E-B547-39B3BE018154`` + +The LENOVO_CAPABILITY_DATA_01 interface provides information on various +power limits of integrated CPU and GPU components. + +Each attribute has the following properties: + - current_value + - default_value + - display_name + - max_value + - min_value + - scalar_increment + - type + +The following attributes are implemented: + - ppt_pl1_spl: Platform Profile Tracking Sustained Power Limit + - ppt_pl2_sppt: Platform Profile Tracking Slow Package Power Tracking + - ppt_pl3_fppt: Platform Profile Tracking Fast Package Power Tracking + + +WMI interface description +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D + +The WMI interface description can be decoded from the embedded binary MOF = (bmof) +data using the `bmfdec `_ utility: + +:: + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LE= NOVO_OTHER_METHOD class"), guid("{dc2a8805-3a8c-41ba-a6f7-092e0089cd3b}")] + class LENOVO_OTHER_METHOD { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiMethodId(17), Implemented, Description("Get Feature Value ")] void= GetFeatureValue([in] uint32 IDs, [out] uint32 value); + [WmiMethodId(18), Implemented, Description("Set Feature Value ")] void= SetFeatureValue([in] uint32 IDs, [in] uint32 value); + [WmiMethodId(19), Implemented, Description("Get Data By Command ")] vo= id GetDataByCommand([in] uint32 IDs, [in] uint32 Command, [out] uint32 Data= Size, [out, WmiSizeIs("DataSize")] uint32 Data[]); + [WmiMethodId(99), Implemented, Description("Get Data By Package for TA= C")] void GetDataByPackage([in, Max(40)] uint8 Input[], [out] uint32 DataSi= ze, [out, WmiSizeIs("DataSize")] uint8 Data[]); + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LE= NOVO CAPABILITY DATA 00"), guid("{362a3afe-3d96-4665-8530-96dad5bb300e}")] + class LENOVO_CAPABILITY_DATA_00 { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description(" IDs.")] uint32 IDs; + [WmiDataId(2), read, Description("Capability.")] uint32 Capability; + [WmiDataId(3), read, Description("Capability Default Value.")] uint32 = DefaultValue; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LE= NOVO CAPABILITY DATA 01"), guid("{7a8f5407-cb67-4d6e-b547-39b3be018154}")] + class LENOVO_CAPABILITY_DATA_01 { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description(" IDs.")] uint32 IDs; + [WmiDataId(2), read, Description("Capability.")] uint32 Capability; + [WmiDataId(3), read, Description("Default Value.")] uint32 DefaultValu= e; + [WmiDataId(4), read, Description("Step.")] uint32 Step; + [WmiDataId(5), read, Description("Minimum Value.")] uint32 MinValue; + [WmiDataId(6), read, Description("Maximum Value.")] uint32 MaxValue; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LE= NOVO CAPABILITY DATA 02"), guid("{bbf1f790-6c2f-422b-bc8c-4e7369c7f6ab}")] + class LENOVO_CAPABILITY_DATA_02 { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description(" IDs.")] uint32 IDs; + [WmiDataId(2), read, Description("Capability.")] uint32 Capability; + [WmiDataId(3), read, Description("Data Size.")] uint32 DataSize; + [WmiDataId(4), read, Description("Default Value"), WmiSizeIs("DataSize= ")] uint8 DefaultValue[]; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 1afd30d00aec..675f4b26426d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13158,6 +13158,13 @@ S: Maintained W: http://legousb.sourceforge.net/ F: drivers/usb/misc/legousbtower.c =20 +LENOVO WMI DRIVERS +M: Derek J. Clark +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst +F: Documentation/wmi/devices/lenovo-wmi-other.rst + LENOVO WMI HOTKEY UTILITIES DRIVER M: Jackie Dong L: platform-driver-x86@vger.kernel.org --=20 2.49.0 From nobody Thu Dec 18 22:18:33 2025 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB3CA25334F; Tue, 8 Apr 2025 01:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075713; cv=none; b=QXiZjrejM85bJ9g8PjuSd/FxteEw0+x5cf70oKqTYhFk/P3Kj6mj10cywlxUnbKRBu2ImBcmKzSTTIY8u4r24b86qUY5lpFUEvEQXUeNXeOBdcGl0LcO/T4/TktLnzdu1joAqQEprq/DDWVCkL1YTEw9sn1KZ/nhKzRMYIr+nhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075713; c=relaxed/simple; bh=yjj4F3qymz54666aWlkyqY7RjZau59PpxW8HOtfL2Ok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Amsv02bmo76lhMys927/QHSC8koKLzxJ8iBhzWkH1TnsS93AnKCzPOvTBm14poCyz3RhPo/jSEBG7EGFvAjnAJWfxDxt4PbU/O3iZre2gaHBTh8wiCj/bDf1k53o8J7yza6JR0BZwRxT2b9uu3uH+aKjUlc7MOZzOQ9YgOnlUnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SMcCH25u; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SMcCH25u" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-22423adf751so49054215ad.2; Mon, 07 Apr 2025 18:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744075711; x=1744680511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FYpg105GeycpxusCr6/Txn4m5p+k3kca3L38kTfl1X4=; b=SMcCH25u0vwCLPpS/zBAu9NKog7br4dBNIGil3piPpKhS8ARE3sdu7to8CPNfhtRG0 Bp9KKEey86hQ4d0Ps2o3/3khxSKjFZqIKG53oy6vi2SGgT5s4GEROGcQOn2jHSCxPlaL 0iOLP/1btfYXh7hO9VeNOiNAY96Wb5KIIUGZhvMCglS03YNPjSU4PyLfcau1+MzBWs3n 97g0gJfcE/g4eYIoFjCidYcCY9YAyxYkZwNpJr6AmR7FIhCVvLJx8fCJ8qLRU8EhfaiV G7QJNUtlZeIw3sSVPPo8gV+vHsHEBiStbVd5++3bRb5FnB1/Wdyx5aD1d7ZTOK++blBY H56Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744075711; x=1744680511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FYpg105GeycpxusCr6/Txn4m5p+k3kca3L38kTfl1X4=; b=UEtU558B+8aygo+xpT9pEZ4riERwzJC0+vEXL9uNBZqlmrxCXIjuDu2zZvbZv6L55/ DIKVv1pVpxa248BgwTisid5Z+O9qBqTwPs7JpdOEgjEWnrHs/f8lAWjpIvJKzGjzNGKy cq7xvf060FC6e+X9JTwN7fTV5EQQXL+Y6N9J9ERG4f1L2GyVm80xCdgLAOCbueqWU9ig E3NGWVDcVxmTAVbBIMR2tkaIyZj1b6cUOJoazSde6NZ+pj1SReg5o2AjV+T//WVpRXiJ 4GNMtvE++5//qtthrep5BweCWiJT3kyCf8WbnIWROSnUBMbvZE+bpET7dUTpvnlQSRkm IcgQ== X-Forwarded-Encrypted: i=1; AJvYcCWOnVcYwKlum6FFZ/CoC60GgzpF0F6KeulORGoKAVZsk+6PHQkUDDCEsHsmw9y4SfSCArzSu6eMqp4=@vger.kernel.org, AJvYcCWv7ybCsJ2AwN4gf8O5BaEp4Eno8cjiyuMfXVN34msahtRZ5T5laIAc/+H3SnUXHsCz593idcqqoJudFq8M@vger.kernel.org, AJvYcCXOB/LYJs7rxpKiWxM2ELCka0Ob8FpM1pVXvSBEhrVgbnWeiPOn40GMIP/zyYRNbfWcVv3BI9n5oPwhgqS2nFmw/Np1SQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yy8zEl3Ykg7CB4Vdc2SI3wG3X2y3oQo63XVDL4Mw7rHaO7NIuvR 9zxTj58mP+/fNro9zBIr81kaC1ayfQfFWQdGdlLYgsQITZ4xQu1Z X-Gm-Gg: ASbGncs0GOHicUC4GlhMlairwKZiDVJnAiRa5duyRSipT/OjJVqDp2Fj3BCJTnQ+EFX jz43u/Rvbvo05dXPiu3iIhWPzeYTg4yp7x682vqjw5UPoXSCodsGl7jyWVs8xT5lIXGJ2Bxwl/5 rCnFwrDqqfRLL1wJRUmUth/BooQbQagHzeHqAVbEsZpdnKoMxTjkxYyhYsPm6gu2uNMOS61YyED epbZ+HShWxZ+Ud90t9+URuuzWoi7hlSV+xtmJ+jqS2Q6h7TO55h2bM0V9QKLNlFPbSSooZFBJ1o OU5NEciliqWgQUD2Iuydt1ECGLds+yd4Z3LxWzgItBvQ4XWY0pf0GhHKYIcDYIQ9MjLVjDT5Bak 0SVqMC5wyJTbFZcwVRbwON0Pmxym8FSG4u1vhVpF3XYo= X-Google-Smtp-Source: AGHT+IG7FIIfKCWbLkd8DJ833APCv8WVrlIT6hMkKB2C12gUO7Z2y/xJzAQlVarQlFJQXS/pV8eEEQ== X-Received: by 2002:a17:902:ef0b:b0:21a:8300:b9ce with SMTP id d9443c01a7336-22a8a0b59fbmr204800055ad.49.1744075711081; Mon, 07 Apr 2025 18:28:31 -0700 (PDT) Received: from localhost.localdomain (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785c39c1sm87901255ad.85.2025.04.07.18.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 18:28:30 -0700 (PDT) From: "Derek J. Clark" To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Armin Wolf , Jonathan Corbet , Mario Limonciello , Luke Jones , Xino Ni , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Cody T . -H . Chiu" , John Martens , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mario Limonciello Subject: [PATCH v5 2/6] platform/x86: Add lenovo-wmi-helpers Date: Mon, 7 Apr 2025 18:28:11 -0700 Message-ID: <20250408012815.1032357-3-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408012815.1032357-1-derekjohn.clark@gmail.com> References: <20250408012815.1032357-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds lenovo-wmi-helpers, which provides a common wrapper function for wmidev_evaluate_method that does data validation and error handling. Reviewed-by: Mario Limonciello Signed-off-by: Derek J. Clark Reviewed-by: Armin Wolf Suggested-by: Mario Limonciello --- v5: - Fixes from v4 review. - Combine all previous methods into a single function that takes a buffer for the wmi method arguments. v4: - Changed namespace to LENOVO_WMI_HELPERS from LENOVO_WMI. - Changed filenames to lenovo-wmi-helpers from lenovo-wmi. - Removed structs and functions implemented by other drivers. --- MAINTAINERS | 2 + drivers/platform/x86/Kconfig | 4 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-helpers.c | 74 +++++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-helpers.h | 20 ++++++ 5 files changed, 101 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.c create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.h diff --git a/MAINTAINERS b/MAINTAINERS index 675f4b26426d..3a370a18b806 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13164,6 +13164,8 @@ L: platform-driver-x86@vger.kernel.org S: Maintained F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst F: Documentation/wmi/devices/lenovo-wmi-other.rst +F: drivers/platform/x86/lenovo-wmi-helpers.c +F: drivers/platform/x86/lenovo-wmi-helpers.h =20 LENOVO WMI HOTKEY UTILITIES DRIVER M: Jackie Dong diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 43407e76476b..bece1ba61417 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -459,6 +459,10 @@ config IBM_RTL state =3D 0 (BIOS SMIs on) state =3D 1 (BIOS SMIs off) =20 +config LENOVO_WMI_HELPERS + tristate + depends on ACPI_WMI + config IDEAPAD_LAPTOP tristate "Lenovo IdeaPad Laptop Extras" depends on ACPI diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 650dfbebb6c8..5a9f4e94f78b 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -69,6 +69,7 @@ obj-$(CONFIG_THINKPAD_LMI) +=3D think-lmi.o obj-$(CONFIG_YOGABOOK) +=3D lenovo-yogabook.o obj-$(CONFIG_YT2_1380) +=3D lenovo-yoga-tab2-pro-1380-fastcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) +=3D lenovo-wmi-camera.o +obj-$(CONFIG_LENOVO_WMI_HELPERS) +=3D lenovo-wmi-helpers.o =20 # Intel obj-y +=3D intel/ diff --git a/drivers/platform/x86/lenovo-wmi-helpers.c b/drivers/platform/x= 86/lenovo-wmi-helpers.c new file mode 100644 index 000000000000..166e87fef156 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-helpers.c @@ -0,0 +1,74 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Lenovo Legion WMI helpers driver. + * + * The Lenovo Legion WMI interface is broken up into multiple GUID interfa= ces + * that require cross-references between GUID's for some functionality. The + * "Custom Mode" interface is a legacy interface for managing and displayi= ng + * CPU & GPU power and hwmon settings and readings. The "Other Mode" inter= face + * is a modern interface that replaces or extends the "Custom Mode" interf= ace + * methods. The "Gamezone" interface adds advanced features such as fan + * profiles and overclocking. The "Lighting" interface adds control of var= ious + * status lights related to different hardware components. Each of these + * drivers uses a common procedure to get data from the WMI interface, + * enumerated here. + * + * Copyright(C) 2025 Derek J. Clark + */ + +#include +#include +#include +#include +#include +#include + +#include "lenovo-wmi-helpers.h" + +/** + * lwmi_dev_evaluate_int() - Helper function for calling WMI methods that + * return an integer. + * @wdev: Pointer to the WMI device to be called. + * @instance: Instance of the called method. + * @method_id: WMI Method ID for the method to be called. + * @buf: Buffer of all arguments for the given method_id. + * @size: Length of the buffer. + * @retval: Pointer for the return value to be assigned. + * + * Calls wmidev_valuate_method for Lenovo WMI devices that return an ACPI + * integer. Validates the return value type and assigns the value to the + * retval pointer. + * + * Return: 0 on success, or on error. + */ +int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 instance, u32 method= _id, + unsigned char *buf, size_t size, u32 *retval) +{ + struct acpi_buffer output =3D { ACPI_ALLOCATE_BUFFER, NULL }; + union acpi_object *ret_obj __free(kfree) =3D NULL; + struct acpi_buffer input =3D { size, buf }; + acpi_status status; + + status =3D wmidev_evaluate_method(wdev, instance, method_id, &input, + &output); + + if (ACPI_FAILURE(status)) + return -EIO; + + if (retval) { + ret_obj =3D output.pointer; + if (!ret_obj) + return -ENODATA; + + if (ret_obj->type !=3D ACPI_TYPE_INTEGER) + return -ENXIO; + + *retval =3D (u32)ret_obj->integer.value; + } + return 0; +}; +EXPORT_SYMBOL_NS_GPL(lwmi_dev_evaluate_int, "LENOVO_WMI_HELPERS"); + +MODULE_AUTHOR("Derek J. Clark "); +MODULE_DESCRIPTION("Lenovo WMI Helpers Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/platform/x86/lenovo-wmi-helpers.h b/drivers/platform/x= 86/lenovo-wmi-helpers.h new file mode 100644 index 000000000000..b76633603dcc --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-helpers.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright(C) 2025 Derek J. Clark */ + +#ifndef _LENOVO_WMI_HELPERS_H_ +#define _LENOVO_WMI_HELPERS_H_ + +#include + +struct wmi_device; + +struct wmi_method_args_32 { + u32 arg0; + u32 arg1; +}; + +int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 instance, u32 method= _id, + unsigned char *buf, size_t size, u32 *retval); + +#endif /* !_LENOVO_WMI_HELPERS_H_ */ --=20 2.49.0 From nobody Thu Dec 18 22:18:33 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24A6B25EF90; Tue, 8 Apr 2025 01:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075715; cv=none; b=rVRs0WcMklTRL+c/m3xBw/MYHjtloSNYERZh4vFEWSTvSJeVJl6nsDOa0xpJ9rK94GezcqgtidUrOkL5fPvh8kwAXpC9fF0hMoibXgnMncermE7u+R41arxYZnAKk9fC+3xWgbZP1tO2FbAqshk9wzTscFFm6NoB8daeOJ4afkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075715; c=relaxed/simple; bh=xu6sNRrDLATKIvJGQguptuXMpTq6cZKcMawcZ5rimaE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b6VVt6+lij+bA+ym3zyJDuVeB8wnUkNaRk4SwKGw9CsceKA79bSHpaOg+VyPh9RbxnGAEHeecSEWs8YPXFrYO7bME6gRJcNLj0nOYFZnsnth+6dw3idLwIVVfEyQvUlp1rqeUt4sUevbEKLasVoJRY/ngE80TLlnQLWcNVHTjqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OvW97v9j; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OvW97v9j" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2260c91576aso41575795ad.3; Mon, 07 Apr 2025 18:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744075713; x=1744680513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xb4m3UUafcGE4ENlyLLiHz3gWw3SXy1QmUM9x05nJKo=; b=OvW97v9jj+iWrEdnBgEmV0pd6mmJAi+nIZfjoq86FujZXy0FFEPzERT9LKChIPCgO9 Y7v/J9b1JrJU4BZJci9k9Q17Vy1RvXqsiUpg8vhnUsSQPpDO2v/VFD5BeX5UpAPdBCtJ /3N5kQ6hoSbx/ALRqWGhfTrwwz5LMc4ykq6uzZl6pjE3veor45QzSE7iahAtMtvpDt04 aL5TBwN4kaQtVdpAbMpkR7XT1PtyDP6kJWKojkfcjSzh0w3evfHoGshYuGpF+F/hrx64 L3bX5Q6Fq6sSxJksRM9hRc8B8SvkupxU04UFqL+67t1qq21/IfqLKv2qyENg98AhPABL Bq6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744075713; x=1744680513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xb4m3UUafcGE4ENlyLLiHz3gWw3SXy1QmUM9x05nJKo=; b=Be/ifV0TcLXrKi0DiTBIG3zCzFwcLx7cXPk/GVIm4y9yV/4zAUPFrznHYbXnOySIjE EMJN7HkvYjqrOP9HwYO9XGN5z4aErvRBLk0A1LaMpJ9rCXtuvgoni911EezQeldWYvuf 8LBYJh4uRnk+b3r9Rxn7Ti/Ss8c2tV+gGE66UnbTzw4oqyZdBsit3UaytTMDrKLCnoNt AJeJwGWzINWYGe2XqdzYaUu/GLbzs+yqiPlen/3w6Tm1QMWV11aylzgZ/Y9Y2qnC4UPE tiQJAieSXwnG5NrUGCrkGQt5+mAEwR89TemQas+fnpnHqgkV0xvWoAUytUBEBO4h7XT2 5uYQ== X-Forwarded-Encrypted: i=1; AJvYcCUJmhrj2wq+xk3cs3UuIIcW77WVk9USGS7+/rMDaXXpBSBIcnKQHXE3ZlMsHuFx8ae9yQpRBPFZB3Y=@vger.kernel.org, AJvYcCUrPUycAMQ/Kb3/pzNZZB9o/sMUNosAjyi7ltDxP02g0TmGvFZ9LL/2znEJVZZOuYQKjvs5ln0pFG9hv5bxTcbyqCFYXw==@vger.kernel.org, AJvYcCV/M+8dhhY6gHgStdZ9Jmc9Z7Jk3vgNUtuulx+F/aCZOjWVN2QGziS0S6hgTdykgfFsWSqdPLwtCASXGjoT@vger.kernel.org X-Gm-Message-State: AOJu0YwVrBrfeuYS/DAvBtzQOVZXWN+/mlSmn7F+Ynv1z4k1eXTKvSDs izGgU8kZeIwa5VIWKGjvpTfmZ0wuYFQZGimGpTzMI6bPD0m+DGKc X-Gm-Gg: ASbGnctQTTVpHUgDS7BkqD/+SvnRNMVhE4mTv8N7+WRnn3vYO7Y7mCfJqf/8SHVjKd/ 8CqV/crZjO/MI3DfHrh6XTLiJEltqW5m/G9rNaGBtjNqEztR17B5iGkSE6/faFzKI9iZmB/XTP9 xV5ejJHmGcQ27OSPpngACd+pA9iCedbxEdtxB+IXsPJ8h+sPjCDwPmh8Xuaa3OgoTsd5VM71+FA XsKkKhaYr7/RbGoww783H1yUNg7FHs5t8QLVc0yIIKhthjvAjZNBnYXSCHkOZBhqzbFejxw2APc N7UUyI+cGGVk1CDnUNLYIaFrZeFX991TOIWw42aUox7v/GYcDuyrXh4JX7yFG93dsrVWUurhROq ZOIcEIUs7RGL/AzgdYRlmwJI70qGrUMPQY5AdA9S0I4Q= X-Google-Smtp-Source: AGHT+IFKWvX8WAjxSFH2sVmuVwDjTYEZxF/r/5t6x0mxiJ5Nf5kXHQilA4OmWwcQugwNBymnzpqCpw== X-Received: by 2002:a17:902:db06:b0:223:37ec:63d3 with SMTP id d9443c01a7336-22a8a05e91dmr154501005ad.18.1744075713229; Mon, 07 Apr 2025 18:28:33 -0700 (PDT) Received: from localhost.localdomain (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785c39c1sm87901255ad.85.2025.04.07.18.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 18:28:32 -0700 (PDT) From: "Derek J. Clark" To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Armin Wolf , Jonathan Corbet , Mario Limonciello , Luke Jones , Xino Ni , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Cody T . -H . Chiu" , John Martens , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mario Limonciello Subject: [PATCH v5 3/6] platform/x86: Add Lenovo WMI Events Driver Date: Mon, 7 Apr 2025 18:28:12 -0700 Message-ID: <20250408012815.1032357-4-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408012815.1032357-1-derekjohn.clark@gmail.com> References: <20250408012815.1032357-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds lenovo-wmi-events driver. The events driver is designed as a general entrypoint for all Lenovo WMI Events. It acts as a notification chain head that will process event data and pass it on to registered drivers so they can react to the events. Currently only the Gamezone interface Thermal Mode Event GUID is implemented in this driver. It is documented in the Gamezone documentation. Suggested-by: Armin Wolf Reviewed-by: Armin Wolf Reviewed-by: Mario Limonciello Signed-off-by: Derek J. Clark Suggested-by: Mario Limonciello --- v5: - Fixes from v4 review. v4: - Remove the Thermal Mode Event GUID from Gamezone and add this driver. --- MAINTAINERS | 2 + drivers/platform/x86/Kconfig | 4 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-events.c | 196 +++++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-events.h | 20 +++ 5 files changed, 223 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-events.c create mode 100644 drivers/platform/x86/lenovo-wmi-events.h diff --git a/MAINTAINERS b/MAINTAINERS index 3a370a18b806..6dde75922aaf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13164,6 +13164,8 @@ L: platform-driver-x86@vger.kernel.org S: Maintained F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst F: Documentation/wmi/devices/lenovo-wmi-other.rst +F: drivers/platform/x86/lenovo-wmi-events.c +F: drivers/platform/x86/lenovo-wmi-events.h F: drivers/platform/x86/lenovo-wmi-helpers.c F: drivers/platform/x86/lenovo-wmi-helpers.h =20 diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index bece1ba61417..13b8f4ac5dc5 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -459,6 +459,10 @@ config IBM_RTL state =3D 0 (BIOS SMIs on) state =3D 1 (BIOS SMIs off) =20 +config LENOVO_WMI_EVENTS + tristate + depends on ACPI_WMI + config LENOVO_WMI_HELPERS tristate depends on ACPI_WMI diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 5a9f4e94f78b..fc039839286a 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -69,6 +69,7 @@ obj-$(CONFIG_THINKPAD_LMI) +=3D think-lmi.o obj-$(CONFIG_YOGABOOK) +=3D lenovo-yogabook.o obj-$(CONFIG_YT2_1380) +=3D lenovo-yoga-tab2-pro-1380-fastcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) +=3D lenovo-wmi-camera.o +obj-$(CONFIG_LENOVO_WMI_EVENTS) +=3D lenovo-wmi-events.o obj-$(CONFIG_LENOVO_WMI_HELPERS) +=3D lenovo-wmi-helpers.o =20 # Intel diff --git a/drivers/platform/x86/lenovo-wmi-events.c b/drivers/platform/x8= 6/lenovo-wmi-events.c new file mode 100644 index 000000000000..5c18c392d0e9 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-events.c @@ -0,0 +1,196 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Lenovo WMI Events driver. Lenovo WMI interfaces provide various + * hardware triggered events that many drivers need to have propagated. + * This driver provides a uniform entrypoint for these events so that + * any driver that needs to respond to these events can subscribe to a + * notifier chain. + * + * Copyright(C) 2025 Derek J. Clark + */ + +#include +#include +#include +#include +#include +#include + +#include "lenovo-wmi-events.h" +#include "lenovo-wmi-gamezone.h" + +#define THERMAL_MODE_EVENT_GUID "D320289E-8FEA-41E0-86F9-911D83151B5F" + +#define LWMI_EVENT_DEVICE(guid, type) \ + .guid_string =3D (guid), .context =3D &(enum lwmi_events_type) \ + { \ + type \ + } + +static BLOCKING_NOTIFIER_HEAD(events_chain_head); + +struct lwmi_events_priv { + struct wmi_device *wdev; + enum lwmi_events_type type; +}; + +/** + * lwmi_events_register_notifier() - Add a notifier to the notifier chain. + * @nb: The notifier_block struct to register + * + * Call blocking_notifier_chain_register to register the notifier block to= the + * lenovo-wmi-events driver blocking notifer chain. + * + * Return: 0 on success, %-EEXIST on error. + */ +int lwmi_events_register_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_register(&events_chain_head, nb); +} +EXPORT_SYMBOL_NS_GPL(lwmi_events_register_notifier, "LENOVO_WMI_EVENTS"); + +/** + * lwmi_events_unregister_notifier() - Remove a notifier from the notifier + * chain. + * @nb: The notifier_block struct to register + * + * Call blocking_notifier_chain_unregister to unregister the notifier block + * from the lenovo-wmi-events driver blocking notifer chain. + * + * Return: 0 on success, %-ENOENT on error. + */ +int lwmi_events_unregister_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_unregister(&events_chain_head, nb); +} +EXPORT_SYMBOL_NS_GPL(lwmi_events_unregister_notifier, "LENOVO_WMI_EVENTS"); + +/** + * devm_lwmi_events_unregister_notifier() - Remove a notifier from the not= ifier + * chain. + * @data: Void pointer to the notifier_block struct to register. + * + * Call lwmi_events_unregister_notifier to unregister the notifier block f= rom + * the lenovo-wmi-events driver blocking notifer chain. + * + * Return: 0 on success, %-ENOENT on error. + */ +static void devm_lwmi_events_unregister_notifier(void *data) +{ + struct notifier_block *nb =3D data; + + lwmi_events_unregister_notifier(nb); +} + +/** + * devm_lwmi_events_register_notifier() - Add a notifier to the notifier c= hain. + * @dev: The parent device of the notifier_block struct. + * @nb: The notifier_block struct to register + * + * Call lwmi_events_register_notifier to register the notifier block to the + * lenovo-wmi-events driver blocking notifer chain. Then add, as a device + * managed action, unregister_notifier to automatically unregister the + * notifier block upon its parent device removal. + * + * Return: 0 on success, or on error. + */ +int devm_lwmi_events_register_notifier(struct device *dev, + struct notifier_block *nb) +{ + int ret; + + ret =3D lwmi_events_register_notifier(nb); + if (ret < 0) + return ret; + + return devm_add_action_or_reset(dev, devm_lwmi_events_unregister_notifier= , nb); +} +EXPORT_SYMBOL_NS_GPL(devm_lwmi_events_register_notifier, "LENOVO_WMI_EVENT= S"); + +/** + * lwmi_events_notify() - Call functions for the notifier call chain. + * @wdev: The parent WMI device of the driver. + * @obj: ACPI object passed by the registered WMI Event. + * + * Validate WMI event data and notify all registered drivers of the event = and + * its output. + * + * Return: 0 on success, or on error. + */ +static void lwmi_events_notify(struct wmi_device *wdev, union acpi_object = *obj) +{ + struct lwmi_events_priv *priv =3D dev_get_drvdata(&wdev->dev); + int sel_prof; + int ret; + + switch (priv->type) { + case LWMI_EVENT_THERMAL_MODE: + if (obj->type !=3D ACPI_TYPE_INTEGER) + return; + + sel_prof =3D obj->integer.value; + + switch (sel_prof) { + case LWMI_GZ_THERMAL_MODE_QUIET: + case LWMI_GZ_THERMAL_MODE_BALANCED: + case LWMI_GZ_THERMAL_MODE_PERFORMANCE: + case LWMI_GZ_THERMAL_MODE_EXTREME: + case LWMI_GZ_THERMAL_MODE_CUSTOM: + ret =3D blocking_notifier_call_chain(&events_chain_head, + LWMI_EVENT_THERMAL_MODE, + &sel_prof); + if (ret =3D=3D NOTIFY_BAD) + dev_err(&wdev->dev, + "Failed to send notification to call chain for WMI Events\n"); + return; + default: + dev_err(&wdev->dev, "Got invalid thermal mode: %x", + sel_prof); + return; + } + break; + default: + return; + } +} + +static int lwmi_events_probe(struct wmi_device *wdev, const void *context) +{ + struct lwmi_events_priv *priv; + + priv =3D devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + if (!context) + return -EINVAL; + + priv->wdev =3D wdev; + priv->type =3D *(enum lwmi_events_type *)context; + + dev_set_drvdata(&wdev->dev, priv); + return 0; +} + +static const struct wmi_device_id lwmi_events_id_table[] =3D { + { LWMI_EVENT_DEVICE(THERMAL_MODE_EVENT_GUID, LWMI_EVENT_THERMAL_MODE) }, + {} +}; + +static struct wmi_driver lwmi_events_driver =3D { + .driver =3D { + .name =3D "lenovo_wmi_events", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, + }, + .id_table =3D lwmi_events_id_table, + .probe =3D lwmi_events_probe, + .notify =3D lwmi_events_notify, + .no_singleton =3D true, +}; + +module_wmi_driver(lwmi_events_driver); + +MODULE_DEVICE_TABLE(wmi, lwmi_events_id_table); +MODULE_AUTHOR("Derek J. Clark "); +MODULE_DESCRIPTION("Lenovo WMI Events Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/platform/x86/lenovo-wmi-events.h b/drivers/platform/x8= 6/lenovo-wmi-events.h new file mode 100644 index 000000000000..e4c5459c2f24 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-events.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright(C) 2025 Derek J. Clark */ + +#ifndef _LENOVO_WMI_EVENTS_H_ +#define _LENOVO_WMI_EVENTS_H_ + +struct device; +struct notifier_block; + +enum lwmi_events_type { + LWMI_EVENT_THERMAL_MODE =3D 1, +}; + +int lwmi_events_register_notifier(struct notifier_block *nb); +int lwmi_events_unregister_notifier(struct notifier_block *nb); +int devm_lwmi_events_register_notifier(struct device *dev, + struct notifier_block *nb); + +#endif /* !_LENOVO_WMI_EVENTS_H_ */ --=20 2.49.0 From nobody Thu Dec 18 22:18:33 2025 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 430B025F78B; Tue, 8 Apr 2025 01:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075718; cv=none; b=D2bPkr0sBWJmUzIH3nREdaYGdoN60od64MrDgNlFtI95jGx965jeU7YxdiS75DL0LboLnlbrsJjW9Mv3igsA2LKLjPx3zQA2RTqIChiGzAe4qIrkMND/YtBc+SrzeV8klw9KUK/faykjZsvGxVSk9vxXJ1ci5XDlrMTOCBXSNd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075718; c=relaxed/simple; bh=rnNPBXhzEk16Y54/A19e+RJ7y3Q1HPbBOiCMPvbxv3c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=twJOmfKArgNvTHUkHdhquKX+jnruLlYQGcVOtzO2YTR2KVfq4mbXtiRQz+KM2hTqohia63SL0yt4zoz7IrIerHIYS30W1BoBV+cWLmvqUJ5SFog1E5ygu/qJ4i9WJmSuRnL7Q7zQm1d9DCSxQsulDEXM8Nvn20KWvZptZlDD6i8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=biNVmfpf; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="biNVmfpf" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-22438c356c8so47917175ad.1; Mon, 07 Apr 2025 18:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744075715; x=1744680515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Qe/YE4w8xe7KudMW5XZzHk7Nk8IRkaRpKGX2azDFj8=; b=biNVmfpfA+E0kOuvzal8gk1E/dRyg4HKruW0kwRnH3p/AtsUfHT4jOE7pc/wqjt7pp InJbZa6LyUBqN95c8Yy6S2r5Xr/Iwwcw10bL28L7K0e0kzftXcaJIcpNKj9RumzCTN9S bBkJJtIs3qFX667DYnU2PiruOx2ktpB7Io8fMEP+IEIMkV7vlV3WAyNeZ+jnL2Aiq4rw u83ZibGgShiay38kms61iZX7DDlpsmLUmSvuR2i8Ahgb7We5B9IF2AheSVrYknCFqX5S ROP67Vj3NcnrZWC3AZ02wFObBcJDfFx/MF6VlYhHExh+65Lwc0utRRSDiz7mVqTJ63w9 VmUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744075715; x=1744680515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Qe/YE4w8xe7KudMW5XZzHk7Nk8IRkaRpKGX2azDFj8=; b=fu7edk3A8EqLCeDD1OPYnDzJeEOLnBV/FCShrwZqAVHNIkWbQmsedqwEwGX7e3DgdB 6NdJoR/vwgOM4KyJIvOVshwBP2faY55+5KAX9Z7dJ+uCWaCH0jgLeZO232W2eKuUf+Pe iArgzqqYaclaWBmtxxbANOEkx09LEXlsZvGNonUWIXwKFQxNASz8SjK1P83JzQAbbEdf /sTGDbetBcZff3fa6LLgDaTUf1HIqTgiJSMS0QcFgvxdm7KVFJ4Vjs1sYJSQqP3o2ymx FfX/8jp21WJP6Sg5pB/ap2W7ZnwRqARIIHSNqW0Q6VyuwqRpgHgg1P+z7Bnuo6c3Y1N7 6QsQ== X-Forwarded-Encrypted: i=1; AJvYcCURMxfMep4pbAXRJtFWAjDPy/ZfXFIY2q7CWMLDLzXnUU1ErOXgd9tgxI2+PJTcfb+wnoEx7oKsnorn5rxa@vger.kernel.org, AJvYcCWjQhPUhqOQibo/tSk4YRcGy7Mpz6S+1XHvxxvujxtJ2DkV5Utpry6XFTITY1BK2Pne7zAUUQYZs+Xyy5ggspeM0/eCBw==@vger.kernel.org, AJvYcCXuLCVNJAj0VYuZW8Rd65PcObBzmd495aeBT0eN7Rj/thWFtRVc5qtF3xXPgdrA5O7GcCWW3HGC5YA=@vger.kernel.org X-Gm-Message-State: AOJu0YzaaiPRIoxVVWVshFJrbbVEM8+jx8JINtGVcjChBKokaafPe5ds aminHzCbKgLsUGkJEo7lYbh3yNR6zUO6RsAM/mpQdvpJYftgxpLQ X-Gm-Gg: ASbGnct7DlcA4XerxcWKfoUNWnG3tk7TmRTnPrvgGRDAiPMCbCX49TuNRRjAGUXzLxt ySXaMfIlGXVp+kDgyuMnZ9iUankJKQ/e9TSoUSmGOyRfRv4Ct489Q9j7ipTWwvquXdV64B72GTs +xkXqztQvPkcaEWJqlrznG8LT92chqXTTXJXVyaWKsy6v+ITktIIryUblz6pvALo0gUl6cfuUQM 6HH9a56DRQ5sZPeRGOPqb2EkNn7CFY8VhU3JjoTku/UIt4C548k9cnDeHay8BpNuHgjstTcL2Ga vxtyOwE43OJEtR4tdHnqNU0g1gc+TvppECUpUPI+bHMO6shXq/CGu41IST3WpvBBnWlNA4GPnC1 i/aqfI5TVxoe0oZEX8zSpR9IhJEyP7nhYsCFso36hDXA= X-Google-Smtp-Source: AGHT+IGEmU3c8ctKbsPJiABeKYQAlwGXSh5hecZsajDEHbqHQ8GM37Sv1QAmzN+2zv29MAZN86jOHw== X-Received: by 2002:a17:902:d4cc:b0:220:e338:8d2 with SMTP id d9443c01a7336-22a8a867491mr193785915ad.21.1744075715254; Mon, 07 Apr 2025 18:28:35 -0700 (PDT) Received: from localhost.localdomain (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785c39c1sm87901255ad.85.2025.04.07.18.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 18:28:34 -0700 (PDT) From: "Derek J. Clark" To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Armin Wolf , Jonathan Corbet , Mario Limonciello , Luke Jones , Xino Ni , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Cody T . -H . Chiu" , John Martens , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 4/6] platform/x86: Add Lenovo Capability Data 01 WMI Driver Date: Mon, 7 Apr 2025 18:28:13 -0700 Message-ID: <20250408012815.1032357-5-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408012815.1032357-1-derekjohn.clark@gmail.com> References: <20250408012815.1032357-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds lenovo-wmi-capdata01 driver which provides the LENOVO_CAPABILITY_DATA_01 WMI data block that comes on "Other Mode" enabled hardware. Provides an interface for querying if a given attribute is supported by the hardware, as well as its default_value, max_value, min_value, and step increment. Signed-off-by: Derek J. Clark Reviewed-by: Armin Wolf Suggested-by: Mario Limonciello --- v5: - Return to cache at device initialization. On component bind, pass a pointer to lenovo-wmi-other. - Fixes from v4 review. v4: - Make driver data a private struct, remove references from Other Mode driver. - Don't cache data at device initialization. Instead, on component bind, cache the data on a member variable of the Other Mode driver data passed as a void pointer. - Add header file for capdata01 structs. - Add new struct to pass capdata01 array data and array length to Other Mode. v3: - Add as component to lenovo-wmi-other driver. v2: - Use devm_kmalloc to ensure driver can be instanced, remove global reference. - Ensure reverse Christmas tree for all variable declarations. - Remove extra whitespace. - Use guard(mutex) in all mutex instances, global mutex. - Use pr_fmt instead of adding the driver name to each pr_err. - Remove noisy pr_info usage. - Rename capdata_wmi to lenovo_wmi_cd01_priv and cd01_wmi to priv. - Use list to get the lenovo_wmi_cd01_priv instance in lenovo_wmi_capdata01_get as none of the data provided by the macros that will use it can pass a member of the struct for use in container_of. --- MAINTAINERS | 2 + drivers/platform/x86/Kconfig | 4 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-capdata01.c | 168 ++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-capdata01.h | 28 ++++ 5 files changed, 203 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.c create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.h diff --git a/MAINTAINERS b/MAINTAINERS index 6dde75922aaf..56ead241a053 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13164,6 +13164,8 @@ L: platform-driver-x86@vger.kernel.org S: Maintained F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst F: Documentation/wmi/devices/lenovo-wmi-other.rst +F: drivers/platform/x86/lenovo-wmi-capdata01.c +F: drivers/platform/x86/lenovo-wmi-capdata01.h F: drivers/platform/x86/lenovo-wmi-events.c F: drivers/platform/x86/lenovo-wmi-events.h F: drivers/platform/x86/lenovo-wmi-helpers.c diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 13b8f4ac5dc5..64663667f0cb 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -467,6 +467,10 @@ config LENOVO_WMI_HELPERS tristate depends on ACPI_WMI =20 +config LENOVO_WMI_DATA01 + tristate + depends on ACPI_WMI + config IDEAPAD_LAPTOP tristate "Lenovo IdeaPad Laptop Extras" depends on ACPI diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index fc039839286a..7a35c77221b7 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -69,6 +69,7 @@ obj-$(CONFIG_THINKPAD_LMI) +=3D think-lmi.o obj-$(CONFIG_YOGABOOK) +=3D lenovo-yogabook.o obj-$(CONFIG_YT2_1380) +=3D lenovo-yoga-tab2-pro-1380-fastcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) +=3D lenovo-wmi-camera.o +obj-$(CONFIG_LENOVO_WMI_DATA01) +=3D lenovo-wmi-capdata01.o obj-$(CONFIG_LENOVO_WMI_EVENTS) +=3D lenovo-wmi-events.o obj-$(CONFIG_LENOVO_WMI_HELPERS) +=3D lenovo-wmi-helpers.o =20 diff --git a/drivers/platform/x86/lenovo-wmi-capdata01.c b/drivers/platform= /x86/lenovo-wmi-capdata01.c new file mode 100644 index 000000000000..a5255e080e87 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-capdata01.c @@ -0,0 +1,168 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Lenovo Capability Data 01 WMI Data Block driver. + * + * Lenovo Capability Data 01 provides information on tunable attributes us= ed by + * the "Other Mode" WMI interface. The data includes if the attribute is + * supported by the hardware, the default_value, max_value, min_value, and= step + * increment. Each attibute has multiple pages, one for each of the thermal + * modes managed by the Gamezone interface. + * + * Copyright(C) 2025 Derek J. Clark + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "lenovo-wmi-capdata01.h" + +#define LENOVO_CAPABILITY_DATA_01_GUID "7A8F5407-CB67-4D6E-B547-39B3BE0181= 54" + +struct lwmi_cd01_priv { + struct wmi_device *wdev; + struct cd01_list *list; +}; + +/** + * lwmi_cd01_component_bind() - Bind component to master device. + * @cd01_dev: Pointer to the lenovo-wmi-capdata01 driver parent device. + * @om_dev: Pointer to the lenovo-wmi-other driver parent device. + * @data: capdata01_list object pointer used to return the capability data. + * + * On lenovo-wmi-other's master bind, provide a pointer to the local capda= ta01 + * list. This is used to look up attribute data by the lenovo-wmi-other dr= iver. + * + * Return: 0 on success, or on error. + */ +static int lwmi_cd01_component_bind(struct device *cd01_dev, + struct device *om_dev, void *data) +{ + struct lwmi_cd01_priv *priv =3D dev_get_drvdata(cd01_dev); + struct cd01_list **cd01_list =3D data; + + if (!priv->list) + return -ENODEV; + + *cd01_list =3D priv->list; + + return 0; +} + +static const struct component_ops lwmi_cd01_component_ops =3D { + .bind =3D lwmi_cd01_component_bind, +}; + +/** + * lwmi_cd01_setup() - Cache all WMI data block information + * @priv: lenovo-wmi-capdata01 driver data. + * + * Allocate a cd01_list struct large enough to contain data from all WMI d= ata + * blocks provided by the interface. Then loop through each data block and + * cache the data. + * + * Return: 0 on success, or on error. + */ +static int lwmi_cd01_setup(struct lwmi_cd01_priv *priv) +{ + struct cd01_list *list; + size_t list_size; + int count, idx; + + count =3D wmidev_instance_count(priv->wdev); + list_size =3D struct_size(list, data, count); + + list =3D devm_kzalloc(&priv->wdev->dev, list_size, GFP_KERNEL); + if (!list) + return -ENOMEM; + + list->count =3D count; + + for (idx =3D 0; idx < count; idx++) { + union acpi_object *ret_obj __free(kfree) =3D NULL; + + ret_obj =3D wmidev_block_query(priv->wdev, idx); + if (!ret_obj) + return -ENODEV; + + if (ret_obj->type !=3D ACPI_TYPE_BUFFER || + ret_obj->buffer.length < sizeof(struct capdata01)) + continue; + + memcpy(&list->data[idx], ret_obj->buffer.pointer, + ret_obj->buffer.length); + } + + priv->list =3D list; + + return 0; +} + +static int lwmi_cd01_probe(struct wmi_device *wdev, const void *context) + +{ + struct lwmi_cd01_priv *priv; + int ret; + + priv =3D devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->wdev =3D wdev; + dev_set_drvdata(&wdev->dev, priv); + + ret =3D lwmi_cd01_setup(priv); + if (ret) + return ret; + + return component_add(&wdev->dev, &lwmi_cd01_component_ops); +} + +static void lwmi_cd01_remove(struct wmi_device *wdev) +{ + component_del(&wdev->dev, &lwmi_cd01_component_ops); +} + +static const struct wmi_device_id lwmi_cd01_id_table[] =3D { + { LENOVO_CAPABILITY_DATA_01_GUID, NULL }, + {} +}; + +static struct wmi_driver lwmi_cd01_driver =3D { + .driver =3D { + .name =3D "lenovo_wmi_cd01", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, + }, + .id_table =3D lwmi_cd01_id_table, + .probe =3D lwmi_cd01_probe, + .remove =3D lwmi_cd01_remove, + .no_singleton =3D true, +}; + +/** + * lwmi_cd01_match() - Match rule for the master driver. + * @dev: Pointer to the capability data 01 parent device. + * @data: Unused void pointer for passing match criteria. + * + * Return: bool. + */ +int lwmi_cd01_match(struct device *dev, void *data) +{ + return dev->driver =3D=3D &lwmi_cd01_driver.driver; +} +EXPORT_SYMBOL_NS_GPL(lwmi_cd01_match, "LENOVO_WMI_CD01"); + +module_wmi_driver(lwmi_cd01_driver); + +MODULE_DEVICE_TABLE(wmi, lwmi_cd01_id_table); +MODULE_AUTHOR("Derek J. Clark "); +MODULE_DESCRIPTION("Lenovo Capability Data 01 WMI Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/platform/x86/lenovo-wmi-capdata01.h b/drivers/platform= /x86/lenovo-wmi-capdata01.h new file mode 100644 index 000000000000..15974ce5e008 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-capdata01.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright(C) 2025 Derek J. Clark */ + +#ifndef _LENOVO_WMI_CAPDATA01_H_ +#define _LENOVO_WMI_CAPDATA01_H_ + +#include + +struct device; + +struct capdata01 { + u32 id; + u32 supported; + u32 default_value; + u32 step; + u32 min_value; + u32 max_value; +}; + +struct cd01_list { + u8 count; + struct capdata01 data[]; +}; + +int lwmi_cd01_match(struct device *dev, void *data); + +#endif /* !_LENOVO_WMI_CAPDATA01_H_ */ --=20 2.49.0 From nobody Thu Dec 18 22:18:33 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7968825F7B1; Tue, 8 Apr 2025 01:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075720; cv=none; b=enOCzfu29FWqcZAgG6PQM0bHyp8OJjOU9DJJ+wLuITY5K7/UQtQ0dWovD7ZSqjgE/pJFDyxzO+vCQ1+a5z72A83CDCb+DN0DaqKEF+hJAy4bHP5+TMhnyjGKAIcgbLuLVZIdT9uQNnilijrzb66sAudhyLOpCz2KWEJQNdcpuDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075720; c=relaxed/simple; bh=be+V4oU0YGES/bzKRbOZ+abNAZb4/3xOLxwlh5O9wNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nkwPls0Oo0yGeUNu+EucX7Oby9CsdHNm4LX7Pfs+c5XDFy85gtF5f/ZBTekPMvUJOSjqu3fWHtH30J3alGpU2mRZ7v1WOUMIzwhsJJ4Z/4q2l9y2bbEkde8Mcr0TIrB90QlTIgE/ts8AlQz23EnIXOwIOhoMwCQq6Y/leVv6ee8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GoeCBmOJ; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GoeCBmOJ" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-223f4c06e9fso45281145ad.1; Mon, 07 Apr 2025 18:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744075718; x=1744680518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9iqNV3cJLdo5lLRjxu+W8i2ibQRuJ6CcqWm7Q8Uxa7U=; b=GoeCBmOJDMSaPHJGIW4xHaTTRK1Th90JKrajrACvIYk+MZ+v31TB/vIzpMcw2POJQD 04p4lt7fmkurXhwSwlL61f+EnoSJBon4+NSq7hxPYrPrgZ+4I06i8Ffw/EBlXZrylFC+ tsYNvBY+oQa7QEM9V4onK6Hgo/QXMfhRQSykBLPWKm7cZx9fOOwQxjXTyH3vBh+SfJbV cjGquUsG4Q++pFYYCCDJAvooj4hrlbXa/jhIJX4EmzNK0Wm/7j2hbJ4rAP/S1mw4jrAX FJfRRv6Zafvslle8fgWEv2xd4cnevf5EefIZ7tHevKJlo229AaPWDlOAW2kPJDYtBNq2 E4EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744075718; x=1744680518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9iqNV3cJLdo5lLRjxu+W8i2ibQRuJ6CcqWm7Q8Uxa7U=; b=Niz9NpmJBTqmdUKTlUsp7gF3icIgumsZnCFla1R24F6bmY+thUjoSHsDrNq7JFFFZ6 gPFy/HlpwOJQxctShxuX0It+MfHUlNdcyHTKVvHMzPal977QBMEMBHvDb9ywOp7raTAK S0j67bIX219dFKYbJWr3QIFVTbENSK/0x1eD/kKxwbKpcr+iTPvWvdy+US0NOKHOeWiQ t+ZHoXEY4KaFRPzAn61Xg2DUYfShFfEXShRfOoycc1OsQh/m4/WHya1xIGkOoIwrQ95s ANpoh6u53ciMhnls9k+SLYY5lrq/SNvRuTIUWmgLBA1mxcRqMF0Iw8HhKhR9eDHIslZu Owhw== X-Forwarded-Encrypted: i=1; AJvYcCUrYeBNC2uYmG+rF4sUx4oA6XnmYIHI+WEqYBqGo4h2Lq1oKjiXmDDi/K0bLNkFWB1/K/J4HoTBZ51YRGoYa3P/UeSBmg==@vger.kernel.org, AJvYcCWAlKuXLgqSYl7d1CgtNEXfxWH+ZJny0K7cVG+BZ7pS8xacC77tbXgvKfp7QNd0qmOnynA39lqyS2o=@vger.kernel.org, AJvYcCWDj8G93PGuGac00GwZD1mrft4uUEGLmye6ObuWdsLX41VsYIjOC8XsAcmeH0ocXdg041GZEFyEQgCnxN0z@vger.kernel.org X-Gm-Message-State: AOJu0YyOES5LAJ/muSIZBEWucW6hyJ04K7Oq0HFtbkJTxII1mn5ozOMn 73cH/TyMWhgBOs/fjyQRiRzKc1iruLX3fkCU9d68pQwWuZGuGcPi X-Gm-Gg: ASbGncv8+CASh6gheUR1pziXKeIL8axRD8LLtxJ0v8etUZUUjXNERL4mrhm0itOICPT aM8a1K7Tos2bNZiYsC4INIgQQaIxTyFYG9dldDR41tbtQUP7i8OwyWE8yPIOejxRK+eo6rchz/p 7doeUSnpa0rnCveJlMbEYCCkX5fKGGZwfOrjQtlWo5dLMx6LPUZExHix5w01eCYnvFA7263yki+ a3C1wW+jttu+UWOeigbnwPOhHkyG58KfuBs9tJZr4qzZA3yCiMfw542GllCP9zsy28ZRZdOiLcC PZ7xsXDNctu00dyB75e21fPUDDgkf3iwyew71Z/ga33oBKr9m9T9NyTzHCpWJgJbvisHEmU87aK kvk/XT+gf4hqvttW3RDZiZfWWeKuLUD9MfPGj1e3WHXM= X-Google-Smtp-Source: AGHT+IFLaoCYKkMWLHTYWmzRSWT0uSXi3ckiAgurwO9/hNswnww0+g7nKPoIRNLhcYb/9zz+MOWj8A== X-Received: by 2002:a17:902:f68a:b0:220:ff82:1c60 with SMTP id d9443c01a7336-22ab5e52cfdmr19480765ad.14.1744075717530; Mon, 07 Apr 2025 18:28:37 -0700 (PDT) Received: from localhost.localdomain (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785c39c1sm87901255ad.85.2025.04.07.18.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 18:28:37 -0700 (PDT) From: "Derek J. Clark" To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Armin Wolf , Jonathan Corbet , Mario Limonciello , Luke Jones , Xino Ni , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Cody T . -H . Chiu" , John Martens , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 5/6] platform/x86: Add Lenovo Gamezone WMI Driver Date: Mon, 7 Apr 2025 18:28:14 -0700 Message-ID: <20250408012815.1032357-6-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408012815.1032357-1-derekjohn.clark@gmail.com> References: <20250408012815.1032357-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds lenovo-wmi-gamezone driver which provides the Lenovo Gamezone WMI interface that comes on Lenovo "Gaming Series" hardware. Provides ACPI platform profiles over WMI. Signed-off-by: Derek J. Clark Suggested-by: Mario Limonciello --- v5: - Move to patch 5 of the series and omit the portions of the driver that rely on Other Mode. - Rename most defines to clearly indicate they are defined in this driver. - Misc fixes from v4 review. v4: - Add notifier blocks for the Events and Other Mode drivers. - Remove notifier block chain head and all reference to Thermal Mode Event GUID. - Add header for Gamezone specific structs and functions. - Various fixes from review. v3: - Use notifier chain to report platform profile changes to any subscribed drivers. - Adds THERMAL_MODE_EVENT GUID and .notify function to trigger notifier chain. - Adds support for Extreme Mode profile on supported hardware, as well as a DMI quirk table for some devices that report extreme mode version support but so not have it fully implemented. - Update to include recent changes to platform-profile. v2: - Use devm_kmalloc to ensure driver can be instanced, remove global reference. - Ensure reverse Christmas tree for all variable declarations. - Remove extra whitespace. - Use guard(mutex) in all mutex instances, global mutex. - Use pr_fmt instead of adding the driver name to each pr_err. - Remove noisy pr_info usage. - Rename gamezone_wmi to lenovo_wmi_gz_priv and gz_wmi to priv. - Remove GZ_WMI symbol exporting. --- MAINTAINERS | 2 + drivers/platform/x86/Kconfig | 14 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-gamezone.c | 375 +++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-gamezone.h | 20 ++ 5 files changed, 412 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.c create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.h diff --git a/MAINTAINERS b/MAINTAINERS index 56ead241a053..49deb8ea4ea7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13168,6 +13168,8 @@ F: drivers/platform/x86/lenovo-wmi-capdata01.c F: drivers/platform/x86/lenovo-wmi-capdata01.h F: drivers/platform/x86/lenovo-wmi-events.c F: drivers/platform/x86/lenovo-wmi-events.h +F: drivers/platform/x86/lenovo-wmi-gamezone.c +F: drivers/platform/x86/lenovo-wmi-gamezone.h F: drivers/platform/x86/lenovo-wmi-helpers.c F: drivers/platform/x86/lenovo-wmi-helpers.h =20 diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 64663667f0cb..aaa1a69c10ca 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -467,6 +467,20 @@ config LENOVO_WMI_HELPERS tristate depends on ACPI_WMI =20 +config LENOVO_WMI_GAMEZONE + tristate "Lenovo GameZone WMI Driver" + depends on ACPI_WMI + depends on DMI + select ACPI_PLATFORM_PROFILE + select LENOVO_WMI_EVENTS + select LENOVO_WMI_HELPERS + help + Say Y here if you have a WMI aware Lenovo Legion device and would like = to use the + platform-profile firmware interface to manage power usage. + + To compile this driver as a module, choose M here: the module will + be called lenovo-wmi-gamezone. + config LENOVO_WMI_DATA01 tristate depends on ACPI_WMI diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 7a35c77221b7..60058b547de2 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -71,6 +71,7 @@ obj-$(CONFIG_YT2_1380) +=3D lenovo-yoga-tab2-pro-1380-fa= stcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) +=3D lenovo-wmi-camera.o obj-$(CONFIG_LENOVO_WMI_DATA01) +=3D lenovo-wmi-capdata01.o obj-$(CONFIG_LENOVO_WMI_EVENTS) +=3D lenovo-wmi-events.o +obj-$(CONFIG_LENOVO_WMI_GAMEZONE) +=3D lenovo-wmi-gamezone.o obj-$(CONFIG_LENOVO_WMI_HELPERS) +=3D lenovo-wmi-helpers.o =20 # Intel diff --git a/drivers/platform/x86/lenovo-wmi-gamezone.c b/drivers/platform/= x86/lenovo-wmi-gamezone.c new file mode 100644 index 000000000000..2e6d5e7faadf --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-gamezone.c @@ -0,0 +1,375 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Lenovo GameZone WMI interface driver. + * + * The GameZone WMI interface provides platform profile and fan curve sett= ings + * for devices that fall under the "Gaming Series" of Lenovo Legion device= s. + * + * Copyright(C) 2025 Derek J. Clark + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "lenovo-wmi-events.h" +#include "lenovo-wmi-gamezone.h" +#include "lenovo-wmi-helpers.h" + +#define LENOVO_GAMEZONE_GUID "887B54E3-DDDC-4B2C-8B88-68A26A8835D0" + +#define LWMI_GZ_METHOD_ID_SMARTFAN_SUPP 43 +#define LWMI_GZ_METHOD_ID_SMARTFAN_SET 44 +#define LWMI_GZ_METHOD_ID_SMARTFAN_GET 45 + +static BLOCKING_NOTIFIER_HEAD(gz_chain_head); +static DEFINE_SPINLOCK(gz_lock); + +struct lwmi_gz_priv { + enum thermal_mode current_mode; + struct notifier_block event_nb; + struct notifier_block mode_nb; + struct wmi_device *wdev; + bool extreme_supported; + struct device *ppdev; +}; + +struct quirk_entry { + bool extreme_supported; +}; + +static struct quirk_entry quirk_no_extreme_bug =3D { + .extreme_supported =3D false, +}; + +/** + * lwmi_gz_event_call() - Call method for lenovo-wmi-events driver notifie= r. + * block call chain. + * @nb: The notifier_block registered to lenovo-wmi-events driver. + * @cmd: The event type. + * @data: The data to be updated by the event. + * + * For LWMI_EVENT_THERMAL_MODE, set current_mode and notify platform_profi= le + * of a change. + * + * Return: notifier_block status. + */ +static int lwmi_gz_event_call(struct notifier_block *nb, unsigned long cmd, + void *data) +{ + enum thermal_mode *mode =3D data; + struct lwmi_gz_priv *priv; + + priv =3D container_of(nb, struct lwmi_gz_priv, event_nb); + + switch (cmd) { + case LWMI_EVENT_THERMAL_MODE: + spin_lock(&gz_lock); + priv->current_mode =3D *mode; + spin_unlock(&gz_lock); + platform_profile_notify(priv->ppdev); + return NOTIFY_STOP; + default: + return NOTIFY_DONE; + } +} + +/** + * lwmi_gz_thermal_mode_supported() - Get the version of the WMI + * interface to determine the support level. + * @wdev: The Gamezone WMI device. + * @supported: Pointer to return the support level with. + * + * Return: 0 on success, or on error. + */ +static int lwmi_gz_thermal_mode_supported(struct wmi_device *wdev, + int *supported) +{ + return lwmi_dev_evaluate_int(wdev, 0x0, LWMI_GZ_METHOD_ID_SMARTFAN_SUPP, + 0, 0, supported); +} + +/** + * lwmi_gz_thermal_mode_get() - Get the current thermal mode. + * @wdev: The Gamezone interface WMI device. + * @mode: Pointer to return the thermal mode with. + * + * Return: 0 on success, or on error. + */ +static int lwmi_gz_thermal_mode_get(struct wmi_device *wdev, + enum thermal_mode *mode) +{ + return lwmi_dev_evaluate_int(wdev, 0x0, LWMI_GZ_METHOD_ID_SMARTFAN_GET, + 0, 0, mode); +} + +/** + * lwmi_gz_profile_get_get() - Get the current platform profile. + * @dev: the Gamezone interface parent device. + * @profile: Pointer to provide the current platform profile with. + * + * Call lwmi_gz_thermal_mode_get and convert the thermal mode into a platf= orm + * profile based on the support level of the interface. + * + * Return: 0 on success, or on error. + */ +static int lwmi_gz_profile_get(struct device *dev, + enum platform_profile_option *profile) +{ + struct lwmi_gz_priv *priv =3D dev_get_drvdata(dev); + enum thermal_mode mode; + int ret; + + ret =3D lwmi_gz_thermal_mode_get(priv->wdev, &mode); + if (ret) + return ret; + + switch (mode) { + case LWMI_GZ_THERMAL_MODE_QUIET: + *profile =3D PLATFORM_PROFILE_LOW_POWER; + break; + case LWMI_GZ_THERMAL_MODE_BALANCED: + *profile =3D PLATFORM_PROFILE_BALANCED; + break; + case LWMI_GZ_THERMAL_MODE_PERFORMANCE: + if (priv->extreme_supported) { + *profile =3D PLATFORM_PROFILE_BALANCED_PERFORMANCE; + break; + } + *profile =3D PLATFORM_PROFILE_PERFORMANCE; + break; + case LWMI_GZ_THERMAL_MODE_EXTREME: + *profile =3D PLATFORM_PROFILE_PERFORMANCE; + break; + case LWMI_GZ_THERMAL_MODE_CUSTOM: + *profile =3D PLATFORM_PROFILE_CUSTOM; + break; + default: + return -EINVAL; + } + + spin_lock(&gz_lock); + priv->current_mode =3D mode; + spin_unlock(&gz_lock); + + return 0; +} + +/** + * lwmi_gz_profile_get_get() - Set the current platform profile. + * @dev: The Gamezone interface parent device. + * @profile: Pointer to the desired platform profile. + * + * Convert the given platform profile into a thermal mode based on the sup= port + * level of the interface, then call the WMI method to set the thermal mod= e. + * + * Return: 0 on success, or on error. + */ +static int lwmi_gz_profile_set(struct device *dev, + enum platform_profile_option profile) +{ + struct lwmi_gz_priv *priv =3D dev_get_drvdata(dev); + struct wmi_method_args_32 args; + enum thermal_mode mode; + int ret; + + switch (profile) { + case PLATFORM_PROFILE_LOW_POWER: + mode =3D LWMI_GZ_THERMAL_MODE_QUIET; + break; + case PLATFORM_PROFILE_BALANCED: + mode =3D LWMI_GZ_THERMAL_MODE_BALANCED; + break; + case PLATFORM_PROFILE_BALANCED_PERFORMANCE: + mode =3D LWMI_GZ_THERMAL_MODE_PERFORMANCE; + break; + case PLATFORM_PROFILE_PERFORMANCE: + if (priv->extreme_supported) { + mode =3D LWMI_GZ_THERMAL_MODE_EXTREME; + break; + } + mode =3D LWMI_GZ_THERMAL_MODE_PERFORMANCE; + break; + case PLATFORM_PROFILE_CUSTOM: + mode =3D LWMI_GZ_THERMAL_MODE_CUSTOM; + break; + default: + return -EOPNOTSUPP; + } + + args.arg0 =3D mode; + + ret =3D lwmi_dev_evaluate_int(priv->wdev, 0x0, + LWMI_GZ_METHOD_ID_SMARTFAN_SET, + (unsigned char *)&args, sizeof(args), NULL); + if (ret) + return ret; + + spin_lock(&gz_lock); + priv->current_mode =3D mode; + spin_unlock(&gz_lock); + + return 0; +} + +static const struct dmi_system_id fwbug_list[] =3D { + { + .ident =3D "Legion Go 8APU1", + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"), + }, + .driver_data =3D &quirk_no_extreme_bug, + }, + { + .ident =3D "Legion Go S 8APU1", + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Legion Go S 8APU1"), + }, + .driver_data =3D &quirk_no_extreme_bug, + }, + { + .ident =3D "Legion Go S 8ARP1", + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Legion Go S 8ARP1"), + }, + .driver_data =3D &quirk_no_extreme_bug, + }, + {}, + +}; + +/** + * extreme_supported() - Evaluate if a device supports extreme thermal mod= e. + * @profile_support_ver: Version of the WMI interface. + * + * Determine if the extreme thermal mode is supported by the hardware. + * Anything version 5 or lower does not. For devices wuth a version 6 or + * greater do a DMI check, as some devices report a version that supports + * extreme mode but have an incomplete entry in the BIOS. To ensure this + * cannot be set, quirk them to prevent assignment. + * + * Return: bool. + */ +static bool extreme_supported(int profile_support_ver) +{ + const struct dmi_system_id *dmi_id; + struct quirk_entry *quirks; + + if (profile_support_ver < 6) + return false; + + dmi_id =3D dmi_first_match(fwbug_list); + if (!dmi_id) + return true; + + quirks =3D dmi_id->driver_data; + return quirks->extreme_supported; +} + +/** + * lwmi_gz_platform_profile_probe - Enable and set up the platform profile + * device. + * @drvdata: Driver data for the interface. + * @choices: Container for enabled platform profiles. + * + * Determine if thermal mode is supported, and if so to what feature level. + * Then enable all supported platform profiles. + * + * Return: 0 on success, or on error. + */ +static int lwmi_gz_platform_profile_probe(void *drvdata, unsigned long *ch= oices) +{ + struct lwmi_gz_priv *priv =3D drvdata; + int profile_support_ver; + int ret; + + ret =3D lwmi_gz_thermal_mode_supported(priv->wdev, &profile_support_ver); + if (ret) + return ret; + + if (profile_support_ver < 1) + return -ENODEV; + + priv->extreme_supported =3D extreme_supported(profile_support_ver); + + set_bit(PLATFORM_PROFILE_LOW_POWER, choices); + set_bit(PLATFORM_PROFILE_BALANCED, choices); + set_bit(PLATFORM_PROFILE_PERFORMANCE, choices); + set_bit(PLATFORM_PROFILE_CUSTOM, choices); + + if (priv->extreme_supported) + set_bit(PLATFORM_PROFILE_BALANCED_PERFORMANCE, choices); + + return 0; +} + +static const struct platform_profile_ops lwmi_gz_platform_profile_ops =3D { + .probe =3D lwmi_gz_platform_profile_probe, + .profile_get =3D lwmi_gz_profile_get, + .profile_set =3D lwmi_gz_profile_set, +}; + +static int lwmi_gz_probe(struct wmi_device *wdev, const void *context) +{ + struct lwmi_gz_priv *priv; + int ret; + + priv =3D devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->wdev =3D wdev; + dev_set_drvdata(&wdev->dev, priv); + + priv->ppdev =3D platform_profile_register(&wdev->dev, + "lenovo-wmi-gamezone", priv, + &lwmi_gz_platform_profile_ops); + + if (IS_ERR(priv->ppdev)) + return -ENODEV; + + ret =3D lwmi_gz_thermal_mode_get(wdev, &priv->current_mode); + if (ret) + return ret; + + priv->event_nb.notifier_call =3D lwmi_gz_event_call; + ret =3D devm_lwmi_events_register_notifier(&wdev->dev, &priv->event_nb); + if (ret) + return ret; + + return 0; +} + +static const struct wmi_device_id lwmi_gz_id_table[] =3D { + { LENOVO_GAMEZONE_GUID, NULL }, + {} +}; + +static struct wmi_driver lwmi_gz_driver =3D { + .driver =3D { + .name =3D "lenovo_wmi_gamezone", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, + }, + .id_table =3D lwmi_gz_id_table, + .probe =3D lwmi_gz_probe, + .no_singleton =3D true, +}; + +module_wmi_driver(lwmi_gz_driver); + +MODULE_IMPORT_NS("LENOVO_WMI_EVENTS"); +MODULE_IMPORT_NS("LENOVO_WMI_HELPERS"); +MODULE_DEVICE_TABLE(wmi, lwmi_gz_id_table); +MODULE_AUTHOR("Derek J. Clark "); +MODULE_DESCRIPTION("Lenovo GameZone WMI Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/platform/x86/lenovo-wmi-gamezone.h b/drivers/platform/= x86/lenovo-wmi-gamezone.h new file mode 100644 index 000000000000..1f8366b67b49 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-gamezone.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright(C) 2025 Derek J. Clark */ + +#ifndef _LENOVO_WMI_GAMEZONE_H_ +#define _LENOVO_WMI_GAMEZONE_H_ + +enum gamezone_events_type { + LWMI_GZ_GET_THERMAL_MODE =3D 1, +}; + +enum thermal_mode { + LWMI_GZ_THERMAL_MODE_QUIET =3D 0x01, + LWMI_GZ_THERMAL_MODE_BALANCED =3D 0x02, + LWMI_GZ_THERMAL_MODE_PERFORMANCE =3D 0x03, + LWMI_GZ_THERMAL_MODE_EXTREME =3D 0xE0, /* Ver 6+ */ + LWMI_GZ_THERMAL_MODE_CUSTOM =3D 0xFF, +}; + +#endif /* !_LENOVO_WMI_GAMEZONE_H_ */ --=20 2.49.0 From nobody Thu Dec 18 22:18:33 2025 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 980C725F97B; Tue, 8 Apr 2025 01:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075723; cv=none; b=OkiwwJO61DCyly7974xgXhYo7lVZiSaBwUCZJxr2F5neb2q5Ma1rsaORgYjJqIMJjta5urg9oFaCV1sdky1S/bRXLs2dX9lGYi/E2WyHmkAuwbyMdFi6r40aYsqPxPoSbHgcsp554z+raMaabChSSsX47FKq0zRSPxXAqLyivTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744075723; c=relaxed/simple; bh=9juF4lZrN7JBNwB7jjS7ZSUaApDUwXco2RVAurT10vY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yg2oUY0/iaWB9q65zauTMG611kv4jbGATMDM2EimN9YS/gwb10i9uBmw9LyIYmrWZYai1m2nVcJn4dClum6nzZ0ZNS4dBvTIvaz5k+HkGmdYuGA/RPBybAZ61OLGmxt+iV9PZ+JEv9nqyyPoaUuKt42oh7cVmcG7wT2c2Tush3k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PLIUAtkW; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PLIUAtkW" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-22401f4d35aso54763895ad.2; Mon, 07 Apr 2025 18:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744075720; x=1744680520; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=68H7RgwF7/UMwJhmeugghcmSTp58xHToh8gjGlxH1Ec=; b=PLIUAtkWsyEM8VwXmtq8pwommtZg7WP4SsWz4l3ffblKWefWEqDuWmlEaeMoZJyFGS BSLNJxVprVwZLGe75k4gvW0kmMZPx9EvlzoOmAIGoiFIUigw6buhKzroHkx0ALYQeJiL WfvSJ7I/E96v/htJ44aTf+zqUQx+fjDkwYEIP92yLrNb+OwcRKaVwWdW08k9cliQjDr2 hbvOruaTZ7UQqTdsoC33AW3izcvjROAT6+kU8rUFH2IQGrwFJ0mZ1oHvBSHhXi1biXdf kubbTcigRoQCkfUZafJqLiqIadp6janBdxjegzhtPKwv7OuE/vikiPDrVuOokHjIPX2g L0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744075720; x=1744680520; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=68H7RgwF7/UMwJhmeugghcmSTp58xHToh8gjGlxH1Ec=; b=IQXmUX5FCU+56/9PSCP6oIW9KzgMZsUHvodCN9wGINorP7PRhSM7WaZANpgxAOWA8h 0ZOZ9wIkSQa9FWDltZw+SzXft2wn2jETu49IHqlwfEXSBygr+zeDEZ5me9kMfCC3pO5E hs7/oCVTo7U3TzWP351ym4Mvg3YHl6OdJ4T//QClt7QhPDXAElGBDsbN0kbzGPQpCwTo Zn4Ol3iivmJvCFzxxBbAlUeQGTFNRISwedro0NUaDc5q/yaIfD56N6s4trXxCWAYI8+n v6xNEMHUhvk0ELndweav1bxAbB7iVrFs0D3CKcz/MVCiwsvAKFByPFr0Z+UIyJYYZ7JD SdJA== X-Forwarded-Encrypted: i=1; AJvYcCWW8H8Pz8tgQHs+hYQKQ2YvRSt3GRYM2NxwMF6Xjcvb/qSaRnxI1BpNIf5+3PBkKKREI8pAvGkE5kpjv9jWaL8MoCXuxA==@vger.kernel.org, AJvYcCWzFNVs1IyyigojXLyuaqbjkSUIgtXYdJXf6P1wvwiK2v/vuWuvDo1Z7I1WXmedQLW0rqOjmvACuWM=@vger.kernel.org, AJvYcCXVn5w58pbNn869PEkVZxPMFjNUx/S7KqZQgL2TpvaSZw/b2UyXzuidp3R4Fg1TfKlk5qRkJbiDSc0PDSsW@vger.kernel.org X-Gm-Message-State: AOJu0Yw/M8GAzVMy3mx4wrT5qwkcS4OnsaVK+e4H8wRkq0TsECq8a8sL pHbf2lDwLZjQ9u4tVOFHj4avibzRXkT7cKS16xVXLQAJPMweicO5 X-Gm-Gg: ASbGncsqU6kPz23NJqNrJ7+BlmjOQz+cu6jDdfK9TaFLGXIpV/MAqE5gV/IFhO1vfPT G0++8iXmejtvHyq1t+7ftK6yEJKhW2ck5CgSSegVDXf1baKszXlbn7qyiwm77pZHeai5agy9x5Z 29xupYkvilA8GTpwmWIO7AGyr8iM1oBYNIg02tRscCC0P5aee1pw9UaDh/dgy/rJYv2R55iZTP8 8BnPyk47r4HALvPXV+zyHSEtk0+vCVo3k+Y96egZ6n85WfUxFKTHDx6Bg6i4twjnNn+gBJCWZZL gzFbmE+cboVeWH2smNCZ0QMaHYQaWiAGP0oc/hoCsoXd0Xbo5kIb0V3LF3jcszR13WE4rmVXF3D sjADfaYZEls4zzLD05AlW+ggxZ4gY5MESGZa99rNcLTI= X-Google-Smtp-Source: AGHT+IH2cNAGg4KGJeXG7zxMy6losG6w52gpvx87f3gx+GzfR2e1GaaZbm3YkNEuoSWWxpIOrXFJvw== X-Received: by 2002:a17:903:2383:b0:223:4d7e:e52c with SMTP id d9443c01a7336-22a95514117mr166895705ad.5.1744075719542; Mon, 07 Apr 2025 18:28:39 -0700 (PDT) Received: from localhost.localdomain (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785c39c1sm87901255ad.85.2025.04.07.18.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 18:28:39 -0700 (PDT) From: "Derek J. Clark" To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Armin Wolf , Jonathan Corbet , Mario Limonciello , Luke Jones , Xino Ni , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Cody T . -H . Chiu" , John Martens , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 6/6] platform/x86: Add Lenovo Other Mode WMI Driver Date: Mon, 7 Apr 2025 18:28:15 -0700 Message-ID: <20250408012815.1032357-7-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408012815.1032357-1-derekjohn.clark@gmail.com> References: <20250408012815.1032357-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds lenovo-wmi-other driver which provides the Lenovo "Other Mode" WMI interface that comes on some Lenovo "Gaming Series" hardware. Provides a firmware-attributes class which enables the use of tunable knobs for SPL, SPPT, and FPPT. Signed-off-by: Derek J. Clark Suggested-by: Mario Limonciello --- v5: - Switch from locally storing capability data list to storing a pointer from the capability data interface. - Add portion of Gamezone driver that relies on the exported functions of this driver. - Properly initialize IDA and use it for naming the firmware-attributes path. - Rename most defines to clearly indicate they are from this driver. - Misc fixes from v4 review. v4: - Treat Other Mode as a notifier chain head, use the notifier chain to get the current mode from Gamezone. - Add header file for Other Mode specific structs and finctions. - Use component master bind to cache the capdata01 array locally. - Drop all reference to external driver private data structs. - Various fixes from review. v3: - Add notifier block and store result for getting the Gamezone interface profile changes. - Add driver as master component of capdata01 driver. - Use FIELD_PREP where appropriate. - Move macros and associated functions out of lemovo-wmi.h that are only used by this driver. v2: - Use devm_kmalloc to ensure driver can be instanced, remove global reference. - Ensure reverse Christmas tree for all variable declarations. - Remove extra whitespace. - Use guard(mutex) in all mutex instances, global mutex. - Use pr_fmt instead of adding the driver name to each pr_err. - Remove noisy pr_info usage. - Rename other_method_wmi to lenovo_wmi_om_priv and om_wmi to priv. - Use list to get the lenovo_wmi_om_priv instance in some macro called functions as the data provided by the macros that use it doesn't pass a member of the struct for use in container_of. - Do not rely on GameZone interface to grab the current fan mode. --- MAINTAINERS | 2 + drivers/platform/x86/Kconfig | 15 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-gamezone.c | 35 ++ drivers/platform/x86/lenovo-wmi-other.c | 677 +++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-other.h | 16 + 6 files changed, 746 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-other.c create mode 100644 drivers/platform/x86/lenovo-wmi-other.h diff --git a/MAINTAINERS b/MAINTAINERS index 49deb8ea4ea7..0416afd997a0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13172,6 +13172,8 @@ F: drivers/platform/x86/lenovo-wmi-gamezone.c F: drivers/platform/x86/lenovo-wmi-gamezone.h F: drivers/platform/x86/lenovo-wmi-helpers.c F: drivers/platform/x86/lenovo-wmi-helpers.h +F: drivers/platform/x86/lenovo-wmi-other.c +F: drivers/platform/x86/lenovo-wmi-other.h =20 LENOVO WMI HOTKEY UTILITIES DRIVER M: Jackie Dong diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index aaa1a69c10ca..be5ab24960b5 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -485,6 +485,21 @@ config LENOVO_WMI_DATA01 tristate depends on ACPI_WMI =20 +config LENOVO_WMI_TUNING + tristate "Lenovo Other Mode WMI Driver" + depends on ACPI_WMI + select FW_ATTR_CLASS + select LENOVO_WMI_DATA01 + select LENOVO_WMI_EVENTS + select LENOVO_WMI_HELPERS + help + Say Y here if you have a WMI aware Lenovo Legion device and would like = to use the + firmware_attributes API to control various tunable settings typically e= xposed by + Lenovo software in Windows. + + To compile this driver as a module, choose M here: the module will + be called lenovo-wmi-other. + config IDEAPAD_LAPTOP tristate "Lenovo IdeaPad Laptop Extras" depends on ACPI diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 60058b547de2..f3e64926a96b 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -73,6 +73,7 @@ obj-$(CONFIG_LENOVO_WMI_DATA01) +=3D lenovo-wmi-capdata01= .o obj-$(CONFIG_LENOVO_WMI_EVENTS) +=3D lenovo-wmi-events.o obj-$(CONFIG_LENOVO_WMI_GAMEZONE) +=3D lenovo-wmi-gamezone.o obj-$(CONFIG_LENOVO_WMI_HELPERS) +=3D lenovo-wmi-helpers.o +obj-$(CONFIG_LENOVO_WMI_TUNING) +=3D lenovo-wmi-other.o =20 # Intel obj-y +=3D intel/ diff --git a/drivers/platform/x86/lenovo-wmi-gamezone.c b/drivers/platform/= x86/lenovo-wmi-gamezone.c index 2e6d5e7faadf..9c80561f931c 100644 --- a/drivers/platform/x86/lenovo-wmi-gamezone.c +++ b/drivers/platform/x86/lenovo-wmi-gamezone.c @@ -22,6 +22,7 @@ #include "lenovo-wmi-events.h" #include "lenovo-wmi-gamezone.h" #include "lenovo-wmi-helpers.h" +#include "lenovo-wmi-other.h" =20 #define LENOVO_GAMEZONE_GUID "887B54E3-DDDC-4B2C-8B88-68A26A8835D0" =20 @@ -49,6 +50,34 @@ static struct quirk_entry quirk_no_extreme_bug =3D { .extreme_supported =3D false, }; =20 +/** + * lwmi_gz_mode_call() - Call method for lenovo-wmi-other driver notifier. + * + * @nb: The notifier_block registered to lenovo-wmi-other driver. + * @cmd: The event type. + * @data: Thermal mode enum pointer pointer for returning the thermal mode. + * + * For LWMI_GZ_GET_THERMAL_MODE, retrieve the current thermal mode. + * + * Return: Notifier_block status. + */ +static int lwmi_gz_mode_call(struct notifier_block *nb, unsigned long cmd, + void *data) +{ + enum thermal_mode **mode =3D data; + struct lwmi_gz_priv *priv; + + priv =3D container_of(nb, struct lwmi_gz_priv, mode_nb); + + switch (cmd) { + case LWMI_GZ_GET_THERMAL_MODE: + **mode =3D priv->current_mode; + return NOTIFY_STOP; + default: + return NOTIFY_DONE; + } +} + /** * lwmi_gz_event_call() - Call method for lenovo-wmi-events driver notifie= r. * block call chain. @@ -347,6 +376,11 @@ static int lwmi_gz_probe(struct wmi_device *wdev, cons= t void *context) if (ret) return ret; =20 + priv->mode_nb.notifier_call =3D lwmi_gz_mode_call; + ret =3D devm_lwmi_om_register_notifier(&wdev->dev, &priv->mode_nb); + if (ret) + return ret; + return 0; } =20 @@ -369,6 +403,7 @@ module_wmi_driver(lwmi_gz_driver); =20 MODULE_IMPORT_NS("LENOVO_WMI_EVENTS"); MODULE_IMPORT_NS("LENOVO_WMI_HELPERS"); +MODULE_IMPORT_NS("LENOVO_WMI_OTHER"); MODULE_DEVICE_TABLE(wmi, lwmi_gz_id_table); MODULE_AUTHOR("Derek J. Clark "); MODULE_DESCRIPTION("Lenovo GameZone WMI Driver"); diff --git a/drivers/platform/x86/lenovo-wmi-other.c b/drivers/platform/x86= /lenovo-wmi-other.c new file mode 100644 index 000000000000..342883a90270 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-other.c @@ -0,0 +1,677 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Lenovo Other Mode WMI interface driver. + * + * This driver uses the fw_attributes class to expose the various WMI func= tions + * provided by the "Other Mode" WMI interface. This enables CPU and GPU po= wer + * limit as well as various other attributes for devices that fall under t= he + * "Gaming Series" of Lenovo laptop devices. Each attribute exposed by the + * "Other Mode"" interface has a corresponding Capability Data struct that + * allows the driver to probe details about the attribute such as if it is + * supported by the hardware, the default_value, max_value, min_value, and= step + * increment. + * + * These attributes typically don't fit anywhere else in the sysfs and are= set + * in Windows using one of Lenovo's multiple user applications. + * + * Copyright(C) 2025 Derek J. Clark + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "lenovo-wmi-capdata01.h" +#include "lenovo-wmi-events.h" +#include "lenovo-wmi-gamezone.h" +#include "lenovo-wmi-helpers.h" +#include "lenovo-wmi-other.h" +#include "firmware_attributes_class.h" + +#define LENOVO_OTHER_MODE_GUID "DC2A8805-3A8C-41BA-A6F7-092E0089CD3B" + +#define LWMI_DEVICE_ID_CPU 0x01 + +#define LWMI_FEATURE_ID_CPU_SPPT 0x01 +#define LWMI_FEATURE_ID_CPU_SPL 0x02 +#define LWMI_FEATURE_ID_CPU_FPPT 0x03 + +#define LWMI_TYPE_ID_NONE 0x00 + +#define LWMI_FEATURE_VALUE_GET 17 +#define LWMI_FEATURE_VALUE_SET 18 + +#define LWMI_ATTR_DEV_ID_MASK GENMASK(31, 24) +#define LWMI_ATTR_FEAT_ID_MASK GENMASK(23, 16) +#define LWMI_ATTR_MODE_ID_MASK GENMASK(15, 8) +#define LWMI_ATTR_TYPE_ID_MASK GENMASK(7, 0) + +#define LWMI_OM_FW_ATTR_BASE_PATH "lenovo-wmi-other" + +static BLOCKING_NOTIFIER_HEAD(om_chain_head); +static DEFINE_IDA(lwmi_om_ida); + +enum attribute_property { + DEFAULT_VAL, + MAX_VAL, + MIN_VAL, + STEP_VAL, + SUPPORTED, +}; + +struct lwmi_om_priv { + struct component_master_ops *ops; + /* *cd01_list is only valid after master bind and while capdata01 exists = */ + struct cd01_list *cd01_list; + struct device *fw_attr_dev; + struct kset *fw_attr_kset; + struct notifier_block nb; + struct wmi_device *wdev; + int ida_id; +}; + +struct tunable_attr_01 { + struct capdata01 *capdata; + struct device *dev; + u32 feature_id; + u32 device_id; + u32 type_id; +}; + +struct tunable_attr_01 ppt_pl1_spl =3D { .device_id =3D LWMI_DEVICE_ID_CPU, + .feature_id =3D LWMI_FEATURE_ID_CPU_SPL, + .type_id =3D LWMI_TYPE_ID_NONE }; +struct tunable_attr_01 ppt_pl2_sppt =3D { .device_id =3D LWMI_DEVICE_ID_CP= U, + .feature_id =3D LWMI_FEATURE_ID_CPU_SPPT, + .type_id =3D LWMI_TYPE_ID_NONE }; +struct tunable_attr_01 ppt_pl3_fppt =3D { .device_id =3D LWMI_DEVICE_ID_CP= U, + .feature_id =3D LWMI_FEATURE_ID_CPU_FPPT, + .type_id =3D LWMI_TYPE_ID_NONE }; + +struct capdata01_attr_group { + const struct attribute_group *attr_group; + struct tunable_attr_01 *tunable_attr; +}; + +/** + * lwmi_om_register_notifier() - Add a notifier to the blocking notifier c= hain + * @nb: The notifier_block struct to register + * + * Call blocking_notifier_chain_register to register the notifier block to= the + * lenovo-wmi-other driver notifer chain. + * + * Return: 0 on success, %-EEXIST on error. + */ +int lwmi_om_register_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_register(&om_chain_head, nb); +} +EXPORT_SYMBOL_NS_GPL(lwmi_om_register_notifier, "LENOVO_WMI_OTHER"); + +/** + * lwmi_om_unregister_notifier() - Remove a notifier from the blocking not= ifier + * chain. + * @nb: The notifier_block struct to register + * + * Call blocking_notifier_chain_unregister to unregister the notifier bloc= k from the + * lenovo-wmi-other driver notifer chain. + * + * Return: 0 on success, %-ENOENT on error. + */ +int lwmi_om_unregister_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_unregister(&om_chain_head, nb); +} +EXPORT_SYMBOL_NS_GPL(lwmi_om_unregister_notifier, "LENOVO_WMI_OTHER"); + +/** + * devm_lwmi_om_unregister_notifier() - Remove a notifier from the blocking + * notifier chain. + * @data: Void pointer to the notifier_block struct to register. + * + * Call lwmi_om_unregister_notifier to unregister the notifier block from = the + * lenovo-wmi-other driver notifer chain. + * + * Return: 0 on success, %-ENOENT on error. + */ +static void devm_lwmi_om_unregister_notifier(void *data) +{ + struct notifier_block *nb =3D data; + + lwmi_om_unregister_notifier(nb); +} + +/** + * devm_lwmi_om_register_notifier() - Add a notifier to the blocking notif= ier + * chain. + * @dev: The parent device of the notifier_block struct. + * @nb: The notifier_block struct to register + * + * Call lwmi_om_register_notifier to register the notifier block to the + * lenovo-wmi-other driver notifer chain. Then add devm_lwmi_om_unregister= _notifier + * as a device managed ation to automatically unregister the notifier block + * upon parent device removal. + * + * Return: 0 on success, or on error. + */ +int devm_lwmi_om_register_notifier(struct device *dev, + struct notifier_block *nb) +{ + int ret; + + ret =3D lwmi_om_register_notifier(nb); + if (ret < 0) + return ret; + + return devm_add_action_or_reset(dev, devm_lwmi_om_unregister_notifier, + nb); +} +EXPORT_SYMBOL_NS_GPL(devm_lwmi_om_register_notifier, "LENOVO_WMI_OTHER"); + +/** + * lwmi_om_notifier_call() - Call functions for the notifier call chain. + * @mode: Pointer to a thermal mode enum to retrieve the data from. + * + * Call blocking_notifier_call_chain to retrieve the thermal mode from the + * lenovo-wmi-gamezone driver. + * + * Return: 0 on success, or on error. + */ +static int lwmi_om_notifier_call(enum thermal_mode *mode) +{ + int ret; + + ret =3D blocking_notifier_call_chain(&om_chain_head, LWMI_GZ_GET_THERMAL_= MODE, &mode); + if ((ret & ~NOTIFY_STOP_MASK) !=3D NOTIFY_OK) + return -EINVAL; + + return 0; +} + +/* Attribute Methods */ + +/** + * int_type_show() - Emit the data type for an integer attribute + * @kobj: Pointer to the driver object. + * @kobj_attribute: Pointer to the attribute calling this function. + * @buf: The buffer to write to. + * + * Return: Number of characters written to buf. + */ +static ssize_t int_type_show(struct kobject *kobj, struct kobj_attribute *= kattr, + char *buf) +{ + return sysfs_emit(buf, "integer\n"); +} + +/** + * attr_capdata01_get - Get the data of the specified attribute + * @tunable_attr: The attribute to be populated. + * + * Retrieves the capability data 01 struct pointer for the given + * attribute for its specified thermal mode. + * + * Return: Either a pointer to capability data, or NULL. + */ +static struct capdata01 *attr_capdata01_get_data(struct lwmi_om_priv *priv, + u32 attribute_id) +{ + int idx; + + for (idx =3D 0; idx < priv->cd01_list->count; idx++) { + if (priv->cd01_list->data[idx].id !=3D attribute_id) + continue; + return &priv->cd01_list->data[idx]; + } + return NULL; +} + +/** + * attr_capdata01_show() - Get the value of the specified attribute proper= ty + * + * @kobj: Pointer to the driver object. + * @kobj_attribute: Pointer to the attribute calling this function. + * @buf: The buffer to write to. + * @tunable_attr: The attribute to be read. + * @prop: The property of this attribute to be read. + * + * Retrieves the given property from the capability data 01 struct for the + * specified attribute's "custom" thermal mode. This function is intended + * to be generic so it can be called from any integer attributes "_show" + * function. + * + * If the WMI is success the sysfs attribute is notified. + * + * Return: Either number of characters written to buf, or an error. + */ +static ssize_t attr_capdata01_show(struct kobject *kobj, + struct kobj_attribute *kattr, char *buf, + struct tunable_attr_01 *tunable_attr, + enum attribute_property prop) +{ + struct lwmi_om_priv *priv =3D dev_get_drvdata(tunable_attr->dev); + struct capdata01 *capdata; + u32 attribute_id; + int value; + + attribute_id =3D + FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) | + FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) | + FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, LWMI_GZ_THERMAL_MODE_CUSTOM) | + FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id); + + capdata =3D attr_capdata01_get_data(priv, attribute_id); + + if (!capdata) + return -ENODEV; + + switch (prop) { + case DEFAULT_VAL: + value =3D capdata->default_value; + break; + case MAX_VAL: + value =3D capdata->max_value; + break; + case MIN_VAL: + value =3D capdata->min_value; + break; + case STEP_VAL: + value =3D capdata->step; + break; + default: + return -EINVAL; + } + return sysfs_emit(buf, "%d\n", value); +} + +/** + * att_current_value_store() - Set the current value of the given attribute + * @kobj: Pointer to the driver object. + * @kobj_attribute: Pointer to the attribute calling this function. + * @buf: The buffer to read from, this is parsed to `int` type. + * @count: Required by sysfs attribute macros, pass in from the callee att= r. + * @tunable_attr: The attribute to be stored. + * + * Sets the value of the given attribute when operating under the "custom" + * smartfan profile. The current smartfan profile is retrieved from the + * lenovo-wmi-gamezone driver and error is returned if the result is not + * "custom". This function is intended to be generic so it can be called f= rom + * any integer attribute's "_store" function. The integer to be sent to th= e WMI + * method is range checked and an error is returned if out of range. + * + * If the value is valid and WMI is success, then the sysfs attribute is + * notified. + * + * Return: Either count, or an error. + */ +static ssize_t attr_current_value_store(struct kobject *kobj, + struct kobj_attribute *kattr, + const char *buf, size_t count, + struct tunable_attr_01 *tunable_attr) +{ + struct lwmi_om_priv *priv =3D dev_get_drvdata(tunable_attr->dev); + struct wmi_method_args_32 args; + struct capdata01 *capdata; + enum thermal_mode mode; + u32 attribute_id; + u32 value; + int err; + + err =3D lwmi_om_notifier_call(&mode); + if (err) + return err; + + if (mode !=3D LWMI_GZ_THERMAL_MODE_CUSTOM) + return -EBUSY; + + attribute_id =3D + FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) | + FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) | + FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, mode) | + FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id); + + capdata =3D attr_capdata01_get_data(priv, attribute_id); + + if (!capdata) + return -ENODEV; + + err =3D kstrtouint(buf, 10, &value); + if (err) + return err; + + if (value < capdata->min_value || value > capdata->max_value) + return -EINVAL; + + args.arg0 =3D attribute_id; + args.arg1 =3D value; + + err =3D lwmi_dev_evaluate_int(priv->wdev, 0x0, LWMI_FEATURE_VALUE_SET, + (unsigned char *)&args, sizeof(args), NULL); + + if (err) + return err; + + return count; +}; + +/** + * attr_current_value_show() - Get the current value of the given attribute + * @kobj: Pointer to the driver object. + * @kobj_attribute: Pointer to the attribute calling this function. + * @buf: The buffer to write to. + * @tunable_attr: The attribute to be read. + * + * Retrieves the value of the given attribute for the current smartfan pro= file. + * The current smartfan profile is retrieved from the lenovo-wmi-gamezone = driver. + * This function is intended to be generic so it can be called from any in= teger + * attribute's "_show" function. + * + * If the WMI is success the sysfs attribute is notified. + * + * Return: Either number of characters written to buf, or an error. + */ +static ssize_t attr_current_value_show(struct kobject *kobj, + struct kobj_attribute *kattr, char *buf, + struct tunable_attr_01 *tunable_attr) +{ + struct lwmi_om_priv *priv =3D dev_get_drvdata(tunable_attr->dev); + struct wmi_method_args_32 args; + enum thermal_mode mode; + u32 attribute_id; + int retval; + int err; + + err =3D lwmi_om_notifier_call(&mode); + if (err) + return err; + + attribute_id =3D + FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) | + FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) | + FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, mode) | + FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id); + + args.arg0 =3D attribute_id; + + err =3D lwmi_dev_evaluate_int(priv->wdev, 0x0, LWMI_FEATURE_VALUE_GET, + (unsigned char *)&args, sizeof(args), + &retval); + + if (err) + return err; + + return sysfs_emit(buf, "%d\n", retval); +} + +/* Lenovo WMI Other Mode Attribute macros */ +#define __LWMI_ATTR_RO(_func, _name) \ + { \ + .attr =3D { .name =3D __stringify(_name), .mode =3D 0444 }, \ + .show =3D _func##_##_name##_show, \ + } + +#define __LWMI_ATTR_RO_AS(_name, _show) \ + { \ + .attr =3D { .name =3D __stringify(_name), .mode =3D 0444 }, \ + .show =3D _show, \ + } + +#define __LWMI_ATTR_RW(_func, _name) \ + __ATTR(_name, 0644, _func##_##_name##_show, _func##_##_name##_store) + +/* Shows a formatted static variable */ +#define __LWMI_ATTR_SHOW_FMT(_prop, _attrname, _fmt, _val) = \ + static ssize_t _attrname##_##_prop##_show( \ + struct kobject *kobj, struct kobj_attribute *kattr, char *buf) \ + { \ + return sysfs_emit(buf, _fmt, _val); \ + } \ + static struct kobj_attribute attr_##_attrname##_##_prop =3D \ + __LWMI_ATTR_RO(_attrname, _prop) + +/* Attribute current value read/write */ +#define __LWMI_TUNABLE_CURRENT_VALUE_CAP01(_attrname) = \ + static ssize_t _attrname##_current_value_store( \ + struct kobject *kobj, struct kobj_attribute *kattr, \ + const char *buf, size_t count) \ + { \ + return attr_current_value_store(kobj, kattr, buf, count, \ + &_attrname); \ + } \ + static ssize_t _attrname##_current_value_show( \ + struct kobject *kobj, struct kobj_attribute *kattr, char *buf) \ + { \ + return attr_current_value_show(kobj, kattr, buf, &_attrname); \ + } \ + static struct kobj_attribute attr_##_attrname##_current_value =3D \ + __LWMI_ATTR_RW(_attrname, current_value) + +/* Attribute property read only */ +#define __LWMI_TUNABLE_RO_CAP01(_prop, _attrname, _prop_type) = \ + static ssize_t _attrname##_##_prop##_show( \ + struct kobject *kobj, struct kobj_attribute *kattr, char *buf) \ + { \ + return attr_capdata01_show(kobj, kattr, buf, &_attrname, \ + _prop_type); \ + } \ + static struct kobj_attribute attr_##_attrname##_##_prop =3D \ + __LWMI_ATTR_RO(_attrname, _prop) + +#define LWMI_ATTR_GROUP_TUNABLE_CAP01(_attrname, _fsname, _dispname) \ + __LWMI_TUNABLE_CURRENT_VALUE_CAP01(_attrname); \ + __LWMI_TUNABLE_RO_CAP01(default_value, _attrname, DEFAULT_VAL); \ + __LWMI_ATTR_SHOW_FMT(display_name, _attrname, "%s\n", _dispname); \ + __LWMI_TUNABLE_RO_CAP01(max_value, _attrname, MAX_VAL); \ + __LWMI_TUNABLE_RO_CAP01(min_value, _attrname, MIN_VAL); \ + __LWMI_TUNABLE_RO_CAP01(scalar_increment, _attrname, STEP_VAL); \ + static struct kobj_attribute attr_##_attrname##_type =3D \ + __LWMI_ATTR_RO_AS(type, int_type_show); \ + static struct attribute *_attrname##_attrs[] =3D { \ + &attr_##_attrname##_current_value.attr, \ + &attr_##_attrname##_default_value.attr, \ + &attr_##_attrname##_display_name.attr, \ + &attr_##_attrname##_max_value.attr, \ + &attr_##_attrname##_min_value.attr, \ + &attr_##_attrname##_scalar_increment.attr, \ + &attr_##_attrname##_type.attr, \ + NULL, \ + }; \ + static const struct attribute_group _attrname##_attr_group =3D { \ + .name =3D _fsname, .attrs =3D _attrname##_attrs \ + } + +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl1_spl, "ppt_pl1_spl", + "Set the CPU sustained power limit"); +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl2_sppt, "ppt_pl2_sppt", + "Set the CPU slow package power tracking limit"); +LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl3_fppt, "ppt_pl3_fppt", + "Set the CPU fast package power tracking limit"); + +static struct capdata01_attr_group cd01_attr_groups[] =3D { + { &ppt_pl1_spl_attr_group, &ppt_pl1_spl }, + { &ppt_pl2_sppt_attr_group, &ppt_pl2_sppt }, + { &ppt_pl3_fppt_attr_group, &ppt_pl3_fppt }, + {}, +}; + +/** + * lwmi_om_fw_attr_add() - Register all firmware_attributes_class members + * @priv: The Other Mode driver data. + * + * Return: Either 0, or an error. + */ +static int lwmi_om_fw_attr_add(struct lwmi_om_priv *priv) +{ + unsigned int i; + int err; + + priv->ida_id =3D ida_alloc(&lwmi_om_ida, GFP_KERNEL); + if (priv->ida_id < 0) + return priv->ida_id; + + priv->fw_attr_dev =3D device_create(&firmware_attributes_class, NULL, + MKDEV(0, 0), NULL, "%s-%u", + LWMI_OM_FW_ATTR_BASE_PATH, + priv->ida_id); + if (IS_ERR(priv->fw_attr_dev)) { + err =3D PTR_ERR(priv->fw_attr_dev); + goto err_free_ida; + } + + priv->fw_attr_kset =3D kset_create_and_add("attributes", NULL, &priv->fw_= attr_dev->kobj); + if (!priv->fw_attr_kset) { + err =3D -ENOMEM; + goto err_destroy_classdev; + } + + for (i =3D 0; i < ARRAY_SIZE(cd01_attr_groups) - 1; i++) { + err =3D sysfs_create_group(&priv->fw_attr_kset->kobj, cd01_attr_groups[i= ].attr_group); + if (err) + goto err_remove_groups; + + cd01_attr_groups[i].tunable_attr->dev =3D &priv->wdev->dev; + } + return 0; + +err_remove_groups: + while (i--) + sysfs_remove_group(&priv->fw_attr_kset->kobj, cd01_attr_groups[i].attr_g= roup); + + kset_unregister(priv->fw_attr_kset); + +err_destroy_classdev: + device_unregister(priv->fw_attr_dev); + +err_free_ida: + ida_free(&lwmi_om_ida, priv->ida_id); + return err; +} + +/** + * lwmi_om_fw_attr_remove() - Unregister all capability data attribute gro= ups + * @priv: the lenovo-wmi-other driver data. + */ +static void lwmi_om_fw_attr_remove(struct lwmi_om_priv *priv) +{ + for (unsigned int i =3D 0; i < ARRAY_SIZE(cd01_attr_groups) - 1; i++) + sysfs_remove_group(&priv->fw_attr_kset->kobj, cd01_attr_groups[i].attr_g= roup); + + kset_unregister(priv->fw_attr_kset); + device_unregister(priv->fw_attr_dev); +} + +/** + * lwmi_om_master_bind() - Bind all components of the other mode driver + * @dev: The lenovo-wmi-other driver basic device. + * + * Call component_bind_all to bind the lenovo-wmi-capdata01 driver to the + * lenovo-wmi-other master driver. On success, assign the capability data = 01 + * list pointer to the driver data struct for later access. This pointer + * is only valid while the capdata01 interface exists. Finally, register a= ll + * firmware attribute groups. + * + * Return: 0 on success, or an error. + */ +static int lwmi_om_master_bind(struct device *dev) +{ + struct lwmi_om_priv *priv =3D dev_get_drvdata(dev); + struct cd01_list *tmp_list; + int ret; + + ret =3D component_bind_all(dev, &tmp_list); + if (ret) + return ret; + + priv->cd01_list =3D tmp_list; + + if (!priv->cd01_list) + return -ENODEV; + + return lwmi_om_fw_attr_add(priv); +} + +/** + * lwmi_om_master_unbind() - Unbind all components of the other mode driver + * @dev: The lenovo-wmi-other driver basic device + * + * Unregister all capability data attribute groups. Then call + * component_unbind_all to unbind the lenovo-wmi-capdata01 driver from the + * lenovo-wmi-other master driver. Finally, free the IDA for this device. + */ +static void lwmi_om_master_unbind(struct device *dev) +{ + struct lwmi_om_priv *priv =3D dev_get_drvdata(dev); + + lwmi_om_fw_attr_remove(priv); + component_unbind_all(dev, NULL); +} + +static const struct component_master_ops lwmi_om_master_ops =3D { + .bind =3D lwmi_om_master_bind, + .unbind =3D lwmi_om_master_unbind, +}; + +static int lwmi_other_probe(struct wmi_device *wdev, const void *context) +{ + struct component_match *master_match =3D NULL; + struct lwmi_om_priv *priv; + + priv =3D devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->wdev =3D wdev; + dev_set_drvdata(&wdev->dev, priv); + + component_match_add(&wdev->dev, &master_match, lwmi_cd01_match, NULL); + if (IS_ERR(master_match)) + return PTR_ERR(master_match); + + return component_master_add_with_match(&wdev->dev, &lwmi_om_master_ops, + master_match); +} + +static void lwmi_other_remove(struct wmi_device *wdev) +{ + struct lwmi_om_priv *priv =3D dev_get_drvdata(&wdev->dev); + + component_master_del(&wdev->dev, &lwmi_om_master_ops); + ida_free(&lwmi_om_ida, priv->ida_id); +} + +static const struct wmi_device_id lwmi_other_id_table[] =3D { + { LENOVO_OTHER_MODE_GUID, NULL }, + {} +}; + +static struct wmi_driver lwmi_other_driver =3D { + .driver =3D { + .name =3D "lenovo_wmi_other", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, + }, + .id_table =3D lwmi_other_id_table, + .probe =3D lwmi_other_probe, + .remove =3D lwmi_other_remove, + .no_singleton =3D true, +}; + +module_wmi_driver(lwmi_other_driver); + +MODULE_IMPORT_NS("LENOVO_WMI_CD01"); +MODULE_IMPORT_NS("LENOVO_WMI_HELPERS"); +MODULE_DEVICE_TABLE(wmi, lwmi_other_id_table); +MODULE_AUTHOR("Derek J. Clark "); +MODULE_DESCRIPTION("Lenovo Other Mode WMI Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/platform/x86/lenovo-wmi-other.h b/drivers/platform/x86= /lenovo-wmi-other.h new file mode 100644 index 000000000000..49bc3521e184 --- /dev/null +++ b/drivers/platform/x86/lenovo-wmi-other.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright(C) 2025 Derek J. Clark */ + +#ifndef _LENOVO_WMI_OTHER_H_ +#define _LENOVO_WMI_OTHER_H_ + +struct device; +struct notifier_block; + +int lwmi_om_register_notifier(struct notifier_block *nb); +int lwmi_om_unregister_notifier(struct notifier_block *nb); +int devm_lwmi_om_register_notifier(struct device *dev, + struct notifier_block *nb); + +#endif /* !_LENOVO_WMI_OTHER_H_ */ --=20 2.49.0