From nobody Fri Dec 19 16:02:02 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10749264F9E for ; Tue, 8 Apr 2025 07:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098129; cv=none; b=PO/pVfjV9Y8JvRJFKRX29Mw7FMqdBr0PAgO3MVDmlNaqoofcnMuDoP2xJEfCVmLv1Qo1hMpDuoiyaK0UxNUNUs9jNqemLlXW/WYiQaJveItdoRIYTokuwNEJfUDKMSq4yo8OJlddoOiwrAv5qGw3tmnqeYdTr7+jmyBa3E36P1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098129; c=relaxed/simple; bh=w9HdOzQ+MPAl+VXOwxJ+lRF040+F46AXVGIrMR12QAU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qR/B033HEw1NsFziUao2gDf+cqO+zMSvwDJ+v14kJN0dX2pkanWovzYuh3KifrhqsRC5JPNBIAfAgQhHsbm4kdK8c/qrlK7ZA8qN2qkHso73V4EI8x2Scsy4bvlxLeRycx+kSTVI8ycvURTiqDemkWV6n5amS2wJKQw4EnHP0mM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=f5qwqH4D; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="f5qwqH4D" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so35644715e9.1 for ; Tue, 08 Apr 2025 00:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744098125; x=1744702925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+E4+JrmdhxqWEi/lSbN287+Ko95rcwpd5gn3BuFGQ0o=; b=f5qwqH4DtVvSJ0eJvGpun1RuP6ujUqzZcC29/w86RTHbm/j+wAuwM+BSQjIBAWNHR1 8s3QTu32XqUnZEnHkQwsH9DgcCNLCsFHfoQdOpWd38ldTtEutKgnVJXnsRrNZe9v/J9a gI6Flcm5DhCvCHBSVHNBLu7/PT+SU4YsFdPWkdmc3uvlZBPS17w6q7IvCjikNSPxSyEZ yoErSEZfHH8dF4E1VV4ER9+2O6nI+f8OaHsq2/iWVHbVbcrjQDu4v1fgC9pC1gMG5TeU ca/10YXFzNnRCxFde5GYyuNIMjdreLH2JPnLQsOOpBPtpqnisu+RkjpgNYzV9ZlJt8nX OtRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744098125; x=1744702925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+E4+JrmdhxqWEi/lSbN287+Ko95rcwpd5gn3BuFGQ0o=; b=QnDQ9iVDAtGKyk+p8n40apTb8efGGlwY/8XlexoVu2JDYtp02IQ2DepAaNAAXJGGeh Woip7EvuNCz6ZueTZzVPccHU3jFXS9ozjxQ6+4/iAdisOoqVXsrtkC34+IhPPTnPnQAo 8NLG3kduaJaX0Be1M6b9mcuFw2kIfl+s4jc/HLHGDHVIEAfZv7pqvLcj4fSLsL+RBPRw sYyqyTT2RqUS6zovzLEsa5/dXgyrdHPcMyNDbVas+1dlFbqLxv22DCXohCM85OeU3RZc jQJ3+qJ615LNwkK/eOuGe266Ku81iAHY1epJZKmo9NwYYDweBx0SYOMa6DQRuc6RXEqH zO3w== X-Gm-Message-State: AOJu0YyUYYEw/zGyraVmFVOohcovemSbLWojdBIxxvRGRc9uOYnsH6OW bm+qFeIU5XYGBlXK0cmIvBFAlDIPaTSHTx0mTlwBu1O118oHgPwK8bShGBjwo14= X-Gm-Gg: ASbGnctXJ5C2SRRozv2tfaWoO/tpf5WlXxSgiHlPXhOGmjztrJUwvwA9LD3Dkk7p5jA naruXeymrOneWALaVZR1ETsbpsOsFDMP9JNhyziF7crRHBXUbUl4OEOFILnJGblQTPndMvK7WfW u1SVM6U3wROdcTSqmdlrEA+ZCNhwN0V4Ro40Azj3B/lnjjBCvAEX9P77DXwJi6HIrRpySPa4R3d 7k45TkoEw8ysPJeRTYWE5sTwIXcLlJ7163tVQqdk4OneSecOkNAb1jw2U7mymG34tnvFvOOkYyb wHbm4ihFdhRkPu9LXjXay5OP3eWQZhtJOpJVtAnynpZWRb+k X-Google-Smtp-Source: AGHT+IEgYUJEVuD47zg99gzM4mhFe0o7lX2Qif0XxVRVrvKWgac3NPWEP6sjqY2Y/veqsO5+qA2ypw== X-Received: by 2002:a05:600c:698c:b0:43c:eec7:eabb with SMTP id 5b1f17b1804b1-43ed0bc790dmr159298255e9.8.1744098125299; Tue, 08 Apr 2025 00:42:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3009644dsm13876928f8f.6.2025.04.08.00.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:42:04 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:42:01 +0200 Subject: [PATCH 2/2] serial: sc16is7xx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-tty-v1-2-fb49444827d4@linaro.org> References: <20250408-gpiochip-set-rv-tty-v1-0-fb49444827d4@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-tty-v1-0-fb49444827d4@linaro.org> To: Greg Kroah-Hartman , Jiri Slaby , Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1572; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=hQMZZhr8YRzEKYPpfo+vbJ73LYUTFXlK4aC8NxOLWao=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NNKZc8Vdaxaa/DH5AXXTlTVJB177D+PAdS5m FnTcJm7bh6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TTSgAKCRARpy6gFHHX cmvBEAC8a8bQCk7ugVP/EShWabd3phdda13V642kXNozPtEmmQX73ubQFwOanHqNpH5KHS3Sv1C HggbLZM8UFI9OX9AExD+mafcuzs1giV+w54uswUMUKFA71fWGMdUQuKP7WHsDj0KeNc8ry3QQb9 IQNfaUV+V0iyvoJ0xb29Dak/jaU69jWMzqdj/XR7w3yxEL4FcZ2hhHVdVaRC0ls4paJ7OiVFJmY cTlCuXkyTdfn6oFR0VVnN7W8qRSD9Elejz7ByjIbmg8xRJFfcnEFAU2BD70d8NeKDsuXoBfy5yF uuCT7ABi0QOArFVwtKbXczovOrigULbqhJZC326+G0IYddsp3MdBcCVinZynfvLoBZSqhLqXoRC w2Z3s0PW8jlr9661KvtNswG0xm/O4rS75vUihyAn6EehmWb9/SnP9LV5W75TZ5xaXZUjCC11g+M qgQXbekLAVUSakRmj7PToxh0f4qsE3pkBk52UzhSrWy5q+zKAC1pW1TVQdqgzQx8tW4FUecG9iF igWSd2j5REtSlwHiLp9K8mL8XAgJloIylS+JN3MJNbl4wTvv6l3L2RV6CjmqoWpFV3SgbqQs/K2 PeFa9CnsSBUqS2Az4ybSQDh0JhBgROU7o3tYcCw78S8evp/79pDgDwU79XZjS5FUDoWpbZIm64E mFsC6GdT5wM+33Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/tty/serial/sc16is7xx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 560f45ed19ae..5ea8aadb6e69 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1333,13 +1333,16 @@ static int sc16is7xx_gpio_get(struct gpio_chip *chi= p, unsigned offset) return !!(val & BIT(offset)); } =20 -static void sc16is7xx_gpio_set(struct gpio_chip *chip, unsigned offset, in= t val) +static int sc16is7xx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int val) { struct sc16is7xx_port *s =3D gpiochip_get_data(chip); struct uart_port *port =3D &s->p[0].port; =20 sc16is7xx_port_update(port, SC16IS7XX_IOSTATE_REG, BIT(offset), val ? BIT(offset) : 0); + + return 0; } =20 static int sc16is7xx_gpio_direction_input(struct gpio_chip *chip, @@ -1422,7 +1425,7 @@ static int sc16is7xx_setup_gpio_chip(struct sc16is7xx= _port *s) s->gpio.direction_input =3D sc16is7xx_gpio_direction_input; s->gpio.get =3D sc16is7xx_gpio_get; s->gpio.direction_output =3D sc16is7xx_gpio_direction_output; - s->gpio.set =3D sc16is7xx_gpio_set; + s->gpio.set_rv =3D sc16is7xx_gpio_set; s->gpio.base =3D -1; s->gpio.ngpio =3D s->devtype->nr_gpio; s->gpio.can_sleep =3D 1; --=20 2.45.2