From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 408D5263F2B for ; Tue, 8 Apr 2025 07:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097910; cv=none; b=sJssouGLndQAa6Uidjv3fE4U9l7nM280TJBQoeE5syyQSX0RMoQ/mTLxi7r/qH71F4i3QMS9Pc0hnxU7to3BgFTLcDvHgWgsFhMrlx4nUfQCGmv977PMNHclPqr4jTiJVE3c+Gg2YL/VGASgWR7it5id+P4jJU/LSYE8T0RGq3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097910; c=relaxed/simple; bh=H1/r13cT2Qzqk1U86sWdRYzAebCzT/guHQtTx86LWdU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qqQHavUKPBVQ6moq3gA19a3TKsK5Ljr+qoFI9SwghiNdS0BT11dHnPOmbI/VeEGkZsZbkUB2HTZpqKfFQlu8PD1MsAFxCkpBwu12VNqpIN4Bs/cw38dRc91UPb5DrpaR9y7NaZfIBoi5En/rw77NapG2pfdCvJQ81NgDnZ/2A50= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ylP8jOKj; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ylP8jOKj" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-391342fc1f6so4575244f8f.1 for ; Tue, 08 Apr 2025 00:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097906; x=1744702706; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dOnP59hUnqLwlou/8ixKvgPYKb1YxP7pgKnSRZqR8uc=; b=ylP8jOKj7WUDvXH8qBtaGThA4HArqUj9VAd0pNZoW8PpuTBRFHY+FRzvML/sn8sNQZ 80qb4wEov3kmjvJfPYsaA2wgfjX0y0cXva96BfIlDLuxL1NAD7Zt4swM2zIU2OQRJjFs 9UV9QwWUWlCuqUpBcucSGl94NPBvMDXo24LE0BAi8K85P6caGAR1GP6ClTIzla/tfekt rMOFjDrnA6BQ0VLm5tGX9kPC35f0Un/TUyeaaoZ5MCMbWd9/yjMD5UFXX1AXaHOcdf14 mxZAMn+8rrasAu9nDaoIk1vtpjcTlzzc8xzjzwaltWxaUzfYbmxEztaanM5MKFGX/5wW ZStQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097906; x=1744702706; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dOnP59hUnqLwlou/8ixKvgPYKb1YxP7pgKnSRZqR8uc=; b=Aex6rUwQfL8rOoydw9QCNjtCW3QL/1z8q/sPNggnECC+yUWJpHnttCn6wwmikH0PK/ PknvaEmtB+WxpS74cYqRkDG4DCYfjL4iYPN3udSVO8RsPYceMFzxdlX/OHpVH6cTW24o c+LafeC8/hHd2ppCQrKo8MNm4IYHMfu5VEgJnw+XD4sFGdFIfH4HY0v1nx8ScxTHNbsV uABOIWqaC/3F5zrxS+iSxDWK1gw08yfyyiLy1OqPtqgtcMLDS+TBRqZ/dda62w5/HT2O mNRvmuoGO4fzTwklCueVxZsv56CV/xO8ASzB0MCt/IVEaoPE9ko8lmhJzIOiG6qw4qZJ acnA== X-Forwarded-Encrypted: i=1; AJvYcCVOvZKGitoKZVWuO7R4SF5oALkKUJOZ4psd9hwtz3megkNRS0R5ahoj1ziJm3nHvj1KM3glLVgCsaBNRvs=@vger.kernel.org X-Gm-Message-State: AOJu0YyGXxEkizEqFNoZiXbSj5PBcd3vsb9PYeD7g56ushuHoXtPVVss 5O/CTlWyqrSIy5pFOLadbhyn8lJm7nfmdLFMOdcnRuuOaUgfn14SfjwmeQLG87U= X-Gm-Gg: ASbGncvNvlmeGaPHbvi/xkO0t1+Dtqm89l1cPuxV+ZZvf6ZxKHf0GDtCfBrOfqvSDPw PNNB2ZeSUR0belZ3T8x/7GawwcP8jd5feeH+6EjrOX7X+2BqnHYsjHxwCx8gIzHSx8k8CeFp95I niA372+Q8DrOVwy9m2K5+QsNR1RV8wwPvSLOYMGoi6mjheTSu96GC7KqkZeV+hqYiLmiOi2bjx0 niFwsazLfDMzvjDnBDcBkX6Z3btWoORPXf8KJyMuxd2vfnNoxMlfliBZs+2DobzydSdCO3CVPu3 eN2aGIeqQHqFIzXGLeaWHkFYyeCMvBu7dBpmlg== X-Google-Smtp-Source: AGHT+IG7DQDDtJlKr0AX5fXm/0LslLDepU2Ul+w64BukKBUcPoEM95MldvgUmHprJ30qamN+W88wuw== X-Received: by 2002:a05:6000:1844:b0:39b:f12c:385e with SMTP id ffacd0b85a97d-39d0de17bcfmr13214832f8f.20.1744097906542; Tue, 08 Apr 2025 00:38:26 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:26 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:19 +0200 Subject: [PATCH 01/12] ASoC: soc-ac97: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-1-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2057; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=+s84gxi24INum35RXpjv/Lah+LzIeKYxE5tndjwwncg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJtls2wjcS0sj2b+6sSYrrAjLpD1ASs4aSuL YELPn9i8CqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbQAKCRARpy6gFHHX cicrD/4p7G7svsv5v51KuFQmsokFKj2MMyKpLwVKzvPKUR3jJgiiG5jmmC73rdn6kP3B4c3WeX8 ZZgxYEdYkQGY7ctLuTX72ERBUTwGVCuSmrWMJU9qTniEUBObxetXWgGXXFYjCm0VSGF7EV/VPVo dYTGMASWkugoa9q3BCaSobmbCA5T7lEZ0+tU4lNvlBzOFNLaQ+qw4aW7WftW90+h1LxvJna5thl OGyz4C4UdF7og62Qec1SwVv6ciKTNBUf6ZZQJKMhpSgGvgfrHT+qZhfbMaan2H8gPpWsxbSLRFh oVRAz5kmspkuf9VaUNHQ65dI9SR0+9BCgj8fguGQmLhuuoxo/NwV/aU5Vw2XYXYy9nPntrkF2FN oGOgbL+ENh7l4qfjtv7lRX1VEjSqjelGNeLP3SA1c03l09xi2og3veYHlmoFpqyTfK2Aq6rHHuf 04XAWRIWBw/l/+ueNt35bQPmooh0zSXKg0YEaZI/2T1GbjcQ9GJK3RAHrEPqYeeA1xirxknPXpj Kca75P9W/+M1okpl+lgCcCn1qR4wYRXIIz287CYg2FZYX/P5GgBLdqzwWMoM1ddKapjdB/lRnjz 7v0SNq1VDuWhoGZOSA9hTEAwyaFcOmQA1nivp1128qUknVGOWDZaMmA3Z++BWYlg8nwsAE/Jfqd 2LTFtlJV7s0CGsw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/soc-ac97.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index 079e4ff5a14e..29790807d785 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -87,8 +87,8 @@ static int snd_soc_ac97_gpio_get(struct gpio_chip *chip, = unsigned int offset) return !!(ret & (1 << offset)); } =20 -static void snd_soc_ac97_gpio_set(struct gpio_chip *chip, unsigned int off= set, - int value) +static int snd_soc_ac97_gpio_set(struct gpio_chip *chip, unsigned int offs= et, + int value) { struct snd_ac97_gpio_priv *gpio_priv =3D gpiochip_get_data(chip); struct snd_soc_component *component =3D gpio_to_component(chip); @@ -98,15 +98,22 @@ static void snd_soc_ac97_gpio_set(struct gpio_chip *chi= p, unsigned int offset, snd_soc_component_write(component, AC97_GPIO_STATUS, gpio_priv->gpios_set); dev_dbg(component->dev, "set gpio %d to %d\n", offset, !!value); + + return 0; } =20 static int snd_soc_ac97_gpio_direction_out(struct gpio_chip *chip, unsigned offset, int value) { struct snd_soc_component *component =3D gpio_to_component(chip); + int ret; =20 dev_dbg(component->dev, "set gpio %d to output\n", offset); - snd_soc_ac97_gpio_set(chip, offset, value); + + ret =3D snd_soc_ac97_gpio_set(chip, offset, value); + if (ret) + return ret; + return snd_soc_component_update_bits(component, AC97_GPIO_CFG, 1 << offset, 0); } @@ -118,7 +125,7 @@ static const struct gpio_chip snd_soc_ac97_gpio_chip = =3D { .direction_input =3D snd_soc_ac97_gpio_direction_in, .get =3D snd_soc_ac97_gpio_get, .direction_output =3D snd_soc_ac97_gpio_direction_out, - .set =3D snd_soc_ac97_gpio_set, + .set_rv =3D snd_soc_ac97_gpio_set, .can_sleep =3D 1, }; =20 --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF55263F3B for ; Tue, 8 Apr 2025 07:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097911; cv=none; b=HEW/h+6W30jMJLkdm+Iv25LGGUFp55PZu4kDQw25GcH3m8wgVHBPf/In0aA5ClNZodCtxN1T1YRg6V/Q0xV7haHVJqqeJ+hsZq6jWsnPxzZsiLQa6e1lbtW2+HnPXhmJ7RaJLQrTJQCy0F/WR5EPHdRbwGZXRLTmMibfzvVvr9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097911; c=relaxed/simple; bh=odvVZUrS3dbzVw9lDvpqQQ/85WCUEdMbQVAmeGMYZGc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UFXTuAQCI8cU8jtljQkCFQrTsNgcNW9UEE2wrC1HC2c6IGuInzJwWvm4blNbWbLu0V5LJ7MVUI8ia4STfqrfTj4H0JZgu+kK5M7pSb27RG0e9oNKemGTrxeVwscdGC0ETIflD2VlopXOL2XcspTuFqxX/wSY6v4/wXegLuo9nm4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=cS8c49fc; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="cS8c49fc" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-38f2f391864so2837961f8f.3 for ; Tue, 08 Apr 2025 00:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097907; x=1744702707; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vM8Qea3FMtrgDWi17clkzSyShy7K/VLobQ3OM+BTpzw=; b=cS8c49fcSq74m4mT1naL6gWvEmKjSeAr7iW2/xt5Nk/3Lj30pEIpnZW3iAnFq2caxV ecdhc0IuzAgjU4zoWZvdre7KT67w4aqAlVl4NAcVn/tjQ/jYaClaBbRa4Qd83AMaMgYQ W4QmfWMhbblZ37x2z030M80yUu1ue3qYQEf5wHpL/RAtWC4DhQ56KK5xeL0lqcpf2pGo 57ab9YayAFdA55lIcifcJrLl03yQqwK0UQ7s8wOJEJeUSs6NqgVhyVC3f/VP269W0yE0 plWxOUxkbncvsFVS2IahiXM6KYc+lLbc+Nr8jTcgfWQifIU7axjttaH1R6N7zcIh+FNT E34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097907; x=1744702707; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vM8Qea3FMtrgDWi17clkzSyShy7K/VLobQ3OM+BTpzw=; b=ha9d8gPnjrrUQu52l+CsmktkfzoGtjNE9saomt/n+x6YcJcgwD99xuGL/vzvCCDm8U BkYk+Q90TL1pIyA7RBReAzz/sLFXTTEHcgOyTO6J3kchV8o6fqMO0ToVH7qMy4XEt3+F oL5GrJvx7IuEXp1e4hyiRn0ZrJXH2nHbLfCjh90+4dzu2pwxQtqjrkBMjZxavSZlu7dZ PsqWQtpA7jjohVGbXjokAY03vNo+ZQ2tjLs3bRfl5xLeWdiJnL2GKCmGoStX/YH6de91 4PvdLOCaJnx9Io3sV3ONPHnxjATPtqGc7xosYcRFaufOuRchrAlCBxhkSYYHlNrRT9z1 nXSg== X-Forwarded-Encrypted: i=1; AJvYcCUi/bildfhwrHt2zOjNmTc07Laaemb7MciCwoUlVcphXEeyfT3ERPgniKYVS7mRq0Ep5HoJ/WsVgJGnZsI=@vger.kernel.org X-Gm-Message-State: AOJu0YxvbA5MebnVeRz1qpFOAH6wx1G9bhOVg2ajLK/atW36bT1Zcymh 6iIw0UOWjBhB4+wgabTEIxYtBAMLtI79xlB0ux8+9Nr7ILYp65TxesSy2mIFQzw= X-Gm-Gg: ASbGnct3WI/y2nLeyVmmz/TvmNVNFocqw0nkY9HrHFR7dfAmbZZb6dIkoIJtCBjLq+h vK1X2BBfAENG9AxbK2zXsxg5GBmjR1uRTqU62b52l5Eigw1wNiFbFh9NfRtgmmyv/hDORoN5GVW wKWYgai+n0AwRkZlBXkfsfsCCZdkBurEIEuTvOMO5+BW+AnE5ySuMziQDeH92KIZtaJNrs8E/su LZFl3TNLfLNJ49p/wW7jYy2AESR+t+yaLZwM2RrfX/xPBv7hiojQPemsymqInR+wN6pWtgXC0GF 2iOTpoPhvIox6AS8hMW5X5tm6tbhzHbU8/yXBHvcfRtCuVqN X-Google-Smtp-Source: AGHT+IHG4Z/ZuFphLMM4BLXvIJni9vAF4RZfbvwi7RnlWhP+eHtEE8msr2+s9dSB8JIiVDJomM+vzA== X-Received: by 2002:a05:6000:2512:b0:391:253b:405d with SMTP id ffacd0b85a97d-39d0de62927mr12155263f8f.41.1744097907542; Tue, 08 Apr 2025 00:38:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:27 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:20 +0200 Subject: [PATCH 02/12] ASoC: ti: davinci-mcasp:: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-2-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1670; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=4r1nNQSWxtmth2sTRGpaUPwZfF0gETP2bZXWejf1QY4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJtxz6edE9QBclqAj6Xs4+ohVR6fblexPUix T1DRmXYfQCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbQAKCRARpy6gFHHX cn5dEACtbJfAMR6blmJ5wZcZOFlii3iInTRZzxbZjFSWOCktnBrvaRB+jeqQ3IZxcM4fzKhQHs6 N3KJTejg3lD5nx5JVxxA9FRJDkXlDOzpJa/5/eobsWgmQOtYyD2edbPb//P1qw5f0F2G6k+7cET CQ8DZFfEvRtULbVjWYkufogdf6u+2oPkLlsicSTyuH5zouYuKanlMmQXwaZntrm4QgRhe7m8q7b adhDH5smg3VjX3GqZBA4BsfI0fLWJHpp8gtVn9ck85B/l4hXhaoxcAv4EaOZiDSamljQOk6+3l7 D8m7hQTMuB2DmVTypZe4f6hptW+oiIqnrhcO/8dAZZJFBgCYnV11Wdbx9tZjiAvT2yvShU9H2ae GvMZTUu8277850aaeuD6Ig438+uY3Z1F7TtVBBRs/gurlaEcl+hHP9/OfOWVeKf0yIlXFq4H0FK jUCe2rYGiEzQRrJUHgAAj3tY9t0Jge2Yev0Lv9LebKQVxNzB1xVdM418dKMTQOh7xe4meV9YMIU asJa6U6nBxsZyJs4ZZOS7TWzLJTUssSXguWW7ITmLEAwavxzDfV2OlMU04xULphX1f6QaOibmjt +kkXlVFP/GA+1mfY89eommtJmf2iBx/O7Z9j/vKwN9LfxJS9v/hK57pPhqXVat/pH6Cg/ATvSJX RlU2bZozo648+fw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/ti/davinci-mcasp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c index a0b8cca31cba..caf1887cc9d1 100644 --- a/sound/soc/ti/davinci-mcasp.c +++ b/sound/soc/ti/davinci-mcasp.c @@ -2157,8 +2157,8 @@ static int davinci_mcasp_gpio_direction_out(struct gp= io_chip *chip, return 0; } =20 -static void davinci_mcasp_gpio_set(struct gpio_chip *chip, unsigned offset, - int value) +static int davinci_mcasp_gpio_set(struct gpio_chip *chip, unsigned int off= set, + int value) { struct davinci_mcasp *mcasp =3D gpiochip_get_data(chip); =20 @@ -2166,6 +2166,8 @@ static void davinci_mcasp_gpio_set(struct gpio_chip *= chip, unsigned offset, mcasp_set_bits(mcasp, DAVINCI_MCASP_PDOUT_REG, BIT(offset)); else mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDOUT_REG, BIT(offset)); + + return 0; } =20 static int davinci_mcasp_gpio_direction_in(struct gpio_chip *chip, @@ -2216,7 +2218,7 @@ static const struct gpio_chip davinci_mcasp_template_= chip =3D { .request =3D davinci_mcasp_gpio_request, .free =3D davinci_mcasp_gpio_free, .direction_output =3D davinci_mcasp_gpio_direction_out, - .set =3D davinci_mcasp_gpio_set, + .set_rv =3D davinci_mcasp_gpio_set, .direction_input =3D davinci_mcasp_gpio_direction_in, .get =3D davinci_mcasp_gpio_get, .get_direction =3D davinci_mcasp_gpio_get_direction, --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 791772641C0 for ; Tue, 8 Apr 2025 07:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097912; cv=none; b=I8hYwK6q3GNFoxOMksyUjsQT481eivHg1PwKVKIRUN/sfmxWbU/Ej+t35kS6wU7O3z0sYZEcLhK9sw9+S3chRRLUJygS22BQbzp+QLKPz0fp53fjDMgnq9W0sOBVCnya2GgqR6HRK6w5BREE0AjY+JM5Z6u0+2oX8c0adYmt23k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097912; c=relaxed/simple; bh=1IUDawPuMnzL1syBH36aZZ6k9aIzZFFvZJrc5M9W+h0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CXT3UamP28+g6WFbE4QKLVwZzqHal6inpWn1PHsid41aESPvjKr0AJ4CpH+PdS5EbtVEnld2ChaOSCTdy1fFClVgXScoz//ySyQxQnjpS2ujLvmmzmg3Kr55QaXGxK0RfimyyvBPmhhVs1nok3STYPJUH9qi7nK9wDG+dBhIroQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=MOhg8jqE; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="MOhg8jqE" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39c14016868so4600765f8f.1 for ; Tue, 08 Apr 2025 00:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097909; x=1744702709; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/qLbnSxZuvxxqgDY8JPrap5c14Fhz4xBCnHroQ52eE8=; b=MOhg8jqEjcQpPV6BaiKAsgGYgaOkkNOP2X1EC6trdGOqOP0dM9DHTYCAjyIufrvGgk idFSLSLXZqvX3CkI8LosZLf+B6345iZSF9BwYLs36LFcG48+Mwo4HT7wwaOKz7iEr/Tt O89Bz3NAVP2dOKHFcVRZjm8OS89Z8OmNvZDqQUQyg6FsJoh5JJfgVw73z6uysXXUO6hV JCyPlO6LgfuwQVqV7QPlst+nrtN7AAjlhBg5Y//WZXDc/KewzqPb61G7bBuvOkJQKdC2 0hDkku5TNsn2UisDSn7HPIU+iFuqmbIpPfFdkZgMFznYChoEw/Xn1bGXvJwzZN4Y9CQ1 4oXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097909; x=1744702709; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/qLbnSxZuvxxqgDY8JPrap5c14Fhz4xBCnHroQ52eE8=; b=KwXRmAig2C69IlyGfYwKDYNTBKxOXV1d2cOsqSNDtiLUUGRQ395cuEiBTfm/UcbPD2 +HEpK8w4XluRlEz2dWlejxTZGlStoU1pAZKj3O1m72DHdo3zfmsyGPamYvjOwHdDpQVu Bs/br9RXk4YPdLpnNvJ1tuZGep/X3evvjOKOGSoIfe2pW+zo9+aNAHtIFYRlyArxAPRh I8RkC6oDUIz/HK5Ui9LCoRqppt2c8PdQnjENebMYnYswRNSdju+u6PP1jPP87oZnF111 zePH5ALGlWau7DkmmTTAVagCnCgBTGjTOdFFdtE1CPdrkJb9pWIlM7FnH18ZAlP73hFF OdMg== X-Forwarded-Encrypted: i=1; AJvYcCWllxxTG2jBwFaSWH32nfN/5isaM3ZJR+3A5yFmdnQ3yhijiOqhSj3sBB1RaoiPVRNuM+29WiSG7wWBz6w=@vger.kernel.org X-Gm-Message-State: AOJu0YwLil7oy3X9pxahDeS6AjlrGR4xPp4capzZPT77Msz+TxYgC3XX ZfxOeJ0xpf1nfRRP5lux/TumvAbQWBWZUIO8nrcAlu4wMqe+rpt+UrRW0qVoRKE= X-Gm-Gg: ASbGncuP6V/epIyD8U79oRpOKLwYoTki2kLd1Ya/HT7n2XXU0RcijrR1n3Wiy4xnqNa VYLLxTQQYCDsOmRIWD1TfOcwU/OpHZeEfgje9tZFyt6rpIEoqLIK8/GHMyfgFXO4MRuQ5rXX2yX Vbf/CYo5c1Oh17Y5TSN9SG57ncQknpg4KYoisGuq2osFjWwZeWTVrwt9sfkdYUH6ZZh2F9JhjPO FGfc3mQKpeewe2IDybeSFcinEmlc8VNTC1jiUwMpGYc1SMGfZ/DcNU/52IFUDgvvjxBRhZ1QnjE ivABKZ7I1Aub+vxvFFD/5qwjDon6KQUvdfb60g== X-Google-Smtp-Source: AGHT+IHvYGfZ7yR8oB9kGjMs/YRCRLgRd8dQnkUz0sLZd+LtxfPulakxOzObaL6yiBQuQ+UU4Yt92g== X-Received: by 2002:a5d:5f83:0:b0:390:ee01:68fa with SMTP id ffacd0b85a97d-39d0de2564cmr13657198f8f.24.1744097908651; Tue, 08 Apr 2025 00:38:28 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:28 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:21 +0200 Subject: [PATCH 03/12] ASoC: codecs: wm8962: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-3-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1574; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=0wuGbBgNgomJF8AO9tExLloUdiNGvc37irSst6MvvQg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJuYHJbAn0GFK6r9Phd4nSelz/JqRjF/cNIt 9N6Zr862BmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbgAKCRARpy6gFHHX cucsD/0YLwi1Yh3e4x+YoiY7EbbSTHrO2YjLooW+nxXbIpy0FsF78TIVsyApbTfSTVUJwWqc+IY qpVzaaJ6IvAnFgcQYh1jhsEvaypV4KbuVLmDMA/dCx+h5KORRTFitTI8E/RdtRHU7KoSRcbrRLU uTFkwsamxnrd2bUU4LhNpsD5pqNRKsWSGbGwYKBlniTUApUl1fVW8ud/Jzji8sNBP6YXQq1/4kl uwnB6BOO2HmUGFKItvFHT9d8Y1sxzHFr0XAb8ywWuSedircQO2/Gd2B3n/L/045cL2I86JNxDbk 2aUt3egi0UQFkpMt0FYJlptnT6Ym184FSm3uEYBPSroON6khC38Vgw1FOw4DxhdN/Hu/NLTJ5Y5 pJnKy2KnEGlqzN/fsQRM3yZGcQe/SIu7Kgn+XQifR4jzU+QcNcy5kRIikigbSMenJcQtgKCMGoI PRKeXNUaFgnvG6iKYu0FdVoJfJQDfEchGz1vyRG1yHcNGVtPvHaQLuig79dLq5iSQzs/0Z+mySJ QjPKB2KRBFF4KVYZ36wK3ycwLLDwH+Qnvh6W6bfrE33fi59dFnEw5fgQZ2GABHHBEHuLG/8Ge5Y KJ4pSxc7IzpYr6yYgbrBWl1FwStcl5ofwY0TGQdl4zC1d2IW9Y4PFbdBtQXn9lTKyy9B8JZo/HM 0ExCgf8kRRRqdxw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/codecs/wm8962.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index 68f746626c33..d69aa8b15629 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -3407,13 +3407,16 @@ static int wm8962_gpio_request(struct gpio_chip *ch= ip, unsigned offset) return 0; } =20 -static void wm8962_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm8962_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm8962_priv *wm8962 =3D gpiochip_get_data(chip); struct snd_soc_component *component =3D wm8962->component; =20 - snd_soc_component_update_bits(component, WM8962_GPIO_BASE + offset, - WM8962_GP2_LVL, !!value << WM8962_GP2_LVL_SHIFT); + return snd_soc_component_update_bits(component, + WM8962_GPIO_BASE + offset, + WM8962_GP2_LVL, + !!value << WM8962_GP2_LVL_SHIFT); } =20 static int wm8962_gpio_direction_out(struct gpio_chip *chip, @@ -3439,7 +3442,7 @@ static const struct gpio_chip wm8962_template_chip = =3D { .owner =3D THIS_MODULE, .request =3D wm8962_gpio_request, .direction_output =3D wm8962_gpio_direction_out, - .set =3D wm8962_gpio_set, + .set_rv =3D wm8962_gpio_set, .can_sleep =3D 1, }; =20 --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA7B2641F4 for ; Tue, 8 Apr 2025 07:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097913; cv=none; b=d+eO6fvEw0GxKVgCPcPl7J/7EZnOFP1+Yjp9QI2V0H54BhW9521yUreyheHgmSGGFJUryRa1+4suHWTIkzK+9N13YKYnuwLNEvIKhU9s/XnLyYd/4A7ukIGGP1ofFKINVU9SjoBkXwQ80EaCWdO0bSXt52ap2qjrqtesLT9TqOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097913; c=relaxed/simple; bh=L5T41Ha3vwVgec+LKuywfKYPQFYp4488ZbqdSqHolQc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Cq31sykvuhRkkTsL4wkb9wDD0xOQvpBm0J+cYVqhnAKsgnL1PoIiUyzCSuKQPIb3ULjFnodFIUaZuiogu3g4scT7sesKVZHSE4C9rv5gIukIR1Z+W9cD/C0wIz4EWzcc+2IZI6kNi268E35psnCTIOHtpfuDrAxfbrYFdiwT1QA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=n9k4Zg8F; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="n9k4Zg8F" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-39bf44be22fso3464025f8f.0 for ; Tue, 08 Apr 2025 00:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097910; x=1744702710; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kfNXJpntX57p6p2HBzuwOXB3bKScNMDPqsKUXLptGlk=; b=n9k4Zg8Fzv9TYnpvkcRX5oZwtq5Gg4ZgfwQAQNr6Xh2uwyqAYzTIMObHXN8qCfbMnW XAZMAPleouJhR2ZrBo3yMcRJHvaHQEXqBuMiVRQ+yljhn7/1yh/zLDJKDOby+rtF4bJR y6RqJMHVOO9CSuZaPqgNn1RbS6y9qhnizMWfEU4nHNOHI/BtDGZuMyG/0StcD9ZRRKWo MmHxIjRusJe45Gj3AYeZjyRLOuOUWsD+4hnBXKJ1lvKNCYz42Zoc7GjSR2EzQ/lMLlpk di0/SPUoeUHnxA7ux4aoMVUBomYVx8brC6KfHgLoDNb5LJTbGMu6orM/GFv5X84i8NQR Zn4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097910; x=1744702710; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kfNXJpntX57p6p2HBzuwOXB3bKScNMDPqsKUXLptGlk=; b=czFpGH+PMiU/+yTzRJrO3iB09N0YzQQJIrFs151LB21gbJj93YNBmUz8yNVP3NwTtP 0UjURt5g66Xskd+DMz+QxLxLjAy3+cgrAyBPoaa4iFqlJXR4gP0q7EskNqtvsIAoPhu2 J6kJvbR6vaw4TreqBJGfzr8ZGMMK+RFMP38PKvOy5CFJsLWGBnRkIdNJz3nySBAWyb87 tEXwSgwkcj2bQgrMYXYv6/mWjP1/TjSOL2tcw8yO9Q7LbJ3jawUBjjLfglTksGsjAmJu +zGHrK0doJqbt9ujoYhZnWkKdiYpoZZolnNDTUQKq7wTf5A/Ic+xMBUmdxur14mDONmd jf5A== X-Forwarded-Encrypted: i=1; AJvYcCXfrjkIkaQq50LD/6uAj9XaVh66AuE7aa5MSodpB1fcIZJC/f7qH14IhLSnEr4jl16fnLnIhb7zSQi+8/o=@vger.kernel.org X-Gm-Message-State: AOJu0YyTMpTllZlmaqKe7FZVbQ4IurhxmL+kUPBe1mD03IByju8cDivY 1RCl4vkuIbcefNtJtPLJ92RAdPzWn5eiFXpsiv+ziHirn+h2c8JeLHBRecZJZN8= X-Gm-Gg: ASbGnct/Cu1VgAuM9IhUPqsOvR7ek4ghK2jXsffNj7SjsSf93XDFpYJRSRG3gn6z2YO 9AoQT+WB84ydmamDljYK4Ue3QD22tfEazr809qRUFmewS+eWPmDyQsj3QsozGLFH8J4JwUvbZwo mKpYUmxwawLsudNlkc2HYQs5uZWQ7GWyjYJ5b2PJCEIY1D6ekYaKyg4MEeHY8KIeOvI7q0oj01L 7PCjSZIxn0tFi2X2IKh3jhjsHHXJMUvFUvciqcpfLD2m4wT+RGgKi94/6Bmr1sQoiW9qRlFgJN+ GALxE0FGDK9zwr4tjoVi5+XNbJSQb1cmes37SAVDlkFUuS17 X-Google-Smtp-Source: AGHT+IGai8x6sYMmuQjTZlOAl2dV2nu2vKt8bzQLfSxIdLBY64Nk78lnf4JieYJi/KN4Md8XEpVpoQ== X-Received: by 2002:a05:6000:42c5:b0:39c:1258:2dc9 with SMTP id ffacd0b85a97d-39d6fd07bf6mr6383862f8f.58.1744097909723; Tue, 08 Apr 2025 00:38:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:29 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:22 +0200 Subject: [PATCH 04/12] ASoC: codecs: wm5100: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-4-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1536; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=eCAzJxR7BEmKW+OrHCqV/0gcI/0bn9PMYKCV9A4MflY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJuHFaP+AQBZcqqOWYXn8VtjZ7+6YS5jQ2Yv iSsM5UIbTKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbgAKCRARpy6gFHHX cgTPEADGyhEutaHz5HSjjOvub/MGRI7gGFYns34ZiHnExD9RqTS2SmEQGPewtRQFwJNhqTdeSAi S1IFub04yf5rbWpFBOMWY1qWi7I/mKy0SfiLVDn503ZVYP0CXdluH/CtCjuVhMq2lGvN3zWSJid Bq1rtg8FjHY6PP2EN1aPEMhUxPeWI0nGfDAVarK/pREI8d872aah8LCRD+z4kKOy877g7aU3lL7 Uh6pvQ4uCM0G/rC50TiN3SxT7lGkPLLR5S50MTzXqs5D7xh9TgT4QDilyP4qWkFcOlLPb0l7tWY Y7GQcn8TwJNCO9V4e8eeDtV0xT6MuA/FK9o6GWx/8kRwpqiLy1GbmV1BLAfbwqMGOk9/5RsZB39 LKyp7SGgJqXBqNP3zYIzxHnB2WxMYhqFDM+2BVz1UQ72h/Tq/jGhWhvr8LzKxdm/bMRVQGixRWH nbW6ePGGgPuHKs1ZPh2vbE5PqpwsG7tlAkdCrpsrN3WNevF3t6E6yZWng0oA/bZ2K+eb9c+daCN oeIjo9NkSsOBnYsYdSMp+nOf3kIKmcUtOqc97wpPJASRfrPZO8TC3fAbc8UjXW+JrcNzsDJ2iWz mEumGp0stghYdQc2IYVk/Pj1+apmtveSSjjDqUCi8l8e2qwZbXLyWNx2D+DkI7VicdvKjyeauzG rSJ+aCq0NBIq+OA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/codecs/wm5100.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index d9e5762324df..fb5ed4ba7f60 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2236,12 +2236,14 @@ static irqreturn_t wm5100_edge_irq(int irq, void *d= ata) } =20 #ifdef CONFIG_GPIOLIB -static void wm5100_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm5100_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm5100_priv *wm5100 =3D gpiochip_get_data(chip); =20 - regmap_update_bits(wm5100->regmap, WM5100_GPIO_CTRL_1 + offset, - WM5100_GP1_LVL, !!value << WM5100_GP1_LVL_SHIFT); + return regmap_update_bits(wm5100->regmap, WM5100_GPIO_CTRL_1 + offset, + WM5100_GP1_LVL, + !!value << WM5100_GP1_LVL_SHIFT); } =20 static int wm5100_gpio_direction_out(struct gpio_chip *chip, @@ -2288,7 +2290,7 @@ static const struct gpio_chip wm5100_template_chip = =3D { .label =3D "wm5100", .owner =3D THIS_MODULE, .direction_output =3D wm5100_gpio_direction_out, - .set =3D wm5100_gpio_set, + .set_rv =3D wm5100_gpio_set, .direction_input =3D wm5100_gpio_direction_in, .get =3D wm5100_gpio_get, .can_sleep =3D 1, --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8497026461C for ; Tue, 8 Apr 2025 07:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097914; cv=none; b=d1uDrX93uAkiSPHh+bnYR8Y0/GinShJKORncz0bwTcRJ5M2OiABo7HzHKDI1X6NOm1Lx0/Ga6BKn7Oh3r9Rnt/UQaeG0a6gB6n6+dioDtX+hQ13Oy2FGVbEVEPWP3Qcr+tq5iPIW9/L9mOKBqExIdAcf41ADrgPC42EuNLOgApU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097914; c=relaxed/simple; bh=gnxLULCAyuh9NQsbezqTT7XeAICs/jSdAV8dBui03AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ud2gWwR2w0EJLDVfJttKK2xY52ELiCLLhDVOT639yaJzLdbIIhuFqeFpdIF8s7blloByYPLsjaYmMquqJ7nHy9w0Lkd3ZyvN0dS5sGD1tdWgUktnUk5IWypEtQTCrKEgABC09PUJVERyXMgYhSU+Ovklvbt4hRRGayxLPNhlQL4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Zz8ItODr; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Zz8ItODr" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39c30d9085aso3037574f8f.1 for ; Tue, 08 Apr 2025 00:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097911; x=1744702711; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aDax3Ws05YZ8zmDA6rC1tfgqVxvQ1cnKk2mOaqzS1/I=; b=Zz8ItODr+iek7sistyaWm9uOHGLFGzwiCzZqY6h698pvEiBDAA69ZRpP+4SXCizoKg /C/TKZ3zMZRaSuENpRx1K55P0MXim1OLralrQYVtqwXruZdAoE+vzfEWAaJJq2Ux5pWY 1OGSznWL1t4ykOzYE7BA0GR3fbovH+jDJ6PJlc4q9quO5htqnyS5M6gZRZpD3jduci3n NQClzZhf+cbGyxWrGImXHddpv2kkE0o6iMcUQmjW7CYHQN21ne/RKSI4eeqi0clWPdk1 MQD/C7MOquBdTVQgRWT/Wq8FnClbEvpZrJrEMoTPrrKOAX4t/fv/U9AjtfWZGiD/JRrT xGUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097911; x=1744702711; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aDax3Ws05YZ8zmDA6rC1tfgqVxvQ1cnKk2mOaqzS1/I=; b=U9D0zPXw0Uvt4GVdlGAl/0GA7hgjsQ+1KwNwQv3bgf7wKcYzBykuqhiL+EEkAwQU70 Y8D8BEkgGC+pwHUiMMcDnKX9l8PFTMZS0644ozge895XeVNe7dPfco0KwqIbb94+SDQE U7oPC020Xfurv8Y6VoWb6kKlYbh58JfpC4Vs8MzcJWW3pUPRpKN9jdShgP5uP+E8iJqB J4V1Hvy0h4zNwiTEhBJ8T6jX1z5/ZdFt4A5FmtArP6LSsT8g5I5UAOzZ4pbczFQ7MT9N 11NgtwbP1PH4287QzNyBbsyBLr3vBfSGsYYwzCqZ3NBPbyZOCIWe/YP0AeUT40m2552e 94yg== X-Forwarded-Encrypted: i=1; AJvYcCVSmRDgZqRNAIK/KLHB5kk2JyjEmUL9H4KSus84FaDImaxTK5q3JULPtRkW5B6grc5WyiQaodfYLMR/d6s=@vger.kernel.org X-Gm-Message-State: AOJu0YxWfTwCd7vCdb+HBnlbxC4lJlAEUpSr0YcxlY5PtBmy4kOGFdfI bacLeSUmWaWOiFFmtNSzSLQirH6KrBezbOT/91wp5v47kNxjjbrB9cm25poUE5s= X-Gm-Gg: ASbGncuaKnMKd7TCILc7CDRByHF+yOViFOnoMrR1nisb1BocJ63SsHtkEJowqCCgje5 qEDxnp6aAqY7ZHKje8nGXPcLAxExDxbc67cJP+Za2JTj8o+PsxFXTyAzit1Ijm07tvZyP54zVmc W2KCbBQk7kZQvpW21T+iLmWoM0ia6r4IBhBCUBCVW3XiGYOZdTpXY8H/OsJulrChRH58GPU1vDz KdGKamWdvb0G1kEHGxAUfEDLveXyMUexJThWjUOQuQHaEZjP0WGFmbyFgwYPnPCWi0HwYf4DmDN 2bowRJvD7DHjq6wa+whOWFwqyTbIP/urJpO47A== X-Google-Smtp-Source: AGHT+IEWN9bYde/xMBfOkHQNa6HTYyFDHb28eVaUUMXpnBBVvhESil1QEAAwJj+1rOSrQNH6YQ+0zg== X-Received: by 2002:a05:6000:1867:b0:39c:2688:6edd with SMTP id ffacd0b85a97d-39cb3595c48mr12927726f8f.15.1744097910752; Tue, 08 Apr 2025 00:38:30 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:30 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:23 +0200 Subject: [PATCH 05/12] ASoC: codecs: rt5677: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-5-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1523; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zqMzTD4a9F77NzTYV5GJminLBgRVL2t9zDj4XQHtrdg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJuPhUyJQBxaca+q9M4yYolMhou4yTpNTZ4z bBZeOmVg++JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbgAKCRARpy6gFHHX cjTPEAC1m5Nhh2RvAgn2Pdst2uBxBgbujINKZhSTjhjkRq2GEmSbijkEPVPhf3lTtSgh831MbWY /u0gfFdKiH205VrjCt/8wzP2IL4IMpSaWYwt2Q2JAIHbbCVfDnJRL7y3hwEnoxArxbkJytcOKis FzezC8j6QX/iHLKZT/aBdX0ldbqSsKmyQYRMVMKm8sJjAS3ytnxsrKtuvjXt39QjGz+9/rJ6U3X +P5nukSNs+yzFNVyFIk6iGrXCC8UEmzVdAe+D1naSqPiirI7nnYt5fcie0iR04GoHq2IDEJaDRu 6hJZJJNBBiLZLIcEQMSs45Xwts0A+SrnEbcXOBgrs+JdkQTJ8zwWppLPWPfbBfdtUDAzOwF9nhR a1fMazH4gjgsVO5GQboxTzs12sAQyUyBKTsWmU/6C1koEFip2C6I7oJJnmqTMtnUgbL1RWHYQ2k dUwigXx6LBL7gN59RUhnnViGXAWoWdibP7VWrZ0YCm+zXd+Kqeoli3saaMek+mza0XqWSyZgcL4 G2KDLyBbxTUWfHj3Wvybh8SBenScb9aaAyCfnFFl43VlOsRbnOieVGSaFPQ6UMTbjj4spNmsfEn qHnY6WkI0X1nN5hEOof8Ym1FX5XGI6rpQDm8qDZ2Sj5QCuCNSeCkDbUvPsjK80aWka4sZj5El99 62Jw0Pdii81VBAA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/codecs/rt5677.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 6e4774148566..69a0fb8d7f77 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -4725,13 +4725,14 @@ static int rt5677_update_gpio_bits(struct rt5677_pr= iv *rt5677, unsigned offset, } =20 #ifdef CONFIG_GPIOLIB -static void rt5677_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int rt5677_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rt5677_priv *rt5677 =3D gpiochip_get_data(chip); int level =3D value ? RT5677_GPIOx_OUT_HI : RT5677_GPIOx_OUT_LO; int m =3D RT5677_GPIOx_OUT_MASK; =20 - rt5677_update_gpio_bits(rt5677, offset, m, level); + return rt5677_update_gpio_bits(rt5677, offset, m, level); } =20 static int rt5677_gpio_direction_out(struct gpio_chip *chip, @@ -4834,7 +4835,7 @@ static const struct gpio_chip rt5677_template_chip = =3D { .label =3D RT5677_DRV_NAME, .owner =3D THIS_MODULE, .direction_output =3D rt5677_gpio_direction_out, - .set =3D rt5677_gpio_set, + .set_rv =3D rt5677_gpio_set, .direction_input =3D rt5677_gpio_direction_in, .get =3D rt5677_gpio_get, .to_irq =3D rt5677_to_irq, --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE3E264638 for ; Tue, 8 Apr 2025 07:38:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097915; cv=none; b=sYuRFL7FHHW6Jf8lLXM7MQh0u5xHR5aSHZlSyEGzrxnDTa3WnDL9LmGkZQp9V9+V00sclHIEIoelGwXzblEj7OdZXKnBavwskr9We89JQqHFfGROWhLP8iUSCfUTiVyUHKFClTLQfRwCJYcuKA18uSfNWPzwbm2z7aU0m78D/q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097915; c=relaxed/simple; bh=gmKssN881RyaMdbX9IDKos6vpe0C9x5lclww+lbf4e4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D1j9h7rMMYeAsuAvAUtBRW0/dgUAz3QqhjAKiFqYp9HGZ0buPCR44Jtj24sZEF5WU/00hVhNMPFbfh20HIgLrO7O3RYUFG1eEOYL/zjuLV2Bz0b1DUTV7mLoCFxycX0QOtwtFfrf4tWEO/5sqcQIkqUT4/LazNCOY0uVmMWq/so= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=zpKGol//; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="zpKGol//" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-39bf44be22fso3464038f8f.0 for ; Tue, 08 Apr 2025 00:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097912; x=1744702712; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LQVmUT29V2vBtC9E+gdEFAxcap/8e4R6NNrtBDHE7iQ=; b=zpKGol//Mt5OILiY9yqXj2vaJ4bvigJlZ+KtIIfWpKOHQIcibL7AT2h5z7nwcgNBWf 664teir3Gl4Y+XC2chp7oqu5MwKcEJpkoGImMKwdPKUhyEhggXNHPfKocpHhEj/NNMWa WWTzwkEH4DeHWkzXlHzFkoe/By8LA8rJazGlXvRvcJjDwLiBqEXmOLdXIIM+Soh4Mqi0 xzZvIdyuf7rfCDsjmciLWlS8OrSN7sdmSQU79mk8TKshaj6oNJKFz/IdEbw+v7dcNKxX btH6xZa0ieEurCxreWDCsYvtKVwVSzEVkm1Jph86qZuRn1z6CBxVlTUugm20roSMiN+d FUeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097912; x=1744702712; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LQVmUT29V2vBtC9E+gdEFAxcap/8e4R6NNrtBDHE7iQ=; b=Or92nlVad4zky2RA6H35cCZfFvcOFyvU2qqWq325+5zxllp4fY8nsP5mHAcqMAcVlo xUc5tH1yOWz+8j5fALsJidCF7ZoyvI8dM0uUStS48P8RAWah8mRc/2FGWUwT9aXHGFNs a5ijHl7NRa/CqmIYjZx6zhLlOqLJcYVLCYTk0+o+Z25cPAUnB+jD9oKb+zxA0p2Rr+ky eVCZENd0dHggsR4aq/oPpqQuR0z99sKLq8Vz67reupaBN9ij0EHH6EGt2TlcI+hk19PY KfwF0jnwwU3FAI+MQRyAEe/o/OwCOtbONnUSP97ipSbyAnm+yGEB47N2cxDUY9fP3okh 2+vQ== X-Forwarded-Encrypted: i=1; AJvYcCUfbVh3zhDBmP90nJwxCM3jZV9MZtGcXwRcfxJegx6f3CvXW7uIbxkhEraVQZ2nNe7t9w3STzTXJ5xMspY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3iFl85yJQAwgZkyW6kMaXgncL5qTidlUwQjkGX2c9diglpUXf NmqZ68C+JakIHVbs+e6q0J2h79OQT8MrcCbU5vtPU2KWmDSifFs+EHV16HbtmnA= X-Gm-Gg: ASbGnctiahuRFQbEIDqfyHQWJwylMOh/tGR71zVWulAsfNapTPHUun8f8v35WJIS1pv FmrW11H5+2/SsNT1EYFiFoZ05G4PAh4tFxscwEiHKLYP3ztUi0mtxjeWjeWt10A+IO0JgYTPw1A j7xWOleustwXLwHw9qJQk5Bj+24pvaYKYrHYAHztBlluJDylgJnH6XUW1qBud9/ccuZvxAq8OTp PPsfJa7NZhAGteC0gWx8PeI+vaTc2lHfPJbHDOBwy/I3OgvcW3gfh9IKho/haaber9izC57hu4R 21p7jpNu6va1H7+pa+byg+4wdDxtRBdHf2m8zg== X-Google-Smtp-Source: AGHT+IGUJn8Zq34HDc5Dha7/WV8HrI2iZCosrT+ksBpGa3LxTqmcQ7HJ8H3bhYBFYza4iwBG7cA9tw== X-Received: by 2002:a5d:59ad:0:b0:391:1139:2653 with SMTP id ffacd0b85a97d-39d6fd06913mr7779430f8f.52.1744097911839; Tue, 08 Apr 2025 00:38:31 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:31 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:24 +0200 Subject: [PATCH 06/12] ASoC: codecs: wm8996: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-6-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1551; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=J+UXKSUM53U2y2pHQ+9DPWteN9/2otTFvDTKRKmiZUs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJuvYmZB5HOytKdjpF+bXv0ibp4qgHi/JhNO UlbOT9UwHiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbgAKCRARpy6gFHHX ctRxD/40q9HVEWkMEU1CQ2bpA1xLXRmNnYTvAA1+Rh9v+2slXDl8EpukoU/ntP7Zcb1HZqDmdHB As0sbr1Xthx002nsTO2ykfLst8E1tfhiQpGo2/YiirvAx5S4g9CAECLgVNBa3vpm/bvdxqP0ZB9 YliQrDQSyolU+tdSU7F0ZDjwLf/9QnQMSEUU2NJRHe/XhUOJ6Dn31c/sAVhCD3/w5NjkPqNwD/R kgXonWNMNi0DvCJq83xI8bdTwID9JF/BdSM6mur2PPpzhnhiPYBAmoUWecdLm8VDKgjbdK1UF87 rtIQJBU4lAbtxRiyn3p3qHPTmLNYDbnPI0hYRi6Mi60rAoqLZqIrXqmjkC56vDzVg+tajH8C9+k glVthIuYXvAblFH2dVsuWzFclKI4mCCtUweAbyQXhflJOD+XNdqkAgIGnQlFsY8nQ0/gYhZa/v4 uGG6YoTTDJaO0cNlWiqGEtJVt/C7CZcaRJLtTek9DYqWHap+kr/vCEjP02Cv62+z/IOdCty3WwS mIEfGgYqsjeX99tBd6rWTZUIVqLLDoNjCHWgp5wZBrG1zu0PzIvpeCe9rTV1MgZdmtIrjE/8eG3 phAnYyMls+IsW2vudz+FckW5zGScBZgs4t6oPuRhEXE2vnTP/6IPkkFQmyHCRAfOjl86CNz9gxh pnSNCdM+uwGQMgw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/codecs/wm8996.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index c2af8d7ecdd8..e364d0da9044 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c @@ -2136,12 +2136,14 @@ static int wm8996_set_fll(struct snd_soc_component = *component, int fll_id, int s } =20 #ifdef CONFIG_GPIOLIB -static void wm8996_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm8996_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm8996_priv *wm8996 =3D gpiochip_get_data(chip); =20 - regmap_update_bits(wm8996->regmap, WM8996_GPIO_1 + offset, - WM8996_GP1_LVL, !!value << WM8996_GP1_LVL_SHIFT); + return regmap_update_bits(wm8996->regmap, WM8996_GPIO_1 + offset, + WM8996_GP1_LVL, + !!value << WM8996_GP1_LVL_SHIFT); } =20 static int wm8996_gpio_direction_out(struct gpio_chip *chip, @@ -2184,7 +2186,7 @@ static const struct gpio_chip wm8996_template_chip = =3D { .label =3D "wm8996", .owner =3D THIS_MODULE, .direction_output =3D wm8996_gpio_direction_out, - .set =3D wm8996_gpio_set, + .set_rv =3D wm8996_gpio_set, .direction_input =3D wm8996_gpio_direction_in, .get =3D wm8996_gpio_get, .can_sleep =3D 1, --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04CA026560D for ; Tue, 8 Apr 2025 07:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097916; cv=none; b=Nfifm/Qj6pHifGo5d7La29tcmixhx9090JCSXt5SR/4ZlM2Kq9tixsKNlKSbS+99mluyUT3UjGWcEA971Oj+0TmG0OR6Pt4vo3wsrV85P9Ffx3xe3Y3hWYAP7uN/7AmWSj/fexYt0TvKcPzxtKBz3+7r3sHXQCbztFslssvDhNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097916; c=relaxed/simple; bh=R/A3ylqOH9M0lwaSSat9OzcHkaRY1rHj05MI244k0Kw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ul4KEq4mcf83mhNMh3Cyj/2mmKP2ML/glBl1PuAzA9h1DVcrGvWD/vr0eZvGWWHJ9jZxmnMqr7CHvwmQx3YlmkRScoj1Wtm34aW//rl3u5Tan5JqtnBYDv/kMI7dxKZTmK/gfCTuNbX++A4yo2P1kS1Eg/HDVlfA/Q9MJk7SYog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=RXt1wO2c; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="RXt1wO2c" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3995ff6b066so2830061f8f.3 for ; Tue, 08 Apr 2025 00:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097913; x=1744702713; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B1uFhkuKxlLMwl31+Z0D6QqX7Bfo4gt21QMBWz3jFqM=; b=RXt1wO2cCD+aZTO0dw2wUq5CzOHh+BbDPxSOPi4P2PYgKLen3IQsX+e7D14nM2HLRi veRzBOuRWDgz6GhFYGQt1c+X6Kk0CKQtUxSMtzTIUCJJ5U05AEpkVNqp0VW2ZVyeC7hd bK1qK3Bm6K7jb+fvANqKuBqB84GnUO0U4i2o7MvEFOXLkohzX5+aQ4F3DVe9ArBq/7c8 3EnCqFsffPU/VHM25Z5tVfr1J0wVjyiSGWpnYNKWmNlmBPhYFC6pNAcasqqtQNNgV1xO oGiE42UnfQy3VQPd0N8fDQTZPtB32sSot50v6NQQUL7SsYVb7SrzXLIhW0WInvh3gBVU neng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097913; x=1744702713; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B1uFhkuKxlLMwl31+Z0D6QqX7Bfo4gt21QMBWz3jFqM=; b=Kz0sU0nKHCQDeLmNfcNvEdpAHMojcP7rnAKt1DqXPhcAfkK9lg95gOMPhovsEEi14X PlfKiRjzWIPoKCg1hwv6MO13uR5z5d4hgn9Is9uAzQtxcqWaSqByHmwO+6MSzYZ0sRwc QT8VB4N9Uj8uTsRCc55nnSH8MBn8ytIRcMVAP+Kv0UVqasNnDJ9gElt2/LnkqDE2Xddn VAX3HZmpABgCErR8y3rzLC0YoiPxr+TbNdubEbIWvYjQnwP20MXEWRG807tFB59rzVxo lEgYYruEMjo38ujFRlZ+FC7XJJQkrOXjQa0JXah88j5R4WyztrIY/tmibrBCGu3XIq2h 7QUQ== X-Forwarded-Encrypted: i=1; AJvYcCVB7rmAFYriBmFpU3vrNKKMAVN4ArlPottpRHXbmVbDSjo3l3qRI4tBbAmM7xkIGr+zOZPGv285FOi4eYw=@vger.kernel.org X-Gm-Message-State: AOJu0YwBEpcggx/caazgR5+TSEd9OyFJLqyb7RGNzH1Sv+zt3mKa0Fpc 18O2WrmrXaLMJPXDZDbWJSYeNwo4ZUEUHZDxfqwJZiYI5NXBy9ZEejOmMJTOPC4= X-Gm-Gg: ASbGncuTnYLAJtXJzWkz6Zshl21xxyJkG61a7RT4LtTMr2XqKDRRTzQzU86WDgChl5f pmYq02efqJSs9DbOmLh5Zs37fnpY6fro3lM+SBXPZWlYIQLPvwRkdfzd2ZW5B7AUOkkSNg9iT09 hlPPQTZbYi9iYmp+6VkUbnFTKKlLBsMkjqCKUMZ+G5znSzffk+KMXiI5Kixn8nVdXvrM7GMqlSS dxBjG6W7VOe+TxsMjkzDT3mwVk++10Nk1cYBRBduDWATbW7ee1KTOMEdklFKFPUkZVxhpBzPBuN zeXjhq/Lxqmi3wg7JC4MezEBES1xiLEfd8pUkw== X-Google-Smtp-Source: AGHT+IH7iNRt7fIB3NK4furLHtKGOmNKWjDvqJqeUDP7R1K5uKGIvdDe43Tv9iw3hACcOH9nLmnqQg== X-Received: by 2002:adf:b647:0:b0:39c:13fd:ea9c with SMTP id ffacd0b85a97d-39cba933220mr10732675f8f.47.1744097913203; Tue, 08 Apr 2025 00:38:33 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:32 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:25 +0200 Subject: [PATCH 07/12] ASoC: codecs: tlv320adc3xxx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-7-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1473; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=NsqwcSofKcQmDaEngiuDI5yN4QKWQmReIXbN5GWUN9Y=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJvYdFcFg+BfZgGFSOp+Nn+UTNQcd/DMKJ7h sDDcwF4HqWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbwAKCRARpy6gFHHX chnqD/wJyAtjmyiPPpsVt7o1nDHpXRZY8sLviChhI1phvTSvnrU3BpTQiBjb09lyDoBqVReMTnK kstdJfb+JXw8xJhs2Rlyt/X/AcZOvHokd/eJWvRB8zjlkQOCvzsgle25YtURSJkg2yNsIWL5ZUM hJGoMqM6pM7lXQ+NRiBs21v8f+93uAreL8pNwkitKdyn4td9CC+rfdVi6s0Gy4kMqQ4VuXyaq+L SIxV1W7LhXWlxlbSsjMJm5IGeK+4z6mEnyoid6WZbshAWIhN7L9JOVmf9szQfGQMPwPv8pFrnmn Tt8vXHJ1uTm9SHP0dS2trsf9Ef4EppfmIDTXJlXYr9I9NBE7Yz7g1Q2egLzs8FBLChjWPeK/Kr1 TNi4KObYXv5YfocxPwZfHX1CTzv2ENTOOXuJ8tJALFhltcYF2wd4CDXuuCRtE5ScxtdJEkHJL0C R/ZvmG2gwORLBGdwxOKixxAAqn91RPfwcJR1q6FWSqzQsapjJRXJYAVvmIoMvzy8ESYE++4H8j0 JpwUKJ2cSqOcRe8uF+EukAC5efOZKyCRc6F5sUSAtKU4/JBXN2cp8HBcEYPyMW7E6XRqMB2FZFl 7DIbjxOObh6kam3uoBLZa8xooV/Wz0V8e8RKmRFsLY/4ureE4MCHDPdO1ths/duwx+muvrG+Syc pZw7RuDmPiH4WdA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/codecs/tlv320adc3xxx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/tlv320adc3xxx.c b/sound/soc/codecs/tlv320adc3= xxx.c index 191e067ed1c9..1035ba17dc5d 100644 --- a/sound/soc/codecs/tlv320adc3xxx.c +++ b/sound/soc/codecs/tlv320adc3xxx.c @@ -1015,10 +1015,10 @@ static int adc3xxx_gpio_direction_out(struct gpio_c= hip *chip, * so we set the output mode and output value in the same call. Hence * .set in practice does the same thing as .direction_out . */ -static void adc3xxx_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int adc3xxx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { - (void) adc3xxx_gpio_direction_out(chip, offset, value); + return adc3xxx_gpio_direction_out(chip, offset, value); } =20 /* Even though we only support GPIO output for now, some GPIO clients @@ -1052,7 +1052,7 @@ static const struct gpio_chip adc3xxx_gpio_chip =3D { .owner =3D THIS_MODULE, .request =3D adc3xxx_gpio_request, .direction_output =3D adc3xxx_gpio_direction_out, - .set =3D adc3xxx_gpio_set, + .set_rv =3D adc3xxx_gpio_set, .get =3D adc3xxx_gpio_get, .can_sleep =3D 1, }; --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B63D26562E for ; Tue, 8 Apr 2025 07:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097917; cv=none; b=fHBwl2ktPQZ6gffJ4uayKzR9AIXNEwyDPeb2OVkxK2Fwo3NZnuS9D3ToWojH2ZtJ7SjgpecnXRzihrvqZsyzVu6a8YN1WBhDPTGWfB/875FUTynzHOwsahKyqpVqiw8Xdrn3wk3LH44BhLNCQYL/SPeuc5mr4JcmVsa63NYi+Go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097917; c=relaxed/simple; bh=fY+pWVILXqb5/itiCqfMZP6GT1wrAGbxEdKCgLUSImI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GeK1YBfbChoVV+5k2gfQFoiwbmLGK5RC1NdCa7J4A+pfFmxrzHdp7AHemBHKa23wjqkWyhmpYQgTC2HbcL6/wr9cQzq09itlbk+ImnsRSWtJZkfDxlkvPIJ3nR3V6xuefYsEO58RRKikW0g/i9dEv6Jf72rg5sfaULDNh8wQXg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=pR1kh0jM; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="pR1kh0jM" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39c1ee0fd43so4347890f8f.0 for ; Tue, 08 Apr 2025 00:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097914; x=1744702714; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZBoBUt087bpPfgkOHFFjzVkIh+yz5QA3imLs9YI01iA=; b=pR1kh0jMaSHRGOEu5hNXz0u+MAyf9MFYaUuYEX5V9gWwUla0RfLyQ/xPIob7bTdEo8 90IY8VfLQNGKwBHONqlok3/gnmMFF2Ri481Ztq02+USCWKTO+iiBkRBlJ7LxxO3oUHbt /7M7mait8DxmbxihJUmxPSvBoFJ7OMl6IhOYaAngxXeOtrCivzusGB9Rk7s4P3FhUQs7 8yYXUEeH8WSJvivxjfAFlCP6x1ud7geOdlQo29khNbzuptAqio3GeswnJR7S3hQz30es 3257T+xsr7bPfikv3zwFj56mNAzzuwX4gSnpCdO8k0SXZkx/EV5ComDSbBogjsW6tf1S fJkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097914; x=1744702714; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZBoBUt087bpPfgkOHFFjzVkIh+yz5QA3imLs9YI01iA=; b=Yw+JvN8HCSJ3m2AAsLmisYGvhtrL5Of+2knfemtQKDEdlLhmuNttydnFPOfLF5BU7U fflbLDswiXUhGqaYgnpmE+xZezx69ZgF/gNbpDxdSuPV0ef3t0Z4b4NBlgMZEi+AYnXx t3rAQtfteDamH1e6uZN9Qn9wLAaAMhZ9zpQ9V9h4TAMNY9iEO/J+xqL8A1dOixtH5pCq DW/DiyvreZeqisx/IglGP6mjXW1ncT0l6Alt6tM7EL9MzZkr+N7FqDXiByx+pqVfO0B4 FrUH/qIqo/zNjE3WL71Z4mZIHfWdh+ZH8EWgom90mvDhIsntSSe1SLYQro10hometxB4 1j1Q== X-Forwarded-Encrypted: i=1; AJvYcCUl6HY9I9xZq12z7CYrELummlcfm3P5Mo3eN03+BWl5ZOknAzeO7gMfjpcxs1NlDErn70t9hANnA8NXZ0w=@vger.kernel.org X-Gm-Message-State: AOJu0YxVZ9V6T6Yla0NlLa/FRCVoOtx1z+fiatmW5vW7JX/3vb0ocOxe 4mBA5/VG/4X+ldI4G1qtErps2Ooi/m5TxIyNDhBFvuXRDq6yKhMMVLQeeJ1Q9DA= X-Gm-Gg: ASbGnctDWsdiuwtXY131+YJK1A/qzj6muJRfAMyTnUOH04Nv2OB0V1C2E9kAlitLV8u FJeGyNtWDh1XNc6HIQMcXnLwdNdUYf49hiuG3XyV/3bvSE5hO8ulWMLbHxZSxYwDCxJ1a+mE6nG SmsA7b7LkPcQ5J/N2JwM8J1DELUMRxEHHE2YgQMnSx3pZO+f/JFBxTL82d8OyRnV+NXZuP+ISnr aZfMVkHv97gzWhBZdAB25FqfC+RznPaanUnatvlJ/GWSgnqrMtwS+rul4x/LUb/JHBxmwmTUofz KHBNXpd+Ah+bkyxDtCQc9lSrryi0S9H9KGsj9Q== X-Google-Smtp-Source: AGHT+IGZzWPqum+g/fh0DG9ZeMxuwA7hGhCymtHVGUiGXAbEqjqT2osxcevrD/xaQ1rQvP2TSbkLzQ== X-Received: by 2002:a5d:6d8c:0:b0:39c:1429:fa57 with SMTP id ffacd0b85a97d-39cb36b2a54mr14794973f8f.3.1744097914304; Tue, 08 Apr 2025 00:38:34 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:33 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:26 +0200 Subject: [PATCH 08/12] ASoC: codecs: idt821034: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-8-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2498; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=cgS6T7BQF961sKz8ax21RsHAauAs2dNcFyYRBwkQxTU=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJvNVwa+w21sExX3reksODhxqsavG/ZikzPz C1DStlIuC6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbwAKCRARpy6gFHHX cqyvD/0dEy+efm6u6Nh8gozJACwedpwcG1L9GEZj2HrNlnETPemPzBV/eINPvN3vGDouJyJcQ+h mcVbVmQk1qeDyNm6vLLDdT7fOppv9yyEJiAEFI9tXbAw0wXoEDNO+wBH9n2Zw4IBmZ2eTn42seB MGZYb4bGFPo51kIYtzUQh4+w/XoX+0tH31w5jnWYEJwppxc5iaAVDC7HgtI+bBhx3cRKpKx5rlI TXQgDc0ixZEtE/VnxrBovtDsoOvcr7qG4xZHPBGk1zVtR+OBCmgattvW/xxMOwt8JCcv0N6mOPC n0GqgeKafgh61RwboTgtDYKpzOiS7TeDkQh422AbQeURJfjg7LK/PCJiluprXBhyn59bFJHFumW xWSwXLhBPwluM1Ku7BxyfUBYswwBcRDeUGaqKQMYyjBiw0dR4cNzMuaRmnRv0Tx+8SD3M8T3Cw3 Nq64hJX/4LsjI2h8dO9xEJRNFMddYp8/NM+tNTdVW4DDN59cegxet9MPt2JVr6/zK3miWQWiBuS BI3lG6bP0W9ZIZnbD5vSAbA9SD5VOH3f93o9CWe5CODtOQs2SQ7w140dy8g4diVc3EMNwuqJk7Q SrCfeYdVjCV0Mpd9IlJ6TK+6WoQUQ286gbR/+GyuKZV0i+cC2uA8u/zt/rhxNlBB8tof79z2s5w b15sVZOUPaOJ/7A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Herve Codina Reviewed-by: Charles Keepax --- sound/soc/codecs/idt821034.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/idt821034.c b/sound/soc/codecs/idt821034.c index cb7a68c799f8..55e90604bbaa 100644 --- a/sound/soc/codecs/idt821034.c +++ b/sound/soc/codecs/idt821034.c @@ -957,7 +957,8 @@ static const struct snd_soc_component_driver idt821034_= component_driver =3D { #define IDT821034_GPIO_OFFSET_TO_SLIC_CHANNEL(_offset) (((_offset) / 5) % = 4) #define IDT821034_GPIO_OFFSET_TO_SLIC_MASK(_offset) BIT((_offset) % 5) =20 -static void idt821034_chip_gpio_set(struct gpio_chip *c, unsigned int offs= et, int val) +static int idt821034_chip_gpio_set(struct gpio_chip *c, unsigned int offse= t, + int val) { u8 ch =3D IDT821034_GPIO_OFFSET_TO_SLIC_CHANNEL(offset); u8 mask =3D IDT821034_GPIO_OFFSET_TO_SLIC_MASK(offset); @@ -973,12 +974,14 @@ static void idt821034_chip_gpio_set(struct gpio_chip = *c, unsigned int offset, in else slic_raw &=3D ~mask; ret =3D idt821034_write_slic_raw(idt821034, ch, slic_raw); - if (ret) { - dev_err(&idt821034->spi->dev, "set gpio %d (%u, 0x%x) failed (%d)\n", - offset, ch, mask, ret); - } =20 mutex_unlock(&idt821034->mutex); + + if (ret) + dev_err(&idt821034->spi->dev, "set gpio %d (%u, 0x%x) failed (%d)\n", + offset, ch, mask, ret); + + return ret; } =20 static int idt821034_chip_gpio_get(struct gpio_chip *c, unsigned int offse= t) @@ -1054,7 +1057,9 @@ static int idt821034_chip_direction_output(struct gpi= o_chip *c, unsigned int off u8 slic_conf; int ret; =20 - idt821034_chip_gpio_set(c, offset, val); + ret =3D idt821034_chip_gpio_set(c, offset, val); + if (ret) + return ret; =20 mutex_lock(&idt821034->mutex); =20 @@ -1112,7 +1117,7 @@ static int idt821034_gpio_init(struct idt821034 *idt8= 21034) idt821034->gpio_chip.direction_input =3D idt821034_chip_direction_input; idt821034->gpio_chip.direction_output =3D idt821034_chip_direction_output; idt821034->gpio_chip.get =3D idt821034_chip_gpio_get; - idt821034->gpio_chip.set =3D idt821034_chip_gpio_set; + idt821034->gpio_chip.set_rv =3D idt821034_chip_gpio_set; idt821034->gpio_chip.can_sleep =3D true; =20 return devm_gpiochip_add_data(&idt821034->spi->dev, &idt821034->gpio_chip, --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25A97265CAB for ; Tue, 8 Apr 2025 07:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097919; cv=none; b=lPMbP/BldyS6R2xh/b3kHq8B8qCvJRWriKR+/VkUUb1Hi72NfmKhTQD0SXh1BxNtbgJ39mShm2NBRzSrMoZZiN7rnUR/BTQ/tQy9EYm0t4+CRuIIAhTAXLUXUqsQzh+jMHNzTEb78ejNgBPllAlfL/jdcdQHkQABEw1w7cOtM+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097919; c=relaxed/simple; bh=QyM9Y2T9KFk9FIF6coN2uL+8ky5fWHdeo/FQXvejEe4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hwn3qKlH9xcVmh9DVOlWAKG9t/4HPByUFL3D4GUT537GprHyWlbrmUJwtbuFo+wrJ7ZTukGN5hdSTfueYXbVl4KJ2ZWmToT28+okaA2aXjfaQYV9nFPMMZFPFOWYix579iGw8SrgqfrULJQ88NRjrTLZ5AkzntPFm9oSirgvZtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=2/vmbU6j; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="2/vmbU6j" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-399737f4fa4so2786413f8f.0 for ; Tue, 08 Apr 2025 00:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097915; x=1744702715; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=W803SFoPErBgnl6+mnZ477H39AcMJ+KI3OFr89zmp24=; b=2/vmbU6jcZCKPgKVxlMnyBjQaArjIFx563FFYtOta6vvij/7yLmQP9TMuCPFuRNfhx ZnoEg6kgeeHJHCu0ezsOFTr1K3LOA0h7nuRynVM8I4WruiLvNivhvRNqIWOrJUh2nDTB txv9KGsnozLmySpIM2NiuQoBU7TSKdMYPSvDVbAtyTXHSm44m93pYplyLFSlcp5UTQuc ps7q3fmuUIHeRvZ3hxmgn7XWnxxUfq/Ne6yjhMhbrBCdLJD4Ot40YBoAiVb1G2ZCWBJJ ekbtORcteRp5OmJm8zTxiLXaWk4q3wAVNXD9857OPB/FvCcEy/Cmf+MRbmmdJubmRFs2 DrvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097915; x=1744702715; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W803SFoPErBgnl6+mnZ477H39AcMJ+KI3OFr89zmp24=; b=Pubx/CdlQlJCQxaJ/s7fZNiESJmXFmEsRDdNsTX5dMBC8bkrVoHxY7kNctdHsdpPAX 5yL6A8EcGhPhXIM7lNa31YlpS5qCxVr+4Gd+haSfIHVvlt+5QJAYw3Iuy0D3TAGgRIQ/ sZg6HSlnU0/YL95eF5LZ4KLeBwVNZUsy7l7crFD9hKODaQwiS/IQVI7jCcvIXRZvhKm8 q/5CDrCw+yCu8+4veZrxAMju5vaM5JWvOj86RSTXIDjBUqcrF/nBFZd5e/bqaBMENNwu jRmZIy9JlcgzyeB7c15lucTmGfd59FWfDqSPO+YAlLUW+6OGh6PA8qnKrBVrzPV3Y9qr mSxw== X-Forwarded-Encrypted: i=1; AJvYcCW4JHnpDeG5ojaBm6gV/5zKH+wkX/SnE+LJ4/BwwvqcA0PgeCT92QAiK9IUiTSk+gy5X13wkvqHGnve+bg=@vger.kernel.org X-Gm-Message-State: AOJu0YwRYHT0YjswfgzL7LE7bHyfZ3agzMdLvXHpgRwTYI6Zv107zxrX R6ofq+0esiNyGliCRs6MeoPYYWO7ySsZZQXRjlFGQYsTXM9ZjSzpHKvrBs29UuQ= X-Gm-Gg: ASbGncuG4Pa4HxhktrgCexrqbl4vS+5TnXz1cq6RKXlTaaIc7XISO89HLOa6mLPq/L6 wqudIa1GdqKn6k+Lcpp/HUwmkcWYZEC/DCS3blnAWTInSH4YtFos8b63EvfbQ1rDO/kU47loMxW eehQA8I5hFLbHDKfB6FfJ3a40pYvcuBTsiZtpDuQAc1nJp5NvcSt6fkPayOoL5iis0kF7lMzTyz nzlsFT/8iOuu5yFFLfb2y0SmXY9ZXy2zCqOx7Aog8KRKD5ETagRKxBQIiyOrTglKwdnm5yo/MW4 pVYKI+L5ylnhHIUWkv3GGo0qfzXf9BIlNkTIzQ== X-Google-Smtp-Source: AGHT+IFu6lZjvoeA0BI6CTAms2fH8tDTh0Ob12qHNOFNaOg2B+9x5oIaqW97sCHJZtmtAyMcmFnsjQ== X-Received: by 2002:a05:6000:4212:b0:39c:3108:3746 with SMTP id ffacd0b85a97d-39d14662f19mr12870082f8f.52.1744097915381; Tue, 08 Apr 2025 00:38:35 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:35 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:27 +0200 Subject: [PATCH 09/12] ASoC: codecs: peb2466: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-9-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2569; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=y4V5c/YLi6h6vrcHaV9RorzHXNL2yLbtaONpy+VaplY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJvxXG45j3PQaKR207Rl+yciiaJhmVkwRAT/ peItlc1PaaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbwAKCRARpy6gFHHX cuilD/9ZQ1TM0g2o7wCTvTxqpJDnIQT6Pidi0cJW+3Ak5pKNfe8AkS/6gI2e9hdn2ERVgBV4yg1 3iRb3J0oWGBqMnLH3fEHdTTLPAaH4NBy9tDHDuow5zKbrwQSNk355uNwBnOXx+rW5XkqWvrzZ9F jyeYEUJKNQ9TMVVbU/WFKJBwMl8vxHq3IOJSU2QV7I0bkk8w1Ntocj+PsdiJVPgytTRBtCtricw QzWo6sQNusiRtXVLPM/3cxsCV2akzeIsQpOn+w7qZTl7a3azVd8TN4FfY9bZ4HLaVTXwiHt5V2s 2OfbMW5KopN017da73uNUe21evhpmliBIHDza+Jf5arY4wiyhVnZOxAZCNwvASuFtRv2fxTybeS GWctWsOnLezDNmT1BCAsO2qzB60wwC9xENqhs3TQ4oY2/LKX+MrdGJCuqbkNYSwQ7uIw0HEqwEv fPg3ouPHfvGNZ9HSBe9mw7cyY1cr6Xw2jvp8+NA0uPk4toUq3mjAC5CEKmwS7mFaSAR9r6k4VbU RDvyIPf0/9iKSGZeFtpSgZgoHyOB9jN3KNeK6uWi/pG7LJFggJqrgOSvx71C9GMJlfLyFcEVgBw Ouc37XqH6Cnhn92YG3fBTw//AFeQ+Ooa1t+/m2seLwXYz1VHee2IvocOtyjoQ4kwLHO3O/iP63i /GqnHGx5vxkI7zA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Herve Codina Reviewed-by: Charles Keepax --- sound/soc/codecs/peb2466.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/peb2466.c b/sound/soc/codecs/peb2466.c index a989cfe058f0..b8905c03445e 100644 --- a/sound/soc/codecs/peb2466.c +++ b/sound/soc/codecs/peb2466.c @@ -1726,7 +1726,8 @@ static int peb2466_chip_gpio_update_bits(struct peb24= 66 *peb2466, unsigned int x return ret; } =20 -static void peb2466_chip_gpio_set(struct gpio_chip *c, unsigned int offset= , int val) +static int peb2466_chip_gpio_set(struct gpio_chip *c, unsigned int offset, + int val) { struct peb2466 *peb2466 =3D gpiochip_get_data(c); unsigned int xr_reg; @@ -1740,14 +1741,14 @@ static void peb2466_chip_gpio_set(struct gpio_chip = *c, unsigned int offset, int */ dev_warn(&peb2466->spi->dev, "cannot set gpio %d (read-only)\n", offset); - return; + return -EINVAL; } =20 ret =3D peb2466_chip_gpio_offset_to_data_regmask(offset, &xr_reg, &mask); if (ret) { dev_err(&peb2466->spi->dev, "cannot set gpio %d (%d)\n", offset, ret); - return; + return ret; } =20 ret =3D peb2466_chip_gpio_update_bits(peb2466, xr_reg, mask, val ? mask := 0); @@ -1755,6 +1756,8 @@ static void peb2466_chip_gpio_set(struct gpio_chip *c= , unsigned int offset, int dev_err(&peb2466->spi->dev, "set gpio %d (0x%x, 0x%x) failed (%d)\n", offset, xr_reg, mask, ret); } + + return ret; } =20 static int peb2466_chip_gpio_get(struct gpio_chip *c, unsigned int offset) @@ -1879,7 +1882,9 @@ static int peb2466_chip_direction_output(struct gpio_= chip *c, unsigned int offse return -EINVAL; } =20 - peb2466_chip_gpio_set(c, offset, val); + ret =3D peb2466_chip_gpio_set(c, offset, val); + if (ret) + return ret; =20 if (offset < 16) { /* SOx_{0,1} */ @@ -1940,7 +1945,7 @@ static int peb2466_gpio_init(struct peb2466 *peb2466) peb2466->gpio.gpio_chip.direction_input =3D peb2466_chip_direction_input; peb2466->gpio.gpio_chip.direction_output =3D peb2466_chip_direction_outpu= t; peb2466->gpio.gpio_chip.get =3D peb2466_chip_gpio_get; - peb2466->gpio.gpio_chip.set =3D peb2466_chip_gpio_set; + peb2466->gpio.gpio_chip.set_rv =3D peb2466_chip_gpio_set; peb2466->gpio.gpio_chip.can_sleep =3D true; =20 return devm_gpiochip_add_data(&peb2466->spi->dev, &peb2466->gpio.gpio_chi= p, --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B142265CC7 for ; Tue, 8 Apr 2025 07:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097920; cv=none; b=eNVu65vp1k9KeiE2ooFcBxse+xq294WqUVJvEy0aRkLSUJu+4opJae9K/ST2Oy13h7oqPGckaI0UFkQy6KMpNRlN4DomYlD0mGf+1+wfkZUHjfQoRmwCUtwfFFke56Ke/V1HobOzthScXVq4QbKq9Xro5ddosZhDDjcWfzMq2jU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097920; c=relaxed/simple; bh=iHrkXe5h1z4tzTJGa40kk8YaEGYYX+YiF6Amd3et+z0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QytYpM0acdH+1/QCMv/XWs1euosplDH8Y6PCggglBotFJ1u3W4gWhwH6hn1p4M9qoQO7pUaGcz19djdj2UFlgCiIOP65E5JHket1i61ZYFdKI1sI8j/LSbg2qcWz5npKUlasXRX/iGYhZjpMZSLgY66lD6y2m5Rv+oqlzWwSfco= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Io6LPklX; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Io6LPklX" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cfdc2c8c9so30149145e9.2 for ; Tue, 08 Apr 2025 00:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097916; x=1744702716; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YvcUl+FgyXEa0lssAY7sah73iVwNMHdHEiWjXEgeur8=; b=Io6LPklXSugcHJXry6JkqK7vN5Vac9Q4znVUco4TN6pQboAViGk1XAsmeKDtM3V/9B O2UpwDIs9rupazFuHTayHUsN1sruvXY8YOdbPR6baXhJyVVnQJPtzIVbykSXjz+Pm5WC 7o3p9AAuOlT51wNZS6KcMpKJ53hTMZsvyZLb19dz2/CUuThqlUzGk6Pu//AUNJqqCIp4 M+WV9fh5Hnh3e2agcYxdbwlEXmWhGmjsKdTRXRgtIL/Yh4eBZhOu5LMUk3YzG4/YK5Bx y3lwU1ETZ2eJVeItTzsoNomggAVOYLgJ8OELKFGb2f9g5nFGIZJYvWGvmI6iCn/uovlo 1/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097916; x=1744702716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YvcUl+FgyXEa0lssAY7sah73iVwNMHdHEiWjXEgeur8=; b=w5j6DyvvRkroM9dX7hfTDSJUPQdOMWrbCL6UuSzG47BwCDFPl7hNsYQf5EXZEQ7pA4 34AfWPNfKdKnZ4K9ejq10AQePj4CSA3To8YfyOJnM+0Si2jJsbsUY9OtzjGdvT4gXuH7 0mz8EcFNr/wj3Is3ILzYumdlOsaz3dIsKlFuktgWNTMmRUSKnjYprI7yeohn/bRHMdzW XsSpz18Wp8dWd+AiSB0o9dky0I+SHV7tX4/+JCfH5QvWoEbakuPc2d/un8VVafXNvqhN Uef+p8Bry4hi07dwz8Qf0WOfMcXc6VsOYSPg1nb2VZZJiE+iwxH8JobM5WEPuE9I6+RQ YU5g== X-Forwarded-Encrypted: i=1; AJvYcCX7SGuWpcoSX7ZUr3datJTxpDzPhOrT6mNR+71TksXLdFbjF1BQKcDOaCW529Y0LJsHttmYOXD3YZPYDss=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc5BJOBNvXDcXZyf+OQeb8v8DKPEfEixT/QA5vnj1N/zA0fDSO 19A8nprROa/BlS85nxCIWA+fpu6Cc5AbTBELYktC9Qfnpe2Wr02U+002d1OabyU= X-Gm-Gg: ASbGnctvQDcASybK7sF2TO16EGRpFojPoSr14J5cfm12yAQlSxL0hm0hmdr323ZplIS TFn65Ldnt+NmrKyU3IVZbaLUeh615sWfqbf5Zpe7aLrpuA7LA6GUHDv3N/0ftfAR+7QZQwO9lbk vEkIi5ctXaSfcGGDPvf6CNdGu/OiyVjrGf3rFKiy0at00kONSAwPi5aZjkcY1zP9el0MkjK840A ucZ8DPGVUHofBxwp4olLpQBxVlkzGXUBI2jDauUIOBIuuzInZLiTLTNmpc8JlkhA8Y7/o2fI9m0 h2TqHxVbXf9KcbiU1CXVFoHWZqxJ85nQF8dN5g== X-Google-Smtp-Source: AGHT+IFwk1uMRpy99nhOF3Kp9erADIpAQZph5aa+Q+sNUxD06YSbpujAM4xW5AbmmoVWHwdgDPwwGA== X-Received: by 2002:a5d:64ee:0:b0:39c:30d8:a80 with SMTP id ffacd0b85a97d-39d6fc2930fmr8820700f8f.19.1744097916395; Tue, 08 Apr 2025 00:38:36 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:36 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:28 +0200 Subject: [PATCH 10/12] ASoC: codecs: wm8903: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-10-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1515; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=67o6fWDiy7sxHsZC8a8tfJBk/wPa39r3F5c7o3Lfqqk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJvb3n8ea2db0zLqYHLMw4MRqnN0dTR0v9Ef PN7HCdo4X2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSbwAKCRARpy6gFHHX cpMOEACOXpEn9aiFqFFzE/amxKw6dFdd0eMSDL4VlZpE54imw2m94NgtJaISilSwMOJoaUHULns Odez60bWg3fnngDFhDz28Es3rfhxRUaXDKCjZ6lPtjMzk/CJsk0ebuTKn/vlo4lnhnwYW90X7YU CU/zzxqACpiUXCvIP7ObZ0WeRTd+rxAWrqVYnq2Cc2R5X+xlyfvKXsjT1PvZ5Xh10K9D/9jcB+/ IUg/5kcvi/IqFiN0gVT6Yl5iU0Wdp+hGtHc4E80UDf7XKLh97Mrx6poWt7kbJ9bPtJ7jniDCm4H MUf5QsA4WKLI4tfEBdQFc+xSxtCgGs4KTuekaQ2s40WiiSB95BHRmVFYDRbaXieYdoZ2sPe3eRu 9/BsiqGnfI0wbBAgevRi++UHWBKH1k47T7J14WTNYUIlHLy17vEEV8R+OIanuzPKndl6LSlHLPJ csJzpdG1Hyykh1/2Ez4g8kp8PR44Br/ZNds9QmNkCro8eeL6wtTNal+i5/igFKmFrnx5AjmKKHW S1MHXinniIrcJrXwyNTQpqg6UlSaQCP1/Bgh1fAqqzV9hoWdH7dOFLWBnQzcFcmx0j82fYhla9I zaHftq3mm42bh+SG40ju6EUw61ykIxjxf3iFlfXPu3C0NGtHP5sxZeH39wWaHkg5H0upzP1FNRG LHQAzzBMw0UN/4g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/codecs/wm8903.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 03902909f27e..2ed9f493d507 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -1825,13 +1825,15 @@ static int wm8903_gpio_direction_out(struct gpio_ch= ip *chip, return 0; } =20 -static void wm8903_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm8903_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm8903_priv *wm8903 =3D gpiochip_get_data(chip); =20 - regmap_update_bits(wm8903->regmap, WM8903_GPIO_CONTROL_1 + offset, - WM8903_GP1_LVL_MASK, - !!value << WM8903_GP1_LVL_SHIFT); + return regmap_update_bits(wm8903->regmap, + WM8903_GPIO_CONTROL_1 + offset, + WM8903_GP1_LVL_MASK, + !!value << WM8903_GP1_LVL_SHIFT); } =20 static const struct gpio_chip wm8903_template_chip =3D { @@ -1841,7 +1843,7 @@ static const struct gpio_chip wm8903_template_chip = =3D { .direction_input =3D wm8903_gpio_direction_in, .get =3D wm8903_gpio_get, .direction_output =3D wm8903_gpio_direction_out, - .set =3D wm8903_gpio_set, + .set_rv =3D wm8903_gpio_set, .can_sleep =3D 1, }; =20 --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D883265CDA for ; Tue, 8 Apr 2025 07:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097921; cv=none; b=UbJ3KJzHS1CgcrYr2ldwdEj7oPWroOYu+orvsy2oFFHNs80rtTU5SnSlH1OEqlZTg1tnyf37vBfJ3Qte7W9hl9MfiIJkrqZyOHBE8Hab9QpqmqDmNxB54LGYs7Vi1TeL8pBWxRJO1/siHIYfUF9ALi3wprU0HdllTtOKvGvV7mg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097921; c=relaxed/simple; bh=ilNZkKiACmLQieG1b72vG128/Zk6q84worNVpRUdsuI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uyUtOskJt0K7897QzK4YGicC10WZXvsgRmyjZkBXNZuiS1/M+0E5nh++87FvcHeGoMfivG14gbxQO9JSQzj7ViKiCL9Kc00oLvKh9Nx6hL7gPVY/IT0CdEiquYbyeBOGH9G9FNFGkwky+v2fgObngsz2yB/p26gNzo8E7W9IOvc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=DIL4ieaC; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="DIL4ieaC" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43ed8d32a95so29508585e9.3 for ; Tue, 08 Apr 2025 00:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097917; x=1744702717; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8ycPhCwkmIeN+6silmLpioRHga2dgaX99hgp4Vd22jM=; b=DIL4ieaCv/C16PFDMEPaLGH6a/pJGBAOSuxnyh/gfzK2gAvZ5G9fkK6H8Y2yHstYnm /yC0jbMQdbHNt+KSxqRuov9Evt+w38RlCfjib7gkU71Q5e8rZ3d46oMDsiHqVLle6+cc 6G3HW3J41qZUTxP87BtNw6yaQNwEFckoR57iCRBXEh25R5DLHSUyHqvLEhAPvO+6TEB4 S0JpgCTsavQcwHhpQEOCFngQHvqo0BPMTUkeuectkeVI8KVvCeY6sanAoSvhh+ePw3Bz rYxPgryLLQHZXMdAzooNC8S7cblw4LIOh97WJY6kct4FqUPyQxA0lFjQF9BHPx8Qhg7d eefQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097917; x=1744702717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ycPhCwkmIeN+6silmLpioRHga2dgaX99hgp4Vd22jM=; b=cXGI+hWzpJvMHJ+MRaO0/kcCrLj+N5ax5JURBFfEvmPb0IgtyClBz6+e+QbY/IxbyF nlCvBjhVY39bt1YMMqHIrbLtJBLMKI0W7tpWMZc84X1sXeKbxd184oSxPt0YZ9c2oEDZ gMqzTqu3/Li+HEn08W91kGuMM7osBsBd4SfMdPj6QPh/G5WP3dRPg5u5iPASu8JJKGDq 79y5q5ISNv1vxpyjUHWLP36K14+h9Zy9HckhPeerxxtNuA7XvyykS0+qj5ESB2FWxt14 T0b0qPLilxSCdtnBUYPwkWP0GVgN8TCr+4zq8HcnatY1THrUMNURp2si/ZU0dHY5UlAs SRXw== X-Forwarded-Encrypted: i=1; AJvYcCUKS8Mn38NSZrUyRohjMH0YXnX9UW3PPqDElbZxekchNPa151EkMjcf1wcXRBQEFdWd3pRqi6O3YaH9LjY=@vger.kernel.org X-Gm-Message-State: AOJu0YwPr4gc/4RHUmAWCtljDQSzaDbuONwdqgpLFIkwov5w5uHFVYLo wwEUlydr6tatdNp2Sfn6Vr3zDBIN1A/BkentVuM2628mFaNUJHMUup3kJi9hu4c= X-Gm-Gg: ASbGncuXRKUROyEf9hqAF5qcXWoGP/tG3vX6lMlLlN2qbkm/YCAah5YoVCajTid4LVb GOFF1gOKISlLkTMSALiHF2TFajEG4e0x84GqvqBrpqzgf6GWpmXzB6jjniIgD4IYvqQIo+Dyetk +EWzY6tKw9VIjMj4dnkl1/rGrlKtgkompQDH4fgJtcFh5MMLU8yQBD2mKrMhurGATl1VpmGGaRs mPh4Wc0h/iEUyU/S5bgLBoRw8jUPfnfgO/zR9Gll1+UXipEfXloDg0iuOWTpJoiCW6ak8bbsFD7 AvZW++9PufZ+Aa8VY7JJmjDAOxG+MLj8goGQhw== X-Google-Smtp-Source: AGHT+IHONac7vF0smanIwJjC1sSegxVSDSxo0Fao4YOZkxOMnAFYYlxFn+VI5ZwK/8z6s0d03LQBFQ== X-Received: by 2002:a5d:64ce:0:b0:391:ab2:9e80 with SMTP id ffacd0b85a97d-39cba932351mr13076929f8f.24.1744097917408; Tue, 08 Apr 2025 00:38:37 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:37 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:29 +0200 Subject: [PATCH 11/12] ASoC: codecs: zl38060: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-11-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1748; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Y8rStYn67bqY0zwEQqMRWDBXvlszYOOAybVWufsDq9Y=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJwjVac6Z72dKQybQpKKwEA8WZHYgRpIphxa hSaGL3tAZGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TScAAKCRARpy6gFHHX ci2DEADVfFybRaZ92cQ7oOBFVA2hFlExzCCKSpX2hgCoSJtma3DxeUAAs2clk7piMxfEW6givsf Cq0sMl26CVRSXlohi+7FPbI0GkLdeAgiSz/MYFu5np4Aovvhw1wpWDvGCTQTvo4jpIdWfl1A6Wy I8aJQ1KDGInzUw5taXC4KYwtLO0GVBF7CuZdj1ruiBK8tj/+TO1J4NOkKFUygI/kPG32HPMrFqL XaOp8+UTr4N+cCbKUU2xKyY8ZhCZIwQ/nAoQzdLpgtMSpGEx4ZFUJoJq+QVJgo2FZcbUqOUPwG9 xJMU9UPLPhJzDxg3+mM0wEd6PU4MeIK63ve0Ea4ntwQ16w8iwB5Y0GpjdhFOQMAXr4LLUVW5QKr 2TnRV+MlZPW/PvPfYH4c0YUpFlNXyFW7Zv8zUD+TPpuQp+/s+BAqESXZj+2aZuFGA1NIxgFroaL yJfjasFFcxtr46w9GYibs8PCbGzHyUtzyAIfop8qXKBa9tx0GHFaDLkAHdoqnP36eNIfqJOxSVC h86HqUN0RcsuA7AglqIzpB5dt4RaofwsHA5artyBNr73MmgeXi7STl6x+Ozqql/iiQkLsj6ZJ+B xmOyZodI4alClQu56OtC0tzpjJ9qeE+aPF2Mziv1oxbV4vIrPYfkqJD/HKTp2uuDR6FouW3pb5Y DzegeJg7vkf9ljw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/soc/codecs/zl38060.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/zl38060.c b/sound/soc/codecs/zl38060.c index 28c92d90299e..180d45a349ac 100644 --- a/sound/soc/codecs/zl38060.c +++ b/sound/soc/codecs/zl38060.c @@ -387,12 +387,12 @@ static const struct snd_soc_component_driver zl38_com= ponent_dev =3D { .endianness =3D 1, }; =20 -static void chip_gpio_set(struct gpio_chip *c, unsigned int offset, int va= l) +static int chip_gpio_set(struct gpio_chip *c, unsigned int offset, int val) { struct regmap *regmap =3D gpiochip_get_data(c); unsigned int mask =3D BIT(offset); =20 - regmap_update_bits(regmap, REG_GPIO_DAT, mask, val ? mask : 0); + return regmap_update_bits(regmap, REG_GPIO_DAT, mask, val ? mask : 0); } =20 static int chip_gpio_get(struct gpio_chip *c, unsigned int offset) @@ -422,8 +422,12 @@ chip_direction_output(struct gpio_chip *c, unsigned in= t offset, int val) { struct regmap *regmap =3D gpiochip_get_data(c); unsigned int mask =3D BIT(offset); + int ret; + + ret =3D chip_gpio_set(c, offset, val); + if (ret) + return ret; =20 - chip_gpio_set(c, offset, val); return regmap_update_bits(regmap, REG_GPIO_DIR, mask, mask); } =20 @@ -436,7 +440,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D chip_direction_input, .direction_output =3D chip_direction_output, .get =3D chip_gpio_get, - .set =3D chip_gpio_set, + .set_rv =3D chip_gpio_set, =20 .can_sleep =3D true, }; --=20 2.45.2 From nobody Thu Dec 18 17:58:49 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D64A266579 for ; Tue, 8 Apr 2025 07:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097922; cv=none; b=m+hXA+cWCHXH1rZIikdE8MBa30eRQwGR7NXFNlsUaQO3OsbLuu+C3yGzCgeLkUU29+5E/G2uQI8CgXL9lM45fB2lvsBckdRqOyhjMeGcHd2dwtJlDSy4OORG2zDtpyfpEdUGLwIXmJi0s14mKHt8Rs+vzbxCrxr9rExduBsVDek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097922; c=relaxed/simple; bh=k5vupL3n8W6xhxCh+SyC2X8XDm9fYPVtRAm53auXbdM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XXKzPYqb/yI5nb/0Ogzn39M5cb0ZA3E+eW4LLgn9Kob3M+iszQeiTEy0PknOx9jVs/DUh2DaOaOaNYNe8aT5VXvzCPizQl4F8GRfhiRwCdReNWk4HAfdonC/4vJ6OjrS0jm/iL0zvm2kDEGlICvRiRr7inCD61y5JG1KpMgfjbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=RfnoV3MF; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="RfnoV3MF" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3913958ebf2so4619567f8f.3 for ; Tue, 08 Apr 2025 00:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097918; x=1744702718; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h8SlS/IkZp071lE3E9og/zyHpds+/VnXMpibkYRrvZA=; b=RfnoV3MFL4Kfa9cy29c85WT3xr2480s+FIJGV6eP8VpM+5Anl3aR6ejlpOM3XWqVd4 ouPn7VMmNIX27otz9+rWVdals1/PHcc58Bm5M6FnVMXjd7G/wu7ba4lxng2cO4N6KK23 kjbIML1ZnfNeDwIzXN/P6pxTkAMtJcP1A97Jw23x7vPlZF2yZiP7mbgx2vDvXVzPWKA/ RSsxDz37a6IKtmAQW5SSVXzk3AciwasBlJQ7GLwQh9WuvMLpKqPeKlXQMdZx4r2Z2RIO QmDEjZMIxTS2nnUH7ELmM8fBXEKNDY0H5yUiOfw+n1m8nsSaCU/a39Myzaj+5ht38WaH 4wUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097918; x=1744702718; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h8SlS/IkZp071lE3E9og/zyHpds+/VnXMpibkYRrvZA=; b=jX0uTFA+MyJ1b2YK6gBkgJ5hUrXwVNbJ5y7bwdYnkwoKP79Uk7YR+RpkZmRHEawnRz OpD0CrLIwHl4PXL2cc6LjLHtYwP4YUk6dfUII+coSM+7QQuds+dm6IKUyrIgTFB36aAO XYIPWkcQNjstUejGw4R2R4aIVyjo2tlWb+5s4CYjcNZcL2s3Ln40JLWpn4kjMVikcDtT Qi/tOOVZcqA/2e31paNEMICiFx+yN6rzuYnfA6JWv5ctnpnkV+ItQn3sph0a/s8J1GVT HQ1qWRhiJtSoANK4Tw+JHIKdmXyPEplaReQ6btSiNYdajB3GU7MhmAtfOrftFbwuhqhe bVMw== X-Forwarded-Encrypted: i=1; AJvYcCU3/jwUf6OX5yDQT4LXMiuEXEyFZ4M1sGjyfe0C+9mPcpzYWK6OLJ6Ighew6i8oxg+fuWKBV+VAuuThbuE=@vger.kernel.org X-Gm-Message-State: AOJu0YxEO2jR3xoGn91LBqULlnWERyMXM5YS4yVs5UXkZPAwpThG9R5E zQgANzm4k5q2QMtzdFL08UOf4VhQZ25dNMCCOqgFcJyv9Hu3+0MgYkDoLtLYjFQ= X-Gm-Gg: ASbGncsziLKOSj6wLJchM8rBT3sEygrjaDXSKuCxbU3qAeIT0/swc9vR/FgIOeidtZY 8jWLc+CekhldkuR/kwsD3Vpyd5zp/Bv9Wm2G6l3iYlZd7UlbmQ/qcLIZympyqY4htjG0o4/L5Nw z4DQ9ylRJi/FWYq3yGNkp2xj1M9jo4EZrgaYuq2Doz3KDX2H0Gv/XQXqeYGJkp9hzMV63WIPklj LpAGp9Of5vI4BbJoUKO4BKXGeYdpfYj18DcONP7NJzA1aTw37WKU5bijXARaQD98ZKwyEsSd5yc 5jShAG8mN8PP7sndZYz1NUrleLDfjoI5aK30VA== X-Google-Smtp-Source: AGHT+IHVdtfNRfLocT4pHHsOiqn02tPEY93VHOwmAXBlq+2rA/lzXOJPZsDShMGFqryxs6tz2QGDeA== X-Received: by 2002:a5d:64ac:0:b0:39c:30e2:7218 with SMTP id ffacd0b85a97d-39d6fd18da7mr7950301f8f.41.1744097918459; Tue, 08 Apr 2025 00:38:38 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30239813sm13892137f8f.101.2025.04.08.00.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:38:38 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:38:30 +0200 Subject: [PATCH 12/12] ALSA: hda: cirrus_scodec_test: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-sound-v1-12-dd54b6ca1ef9@linaro.org> References: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Peter Ujfalusi , Oder Chiou , Shenghao Ding , Kevin Lu , Baojun Xu , Herve Codina , David Rhodes , Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1415; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=rJRtEYixkAn0Lvz429+OjNvyXIZi456GPAqjVX8W3O4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NJwI/hZOWHfYBr33xc/jFo22uwFnmFIPdbf+ J9uXUBFm/aJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TScAAKCRARpy6gFHHX cqwjEACvzCz5vMpsyV0eFMubArpgGfUHrYcBTu/vI58XoaaJrRn6ylJU02IuFBVJaa5+eC32fmc LeFZC+OrR60DiWJtEjo/5ufTYHkBsu0Duf6YlDqwrVXWtmorKtatl3IdUZ97IT8uTp48A0VUAtJ YCPg0oC6fqO1nhGLBID+MVWX9YZeQlhvCXhjXY+oKJSFyonfi5E/kgxp3LXsDQHLUEi7jPjm+IE m4CQlrFVN9jsuyxcnITLxaZwcR0pFikCUgBOmc3thh8AGN8XClJE29KiAlmzr8xYX9QQiPR7TUI g0y+HDRsLMDLxf/laKyhfA2VjIRQDJio2AqFsC/nYR7dskvaXMBvusg0UuHDaM/fuWNs/15hc0p nihBNDylEpDR8uvBW+sqDbrDQudXFEyqTGU9YOL7N9mbKXoz4ycJnTefuXhpVAKB6ZgTU1AKRFa jnzYIW7AR42ow5fP1RsscVOzST5UWek2PD6tcao2PMjuwEtRX4EIe0QkyhuyBQFsEa8ItLt28lQ McE91qVbvCciWGo2otcSOSO/5WUse8WUJ4ucHJMNxY85Bha++zf8tcV66fyQ27v2PtvIpImJsAT l9VG1ORxh5A0uzmB1wKPSgHCzVYyrARLAnda/TtgHjuZ5zbQWBE65406t1rwp4mXqU4YCItKDcg mOTziCg3aSWFCIA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- sound/pci/hda/cirrus_scodec_test.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/cirrus_scodec_test.c b/sound/pci/hda/cirrus_scod= ec_test.c index f5d6241daee4..08b0bde1a461 100644 --- a/sound/pci/hda/cirrus_scodec_test.c +++ b/sound/pci/hda/cirrus_scodec_test.c @@ -48,9 +48,10 @@ static int cirrus_scodec_test_gpio_direction_out(struct = gpio_chip *chip, return -EOPNOTSUPP; } =20 -static void cirrus_scodec_test_gpio_set(struct gpio_chip *chip, unsigned i= nt offset, - int value) +static int cirrus_scodec_test_gpio_set(struct gpio_chip *chip, + unsigned int offset, int value) { + return -EOPNOTSUPP; } =20 static int cirrus_scodec_test_gpio_set_config(struct gpio_chip *gc, @@ -75,7 +76,7 @@ static const struct gpio_chip cirrus_scodec_test_gpio_chi= p =3D { .direction_input =3D cirrus_scodec_test_gpio_direction_in, .get =3D cirrus_scodec_test_gpio_get, .direction_output =3D cirrus_scodec_test_gpio_direction_out, - .set =3D cirrus_scodec_test_gpio_set, + .set_rv =3D cirrus_scodec_test_gpio_set, .set_config =3D cirrus_scodec_test_gpio_set_config, .base =3D -1, .ngpio =3D 32, --=20 2.45.2