From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 864054CE08 for ; Tue, 8 Apr 2025 07:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096877; cv=none; b=gZ94dTeCipoQJYZWiEqkYSE2ckCMZvAT1KTRSHB/fvl3o7syuZw3r4Dt/iB/MFT6swItNus3XMGr+is2TjyDAbfdCjWyqYZ4AlG5f7YcRTA40+nrlbkrEC3oxDEO7v57e6AfdG/n/SoIGB7O8xu4P6bk5+DFLMOLiF9g+l+xHSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096877; c=relaxed/simple; bh=rCa8o43PCU+Q3/Q8/g6YbDCo6E6p7FBCgwy8cSfadu4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gjMwRhPtvEnZOZqX84QspyTMM43q0aC0vUj3XBH1+1a/DOnWs1mTOwkdcAmep7eOaPHIybOMdeUcQDWQ4X79qhYs/VGBy+CME4VGoysM9URzlS7aDzxKTFmab2hWoBN5zozsuXk+Y20LQLGTOlbpJsCoRw8Q1lI8zELJoqWqZLM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=n3GEVPJ6; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="n3GEVPJ6" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso34152425e9.3 for ; Tue, 08 Apr 2025 00:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096874; x=1744701674; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6wE8TQ/kC5Gw6LravAsHxdU7HVea2/Xz35EGN35IBRE=; b=n3GEVPJ6zWSCmcsYKx7yLej8EQLOsVJ1OFIGsodl1geSBYtnTz+TbKqFFYAw2eo7E6 sIx5VA5k9uWxHq6FzpW6jxcBrK4nmyjcWvx+R1l12q33es+X0IKys66J7tTU50SrhIVF ffnf16Q6vnPh0+0tYS2VgR6RtwAbLuFm0EacMrejfEaGURpasFX+M9hhqi5wQ+AnFd2s pF13QydxKwOLhT5rAFAGXRRJBmrdf9bfucfHGAVMdVa5Yqi69TW5yCBdJ49IeQhUuRvW A26hLoax+dqfDbO5l1Ri09GFBwhV0l2bIWMjLElGbgg9OSwG078Qy/cnfxLpv0m47Lk2 92Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096874; x=1744701674; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6wE8TQ/kC5Gw6LravAsHxdU7HVea2/Xz35EGN35IBRE=; b=LBMKHurW3Obqj2XU7S4qD/dwWK+xssrNt++RL+obZXHan/vlGwL9H+4cMcVuYVTG2/ dnY2l/ofWAqyvUWKCupWb62d2UDDbT1P78kEj41Xwc4UiZmiuqS2yA1i0uKE4WcDzu2A ltACKvjn68JbVWxav+IbECuLfiwWOg0hyfHHfoSRccoN9wqNk5EiRPQkpA/8x0dF3m6L NQyHZlKxIlDXalfzDR13C/KWMN9rnrer7AKnyhBtimvyrBNu//bwauaD5lExncy9QxhU axgx91ycSFKS87tbgusIK2HlSPOPs9bkxj9b+y+xs4yJtiTmrahiiY1cDIGOKWRypBSU 5ZOQ== X-Forwarded-Encrypted: i=1; AJvYcCVp6qWdx8lY+/8vsqPMUuTBfYuI/3P2tZlt712h4/qJnVLQh2Lqbud/JGhDNLu898B9g3zgrUGZITfXauI=@vger.kernel.org X-Gm-Message-State: AOJu0YztKuiGG01CZdrtTuwzLHwqZeQZmyvOumiHpWmgetIpu8CHEJom ODxHIUeg1kQw/EMeANrPTC9KKbDSi6Y1JO0vLc9wlYYr6FiUqKWbRFaqb9cTOaU= X-Gm-Gg: ASbGncujzsSpBBsrEd1Q4bewadWSbHJshx0GN6jqQyUMf0yY0u4BDT60xbAxglcsdYy U8H5MRtevg4EronIDUPPrOdsh4xACivmAMAOF4YleecsA7pxxo561SPqGx0tN3o4bFlp1ijXoWh 5QCGJJjzhE3BqnTwKSn8pCFMJraAn4a78Moap/g5gOgu3P3Cg1852xENBbvmxWhI3K9uuplpJKf 1y4xSL2n7We7/Ndg20XL7lesnBygOhMprZcqbv0purvDS1aFg1HGWNTGSVyW9q1uSu+aFMuzWEf c8pDCdAYCMio5r6oLGLh2vx6YQAhdLlk0kR0Ww== X-Google-Smtp-Source: AGHT+IGlERrHqVi1qC8FfhdvuV397D2yqL6s1YKuhUH7GEN8bWhP/1UK6ZgmfnUxwxq/O6rNRgufNQ== X-Received: by 2002:a05:600c:198b:b0:43c:fae1:5151 with SMTP id 5b1f17b1804b1-43ecf9fed70mr120686755e9.25.1744096873779; Tue, 08 Apr 2025 00:21:13 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec342a1fesm154404135e9.3.2025.04.08.00.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:21:12 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:21:09 +0200 Subject: [PATCH 1/5] powerpc: sysdev/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-powerpc-v1-1-73dc1ebc6ef1@linaro.org> References: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1582; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=i76qJt+Prqn6FRHBSKnAuC1THRUFVaV9XqqCXjg0eY0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M5mUvt+4lLGPJCp7pGcUJyi3hfa1RzNMiZSk SZvUFz9DguJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOZgAKCRARpy6gFHHX ci49EACpix94RiRhas3jBzoubO7P2DaiD1iTemCLusg5lAl2gI8c3y5nVaHmJL1Gjj6vWvQI4Fz ifbjRgY/H3TcJ61f9NDS+Rg0PZgEUGamwwyBaUHwh++ghPvV2TQk7sgh843biDJ/svliUX41LFy cAWB54sEvynIQ6XKNELIZvx4CHHm5oUdJmLRkRS+EGbcWmmzQMF+/wH6YuZ8B9u4zuGqhuJvyk0 ygvfj1ao7GWWqOIWex+pJNBhid+tra5Vx8RboCWRFNhS0F4BHjEsin/gCnZNYq3EHfMBEwD5VPs qYm1w/Mp0Z/RpgVtT8lj4s7O9BzPRlvbKkqAznjKaS6m0O/8h7WnJMlThB27vCy6FBimgXKax34 5aDjK+GalcUNKpJDuYQ+2+MzSK1n5X8X+tBBYF4FS7u0UOFIQISgZJ5NcGaYcOgXTww6OSV6EoV ryoVFRuGfFpuaA+H203Rq11yvGzYQFUAJPDOkUrzGrLV2aUcahCv+lAXTpwsKn1yuw8YBrz4eqr 1RfGYuIXMZHdLm01+nyz1/6pFME3V3KXUej4ekjMPuqk9imHyOnFMcs0dQG2GhtBspFHtUNhKO/ 9hy2Ub4uqPQMlrUaQmBxun1yvG/j+y2es37MygmZzk2V+4WDnGOV1S4IatJqadFXi9zc2SQaCxm bEe9bf2DxYVQy0w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe Leroy Reviewed-by: Linus Walleij --- arch/powerpc/sysdev/cpm_common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/cpm_common.c b/arch/powerpc/sysdev/cpm_com= mon.c index 47db732981a8..e22fc638dbc7 100644 --- a/arch/powerpc/sysdev/cpm_common.c +++ b/arch/powerpc/sysdev/cpm_common.c @@ -138,7 +138,7 @@ static void __cpm2_gpio32_set(struct of_mm_gpio_chip *m= m_gc, u32 pin_mask, out_be32(&iop->dat, cpm2_gc->cpdata); } =20 -static void cpm2_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) +static int cpm2_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int va= lue) { struct of_mm_gpio_chip *mm_gc =3D to_of_mm_gpio_chip(gc); struct cpm2_gpio32_chip *cpm2_gc =3D gpiochip_get_data(gc); @@ -150,6 +150,8 @@ static void cpm2_gpio32_set(struct gpio_chip *gc, unsig= ned int gpio, int value) __cpm2_gpio32_set(mm_gc, pin_mask, value); =20 spin_unlock_irqrestore(&cpm2_gc->lock, flags); + + return 0; } =20 static int cpm2_gpio32_dir_out(struct gpio_chip *gc, unsigned int gpio, in= t val) @@ -208,7 +210,7 @@ int cpm2_gpiochip_add32(struct device *dev) gc->direction_input =3D cpm2_gpio32_dir_in; gc->direction_output =3D cpm2_gpio32_dir_out; gc->get =3D cpm2_gpio32_get; - gc->set =3D cpm2_gpio32_set; + gc->set_rv =3D cpm2_gpio32_set; gc->parent =3D dev; gc->owner =3D THIS_MODULE; =20 --=20 2.45.2 From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486BA261587 for ; Tue, 8 Apr 2025 07:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096877; cv=none; b=M9R+vryQ09ZomgHeRcVhUDovpEX+pKxddjjWKxGmeqPjXw2SP5tSmCEqep++33aqYLGB4BUvOUbZJLFj2ZEEvj6XuzJJh8zft8B9XnhXyQXhIsn+b2FtIxPAXVx4ZSrX/DAgN0FVaibJvw4Om8+dvYxsB0TZVQdrpS+E5citKAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096877; c=relaxed/simple; bh=PUo56Q2yzjhFctr4qJbBVg4rRJDOKkYPse+T2INVimA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LL6Gb/El9m/3ACZJzKHsxAsfXksuM2ueS3vFG0/JyX++lIO/QisszANVQZ6H9U3dM/gkBDh2tqEftfVKvCGRQK/SskKGKfmFxFD0Fzktv89S+1Bi98MceLTQQTmyDB9IHXUhU/msJyCV6bJjhd4V7Q2u422AsTvA3hySL9Xf4bI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=v2zFM1d+; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="v2zFM1d+" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39c1efc4577so2831156f8f.0 for ; Tue, 08 Apr 2025 00:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096874; x=1744701674; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9EKgQ1cgxpU6DSJVVu3CokqxSFGqHBUMN7AY5XSvKwI=; b=v2zFM1d+8ZszMR9EihxGe/FBGY+JPPpsc+/6nzozbkgMILd6UOc+i0vd0+p88oPn0r lrk+psdo9IF/lUl8TRA0u3sJERmPfbEybrPRgP80FCPNtGcEjGNZkEJMMxImY3LbNYUN 8QKLMwQ+pkFXEXi1IqIr80qdu5fxpH35UNKYtbE5UgUgNJq1cUpacAEcvRTZ9yHbl4x2 X6EzBRpkUO/dTZ1KxIX8zaIeMGsFlfEsv29CFmT0WYy+6S7y+Far1Bm0QDDwR5et2g+w nLbmQ131DuBcIMS5YDGMOEcE7CqzV38EvyzQMvGCuAUmnOG/HEfU1ZN+Ol8V6Wr5j0wd 1Liw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096874; x=1744701674; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9EKgQ1cgxpU6DSJVVu3CokqxSFGqHBUMN7AY5XSvKwI=; b=b7/uGQA/EupZfvfuUN3dTK/T/Pfj25CrQF9oX9g1DZIlRDX0CpYx/A0RPYQ6gVKfxo j0IwuT4eZd3phNhqejL5n8LJhAcrOfTVXLz7qnLADKOSh8rRuM83zCld6+yMSvo9Sqle +I/gzl7dofB4Q7elfRmxh/NLpbp2xPSCLo8DcjKTZwxxw+a1wkYJ1NIqobbNisjQe+5B GPju+bTBUw/mUUNW8E1uIQZ0jSKtZszATG3MxYLJzVv18CopY7VyO91XN5P11LVNdNmn tPIdk+AWl1RAsCVf8E3jyFiPprzg87Vr+QH15omqvqmBmFpb6T6QVNo0bq42KtWV4Mv/ Izng== X-Forwarded-Encrypted: i=1; AJvYcCVn9N+XppbegBFyrGpyv40v3zfvYd2uBpmfPc6vcgRyOmpitzxLfUYkiX8BPFa7gH/0zVliHTnXD90Xcxw=@vger.kernel.org X-Gm-Message-State: AOJu0YznRT/16bK7Nm+RfFNBkXkpO9DatDT6s58x6DmI4UkSL0TlCunt D7hU42rspN/g4OCmIaj0oF8Rpi5nJeNmPVIdCxv28+w8PHQFX88v/kD+x0Bxszg= X-Gm-Gg: ASbGnctPz8J2vlDZzqAuF1WHg3Y97ufRIbSAAas3KBWPC4GFExvSP/cdD8rcn+arDiF vuDrB1CEefjuDl11Ux45wzuT3MpC+GMo/o3/senbTuWjD5ArkF4efVjNcs1uEwRY9hEnaC67Dgr XfC6VyXIrL0GW2Bgy6BUHnktsv+H9y6CldUlkawz+pZ1osySe3gGgTkWVzNUucLOzDHw7kgamq3 9Vta7bGvk6bwIxcCsCfH8ky9klWYb53m2qSdeEsU/zg+jBkvBjxRRhccVV7wStqYUtPCLDmz7xB yw9qndzmOdfZ9LbA5yruU4P1d+fIhhPKPNKTlw== X-Google-Smtp-Source: AGHT+IGfBvpH0yFkliZLtXlbOsc/im0FjsnYwDk1DO3Fnkg/Amyk0+BzHkIllruNLf+k0vJRb3h3JA== X-Received: by 2002:a05:6000:40c8:b0:39c:142d:c0a with SMTP id ffacd0b85a97d-39cb35bda23mr12921572f8f.19.1744096874610; Tue, 08 Apr 2025 00:21:14 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec342a1fesm154404135e9.3.2025.04.08.00.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:21:14 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:21:10 +0200 Subject: [PATCH 2/5] powerpc: 83xx/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-powerpc-v1-2-73dc1ebc6ef1@linaro.org> References: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1493; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=T4A59REGiz5eXob5HMd6JwbPWhPT8lTp1DmdLIdpCvw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M5mXcX7kY466l0OiK8NIg5nd6PegVrBTz5Aa R0NwF85CWSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOZgAKCRARpy6gFHHX crwFEACOditebqDnaphThATlEMjgOgAWyDQeAEeb+QxdPhrDCGrM945fOgEEDGXhJGdoD7do5iE Hz6qaTwsLtEacAQodx1V+cgO+UD/vFMjHmaZZ3Bg52U+0J/qzYK58L9l4koz+PARYWiDbcNmQIx yu5/cZhXO+enA3bpZPQUcKmDtfOujhymNXkYMzBfZVv0sBfALvPPkv7c15AOlCtwVUvLwzubEiJ gNYvdIxXjMSzhvV5t+KOVFZpWbv0smNiEp2tNOHU0DAZZ7ogu03DBk9d9AscS9tCGF/1a6pWueM fzvvLxDfmPqXTrW1DG4fQ8Y36utZEXUfpiGAPqYsjICMIwmMYaxYBLIHTmuRulXpkrdErKJcwXN oM3jjdlHR6TpE4w5cbXxJY+tl1SiGNA0xaZZSQj4WCpTKXxH1qnqeNvImuYdQ7Im8665DuOIcfc /OYBh5JBhAZPqe+JlDjrQpQUTqXDT2MM6s/d7JJ1ys8EwTq5KY3EZaZAorGAGCsAmscyuz/uefG QTQJS3NFuVkw6wzzSFFHTUm8hz+PVpLWLnhoZOXLx8kP8ljszTFiKp7coboOT4J02tUzkWzQ0Ue CM+5pjZQ+VmDEp9OswqiqyPLiMTIGPgCBK7L3F+2CIwHDk/lKvNn6nZd/Ktm805r2AJOItWe44I 73ElfPLII2F36nA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/= platforms/83xx/mcu_mpc8349emitx.c index 4d8fa9ed1a67..d4ba6dbb86b2 100644 --- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c +++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c @@ -92,7 +92,7 @@ static void mcu_power_off(void) mutex_unlock(&mcu->lock); } =20 -static void mcu_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +static int mcu_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) { struct mcu *mcu =3D gpiochip_get_data(gc); u8 bit =3D 1 << (4 + gpio); @@ -105,6 +105,8 @@ static void mcu_gpio_set(struct gpio_chip *gc, unsigned= int gpio, int val) =20 i2c_smbus_write_byte_data(mcu->client, MCU_REG_CTRL, mcu->reg_ctrl); mutex_unlock(&mcu->lock); + + return 0; } =20 static int mcu_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int v= al) @@ -123,7 +125,7 @@ static int mcu_gpiochip_add(struct mcu *mcu) gc->can_sleep =3D 1; gc->ngpio =3D MCU_NUM_GPIO; gc->base =3D -1; - gc->set =3D mcu_gpio_set; + gc->set_rv =3D mcu_gpio_set; gc->direction_output =3D mcu_gpio_dir_out; gc->parent =3D dev; =20 --=20 2.45.2 From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5673F261589 for ; Tue, 8 Apr 2025 07:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096880; cv=none; b=GAZBfaZ7aYau6t2hiUDsZjsgVO5/zvz+C+pOVhv8iTDaw++PFp6wH1t7YrRvcUFt5pIuuTqTANDwdKXSFNAVoBOqjJKc9kAaTt8yeUfZLM/OaSk1UGSYhcrbO0w9W04RE/b7LkFhdCtZM+Zl+oh8rgiWGv/NUnscT6OcotYqOb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096880; c=relaxed/simple; bh=Z8NuRiiGre336HaXLG/p2D9NiyCslGW/FZNW9rsdegA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VsVUHGgmmvksWyZdC4Ms1NM3AmKNm26G8Ddgz9wQ1EDn+9dcVvutJCEfcx2Ji+V+ZaQlkMT+o6LxODQP9wa4kxRmaOdpOV7ZY+sWC9o4afcgZZogt/uaqZknaBoRCqy2OwRkI27260qogEvrQMm9SztizMxxAwwwSOc4ADJlFeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ZIIVnpyl; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ZIIVnpyl" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso48081345e9.2 for ; Tue, 08 Apr 2025 00:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096876; x=1744701676; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k5VNPwmH2aw3WXLnBPncXSTUgUkesspgvkr7nkorUo4=; b=ZIIVnpylzxesCTIqs+EPKUi348pnFN7m+yGw7Fjp5hj12zguTNyQNKrW8ccnCw6zdZ BYQMkWzAPBWcgilvs4dK/weYpHLqmMB5IbOPv87Q5CbaoHLhP6rFjSJIXt/6f1Yc2bmv YDoer9pusvy5G2EQQKxKuIX+F3BFg4qI/TslcqYOGxZOL40P5cM3JR4pTUT5GLvMd10w H1eBIRsWeLWQ8Rqq/HkwnJV8OmliUYldt2/6mmw52kN1VvOrCvVfPFjdMhwMrDKqo7Fe 9M4rk7CP66alTs+D7lWEdDYLi8CEg8R6ey3ykQw0GZkvxz7mD18ckKvsUkkWSul/xCpP 6aPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096876; x=1744701676; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k5VNPwmH2aw3WXLnBPncXSTUgUkesspgvkr7nkorUo4=; b=xAJ6esfrHXsLJiUTXAJGevQR9DWWMLk6vilwAd9Dr27gSR1Rhn2Z4LGhVX+lq2q4cO STn8Pll0lElwg+Y6CbMDvA3b9OMY/xbfqSJk9Uw0GkA/pHbREB2KDecs0E5Ya0d/IDhs Xh0u2epwncN9/0n2ZwgNpE8b7gNQ2+rbTfQl9dy0qMeoYVr4xmo3eCDl2GWRQNq+SyDO p0ujHMsYJhNJS4nU+wzkWho5Fy2dY1A7M6te4tYB38WLJxRpRcnmnXXmrlbLiKaoMH03 tK2sliyD2jQVWq9ky1MqVwjLVxZXiGl/MErujRROWo3VySES4BKspe9ixAGoCWT6hBBf VJ9w== X-Forwarded-Encrypted: i=1; AJvYcCXGKkDwwgwoDnQCTVF9x9reFqlxccXo28eLwqWetf1uVO0vv6VW/PBNYsGm/uKYi2GAAHkLi9sFzHkcpTQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yybb06+ZhrIUFcgr7l9Ug3y+OdcAFNI+YENP+iqY0YlhsKlnamr Lbtt0Vr96RZYlz/8VETIr5nE/zsuFu6vBiBuqiMGp4IzEdcZUzZFZDWHioxj8i4= X-Gm-Gg: ASbGncvDqmmwRiB2s5oaKO3xWutoVKvLMsMSTVcxUowdoc0F4BYjFDiCnDULTDnV6c+ eedUQXLkfSb0NEh5unM8nXKzFIszaPJlGPspd1ysEoCNp9l8/fPchd/FiIwdq02vD/q4GrmVuDS UD2tYP1FJ2i81zwYWyypbxz4RS/FHmQHZXWycMAu3DidaLJGS7Zoc4YNTPwRcpGoPlUENAjRnoz G5/3SRGHVPOQ5goCp/fgi/gouk+hRW0TqNrpB/6ylZdxjmltCCAAyYLETt3ZHYiDqPvS1/A1lg5 ipbo2U57JMbruLp9EBvAoNOiR8/kQRykXd6Tdw== X-Google-Smtp-Source: AGHT+IH4VtW25T5J+PjGlIaZ6M22QPow4uOtnfupdUllT2Fkt12p4tk7DF0T4P47TDZZTHY0VBHcAw== X-Received: by 2002:a05:600c:3103:b0:43d:300f:fa4a with SMTP id 5b1f17b1804b1-43ecf89dd3emr156314595e9.12.1744096875649; Tue, 08 Apr 2025 00:21:15 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec342a1fesm154404135e9.3.2025.04.08.00.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:21:15 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:21:11 +0200 Subject: [PATCH 3/5] powerpc: 44x/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-powerpc-v1-3-73dc1ebc6ef1@linaro.org> References: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1553; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=LL68VEJKE/MtZ6G9TyrymTnHIDLdTmXeqNGFDYstqEM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M5msWyg7dgLldXdctL+ZK3AKOwzmS8REEK9k 9AhwWrSKiaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOZgAKCRARpy6gFHHX cigSD/9n9tAkmdjxn5eCjtFyUMEDYwobZytzV5we7jp4QTTClSMwVsjxPVdAuelo19SzpC5P1u0 M63rtFA7UKIfwCv0qVMtTIjOfE5qekRqcE3rpWVC57w0YF1CCGAPPzX4gSvo4ldTxlu7j9Olyrg ZQn3QFnmn1IZKayoceAC15tLVl/eZ3IIX19k0JbnpHAUOesg3uiENYp7k5EMprGRKfUJp9sVGBi jw84x4E9W3dLHqOBTZgyxW8Ro/FZRteiUscoL10ecKjUZZ9toN1tt4dPuJr6U0hoGXZoVudteyo QSuCQ0tEqeHw4rm+fcKwwN/uE0U5ytmA3sr/g/eKPGTI487XQvuglX53vuusbrdEv8QlU4d3ReS Swe/4oyn+0HH1lqg1HVljkPFwE7PLSiRNCC5zvR2mqieXeCtTGiml4ml3rtCjWSnuwYP31q8ceh pDDlxxguynZwDlBEAy0HRpWqynT06o/p2vpwEpHkCKj71/iV/+H/3obtyjiI5e/WfMNvDBjszrg fl6TFPIiat950nUVd8hSd5ClC2Q8MY6OaTz6z5BdELRjbZy7cy3TDLR9zL+yfbANqQyfEVoJAWz wayOYSs1wPhwIm6pa0PfDng2DFrmIImzJSvnJrJTXLCD6abuuSpjIY7MGu2mTBoj2F5pJQiRBIh h/cCOIUgu6sJ2Qg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe Leroy Reviewed-by: Linus Walleij --- arch/powerpc/platforms/44x/gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x= /gpio.c index e5f2319e5cbe..d540e261d85a 100644 --- a/arch/powerpc/platforms/44x/gpio.c +++ b/arch/powerpc/platforms/44x/gpio.c @@ -75,8 +75,7 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio= , int val) clrbits32(®s->or, GPIO_MASK(gpio)); } =20 -static void -ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +static int ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int va= l) { struct ppc4xx_gpio_chip *chip =3D gpiochip_get_data(gc); unsigned long flags; @@ -88,6 +87,8 @@ ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, = int val) spin_unlock_irqrestore(&chip->lock, flags); =20 pr_debug("%s: gpio: %d val: %d\n", __func__, gpio, val); + + return 0; } =20 static int ppc4xx_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio) @@ -179,7 +180,7 @@ static int __init ppc4xx_add_gpiochips(void) gc->direction_input =3D ppc4xx_gpio_dir_in; gc->direction_output =3D ppc4xx_gpio_dir_out; gc->get =3D ppc4xx_gpio_get; - gc->set =3D ppc4xx_gpio_set; + gc->set_rv =3D ppc4xx_gpio_set; =20 ret =3D of_mm_gpiochip_add_data(np, mm_gc, ppc4xx_gc); if (ret) --=20 2.45.2 From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F993263892 for ; Tue, 8 Apr 2025 07:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096880; cv=none; b=WJyde6BuE9d4/HITWRRyTqlznLIM00P4KAYWv1rOFfMmHEXTNNbWe8anUufr+vsOJT3GEmnFCUm8lGODGh4NSr5q8mwTOmSN2s07KAR55IPDel2oEwA9dPdm46vUwDH3whZaJF5M/avlIaJEeksALzA78WTvwcq1mU7k2KX48es= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096880; c=relaxed/simple; bh=ExeqpQJOlBzFpXFbPqDRMvjXumW+0LAUpb+LYyPognM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nLzz3qlmGOBVNmIC+YqE9Ym8eZyVZNhicFKCiwutcqJ8JlY04yDPOaWSWrc/D3s0lrtbEzyLrRsf3XFE1n4jYRYlpKBSuCxLTrqp8I7OUE7Mni2RZGNnblMUr2vyXAek46N7kLSxNtjPTKcNP4xOfxUIrjBLvctuPZjad2y643s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JNH6rl3w; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JNH6rl3w" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43d04dc73b7so56761125e9.3 for ; Tue, 08 Apr 2025 00:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096877; x=1744701677; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A0cSllrBnTQSAVrux+ZYY4miSWlQmvTzHbS9nTbIcjU=; b=JNH6rl3wpXBzqJuRUubAYjikI/sm9g6SS/hAVsu95KrCDbi3kR+2dfoD+Lu9Dij6Dn pfLChDRvCd06mEvUalceCd+OTgaNwY3J/U1t4CxL3MTUOY9q5eRINszhUeSOGdSNqEq6 45IKKIXNZEdQRdDLv86/rPmIcumPSGwXkB2YQf2m4OAF2+4NAzWiurzLHm6Q8lsm5eiK sHx03WruXnpXjMpP0S5og/JQa91HA1N+O+8dsEvukNUIy+zy6wpy2OfAvPUf21RFgH+O Krgx7zrHiOcJvhMS8N+fJSsYBz42nv2fXzI1LC57QGNxvdz3mHgQ6QORodhPdQ5JNK4z +t7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096877; x=1744701677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A0cSllrBnTQSAVrux+ZYY4miSWlQmvTzHbS9nTbIcjU=; b=A01Pnrx+OUXOnLhBWspXKP/WInrdW4f5OgYchH+UsQWSDDzbGOg/yc/BPZ3n5OuB90 snfYXKVJDn/YhT1uzyqidvvVMQxTjfACtTpgkM6lKqORS09G9GI2PuZ1kI29nAlOZ44w 7/1C4pvSShiVAoEOXiNFvLP+ulqoSL9MKDjHDf4Xf/S/OzYRCTO9I9PMF9LsSdzXRG5Q 639412UaEVQUq9hW+MUqX4xJa+QXVv4mgfY53IdNIlSTc6ZHIpoNPhEAWNQsj7QRcBdV TgsVvfbwX9j1FBx+uvjkf6UYtVUev+eTO9SeXTuWLkiholE5Ulo4JQgoz9/mdncxyA8T fSYg== X-Forwarded-Encrypted: i=1; AJvYcCXi96B+GbDB1Q+XASG8tQrn4ttyzOrA1AfzZi7HhB6BkUrYZG6VjYrNLjymU1GTcdh4o0AqbIZvyIU/eQc=@vger.kernel.org X-Gm-Message-State: AOJu0YyjrxHZvMaC3RseXMzoh6TV1/w9tpeFLRpgLvEPcSJ8qrSvyJoq yJgs1lM/JM7zRjV6fdmJAHSEpnoo59kqrkVIMY9l7QdY5R0OGj5DyHlf+vxueBQ= X-Gm-Gg: ASbGncvt7VdgVWpFxXzJhcq67uNsl/MeMmsZOTsvksSqRhyhwjRVhI/2ZU1phHY7or4 FN2EseLTfkPwfmTc4VEUGxE3bHsv2zJaAVWUJEdTQ36fL2KzleQcJahApLqe2VNE08UI36CHrdz JyhFfvN8OISlYhsSRTEp+nTCqi0ejc1hYh4Jr/LHRy6KbYaAr5KKNKWesRtA2kAj/oGCoFJ8dE0 cYdUABevy2xWJuM5sAupRpL/EjsPYZCqD2vAZBLdqfi33Hfzb20YLSv5E/NdnQixbKt016fojdE 0cZxBu1oji9otw8LZsnHKfw96V3W7lb1fsHs2Q== X-Google-Smtp-Source: AGHT+IHxFkxaFTSuHg6XALBk3AAm7ho5zuZR9ashDUFieaG7O18TykGWwZO57XfJMNPuLDY705cc5A== X-Received: by 2002:a05:600c:350b:b0:43c:eeee:b713 with SMTP id 5b1f17b1804b1-43ed0d6b07cmr111746535e9.20.1744096876732; Tue, 08 Apr 2025 00:21:16 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec342a1fesm154404135e9.3.2025.04.08.00.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:21:16 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:21:12 +0200 Subject: [PATCH 4/5] powerpc: 52xx/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-powerpc-v1-4-73dc1ebc6ef1@linaro.org> References: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1625; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=bkSnAWn1tiNFi+Tzj5ivTeMtlGuzsIZFtgns6Zf14Mg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M5nMXBRd9uglf1v9JiIXSvv4QhJX+qgqtx4m oLBvLI77c6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOZwAKCRARpy6gFHHX crylEADOeJxsWbM8Qlpy6KWQ5pDNGZ3Sy1k7KSHEPtibqX4pDvTT+rvmj+q5af7AgQhGAUKw60n LoN2ym6kJ2RXpauVosz5GOIuD6As//tXeflYzn4L4q7tSQ1ZA6iCGZbGotMwSu8NwBHyXTh7iGw p8nDWS/nYvlDuiCHYxbe2WCCbgybgMj3XcjObVtwCetpjsE+CoTEj3zOrqTngJegY0UbSin12eq HVwyU7f+GzY8meh7nWc0FgPtjEShmVm8VVoumvIt/q2ZxUFoHRFLJEGd9MfiGlbKxV1T+bg8nbD 9YWAAOGffBxFue29AEjZ0S0Ciw/B1mdJZ6/1E+gGLsmkOv5QL/olUtd3VKu0KHupILfFpI7ShzA DY3Z8pr4rM0WucQgr3md7/4ypm8sDejAmXmQxYioeJBqzn5ZGltf27cA2fKUUv85ErtlArU70dc JZVpZGrzOGFpjN7DkjE7ooUKnLrJOdnupdTN9vttPO4e2wmkOrxUci/Uz3v/bFK9oK68mRF9TxY V9Vx9GoLXc/b328iPklYO+jI3w94HroEu9u1NozvlDnMhdQ84NGOqO0s/pP18LzdQYUofYogx7u ysTM4W+pb8qN2owxenJroMDNUulxqeU/BQIJSEUv9vrmVSjZlU0jRwFaf/GsJpgZeEIR3RpQf/l 49lOQDFjVUPv1kw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe Leroy Reviewed-by: Linus Walleij --- arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c b/arch/powerpc/platf= orms/52xx/mpc52xx_gpt.c index 1ea591ec6083..c96af6b0eab4 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c @@ -280,7 +280,7 @@ static int mpc52xx_gpt_gpio_get(struct gpio_chip *gc, u= nsigned int gpio) return (in_be32(&gpt->regs->status) >> 8) & 1; } =20 -static void +static int mpc52xx_gpt_gpio_set(struct gpio_chip *gc, unsigned int gpio, int v) { struct mpc52xx_gpt_priv *gpt =3D gpiochip_get_data(gc); @@ -293,6 +293,8 @@ mpc52xx_gpt_gpio_set(struct gpio_chip *gc, unsigned int= gpio, int v) raw_spin_lock_irqsave(&gpt->lock, flags); clrsetbits_be32(&gpt->regs->mode, MPC52xx_GPT_MODE_GPIO_MASK, r); raw_spin_unlock_irqrestore(&gpt->lock, flags); + + return 0; } =20 static int mpc52xx_gpt_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio) @@ -334,7 +336,7 @@ static void mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_p= riv *gpt) gpt->gc.direction_input =3D mpc52xx_gpt_gpio_dir_in; gpt->gc.direction_output =3D mpc52xx_gpt_gpio_dir_out; gpt->gc.get =3D mpc52xx_gpt_gpio_get; - gpt->gc.set =3D mpc52xx_gpt_gpio_set; + gpt->gc.set_rv =3D mpc52xx_gpt_gpio_set; gpt->gc.base =3D -1; gpt->gc.parent =3D gpt->dev; =20 --=20 2.45.2 From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ADE12638BF for ; Tue, 8 Apr 2025 07:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096881; cv=none; b=HUQJ75NLz+DvwUnDi2AY3zeO7/kYuI5zDQRzxYihQKhxtZyY2ueIqe7cKfv6axD8t93fb/WhO6oWFYyJVupf4kYHWa3ppQznvj0ab2xUbHNrbSdoHp8zvdRuNWVK1c1c2fJ5AY2p6YkcKF/DF93y+nWDL3lXLZ5JIzrN/0F6VkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096881; c=relaxed/simple; bh=4s0EUcwB+s1Xq3ZkAByVjtUfgJ3yw9YYZaLLaWHs2rg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gWJUZhC9FwOgD5U+RLGn5h2u1+aRDD00Hr0nkD+qREDBCIAOoOJ3YdvcuKo1JMBzUmOxToGISirbJGbB/7rW9ircK0omuY8EuSMPj0fSvFO9/4/d6gZdkZFX3CCct/OLEGRd5QQdjp51CDvt7iHyku5BH8/C1kkNwCPP0m2Cgbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=quGaDhoC; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="quGaDhoC" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso34152855e9.3 for ; Tue, 08 Apr 2025 00:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096877; x=1744701677; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XvshZe5PSemjV/2XZOVRqNiaOz/McPkdhU5QyFybI6E=; b=quGaDhoCHE9RbEo1BVmtUoW/KmBnoNsw4d2HaTG0Qiywvn0htviUTe3C3zuk1GaFsK eHmjhxisq0udmrrIKbRbObXxQ/IbkSFsCWVz+g1LIzMy5FumT7CjKhbthO0CAgtH+zWf 19VAqvoiVDwkroocVCqGV3683gAHp1k7lEPD0BXrPzqmOFkBoHWGqGE/1UkWcpw6zeDu doDzaLNoiwIZM1dNZkz2gFTMEXjN9yMfxYxAFmXG3PgQMHNy2MDdBKvf6E5umxoFoz0e T6tmmtbb1sySOwIaZkLFkBZCeJqzdLqh7ClE4PLCnRLQcdwtnnI/3I17BHUerpS3p0Va FoLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096877; x=1744701677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XvshZe5PSemjV/2XZOVRqNiaOz/McPkdhU5QyFybI6E=; b=xMnVx0q/KMMolcnfi3o098MxTrl7zJcF6iE9aoCjzKlyDLU2b7PWV9G95HUh9/okpj 0ONgbj0i9jpa7hoYKWxnqAvR0iRSBl7z18vLy9EHRYUltR/Ff+sqPJ8TP9Fs/mhPDtNq nj2UpgiJwoCLejQOy0I8VW11+QGWFj5RCQgndxeoflxSgH+Tbv1zM/Ry0T4cLEDt8g6r DcIgN5nIvD2Cvhszm19SRLD9Av6/MevptyTRr9JSB6alEGfc5uO/ui+S8fXjzerEVhb6 jRgNkX3sc+qfEMZZIgmpj2KyDLjCtRj3U56DXHmqrBzeuuCmcAyRJt+DQoLKPa/1idgI xzDw== X-Forwarded-Encrypted: i=1; AJvYcCWt3FY1aDx0zElB9gx3b6RA2Lqsfr7NWI2PvKMQtldItbNhFjys0W3AMxiRgidyhKlVKtruPyPIEokEvBA=@vger.kernel.org X-Gm-Message-State: AOJu0YwiFYfS8drpmKo/PpIqPD1W/vp85fePqcrm7PhOXe/eYd11REFr 4ZyP0Ft7DNly2p8xs8CXIO4GM0tQG5zqBrp/uig6/iLgbdi5VItpuu+/D1Txd+k= X-Gm-Gg: ASbGncveRX/3rAeY7LD5rJTxUjOA6AbfOcJtsaCQgxeVCkl4tlmTgr6WbkLEEZB0rRE hRqQfq6ofY7zmW4kLrnzmAJRNCHlIM3Ig0HrV2R2zqhj2NH+DJm11Pjtz/kMQ7h2c0rxSn9pQcK b3R/V2A8DmMPj4dfU+CcvpP3By4ph5/A/pqKL2RGARxwUvSoWS0+mooE4cgRMyh8dge5qPv/i3+ G3gvwfFOlmwm9pIYCK7WrkoWKdG9a3MsjUyFydYmPxfMLsjrtu4CupOM7V2t7VZq2F83WD5aYeT DVXZ8aHHjsR0aL3MeTnNU9kQLuQHYm6VO4/Wng== X-Google-Smtp-Source: AGHT+IGrW4uYgQjk5NoZkfCg5Q4JZQulnqw+Rx7LKQ7tq7TOQnOVz0pPCRyGYatMVBjG1AXtl+w6yw== X-Received: by 2002:a05:600c:1553:b0:43c:f6c6:578c with SMTP id 5b1f17b1804b1-43ecf8d24dbmr138973775e9.15.1744096877570; Tue, 08 Apr 2025 00:21:17 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec342a1fesm154404135e9.3.2025.04.08.00.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:21:17 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:21:13 +0200 Subject: [PATCH 5/5] powerpc: 8xx/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-powerpc-v1-5-73dc1ebc6ef1@linaro.org> References: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-powerpc-v1-0-73dc1ebc6ef1@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2602; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=j7/vT2sqk3w0eq9R3JA6vJfjNNyoaO3ADhKnGJw1wQk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M5nw+RlBM7GRxu/xO7Dk2MaKAuqw17eaEkTq XAGkLPLyfuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOZwAKCRARpy6gFHHX ctefD/9qKiesq1chihFiqBhxfgS5v/Ytom4gLe+8YrTB+nRv7zmH8mj621N8fmJEbmW4PziTnaC vseQz//WwbagqW+fKFpYGuCiAkZXD4qUxW1vkLOhI7yt0C56r8TBtz4knXs3tTi/hqp2+ipJWgX UVXU9RFrMW0oUnHD2IwDauVEQbv9YoRr3gfIruX2Jfin+8P3yNoHLKEv3t5jQ6ewz8qH8LPwodY yCpL0ONxgxBy8fc7de+R6lduiUbdf3fPTwkoWK1QAkR/AUfy+Ni8/XAdJOIw2wdnWgDQRKYF+ER cjAWXp/TWSAgCAlZG3yKF1skJJOT6Blym2rjQZ8rrOSppsjkPKZnOeo9Y3x7TBzP7CViN/RA3HG bNyL9Ie92Cb4W4sSw51ovD0kquBZmhMSoS0kOhM3ojN36mrccJ80rNzoxdbyXSf7uUqH7/ntBXM NPh0rmGrYqwlSh+jhXcsZriiy46/LsMHpY7pQydNt7l8Wo9BGHg9SQAu2J4d4JxMtGb5l5R1UL0 8/k2a6xn6UmqcZdk/PR6QWHHxARvz3jgR8F/ypWXfvC9nPns2Bf8mJStATofB5n1rDgOKeLvomB dV7fXkj7MYSi07D2C+6gI9xd+WtEvQT9lspoQyQEV0Q7eWLUuAeISFqApvAq7AhAWHdcwsXfXgV C2BzXkHLmqZ5Ogg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Christophe Leroy # powerpc 8xx Reviewed-by: Christophe Leroy Reviewed-by: Linus Walleij --- arch/powerpc/platforms/8xx/cpm1.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/8xx/cpm1.c b/arch/powerpc/platforms/8xx= /cpm1.c index 1dc095ad48fc..7462c221115c 100644 --- a/arch/powerpc/platforms/8xx/cpm1.c +++ b/arch/powerpc/platforms/8xx/cpm1.c @@ -417,7 +417,7 @@ static void __cpm1_gpio16_set(struct cpm1_gpio16_chip *= cpm1_gc, u16 pin_mask, in out_be16(&iop->dat, cpm1_gc->cpdata); } =20 -static void cpm1_gpio16_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) +static int cpm1_gpio16_set(struct gpio_chip *gc, unsigned int gpio, int va= lue) { struct cpm1_gpio16_chip *cpm1_gc =3D gpiochip_get_data(gc); unsigned long flags; @@ -428,6 +428,8 @@ static void cpm1_gpio16_set(struct gpio_chip *gc, unsig= ned int gpio, int value) __cpm1_gpio16_set(cpm1_gc, pin_mask, value); =20 spin_unlock_irqrestore(&cpm1_gc->lock, flags); + + return 0; } =20 static int cpm1_gpio16_to_irq(struct gpio_chip *gc, unsigned int gpio) @@ -497,7 +499,7 @@ int cpm1_gpiochip_add16(struct device *dev) gc->direction_input =3D cpm1_gpio16_dir_in; gc->direction_output =3D cpm1_gpio16_dir_out; gc->get =3D cpm1_gpio16_get; - gc->set =3D cpm1_gpio16_set; + gc->set_rv =3D cpm1_gpio16_set; gc->to_irq =3D cpm1_gpio16_to_irq; gc->parent =3D dev; gc->owner =3D THIS_MODULE; @@ -554,7 +556,7 @@ static void __cpm1_gpio32_set(struct cpm1_gpio32_chip *= cpm1_gc, u32 pin_mask, in out_be32(&iop->dat, cpm1_gc->cpdata); } =20 -static void cpm1_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) +static int cpm1_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int va= lue) { struct cpm1_gpio32_chip *cpm1_gc =3D gpiochip_get_data(gc); unsigned long flags; @@ -565,6 +567,8 @@ static void cpm1_gpio32_set(struct gpio_chip *gc, unsig= ned int gpio, int value) __cpm1_gpio32_set(cpm1_gc, pin_mask, value); =20 spin_unlock_irqrestore(&cpm1_gc->lock, flags); + + return 0; } =20 static int cpm1_gpio32_dir_out(struct gpio_chip *gc, unsigned int gpio, in= t val) @@ -618,7 +622,7 @@ int cpm1_gpiochip_add32(struct device *dev) gc->direction_input =3D cpm1_gpio32_dir_in; gc->direction_output =3D cpm1_gpio32_dir_out; gc->get =3D cpm1_gpio32_get; - gc->set =3D cpm1_gpio32_set; + gc->set_rv =3D cpm1_gpio32_set; gc->parent =3D dev; gc->owner =3D THIS_MODULE; =20 --=20 2.45.2