From nobody Thu Dec 18 17:51:28 2025 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C942627EA for ; Tue, 8 Apr 2025 07:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097145; cv=none; b=JADn1AO/KwObbSfGdsW1qqVdQKMXoDZ97Mu0t4Z4h2urNd5rQnU8SlJ7CRUh1DBLzE+NOgN7bBg7tDVwZOB1MtHhVCMLxcsKHMzb9j90DSkQYmOeuanddo/xO4MRjKpBo6u3phS77+CKsIZEBdBJ1+n0kVEvXZcRCIk9b6Q3Z+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097145; c=relaxed/simple; bh=oFDJBxlaVibC5gJZK7MUiCXZSDcBAlZc/J2265/ifHQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ll74lAS1AJOycCHy28VSRlhYTR1jyZgF2KZ3/b9Q4WMRFptm4Xdb8emKZZwSS00hXFBuPm+ngmvAKZLx83gmDO6MqBQ8kZUH5+w+RiG2/XBDfkJ8LBeLdvnG7Ym/28BLP8J5yT2TKpiWsK7KADJEzb+Eq9ecz0WUsIn9xqyh83E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Xwb3wcmR; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Xwb3wcmR" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-548409cd2a8so6174038e87.3 for ; Tue, 08 Apr 2025 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097141; x=1744701941; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6bblWb/A3f8Vp31ZlZJvX8Y6uILdxWWSmqIBQEBD8XE=; b=Xwb3wcmRapG3dbmjNAyJRGnSMI4HC6dZq5ykpPRQmSXpJdCQBva8nF3DLsnwGUihnY m6Uei4QfnxKLDLNU2GWsgyE8cvq6EQg20ABaCfLIUNSTY00ffGT5NniYpkP2m6k11xO9 hnRn16idI+gTAFHF4jGq5OvtlM9X4aGmRK1Z1IXEklKigu5wNB7HaO8KIu1GwL6pVQe6 3OThuB3L8X+C6D3vrF9ObJn12t+BsE0tqp+fmnmeHaKob4QP4bujUSqU1LcsuCrmTzve 9tYB/8o3nOj+TQKACHZEy/SFkA2wlMpQUQ3my6BrMZY/8Bf/BoCM0twXQRQzycZU7DvH hlIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097141; x=1744701941; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6bblWb/A3f8Vp31ZlZJvX8Y6uILdxWWSmqIBQEBD8XE=; b=uaD1CWCFu8JH6jYefYyAMytBf/SX8HBuDM7pPXh9aiDcnUtyszNz7WY0OKU7rhcPUx OFRStGNeXIkLMQZjmvtT+xIFAhqyqrtrys02BXxBdhS3q/cIoYLGAMqvIGGhrGy4gDLj qcrM0kpPgsSgQssifB++DjEwyvjWQ5M6GAmITXIoUAQvdCNCl5qDw17bksBWUwwZkua7 4siyX/lL3hzKnkEAI3gMnVcY9TugKWRKc/RZEKrFAZvvQoBR+sqQW3x2NF+Q1eEXDsVN I1yv7wZvZ48F2tFlpxbaX4opgzqpGu4RPllCwCjEbJzUYDh0SnNjEIoJjgrLPR5tzgRw Gj5Q== X-Forwarded-Encrypted: i=1; AJvYcCXpHNS6NHbpqoXH5oa3MSQqWqtr54pNlUuPhR7dhOYvWBvBjnJFiEzngGMkPJJjdCgzt+v532DzOKFKtb0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzdp+jg7Si7BhU1fcVr8SSIyzOT/m8B2t6T3ev0Bg43BmQcbIZl B50Zh0wDdLmM/ntku+VwBAj9km3ySl6MSGQpnzT1HRMG6NvaGBLZlJnrtsMLPX68zeqGSj3zsAx SgvU= X-Gm-Gg: ASbGncvccyHjPo0kCJ2PTnS7pFGLRx4q8V7VWd6gIsB/tJ2UjumBLG01OU2GGWAk9aS bDfQEf3/JWIlq+pifijFLrIxesvhdoJGWYUxJnBXud7HVf2QYZMw3qwZ6CLCDOM1Rr0rW5JWIVl 9rZAYZfB4h5vE7OG6V3Ba0FzlFhGjV0lmEjd14+J6MnJoEIRPwyNpMZ1DpTYtrNfE/R2AjgMSOd nG64cEGj1OAlkbQ3df9uKvgAbbolkPFp/fcDQSaUNIG5Gu62sEEDFFHOd2DWnhpMde68h/zvDzH C7RA6n9qSbu1kDaNalqTzihKecbqf6yczXCUVA== X-Google-Smtp-Source: AGHT+IHqIWuX5sWz9MJQWDS2IT6lTfF85m614lClDoVvdHMGky/Ix50ZxwKNqFgfUZCLhjcPg/Mzog== X-Received: by 2002:a05:6000:4313:b0:39c:2669:d786 with SMTP id ffacd0b85a97d-39cb359830amr12025582f8f.19.1744096669312; Tue, 08 Apr 2025 00:17:49 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:48 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:38 +0200 Subject: [PATCH 01/10] pinctrl: at91-pio4: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-1-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2256; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6oXQdDn+JiYI7kPrR9MR4Ulr8BlxDaIdgOQst72f6aI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZS1CVSr+OpPpLt+g73dsnxK7Cn+5jOBkEm S4RhLYFpI2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX ckshEADgmKAecLNRDwbY5cLUNohPOOEtx7wPD6IeqZgsOFSImxcR1AYiTklwNvcEyx4WnHhAmzb oG3lzRmS0xFVCzQi9mX4uHbuIJXP1MxN2ddsgnB6lg1CEj1b4qv6DNNxxtBQ0ipnDwRNuawQcwH aeYqABy61n2vfrZJBJVOSi9TQAkdSEJwgvanfueiX/vJnvVKET+cxjJqHSgRCxlPdre/sm0kKMI CCPKVMovBcpT7OOGP0j4+p0kCB6NCqevlaTewuoV/h4tWjYpF6SH9gESREPjsk7R213eO+DWr4n UFTfB1ByxQw7vd5agHmcng2yl1ZV7SUNOsT5kf6nSoI4cvkeO4ons+t63tePlkRUDoQumIQzhga N/mIkjV7W2xjVvZrcZEGS63D38/fzY4sA7sVuWaWgZwWrCrfhPajPxotxjxOsvTWXSWJkfh6ixI f2yLdNBgi9wSYNat2UoYPTLeRh3lzFjphWxPajFb+ZQczTx/bXcjtpDXNQewa78BXhZ30rEIrF/ M3gIErsXpEjyv3RmSJV7CGPdxfLwaxjHq9SZNfNqeeYValUtoqirxITK0jSaQrmdUBMmUx/IqJs XwWZMdG3msE++lZ6NvgjhT2WFVsie3VhFAI2l/WdsxXhiwXItFE0r0m2V8VtqyUKn2/YCh5ew2+ nnZya7p1LkYH6fg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Claudiu Beznea --- drivers/pinctrl/pinctrl-at91-pio4.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-= at91-pio4.c index 8b01d312305a..5db839fa9b3f 100644 --- a/drivers/pinctrl/pinctrl-at91-pio4.c +++ b/drivers/pinctrl/pinctrl-at91-pio4.c @@ -390,7 +390,7 @@ static int atmel_gpio_direction_output(struct gpio_chip= *chip, return 0; } =20 -static void atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, in= t val) +static int atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, int= val) { struct atmel_pioctrl *atmel_pioctrl =3D gpiochip_get_data(chip); struct atmel_pin *pin =3D atmel_pioctrl->pins[offset]; @@ -398,10 +398,12 @@ static void atmel_gpio_set(struct gpio_chip *chip, un= signed int offset, int val) atmel_gpio_write(atmel_pioctrl, pin->bank, val ? ATMEL_PIO_SODR : ATMEL_PIO_CODR, BIT(pin->line)); + + return 0; } =20 -static void atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long = *mask, - unsigned long *bits) +static int atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long *= mask, + unsigned long *bits) { struct atmel_pioctrl *atmel_pioctrl =3D gpiochip_get_data(chip); unsigned int bank; @@ -431,6 +433,8 @@ static void atmel_gpio_set_multiple(struct gpio_chip *c= hip, unsigned long *mask, bits[word] >>=3D ATMEL_PIO_NPINS_PER_BANK; #endif } + + return 0; } =20 static struct gpio_chip atmel_gpio_chip =3D { @@ -438,8 +442,8 @@ static struct gpio_chip atmel_gpio_chip =3D { .get =3D atmel_gpio_get, .get_multiple =3D atmel_gpio_get_multiple, .direction_output =3D atmel_gpio_direction_output, - .set =3D atmel_gpio_set, - .set_multiple =3D atmel_gpio_set_multiple, + .set_rv =3D atmel_gpio_set, + .set_multiple_rv =3D atmel_gpio_set_multiple, .to_irq =3D atmel_gpio_to_irq, .base =3D 0, }; --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4BF126158C for ; Tue, 8 Apr 2025 07:17:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096675; cv=none; b=MYkk5Wh5oVAKlSxDoRZEBlFSvZq2Len+bzDb1meZxoD3IBE4o5inpemOJTVlgOaepIFvBEYPt2Kdh01dq2/7KLr7DFzrN0wLTLR6t6ldOQaM7/YdgRiRwMQMIxp/FiQtbuvSIxpAQcxguJROqa3S0wI1AiKyjZzWaMtE5MPPUKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096675; c=relaxed/simple; bh=rMoLNEgc8ra7f81mpaEJiXyRA6uVb804TO4wJizq22k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HVrYXJtE7VCojzVucn7Fjf1CqRSulmWEHiGxNPAOJC2q23VUKbGBBTWOry+9qNv3qI3S82ITcm3yfKtWRn/89DAGGTLAejfo2jKowlhU9A9a55XGCgGNiSZbfTwAjPZ25+fx3VYzr4CT6EjPGdzFnuxcs00azIknXhVl0FQluXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EFSvf1WQ; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EFSvf1WQ" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-39c1ef4acf2so3061472f8f.0 for ; Tue, 08 Apr 2025 00:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096672; x=1744701472; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KHbdZ8I5zBJbhRifEOkTpCnTw3e9jVPzpvQJpqCzg30=; b=EFSvf1WQKpEWCnApfQNGOOGMqEPzX8xFBMhVaRCe5FcN7KbsgavU1TM5dOBX1Xqrys g/PoAYz4JYnwhdiicpg2SWpK+rTaPNhZB4P82Ykiz/MkHreacbO3pttwLm85pOdOZv0t CJ75QlsVMV6iiSDK8esSOVZWssltvx1DA6QxIIRO+GEH+GoU+AdLZZQpYEyP0dL6wuVl LVRtHQ3VpdFSRnxtV0jVylfSf+2ExtS9Cy+o0k+L+vzImzF1RBKckaAuUN3hrAol6CfL BpbneKOSVU3a4i8EgAR6DCZoB1UiQfk/1k+FMzJbzxHw+FVEaaUHVBmOBWEaq8A0Ss3Z TJhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096672; x=1744701472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KHbdZ8I5zBJbhRifEOkTpCnTw3e9jVPzpvQJpqCzg30=; b=xAtqd3q/nOmTuOwM2ePYiCq3oIFOByRj/sS+wBmpPaqZ+wCmXZmtv3SKF7A+Bbly3G i0UOCcwGaGjdIGG+mrW7EVsvQ9wPxNLxHTa1TORXD8SiUvbUaOqio/54dvf9ALlGPV9U +PwaWcThy1cZvU/knGWN2gPv98dbw8/0PP8XLUQaY53jX3m67jZTzwxxQbSjrJPPPu+8 gMkfRvV8lfBaScyXqqXAUVlN50JFl8x0uz3b2vmZA+HynQFfaI9rRDt7BLmYuxs15Dym B6G7VzQ7d78cREHksmR1OFqJbtvf1ZZcH5H1F4l4AYx8Sxyvi/F/GNT7tT/2XtraCowN DlKQ== X-Forwarded-Encrypted: i=1; AJvYcCWRotTdpAcvjfdSkeL5pWw4Vy/PKcRUjdR4vlAXTiSp+r51JSDrGBAUXVbOT5sGKx1U6dJpZcV15IeOH9w=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0YURPa5PEPSnhxEqdEIeycGc0FQcY1ZcJ6rJhntAqKZi0r8LN UIkHZHc/BTtTF0iEYH07gocn2TPs127dcRZVFcdhXB0uA4SwlD8/ditHYKFSshs= X-Gm-Gg: ASbGncvJ2sGb3xrAtCudahBB/TR/deuVcDl02PAGi+igNS9/mw+Lf+XA7Z+YanFWeGK Fj+J9Z0UgsavfgZEBBbCWyfhzlqwLpj8ch/FWyyDP61thzKHEKm2v2YanMaoWXXpFVjKC9ushld /Jns7Z90q2bPwp9YMzjsVsamWJwFbP9vn/5VUzYZWcmXipIwP+wCC7+4fSPC5YpGw28xRL7ckKf ybBO2HP9qUna7hklj+1esgbRTAhjSnreuRltltJ9MZsjucsTXzDfBZmIgeF9NitpwjVwJ+orSQm J4265QgqbSGx8Z0C8adFe7u0pJLbxZIyecqiJA== X-Google-Smtp-Source: AGHT+IG66JLNMA6/+F4yvPGqakGWzMF6ZtCNetVsbjFv2aPqMbejsIAN56v674i7htexv9OZa2w1UA== X-Received: by 2002:a5d:5f96:0:b0:390:f2f1:2a17 with SMTP id ffacd0b85a97d-39d1466229bmr14181138f8f.53.1744096672155; Tue, 08 Apr 2025 00:17:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:51 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:39 +0200 Subject: [PATCH 02/10] pinctrl: rk805: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-2-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2092; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=sUTrzWuOo7PVik1QzFjSyEGMbbgvgdGB1epc3LKWdY4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZtGmml6ycwEzk3KhRs/YW0AQqsaUfB686c +V6uDVoAR+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX cttsEACbtqoZ/RYzP/rSItzAm6RyIKDSI67qmiaM3eZO+Qwuz4UvIvJ/GL6pV94KgneXWwmwPKo P7ywI2W0szbMsr9K+DM7p2BGeLSS8pyImHtM3ITgmaayPUvVb3Y7MrTj+v9MYNRnjYl5sGRlIjK 1EmAEesdJqsGiDikg07oXYnqGVad+4NJ2zxDtQ5n7tB3ShEJusRuIFA35sixjIGRTR4Nr+0DmSH ARiPMtTFkfjtgsXBEDCv0PRzyup4961wgfvFgQ7GRwqsXxRacjsZAEmoYduAjZjqdJ1dny8C8i/ Evwq8RUqfgTcjvwjmVDu3klH9BEGNcZX9frolFeag0oRT7/RZHWm0ZxaKaU4rlH/E0Io6pd73nU sw0vsjb8AZuD4il5knSflEdQN3RuRoPp/QdnpHdPim0zwLKdIVMyzNu6p2O0tRQGmQi3tJnf6+/ +iwIO4FrFQOgX9vh4VdG91Tuu+BBuoCRJMWkbcnWF5dZaX6tREBxwtDhCsxPH58+4G5NQgX0XN+ IJgHJLn/R/KYnp/l1eWewkxcLXRRPGbcaEUJ5lTHuvd6fGpdv0Af4X3rK0WZJ6UwBJw5u6pQLY5 8YdLZCYvmvA8jSXhIocYAmemyaGKAMW/JnBi6mtMkH5dOwmpnp+SvX5iwwf+9a5m+kDEg4dWidg WpA2txNtQ9d547g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-rk805.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rk805.c b/drivers/pinctrl/pinctrl-rk80= 5.c index c42f1bf93404..fc0e330b1d11 100644 --- a/drivers/pinctrl/pinctrl-rk805.c +++ b/drivers/pinctrl/pinctrl-rk805.c @@ -325,26 +325,26 @@ static int rk805_gpio_get(struct gpio_chip *chip, uns= igned int offset) return !!(val & pci->pin_cfg[offset].val_msk); } =20 -static void rk805_gpio_set(struct gpio_chip *chip, - unsigned int offset, - int value) +static int rk805_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rk805_pctrl_info *pci =3D gpiochip_get_data(chip); - int ret; =20 - ret =3D regmap_update_bits(pci->rk808->regmap, - pci->pin_cfg[offset].reg, - pci->pin_cfg[offset].val_msk, - value ? pci->pin_cfg[offset].val_msk : 0); - if (ret) - dev_err(pci->dev, "set gpio%d value %d failed\n", - offset, value); + return regmap_update_bits(pci->rk808->regmap, + pci->pin_cfg[offset].reg, + pci->pin_cfg[offset].val_msk, + value ? pci->pin_cfg[offset].val_msk : 0); } =20 static int rk805_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { - rk805_gpio_set(chip, offset, value); + int ret; + + ret =3D rk805_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } =20 @@ -378,7 +378,7 @@ static const struct gpio_chip rk805_gpio_chip =3D { .free =3D gpiochip_generic_free, .get_direction =3D rk805_gpio_get_direction, .get =3D rk805_gpio_get, - .set =3D rk805_gpio_set, + .set_rv =3D rk805_gpio_set, .direction_input =3D pinctrl_gpio_direction_input, .direction_output =3D rk805_gpio_direction_output, .can_sleep =3D true, --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 090B126159B for ; Tue, 8 Apr 2025 07:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096676; cv=none; b=oxyWUpImqsWEd3WkpYWucBouz4mV7unj9Ju6gtuX2hC93rYfvwcW2+NQkLmKu+WzCMUfpb38ewJe2/yHvw1l1SsH8ZTulArf9rhvxhs0kOVgOpNCm5GVKYbPcpIs2flujLhcD2BSi5oRksszNnYfCGZ2tPzscTS9vLAnscTSb7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096676; c=relaxed/simple; bh=mm+CYE4HlFqyXrmHXF0COUC9+WgpXE6WtAJk1HFSlKk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=vBFTXSoR+NV5AsK8Yz7JVvW1ygdea5xAMPg8iTmn3oUkRQuPKMhRXqlaQ37mqKdhmhPu7CPhGCVEiGgSoXkIxqdUmUEKVooRgvxA85Ex2HksrjJU4c4uC++5CL1KHCmyY25d3fWww9sduzzW60nbrOS0moeGHmuiydhnPO1WZfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=zmyANZSP; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="zmyANZSP" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so40734065e9.1 for ; Tue, 08 Apr 2025 00:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096673; x=1744701473; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kgKpi2eMQzrwoQvXzcbqAzy5xxQOgpVGvK0+n6zqybM=; b=zmyANZSPe5F0+SNAThTUiSayS4NkdTkMGA9SIWxQat4TXal8PWxLSmTWqTcE6YZGWI 486Fyj6TZXQ2Dv7Qowzg2U2n3n/AzTXou7AP93hkr4HFfimm3DrJ49Wy7p8UdVJbhI+d 2QhwopRrLFA6v34FFph9Q8zblCwTwzaquiHD93HLWuqVrT9/ZV+rz9vB3YvEQvQYRhZ/ aaYx36+wkBFy2IqnRFUZ3yJChj4cL78YDGvPmS4qDU9OcBcW2GkyzQ/Sm8QLG21rx6l4 YLE+m93Obb0PfHkx3t1vdrk8GLwBoEL+9jwnCeaUSMNh5CnRZWLh1H5oH/vSmuMYmOhO hF+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096673; x=1744701473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kgKpi2eMQzrwoQvXzcbqAzy5xxQOgpVGvK0+n6zqybM=; b=CRsQrtv4QAYH2R8GjU5bWN+lE6+OUl6pm35CilIL7lKNZmPNRDrfJ4rv10Jdh8l5rI 8oGP59xA4KTbaSN1/og1fPj3IZFPqCDGwTuILM9/diJrl5WrwOrE6UgVqEI9Wm76WTUd JNkITx1xG2SS5EUA3eLzus9l9b/USWt7eSwP6M+RYwUrhV04Tmj+3NGIr8CdxRg55CzY G6YOTtyi1H1N33ZD71cBNTnAZirkPkuOPKaJbFIuh+XYdGxpi+2FP/mUkcAhGCKpHq3j ELirAeyr8PmMHsxReC+QF2TbNaga9wyWcBJWfwAiHtzACqR+AoHJL+uMfrCF0UUb2KDx yQMA== X-Forwarded-Encrypted: i=1; AJvYcCXOykXMcFLFJ8xhTq1iGq0gHOmSllCN/DL9Vpkhqb0NWrN4Gmf0YF5OCZ5UYBhycrz5SWbSBMwuvm9+dSc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1VgWfZbFyu3c3EP9pyjSlyvf0pC75ivf/ondt2oOmynwFvJ2V OIUfVJ7+FPny5ww+YcJmtSVvQzwUfR8Ns4wEtQCEarOZnSG+Z5wTME/huDGhRMM= X-Gm-Gg: ASbGncsD1dcI7VvFwlvjFXTq7xtgC6qa+5LwS//trCCx3V4B6qY/WlPhMboSE04hOIJ PtHRG18N7E0rnfICzct+1TH/dCcPiRxPHqsw6pbQ782iyjjD12rv7kVhIuRsm3NJn0WwraCRSzN xt2VukXo+/QsQXwczy/gLCSK5kfuAZcrKwTQJgAuzP3JX5d0UATv0ns7QN8CGOrVAxQ4WAuk3K+ WTUfFpqd9f4DtdqN8wdJoie14SelC21Bvwbp8IX9HVkdUaZ5KYGCoSf/KgrjaW+kE1cXZK2QCJq /yHhe1U+EuV2F1Em7QiVkANkQxvPXh0VSbalzQ== X-Google-Smtp-Source: AGHT+IFIDoEgtgjZmRm76oLe4qBixaJVFcxIWBxSgP9eQc/+muRPjB5OZ4DhcXqFSFfMWbn8IPCLNw== X-Received: by 2002:a05:6000:2484:b0:38d:ae1e:2f3c with SMTP id ffacd0b85a97d-39d820eb1f9mr1593525f8f.25.1744096673169; Tue, 08 Apr 2025 00:17:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:52 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:40 +0200 Subject: [PATCH 03/10] pinctrl: abx500: enable building modules with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-3-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=7gT59a+ieEBoRyUfHtp8d/jvYbZrPQXR8M3Rkb54480=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2Z62HjgrUOk13umM6zCKtt5wsF8hMyPqGii +FbeYzWZu2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX cr+9D/4pVK6myjhrhbvOnoR4PHJ367IIWOAh/Zh8cc762qftCq98AjRSHWjpi3KMWk+T1SoewR6 yd9FAaYyN5ggStwHN8ifchYiv+JA8sO+i6UuSIOQUVQzey/SsbW1SeTgmZ3o/GsdKPG/HjoxejZ M1kbfrXMCRWGU5zTxGwLAZl126dUhXDTKScOqGDG6ZLFctZH0MSBmu4Nu7uWpRWQK3R+Xr6OGfa +BSLVhz77RThlP5bmwNejIlKFQNdlTKOpKLwZ4d0FEN5QJPa8Epbb+Vvkputkda+ERCCbCEvjf9 8ZSHC0SCNCcLyorbyOA6rgYWiPo+GZMHSqoF/Pl1OFZzp2mCtAXPyQrKJ2wv0I5KYUJSLuNstbX pAA8HtMWVKN2o8VTfFf0kYbEFAo7BM5D+3B86ctemR78XtjX9vA/33qPRw6qbRuWNjF2jLMxwGg 7sr3CLWFwcyqt8oNdhyjEWmfnIO2z+BYPCo7Btr52pKon7rbGIyJAAG4gxmUqgjRO/PJ06aCPjV erKdtcafZvxLT9Mf2jX/+expNbOTo5PKgOvekHmSlI2xdATbBZgMQPxFNUNJVlXLL3UGV8fR/Zh +ApMwVs12NjHuf/sT9aZDxPH2zbKJvARpXLKynmGD52HIn+u06LPHHbZH2+obwAez7+Tde1ydSJ G1AuErL37JcATMA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Increase the build coverage by enabling the abx500 modules with COMPILE_TEST=3Dy. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/nomadik/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/nomadik/Kconfig b/drivers/pinctrl/nomadik/Kcon= fig index aafecf348670..2c1f8a4f5d24 100644 --- a/drivers/pinctrl/nomadik/Kconfig +++ b/drivers/pinctrl/nomadik/Kconfig @@ -1,20 +1,20 @@ # SPDX-License-Identifier: GPL-2.0-only -if ARCH_U8500 +if (ARCH_U8500 || COMPILE_TEST) =20 config PINCTRL_ABX500 bool "ST-Ericsson ABx500 family Mixed Signal Circuit gpio functions" - depends on AB8500_CORE + depends on AB8500_CORE || COMPILE_TEST select GENERIC_PINCONF help Select this to enable the ABx500 family IC GPIO driver =20 config PINCTRL_AB8500 bool "AB8500 pin controller driver" - depends on PINCTRL_ABX500 && ARCH_U8500 + depends on PINCTRL_ABX500 && (ARCH_U8500 || COMPILE_TEST) =20 config PINCTRL_AB8505 bool "AB8505 pin controller driver" - depends on PINCTRL_ABX500 && ARCH_U8500 + depends on PINCTRL_ABX500 && (ARCH_U8500 || COMPILE_TEST) =20 endif =20 --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70E772620CD for ; Tue, 8 Apr 2025 07:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096678; cv=none; b=HIa0h6wQzTQ7pPKg6wKLFjtFbc/ufkkrJrxElVdBU9cP8JrzlS0ShZz9XGzp+OdTZVaImVuJ2AsKQq4131dQqEsHCXbwZb4ewOu12A/KJDkT0rAuxjAfpQnS74dpG1mheUoftOF9DZSdNQg1sbnjuNroCe1To1LRr9rtinLzqRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096678; c=relaxed/simple; bh=LUO169XweHthkl0x5gh4EBHKDTlbmHW+O/3cx40pVA8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uw9GoCdjGOY2sEBgu/YP+PahsbUgyZPahif3Gw0K++Vd6ppbcwIppDEge3FGAb+Mv4TX2F2kID6ItwiIRdS3q4yuVF4nkPZo817xY9q7cLECXfKP8B8GAtroDsznb5gab4jC7Ey3CZcZKwlYjzNAmEWCYYenjZyCvViESsR1v/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=FaONou+0; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="FaONou+0" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cf680d351so36280175e9.0 for ; Tue, 08 Apr 2025 00:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096674; x=1744701474; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oinSzm+bMahZJYAUWu862y4MPTAeTqz9q0Fj/pnJpP0=; b=FaONou+0YTurmuYaYSXwBHKij0TZN3e8kqnDwuXMsizfcukkSI38P9lncuk8f12AnC OqlKutqRLQZ4MZxL+U26IIaJ/xlTr9WIfNm3RfId/qyXj0WVDdtJ4Uz9xYuYYfTG3ipA dVWb4fx1q3ESavS23D/nQf/bZnYCeOAPBOzE5gH0vK3DsOujCnHwL7AXUoTotbAIrXha elaZjMnx6eWnnAIld60LwBTt0CJ64YLM6JnWBAwVBZN1MAYDlsEN0FE2wGlOr7jxC4Im bA1Sw2Ji1Fg7zY9iAbAajzQGocUQGJKqTmXhuJbk5tBtvLgukD08E0Y8McvYEVZhfSCs 2a2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096674; x=1744701474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oinSzm+bMahZJYAUWu862y4MPTAeTqz9q0Fj/pnJpP0=; b=t6cpMS2kwMyDh7upC3R80chun3VQBUWjhgd1ZwoRMnwAzuci9rAfsCD7jmqY/U1w56 my9MlOxELQVtuPGM6DmDCGTlLYJ2k/7t/sB+Hp6JHUiaVkBSTxGut68zBXeINYFF8RVw xtEgq6gWNI+szDTh62flnDo2+h92LeJh/s80VxbenZ9PC2wcyJa/Inhr4N8fIcDViq8C kXQrtIO1gi4gHv3D0ITIO2Kc/H++T8/3W+PmERE8/DBmnSwKe5LNsxPgmFCg9A0PYWSv T+U2MwcceuEXKNnXlvzNy2IC1WrKLOhxDiwPZmxgo8fs/A7fjbEYk3SAKLFvF1ENEpPl yeVw== X-Forwarded-Encrypted: i=1; AJvYcCU2FO58g2sYm/YTCMb+RiADvARXGOIjmTseBuBYXVUP+61d2f0EWgI9sstNaGGUh7/mGir22DMelgKitgs=@vger.kernel.org X-Gm-Message-State: AOJu0YyVSjrQa0myXc1Q7ChQYqXgCs5XKBnchlotjta4WtDlLJscli1F gKhGm2xsQPNzoMzlAsMfUd/Y6P44wjaSriI/BoONRhZqRExZVxtBAKPaA3xttTs= X-Gm-Gg: ASbGncs3gmatDnA2II5u/uGPgGoN31JQRFat0E1/3HiyFp/SwDwE8oSEsWhOhs4rW4U eqCeTjHbJJigYOZoLvNo91HSfiKAGkmSGeVK+1HF1RUIcR0PgtntfvhPLohGqqETGqBBXUBTb/i GQDiF5nIzI2GXOiEuockzTaljxBMbv+7qMe224NbX37HY5YadfRESGee/RR3bwGoH8rmPqFhoN8 1k4uYy6FarNF0pNFnjZDc3uPxDzFmNb7OLxpP4NzR/v7y/5dR1efjyfe1ZauSsc9XzvDwUH1OZm 9zoCeEE+kWtZGtMjiD1BAsZueXASdqHbYEWl0w== X-Google-Smtp-Source: AGHT+IHrjnllwruX19f7P/GJ6q4XihZ8rfCQK9jOXGEEswSMIiSKCV482ACd4hwI02zSsicA1Cwvhg== X-Received: by 2002:a05:6000:2289:b0:39c:30f7:a599 with SMTP id ffacd0b85a97d-39d820f7f4emr1793514f8f.18.1744096674126; Tue, 08 Apr 2025 00:17:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:41 +0200 Subject: [PATCH 04/10] pinctrl: abx500: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-4-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1591; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nW8gbeASZZPGvCfMjx4XcSCJQKXVyNGKry+o6wrAY6k=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZVzNUI3VgRQMzfUNu5ztBdbgFOzKCX2cTD gqJRJh5fnqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX ckcMD/9lHTxFJCt7mJF9tP1pyTVlOFcI4iTV1L1QK53z5FW2Z3SMIbsg/WP0Ox+KZTEQhQIH3rM wwqGzcFbxbursx8+r7+ZvVqkU4QZIBUyACF7u1pek1/n8JBWnexyzkfimQ/4dv84Mg8fblHxX6/ e9AxG0M296lr/4pAiXZ1OD25/6m9fmgaetnGniuV57A4pLBJe9hlfZ2YzB5mYUgkf1H//Jbwa+A 6XaU8J7I4WJxHP8tl6QsF4nWHGmtgm2fhT82RFptXXjqk4O4soM7AG+Ss+tjQK6UQz9anNLU6Lm rmqduN1o+po7YG+d9QycugTfQLY+ldfFNdSba874x5yFE0yN5u6hWFUlf7kqCSA9/ShGC3h1b1d P3SrzAAp/KzpaZ0qz4k3uHr8AWzjtoebNiQLf0np9Rhj6QlsXMPTjpRvO8qu6TwbjgMUVwXs+ML LAU2zu2R1fixy6aGTWSrsqOHHB7OOlUsUa2Gx4LvWVk5suCmM1xbfDPoByv89XnsFLphWZVxUvK aJGTZoxqeRJVCy+Hfx8X9v29LWuxTlLQC6oNMkvVpk9Pycf8fKsnjpKqnwNQ8Of16WN8gMmVTAb w4ONrOgUNVqfGiBiUJqcKD1U3JafBOwIdNX7SuEwqraaSC6bMhiSiynASp0nnYhkZEAuJMLEqV9 8aWIUWj5E3JEMig== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/nomadik/pinctrl-abx500.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nom= adik/pinctrl-abx500.c index 8cd4ba5cf0bd..2f55f83127cf 100644 --- a/drivers/pinctrl/nomadik/pinctrl-abx500.c +++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c @@ -167,14 +167,10 @@ static int abx500_gpio_get(struct gpio_chip *chip, un= signed offset) return bit; } =20 -static void abx500_gpio_set(struct gpio_chip *chip, unsigned offset, int v= al) +static int abx500_gpio_set(struct gpio_chip *chip, unsigned int offset, + int val) { - struct abx500_pinctrl *pct =3D gpiochip_get_data(chip); - int ret; - - ret =3D abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val); - if (ret < 0) - dev_err(pct->dev, "%s write failed (%d)\n", __func__, ret); + return abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val); } =20 static int abx500_gpio_direction_output(struct gpio_chip *chip, @@ -540,7 +536,7 @@ static const struct gpio_chip abx500gpio_chip =3D { .direction_input =3D abx500_gpio_direction_input, .get =3D abx500_gpio_get, .direction_output =3D abx500_gpio_direction_output, - .set =3D abx500_gpio_set, + .set_rv =3D abx500_gpio_set, .to_irq =3D abx500_gpio_to_irq, .dbg_show =3D abx500_gpio_dbg_show, }; --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D032620D3 for ; Tue, 8 Apr 2025 07:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096678; cv=none; b=iCkalfz7l0TdDvp0ihOr7v0eqFQgW9Uy23v2QcINrageG7JMqtReXZ4uoUP5NrFkzhrPAaDsjxxspgb5J4yRTBI9TZZa/2eRciFlX08EF81csx1gUXbkNb7WSgRC+8FLGKQNqFryx1YPwgeQRZlgyduUSEszgoMWK73YZXwsCZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096678; c=relaxed/simple; bh=MyfYoAl7StVsO4BW3rx1l2AiXfWRq1lVePaWfhahBeg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CWKA2HDzni5WtsIOMpoqeql5AMpS6aNGlNhfJGX4yNvZ7QDjNbkUi5lsQ01iDyj3/LNu8+Bi3V3RdqW4D/ivU2bkhRg+sf+djbdbBH/eoEecWoU7f8v0spuCe5PNsdGnPifkyCVn5UGk2iIWlaSHiTY7PxsENHYEAy/a62ItyOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JOB7cEOy; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JOB7cEOy" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-391342fc1f6so4559747f8f.1 for ; Tue, 08 Apr 2025 00:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096675; x=1744701475; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WVFJWADW/y0RMccjVQrvsZvTL6Kql3Z12L3/megvx2A=; b=JOB7cEOyJmtN5yX5YsH9OtLzPST66qUwqQ/+1oeJ8tddyJnSX8KUj45gR6UuERNBj1 H9SBFzz7TfqC00EdMfEbTmmzNwCgJwIKM4tJp+JyZAuFemvaAqbjG5TfbEZLqKCCKzVx S+3m4pgl9Q9uuEHndfdXUZAjHTeDdcfKDy7xoOakjqdnS27hdJavgmH6NS9IHq5j8ZWP HJHtK5M+TbPMmFzEo1gDOKeBYzZhmqaPgI/O2O/BAAspf4uXVPn+e16P9xP9W3M788l6 z8/h0z0OMBBXHdZUuRk3JaFFaLKvGEpdaOCymHJdYKINEHh3hb7ZLFXPcvFo+2kTNsQr UakA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096675; x=1744701475; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WVFJWADW/y0RMccjVQrvsZvTL6Kql3Z12L3/megvx2A=; b=KwH+HZC2YERjsGbxkDWIZxQajnE9sws7fsXAvyRRtcFAzovFStsOFvribEXFMMJB5i OO9e8tCyHzNfUXJw2Z6EDa+QweYUN8Htx1uwzn21x7I4bXWgzycO/mXRYEae8RiumU4c qBQlAajbwy+wJO2Uo4M4WpBel5GOMDym8wB2k4Qs26RPsfWLBsH46gXYf7AVc+5Dckah 2Ml1r+GgXKV2BmiSDhWjLswYbM/Ybh8kIohmNY6AEmodFvIltdDRwZW1H9wEqAf8Nxhb Y7JSPb0KNrmGR+8+9O7Dmm2QNJPQdEWrSkNSUnRww/aR73bV0TgjG/FR+pjs3DSPaADu mzQQ== X-Forwarded-Encrypted: i=1; AJvYcCVjMr5N/r75VVcCZbNBSMLrESKJPam760cJLZrtjMhF9TGgy2+Q7u7EiR/szqrcee2gQaaUC5DXoCxwD1o=@vger.kernel.org X-Gm-Message-State: AOJu0YyiiIPMmR5u9VLiNfECMSm1aFS66AxFp2Nm0+SM0FIN/a0j9FD+ sDzqb08pv5n8E+0zOGUMjl2wEeFtIBGcdT/4t4xR3kSu7ocKvvprk6ZKcB1xMDQ= X-Gm-Gg: ASbGnct8jcrTIg4rjApsCcm4ZwP29Z77QSffoQ/DubsSDo8HarawrgJT+Hj+uP+BVSB Ymkc63qn62cHY1D9QIcUMLBj9e6kG3UyBKTXmGQYaUC8NfeGgNllTBm7xJQAP+5iR7h5EeISekd QwmkIXJZ3jzeOWFtEBFsbOW8ea2qyMAGNXDxRRivgEdl055mhLzET+FpyidnTf00RkcePm5YYd1 WWPwK36TDjtfD5fYGnG1b9gypTdgEJPBkXb4dax/Vw0aFu6lLg9VjSYmO/SSJ6XG4KNRjJfqS+G fClI/UjTgBAchiAt/i5L0HYb8R/AQpottnpfUw== X-Google-Smtp-Source: AGHT+IGb12K5x3MyGax1/meWBHx/ceb2e/LqJgU9QQIZHIFbzKHDCky62yygJ2VTuSCj50YJyfE4bw== X-Received: by 2002:a05:6000:4313:b0:38f:2413:2622 with SMTP id ffacd0b85a97d-39d0de679d1mr13305391f8f.47.1744096675082; Tue, 08 Apr 2025 00:17:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:54 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:42 +0200 Subject: [PATCH 05/10] pinctrl: meson: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-5-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1477; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=S3igGGikbfII9kNPL0KKjqnS8YUnpBiOi6WZKLdujUk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2a21smivbrNX7hovJ5AmOVQjkGrJhwqOgTw 9GIegrUEM2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX ci67EADKEh90ymTKMGsCY74l9LHK8QIQ4v/81+Rc6Eqfw4wVjL+lPNaGTcSBP2utqyO2KrQMMFw Ud7MCMHcZm7kzMCKgZhr4Q5hxKegKb2tXZsgsyhV8YdIebBSZmZS3xjHm1FTslGntrxTtZfUcgD 9Ncx7bkinKF9GE+JhCUYTwm5rX/ImXZPua18/+263zoA9IcowGvpu+sHiPYBinPQTG/NzQUeczO GStvT8lo/PvFW5C2evtDAAac3WkpMH72Zd++nH3ZSzFjmh6wa+JuZj4++IaVtdQvf34/rVmBvxm 6lfHwsxcLCcvsiKLGQvJ0pyMUTgjTXWuCVx1yI4OFqh/vGStiEpFn/FM4m6cgY2+8721nFS0XSg skTUnIqE+icmuFIxh33ZNyBinNKoXfA262Dd1FT4UU/UGWwK/zVzRXebNxxuWVofBCrpGfvckJj 5An31hmmubXfJwwqfo1WCobGVNTYhODCiiFTT1nEEdIOgEF1ogNVoLg7ND2vY3mbvxs/m59mrBt Ghvcu71zj2ubCbOCger+FJ91d0OXgTTDx3l6RxskE+/H9YiT3YVPYtaxsW15NZ/wrgk3dpqh3Pb pxgF2SOpd2n46VLipFyjCU5PmDaB9KG2fyxu5yKFQym8Uk1AbdlkcgldvEzqzVK06tjwV4yQehq CrMwCr4lgCvIlLQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Martin Blumenstingl Reviewed-by: Neil Armstrong --- drivers/pinctrl/meson/pinctrl-meson.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/= pinctrl-meson.c index 253a0cc57e39..e7485c82089c 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -580,9 +580,9 @@ static int meson_gpio_direction_output(struct gpio_chip= *chip, unsigned gpio, gpio, value); } =20 -static void meson_gpio_set(struct gpio_chip *chip, unsigned gpio, int valu= e) +static int meson_gpio_set(struct gpio_chip *chip, unsigned int gpio, int v= alue) { - meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); + return meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); } =20 static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio) @@ -616,7 +616,7 @@ static int meson_gpiolib_register(struct meson_pinctrl = *pc) pc->chip.direction_input =3D meson_gpio_direction_input; pc->chip.direction_output =3D meson_gpio_direction_output; pc->chip.get =3D meson_gpio_get; - pc->chip.set =3D meson_gpio_set; + pc->chip.set_rv =3D meson_gpio_set; pc->chip.base =3D -1; pc->chip.ngpio =3D pc->data->num_pins; pc->chip.can_sleep =3D false; --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4488261593 for ; Tue, 8 Apr 2025 07:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097053; cv=none; b=hx4y9MSTkCH7Ar2eHh2NihzBvWEwUCleKYJp91bMQgYvmK6p8JI0wZbERoQEIXISkABJaM5CSP3uco6QarVHnMk1fYfedPa7BYHARd0HOwp1yHuSw9ON/lp2aUBYu8XZAWIk4UheD11zV5bMXlKp/PQ2l+B3lTH5FziEp6WESJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097053; c=relaxed/simple; bh=hmSxWGIiK/DtDwGKJHp041KAlwlf/8OprB/NVG8dke8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aeyJNWUAj8Iq6CthuzINYyCMgLZLHzJDqSsWpvLKxPCX6wQ0GeVf8hIDkfQ1BZoZKH0PZF8N1Klw4Pu6q4/LWjZNePlspONL3+e7e6LIF4VrGBe1JZlHxlHjRiQzQXA7yWxPE96NgJSFR5/P6nM1vIN1jXoCBkUOlDOOaNTJOBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=BjmtHDyu; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="BjmtHDyu" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ac339f53df9so909675566b.1 for ; Tue, 08 Apr 2025 00:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097050; x=1744701850; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XOjNNeHzyY58LMv3k+FTJZV8HBjSzUrYs1slCEoFb4s=; b=BjmtHDyuKnlFfBK0vH6M3+3br0zZ2mFCf22sAkLEhxDNfcqlU3zP7hvE1HrwBN6SLJ Ihz59AlOM5u0OSx1n8DQqBBIjQS/HulxCk/79pe/RVPCo1aYjP/vS802U4vTgtLxDuQd Mxo7bDrP3q9U++6m8FD3s/ic8arsNtg266LUPDoQ1dveybzWmn0F4NRobCsJ84xtYMxn I8Rng74pSBwBvo81xVo+zQLySQKMY8mGBGiHlgHWzDedurJNP+haXpE3nQeZ9WGStw+c SpOXkg7eaOfz2E+ZS78WVMrZ0rC7GoZeH1vbQP8ZyMScu53Ns0QuBBQfF1t0JBIRQ7tx XIQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097050; x=1744701850; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XOjNNeHzyY58LMv3k+FTJZV8HBjSzUrYs1slCEoFb4s=; b=viy4fKeZUgMYM61drhEr8aRKKpnRpJdskHZ0IMgtBUNaUGnF1zGlXHHX1rEZcBZwiX g6Iq5C3W1CVQbUToeOGGxRX0okmAiSMSovE1KqAYuMX5B69FNS9Tbe9IdG0cbsofUauu ocBwRwSXAp7ppybbF2hdFOSsY62yGc4OPyDxTnqIRvc96D58xq0s5K36sx34dMeljLNp 5PMq1PNZ4QAO6giQXfY/aaZFaFqGWy/Lbkn2Nu/qSTQMD1FCYarHPLs9kXQN01Av5J1i +sYL1n5frY9PyBylC6bHutfwFqXUIsTcXcbkP404uyd6WkZNeT7yDaqj6gTlNSWkyYzL mpMw== X-Forwarded-Encrypted: i=1; AJvYcCX3zds2c0Y5FGoG9iXuSZ9oC9SuyxCofn50lFDrvwl6rh0OgyCXEbaDxy2IJP4fm3eWxCuJx5wq6ozEdVU=@vger.kernel.org X-Gm-Message-State: AOJu0YwZddhb9IMyLIBvkievHN05fUkQUQhMyVWRgnvIqtZLI04tSnsU PAd6P3begZxQYy5nR/r1h0S4NscphD4980R7IkedACAKQCmOD2UX25ZEzT3SDkHVNj6HG9XWuKk cfwk= X-Gm-Gg: ASbGnculZazMo3DtsAI96Vx87OIJeSxdBg0qn4pJrYuTSGJBOCtUcd89QPbREeP4iwj CYtdu3+87li/t6Cr08sxWn5FWjVf7e6YYQY0zgqcioBrNEyGExu+kMfEehfcLCruQUCaL9XrAO0 LQVJK5TVOLhCDVNUJOr3SJnnYU6/nJ9VbPv/oqqiXfXlRcAMOJJtavk+v5gIWmy1Q8vJl88lnvk tRY02myytGk7Xek05IkLiOPuX/lRszeD6wjfbEvQpADoGRfOJdi5MXIbzpxTzDwW7Fd4Ny7TVr7 U77Y5RmE+OoCGMrJh0fFSc+mgjawVOfrrIumFw== X-Google-Smtp-Source: AGHT+IGDlv/Wz2Tv0JI+8Hx2njCPUM9rczyDR5EAPHa4oqor0nd3oFYHO3dEgeKjIpQ3eleoyeURtg== X-Received: by 2002:a5d:59ae:0:b0:39c:27cc:7ba3 with SMTP id ffacd0b85a97d-39cb35aa8ecmr14702868f8f.33.1744096676320; Tue, 08 Apr 2025 00:17:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:55 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:43 +0200 Subject: [PATCH 06/10] pinctrl: amlogic-a4: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-6-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1680; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zFDAJ44H3rDElvqiaNPmVwvOeCsvopBV8K2+vzPv+N0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2aCcCPhwuF/Scl+dWhUvbWutpdgADlyzo6E dkwEIOpAkiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cnRjEACRE1eo2DpKjHGbPlQbMpv86tO6SMwS6frSIq+KfYxOaODnxG0vYoNPl1XeTMMPfKWxuKo MspJKWTkvUN0QuIxmjcZ8vBjIh2Ssf2biltkgH+3Ut1/ExIvxXr/M7gT0UOy2/r94+c7DkVzBEK MXr/4KXQXVZ4OSvLf588xywzpAYfsAPShtYaqDz9OdGk8uc9fPG5lzGH4ccc++V5cuv0ZlY9tD3 ZXnb+hLdVs0BvC1ESV29eq9xcIkTRj/KhdzH4WdJDJB4Fx4xRvCBxuTrv9+Hv2FE6VyVgnX8Knt wPQY7lA3cwjzj0sWtwauKnLeZ0x1DD6IMexNhfxrfvgGpEXh0w3i09yOn6vnAvTxetgrzUoiZsq 5210n+9CVXDRsBqfEUuqtBOx2/HJBwMibEOeyf/tK8wVBtbrEFq1ji769lP5H/PGJUFNT0bPXLd vnKVHrJiJUiyX0REr7gSm1AjTYXZb/jNq6PcBIY1JG8vYGaruh/7KsvN5PbWlmeIxn2DIKitoEB 5c3paQ4gObhMQ1lHal6NduGavNkTb99awzhp7MjrFLQ7vHEkk6LWPVdn1/obav1Qnh7bwi6/RYI rfIeivF5Tge1zaLyASFLrEOQUIffbwsDEofBTf4iFicbK3EDjEXXtUNKuD4DDgO+q2/1XPzUYDj IgJ4xDux3XMrr+w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Martin Blumenstingl Reviewed-by: Neil Armstrong Reviewed-by: Xianwei Zhao --- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/m= eson/pinctrl-amlogic-a4.c index ee7bbc72f9b3..a76f266b4b94 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -806,15 +806,15 @@ static int aml_gpio_direction_output(struct gpio_chip= *chip, unsigned int gpio, value ? BIT(bit) : 0); } =20 -static void aml_gpio_set(struct gpio_chip *chip, unsigned int gpio, int va= lue) +static int aml_gpio_set(struct gpio_chip *chip, unsigned int gpio, int val= ue) { struct aml_gpio_bank *bank =3D gpiochip_get_data(chip); unsigned int bit, reg; =20 aml_gpio_calc_reg_and_bit(bank, AML_REG_OUT, gpio, ®, &bit); =20 - regmap_update_bits(bank->reg_gpio, reg, BIT(bit), - value ? BIT(bit) : 0); + return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), + value ? BIT(bit) : 0); } =20 static int aml_gpio_get(struct gpio_chip *chip, unsigned int gpio) @@ -832,7 +832,7 @@ static const struct gpio_chip aml_gpio_template =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .set_config =3D gpiochip_generic_config, - .set =3D aml_gpio_set, + .set_rv =3D aml_gpio_set, .get =3D aml_gpio_get, .direction_input =3D aml_gpio_direction_input, .direction_output =3D aml_gpio_direction_output, --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 571C325FA34 for ; Tue, 8 Apr 2025 07:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097006; cv=none; b=Gp+oBUg8h141HuEDNMaNyIFyGJi2WPazk7QJoUryRx+pROg4WYPK+M/8nh7lUcbN/81MRUPKhg+2Y+lQI1uShXGu4knUE4lPyTswp/9GkYHTuCfKdYgkZQH6GQ9lzJxHSeq9EMLV1jUjTOa/Y6K8DdxENrW/U7hOKzICTXiBftE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744097006; c=relaxed/simple; bh=1pHaIND2KYP7IQR016ZtHvkE+J/KYHTFCXPcGNsWjjg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M9ubdfM7HQgJmdpRWmre5B4tlWh4ckTUuZKs9rXlli0Q1nD0Y+mHXSvDBXDoi9Kux7dpJNLouLkooT5r8qvxY8UPJ4aBMZZ3fPhj1eWNgOrJnE3BwYgG382VYhHEIU7OMLHrx0KV69JW+XpmiiC7Ql2k2+YupB62uY7Ro/vOuK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=sRcFrueT; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="sRcFrueT" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so51277915e9.3 for ; Tue, 08 Apr 2025 00:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097003; x=1744701803; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o6prcSe997utkmrj2Wk6sqfMRushEUX5sURGCDCfQ/A=; b=sRcFrueTQ99Ls4ZePpZRhqqjFiEhdr00YQ2x18TcI754TcEF/sO+fins1dCOC9nfyA GXfylqJEnhiOzZ7j/dCTQE89Vi30wMuU8NMDruU07O7Iy0w6c4LHourIbNGVIMFKlLv2 2eJI0KM42SOTKWTTlDPtGcTXiYdNjUHf6VC2VDIyY36ckfSOp8S4LzbA8YJK9Ln/Q3Ql GRetzl4AwxI0xTaQNbxa+55+RPyOKq4phmGXNju11NvLg/9A54i57Soi7lHoS+AKhsiT Xr2mEs6tv+i89rS9xh8jA0njfa6mhkmfdm8TXVDoCj6ByYOLgpd8kvKy/Svw0GNfVrTW xW9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097003; x=1744701803; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6prcSe997utkmrj2Wk6sqfMRushEUX5sURGCDCfQ/A=; b=baXiq/04ujPd41P3VhGqEvmtd+r5xdIRRMDN3t6RS6zeW78APjT5ICFX+CYzj2CZ1o qBES7gSiTmp3qtu8t3AjP8aOiqrZuk3mgD5XN6VkeHiieKVPvotxTlOck9DtTkIM/exf V8LOsgCpt680Z+bhmsJg5JgSEAA67ov2aLEabkko6+/atN9A9+Z9FcVmw9M8+ZIj1gWx 7bGBwkTLFOtA6GkA4BPLWB2AfzE7yWKtK6+13s3sUZsc+JLnjMSnT+DmUXAXyoJj7F7H SExIg+N/F0/4ofajJW7Zwqy4AEOQVtNoJfgklfgy7zkT0HCt4zKYFmhssSR4Ti8T+fw/ 7MYQ== X-Forwarded-Encrypted: i=1; AJvYcCUwj3ftjQfx+Ip0Mi5JBJW0XxD19eyZkXgxayzmg3N4Qs9xnO+dQ5rqkqBxtZ9msyRhQtMdYzJTAZTuRms=@vger.kernel.org X-Gm-Message-State: AOJu0YwYCP5FQoBE3Wyv1G/lP4mJcXzUoA550P2qhzRU91SWqVdGSo5m mRLHZTtiTZvQuMotQmiudEvtC3QFHsV7Bi98x6GAl7MbhOhY9F7ywEb1YMsSrxLCId7pClUFp+g eyd4= X-Gm-Gg: ASbGncvvAzeO1tqCL1+ks3vGFE20FKaWdE6UJq0fa2LuH2u3KPEJDPkWICAoYbwB+GQ wUn0Q/7G9jxmxZ+ktQ2MRqiMAo/60hhrRDxzSb+J8V8vLYCMQBOTB+cEI+HYIBC2/GpD8bqaV43 gN4LNzoFZmmXPGWlGsqclDZG05QWiRhOTrE3KF/OEexRvi6FjZS/1V5uD8+gE78QT6qbC2xo0VX J9Ro3qF3ZV32KObcE2H7Q2eMtfcHwxZAJikyq7tdhG88lQqpowg1SOfNfLZMfS/Js6QCRtF8Av/ km8xrO7xWv005HQ1aDz4FpxwR4PJxLj9W7G5Yg== X-Google-Smtp-Source: AGHT+IHzySH+p8lRsbpEKp8XdjRw3BmN8WdHjMLgCKHMXaLLom4rGv3xsF4growXW8khurtrZ60whA== X-Received: by 2002:a05:6000:1846:b0:390:eb6f:46bf with SMTP id ffacd0b85a97d-39cb36b298fmr15212511f8f.5.1744096677281; Tue, 08 Apr 2025 00:17:57 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:44 +0200 Subject: [PATCH 07/10] pinctrl: sx150x: enable building modules with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-7-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=667; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=YmzRn8TzGA6hsDQ4Ls1ViAlvgo7b9jMn9Wlo//Y9vfE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2a3aI8tyRJWFB0j50+lYKjuGbu/ifeaeFQ/ 4M0t4m17MyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cnJ4EACh4EPB2PiBQrpFxrQpn3I5/hHOewyCLs6D3bGW26OisrbJ6BrXg5SN88KZnurmvDHsuP3 MvwP+6leXhNTitXtnj5TQxtJin6NVZ0Al8MJyd9xwa21k8YTlRMm7rgA4Vx9CNvjDV9gf5XOdBF o3JYv1QhJr/SgcdkDr5Ox/diUgdt5Z+bjO2zMLW0i90TN8XxW/blNaWT5xnj070aBbwHIva6E+l v1y1VlHp/I4MrpZmV4MtqxBFHCOAQZEOd+itR+n/S8LP50+qens7NAVqfZhfaQQ7KSmLbRKJpm5 kiG1CDXKTkVqJunSULnVtRahqu1J6ZcmwDJeXTo5PtKQZiFIlUHRjOs60Av24wdhwd+FY4ptQOp pU+EYeQcKSLcEMkga3AqSlN+IrU5XJAo9Y4FLczzGc6/9kTe7Y/MLq04J3fmVsp5KDuJR98aytJ 6m/1/sJrIyiE38hKgq9Ta2I/s9/NjynRehGmP87FTcRsCV1bnl97G4/o6CZtPg/knk7WmCFCogS WBIkWDQrNxAYw16mjSeY+350vXO3jYh+7OIbRVqdjqYiZKSAy9A2h4HULcXVra+fEX2z6ALsNmI gsWEWEJpEXYy62lnL9J9OTf1+ihsnQZFt0jOnnge9cZzyJTQW7bhCj2GDkVkcgK5wezSQQbuork C6IVZWbEkEfQnFg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Increase the build coverage by enabling the sx150x modules with COMPILE_TEST=3Dy. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 464cc9aca157..94eb41bb9cf2 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -541,7 +541,7 @@ config PINCTRL_STMFX =20 config PINCTRL_SX150X bool "Semtech SX150x I2C GPIO expander pinctrl driver" - depends on I2C=3Dy + depends on I2C=3Dy || COMPILE_TEST select PINMUX select PINCONF select GENERIC_PINCONF --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0FC520B21F for ; Tue, 8 Apr 2025 07:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096687; cv=none; b=WipOFN07ZUQ8K2/dUNmApIkAnHTHu/YLKaZqI34/0McPJOOmJtxQrYLKvKG2KrQFJm+XcUCaHvkYTQf0+kQn1281Zz3pSjaVfLvhwsJJmFN9I8DiykosNPbALtEMG25gBs0R+U5WKPQ4SBsr+tbJzgtrBkPLLim3g22oOVIos0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096687; c=relaxed/simple; bh=4OeEvNCO90SdfkhPZOcSBTLFif5IjDlQ6OH4KtQtVEc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bZRG9kCCq7Aq1Sn2ol5kQ3ge8Zyr/JOFmODwxpytRQ7qagZRed7FzxwC5Tu5rzFY2UYrblN+lzOLHuPHWZEeJtWSZrXAr0cOOztF3XVD7WwRNZVstChRDG6AkCAOs04EUg6SYf2e8rei41TSEgeVR9CIE4YxFkYpKDQgdbHp30c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=qo/a5V76; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="qo/a5V76" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39149bccb69so4774367f8f.2 for ; Tue, 08 Apr 2025 00:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096684; x=1744701484; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XD5pUwvjF21WHvNYwLGg3m0Hf3jMmd7qTIORgnVtv+o=; b=qo/a5V76n2xs0csvYpfsO4UoM42pDDWeoDiANNzRichyV3ra7kfrAAp+hSTeojQTrg Q0sQinyK0F4wdpkVHASBWRYc9URsshWf4GfRH8LWtaboUs2lhROL/KwpMB02njq1zQKA +9p1HRNGvRzK9R+CzZyb0OXs4b5S7s5JOI8aA2hxfrJX/B5GJHStuHD+rUgpJ5W4LUXA cBzYKTE57FTJp/rvq4lL74LHK95x6Q20S0O6LCszaqjfbVGK0j868uPQ6NHTSfOipbxW 9xD9RU6cTKxjBMFXe0O53hF8+8R5+Jo+mwdKSbSfPwnoCpP/ByHevBHbuY072iqyWktp 0AOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096684; x=1744701484; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XD5pUwvjF21WHvNYwLGg3m0Hf3jMmd7qTIORgnVtv+o=; b=tM19WFwcWXXiN076B1RiYApdXd8HEGgBmBRDoFYovg8FAanHfze/tjWQd41hTvw0lE gaco3/2QGAbk/J4CxkVEqwUQ5JlrLVq0XH41jJ7kJnnE2QqTzgcnWyFwVZlg3/J718mE +IpguRjTD2EHad2TBoqyLzQeBvJKxaTorXApTigzabIGC5PGCcY/y2mYV6c8cqVIzdBp yIblCwmw2KMyC7mPO2JPF2RwXdL3mHe5oJPoDoUcJBvP7j1XooDz5tGwwpVxygW/UEeW a+EJu1G5ee1ZbKw5VKkt2WZEvKFFbVM3Qp6yYPZBR4w8UHXjohG5YUHVOAaYTY4HH5vB jUkw== X-Forwarded-Encrypted: i=1; AJvYcCVl1rwz66rHHuUHVV0QDnAtm+etgtOvA0at5PGDZqpZFYP/Am+plXYHejP9y+MTvcGvF9kuUR+sTsSBZTc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn7JSKP/l9zSPPyQ1EyD2dpHbqeYn1Q8qlCVk1dbF/IEUMLGjn 7q7ez1igwVDNGrf72xptf6YdKYR5tj81KoUeu79QOiPvHI/TKICRCK6ueF+oCaku//8mEFsVP7M Yx5o= X-Gm-Gg: ASbGncsI5Bb4O43h/cK4D5jcIULoXdNis0XdDjKpFMkkHmQw/ouU4SOBHNTrtuwQPQ6 iDg3Vl5d8Xdc1kGUg8SW0S+GQNdFromjsTwi4Xish/MsIos+cRMU0IlSvKKjeQJ1WQHkyA4t9GP XO1ilmLBTBj1alz304N4VIuSbchKHBQET+LMo46jO4Bwqazllt5jWhbBvyO8RUb0OJu5mAIyOuG 7fmLpBbEo7cJGdTeuQ9CTAQEtRVn5mIOlY2QPPJHq5cnFDT+iTprzg45hM7QJ23mW70lySl9a3k 0EZ6OJFXfRIN0bpnWVgnQAwZZ/j369zYOq2QbnfBRLk2CE4Z X-Google-Smtp-Source: AGHT+IFABP+0NyYfjrmBkKOY8Qu8GHG07RX08meqZeJWYd12gU6oEH77JekbQo0tofcJZaJ2znOR0A== X-Received: by 2002:a5d:64cb:0:b0:38f:4d20:4a17 with SMTP id ffacd0b85a97d-39d6fc48b9fmr10149766f8f.13.1744096683833; Tue, 08 Apr 2025 00:18:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:03 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:45 +0200 Subject: [PATCH 08/10] pinctrl: sx150x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-8-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2534; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nW90rn+BHn4CcA4KM6329dEBeQrDE0H95eIQ6kXIjjg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2anp9vmc2BpNT/BOe9JwVC3uov6dAPDjgly g/s/D9FRDaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cjUhEACQA8gdiny3H0cIs/eCXCdyJOM9rKhuf2+4gj2/MdJ4pjxMDZN3V2spjwTYGEBIvnaD2aw 8YI4+5YrJ/gacqwT5jdjBrv5M86+lRF5x86+aNRAFzrvKT1fp2ZQOSVCdFg5c/pDmPEU8HMJu85 eZM4/n8/sw0vlUHZ6wC5A3oX5Sbxxq0ODdGC1dCdre8Msr4AIZF9Rud/U0l/y22pDHy5AKDsEBJ 45mZjH1OmDd53+rAicyRRakUYgVM4hjGDmZuiAYrNQATMYnENj+DH367L8luvpChW7o8fHoDRZ8 SOKri5vWh0/qd01aZY1waCCyH/8jjdOf3v663xcAX+vBZg0z11mfZY544nqEXoIPun+NYhC9goA +elwZSvzY6TjL5X3SaNFiWSrcNSGObk3otEPfb1/Rys5r5iJNEucwjKiGjKDVc0/WJC9BLewaBE yHyUqES98sh2Ku2o6e40CjdKDsXHwa4Nu4U873+GjpDrypUhlpb83ax2OzzkXuHv4mvLvUQu9lx Op0AGrK6iBc7LT0wuW6I63145+LILkjBnDCErF8JdK9Kjq1HYTLQvslx8onmZ3l8ge9yrQfWCGV i29GbD3Msfrbsdl06ZuAND29xiKUyTaL39tudfMlz6CPR/ii5YZmxVuFSe0vVWBkc3Pxb7B/FM8 aL2+h9Qb3cin5zQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong --- drivers/pinctrl/pinctrl-sx150x.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx1= 50x.c index 98262b8ce43a..d3a12c1c0de2 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -432,24 +432,25 @@ static int sx150x_gpio_oscio_set(struct sx150x_pinctr= l *pctl, (value ? 0x1f : 0x10)); } =20 -static void sx150x_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int sx150x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct sx150x_pinctrl *pctl =3D gpiochip_get_data(chip); =20 if (sx150x_pin_is_oscio(pctl, offset)) - sx150x_gpio_oscio_set(pctl, value); - else - __sx150x_gpio_set(pctl, offset, value); + return sx150x_gpio_oscio_set(pctl, value); + + return __sx150x_gpio_set(pctl, offset, value); } =20 -static void sx150x_gpio_set_multiple(struct gpio_chip *chip, - unsigned long *mask, - unsigned long *bits) +static int sx150x_gpio_set_multiple(struct gpio_chip *chip, + unsigned long *mask, + unsigned long *bits) { struct sx150x_pinctrl *pctl =3D gpiochip_get_data(chip); =20 - regmap_write_bits(pctl->regmap, pctl->data->reg_data, *mask, *bits); + return regmap_write_bits(pctl->regmap, pctl->data->reg_data, *mask, + *bits); } =20 static int sx150x_gpio_direction_input(struct gpio_chip *chip, @@ -1175,7 +1176,7 @@ static int sx150x_probe(struct i2c_client *client) pctl->gpio.direction_input =3D sx150x_gpio_direction_input; pctl->gpio.direction_output =3D sx150x_gpio_direction_output; pctl->gpio.get =3D sx150x_gpio_get; - pctl->gpio.set =3D sx150x_gpio_set; + pctl->gpio.set_rv =3D sx150x_gpio_set; pctl->gpio.set_config =3D gpiochip_generic_config; pctl->gpio.parent =3D dev; pctl->gpio.can_sleep =3D true; @@ -1190,7 +1191,7 @@ static int sx150x_probe(struct i2c_client *client) * would require locking that is not in place at this time. */ if (pctl->data->model !=3D SX150X_789) - pctl->gpio.set_multiple =3D sx150x_gpio_set_multiple; + pctl->gpio.set_multiple_rv =3D sx150x_gpio_set_multiple; =20 /* Add Interrupt support if an irq is specified */ if (client->irq > 0) { --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC5A5263C8B for ; Tue, 8 Apr 2025 07:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096688; cv=none; b=guMh5fZO0kZ6Y8SloHar3p5vrMuZguU80XtRjkYyxl8yAofBuKDVj+g4eI+mKgcghfqxixpQQIBM1h4cki1hUYqE2xdysEZS3GjcRBaROJrYQa8uVvN73CEPb5pf1d/yqftBbHv0ZimVi0q3Ler+asgPK0HSl+Ix2CvayvldyK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096688; c=relaxed/simple; bh=l752bRx9ig6/DZFR1lUNJZhYOvebM+yZK6p05T8xTlk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ScjDRZBPQTtcUu1GQsfJV8tnLu4FsspYgBzhZx2L4HIjRewz1EVzUfWv0Pvwcp6OS7ZPs5y5uBuXUKnQmZPNfdFybk9UyXhajl4kPLA1lJlsyybrcwzKVNjxAiXe0kFFEvLSba1tNcwST//IMHktGj9jWzh4N0mtnYfCET+zr1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=1TvA6aIa; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="1TvA6aIa" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43ede096d73so20959845e9.2 for ; Tue, 08 Apr 2025 00:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096685; x=1744701485; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5HVOt+4srGnvQwsP1v9+2VHPQ1xwkV/AAlcGkzlseiw=; b=1TvA6aIa/P/3W87lXp1RxZ3twYtkCNekFbF/a681O8Lr/RFQvOiwxiM0DZf+l7sdxx IRMuJvgu3/QwLSgHyUBF3T5tQGTkMopiJj+mMVG11AUkTFPxcGcQhdoTMekzmtbMMf0b dR8bqcNIELHyAcmsVO/jbKX1XEw2ivfHSbdsG2hNfNUAXJAxnKHCxGxIa/fsGosb4+53 9RefJbr/jiCseA0VHteJC+bLPFdn43kyle0fsDO6CwjA0XeXbEEvnk0IGZm1CfCqDHGm g65aG/R1wiDsnIiUX/uZfceuH/rsiY1S8aCKAJXeaMgiT5yNDVBfAuNNFDAXDNY2qlwa 8/Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096685; x=1744701485; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HVOt+4srGnvQwsP1v9+2VHPQ1xwkV/AAlcGkzlseiw=; b=NcmJZ9LUvt05vtNyYmwkIDFmJ5ZyIb3z8cMjOhLR1lDIPtBhygPv7ovKv1AvraonKq fHpdKexYOqdHHdff+EcMpXzZ6OmFqoj08BABh/b3fTGCJaVpxC2paqWhqevOoj+f33m6 MVhgazDq9wjFM9yHB3yYj8EcHwN5LfRTwZgZBHCAf3p++D+fqt7OaP8P+IRBPAyjGpPT a+mOwJgRaWJZPDE70BduJB1MophmEBCnH55VOHJSIjgsE5Yy8Aqn60Zoqpre4rm9i7Hh b/qBaRjDrKIB62YcydVfu1jZqnoSTzQuq5LWiOh388SEPlaQqqllwF6ap9wkbn7m6Gan 9pbg== X-Forwarded-Encrypted: i=1; AJvYcCWgdC6O9JE3fKUVhBZFEcRKav418YoDU9seBi9MWe/yBG3u88wtdkjBYD4qwJ5Xbnxh03wlAjtmsNLabgQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1anCwpNXaLxGYOq5rhY368Pdq55DWNwzAe/UyJ2Ae1zZQf7kP bIf/T3z69e1A/lakacSDgnrKwGAjYHETN6oENPyl2zfKB/c1ETssn02mwH7Vv/M= X-Gm-Gg: ASbGncuTroogAyOIPEPP5qOwe4xROlm3GUgUM16fxRh5KSMSc6kw+4CyXuMvo9ZcdIp 3vjT3jQzYWW9UGjs5F92NU3decOmqOj3HxaF8lUjVt0PPgoiDaO8F7vIVaxSYuFoSq9C/RD2Pia dC+yFI63n1T3VIdllaRTe51QV+nECtQoGHjDNBN5gow8kyy/Ey26t55ZF6MjpLmAW0UYlqSwOuW 5jNfFzaFWj/G03vLL4LZhwy0VtIpV3WtoClOkYQKpinELrl/MAoqbqAoRfm3Td8ww/L2sReA3w+ jmcShs99IyJjHEP/1C1n+AUV01kCwnUBb4qT+g== X-Google-Smtp-Source: AGHT+IGSySduYIODYDDBNhKW+V8JxaftIxx0mbfbLM56e4WvjRuBEIilNZOQDJkJo2kY1AIOFFw1zA== X-Received: by 2002:a05:600c:1d28:b0:43d:7de:16e3 with SMTP id 5b1f17b1804b1-43ed0d9d18emr123594385e9.24.1744096684912; Tue, 08 Apr 2025 00:18:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:04 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:46 +0200 Subject: [PATCH 09/10] pinctrl: ocelot: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-9-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1855; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=spvpQCaMJt/FlIsnba8JPp3MhbofiKGgIiv9FJg4rZg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2agt3O6aR1vCS8hOqHTDKX4aiCLJ+nYrJpF NCIW4f85ciJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cij6EADKyrhyl0qDS61cTLux6MOWrF0i8ovx0ZQmpwIhr0Bg5B+CblqHxvZat19Nu7Z/KQuhoxa 5a4ZjXS8zPhwsmNHcJL8XmmCO7AuZyzbIw/dJAygTYI6OrSzueQYkwP5vZpAyxet7FuT1YH5JCw AKvK5JuGVvzXt/1+S0QhyqRa1DBk/r9qW/PGztC+Q+1JIP2r7feH6HlncUVIUwcUmAtz47d1GKU d9WdVpTnCDHkoQOSX43tLjkyf+bWEUz35UYdBYvlfQ691lbhiEgyJZo8cU56ecomEvyTazRrZel IPsNTSh1TYRxmQ/gG/yks6vYRor8W09Gaw0FrsS6r5ifS5/BdkYI0/W5gX6I54YDaQYReRflW6G e96ttMnq/Z8KuMsKIUEteJbJMqomGgb5fJ9q5gEIw3QafPDTn9G5b99Jco4HVa6RwDPA5/LAXmY ttBiDSb/t7dTmdHdHxNHdzkYKzwk2MxkH34FBOX0/wo+7HoCuAeePRR1D72+DhbDm40qtzwPhIW Tkd+O16r6I0zfcX4kMUD7znBhtCMNTTSCyKjzQofWO3wqRQmC/lxZU+m+9WjsnCobS2jV6bTGb/ 6HE1y+gTQLWisUWQCGbsYviBPph9oEM1aA7O3zarkvGGcMtGx5/W0bKBdZ2nCh/us7+xv45Qh88 jH2gOpx/XG01JmA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-ocelot.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-oce= lot.c index 329d54b11529..fbb3d43746bb 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -1950,17 +1950,18 @@ static int ocelot_gpio_get(struct gpio_chip *chip, = unsigned int offset) return !!(val & BIT(offset % 32)); } =20 -static void ocelot_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int ocelot_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct ocelot_pinctrl *info =3D gpiochip_get_data(chip); =20 if (value) - regmap_write(info->map, REG(OCELOT_GPIO_OUT_SET, info, offset), - BIT(offset % 32)); - else - regmap_write(info->map, REG(OCELOT_GPIO_OUT_CLR, info, offset), - BIT(offset % 32)); + return regmap_write(info->map, + REG(OCELOT_GPIO_OUT_SET, info, offset), + BIT(offset % 32)); + + return regmap_write(info->map, REG(OCELOT_GPIO_OUT_CLR, info, offset), + BIT(offset % 32)); } =20 static int ocelot_gpio_get_direction(struct gpio_chip *chip, @@ -1996,7 +1997,7 @@ static int ocelot_gpio_direction_output(struct gpio_c= hip *chip, static const struct gpio_chip ocelot_gpiolib_chip =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, - .set =3D ocelot_gpio_set, + .set_rv =3D ocelot_gpio_set, .get =3D ocelot_gpio_get, .get_direction =3D ocelot_gpio_get_direction, .direction_input =3D pinctrl_gpio_direction_input, --=20 2.45.2 From nobody Thu Dec 18 17:51:28 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5C87263F22 for ; Tue, 8 Apr 2025 07:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096689; cv=none; b=b4maSM7jhyiWIlutEZ+Ygor3IWBUdJdLfFc6JSYPbcBTIPbR93CXYF1ERkZI3gg65q8rU8GJu2ZylifR9HBDrNU26REPrOc5I5A9u2n1OttyjhbXMOFaRteoteIWVsbdcA0BtkcCJOyYaG7WC5c+0PBXcqXx0BAC21jdeiS4wMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096689; c=relaxed/simple; bh=S1eRm9ruT/z8xa6PV2GYxT3sAM1tH/Z37d9OcC4qqFo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rBdLbkoIU1/pxRz6rMThLdm1Y7TpQP8FMinb/X7Y7QySnLU4+5NovSqwexHAzo6+KvcQI6/UZJk/F1ifGCLHmzJE6Bsus/A6ZcwUj3X41vw+i3VHXj67S5atTrO2Pzv6AoTdlU/mNIGyU9oIXfPZc6CGZNwYJGvm7omqBhs1oJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lmUj2Ewh; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lmUj2Ewh" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43ce70f9afbso56441705e9.0 for ; Tue, 08 Apr 2025 00:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096686; x=1744701486; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lsLjcRrGKuzDX9mvNJ2l1Pj3maW/MPJjpEEItwHgjBM=; b=lmUj2Ewhzr4TtxbBgCyouo8GVt1gku318lTNsVJjCswA8TJKI4s/kXDj/GKUiAj7IQ MIecDrh0N0XsujNBxfhy9FV3pfe+rgJccIKUXaZB7E4Xd4akWBaXmXY6IwFswEGCgSxh I88fGg10AvFZr2zphUP7meE3F5eFx+mEd4gVzFuXQC7DuLOtUBMxfdP7xj77lh2lf36o fLFCFk0i5pI50js3SEzAqEtgXUTP8aA1TzkIAkvbZRwVu8S0m3DsOHT/lVAUg5HaN8RF KgLPHpA94P2YiyTIWO5qx/NFWkH7i+9eEsoe0sKn6RX1WSTiEOEhHm7rc8tZZPzzm8tK RO9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096686; x=1744701486; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lsLjcRrGKuzDX9mvNJ2l1Pj3maW/MPJjpEEItwHgjBM=; b=hOAIKS80ZQCMd9zZCiOU8egZM/H70PqJxtYEy+szVmFe8G6FLa+p1OSLFE2rg9Cn4J rIuTt61AlRZKmL+BxKgu6DIKyZbpULuYME3mO/fYiqKk2Bo47rM9JDhRCmbDFp8DXkmS IJwHK6R0ba9GUHlWr51sDf9ZG9DbcD6GMeTZ68BJkMaq4ZAJKoM7fdeO1ZLS+l0hKyME C4L5Nxb+M1hU9jUFSvYGRhPK4RrKufkZrDf12BzEdv3MxPuTdY7sPjsojVBpcxcMAKg+ AFflxOjwVI74b17mUH3ekMQZ0KmoZDhy2AarNZI01x+Hsk8bIeX2c3GzTUVB+oy3UEiF ajeA== X-Forwarded-Encrypted: i=1; AJvYcCX8EicwZlT/UY4qQ+zg12Hj40Z2H72wFDRl3YnQz7f0XOMkl/MaiRSQZBX2Uw+H8ZTvGKnVBldPeYUHLJ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9X4HoFqSlKj8ITe6V1CNoe+8mhVB7cstXUNDwAFwRYExfzf1V /soiqnCy3HFB0xRnH0qFWEuAk5IUov8ugmFRxfCldDQIK2VJcjT3OPMCEtp/4KY= X-Gm-Gg: ASbGncufpMyBHudwESahAE/u/C4mwl/TX0E0BuEq9uhFmmFpURqKrO3O0RMZCy/IDDC f+cAwdY+MUxXNSabHMnVwlh4BWjOXevBZKuf0uI3TrKcxMvrIif4oLRwHU72t1ixV1zBsyVmWBk ow8mCfeRTHK6BNlGEqjvtkFoSRBpuF9tjHHZVihX+fx/JnJBf1x6TO+QuHiV8BVKkGyPjaWms5/ OIaccYNK4dOrrxl8WccT44z950eH35jwuYlYsnSFg588qKEfUOmr6TNS9tbbuBkg8luxGFmRTB0 SX2CDBR6skX8Siqkl+ChP4GnWvlU80CYOato9g== X-Google-Smtp-Source: AGHT+IFVLY1WNvAayiNBB006bFO4nSra7Yx4DcKw1yaLoj6yk4wJfEbc8yNlS2Lbk6qsNo9ohgkRog== X-Received: by 2002:a05:6000:40cc:b0:39c:142a:ed6c with SMTP id ffacd0b85a97d-39d0de66a15mr12602862f8f.40.1744096686025; Tue, 08 Apr 2025 00:18:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:05 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:47 +0200 Subject: [PATCH 10/10] pinctrl: cy8c95x0: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-10-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2609; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nFz0ZQu1wB25C83nAY0bNQ02w+UniTfC+j0g7wZb9Vw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2b7PYpEd1QYwzkZOLJp94uziWDLFCT9+cRZ 6jtV1w9v+CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmwAKCRARpy6gFHHX cphiEAC83D/t8tFMiLHRxWuKzVZS6TAwB9yfLq3bsdR9gOgBqJaavIsx28w0liHuZZIj8w3UHJ3 te5PhEz/S5S7Osm2h1k+wsZovOT4+g7Tn/BqJ04NbpBDccfDwNlRHz9dp5oTqhX/I9BxlNdAM6j nw2qiHcJBTD+wKKdTworBCco10+UdxKyIVJZ1xIEUUha9S7j83VF0X/lo/D6JFLOPf7hVAxpMUg UAs4h9Zmbh+zfoE3OX3QPGFNlwtL/UHFHuKx8uHYrmKv0tOmFEJL2FpJ1Dpt21Ue0har4mN7d+z XYTh2aZ5lZBpTRONkVjKs17D58wvSoBeJSXBp60u0KOD5isuDZxUWicE89i2IY9+jkffOPFNBBj hwVA2QcAYCAUMMtWb4BzW4sg02wn+SwW/2TRCl5aUXcF7n+rRnYBTlfmliRX2kHJ3PA3532UUS4 0qF0kn7hDbX9yY7oX/aD3N97/Eyh9HrOfWH13ZdvF5Hh+MT56nrovr0kjLQFazEgd8IYV8CEPDg ZoCCrIrePRmAOUTYwyZAb/qrH/mEh2qLVE5EAVKijNbE+LV0QR4DWDglwYmR6LbjrmcfnyoOS3U 1/73A3TxYyCRipzULEk7VLJXFMw5u8ROVTWk+4s4XCehemi1NJRDj9ORfPUJMTW0b8refz8JnQW hv7fa/dGOTU4VTg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-cy8c95x0.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 3cfbcaee9e65..8a2fd632bdd4 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -742,14 +742,15 @@ static int cy8c95x0_gpio_get_value(struct gpio_chip *= gc, unsigned int off) return reg_val ? 1 : 0; } =20 -static void cy8c95x0_gpio_set_value(struct gpio_chip *gc, unsigned int off, - int val) +static int cy8c95x0_gpio_set_value(struct gpio_chip *gc, unsigned int off, + int val) { struct cy8c95x0_pinctrl *chip =3D gpiochip_get_data(gc); u8 port =3D cypress_get_port(chip, off); u8 bit =3D cypress_get_pin_mask(chip, off); =20 - cy8c95x0_regmap_write_bits(chip, CY8C95X0_OUTPUT, port, bit, val ? bit : = 0); + return cy8c95x0_regmap_write_bits(chip, CY8C95X0_OUTPUT, port, bit, + val ? bit : 0); } =20 static int cy8c95x0_gpio_get_direction(struct gpio_chip *gc, unsigned int = off) @@ -908,12 +909,12 @@ static int cy8c95x0_gpio_get_multiple(struct gpio_chi= p *gc, return cy8c95x0_read_regs_mask(chip, CY8C95X0_INPUT, bits, mask); } =20 -static void cy8c95x0_gpio_set_multiple(struct gpio_chip *gc, - unsigned long *mask, unsigned long *bits) +static int cy8c95x0_gpio_set_multiple(struct gpio_chip *gc, + unsigned long *mask, unsigned long *bits) { struct cy8c95x0_pinctrl *chip =3D gpiochip_get_data(gc); =20 - cy8c95x0_write_regs_mask(chip, CY8C95X0_OUTPUT, bits, mask); + return cy8c95x0_write_regs_mask(chip, CY8C95X0_OUTPUT, bits, mask); } =20 static int cy8c95x0_add_pin_ranges(struct gpio_chip *gc) @@ -938,10 +939,10 @@ static int cy8c95x0_setup_gpiochip(struct cy8c95x0_pi= nctrl *chip) gc->direction_input =3D cy8c95x0_gpio_direction_input; gc->direction_output =3D cy8c95x0_gpio_direction_output; gc->get =3D cy8c95x0_gpio_get_value; - gc->set =3D cy8c95x0_gpio_set_value; + gc->set_rv =3D cy8c95x0_gpio_set_value; gc->get_direction =3D cy8c95x0_gpio_get_direction; gc->get_multiple =3D cy8c95x0_gpio_get_multiple; - gc->set_multiple =3D cy8c95x0_gpio_set_multiple; + gc->set_multiple_rv =3D cy8c95x0_gpio_set_multiple; gc->set_config =3D gpiochip_generic_config; gc->can_sleep =3D true; gc->add_pin_ranges =3D cy8c95x0_add_pin_ranges; --=20 2.45.2