From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2075.outbound.protection.outlook.com [40.107.247.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FA402550AD; Tue, 8 Apr 2025 21:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149241; cv=fail; b=BbznRZxrB/ZT58xCFUVmOnqpKz1fnChi48O4D4raahr5jDThonkkLnpnHa8pjku+YSMmvc5GptstEC/IOOYbbXnO3zCQwc+eVHAo1h5VUgKpn5v28hbgw4I5mEj1BYrinebcMaGNwpmHitSyiuZtoMx42//UQw5a0JxUcPgDJZU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149241; c=relaxed/simple; bh=z3gQbG0/BrJcget2ANEIY6eVCVMxZEBt3sBKmejs3RA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=fqBN+Ai3a/XssSjXxJMwwlNmypPV+xx0v+qX0NHIryxdNanPfJWe46bCBj97wyP8dif8bjRkPFyjp7R/ax7n6oxouaEXMWD9BM3a5+xkutakFRq+K2dAS2572BNSOL3/8BtcVXv4soitpgYTkXASmIlUEXEIe0Of+FZysdd9ROA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=jwDasu3G; arc=fail smtp.client-ip=40.107.247.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="jwDasu3G" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ma2ErLqaHgieM24mxAn95OBjZ2X6YubyNyFPo7OI18Qq2cHB/Z88M4i0eAqE1ZbM49LecCOUGo0LIsI/RJ/L7dwYLHMogVy0s1v4bDWj9vRjvgM1M+Kt4NfILvJeld6v0UEmqKJ9E49lOMlAWHRez0ByqSQ/pT5qk4nVONes9EK6pWp6bvD/Jv3GVgHxhSTiimYxt0izirji3PErjuLvds+h2QNmz/Ri2B8eCOAYuNBTHtuvCI18RenMfBGA7w8JiOyRR32HF/3h9ejtGRWf7Nw4u94EzJE+zmUDcAIxGnUkP99mf957t5fKtzD4IFdOEaSlJr1iM01KTnj9KPOsJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Yhkdp20aOZOX3AoEgvuSdI/148ioIfxDQbW/0DtkqA=; b=TYRAIr6VP28V49yyPSV90R1i5ezgbGW02tuvDWyYpCaQ/4d35mMcqCreyI/+j3ooWKQSV1x3j5zbSaSt9D//YPGG0/S+69asgCff7uLxiXkUAb9wZL/fPLv2h+kP9XP58N9vy8T42kNrIRcftAriH64Arf9oXkr4iMkt/giACXGjJGgOZkw4d0s+5fLVf/aZafmw5wmxyBDBNWnW+uTA3DrgDhoUHliiAWi9C0GabWZo4qQmjHvSyMXNB/0/f9RRl4t386EnMzgIa+Q98ljy+GevxniHN+C7XuvLjs9YYPCqdN7O6TQuzzamoPt84QZmItJNRHVoQ32vrcaC3ED+sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Yhkdp20aOZOX3AoEgvuSdI/148ioIfxDQbW/0DtkqA=; b=jwDasu3GqGnOxH8tLusK4OBaOaeId15BX3MkDqGiPaqN7EtRGJC34zUY4IciKlwAMYx8PubEHpvieczq6BJBM/NabW7Ir5K4OQOcZ5y2kuCYIL1ikiyNgDmwcAR94/zibDT4XDMP4WLl/fwgv+X/JYh/UZ4a0ZC//8RQ9ZYVeI5DfGhOyzGf2vCzgDYONfKdnB+82OC03SS15wE0JzjgTfwKksnWeEaR0vuFlg6qVazm2AXLwqVFYEC99KziRd9gOiNk9B4H5yK3MjjbHV74SM/mlE/6Yd86xDCURRo0IMLm1g9ErfYXZ2AVbwGQakWx90BZy2abE3uxSdlVqH6j8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:53:57 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:53:57 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:52:59 -0400 Subject: [PATCH v4 01/13] media: dt-bindings: Add binding doc for i.MX8QXP and i.MX8QM ISI Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-1-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=8826; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=z3gQbG0/BrJcget2ANEIY6eVCVMxZEBt3sBKmejs3RA=; b=dhBx4Ui8FWTWLWDsAP8pxl3XOdt8fGbZhYsUekrcUSMO1dZoKreMrMwkyYkS1J/6J/4xP3pqd KoJtsHfhDhMDp9pHtLBRCsHec6kJYQ+yQXOxEJc8TXcYgnDh5WHpSK2 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b4c211c-8258-4779-5d6a-08dd76e7dd25 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V0hCUlA1SnAxQW5qdG9NVE9pVGVnN3BYY0tUOXRpOHJleXhFTmhsQy9JdGdn?= =?utf-8?B?ckY3K3BDTkhxeTB4WG5rMjRTWGtSNDJLeFdCZnZEWUUxek82cDJoZkRGa25H?= =?utf-8?B?RHJWWCt5a1dOeTdKT0wzcDIrbkJBMDh0QlBaK1RyV1BqZC9yV2VPdUJWS01o?= =?utf-8?B?b1ArY292VGRiVlhYYUdhWnhzUWVaOGZYYXFuZUVjMnhaenZjeUFkTW00RktV?= =?utf-8?B?VmtDcTAxU0V2RFgrNGFtdmRYUnd4clFOL24xT0xTWHFxZ21FZ1dKbml1cjYw?= =?utf-8?B?RFVEa2FiRnVpNnh5V3h1NmE2dkJ6N25BajZXSzdjQ3RnR0JCWVNVZG1qM0Ix?= =?utf-8?B?TEtzbk9wb0lTMHFJOURVSUFpYzNiSUhxWnJzZ2w5N3RJajVPRThFdm9ma3NH?= =?utf-8?B?ZmxIQ0VuemQ0M212R3hMcFJ2a20xenR4VjcvYmJrZElhRWpIUnkveUhVUW13?= =?utf-8?B?Q3lrZldGUjJqc1ZqeC9Gb0dQQlBzWThTQklwQ0Q1ZW1iNmY5WDhTRTR3SFdC?= =?utf-8?B?WHlJQndWMk1oY2RyL2Z6ajcyU3d3bHRKMVREVlJzVnAzY0ZERGhOcXNVbWlx?= =?utf-8?B?UmMyclRBV004R2pOcnZZR2s4bXVwZUlHS3o0ZlVySTROQ3hLWGNzVEtlTVJH?= =?utf-8?B?N2RoYTBwL2V2a1h4ajBYNzdTOVExRklpSWY5dEMyajhMK2wxYnlxcEU4SXQ5?= =?utf-8?B?emRhbi8xTUdVcEh2MmNpdXEvbk1PZWZzKzFwK1d6N2JGbE5WL2xYRXptMURm?= =?utf-8?B?a3FTVk5BOG9XdHFsNEtSQlNRN3hYTEpsNm51dXpmMEM0ZFdFUDlXRXVodXh0?= =?utf-8?B?TlNBL2FkenU1L2tibVhSWnVIUXVHYVRDazM3SmhMbTZQSzlhUWZIbW9xMDFh?= =?utf-8?B?VG1qNmFqdFk2eW4rMkpDVWlkSjFYUC9QZXdSdjJLb0hXM3duSEI4UUxpRlFy?= =?utf-8?B?cFVRQm1ESXdYTGh0UG1zWXlJTXZLbGRZc0V1d1dTZlZxYjNEVm4wbGR1bHA0?= =?utf-8?B?amJZTzh6R3BVYUhrWGNYZ3ZZMXdjakRnajRiMm53WE1xMm9SQXJnYng5bzRF?= =?utf-8?B?ODY1YVR2K0UwNGNscnk2eG1HaG80a3J2RkxpalBIZjVJQ1VpR3MvcEZwa01k?= =?utf-8?B?WkZoLzhlUUZ2QWFTcWJ4WVY2Vjg0NEk2U0R3V0xxYS9JZ1pDRmY2cmZLK2dX?= =?utf-8?B?V3ZZMGVDRXpjNG9yRmtZVGJwV2pHUWpydHlYcCthZi9GNmZVd0lMU0RCNnJ5?= =?utf-8?B?UmcxeE9CdThlcnFSejVYbVdDYjVSb3pTYjJSYjhTUzA0QUFBdDhGeDkzYTFI?= =?utf-8?B?bVlzZ1F1Mm9uWEsrM0pyWm9TRTZJUkYybUQxaC9iSFZHdXNvRWczcVBxVDly?= =?utf-8?B?UUFRQkRSSnQ4OE91eUp2QlBvdE42eHpxZlY1YXdCWGlaS2FtenpZYTExalBk?= =?utf-8?B?ei9NcWpzUWlCeGRxalNBb0Y4L1I4anVCUVNGTFIvcS9vcjJtVXpLTi8vWHI3?= =?utf-8?B?ckthRFBnQUZ3T1VSV0pWUktXK0lQalRDZSs4by9uM1lzcUxxM1VXbVUvS3Nx?= =?utf-8?B?azY5dzhoNGh1OFdjVnYxQXZmL2loRVhjcC9MVVUwNkNRRG1nNG03RHp5Kys2?= =?utf-8?B?MnZ3WXRpUm5VUytwWnkyWCt4RXpna3puRFNwVXhMbExaSUkvb09DVzl2cWM3?= =?utf-8?B?eXJlV25SdTVJdExrMTkxUTVTRG8rd0FZYy8xNnpFNzRXQldwVkkvVkVJb2hB?= =?utf-8?B?MU96Wmd4MGdJVnl1ZUVkMkhHTHlzT09Tc1V0eHdidnJaWGtRaHBablQ2M1U2?= =?utf-8?B?SXRvWGEyNkhTNFN0WWx5bXRCcmVZNWFlaEUzbitzcWZXMklieVVqYU80MEtD?= =?utf-8?B?alFwS1JmUzRLTWtBWFh6OTNZWGREVDM1a3h6aDdySDA5blE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TElXMHFHOXlVeCtoODdQTWhoSzJlLzdEZlFBaVp1VmthZ21pd1BXdkhQTDM3?= =?utf-8?B?R3l0UldWL0lLdkNUN3hKTFJCai9TU3lWdUY4YzZCSk1xckFhdFh1dXQwWjdy?= =?utf-8?B?bk1ueUR2Z2pQQmxFSTQ5WUtEejZabGtxem0xZjgrNlhBMjU4ZDQvUk9kTGpx?= =?utf-8?B?RnFxbXVodndiaDlOaFhBUnJ3d2twMUlNdkc1RGZrU25NU3laa29sNG1CUS8y?= =?utf-8?B?RkFhcVVPcFhFek5YWjM0OVh1ZWUzYVVyOHVqVW9TQ21pemhVMTJCaXV4aUxN?= =?utf-8?B?R2tISzgvd0tkLzFVWHhUV2ZaSGJJeGtqT1gyaGV5bmdrYUdHeUlpWFF4ZVRY?= =?utf-8?B?M09INWhWR0MvTC9mcnVLbTVQNGttZ1hPV0MwV2NlTHNpWDhQZjNDYUpGNlp0?= =?utf-8?B?N1JiRHVpVEFMVENCTE1taVNKazM5SWpJeHZoNWVWRm8waER6Rk00WEpjQjRx?= =?utf-8?B?dXRlZGNUYlNPVE5hNGJ6RzEyN3ZmRlNzY3JXRlNVWjhjSDhaTXY1aGxta2t5?= =?utf-8?B?RjdqZVc1WENYai81Uk1KTzRrK1FrdElvUXRjY29NNU1aRHFObi83dldReXdV?= =?utf-8?B?ZExSSEp5QWd5aU82NXhhTEExQjcrTFVMbWdPR1UwcVVhR0paUEFrdE9wNTdq?= =?utf-8?B?VG9XSklDYmlQZHc1MUdWVTlrL2JPQ3hVRXF3RUw3NVNjQkhrUmFGQ3BaOG80?= =?utf-8?B?MFpLWWRtaE1IZmVqNER1WGtVOWpyaldkeWJxekN2SGx4REc0VmhUVXQwcWZJ?= =?utf-8?B?dDl1d1pyMWdVVHlNWTg0cVZqKzIwbHRlOW5DZVNrOUlkUE05K1JmbndmSnZF?= =?utf-8?B?ZjZkUVoyeExNNEJ2bzI5a3hnQ1hrdmlkNUMxSVVld1VlcWFZRFVqdkRnTmtn?= =?utf-8?B?VmZQNnhFanV6amh3bHJPNWpKQ1ZBRkxWdEY2c3hodE1ZdjEvMVByUElDY0JI?= =?utf-8?B?bzZSaEc5dCt2cGRZdjMyMWwxUWIzREsvVHFldmUzNlBNeDArSjNxQ0RYVndt?= =?utf-8?B?NXloeitvWGpCZTRYU0VCRElJTkh0cDdTTGJ2K2Q3cEVmdjFBbmk5QWxkemlM?= =?utf-8?B?K0FwOGFCaGtKVnlCRkQ2OC82U1JnQjdlRkorcDJHWUExNjYyZjVQNEFqV2xD?= =?utf-8?B?dm5PbVl1QmdPL1RaaGRtSFgwMW5TdnhlNkxnMzVtOUdyckRFU3d6QmUybUpI?= =?utf-8?B?WmF2cWI2WG9nYXk0ajU1OFZ5cmErSWhyeGErS1MwV29EUHRjUUVEc1VFMVZh?= =?utf-8?B?bW5WZ3Q3NUpoRWhWRWFYN1ZwbGFVQUtWZXdsZzQyb0IvNUh5T1dPaVBjZEJq?= =?utf-8?B?aXlUSjBNcnNabGRhdjQzQ1UwOE5Xc2JJRDZKMHZCem5IU1lDeUNvN2t0VXpU?= =?utf-8?B?NFJwQUpVWkxLaEEyVDBsZkRCaGk1UzgycmgrLzhWNjlFb3RwVDQyYmVCUWdn?= =?utf-8?B?bXEvVXY3MktDWjQrVWFydEV2T0RuOVlCZU9JSlpFckYzUVdWMGlobUlQeFdG?= =?utf-8?B?NmJMV2prenMyMHp5TElpekI4M3FndjUzRkRaUzh5QjgyVjZBQmZUUXNqRW0v?= =?utf-8?B?UlRXeDNVWjlzSWN6OFNZWW43UXF1QmRUYlpVVTVMbERsL3BBMVR2RDUweUVN?= =?utf-8?B?eWd5REhrelhablFMS29GVDEzT2JIQmZyL2dvMHpLOVNkUDMyTTV2VG1ILy94?= =?utf-8?B?WHZlNWJMSkg3cEZJaWZYbElUeXQ5UUlWS0plaFNlYUFaT3ozWGZGQlhnU3hk?= =?utf-8?B?elF0NjlYRSs4cld3UG9sbXpCRnBmemdlQlQ4cVQyZTNJNlByNkJNamp2SEN5?= =?utf-8?B?Z3p3VjdGczFqQ2RmclczU2hXOEk3TW5iUHJVT05QYW1VR28rbCtFU0U1QWxR?= =?utf-8?B?Wm0xK2FaNEJqN1pKc0hmR01nQ1ZQbUg4L1dmdmY5dDA4Z0NaNlZlY3R0UG5y?= =?utf-8?B?Q056Ym5SdmJpNFkvWXo5ZmIwbFBwektZQWo1UncrNDVHNFduK3RoRFZiQmp6?= =?utf-8?B?QllmcFNUcHp4d2VkOXdEUlRxeUhPVFo2OXgrUGp5VjNlWU85ZGFBV1cxcFQr?= =?utf-8?B?dWg4Y1ZqOUNaK0tvNDlpZHdBRkF4N3AzQ0wxb2RxaUIrSlpwY1FPTkJobnE3?= =?utf-8?Q?mAu8=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b4c211c-8258-4779-5d6a-08dd76e7dd25 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:53:57.8496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XaxOfFAf/IjtRcwlx3wG6uk+keqh+sIO3TFDyGI+LT9f/2TJuF+B0Z+xhZHqKVujlkJLuNAwPIWc921YI2VqbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Add binding documentation for i.MX8QXP and i.MX8QM ISI. The clock-names, power-domains, and ports differ significantly from the existing nxp,imx8-isi.yaml. Create a new file to avoid complex if-else branches. Add new file to MAINTAINERS. Reviewed-by: Rob Herring (Arm) Signed-off-by: Frank Li --- change from v3 to v4 - Add Rob's R-o-b - change qxp clock/irq/power-domain to 6. (QXP C0 change 0, previous chip have not production). - fix register size to 0x80000 for qm, 0x60000 for qxp. - fix qxp's irq number and clock change from v2 to v3 - none change from v1 to v2 - create new file for 8qm and 8qxp accroding rob's suggestion. --- .../devicetree/bindings/media/fsl,imx8qm-isi.yaml | 117 +++++++++++++++++= ++++ .../devicetree/bindings/media/fsl,imx8qxp-isi.yaml | 106 +++++++++++++++++= ++ MAINTAINERS | 1 + 3 files changed, 224 insertions(+) diff --git a/Documentation/devicetree/bindings/media/fsl,imx8qm-isi.yaml b/= Documentation/devicetree/bindings/media/fsl,imx8qm-isi.yaml new file mode 100644 index 0000000000000..93f527e223aff --- /dev/null +++ b/Documentation/devicetree/bindings/media/fsl,imx8qm-isi.yaml @@ -0,0 +1,117 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/fsl,imx8qm-isi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: i.MX8QM Image Sensing Interface + +maintainers: + - Frank Li + +description: + The Image Sensing Interface (ISI) combines image processing pipelines wi= th + DMA engines to process and capture frames originating from a variety of + sources. The inputs to the ISI go through Pixel Link interfaces, and the= ir + number and nature is SoC-dependent. They cover both capture interfaces (= MIPI + CSI-2 RX, HDMI RX, ...) and display engine outputs for writeback support. + +properties: + compatible: + enum: + - fsl,imx8qm-isi + + reg: + maxItems: 1 + + clocks: + maxItems: 8 + + clock-names: + items: + - const: per0 + - const: per1 + - const: per2 + - const: per3 + - const: per4 + - const: per5 + - const: per6 + - const: per7 + + interrupts: + maxItems: 8 + + power-domains: + maxItems: 8 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + properties: + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: MIPI CSI-2 RX 0 + port@3: + $ref: /schemas/graph.yaml#/properties/port + description: MIPI CSI-2 RX 1 + port@4: + $ref: /schemas/graph.yaml#/properties/port + description: HDMI RX + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - power-domains + - ports + +additionalProperties: false + +examples: + - | + #include + #include + #include + #include + #include + + image-controller@58100000 { + compatible =3D "fsl,imx8qm-isi"; + reg =3D <0x58100000 0x80000>; + interrupts =3D , + , + , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>, + <&pdma6_lpcg IMX_LPCG_CLK_0>, + <&pdma7_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", + "per4", "per5", "per6", "per7"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, <&pd IMX_SC_R_ISI_CH5>, + <&pd IMX_SC_R_ISI_CH6>, <&pd IMX_SC_R_ISI_CH7>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + }; + }; +... diff --git a/Documentation/devicetree/bindings/media/fsl,imx8qxp-isi.yaml b= /Documentation/devicetree/bindings/media/fsl,imx8qxp-isi.yaml new file mode 100644 index 0000000000000..bb41996bd2e36 --- /dev/null +++ b/Documentation/devicetree/bindings/media/fsl,imx8qxp-isi.yaml @@ -0,0 +1,106 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/fsl,imx8qxp-isi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: i.MX8QXP Image Sensing Interface + +maintainers: + - Frank Li + +description: + The Image Sensing Interface (ISI) combines image processing pipelines wi= th + DMA engines to process and capture frames originating from a variety of + sources. The inputs to the ISI go through Pixel Link interfaces, and the= ir + number and nature is SoC-dependent. They cover both capture interfaces (= MIPI + CSI-2 RX, HDMI RX, ...) and display engine outputs for writeback support. + +properties: + compatible: + enum: + - fsl,imx8qxp-isi + + reg: + maxItems: 1 + + clocks: + maxItems: 6 + + clock-names: + items: + - const: per0 + - const: per1 + - const: per2 + - const: per3 + - const: per4 + - const: per5 + + interrupts: + maxItems: 6 + + power-domains: + maxItems: 6 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + properties: + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: MIPI CSI-2 RX 0 + port@6: + $ref: /schemas/graph.yaml#/properties/port + description: CSI-2 Parallel RX + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - power-domains + - ports + +additionalProperties: false + +examples: + - | + #include + #include + #include + #include + #include + + image-controller@58100000 { + compatible =3D "fsl,imx8qxp-isi"; + reg =3D <0x58100000 0x60000>; + interrupts =3D , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", "per4", "per5"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, <&pd IMX_SC_R_ISI_CH5>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 78467ad7a8fef..977f338bec04c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17428,6 +17428,7 @@ NXP i.MX 8M ISI DRIVER M: Laurent Pinchart L: linux-media@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/media/fsl,imx8*-isi.yaml F: Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml F: drivers/media/platform/nxp/imx8-isi/ =20 --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2042.outbound.protection.outlook.com [40.107.247.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913E72561AA; Tue, 8 Apr 2025 21:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149246; cv=fail; b=omnQMgff6NMM3irOFgkuvsW1Pct2KywXjRyqBhyVvMYC+mpG6ghvv7AmAnXh6Zx6MDVfITwvuHywbRaqt/1aY00qRaP2wM0qaUU+MCDRn7h3n/04fSDboSaCR1mx5f5swGXNSjAN2JQQZaIiHfr5ygQuAaNNbRc3bh3Fc8ivodk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149246; c=relaxed/simple; bh=whffEOlnqKmx08fE+iHWtEpWfG1ym3K0BSf9B+jZ/UM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=baHDqFyKzbC4tupZf5ieIUtCFvq5nD/kBcEj6dG/JaHEN4LGkmAsgFxX+0XUadGEMU0+kskNaMrCZuAxeqCf4ZqPqwm8Vp82OlqRS3g3jPxrY8pJn2x1JIJ/KejSJjXDlAutUdtlOFP90CLpfaVYiVA1Jw4Zy0RidizCWUKb0eQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=SLyxHk2J; arc=fail smtp.client-ip=40.107.247.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="SLyxHk2J" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cdkMZyQb5BO8LBgFox9Ke0C6kO5fp/Z+V3pDrH87dQnb+ZZ9JulBKWKriq6ZzRNwfTnwPhwAbCSY3fXAxFcFHPVBKPWkcLa0khVHqjJh6b8/MgAS16FqDJcxshi8csXA27ETNluYq6hfmWEOZ4QpnOhb8bqVwJ0AsL5cc0wPV9Sp5e2caOgKozcpfLxlcklZT8TrRr5OP4e+ElymEF7UjgyiWT8tWDJpfefDSYKNmPdI0Flr7Fq9nlorBEcx7vhrBnW3PB5CJpY0dIEx6iqaJOv5JLykTyMp7IXiyaW4mXP4z5iaW1fVmRJKqnvV6itrCG+r7/QteZfOdCU13mZXQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ffsql7ZUvBkYVd9O4D1RB7qM9ZUCbJlBPFNukIiFzYE=; b=ZitDWPua5jYrpdL6HVLJdPGWDknLCnbD/3xuqxNQ5QYTrS09i7662HloEONmgD/ezGRJhdA5/uZ+UqoZ7jpv6RbiBS7odeJumQB6EyjvXvlghgB37k8jlMwTuCRdzJ2Rh4PUxCVUeFFrBY+mxs4fW2koDvmVmKWgK3K+bI0lUs02PlJ5BHMEYPjNBLC3xSUCeCi6omJnuhdNEsJiqB7jQEZcWf8nf9gnTRs9iUawvOrI2IwQnTB6JLiAMVoed6KTj0Zseh+0+uPo58Z9n8nTFW/S7aoxWl+UQuMX/kJe/0NVW3KQ5r+Ya9aB8hydwjkgxTHYLv+jXDcm4Zbyym9RhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffsql7ZUvBkYVd9O4D1RB7qM9ZUCbJlBPFNukIiFzYE=; b=SLyxHk2JgxKoV6aci1DhsmgkFZ5I5mXiCQSE21cwca0dMpPtCUB3TU8kP9A2IEXp4DGfWjMAdUcg4A9qqdiXqecIpXfqc7frCpMdNZqBftASWEZ0EXHS1CP/RDBgp6qizlDJnDmLieBJQY9QfClwhmzaPNu9OaaXAo3vERybIOMPDy8jkMhtafprb8rRy+U99LoqaTVlEs7x8pAF+Qj5T0ma/Ju5NCjvjEor5IWWEnIs9Kgq5NoaXFDgrdS1BKhXb6LcrWolHOqeyRPenXTPKLim6C7SKX7kPRq3+VE5g1Sx+7UbvEUNT2rRA3PP5+LJOlbErHme5VK0ZofGXHAhVQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:02 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:02 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:00 -0400 Subject: [PATCH v4 02/13] media: nxp: imx8-isi: Allow num_sources to be greater than num_sink Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-2-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=2311; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=whffEOlnqKmx08fE+iHWtEpWfG1ym3K0BSf9B+jZ/UM=; b=PK+UDnAYVUmFPYzl9dB4GKXAqq4qvb4fjSjqeL0MY1LC76L2Xmj9/FFc+y/3lHgtzET/cAv4f tQqeYEgiYf4AkfT96s43Vqd56n4of0UB+jQfjQ4iyo0EBtF6nke71s9 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 42b45505-1111-4fd1-87d3-08dd76e7dfac X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UWNPN3p1MFc0VUVXckpMZVE1anZyQ2xJcnpTdHZWblFFNHlOdTBmc0JWcUNn?= =?utf-8?B?eFVKYWxHK3RzcEJTNk0wcC9renVpV0lMelFxMDZNUVZkSjhWeWRwemFqZWVm?= =?utf-8?B?SWVvSjZKejlyNDA5M0RZK0t0QjNBZkxXQVM5RTdpUHNMZXFtWHVRK1JqaTYz?= =?utf-8?B?TzU1YXB2SUF5Y0t0Vjk2eDFTYkg1djlVVHR1RlFYT3BCL04zY3FCTGd4OGJC?= =?utf-8?B?WVRwN3BYaEd5R25YSXdGYTRHcHRQR2w3bzJ0OFc1WThvbmU4ZWQwa0dqeENv?= =?utf-8?B?K0tDTDFaeXJhQkdCQTBDc0pmOXl6TVZ0ZHdyeHZ2Z1E4bkY0MUplMlZ4bDRx?= =?utf-8?B?K0ZQd2poTXFzWDg5WXBnRGFTdkdObVZDd3hsTkp3bytvZS9pNGtSc1RGRjQv?= =?utf-8?B?VVIxb2tHTXpmK1ZWMmZ1QWY3ZktBa3lWYmpCR2YyaXlBWnZmdEI1bG9SUGR5?= =?utf-8?B?UmZ4eWVyVGkrUHNTeEFaODVud0ZZN1RnUTVSS0NGeHhrZ1BRR3lGTmRvVXFY?= =?utf-8?B?enJ6WnN5WjVmQ1hMbHpVcU5FaTZBTmJ6bExBZGwwNVR6bEs5YVV0Y3h0SWxh?= =?utf-8?B?SWFQdjNEV2hlZHcxUGhCekxwOTBmdjAvbDBCcjl0VXVTOGpZU2RHbTdaekll?= =?utf-8?B?S0RabVhhb2c5NzhxYUVVZDNBaFJTYkptTUtQdS9NMDNMSmcvN01kRHBaODE3?= =?utf-8?B?YUl6RzlDc1AvN3lxWlpQQmdYTmY4aHFoNUFIQVk0U0V0bzBFOVh4ZjNHZHcx?= =?utf-8?B?Nzl0dnJPbS9PeFBTYzFGR0FJbVY0blhlWE9TdXpCZVg0d04yZktITWNFVDla?= =?utf-8?B?ZkxodmJKUXNxWVVHWWZLRExnUE55R2J0aVVhM2RWenJuY3JXRWZYbnBUbFcz?= =?utf-8?B?V2grL3lHUlhjSytvSXJMY1BoRTc3bUt5V1F5bWVLVTc2bEhoankrRi9tc1p3?= =?utf-8?B?b0RJQmFROHE1UzljNzNtaVhtSENWOEdrT0dnZ2VWQnJJREtKV0VmWGEydklw?= =?utf-8?B?cFFjVHRxM0dHMFIyWjN5U0EzQi9tY2NBT0VVaUhybldEdk5ObUNka2JXdU43?= =?utf-8?B?MHJwcmF1WE52QkhxcEVkemFoZUt4R2RkQm5iK1NJZzlSS3ZJSU1XK3lOdGJW?= =?utf-8?B?Nnl3SU9odVlQWlZHZ1lNbGhYSFB0VHJNSkZsZkM2YUhhUTlDTVhsbVJ3MHg4?= =?utf-8?B?RDhXWnljL25HOHVndEloamhPV3M5UVl6VGRhRjlJbGJ4NlRUZHh6TkYzK3Fl?= =?utf-8?B?U1lmOVFHaWtkWG1FMlZNL0dSdVhHbFRYV29CZUNzb2pzY1YzMStFTk56djV5?= =?utf-8?B?YU9iY05vVVRJSTM4VUNiVGdva2wvVnRPQWRoZWRNUC9RTk9zWHdxWFNUbXA1?= =?utf-8?B?dk5XekJKNzJPODI2UWVmV2VUV0FMYnhBN2FWTEpCVE1xSHBpT0xqZHBlbE15?= =?utf-8?B?Vm1YNTRDdm0vK1VOOHNLRmV4U1dGTXNqRzZhSEEyRDlTdFdtYVBUWjZpenIz?= =?utf-8?B?T0FOZkZmbDNLNDRJTnVUdWF2VWFtemV2N0xwTkFRTk5iQXZ0bzRKRWQ3M1J2?= =?utf-8?B?WVNiUStqT1FtNkNOMURQM1dQZTYrbXIzSmJPb1lycnpqSWE4cWliajJqNUJl?= =?utf-8?B?U1pKQXJrWTdyQm04NDA1MW1tMkFjaFpRMXJNRW9DVGRZdjFTTEt5elJzb0xO?= =?utf-8?B?TnNHZlJjQ2ZqVW1sSENvd01JbkVyRVJ4RklNSlJ5OGp4L1U5QzFhWGdxdjhL?= =?utf-8?B?cFE4cWszWGExM3YxTEpFODNIU2wvMVFSbDlXczJ4U2JFMTVSdDRSNTBQQ3gz?= =?utf-8?B?UVNhekZZVzlTcTVQcmJVU21DeTRiVXdhVE1qNEgwZWppWnMxOTMwemk3OGZI?= =?utf-8?B?d0RJQTRKS2YzcTJnbW4wbXJPd3QyaDlWaTNIVXpQQUU1dDQ4YzUwb05yY05k?= =?utf-8?B?OHQzcFFiNzkzUFFFYi9tRzM5UkNLc2t6SFFGZ0lyRmdPMENiV1pYWXowd1JP?= =?utf-8?B?YmhGMHErODVBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1BXNlBIWlJOUG1FYTFSVDRDOWZldzY4aldzYmNYK1c0TjZERkFna0Y3ZEtq?= =?utf-8?B?RGwybTVhNzFjS1RMYnZpZklxMEwxM2Z4anBla09NaXBzbnp2Sjd0UkRYS1NQ?= =?utf-8?B?YXFvNTN2R1BDTnBlendMdXdJT1NMczNURlZqaVJZdFRpWTFqSm84SGZBOHVI?= =?utf-8?B?YVYzblFubWtOdWpIbmNwWWZmQVpOZDZhcFU1TlBPNU9lc0t3MExDTVg0YUdE?= =?utf-8?B?dENTSzhwaVBveGVTMzhMdy9RdDJrZEtlU0xhOTFXSWRHMi9EbkwzRkZ3eito?= =?utf-8?B?Sjc3aGNyLzdMZTI3OG9SaGxOR3RES3NuQU1zRTN5Tkp0VGVxaHQwd0JGRG9R?= =?utf-8?B?M0NVMGhhdHhuRVNOSGJqVGg2VjQ4eWJNM281bzhPR0RZZFVnUmlEa0JDV0NJ?= =?utf-8?B?emhWVEoyUDNkOGhLQTljUVNHWXVtbldOS0JWOXV6U01VaFpwamJsemZGUmtO?= =?utf-8?B?Q3cyVjFlcWU3dHYzaExsMVUwUkljZHc0U084YTFuYjZ3VmJmNStaYlRLclU3?= =?utf-8?B?WFNrQ0hxbHpHbWFiZWpLdmM4VlRmc2I2T1dJRlRVKzlvSlpxRklHREFQY0xn?= =?utf-8?B?VjhDSXV5ZlF5UDY0ZmphVXQrMkRnbTlSQzFraTZVZEFrOVBmTEExRU92ZFow?= =?utf-8?B?aXpIK2gvU0FjSnpWb1JCa2JtN3h1WnJqYjVpdGFjcWFYZ29jVDB2UHBLWUJo?= =?utf-8?B?TTZ5VEtNaE9zZzVUU0Z2UmtBdHhudXZpUHlXdXgwcDNMazA1Q1RBalNzMkpS?= =?utf-8?B?clBsL2lNbzhiNTgrMEd0UEQ4R2w2YnZiWi9JdG1LakhsVEJCR1FjZnRpK3lu?= =?utf-8?B?aUxLOW5mUmd2Mmk3L1JsSmVoeVVEOW5OS0dKS2xpUXhBZEJlYndEeExyS09F?= =?utf-8?B?eDIzQjBPeEs2WG40NWFWUThLMm12SUpiVkwzNExOU0I2eS9yZ3Z3aHNlWjU0?= =?utf-8?B?THNjbGFhQmRMREwwZ3hWVjQzSWZQN1MzNkl4azFhY015MGtuNGtsMVJGOUIx?= =?utf-8?B?Tm1jMlhsSmxlRXpqbEhHWjJPbG54bS9DR2NsWGRzZlI3SGQ0WWJ4Yk9mNXYz?= =?utf-8?B?NnRuajlBWHdWYW5jK2NUSTh0RmYxSkJmeHBqM2VyY3Njbzhvd1pUZlNwTFZL?= =?utf-8?B?THUvUE5CYlVzY21WcEdWd2RsZVB3c3loWEJQQ1pXVm9RUGYxWmc0TFF2Kzky?= =?utf-8?B?STlXellzWUVnQUlhazRKcld1VWR4VmRqRDBIb2UrbmZ4aU9lVkJ5QktzYVZC?= =?utf-8?B?cjhCakliRHlObG5XUGQvTVhkbHVpVzJiMUE2YnlRUVBKcTc1U3VuNForRlJB?= =?utf-8?B?RmdkL0ZMRVRQVzNtZHArU2p0ejRPZGpZQkxQbnc1RzE3ck1jSmFwTEFLcHFw?= =?utf-8?B?TEpsU1hQdjRKSml4cjZieVUwbFNWOHp2WnJlUWtkY2FnK293VXc5ODhMUDhQ?= =?utf-8?B?Ni8yZk1ObW9pampXMjBLNXFTM1FCMUUwY05QV3NGRzhjb1pyRWV6SjdQeEpO?= =?utf-8?B?OWlXU1FwOFcxVXczNzA1OVplRHhKSUVFWWM5OWo5QXNEQ0VGSVQ1Q0QyWndY?= =?utf-8?B?eW9jUkpLV2pISUJ3Qlg2TmhyUWYvcndxWFdvem50K2pjSjhQZmlaTEhGcE8x?= =?utf-8?B?ZEFHM2U1dllUa0VXQmI5Mnd0NnlkYlEvWVVVbEsza2xCRm5Ea01zWDJ6ZEw1?= =?utf-8?B?NS9XYVZwWFVybW1Vc0xTYnhBZzY1Vmp0c0hscmJYSzZOOGwrR3UvNWNUUWZV?= =?utf-8?B?U2RRNzdON29BVG9hZlFoR0NqekJRWVRiaVFSYStCZzJpa3Z0dWVNUTk4YUc4?= =?utf-8?B?U3VDUlg1T0JXSnJsbW84L3VjT2NuRE9ua3Z1WURMR1ovZlNvVWh4cnUwUG1a?= =?utf-8?B?dFJSbFRnaVhQNjZzdlNRb0diaTc5T09Fc0djeE1WSE9mcTdhS0lFU2pZSmRR?= =?utf-8?B?ZkpRVE5kTWFSRmNXTWtHU3A0UzQ2UzVjZnk1aHQ0SFVEd0RLQkF4MUhLV0d6?= =?utf-8?B?KzVueXJmWks1R2ZKTi9Jcmp3YjFJQklpMTBJeU1laWVKVmdTdnhkYjM1ZlJB?= =?utf-8?B?b3NUcnhmVlUyQ21lZFNCSTV0VndiMmJHdnB6TEp4TTRtYzNZMmZRRExiZGlq?= =?utf-8?Q?FfW4=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42b45505-1111-4fd1-87d3-08dd76e7dfac X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:02.0108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1laf3/iMwoyqoyNgZVFc4q2Zy2G3NRAiBEJUaon0b72Ycl7fgHjWHlX9S49ci8+Qa1qgiqoSC9PTwGXXU1/h0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Allow num_sources (drvdata: num_channels) to be greater than num_sink (drvdata: num_ports + 1). ISI support stream multiplexing, such as differentiates multiple cameras from a single 2-lane MIPI input, or duplicates input stream into multiple outputs. So num_channels may be greater than num_ports at some platform. Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- change from v3 to v4 - use routing.num_routes =3D min(xbar->num_sinks - 1, xbar->num_sources) - replace xbar->num_sinks - 1 with routing.num_routes change from v1 to v3 - none --- drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/driv= ers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c index 93a55c97cd173..55454445359f4 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c @@ -188,11 +188,12 @@ static int mxc_isi_crossbar_init_state(struct v4l2_su= bdev *sd, * Create a 1:1 mapping between pixel link inputs and outputs to * pipelines by default. */ - routes =3D kcalloc(xbar->num_sources, sizeof(*routes), GFP_KERNEL); + routing.num_routes =3D min(xbar->num_sinks - 1, xbar->num_sources); + routes =3D kcalloc(routing.num_routes, sizeof(*routes), GFP_KERNEL); if (!routes) return -ENOMEM; =20 - for (i =3D 0; i < xbar->num_sources; ++i) { + for (i =3D 0; i < routing.num_routes; ++i) { struct v4l2_subdev_route *route =3D &routes[i]; =20 route->sink_pad =3D i; @@ -200,7 +201,6 @@ static int mxc_isi_crossbar_init_state(struct v4l2_subd= ev *sd, route->flags =3D V4L2_SUBDEV_ROUTE_FL_ACTIVE; } =20 - routing.num_routes =3D xbar->num_sources; routing.routes =3D routes; =20 ret =3D __mxc_isi_crossbar_set_routing(sd, state, &routing); @@ -453,7 +453,7 @@ int mxc_isi_crossbar_init(struct mxc_isi_dev *isi) * the memory input. */ xbar->num_sinks =3D isi->pdata->num_ports + 1; - xbar->num_sources =3D isi->pdata->num_ports; + xbar->num_sources =3D isi->pdata->num_channels; num_pads =3D xbar->num_sinks + xbar->num_sources; =20 xbar->pads =3D kcalloc(num_pads, sizeof(*xbar->pads), GFP_KERNEL); --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2087.outbound.protection.outlook.com [40.107.241.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E9132566D2; Tue, 8 Apr 2025 21:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.87 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149251; cv=fail; b=peKieS33kMuBXNo3bZWGN87PO+/DkPoyxPYb/pinlt81xDad41RgxQgkvTEke5sAs1D4dVZASsNLJi17GPS2p/1aR6U7mVzgJ+KPiquq2+JyD/yTzJc2SeziGBFgJEa2FIwXwzmDAJhm57abFFjppYEoAmH2XyCnsGLrtkI4R+Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149251; c=relaxed/simple; bh=noXMKVQBMelK/ehK/17x/ZiLJCzT079DHPxDBWD1mPk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=pRHurzhF557F/ptdVEtJUuptVR4zCIhAUKXjQsqA3JnlP6Gtgbr7K5ZHbM+dkZppcQzDJpXSBexSVItW6R+5y+O4St7A/uoi7ArA1va2R0c7Xb3hfOwzaf0AwKWwrFUnfO+QHLZYskk57f/ovaNm/bcqYEcPFszv+cjWslXmLcU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FjaG4ngC; arc=fail smtp.client-ip=40.107.241.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FjaG4ngC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oB24SjYArDcFrfPdfwXI9etj4gBp6+EDTz67zSV3CIQ509l7PIIdCmYOIiYIzCTyH68a6xPkCaZqrRHnZyH4QeHXZYA7wG98Af7fMEwquu6jmUHBGp7tPYOyrixRu11B4YGSZnhoKuFkNFf5kN2nsVj5F6zfOXPjorDka6z2ORHezldZurWiP7fg3VgVACnPej2T8UjEJ7dhm3VRd5k2oD+QEqDrS+ytCzx41Z/zKepnJ8Q0be/S8MM32XnfBaBf0fUYumBLYBrbyocz/i6iHZxdrG6nMus9l1TiG3jTwDbzHZqZm3Y2igXcjg5Qtf/uF7uYbIaHD+xBySAoQE7JJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Ydh2r1iRTTmID8c6vddANSkJyJZKA1k2Bb8KWqAxXs=; b=WNuIg8JVStUxVLEY6E8Ry1Qp/Fu32u7HouiUjpboqMM/6O63nL8zQ/Nh978RIiQ1Bv/+nToLKJr+DQAaF2O2oGeyqptFwn0iQmjdYDIZuJ0aQ+FR4Hhq8CVbizls1TXpgyCSKJZXzZLQZN6V7D/JPdx5vu4myWWvuwn14tjHFemzV76PlWILLrd3C9uTQKyzhxGC67IEM/+wipaPafPswnypGK+fQmuzJRpJkDBJgFuRi0IF1GFmcyjMB4GSUiiFDdfuXod2Yif/M7Ygc5WkOWFxAD/O68tZ9kSZyJWuGIcMg4dBXWjS/m8vvjndWbuiY0iDrjwDgNMH8zStY4FFXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Ydh2r1iRTTmID8c6vddANSkJyJZKA1k2Bb8KWqAxXs=; b=FjaG4ngCl/u45ifSGZqTD+bDUHFfvmbQi7QGyBtuR3gmtGAoIT9IVgp3Senl5sGHshNNk94qR64GsF7E80bCR87GWSyyaCueqTvxZ5DPY5ntp4cXFeUhfgGzCzlnaTyxfQbJbpWzHSo2JKmkNihjpcRlN5zbfCCp1EXEzX9KpFaetTfNNg0EUgXl56qbBjFlKbTgaHQGqvzBE5PP3eWqzkXIhRfAF2W38O+QoWkDHr0mkwO2B5UgOU27fIKvvzq/tlVLbQuwaAL2irNJcFriwj9pBKH3O7r+4MDuF3KVGdozBXkpjUTkaIRtPR55FmV9WqMAPoyKsA6SPRA2eK+NnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:06 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:06 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:01 -0400 Subject: [PATCH v4 03/13] media: nxp: imx8-isi: Remove unused offset in mxc_isi_reg and use BIT() macro for mask Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-3-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=2902; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=noXMKVQBMelK/ehK/17x/ZiLJCzT079DHPxDBWD1mPk=; b=hxb2IYvh6f6/SswqYyMi62Zbf1dc5KaQJizcMsuXz/FD8R/DRB1bxW1ahI0sm9p+njbSavfI2 FVrbcra73DcCC73WVQBX9PXPDpiFeRHxoxEH7zu0YtF5jyMZOrLa4mY X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: f5f3a77f-f459-4879-231c-08dd76e7e229 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZUxJTjhVbkR4L3VrMmhFRElwOFBuenUvTDZWSmd4dCtseXRXaTBqNG5YcG9t?= =?utf-8?B?QnppazQvSWgzZzlXa3EvQVpRdW4rcjVOWDJOL1N6T1A2OXhZMXJWQktEMnJY?= =?utf-8?B?RTJBOTRYRE9PTmlVRGZuUUszamYwQWRwdVg3WlNoRTAySmR5a2NGS1NHTGJo?= =?utf-8?B?b0RCeksxQnQ2RUU0azVqSkt4YSsvRk9FTXBWSjY3YlcyOVc5TkJ0OFlhNFNJ?= =?utf-8?B?TTY3ZDd0MlJwaGpDOTRkQkVXYncxVGhrWnlLY0ZOUGFwZVFPZ2U2WHNTSVBI?= =?utf-8?B?a2lONkJ4aFArN2VmaVh0ajFyRzVSMUdaSUNBSUQwbWhaS000U2c5c0pwVkxi?= =?utf-8?B?NzFyTnRmdXk0ajFLREx4VGswUUhzeU1yUFh0dXhwb1lPVjB4S0czVVN3Y2hu?= =?utf-8?B?VU8xMXduU09oZ3dSUGdMYWREWTJyZEozTGRPcis3VGI0SmZkdm9wNDFZZUdZ?= =?utf-8?B?eWhTanM3SFR2Z3dXUkE0Nzl1WVhZY284NDZQbWdzMWJmZDZaT01SUS9MZm1W?= =?utf-8?B?WXlUTDZoRzhmZE5XS1dCcUt2Y212RGxoSjZZUlp6VGgyeld1QWQ0QnRyaXhD?= =?utf-8?B?T3k0a1FmeDBESU1EUmVQYjRLY1NpY2dYT0lleS9QSUtGSGRCWGtxL0t2M09T?= =?utf-8?B?YzZmMUNlNUVaYnQ1WUhpZko4WHk1R2o3OU8rYWVkY2FFUG96ZExwSmlvOTNM?= =?utf-8?B?YTlkSXVvSFJ4R2lJSDhyU1BsRTZMcUhvc0U2b2R6clJUU29vbFVjencvdWt1?= =?utf-8?B?UjJhaXNQaVlMSEtoWnZZRzN5NEMzUkJZWGE2bjh1TTRDNnpTc2p0QjJkQVFQ?= =?utf-8?B?WEYxbnByV1ZkSGxxS3p5WGRmQmpsUERjUmRBeTV4RjdXeWRZR25RQytZb09B?= =?utf-8?B?dkIvMktnd094S2l6QnRhR2JEMUdnWkhpbjQvRGVxM2RabnkvSVNUZkNNdW1y?= =?utf-8?B?RjA5bEROVHFWak1HT0gzazU1aExDTDF0azZoRUdEZDFjRkRjTVV2dVdNd3p3?= =?utf-8?B?RHdOa0hxKzBnc0xDU0pKTlpZNnFFTVF2VnJwc1VRa0t4UVNUNzJneTlxd1Bh?= =?utf-8?B?cDgwZ3p5R1NsWFBkc1NhUjY0M1pUc2hOOFNKbU9FUUhVdGZqRWQxTnpJR1ox?= =?utf-8?B?WWdEUDhYMzlVZEdUTWpMUTFOQk5jQWdVbnhKYjFsWUJTQStIalMyTFRaS3Av?= =?utf-8?B?dW15NjJ0c0s3L2tmUnNGOVZ4eG9NRGRDbk41dFkzY25Td2kvK3dmd3hNck9h?= =?utf-8?B?SytXVzNhcjlLb3d4UzVBT1owR0liZkt2TUwrelRZL0M1OEtYVkZsMEJoZ3N0?= =?utf-8?B?QkxIRE1ubnhrYmNkbzVEWUh0UGJYVWgxR3NBbGMwcitPSndIRHYwbW9UUnZj?= =?utf-8?B?d1ZDNXJ6WUk3QmVmRmU1S010Zk4wZ3A3TWVhZWdXTG9SRjlwQ2p5U0FsSTla?= =?utf-8?B?VFluVzE1eE1pU1gyekVLNVhRdlh5Q2JKNW9BZ1dadzRtSnBjaW1tdU9zaEUv?= =?utf-8?B?VFpIOUh2VzQ1WTJDYzV1K3VnMmlCd1Z6ajgyQ1c4am1OTmZya293UDNQRTRp?= =?utf-8?B?KzlObDFXOG1BcEh5S3FDSzEzakN2bk9DQk1wVVBRQ3g0VlphSGZRTDV4OXZy?= =?utf-8?B?R3pRWDZYUzJpWkRicFA4cytHT3psV0FJTHFjY2NDMXV0YnFCRlhaMkJGUzhI?= =?utf-8?B?U1pKYmx6ck9ycFpHNmFHV0E3YitYdG0weEZLR3daU09WZ3krRm5nWiswQkhs?= =?utf-8?B?NnpvdHVpaGZTV1J4RVVxRjAwM1VQMjVmVnpyclJQN0RjS2Q2ZzJ0cFVVYjAr?= =?utf-8?B?V2J1NEdkcXVjWWpRSENndzlBblQyK2hiUzl2REtvYTJjcGo3b2taYXBCaUVY?= =?utf-8?B?U3ZPRlFUYkF5b1FLbjg3bHp3a2dMaGdpVjZJaGFNZjhRMkJMSjBPUTBTU3By?= =?utf-8?B?blJuU09LUk5mMFNiQzdSemVocWo2Nzk0L2hPZmpONmo4TEJjOTZBZFhCUFQ1?= =?utf-8?B?TWJxZVE4ZEh3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VU0xTGNCcDczZkRWZ2M2VExVVjJoTmEzNTl6bFBrMFNHT3Q2VCswM3UvclZu?= =?utf-8?B?Z1dCWndsQXpQZGZIcjBSVThDVlBSVDhHck5LbXMvcktzUFRCV2NFaWx1Qi8r?= =?utf-8?B?UHAzTys2VlRBVndaTkx0WkhxcFJXdXIyQ0RacS9YR3A4WjgrMVNESUFvemRR?= =?utf-8?B?L3pWcEZVYXloZ0Y5Y1pFUmFiZ1hyb0NiamM2T0VlYzVGVDZVSWNsVVgvTWo4?= =?utf-8?B?MmRxZ2J4MXBFU0xCUE5IeHlsRHF6enBnT0Q1SnV4YlExeTZkSkNoaWE3ZHh5?= =?utf-8?B?WVNtZ2c5L3B0VlRWY3lrZ2JZM1hTeGw0bzRheDlFbkxURGRNTW1hdUFCeEJs?= =?utf-8?B?Rzd5NEFBbmxKYlRqQnBoUWsvZGJEekZmR2xVK1JIVG5sTVd5ZE5QQWdEQis3?= =?utf-8?B?aGZUZ2tlUjlYb0NvTjhtSC9Wc2hObVRkZ05BMlpFVVljbXk5QUZ6a0tubHdS?= =?utf-8?B?L3ZVMHpoWEpYWUZUdldoZVBGanZVOUdnRFRpZkJ2Y2NmMG5Fd2tROWMzOUsz?= =?utf-8?B?UHQrZzRnUm10cGw4M1BRNWxDU3I0SjhJMTVFNHBhZVRHWGVsZmlkRnRJTmw0?= =?utf-8?B?T1ZOMHVmbVZURjZPMVJNZHRhNHUrSXJXU0wzd0NOV3hMVkVRczFqczBESEJj?= =?utf-8?B?Q1JtRnpkdUF1YzZ1RVFSZjRIdks3V1BzNkxkMUlCb1JlN3Jra0k5ZlFIYS9Q?= =?utf-8?B?YU5KRW40UTA5dGY1bWRIOStmVzljdXRUaHp6L0hwVldndlgySFRqbjhQbUg4?= =?utf-8?B?b1lDTmVwbkovSDd2VTRIdDZWekZsSm82U3NHUmhCd1JLWHYyU1lVS2Nvc1k1?= =?utf-8?B?MkliUStmTzNNeVc2bHRYT2Fvckw0aEVjK1ZJT0t2NTY2dzc2TTlsem1rMElo?= =?utf-8?B?dkwzV2xFSFdRdFJaQ3A0SjhWcFZPN3hBcEF2eGMrQXpGRkZ6UUduUFh4cHh4?= =?utf-8?B?QS9CRjRtcFhUUllWcWlpSjFTa0JMNHhzSE0wRGVTMndwTXJjMStGaFVNL2Z1?= =?utf-8?B?UlNBWUwrcnpxR010bjVwbjFidStqNVlRL2I1Y2NJNkpkbjMyWnZTSnV4ZWxP?= =?utf-8?B?Y1NLOVBZV2JSUWtkVUFaYWxnVGRDR2lzbWppZmpmWk0xQ2xWRHpmNEY3WDh1?= =?utf-8?B?OHpEWTNhcEVHRUhBdndtV2NzZkh3NTRMSEF6c0ZYRkswM083a3J3Q1h2SGlN?= =?utf-8?B?S0hMODd3Tzgvakl1ZUR3VmpwdVY2S3N4c2dCUC9WbHNDY21MalM0eWF5M0N1?= =?utf-8?B?aTF0WjIxNDBEYkNNUTA3eGZSUGNNazlqMmljWDZMNTVVTWl5YTEvVGNnb0RN?= =?utf-8?B?N1lvMzZCRWJlR0s4MFlqY0FXY3J4eFVGZEFMTkxOY09TK3o2UFRNaHZDQ0dn?= =?utf-8?B?YUU0elRkdFIrVXdaeWloS24xMVFyU3hKQUxBV21KREtrajM0bjB3aWpSbDV2?= =?utf-8?B?NU1uKzh4d0NZWStwQlRiM1RuUUg2dkxxRnpoRDZqQ01tQ1dVWHVxNlFWSmU1?= =?utf-8?B?M3lFS1RFdkZxM2dsUWJtU1hMTFJBam1tODMyREloSEluV2VRNUtPKzU2ZDdX?= =?utf-8?B?WUNDSU1GWlJHMEtEZnlKSUErOGpGNzI2MFRYSTdrSktHSUJtdXI0OXZIZXVX?= =?utf-8?B?WWJBVDRiVThvOFhSSlNYazRxRzIyeXc5M1lsWUJCbVFGdHMwYTBYRmdRTGFi?= =?utf-8?B?MWFmZXhzVDAwVzF6UCtPL1U5Q2Y1QzFpcHZXZ0JQME44UGRpUmZnaXV3elZj?= =?utf-8?B?d2oxQm5YbzB0NytxNi8zbU8rZ3F2Sy82OEJhd1p6bmVlWm53M3d0cTNGQ3NY?= =?utf-8?B?UUVMYWM2dVNvRm9JemkyK2RMR1Y0dzFib2ZJK3dzWmk5R1FaWUZiZWVqQTN4?= =?utf-8?B?U3A1VFpEaWFDd0lldFlQZXBCSmZhYURpcmFoWmpDRnFjb0RGODJHbTkrZEhV?= =?utf-8?B?OFl5VllGaktCdGs4bE4rOGx2aGNabzZPQjl5T1NrOFdoVHhDc1JxZlN1Y2pM?= =?utf-8?B?dFc0YkxPZXc1QTMzOXZ6S1ZSdXI4aGxoa2N1ZG94N2QzdzZaMHllMmlsaFZW?= =?utf-8?B?K0hMYnlCTzBTeW1CNUF0aExIZVhvWk9ScTZrK1VVZjcvWGNyZjJqQWhLSnFU?= =?utf-8?Q?+2GU=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5f3a77f-f459-4879-231c-08dd76e7e229 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:06.2193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r1GisRr/EmJb/s+XpbEy0vMm7WHdp8TseKdDKOTNxMPJ0uP+6uEhgWIi+iwOWIQHpw/vbSzQksiKku6MNDyjGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Preserve clarity by removing the unused 'offset' field in struct mxc_isi_re= g, as it duplicates information already indicated by the mask and remains unus= ed. Improve readability by replacing hex value masks with the BIT() macro. No functional change. Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 25 +++++++++++-------= ---- .../media/platform/nxp/imx8-isi/imx8-isi-core.h | 1 - 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 1e79b1211b603..ecfc95882f903 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -3,6 +3,7 @@ * Copyright 2019-2020 NXP */ =20 +#include #include #include #include @@ -247,24 +248,24 @@ static void mxc_isi_v4l2_cleanup(struct mxc_isi_dev *= isi) =20 /* For i.MX8QXP C0 and i.MX8MN ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v1 =3D { - .oflw_y_buf_en =3D { .offset =3D 19, .mask =3D 0x80000 }, - .oflw_u_buf_en =3D { .offset =3D 21, .mask =3D 0x200000 }, - .oflw_v_buf_en =3D { .offset =3D 23, .mask =3D 0x800000 }, + .oflw_y_buf_en =3D { .mask =3D BIT(19) }, + .oflw_u_buf_en =3D { .mask =3D BIT(21) }, + .oflw_v_buf_en =3D { .mask =3D BIT(23) }, =20 - .panic_y_buf_en =3D {.offset =3D 20, .mask =3D 0x100000 }, - .panic_u_buf_en =3D {.offset =3D 22, .mask =3D 0x400000 }, - .panic_v_buf_en =3D {.offset =3D 24, .mask =3D 0x1000000 }, + .panic_y_buf_en =3D { .mask =3D BIT(20) }, + .panic_u_buf_en =3D { .mask =3D BIT(22) }, + .panic_v_buf_en =3D { .mask =3D BIT(24) }, }; =20 /* For i.MX8MP ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v2 =3D { - .oflw_y_buf_en =3D { .offset =3D 18, .mask =3D 0x40000 }, - .oflw_u_buf_en =3D { .offset =3D 20, .mask =3D 0x100000 }, - .oflw_v_buf_en =3D { .offset =3D 22, .mask =3D 0x400000 }, + .oflw_y_buf_en =3D { .mask =3D BIT(18) }, + .oflw_u_buf_en =3D { .mask =3D BIT(20) }, + .oflw_v_buf_en =3D { .mask =3D BIT(22) }, =20 - .panic_y_buf_en =3D {.offset =3D 19, .mask =3D 0x80000 }, - .panic_u_buf_en =3D {.offset =3D 21, .mask =3D 0x200000 }, - .panic_v_buf_en =3D {.offset =3D 23, .mask =3D 0x800000 }, + .panic_y_buf_en =3D { .mask =3D BIT(19) }, + .panic_u_buf_en =3D { .mask =3D BIT(21) }, + .panic_v_buf_en =3D { .mask =3D BIT(23) }, }; =20 /* Panic will assert when the buffers are 50% full */ diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.h index 9c7fe9e5f941f..e7534a80af7b4 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -114,7 +114,6 @@ struct mxc_isi_buffer { }; =20 struct mxc_isi_reg { - u32 offset; u32 mask; }; =20 --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2075.outbound.protection.outlook.com [40.107.241.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D565255239; Tue, 8 Apr 2025 21:54:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149255; cv=fail; b=HCR7IGZyICsjIuqLn+5kb71VfnU02m14CCXrsqxk4jChvscHjrjIiAr73Fhh+lE1xt8xQjRvJ8RuD0TlDuC9waciHGZVy71ecOISOjOCrMZeI5JYi2Yy+3wFbS7hZnx5cR6CUCe/qHiESXd3BQWHX2KCcggSu90EtrQaF3Htn3Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149255; c=relaxed/simple; bh=NmWY5lQ0wDC6DARs+42lOLmZRItY9ghCAf/PRetKaOE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jcCSe/LAU0oKiXWpJyH9fwaqY4LGFNCm1nKJ38pXeQf+TTMe4xSQIg0UGhx+nbN3EZdcUd4dqQXdEYYBlg8xu0VpUzSkf8eXozRBOdBYx7Kk4kAmLhzpHayQ+/Jz/vUC7/fd/3jmo1QUzchZLrxKrokvdBkA76XWZqbQREtvXOI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=aQuax8oc; arc=fail smtp.client-ip=40.107.241.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="aQuax8oc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XAFGuHzUG0p7FnXiR83BIbF/WMSDgR6YByHMkRiaDlF9wXA9FWThy3idWiMsYnV5L40KPBKD6zbLkkA8AnxDnueDf4KLVRvGCKIO4YttLWHFrn9ejDOVHHFfu7M63fcI5CVFCCXr20iwG7nI05xld0zBJK5my1Fdh2sUJIbtIR/f50zyskQxYD3Gt1Dk4H6t6v3fhVkvMYL4ELUuRGvZuKWiS10cdHifeZcJLmlw984AdHy0MuKLc55JHPskh2ivSh46vKKYibf2R9MQ9s88FZtAif1JzYGrHcWj6ZJ0Om4VJYSy0N9h5lgdF6BLfGybNysWjwHlfLu5dwO8oKH6eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7HJQ2hAoXZ3YLXCtp8CmzB59RjwMxfkFMOMkFzI9l8=; b=bphicueNXT7+GP0+7gPlh8sOSwQKU2F6ZTIV4LGB5bxk8ru9r1/OXneaTsI7kQYfRBTKRj4m8T2x8LbtOYU/FvqbnbV8E5SI4HLRs+cypy3WmeQzAiX7PcarWFOoHxHx29hwF24D0DT1BWHje+AWXnBjdXSiCSYjOtKwmJ1kCWPE74cHAPhfH2fUHa29raQCv5b9VC5o+vWTfHExh1PKVsUd9Bsl40lfVczoC3oKMt1sTGDWeY0rMhq8KAWMVg69UJc65vSrRKsAo4MBrx5KSdvE5k7hG9zVM3j7g+OT56xNGspXxYBadNYVq7sCOdFOU7OVwn2Y3Gh/oW1cTSeCzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7HJQ2hAoXZ3YLXCtp8CmzB59RjwMxfkFMOMkFzI9l8=; b=aQuax8ochjxWI8VLVO4efRoSbgrBFMcBb99GV7zuksN68LtrOW7JKc67uEPpa8quv4zUHB8zLkOhJzvDB2tvrwZAGmUvP82JzPVcWdXulhI8oW/Rd4E/zcO2YRyCFfoAgpyOl9RfEMuLY8FExIvG0x6nMY1VUlT6pymivcRUNL1NrArPJDnpkiJAtO24T1noOql5tp3ZjByB/vTyYI+3/pzRdsrjgCXjCx7vqbP6GdCd6qJh+uhtIn3AmB3rqXwDZDCJNJacKoMK110g3yScrmfTLWeWxU476UZ9p1jEUpSVZt5buEc2Utb4HUfHllGWIvfkHAfQQ1hmvtEkbvAtHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:10 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:10 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:02 -0400 Subject: [PATCH v4 04/13] media: nxp: imx8-isi: Use devm_clk_bulk_get_all() to fetch clocks Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-4-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=4942; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=NmWY5lQ0wDC6DARs+42lOLmZRItY9ghCAf/PRetKaOE=; b=PlRAskn940mlyeA2Pxt5d7GFwL7NxNOmByoEXcu4hc9JE1iio5wMJYFTtDpEeDhfHqx1FoJU+ 3kvnbGjZ82HCdyThePWO+vp4IuHHFy1DG0sjQ2wft8uQoy1VqvlWW3N X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: c0702599-682c-4f33-52dd-08dd76e7e4ac X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RTBXTE9FYXJvOWExWUNPVDRhaHVPaGVPaGVITGR6YU1KcEhHRkFzbmpUU2NC?= =?utf-8?B?YjVYWC9vWGU5RmpwOFBYRTI0Z0cxaGIwa3Y3QkNTMDlMNTJhT05SeThrbGEx?= =?utf-8?B?cWd2cXJJNXRmcFdkZlVtdFhqZmpROXZVNTE4VTh3SG9YQ3RjWGhJNGVjT2U2?= =?utf-8?B?K3RjUS9sOW1STjdVSVRCU3RKWTU1VXByaXI5bHJaY0hVd0V6Z2pCNG01SXBX?= =?utf-8?B?N0Qrc3NDZ1VobkNaTmQ0MjhZUURzYlpWUHl4YW55Z2kwVEpqN3VuWU9scmkv?= =?utf-8?B?NCs5bkJHOENKeHBNTkpKbXlNVkI4d3pCSHhjVDFvT3hic2FCVkdqb3k3Vjhz?= =?utf-8?B?SVc0R2hrUGtSTGJhNWFCSzlzUzdSMjlhdHRUUnlqN1E5S1Q0eUhITnc2RERP?= =?utf-8?B?Tmo1cTFmOUttUFRrY0g1Z2VrcUJRd0t6YXRzWGhFeUI1V1grOEtoNnRpU00z?= =?utf-8?B?SWR0c2U4SzV1L3RSanpwSmxsNjdqRFNBOVMrNHQzdHNrenB1K1FtMEE1TjM0?= =?utf-8?B?cHowZ3FsanBPV3RaNUpsUlRRbUdOTWVvTmVyKzh6VzFnU1dlN1RFTWZuQlNk?= =?utf-8?B?Y3lIanZ5a1pSYVJBMkZtaWFKSkk2bVpQajFsMEx2RFBuZ1RlS1I2aUFsUmR6?= =?utf-8?B?ekQ5WG9YRzI3ZWNEdFphc2p2Mlp6WE9PU25kVlpQbGFLa0E3QmJGOVFBYkdl?= =?utf-8?B?WjE3WXcwY2c1RTdRWVNvQzV4OG1QQ3FlaFJOeDJrUWgrSUxMa3JSTlNWYnFH?= =?utf-8?B?M3VxR2VtT1pjaDJXMUM1SVVOR3FlUWJZQVF6K0NHa1h0T3YwT1BYdjJMM08x?= =?utf-8?B?cG1jVlQyVGlUQlU0YzNjUWloRnVycitRRnZTQjNUMVVYcDdLZmZJZlNGa3VT?= =?utf-8?B?eXMyMDR6WVB0b3o1NHl5ZXIveHBWYmxSelVyRG5lc1M0VjJRd3NFaUlJaTVT?= =?utf-8?B?Y2g0VWI5Q2dlMjZQZXFoYkhNWXJvY0l2R0JXcnh0TWlHRnEySGRGYVlkTUEr?= =?utf-8?B?TldtVSs1dzNyZzF4cnY2di81cXN0bG42dGRRSmpSQ3hLcEs5bVRSejNhNUdF?= =?utf-8?B?WjNaclI4YUJrTlVxeG5YQ3ZNRDZneUJXM3I2OWpRQlBrOUxGa0xYbnJEblpY?= =?utf-8?B?V2R5RlBBQzB6NDllNTkwV0tTQjI0bDdON2dQVkcwTkNrOW1wd3o2eEN4YWlL?= =?utf-8?B?YW5SN1ZrU1RRaUtEbnpLQjBPNkR6aUZoUG02N1VVQW5Jd1lLN2loN21HN2pi?= =?utf-8?B?clQwZHhHSHczVEZrWHB5c0crY0ViTTZDOStnaTRMNm9TTE10VTYyWVRaRkpP?= =?utf-8?B?YWt0Y2ZvOU5GbnhhYzExSzVMZFRKczNwdGRZbTVCVHZRTzNaMFBoYVc3Zkkz?= =?utf-8?B?TU5nMlJGY0xwY3kveEVSVm5IcTY1ckxqekYvTk5DcUhwVmM2VVk1S0JJanAx?= =?utf-8?B?STJyZVFRR1lxTWl1bnA3U3lnMjRjV1FERVpKbDdSQ2ZBVFIxbHZtTHYrcUJt?= =?utf-8?B?cm84TTJUTkVmRWJUc1E3Mk1qTFVLcHRyUnRrcW5hMWVlSmgxYm1jNGljdUM0?= =?utf-8?B?V21iTXpwUUQwaUVSWEJRbEdydTFha1pCRk5uYzlUT0tXay8rY29ZWEtXdmdp?= =?utf-8?B?bzQ2WDYrdHRPUi9CMmNzTEp4ZDFIV1dDRWNrYUpBdzNlUnJzdmNLcEwrT0Vz?= =?utf-8?B?WmhVRWk4dWlVc1d0SkthRGFkdER4b0FudVI1ZTJRWER5ZVFLSjVPcHd6a1Bu?= =?utf-8?B?MERvSEVIVHJzaW5LaEdJWGVDejZyTkt5S2cvbFVUNFdRNlJxR2dlZHdKeUky?= =?utf-8?B?Z1BDcCtlNmxTZUxaUTdjd3dpVy8xbzRUdjdZdE9QcFRqNFRUTnpFcXB1YlNF?= =?utf-8?B?cjNZOXBkcjJCaENVR1UzS1JMNnBubVh1a0ZjSkY0Y2UwVndmYUl4QWNWMGxN?= =?utf-8?B?aGQ3RE45S3hXN2FDSENGN2JlbkhPT3NuSWFrV2g4cXVmS2lTbklWZk9aQmZX?= =?utf-8?B?SmswcTdUZTZBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTEvNmxpT04reU9BM3FJOHpIQVNEajhCbzNEV0lXSkFtRlFIT1NRVHFyK2tE?= =?utf-8?B?c2QrQmpDYUFERG85dHJqTlZqcUFkaW50QytMaWhNRDl3YTMvU0hjQU12UEpY?= =?utf-8?B?ZCtxdHEvaUZHTjBUcDRkbGJ0TVRsWTlPR055ak1JV2ZGVWswZVd6UGxzNk9W?= =?utf-8?B?ZkFBR0lGQUpBaDgyZmtRVCs4ZjlqRFdCOEhKajVJbTVOUEFldE5URXBxS3pa?= =?utf-8?B?a2Q5WVJhdVdOTDNzaEJyaGRlQVZzNUJmY0VGQUlyQmRSR1NSQmVUbWFQdUZL?= =?utf-8?B?bDNsYmdqaTNzR2Z3YnhzOCt1bUhZbVhGL005ZWNGaUdCTTAvcVNwQTNqZnFz?= =?utf-8?B?ZHZraGE1OTB6ajk3ajluajVMZG1sWVhTUjFZeGlDS2hhOGIycFhjUWlzUUhD?= =?utf-8?B?VFNaUUFwN2pycCtNQU1zKzJCZUMzSUU4L3plczRUTVpDR3pkOXVRYVMxSTI5?= =?utf-8?B?bWIxZWdmZ2tmRGJGMlNPcFZCd0ZmTElsS29jSEdmajlsR1NRMml3SjJsc2hR?= =?utf-8?B?Nmh3c0NiV0F3YkVkOGI1OGFOUVpCdEFxd3NMeXFjL1A0RzRSNGFKSHV3L1ZE?= =?utf-8?B?b0pvYTQyTm5ra011TWpRVFJwTDRlSElsK2NEMFdIK25Od2QyMi9oWUJhT0tR?= =?utf-8?B?T2dyODJpNEVMTUFKSlJNTHZpamUybncyU0l1YXV5Y3JING5JN1hCY1ltbmtC?= =?utf-8?B?ZVdqMTB5YUJvRFRBNkRmQUtiUWFJMVdnRE5FcmkvV2NEajJITzJJdEk5RHll?= =?utf-8?B?L1ZjTkhTLzdZV285WUJkdGlUNXB3dEtUcElVb3FpemFqWTBZalh6M3MvUkMw?= =?utf-8?B?OEU0Q3hzT0E5RE9manV3M2hRSkxiZCtUdXJKcjRJLzRxcUIvSVdjc1diWTNx?= =?utf-8?B?dmxvZHFqUlNDc2wyTUFXcjdiNTlnQ0puelFTOEhseVZLUkR0V2wrOHM5TnFR?= =?utf-8?B?UUhWdHVkRE5SVXFVWHZjT29HSE1KTnVtWEw2UFNFbjhhYmc1NjdiN0w2UGJq?= =?utf-8?B?bERwNWdvUmtvdERCa1NERTV0R1B5K0RkWFF6c2Y0RWZWN2ttOTg4L1cvbUlK?= =?utf-8?B?Vy9iRXd3VGwwT05rZTlkOGM4MFMxeTMvRHZUMUNpeDJERENRNHhyaU5WU3Fl?= =?utf-8?B?YkN2UzVvY1d4b2JsZjlCc0NRR09DRURQUEFNMzFRczRLTGpaaUhGL1p0VDNM?= =?utf-8?B?VXJTNXRtUlpBTnZ2UExBSGw2NW1ZZkI4UXUzM2JxNy82b2UwTER0VVNnV1Nr?= =?utf-8?B?THFMaERkV1BQZ21RWW44clFKeDh1RzBrbllWTC9DaWtQRUFOaktKVmNKeUZ2?= =?utf-8?B?cFp5K0pXbFAwcEhzS1pGRG5NM0xqaUZSUTc5QjVxR3JiWnA2M3V2K2RGVita?= =?utf-8?B?dkphTk5xUEVUZkFRRWRQaFVKejNvUGczbG40R3hmd3kxbjR5ckRqUzJTU0Nz?= =?utf-8?B?NkV6dEZKTWlpRTF4RUtFK2o3Yi9ZOTVKVjJ3M2w1OEdFRTB3ZFA2YTlNNDRF?= =?utf-8?B?eTkzY0hYZXQxYjl2ZGtLNlp2WnpZbHRyVU42RUdJMGEvcElUYWtqZ0NiS3ln?= =?utf-8?B?YW1FUG1sc1ZDcEwyK2c4OWVuMzI0OEtoMFRxa1JhSmZCRE9qdVBWRk9yZmJi?= =?utf-8?B?N0JFWU5wNEl6UzZWOWVmVS9DMmV2eGpaVnlURFlhQVM0NzhGb0V3SHpka1k5?= =?utf-8?B?SzVxa1ZySWlRMmYwU3NLbTczVS9mYWZqdkR2TnFqMkFJbGZ4eUowUVMwb1J3?= =?utf-8?B?Vm9EeldCVTFqS1pIMkYyVVBxeDJLaUg0RVk4K3ArYU0vWGh2c0pmOEtJWDcx?= =?utf-8?B?SDREWW5yQ3VYelBPZUF6YndvaEpMMnJqb0ttand1ZDZXTFFzaW9BYy9vb0dS?= =?utf-8?B?bUQxU3BnWXNrU0R2Qk1SZFY1bDRtSzVFcUJheGc1TXhMR2ZNbnFMNEtlbnFp?= =?utf-8?B?RW13bmZuV09IT1M2SFB4RlVLR09HY2w4ZXRZSTJub1Y0eUFNQVdJbnNqc2dX?= =?utf-8?B?SDdjMkpQU0RsRXE4UzNjZTlFTEdPTnViTFQzREQzeXdONU5wOTU1WWFtMWp3?= =?utf-8?B?d092V2daWkhGUzdTYlFXUkIrQ2RKNXRPUFBiajgrVmtsOFFSdFE4WUEvLzlt?= =?utf-8?Q?74WoSODheJteUp/KWQpmmPaBg?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0702599-682c-4f33-52dd-08dd76e7e4ac X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:10.4399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O18uGwRJ02k5iNws/sb8VvJekrDp/r8eRYP2qW+iCPbUfV/E9kzXOMt9Qhrp+7ZAAUlJR7JUimGmx6s3rBFCLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Use devm_clk_bulk_get_all() helper to simplify clock handle code. No functional changes intended. Signed-off-by: Frank Li --- .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 46 +++---------------= ---- .../media/platform/nxp/imx8-isi/imx8-isi-core.h | 3 +- 2 files changed, 6 insertions(+), 43 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index ecfc95882f903..015350c6f2784 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -275,11 +275,6 @@ static const struct mxc_isi_set_thd mxc_imx8_isi_thd_v= 1 =3D { .panic_set_thd_v =3D { .mask =3D 0xf0000, .offset =3D 16, .threshold =3D = 0x7 }, }; =20 -static const struct clk_bulk_data mxc_imx8mn_clks[] =3D { - { .id =3D "axi" }, - { .id =3D "apb" }, -}; - static const struct mxc_isi_plat_data mxc_imx8mn_data =3D { .model =3D MXC_ISI_IMX8MN, .num_ports =3D 1, @@ -287,8 +282,6 @@ static const struct mxc_isi_plat_data mxc_imx8mn_data = =3D { .reg_offset =3D 0, .ier_reg =3D &mxc_imx8_isi_ier_v1, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D false, .gasket_ops =3D &mxc_imx8_gasket_ops, .has_36bit_dma =3D false, @@ -301,8 +294,6 @@ static const struct mxc_isi_plat_data mxc_imx8mp_data = =3D { .reg_offset =3D 0x2000, .ier_reg =3D &mxc_imx8_isi_ier_v2, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D true, .gasket_ops =3D &mxc_imx8_gasket_ops, .has_36bit_dma =3D true, @@ -315,8 +306,6 @@ static const struct mxc_isi_plat_data mxc_imx8ulp_data = =3D { .reg_offset =3D 0x0, .ier_reg =3D &mxc_imx8_isi_ier_v2, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D true, .has_36bit_dma =3D false, }; @@ -328,8 +317,6 @@ static const struct mxc_isi_plat_data mxc_imx93_data = =3D { .reg_offset =3D 0, .ier_reg =3D &mxc_imx8_isi_ier_v2, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D true, .gasket_ops =3D &mxc_imx93_gasket_ops, .has_36bit_dma =3D false, @@ -386,7 +373,7 @@ static int mxc_isi_runtime_suspend(struct device *dev) { struct mxc_isi_dev *isi =3D dev_get_drvdata(dev); =20 - clk_bulk_disable_unprepare(isi->pdata->num_clks, isi->clks); + clk_bulk_disable_unprepare(isi->num_clks, isi->clks); =20 return 0; } @@ -396,7 +383,7 @@ static int mxc_isi_runtime_resume(struct device *dev) struct mxc_isi_dev *isi =3D dev_get_drvdata(dev); int ret; =20 - ret =3D clk_bulk_prepare_enable(isi->pdata->num_clks, isi->clks); + ret =3D clk_bulk_prepare_enable(isi->num_clks, isi->clks); if (ret) { dev_err(dev, "Failed to enable clocks (%d)\n", ret); return ret; @@ -414,27 +401,6 @@ static const struct dev_pm_ops mxc_isi_pm_ops =3D { * Probe, remove & driver */ =20 -static int mxc_isi_clk_get(struct mxc_isi_dev *isi) -{ - unsigned int size =3D isi->pdata->num_clks - * sizeof(*isi->clks); - int ret; - - isi->clks =3D devm_kmemdup(isi->dev, isi->pdata->clks, size, GFP_KERNEL); - if (!isi->clks) - return -ENOMEM; - - ret =3D devm_clk_bulk_get(isi->dev, isi->pdata->num_clks, - isi->clks); - if (ret < 0) { - dev_err(isi->dev, "Failed to acquire clocks: %d\n", - ret); - return ret; - } - - return 0; -} - static int mxc_isi_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -457,11 +423,9 @@ static int mxc_isi_probe(struct platform_device *pdev) if (!isi->pipes) return -ENOMEM; =20 - ret =3D mxc_isi_clk_get(isi); - if (ret < 0) { - dev_err(dev, "Failed to get clocks\n"); - return ret; - } + isi->num_clks =3D devm_clk_bulk_get_all(dev, &isi->clks); + if (isi->num_clks < 0) + return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n"); =20 isi->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(isi->regs)) { diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.h index e7534a80af7b4..bd3cfe5fbe063 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -169,8 +169,6 @@ struct mxc_isi_plat_data { const struct mxc_isi_ier_reg *ier_reg; const struct mxc_isi_set_thd *set_thd; const struct mxc_gasket_ops *gasket_ops; - const struct clk_bulk_data *clks; - unsigned int num_clks; bool buf_active_reverse; bool has_36bit_dma; }; @@ -282,6 +280,7 @@ struct mxc_isi_dev { =20 void __iomem *regs; struct clk_bulk_data *clks; + int num_clks; struct regmap *gasket; =20 struct mxc_isi_crossbar crossbar; --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com [40.107.22.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E05D256C8C; Tue, 8 Apr 2025 21:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149260; cv=fail; b=to/5ix1s/noEMEPE7ZXRcZysj0F2UEpD2GTmiqenCTirJ3HqNSRFugZluWYBGOCpgDiD/213ChOohpYoor4HD4vTxT4wlRWFVoUKzR3iHKPO+g7pbCP5X18oWSYjOZp0iZ87dFQkUK1qZhHUPBWxwkvBKR/3HkqWJLexsDyQ+HM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149260; c=relaxed/simple; bh=IkEAaXIvaucb1utJPWn/OOEay3TWubA/0duLEbKaCEs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jveIoklAsVCMY+UhR/bEXvFPRVf5/7K0MfqhaNpPPxAusFSMKo8X3kvFeM/tYKBzqpVjdtMEQEs3Lkt/BuEbLuBZFT5spMjwAA7Yn/uitRoNIyxMBDltyCktLwLFDsM+LDAgjhj8omjcCAvXPwZTWwnP3DOFmfhPR7eSu4JqOmU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=cOrYo/4J; arc=fail smtp.client-ip=40.107.22.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="cOrYo/4J" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ARLqkb2HdxZFbEM1+miFvVBpS/8CVq56LfqHGPqhf/+o9uX0owVLWARNuA5gUduoNL6hySaCEa/nb9FTQhYmNXQ8KWKVAdubii9TY8xJu97MVVR/hBMqB2yyZp/1zZWvfp9ZwzbL/gMsmp1y9WV9bDUOVgLP7YB87U6c/VCW1jwanGvN85ThSyqFoqDi8dhtxJMnrJsQCaZhkvTZYm+pfGlftQbqqHN6cSzzCAXhuWl39V/w/XOWGyx/DJVB9HeVoWR9OmvKZyWnV8PL11wQwnbQCRUiDm4NAMazkVe20gWA6+PUsJjTow6GkjcHRlmYf8WhMEAuYrpgii5WBgMlEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duyx0+ALz8gkTQnbJkTxbICnPUi5pZZGzoIPTth4aeQ=; b=Fdz+O95PTpZv6c67dBVfAcdT+EcB8GIzedYs1klP2ExHCIeOEBZWoY03N3CHOghsYPVogkZNy3PUY+3ZyX6HbtBc6EDmhFi3jvHMuoJ6N2HOSpiAf2HLjPU8wwhSqSbPtT9xCazoO6VuvpiEwsp0IkqDw4w1IZxAi0KmmHeLtjGSFQfkwmlbkWLYPe8IiBLmGEdZDRCxLHqtjdDSWZmH2vn+Z/vOLbM6hMJEGSUK2BgIQj9Zc1gORXxVbwyL4GtiaZ+r5yiZjaVi0GSneZAX6SjeOLcgeo2guTvy9vivtAlRQEu+HTBUznrDgVMQoNzjqmD5/m+L1MevoVTPDc1qSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duyx0+ALz8gkTQnbJkTxbICnPUi5pZZGzoIPTth4aeQ=; b=cOrYo/4JMYdV3pyeZYWoLzWd+Gx38Z5BJovSMDu/OK7fb1k8Yhj0bA3yj3LciiFrMTmadHKIntAyXChWAqHZM7ZBjzydUH+RDPNhYzFlA3jBjQscGeEYjdwDxQJkp/3L/NiDwE0RQqe2u5O2RYyqYAzADDVwP5+yzTEj5pOZDUYPgyd7VEnq8oN7CYfYDF41eudB2TLIV//JwdM3g1Y6Q4QvZlcwsjzViAHjtIll/9F3Z6WmMjd+1UzSJbqvyUPcNcjIFBdGblHekENI1hQrMbp9NeezEd15fWQnI1wuEKSOa9VeHib5etnvHoHVyE9CIpv6dTbFCoVVtFO4aeGl5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:14 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:14 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:03 -0400 Subject: [PATCH v4 05/13] media: nxp: imx8-isi: Remove redundant check for dma_set_mask_and_coherent() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-5-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=1059; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=IkEAaXIvaucb1utJPWn/OOEay3TWubA/0duLEbKaCEs=; b=Tabdn1ToWSVawSrC3OxWTdZ3DtSLV+/xNeRpF6qUjuMlus42kRlJZu61qnC53bKS9kT1U32/f rXXa3tafdiFAkVT3jolbDqHNjI1N5ZqrLfxQ9kNCCnA8bCX+Z/8/VRG X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: aa3d79c9-6f09-4784-fce4-08dd76e7e731 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZmhLUGxwOG5SUnU2c1ZVSXU2UGF4YXdoa1FZVG5ydDlIRlQ1dUthYlVXSThQ?= =?utf-8?B?N1Bmank2dUxKcE0yV2c0Ulh5TTlFbzkrVTZ0eFNFMUl2RzdVZmFyZ0lmQWRq?= =?utf-8?B?bTdidFRlNnlRNnN4VUp4a29vZmZyd1d3MndSblQ0OXVBSW1OZU9oODJKYzN6?= =?utf-8?B?QXAzK0Uzc3cyYXFpMEpOaVM0YXZJK1duVkJqUmJGdkVIcWJWK2JrQldPS2Fj?= =?utf-8?B?Q0hDYVc2bzlSM2xxSmQ3TFV1blVLYTE2K1VzY2lheGt3T3JzS0pSQjhtalpn?= =?utf-8?B?NWtXZy9lM0orZkFNMThNazU4ZlRXTGQ3ajMwNWxSdXB1Q2pEWXJHRVFIQUx1?= =?utf-8?B?RnozT0xYK3BqbllncFhBVnFCK1V1YXJqY0IzeWZsbzlmMCtXVGc1R2FrZk9u?= =?utf-8?B?S25OU1VCTHUzc1N1SXFKTU55WWhDeTkvbVUzYXhnNWc5QjlhdldYd1luTWxU?= =?utf-8?B?UzBSRTd3MlJ1YVQ4MWx1bVNHSVI3QlJWbzV5Y2JGc1FEZUNoZUpiOVdyQXRr?= =?utf-8?B?TnpVR3hVdVhKZDhLU3ZjSU1jMHE3MVp2RzJhZzhBcXBKQmV0Q0x2UHFzZmQz?= =?utf-8?B?SDJNaDRBSGV0SXVuNVV0YXY4L3ZjUlNBVEd2dTZSQmtnK0dBUHlkaFhBLyth?= =?utf-8?B?dm0zK3p4NXRxWUlkenA2eGs5TjI3NW9UUUh5eEprVVdNbGhYeHIxWllKRmt5?= =?utf-8?B?dnkwbUwxTllUK3pubHpNSCtvSUZ2Z25BYTNScHd3ZHAzRmlkU01ndXZ6QVRK?= =?utf-8?B?RktFSU1RQWFBMXk3UFFVQXJsT3lJRUZ5blNrenM4N1JRQmFTRnJkWXh3b1dq?= =?utf-8?B?T1U5Z1pTQ1BlQjlsTWpwanZPUEtpRFI1SkRxbFdmTkFOZzZuVTBCWlJZQ3BT?= =?utf-8?B?VkdpSDZPWWYxaElEK2pDVDA5QkV6ZTRJTjR2V0k3YXRBRDFuS3kyN0wyRUtY?= =?utf-8?B?NGJTZGc4cCs3MWxBSTVLWUtoY3hiVzE5bVVLalJDVUV2ZTFhVVk3djc2a0Rw?= =?utf-8?B?RE5EZUtPMmsveG1zT2EzVGhJRGtZTEFlVTR0c29hYm1BU0RwbUtjdThQb1A0?= =?utf-8?B?M1Q4MXVzU1RXdHRKNU1za0o3Y05tTHZreUZCaVQvTTVlUTlYS2JTeFlvMEY2?= =?utf-8?B?MTJmZDhmenc3aC9McWxSWVM2RnNFMVY5NUY3UWVSV3l0YU5vNUEzSmN5MVEv?= =?utf-8?B?L2czNjRrSEtkaGpoRHo1K1lsVlRZWGZWWGY1VEZ3Vks4eE8rVXJPY1VFTHdx?= =?utf-8?B?YjkyREV1eDVQS1BLNEdDTDJFOTIxY2ZPT1p5OWFxT201QWJCdmJHdUw1dEV6?= =?utf-8?B?UTREMkVERGp5c1IyQ3JEQ2pIT3ZlVHc1Ri9hLzh1VnZxSXNKSCtNd0ZqT0FF?= =?utf-8?B?RG5JQ2pJclhHelNVWVNyclpYVE9aclJSV2NON3BLdWpxWmtHaHpDd1hIam5B?= =?utf-8?B?R0lnajNVZ3llUDNBU3BHZkdhdGpDRjFMajVORDViNDd2Y3dHRmx0b01PMkZE?= =?utf-8?B?N0VaUWkzRGlxWGk2Y2NyRkhMdGJiTjRuNUxrNVVlVXAxL0JqSnZKbEZ4SEhk?= =?utf-8?B?RmxWT3Izeml6TSt0R0tYRUw1SVZGTVFyUEEweVh5dXZqa2lmeEpPRTExZmFV?= =?utf-8?B?WXRJT1c4bmhWWG0ydGxtZ0YxcEdZVEU3c21mUmE2RGFWS1VoWHdFOVJ6RExL?= =?utf-8?B?UmtKRVBxTEJIRXE5U2dONkE3UGlmb0NXMGwzMVBraWt0aENvMlF0WTNjQjZJ?= =?utf-8?B?cVprMHhvMUhONkFiUk1NTTlZU1g2eFl3RVpPY2hINDRTZTkwcVhDQjg3R1Z4?= =?utf-8?B?YXl0ZTFGV084S2dLckExcFFQUDdqa0YzSk5ybjNFSmVRRUdMdVBuT01DMFJZ?= =?utf-8?B?NmFrNTByY3pONmkyeHBJb2NUelhNR3c1QjBvKyttTnhwZjFTTFpkQXZsNjRJ?= =?utf-8?B?WjcxeTFQWmF5TzhlK0JBcWdMaGRZdThjVFZtMjY1QjlxSTlzL2ZTRTAxMHF4?= =?utf-8?B?bUpMZWM4VzBRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGNJN1loTDZ6cTBvUHRRK05HbFhWWEV1M0VHbTJhTnNac3dzbWs4Nm5WNzVS?= =?utf-8?B?U1I3VHVFRWpuaXNjaDlkOC9BMjF4QWw2dnhKSmtPZzdldmdEcHo4U1FpdEtR?= =?utf-8?B?ZGhHRFhNWFhVK1VxOVduWHczdzh1SnlWWjRvVytUcDFqQlB5b2ZKTTc2NDVW?= =?utf-8?B?QkdFV3hXT3d4UGhrZE9yYWU3UmZTa29qVW1VMm5BeVB2OXRVaTBpanl4TXRQ?= =?utf-8?B?M2FOM2FOWmFQZ09jblRLVHVNb3o0d2VYQjg1Sm5sYWtVMFQvbC9PQlVYRnha?= =?utf-8?B?bGluT1ZZU3hLSVBWRHF6dExZOU13aTRUdGFwYnd4RkRlZnh0SjdqMnlWdWEw?= =?utf-8?B?WjQ2d0MvdnNjUldsL1U4RTIxd0VrZ1M5Ylpnai9MVjl5UjVGR2YxdFJ6SkNH?= =?utf-8?B?VTMxdjBLc0pWOWU4R29VWkxlZkRWRjRtUVpOREl3eEphdVNHTXZzeDcxeUU0?= =?utf-8?B?dWE3eXFJbWlMOGJlc1dZS2xOWm5JaDh6LzlrYjZwc3lSREFzZ0xRWTZNZk5y?= =?utf-8?B?NTRrd3JTQTF3RE5XRVRUVEI5RDZJNXNZOEtZWEgyNzdRampNd051TjcrT1RH?= =?utf-8?B?cDAzbEk5dXdMZHlvdFZqRGxBZDMyT0NHMk84UE8wVUFJYTM4Rm9CYTJuU3N0?= =?utf-8?B?ZU40eW5GUUwzL0l5SHdPaStQcmFmd1U5TW1td1RyaVF5cTdkSkxHU1F4eTdz?= =?utf-8?B?ZjU3Tzc4elhMSlhhZE9GaU55dDA4SHZXYXk5eFl1WTZ0d0Z0bzBCaTdkdGs4?= =?utf-8?B?L2RpcnVRZklKZW5lQmlvM1lxNTFCbHFIdEhCdUFxZzlZd2MwQXdFVlNqcUtm?= =?utf-8?B?VVdjYituTjltN05VcERxSWNPV3FmL2NXelZpWVBnSk1xTk84TXVsaFZiVHBX?= =?utf-8?B?WHNoS3V5SlFrU3Q5ZmhIT3djQTE4cVNrMHpDWFIvajFlMnE4V1VQNEVoWVE5?= =?utf-8?B?TkJsbjFiMjVGYmlUeTdCV3pyTUZWZ3NmZWdKb21kNWtzbTczWVVUYjFHUFIv?= =?utf-8?B?czZNODkvZTJJdWZKcThCdzBrOUZEU3hkZ3ppY2tUTFlVQ3h1UVBVM2N5TnE3?= =?utf-8?B?VVU4ak1QVVpKVzZlMmVzbW5SSnZ5OVlsT20vMHV3UXRtK3Rvc0d1ZXdXT0w3?= =?utf-8?B?YWZjQ3ZtNm5YaEVCQ01vUXJxRDlnT2hEcnB5ZWtzeDdnQ2VvakJ5Yk1YM0pW?= =?utf-8?B?WnhTb0tDczFZM25VYmFkUW1IL0hBQjFNYmdZWURRMWVldVF5Z3h0UFkvekZa?= =?utf-8?B?VTNWMEZCOTExUWZoUnNwUktGY1dnVEE2ZUpZTUlIMlN4SjAyV3d0KzZwMFIy?= =?utf-8?B?NHByMC9wN210a2tLV2FRVGNDZTFtRXE1aGoyZk5rdDFkYS9Rd0VYc2lML1M4?= =?utf-8?B?TkRuZkgvT0xmWEJ6MFVPQ2pCN2FSRmlpRUhkQkhCZHJMTk8xdHhjR2lzWlJa?= =?utf-8?B?dWZXNk5nNjZoYktmU0k2QVhsT2E2Vys2T1lvNU1lcnRGeDhQUjVwdVNjQlcz?= =?utf-8?B?N0FUbGxsUVk0LzE1Mmh0TGZWZExHWkVEcWZJMlB3Ny9wcnoxNG5UUGFWelNJ?= =?utf-8?B?czVVeDFwcHRnKzNCSHdTZTFxelRHNXZFRzBYWjJTV0dUVFZXQU82SWlvcWtk?= =?utf-8?B?eS9RL3lld3dha2VTdmdPczNveVdQcWkrK1QxUWpFMHJoTXBYSkF6UzFhS3VK?= =?utf-8?B?VGpRR3JEMEFPa1E4eU9oZ0FOU09Hb3piMzd4bVRxRTh3Nm9CVFg3N21KdENi?= =?utf-8?B?ZkdOanFCaFdWQ3RTZXRrQVlHYjV6OWlpZklXVlFYcW1QRXFkYVl3dVZZbUd3?= =?utf-8?B?K21Remd1RG9EWXB1WWNTYjFHSTlQZVJpWFBtemN2OUx2VlNVT3ZEcEhEbDRS?= =?utf-8?B?Q2JkNGNvTGREWnZ2NlVjN2lUMmVOenVQTE1TU0dUWnFpTVpSSlpNci9DVDlR?= =?utf-8?B?UmFtMVlXbnZVSXNjN1BnR2s1T3JyWEtxcHBBb09hMlJSRyt4WVM1eXE3ZU0z?= =?utf-8?B?d3RLV1dNTGNBTlhmU01EYkZRaDlKV0RkVzI1a1JVZTQrczlyLzZNQm9Fdndk?= =?utf-8?B?L2lFLy8renNaTFZYcWJ1RzBmWWNlelNyWjgwZUJ1Mk94ZHh5bXhRNmVxY3Qy?= =?utf-8?Q?jJJQor2FqJathUVuXSSibw4KY?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa3d79c9-6f09-4784-fce4-08dd76e7e731 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:14.6704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H781xgVTqk22X2WXE0l7o4I0xsoGc6FrGIOi8ydj+evIuoX7QUSVWZwzYPWbopTAKpHK5GMFyJZUy4pwil/35w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 dma_set_mask_and_coherent() never return failure when mask bigger than 32bit. See commit f7ae20f2fc4e ("docs: dma: correct dma_set_mask() sample code") So remove return value check for dma_set_mask_and_coherent(). Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 015350c6f2784..073ea5912de3b 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev) } =20 dma_size =3D isi->pdata->has_36bit_dma ? 36 : 32; - ret =3D dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); - if (ret) { - dev_err(dev, "failed to set DMA mask\n"); - return ret; - } + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); =20 pm_runtime_enable(dev); =20 --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com [40.107.22.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6838B2571A2; Tue, 8 Apr 2025 21:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149262; cv=fail; b=rCsVPP46oLqxd40MsPCMv3TtVLU7XtRQVIFz1Mr4a2h0yagBdiKAyc8KKz2kJYmCvzc0dCZpYHznubizlfIKURCszEEP8o6yWwcVPnn4mtNflLuAfylFMU4szeF3dLAl3PMsirjwjzOWJuuIPkxcQ/hZGnx/3nrFr7fvrnMhKoI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149262; c=relaxed/simple; bh=JVcBDHXKyjksqu7qIzz9vxx7gKd9zWNURmLLuL16DR8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WNBveq1pPdL1cq1KICb0VV238lyB2p+sjoiJms4vnEIYqElaqWsWhdLSJyUQ4f34icJHzXp/ASeRPAEGDJgV2BvK9noMDa2QlcYqxE6bhVVClXDjJUF2iTQhPGx6P8h/w0b1uC0RyKQXoi/0Dpo6NqdYBX/IcW2zKJQa+R3CjWU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=M+11fB2N; arc=fail smtp.client-ip=40.107.22.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="M+11fB2N" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hei6kiu5WFSruUOuQjlLAdJJYwDmNuoXxAeYVhtYkwqEdQSq3R/lYw1gYundnWPgykHxgfxZ9ru0sW5Ev6XTCHHDKjSPT/T/PvWXEPViTc4OPYe5HQbaZF07cJys73SeEfHaRczN2vzw3TjGNK6TdGsbp6CgD3Rh5OvSZuXoX65YK5ekGeFFpI7/gC2pY2MuPBcZdIQjP/t8OTvDKaGW5+FKMGdaUU1lqZRRnHFEBHMBkGQBx8U60cnXOZFXa9e1tVG38YqiG62rvlosfK1kQj5TJPxlOntKB1xpwSbs4iHOwZAOUGBr6ziVVO2tww2Bbe0XtxP9RrmyP53Bc5N/Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+T2vCWDs8vHqngH/at9Qb/e7wkZP+AMlnAipwWdUNY0=; b=NrUnEj7kVneaNox9JOFKRqWJidfzBK/FlC5ddCMgSZVnGxvZH+U1d+7n9NCX+GsS1jt+vuR8KRv8vlViAs5Fo+H1YMbntPIXEkfVdl6Ldl3do9JSBaHALs9AjAiqxYSZ8Q4DJ8RlFncuk/bUQiVNh7vzHG2CHmt1BkGhLXTZpaAsR5sVtU1fG5a+1q1gaKZpO+mJ1mLjxDWgSe4ydNrAYrsimVXrocakXf3frrARm9/7Jy6GFjGEsEI0ukJdN4oropAgGH5BndLc8Yx2mulf33sXcEfes37q3nclh+GmZP+Tl/v8EMR+BnbmEEf518uyp3j9gOxdE4cM3HxguztRlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+T2vCWDs8vHqngH/at9Qb/e7wkZP+AMlnAipwWdUNY0=; b=M+11fB2NaXvchLIirUjsCyvVa8C76F04tS27r3NNpZGiYAqcGRRAP0mWFY3fWTxRWxHskoFsDgINbrrMV1MYnSPrmB+8EbxfdswTT+WKb9pqZtxSEVFb+HIEsm+3WFCLDPUJ0/Z6BBGMYl60+vXdubBijSv71Q6mlkhRBOIFgWAXhoDB/zZCM9A4wqpzIy045Dcx/WmoR4PdVFy7x3NbmAkbYiv9zb1fvyQ876Co+FqeLkysCXB/XdFr7RiJFfRebO2sLg8jKE1zazVYsE1rPg2+UKhVLWux22Ubg9t/qw0e4EBOPyiWcGZlcaDy1txJANneKaHFg5Qjtf/FS3MMHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:19 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:19 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:04 -0400 Subject: [PATCH v4 06/13] media: nxp: imx8-isi: Use dev_err_probe() simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-6-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=1421; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=JVcBDHXKyjksqu7qIzz9vxx7gKd9zWNURmLLuL16DR8=; b=ZVkcr9VeI+3SFFSmnx+FZ5T/+YNTKDA9vK/hrbZgXJdv5jiwyPKsGQRWV5RA49bnmuzzjtc5V hQXBOrfy7NyA7tuqbAKJMizhcC9yic1oNhZCbi2MuYRGnrUc3gCe3P5 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 7522b18d-0c26-4bbb-7e19-08dd76e7e9bc X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WUlIcUU0Qk1QdEgrTlJjcUNBaW1yWHN4MXdPbGxwYndKODdtc1FBd0hURDg0?= =?utf-8?B?RUNQUnF5TlRtMWdyNkxnUlkyOE52L2F2L0IzTWdPWVhaT3U5c3dWK1hIeGV0?= =?utf-8?B?Z2hHbU9PY1BLRzB5Tkl3RHRJT2RMRWt2aTgyTzlwaitRb1lXNmZJSFRJUWRk?= =?utf-8?B?aDF6aXdpTTNsQ0hsVmQvdEIxV2RvZWdlWmMyTVlvU0N2bTRQZWk4TXZvNUpR?= =?utf-8?B?N2diVU54bzdvQ3FTbnd2V3BZL3pGMzBlaE55Z1BsQWlBUEtkREdYZEt5cnlQ?= =?utf-8?B?SjZCU2NDd0RmMnFodzM3R1hvUnpWT3VId2Z0RTZSUG44UmZXM2UzZGpPYWdt?= =?utf-8?B?UGdHbWs0MWprQWNIeDdZV1NreldMOStQeFZWNWZOelFuTnpTZnJRemdyU1pO?= =?utf-8?B?VjgzTEVITVlRTVBZbmZBNFMzTlJUT2w1VUJUbjZkYlZNS3l2UmQ4SEZyTXg0?= =?utf-8?B?eDFtY0FtZEhONHhsK1NNWnMrRTUzSktuNjNDVnRZd3hoN0VKSE90ODVZL0NH?= =?utf-8?B?TzYxb1diS2pPYUFQK1hFNzhidEdqcTVodnBoNG5acHVHNXR6akttYlE3Yjhh?= =?utf-8?B?NmErNis2cFRFTzF6aVFXT1pnKzg1WUhuZjdLa0NFYVFoUzlRMlk2U1BrTjlJ?= =?utf-8?B?RzZPN1h1UTAwNEloM2J6QktHV1AxaXdjeEN3TWRJQ21xeGZwZEFIL2E2em1p?= =?utf-8?B?ZGJFbVVDejhjUDhhbHJWQzh5ZmhKS3lFaGkvVWJLK09hRjN5VnFoNzFrZUk3?= =?utf-8?B?VHh3VFB1bHZCS3A5RUp0K3RzU1NqUjd0a29XTlBGMjJYRVB4TTJ0OU1mOXhm?= =?utf-8?B?a2dSZjZGZ1UxVXFwcWR6a3Yya3l5cjh3L3d2NXIwSzZXdlY4OGt3Zko4Y1ox?= =?utf-8?B?aW5mNHBSc01xc2Vka3psZHk2VHYrM0w2YnJ4MHhVeWQydG1jSHRGclZaN2Zs?= =?utf-8?B?NUZldE05djZENlAzL3hqVHdKY2hzblZoaE1lcEh0N0M1QlAvOElVWjY1SE0y?= =?utf-8?B?Yk91Z3IrR1R1NDFLY3A0MzQrRVYxa25UWm1OTDNoRkFCU042Nk5JbUVKcUw0?= =?utf-8?B?YlVEUVlUN1lEV0NrOVd1cDNFczZiakovY1dpeFZuamdHYnN1cUtwdFg0R3Jj?= =?utf-8?B?S2tqZUVHQldYRGRJUWxuSzc5dDFLWXdSaFZzaEN6Y0NRdGsyTE1IbEVibm9L?= =?utf-8?B?enNrdDZzUE1sR050elNPZWhSZlBybEhIa3ZVQWMwaVQ5Qld4WGpBck0xeU5t?= =?utf-8?B?TGFqUWpUNTh5VVlqTzFTOEhtTnNUdFZ1aVNJQzJmc0RXWlZIT0d2ajA0SzhJ?= =?utf-8?B?OFRuaWZxZzJ5ck1WcGQ5aWpOWWF2TGU0aGpEOTU4S0lweEt2RWFGVlp4SHlh?= =?utf-8?B?bCtCU2xYRUV2dFhsV0o2QlFHZFBMbXpzRmdxNndlclVJQlRramxFdzFBSHNJ?= =?utf-8?B?Rk1BeHpaVVJDWWhDaklBV2RHZlFJSGtvN3p6RzBqYXp1WlVxbHdsalQrNjND?= =?utf-8?B?OVVmcFZRc3dKa3p4N3c5blNtRFhSR2dIRFBsUmczaE1FYVpOWms5WHc2RzRo?= =?utf-8?B?TkNpQzlYdXpQMGQrZGdzYmI2MVE0K1hmb0JxZXcwQ1QwOTk0UzFLZVlOejhj?= =?utf-8?B?SWh4MjFLNEFTOUw2Znpna1hpQm1GYm9VZmhtYURRNkR0Y1dOa0REUEt3Sndx?= =?utf-8?B?QS80YnhiREozZEtONWluYkc4aHRUdVRpQlNRNjFmTWFmbDU5UzN1ZzhIdzh5?= =?utf-8?B?cGNpRXVIVjR4cEU1NmdHcVR0K3hhSW1nT01UMkVaNDVVc2lxWGFNV1BMNGdq?= =?utf-8?B?aWpGaHRxVlk3b0tDTzlrOWUvbnprVHhReUVGT05YWjA2Z3lJNTRPazVVbnFw?= =?utf-8?B?NVdHSnZzVnNTdzA4UjA4ckp5K01FVEhUZlJPbytidFZQc3U0VS9zcDVRNnVF?= =?utf-8?B?OEZMYkhucE9DNm14VTNvMXlMRjB0aFdOckZnWHJBNFBWNEZmOUpLZXZ5YmFT?= =?utf-8?B?ZVZEbE8xWUVnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWdiVmQ4V3ovY2NTeGNyMi9yTUp6RUdmcGJjTFE5YmNVSWkwRmMrQkNQcXk1?= =?utf-8?B?RXZaRzFDSjJkWVcrUTY5c2FCSlg0NW1MVzl2MlQzKzdjckE2Z0c5c3ZFUFZQ?= =?utf-8?B?ck9nSTJWWHNlMWQ0bHcwVFZrZUhPQXlSclBCUGxmQTQ1ckp1U09VNVdoQklB?= =?utf-8?B?bXZrR2pOYlVDYkQ3NVVsRFNwM2RRL3JJNUpibzlzdnEwTThPR2xDRDlpcFNi?= =?utf-8?B?RTdiOUd0eFFJL0Q4NllMRjNhUFdqVEo2S1R5RjYxVWMvL1E4M1Y2ZHhoalQ0?= =?utf-8?B?NXhSQUFjd25Cd1ptVFFJeit3TTIwOHV4NHBVbTVUOU9pc3J5bWVWbzBPaUdl?= =?utf-8?B?U0xaOFd4R0NxZGJ5Z0pFelVINmlXQjlNUjl6cXVzRURqTFl2QnJOWUh4Vjcx?= =?utf-8?B?bVVnNnJPRDZCMEhmQVE0eEx5RVpneDVHNmZTTUtnYW1yR1BnekJOWEpVVjhR?= =?utf-8?B?WTZQckhOWUxtdG0zYjdMNzhDREdYMFZDUk05aFZJZW41ZE13dm9BUWJUMzg1?= =?utf-8?B?OWNwNGl1WVVzekQySi9GYVNuTWxFbGRPRUNkK2NFaWYrM2kxMUFRdjVJM1c5?= =?utf-8?B?Yk43K2JrZzZnOTVnQmVTY2NNVVVkLzlGYzFsYzVkcmhlWFBWV0JzNEpocVhB?= =?utf-8?B?dGQrS1I1Vit6bnhkN0dZTjV6TlY2MTVXQjNuSVhWR050UXFwZFNkMkhrMnIw?= =?utf-8?B?MlNmaUFCU0o5UWFGMnRKUlVEb3Fvam44NzB3L1Jma09VTmF1Zjl1Mjc4OS9O?= =?utf-8?B?aU1HWkY4blBScjhqMG51WllNUW0rOVBJcWdXdDFPdy9RQko3MnROTEJ6N3pS?= =?utf-8?B?ZlNwbk52Wk1EajFPZFR4UUhJc1l6aXMvbmFJckFtNCt2KzdINDJvbHBtRHlP?= =?utf-8?B?Y3h0TFVHamxyNWw3QnRjMXNYNlR4cEQ1RExXM0svLzJSa0l2TGZTTGlVeXFS?= =?utf-8?B?NDkwK2tzamxwRWtFMDV3bUh6SXJHLytxTDhmemRoL1pSYWthbTdLcVFWRERl?= =?utf-8?B?NTNBWVcvNmdoeWpPcEdqZW1rMnEvOE5JRXMvM21USTVJOUpYV0JxMTd6d0d5?= =?utf-8?B?SXJKTWZ1RmpId3JieDRjMVBsTE4wV3hjOXp2WVpqUzBUZWh6MFFOSU1LNmF4?= =?utf-8?B?Um1IT00rRXRtcWErbVIvVHNuUjFHbTR1QWJ3SlVIcHdTZnhVajJQSFprZE90?= =?utf-8?B?NmZTSEtUbmtGNitMNzJ2aG12WlJYSlhtTlI4bVIwdVl1Ymx2aVlNYjE4d1Vz?= =?utf-8?B?cGlaZzZPMXl5K2lmZmxtcEtFY0V0Z28yRWhWbW9hMC8wYWdDOEgwKzMwZXly?= =?utf-8?B?VW5MYzltTnROK2RTa2p6Wnh4RzRwekovUjkvMzcyV1M1UzE4V1NUemNpanNH?= =?utf-8?B?REI5NllidlJnV1RQS1l3WTFOOG83TmdhKzBlTTFQeWV0Y3FVeThaV2tKUkFi?= =?utf-8?B?UnA1K3lqeG8yRWVjbFdwL3NTNkJMeGE3dU93MVVJb0Mrb0hPdCtobjd5OXBZ?= =?utf-8?B?czA4SW9ybkNBMVBPa0p1bDg5eTVlNlhMY0t0bERnTkd4MEV4SUFlQmltZ1VM?= =?utf-8?B?NUh6RGluRFJMOUlJckdrS2RmOStNMnFlSFZ1L0gvcUxJdzlJSXZKUFBxbWZK?= =?utf-8?B?MDlxYjNEQ2Rka2dVOVFjQmhndXRqMVpGUmkrVWJIYnFBam9heDJxWG5rcXVN?= =?utf-8?B?YnZ5anlmWVJDaWJSOGh2NTRLakZqd3ZzVXNkY28rNE5hV0w2UDdSZHA3blhs?= =?utf-8?B?MGpsQUM2MnRmMVlVbmEvVHRlYkMrWHIvcXVXcnJMRVBPRzY2THEzZTY4Mk5v?= =?utf-8?B?WTFmeDNTeEZZcmltVkZMSDlqdDNVOGNCM2hoVCs4VUhHOE90dThzT3g2S0pj?= =?utf-8?B?MnBldlZZVkZDUGhCM1NQc2x3U0tCS3h1VWFOQ29YWWpMRnpNYXJhM1J3TFYr?= =?utf-8?B?dytnZy9ZdHdML20xSFhGUTlwL1VpaTJ3WTEzVHl4SHp5UEdTTDIxZVZkeTdF?= =?utf-8?B?UndtRk9KME1XSGhnZW1teEJPNDdYMXQxU0JOajJwQTFpTVNtZDNjbHpFQk16?= =?utf-8?B?dzZYQ1V6TCs4VWlBdGZCZURPRHpQc1ZBUFBmWFZDNmFDdWRaWlRxbTR6OGwz?= =?utf-8?Q?TxqPFK0EhmvLdbBr+v0KGUub0?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7522b18d-0c26-4bbb-7e19-08dd76e7e9bc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:18.9890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zxAQLACspjhR8fUUhk07JHo8mt9mAbeltC8pX1bZKTyF6tr4+LBAK+j5KsTblquaNaIubKm4Ez4mvq8Xb0X6Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Use dev_err_probe() simplify code. No functional changes intended. Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 073ea5912de3b..398cc03443be3 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -428,19 +428,14 @@ static int mxc_isi_probe(struct platform_device *pdev) return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n"); =20 isi->regs =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(isi->regs)) { - dev_err(dev, "Failed to get ISI register map\n"); - return PTR_ERR(isi->regs); - } + if (IS_ERR(isi->regs)) + return dev_err_probe(dev, PTR_ERR(isi->regs), "Failed to get ISI registe= r map\n"); =20 if (isi->pdata->gasket_ops) { isi->gasket =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,blk-ctrl"); - if (IS_ERR(isi->gasket)) { - ret =3D PTR_ERR(isi->gasket); - dev_err(dev, "failed to get gasket: %d\n", ret); - return ret; - } + if (IS_ERR(isi->gasket)) + return dev_err_probe(dev, PTR_ERR(isi->gasket), "failed to get gasket\n= "); } =20 dma_size =3D isi->pdata->has_36bit_dma ? 36 : 32; --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2082.outbound.protection.outlook.com [40.107.241.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE98C256C91; Tue, 8 Apr 2025 21:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149267; cv=fail; b=csk2TOMsIV+E73riscUKmuWrzzUT8LKEDjOLsJBcPFbWxA03281KwiimajqEbD2tThrRdAUm5H4XN60ShDAWfAvCXRFGOpMge0fCp3m7R0YdDgMOh80JAsO8kuju9uy9PnH2W0Gye6lh/3tKBge7j2dbycuaEo1FDwEQYGdXDJw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149267; c=relaxed/simple; bh=xLSSM0+e1a/SWzx8qruzJ6ZvT+trPm6wm5lJfqq+67E=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=BSWb39Nnk3i09KnPKTB/h61gqP7I/5mbRo8LMlKDxDKz/7djQba8A6gINJAVAzMutwyIjhDzlcf3msy5g99VZNZzgYWJkpnD4KZRuqTaGTBWXc6P6FyldQ/h7fqTpGRy82jFn9/z3DBq6/95RIMgGeCk42RfX7vnm+jmR7n9hIU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Py8qYjN5; arc=fail smtp.client-ip=40.107.241.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Py8qYjN5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KLoqyBk0WF4txo/HHV2UorRCgQVyL9m0w7bhK8r4Eyie216f4RyPNEJimXzCP9pHyMAHgVTRcGF6IaLPz0LNbuae2GDR6O+GL/zKFIy1cAss3ZILrFffokSi8u67Mqm1fd6PUjlyc4sq90MEGWcfiHYK8rMHpocBG+jM+IA+cAj6EcauvnoadaiKZKbSbVLsP10sf5S/RsO7F6icxA/z5RuL6nudiz8kNjAlaUioo9DgD3QPbRfK1hNSD+Xnr3Jq34NOZhd7sB1FPpnj/apmY3xJUAlW5Ht5SjzpVhJGeAVPOzJZ3nTIQXNp2y+2Nx8mgr2RW3UIClYleB8QzbZ7ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oSGvD+NWISf4JD/oUV5yDlkbwp11Zd3Ii8zd96+XVGs=; b=qJ2S6ebFcIkW32vJa7XQ9fei4tIse4rXS2hVa80V4lkoOmbQOmXYkObryYAmpaNpJKdnO6HqhzCTdZIksp65vWnvxUMvYTDExTQEkIrpzkSD1CzEy5tnDi03d/5gA/A5aPvrDbN9hNGncFSJKHQaX8XJT4mUEc9u4Tt68pXU1EtgJgwEWZwJJTmiwcmsCQ2dmB136PevjbJbg2xTBVaksJ0PPX4f1M10buCnIDAn/I1TBm/s8L0oX/Kn4DxrXFMECmGQo9gh2J0i52mOSEXNsUAQwprp3+V6ahy59HkE6eLqy6aDieESyFQmCt/r1kd9TCdMjLIleP7xnz7LgLHXBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oSGvD+NWISf4JD/oUV5yDlkbwp11Zd3Ii8zd96+XVGs=; b=Py8qYjN51XXwC6VdbApMKFzR3+LiOw2KVSdDHxr4QDzXPZKv9SoQikRkyTzo61jsS4wwE0RdrYQqh7fL782VrIRSgZ1VpMPzfR3abOp45FhJag8EX3sXm226oQcnr/z3NE0ccAxVeVutQm2CjvNuzyBkeuUEemEjyDfQkAoq/syKbDNIQBLtbYbWqiEURgI1W2yJ/dCEE1he0oCSmQhh4fAcAx+oR7ECAOFmPX7AVKzNB1L6m+Pu2zkRuaEhEAYcbmA1InzS/Dy62NSaT/0A4svyci+u1UrSJXgSByI/4cqB8y61+1dxOKGvlpWE0ZzOdu1eDPAH8oZlYrhZeGd9Cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:23 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:23 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:05 -0400 Subject: [PATCH v4 07/13] media: imx8-isi: Add support for i.MX8QM and i.MX8QXP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-7-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=4339; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=e9Hi9R86FlHE3X6mVjw42jHev4ZPMWLjqL0H2IxdjrA=; b=uvONEIxqnvI0V2LnhqcPsDg3MqyKzWUmY3ADxguuk8xo3ICfurLnJYE/ya+ZC75z6bw842iCR f4eqpX1DbtLAS9wslK8fIItJkB00sQs1I59sXxw+qP98JmtETk8r6UV X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 63b3d71b-a6e0-44a3-7077-08dd76e7ec46 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZndEMFBrTmlOVG5VeXNNT1hQM1VHbkVqWDRuNW5sdUpYREpJZnJHU3didTZp?= =?utf-8?B?UDE4SWNwZVVoSGVzN08yZFB3bFFkUFh1SlFWNDhscFlWOU1IbGdKUCtpdGYy?= =?utf-8?B?TFk1aXZObDNDSHpUTGJOaEdGVEFYL1NkOFhvMVMwUHV2SUJEMngxdTM2RU9P?= =?utf-8?B?UW0xUzZHVTJ3dWFCcVpOc3BQUlh4aEZpNFNjUWpianlmdWR6WDBiREM2WFBq?= =?utf-8?B?RktYV2ZqRHR4aGNPSlBpWEk0T2Z6cStSSG5lZSt6Q1BiVnlMd2NYVGNUaTI5?= =?utf-8?B?WHJ4ZDFndjZmS1o4WmZlY0h3MjFBL0lXdWF2OENjbXJENXRNWTBJVjc5c1dD?= =?utf-8?B?UEdWcnA1VDJpWHVQZ0kvaVVVWk9rT1BxOUx4NHY1bzM2U2lwMFN3T0svV1hI?= =?utf-8?B?Vml6TXRNa2VBNDdlb0hVdUhMQVNiOXdmYkNhNVdROW5mV0N0N21NMTNDYUYv?= =?utf-8?B?SWlBNjJaREZaa0dndm82M2JYQUR3RVBPd0VkcFZGK0JhMlJPbDFoUWN5YWtq?= =?utf-8?B?ZTVhL1lPVWdLU1BtVWd5VWlrMFZ0UGllVWp1Ym9sOVJMejVhSHIxRUlGYmtN?= =?utf-8?B?U1NraGIvdUhKUGdmMGtaSEx3VXgrWS9wTVpxeDBoNHhVQzI1d2o0OXEzUFdo?= =?utf-8?B?KzlrVWlZenhHNEFubnhjMzV5TFdqSlZHVTBGUzdBSDFGcUFQdDlBaUhtSHZ4?= =?utf-8?B?ODYva1RRTXRRZjJYc1c3WjgvS2RCa1dISzNpb1ZaTWFwUm00VGZVdk9Ed0dy?= =?utf-8?B?V2hqQ0RKaEZtT3E1eFRrMU9KZEJWUHU3S1djNzRqUjQvendtRndub0EySHU1?= =?utf-8?B?b1pTT0VMMkVPZjFCQTkweEFYRFJ0T3VtMVprS09JY2lFaG1zSWt6cUQ5VDJ0?= =?utf-8?B?RGUvdzJJMXFXdnhOM1M5M2FmZmVudE1CWWVhNVBxVTdlVS8xazdHTHF3cUZ2?= =?utf-8?B?QTdZbHdCcThLK05CS21RR2hvdlBtYjBVK21nTUMzUDRudncreEpnWlNUd0tR?= =?utf-8?B?QVNPeU96OTNqUzEyWmNteU42QnAxUUJNNmx6dFFFUDlvcTBYYXN0SDRxWGpu?= =?utf-8?B?UWFQb09QUzdUVUZhMHorRGRhMTZMUjZBUWVmTVVEbitlZGNHUzB0aVhwV09P?= =?utf-8?B?N0x2aEoxRGVPSGFCNnBhak04SGhBenJMM2JJbDZjUFRSeTMvOGFpKzl4ZEMx?= =?utf-8?B?NFFNa1hxem5FVEZsSnBON01WNFJBcC96RzJkb3Q0cUJvMldMMmh4VWNudzdY?= =?utf-8?B?OXZMRmQyZ2dXYmN6SWxxeWRDTS8zQW9TSDJBeXdUVjhQZllsbmxlQzBhSjc4?= =?utf-8?B?dXowSERvaVdXRDN1K3FaOFVFdVlseFp5Z0Q1K1NIWDdETFg3cHlmbmFaTmpV?= =?utf-8?B?RWxNdUhLZ0Mxb0NwcTZQWEVlVllhNE1Ham56cFhRdExwbWNnVlNxVjhkY2pv?= =?utf-8?B?SGxIQXhGMGI1eVpGWGQwcUlkZ2k2NkgweFhRYWhncitUbU4vdTFOdkMvbUcw?= =?utf-8?B?UkV3cnJ5UDhSeWNDZ3dad2lmQVJCZGxsdFdidmtQbzVwL3ZxcTcxdUNmbGww?= =?utf-8?B?SlV2YVFxV08yQURNZmxnN1VieThkbm5NZDBPNFYvT3hkSVdMZVRFQ3pLbmY4?= =?utf-8?B?c3Q1dlA4RkU2dUZYektDdGNFM1VvOXhYUTVLUGZ5SEpuZkpBWVhHRjhjNUE2?= =?utf-8?B?V3VCUnd3amtRR2JhTVNFZDlYN1ZtOThPaVBHcnl0NlFPOW9XdkwzRFBxRVE5?= =?utf-8?B?Sm9pQVMvUmFlK2gwTUg0Vko4a24vcnMwTncwVEN0MHc3VVpiTU1Xc2RHUHMz?= =?utf-8?B?RWY1eDJKckhrYzdRZm9sdDZGcUo5dVVjbERzQWlQT2Z1QzBROUR1ZG5EdkNk?= =?utf-8?B?QTYwWlVGWGdJS0E5d3ZFcTVHNXlCemtuNE5SQUkydFVuWEd4dUNzbk9WeUhN?= =?utf-8?B?VzEwOE1kZnZTT0VZaDBoYlROdXVSSFpTVmlKNHcvNzBxZ2hnT3hYZXNHSFMz?= =?utf-8?B?dm8vaE93cWl3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SytZS3R5Z2ZFTnBtQmZ4VWhsbDV0K3hwYzV6aVRKemRLWjZiSzd1dDVvYXlU?= =?utf-8?B?N0d0a3BLTVBEcG1GWUQyNW9uc3lVdUtxNFFLUXBQd1JuTEpVanYzOXIyb3dV?= =?utf-8?B?TzFoVVBWVGN4dVJWWEJnVDNyUVpieTJDcGpHK29nVXZtSjNSQjBNVFFFUXdG?= =?utf-8?B?WW5vSzN3U1pBZmZ5V0NPbENJWlJOVitONW9Ed3ZTcldaSGRoOWdJSlRyL1g4?= =?utf-8?B?SGlkVmRsS2hFM1dQbFpZaG1kNU1mNVgyQk9GcDc0bVJnUW9tQTdWeXdjQjRo?= =?utf-8?B?cjVLUGFFenYrZTMxeS8zb0llTy9wLzJwQ0xHSEtmcUNOV2poc2NYT3Zlckp0?= =?utf-8?B?K3VLL3FwbUVtWiswQ2RSTk1tclpiYmdWM0JycmRJUG10UGtoOWNTSmNuUW85?= =?utf-8?B?YWpUbXQ2ZDJUZG9qaXdJNWwxWTJqeXY2VThXelI2cDdqQ1JVaTVnb3g5ckNz?= =?utf-8?B?QzF4anF4VHpKSUh2NFJQRjJHYk1nTTl4dUtldENLZ2F4SmI0KzVQa05xTUhX?= =?utf-8?B?b1EzbzNNNEQvQTFDTFh3QkZsand6NExmTS8vYWp3OVZVSktML3lkeTVzaFNN?= =?utf-8?B?RHdZMFJhR2pRNEplWGllWlpMMW9LSFBtSFhLamE3bGRTWXlWSWx3NncvODVV?= =?utf-8?B?SC9ERWNkS2pvelBMbVRLSklHTkxHUHFBMEpKOHBORWxGeHB5cFZaZEV0WjNM?= =?utf-8?B?WVd1MS96ZnN1WndKaElYd0lNbVJVV3ZNYnlkcjQwOXR3TFpHUjR2V21wS0Rp?= =?utf-8?B?NEdJV1hPVDVNeitrYXF1OHVkaFdVNWpFZlpsSC9SSHFtUnBhT2JwaGpjRFp3?= =?utf-8?B?bnhCUkJMNFdGQTRETHZlSGU5Tk43S00wTjNIRDdoaldLK0hId1pQeUVNWjZy?= =?utf-8?B?OWJzL3lmd01XOWhDU3BxL2l6UEJsTC9RcE4zR3Foclpxa2RjQVRNbEFPbXhS?= =?utf-8?B?QXhWbURNNjFob0xYNUdKUWUzUEloeHFiRCtoZ2VaUU4xck1ObVNOeFFFcFFt?= =?utf-8?B?S0lzODJrcjlBNG90c2hNT1BDK1MySjV3UTMvaWFMeFEzN3FyTElGSEFSeGt4?= =?utf-8?B?WFc0ZGNOL0NyNytTaXJITmZQdXBKTGFWOWt6Q3A0VklFQ0h3dTFGelU0MDlF?= =?utf-8?B?dmhMR1E1ZFRvb2l2OVB6ZXNJSmpPZTRjeG5VMVBRVkFWeG9WNU4xTFZSN2xU?= =?utf-8?B?M3dlZGtWNEI5bHpHZmowbUVsNnFuWUhFY0paR1U2RlVxd2NRWU1LbWVzd0hL?= =?utf-8?B?YUlBVVg0ZjU2VHNNTmcwRjh0bjdoaVR6ZHp5Q05BdW5McEYyY3had2JmQzkz?= =?utf-8?B?LzNleTZQNzVTNHM4S1duR2g3clIrZ3pJM0lBU0FSR3lCM0NaNmRhRnhjZ2Z1?= =?utf-8?B?VFVBaWhJeGhnWFZUdVRyQkVPV3dMMDVTSTFLczVINE1Ia0hzZkUxTHJ0YUsy?= =?utf-8?B?eXZmNy9oZnM0QVkyZjhueURDa1BWaUZVSCs0Q1ZrNHVCMVBwNkVaVW9iV05l?= =?utf-8?B?d2xaWDRzRS9rVHkxL3FROFhkYXFoWXpNWmpra2xRVS9GdSs0dXMraVpETjd4?= =?utf-8?B?ZnM4RFpiTXptOGgveXUwWU9sNDlSZzNORHc5cklLM1ZJcVpnQnBnazB1WW1X?= =?utf-8?B?L1k2TTZzM3RGTFFXK1hiOXMvLzVJdVBScnVNVGZMVzRDRlNEemRmTlQwUmZH?= =?utf-8?B?VStjak9sSVM3R0hRRUxIL2xkS0tFMzQxUURLTUd6Mk9NTGNpVkNQWi9vS0Zu?= =?utf-8?B?KzIvRkhWeTN1QTA4L0owVENTS3hOZ25ROCt1R01EcGNyVTBpSlR5WFNTUUNG?= =?utf-8?B?QVRqUnVnbndHWUNYb1E3UitQNUhNR2pxNjkzNDNXMnpNdGJYN1lubzlIQk9t?= =?utf-8?B?RXNxK2w1M2dHckZCU25mTnpZZURSUFNEL0NjWnp2bEJrYk9nZGxsTVVnbmNq?= =?utf-8?B?c3ZPRFo0cmFwQzE5SU5SSTQyeHFjdktxUXRXaE9xdU5EeVZqWGVRTEoxZStC?= =?utf-8?B?Wit6bUhiRE5KaFhkWGxkbDdFM2VpdVJBN25XdDlJTGM1b1Q2OXc0TnJQMGgx?= =?utf-8?B?bmFMTXRaYWNyRHp3OGYxZDdCMG1IandMZm5BR0w0K3c1ZXlKa2lMYXBHRjlh?= =?utf-8?Q?8noUYafBaXic+UetmNqLH7M8H?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63b3d71b-a6e0-44a3-7077-08dd76e7ec46 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:23.1742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K8Kr81Obiw8UttDNjCrZ6Wj7mRR/n9s4EvsV1EhxBGR+sC/ddDwIEkHLAw9Jffgf+E052eYJa9Xhj1BB2T0bxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 From: Robert Chiras Add compatibles and platform data for i.MX8QM and i.MX8QXP platforms. i.MX8QM's IER register layout is difference with i.MX8QXP. Signed-off-by: Robert Chiras Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- Change from v3 to v4 - fix i.MX8QMP ier register layout - Remove clk-names array - Change 8QXP channel number to 6 change from v2 to v3 - none change from v1 to v2 - remove intenal review tags --- .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 43 ++++++++++++++++++= +++- .../media/platform/nxp/imx8-isi/imx8-isi-core.h | 2 + 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 398cc03443be3..568d7b24466aa 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -246,7 +246,7 @@ static void mxc_isi_v4l2_cleanup(struct mxc_isi_dev *is= i) =20 /* Panic will assert when the buffers are 50% full */ =20 -/* For i.MX8QXP C0 and i.MX8MN ISI IER version */ +/* For i.MX8MN ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v1 =3D { .oflw_y_buf_en =3D { .mask =3D BIT(19) }, .oflw_u_buf_en =3D { .mask =3D BIT(21) }, @@ -257,7 +257,7 @@ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v1= =3D { .panic_v_buf_en =3D { .mask =3D BIT(24) }, }; =20 -/* For i.MX8MP ISI IER version */ +/* For i.MX8QXP C0 and i.MX8MP ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v2 =3D { .oflw_y_buf_en =3D { .mask =3D BIT(18) }, .oflw_u_buf_en =3D { .mask =3D BIT(20) }, @@ -268,6 +268,21 @@ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v= 2 =3D { .panic_v_buf_en =3D { .mask =3D BIT(23) }, }; =20 +/* For i.MX8QM ISI IER version */ +static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_qm =3D { + .oflw_y_buf_en =3D { .mask =3D BIT(16) }, + .oflw_u_buf_en =3D { .mask =3D BIT(19) }, + .oflw_v_buf_en =3D { .mask =3D BIT(22) }, + + .excs_oflw_y_buf_en =3D { .mask =3D BIT(17) }, + .excs_oflw_u_buf_en =3D { .mask =3D BIT(20) }, + .excs_oflw_v_buf_en =3D { .mask =3D BIT(23) }, + + .panic_y_buf_en =3D { .mask =3D BIT(18) }, + .panic_u_buf_en =3D { .mask =3D BIT(21) }, + .panic_v_buf_en =3D { .mask =3D BIT(24) }, +}; + /* Panic will assert when the buffers are 50% full */ static const struct mxc_isi_set_thd mxc_imx8_isi_thd_v1 =3D { .panic_set_thd_y =3D { .mask =3D 0x0000f, .offset =3D 0, .threshold =3D = 0x7 }, @@ -322,6 +337,28 @@ static const struct mxc_isi_plat_data mxc_imx93_data = =3D { .has_36bit_dma =3D false, }; =20 +static const struct mxc_isi_plat_data mxc_imx8qm_data =3D { + .model =3D MXC_ISI_IMX8QM, + .num_ports =3D 5, + .num_channels =3D 8, + .reg_offset =3D 0x10000, + .ier_reg =3D &mxc_imx8_isi_ier_qm, + .set_thd =3D &mxc_imx8_isi_thd_v1, + .buf_active_reverse =3D true, + .has_36bit_dma =3D false, +}; + +static const struct mxc_isi_plat_data mxc_imx8qxp_data =3D { + .model =3D MXC_ISI_IMX8QXP, + .num_ports =3D 5, + .num_channels =3D 6, + .reg_offset =3D 0x10000, + .ier_reg =3D &mxc_imx8_isi_ier_v2, + .set_thd =3D &mxc_imx8_isi_thd_v1, + .buf_active_reverse =3D true, + .has_36bit_dma =3D false, +}; + /* -----------------------------------------------------------------------= ------ * Power management */ @@ -497,6 +534,8 @@ static void mxc_isi_remove(struct platform_device *pdev) static const struct of_device_id mxc_isi_of_match[] =3D { { .compatible =3D "fsl,imx8mn-isi", .data =3D &mxc_imx8mn_data }, { .compatible =3D "fsl,imx8mp-isi", .data =3D &mxc_imx8mp_data }, + { .compatible =3D "fsl,imx8qm-isi", .data =3D &mxc_imx8qm_data }, + { .compatible =3D "fsl,imx8qxp-isi", .data =3D &mxc_imx8qxp_data }, { .compatible =3D "fsl,imx8ulp-isi", .data =3D &mxc_imx8ulp_data }, { .compatible =3D "fsl,imx93-isi", .data =3D &mxc_imx93_data }, { /* sentinel */ }, diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.h index bd3cfe5fbe063..206995bedca4a 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -157,6 +157,8 @@ struct mxc_gasket_ops { enum model { MXC_ISI_IMX8MN, MXC_ISI_IMX8MP, + MXC_ISI_IMX8QM, + MXC_ISI_IMX8QXP, MXC_ISI_IMX8ULP, MXC_ISI_IMX93, }; --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2080.outbound.protection.outlook.com [40.107.247.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03A9D257ADE; Tue, 8 Apr 2025 21:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149271; cv=fail; b=W1nTu5cmmrRLKufdWa0uI5BdWTwIxmyxhcCfCK8Y0DN4OEpp5fvsXwV9NWdrxDaw68vlR1prDicbb3OWwIs0KX49KZEY24U8GqHg4NgrEGXyaTv8J3IRlcKEvpQxE/nFOkeCgKWqEOvfp8UA5R1VJt4btpUpmBNcgMwiBaurnxY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149271; c=relaxed/simple; bh=gT7TQyKgYZuetnnl6gwDMCC6/lEUHqBeUXW9L55spUc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=GigCeQYERfy5Og1DtFtfTRDGV9tkTczVWbunma2kXWNvFpktU9gbGIbHgdmo1k2TVI/VgQaETO/ttMR2Ttme2oW5GgVqa8EwfKM4N0LQ2SI/difuLRhOgZKV5wZgOvKs+QONeanCaQr+eomAkjKAdSY7pJQy13YACuYw6UkrWPs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=b3GFbAEC; arc=fail smtp.client-ip=40.107.247.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="b3GFbAEC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RZU2PHPOqJmAtPPmKqkypyk0rAlX/EsmE2p6/xetMqqU9dOYD/iUovDjqhdg0edz/TLGgBrkpZBQKAvcWoP49qEJNp7JPYcny0a1t4I/W4KRlBf4Q8QJG3pI0GaMdnrAF2JmFio72vWABbMu9+dfLTc2poPEunKEJ2bDoQRgvteQqVsh21kci2cHzsnxOob+q3gqarVCiwCP+sXmIvZlb/el9yZ5PvNR2tNIGTEo4em5xL5/+Q6NzCixK+1T0LzIr0didDQ9TB6rDoDeIJFqY3CBKwPLdr03EKnCart96/+eHWxqjseD/ELGmSyGUgKEKLwFwgFWNTCGQH2K0i05xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0njBYaDqHi0STH6HD1Pn6JF8CKUVA1NbQ/MTWrJq4Io=; b=uAjtBfdIGP0Zt6+AlZJ35SMm4Htby+pnJooMvd7Bg3aW8YcLnPPfPU1XtOwrP8rqAaD8BXvQONTkYj724y2d9tK5ZaRdHEUo9oZVmN54YCxSzBBMWjuDKZ5WvytZK1AdrOO5S8XYSBsVPQxLDfAhRq3HWGyapXLrICGJUoSlQAGyzUQ+4S+Jxu6sPUBUCNNXuK4DIgwIK8sr6hy5km267v9qgJvC66w0RMX88q3drRUxq1lQyCZW36X/4zypXmZtyMU4WPDEeUil6fJT8RfZerDBPpDZ94qMzu98276zRMUp/7AOK6SjpZUUwaLROXX3aDKjmF4WHRBA9TySwLuvDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0njBYaDqHi0STH6HD1Pn6JF8CKUVA1NbQ/MTWrJq4Io=; b=b3GFbAECyGYAPm1ghdX499w/zNBKuyiv5+IOBfdgvt81V4Mii2NrkrizO+Zbx2H9ybyz6fgKPQP59N6OuCthmvGvVW041A+J6VpaWFWEm9nt0Zwv6gQjtqU0kPwZ5tOLfQuXAfLcfSti0J3k7VGCgyaH7s+fpXEgWNBb+QxXc6VMzZeDZ4E8WrszWzWOZwAgrrY0sfuFyhL4bH+0epTChVIkv6tWUyeSv1lZY2f6ySUi0rhQ55mf7tp7r/N4RA3cSUBbxQr4ifOhZV7Qvl+5d4XkBA54KQcYew1l4RBR5WdmRTeEGHNCd5pBMtHOCqwJJk4P7lAGffvw24eGUhfW7A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:27 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:27 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:06 -0400 Subject: [PATCH v4 08/13] media: dt-bindings: nxp,imx8mq-mipi-csi2: Add i.MX8QM(QXP) compatible strings Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-8-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=2959; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=rNuCdUc5m2jz4Pb3frjMkhoKTZ+8o8wBPm05WwQ2lJs=; b=kRErM+hYLJgap+J4w4k5MHS/ajaEeBgtqECyyo14IK4tQ3m66nfC8nJJr59KzjgoOmWpfroEW CuBr7dsjp2UAKZAO+rulVdAHMEIzGm9bYNPgPGdV4aQNS9skJZvE6Mb X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: d3c75894-e619-4c27-8856-08dd76e7eec7 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eThvOFMySzUvZm5VZDZCOVplOTF4SlZsQzJwV0JLY1JjMzM1TVJERmFKTnlN?= =?utf-8?B?cFhpanBaOU1pTldnOUVXWGNwRWRHVDE1SEFZL01qZUNOS3cwZlF5VGFIQmg3?= =?utf-8?B?aVZveE9KY0xFZEZxNW9pdEgrd0IyRmdmT1IrYmpIRE9NbE9hcWZlZjZxaWFP?= =?utf-8?B?OXhkQUJLQ3pWOFJETHNWYUQ5NXcveGdGUzlOYjk0WFVOc1c2a1VZUVYreXNO?= =?utf-8?B?bmNHeitVem13QnNkLzdwS0xIRiswTFhCRkxHUTc5RVZVcFF2am5iRW1wVFZN?= =?utf-8?B?N2dVUnZRQytrOEZuRVVmcUluTXlwUzJyaGFXMW9XNU9NN2NpRUhzK2YwdVZn?= =?utf-8?B?NFdCYTRJRW1BaUdIYWhsVFUwRTNpUUoySFcrYU44ZVBIQlIyWTNoaGNPRU01?= =?utf-8?B?SWJMajZWeFVLUXlua1lkdTRPZ2lvL3R1R1Mwa0d0OW1GQVptMEhtei9DcjNn?= =?utf-8?B?bVdreE0zNG9iUjJpK0l3UnU1N2NWcWg4U1RMbjg5cnMrejlvMlBwd2hnaU5F?= =?utf-8?B?NkpIZUhJbk03YmEycGd6dWFpWnNneE5NS1Z5Q1hIWUREZzhvSDdIZlUrRTZK?= =?utf-8?B?aThPYThJeGUyT2lIT2NmeDMxc3ZkYTZsTzRCenFXamRxcUN0ekhBRFdVeml2?= =?utf-8?B?Ti9DTm4yQmNrd256YitTblNBcjNnTVViT2QzRi9MeW9sZHIvUDR5UC9TZHJX?= =?utf-8?B?dnZMdWNFdERXVnMxSHlsSEpGa2dqS3FIUnA2cklIS25jbS8yN043cWs4bG50?= =?utf-8?B?NS8wcGZSalVFRFlYU1JmenlRckVzQ0hxNWRLK2srMSt5Y3RoRmwyWlA2ZEU4?= =?utf-8?B?ZWlTYm9OTkg1L0hvUnRwNklyRWZ4ZDR5bG1rZDVla3ZjemZaQk1LOEZteWZw?= =?utf-8?B?bG83YktTeGlEM3ZVZms2bGJNL2VtUjU4dkd3ZkxyUHAxVkZWMllkNUY1QVRi?= =?utf-8?B?enpvbTlPcXBZRVp2UUdObVdYOFE2Z0ppWFMxM0FCS3NySlYza0VFMk5zMFpY?= =?utf-8?B?S0J4bVBCZ2lQOGxNcHN5VG16Q3hZeGpiN2lrRmt0bml3QmxtV0VGYXlKdnNt?= =?utf-8?B?MVF6MitnQnlFeTNXdHZhNUdlWnRIY2pNRFJ1Qm9OaTdPUUFDTlJSdGIvei9Y?= =?utf-8?B?ajVXTFYrdlhCaGx0emZxbW12anB1RGo4STNhY0NVckxVZHM5RmQvMTlURS81?= =?utf-8?B?eEtHUzBuVm50VU5jNWFxMWJPNldDL2lsckNjb0lJN1BObWpHbEZBRU1CTkYx?= =?utf-8?B?bHZUQ1hwVUMrSHZRVSthRHpPYXNveVNDSlNMTEMvRjNxcU5mcWFLSGVaak9o?= =?utf-8?B?YjFhK1FVQlBHMHczOUphYWZLSWVyTGZYOEJwNTczSHVhcm45aHcxbTdEZGE5?= =?utf-8?B?STZ0VlRYUnh4QmJKb3FMR0pkNmRWUUZ6S3VvT3RydE1QSFUvQXNYUUo2SUZ0?= =?utf-8?B?dFZYVGdPZm52QWR4RlphUXFOcCsxUUd2VFg2UkU5ZFkwT2pPckFkU1gyejZX?= =?utf-8?B?OVU5bFVaWGNWc3hIc1hHdTRlejJEVEtNdkN2ZEVFcms5NGlkbzZtZWJPcXFF?= =?utf-8?B?ZVg5SDVlTG9HQ1VHdFJHKzFBYjFDSmVhUG1MbENQSHRsdlYxMTJqV09lWFI2?= =?utf-8?B?dWFDNEZLaFR2cEx2SWFra0hVWkZpQ09QdjFRYjZCNlJtaU02MElGMURYaFdu?= =?utf-8?B?UzhnVnJGdUF1UWhHaisxSVdLckR2Y05aSm5iSWJvRUtPbDZBdG4xTEg1UGJq?= =?utf-8?B?Ym8waTZUS1JzRUF4QUpSYXRMTlROK25XcE9mWmxYc3dxbDlZYWErcjJ1WUdO?= =?utf-8?B?aktCMUdVeUZ5eEhsZ1luVFVLMm4rbE1YOU1raVpSTjM2OE1pMmtVSkV1end3?= =?utf-8?B?em5IdG9vMXNVWlUyU3FZRENQYXhkeEpzeWFlMjR0d3NTVVg5YXZGSnF1Z1BF?= =?utf-8?B?V3lDL05mcFZjL0Z1dnBlc0tMMEU3VWdFYnBTWGllSXZDcXRaYTlEYnp3Sm5Q?= =?utf-8?B?Z2R2dWVFY3V3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTVwR1VYbit3ZkJ2RjdDSnlZclU5VEhvL0thdWlXVGxzbmJlbkhXRG5KMENS?= =?utf-8?B?RHRKU25ZUlNQaDZKcG1NZGVjdzhiQVM5VHlvUkwvZ0p4Z0dIUmMrMXVuSi9y?= =?utf-8?B?amxKSXBDTElKeWxJQklTbjNTSGUwRkcwcVI4OUsrbFVZcFZEMmk1MnZJSFJs?= =?utf-8?B?OW4rNG5FdVNRcy9jM3JUcDd4Um1EeExZdnpMdnVqT0hWWmZNMnJnL2h3OEZ5?= =?utf-8?B?Wmt5bERKOUZwdHd5eFhENkE5MkV5VWZ5RFBacXFUZzVBTEZjSE1zSzBUQ1kv?= =?utf-8?B?Sjh4YjRBQVlxYTU1S0hrcHZNTUZLdHBlcnQzTit1NGkyU3JJV0w0RVFlaWcv?= =?utf-8?B?RFJnZkdQOUVPQVpSVE5EUlR5M1UvM3dudmJ6WVdMNnZQVzMyTWk5NU84TUlk?= =?utf-8?B?UzJJbnJiUUM0VEM4VWNaZHdQWndNVmhBTWFnZ0F0SzFsY2swWjc5VHNVeG1K?= =?utf-8?B?MVZiRGM3Nm41RExHZ2RONndPSkJnNWlVdXJKeDU2NVNRVWxWLzM0VSsrZGw2?= =?utf-8?B?bllxRFpwQm5TVkpjaWpHUzRVNERyc2lBcmMrVUpxN3dUc3IxWUFUR3YvT1l4?= =?utf-8?B?amdYd0NFUDk4a1Q5amxKSUlkZm9vSHYxK3FsMWE3MnFkRWlHZWtEalNFQlgz?= =?utf-8?B?a2dXdENXS2d4VHJEZDM4WjQxZy9YYzAzRHR3bWlFdHl2Smd5cXVvSGhXbXYr?= =?utf-8?B?Y2ViczBYQUxSWS9OR2ZMb0RZK3dkcFVFZ2crRHM2RG9DU3Rqc0VxOVUzSHBk?= =?utf-8?B?KysvT3dCa2hDMzBtTENRbTJ4T3ZNcXNHalQrNCtsN3A1bHNuN2ZWMkNPeVJ4?= =?utf-8?B?VWJFZGVzY2FCSFhnTXpvMythSmhzK2ZzcmlJa1BlUERraEtSMlZPT3kyaUFn?= =?utf-8?B?S0VSOEM0K0lzQ0RiQzBnQzA5d1YwenI1ckJ5WlB6SUhmR3AxWWZaZGRmTXlr?= =?utf-8?B?S085bTNMNTB2czBUWTdTODFlTUx4d21ldVBBcnIzU3lBVy9kM1FqK1NLbDNl?= =?utf-8?B?REhZRk9sMFlkUVJDYUdXR3UzTWMzYUhFTDFubWp0MU84WHdWQkpSazBZbUcy?= =?utf-8?B?azQ4VlQ3M1YzUDdrVUx5eWh0QnVGYzZYYjBqMUFBR0M2RFhpVDRmbFh6b3J5?= =?utf-8?B?aEpKZEJTcXpmTlhMa1Q0QVgwb2ZXalNUMStJK1ZNOEF6alc1UHVDOFhjK2xT?= =?utf-8?B?aWVZQUk4b0UrVXQrYVlweUk2TlBTSjVncE00elRqVHd2a0F6S2ErRDBEV2hG?= =?utf-8?B?bDdPUEVTSldIZlM5SmVmVTRlNEtUaXZnVmFnT2FiNDNrMnlkazZRUHg0bDlF?= =?utf-8?B?K2pXNWVCVWdCUHlRU0lENDgvUkFCUW9sRTl1eXJSUzZkNmNtSllUZElZaHhx?= =?utf-8?B?Q3BENVJvbzh5WXRkZjRiazZIRXErcUprb1BwWjJuLzN2TDZ6dlVlMjQ0SjFo?= =?utf-8?B?czhzWkhlaTRUS0ZtZjlteHhmdk9jeEF2K1dTSnZlZ0pFRkhDS1UwNWpBWUVj?= =?utf-8?B?b1I1SlFvWG0xM29mbWwvYTlyWnVnSEV5RzdhaitiVHNkTDRpUGEyelI0c0Q1?= =?utf-8?B?RmJXREJnWGtWN0kzQTVCRTRpN1pNUCtMWEtsbzlrUjZRTktLNEg5bjdMREJB?= =?utf-8?B?aitZbDgxS0c3VlYxRlZVQnBIR3ByNkY2RlR0MXR1S093QU9YMGtGK2xxNGU0?= =?utf-8?B?bFhqZy95ZXVtSUVyWHNHVU96N2FCc1VnQkJEOTJEUFB5dmh1WWhyWFE0OVFP?= =?utf-8?B?ZXZpU2k3VXpiclNjTXVQbzlOUVFENTc3ZFdaaFN0Wm9KVG1ua0ZweU4xeFBM?= =?utf-8?B?L2ovNDhLQjZjeGg5Qi9GMlMrWUxYR3o2bjlDRTZ6UW9meFArR1VDcFgzVzda?= =?utf-8?B?ZEtrVzE2azFWKytqdlNGL0tKWTF1Q1J2a01zQTVWamFFVlJUNnh2NkwvaDJt?= =?utf-8?B?VkluNktDWTRabldZYXN1ckY4T1Y3SzFKUEppSkE2aFB4OUtrOVVlUkJubFUz?= =?utf-8?B?aEFGQURSVTVISVhOY1BiejV4czBweFkvZ0c4MmNuZU5sMHBCaEdQQlJFSVow?= =?utf-8?B?QU5XRm1iVlJqaFlLZ3FLY2d6R1pORlZuVHp6WHJ5ZjhxT05hd2djaERTU0pW?= =?utf-8?Q?v9xoNNrrhzJabrRdMKGnkeJBy?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3c75894-e619-4c27-8856-08dd76e7eec7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:27.3924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GjUTN60pdLCCU963M2ww40e8K5SXZf40dTwimuGwfmSpG2IJamCJOXH2QBWiWFhJbdq7Li0r/NGCum87y0z98Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 From: Robert Chiras Add compatible strings for i.MX8QM/i.MX8QXP platform. Remove fsl,mipi-phy-gpr from required properties and add new reg space, since i.MX8QM and i.MX8QXP use dedicate control and status register(csr) space. Keep the same restriction for other compatible strings. Signed-off-by: Robert Chiras Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring (Arm) Signed-off-by: Frank Li --- Change from v3 to v4 - use MIPI CSI-2 - Add Laurent Pinchart reviewed-by tags. Reset description is not very accurate, but it should be good enough since use SCU reset. SCU reset do reset for PHY and controller. change from v2 to v3 - use dedicate csr register space change from v1 to v2 - remove internal review tags - remove reg maxitems:1 - remove 8ulp part - add 8qxp compatible string and make 8qm failback to 8qxp - limit reset and power domain number to 1 for 8qxp and 8qm - remove power-domains change because 8qm/8qxp only need 1 power domain --- .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 38 ++++++++++++++++++= +--- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.y= aml b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml index 2a14e3b0e0040..3389bab266a9a 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml @@ -16,11 +16,19 @@ description: |- =20 properties: compatible: - enum: - - fsl,imx8mq-mipi-csi2 + oneOf: + - enum: + - fsl,imx8mq-mipi-csi2 + - fsl,imx8qxp-mipi-csi2 + - items: + - const: fsl,imx8qm-mipi-csi2 + - const: fsl,imx8qxp-mipi-csi2 =20 reg: - maxItems: 1 + items: + - description: MIPI CSI-2 RX host controller register. + - description: MIPI CSI-2 control and status register (csr). + minItems: 1 =20 clocks: items: @@ -46,6 +54,7 @@ properties: - description: CORE_RESET reset register bit definition - description: PHY_REF_RESET reset register bit definition - description: ESC_RESET reset register bit definition + minItems: 1 =20 fsl,mipi-phy-gpr: description: | @@ -113,9 +122,30 @@ required: - clock-names - power-domains - resets - - fsl,mipi-phy-gpr - ports =20 +allOf: + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8qxp-mipi-csi2 + then: + properties: + reg: + minItems: 2 + resets: + maxItems: 1 + else: + properties: + reg: + maxItems: 1 + resets: + minItems: 3 + required: + - fsl,mipi-phy-gpr + additionalProperties: false =20 examples: --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2086.outbound.protection.outlook.com [40.107.249.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B42E2580CA; Tue, 8 Apr 2025 21:54:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149276; cv=fail; b=RmE3d7oDkTf72FSCzhQC2q/UOK1RjqkRvRr1hsL2bv651fjRE5uFIa86LDGeZ3R8D2o30Bn9QcTlCyea9Zpnc298XP+H4V4w5AEaIhbZ1BPffu1/C/u00pZwiVWUt2aHZmNC+QI7q8mVL66T653ivbIcZxSzRybC+ESLzdNEb2M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149276; c=relaxed/simple; bh=FaDfGMR3swA8QXQAar4w069jozmRmSBM+fQOBalUW/w=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Ku+yp12yA0mkEOMs8UWi15f5VphGxMQalzcfeSdLluU3wgFZEdcIt8NzGED1iqs2JbhDjTYAPLEkv3nvJNjHpXvymW8Y7BqW1cx/n7ZqiqZDWD/u7jJAXAFmE4reaBiIeMtEJGg3AYqxNU05hps7nGedzh3nW5DJL5C/s44+uxU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ZgHAf8lP; arc=fail smtp.client-ip=40.107.249.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ZgHAf8lP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jCrM5s6PZ34RWY3iRGQiAFW3UTeOjZg8efSr1XvDbAeRs1IeqjAsr6YIn34pLZauJLQTC59/aS62V90XN6EI/HxCFV4174cRFy+Ni8GDgOoo79zeIA11z68iaY3ElHVYq64BisPgbfaQi6vNqDpS3V4tJNtGZiNV1w6XHha7a3wPrvb+dRIAcxBW9OFSgzG2Oz1/6M4J88JpSXCwPp/rTSyERyVIkUXMTO5HXhyIsZnxX93JyZjfvlIlWPBVuA6GX8GaYkFiU33ynXNXno5O7K0RtW5CH+OePaqIOQLhG4/Qw9xY8ROd0kzC7Io7r2mQp95rV8JBiWbUpPMTZy1bag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dffwg9LBBpZq8rLz4RzxC3+OKWjjHLRSiKIlT1Q/7dM=; b=LcOUSHFwacTRqnXI6aD5bozI4BaVIgTunT7CxUqRfGcHlLoCRqs0K8Dik+cW4ctYBD5ylj4hfOCFzh/aeibO2fJgSiyMFgjnNjWPbRzb0Hr7+8umZ7FFJxn3JdcExAuCB+7jicrgpdP1IlNLR+sJybC9DBPqtoUy8LTW0RZ4MZ43KOxTV2WbH8ApLSJyM63eNQQBQDsVqG/hqBUoD+IAo/s33zrvCBOdIfjn5D9q5tgTh3RpdZ79Jz2wVur+U40Zt94oO0tjs1M8J1i/ASTeHrw69inbiFJ5nOfrNdXpIQm5u1Xi4OOncJXLnmZakVC3x8vKyOSD/JU3M8XPU4PSXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dffwg9LBBpZq8rLz4RzxC3+OKWjjHLRSiKIlT1Q/7dM=; b=ZgHAf8lPsFtorEZ5VVxQx5uVXLQqIN/NLaVRaZs+IUdc9D9HlQzGDSIJWTVnJdXhiD/ve/ukBQesKMqGTAzvLUYLfD7jNMA5xWWVU3S5N/Kx0WoBi9FNEoqQ2170j0DXfdmIX8Qgt6Wh2UONz0YyV+2t3n3Kxzy6LUK+3AiZ7AscaOWuO4eRKxBU767ti6YdtIEXa4doo6V0n6ydu6fZVOLe3FuKYCgkxQNTWbnFTd3NsinXJnJZ03S5UujxiWZvi9Fwfr/H2Cp/ZTtEQZEVcilpYSYHfkDB936xbKH0xOup5kEyXBl7wzrOnqbNociQ/Q4GVq9grzD0v3rqcwi0mg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:31 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:31 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:07 -0400 Subject: [PATCH v4 09/13] media: imx8mq-mipi-csi2: Add imx8mq_plat_data for different compatible strings Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-9-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=4412; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=LyukIx+1tiwYPq19TZRYdEvx1H1hK9TvpLaUo0+Fvmk=; b=vHENDKGEwBW/ntMVYAp+FdXOA6MiKjLxelVgNP4IFgF9xmYs26DkEATEo7COZS0JLeacX9oeb FoB7TuPBkdkCJPsRSYdiu5DbjWfpiVwvDZXR51OPM7Yp00j5J8AMdfK X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 469c45c5-cefc-4548-9b90-08dd76e7f148 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cnQ2SDlnanVPZ2RxRjJQRlNpeDdqUm9IeVk3VWZER1VPdk5TZmwwbHdTamRG?= =?utf-8?B?SHIxSGlsU0dRN0t4c1duWWZJSDc5U0ZSWGhxRmp3bklObFhjWVpqcnJ2ZE9X?= =?utf-8?B?VUpMUll3ektQbm1ncDd3aDlXTDMwVmJReXltRXdGVEoxTDhsSGYzZ3dZNm1l?= =?utf-8?B?cWJQSGtrR0dKTGhRWTIyWHJlQzhVZ3FCdTFQR0pwSHJpOGZUMXBWbHRDT2x0?= =?utf-8?B?YXNWcDZvTkpBWnpRaUZrVFY2aUVLS1hyVCtzU2Y0Vmx3WHBaQUxKdElNdWhk?= =?utf-8?B?TFJIb2htNjJhOXNGS0lXRG5IdmQyb2pvcmpGajlRTHpDNkhFVVFrSHoyVnV0?= =?utf-8?B?YURReCtQNmpxeUJsSW9qZlpMSURtQU14RWk4WnFqRDJzTTR3emJwRFJCVFRH?= =?utf-8?B?L3R0aDVjaWJpaHFOc3dNKzBQNEdYWVExNGVEK3ptbVUwd2paRWthZVBPOWpM?= =?utf-8?B?T0JSUy9nOXdmVEo5Tk5ZQWorMzhZQUJtVGJLVWZzTDZ3ck4xSXJFdTlQZFVY?= =?utf-8?B?dmRJa3BPaGZwMmpUZktXS0lOYVFMa21sTTdyZE9URkFOeFdYa1h6eFd0UmVV?= =?utf-8?B?Z2w4UitNSWtTVWRmY3YwalorZTNRV29mam40NmNDNHltem1WVGtFM1Z4Rm5P?= =?utf-8?B?Y21aR3BXbmdZZE92eTVvbSt5Tjg3ZlhOaExEMW9HYjRLcEF3VlpEK1llaWVx?= =?utf-8?B?Q2pSSHo4WUQ4VG1ZSVlsT0x2UXVJMVRyWG90TkJoRUhFa2U2YlV1cHgwTmxo?= =?utf-8?B?NzNXQStrTExiM3RDRFpVWVF1eVNPeWhmVWU3UGh1RjZNeFlhaExqVExKZTY4?= =?utf-8?B?OW1XZm1ueUt0RmttMTRPOTBzMUtMVTFvcXVVbnA3R0Vqdy9BYnN1Mi9OSGth?= =?utf-8?B?U3FGU0l3K0xuQXRadUg0YjJHcDFrQjFFNmxIZUsydkx5M3gzK3MwU05GQUQ0?= =?utf-8?B?ZE5qTkZaR1NtU0lBbjlPODlYSzJHZUZ5aGZQNm8vQlBnUHkzb0FjTVZjQ3ky?= =?utf-8?B?cmhKejdTU0tlcTM2NzNQeUUyWDJwZVZnN05sMTM1c2JHSVJKdmg2azZIbGt4?= =?utf-8?B?S1Y1L1lHdVJMVXB3dEVWNTVKOHVPc2hVVC80M2FSWTUybDJCYldVNU94bElS?= =?utf-8?B?MFBwQ0xIM0Z4eGhPdDFJMEdiVmVDbVYxVFNLa0d3bmVGK3VJVTAydzlZMHFQ?= =?utf-8?B?NjVhNnJTK0RBY1pPV0tXQ1NtNTd1Mmo0dzdacHNWNnB3NVVDTDNvZFhTMkQ1?= =?utf-8?B?MVFLZ1A3ZGx3UkFwc0U0TFdtM2lGRlkzeDRQVUpCZEVxYS9PUDcrQTIvZmor?= =?utf-8?B?YUJ0YStuZFZ1QlgvWDJOYjNWdTN6M0RvOFdCSnV3R3hOaVA5TGhSbVFxcTBY?= =?utf-8?B?RXlTeXNLQlJXY0Nja1NjVHoxeXJTVDJIdkR4UzJvT0ZVN0ZPdjdiYXE0aUU4?= =?utf-8?B?ZzFRb2ZHRlJneFNZS21FNk1mVHRENlZ0cFJoeDV4YzU2UXVBRkdlcjdCR1Iw?= =?utf-8?B?MC9ZQ1dIL2tVT3l2Ymp3VXgvcnV0aFk1SEFzZGhHemNtR2hLTm1aRk9ZTTlJ?= =?utf-8?B?eU85a29iRCtKREc3WkQyaXZabkxZM3dWNlpMT0VwbCtBR0U3cnVJU3BaUFNI?= =?utf-8?B?RlNsN0hiZS9wY0hCR1hTa1huWlg1NURXTGx4eXlZNnhORHNXR0RmVTBSMmxN?= =?utf-8?B?bmFvTGp4NG4xRHVEWWRwc3ljUjFpNzBFZTdqOVFGT1ZuK05hRHhaN0crNXM4?= =?utf-8?B?ZzU4OU4wM3M0VHNiU2xRKzRCeFpLZERZT2tRWDNUc0NPZ2NVSm5rdkJWbEs4?= =?utf-8?B?aSthWVpNcGl4dXRjRmQzbGI0bFJiVW5haDVBanZlNnBITEc1TytKTE42Vzd6?= =?utf-8?B?bHQwVXBHQ05BYTRSd29OSHVyV3JpVGphYUR5S0tiZ1N5N2FZQkUxTFY3Zms1?= =?utf-8?B?angyVG1JWGVPczlmN1g5OWhTamdtb2piZkJxRmRsUzlnN1Vzb2pqUGs0VGNU?= =?utf-8?B?OGVtS2ZvQjdRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzFpdWhnQXZxQlZiZ3c4aXNGcDZOQTRlTTlSdEVzRDEwZko2UjdSZjRwNlNq?= =?utf-8?B?SkFwb09FS2M0alNaaVg4U3EvSTNqQ2FOYWIvaXZrWjl5RHdVeFVOTDRPK2c0?= =?utf-8?B?TE5FVGNvR1ZkS21mZUpQSzhjVTFFR2tFMi96ekdqWlVTVjI0eXpYL0xhQldE?= =?utf-8?B?Z3hTOGI0SjBhNTFrZlJiWE1yZ2FhR1JsaXg3TDlEbTZBZHN1UUxjbGtiZmVR?= =?utf-8?B?YkdZTlM0L3BkZFVSZG1Sbm1vUWVKQ2tyeWlLWlJ4dG9LTU83M2VGNCswcis3?= =?utf-8?B?WU1JVkNlMUxQTW14Nko4UXJpY0RzcEtHTGd4U1hZVXkva3hySDNWbGEyaEd2?= =?utf-8?B?MGcvL1lRdDAwbFoveGVINEFGSjFLbnlONE9xZS9qMmNYcEZNVWtsK1NRdDJ4?= =?utf-8?B?UC80UHlYQkZBTjE4M3FZS1pROGpkTXN3dzFHRDc0UmpHQlNNa093RHFxWUYy?= =?utf-8?B?MkswQ3N5UjN4MC96aDN5SDQzWnVWOE9Na2tZUjRHUWxPNGpEclltSnB6cTVy?= =?utf-8?B?c2tuZGlYSldVNDhIcWZaQ3BsZVRyb3U1QjJtUUJhU3FxWGVNalJqay84U0hL?= =?utf-8?B?TkFraW45YmJlUVNMRWtwNFdlT0RSVElTLys3bkNhSWR3RDNzVFJkU1VKc0dh?= =?utf-8?B?WXJzUDlGZEJYTytUNC93dy9YMDVSZmZ3YjQ1ajBxa2pwemxMZjdEWjZkZDQy?= =?utf-8?B?dUZHaUEzd21lNXpIQllXTCtkTVN4L0duY0dxSEl6aFlhV2JaaC9iY2dwQTQw?= =?utf-8?B?cHpRUWd0Ri9KakNaY1h2WE00c2ZMV2hxTUJWMDgyM2xTaVFWQThjdmo0YmNG?= =?utf-8?B?WmNHVTV3NkhZZ2FJaWsxK1BUQXI2VERsckRnK2YxMEp5UG5XQUVOMW5GK1hZ?= =?utf-8?B?U1E2R1ZxZ2NZSmlkcGFRZnNkemZKd241aWlzeDVhMUhvaUh3d3V1ZkdvaUho?= =?utf-8?B?bGZXSmwrV0NTOUs4NXZ6MDFTUklMdkx4R01wZXZPai9tK3ArSHdyZjA5bjZP?= =?utf-8?B?amJGaWYyQTZlWFJxckw2UU81L043dmsrTGlDcytlcDJnb1lxb0lwQ2hlNTNU?= =?utf-8?B?MnEvd2hHU0RtWFR0d1cvY1R2T2xCNXdUMDhrZWN0WElzN1haRmR4SmxZd2VE?= =?utf-8?B?d3VMMm5MTzg1eEFlRjJuWXJUaGcvYVIrdnBMYVJucW5PVmduR3N6TmN1Sk8w?= =?utf-8?B?Rm81UnM2bmJwcUNDNDZJNU1YbCs1akQ5QjVvaG5Qd1dObExVNDQ1V1JDOE5H?= =?utf-8?B?WTZrZm9hTXVuRmhnUnhUN2RVL082Q3lGeXpNSFBVTUZRc3ZUWDdpTXZUbThI?= =?utf-8?B?YXhETjdYQmMveVJ1YjRFc25TZzlzMjkvdzcyckdGeS9Gc3Zrak8razVFTCtP?= =?utf-8?B?RGVEaWRwV3daMDRaa2pCWDNsSVU0Z1JuZ0pHbnBqbW1USGtPeWtWcko2RjlC?= =?utf-8?B?ZkhRTDhOY3JNd0gydDVZZk5tM2xpbDE3NWpQUllVdktuckdZazZ5Y0d1YzN6?= =?utf-8?B?QzBPZnB2bkRqbzk0L2FVSEZ5aFhjbnJyTVJ0V0dQR2lhcFhnd0ppdVdWajQ3?= =?utf-8?B?bDNjTXlEd2RkL09NREV4M1ZzY1ovUURuMGhEbktFS1lCcnFIUUZFV214OGJ1?= =?utf-8?B?RktReVE2K0Nkckozd0Nzb3h2TnZneWZ3TkdXVmsyeFBLaCtieTFyUEsrL2R3?= =?utf-8?B?MTdEOTZtaTdPWDBHNXlGUksyaDdIZDcxZm9GZm44NjRFeDB0RFRtdUtYZ3VR?= =?utf-8?B?bjNBZ3hIOUY3dG0rRzdsY2lJQk1YUDRsRVBjZTBydVYzYjRiNGRJRTJCZ2Z1?= =?utf-8?B?a2tjZnJhYWpaM2UxU3Y4RUhGWXBTcFpqaURxdFJLQXNWODdKenQrbXRDbXJM?= =?utf-8?B?Y2M0MXA2MXlMQjRBcnhxRWpza1NFSXJCL0lWNHJERmtrNjFoTmswSDlkb2hK?= =?utf-8?B?QXl6RUF2UkxaV2NUOXM1MkpxRWlPZkVEUENwZ0Qzei90c0dBYWhmR1JvQ09i?= =?utf-8?B?MnRUYjU1WUJSZkI3WEZLb2RieGdNMTNFUnEyUzh1RlZNeTRJVENadzBYRS9I?= =?utf-8?B?a3gydmRNOHZwNG91ZzN1aXBMdm9TdmgwUDdES1NvN0cxRGdlcUlibmc2b2o0?= =?utf-8?Q?U1sdCkXjai0PJopHYdT/QqKff?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 469c45c5-cefc-4548-9b90-08dd76e7f148 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:31.5734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SoAlEm6fGJT3pSKxxwhwFxO8sAWBPe1tRlzfr4n9MR+0MIitMGs29JUExffJXASP8CzYcWGY0P87P5SE6qQN5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 From: "Guoniu.zhou" Introduce `imx8mq_plat_data` along with enable/disable callback operations to facilitate support for new chips. No functional changes. Signed-off-by: Guoniu.zhou Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- Change from v3 to v4 - Add Laurent Pinchart review tags - remove unused 'names' Change from v2 to v3 - none change from v1 to v2 - remove internal review tags --- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 58 ++++++++++++++++++++---= ---- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/= platform/nxp/imx8mq-mipi-csi2.c index a8bcf60e2f37d..59ec7107b4508 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -62,6 +62,8 @@ #define CSI2RX_CFG_VID_P_FIFO_SEND_LEVEL 0x188 #define CSI2RX_CFG_DISABLE_PAYLOAD_1 0x130 =20 +struct csi_state; + enum { ST_POWERED =3D 1, ST_STREAMING =3D 2, @@ -83,11 +85,10 @@ static const char * const imx8mq_mipi_csi_clk_id[CSI2_N= UM_CLKS] =3D { =20 #define CSI2_NUM_CLKS ARRAY_SIZE(imx8mq_mipi_csi_clk_id) =20 -#define GPR_CSI2_1_RX_ENABLE BIT(13) -#define GPR_CSI2_1_VID_INTFC_ENB BIT(12) -#define GPR_CSI2_1_HSEL BIT(10) -#define GPR_CSI2_1_CONT_CLK_MODE BIT(8) -#define GPR_CSI2_1_S_PRG_RXHS_SETTLE(x) (((x) & 0x3f) << 2) +struct imx8mq_plat_data { + int (*enable)(struct csi_state *state, u32 hs_settle); + void (*disable)(struct csi_state *state); +}; =20 /* * The send level configures the number of entries that must accumulate in @@ -106,6 +107,7 @@ static const char * const imx8mq_mipi_csi_clk_id[CSI2_N= UM_CLKS] =3D { =20 struct csi_state { struct device *dev; + const struct imx8mq_plat_data *pdata; void __iomem *regs; struct clk_bulk_data clks[CSI2_NUM_CLKS]; struct reset_control *rst; @@ -137,6 +139,34 @@ struct csi2_pix_format { u8 width; }; =20 +/* -----------------------------------------------------------------------= ------ + * i.MX8MQ GPR + */ + +#define GPR_CSI2_1_RX_ENABLE BIT(13) +#define GPR_CSI2_1_VID_INTFC_ENB BIT(12) +#define GPR_CSI2_1_HSEL BIT(10) +#define GPR_CSI2_1_CONT_CLK_MODE BIT(8) +#define GPR_CSI2_1_S_PRG_RXHS_SETTLE(x) (((x) & 0x3f) << 2) + +static int imx8mq_gpr_enable(struct csi_state *state, u32 hs_settle) +{ + regmap_update_bits(state->phy_gpr, + state->phy_gpr_reg, + 0x3fff, + GPR_CSI2_1_RX_ENABLE | + GPR_CSI2_1_VID_INTFC_ENB | + GPR_CSI2_1_HSEL | + GPR_CSI2_1_CONT_CLK_MODE | + GPR_CSI2_1_S_PRG_RXHS_SETTLE(hs_settle)); + + return 0; +} + +static const struct imx8mq_plat_data imx8mq_data =3D { + .enable =3D imx8mq_gpr_enable, +}; + static const struct csi2_pix_format imx8mq_mipi_csi_formats[] =3D { /* RAW (Bayer and greyscale) formats. */ { @@ -371,14 +401,9 @@ static int imx8mq_mipi_csi_start_stream(struct csi_sta= te *state, if (ret) return ret; =20 - regmap_update_bits(state->phy_gpr, - state->phy_gpr_reg, - 0x3fff, - GPR_CSI2_1_RX_ENABLE | - GPR_CSI2_1_VID_INTFC_ENB | - GPR_CSI2_1_HSEL | - GPR_CSI2_1_CONT_CLK_MODE | - GPR_CSI2_1_S_PRG_RXHS_SETTLE(hs_settle)); + ret =3D state->pdata->enable(state, hs_settle); + if (ret) + return ret; =20 return 0; } @@ -386,6 +411,9 @@ static int imx8mq_mipi_csi_start_stream(struct csi_stat= e *state, static void imx8mq_mipi_csi_stop_stream(struct csi_state *state) { imx8mq_mipi_csi_write(state, CSI2RX_CFG_DISABLE_DATA_LANES, 0xf); + + if (state->pdata->disable) + state->pdata->disable(state); } =20 /* -----------------------------------------------------------------------= ------ @@ -876,6 +904,8 @@ static int imx8mq_mipi_csi_probe(struct platform_device= *pdev) =20 state->dev =3D dev; =20 + state->pdata =3D of_device_get_match_data(dev); + ret =3D imx8mq_mipi_csi_parse_dt(state); if (ret < 0) { dev_err(dev, "Failed to parse device tree: %d\n", ret); @@ -953,7 +983,7 @@ static void imx8mq_mipi_csi_remove(struct platform_devi= ce *pdev) } =20 static const struct of_device_id imx8mq_mipi_csi_of_match[] =3D { - { .compatible =3D "fsl,imx8mq-mipi-csi2", }, + { .compatible =3D "fsl,imx8mq-mipi-csi2", .data =3D &imx8mq_data }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, imx8mq_mipi_csi_of_match); --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2078.outbound.protection.outlook.com [40.107.241.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4E3F2586EC; Tue, 8 Apr 2025 21:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149281; cv=fail; b=NJd6tJjE9VK6fSwhFpw/jIvig77bTHTqJRlwDBORlnnWh60H9ISqWN0KSODYUgCgKXJtrxg3y5LVitRo3+b/hXMSKX74X3eK05O2OebemK0UNH0W1p7ihd39xxRCfDn33TTUXSYphihvKsx6ANnUue1QG78G/5W5Oo/WHdWTuFg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149281; c=relaxed/simple; bh=GtmsxC03RxLq9WteRSAOzGXicyQnYIuxWpAMa2Eu620=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=fNx0ls/m3RyLpjXKMdf/uGi8azTHEu93oJw7k2d2mto8yts61TD+rKVPHAmxjiqBzbXWlx7bznbCIP0cKXItIBECOSvADXFK3scBG9gplN0f0y+X4lx5PfRGDE1E1Q3ARn77EqXX9r4JOJybdRKlV2onpe55mfK8l5BQg9Px558= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Ir253U0H; arc=fail smtp.client-ip=40.107.241.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Ir253U0H" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UlLsVwY7BvrWM/6K3lKNUHG6XV6LCjkoYD0MDRd5z4pkWOdD44WvEI2Xvkc+2vaACNdulFFySaO2A+LNJ01jnk7PkV1XqwEk1wP8AjUbplrMPqW5b16E9Sd9RsYZhiprDwu3P6uGuwygbb02S2Vpgu+F/IBvMq8hPay11oPRaadRa+dyLUKGfs5LNX5APoL/b0ADOfzL2fueo013jipa+xjQNgShBaL7M4GM12enZ+keSFhxLAR/Ek9GBMaALwJGHaasCyrfqnPt96P2jdjLAibpcGPl1XmIGACcpO8PQyz7Xo1ufkBwOdQ6rOGSbXYKsreuXqoDSp1DwrMVGk4k7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UKc/xl1ev/Xgr5+VylYYaGYM3luxXIPPdyAYxRjwX10=; b=WvHnfhm1/eFymcOe0QDr4hdwB1jXxuwpdSPxr4IL0QntI/HpVhsjj7CsGgSDXhjL+fgdqmJEu4yDUSW+onmQxF2IlM7aMjbPbz0JrO6RTnTz0b9Glio9UKhs++S9k64k9cno9Lt73pq84NDvkZPYsIFlZconQwQz/905sDyTE57f2Q9q65YjQG7VUldZI3RDw7LL5a6Oh+Gs4eQnvMPfajntUcpt3cSBRVHkh2EmIfg0Y0pkED0F8a7s6ip50FKD+bA75urrtQVZVFyU2kvykYnIy/mB9MiYAcC6YaMrj7lH0keEiSrihpfeUX/FLVaXKfJRQYE7/l8ZjriPTiQybQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UKc/xl1ev/Xgr5+VylYYaGYM3luxXIPPdyAYxRjwX10=; b=Ir253U0HLGcFJCO5esWZKfcik3z/WcdlEk3hJI74UpLCFg9KAQq6HzGZ7VOndDcJLoU6dYnOuulvYOQWopeTUAo+C1Run44OCtGm8wD1zPzZAnMlWvHqZCaRpEdcMUNgcS2C4lc8xQwYe7/jAUjJZYEreLnHN53BkKV/fAnZBupPrhNtc1OCtDIY23ToUOrYb+rEnD7O7gInmmaSwbzXECHyZND73COrLRtkAd8f6+F0KWRXoauq4xLhPV/JrMwjVXMnaoL05ChtX/aVSE5FjOVPZag5G97YbyQa1nWcCW1WafzjqJ0+QreOGXsqqB0nB05wz85Ow2i6PU+SaA6OWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:36 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:35 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:08 -0400 Subject: [PATCH v4 10/13] media: imx8mq-mipi-csi2: Add support for i.MX8QXP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-10-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=6039; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=GtmsxC03RxLq9WteRSAOzGXicyQnYIuxWpAMa2Eu620=; b=xiuaornq99vq6LrHG01zzPwSjlrezxFExFvpuZ1mJToSTgiD0ttd0QB5MwBWVOhcLpYJ1Eset M1+K/Az2sTKDyhp1/2M06CvnDDHLK3FjQV0h9bnK6YbNYomQ5QjuMQn X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ce136f8-07d4-4763-412e-08dd76e7f3c6 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bkE3ODZjbWZzK2gxajM0Sno5VHhsd2RkWjA2dHVBaDJpY21sdG0zcHVhNU9U?= =?utf-8?B?VXZmbEN1UEJtNUJYc0pmNGN2OERVYWw0UlpqSTNpVG9YRE1KdTlWTGV6M1Rz?= =?utf-8?B?RXNJTlJKWjNpQnNlVzFuWmh4SVR3S0FDSDNYZ0V6WVRRbm81bVZHdjIvNzVk?= =?utf-8?B?czRHQUlwVk42SXJKWXlkalpMQ0VFUkZqNTJBYk5od1VrQjR3MkQ3R3hMNUhB?= =?utf-8?B?VkJDRDlBYXJQN1o3ZlQ1UmJPdDdhS1JlQnVYa25pdFExUkpnSDg4enVlVmdk?= =?utf-8?B?RHVRQmRuTzVGeXJyR2pYVDR3UzE0dmlkYU4wYWZXeDY0ODBrN2J0VHVmSGRS?= =?utf-8?B?Z1JIMnExS3dKKzN0T2JPcDVVUzhXZDREYjZkSGVSdDNzMXhWU09oWlh3SUl6?= =?utf-8?B?U3oyR1ZvNWVLSXI1ZlRFWEtzZWdaRG5lRU53VStNR1JsMldOQTNnNVdETzRi?= =?utf-8?B?dmFMaFVuNEQ4UDZyZ2pBUDNmbEVFV3k3aXFReVp6Zzh1bXRMRGhoUDZLdzRP?= =?utf-8?B?SHFMZ2pPbk5EN01HSWJrdkxQaG1kZlpaOGdzYS9vWkNhT1I4N0tEVnkxWmg4?= =?utf-8?B?b3E2STRYOWZEVFc2alV5MTJWRWZlOGUxUCsrckQ2MmdUeEduT2gvNm1QajhR?= =?utf-8?B?Wlo1d09HWjJ2R2I5Uk9OR2sxNUZPdkFFMmNlUXpWQ1ZCcjFUeW1jZkNrcThK?= =?utf-8?B?TEJSUisrQmdUNE5ncGhyWFhTVlltVkhUdDNmQmxRaE5ISWpvWlJ1MU5NWUlr?= =?utf-8?B?VklxdnNmTkRBZS9mYkJQY0txZ0xPYVE3S1BBejczODQ3aXg0RlF6YThpRW5n?= =?utf-8?B?QmZCVGdOelM1bm0zcGZBbTVRVndOOVdSTnIxSVpaaG1DZmQrcjZtTng4OTFU?= =?utf-8?B?cTdINXZtV2Irdk11aDdCUmZjdDdvMVlCWmN0WnJXcDRyZW42b1RPY3d6Z3cz?= =?utf-8?B?Rk5kRmVMTzYwWk1MOXhRMUZjVlRUcmRQWkptdUJTWTg2MmY4dUx6NjlTKy95?= =?utf-8?B?WmFaQVpKT2FkdnlheFpuZWJvaVB0N0FqR1F3OEtvTUQxK2svcS9MWXJqNG5L?= =?utf-8?B?U1lWTmxyWXJzMDBCaGYrQjZibC94L285RW9RRUwvbGtDc3JmMWZaaGw4Nk1C?= =?utf-8?B?SFVjMHNZWktvNnRwTDEyb08wNjdDNkJldTV4VmhjVXB2L3hpWUh0K3JsR2Za?= =?utf-8?B?VXpJbUdkcUdaMzZMS2RqdTFsM1lrWUNBUTVhOXJFeVBhRDJrekdSYmE3dUtV?= =?utf-8?B?SVBxM3p2MTh0TzBPK241WS9ZVTE2T3dQdy9haVQ3UkRIaHhYV21BUlZUWnFs?= =?utf-8?B?SjhGUEhnK0NPR3NSVDZKYlNZTXZPVG1nV0hZcjJMRlhRLzI4RkhqTzVkTm1z?= =?utf-8?B?dEttWXRlRXo2eU9KSW04aGFBZGwyUDNSSjBHcEdsTVhRTnFsWUV4ZnNRdjQr?= =?utf-8?B?THpzc28rT2R6aVJLYk13Unh6NXlVUG9RZGVGN1pCU1NRd2hLSmRaSndlZ21m?= =?utf-8?B?MzNSUExFc2N5cXlETkNqc3B6Rk9ITnI5MlpsV2J6S2NkNWpXUGNnN2prWmQv?= =?utf-8?B?Q0FidXB4c3NMeWUyZ3BRcFdlbWdCeTlmRGJRek1lVTQrSHVEalR2cUU4OVVL?= =?utf-8?B?dlRFRTVKWWZmRElXMTJjN2U1UFY0N29FdkpOdUo5cE11NEhjbmZJbVdwVGNG?= =?utf-8?B?Q0lYL2FlYVBSbnBNZ1pxaWlDQ0pvWDlEcXFrNU1KVTA0WFdienRJN09UT050?= =?utf-8?B?SGpXMml2V0ZBRTFJTTNOTUJDTHpKSDg0bi9uVDZ5Q2doSlI1dy8vU3ZGdCtQ?= =?utf-8?B?eEJhTHpYNTZCN1QwWTdGK3doRXZVcDk2eXEvUE1ocXh0Nng5RkJQRktkR2cz?= =?utf-8?B?THhRb1RBaDJocTM1SDNzbFloWEdxSWpMYkxvTXhNcjJITUg0bHFPQzRlVEho?= =?utf-8?B?NHNGaXMzVVhCZmM5cHBMVFNLWGVzcjQ5SGlwU3NIVFkvSVFVL1NPVXV4MUZt?= =?utf-8?B?UHVOdlRQNTZBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGh3akYvZ1A3U09GalExN3VteGQ1dzV0MG1YRjFTYXVVVVE5L0ZQNUtZV00r?= =?utf-8?B?TWFYa3podW1iUFprZkVTV0VlZWwvNzNnTFdKcm9iTTBFSW5hb2o3MVE4QjE4?= =?utf-8?B?K1ViMDJMRWYxeHJpK0k2SDM5SjNOcXM5NWpOam5DMlI1WGRpcDFFYW1DNGt2?= =?utf-8?B?a2R2RGRiY2V0cWFCanprODVHeXVTdDlHaHhxZlpGWlJ1NHpjRFgvN2xMSm8x?= =?utf-8?B?VjMwcWl6ZUhneC9hQXloVDdGNkV1RkdncXBLdXB2NkNoRkZTc2dYRU5kbEVN?= =?utf-8?B?cVBBeXZPRUdBckRlQWtjOFVqYU42V2JmUms4d3RpYTVBOXFlYW9CdDFidEhT?= =?utf-8?B?Zy8zaTdmWlRPV0RMWmliYkNRcGdiSHI2bWhhbGQzRHV5eEpoT1U0eTlnSGRR?= =?utf-8?B?QnpCdFBJZ2p2aldvTHgrU2IzVHlFZTZBTEJxNW96UEhiV09hMlVrRDJIeExk?= =?utf-8?B?VjlDYXhaZUR1R011U2Y0cjB0NmlrQ0tYc3dSbVlmOWt0a1NJT3puWDhXQ1V6?= =?utf-8?B?aU43RlBhL0V5c3c0NVozc2hIeGVmd2kwZUkrVXhITzEwU090cnpFczBjVE95?= =?utf-8?B?cmxSQllFL1pHQzd1bXR6bnIrK3dRL1NYNUd1N3EyQjBobTNPV2FOT3daK0dX?= =?utf-8?B?Z1lyamZSaVFiWDJIb2dYVTVLaWxoY0R5WFprT0EyRFNQdjEvamJHZFZGaWRl?= =?utf-8?B?b2wxbDMvY092NVdLNklZbndNUU9qMWdjQUJkVzRBREN2eDd5cVh3dFpEbFpX?= =?utf-8?B?K3oxWW9qRDJacisxdUpDUysvMTN6L0ZHMURZczNJTUJoaDA0c0w5TzhvK2Np?= =?utf-8?B?enNDNnZVMVZmTXNHTVVaTWZ3RnlhRytsU2tqMDBpTU9CMlpibmdDVitNNE9x?= =?utf-8?B?R05iVnhwYm8zZkh4RlJidjJ3Mzd4YXpJaUtNeWZtME02ZjZvNStNOUYrbXkr?= =?utf-8?B?MXhpamc1bXFQMm1rL1FmZXRtRnF4eHNUVWJkOXA4NFRuY09Ra0YwS29GRTVU?= =?utf-8?B?YThKRzhIVGtEUEVxSDFSZy9WZFhwd0V2YmlPNkRYQUM4SytVOVo1Tm54UkhH?= =?utf-8?B?U0k1b0lSYVE5NDIraFJYN05hM2NKTFhycE9vcXNoaDFPUEtlSnFiQkpzSFVO?= =?utf-8?B?dEg5TXNCT0hBazEvM1RHTTFMQVBuR2JiUm1NcVBKYjcvNEJYYUQxdVVDeTFH?= =?utf-8?B?UEhBbE9VaGQ2d28ySURZbTBJUUlQWU5BSE1NQ3lZQmx6MU1ZYldybDNNZXZz?= =?utf-8?B?dkc1K3ltSGd3dVZCUFZLZ2tDbDJJMXlVVXZQaThhTDUvTFdUUFhQYkFSZk1q?= =?utf-8?B?NGUxYkc5TVJ5clhUZ2NnTDhkMmJDcVU2NVhpTnh6Q1VTOW9vN0taMEFWTGJP?= =?utf-8?B?VVg3NmdXUitVejhnWmp6cE5BNFZDc0RManZrbHJlb0xZeDh0dktjenZTeitZ?= =?utf-8?B?OGJYVWkwN2lSL1RmN3RYMTEyRTZNOVIybjlpdnNWTEJWNjRudWFkNmMrUy81?= =?utf-8?B?LzZQUDdzS3hidVBiSFFQTGpmKzI1SnA4NUZ1aUJZZDBYRXNFRU5RNS9TUzFs?= =?utf-8?B?a05KT2hMeUgxRXpqZU9VeUQ1Y2xUV2pHV0pzeGZ2RkFuQ0pzYVRTWHdWNjBk?= =?utf-8?B?MWRCWjJ4RVN6QUVRaTNiVlhXNDhhL3YwbDR0WlFlQlI1ZWs0Qmc2NzdJbkw1?= =?utf-8?B?MHd3NTFGVU5jVWxzTFNRSmhrZjVjS2NlKzZoYWlkSFJ5RFNMRjBkTUk3czZ2?= =?utf-8?B?cXYxSEQxMFdiR1dOWmcyRmNJaTdZRGdjVVpmL1g3NHkyVkcyK0xnVG1vMCtx?= =?utf-8?B?Mm0yV2VZdFFYK1pDaHlGRkwxbjk4K3JEUXBQckFtNEozb1FmcXB5aXFDd0E0?= =?utf-8?B?KzdveFRyNHowUXY2Q2tLSFN6aVJJRExKZHM3MW1POXd3aHd4eTF3VlBuV05M?= =?utf-8?B?SHVGbVhSVE03eGZINHluanFrNThKZy92MVlNb0V1M0RqcFQ5T0Z3RGNnUERB?= =?utf-8?B?M1M4MTluWGZMQ1VUSnJ6NG1nVzhWcVFSWVd0WE1BcGd0cVBzSzJzODFGeGZ5?= =?utf-8?B?d3JwUTFMRStZZndHRytmaE5sai94em1xbm1TT3c2Z244RllROXo2emM0RVNJ?= =?utf-8?Q?aOZyYm0SAMrxHhc4szbjXni45?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce136f8-07d4-4763-412e-08dd76e7f3c6 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:35.7661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dKkwCQXKDBKRf0U0FbL/TfZqtO3ulHwxcFTck+0qFGuWN0PTBVxhYFHh8qavKc6IYoBi7RSwH8rm1WvxGwobuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Add support for i.MX8QXP, which has a dedicated control and status register (CSR) space. Enable obtaining the second register space and initializing PHY and link settings accordingly. Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- change from v3 to v4 - remove reset_delay - sort register field defination - fix error messag in dev_err_probe - fix comments - use true for 1 - regmap_clear_bits(state->phy_gpr, CSI2SS_CTRL_CLK_RESET, CSI2SS_CTRL_CLK_= RESET_EN); in imx8qxp_gpr_disable() - use regmap_write to clean register at imx8qxp_gpr_enable() - remove reduntant CSI2SS_PLM_CTRL_POLARITY - rename register DATA_TYPE to DATA_TYPE_DISABLE_BF change from v2 to v3 - use dedicate csr reg to control phy and link settings. Change from v1 to v2 - change 8QM go 8QXP, 8QM will failback to 8QXP to keep consisense with phy drivers --- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 111 ++++++++++++++++++++++= ++++ 1 file changed, 111 insertions(+) diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/= platform/nxp/imx8mq-mipi-csi2.c index 59ec7107b4508..c6eb6dd0d9e5a 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -5,6 +5,7 @@ * Copyright (C) 2021 Purism SPC */ =20 +#include #include #include #include @@ -88,6 +89,7 @@ static const char * const imx8mq_mipi_csi_clk_id[CSI2_NUM= _CLKS] =3D { struct imx8mq_plat_data { int (*enable)(struct csi_state *state, u32 hs_settle); void (*disable)(struct csi_state *state); + bool use_reg_csr; }; =20 /* @@ -167,6 +169,95 @@ static const struct imx8mq_plat_data imx8mq_data =3D { .enable =3D imx8mq_gpr_enable, }; =20 +/* -----------------------------------------------------------------------= ------ + * i.MX8QXP + */ + +#define CSI2SS_PL_CLK_INTERVAL_US 100 +#define CSI2SS_PL_CLK_TIMEOUT_US 100000 + +#define CSI2SS_PLM_CTRL 0x0 +#define CSI2SS_PLM_CTRL_ENABLE_PL BIT(0) +#define CSI2SS_PLM_CTRL_VSYNC_OVERRIDE BIT(9) +#define CSI2SS_PLM_CTRL_HSYNC_OVERRIDE BIT(10) +#define CSI2SS_PLM_CTRL_VALID_OVERRIDE BIT(11) +#define CSI2SS_PLM_CTRL_POLARITY_HIGH BIT(12) +#define CSI2SS_PLM_CTRL_PL_CLK_RUN BIT(31) + +#define CSI2SS_PHY_CTRL 0x4 +#define CSI2SS_PHY_CTRL_RX_ENABLE BIT(0) +#define CSI2SS_PHY_CTRL_AUTO_PD_EN BIT(1) +#define CSI2SS_PHY_CTRL_DDRCLK_EN BIT(2) +#define CSI2SS_PHY_CTRL_CONT_CLK_MODE BIT(3) +#define CSI2SS_PHY_CTRL_RX_HS_SETTLE_MASK GENMASK(9, 4) +#define CSI2SS_PHY_CTRL_RTERM_SEL BIT(21) +#define CSI2SS_PHY_CTRL_PD BIT(22) + +#define CSI2SS_DATA_TYPE_DISABLE_BF 0x38 +#define CSI2SS_DATA_TYPE_DISABLE_BF_MASK GENMASK(23, 0) + +#define CSI2SS_CTRL_CLK_RESET 0x44 +#define CSI2SS_CTRL_CLK_RESET_EN BIT(0) + +static int imx8qxp_gpr_enable(struct csi_state *state, u32 hs_settle) +{ + int ret; + u32 val; + + /* Clear format */ + regmap_clear_bits(state->phy_gpr, + CSI2SS_DATA_TYPE_DISABLE_BF, CSI2SS_DATA_TYPE_DISABLE_BF_MASK); + + regmap_write(state->phy_gpr, CSI2SS_PLM_CTRL, 0x0); + regmap_write(state->phy_gpr, CSI2SS_PHY_CTRL, 0x0); + + regmap_write(state->phy_gpr, CSI2SS_PHY_CTRL, + FIELD_PREP(CSI2SS_PHY_CTRL_RX_HS_SETTLE_MASK, hs_settle) | + CSI2SS_PHY_CTRL_RX_ENABLE | CSI2SS_PHY_CTRL_DDRCLK_EN | + CSI2SS_PHY_CTRL_CONT_CLK_MODE | CSI2SS_PHY_CTRL_PD | + CSI2SS_PHY_CTRL_RTERM_SEL | CSI2SS_PHY_CTRL_AUTO_PD_EN); + + ret =3D regmap_read_poll_timeout(state->phy_gpr, CSI2SS_PLM_CTRL, + val, !(val & CSI2SS_PLM_CTRL_PL_CLK_RUN), + CSI2SS_PL_CLK_INTERVAL_US, + CSI2SS_PL_CLK_TIMEOUT_US); + + if (ret) { + dev_err(state->dev, "Timeout waiting for Pixel-Link clock"); + return ret; + } + + /* Enable Pixel link Master */ + regmap_set_bits(state->phy_gpr, CSI2SS_PLM_CTRL, + CSI2SS_PLM_CTRL_ENABLE_PL | CSI2SS_PLM_CTRL_VALID_OVERRIDE); + + /* PHY Enable */ + regmap_clear_bits(state->phy_gpr, CSI2SS_PHY_CTRL, + CSI2SS_PHY_CTRL_PD | CSI2SS_PLM_CTRL_POLARITY_HIGH); + + /* Release Reset */ + regmap_set_bits(state->phy_gpr, CSI2SS_CTRL_CLK_RESET, CSI2SS_CTRL_CLK_RE= SET_EN); + + return ret; +} + +static void imx8qxp_gpr_disable(struct csi_state *state) +{ + /* Disable Pixel Link */ + regmap_write(state->phy_gpr, CSI2SS_PLM_CTRL, 0x0); + + /* Disable PHY */ + regmap_write(state->phy_gpr, CSI2SS_PHY_CTRL, 0x0); + + regmap_clear_bits(state->phy_gpr, CSI2SS_CTRL_CLK_RESET, CSI2SS_CTRL_CLK_= RESET_EN); +}; + +static const struct imx8mq_plat_data imx8qxp_data =3D { + .enable =3D imx8qxp_gpr_enable, + .disable =3D imx8qxp_gpr_disable, + .use_reg_csr =3D true, +}; + static const struct csi2_pix_format imx8mq_mipi_csi_formats[] =3D { /* RAW (Bayer and greyscale) formats. */ { @@ -865,6 +956,25 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *= state) return PTR_ERR(state->rst); } =20 + if (state->pdata->use_reg_csr) { + const struct regmap_config regmap_config =3D { + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, + }; + void __iomem *base; + + base =3D devm_platform_ioremap_resource(to_platform_device(dev), 1); + if (IS_ERR(base)) + return dev_err_probe(dev, IS_ERR(base), "Missing CSR register\n"); + + state->phy_gpr =3D devm_regmap_init_mmio(dev, base, ®map_config); + if (IS_ERR(state->phy_gpr)) + return dev_err_probe(dev, PTR_ERR(state->phy_gpr), + "Failed to init CSI MMIO regmap\n"); + return 0; + } + ret =3D of_property_read_u32_array(np, "fsl,mipi-phy-gpr", out_val, ARRAY_SIZE(out_val)); if (ret) { @@ -984,6 +1094,7 @@ static void imx8mq_mipi_csi_remove(struct platform_dev= ice *pdev) =20 static const struct of_device_id imx8mq_mipi_csi_of_match[] =3D { { .compatible =3D "fsl,imx8mq-mipi-csi2", .data =3D &imx8mq_data }, + { .compatible =3D "fsl,imx8qxp-mipi-csi2", .data =3D &imx8qxp_data }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, imx8mq_mipi_csi_of_match); --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2078.outbound.protection.outlook.com [40.107.241.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4902A258CC1; Tue, 8 Apr 2025 21:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149283; cv=fail; b=LygYBa8N0nwEilBP7FRF1vZKC6g3X5ym/T4hgm51PinuxL/Zk6s7WzQvaWEsEPAgAT0pALy2u6CFGjn84s3jsX0RM0l4V5PPUDtAHkWBJKGnOTJYgy4pzRxWhpYF80I3F/PIfp7+YAC3A3on3rvOBjAXeEn6lWMvLxR+qYrC6ts= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149283; c=relaxed/simple; bh=R2kk0SBqVzOFIflcKq8BrxZ0OmoRNLZ62rPJnBtoVIg=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=phCy9WsdGX755tAycZi5r92WXoLqC70KUkDJ4Kk5yk0Dp9zYQv1KLN1XOjsOgCPhkAAoW9WTzBx2eoE+UT5rWtr9Zxw/jxRINLGX/dpFMY9zDMZuTTyeSPhkPtcLACHDkXaILe0q/Vn+WMpAPFI+e54qIG5k4Ge2J/0owkVtVrc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=kANTUpEF; arc=fail smtp.client-ip=40.107.241.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="kANTUpEF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cfdlx4Cisf8/R01MPi3RwTTtbYmL2C66JhFxmmeKurVq8C31II6/pxB1jVRAaGViXAQXLe+XGx7usGz8XH7HlJoNHl/HBMaI3iIjLPzAkMUr/DBasPjuFd/MImhkbRBcvzWxzL/EuToycOAPCUg5YM2WwsuGSPZD6HTKrXdjPc7DZFk5mEyR3DhgO/IVSq4ipKl1HNlhJyLIvppRetlHDlMNDaEFmjJfntvKXZbpx6bNndBXcUxATrHMJOenTeFUGx8EntPUgF5lH/b7+LK06Cb1fQofxuOpTsTcmh45USbkv0yX8TDqMskb7LlyYg8PI9jIHk+db5DZnRPAynyP1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PifaDEuiM0LSt6Kb/d7M3sEq910h1cnQiB+4EzQ/uwc=; b=ieiZDO+8FlA/ThbQyKPwvARmnLpMa/gZjoDTK88T7+5kuu5xVOL2aVO1BqElJYu7LtOYpRaf2gzE+mHUgAO4GvtNl97uU86CI6+7h74KAgPkUVHXdqXJEZxYjNE6MX78bnJUQT+JWOiVE3DyJ/TgG+zlWtlB2K9z5wOql0JQ03qksJIKah3rlb0wTeD9+2a41jYsoUv4SwbfFejvmegMBxrdaIUAL+RysH82FFAKLrX1oaOUho4J/nO9OIwgadkRQkw/OJe5gNIqSrps59qwft9x16U1WmipxaVQXvxyO+9JCDLIv0HRw21B6iKH9GBS4CowmvuQFK1Rb5Uom6t+0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PifaDEuiM0LSt6Kb/d7M3sEq910h1cnQiB+4EzQ/uwc=; b=kANTUpEF2Z77HJPz+jaUWSoI3Jk5qW9agUfBbMhPFoJe/t+XuUaIEiRQLg7cfyOcSAJGFa4MVraH2FEn9N0mSb8v9Ybfp71dt1YVzUhGkB9dOwjPps5PWvvK6jvrd95OUo65/OkTurVRQMm57krxUwmNfxtWC/xXLNCJb/e+gEl2RmJdK/2f6tRV4C4sTEZZUu2JvNm+HGqV5OSsTKOC3xQFBcSYNE3hf9B62f+X/YBEQ8vYPguMhhWmSvN6sb/lTpSZxzkXsTVIpbhwnOp43J3a7x53HLwJ7hGC3/04+3B/KnV1cEE4rVM0cydYfGBVNbC13ZlsfaVxAP9Ea9spvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:40 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:40 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:09 -0400 Subject: [PATCH v4 11/13] arm64: dts: imx8: add capture controller for i.MX8's img subsystem Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-11-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=18070; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=R2kk0SBqVzOFIflcKq8BrxZ0OmoRNLZ62rPJnBtoVIg=; b=5IMKxS3cDYGQBbXkwQVROPd8+BbG1KHk0h1JBSSvwPtQX+aQssBPSyrthYYPK8UZpW1eMNYOD aPrEM6A83VoCKlDzJBgz84wxyQA1/+LOtP5gKH7/pZQrFmzQNPsE3W1 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c68dc98-e112-41e0-f238-08dd76e7f653 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UStMbWJoUHBBdVU5TTh5UTZ5MmIvNS9VeUUxT0N0ZEFHZGsxdzlMdkJVcUFy?= =?utf-8?B?eEExZFZuczV4M3FSMjkrTXNhSFltdVBlTXN3ZVlPZjhSbnpNN0Q1M09PbUpS?= =?utf-8?B?UEZZK0FXZDFXTlJHemxQUmY4UTRvM3BEOGwzSWtiMng0U2Jpc3J4YjkzSUF4?= =?utf-8?B?cVpsTWo2aEhXVE9jUzVaU0xxM0JLYjVWR05EazhtMlNiVkRwMnFrbGF2V3dC?= =?utf-8?B?LzN6bFJvNWVyTDVUOHlRNUNJWGRVdjI4MC9aY2dvZW1saUJoQ2t2eVFsVmR6?= =?utf-8?B?ZGVBYllKTG5NMXE0cnRkSnYzVTlPRWRVNjM4eXJhb2pTVUFWZm1pZi9JUWZV?= =?utf-8?B?RitZV2Y1WGlxZTFITC9TTk1XOWNySm04MHp0UzhuWS9HSVZPT2k2VkVZNjgz?= =?utf-8?B?bmJoN1pYQXVEVmFzMnAwSnpmWnk5TkVSaXVoVVZtTm1SSWxLNy9WNmUxOFF4?= =?utf-8?B?TVhKZFFvWVdaNWNsREhRazBhTkFWZnU2TC92WTJPYTlmZnV6SnAvekswaDcx?= =?utf-8?B?emxhb2M3aWFkSThlQTFQaUg0TElDeU1qdzU2ejRicllqS0tLUmlOcFZMWnNG?= =?utf-8?B?d1dqRVlPTEdBYzIrSk5QUzBXMEFPbTlsdWZTZEZFeDZuSlpzOHRWeXFDckJJ?= =?utf-8?B?UnJMZHIvZzRicDhqWVQrTFh3dWEyZ09Xb2g3NklnbG1zRXQrOU1zaDhBUEl6?= =?utf-8?B?THNaU3plNUlZZWgyTzkxdURERGx6ekdodm1EOGF6b1JHQmZmZzhLWDlYeVcw?= =?utf-8?B?c2tiVnpHR1g1QXQ1VnMrTVM4MHhmQ2ZZaDZ2bnluOEFHMVNWbFArVW1xZEhl?= =?utf-8?B?TnUrZ1JyRVUrbW1iWC9JUFpjb3QvREU0M0tGMU56YkMzR1dZREtGVVRaaUpz?= =?utf-8?B?Uys5N1pXbW5QSFNhWjhpeittNFpKMEVVcHpQVlFLeXQxcFpYVStJUTZ6ZitK?= =?utf-8?B?UHhWTTZpMEJVcnBJdVBwWDJSZHRGU0VXa2RVRlFvT2puNDlsZE5lb2tBOEpW?= =?utf-8?B?OGl3cTdMbk1oSm1HNWEzbzR4cndKejQ3YXo5VjQxTmVhOTBRQUhzZXVFaW1D?= =?utf-8?B?eWcwdllBQkhtRmdTYjJUN1pLU24ya3FycXM0UTV3WWFRSUlhRnZhVnR6Y1JQ?= =?utf-8?B?UUFEODhLMkRieVV6R2orWTIrWHhMdmFNS0t0cFRjelhOenZJRUNsdTQ0M2ZZ?= =?utf-8?B?QkI2dk9qaXI5aWpyZEk3OHZ0R0g2SDJ0R1ZucytMM0pKaFdJdS9UM2t6QXY3?= =?utf-8?B?RytYUVo1MjEzNVBMdGdzRDlkMzVlbUIzaVB4STVNUE94cXd5M1RuVldReURT?= =?utf-8?B?NEp2dERsVGMreHZCZ203WlgwNDdZcHk0ald4WlNKVUtNakxVb2FBZEhYbGpS?= =?utf-8?B?YlU1cFhlWmt1aW0zVjhxY210MXN5S1dFNlB5NXAxdzMrdDJNVXBBQmcvMEMv?= =?utf-8?B?SkFKQWdjSnhkQUZoSGhraTlmNnFCRHV3Q2VjOWp4ZkV6LzdTbWJqVmo5MDBq?= =?utf-8?B?S3c2WStnSmpONVEwTXBvNzk1azVhRTl1UWJLOE9kcDNKampRQVBkazRndzR1?= =?utf-8?B?aElEZlprQVMyWDkzL3ZuRFFxL1lFZFBYMUdtdmoxU1AxUXhMNldvTXVGdExF?= =?utf-8?B?STU0aFlKZXVGUzQrRm03eUZnYWs4bHBqb1grNHUvaHVpNkpWajEzYmhsa25I?= =?utf-8?B?eDZyL01lbG1ZMFF4QW91Tk1ST0ZXL29yYzcxL0FibW8xUEdhWGdsSnFUb0dZ?= =?utf-8?B?QTNTSWNLQkwwd2RaOTZRY2JRTU82cHF0b3hsWEZhVnNyZW9DY1dZa0FSR2s3?= =?utf-8?B?bGVRNklSZFpkcnBxNk5mQVBkOUhTMjR3NitBTkNxSlpiSGNxOEFOQ2J4TTZ0?= =?utf-8?B?ZU1jYXFVVmxONjBsN0o3OWlGYy9XMVR6dHZubWhrRUcwZGhFVGFXYXZ4bGNB?= =?utf-8?B?UTBMaVUveGthZjBvOUZTLzVvSnhyTjZKeDlHQzRZZlpsT01vNldvenRDYTQ3?= =?utf-8?B?cXZaY2VJLzVRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjdzaGhGU0dQelpzallnQmdSdHg2YWZzdW5CWEhPNzBoK2lsbGxHaUhCUytp?= =?utf-8?B?VWdrOGJUandPaTFoRUlOaEx3dlNIb2d6ZW5LT1c1Z2lNODRCUUxtaWk5bmpj?= =?utf-8?B?KzhEK3ZBSC9sT2xJQy8zUXZLNE80NndINW8vMlpuOGVjckRSYTh2ZlY0Ymx3?= =?utf-8?B?RVhjSjNmeFB4VndWbFlna2VqeFAyUGFDK2YvSjg4TnlydFNKcnNYd0xuR0Q4?= =?utf-8?B?VjNKdlZyTTdEWklxQmxDZlJ5T0VTVkU3OUNzTmk1Mms3Vko2clJSWHBTYmV2?= =?utf-8?B?U1ZaNjE4QXl5SDN3RzZFVU1JZFNJWDhXeUhsT1pVbUdIZmhmeGpkek9acW9O?= =?utf-8?B?YkRsZ3NPZ1RWaXJFcFBTaExiY2t3Smw1MnlBdE8yTWJZQnAyK29xYjVIc2FW?= =?utf-8?B?Sk9qMWUvTUhZSCtGWm5WMjVDa3ZTRWl2OG5PV3MwRXh2NCtUNUpYOHVNMElX?= =?utf-8?B?dklvYUVaVGUvdmlKbkRDUlo2dzBIY2NIdVl0ZFQ1QTF2VFFDMmlkWkxZdmF4?= =?utf-8?B?OThTZktNMnFoT1RoTm96Mm1zTVU1Zy9TcFZub0UybzBGLzVtRThFbkVzV3pV?= =?utf-8?B?eEtPU3dvZHdDczF5dE9wS25oK0gvaFliQ3pYNjJrVURPQWdWYjl1UHV3L290?= =?utf-8?B?UnNvNFZuMHBjY2J2WUZubTNmRFBMNzJzWHZJK0V2NjNheGd6RFljeFhnOGcw?= =?utf-8?B?c09XL0pLMmc0SzdTTngvRTdvaWFzei93M3BiS2FvSVd3b2diQ1hoYXBIV0tI?= =?utf-8?B?eExpYW45Z3NJbnY4VE5BMkZJd1hxdUt1bTNZdkhHaTlUTHFXdFdCekxrenk5?= =?utf-8?B?Q3h2SXp5TW5POUFPdDllSW5wZFpSTzlGemRxa21uSllaTy9RZFpXOGdCUmJm?= =?utf-8?B?UGxTa3VlRWt6WmZtNlJ4bWRYNzJrdVI4NDVBa0RGZmpKOVcvK0FPYVVjalhZ?= =?utf-8?B?OGNLT1BCZVJJQmpSL2RtNXpkU2pxQUhKQlR1TlduMGVQUjNzeFJzdUgxdDNj?= =?utf-8?B?ZkVMQjl3ZVJ0WFp4TWNpU1hzdDdoRHArZExwbkFoUjAxZktOSGxYdGZBZ2h3?= =?utf-8?B?S00reVlUZkZnTXY1RHN2T1JzaFczNlNUWkU0a3V0bVUrS0pnbTF0eXM1N05V?= =?utf-8?B?ZVI0USsvOG0rY3UvdEQ1ZVhHcUYzR3BJYWc3ZisxSjlyU0dmODJxdDVpKzFC?= =?utf-8?B?VnhkYkxHT3dlckFJNktXcDF2M0htUUlIU3JIdmJQamJzQy90Mk52NGVpdEEw?= =?utf-8?B?ZFFGZHp4cmFqaWgyQkpGUVJCR3RMMHloRXpIaUtHaHVtUTdlQVpFQzlFSVU3?= =?utf-8?B?MEtILzErV1J0TFpMd2xZbkVGTjJQYWFlL3A0NVpBNHBRbWZKMW9FbHJ5dTlM?= =?utf-8?B?VG9ESzlHK3gvM0dFV29wWkxRMU94TzBGK2k4T1pLUFc4SDBla3JaQkdvSWpy?= =?utf-8?B?SFNkMFJWRVM1NGJOVnpndEVxZ1JCaG9jS2lTRzkxUTlWK0lHMXFsRG5ydGZG?= =?utf-8?B?Qkl5dVFFUERHRTZqNzYzUmdkT2pCWmU3MFZ3WVc3TzB2b3dicE0ybDF4a2ov?= =?utf-8?B?RHh5akpBSmkycXI2a2FyY3BkNmltRkpJWjMwQXhQQTVvOFR3bXAxMXNveUlx?= =?utf-8?B?Z2hOYVlINDBBM1pwVkRud1BiNHdUR04rNm5DRzNhZnB3TkRGQjU1RTEySjlG?= =?utf-8?B?WnFSeSs4ckJwZ1BFeSt3T3JNR1g4b3lRcTl0WVVMeU9FejV5a1lEKzFaZkNx?= =?utf-8?B?QTRJeHE1eDBibHRCUnkzcTVwaWhqZHZUYnVQbFZGbzQvR3JvM1ZFRTNPVVlz?= =?utf-8?B?WXFLejZ0R1B2VzBNbFZWaDIzeUpMV1o3ZXNwN1dxdFpZSzdJUlBYZ3dBSHZs?= =?utf-8?B?OFIyazRnMVVVa0V2bk1nTkt2OTZ1bklwZ0ViM0RteWhvTmNtblAzWjVkdXhC?= =?utf-8?B?TlZ5MDNUOWkyTTRLTkl0QlBreGJhQlE3T0dxNEYxQXN5azFvVE5qRHcxelkz?= =?utf-8?B?S0ZEL1RrWU9TNVN1TTBMV0d6d3BVdW5OVXRJMG9CR0lpSXdCZHFFdWNGSFUv?= =?utf-8?B?YUlqMVdWZkdqMmFLY3RRcXVaM3R1QVE3ekduUVlSekpBSmpsK3llWEhrOXhS?= =?utf-8?Q?CV8U0VqQcYDK8hRv6tdPPeKtA?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c68dc98-e112-41e0-f238-08dd76e7f653 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:39.9980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wRxmEBLdYbYa/PreNvxeF2oa7Q2JKkN+GkBmmV8oChlXB0rr8zirrDsU3y0OqutSyrlo5/zMX7orJ339xGKNKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Add CSI related nodes (i2c, irqsteer, csi, lpcg) for i.MX8 img subsystem. Signed-off-by: Frank Li --- Change from v3 to v4 - remove unused clock clock-img-axi - add ports information for isi and csi - Fix 8qxp clock, irq and power domain - Fix reg size Change from v2 to v3 - remove phy and put csr register space under mipi csi2 change from v1 to v2 - move scu reset under scu node - add 8qm comaptible string for mipi csi2 and mipi csi phys. --- arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi | 362 ++++++++++++++++++= ++++ arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi | 85 +++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 5 + arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi | 86 +++++ arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 5 + 5 files changed, 543 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/bo= ot/dts/freescale/imx8-ss-img.dtsi index d39242c1b9f79..2cf0f7208350a 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi @@ -10,12 +10,264 @@ img_ipg_clk: clock-img-ipg { clock-output-names =3D "img_ipg_clk"; }; =20 +img_pxl_clk: clock-img-pxl { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <600000000>; + clock-output-names =3D "img_pxl_clk"; +}; + img_subsys: bus@58000000 { compatible =3D "simple-bus"; #address-cells =3D <1>; #size-cells =3D <1>; ranges =3D <0x58000000 0x0 0x58000000 0x1000000>; =20 + isi: isi@58100000 { + reg =3D <0x58100000 0x80000>; + interrupts =3D , + , + , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>, + <&pdma6_lpcg IMX_LPCG_CLK_0>, + <&pdma7_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", + "per4", "per5", "per6", "per7"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, + <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, + <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, + <&pd IMX_SC_R_ISI_CH5>, + <&pd IMX_SC_R_ISI_CH6>, + <&pd IMX_SC_R_ISI_CH7>; + status =3D "disabled"; + }; + + irqsteer_csi0: irqsteer@58220000 { + compatible =3D "fsl,imx8qm-irqsteer", "fsl,imx-irqsteer"; + reg =3D <0x58220000 0x1000>; + #interrupt-cells =3D <1>; + interrupt-controller; + interrupts =3D ; + clocks =3D <&img_ipg_clk>; + clock-names =3D "ipg"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_CSI_0>; + fsl,channel =3D <0>; + fsl,num-irqs =3D <32>; + status =3D "disabled"; + }; + + gpio0_mipi_csi0: gpio@58222000 { + compatible =3D "fsl,imx8qm-gpio", "fsl,imx35-gpio"; + reg =3D <0x58222000 0x1000>; + #interrupt-cells =3D <2>; + interrupt-controller; + interrupts =3D <0>; + #gpio-cells =3D <2>; + gpio-controller; + interrupt-parent =3D <&irqsteer_csi0>; + power-domains =3D <&pd IMX_SC_R_CSI_0>; + }; + + csi0_core_lpcg: clock-controller@58223018 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58223018 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_0 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi0_lpcg_core_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + csi0_esc_lpcg: clock-controller@5822301c { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x5822301c 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_0 IMX_SC_PM_CLK_MISC>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi0_lpcg_esc_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + i2c_mipi_csi0: i2c@58226000 { + compatible =3D "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; + reg =3D <0x58226000 0x1000>; + interrupts =3D <8>; + clocks =3D <&clk IMX_SC_R_CSI_0_I2C_0 IMX_SC_PM_CLK_PER>, + <&img_ipg_clk>; + clock-names =3D "per", "ipg"; + assigned-clocks =3D <&clk IMX_SC_R_CSI_0_I2C_0 IMX_SC_PM_CLK_PER>; + assigned-clock-rates =3D <24000000>; + interrupt-parent =3D <&irqsteer_csi0>; + power-domains =3D <&pd IMX_SC_R_CSI_0_I2C_0>; + status =3D "disabled"; + }; + + mipi_csi_0: csi@58227000 { + compatible =3D "fsl,imx8qxp-mipi-csi2"; + reg =3D <0x58227000 0x1000>, + <0x58221000 0x1000>; + clocks =3D <&csi0_core_lpcg IMX_LPCG_CLK_4>, + <&csi0_esc_lpcg IMX_LPCG_CLK_4>, + <&csi0_pxl_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "core", "esc", "ui"; + assigned-clocks =3D <&csi0_core_lpcg IMX_LPCG_CLK_4>, + <&csi0_esc_lpcg IMX_LPCG_CLK_4>; + assigned-clock-rates =3D <360000000>, <72000000>; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + resets =3D <&scu_reset IMX_SC_R_CSI_0>; + status =3D "disabled"; + }; + + irqsteer_csi1: irqsteer@58240000 { + compatible =3D "fsl,imx8qm-irqsteer", "fsl,imx-irqsteer"; + reg =3D <0x58240000 0x1000>; + #interrupt-cells =3D <1>; + interrupt-controller; + interrupts =3D ; + clocks =3D <&img_ipg_clk>; + clock-names =3D "ipg"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_CSI_1>; + fsl,channel =3D <0>; + fsl,num-irqs =3D <32>; + status =3D "disabled"; + }; + + gpio0_mipi_csi1: gpio@58242000 { + compatible =3D "fsl,imx8qm-gpio", "fsl,imx35-gpio"; + reg =3D <0x58242000 0x1000>; + #interrupt-cells =3D <2>; + interrupt-controller; + interrupts =3D <0>; + #gpio-cells =3D <2>; + gpio-controller; + interrupt-parent =3D <&irqsteer_csi1>; + power-domains =3D <&pd IMX_SC_R_CSI_1>; + }; + + csi1_core_lpcg: clock-controller@58243018 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58243018 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_1 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi1_lpcg_core_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + csi1_esc_lpcg: clock-controller@5824301c { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x5824301c 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_1 IMX_SC_PM_CLK_MISC>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi1_lpcg_esc_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + i2c_mipi_csi1: i2c@58246000 { + compatible =3D "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; + reg =3D <0x58246000 0x1000>; + interrupts =3D <8>; + clocks =3D <&clk IMX_SC_R_CSI_1_I2C_0 IMX_SC_PM_CLK_PER>, + <&img_ipg_clk>; + clock-names =3D "per", "ipg"; + assigned-clocks =3D <&clk IMX_SC_R_CSI_1_I2C_0 IMX_SC_PM_CLK_PER>; + assigned-clock-rates =3D <24000000>; + interrupt-parent =3D <&irqsteer_csi1>; + power-domains =3D <&pd IMX_SC_R_CSI_1_I2C_0>; + status =3D "disabled"; + }; + + mipi_csi_1: csi@58247000 { + compatible =3D "fsl,imx8qxp-mipi-csi2"; + reg =3D <0x58247000 0x1000>, + <0x58241000 0x1000>; + clocks =3D <&csi1_core_lpcg IMX_LPCG_CLK_4>, + <&csi1_esc_lpcg IMX_LPCG_CLK_4>, + <&csi1_pxl_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "core", "esc", "ui"; + assigned-clocks =3D <&csi1_core_lpcg IMX_LPCG_CLK_4>, + <&csi1_esc_lpcg IMX_LPCG_CLK_4>; + assigned-clock-rates =3D <360000000>, <72000000>; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + resets =3D <&scu_reset IMX_SC_R_CSI_1>; + status =3D "disabled"; + }; + + irqsteer_parallel: irqsteer@58260000 { + compatible =3D "fsl,imx8qm-irqsteer", "fsl,imx-irqsteer"; + reg =3D <0x58260000 0x1000>; + #interrupt-cells =3D <1>; + interrupt-controller; + interrupts =3D ; + clocks =3D <&clk_dummy>; + clock-names =3D "ipg"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_PI_0>; + fsl,channel =3D <0>; + fsl,num-irqs =3D <32>; + status =3D "disabled"; + }; + + pi0_ipg_lpcg: clock-controller@58263004 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58263004 0x4>; + clocks =3D <&clk IMX_SC_R_PI_0 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pi0_lpcg_ipg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + pi0_pxl_lpcg: clock-controller@58263018 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58263018 0x4>; + clocks =3D <&clk IMX_SC_R_PI_0 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pi0_lpcg_pxl_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + pi0_misc_lpcg: clock-controller@5826301c { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x5826301c 0x4>; + clocks =3D <&clk IMX_SC_R_PI_0 IMX_SC_PM_CLK_MISC0>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pi0_lpcg_misc_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + i2c0_parallel: i2c@58266000 { + compatible =3D "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; + reg =3D <0x58266000 0x1000>; + interrupts =3D <8>; + clocks =3D <&clk IMX_SC_R_PI_0_I2C_0 IMX_SC_PM_CLK_PER>, + <&img_ipg_clk>; + clock-names =3D "per", "ipg"; + assigned-clocks =3D <&clk IMX_SC_R_PI_0_I2C_0 IMX_SC_PM_CLK_PER>; + assigned-clock-rates =3D <24000000>; + interrupt-parent =3D <&irqsteer_parallel>; + power-domains =3D <&pd IMX_SC_R_PI_0_I2C_0>; + status =3D "disabled"; + }; + jpegdec: jpegdec@58400000 { reg =3D <0x58400000 0x00050000>; interrupts =3D ; @@ -40,6 +292,116 @@ jpegenc: jpegenc@58450000 { <&pd IMX_SC_R_MJPEG_ENC_S0>; }; =20 + pdma0_lpcg: clock-controller@58500000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58500000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma0_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + pdma1_lpcg: clock-controller@58510000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58510000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma1_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH1>; + }; + + pdma2_lpcg: clock-controller@58520000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58520000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma2_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH2>; + }; + + pdma3_lpcg: clock-controller@58530000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58530000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma3_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH3>; + }; + + pdma4_lpcg: clock-controller@58540000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58540000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma4_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH4>; + }; + + pdma5_lpcg: clock-controller@58550000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58550000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma5_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH5>; + }; + + pdma6_lpcg: clock-controller@58560000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58560000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma6_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH6>; + }; + + pdma7_lpcg: clock-controller@58570000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58570000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma7_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH7>; + }; + + csi0_pxl_lpcg: clock-controller@58580000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58580000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi0_lpcg_pxl_clk"; + power-domains =3D <&pd IMX_SC_R_CSI_0>; + }; + + csi1_pxl_lpcg: clock-controller@58590000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58590000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi1_lpcg_pxl_clk"; + power-domains =3D <&pd IMX_SC_R_CSI_1>; + }; + + hdmi_rx_pxl_link_lpcg: clock-controller@585a0000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x585a0000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "hdmi_rx_lpcg_pxl_link_clk"; + power-domains =3D <&pd IMX_SC_R_HDMI_RX>; + }; + img_jpeg_dec_lpcg: clock-controller@585d0000 { compatible =3D "fsl,imx8qxp-lpcg"; reg =3D <0x585d0000 0x10000>; diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi b/arch/arm64/= boot/dts/freescale/imx8qm-ss-img.dtsi index 2bbdacb1313f9..ce2ab67c6cba3 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi @@ -3,6 +3,31 @@ * Copyright 2021 NXP */ =20 +&isi { + compatible =3D "fsl,imx8qm-isi"; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + + isi_in_2: endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + + port@3 { + reg =3D <3>; + + isi_in_3: endpoint { + remote-endpoint =3D <&mipi_csi1_out>; + }; + }; + }; +}; + &jpegdec { compatible =3D "nxp,imx8qm-jpgdec", "nxp,imx8qxp-jpgdec"; }; @@ -10,3 +35,63 @@ &jpegdec { &jpegenc { compatible =3D "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; }; + +&mipi_csi_0 { + compatible =3D "fsl,imx8qm-mipi-csi2", "fsl,imx8qxp-mipi-csi2"; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@0 { + reg =3D <0>; + + mipi_csi0_in: endpoint { + }; + }; + + port@1 { + reg =3D <1>; + + mipi_csi0_out: endpoint { + remote-endpoint =3D <&isi_in_2>; + }; + }; + }; +}; + +&mipi_csi_1 { + compatible =3D "fsl,imx8qm-mipi-csi2", "fsl,imx8qxp-mipi-csi2"; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@0 { + reg =3D <0>; + + mipi_csi1_in: endpoint { + }; + }; + + port@1 { + reg =3D <1>; + + mipi_csi1_out: endpoint { + remote-endpoint =3D <&isi_in_3>; + }; + }; + }; +}; + +&pi0_ipg_lpcg { + status =3D "disabled"; +}; + +&pi0_misc_lpcg { + status =3D "disabled"; +}; + +&pi0_pxl_lpcg { + status =3D "disabled"; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dt= s/freescale/imx8qm.dtsi index 6fa31bc9ece8f..c6a17a0d739c5 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi @@ -333,6 +333,11 @@ iomuxc: pinctrl { compatible =3D "fsl,imx8qm-iomuxc"; }; =20 + scu_reset: reset-controller { + compatible =3D "fsl,imx-scu-reset"; + #reset-cells =3D <1>; + }; + rtc: rtc { compatible =3D "fsl,imx8qxp-sc-rtc"; }; diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi b/arch/arm64= /boot/dts/freescale/imx8qxp-ss-img.dtsi index 3a087317591d8..9d9d933148f1b 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi @@ -4,6 +4,88 @@ * Dong Aisheng */ =20 +&csi1_pxl_lpcg { + status =3D "disabled"; +}; + +&csi1_core_lpcg { + status =3D "disabled"; +}; + +&csi1_esc_lpcg { + status =3D "disabled"; +}; + +&gpio0_mipi_csi1 { + status =3D "disabled"; +}; + +&i2c_mipi_csi1 { + status =3D "disabled"; +}; + +&irqsteer_csi1 { + status =3D "disabled"; +}; + +&isi { + compatible =3D "fsl,imx8qxp-isi"; + reg =3D <0x58100000 0x60000>; + interrupts =3D , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", "per4", "per5"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, + <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, + <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, + <&pd IMX_SC_R_ISI_CH5>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + + isi_in_2: endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + }; +}; + +&mipi_csi_0 { + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@0 { + reg =3D <0>; + + mipi_csi0_in: endpoint { + }; + }; + + port@1 { + reg =3D <1>; + mipi_csi0_out: endpoint { + remote-endpoint =3D <&isi_in_2>; + }; + }; + }; +}; + &jpegdec { compatible =3D "nxp,imx8qxp-jpgdec"; }; @@ -11,3 +93,7 @@ &jpegdec { &jpegenc { compatible =3D "nxp,imx8qxp-jpgenc"; }; + +&mipi_csi_1 { + status =3D "disabled"; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/d= ts/freescale/imx8qxp.dtsi index 05138326f0a57..c078d92f76c0e 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi @@ -241,6 +241,11 @@ scu_key: keys { status =3D "disabled"; }; =20 + scu_reset: reset-controller { + compatible =3D "fsl,imx-scu-reset"; + #reset-cells =3D <1>; + }; + rtc: rtc { compatible =3D "fsl,imx8qxp-sc-rtc"; }; --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9230B258CF8; Tue, 8 Apr 2025 21:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149288; cv=fail; b=US1fQE7tRvH0c0ezBrqTTCLFH8UdObSYfr9W7zh8fPQMA33P/LpCP8lnAyZ22vuhlcJBpLqfJ4vjqKMJWTyhvcVglCiOHCtNTUc3FmNzt2z/htE5/jAGJj2fiZZUQE+ok1MrYrqLxnzdiBDfc+J/1bYkiOh1cZK9bNP2ICBiSWg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149288; c=relaxed/simple; bh=J/vXWJ71e9iywXWc7F7QPLUcxVg/o2Yp16ibMSDuxm8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=VCEjoK2tuHmQsgcCCdcVp/XGbZ4/Ms78bo021kmlewB3V2gg9NwXwr0HcH89ONezDw9MvmQZGRFB+IaH53AKxtNxPJ9EFCTXuhU9hAZSC1v8q0HdRqbfXzpliFN0OP9N1b53Pljv/x727sUeA82O5qWxJflN0eRawZC0bWiPpUU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=JAfj2NsM; arc=fail smtp.client-ip=40.107.20.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="JAfj2NsM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Yi0lt9C9Tx8vEYyBi6C8chzId60f58EeCa+QPlJGkNItBwCAsHO8DI7lWyBPGXaWckhYYRIrQd7tBijHv2mdHZ0duad5pEDz2TBMhgUdUxZJJ8kKsjaRcMSL+ldclVcWPVcaWXmtPzAZMgmBE0z6D090YbyQQszqmR8IJXquMhd1nAxhNFeH4HA2MbRtMyK65dJTxQnmn4D5Of7L9I6fo+gKfeHFhxzVQHjRI0XwKMXZQmCQ/6a+D/hJDAVa7SixVOX3qEhjr92iS74rbIY/NyAO1ZzozGZZ6PtJ4BcYAdDVom++9p08NT/nGFUSxARVu6+KJIgk9/uacHeRkc2XoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YqnnDlFpQb10c4i+t/JGSPA0f/+UZq4ELBTIshbiaNc=; b=pWCqp4dNm7f97u1iDFQQgUdMCeN3CsKGKH35cQWJs39IEyAl53LXC90dpE/OUQ5bqSvc4xK5FcvqyTbH/+KbPy5OWqaDrw//be588G81ICzhUicQZfc4HVig85IeFtnju4r+8V7+Bwg1DZmx0hnbk18DB380c55CFS4dS+5AHI4gWUEw34qGRFTGux8C0LwiRW4rpcKRzd8JXYqXjCvYoj1+df7IjHUUB8v6lBPLS20BLh0W7UInlTKi9XVhE6Rkr8otJ4kanypvQXavd5YPtiPA/N0KilT7SB2NPrUN9BtRWlXqTBpW2RQOMKoql4mQk4whNxrowviGWJqPt0FS/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YqnnDlFpQb10c4i+t/JGSPA0f/+UZq4ELBTIshbiaNc=; b=JAfj2NsMHDKPM6Pn0iOMu0vtfgfww2hNHena5YCuHr2ElMK6DUVOcGxAE0ZY8SpVXtFWKmvIcpq2txQsZpqlAN9sG0+LATSML6V63K07AknCsGkLDDac4PCKgQxbU7csGBjW8e2QOMBFUsdZqocUNcYyVFV8Lq6wIypMbDFUBofHx9pVjVNRhNiOQaJUTXa/LaHM6V1ITRxzxJ8y5DmTfrJHtr4wmNogqwA9yR7+PvxHcwwmy26hs16T+DVz96A4lcSwuLzYt6EBuoWsn9sx5LzPqRpIkvI8kgHDZBq+cJpXUSe2eWw5Zt61j3VEheYgzWOwFKBmDOJEEom3NAuLaQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:44 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:44 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:10 -0400 Subject: [PATCH v4 12/13] arm64: dts: imx8q: add linux,cma node for imx8qm-mek and imx8qxp-mek Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-12-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=1608; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=J/vXWJ71e9iywXWc7F7QPLUcxVg/o2Yp16ibMSDuxm8=; b=WLa/tPmqQfvzNTNSDKgkngzg6Qk2a5+cdSljNeIL+tq6l/CVsBZ8SqCPeiXhKNnq340GA2qln utuvuUldmeXBCFq+cSY28yQ1/CUZMn8Nwk5Rdg6XHxPh9nQh0YmyrHb X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: b9cbcd00-3daf-4ca3-8030-08dd76e7f8cd X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NmpHYnNGQTk2ZElseHdIOTZBZzU0VVhCbWRqQTJGaFBmSlZ1cXlNN282ZVpy?= =?utf-8?B?ekFqTGJaNjNSLzF0S3g3T25rdlM5c1J5aXd6VnRwYU02eEszcFdqR0VXRHJI?= =?utf-8?B?V042TUFkN044NnA5SzBpdXFrekV5SHBqeW5sTjJUcTUvTkxXcjFaM0FQTndh?= =?utf-8?B?VTNGeWtQb0lWWk0yMVNFajk2S3VzSVdFcmZoUGVxeVJ0SEQxUnFyVHdsV3U3?= =?utf-8?B?TkM3dGhSYzFNeFV1cFh3emJVZWRseWJUQVVpR2s3aEJzbXZkU1hJdVcwSlR2?= =?utf-8?B?aHZ4clJnWnZlM0x1eVFoSXNGNmtaNG40eTcwZkE5ZEhyU2pQcURwQXBMVUV0?= =?utf-8?B?dnNLM1ZmWGtsM1lPdVVtMnNkY3NpSW9iaTE3NHpIejdPa0psWC95TUsxYlZC?= =?utf-8?B?OEgwbXF1c1ZSMFJYSmErK2h5RTZ2OVZPa0t5QWE2ZHVTc0FzMENDT00zZUhZ?= =?utf-8?B?M2FlV3d2L1lCZGtldXB4dEVUTVMyVTdITlZucDJxYjIrN3hvNW9UWnZaS3Q2?= =?utf-8?B?VnF4Z0VidGNvSU9wbndlUVdHMGlkdVZHUFR6d1ZRREFqdkViNzF1ZWMvcFM2?= =?utf-8?B?UmV0eHA2bVFlejczN3NTbFppbU1ac2tCMkdnTTVSS2hsMlJCZWxXSUxqVWI3?= =?utf-8?B?ZlhtTk8yWDZadVR3VXp0eHdSOGM1K1F1TnhDaGovempFa3hJbFcwUURYLzg4?= =?utf-8?B?b1dtNFFGeHcxdTdXUVhTRUJlTnAxQWtWNXdBOE9lUmFPNytwZE1acFFWQTR2?= =?utf-8?B?cUFHeWQvbjh1QzQxUmhWMlluWnpTVTdwL2tIMVNvMGFmWlVBL1A4NVVid1kz?= =?utf-8?B?eStna0NnU3g3ZEdXMlY4Qk96MkJxNGZXL3FJOWZEMVhZNnIxdk9BS2xReUtV?= =?utf-8?B?ZWxJbS9xUzE3S3lLeVVKQ2RVZ05KN0dJRUVpdWM4SDBzcmFGbW9qUTZRR210?= =?utf-8?B?Mm12YjlHUnNxQ0t0ajMycEViVytmMXhGWlczVndkVW0xdkhIRmhHS1dKMXRW?= =?utf-8?B?bU1FWUlMbi9lUzE2SXlCcStRc0RRQmIyNysvc2FNVzROZFU2UGd6Y2VZZlRa?= =?utf-8?B?YXdqS0U2WHFWdzE0UVl5My9KWW02aU8zOFJBb0MvaEpSYWZ1Z1BDZ012ZFhv?= =?utf-8?B?aGFlMnRQUTdDZDhaUFJGTTJCN3dHU0E2YkZMdS9nM3Q0a1hFbTBBZUd0eWl5?= =?utf-8?B?SHBwL3lpSVp6ZlROOFllb1R4K1lWTzNJZjE0WDduaVZjU1lMZDM3QUdQR2VT?= =?utf-8?B?djZDM0xoVmVzVEVPQ25TWGZhTUoxUnc4QUZ6N1BWNUdsWWl3cTBrTEE0c3Rt?= =?utf-8?B?YzBtMllJNmZraEl1eTVjMFdEUlk4Rm5Kc0owVTRtNTc5Z1VYN3Z5TjJ6Z2lq?= =?utf-8?B?ZUxqM1k1cWV2Q2RNQm5hZWNXaldFVnVRVCtNTGJOeCtjblJaVWxFK3N1Q0pT?= =?utf-8?B?MmM5NWl6ZWFUV0ZsRUI5dk1IcFIxTThMVFVGZ3pZRnRQUHc5RlN2MXEvN2Jr?= =?utf-8?B?S1Y5dGxDdzFJMnEyZXJjUSt2anpuK2lmczVFbDNvaCtvUnJxcWRCL0RBcVF1?= =?utf-8?B?N3N6UFhYc01OaUZNT2NuaUY1L0p2OHF2a0hSUi9zSlljNFhiVU40TzlKZ2xh?= =?utf-8?B?V215VFRGVUU3R1ROSkd2RTZWck5WOUtPL3NJQ1BWQVIxL2E3M1FpT0F3cWJQ?= =?utf-8?B?U29KRFNiSGtCbTBKZTNlNlJkRzhmVVpValZqRnFtNkxRS0ZmYVJQMGF4b0hn?= =?utf-8?B?WDlkRTMxZWd2Vithc2NFWnkxOHk4OEFsRGMxaWVIVnZDOHV4WERrMFV3TUl5?= =?utf-8?B?Z2M2b3lBdDFHVWpTVk5rT2Y5eU9FeGt5TnhYZUQ2TG1wZlM5ek9uT2k0cnkr?= =?utf-8?B?K3R5cXNkK2c4dTZ1Mk5qUk1JMlN1UDV2bFFEK28wY2pROXI4S2NOSXI1bEp5?= =?utf-8?Q?BJ2CZ83RI4+oRqHCj9KHkbIGjl6+lMaB?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elBoRVJDQk1nOVFHNTRlWnY0cjkwdXJKM2k3d2xCU09uYTN5Q1Y5eHRXTlBs?= =?utf-8?B?R0JjUURqbEwzNVlBazhOZlBWOC9HMTdLZ25lZ2pwUC9kbEkzQnZoMzU5RTkw?= =?utf-8?B?RVJQMHI4c0ZnUmdjRzJ3Y3oyaFZCLzdQd2FtS3orWmFLU2IzZmw0VC9xWTlQ?= =?utf-8?B?Vkk2Yjl4WWI2U1dTa0syYkRuS1JYayttaWVjQmRxOFRyTWFzZjI2VFo2UTMw?= =?utf-8?B?cWFLSUpmenJ1aWpRVDd6TkFUc2FzUWtNeUludGlMMjdDalUvaXhkZGJOd2I4?= =?utf-8?B?cW91V2hHZ2NsRW5EajZoYUdHMkJ5ZW03TmRFUHhCTS9DTUxwQlFWb1RTRGkw?= =?utf-8?B?QlFKdHU1L3I5NVBldVRQdDFrNTQ1TXlmbVF0alF1RGRyVDh4OHlSMTlzeWFs?= =?utf-8?B?Y04xUEYvQW5CSUhZU01YcW5YWmZidnRpeU02RE9PdDZwRkE0R2NGRi9qWmZt?= =?utf-8?B?YjJLSmJrbHYzWFVqdzl3QzdEWWlhdG5QZ0lObnRCSDdxRFZrQWdnczVYVWNu?= =?utf-8?B?WGREU3lEbDlaNGptZ1ZaTnJwKzlFTGo5azExN3NQU0xlMCtPWTZQWllEYytP?= =?utf-8?B?elZzQlhydjloOFJnMVU3VGdZK0kwaXV1SmVPdS9PZFBtVUNlQnFYQ1VnZnJG?= =?utf-8?B?QXVlNHhuTWV4NlJ0aEIrbHFQRzBxelNGckhRNFNqUWlzakhKVkpjcGZoNVE3?= =?utf-8?B?L1h2NmFGOGhhd3JlMkZ6c2dyNXpKMUM5b3ZYN0xCNFVMSEM3bkxuTG5ud3l1?= =?utf-8?B?MWxHeDlpV0tmUHhhV3l1SFN3UzBuRE42QW5nRkppbUxJTmlsSmdhejNUUWZZ?= =?utf-8?B?VFhjUU5Pd296K0k5WVZIc2FreGYvbVhXZ0JnNEVLOE5oQzVYcCtJKzV6MkFa?= =?utf-8?B?M1oyL0QxYnpCRFRFNU1WTmk3TTh5TFIwU2FqNEQ5QlJWcDNoVVVRWmh5emdT?= =?utf-8?B?UHlIaTNIdlJOK05CQjBtU0JiTkFlcVZjck14WDYwdEszbkFQbE40dHVHZjVR?= =?utf-8?B?cU01T2V2YlBCZ2JtMTJmelVtRFpTU0Y1dWN3Y29zUGJhUXFhWmlTV1I4eDU0?= =?utf-8?B?OHhMZGhTdVZHNG5waG8xQy8vYm0zSXpsVFBHMWZESkRuOEVLenlSYTNPclFM?= =?utf-8?B?VGsyYTA3cTZqZXNiWldQNWhnWFQyUTFEc0N6QmVOQWYzRnFpQlY5SDloWm02?= =?utf-8?B?MFdvM2hNeGNQVWN6RlZNeGJZOWl0eCtCR0RvTlp1Q2NucDBPUTROeGJaazM1?= =?utf-8?B?STdlN1NEN0FpVEtiRlA3WlZjQVhFTjg0YXRwWUljTWZRaUV4WUpDSlNwamZT?= =?utf-8?B?eGpiUi96K2o0Sk5KYjBzamVYNDFHMmhVMjEwanJYbVdCb2FOKy94SnNmMUpj?= =?utf-8?B?dXBET01Ha1ZvOGlYM0I2eUxXeVpEeEZvUGJqak0yK09rSHhZWHFjZVVpWDJK?= =?utf-8?B?UmVEME5kRnZLOUVyNE5kUnlIVW5VWmZ5WU9oM3NYRVlMSXdsbmFXWURzQlZi?= =?utf-8?B?V25XT3BDeFJRQ1VscVZVS1JYaUkycFI1QWJSbXJXWmN1RWoyVjFiSmw0OE1p?= =?utf-8?B?eGtsV2V5MlcwUkEzczdkWS9wL2xwK0o1TlA2eVNrTXBwWHl3N0pTSWx1WGF1?= =?utf-8?B?dUkyc3lRWlJPS2VNOHFrY1BUUzZpNlJuUXJOUnlFdTFKdWl5YUlDcUE0dEM3?= =?utf-8?B?dmUzb0JnZjdhNHBCYjNzdzdTQm4wRnFtVkI2TTdRSmtzemxHMGF4L09MdTZR?= =?utf-8?B?VHF1YnAwWHRpVWxVQ2VLbWlrcWZtb0RrYm5xZXBhY3A4RnladE9VYmZTNFZh?= =?utf-8?B?aWhwQWJOdVgrSzJGS3JnQVpydmtUTTFBaVdWMVNMMjVnZC9zRVlEekk2V2tM?= =?utf-8?B?b0N3UDBVLzI1MHg4UjA0cndJV3FjMlhLMWJrQlk1WTlJK0ZRcDhPQmo2YkVW?= =?utf-8?B?SUR2d0hDRzRhOHBvazk5MFgyRVBNSkcyKy9WbHkyYnBlcGxpdTJyUG1jTUNL?= =?utf-8?B?aC9aSTVwL2xnNXgweFk4a24zN0NtVnd5UDNhY0x2QkU4eDVJMXNDL0taZE5R?= =?utf-8?B?eGp1ZHJtMUtpcURISnR4YzEwQ2s2Q3dyUVUvdVNQcjFUK3M1TkxsQUZTNTBz?= =?utf-8?Q?EGdg=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9cbcd00-3daf-4ca3-8030-08dd76e7f8cd X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:44.1649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RVsZsWndLUF7Jmx4ocZB/lSlcQSc6RLLQ0tJu9whpIK0fGMiO5pXZbxVbPdu2vOgxaEOS+c9QsGwfEr8oIs0fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Add linux,cma node because some devices, such as camera, need big continue physical memory. Signed-off-by: Frank Li --- change from v1 to v3 - none --- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 9 +++++++++ arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 8 ++++++++ 2 files changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot= /dts/freescale/imx8qm-mek.dts index 353f825a8ac5d..68442c8575f3f 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts @@ -113,6 +113,15 @@ dsp_vdev0buffer: memory@94300000 { reg =3D <0 0x94300000 0 0x100000>; no-map; }; + + /* global autoconfigured region for contiguous allocations */ + linux,cma { + compatible =3D "shared-dma-pool"; + alloc-ranges =3D <0 0xc0000000 0 0x3c000000>; + size =3D <0 0x3c000000>; + linux,cma-default; + reusable; + }; }; =20 lvds_backlight0: backlight-lvds0 { diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boo= t/dts/freescale/imx8qxp-mek.dts index a669a5d500d32..a378f462a283b 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts @@ -56,6 +56,14 @@ dsp_vdev0buffer: memory@94300000 { reg =3D <0 0x94300000 0 0x100000>; no-map; }; + + linux,cma { + compatible =3D "shared-dma-pool"; + alloc-ranges =3D <0 0xc0000000 0 0x3c000000>; + size =3D <0 0x3c000000>; + linux,cma-default; + reusable; + }; }; =20 reg_usdhc2_vmmc: usdhc2-vmmc { --=20 2.34.1 From nobody Fri Dec 19 17:37:50 2025 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2083.outbound.protection.outlook.com [40.107.247.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9CE3259C87; Tue, 8 Apr 2025 21:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149293; cv=fail; b=snjqbIptb2Cqu0cF0jpIjASeOXjPiXZC1bU4NrLUy6VbYZlHQPmyRLF9y0XFMlt4APQ8jMmJ70KkjAyl54dT/6NiMoAR1UKcQneV5EjVod6MIamNwyMHGtrr7Rbmx4BLskjH3Shdbihj6UnQIQRdpfW+/SQPAQNW9C8P+ocl510= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149293; c=relaxed/simple; bh=+nDGwia3/owe7pv+QZPq07IJEos+Cd/hT3WNI74TaMk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=AsCHdNXYG2GL9Au+mHrccPX+vDlnBDD2QhfpstMoQTrT/rWPzNyhch4dCP57E6kG9mCpRSZ38muw7cCmcS42qUQu1Aly+W3Mb9h1nKsRZFa5u4bVrOio6eBHBUCbMLpg1lM+pmKvS9GpaBo3wiLxv3sw6OSwZ9aY7etczkPl6jY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=K1Y61WHS; arc=fail smtp.client-ip=40.107.247.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="K1Y61WHS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C1WJDZT/qLNW57qWG2NN/XZ5i8OkS5HTaPeXIHCKWglp5M8e7I0lz1n2bInofiMQbnv38oyPxXFcZHPn46N0GPf7FV/Q6/ev3hvEa+T+Qo9BjzmogVfUtjpCeFmYnk+3x0GFRqrA/myutVGZoxCwxo9FAN02u60VOGxI5pEGhsxyVn7YYA86jtefL7AmjkKx1clsfIOQFsy5pr8dTCXPWMh4uKygMgEwqcA3YkxQutvkEsUoWnrISKiieG39GOtvZXJvDTtoaCHrGfBBdeeNmyKhGNdeDFsULXScfxuTpwkXJOLI4ksU0lMQxKF29rWrNO0d6SbeZD6HT7FRqFTF7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KttHrRtzn1U19NH6GsJwXSoXWlO1SKYYwMmHuWE8chQ=; b=HMxAbzINl88he2iP2CSGDkFf/jHnB4llwnkLG1uOu5/T6QHrxEK1rahjXRUUiRuksf0OG8JeLzzIQ+XZelZuodK8gIqgpIbuKct1vnEgG7Om9IOPLQyJ/xQAZkqIrOGkamsgplcmULPfatKWT6lu2/Nx2sqxk15448UQ33aKe/k7odylGsbsQXl1CELy4mSXkefqj3KbWwlFLsEXTa9Il9sre1ST8k+f/Nkj960g0DbrnQ0KJxU1CHe2ULCo50YzrQuNYYm+kxzCZuXV0Wepfq0q/cKKyU0mZo0D6qL26CZDW1LJTgyourQWtwKrDBJW8jjs+Z9Mlbr6ajmLUimDMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KttHrRtzn1U19NH6GsJwXSoXWlO1SKYYwMmHuWE8chQ=; b=K1Y61WHSpqaQ0oa8w9SND/t5efSTqDDMtSCh/2rkzjlcarUa8VR+fiv9Lgsu/M1NrLe633o7n5TLJw5vRnllyxMeXeA2QeMH8VpKHuWJYaIwu1CT7j7pHTflNO3h6bsY9mqQ4ZGtsiythvF7rVCtUI3S7nlmyhnyUMoo2dQhAe+FHI5Hs2LBCWf7PueXm2YpbjFVg0jjxNF1hR7bnDuEtWsfL9DGnxewjb6BAGsJ3q16F0NTpHd9JCUoxQgWdG2ka6IUdT9Eh2tpMPQ1WGafqx91X5R9pfgSKLlpSLLCuH0fE7ZAxNWfzUiV3Tezgh8qVRGUDhOPXXnMf2D5/URvSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:48 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:48 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:11 -0400 Subject: [PATCH v4 13/13] arm64: dts: imx8q: add camera ov5640 support for imx8qm-mek and imx8qxp-mek Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-8qxp_camera-v4-13-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=11400; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=+nDGwia3/owe7pv+QZPq07IJEos+Cd/hT3WNI74TaMk=; b=i2EyRjc1aHRNqIiLkIX6ZmEkrru7FOytIrJP/4yJun2zSyDrri9B0hU3DPRXPbOv95wQ/NhQg 1dorGgMmvbHD7X4WLpWluIo5+oc1l6P1qIrRzQbBUD6pf+G2ZqeMOhh X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e8f1ca2-63df-40f2-743d-08dd76e7fb49 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WnlXWEQrVGQyTzVpVXVHTHROTEVJekk0OEhmZ2hoM2Z0YTFpcmJ6b2JuK015?= =?utf-8?B?aDJ4aVZVR1IwY1lkRXVxZDdrd2d6ZmxZZWFabERISTBHRzhjb0tFSStFTzBL?= =?utf-8?B?WXZWZzQxcklmcnBucTFhQ3MxS2tER0RPNW1oUVpjZWNTK0xaZGRlWDhrdkJR?= =?utf-8?B?bEVDRzdhM3NIZ3g0V1I1STlsRGJVejBKVEJSREtsa0hjWTAxVGxBUG1WWUl3?= =?utf-8?B?NVVnZjgwVFFyMnBUK0VtQnM0SDRpTjVJYzRrS2F5eXo1cGREWkxac0Q3UXBn?= =?utf-8?B?TUtBQ2J3TTA2Nmk5SUxYNnZERVcrWXNQbkFZdEd6VjYvdjh5UzlucTk4YTF4?= =?utf-8?B?RkFWbkxuT2lmWGVVem5NenFENUk0RWtMZEUxRUdYbFFEbjlmc1JNbDlsRnFV?= =?utf-8?B?MDdjRXhKVU9aUmVVMFdOZnliUXFuaDhNSVN3d3pGU0xCc21hek9Ba2RPblhj?= =?utf-8?B?RDJ4RVlhR2hiSTFkUXVxSlBZWU9sZU1NbEJTbjBVZ2RneE9GZUVEVUd2V1c1?= =?utf-8?B?d1pJc05ETmtyb3JCdS9hektZdzlyWWpCYzJoRmVrbHhpMVhTeURUM1RlV09p?= =?utf-8?B?R1Y0OUtOMCtZUVRxMmYzc3p0dE16UEdIazhZaDNGQXh5QlZDY3BtdHZoQWdK?= =?utf-8?B?RzVvSHZVbzBzVm1KcFFzUmE5cVg0RDVweUNERUpzY2h0d2QxNFVvQSs5UXo3?= =?utf-8?B?WklablZ2K1RrTEl6STBlTTJZVDBvcVZmOUNiUDFGZWp6SExZRmcrOVNGUU9s?= =?utf-8?B?OUhPMXFGWjVWaXVXYmxSY093YXVpS3IvUEhuUjkzWU9XcE0veVlTYmxBcFBR?= =?utf-8?B?Ri84RkY5RGQvT0h3cGM1bmlKRDRXRXdMbXBqQmdXWVZ4enhYNmxEUC9UN2lV?= =?utf-8?B?ZUJ6R21KYlZnUjNpd2JITXF0SURBaHhMSlBHY2NLOTVVU3FsOW5jN2p5UTBn?= =?utf-8?B?OVJjU0piaWIrRWNOdXcxSlFValdsSXI4RlR5R1VncGtRTGVNaUxhVG9CWXp1?= =?utf-8?B?WFRBYU5peEpDZXdZaHhTZ0ljelZlL3ZQRVRNT3l3MkdmeEVHT2xxRTduWnRS?= =?utf-8?B?Y1B4MXFYTjE1cVd4ZFArRURadjRNeDBIcDdTSTZ1OXAvRDk3c21HeVBGS2RJ?= =?utf-8?B?cGRuZnVLVUN2UjcrZ2cwcGl4K0hyN0R6V0dKQ1psMkxmU2I0Q0VlU3Bxa1BG?= =?utf-8?B?Y0ZyUElOU2xueHBMdFRQTEdLdlpBanZnL3BhYlg1WEc1RVNyRENBaHYyZUtx?= =?utf-8?B?dVNPN3BWSjRodnZKTlNKaTRkaEIvZnJ1em1oZUpxeW5ibVJaUFJabXY3MGRK?= =?utf-8?B?TnErdWFwZlEyUzFlTTk0d1V5RWNSWXNicXdzdmZMR0duZ1JmQ1RWNE5vbjl1?= =?utf-8?B?U1A3RldTdThRRVpSbmRUekZXU25yT3V5VUtjSmZVU2xsOHE3MWVock03VER1?= =?utf-8?B?dFhHRDFQeDk4THFMMnRnVit6TUtweGtGYVE3UUJDaGswNmFxbXBYVEdQSGZh?= =?utf-8?B?d0h6L3hTSGhMT1BXVDlha3Q2RU1RQk9vVmZLUHJ6OHlYUUUwY1VjUDFjNG1B?= =?utf-8?B?c0xuTktONVdkNEU0OTRWQlN3VjZMU2Nvb1o5QlYrdS9YNzRzT0F3S3FFdXpi?= =?utf-8?B?Qzk1TXdLTHZWSS84YXU5bXgzQ01kQWJQdDlzclR3aVZwdG9VMDRndlBwUzFr?= =?utf-8?B?QmxzRnRmeDVORzVHdHRLRGtzZFp3UEJhVnVLNHFDL25aZi85N0hiYTVwRk1I?= =?utf-8?B?ZVdNTUZOTjRDZlFmbnRkVHZSTEx6UndMR0wvN1FtWnJPUEtQSzBISjNrZzNy?= =?utf-8?B?cWdHK0dYdkZzNzVWREVscEZ0aHppQkUwOHJKbUEwR2FwYXlMbjJ6SVltS3Z2?= =?utf-8?B?RTRLTFBNeTkvV0tCTFNoUElvaE1INm9nNFc4REJ5SVFVTU1VTmJua2pDS2Nz?= =?utf-8?B?bXVYRjJna3BxbnlGdGlKWnlpQmFja1ltQzEyQkNYWFkrUWwyTks3bmJiODhX?= =?utf-8?B?VDNlZWVKZ0pnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTFENXBnenUrM2h6ZkUzZ1JOWmdjQUR5L1NXZ000VDBERnV2MUwxMVp5MUtO?= =?utf-8?B?T3cvZjN6SlM2RmNKR21kc0pTZDEvblJXOVNjSVRKcngwTXcydXNHSHVjU0Fs?= =?utf-8?B?M3FYVkIxS0hDK2wrUTMrTXB6Z0l1aEJPcmg3MVIxSzdzWDNkbWVXWVRKL3BQ?= =?utf-8?B?aFhRN0s2b3hnNHJ3Q3BkR2N5WEtobkZrSWtkM0hPVjFWdFZpVFFzazRQeUMv?= =?utf-8?B?bFE0OTBnUlo2OXZoQXJKSURRWlBRdGR0bDdXYVRHaEZ5NmRLNE1ZRkhzUVA5?= =?utf-8?B?TzBtSWJlMmFDZ1VLcDB6ZUtmZFpHd2MyVmpzWEZOMUNMajAyR0RYNmFqTWhu?= =?utf-8?B?NTlFOTdyME9KRFVoeXFSY3BqTWhFbDVuUXl6WUNIazJwV0t3R2g1TW03bDdu?= =?utf-8?B?SDNYYnFoK2tiSnpoWEZwNDV4NEhMSXA0K05CdXJKUE50b3RNY09JOVFzTEZC?= =?utf-8?B?UTNVNy9lTlBhZ21NWnhFTmVReGt3bGcvRGVPaWVEM0swZmZyUHlaYW0xM29C?= =?utf-8?B?VlVsRmE4RS9VSzVyNlhlVjJXUVZ5bFVzdEdZQ1dKWVk5czk5cS92ajNMLzh2?= =?utf-8?B?eS9oRnNrNWxRS0cvZ1htWXZOM2ZXa0JtVlVmUjFJWksxQWRKNzVRYUVSdUti?= =?utf-8?B?RW94Vm1SYjFTd0ljZmQ4QXB1MXlmRDRJL0l6R0FWTm5TTXFCSUU5YlJFVXJ6?= =?utf-8?B?dXFRcTdTMFlvcHdVMGwwMVhwZVgrQ3hVcGtqbURHekVzT0lzRk1TVk9iS3k0?= =?utf-8?B?TW1aQlg5dVliL09NK080RWtyNnJ6bXlNM2RFQ0h3YXdXN1ZVcDZ2cjZudmZr?= =?utf-8?B?YVVud2RkK0syeTBqbW9WTnZBSG5XbHZmNjJFM1RlcDBoaTAzcU5KK3A0TjBy?= =?utf-8?B?Q014SzhaUVlFZ09SVDBaK0tCemMzQUZMWk42cGlLKzZYK3RKYUFrQXF2OGVK?= =?utf-8?B?TW1DZm96S0ZIVzlOOVdkemlYSnpMdFFyZzZDNTdHdXlpOFFick9GNnBXaFZk?= =?utf-8?B?SENIZkdEc3VtUjNBSHpvTUlocWUxank5ODYybVJXYjY3czdteU9ZSkVGTE9k?= =?utf-8?B?VElWT1NHMnJzQ0ZsYlNYd0FYSGJwU09zeVpWcHpnUW9IL0hYM2NoVEhiZEsz?= =?utf-8?B?cWkveWY0ellTNXNJd2IrR0dienVJVUNvV3R4VmJMczEveFlYbUE2eTVKd29v?= =?utf-8?B?TFRpQlc5T3ZEMGQ5TlJQTWJWbzFPYzFCb05peFJOdW5SODlzNDBHN2lBckJt?= =?utf-8?B?TzMwVE9QdVVoRndKUFN6T0dQdUNFbHduQWJzaUsrOE1XTzU5YWREQ0dYNDE1?= =?utf-8?B?VDMyVTlaSnFJZGlOQUVBZS80M0hJT0FEWENObjFHekE0MlFPc2ZMaVJTY1d4?= =?utf-8?B?K1dJeFpYNEJ5R0V0RTNySDVLSWFpMzIwZVVzN285aXBkS3RTd3ZNM2JnZ2ZS?= =?utf-8?B?ek1wLzQ3aDFBQkZEdEJXY3hWNkRxZk8rV1Yzdjc2L2IxZW94Q3JBZzVWOXM0?= =?utf-8?B?aWV3dnJCR2UvZkJRTy9ydGwzdTgwZXVmYWJCeTJhRFR2Ty9KZ0N1OHBwNjg0?= =?utf-8?B?a3p4NjJUcVUvWVlUYWhKSFFGUmY0MGJJWkFiemJQRlAxVDZ2LzI2QzUwbnFN?= =?utf-8?B?NitEelBKRkNrcmZQZThBZkF3SFhLcVkrdHBGQk1WWkxvZFhmNllJSk1kRVl6?= =?utf-8?B?UWtRV3RmZGw4L2gzeStkSHRLVXdoSUU1Q3FXemN4N1Z5MTVuSmF5VjBmUDBk?= =?utf-8?B?czA5dndTdHp2R2hWZkxMZG4yTytOMlo0STdva1NWOHU0QUw0WDdwc2VWbEJI?= =?utf-8?B?SnFhTTRzLzZ4eTJpR2ZxbitscXQ0SDAxYno1emZkeEpTT01MV0pyY1hOdmRX?= =?utf-8?B?dVU3ZTFMbWx5OHlINmR5R0dVMHdPaFVrY0FMNzQ0MnpZcmUzMmtQcG1XY2NF?= =?utf-8?B?UlNtQ3ZjaFVXcHFBaDBGS0l3NVRPOGYrMHlMTGxWdERva3dqbVc0UThZRXJ3?= =?utf-8?B?bUhJWk1uUEluWkFQZGpweTJtcjVhNkVEVGorcTlsaCs3ZUMrOXVEbnZ0VVgr?= =?utf-8?B?NGZFZXZXRlJFT2tjbUs5V2tNWVNmREpjeTNMa3hrWllNZUEzckVzbDR1Wkw1?= =?utf-8?Q?3NJA=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e8f1ca2-63df-40f2-743d-08dd76e7fb49 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:48.3180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mODXtObTYQ8Ca8gSC31tC+v3oASG3+ITKPRALLwzvEq/8Cw7ZAj5rvwEx0UdlMRYSgmWyiRxjngQcQq7Lgi59w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 Add ov5640 overlay file for imx8qm-mek and imx8qxp-mek board. Camera can connect different CSI port. So use dts overlay file to handle these difference connect options. Signed-off-by: Frank Li --- change from v3 to v4 - add board level xtal24m - remove reduntant ports information at dtso because chip leave already add it. change from v2 to v3 - remove phy nodes change from v1 to v2 - none --- arch/arm64/boot/dts/freescale/Makefile | 11 ++++ .../boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso | 60 ++++++++++++++++++= ++++ .../boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso | 60 ++++++++++++++++++= ++++ arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 58 ++++++++++++++++++= +++ .../boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso | 59 ++++++++++++++++++= +++ arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 36 +++++++++++++ 6 files changed, 284 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/f= reescale/Makefile index b6d3fe26d6212..4101ef6ed520d 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -277,6 +277,14 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-apalis-v1.1-eval-v1= .2.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-apalis-v1.1-ixora-v1.1.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-apalis-v1.1-ixora-v1.2.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-mek.dtb + +imx8qm-mek-ov5640-csi0-dtbs :=3D imx8qm-mek.dtb imx8qm-mek-ov5640-csi0.dtbo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qm-mek-ov5640-csi0.dtb +imx8qm-mek-ov5640-csi1-dtbs :=3D imx8qm-mek.dtb imx8qm-mek-ov5640-csi1.dtbo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qm-mek-ov5640-csi1.dtb +imx8qm-mek-ov5640-dual-dtbs :=3D imx8qm-mek.dtb imx8qm-mek-ov5640-csi0.dtb= o imx8qm-mek-ov5640-csi1.dtbo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qm-mek-ov5640-dual.dtb + dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-ai_ml.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-colibri-aster.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-colibri-eval-v3.dtb @@ -287,6 +295,9 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-mek.dtb imx8qxp-mek-pcie-ep-dtbs +=3D imx8qxp-mek.dtb imx8qxp-mek-pcie-ep.dtbo dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-mek-pcie-ep.dtb =20 +imx8qxp-mek-ov5640-csi-dtbs :=3D imx8qxp-mek.dtb imx8qxp-mek-ov5640-csi.dt= bo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qxp-mek-ov5640-csi.dtb + dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-tqma8xqp-mba8xx.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8ulp-evk.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx93-9x9-qsb.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso b/ar= ch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso new file mode 100644 index 0000000000000..ba8ceee41db6f --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso @@ -0,0 +1,60 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2025 NXP + */ + +/dts-v1/; +/plugin/; + +#include +#include + +&i2c_mipi_csi0 { + #address-cells =3D <1>; + #size-cells =3D <0>; + clock-frequency =3D <100000>; + pinctrl-0 =3D <&pinctrl_i2c_mipi_csi0>; + pinctrl-names =3D "default"; + status =3D "okay"; + + ov5640_mipi_0: camera@3c { + compatible =3D "ovti,ov5640"; + reg =3D <0x3c>; + clocks =3D <&xtal24m>; + clock-names =3D "xclk"; + pinctrl-0 =3D <&pinctrl_mipi_csi0>; + pinctrl-names =3D "default"; + powerdown-gpios =3D <&lsio_gpio1 28 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&lsio_gpio1 27 GPIO_ACTIVE_LOW>; + AVDD-supply =3D <®_2v8>; + DVDD-supply =3D <®_1v5>; + DOVDD-supply =3D <®_1v8>; + status =3D "okay"; + + port { + ov5640_mipi_0_ep: endpoint { + bus-type =3D ; + data-lanes =3D <1 2>; + remote-endpoint =3D <&mipi_csi0_in>; + }; + }; + }; +}; + +&irqsteer_csi0 { + status =3D "okay"; +}; + +&isi { + status =3D "okay"; +}; + +&mipi_csi_0 { + status =3D "okay"; +}; + +&mipi_csi0_in { + data-lanes =3D <1 2>; + remote-endpoint =3D <&ov5640_mipi_0_ep>; +}; + diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso b/ar= ch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso new file mode 100644 index 0000000000000..549633f37db53 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso @@ -0,0 +1,60 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2025 NXP + */ + +/dts-v1/; +/plugin/; + +#include +#include + +&i2c_mipi_csi1 { + #address-cells =3D <1>; + #size-cells =3D <0>; + clock-frequency =3D <100000>; + pinctrl-0 =3D <&pinctrl_i2c_mipi_csi1>; + pinctrl-names =3D "default"; + status =3D "okay"; + + ov5640_mipi_1: camera@3c { + compatible =3D "ovti,ov5640"; + reg =3D <0x3c>; + clocks =3D <&xtal24m>; + clock-names =3D "xclk"; + pinctrl-0 =3D <&pinctrl_mipi_csi1>; + pinctrl-names =3D "default"; + powerdown-gpios =3D <&lsio_gpio1 31 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&lsio_gpio1 30 GPIO_ACTIVE_LOW>; + AVDD-supply =3D <®_2v8>; + DVDD-supply =3D <®_1v5>; + DOVDD-supply =3D <®_1v8>; + status =3D "okay"; + + port { + ov5640_mipi_1_ep: endpoint { + bus-type =3D ; + data-lanes =3D <1 2>; + remote-endpoint =3D <&mipi_csi1_in>; + }; + }; + }; +}; + +&irqsteer_csi1 { + status =3D "okay"; +}; + +&isi { + status =3D "okay"; +}; + +&mipi_csi_1 { + status =3D "okay"; +}; + +&mipi_csi1_in { + data-lanes =3D <1 2>; + remote-endpoint =3D <&ov5640_mipi_1_ep>; +}; + diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot= /dts/freescale/imx8qm-mek.dts index 68442c8575f3f..503e0acd7963d 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts @@ -32,6 +32,13 @@ memory@80000000 { reg =3D <0x00000000 0x80000000 0 0x40000000>; }; =20 + xtal24m: clock-xtal24m { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <24000000>; + clock-output-names =3D "xtal_24MHz"; + }; + reserved-memory { #address-cells =3D <2>; #size-cells =3D <2>; @@ -155,6 +162,27 @@ usb3_data_ss: endpoint { }; }; =20 + reg_1v5: regulator-1v5 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v5"; + regulator-min-microvolt =3D <1500000>; + regulator-max-microvolt =3D <1500000>; + }; + + reg_1v8: regulator-1v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v8"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <1800000>; + }; + + reg_2v8: regulator-2v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "2v8"; + regulator-min-microvolt =3D <2800000>; + regulator-max-microvolt =3D <2800000>; + }; + reg_usdhc2_vmmc: usdhc2-vmmc { compatible =3D "regulator-fixed"; regulator-name =3D "SD1_SPWR"; @@ -824,6 +852,20 @@ IMX8QM_QSPI1A_DATA1_LSIO_GPIO4_IO25 0x0600004c >; }; =20 + pinctrl_i2c_mipi_csi0: i2c-mipi-csi0grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI0_I2C0_SCL_MIPI_CSI0_I2C0_SCL 0xc2000020 + IMX8QM_MIPI_CSI0_I2C0_SDA_MIPI_CSI0_I2C0_SDA 0xc2000020 + >; + }; + + pinctrl_i2c_mipi_csi1: i2c-mipi-csi1grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI1_I2C0_SCL_MIPI_CSI1_I2C0_SCL 0xc2000020 + IMX8QM_MIPI_CSI1_I2C0_SDA_MIPI_CSI1_I2C0_SDA 0xc2000020 + >; + }; + pinctrl_i2c0: i2c0grp { fsl,pins =3D < IMX8QM_HDMI_TX0_TS_SCL_DMA_I2C0_SCL 0x06000021 @@ -1017,6 +1059,22 @@ IMX8QM_LVDS1_I2C1_SDA_LVDS1_I2C1_SDA 0xc600004c >; }; =20 + pinctrl_mipi_csi0: mipi-csi0grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI0_GPIO0_00_LSIO_GPIO1_IO27 0xC0000041 + IMX8QM_MIPI_CSI0_GPIO0_01_LSIO_GPIO1_IO28 0xC0000041 + IMX8QM_MIPI_CSI0_MCLK_OUT_MIPI_CSI0_ACM_MCLK_OUT 0xC0000041 + >; + }; + + pinctrl_mipi_csi1: mipi-csi1grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI1_GPIO0_00_LSIO_GPIO1_IO30 0xC0000041 + IMX8QM_MIPI_CSI1_GPIO0_01_LSIO_GPIO1_IO31 0xC0000041 + IMX8QM_MIPI_CSI1_MCLK_OUT_MIPI_CSI1_ACM_MCLK_OUT 0xC0000041 + >; + }; + pinctrl_pciea: pcieagrp { fsl,pins =3D < IMX8QM_PCIE_CTRL0_WAKE_B_LSIO_GPIO4_IO28 0x04000021 diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso b/ar= ch/arm64/boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso new file mode 100644 index 0000000000000..5500c4846f031 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso @@ -0,0 +1,59 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ +/dts-v1/; +/plugin/; + +#include +#include + +&i2c_mipi_csi0 { + #address-cells =3D <1>; + #size-cells =3D <0>; + clock-frequency =3D <100000>; + pinctrl-0 =3D <&pinctrl_i2c_mipi_csi0>; + pinctrl-names =3D "default"; + status =3D "okay"; + + ov5640_mipi: camera@3c { + compatible =3D "ovti,ov5640"; + reg =3D <0x3c>; + clocks =3D <&xtal24m>; + clock-names =3D "xclk"; + pinctrl-0 =3D <&pinctrl_mipi_csi0>; + pinctrl-names =3D "default"; + powerdown-gpios =3D <&lsio_gpio3 7 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&lsio_gpio3 8 GPIO_ACTIVE_LOW>; + AVDD-supply =3D <®_2v8>; + DVDD-supply =3D <®_1v5>; + DOVDD-supply =3D <®_1v8>; + status =3D "okay"; + + port { + ov5640_mipi_ep: endpoint { + bus-type =3D ; + data-lanes =3D <1 2>; + remote-endpoint =3D <&mipi_csi0_in>; + }; + }; + }; +}; + +&irqsteer_csi0 { + status =3D "okay"; +}; + +&isi { + status =3D "okay"; +}; + +&mipi_csi_0 { + status =3D "okay"; +}; + +&mipi_csi0_in { + data-lanes =3D <1 2>; + remote-endpoint =3D <&ov5640_mipi_ep>; +}; + diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boo= t/dts/freescale/imx8qxp-mek.dts index a378f462a283b..d7ab042e0e72b 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts @@ -90,6 +90,27 @@ usb3_data_ss: endpoint { }; }; =20 + reg_1v5: regulator-1v5 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v5"; + regulator-min-microvolt =3D <1500000>; + regulator-max-microvolt =3D <1500000>; + }; + + reg_1v8: regulator-1v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v8"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <1800000>; + }; + + reg_2v8: regulator-2v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "2v8"; + regulator-min-microvolt =3D <2800000>; + regulator-max-microvolt =3D <2800000>; + }; + reg_pcieb: regulator-pcie { compatible =3D "regulator-fixed"; regulator-max-microvolt =3D <3300000>; @@ -781,6 +802,13 @@ IMX8QXP_FLEXCAN1_RX_ADMA_FLEXCAN1_RX 0x21 >; }; =20 + pinctrl_i2c_mipi_csi0: i2c-mipi-csi0grp { + fsl,pins =3D < + IMX8QXP_MIPI_CSI0_I2C0_SCL_MIPI_CSI0_I2C0_SCL 0xc2000020 + IMX8QXP_MIPI_CSI0_I2C0_SDA_MIPI_CSI0_I2C0_SDA 0xc2000020 + >; + }; + pinctrl_ioexp_rst: ioexprstgrp { fsl,pins =3D < IMX8QXP_SPI2_SDO_LSIO_GPIO1_IO01 0x06000021 @@ -821,6 +849,14 @@ IMX8QXP_FLEXCAN2_RX_ADMA_UART3_RX 0x06000020 >; }; =20 + pinctrl_mipi_csi0: mipi-csi0grp { + fsl,pins =3D < + IMX8QXP_MIPI_CSI0_GPIO0_01_LSIO_GPIO3_IO07 0xC0000041 + IMX8QXP_MIPI_CSI0_GPIO0_00_LSIO_GPIO3_IO08 0xC0000041 + IMX8QXP_MIPI_CSI0_MCLK_OUT_MIPI_CSI0_ACM_MCLK_OUT 0xC0000041 + >; + }; + pinctrl_pcieb: pcieagrp { fsl,pins =3D < IMX8QXP_PCIE_CTRL0_PERST_B_LSIO_GPIO4_IO00 0x06000021 --=20 2.34.1