From nobody Sun Feb 8 09:02:25 2026 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2071.outbound.protection.outlook.com [40.107.244.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA634226170; Mon, 7 Apr 2025 22:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066310; cv=fail; b=PHr0Y4iWkPtYBvHLS+J1gF8QF02XREP7ZK3QtsXUMom/Eqc1kvimmZ0Dfqsm+dMO/Mw1UyAiU4OslwKxjMlLTL4zgf8F0NPUHwf/UFAZN0gsEoyqB+N5oLCy4CQKjUL4glHdGdJ80isUiFC7+ByNaLf2rGp4hhh/Gzyh26FEN5M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066310; c=relaxed/simple; bh=51RbEd1KSLYvDRQ2uesQYXoWEvxv+XR9eAS7189qZ3w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ingdB1ZRll/eJv+HXDqg5HiolficlaZxXDbLSglTS3uqxDH0DC6le7p7rSIUJPPqpPIZ0jb6RBHBtVVu/wrustXNCK9flf4+f2miFv09CiViNu9IEhCiwwErv40mjmvVXtxBuA7eysprs5eTmWKrtS30sGuK41SH5SZ2EvOMFcE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=lT+V9v4c; arc=fail smtp.client-ip=40.107.244.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="lT+V9v4c" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tWGxhW9HUSp+lIIV+/lxacSMegs6vhGkhZfmiNgfoZdcVi3jqT8XiEQyBsfQe7Ab9hU/qrRLDHkk4Q1lK7thO1kltX0YQ/yzmmlOtR70LCzZjSUir1dRjW7oIPCyzyeilVHaTmkq1F5Grsa36HMlQ63nYasaBA7CCqhpvrRddSN67oqEmdiH5AgbJ5CaW4YmCYz+8qfPuOTh3k6BsumEPeNYf9fRMPxz2ZqLm9E7Nm2qE3q2cU2gRCXXfTHDmtxCczDI4gbao3F2v9ZYH+TFqMyk2sXmgRCgtwmvl7ZQS5h6Qz6eNcdWw0RBGM3T+fCGOgMsPfEXu9KgetwvEZOsVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Iu1eLkZ6kf/kKGj3QCvA/GOH6E0U124GCZyYdua/Gr0=; b=yReIwZKAMBHM06Pgz+Vjml79nctRBSD0thGaZP887V3J6ucU6T+0k/X1RcdoOJdI4UMywHQhiDN7bQBhnG7zUu9fv8o1JujNQZ+5c9yNPSmunttIMlj3l8S9+wKAl5xk91gbiuDafs3XNZcc5oiQbPIt64nezebJVWGR6WlB43KoisR4fLlSx1k3DS7VkYje6g//ijdY+FA97yY9PIqTKN9cejUw5ue68XQwwi5TuJptqDXSW1+XQqxYpEdkFaBSMUMouMWgAUifCu6H9Ax3E4khOnXbZctQQLJvFmA4qdwhAocHq2AZL2gUmM3s3P5lHj0Fh3vQuQijZsOcmjiMdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lunn.ch smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iu1eLkZ6kf/kKGj3QCvA/GOH6E0U124GCZyYdua/Gr0=; b=lT+V9v4crLTbFIxe2GxpehydUVN/Dchg+zCf+il/izUk+7JlzDQty/UjMUPxe5Ky93EQ1wX2KCQh10ZKxFwJGoba2qWvzshKXaZdkN5lidHeHpPp3BF3oppLULlmGdKUksLeT9TRRnrFPMuK0CABwEFSSTbHPCYGBj27O6UYxlw= Received: from BN9PR03CA0090.namprd03.prod.outlook.com (2603:10b6:408:fc::35) by DS2PR12MB9616.namprd12.prod.outlook.com (2603:10b6:8:275::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 22:51:45 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:408:fc:cafe::fe) by BN9PR03CA0090.outlook.office365.com (2603:10b6:408:fc::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.33 via Frontend Transport; Mon, 7 Apr 2025 22:51:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8606.22 via Frontend Transport; Mon, 7 Apr 2025 22:51:44 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Apr 2025 17:51:42 -0500 From: Shannon Nelson To: , , , , , , , , CC: Shannon Nelson Subject: [PATCH net 1/6] pds_core: Prevent possible adminq overflow/stuck condition Date: Mon, 7 Apr 2025 15:51:08 -0700 Message-ID: <20250407225113.51850-2-shannon.nelson@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250407225113.51850-1-shannon.nelson@amd.com> References: <20250407225113.51850-1-shannon.nelson@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|DS2PR12MB9616:EE_ X-MS-Office365-Filtering-Correlation-Id: 614a009c-e2e7-4cff-47b7-08dd7626c4f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KijyyilNMJYy+ap7hsqnWuXeow/YDCwcpQNLqs4kxIIhkvjigYAbhdR2Zz+w?= =?us-ascii?Q?PA65u9W7/KDTNTUVzGK2HdFL+7J61L/9g+UAAYNiUrJrGyvZwS4p/EuGaIi8?= =?us-ascii?Q?bBSWVZRSBVjn6yWxmsdcPHheUdTdC+wenMi7Uwq0Oc+cv7zN8hmdXNl8M3M5?= =?us-ascii?Q?Xla5lZgmWLW6hILzVFRxy7ztdI5jmiS2m3DAY8jfTZaMJdxXeqXwYVHjbJB2?= =?us-ascii?Q?HTPZFElAP8nBdUEfSC2C3dMin3GQf97JbudRyT7qwh3QXrr2GC5U/vKqAhZq?= =?us-ascii?Q?kp2kAlS6nm0gmoN2vf2wCGf8GX/PNHtgpgPzEaLL9f7SPHYiNfdpIP0Fppb2?= =?us-ascii?Q?2GJwXjX+fEDfH6ykSfF5aKN0S5o1S0E+bTROWouHVTlfi2hShtMYQrB36izJ?= =?us-ascii?Q?2/RvR4Y7eUZaXo88KyAAYZ30vBuJ8HO7kmmn7cwbJ9dAx0m29mV8901Tp2RS?= =?us-ascii?Q?/wtZSeSRhAFzvOJbL3KUvLtCPawpXdkeoedTwzIXXok4rkmZzPUSV9wnqJJ4?= =?us-ascii?Q?JMypkp4rHrdqXqTPhpZQDQB9sOzW7/eRnOM4bIwhIfRgaNcwT8zQ5KGykN7P?= =?us-ascii?Q?sXpeTz89pr/lJIUBGyKTCw+n47subqEqnw3a/FNdMkGnVfjBxooksq89rbFi?= =?us-ascii?Q?B9azkeqsEmoR7Lm5NPGkC8a7xoR8qMGwa+VVDAhM3+qatRp5w8izPDTVD3VO?= =?us-ascii?Q?/dTNZOInkikVFs83msyhA3IknkcuyI1l9DCYnJMiq+xHyA1uFs+sjrBaObiD?= =?us-ascii?Q?p3fM3l8v6SVRJ7bcvUFeWb2m+Ww5VJFdgPeIO79/6PwRi2DXipVOO69FPkDC?= =?us-ascii?Q?EhXhsHoWF0g+ZQoGIKXCAWIGXkbSgvfhFuE7QI307oIHEVwc3NBlB9mt3lvf?= =?us-ascii?Q?A2m7CtFvqlVZpoDTksPOb8lVb2fN0Gmfxb8r1UTBW+GGJC7dQzh4JQAc4YH7?= =?us-ascii?Q?nWhRT36mTakULcsNdGH2E63V38E7EojRtvbjVFq+F07ybeuRTo0etjKryedi?= =?us-ascii?Q?IQrsfbfklbaLH4FJABm//GRzxWK06tqbSGMA0jeWLzZ/F680V02LSnZvhuT3?= =?us-ascii?Q?EmmFa04aA5O1+wRqjHglNuLJp+LrvEK17fqmzPijXt7WvyQVKlvsO9NRbT3X?= =?us-ascii?Q?DAHyLTckS1+WsjdXL1e8H4AJzekpAMqANtM0e1IKj6eCuMluoVxhbBDJPEDU?= =?us-ascii?Q?wWA8SfU22u4aLFugQeZ7P9RPtXU8rnpsZ+ZoftvmOUb52r61E4RHHZXkNy6R?= =?us-ascii?Q?5PWiI+rW7uHC3LtZWjQcJTrOPKb7ZEfFJ1faho3vWbponhsu6A3E26Vpd6A9?= =?us-ascii?Q?19TZuFqv/9VtN/ZTZxX543c+8ZzCw727eNF8vMeVbd6yVt4/pzF0RMRVptWE?= =?us-ascii?Q?aN8/uBcItFpDedt6QwgCkuOgP7LoicB9X47hkwVAgTRcbUZIfdPWFbNg8ASe?= =?us-ascii?Q?9AIlan0Bm2RTOX1iS4u02hMkP1fqXmNz9fN3nV6Jp3ujrxjaCYMUrCErhW2O?= =?us-ascii?Q?GbiynUObWTfCl9s=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 22:51:44.1319 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 614a009c-e2e7-4cff-47b7-08dd7626c4f6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9616 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Brett Creeley The pds_core's adminq is protected by the adminq_lock, which prevents more than 1 command to be posted onto it at any one time. This makes it so the client drivers cannot simultaneously post adminq commands. However, the completions happen in a different context, which means multiple adminq commands can be posted sequentially and all waiting on completion. On the FW side, the backing adminq request queue is only 16 entries long and the retry mechanism and/or overflow/stuck prevention is lacking. This can cause the adminq to get stuck, so commands are no longer processed and completions are no longer sent by the FW. As an initial fix, prevent more than 16 outstanding adminq commands so there's no way to cause the adminq from getting stuck. This works because the backing adminq request queue will never have more than 16 pending adminq commands, so it will never overflow. This is done by reducing the adminq depth to 16. Fixes: 792d36ccc163 ("pds_core: Clean up init/uninit flows to be more reada= ble") Reviewed-by: Michal Swiatkowski Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/net/ethernet/amd/pds_core/core.c | 5 +---- drivers/net/ethernet/amd/pds_core/core.h | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/amd/pds_core/core.c b/drivers/net/etherne= t/amd/pds_core/core.c index 1eb0d92786f7..55163457f12b 100644 --- a/drivers/net/ethernet/amd/pds_core/core.c +++ b/drivers/net/ethernet/amd/pds_core/core.c @@ -325,10 +325,7 @@ static int pdsc_core_init(struct pdsc *pdsc) size_t sz; int err; =20 - /* Scale the descriptor ring length based on number of CPUs and VFs */ - numdescs =3D max_t(int, PDSC_ADMINQ_MIN_LENGTH, num_online_cpus()); - numdescs +=3D 2 * pci_sriov_get_totalvfs(pdsc->pdev); - numdescs =3D roundup_pow_of_two(numdescs); + numdescs =3D PDSC_ADMINQ_MAX_LENGTH; err =3D pdsc_qcq_alloc(pdsc, PDS_CORE_QTYPE_ADMINQ, 0, "adminq", PDS_CORE_QCQ_F_CORE | PDS_CORE_QCQ_F_INTR, numdescs, diff --git a/drivers/net/ethernet/amd/pds_core/core.h b/drivers/net/etherne= t/amd/pds_core/core.h index 0bf320c43083..199473112c29 100644 --- a/drivers/net/ethernet/amd/pds_core/core.h +++ b/drivers/net/ethernet/amd/pds_core/core.h @@ -16,7 +16,7 @@ =20 #define PDSC_WATCHDOG_SECS 5 #define PDSC_QUEUE_NAME_MAX_SZ 16 -#define PDSC_ADMINQ_MIN_LENGTH 16 /* must be a power of two */ +#define PDSC_ADMINQ_MAX_LENGTH 16 /* must be a power of two */ #define PDSC_NOTIFYQ_LENGTH 64 /* must be a power of two */ #define PDSC_TEARDOWN_RECOVERY false #define PDSC_TEARDOWN_REMOVING true --=20 2.17.1 From nobody Sun Feb 8 09:02:25 2026 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2067.outbound.protection.outlook.com [40.107.244.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD55022A4CC; Mon, 7 Apr 2025 22:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066313; cv=fail; b=NGyqUFwv1VCnikzejDEJUYBjxm9webj43dLEpKLwZ4Q6TNNOaFzh1j7lJns2empvxrj8enxOdYS/voVLGsKYlDUs+WefvQpCMkzgktH6L9SOaBNMh0q1wjaZ4sCL6XbPvpkb1mVmmBsoVsYXjzaJ/w0RYGR82ciQXLSKnj1umVw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066313; c=relaxed/simple; bh=p06Itxrw6JrvHJwzgwdCAWN95qadbwxeFMZG19zncJ4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FHuUEDRfyVt1mgkMi27LAhmE+O7ZTF/WXhGGuyOyRMOXt420fCtnAZKHvixyQkXXpDininxPWO4L2Q2K5DRaw212rMkr33qhJ0W1ihzJdTSzvSTvBDWuO7INE+v0XIPHU7lUQfpxdBriRRVAG8LPLUligesBKhGLYjT3JX2gEhw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KuW7KfxS; arc=fail smtp.client-ip=40.107.244.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KuW7KfxS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VyiIPN/WUaqKZ6jWWnoh2nhbcYfEkhtjr3Q+MIaE9LO37pdXNjX/Wk2CREBpLQLZYtMXpIajiFx1DuZWSUGk8WzRSgC6RdwyonLO80ycrbVShB3Cndq3IvbeM8OjSnjaconOr6tSaXRdOd8es3H4kcKyw3We0SdVcdSl0I8dww2dlSn4Pq0+6LD3I5YSPed9UMHIIK8XXC578UssYQW+QKdUf7xe85IU2EGufzyJNDk6ud5j78zlK6uSyKUVKyLuUHD1FaCZ+xSdXh4BugFkwXlqrHccZ9ITOXYnRNelJmHgFWlR6pxl5Rcg5zmZTN78yfY3Y9yKlva5xH2xkiVr0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9P6mPLGKSYe29hou8fEON/0VDO3tQ82KXXaPmiCsET0=; b=VKrllFWHPZz66JZ8kSPfxxjpNLlRTcCd6rQgjBkkW8VssZlkwysDtKFODAHr0hjhrvStnwtykEfdYdAiuk8f/aSbtkmo9kzNKBURafMAzu30kHtg1P/48SMXxr5eFyYTUKh+0nFqAeeBm9zgH8h3Cg0HehCaKiWqQ9TyQQMrG1DLqWXKaXaS/KYOyKnQFPMg0bzl+ELvpaxkjHG0UF7IZgnHPeZfZv1rYuv7LkIHbOOy3Er0ClcJtexpXKthxfAZoXmf2BMJg5eGxQLcUkqlA+6hIdFR2ZfsDDNYT/SJIQEWzeUNJrnHGO3ofyLwoeftMSgWlpHSOHdPUNFG/csOoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lunn.ch smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9P6mPLGKSYe29hou8fEON/0VDO3tQ82KXXaPmiCsET0=; b=KuW7KfxS3NEqvL41foGZbkG28qZKQfyc9yaEnSBh1RJEp2qOv0KUenGUAWyMhaP2wkqguSWSoX1tFVkpU+TfRLnLMkFlT/peBrGvBJtcaubT2RYKzpVECpUG3HgS7xatLJoFUhEiQzmOt9eLyACSjGtaejepgEGGiTrR9V0RT/o= Received: from BN9PR03CA0082.namprd03.prod.outlook.com (2603:10b6:408:fc::27) by CY5PR12MB6060.namprd12.prod.outlook.com (2603:10b6:930:2f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Mon, 7 Apr 2025 22:51:47 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:408:fc:cafe::44) by BN9PR03CA0082.outlook.office365.com (2603:10b6:408:fc::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.47 via Frontend Transport; Mon, 7 Apr 2025 22:51:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8606.22 via Frontend Transport; Mon, 7 Apr 2025 22:51:46 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Apr 2025 17:51:43 -0500 From: Shannon Nelson To: , , , , , , , , CC: Shannon Nelson Subject: [PATCH net 2/6] pds_core: remove extra name description Date: Mon, 7 Apr 2025 15:51:09 -0700 Message-ID: <20250407225113.51850-3-shannon.nelson@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250407225113.51850-1-shannon.nelson@amd.com> References: <20250407225113.51850-1-shannon.nelson@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|CY5PR12MB6060:EE_ X-MS-Office365-Filtering-Correlation-Id: c8c8aadd-163b-4f56-5c52-08dd7626c690 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1VH4km9f2Q6DjcQoLFbu5aJAwNgMSp92piJrT6X3/Z3MxFN3eW2HWOHXGYSO?= =?us-ascii?Q?1nOk+X278PiMzZXxdxJXgJpXoCaBZoW50K48v4Q3i4o5U+WsYVkKv/64smZH?= =?us-ascii?Q?bx+fMX8k8oGEpdpG7j+daLLHpPry6a8rnbBhGd4WV0W/Cum1ENR5VjeFu4ta?= =?us-ascii?Q?6epwNRn+ro+blsp2xletq3kV9k6TQNCpH9jkXxzUCvRBCCzgXD7pzNau50hC?= =?us-ascii?Q?4r/ivQpSPh4MAAvAsDMXUeW0w9wiYlyxPRPzvbmGQ1+HOL5kbKsEpLguQDAa?= =?us-ascii?Q?KeJqnBpyScU9MHDpTv0Ev9atnMdkykcYZkEOVOFIokESVZIz47lDbBZBV/GR?= =?us-ascii?Q?Zjt29S+6FpygRQGCqi974k9fUCEMsynjKxMRBNy8jXefv25uEHkV/cdyz2Jr?= =?us-ascii?Q?3oi6zCDkr9w7udK6aB0owcP5d2UgkF7gg8kj97nPhwHKKFhwRt0fkq56qxTN?= =?us-ascii?Q?Zho6zpc7U93aj/qIltmGX7mzI5nE+WUuAvss1EPwBi7H1oeHHQter8qviN0F?= =?us-ascii?Q?Ohts1Y3avZa39lYPlxaJfXIkUliW0D1pDYHN7Q447xWxhKZOhh79M0Hd3rL5?= =?us-ascii?Q?IiktTLSEXFnpfYmnXydyvpHnLcTEvgpJfzxnCeMvhyNvytQniu4A7XVVVfJc?= =?us-ascii?Q?M3BVVnqMn1ByKdvnZznykvWviWOjFdYomqLvT0qPHXN4kPle13qpqHVAFhYs?= =?us-ascii?Q?eEubLor8jYorJsl7V4XKbXrG6g5DsJvegg4j7NGGNQhoq15daE8bfmIYCtE2?= =?us-ascii?Q?2PazfPAHLbN20VBNKsiH5nt8Rk6SqVaqYVyKxE2InGj0JXxJsuu+MxJB8yYc?= =?us-ascii?Q?7BGadmVoHBu5RJMzYSecQ9+g2mjeJMyd3+FnavKkx5/b9PuS/KQZo32sEjxC?= =?us-ascii?Q?oVxUOPIbWjWQWEBg4oXP7+13MQ4mm+ZLS7DZl8Z0nJF2Ud5LvS4l1aBmQYJr?= =?us-ascii?Q?G0jG2ASxFjC4HeOvb/OEyv8i9jkbOOX/ds/QmgWfkWSTGadmxWNhVuLxvHXn?= =?us-ascii?Q?/RU97xbq8zLkWAIU/oLAJMSz4SSZmWFWARbvMJQOnae/8q649gTDQin78wTI?= =?us-ascii?Q?LreRExql9WrzRvDiYedzkzfYWXvUGIlUm6ANVkajI+4RPXF9pVk5t7SlGqFS?= =?us-ascii?Q?Mmi4wNsN0kv7o5T8gqWyQcDom1SYnoI0gi67tQkBVSi2I32glSXviMgFfgu8?= =?us-ascii?Q?oyo8xreY40lHeZ80I9Cgcru7HMnWFC8cqPtGL9hMWIMNitpk6jYTMXcXnWTf?= =?us-ascii?Q?v3MJwexJwemgHveTyuVrBRTN0xb/PFvpDu66oHp6XmDHSJJvXYm0lU2q66pk?= =?us-ascii?Q?1Igw+k5Z1ncHKpOOUJq8Nm9/Idtsv8KKx8CkLF9ezygFg8XYusiwsyD4DFmK?= =?us-ascii?Q?np/f5rUCyMRJtSs5gbqyEW25E3H6QbhYopCu+wAxbYMxP8v2hN3Hl9fqaqfF?= =?us-ascii?Q?PzLzRf2kjRmizLj/T1xvsMYMrjl5XCpWOx5uJ75OA1BlPacxQF5SKqmzqttp?= =?us-ascii?Q?i3V4SxMzhGrx+f8=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 22:51:46.8194 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8c8aadd-163b-4f56-5c52-08dd7626c690 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6060 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix the kernel-doc complaint include/linux/pds/pds_adminq.h:481: warning: Excess struct member 'name' de= scription in 'pds_core_lif_getattr_comp' Fixes: 45d76f492938 ("pds_core: set up device and adminq") Signed-off-by: Shannon Nelson Reviewed-by: Simon Horman --- include/linux/pds/pds_adminq.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/pds/pds_adminq.h b/include/linux/pds/pds_adminq.h index ddd111f04ca0..339156113fa5 100644 --- a/include/linux/pds/pds_adminq.h +++ b/include/linux/pds/pds_adminq.h @@ -463,7 +463,6 @@ struct pds_core_lif_getattr_cmd { * @rsvd: Word boundary padding * @comp_index: Index in the descriptor ring for which this is the complet= ion * @state: LIF state (enum pds_core_lif_state) - * @name: LIF name string, 0 terminated * @features: Features (enum pds_core_hw_features) * @rsvd2: Word boundary padding * @color: Color bit --=20 2.17.1 From nobody Sun Feb 8 09:02:25 2026 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2064.outbound.protection.outlook.com [40.107.93.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F320C228C99; Mon, 7 Apr 2025 22:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066312; cv=fail; b=lAqJSquVdqcCVmpVGDR/ihf+VCIxFsWEg+1MNSt+uo7l5WJt2PnQyb6npTHTw97m9XKfifpVx83vHhb9q2nKMw1XIT7+GTeY84O245/0USzBcywbHua9JXS8ZBfF1HrD2H6eYBTK0b4w33h07BUiW1bx/Q3+C49whtrYO5MjOQw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066312; c=relaxed/simple; bh=nmYY7pWw9v6eP9O+ANP6DaRH8/KMD4splLRtvNn/kio=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VM+bJrrbMYspxHgs48nPDIARCCMmLeh5xGe/9sj5yCTiaNSqD3qlEet8LkKPxYIaYiwm/CYx31vxEK7oGzjPLD+h4N2YFGyhrzzo+88NvPQJuZ+czXtyx32hhX8TGnIsgaG4otep4uMzncQYM//qzym+9ub1Ux0ZXLc6L5d1DNo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=4yxUNjIN; arc=fail smtp.client-ip=40.107.93.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="4yxUNjIN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P0bp+PNjCJTIcSEUmOQ3QdMci30sohq9NdKCW4vxR6BWiu7c3t4GafoGN3n3V/oQXt62ekwo823Vr9cE1ihYemS7vRyevWHHk7NZ0mA/pE2M9/S1O1wTPVlx1XTGU5h8Y2yX7xjJ9ZOh4QHeCs/BpdpYv47/26YqLYs3FucT+fSkNyQ2AkQy75DYxmaJOnkshcp7EAwTA4iE8Uh4HpxB5pn8Vuez0s/PiOKJ1RzSfDfmNSEM/vjVfkpDq9ls8VlABJxYs5UqDxutycaxfba26F/6k/FHkF2QuJaLcnyOYZMg3UxGjHZ7Tfk5dzkg5mB5b3Wtk+gQ87qMJwCHZdiQTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eJ/o4oj5UCXqzjCPtq/JIOGs7rsNLkJFTKQqL++VXWU=; b=Geh0PbsI0qhaTBVqAvFFAUUFFGxN0AuCphAbVKRiC2Gmz+ITyhcIQSwti4OYB9OKyS78tI3l33kTTkEqmho2zbNdWqpTz1W7PI0OgfDDxid8o8TUECxg0Ls4P0oxqQrIZn6CBtfDK+jkTzVAZoGolRZSQ2AZVg/k+yeoMJ4QxsTZoGdQrZQNihT20rogL+GY43Mm9kVwfb8Gt0rN2JsAsKs++7DApT7IaRDbfLS8Qg67ytRvVfMcaIMg2WLmhJtyqE/tGGUgouABv6QD/YiXKlqEWdpfVpCtTSlH5Ja1ROb+KWSam6sV1SDbiev4xrmQBuUffwCnmYsxYdzTEgdwXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lunn.ch smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJ/o4oj5UCXqzjCPtq/JIOGs7rsNLkJFTKQqL++VXWU=; b=4yxUNjINSwG/TpuocnuYifU2Bc/SxOFbOmK4MD+c73LBMSmRZg975Tl9c7CHxZJ2ncHvI7PSu8AR65TiV8LxfQaTHcBvFzxqMmY0fiw5r3KHbodBiXdlqnjJd11dYU33eXxGdOJB63xRSvXFOeWHnfGhGK5XMYZPKUc7iRYK3dw= Received: from BN9PR03CA0083.namprd03.prod.outlook.com (2603:10b6:408:fc::28) by DM6PR12MB4234.namprd12.prod.outlook.com (2603:10b6:5:213::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.31; Mon, 7 Apr 2025 22:51:48 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:408:fc:cafe::2c) by BN9PR03CA0083.outlook.office365.com (2603:10b6:408:fc::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.32 via Frontend Transport; Mon, 7 Apr 2025 22:51:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8606.22 via Frontend Transport; Mon, 7 Apr 2025 22:51:47 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Apr 2025 17:51:44 -0500 From: Shannon Nelson To: , , , , , , , , CC: Shannon Nelson Subject: [PATCH net 3/6] pds_core: handle unsupported PDS_CORE_CMD_FW_CONTROL result Date: Mon, 7 Apr 2025 15:51:10 -0700 Message-ID: <20250407225113.51850-4-shannon.nelson@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250407225113.51850-1-shannon.nelson@amd.com> References: <20250407225113.51850-1-shannon.nelson@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|DM6PR12MB4234:EE_ X-MS-Office365-Filtering-Correlation-Id: 620b2a69-8256-40ce-425d-08dd7626c718 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?NB0P8scCMjiheBHQepq2AnkidhmbX2Z70Fzc3rGBAgB2d+lvkqGHoAQGoK4Z?= =?us-ascii?Q?XccboIrMZ2U2kmwBgTFgFtRfyM1+tzaexut8Et47xLQZ7/mIednV7nmp+6v6?= =?us-ascii?Q?0POtGOME5yQAcVnQCMHqYI2732Da+SVVrB9k5k47eIx/v4SrvdR+0NNk/q7A?= =?us-ascii?Q?FhD9XZdSwtzhd+dfuKEN+5DGCLWe9sxs43Bx5N1bVs7Mz3vE5MSkGfEhwIg7?= =?us-ascii?Q?v/B90klTcnetQAX8wqD8njUYHVX4lCS6gAXnm+stXtAntxxMpQUl4Vr5aO8J?= =?us-ascii?Q?0Txwyf4psEgi0nG/iRxw7zr4LUsvtnaMhk7GIMCSBOVBVqaTdd5vAPTT8k2y?= =?us-ascii?Q?zRvbs+LjXFYGnfAz88v0zxiOrSnU2Q6ad/91g8xekddEC4yhln7nPmPULs34?= =?us-ascii?Q?2i6II/5LNcIWQ/PQt6IPE1qOlZvfZloIZMy9PC3o/FREhoE89TQzwR6Ghqav?= =?us-ascii?Q?kQkfYpwUkVwsXvNwXcCUIXdp/GwaKFtkIu1Y53VoJ7i0sYzJcTYSk+PoFnih?= =?us-ascii?Q?XG93FSE+f2NjPihJijOpSws4UhOGubbD9pYk0ePChzIRUbwtNSfiYylxj2az?= =?us-ascii?Q?g4XuIvSh7QTrqdsBIunXwoCZP/nDcLDOdPPbWB1E0FT7+YmhuSBXCRY3BEKu?= =?us-ascii?Q?0+Zi+u48Zu5mfHRfS68lIRwZZM1OkKiBTUwq6IpUn3GFcjaaYlxXVEI+CjrF?= =?us-ascii?Q?ugHDxlu6usHKb2yhKBfXjaF7a29IvU5AY+fBuCjzVufgT2TKMGo1t92N8cp4?= =?us-ascii?Q?bTroiNo6/2OHr8Dj12h7cK7awU8+epXQTRlXTgTeoBbCvTaQWuxn2sEi949k?= =?us-ascii?Q?Pd8EFm1y73KxEzm/EisZXfnhaCV5wDOJFHpOzFHVDvMwLpu0oTt3q6dji3Y+?= =?us-ascii?Q?w9gMpcEO4b2cmPYpMuefShSCkbX39TJIoEd2iK8bmQaOk0e27LLNdBLf3Lvs?= =?us-ascii?Q?Qjik+S0KMMdCbwXogM+0ebV0XROZHnT8P1tyjT2lD8kelkqUB1Jgj8qeWNan?= =?us-ascii?Q?Tw3QFERQAPhYM1znJMB2dP/tixdoRRVQ/isfk/U1dEUmHFKYbt3lIJeSjJHS?= =?us-ascii?Q?mFotjlpL/Ye9ZCjP8u/s12FAkqsWK5Z7PG095LZpWNzX127JnJHQkeB1KBlh?= =?us-ascii?Q?WrTyNmJhn068Pv/zdZvwYw1cI1Tl+JfPktmG1NQefRFVrUypYnIEp0Mc96y7?= =?us-ascii?Q?LDBq2BOA+3omdqYQF1NGKkS4CqrczV6p7LyBAyP2jTNxjrenQ8YgWsBfGUVq?= =?us-ascii?Q?tX45qb82J/2NHDqElU5mul1WUgq1p1gssNMDxcbH4mP7gh8dpOdWkazG7vZ4?= =?us-ascii?Q?FcQFzb4KFWXAlyB8zjD/RsPYgGy730SuiZtNZRY7faTAT6+PPd6BTswAAxCe?= =?us-ascii?Q?28rM1jIc1ukm3xjWLbXfSX9t4LuImMq8YrkIGFPYk/5FSsJCMHt1Iz4rnNZM?= =?us-ascii?Q?QnJnTaNAHZ5HAgBB6P8cnjiMwx+zqns6isc+mpLquxARtC6SluzBQMX0qgU9?= =?us-ascii?Q?z6/la7lvqk3Ttcc=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 22:51:47.7100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 620b2a69-8256-40ce-425d-08dd7626c718 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4234 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Brett Creeley If the FW doesn't support the PDS_CORE_CMD_FW_CONTROL command the driver might at the least print garbage and at the worst crash when the user runs the "devlink dev info" devlink command. This happens because the stack variable fw_list is not 0 initialized which results in fw_list.num_fw_slots being a garbage value from the stack. Then the driver tries to access fw_list.fw_names[i] with i >=3D ARRAY_SIZE and runs off the end of the array. Fix this by initializing the fw_list and adding an ARRAY_SIZE limiter to the loop, and by not failing completely if the devcmd fails because other useful information is printed via devlink dev info even if the devcmd fails. Fixes: 45d76f492938 ("pds_core: set up device and adminq") Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/net/ethernet/amd/pds_core/devlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethe= rnet/amd/pds_core/devlink.c index c5c787df61a4..d8dc39da4161 100644 --- a/drivers/net/ethernet/amd/pds_core/devlink.c +++ b/drivers/net/ethernet/amd/pds_core/devlink.c @@ -105,7 +105,7 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink= _info_req *req, .fw_control.opcode =3D PDS_CORE_CMD_FW_CONTROL, .fw_control.oper =3D PDS_CORE_FW_GET_LIST, }; - struct pds_core_fw_list_info fw_list; + struct pds_core_fw_list_info fw_list =3D {}; struct pdsc *pdsc =3D devlink_priv(dl); union pds_core_dev_comp comp; char buf[32]; @@ -118,8 +118,6 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink= _info_req *req, if (!err) memcpy_fromio(&fw_list, pdsc->cmd_regs->data, sizeof(fw_list)); mutex_unlock(&pdsc->devcmd_lock); - if (err && err !=3D -EIO) - return err; =20 listlen =3D min(fw_list.num_fw_slots, ARRAY_SIZE(fw_list.fw_names)); for (i =3D 0; i < listlen; i++) { --=20 2.17.1 From nobody Sun Feb 8 09:02:25 2026 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597BC22AE7B; Mon, 7 Apr 2025 22:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066315; cv=fail; b=SQ2YvsaBnNOjGxX4aNJAHSkTQga73EW3DKZm06Z5LvAoSlpnK0YnrifzYTReNiYOGDMT5NZ5IkCPOO87wrvmmtUyKAiUV1zcKEjz2p9KPwC056Pqo56bkvk5xrdRcIlVI6dZB41doreamG2qUh2QVdumrUIH1qPBcosr1WPBjkM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066315; c=relaxed/simple; bh=pZbI/4YJylErd0w6TGelL8k+PtRH3T7lwa0rUHoiYQI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Nf2I6Bi+nb06Sywq0OjncgNCQklvy0u3U641yS8/Y0TznCD5eTb24l+37f6Cf3sswagTHR+5tXh5+crmHYbgaOFL+SC353kBFkAsvSyTdAAWIVX9Zgr5KIEuLKqtR9j8q/Ygmey1w3MWnNRRl4E9x4xuvHWd4WaM7xPg7g76fr4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=oY+dduaX; arc=fail smtp.client-ip=40.107.220.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="oY+dduaX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J+swI6828aIuYDIE1bEbKsnGl1CXo5bCSD0RLRckdJGTfxVk9EIZt0SL/SuW0rivFX55rm3w8K9OLWPxU4zVUpHFLa0w3kjMyivJ+DXgz2hhRURQXC8F1CSQ+kreOGsPwuUoxDhi2eF0kuo4UjZJL7TC+bV4Gcaa7NiMYwB/f1unz658Vp7gkucTNTTsx/+6xqWZRHPlLu+t+e3qcc3rVPNxXKjv/ZN+5rqeZ9kBRZ7g8SS6OvSQHGoAU0bnScPOoYF1Qzo4dcLU8HE+yVRnybrpfYvPIGRKA9pme1AOkZlV1N2ZqKhLXUTo2wz2iqK+gvaYLqpEmiNgK1+zoRP1Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BnrzTjB4K6XYZkB2M+DX+g6nOXwovoKNNpIRMr4ms74=; b=Q0OlHTYIoMYkD1Pn6ZJqgKPoQsgbhaPzYsL/wr9dvO2s2hRKaBk7VHFqF3A9vmoAMhQO+036RGG8f6g79HqIcT5vJexs0vo4QwaZTAkfL85H2is+eF0ciSm5wc9dnyO4TadNZ0ayTrwaEaJYtvGq7tYcwmHvIPg68mRb0LJaNJDAu6poZU/8Eq9DbG9Fdc7RrfQ0II19cjxpQTzFf/iwAB8454z/6S94PUxX7EgFH/P/FNMG3VQiKZsjSgGJ8352zuPEvcmvg6UccpQApyUZCLyimHbB2Sbp8/BR3fiIyMPisRXCCvzl1uwad/DnXVcXoJ7BEnTCik2PooVQ1DcPcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lunn.ch smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnrzTjB4K6XYZkB2M+DX+g6nOXwovoKNNpIRMr4ms74=; b=oY+dduaXFV91CZYWU6fCu4e6qnA8K37YKOnZCUSRhNs3yWwCCRpDVY6obKrpxSp5hPniT0gAe4DG8bOrXC32cfdoVQl2aeg/qaWVnGVIrQ10s3NzfUC2gLPp+HkDChaB9ZpcSBvWhx6vCqFDskg4vCcByDy/EeA1DUqjUPt6/1s= Received: from BN9PR03CA0076.namprd03.prod.outlook.com (2603:10b6:408:fc::21) by PH8PR12MB6841.namprd12.prod.outlook.com (2603:10b6:510:1c8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.31; Mon, 7 Apr 2025 22:51:48 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:408:fc:cafe::4f) by BN9PR03CA0076.outlook.office365.com (2603:10b6:408:fc::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.34 via Frontend Transport; Mon, 7 Apr 2025 22:51:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8606.22 via Frontend Transport; Mon, 7 Apr 2025 22:51:48 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Apr 2025 17:51:45 -0500 From: Shannon Nelson To: , , , , , , , , CC: Shannon Nelson Subject: [PATCH net 4/6] pds_core: Remove unnecessary check in pds_client_adminq_cmd() Date: Mon, 7 Apr 2025 15:51:11 -0700 Message-ID: <20250407225113.51850-5-shannon.nelson@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250407225113.51850-1-shannon.nelson@amd.com> References: <20250407225113.51850-1-shannon.nelson@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|PH8PR12MB6841:EE_ X-MS-Office365-Filtering-Correlation-Id: 688a63da-8b37-4d0c-652c-08dd7626c77c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fCNhu9RrzQ0j5keMRp7qMMJeHWAIe/EiyqRwiTyUCbL4DKQiSlJn6/IJWyYa?= =?us-ascii?Q?YTvBC3zy7H1bKtyhQ1w7xkapXdHvZ0X2Rxd3nrNcZ7VYLdDexJ03zOczysb/?= =?us-ascii?Q?0Y4pMP9AwsqyBfCwVIcM6Y41sGRTvHHTY2AMeJ45NlwRjKfYD7oDlFXIUppA?= =?us-ascii?Q?6ozz/J8cfInQ6nQ+DXxtiUkMsNywt91hCvwIq1F8CY0ibX3mLDY+IFprnGvz?= =?us-ascii?Q?scEOMUFDx92OuW/cNPghGcHoT4MsALTVBFduvWlaId1NscYebjYjjK6fN79O?= =?us-ascii?Q?EECtLtO8oHby22awTKDb1QNh9ZLpGgh9j01QoPTSKcJtIqYI8jyHVGTfH3mp?= =?us-ascii?Q?UM1WFl80ukl76sqLzD52WyflCRUa+Eq3gEcBJ5gQgFFR8pVhl5ERCsy23VCJ?= =?us-ascii?Q?Iwgvt1IpQBbIUoQ4UiXDdzoLJ7PBB3RmoDPyY79MtyLgP/ReFh+PWuAOMc09?= =?us-ascii?Q?78rsUWNWPqlUMV8S4oqr9tVkFxRSI25ziQVZkRS2vmO9cN2sMqBMhjOg8dF2?= =?us-ascii?Q?6YceYIL2nufx0GLK/JcEf6ne4/dBy5lMISOlVXLHfv24TVtS5Cn17JRrM7K9?= =?us-ascii?Q?w4U7Nnn030iGcj4dGGwUFfcZ5OmF370/i6z7EtP9p5hvP7UirDfkfaDDAgwL?= =?us-ascii?Q?f0yH/wY0l/JWP1kLZzHWIlKPX8P1B+mYhj/1dKnEeq3AfMJuOa4VNVz7tTbD?= =?us-ascii?Q?4h5HBmRY2ImRidhQWnr66w4Q1w/UDgssZ2UoQ+xgT5ZEISgZ70UhuLJdcuQ7?= =?us-ascii?Q?mXZ43X/msjyLkBRKNO57RN1f36U/WsoPr2fYBBa30u9I23c5LPQSKogqEHD+?= =?us-ascii?Q?wDr9jEmpV/5XVN9kEbVOZ+fa6AZ9qDl2bRQmnPB8hrKvdPV/W6QvaflK1RpX?= =?us-ascii?Q?TE1ovchMgyn1hFtv51ZgAvHp3tS7veMuR5uyFGMgrWZgrqgHXHSCsvxQc4pW?= =?us-ascii?Q?3EYftr7613jadEOe+4hHwM1jdnziQsdA5kgNI3NgZKhLZogIUR8wbPyDfj/9?= =?us-ascii?Q?TIFOCVDYTLXpUNtLu+umNz/ICXtZxP8ypMkkM6+DB95xq8S5VT/vHZ+TNMZr?= =?us-ascii?Q?+zDHzYwpL+q/39AhEHnoPBWqlXLrWlm6FOhGHpjgBzVL6+0waa2CEcXvepyP?= =?us-ascii?Q?oHz+vMO0wMNNjFxUDVw8amV6O6eiId0S/YBhSMmjqyHSwBXbELR5sX1S7yos?= =?us-ascii?Q?cdyPEn2tmuJraIIaymOE/RkCxhm3jgSICLHVbPnbnvzXDlPByFXReF2gweta?= =?us-ascii?Q?pZiCgHb3pULqehRRjYR2LZPqlFdrHy9VSjVqkoK95RvLmQOXRNLySn68Vgvx?= =?us-ascii?Q?5MaWL7tMzZuEVcNGbShAuQ0cDvfesWMuVNKQNOkdb5e56npTU/Yj7DbiLs9p?= =?us-ascii?Q?romnVJf6gHc+BOuYO5U8iAtBLpP91wfdFJ3GbBDLhdm1FqcjtC78naj9rwKC?= =?us-ascii?Q?jDfw7Is6qeyRGS/CXrc42mP8j2PNt2vbEXEugvCd1jWtnxbCNnl0btuZ4UkG?= =?us-ascii?Q?elb5ZMX06O3onBk/izolZS+iVqltopOMvIM4?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 22:51:48.3662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 688a63da-8b37-4d0c-652c-08dd7626c77c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6841 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Brett Creeley When the pds_core driver was first created there were some race conditions around using the adminq, especially for client drivers. To reduce the possibility of a race condition there's a check against pf->state in pds_client_adminq_cmd(). This is problematic for a couple of reasons: 1. The PDSC_S_INITING_DRIVER bit is set during probe, but not cleared until after everything in probe is complete, which includes creating the auxiliary devices. For pds_fwctl this means it can't make any adminq commands until after pds_core's probe is complete even though the adminq is fully up by the time pds_fwctl's auxiliary device is created. 2. The race conditions around using the adminq have been fixed and this path is already protected against client drivers calling pds_client_adminq_cmd() if the adminq isn't ready, i.e. see pdsc_adminq_post() -> pdsc_adminq_inc_if_up(). Fix this by removing the pf->state check in pds_client_adminq_cmd() because invalid accesses to pds_core's adminq is already handled by pdsc_adminq_post()->pdsc_adminq_inc_if_up(). Fixes: 10659034c622 ("pds_core: add the aux client API") Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson Reviewed-by: Simon Horman --- drivers/net/ethernet/amd/pds_core/auxbus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/amd/pds_core/auxbus.c b/drivers/net/ether= net/amd/pds_core/auxbus.c index eeb72b1809ea..c9aac27883a3 100644 --- a/drivers/net/ethernet/amd/pds_core/auxbus.c +++ b/drivers/net/ethernet/amd/pds_core/auxbus.c @@ -107,9 +107,6 @@ int pds_client_adminq_cmd(struct pds_auxiliary_dev *pad= ev, dev_dbg(pf->dev, "%s: %s opcode %d\n", __func__, dev_name(&padev->aux_dev.dev), req->opcode); =20 - if (pf->state) - return -ENXIO; - /* Wrap the client's request */ cmd.client_request.opcode =3D PDS_AQ_CMD_CLIENT_CMD; cmd.client_request.client_id =3D cpu_to_le16(padev->client_id); --=20 2.17.1 From nobody Sun Feb 8 09:02:25 2026 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2087.outbound.protection.outlook.com [40.107.243.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF4F222ACDC; Mon, 7 Apr 2025 22:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.87 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066315; cv=fail; b=Go6gnpjxccUyz7FHWqBekPyFtLBIr3ldGYKtBUdT12ckUK0z9peCmlm8+B9JZNnws5Aaxc/6w3HpZ0TIqyUx5J7FDmLbToD6IgI+v3EFONh1lttCFtmFtvDBkQ9TlnL9Rja4/P9aBIF2TFpWt5V2RvpBOkReJKoXRSRv4NLnpS8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066315; c=relaxed/simple; bh=KTUTN4rC+085EaXJJjaYdpFiIVXk23GrFrYtJkQJWaQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aVTFjjFKvTgSlAitE0e2R18fRq2QZp0AXeuhoLKc9cja3EpCv3WPb0ah4vJg67wi9pDlUC6hFSnmbeiPc7UigQyTdFB3YdQkfR65IMgJr7MC+yjiFKZGGPJ9VJlXPuzNfNvlLRUTifehEm0kT49mWycikfKbQjigg5sgVwxc6Fk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=d5+N0btA; arc=fail smtp.client-ip=40.107.243.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="d5+N0btA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w68wFb273lrgt9G68G3RXKQO/6gNXEAdLD9QzKUdwpMEuFbbXL7Z9WmfzApPRbi/jTPoEFEcrr9vy0gzwLHLO8WVo37tWkleqcQyMygQztghOt/f6blyIJBeA1htzLTb096UE6jml9xn2BoKw5+ERIkHvg2tT5LiMeN/JgaQ7yaaiRbyIO7Z0AWH26SkWLkrPKe2Mc444uBeO/vSMUKuLPoS3pyo7Gfjs1HXYVWEbnV3Ad00rhHxj8gUd8eybduMYq0HnGpYaiKnfLkx4I4gZAAMp0VcSJtQOdjsDckqapLHdtisYY0m8y8AfY10ducsqYiHbwr3y9DoWnLHTkmfxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A3LbZWzWQyUkC85Yl2tj6sDaOCdP5KAPH5dPI3+/cmk=; b=uRgH3zNNryGKvqdh74arWZs7zHoJYzfYl5FT3/l5ivTEiKNPNW5RjyuKv7ygvvILJDpUZgosJMFtbCzTcQ6UWD2bgzFlEjZHJaraK72Sg070MUpc5iEl+9fMB/ibzf61mdwX/V74DQyx4eiG8u0jUgqiLe2XgYtLfN0iN8LO+hm9iveVZcYRNC/szsdZK38U0GQ4leWn26e9jZnmILMGjXrPu4+GU6SmJDXh2Sr6hGthoNo7MaMdpx/ikZSz13OPDoUyzH+2zUeERXEZ18NAICGnjYda0ciHXb/S+sabVCaW/sOrQmWJ8TYgOWPqO0L588LFqWGghfphCEV2ja+BDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lunn.ch smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A3LbZWzWQyUkC85Yl2tj6sDaOCdP5KAPH5dPI3+/cmk=; b=d5+N0btAFfVBf497w03Ob+T61Ow4L/iaBPno4IKbOtpmDgAjuuddpmFMVio122ac2vT8H8ZCL4M3dxYwsETz3DzyQ1IRMXH9Tl5bFOIWLAWiKUjoLNR+T0NzuhvT2YDF1Doyy5q8nlFxa1Ga+nikHImpeEJ34GZUF6TihjQepsE= Received: from BN9PR03CA0083.namprd03.prod.outlook.com (2603:10b6:408:fc::28) by DS7PR12MB6143.namprd12.prod.outlook.com (2603:10b6:8:99::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Mon, 7 Apr 2025 22:51:49 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:408:fc:cafe::2c) by BN9PR03CA0083.outlook.office365.com (2603:10b6:408:fc::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.32 via Frontend Transport; Mon, 7 Apr 2025 22:51:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8606.22 via Frontend Transport; Mon, 7 Apr 2025 22:51:49 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Apr 2025 17:51:46 -0500 From: Shannon Nelson To: , , , , , , , , CC: Shannon Nelson Subject: [PATCH net 5/6] pds_core: smaller adminq poll starting interval Date: Mon, 7 Apr 2025 15:51:12 -0700 Message-ID: <20250407225113.51850-6-shannon.nelson@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250407225113.51850-1-shannon.nelson@amd.com> References: <20250407225113.51850-1-shannon.nelson@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|DS7PR12MB6143:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f647d00-d987-4309-4b72-08dd7626c804 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BIJL+sWlZ9kp+6soGRvt6O+cjIhN1hwE6mCmPKJnNG/QwAG+fhMTe7eayEOE?= =?us-ascii?Q?csO1eOXnklsmxu3VCCfJ+BR+0GTFi/VSz0wDs9TX71XccMy1/2R0YEytiFYz?= =?us-ascii?Q?moIGithhOVCJT62TJJSyPNQMwDKX42bF2WUodw/qfgX2htNWn6ccMAo0hrWu?= =?us-ascii?Q?Q6snIqPQ50hsfB6GVpqIctDCzY2+A0tThEa2pg3xpcE1HdpGtFs+ErcWhFfM?= =?us-ascii?Q?MIEkloNv2LPkDKZUzcKGhBCev7p5GQ6kmda/8a2oyeOZ7IZRv0OZkvgNprfZ?= =?us-ascii?Q?nU8v1ZSyR0nKRRwnceL02eh+cLVtq0dbnpwI1gDCuSg3t0Ni4vPkJxeVao5/?= =?us-ascii?Q?qVyCVw0bOqlHpERMQ8hNoVFyUuklCZKpdExXKnEeNLS7wKqaqWFXXM/NVSMP?= =?us-ascii?Q?zFu4SsaxJrQOBS9oZXUXUWdyNBh5xHsj0SvyPlQJHHME9iAKKkC/U4ZGEOgf?= =?us-ascii?Q?RRitKKnhMgV5K8O5c+0AVeaOOmQF7PeARFWHyzDH4Mdq1F0IScfoHK/yQEn7?= =?us-ascii?Q?WYn/JkB/Bg+ujWTSKEFC6wt36QS3ryYhQ5fk5vLdVC3bIBntutIy7ifSV6Rm?= =?us-ascii?Q?PvI+O6nkjvNZGLsCx3LW7LUHvNOZDXpeOCMW87QWVkHHKw4KYJ7tF1Wxht3h?= =?us-ascii?Q?G5GkmnOm2r7H9OS2No52HNK19iPohx0KufWnMcQbSwdTMfMM8Kj4eYRwh215?= =?us-ascii?Q?OOgC5ovsf56V6xIw4xZ4oaLXJdHLUwFvYH8vFjznQrDrUsWf6NNeBN+1Mi5c?= =?us-ascii?Q?t1gYnakO/1KSqV6jLCy78vmBxsblHguF2UMjLf4TecHaBd4LSZmUxxtzvN7V?= =?us-ascii?Q?WL06P2CE4/oj7vzetaogjki3Y9zqQvqT4yQNIMTTBsUSDYQCZ/Y6K97kHazO?= =?us-ascii?Q?CU0lpxfQVLvIpxeaOMcp83kcJZjSzwUsUYms2/CMnj9olxUmvIhvbWlacfqT?= =?us-ascii?Q?7XoJhkgLMLURboVRHpncAOT4em64hzj0W9oP3UfDDDjx4SIt/6L3InwB6+wQ?= =?us-ascii?Q?d/Dn+YKcN5pyQtijnLxKwRDXy+hG9cXVkAWJC0vdisGPrWrd9p46m7m/oWLe?= =?us-ascii?Q?6HuLBeMZr1tWEv8hcU/0MbMsKOxe5eLHFjRdUp5T69O2NARAdrXUN5mYyvY3?= =?us-ascii?Q?ijUv9DQCLQ99h6TjDfoJrLHocxZ7YHUSWqs8WaS2kdyLIAd0p8s/eesrfEYU?= =?us-ascii?Q?gdqG6HakcN4hoW1UjCrtX/tobGq3kwCBNw8XxF2c+IkA+aoTWdKwbHblqGTd?= =?us-ascii?Q?90bkc9DHwj57ek5N6fPmfQ4S6HDqgtk445efL5GTSaC2gZa+OsPY1KQhmAWN?= =?us-ascii?Q?PUNEEXmdd6b9MFxGW1ZQS5UCtsTsbuQmArcB5OgIewB9BDMsm1+y4o0vx2uE?= =?us-ascii?Q?pnxphS8Bv4gGtrubRrbqku1F4KNxZpKbjOZJniy1IZTmOkrVh3Q8YmPrOvV0?= =?us-ascii?Q?N6G40Ow/Lc1Xk7YqT9kg3iOnngX4Ek9kM/TBXBLbBsp4TVsvtnnk6g=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 22:51:49.2569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f647d00-d987-4309-4b72-08dd7626c804 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6143 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Shorten the adminq poll starting interval in order to speed up the transaction response time. Fixes: 01ba61b55b20 ("pds_core: Add adminq processing and commands") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/amd/pds_core/adminq.c | 4 ++-- include/linux/pds/pds_adminq.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/amd/pds_core/adminq.c b/drivers/net/ether= net/amd/pds_core/adminq.c index c83a0a80d533..2e840112efea 100644 --- a/drivers/net/ethernet/amd/pds_core/adminq.c +++ b/drivers/net/ethernet/amd/pds_core/adminq.c @@ -235,7 +235,7 @@ int pdsc_adminq_post(struct pdsc *pdsc, .wait_completion =3D COMPLETION_INITIALIZER_ONSTACK(wc.wait_completion), }; - unsigned long poll_interval =3D 1; + unsigned long poll_interval =3D 200; unsigned long poll_jiffies; unsigned long time_limit; unsigned long time_start; @@ -261,7 +261,7 @@ int pdsc_adminq_post(struct pdsc *pdsc, time_limit =3D time_start + HZ * pdsc->devcmd_timeout; do { /* Timeslice the actual wait to catch IO errors etc early */ - poll_jiffies =3D msecs_to_jiffies(poll_interval); + poll_jiffies =3D usecs_to_jiffies(poll_interval); remaining =3D wait_for_completion_timeout(&wc.wait_completion, poll_jiffies); if (remaining) diff --git a/include/linux/pds/pds_adminq.h b/include/linux/pds/pds_adminq.h index 339156113fa5..40ff0ec2b879 100644 --- a/include/linux/pds/pds_adminq.h +++ b/include/linux/pds/pds_adminq.h @@ -4,7 +4,7 @@ #ifndef _PDS_CORE_ADMINQ_H_ #define _PDS_CORE_ADMINQ_H_ =20 -#define PDSC_ADMINQ_MAX_POLL_INTERVAL 256 +#define PDSC_ADMINQ_MAX_POLL_INTERVAL 256000 /* usecs */ =20 enum pds_core_adminq_flags { PDS_AQ_FLAG_FASTPOLL =3D BIT(1), /* completion poll at 1ms */ --=20 2.17.1 From nobody Sun Feb 8 09:02:25 2026 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2081.outbound.protection.outlook.com [40.107.236.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27C522B5A1; Mon, 7 Apr 2025 22:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066317; cv=fail; b=q259ZwO2NJ0jGBmzpes4q69/93WWXuPlsxzC1s+ulBSQC3Rb5gkrZcOJx6mRNKePTSlDaDPAYzWESrxQaLEQ2WLSDMEWfo6TGw3f1NX8sZ5Q0/RLyW+SFCUv8V2ivsN0YoxYuM3ECRA91T8GxdWTP05U2KXfjHWDfYHkNNGeWfE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744066317; c=relaxed/simple; bh=iFYXoUdF3W8taZedS1xk0FCTEBI6CgwrfHDv9Cl3jF0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sibo47cZxh0tLbvVkLfVBg+Bhq1JH1yksoYgWsO8BKWRG45GWsEOcVvz4hkhBCOYn5oI5UGHOXt2FWL1emR0MVnO5g0l2AAlQj2v/DJGp4oNTStrmNsRnFEw2IHlapqnxf0pYpZkM/HBrWbHSaql7UIgNK/1uZXvbC4K9LtfA5g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=QMRlWxcJ; arc=fail smtp.client-ip=40.107.236.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="QMRlWxcJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MRo2LCj9KdLrpHrIue0zfu2nEvR9Q0exv+vjlxglTMqST+YQTd+itZYfKK+lxiW58MPPCsIZCX9NLjAhq4dzYBsjwmlkmR9a+kRwcs5FZidzxmI+VWwSLeMEwJhHf4Lg/4QJrvRwh8Exj12daoV9BoVqMGvJABi1qw5mxm22GVGQPK2nNDN5Y2pptSvOF/gQv86X2CnbC+KNBam6qZI/+0UHekz53wVKHVKm1RuRSVlVKYJ4hOMUJJ2JcVPAxqGTev0m7BqrJUrw37v37Zd5TyQHFrxMT4CGEslY7+zlMtuHSZCjtDG1RjyX3HVDBTEdXHogw9/YI0N0G4Ig4vz6UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DbRfsUR9h/xdmIkJ+voPFjdBSud2yuK2UaqSyKlCj4o=; b=ZtmGfYJIrDELDAi4q3P1m2IOonYLyhVAWeYj0IPPAPGTJPyLMEJwb67Y+V3qPxQip+SgZIGEIGyjWPTA4X88Bo3siyu5fIdbSQKFWW30L9UHdqpTmLq9IjxdJyDZpLmTCOQHBfAy0adod376wmbF1TFryC7h7jC13bCAC0Oww9IUS9ZBgOe7avp5lZCoBT/EHsSGETinH/AH45Ho+Kl/TpSe0r98nh7EhvifRf20poc6ZyCDgSmI3mHFmk2Nc9JU9X/5kHvjZ3TvpyqOmhTVcRs91538OerV1reOdJM5Ctx5yZWjgUxG7oKLCQUuRgyugP8x/rgzi7Htpy0QZAvnRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lunn.ch smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DbRfsUR9h/xdmIkJ+voPFjdBSud2yuK2UaqSyKlCj4o=; b=QMRlWxcJv11zryobZpH3TvPop/Sd2BSIhBgPFReOFqhZHdW+AdcaTESl9bsCEalK0jcVlBzN9gXaom262F7ynQJlK/f9IcgVpIcNK7XfiqzeEp81YxhlGZRsPDEm+eYU8VnwJXF6zZsRh8JbLSzOUml0mJjwY8tQVgmmPe9NUak= Received: from BN9PR03CA0078.namprd03.prod.outlook.com (2603:10b6:408:fc::23) by IA0PPFD7DCFAC03.namprd12.prod.outlook.com (2603:10b6:20f:fc04::be7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.27; Mon, 7 Apr 2025 22:51:50 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:408:fc:cafe::32) by BN9PR03CA0078.outlook.office365.com (2603:10b6:408:fc::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.34 via Frontend Transport; Mon, 7 Apr 2025 22:51:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8606.22 via Frontend Transport; Mon, 7 Apr 2025 22:51:50 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Apr 2025 17:51:47 -0500 From: Shannon Nelson To: , , , , , , , , CC: Shannon Nelson Subject: [PATCH net 6/6] pds_core: make wait_context part of q_info Date: Mon, 7 Apr 2025 15:51:13 -0700 Message-ID: <20250407225113.51850-7-shannon.nelson@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250407225113.51850-1-shannon.nelson@amd.com> References: <20250407225113.51850-1-shannon.nelson@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|IA0PPFD7DCFAC03:EE_ X-MS-Office365-Filtering-Correlation-Id: c4abb84b-e0b6-4ed6-a801-08dd7626c882 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IWURqKbR7cAZNhHybQH6YmpjVt5h+fMi2LgmQz49E/B8OKW45WZHP4Ih469a?= =?us-ascii?Q?Fh+StW3p65XTb4pqyjly1I/DUPyV5JPSoGNfjru2VAgBFo2XZ0reSsGFr+oh?= =?us-ascii?Q?ZALfCIY/Z71YkC+MiLDzRhWXwUIvHbL8B5u3axV9vesMENGQQRzusHc1gSgG?= =?us-ascii?Q?rDgIrN/DMabJChT4GQJI9f4kjeirgdyvT6nwU47RW7DIPfaI94AhdfKRVBps?= =?us-ascii?Q?/Pix7wNG7w/IhH90KL4aOBZM3Gr0M/MODw7KptraSACV+UFUlhxtFwo5RKe1?= =?us-ascii?Q?YA13vzfVBpoS7rdp/UGure40TbTpycfU5/+tHbZfTtB36wItFFfeaqihkLYN?= =?us-ascii?Q?tS2LAk6e4A28ccr3IZ2bkXVS75HBSXFHCiR7L0SBp3Wv71R0Mv3GGOBHWhjJ?= =?us-ascii?Q?gQrg/Y42upuUqvzTdGK3o3mHjn0IzbkcowWX3jFeTvppIlNozzx365NSkz1R?= =?us-ascii?Q?a6znBnkVk+b37pJdnrPgUNHvXB6dGY6SLKk54LZBVx4VpAdvs1MV+5e5hEnc?= =?us-ascii?Q?SDvtRsFWv9pdFCC1F0TqGlCzgrtwLk+FPLQwSXSXd5pTpBlBsKBvNYTgrT46?= =?us-ascii?Q?haljfmAI0fL+MULQKGZeibCo+/UEyL4pXxOtNrLv2g6YROQVyS8KjTbiqrO2?= =?us-ascii?Q?OE4ZlCtTyOPF7E1HaU8qS8ec8yTcBRywh7kGhydRBKeGe6SW5w27y6Q9W1EF?= =?us-ascii?Q?Dvh+s4AzGDcTFcbCLWN8nNBMP7aXY68P0hgx3xNzolKrsHz0DoxjfTE5PidV?= =?us-ascii?Q?gEEPTauSMSDDcptUTm0wXnFlK9RdXnX6a18bdPL/sREQqrmz0G4O5AQ7Qmpd?= =?us-ascii?Q?L2209sxF7y+jvMbVNqiahY9mfSnMjhxdjeb6lnx70LwYbssZKgdF9164TY3Y?= =?us-ascii?Q?VEWT5bMaFmcU2hP1o786724KAZPpRYRbVq6vlp1SVfwUtFor8Ofp0tJxL93t?= =?us-ascii?Q?dKCcUPmDCdsb3aiGp4icAtg7JSHJh05/JfGQ7uDoA41YdrNUDS5ss0dVOLzm?= =?us-ascii?Q?qRr4zcfsyIeAeuB/0UKktfX/q8rEA0GLdORdagQaNOdSkakrSK9lKuIG97Q6?= =?us-ascii?Q?BXLuP4rL+1ACHtrOUhnNfrY0LmhED7uLks8kqaQI34HtXs8eGxwwM4z5LGIt?= =?us-ascii?Q?FfsFUbD/qMkKE6xomKOVqFVRss7qq9c8QkcWjc97tXIoEyx10G+K4zWX4AZ6?= =?us-ascii?Q?8w9nAW6mQ+oJTBLCebjukcuGiW3hwoi+Can1ZH9iSG94SzfYRhlU1RR6jEI1?= =?us-ascii?Q?WaANhmmKXw2KI8HuwRPNjxLLeBYmCeeXIu9lDyelgAdN4nzXqVkzTvddNg5f?= =?us-ascii?Q?2vfX9wuJkUuTN8kcvODYuJCzpjmh0KW7LurZB0ulZF28kWseeoNy7NZSbyzX?= =?us-ascii?Q?V8Bo32Dv8yv9b611t7VlO8b7FQLf+bO+eDvBLkiApVJfB5jWebJ+dxRVWT4w?= =?us-ascii?Q?/2bKhiY4Ik+XosY5BdziDob2qGRZUsz7NiDAbRzSsoxm0bqneOkmURFKtvLU?= =?us-ascii?Q?YNd1bPARAxHt1qg=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 22:51:50.0850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4abb84b-e0b6-4ed6-a801-08dd7626c882 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPFD7DCFAC03 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make the wait_context a full part of the q_info struct rather than a stack variable that goes away after pdsc_adminq_post() is done so that the context is still available after the wait loop has given up. There was a case where a slow development firmware caused the adminq request to time out, but then later the FW finally finished the request and sent the interrupt. The handler tried to complete_all() the completion context that had been created on the stack in pdsc_adminq_post() but no longer existed. This caused bad pointer usage, kernel crashes, and much wailing and gnashing of teeth. Fixes: 01ba61b55b20 ("pds_core: Add adminq processing and commands") Signed-off-by: Shannon Nelson Reviewed-by: Simon Horman --- drivers/net/ethernet/amd/pds_core/adminq.c | 23 +++++++--------------- drivers/net/ethernet/amd/pds_core/core.h | 7 ++++++- 2 files changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/amd/pds_core/adminq.c b/drivers/net/ether= net/amd/pds_core/adminq.c index 2e840112efea..86a6371e5821 100644 --- a/drivers/net/ethernet/amd/pds_core/adminq.c +++ b/drivers/net/ethernet/amd/pds_core/adminq.c @@ -5,11 +5,6 @@ =20 #include "core.h" =20 -struct pdsc_wait_context { - struct pdsc_qcq *qcq; - struct completion wait_completion; -}; - static int pdsc_process_notifyq(struct pdsc_qcq *qcq) { union pds_core_notifyq_comp *comp; @@ -112,7 +107,7 @@ void pdsc_process_adminq(struct pdsc_qcq *qcq) /* Copy out the completion data */ memcpy(q_info->dest, comp, sizeof(*comp)); =20 - complete_all(&q_info->wc->wait_completion); + complete_all(&q_info->wc.wait_completion); =20 if (cq->tail_idx =3D=3D cq->num_descs - 1) cq->done_color =3D !cq->done_color; @@ -162,8 +157,7 @@ irqreturn_t pdsc_adminq_isr(int irq, void *data) static int __pdsc_adminq_post(struct pdsc *pdsc, struct pdsc_qcq *qcq, union pds_core_adminq_cmd *cmd, - union pds_core_adminq_comp *comp, - struct pdsc_wait_context *wc) + union pds_core_adminq_comp *comp) { struct pdsc_queue *q =3D &qcq->q; struct pdsc_q_info *q_info; @@ -205,7 +199,6 @@ static int __pdsc_adminq_post(struct pdsc *pdsc, /* Post the request */ index =3D q->head_idx; q_info =3D &q->info[index]; - q_info->wc =3D wc; q_info->dest =3D comp; memcpy(q_info->desc, cmd, sizeof(*cmd)); =20 @@ -231,11 +224,8 @@ int pdsc_adminq_post(struct pdsc *pdsc, union pds_core_adminq_comp *comp, bool fast_poll) { - struct pdsc_wait_context wc =3D { - .wait_completion =3D - COMPLETION_INITIALIZER_ONSTACK(wc.wait_completion), - }; unsigned long poll_interval =3D 200; + struct pdsc_wait_context *wc; unsigned long poll_jiffies; unsigned long time_limit; unsigned long time_start; @@ -250,19 +240,20 @@ int pdsc_adminq_post(struct pdsc *pdsc, return -ENXIO; } =20 - wc.qcq =3D &pdsc->adminqcq; - index =3D __pdsc_adminq_post(pdsc, &pdsc->adminqcq, cmd, comp, &wc); + index =3D __pdsc_adminq_post(pdsc, &pdsc->adminqcq, cmd, comp); if (index < 0) { err =3D index; goto err_out; } =20 + wc =3D &pdsc->adminqcq.q.info[index].wc; + wc->wait_completion =3D COMPLETION_INITIALIZER_ONSTACK(wc->wait_completio= n); time_start =3D jiffies; time_limit =3D time_start + HZ * pdsc->devcmd_timeout; do { /* Timeslice the actual wait to catch IO errors etc early */ poll_jiffies =3D usecs_to_jiffies(poll_interval); - remaining =3D wait_for_completion_timeout(&wc.wait_completion, + remaining =3D wait_for_completion_timeout(&wc->wait_completion, poll_jiffies); if (remaining) break; diff --git a/drivers/net/ethernet/amd/pds_core/core.h b/drivers/net/etherne= t/amd/pds_core/core.h index 199473112c29..84fd814d7904 100644 --- a/drivers/net/ethernet/amd/pds_core/core.h +++ b/drivers/net/ethernet/amd/pds_core/core.h @@ -88,6 +88,11 @@ struct pdsc_buf_info { u32 len; }; =20 +struct pdsc_wait_context { + struct pdsc_qcq *qcq; + struct completion wait_completion; +}; + struct pdsc_q_info { union { void *desc; @@ -96,7 +101,7 @@ struct pdsc_q_info { unsigned int bytes; unsigned int nbufs; struct pdsc_buf_info bufs[PDS_CORE_MAX_FRAGS]; - struct pdsc_wait_context *wc; + struct pdsc_wait_context wc; void *dest; }; =20 --=20 2.17.1