From nobody Sun Feb 8 04:17:43 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77411EE032; Mon, 7 Apr 2025 19:36:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744054581; cv=none; b=N0Cl6uzgZlD+eK7Kc24XK75S7R6x11/2AfAR9a41DbQWZAmFmD7WODAL0Yk7kqZZrU4KMgiKP+o8XcCBsRnmlAmm7MaKd358hF2RGqEudCDg4nyYguPHQ3ZzqY886mqr02DlxFSY4HxkixbTehzafjyVUJCJLzzrdeAqBSfvEUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744054581; c=relaxed/simple; bh=jwsoeajWLSOPJcvIZix/A6b+favE2I6KfWiuZwzI3kE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=VbJha0HYgnMkmycd2nbE7ds0eZZl8DPF/uyyvWNHeSXjzzZaOCvZBH373tk0SjoolcDx19PhTnvCqPAM2Iyy4tzO+ybJQOu98YcLKnWm4Zp6J8TAGipQErgSh2vf0nxp1nL+n20bBxQfkBgVekqDqBSjIR8LSGdQ8qYUJ7zxolQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RXU2pOad; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RXU2pOad" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-391342fc1f6so4242949f8f.1; Mon, 07 Apr 2025 12:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744054578; x=1744659378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EL5d6O3loKPdrSygpYmikEvuM6mYmpkHUhAOsZ8Nu3Q=; b=RXU2pOadSFP8WSSMWPV3qegJE+L3/tA1CeaQPxnRRRwy3j11y5LIDUlvGF7Owt2BOC IvgCWSqCsxrE5IKMzN6sTbKLRICrYaeGhgeMcaTEwyMIfUO0dtHeuiesmEptNeMCkCrY vI7GSizuK6ZehtqMsq+ETdui9mgS958awmRGjx+JsMujhjVaQVvJGfD6PmxXzinOrhyn MxWXR1MKoJs4Sj2xgm1rETz/uaTVE2yTFR09C9OvdflbhCZc4GbPWu+ONvUV1nfNwiL7 A0R6dwrOkueUPR3pTpgRLcaofDdkzBGLeUfL9DMI7DOZM0itBIL/qW+5K4ku9BbBL7zH NVMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744054578; x=1744659378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EL5d6O3loKPdrSygpYmikEvuM6mYmpkHUhAOsZ8Nu3Q=; b=k0lnBxTO0DrWhq4Ev40OD+w8bGXVRuoQu9ZYpASCOKAhSTiXTrWDhVs5Zx7Y8E47Ym hkL0gxT7cOEUA8sRy3LGSiBfxfiYlY8zb6ISD5wLHnbiiu3Sn+rr7qT3wCC4vN/5MrAh QHDjKl+W/gUKyF/QCnBhe/9utdaGj3XwMGsz1lG1XYPu564LBcZZwQyoGy74BLl2vXLo Wy+7pRtZ+r5u/qczqaA7Z/QHZxMllAj+kh+8kNd2gFT+lJ8MTg7nuJdky30W5aouCNCd dEq6JTLBA/+QxFe022kWlBGB5PMsX77vrF1GqrE35KBt32IBCHu26Q7QBW9e6C4nJPxd APwQ== X-Forwarded-Encrypted: i=1; AJvYcCV51wxENoVOhDPmEcqbiCuyIl8QX+7LehAXm8cN/R/4BQlLqzcMupoVNo8lKv4fqODS75IFr9yZP+d24L9/@vger.kernel.org, AJvYcCXUqI0SbCLy+dsksKMyIHZYfl4snRAtmDJJN7DxfhApsEGt7dvxv+JbPcpU4Hcy7dfhcuHikLs1rA+0@vger.kernel.org X-Gm-Message-State: AOJu0YyRXjElydL8FuhO0W3w9thr5FVPocOIUFuB0lBS/9gt1YoZxwhU yozYxPnpc2iyxdb527CnNBDI4mJgWancK5UK5cd8NpdO7n2gFUQ8 X-Gm-Gg: ASbGncuCbMDmjMJaWnGmSJyicS9xcfIi1nG78BkMkafZaOzG83sL7vFRVJIRKJAOG/k BSfIh68Z/4HCa7WUn7G5LMf2H4Te2TlCnWTlg/vZ9nulL1U2Lh5eXICkGpSK+2dXizFcNfk+Zz8 Kzu3EZPy23fmhWMReq1Q/4N/0QeITV8jXSpUgNQqI2qIJyQ+MOcv3QlTtOCnonZriLcD7ZFTIaa 2UBruhbXDLINCK70ihedcD3gWCVztYYC1CUMMcjFRhi3KKf0XWHKPeMLa+GA95Y0kmnGRK4kbgf pf+JfLn7kzJbCpvx36PqlDdurZOZviz5qYViw5GWY3AJjfStbJ6sEY5oDKUXfGQ= X-Google-Smtp-Source: AGHT+IH+JhJvbMe23o1gz6gaJ3o8ZSOAaySMAqbNHxTH1p6tkmuvf3PpSmaArnx/ItinZRECN4gtpg== X-Received: by 2002:a5d:5847:0:b0:391:38a5:efa with SMTP id ffacd0b85a97d-39d0de28728mr10386777f8f.23.1744054577987; Mon, 07 Apr 2025 12:36:17 -0700 (PDT) Received: from localhost.localdomain ([37.162.191.164]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d62fsm13122812f8f.79.2025.04.07.12.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 12:36:17 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antoni Pokusinski Subject: [PATCH 1/3] rtc: pcf85063: create pcf85063_i2c_probe Date: Mon, 7 Apr 2025 21:35:19 +0200 Message-Id: <20250407193521.634807-2-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250407193521.634807-1-apokusinski01@gmail.com> References: <20250407193521.634807-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Move the i2c-specific code from pcf85063_probe to the newly created function. This is a preparation for introducing the support for RV8063 real-time clock with SPI interface. Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-pcf85063.c | 97 +++++++++++++++++++++++++++----------- 1 file changed, 70 insertions(+), 27 deletions(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 4fa5c4ecdd5a..03dfc58f4cd7 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -559,12 +559,12 @@ static const struct pcf85063_config config_rv8263 =3D= { .force_cap_7000 =3D 1, }; =20 -static int pcf85063_probe(struct i2c_client *client) +static int pcf85063_probe(struct device *dev, struct regmap *regmap, int i= rq, + const struct pcf85063_config *config) { struct pcf85063 *pcf85063; unsigned int tmp; int err; - const struct pcf85063_config *config; struct nvmem_config nvmem_cfg =3D { .name =3D "pcf85063_nvram", .reg_read =3D pcf85063_nvmem_read, @@ -573,28 +573,22 @@ static int pcf85063_probe(struct i2c_client *client) .size =3D 1, }; =20 - dev_dbg(&client->dev, "%s\n", __func__); + dev_dbg(dev, "%s\n", __func__); =20 - pcf85063 =3D devm_kzalloc(&client->dev, sizeof(struct pcf85063), + pcf85063 =3D devm_kzalloc(dev, sizeof(struct pcf85063), GFP_KERNEL); if (!pcf85063) return -ENOMEM; =20 - config =3D i2c_get_match_data(client); - if (!config) - return -ENODEV; - - pcf85063->regmap =3D devm_regmap_init_i2c(client, &config->regmap); - if (IS_ERR(pcf85063->regmap)) - return PTR_ERR(pcf85063->regmap); + pcf85063->regmap =3D regmap; =20 - i2c_set_clientdata(client, pcf85063); + dev_set_drvdata(dev, pcf85063); =20 err =3D regmap_read(pcf85063->regmap, PCF85063_REG_SC, &tmp); if (err) - return dev_err_probe(&client->dev, err, "RTC chip is not present\n"); + return dev_err_probe(dev, err, "RTC chip is not present\n"); =20 - pcf85063->rtc =3D devm_rtc_allocate_device(&client->dev); + pcf85063->rtc =3D devm_rtc_allocate_device(dev); if (IS_ERR(pcf85063->rtc)) return PTR_ERR(pcf85063->rtc); =20 @@ -605,19 +599,17 @@ static int pcf85063_probe(struct i2c_client *client) * of the registers after the automatic power-on reset... */ if (tmp & PCF85063_REG_SC_OS) { - dev_warn(&client->dev, - "POR issue detected, sending a SW reset\n"); + dev_warn(dev, "POR issue detected, sending a SW reset\n"); err =3D regmap_write(pcf85063->regmap, PCF85063_REG_CTRL1, PCF85063_REG_CTRL1_SWR); if (err < 0) - dev_warn(&client->dev, - "SW reset failed, trying to continue\n"); + dev_warn(dev, "SW reset failed, trying to continue\n"); } =20 - err =3D pcf85063_load_capacitance(pcf85063, client->dev.of_node, + err =3D pcf85063_load_capacitance(pcf85063, dev->of_node, config->force_cap_7000 ? 7000 : 0); if (err < 0) - dev_warn(&client->dev, "failed to set xtal load capacitance: %d", + dev_warn(dev, "failed to set xtal load capacitance: %d", err); =20 pcf85063->rtc->ops =3D &pcf85063_rtc_ops; @@ -627,13 +619,13 @@ static int pcf85063_probe(struct i2c_client *client) clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, pcf85063->rtc->features); clear_bit(RTC_FEATURE_ALARM, pcf85063->rtc->features); =20 - if (config->has_alarms && client->irq > 0) { + if (config->has_alarms && irq > 0) { unsigned long irqflags =3D IRQF_TRIGGER_LOW; =20 - if (dev_fwnode(&client->dev)) + if (dev_fwnode(dev)) irqflags =3D 0; =20 - err =3D devm_request_threaded_irq(&client->dev, client->irq, + err =3D devm_request_threaded_irq(dev, irq, NULL, pcf85063_rtc_handle_irq, irqflags | IRQF_ONESHOT, "pcf85063", pcf85063); @@ -642,8 +634,8 @@ static int pcf85063_probe(struct i2c_client *client) "unable to request IRQ, alarms disabled\n"); } else { set_bit(RTC_FEATURE_ALARM, pcf85063->rtc->features); - device_init_wakeup(&client->dev, true); - err =3D dev_pm_set_wake_irq(&client->dev, client->irq); + device_init_wakeup(dev, true); + err =3D dev_pm_set_wake_irq(dev, irq); if (err) dev_err(&pcf85063->rtc->dev, "failed to enable irq wake\n"); @@ -661,6 +653,8 @@ static int pcf85063_probe(struct i2c_client *client) return devm_rtc_register_device(pcf85063->rtc); } =20 +#if IS_ENABLED(CONFIG_I2C) + static const struct i2c_device_id pcf85063_ids[] =3D { { "pca85073a", .driver_data =3D (kernel_ulong_t)&config_pcf85063a }, { "pcf85063", .driver_data =3D (kernel_ulong_t)&config_pcf85063 }, @@ -683,16 +677,65 @@ static const struct of_device_id pcf85063_of_match[] = =3D { MODULE_DEVICE_TABLE(of, pcf85063_of_match); #endif =20 +static int pcf85063_i2c_probe(struct i2c_client *client) +{ + const struct pcf85063_config *config; + struct regmap *regmap; + + config =3D i2c_get_match_data(client); + if (!config) + return -ENODEV; + + regmap =3D devm_regmap_init_i2c(client, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + return pcf85063_probe(&client->dev, regmap, client->irq, config); +} + static struct i2c_driver pcf85063_driver =3D { .driver =3D { .name =3D "rtc-pcf85063", .of_match_table =3D of_match_ptr(pcf85063_of_match), }, - .probe =3D pcf85063_probe, + .probe =3D pcf85063_i2c_probe, .id_table =3D pcf85063_ids, }; =20 -module_i2c_driver(pcf85063_driver); +static int pcf85063_register_driver(void) +{ + return i2c_add_driver(&pcf85063_driver); +} + +static void pcf85063_unregister_driver(void) +{ + i2c_del_driver(&pcf85063_driver); +} + +#else + +static int pcf85063_register_driver(void) +{ + return 0; +} + +static void pcf85063_unregister_driver(void) +{ +} + +#endif /* IS_ENABLED(CONFIG_I2C) */ + +static int __init pcf85063_init(void) +{ + return pcf85063_register_driver(); +} +module_init(pcf85063_init); + +static void __exit pcf85063_exit(void) +{ + pcf85063_unregister_driver(); +} +module_exit(pcf85063_exit); =20 MODULE_AUTHOR("S=C3=B8ren Andersen "); MODULE_DESCRIPTION("PCF85063 RTC driver"); --=20 2.25.1 From nobody Sun Feb 8 04:17:43 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BBEC21ADB2; Mon, 7 Apr 2025 19:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744054585; cv=none; b=stKIN4TKh6aHCBnJpWkztdvhXMJXTpguyUNIwXRDvbn8Ll7sVeZQGvu+wWt/6+FhjAslUu9tNWUpPcuW++RsNeJPAr3emUtcol71JsN/0N1dwcFokd+eqoVU85e02MceW5cNbN+my7rg1pollWmwOImQVJLeQ3THq8keyI7FQFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744054585; c=relaxed/simple; bh=ms+tYdR53053E43YyII93QJlp+tohqyqFRMZhXt0p6E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ZijMFE3R4u5rsETydhmQhDlDYhEWw0bE6ymhCa/3qsU9eTQq4yQ6N5NmFg1BW+zTx71M2u4P/dcrqPnSBGSXzdq/WYHWIrLgsfn9WGi9ZNfLOVE120v697mdXNEIueCVLreqDxvSuBpb1LHW3T53lpoYNHdrWGolMT5+X7TEQ4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=igq33PqE; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="igq33PqE" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so45720235e9.2; Mon, 07 Apr 2025 12:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744054581; x=1744659381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hlHmBNOkxmZPTNxQJVMiMMe6Xd3Ab4qQY+iYtGL1uvM=; b=igq33PqE4waWoJ234w7LsPniSZuEX6F3W1g2F8eNRhTryRjeFsWIQsv4k4Rk52pzx1 0RcOuKfHUvakeuXmk+6SeDrIdtvdszkFp1gkYx1wwtZgnE4ENrWDhZHWuDOJemNkgVu2 Rvc7qXb1Lcwi+ZKpa8O8bWkhb5hHMdlJkHB6ecvwlL0cMPkUGc3JuUJD5ZwhG6FXmOJz Xw+wJwj+PfsNva2plv7g/YNaA+h0wr27s96lHYv97OyG43prr+DnkHg+hX9Ss4EfB5cc b6y76azOEiF/JBbMBMRkmlcORWk/VgAhqZos1Leb7k502ovuWDenfWH//+3TWkA17icS miAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744054581; x=1744659381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hlHmBNOkxmZPTNxQJVMiMMe6Xd3Ab4qQY+iYtGL1uvM=; b=hPrCkJkbkel3z3VWOb33JxoXxaaaHIRaLadgGxoDSeKnDIodCZAHPfJdz6pe99mXkA 7epODzhjlANDieqUvoRXrIUP+rUckqjT09lmy8vMUgqORbjub6NkAVOK2zoxv96yQA1W 4UIxXoQWaYHYOQzaLB1MWvY3ffU5JVyYYv4yUhj0U9rGnyQbslOfbut61RBOi12Iitf6 Va3/EOj5okaD144ZskaSfSi4AP4jdkNCoY1FQe9gmK5sx20eMys/RUHKVFwDqgRNeRQO wZ4Dq9ErOFd253fNLYfMMMO0sbuZAXSKFCsRlf2AbYpXX+EzearPJmgAjb3e4fagu3x/ 0MVg== X-Forwarded-Encrypted: i=1; AJvYcCXVYqh7TnUx62xPToHkMXNcQGJO5mr90Y0cnGKUSsDApuF7xqAuAI2udw9Jh4DgDAbPE1ubAxtufiW6@vger.kernel.org, AJvYcCXwnhSddYwYr1uMds9dIpAk6fCSSUZZ4izfawITOCepN+Mn9S1PyQUbKCVdEOMXMFemjN32nM5Qx848rzC8@vger.kernel.org X-Gm-Message-State: AOJu0YzQVdtqpYXZ69sQyjBdZJGFwlyS82gqROBMudRc2w8jBGXjHVIr xImo3DtJ/sfk3bPLH1j3ETtQLCfuK6/zxR6sE+Oc0nTZRwXWMMi+FwKTQdTKQQ8= X-Gm-Gg: ASbGncumX1/CqVAx3kD0GRtwS9Bd6FKIHQ07J9ZQ+Lw0bcR7/ZP78o/FrNNvMHr7agJ HzbRrbnO9xXeymUFUMXiJfjvhaWOEP4AXuETDTmIn13vktg+uF7YfaYEff25fnfalWSlBnbI8bZ Ws+ASdgJmvYSNaKBZTYE2nkdsAWxHOdr6rJdeR3qY2gJJJf47DR473WsTKMkn7KZif1iJTp8teC PS3jog5/RazbpKved0FiGeuI/L20xzVx8+ful9tCT8LT7ecNF1CNk51Q5j5vXr1wquuXS1WiMml fQ2xoROjcxHDQnUAnN23+j4nXhsp0pKsL6V4F6/D6DoTAaQ9I186C39zz7qVPz8= X-Google-Smtp-Source: AGHT+IH1hs11OVfqQQEd0Puk52b90jTdsp1VBSkd909WOM5UwPPvjaCV4xVQzK5kVLzuDliSWuvy8A== X-Received: by 2002:a05:6000:2482:b0:39a:c9ed:8657 with SMTP id ffacd0b85a97d-39d0de17e4dmr10920173f8f.17.1744054581141; Mon, 07 Apr 2025 12:36:21 -0700 (PDT) Received: from localhost.localdomain ([37.162.191.164]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d62fsm13122812f8f.79.2025.04.07.12.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 12:36:20 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antoni Pokusinski Subject: [PATCH 2/3] rtc: pcf85063: add support for RV8063 Date: Mon, 7 Apr 2025 21:35:20 +0200 Message-Id: <20250407193521.634807-3-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250407193521.634807-1-apokusinski01@gmail.com> References: <20250407193521.634807-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Microcrystal RV8063 is a real-time clock with SPI interface. Its functionality is very similar to the RV8263 rtc. Signed-off-by: Antoni Pokusinski --- drivers/rtc/Kconfig | 21 ++++++----- drivers/rtc/rtc-pcf85063.c | 74 +++++++++++++++++++++++++++++++++++++- 2 files changed, 85 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 838bdc138ffe..1b9be96faa13 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -483,15 +483,6 @@ config RTC_DRV_PCF8523 This driver can also be built as a module. If so, the module will be called rtc-pcf8523. =20 -config RTC_DRV_PCF85063 - tristate "NXP PCF85063" - select REGMAP_I2C - help - If you say yes here you get support for the PCF85063 RTC chip - - This driver can also be built as a module. If so, the module - will be called rtc-pcf85063. - config RTC_DRV_PCF85363 tristate "NXP PCF85363" select REGMAP_I2C @@ -971,6 +962,18 @@ config RTC_DRV_PCF2127 This driver can also be built as a module. If so, the module will be called rtc-pcf2127. =20 +config RTC_DRV_PCF85063 + tristate "NXP PCF85063" + depends on RTC_I2C_AND_SPI + select REGMAP_I2C if I2C + select REGMAP_SPI if SPI_MASTER + help + If you say yes here you get support for the PCF85063 and RV8063 + RTC chips. + + This driver can also be built as a module. If so, the module + will be called rtc-pcf85063. + config RTC_DRV_RV3029C2 tristate "Micro Crystal RV3029/3049" depends on RTC_I2C_AND_SPI diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 03dfc58f4cd7..512933479dd5 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -17,6 +17,7 @@ #include #include #include +#include =20 /* * Information for this driver was pulled from the following datasheets. @@ -29,6 +30,9 @@ * * https://www.microcrystal.com/fileadmin/Media/Products/RTC/App.Manual/R= V-8263-C7_App-Manual.pdf * RV8263 -- Rev. 1.0 =E2=80=94 January 2019 + * + * https://www.microcrystal.com/fileadmin/Media/Products/RTC/App.Manual/R= V-8063-C7_App-Manual.pdf + * RV8063 -- Rev. 1.1 - October 2018 */ =20 #define PCF85063_REG_CTRL1 0x00 /* status */ @@ -559,6 +563,18 @@ static const struct pcf85063_config config_rv8263 =3D { .force_cap_7000 =3D 1, }; =20 +static const struct pcf85063_config config_rv8063 =3D { + .regmap =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D 0x11, + .read_flag_mask =3D BIT(7) | BIT(5), + .write_flag_mask =3D BIT(5), + }, + .has_alarms =3D 1, + .force_cap_7000 =3D 1, +}; + static int pcf85063_probe(struct device *dev, struct regmap *regmap, int i= rq, const struct pcf85063_config *config) { @@ -725,14 +741,69 @@ static void pcf85063_unregister_driver(void) =20 #endif /* IS_ENABLED(CONFIG_I2C) */ =20 +#if IS_ENABLED(CONFIG_SPI_MASTER) + +static int rv8063_probe(struct spi_device *spi) +{ + const struct pcf85063_config *config =3D &config_rv8063; + struct regmap *regmap; + + regmap =3D devm_regmap_init_spi(spi, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + return pcf85063_probe(&spi->dev, regmap, spi->irq, config); +} + +static struct spi_driver rv8063_driver =3D { + .driver =3D { + .name =3D "rv8063", + }, + .probe =3D rv8063_probe, +}; + +static int __init rv8063_register_driver(void) +{ + return spi_register_driver(&rv8063_driver); +} + +static void __exit rv8063_unregister_driver(void) +{ + spi_unregister_driver(&rv8063_driver); +} + +#else + +static int __init rv8063_register_driver(void) +{ + return 0; +} + +static void __exit rv8063_unregister_driver(void) +{ +} + +#endif /* IS_ENABLED(CONFIG_SPI_MASTER) */ + static int __init pcf85063_init(void) { - return pcf85063_register_driver(); + int ret; + + ret =3D pcf85063_register_driver(); + if (ret) + return ret; + + ret =3D rv8063_register_driver(); + if (ret) + pcf85063_unregister_driver(); + + return ret; } module_init(pcf85063_init); =20 static void __exit pcf85063_exit(void) { + rv8063_unregister_driver(); pcf85063_unregister_driver(); } module_exit(pcf85063_exit); @@ -740,3 +811,4 @@ module_exit(pcf85063_exit); MODULE_AUTHOR("S=C3=B8ren Andersen "); MODULE_DESCRIPTION("PCF85063 RTC driver"); MODULE_LICENSE("GPL"); +MODULE_ALIAS("spi:rv8063"); --=20 2.25.1 From nobody Sun Feb 8 04:17:43 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A309215F43; Mon, 7 Apr 2025 19:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744054587; cv=none; b=lshggLO6MWFctSD4vqmZSvDU9LCkULD5Qq/t3/BKYZzH5gZlmceYJuaQXsblfRXdzxXJQlsM+zsCiI84N0rk4jjWbFKBE79DU7eMo1tdo91aA2Yf/10a3MMAkWu6FA7WQpmib3HHXvTzNATTbu/6kgxaAAd1xF4Jg7/PKEv4gMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744054587; c=relaxed/simple; bh=nStIjfSZeL0zt9W7+iaa9CoiY9nOZsfvqJhLH6Sl5g4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pj+Y8ibsWZzO/4CePW1kFlgGiCIA5jezrzwPsZLcWVGgB05z8A3PxRN9ufrTieevevWgMfasgbkpn4pXQpB6OVjDrwqXb79s4O59tdA7aUiu7bqJz36kbFiElSXu8PASnflWiFWKx0OJvls9h7UnlJgwvF2uld5DVYKlpANSYY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TisXWwTs; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TisXWwTs" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso2729569f8f.1; Mon, 07 Apr 2025 12:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744054584; x=1744659384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hSPr9sZkytyi6HYm3brTb7NWt25n9J2i6nUGBqwMRe0=; b=TisXWwTsZER2+t3Fz0C3+MLh6b0gjcyVu1u/96LycHVavndkl9CLh+HLt4XrnCBpb1 NCTQnl9dBQGKM2y++PR6Oeu1rBuxzYaGwwkekD6YohdzLg5LUjjzFNTy51tTz2DC1kBs 7WV+8FkDv6zs7AUr7UDHy+9LSbX0ZIck0CfbCf1U7PhXvlwdi/FRFoqCeT1vAvCnxWew b3qxD1GwL0pYMQ+kQRm9Ijy3I8B04+P8JrPcmeMnR4u7FjGesBMXpWdebilxd1JUuDLa aaJbZFU5txVy5TBZj7AIwxE57QCM3mc9KvAEnolXo6GzOwEwVaFidSgpWRwd/Sl32nHm r2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744054584; x=1744659384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hSPr9sZkytyi6HYm3brTb7NWt25n9J2i6nUGBqwMRe0=; b=hcM+P1woM9hXC4BVcwe72owRwooIdrRWE0uN3AGoAr95WeVTA8btWNCJbHiZacEjpC IDr7QZIRHbREXtektv2HT8kX7hjYwmQYGD6lPAx/n5W3kj/TEn6tm6WGFEDzoGcTA7yb nH12xyKhc2hLsabrFsvSvpIUjwGEagkCAD0m6XOodIruq5t4r3uJ9YGsHRj+mvtPMX04 aIJSpmqtm5sfDvqb8FWDktg2Oy6ffbRW149NQUnsOWi/Z3qbcKwT46qmPOGp11nr3QRs Z5kLnIaUmeYch5tr8Tj+rDCnfmgqds1MVneBme12SCgkaAarUubDtfW4oTjeOtpGsenS HQVA== X-Forwarded-Encrypted: i=1; AJvYcCVTchuXNhmCl7ROzwWNPYGTVX+K/03aY/XihvR0Fc3JZ9u6jNjvjZRe6U9n+cUx0rvMzz2BEVhvBF209INT@vger.kernel.org, AJvYcCXOFnnsGJmp9E0DV0REhj7HWU+GqsshBrhdNyagJ1PGiAtx/9igyUiz1ajDInAbXoag2YRq0MlPb3PP@vger.kernel.org X-Gm-Message-State: AOJu0YyOXFqg8EqBtfmqTCT4qmKnPxV4v5CaFwERYOoi669BrTQNV1/P MQq+AFoNcvvQmmZT/9omlhgsNQi/UmJVSnLRgGnNKDDl2B9h9+Ef X-Gm-Gg: ASbGncvStiRLRYeLVf9QXbw0gdZyfczOEqJw0CrqWtlCjOewkPdkWzCH0ffz7L5Geo+ 93mM0zTHZTWxP+NfdM0o+1VUN4uCvGMHvGVw6LFSKgHJPVPXBRXy2s+s8Uoa9H586jXXeuIZM0i 0jmFkx93eKWaRo+UwhY8lrWPhHFfYjbhhnr4iic2PF2u8+kGCrKxNGM+z7zKr8K0IQ5qlNX8mmL Fj7YnoWNOzfd8izSB6NawE+tekOGo4N/78OroZexA4a17Nwt0F4XIMV0cx0zMrTsDrP+KlhWDah BeXIiPzHDtC1dBdCwEITe7U+k0UTYAiPRhgRBp7czelb45b3A86eakjPSh4sWD4= X-Google-Smtp-Source: AGHT+IEUiomeOiUOHrr0DKhbBbz9XR6SWezAxykM7N11ouMT90URl7Xtcfm6e8GrZrN3ZF04M6mwbg== X-Received: by 2002:a5d:584f:0:b0:391:65c:1b05 with SMTP id ffacd0b85a97d-39d820b0af5mr646908f8f.11.1744054584329; Mon, 07 Apr 2025 12:36:24 -0700 (PDT) Received: from localhost.localdomain ([37.162.191.164]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d62fsm13122812f8f.79.2025.04.07.12.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 12:36:24 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antoni Pokusinski Subject: [PATCH 3/3] dt-bindings: rtc: add binding for RV8063 Date: Mon, 7 Apr 2025 21:35:21 +0200 Message-Id: <20250407193521.634807-4-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250407193521.634807-1-apokusinski01@gmail.com> References: <20250407193521.634807-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Microcrystal RV8063 is a real-time clock module with SPI interface. Signed-off-by: Antoni Pokusinski --- .../devicetree/bindings/rtc/nxp,pcf85063.yaml | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Docu= mentation/devicetree/bindings/rtc/nxp,pcf85063.yaml index 2f892f8640d1..cb31c7619d66 100644 --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml @@ -12,6 +12,7 @@ maintainers: properties: compatible: enum: + - microcrystal,rv8063 - microcrystal,rv8263 - nxp,pcf85063 - nxp,pcf85063a @@ -44,7 +45,12 @@ properties: =20 wakeup-source: true =20 + spi-cs-high: true + + spi-3wire: true + allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# - $ref: rtc.yaml# - if: properties: @@ -52,6 +58,7 @@ allOf: contains: enum: - microcrystal,rv8263 + - microcrystal,rv8063 then: properties: quartz-load-femtofarads: false @@ -65,12 +72,23 @@ allOf: properties: quartz-load-femtofarads: const: 7000 + - if: + properties: + compatible: + not: + contains: + enum: + - microcrystal,rv8063 + then: + properties: + spi-cs-high: false + spi-3wire: false =20 required: - compatible - reg =20 -additionalProperties: false +unevaluatedProperties: false =20 examples: - | @@ -90,3 +108,16 @@ examples: }; }; }; + + - | + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + rtc@0 { + compatible =3D "microcrystal,rv8063"; + reg =3D <0>; + spi-cs-high; + spi-3wire; + }; + }; --=20 2.25.1