From nobody Sun Feb 8 11:22:03 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77CAD155A59; Mon, 7 Apr 2025 08:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744013516; cv=none; b=g7qbk4iPDp4iV9dhTKeb+pmeeQlGDoTP49Y6sdP5AnRmfE1EUeFuZhUiGmS02AS5c2IWqhsDFbhxfR7hj99J3Cu5swFC/oWKZmyXnA9+BWA+no/ws2v1RluU+lVANk29P5fznh7nqI8JGNJOEavrpC+/e/S2CChQwRycsiuENrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744013516; c=relaxed/simple; bh=XV8q83Q0UNgZQlHyQddxuoT/XfdRn545dZZTX5O5Ltk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Gc+kdzqhnElpbkqU1DRVT4BgDki5wjDqdiwHg+HlfQRro7eW5XUb65ZDl8dMEZIHowwO8/jZCoyF6V6gZAmli+ap5ZmhmyjJo2Ul48zydzoBSnEhT2i3Dco5cVaFJEcde3ITp0TelO4jKoSlk6XQNl+RO4b96hCCJiqH8EYZ8mQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [124.16.141.245]) by APP-01 (Coremail) with SMTP id qwCowAB3G_y3iPNnV2fUBg--.17556S2; Mon, 07 Apr 2025 16:11:39 +0800 (CST) From: Wentao Liang To: sbhatta@marvell.com, sgoutham@marvell.com, gakula@marvell.com, hkelam@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wentao Liang Subject: [PATCH v3] octeontx2-pf: Add error log forcn10k_map_unmap_rq_policer() Date: Mon, 7 Apr 2025 16:11:17 +0800 Message-ID: <20250407081118.1852-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.42.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAB3G_y3iPNnV2fUBg--.17556S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CFW8XFW3trW8ZF1rGFy7GFg_yoW8Gr4rpF 4jk34xC3ZrXrWrtan7Ja40gF15tay8J3yUGa4xA34fZ39aywnIvrn0yFWSvrWxGFZ5uFy3 tF15AFWkCF1DZrDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBj14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxkIecxEwVAFwVW8ZwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUfuciUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgsFA2fzf7Uo5AABsY Content-Type: text/plain; charset="utf-8" The cn10k_free_matchall_ipolicer() calls the cn10k_map_unmap_rq_policer() for each queue in a for loop without checking for any errors. Check the return value of the cn10k_map_unmap_rq_policer() function during each loop, and report a warning if the function fails. Signed-off-by: Wentao Liang Reviewed-by: Subbaraya Sundeep --- v3: Add failed queue number and error code to log. v2: Fix error code drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c b/drivers/n= et/ethernet/marvell/octeontx2/nic/cn10k.c index a15cc86635d6..9113a9b90002 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c @@ -353,8 +353,10 @@ int cn10k_free_matchall_ipolicer(struct otx2_nic *pfvf) =20 /* Remove RQ's policer mapping */ for (qidx =3D 0; qidx < hw->rx_queues; qidx++) - cn10k_map_unmap_rq_policer(pfvf, qidx, - hw->matchall_ipolicer, false); + rc =3D cn10k_map_unmap_rq_policer(pfvf, qidx, hw->matchall_ipolicer, fal= se); + if (rc) + dev_warn(pfvf->dev, "Failed to unmap RQ %d's policer (error %d).", + qidx, rc); =20 rc =3D cn10k_free_leaf_profile(pfvf, hw->matchall_ipolicer); =20 --=20 2.42.0.windows.2