From nobody Mon Feb 9 03:11:25 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF92D223335 for ; Mon, 7 Apr 2025 05:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744002082; cv=none; b=r66gEPd1dVA41b1T1SabZBKGgNrpeWr3m/SlE9r3ZYNP7eCGIlm8JGUsdeIAXXY7ryRd+x18qC2JTlSXxrDyzW4lj6J04tYSFHaKZpx65peRg40ieuSPez3mm5ShOy4/yEZNEo/bN0oRvCGhs6rvHexGfxqnW/XsVG4a0zB8syM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744002082; c=relaxed/simple; bh=uzrqNAXM/KeEjp8qWr6xTf3VLWW7e0MNaK/cvBjUNjU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=M2DvU42Y3CudUL1zpqms/IL8JVQmr0Ri9AwIUfRnfMFsgYdluWZDKZXgsVlQSDkNpIybQ0+ZzhU9WmIs7mzCZIBQ1GSnY474/KIQCYxvBgqvN90fOe9xBQdYnBraZsfPOGnAjnzAdE6/dlUwFCgq5wPtkp4uF6lerr5d+3aICd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cTvnBtMd; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cTvnBtMd" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2ff854a2541so3508450a91.0 for ; Sun, 06 Apr 2025 22:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744002080; x=1744606880; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=fqf5UWKI2N4Og32+0x3lkK0y6IoadYAF1NX3nVy0tDA=; b=cTvnBtMd2pCzZMYgbDbOFBMH53bcb3oZgfT1Q/FjpLlot9mZwTf4C1BmmhPx0hnAo1 FlIiD3+OfXicErPm6ayesfD5cMWAE6RJSQxon2hmd984XnVCGcjmi0WTSqmF1xDZ1DXV cI+eruNWjKbAoff6hcIBOZcrx6mnxJy9iB9Rf/rFA861IjGEN+qIJml+pVZEhEBsbRuG uL1aWTsJG+L5p7WHge2HLwMpilzFbOatmp96ZVMas+/ShIwNWvraEen9UEpTSN3+6Qis 85X6DZg9WavDPC+Fdw6j+uy1yEY783tztK2AGMOks/waC4Km/qnbyoHzhWoxHzk/yIDW wfbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744002080; x=1744606880; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fqf5UWKI2N4Og32+0x3lkK0y6IoadYAF1NX3nVy0tDA=; b=I6ZGqJH9CYR8CA1pxcxgXzc0sqhoNfEQpXmgx04vOzOxhkL/NQa+FCKjdeeNV9ck+Q TUstMkv/SGhXtlTgQVsF+84Vy1/pyuI/Dn4ZRoFoxfj9vV85weTJq31uBVDFgWsHrTB7 XhcCf5StS00y6ETfKrQYrrpPnTnoOlx19icz0K7hB6HQVyA5nGhUbF9UbBzk/uT2xtal +KOoizzckZ1mqRn1Wb/HtmlXdR4q09oGLHlDLTZ9kYRt4vzz3bZAZf23qJ6erZS0vl06 S7Ut73K3cxVJUi6Y4VzvUSn5DayALy2wywcfxJnj5ptIzyaIUWL2znhHiDQjhBUUT0KW fISQ== X-Forwarded-Encrypted: i=1; AJvYcCWUOwHRYM3DSxpc3vaM8hrm2kH0mAxIFnQn0GF6nZ857jZT0Kh7gmcBG73hZpifhGjtNAaeOtSzHEfw+UA=@vger.kernel.org X-Gm-Message-State: AOJu0YzZRzczNVVYPP5gk9Vk9eVkxub0B4XqtrT5pGOOzDVWZXjYZLBq R0G5F/Sn/eQ0m9Oc8djPCu5IKL7J05cIsgc5LLcGZwKI1q3j6pUQDdGsur2NUFP42bQEQ6EYlhY CpI+Rhg== X-Google-Smtp-Source: AGHT+IGmcAVt5EMV3QErs7No50mhGib7CCW7DyRluV6DypHgyQ+07hXaXEDAfyGrowz+s51DmBz1jIqqE+KR X-Received: from pjyp8.prod.google.com ([2002:a17:90a:e708:b0:2fc:2c9c:880]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3a4e:b0:2ff:6fc3:79c4 with SMTP id 98e67ed59e1d1-306a4b70f41mr15349365a91.27.1744002080157; Sun, 06 Apr 2025 22:01:20 -0700 (PDT) Date: Sun, 6 Apr 2025 22:00:51 -0700 In-Reply-To: <20250407050101.1389825-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250407050101.1389825-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250407050101.1389825-7-irogers@google.com> Subject: [PATCH v2 06/16] perf intel-tpebs: Reduce scope of tpebs_events_size From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Weilin Wang , James Clark , Xu Yang , John Garry , Howard Chu , Levi Yun , Dominique Martinet , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Moved to record argument computation rather than being global. Signed-off-by: Ian Rogers --- tools/perf/util/intel-tpebs.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c index 2b04deaf66ff..e3bed86145b9 100644 --- a/tools/perf/util/intel-tpebs.c +++ b/tools/perf/util/intel-tpebs.c @@ -29,7 +29,6 @@ #define PERF_DATA "-" =20 bool tpebs_recording; -static size_t tpebs_event_size; static LIST_HEAD(tpebs_results); static pthread_t tpebs_reader_thread; static struct child_process tpebs_cmd; @@ -86,15 +85,20 @@ static int get_perf_record_args(const char **record_arg= v, char buf[], static int evsel__tpebs_start_perf_record(struct evsel *evsel, int control= _fd[], int ack_fd[]) { const char **record_argv; + size_t tpebs_event_size =3D 0; int ret; char buf[32]; char cpumap_buf[50]; + struct tpebs_retire_lat *t; =20 cpu_map__snprint(evsel->evlist->core.user_requested_cpus, cpumap_buf, sizeof(cpumap_buf)); =20 scnprintf(buf, sizeof(buf), "--control=3Dfd:%d,%d", control_fd[0], ack_fd= [1]); =20 + list_for_each_entry(t, &tpebs_results, nd) + tpebs_event_size++; + record_argv =3D calloc(12 + 2 * tpebs_event_size, sizeof(char *)); if (!record_argv) return -ENOMEM; @@ -226,7 +230,6 @@ static struct tpebs_retire_lat *tpebs_retire_lat__new(s= truct evsel *evsel) return NULL; } list_add_tail(&result->nd, &tpebs_results); - tpebs_event_size++; return result; } =20 @@ -289,7 +292,7 @@ int evsel__tpebs_open(struct evsel *evsel) if (ret) return ret; =20 - if (tpebs_event_size > 0) { + if (!list_empty(&tpebs_results)) { struct pollfd pollfd =3D { .events =3D POLLIN, }; int control_fd[2], ack_fd[2], len; char ack_buf[8]; --=20 2.49.0.504.g3bcea36a83-goog