From nobody Tue Dec 16 13:46:32 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A31D225766 for ; Mon, 7 Apr 2025 07:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010662; cv=none; b=CiFKmos85qrOnLM7/MX0MTli9a/ujwHlIBhwjyCd9uYLppW6snJ5SnwkgUJwi3fJtA29+6EAWbZKkmMtKmm2P/Lvd+7u71GLe75YiMqkz/ydvyp7Jf0VemwUIZIetiFSnSdlxBzqA/K2LsxaA+QNVADhx+D+3iXo6DaxqNyiEYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010662; c=relaxed/simple; bh=fbiFpoKOI6m0aGhXZxUUnWSo+VxgAzN63GELm8iUQWE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sypjQTcsyvb1f0wKzLRzWzay6BAl1S10CDp1vdR+FzsNYKvNevoj3H1BmgWYIQWyJ5aooj7b09tGGeE09rM/2izIvEcX44JbuNkpd/yO9lM22yQngHZ2kGNFDGaUWv/cc3rXyb7ICP3/nQO86I1JPluNw2EMtiOglxRRfMqOWXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Zwfhe3/t; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Zwfhe3/t" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39c1ef4acf2so2292550f8f.0 for ; Mon, 07 Apr 2025 00:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010659; x=1744615459; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w+RnWOfN+6w+LxNXEEpLHTyc1GC0ngIrO3mLjHzJr3w=; b=Zwfhe3/t9Zy1LtS7jFTBMhXyAayqqgL+8FpiTY7cvbtcPAKE4vOHWxatv7EeMWSCZ0 gb/q6MOtYum8d9GhiZzU5mu0UAr1VJ6Ih5EBVPO8n4kswwusBXeDyMNiODdM2sSWicmP fsg6hYbweaIHULg2GCfQpCN8wWNxXyvde6nMqo3x7tqTeK2uj3a4f1VdDwdybsjRIuU/ KYhX/cvUSv9KQ2Lhp7erJ8+PphcZNUpS87TmtuY80mzQmHIMfURj+d0yCpkDAkaLRR6Z IMXEpCKRyHi+bHH7qszKxOtDBZEr8jiFjwXNf0+OSPx4YcSekFqP8dwm2ExULCGHg9cx WZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010659; x=1744615459; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w+RnWOfN+6w+LxNXEEpLHTyc1GC0ngIrO3mLjHzJr3w=; b=nheBAPeWPw8TJf3u+UIwv/2pVKz1fd8jgVoo4iBkf3x8QgkTfDkhXf1k0SOFQxpQZz FiftV/3Grr65eHqzSGuQkMTqPObiIWox6PcR6/XJ2tnUvuBbmZrHJmZhJ8l2oCUvkLCC bt9yUHrXXEH23kRSDLcrC0pwQGJqvyOr0tO9e/CbTSpoRcRpsLtW0t5MHzSc0gS64CZ2 JnTjk9x4wu6XAEXFrDBuX6VT54xic4jvUDeteOOb7SCdadvn5kqmJ+xIPayfe7eRB+DG FvMWWi3vtz4W05718+/P+4NF8qY4Fv5fsdgGXm2VesLRQoYjQzeLAlH59RWNJuCNVyfE 0lLQ== X-Gm-Message-State: AOJu0YxAVrdGtECZOUlG+VRatelHzNVxdct2SsAny/+OJGZzXXk/odFc /L3QoyPksXZmtJB4yEUtPPGhk08KS0htKJq+DWkAbe5o1GSHfO2pzB1ueynu8IVfNzkUezq5Qio ay00= X-Gm-Gg: ASbGncv00T2z6sx1/AL3/vKLiIakWa93hsQ9RoohIAxYuEZ7IMREkdt7b0/KD+oMNbk Lku2cFDhWWeJLnB4vOjLiryYieQD59YDU1QOE+JjpA1xfKcBTCNOdzAiYBpgI6lWyU0V+RqNU2x /UtHEhgMM5eGEdPYL+j+PX9rW5ynLhGGim+fitCbx3lyWB6xYIL9ZLOPMmJpW+PhM2gTzKjCkTM fAoEZIUtP5Oddr4SivR1Dwd0Dt3M2zKDoaRwrVgfGrZGqzuAGoyIuYm0ibuU+1vucCsr/wNU/Dm Rkx3XA69WKpMt0EFibt1yGelBn84pAmcN/hHmQ== X-Google-Smtp-Source: AGHT+IH0WVOZefAecKZx3yQl9YAZCMB9bf/Ht2dPIj0bpt8N2XaYatpp3frOJwP1A6hIsok1pk6i0w== X-Received: by 2002:a05:6000:4304:b0:39c:12ce:1052 with SMTP id ffacd0b85a97d-39d07bcd00dmr8845154f8f.7.1744010658797; Mon, 07 Apr 2025 00:24:18 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34bf193sm119855255e9.24.2025.04.07.00.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:24:18 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:24:13 +0200 Subject: [PATCH 1/3] mfd: sm501: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-mfd-v1-1-43f4d86d01d1@linaro.org> References: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> To: Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1375; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ZmFHKHzqAXVJSMQVt7pCMXflJb5/olwuDA9LZzUAsr0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn832g/KG/gKXEdDnf+bAangWkItxLhvzuqK6MN 2aDaYEaDsWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N9oAAKCRARpy6gFHHX ctJyD/9FEyEXjvhBJ4Wuy+oAzYXLRAq0L4z1uQ/V7dTc3/hsbCbH4O5y91ktPwLly8Q28+bgJXb ZTUOhk3fEPrsfGQJmPzp2X2dYLNFRyKbYAsx2hDRtbI8Mj1CBZn7ISNMusP9JLwG2Ptrm3siuhr W4eO9wZTo9SqXi0P+r0uECdeQGFSrefcnXihqQ09HuL+cfsqTKzI7op1v5bMB/F8yxrtpIzB78v akQCNDoiWpQvb0dE4rzWNuWlTo/95jKewIc5d070rLF/PTMawolx6q04OpcdwY313ryyEMXFhTx 0M57ec11SnzlTMyMkJ+ZhwR2BiGgLfMFAbFC7G20CUq64sKHD5PJVyL3ym6z5Sy3I8o9d4xtN3i tAsW3nYZ5I1x6VlTuL75PXp5CGTkMCmWgI0l4WZPh3rQM3xsc0zAmtI4zbEdbhhofFHH16M9sKI 0ucqhYfU/K7N3dsX5l5bXyzfHFXRIdpO/NrrEP5wR4Cb3z9NuDD31RakxMRkACCfRW4uKM0x4qo 5IEEqSq/pBH3EYGbsW8YYUwefuXkOsI8AdIir44w/b+OYVwOM/y/AoBrDMQ+3eq3sIqbTKRgm8T J2jqQq19s1M7llpziJgQ6rmB/vyNkXlZEjiZxfCIxrT/0fpV6ZYpj6ar9zIrNAcmZvGySGG6R6l JXNy8fplywgLXXw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/mfd/sm501.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 7ee293b09f62..94ad18b52b83 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -915,7 +915,8 @@ static void sm501_gpio_ensure_gpio(struct sm501_gpio_ch= ip *smchip, } } =20 -static void sm501_gpio_set(struct gpio_chip *chip, unsigned offset, int va= lue) +static int sm501_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) =20 { struct sm501_gpio_chip *smchip =3D gpiochip_get_data(chip); @@ -939,6 +940,8 @@ static void sm501_gpio_set(struct gpio_chip *chip, unsi= gned offset, int value) sm501_gpio_ensure_gpio(smchip, bit); =20 spin_unlock_irqrestore(&smgpio->lock, save); + + return 0; } =20 static int sm501_gpio_input(struct gpio_chip *chip, unsigned offset) @@ -1005,7 +1008,7 @@ static const struct gpio_chip gpio_chip_template =3D { .ngpio =3D 32, .direction_input =3D sm501_gpio_input, .direction_output =3D sm501_gpio_output, - .set =3D sm501_gpio_set, + .set_rv =3D sm501_gpio_set, .get =3D sm501_gpio_get, }; =20 --=20 2.45.2