From nobody Tue Dec 16 11:49:25 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A31D225766 for ; Mon, 7 Apr 2025 07:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010662; cv=none; b=CiFKmos85qrOnLM7/MX0MTli9a/ujwHlIBhwjyCd9uYLppW6snJ5SnwkgUJwi3fJtA29+6EAWbZKkmMtKmm2P/Lvd+7u71GLe75YiMqkz/ydvyp7Jf0VemwUIZIetiFSnSdlxBzqA/K2LsxaA+QNVADhx+D+3iXo6DaxqNyiEYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010662; c=relaxed/simple; bh=fbiFpoKOI6m0aGhXZxUUnWSo+VxgAzN63GELm8iUQWE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sypjQTcsyvb1f0wKzLRzWzay6BAl1S10CDp1vdR+FzsNYKvNevoj3H1BmgWYIQWyJ5aooj7b09tGGeE09rM/2izIvEcX44JbuNkpd/yO9lM22yQngHZ2kGNFDGaUWv/cc3rXyb7ICP3/nQO86I1JPluNw2EMtiOglxRRfMqOWXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Zwfhe3/t; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Zwfhe3/t" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39c1ef4acf2so2292550f8f.0 for ; Mon, 07 Apr 2025 00:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010659; x=1744615459; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w+RnWOfN+6w+LxNXEEpLHTyc1GC0ngIrO3mLjHzJr3w=; b=Zwfhe3/t9Zy1LtS7jFTBMhXyAayqqgL+8FpiTY7cvbtcPAKE4vOHWxatv7EeMWSCZ0 gb/q6MOtYum8d9GhiZzU5mu0UAr1VJ6Ih5EBVPO8n4kswwusBXeDyMNiODdM2sSWicmP fsg6hYbweaIHULg2GCfQpCN8wWNxXyvde6nMqo3x7tqTeK2uj3a4f1VdDwdybsjRIuU/ KYhX/cvUSv9KQ2Lhp7erJ8+PphcZNUpS87TmtuY80mzQmHIMfURj+d0yCpkDAkaLRR6Z IMXEpCKRyHi+bHH7qszKxOtDBZEr8jiFjwXNf0+OSPx4YcSekFqP8dwm2ExULCGHg9cx WZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010659; x=1744615459; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w+RnWOfN+6w+LxNXEEpLHTyc1GC0ngIrO3mLjHzJr3w=; b=nheBAPeWPw8TJf3u+UIwv/2pVKz1fd8jgVoo4iBkf3x8QgkTfDkhXf1k0SOFQxpQZz FiftV/3Grr65eHqzSGuQkMTqPObiIWox6PcR6/XJ2tnUvuBbmZrHJmZhJ8l2oCUvkLCC bt9yUHrXXEH23kRSDLcrC0pwQGJqvyOr0tO9e/CbTSpoRcRpsLtW0t5MHzSc0gS64CZ2 JnTjk9x4wu6XAEXFrDBuX6VT54xic4jvUDeteOOb7SCdadvn5kqmJ+xIPayfe7eRB+DG FvMWWi3vtz4W05718+/P+4NF8qY4Fv5fsdgGXm2VesLRQoYjQzeLAlH59RWNJuCNVyfE 0lLQ== X-Gm-Message-State: AOJu0YxAVrdGtECZOUlG+VRatelHzNVxdct2SsAny/+OJGZzXXk/odFc /L3QoyPksXZmtJB4yEUtPPGhk08KS0htKJq+DWkAbe5o1GSHfO2pzB1ueynu8IVfNzkUezq5Qio ay00= X-Gm-Gg: ASbGncv00T2z6sx1/AL3/vKLiIakWa93hsQ9RoohIAxYuEZ7IMREkdt7b0/KD+oMNbk Lku2cFDhWWeJLnB4vOjLiryYieQD59YDU1QOE+JjpA1xfKcBTCNOdzAiYBpgI6lWyU0V+RqNU2x /UtHEhgMM5eGEdPYL+j+PX9rW5ynLhGGim+fitCbx3lyWB6xYIL9ZLOPMmJpW+PhM2gTzKjCkTM fAoEZIUtP5Oddr4SivR1Dwd0Dt3M2zKDoaRwrVgfGrZGqzuAGoyIuYm0ibuU+1vucCsr/wNU/Dm Rkx3XA69WKpMt0EFibt1yGelBn84pAmcN/hHmQ== X-Google-Smtp-Source: AGHT+IH0WVOZefAecKZx3yQl9YAZCMB9bf/Ht2dPIj0bpt8N2XaYatpp3frOJwP1A6hIsok1pk6i0w== X-Received: by 2002:a05:6000:4304:b0:39c:12ce:1052 with SMTP id ffacd0b85a97d-39d07bcd00dmr8845154f8f.7.1744010658797; Mon, 07 Apr 2025 00:24:18 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34bf193sm119855255e9.24.2025.04.07.00.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:24:18 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:24:13 +0200 Subject: [PATCH 1/3] mfd: sm501: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-mfd-v1-1-43f4d86d01d1@linaro.org> References: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> To: Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1375; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ZmFHKHzqAXVJSMQVt7pCMXflJb5/olwuDA9LZzUAsr0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn832g/KG/gKXEdDnf+bAangWkItxLhvzuqK6MN 2aDaYEaDsWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N9oAAKCRARpy6gFHHX ctJyD/9FEyEXjvhBJ4Wuy+oAzYXLRAq0L4z1uQ/V7dTc3/hsbCbH4O5y91ktPwLly8Q28+bgJXb ZTUOhk3fEPrsfGQJmPzp2X2dYLNFRyKbYAsx2hDRtbI8Mj1CBZn7ISNMusP9JLwG2Ptrm3siuhr W4eO9wZTo9SqXi0P+r0uECdeQGFSrefcnXihqQ09HuL+cfsqTKzI7op1v5bMB/F8yxrtpIzB78v akQCNDoiWpQvb0dE4rzWNuWlTo/95jKewIc5d070rLF/PTMawolx6q04OpcdwY313ryyEMXFhTx 0M57ec11SnzlTMyMkJ+ZhwR2BiGgLfMFAbFC7G20CUq64sKHD5PJVyL3ym6z5Sy3I8o9d4xtN3i tAsW3nYZ5I1x6VlTuL75PXp5CGTkMCmWgI0l4WZPh3rQM3xsc0zAmtI4zbEdbhhofFHH16M9sKI 0ucqhYfU/K7N3dsX5l5bXyzfHFXRIdpO/NrrEP5wR4Cb3z9NuDD31RakxMRkACCfRW4uKM0x4qo 5IEEqSq/pBH3EYGbsW8YYUwefuXkOsI8AdIir44w/b+OYVwOM/y/AoBrDMQ+3eq3sIqbTKRgm8T J2jqQq19s1M7llpziJgQ6rmB/vyNkXlZEjiZxfCIxrT/0fpV6ZYpj6ar9zIrNAcmZvGySGG6R6l JXNy8fplywgLXXw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/mfd/sm501.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 7ee293b09f62..94ad18b52b83 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -915,7 +915,8 @@ static void sm501_gpio_ensure_gpio(struct sm501_gpio_ch= ip *smchip, } } =20 -static void sm501_gpio_set(struct gpio_chip *chip, unsigned offset, int va= lue) +static int sm501_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) =20 { struct sm501_gpio_chip *smchip =3D gpiochip_get_data(chip); @@ -939,6 +940,8 @@ static void sm501_gpio_set(struct gpio_chip *chip, unsi= gned offset, int value) sm501_gpio_ensure_gpio(smchip, bit); =20 spin_unlock_irqrestore(&smgpio->lock, save); + + return 0; } =20 static int sm501_gpio_input(struct gpio_chip *chip, unsigned offset) @@ -1005,7 +1008,7 @@ static const struct gpio_chip gpio_chip_template =3D { .ngpio =3D 32, .direction_input =3D sm501_gpio_input, .direction_output =3D sm501_gpio_output, - .set =3D sm501_gpio_set, + .set_rv =3D sm501_gpio_set, .get =3D sm501_gpio_get, }; =20 --=20 2.45.2 From nobody Tue Dec 16 11:49:25 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED0C22618F for ; Mon, 7 Apr 2025 07:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010663; cv=none; b=UJmABdUd3fOVl2ZXlkh6D1Dpsw84de5uENkt6Z3sMg2a2Q5Kx+rt4O4MVpUKLvWReO0wlugPPepOc7cRmf7CqDQCHxGMSFsDOZDNa7Szi3cp2Fv0C69gjhCXZXA9cgKrvgGVLcg2FmO/XGKUmssl6x+t4SRg63Nb7Hc39bJT3lQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010663; c=relaxed/simple; bh=J7f2eUTApbiWEcedhWmYKxUPKehC9pqeBkajVKzZWqM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mIVmvdaBpcVlRpqoxTf6ctHr4RSSw3fJ8DeYitH7przrlUr8a9v+V/DrqMWpBgCTSMOU4LWfKRELdl7KdiElQb+201dsklSBgO4X+/ZfS1mrq1egUlNBExR2tdgLmTiQIqgmPdFFaEagZ0p0QoRNKI/S4FZFtoJ4WXF8lh1M1To= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ri7GuhxH; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ri7GuhxH" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-39ac8e7688aso2940493f8f.2 for ; Mon, 07 Apr 2025 00:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010660; x=1744615460; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H8ZsxLGWS4jokMHzGTeIU5UFzwoJYJnzajiKuQ0WlY0=; b=ri7GuhxHg+7WwsXH7x/LwveYcx+j65PrEIOiMQXr2tR84zuz99VWTqy6pcb/p8trOt mK7XElHddFWs7IatO0gbxwHvLIyd5X7+q9vmXmmsvSKYdsHNoVA6SmT/zfnR2bOyc4GD mj8X2imr/lKyZWwQTAxgWAt27WGvGS03/U2KNeKEkl2NGF526LTSTIqMlVy/RjOzYzVy TAW1Pj9uahac8aucFohjoHcHBRvYtcVkf0IXNZj54ySG2VRtH7xmRe8x2/rfVuhZu5rS JBIJ0yfsqZ9b3BDC4+H3XvfGq7xc4PkLnhpfiQ3/g/iP9bj6GLhyJMRxh1EUcUZ6ilCQ TiVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010660; x=1744615460; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H8ZsxLGWS4jokMHzGTeIU5UFzwoJYJnzajiKuQ0WlY0=; b=dAkAnyHMJqSNtn+JPfYS0P9WGbSSdTJcIrNnYqXqoyfuJqdL6/Pk5Xv/GpXn/QRXrn qMPwjwCKcklmWL/Lwc4ZeDvHkSONHhXGPj2vnm+1xfy0eayto0wbrHSYC0V3OO6nRlHb RJCAVYM0UHUH45WTpEc0KwAbgirDoj0LgpVcwuLGGfeM/t3ohctxsmS66vojUo52POFj kkTJWiN34CkwQMX5Yhw7yzEyHCEMbgZUCOrj5ZlTMTBkd/drs/ivO2DNu6QI2hhs8NLM VxGu9Ain5MbjEqlTNeUxe7YQQsCfJgWPI6paScVoHaPqoBoy0hRWKg/ipNJvW9VVt7bw r5wQ== X-Gm-Message-State: AOJu0YxdhA1eO4Rr6SnHcBAoThkrg+1hL1feJpFy6O1iTLhBB0RtSNG/ +V6haxKU113x46E8sR8ZaGHeuncDJ1Uqy/y8e+QzcGKMHNwWM5nZHJqwynn1WzY= X-Gm-Gg: ASbGnctFC7dsMBFSd5hmxRDuOjn2+gwROIi3JKiSti/mtg2KuGzrP5HOXodx2WR7cbq YuXq6CQWob3yGoQIKKI3IT9AGnLZttZR5txKm3SQzGigOC08kvymR26VBTVoXLiOHrSv4aq2+DQ NZ5n70MS8wWfEIvfjf3vYv+8pkW3EWOAwZdfEVKis9Ja226NwqVU+6mhXtSvDrI3MAvSZ5um3b5 c4sa9STikMeTg8Ef3snqVqbjM5s7jYHCPNYf+gtf6TiSReKnd4h7A5Tbm/AqfLMCjMzAmZ+gChL 36z6BpNUEtO3o/k2/WmxYQW9repL8ldJvae0Ug== X-Google-Smtp-Source: AGHT+IEHDmnu8o2tM9N5GgWCGN1d01t9y2nKlBwNOJafY9H4tnxyVKYzGqxLBk349w1BiP4YorcOCQ== X-Received: by 2002:a5d:5f8a:0:b0:399:7f2b:8531 with SMTP id ffacd0b85a97d-39d6fce113emr5809650f8f.38.1744010659698; Mon, 07 Apr 2025 00:24:19 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34bf193sm119855255e9.24.2025.04.07.00.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:24:19 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:24:14 +0200 Subject: [PATCH 2/3] mfd: tps65010: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-mfd-v1-2-43f4d86d01d1@linaro.org> References: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> To: Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1365; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=dQlwl5PHLnR5U3eeEdKnSpeQk4aB5gzzRzjEGZ9SUOs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn832gn8MmFWMAXd4hoFe2Z1lYY2mUhkyK72lTZ AD1zYT1cKaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N9oAAKCRARpy6gFHHX cvjfD/wPlFmkqP7wkuSptD71j/OYnTX51KWKxAYbW22mJ/257F6DjNpbwMoEudW0FozI0jjdi/I tXMK+YHhq3uyreCGTNP9a6DNtfLgRNVJvLvspntlrfliQrzcVXxnt0Hrzw/dFrU2mtd070IfJzb ABClbELM7fVdQHHMYSa1oc9lYbFOIdXv0uDNM0x+iC42FYyz1OEW4bt8uumtW5gbSAxUigUdckX LYYdIyG2dTC3865pgZ1GurJFf12gLO9cIBUDmp9hpNLgSku/EOP/YSiZ8mUO1VJutUeQPGZEZMX VkI9S77Kmd5la0ukUGae7tW4JPtlFdq9ELfNdvJeLj0TYyZt7SFheAzFvIr9sGEQu/tVKbgS/7B CsgQhZ9WIwx6peZASqJTBpkAgXaPZyGaz/vXeGp1IzYd1MrEP6Z4YGP1r6tZIK4pdvqcuEPM8Vv wA4hOIvBOA39HwaSvvUpw3kFjjlNrhJ8q10WQ3VMIFU7jld3qaAoY5jK8sw3xhWLyyhR4PolBKy bMLMYSLag86n6eM4T62fKU97pUWng+hk34IGp/lYmEKsyeQ5kPBQwAtgAT5e+mYx6x/DvVNRwW5 80t5sR95joX1LhXOXRNNLuZK7l0y7qfCED6cTLZMuleOCl86VSNp89yulpL1ox2uIPREUrW4djN dhIRxwWKaY0TF9A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/mfd/tps65010.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c index 00fb12c4f491..5f1d1e061192 100644 --- a/drivers/mfd/tps65010.c +++ b/drivers/mfd/tps65010.c @@ -446,7 +446,7 @@ static irqreturn_t tps65010_irq(int irq, void *_tps) * offsets 4..5 =3D=3D LED1/nPG, LED2 (we set one of the non-BLINK modes) * offset 6 =3D=3D vibrator motor driver */ -static void +static int tps65010_gpio_set(struct gpio_chip *chip, unsigned offset, int value) { if (offset < 4) @@ -455,6 +455,8 @@ tps65010_gpio_set(struct gpio_chip *chip, unsigned offs= et, int value) tps65010_set_led(offset - 3, value ? ON : OFF); else tps65010_set_vib(value); + + return 0; } =20 static int @@ -619,7 +621,7 @@ static int tps65010_probe(struct i2c_client *client) tps->chip.parent =3D &client->dev; tps->chip.owner =3D THIS_MODULE; =20 - tps->chip.set =3D tps65010_gpio_set; + tps->chip.set_rv =3D tps65010_gpio_set; tps->chip.direction_output =3D tps65010_output; =20 /* NOTE: only partial support for inputs; nyet IRQs */ --=20 2.45.2 From nobody Tue Dec 16 11:49:25 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E20B2288D5 for ; Mon, 7 Apr 2025 07:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010664; cv=none; b=ti/cIDsux7zRONaH1djcEsXeFK0HjAZRHefl9fGzo7ZLl63e6Bu8y+oeIVocBZir2kVFm0nmGdqRJo/JjxalZU6WlKd9IwDGfbTd3WCpKpOGOd/4AH6mJaqdGETxWnUEaFtwgnZgA1oZ10R8iIlbj3JHwLyDlPQiJk1aHBtW8OQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010664; c=relaxed/simple; bh=46TsQHfMfuus2Y4N2Ujc0pUgsSG71cEeMP6rCE2Iukk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xc8aux29Hf8So+QVMR8pdcAPWgpSPumb3Ncfp1vAULuMw0v2EvrwL9wYZGJQhJIkhuy5LHxdoWzTn2KniBtwqH2lL0Smervtgirk9lGfHL83EP1z7yQWouIHZFL2n/szEQEO9EO+KrfhlJ5YQL6VOe93qDjtt3yiGiwKMd4XiLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=2v+8ql8o; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="2v+8ql8o" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso36767755e9.1 for ; Mon, 07 Apr 2025 00:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010661; x=1744615461; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/KkROuiXkCDKpcqyvio/9J/+1//CP2e3LnZSKP6f61Y=; b=2v+8ql8oa3C67rgEkAb3uEji66pP+rOQdUZjUm99XaFfBimxo5sTy303A2tPQAxdqB mOeYBsepcQXgoF1PM5GgK6pPp+DHg2Er8aMfOttnIAZPCAD8L84SmYMKxA/DYEGIjqa5 Mf5F3O3KIw//xUpqT79kXkruB+EoDIIVqVprur5QbBlzyIz4/c4zwG7xxlJDJ2Dmlo4q 6cR5h9jMIkj1pbJhuq6wZh30O6zmnu7PEskvvBckolCxy0qG13BI/Xln4WR5PzK1VRlN EwGULIc3HBskwfZ+iywbRPYW7I2N3x1B0GT07IVPxHsvJViSP5jWUOO/7xYBkJULtWli Aa1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010661; x=1744615461; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/KkROuiXkCDKpcqyvio/9J/+1//CP2e3LnZSKP6f61Y=; b=DVy0cAXmFXSne60MI1HM5SfPFDNaDnDN2zQn3SCxd6rzm97IeSDiCwOZ+1hEq1LahV IKRh5XRjtseRdfUmtQXzK2Nc/yoUy1VJ0ymFy3b5h6pPOng+pAFVc1kW7Z6JQF3Ep8iH EX2F+/RP6mQ9kcVjUg/hf4+UYnrZjgfm61qt9IODk4moksgxHDb8E/gZ8QVU/mWX1A++ Ok27EWmFDvUvBeo9QnWbbzEjJyegIQZBH7YU1Kt/DIOM8KEH8qjobC8TCJaQZTriJ745 dMwnZx4vA5wrRoqIaPEjzm07faOdsJunZ/iAe0Hk04vMXBDcwwIO+CId8uSIL9IWKGeW I0OQ== X-Gm-Message-State: AOJu0Yxdw8h1IEljkNXMzkp9uWC3vtDAVHF4QZaU0OuHDqOY45jE1S/7 fT4Np+DDImyhuR10IcWerECA7ZLdVJBGf16ySZwTuF6ce48chmqyZCWdtcMSXdA= X-Gm-Gg: ASbGnct2HT4TNbsR+YC3pWfr6imaM1JV34Cgx587rApY/sWZzCDZEugfRgnlBi44C3O jSNKRFJXUXhZV555bQ8xeLQeqK/y/dOl0al39xB7EWBs4aHAmu4qNT3t7HL/reCdNYDUNvOlz41 sUcydRjapr0StmUHFC0b6PKo0zFhiAXrg9QPFECCCdXRmCBrK9dh3i2CXiw/dPB9f0/Omt0M6uN jfOoekvBNMgGpWIhDLYmPwT7uzmYbqT/aOYpYxyW4Cfnhoql/ZLCDAhT4IZaP2Y9adEE0hZIPFD E4f5X8OEb7yVxboAlmc7QMzgDEEhuS57B4R9IQ== X-Google-Smtp-Source: AGHT+IFtNLoH7gdKr+kyVE/8qt5O8vviG3nWzND179kXjnQR6oK2QV4EUTBGcSAr6Wgx1MkzEzIGiQ== X-Received: by 2002:a05:600c:1ca4:b0:43c:fcbc:968c with SMTP id 5b1f17b1804b1-43ecf842872mr94232465e9.7.1744010660778; Mon, 07 Apr 2025 00:24:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34bf193sm119855255e9.24.2025.04.07.00.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:24:20 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:24:15 +0200 Subject: [PATCH 3/3] mfd: ucb1x00: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-mfd-v1-3-43f4d86d01d1@linaro.org> References: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-mfd-v1-0-43f4d86d01d1@linaro.org> To: Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=TF+EFt7bi6NiJtGjUB3SG25pVoTiUVHr1riDXGIMQcI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn832ggGtmHWHRB0jo82i+GFL3aUN1MFDemCit1 rR5kPzXsraJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N9oAAKCRARpy6gFHHX ch7JD/4sIxMbN+qp3taFnSwWjK3XqAYEI3jwbJqEC21sIokHaETEU9SdplBDszdGntVuqAxHbUV GF1tgivckvWyBcOQHnZAwz9CnlAdgPb70BfWpi/yyOokfzHmFFWIVPUvrag1Qo1g17T293SMn0r 0aj4x6AFrqDCfzEl3bxTQpZjcKa1qCThwmfF5DugUm+x30NiRmuQg0aZasa12aSnZ7lz+oqZxaE I4av90UzKS/bkcNz0B/fmlUrRE4RRxQxqTpvk56Nv+QykP9P+M68sH6mZ2DMgvjFYihYTNoDB/O G7ne/MHSp2NIlJRHislM657eqQYp1Gylr0OezdpE+i716faf3TKkqJonj/SlckwfnkqWsNpHR7T HwhWVd8f3E2L/gpOnDBd9IfT3TP/ncztWW6D5RXp87f5oUY8Jg6QNkmS/9PnJaL0HUO8kLZDDj4 Tp/FCPeUc491T+ynmZH5X3Nr4bjAr1PPeG1jEyLazqcE7vUd8fBWZoFTqqCn51CnKJ6FgLlmAUZ 8hd+/ILdLNsvUQJeLr/YPJ2sY5ItODk+iPhkTjwZqHtzhh4NCh24hH2qDBp0uVJfhJ8fcTbAW89 ZAECjTGyBcnxSTYOlQcNsQpMFy9t1gdTwQnn6LIg6VRzMUxhsIRqgFgX8xzPxoXmvP5LTKirWug H7mkyD0SRy4m5iw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/mfd/ucb1x00-core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/ucb1x00-core.c b/drivers/mfd/ucb1x00-core.c index fc4d4c844a81..fd71ba29f6b5 100644 --- a/drivers/mfd/ucb1x00-core.c +++ b/drivers/mfd/ucb1x00-core.c @@ -104,7 +104,8 @@ unsigned int ucb1x00_io_read(struct ucb1x00 *ucb) return ucb1x00_reg_read(ucb, UCB_IO_DATA); } =20 -static void ucb1x00_gpio_set(struct gpio_chip *chip, unsigned offset, int = value) +static int ucb1x00_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct ucb1x00 *ucb =3D gpiochip_get_data(chip); unsigned long flags; @@ -119,6 +120,8 @@ static void ucb1x00_gpio_set(struct gpio_chip *chip, un= signed offset, int value) ucb1x00_reg_write(ucb, UCB_IO_DATA, ucb->io_out); ucb1x00_disable(ucb); spin_unlock_irqrestore(&ucb->io_lock, flags); + + return 0; } =20 static int ucb1x00_gpio_get(struct gpio_chip *chip, unsigned offset) @@ -567,7 +570,7 @@ static int ucb1x00_probe(struct mcp *mcp) ucb->gpio.owner =3D THIS_MODULE; ucb->gpio.base =3D pdata->gpio_base; ucb->gpio.ngpio =3D 10; - ucb->gpio.set =3D ucb1x00_gpio_set; + ucb->gpio.set_rv =3D ucb1x00_gpio_set; ucb->gpio.get =3D ucb1x00_gpio_get; ucb->gpio.direction_input =3D ucb1x00_gpio_direction_input; ucb->gpio.direction_output =3D ucb1x00_gpio_direction_output; --=20 2.45.2