From nobody Tue Dec 16 11:48:20 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A28FB185920 for ; Mon, 7 Apr 2025 07:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010827; cv=none; b=MaGsadfQXMEeuJ8S47KZdsZmssTOIJFXvrgsOsXDClTnz9l47zXNaZfgePMxs/JQjPzh8x8AUJnVLM4IXCWbgt3TAlXkX/pL16YoA2QA34mHzNer9akRFKNs6JRkXZT5xxp+/oypHaJQVG4h90QtIwoZhQIXQvkf4OSDWp64l8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010827; c=relaxed/simple; bh=Q2hvduva6KqQkHASyRGukCcsvLKULC9rmnwEVzjrJTc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LwPvbgDxOKC1VGMlXaxXmhS4r++S0wF6QHKBGF+tiIRIzuYsISbn5bqIHhq11FLGht9DLNFpTeinZNZFbCQQlCEtE64PUHneqgD27BZOI7qJ8nhiJuAylg3mEPa2PDfn/qk/U+r9aRyfd1kkHVgTPqRQf2imHCVowtRZasxsWuo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=QVKDmJBf; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="QVKDmJBf" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ac6e8cf9132so422416666b.2 for ; Mon, 07 Apr 2025 00:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010824; x=1744615624; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ibROZn0IFJz5QzV4WaY8wi22jP2cRYC3gjXYgtkdD7g=; b=QVKDmJBfdITVImVujb4L9Tx+HpN3gAg5I8F/AlQ1b+x/yciQDI6JbLtJ2DF8r6tglU HECMWKNWdtD3bRdxN6GU0HpWrQ6seElCswCf8CtkDdxY68T+YMelkYA3pl6QLn3E5ubu 9/OFlCZcrt3SVR+neD7KRCkjzJvmhOdKzb7m0GWOLg+vtHAMauRuFz15gjaiFR/AyTPe KraKfTvKjgNtWJFA/KtVE3D2PjOsJws2ATP8qo77VRg680+71Cc6/z9DBpxUu8bn+1qx 1hyARWxQ4yZ0+ifOHosqDd8BJ01MsUEOmwQqVwdxXF+BUOSHa2qDCvV9G1OQwXz9FQqC 93tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010824; x=1744615624; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ibROZn0IFJz5QzV4WaY8wi22jP2cRYC3gjXYgtkdD7g=; b=LdkLCJwRsg3km5Kges7+aCHp5tRhpQhheqEsnqy9vzqCoxg+MWXwcd+pJNUqd4/Qe3 6HT6zBjEEEeqimKtiY/dHX078fbrBXYpKHubFZJUtd/4ToYGZ+boXFp+LOGHnbR4I5sl w8olkEvLcI8VmlA1CXKLKCkLq862WceXAhGye+s6YkfqfFIeUG8yv9FMEJKrA3f2Lni7 lzf9P7dsbY9U254ICmMbT3pkF+/yz6OZe18KvYz+/rDz82OIbE3+Zq+21nFM8cILP5s3 ukrPEXz1GxHOotW1WQ08GUDCSJdLdjvHB1WwALKWY9gR1k5wxRU1k4xprS4G7lg0pzRw 1fNQ== X-Forwarded-Encrypted: i=1; AJvYcCVt9tSu0frwxxrdSzbPybxh0lG05zpkIPW2EHuR70PmMFPLOg7PulV7HdT0RSBtT68jS3Qt5OKXWn2T5Ys=@vger.kernel.org X-Gm-Message-State: AOJu0YxNymEMAbvXtdVo9HX0zdI8ApffSpUaXouCG09mcD0qJRPUlCG9 ut6RqSdy3JwE38xoPKTQMLkimVv56N4Qjb+T+iZVYZBKvt5305QS+9S1pcrHdA2tsrrZhuI29tE twRU= X-Gm-Gg: ASbGnctB/TtthHr6+p/UYHYy+ChEDezk6ehnIRXSK8TsDSAVgCLVOQZrenjyoAz+bDn EqMlXFPfQ4qaXtsKY5J9zmgZ5tE+o23q1CSQKWTa0GDl9o5a/wZkUltFxCzbR9froM8JkMfWz+O Zi40rjI4F00ryWCacuSqFc4/QmS1Qa+yrQ5CU7E1gX4KRRetEFzE2mK+2yNFmZ5e7j0deiT8vc0 yF7spMYetWyi6qSlvGxSeIwpOybX2ZKaj5g5+teXdcSSsy9hMpp6OBysKXPiU+qFST4QIQ03iY+ LGRQ1W3NDhCqWRZj44idu2ZjS6a9t7dsIu2L0g== X-Google-Smtp-Source: AGHT+IEkHVJgOyU9xGp655NX5EHCzYygkvYDzVBi2Npjvs/0OWrQOPdns3JjSlF95Cj2KJnmKf8UhA== X-Received: by 2002:a05:600c:198b:b0:43c:f1b8:16ad with SMTP id 5b1f17b1804b1-43ecfa0572cmr131452905e9.30.1744010353699; Mon, 07 Apr 2025 00:19:13 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec364c959sm120215145e9.25.2025.04.07.00.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:19:12 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:19:10 +0200 Subject: [PATCH 1/3] Input: ad7879 - use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-input-v1-1-a8b45b18e79c@linaro.org> References: <20250407-gpiochip-set-rv-input-v1-0-a8b45b18e79c@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-input-v1-0-a8b45b18e79c@linaro.org> To: Michael Hennerich , Dmitry Torokhov , Linus Walleij , Bartosz Golaszewski Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1714; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=foyELHbizbcWk/j9r8xiniRZm26jVuqeFRwl7mGDslU=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83xvMsVuyrAN8UuFJvWiCgwJIhVanOjs5RyNU f6v6R7ldHKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N8bwAKCRARpy6gFHHX cjBhEADJTqfjnpnZK+R+cF6dWcfSD6GmueJNC9Q1SYVFVHW+TQvc3mi2GfaIHJIqqkmrqMSa7VV LWzNtodZD6j9I49JZvliGWrbph/MS2MniyULfTw/GMwmhPwZYpi9g5+4cwopCvfPbMUouldhvUO cp8vdggCPeBpOaWx/AmYIEeSB/Oy8RofO4vsuvh5/elW3GueigH8vQlas2CQYBndd0kk8OEgdZY e4/wFB5pNg5mKqxB7byMuFhmkDtdSEHWP+O1H5+66MQVXNJU/Iy++0DvU1fQJZumxIZxQPIFXCb k9yOgd6MtU4N3gcM5dtjsIt+BIVmmn+VDbGrlIvJrk6AmyD0JdtgwDITtnWE5BQTCLkbDtZXM8b q+B+ct9iHNr54/R3EPgziIWcCf7cW/FrGqWZE2g3gq/NVmo42KTfZxcY6L6BfW+N6QlI2UtiThG 62dx7KHW75jBQTWMU1nC6IX+5KC4S6XtY881B8phngJLNcmh3c9itLogh95f229if6u/ktqZIBK Mh9Tx8iQMLEyFE383FA6SQQYC2gghSl7zYDqqw5QZmdGbjpEaufAfPbZmRQC9a8pwGE/Dbf8Y1D W+9NBHCzUnLCeJtFZlh9Li4FwhHBoRNA1DbM1nJwK+1Br8ruCTsUWJ0mSgmUTC0INmrSfQsN5F6 wJFGm3Ml2SPjJdg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/input/touchscreen/ad7879.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen= /ad7879.c index f661e199b63c..12fc39f9e784 100644 --- a/drivers/input/touchscreen/ad7879.c +++ b/drivers/input/touchscreen/ad7879.c @@ -444,10 +444,11 @@ static int ad7879_gpio_get_value(struct gpio_chip *ch= ip, unsigned gpio) return !!(val & AD7879_GPIO_DATA); } =20 -static void ad7879_gpio_set_value(struct gpio_chip *chip, - unsigned gpio, int value) +static int ad7879_gpio_set_value(struct gpio_chip *chip, unsigned int gpio, + int value) { struct ad7879 *ts =3D gpiochip_get_data(chip); + int ret; =20 mutex_lock(&ts->mutex); if (value) @@ -455,8 +456,10 @@ static void ad7879_gpio_set_value(struct gpio_chip *ch= ip, else ts->cmd_crtl2 &=3D ~AD7879_GPIO_DATA; =20 - ad7879_write(ts, AD7879_REG_CTRL2, ts->cmd_crtl2); + ret =3D ad7879_write(ts, AD7879_REG_CTRL2, ts->cmd_crtl2); mutex_unlock(&ts->mutex); + + return ret; } =20 static int ad7879_gpio_add(struct ad7879 *ts) @@ -472,7 +475,7 @@ static int ad7879_gpio_add(struct ad7879 *ts) ts->gc.direction_input =3D ad7879_gpio_direction_input; ts->gc.direction_output =3D ad7879_gpio_direction_output; ts->gc.get =3D ad7879_gpio_get_value; - ts->gc.set =3D ad7879_gpio_set_value; + ts->gc.set_rv =3D ad7879_gpio_set_value; ts->gc.can_sleep =3D 1; ts->gc.base =3D -1; ts->gc.ngpio =3D 1; --=20 2.45.2 From nobody Tue Dec 16 11:48:20 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9EA6229B02 for ; Mon, 7 Apr 2025 07:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010364; cv=none; b=PWbG+z8bMOD0I5JfI3r+c5Gj9rBvmogjAUoOs3SauCCTl8hICC7SrJ3f+0jKH00KSiG9Vuf1zsHXs8pwfM227Q0URSWI5wqZnGbFvvwuqn1cUCfbrW8M5DFD9TPLzI3WBz28DNrcZGg4ENP2gkkGN0Wn89szJg2KiQ/Q3jCpz9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010364; c=relaxed/simple; bh=+deuLPSQkEJHMd1oN95jU1WrKRZsQUmYNkgMgUdiHfQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PB3Jm/1zmXsUuGBuIA+195r8ooE0lOmsNKDFbMDfa/gSe4T5I+DlTGDAzpuyT4oJOkjNby+LPkzkUi/wqDT33xdLv+FVdnXiFwMEU0flJdlsZNyUyjj9BXjsBszfY4efplQdwXaISfNL8DO3IG/TMLU0GFjyJz1LozdkprNAndQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=jIUPdJvK; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="jIUPdJvK" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so37173845e9.0 for ; Mon, 07 Apr 2025 00:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010360; x=1744615160; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ChXOA9p44Ws7ALTa8sIdL/yKUHK+mgWVc1wgenfZZQc=; b=jIUPdJvKW0zUaPcv6jYIZw9bUSZquBFCMgkXHCx/MOgbnwdqQXYqyQrvhSGV4Ny7ok e7qn0XOQzKLGR1Y2S/6ndt86fL9U1lL2Ur40pRuviqyLY5KxDkoFy0wt3pPPWOsqPWIp arVdaRnskhRO+VMxRTmVj9yqmWDG7EBmgsxEGCAJGkXeJXrVOH6D1JY+YRhGfveb2tTv 3aq3M0rSucHP98Fn2QJEHoodNU/eyuoXmm8EAyAaabILY9meQtHJk2lNLubbWQsmINHd Ky54dUmKDMiFkErbacL3gPvkhw61eshYf0WDU3p4/9B6KTka+UQ8UMeaxwLqkEHHMfBR 2efA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010360; x=1744615160; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ChXOA9p44Ws7ALTa8sIdL/yKUHK+mgWVc1wgenfZZQc=; b=TSIRhEIXnmuhm5qCxbkktMufrdY1SzI5Zm/wQYEFMAa2R5+2aPPb/Mgunb8TTsnVRd 5pR1rKDbDSvM6+/x8mJS+CXW4o6w9McuzEUbrpZrHyjw1w56pCQSLyNSFITA1VqWgPzK IJsJgn3bvyzA5W2nbPuk6oT/A+MFXVMHdehBGu0PM70ZF+IIlHkhBPbWxjGO5ZZJmFcG vQ5eK4RfdKbGoQ9oqOEebHSuraU8v9Anf+ubEwD4yFWjcOmudNY6wnjGFLKcArOltvpQ WJ891scwX6vBEocNmfDjcJBOjvGnZwl4KVVaUyUC6/JQZF9DFoFse838yfhMZBtknIX0 Q93A== X-Forwarded-Encrypted: i=1; AJvYcCWfddZzou7qLE75O1pJY+HSLt68nAc6hlAz91W+wxSDiAaJl0XrHJzZ1vOh/b7uQKXYeOx2+eMKCII0h4c=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9iKBL178kBaztu+4T7gKoVJuBIMA4YsHy2pGkcNsBba7+XAxb H2wU3Jtz54jGpaZ4vcef0afx0aRuQdGj9kSMP72mNsdo4PY1NHTOKzfpqe67a18= X-Gm-Gg: ASbGncs4XLlhdiUVRqMd/tYzC/KNt2v1Rz5wDOawV0cZLpZt2V/G+Y8BZhZY71acF0k kNFwDWB2COg/txxLFxZeHOu/oP0Ap20DiUofSUtmdrz974PK4wlUTLYFdtXKO5yyXPqodYYBKfC gQ3o+TLksTE4L3JiGECVRPuP5n5tBB5HBBYDgoM8coBIqZQ0YKmcH2gdUqa0rZ3SqTW7gb7e6Xz lWXAAvUVEXYWV5/7h6ZG9bdvtvF0I7Q1vOctxez2NKwPgVkmUAZppEMSc+nVy98FU4+S/h3FtnI 4cpB/xTfIfQZJd1HFmhqhWoVMluj4VnG8AGfcA== X-Google-Smtp-Source: AGHT+IFV4P8oQ3nG1OU2BDLNtmclbNouSwMD4cLpZlwSZElcCaMEGPNksjQsv2nIGYL2m479ZPgS9g== X-Received: by 2002:a05:600c:1389:b0:43c:fa52:7d2d with SMTP id 5b1f17b1804b1-43ecf9c77c7mr84576565e9.20.1744010360289; Mon, 07 Apr 2025 00:19:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec364c959sm120215145e9.25.2025.04.07.00.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:19:19 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:19:11 +0200 Subject: [PATCH 2/3] Input: adp5588 - use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-input-v1-2-a8b45b18e79c@linaro.org> References: <20250407-gpiochip-set-rv-input-v1-0-a8b45b18e79c@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-input-v1-0-a8b45b18e79c@linaro.org> To: Michael Hennerich , Dmitry Torokhov , Linus Walleij , Bartosz Golaszewski Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1794; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=o8UJdITbenIEBWagS9tbUTRGEbSz2Bo2wwxkVvQkfuo=; b=owEBbAKT/ZANAwAKARGnLqAUcddyAcsmYgBn83xvqP9Ph+Wa7aamh/W98Tk8+U6/kt9q1kKzL 05h47rIvU2JAjIEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N8bwAKCRARpy6gFHHX cotzD/UbHDgftNnyNJ8HCygByrRKaQFZ3aVycjBz4aWVoHfft7cLF9QRClurpPH5B6EURB0jL1V a0RXvV3COSo5AGBpew/77WVrjil5NBTUiZTan6AT2WF8JuKA4U+mkC/lAP88ylLZ8dtt19wDdAm 5oqlO5wxa2+Idky0zIakj8SU8Zcy9VG6Kc1f3nBGFKgKmVDc5yYI54dwJu2RUK9j2TI0Dw4E4rF QJOQ1sRCE9Ecqa2rcFyi50PZXKrx7Z87Wyqjyo4NWrkkpNCphgyGNXdwhr2hRn7VMB+VDzj95w4 MIuG+wuPGvjtRbdLG8XnM6SSSHpkTkIzDLqGFWJVWlbk7t3Yuk1RlPTEzoax3PzeicvlYK8MZii fB8DzqERSRcDBy+ii/ZNgPEQwMfPaSs/XVKVMrQumqss35lI/D+bQ4Iw+dCpEVW5DT0xNMdfN0U ermT0MKJknP5URBrPtN0+ua3StIuqDXebEqp50PvrHdHctcN1zie4uTrCoquTp8VMxEaGpaVykr ++LB0/0XSElxUmX3LTa2b0EOyhDvgMijDA1xK10XqtQ48lr9rpJy8z84X/9xXbTn1+cFod47Qbm ExQc9D9s/iia3aqiKqZxw914ArOYaV0BQRyOY3YnP7rDuXZ6aw6CSaRr735fSLigKVzdRy3QBIY eOQws7vTqgCa3 X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/input/keyboard/adp5588-keys.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard= /adp5588-keys.c index dc734974ce06..2b2aca08423a 100644 --- a/drivers/input/keyboard/adp5588-keys.c +++ b/drivers/input/keyboard/adp5588-keys.c @@ -232,8 +232,8 @@ static int adp5588_gpio_get_value(struct gpio_chip *chi= p, unsigned int off) return !!(val & bit); } =20 -static void adp5588_gpio_set_value(struct gpio_chip *chip, - unsigned int off, int val) +static int adp5588_gpio_set_value(struct gpio_chip *chip, unsigned int off, + int val) { struct adp5588_kpad *kpad =3D gpiochip_get_data(chip); unsigned int bank =3D ADP5588_BANK(kpad->gpiomap[off]); @@ -246,7 +246,8 @@ static void adp5588_gpio_set_value(struct gpio_chip *ch= ip, else kpad->dat_out[bank] &=3D ~bit; =20 - adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank, kpad->dat_out[bank]); + return adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank, + kpad->dat_out[bank]); } =20 static int adp5588_gpio_set_config(struct gpio_chip *chip, unsigned int o= ff, @@ -424,7 +425,7 @@ static int adp5588_gpio_add(struct adp5588_kpad *kpad) kpad->gc.direction_input =3D adp5588_gpio_direction_input; kpad->gc.direction_output =3D adp5588_gpio_direction_output; kpad->gc.get =3D adp5588_gpio_get_value; - kpad->gc.set =3D adp5588_gpio_set_value; + kpad->gc.set_rv =3D adp5588_gpio_set_value; kpad->gc.set_config =3D adp5588_gpio_set_config; kpad->gc.can_sleep =3D 1; =20 --=20 2.45.2 From nobody Tue Dec 16 11:48:20 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA1572309B1 for ; Mon, 7 Apr 2025 07:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010367; cv=none; b=CMhWaer7kzLpA8pVwS7xhoVVG62UDv5YvihQpSeY2g3g8QDIDrhUPShRM27QYP0T/WNq+6g0Text4AtId/wXEGfELkG/GuZjNrnMaO74O5aPRa4SG/BVI62hv3tvPJ0T80sqCVwgTkukUhvHvfYM4QRlu3PUYlBWyi3XssbxwLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010367; c=relaxed/simple; bh=XdR1F1d24wz4tnZ/+4ZmFiOQGGu2evq7oEPt90HJ6QA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VOjTDj1qzKPatUVN3bHWQZXL5gEXbxi+W8aCi2ZyXiDNP8Vm0Xs6p1v+i4Stsbxc4OnvYuFX4cpjz41UMf6sEkpuH3dCCGinhLLF4Cti0lgMP4K55CMCXNa9tpTZViW2Bwo3nJPl8HIwmYrp97iCmXFWYl82PTSnv5BimMaRb6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=UNWy/fhl; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="UNWy/fhl" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cfebc343dso25282135e9.2 for ; Mon, 07 Apr 2025 00:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010364; x=1744615164; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IHa5+3Xv2nYSlmM0R8jZrZyFIIPzDhCPSeCMfkmkG+w=; b=UNWy/fhlCv5bo7eiTSBX0479u8/p//dZWhcGOOuEMVTs11wmqmlzJIowy+TKtYdDCz FHT51IYo4PHLzfVPd9aXpAqaUEt695bKeOXuK5mtiYkqSMmYQUTU8a1ftZiIVeNwHs2w xZwf9p3I9jhVjcqcXH7mv+tULa5R1Iu9fSE6Tn2Cs5H/yysJ2DRZcrHTLJepvAitonaT zhCEXE9eZFA7mFtz8epLwgTzIe6+yZzi5wi1B+HPH3tHPOm9tWJN5BowXmRWnPC/MbMO 6PyoOu8oZ1f/HMJjutkxt1gYtWF5oQ+2MsQgSb9qjN386Cb8YH86pg9ZfEjZEGhVU8+g Z1MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010364; x=1744615164; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IHa5+3Xv2nYSlmM0R8jZrZyFIIPzDhCPSeCMfkmkG+w=; b=ez44m3F7bnVPm6rF/SnOgBDlCOfadvc/LCToDMHDdw7og8EKkStfT8w/nYYO1EUGO5 EhvqGFYjtC0chJkVAHy/LAz/1OWOYoH70ycuzSNUKmn/HLUCh39Z1uVNXcAGnWMmKdc1 RgocIYetAoHwbW0pIInr8h4fHMGY/JoxoxM86T785pqA36grSrC/dUqwV5P3dsfBQr1X jr0GalDAOsQnjgnNiuHzVUFnLYjhWYhU3gLyW3uR4O2OqWEc26os/hT59BxH0h6qE4jv IzlYIdYNlLdhhdMqPDj2lB/+hLE4LkZMgsq8AsEp7Itk3nydcbl/mdIu+30+zm8wLW8j sTWQ== X-Forwarded-Encrypted: i=1; AJvYcCXqbXOevmyCa0dAhRt/kc6070IEM4OBS3oUgebo7AE6v2+NcnIZ/ZbftDQVvncQdLhPsV9/7hfl2Vp3xiI=@vger.kernel.org X-Gm-Message-State: AOJu0YzyW+719mktuC8RWOnvj9KYHQfPnZNrtkxWBJ9ZTdU9pH6izyHi kzjSd5y5+GOiK4nyFNgD3Hz7HifLE4ih7d9E/kD2fRPZokSAzis1sxY/BV4hwc8= X-Gm-Gg: ASbGncuamOqUk7pPE0Q1Fwg8xW8YqJMVXeiwSnOEUOfaSXd8fc8/qk1yywag/hx47sO dvy2R96F8pnh3zpGUrnxC0VtEV0tJEY12aOfepeATqbmBNH6PqOHk7IJgfFicXOj7lHBSm4+JCd B1JOIyxRpWQA8qIT+0FwXispqQeZWofLzzMnY0cowjuCC2aB8Eav0IlxqvCo4kx4t3JoaejK4Pj MJSPmaqYne/LNQ2yLAiWHWFAKnhnnFSgmlw0CTOdjxqQeXkNh7vjZ2GqeB79Nnk9pGPF/MVK8/X l4BWCRCrkcWpxOOHaDa7GIEY56EH6Psd0tjelHZHXkAdUmpB X-Google-Smtp-Source: AGHT+IEC4uRQ9XNMmKKpbID7+2W+G955oGmEj85gPslrlwXGh/J5f08lBKYmki24DDnHeD1PZLDfuw== X-Received: by 2002:a05:600c:1e23:b0:43b:c95f:fd9 with SMTP id 5b1f17b1804b1-43ecf81c304mr101899695e9.5.1744010361163; Mon, 07 Apr 2025 00:19:21 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec364c959sm120215145e9.25.2025.04.07.00.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:19:20 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:19:12 +0200 Subject: [PATCH 3/3] Input: adp5589 - use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-input-v1-3-a8b45b18e79c@linaro.org> References: <20250407-gpiochip-set-rv-input-v1-0-a8b45b18e79c@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-input-v1-0-a8b45b18e79c@linaro.org> To: Michael Hennerich , Dmitry Torokhov , Linus Walleij , Bartosz Golaszewski Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1854; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=b1mbZ9+luKGaPZMmERJAiMQlHQJ363cz8LumGJPcpTM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83xvW12rx8RkPQUSxweYOqwmmE0p4xrJnqauq fSmi5ZJlsWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N8bwAKCRARpy6gFHHX csOwD/0TeLStBON5XGpuhq0sT+tGYEAXHhUsDfBm+6vTRWA8DAPj8UvyoWIJpVSXHhJ14d+LF9/ MPaJf0IY5KUNyBNefLcPapsbPwWG4ThYyel073Xq/8IP/P5hzy8HdOzgYem0VzpGSgS22YGPsSY PNI3icdfVpBrtblUKN1kOpsW/DvAvjkrayb74UCZVoeQAftbNnswVMBDT80aOyEZx/VCcBAroae 0JrqhW6RnTqY5eCZmkEzuLOeSpwHcd9Sh0PzKcR/r+9BMVBLesPLi50KL+yvJtk2CZDkH2A6DRR /EKjKEg7xJdPho9+PiPV2yfsyrb5DM6B0El7Mdn+tRm4C8VDd2by7PeXD2cdumvIELOGxwQ/9if MqC4/wLoXqsxumsw4FSiok/CNfk/XlVXp+mFazMOpHVobIWqRxd6gbU6QTuWsRuy4tlPq8KxPdO 8A0318xTNB9W9mLoM1t7jRSh0rFsKuIyV8b/z/aOaHxYvXaVTklqSw941hlG7RwODDLWoArsuyj 6DOlSS4wIAgFuzEKbO+R10JTBsNZcnQ61h1rbpxpA1gjpxN070eGsllW6ZgVxGcRtJeMoeesB/W fB4CUGLxl5ZUdXR457F1R/jgRWnleYoFvOLMcH/FZHOppGLoXtg/PCyHDYb2w1zI0STYpvzds81 RaKAUPjWTuQTCiQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/input/keyboard/adp5589-keys.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard= /adp5589-keys.c index 81d0876ee358..986a789f1ec3 100644 --- a/drivers/input/keyboard/adp5589-keys.c +++ b/drivers/input/keyboard/adp5589-keys.c @@ -404,8 +404,8 @@ static int adp5589_gpio_get_value(struct gpio_chip *chi= p, unsigned off) return !!(val & bit); } =20 -static void adp5589_gpio_set_value(struct gpio_chip *chip, - unsigned off, int val) +static int adp5589_gpio_set_value(struct gpio_chip *chip, unsigned int off, + int val) { struct adp5589_kpad *kpad =3D gpiochip_get_data(chip); unsigned int bank =3D kpad->var->bank(kpad->gpiomap[off]); @@ -418,8 +418,9 @@ static void adp5589_gpio_set_value(struct gpio_chip *ch= ip, else kpad->dat_out[bank] &=3D ~bit; =20 - adp5589_write(kpad->client, kpad->var->reg(ADP5589_GPO_DATA_OUT_A) + - bank, kpad->dat_out[bank]); + return adp5589_write(kpad->client, + kpad->var->reg(ADP5589_GPO_DATA_OUT_A) + bank, + kpad->dat_out[bank]); } =20 static int adp5589_gpio_direction_input(struct gpio_chip *chip, unsigned o= ff) @@ -520,7 +521,7 @@ static int adp5589_gpio_add(struct adp5589_kpad *kpad) kpad->gc.direction_input =3D adp5589_gpio_direction_input; kpad->gc.direction_output =3D adp5589_gpio_direction_output; kpad->gc.get =3D adp5589_gpio_get_value; - kpad->gc.set =3D adp5589_gpio_set_value; + kpad->gc.set_rv =3D adp5589_gpio_set_value; kpad->gc.can_sleep =3D 1; =20 kpad->gc.base =3D gpio_data->gpio_start; --=20 2.45.2