From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4EF224AFB for ; Mon, 7 Apr 2025 07:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010000; cv=none; b=QsU/YZ5KCsuJ8Qv0EiT8dzXVRwcv1A8u2tN08gtsATDNwsQjHeGDq9oetrtspFnoZF4mDxUvGsVpV2qYmwNAoMllOmF9xGKdZABKqI1GAA4WuHnp7V2DJ4dWXLozfH1hD7wJ8k1zvQLEGlHZbYQxJzeisiy61k1j6W37EYJr9gQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010000; c=relaxed/simple; bh=/5Sjz3aLnWW1HWrOcAYyweVPpFM7vC+vJtoK/pB1it0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yll97LcV7FV9P/+wwsLV3qDyrolC6rQ7VCNmuNcnys5mKB6E6+8D/LysyO2+CUFvNFkj0cL3uIY4C5KaBu8q0tFJSYUgM8NdTSzZr4fzBzFTHITaDcdUYth5sqDLpJs4Bf9VL5VnzluA2kPlN+qEWVoo9b0N2xo7SQ+N09n7GOs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=NXaIbDDm; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="NXaIbDDm" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-391342fc1f6so3572803f8f.1 for ; Mon, 07 Apr 2025 00:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009996; x=1744614796; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5irncOO7SE3DLhdbNeNA8jd9DPgwzCzzTwzb8eKHP+I=; b=NXaIbDDmSle1F0IPCwn+YbBmNvDZ43f3hyUwKSjrmnbH8Zlw2w6pJ7ViJbpq1Dc9sn psRkom2vRBgHZE3vpN0DmNxp4wPGvVi8sg9DGPitZJjver6a4RC4AEyLf8fy/EYtqw2J c97rp9rssqNLvETLkF4A0kxOvdGZME4m2jCJUcUgrlUUL9UP2rOF81tAanVds/HTu2u1 xYL/Vt9+v3b80VDIQIBfOfaI1j5q+dZDiaom1kioA/cUFODrXfo5CAExPdmiTjjQrs8e PAoVIsLDGNnltFI9Znt7nfY2vP9dLz1an8wHINT3chS1do5bC51PmzM9C2XYGbjiKRvf pDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009996; x=1744614796; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5irncOO7SE3DLhdbNeNA8jd9DPgwzCzzTwzb8eKHP+I=; b=qI/Um3ykJpMyRqvTfs4jUUHOesahTqQURBZ8a0x32bVIfDIJGlZeZ+q05jI+e9K8ao ZDYMi7r5HuzEJJfP9aHDRyqBD2IJLzTgrxhIrz0c7LckAroPiESnY+QOFvT+Op2juilI WQfgJg/yBUqGw9MCNu8Lj72F2bvML/J6obZCWpb+sI4UQnY9GuD1bfAJIgy77uGazAw4 bj8Cx7mr14vgDYM+b0z+8D+hRxREmLIlWovmg5Xgp+IRV8GhxF/hdZl69E7DwTHAW+gK MXydBl1HX8HGf3+6xLI61WXO2X5tUFy50UOvudkU20zMUFlwFFL5fjKKutgPI1S2xT4H TqLA== X-Forwarded-Encrypted: i=1; AJvYcCXKLWmp3NDrL4SIWwLCqyuKN11Zyn4CsGw9LRyGn8OuwVvDQYL5Wi+LzoXqKcSM5TnFVgZHVNIZNEOgfSY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+X4cDZggDbUjVsNhqgFpRQsdAbdcoffvzXe5NRJIsdou+blSb aXz7acvNIbiQdh5kVfcvb2BsELiMSzC5xVFN1zbEgZ52nIXPfJ91e2m97lnjHOo= X-Gm-Gg: ASbGncuikltLRgrAilV3XpzBuJhEiXDooaGs53OAKztroPEtTh/HVs77par2NnsYGtp i2fcDyY9mF9V7fEFH2NO0yIH2uMD9fojXCgoScI35vQR+UKbQoHl3LAj1B7yir+MvWA86tzfrUE xxhdnuhu+zAlOG/KCxN0Bpv2CxzztNF+vchIchDYGEBFJkoXWO+P/91aS3zk8P5PP3/O/7ftVKS IZnrkDp3ZlqqZ2X3308o7lw1wu8J/OcgwmXhMTcvh6nz3FU0DRfnaHQz6KCoDIeJktxPdPThr1V rROY9wlmfGt8OMSrn8LuTs1/X9YCYTzBe1S83w== X-Google-Smtp-Source: AGHT+IFBHgqI/Cxfb0Fe7GnSQX0dBTR8Ei+wg1va5UMyVSuvAr5jqU2pls0VxHNJRirZpFzVr6R2gA== X-Received: by 2002:a05:6000:4027:b0:38f:4acd:975c with SMTP id ffacd0b85a97d-39d0de28abfmr8610281f8f.27.1744009996357; Mon, 07 Apr 2025 00:13:16 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:15 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:10 +0200 Subject: [PATCH 01/12] gpio: dln2: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-1-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1429; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=+n19bsYgJ9JYV2dFC3UJAuU3dlkEyRxjh8PBYfyEbIM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIgmH9ntPZ/6dk4gBE6hPGCGhE/lByx8cce k8UINLyU+iJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX chDqD/0Z9/1FeuoUlnMoAXDIXhzac/3fSTa6xFAnJgTyJfbhsEsUh5CIYenipRVpDmY5T81G7cH eWYEhbJKuQLRvi9UXr4HhimopV1bi7S0wAg2xoz27GPQAXkW/OxgQs7XfZrgFqaAmUhpf8xj9/l MQQlRFfK2w1olppK1HpMvCSXKQHxeh2r3+ma9sgdTYkWatE4PCI9gZaWjjJi1sGzZzX7FdcP8T8 rYBvaVoMirOR4BmWbhp2vJq4+CKR5TTnTZ/8TZFj6Ibb/gFun89CaQdAH3QVe3myF6YSpeIgXDv U3uv6i4VgMFMuvFP0uvHOa6FN3kD4HDI/Nj1eMPlcdX7NbjC98UCysrNoJqlxngT7QsENrhFeeY vjs2Wik4oEkIiNWChZPE8Mbb54H32/VYDlXenzlw+Iy+UPa04d+5pn6z4zwrAEvWQ4z9Ojl303J Uj25cc2Nl8XKdn+YCb86uOarCsfvisuRAXbOTE4g87GG/5Ssa9S0hmP70yj2SHhYq4o9c9GTAS5 DwDJ2Da246eeAE67fyWnaIrOkPc/YEYSLFhCquFBUdp/gZgTYlhwG/2z9pIxHN2Xl6lBQfF7xgo uoyy4gDFXFQyp18mUyQERyxZLF9nUN4/Do2SdLM47h6x63M8FYf0mVFoDzkhGXgWp+sFkLNunLs MJOQzIRGZ6Q8eLg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-dln2.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c index 596da59d4b13..4bd3c47eaf93 100644 --- a/drivers/gpio/gpio-dln2.c +++ b/drivers/gpio/gpio-dln2.c @@ -220,11 +220,12 @@ static int dln2_gpio_get(struct gpio_chip *chip, unsi= gned int offset) return dln2_gpio_pin_get_out_val(dln2, offset); } =20 -static void dln2_gpio_set(struct gpio_chip *chip, unsigned offset, int val= ue) +static int dln2_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct dln2_gpio *dln2 =3D gpiochip_get_data(chip); =20 - dln2_gpio_pin_set_out_val(dln2, offset, value); + return dln2_gpio_pin_set_out_val(dln2, offset, value); } =20 static int dln2_gpio_set_direction(struct gpio_chip *chip, unsigned offset, @@ -468,7 +469,7 @@ static int dln2_gpio_probe(struct platform_device *pdev) dln2->gpio.base =3D -1; dln2->gpio.ngpio =3D pins; dln2->gpio.can_sleep =3D true; - dln2->gpio.set =3D dln2_gpio_set; + dln2->gpio.set_rv =3D dln2_gpio_set; dln2->gpio.get =3D dln2_gpio_get; dln2->gpio.request =3D dln2_gpio_request; dln2->gpio.free =3D dln2_gpio_free; --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C475F221F1A for ; Mon, 7 Apr 2025 07:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010000; cv=none; b=KVNiAyUmcmys9yQjpqhwVPCjZi5k9P0/fcfCF8L3O53QSypPXr6TmkUHG8FN956AXeoHpOsIBGHGRamGCHbCAOoPQ2Psq/jfTCAJiuSjuafb4ssM3KFPL7z3ZexRbCjJBLrU3Q0xuCjBaNkxOIK4T0AfjrI9mHoEIouHXws0xB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010000; c=relaxed/simple; bh=v+UnjFHMxAqwy94M3qJUXymRSNqizlBnKqSV3yUkTwE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ImJuPqTCFkO7E3wC5Q5Y7NVSaNQB8F7InVj6Y3ipVV+2YktXnqFmUFrjUHBM6xpGgFBN6tk3X8dKQ5ImjQXW21wpu8ON6Eb96MtMtaiR3+nZwmFaMzKwAzZ6SUiGYr4LZE/3TrMLjTWm8d//6Oa2yahBtkiZSy3jbROM+OvU9Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JOCJVjk2; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JOCJVjk2" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43d2d952eb1so26659995e9.1 for ; Mon, 07 Apr 2025 00:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009997; x=1744614797; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1zQjLtm40iNq8UW8XbxtAHLJFCmbbdZctSQ9irwpSVM=; b=JOCJVjk2s3bpMHY/J3TvNY8lBqVbFDDvtxoKs8TEsGQLup924DDGkcnv9YAdUwGSOy zfT/y3vFuTozqYlfCG0sEcSpUXFt9QghRsLqUPEHr9m1kIclXpARuvLruSE8V/7H93tH LrhKBjDBWuvFMwzKPh4nshJP/3+z0Lv+1cBMHDymWmU2QWd1d27YC7ZeXeGFRMjG0X67 hacjxhZ36Kd29ns41Otvxdnt7mB1LHdRG2rWa9ekDv7PnorJ/NZsQKn7Ds9PNVRoqLI5 iq4W0V9diMvsTyK6LOTIRsUbz6f3A6SQhQcL3DzxT4e2pgLdgtzzLN89knlX/iEWK2JX M3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009997; x=1744614797; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1zQjLtm40iNq8UW8XbxtAHLJFCmbbdZctSQ9irwpSVM=; b=KGDXhRgBMH+YUwc37NmEQxkUKNaCfiqveDPiqUXppKaarGDeiiN3KjHfkkhowp6NeW s08SzOy4UtSnMLlpYLZH3acY0fSzNgJZX340cFU4jaPHdLwDud4vAJx2OulWdIELPNJA zU+1II+KPjP1lEKUcGgt5UKrtk9THBR7IKp9SPNyX2nmClSJ7okyuVjgzHRH9+IodgK5 f58WQINuY80CjcgFO7UfltKfhPKn3k+N+ZD0dEizfWA/o63XTmv/JVYzjCic0xD2XL/n 0BMXPMr2Z+cv1XH4zFUSFFMgRD8HtCmU361L2680Fme81ZcXGYCjJIf0/tHS4cqCkVK7 bRyQ== X-Forwarded-Encrypted: i=1; AJvYcCUR+oCZheB3galpej8SU2jTad2rpe4h7sCE/A0qZ+i/b4dOgfAgq/ceCqJePKTjbN1dSqcttKSdiHCRMy4=@vger.kernel.org X-Gm-Message-State: AOJu0YxnOxZPKqydFcQZJ6qeFhrWkgVZiaUUW0zWZmtcDmB+Uk3Zpc88 ggoFcshOcSv/gcnmsioqUjfxzg9Na8App+m+KVsQ40HqFRaWj8iRuW+OaQRoH20= X-Gm-Gg: ASbGncuxxu9XN+jkeh5trwRS9DJkQDUDU50XbJhZJV2fGjtyORMXwSDLq/OUqWq+GxK 0/rM0s3mFHIpn7MQPlRpO/tKiqU6eqsJEfXmsdtXUF3psTdRMqSzgUfzFtITR44C+r1EmSNt6cY EpLu+7BrNtCDJ2F8hfQSjvMdQc7jJtmqkUcqnUg5L9mmrd7JKsiJCgBEhGrugyo8TmkKHrLcQBE UDJhKsYlyQAl2HgXlaobwMHyJrc0pi67+zBKe5AAvMtcqcLAdsymMstVEyZExyorkCZMOsEV5Mp NVRYOeVbFRTpuCkVbvon9pFNBy7FY6uodwMh7Q== X-Google-Smtp-Source: AGHT+IEW7+lJhkewxGW5VJOMPuyU/iBjF8bH7O39UlC3ofjb4Ms5uuG30X+9kSf0GSUz28JKAf67NQ== X-Received: by 2002:a05:600c:a013:b0:43c:f8fc:f686 with SMTP id 5b1f17b1804b1-43ee0616fedmr85967385e9.3.1744009997193; Mon, 07 Apr 2025 00:13:17 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:16 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:11 +0200 Subject: [PATCH 02/12] gpio: eic-sprd: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-2-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1334; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=5A6zzhsqbuFQhR5Hofol1LNkPbnT0JcOJ+YNZXE98OE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sI2V8zg5FJxMUMaRkfC07sJYiSRsypxrJAp fMycLk+/4CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX ctb2EACByYklX5SCC5JSBbz7+I0EJoIpsFeBpLsSw9cMfwVJR6/NjsCfNRLBlVKR2r0zQk8BeaV aJzHRRiU/+YR9Ll5nnZ8EzUY61sez3gq4+gS0pmbWUgD5WTXG0iPIji4hc2Zig1ykKotvAPmiOb dLfBqcCq4lKcaJnD4/c9VMa8Xr/JdoQJH13Fj9D8cNFEfVSwkAOEk3E7FOkpKfkm1aPiC+GflqP aZVFO27Rr+HVoZGz5FaWR0is9cEl+bVpfwcMygi+LgBSZTSw/hMj2jFOsRDGePVWZQTbfgTJpIG KpEk3X+2vJXV6BGiL7qlMCdcy5b/yT+zNVUar41GWAYN/XztovlRC0uW0cSF7gc77lY0YxdEYJ9 fUZ4pewLtTQ2lvZYxj0vW+8JePeC8d0te7Yc0GM/Y3try6KhZ/6juUrfIqPzvjLoMHASSJjvzzB DnpUPDEJ5MqMjf2rPZGrombA7n5maN5iGxAelCl4cgJBhjI10bnmUYEY5zTUx+4Xvy45I+Eyly1 d4aEigjzYbpRNlbQ2UxzgqEL7COF/b1BO0h8Gomvvjng2IcPtiomsOOd7dEuwousy/8a5pX/K4y 5Y3Dpb2LRc7TPRSWGnP1ngergD005KqkQdLYkY99nYhVuc/D1crz7tcN/XbcJ/IzFK4APqtbZIs zPRljQkkWVYv2zA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-eic-sprd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c index d4bf8d187e16..f2973d0b7138 100644 --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -203,9 +203,10 @@ static int sprd_eic_direction_input(struct gpio_chip *= chip, unsigned int offset) return 0; } =20 -static void sprd_eic_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int sprd_eic_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { /* EICs are always input, nothing need to do here. */ + return 0; } =20 static int sprd_eic_set_debounce(struct gpio_chip *chip, unsigned int offs= et, @@ -662,7 +663,7 @@ static int sprd_eic_probe(struct platform_device *pdev) sprd_eic->chip.request =3D sprd_eic_request; sprd_eic->chip.free =3D sprd_eic_free; sprd_eic->chip.set_config =3D sprd_eic_set_config; - sprd_eic->chip.set =3D sprd_eic_set; + sprd_eic->chip.set_rv =3D sprd_eic_set; fallthrough; case SPRD_EIC_ASYNC: case SPRD_EIC_SYNC: --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8718225760 for ; Mon, 7 Apr 2025 07:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010001; cv=none; b=IQLKOg5kAaW8mzCoU3tOtEKfdPKy2/7vf5Q7Pa32N0ahfjzZQ6HoXX+dy0lJP97SyCrLRT0tz6MQuV5zsN80ma35XdGV67U0haoEIxdn3BddMj/9+e6bvjUd9YGdYjI2edAyeCIt2vp+dgiVrmfL8wMPkHI7wFpMYgEhwZO4It4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010001; c=relaxed/simple; bh=3UqRWBNBXZo/ZeZgdiat57DVN/jGiDxmQMa8wMm3mEs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YmJrb8AWb1E1G489MQ3EwiBHYpH4Vk29QbTbysqf4OTv7/y8Swevn1W0P6IPD2ICNqxycPj9od8UmZREkHI1KFCboUG/8xVVFPcDeCEHwYs5W/+j1Z0xKK+Mnn7Ph+k7qxc5PGrd3cA2pDTh3VqHbr95zqqVCuiOfwUKYk4Wgr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=IdPcTtiV; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="IdPcTtiV" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so20697975e9.1 for ; Mon, 07 Apr 2025 00:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009998; x=1744614798; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=g1fP3xcbZWM3sDn2ueQ9yrMymsFb75Gu1/jl1pJ8LTw=; b=IdPcTtiVgu7JlkSEIrOoSX9S0r45eoTQzC/eQnA0V77LzBDWGq1H8xEHOh40AHjTNb ET37NePXzcr/KkHMcXrOge393dSSURvNDhVFe+ggEgSYo5bzm85WIzryxHwYe/Kv/GSk 2fF64N9dgt7k+KcOB7sR6VTci5GEm/seVoJBNErUHQ+L3F0aCoHXcSBv+4p2OQJwNSSv 7u7n7nekkr827OxDgBFFM05Yxh+2JFdl04NBHrU2CwQGDqOb3+fhKtXX2eG/RDaiL0Cs l94zo4mUveByPOneXmTjjIGcb7YbisHuzUjKPDcNNGHOe2tpyGTXFL+MDb3yX6oc7/ja 4/Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009998; x=1744614798; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1fP3xcbZWM3sDn2ueQ9yrMymsFb75Gu1/jl1pJ8LTw=; b=DkGU7cKvZ4S/KLb0twnM4nwAXg3zTy4td3s8z/m9RbtYWvWDDv33EmAiErgRPzDH+q rTJLpJefRM+mki+ZNAZIeX+4hd16XSyVYK1GjdG2Eq4Ql3/ViTjtUZ+p7AiWB7rFZt9l TfxxMsvTPm3lDOJvfpM5Gz7kk+sQdoVdXo6JDPBeoT0saiE1q0Oz9VMT58ox9WeYUibT Gc5+iC9QyehjOMytERZJmpND048WOfQVQ0D0ljoLsTfQN+OPSDnETtK+lUNnMstpxivA C1bXiJ1OC0KeO63t4trJ+KNDXtL6NbOw9KYZleeF/Q65S8zydBCXIjIyUr1RaJgzKitd 930w== X-Forwarded-Encrypted: i=1; AJvYcCXDZlS1+en+kPixttm5PYKaimGW+48KskdO76+gYSgworNKG3+kMj1P2ZRQjiF+dXHX8oL8CMuVv2HzmLE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywo/1RvQGHGhvL3lMnI6RCdC0hKQR6pYzp7tvEn1cjl+lV01ySl NjufYdXKyl1W4A7y4gzt9caLe3wJ7ska9grDv1dSFhGwmKMmkLFqUMm8ONR8tRk= X-Gm-Gg: ASbGncsdrhQNb23s+5H5XgSy6rK9iQ1sGsaowcgyXv/C3owh49r0ceNgX2U+QRZEv3D bNI4HPPpAIYFRPN4SGpAj8471lLD2oSY2uZqPmG2FPecLryVBg8/JjLCBepBLgxCLxPAqPrIyFk s1KgbTEXutQKu6Tjp5AVwAHDUt1qaGkPanhmvb5P5GzBy6WqPgU3/AzBObpDKJ0hGvEEhJqlOvK c+A7o2JfSAnourXOLOLoOHsSOVNDnCC6Mqsb+hnU25wSCbVKABn5iL5nMbSzJwYDepkrvWXJveP iksGWEFJKcpfk6NoS47eZL1C1HbjsKDw98bXmfJHW3kDGyJt X-Google-Smtp-Source: AGHT+IGzLgILttDxO1B8ID6ZmYzo6UknUTAj6YgLYVfn5lH4jvVbwUel10EFxuC86rN+5EElsQDGrw== X-Received: by 2002:a05:600c:1e13:b0:43c:fbbf:7bf1 with SMTP id 5b1f17b1804b1-43ed0da49e6mr130036885e9.30.1744009998188; Mon, 07 Apr 2025 00:13:18 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:17 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:12 +0200 Subject: [PATCH 03/12] gpio: em: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-3-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1477; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zoMPRDHW7Y3vEjectUVkjXPywBkkJrvFak4r8W20jMQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIVNSgQwx43danFZuwlKoFhMjhiY4tXyr3K hPcVKvFHrSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX cjyrEADFMysjkLjIc4WN+B46gtwK7IJ+YVCQQCJApl4/0aueqbNPycaFo8kpJ3MlEQABIFK//YC mPYqV+EPiI03ax66V45tvlBnBE4elvx3DUeEvur/yjdOAGJS40SVXUBntZlCnuCuRzHC96vDNcx 5yiV41OIBqFD25ocDJxlIQTnhzfb5usz3+t9bkcvbah6vDS4sHvbxrre+67+vIraZQ58GFE0Jpe IjQUBSkZ2WaA0Uq+4d7HXY9TYEtJvn2nzVwSgyMUQi6iUKG3bxxt/PWDHj+BSIhUOk+AJgRWe63 NNeT8Loi4x5F51xpLgFXHe2/7BrSAZaUQZ2H5YizUY5cR2K7UfXywccY1FUlGl9ImUqV7PnfrFm S/jdAWb9COZ1rkCitxYVX1bEb1Un2DujKjPQJLMzn1HcWr6iURKwXTxTKsjIY+xPG2pecEIzB3o EPnNfFBtGbjvsSaCGDm06EiD4V0o2C3BF2uu4LH7BpQlzuYa0bDjFOueCufLBFhPRWyjOQlUuKd mEZS8chidh6g8GgwfWfOPh+/eT/19cbCPDi6LKp4+TJwlAoFY/6x4XIsAYpNXENGItGQHAZdxUS NEDpumQOLGrDleqcTZwv0xiajhTebODEPE/mzCbAj0Cj9RPyY38A1RuAvw0pTficQbCASosENsf 7kxItCqcsnjKYew== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-em.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c index 6c862c572322..857c28895131 100644 --- a/drivers/gpio/gpio-em.c +++ b/drivers/gpio/gpio-em.c @@ -204,13 +204,15 @@ static void __em_gio_set(struct gpio_chip *chip, unsi= gned int reg, (BIT(shift + 16)) | (value << shift)); } =20 -static void em_gio_set(struct gpio_chip *chip, unsigned offset, int value) +static int em_gio_set(struct gpio_chip *chip, unsigned int offset, int val= ue) { /* output is split into two registers */ if (offset < 16) __em_gio_set(chip, GIO_OL, offset, value); else __em_gio_set(chip, GIO_OH, offset - 16, value); + + return 0; } =20 static int em_gio_direction_output(struct gpio_chip *chip, unsigned offset, @@ -304,7 +306,7 @@ static int em_gio_probe(struct platform_device *pdev) gpio_chip->direction_input =3D em_gio_direction_input; gpio_chip->get =3D em_gio_get; gpio_chip->direction_output =3D em_gio_direction_output; - gpio_chip->set =3D em_gio_set; + gpio_chip->set_rv =3D em_gio_set; gpio_chip->to_irq =3D em_gio_to_irq; gpio_chip->request =3D pinctrl_gpio_request; gpio_chip->free =3D em_gio_free; --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D86CF22578F for ; Mon, 7 Apr 2025 07:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010003; cv=none; b=bChySF7hF0uzgckAJcCcKVqawXtUsAXOslgRPgGivWPdKf5XMVkfitlP44yt9f6YCAH8DE/BaCiAXDDnTje4DUn0r42Q9e40XPqTR6TVNRbndEuJaEwlNGr3o0Q84jOvXzAIoE5jzXHoDoQxjDx0WrEnPtl3F1kxaD/9HvO4ZW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010003; c=relaxed/simple; bh=RkgKWhSsIhzUGPNoN0mdX6+aMhttLmif45hukjZbTak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fGV6alj6igkoL35MfokhxmP4NeltAcBVG4ZOHKwke4eOmpRWNR4usQEf5okUR2ovfOsVhwMCeZRipFDUfaIHClun7itifrWpxlIRjnxB6da4GE7p9v9tzqfYW8g5PTaTvKUIwEh+YxHke6eHJ0skp6E40jdLCT8k+P+Ac4YR7K0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Y0eV9Ely; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Y0eV9Ely" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso36746745e9.2 for ; Mon, 07 Apr 2025 00:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009999; x=1744614799; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5Wepzn0bSrTUctNYJZv2tNgjnTLDxfYJ7sTLL6ztZhk=; b=Y0eV9ElyEWsNC26ae+aWsk+VQJUCR6i86K83WsCONwlnsgv7DIsfam+//8fTcmI5xm kayKIr4Z448ikiJViaCUQ9OhJG9ckTJmXPvK6oymZfBtIrVVrJQETybdmQ8rkKk1P4o/ d9MEy4E4j3MBvjsOCmr4FNDASS+WdYfdZWEa+nW6oIRswgHARbfY1t+1b7SkHU9xO3Vk 9x2Q8Nr5XUqUOJoU5fYK9tkdfGV/K1gPeiG5hKCRZiV6e2A3bJ9vMs4USVjYu0gLVdz9 lbF9bu2/PheH747IeMkWmSeIiUocxDJ/itcn49n0jTHtIcwtucImmQViNdhJTV9LZQ72 cqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009999; x=1744614799; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Wepzn0bSrTUctNYJZv2tNgjnTLDxfYJ7sTLL6ztZhk=; b=l2u6x59E+c0UjebZ7hi44nFSgOsXXaGYFwLEiUs8FUFyUTIxpU0fIYgWDSRHhrr2xQ tasP5l439asPg7LK3uGtAZu2sLa1erhD3YlY9h3a3xRCAgGYw7fUleCh2nLcHV6Gzdlq ZnfV7CNUR9c1zXfEfZgUyJbJojDc9DkVyAv/GU1VZgpyZTRzs3rgHLK4wKLHcaMwenLg UoXE2X79FIpzetkewRx519wqYZ+JIRCz82PrNpVGof3kNGfv6qVcGffii0o2Na5rKlu5 x3NFzyQp4mSAJM1SHOojG01hQD5SanGw+AALssAiJJhhSrg4BR3bxtFbbFCJJP37Gdig MAmA== X-Forwarded-Encrypted: i=1; AJvYcCUXCF5qDfILUbpi0Fx6fffG2L6Y6BI7VPuEQKcAefSGdmshRKNuaPiSj1X2Tp9zuXQ437wYzg/8Wclbvd8=@vger.kernel.org X-Gm-Message-State: AOJu0YwgESzRYJ7/Z85uITzn2AXSb2flihip8ymCTDwiIIR1VuG/bvg4 wkvR2ZFm/4SPjwu7Hm7mxWqoDR0VmdvDDJYQyCN21AUlqOUIiTLd7zFDDzZcK5g= X-Gm-Gg: ASbGnctdvdSltG4gOeSqwb7IeLsCirfEkiqIYyhkwoAzYDa8nWJ5Siv3xiKLneQaOw0 9ngpCailVEGihWckv+16RnJunxhJf8vHQ1tvD8T7n+kAODRSkTRPE04XGB1P/LRjtrC/QVdBUOL kK/pX93OJIr2y9UGUS9EQ35zQoDwlMmjUrnFrutrZQMK1atXpoEo3DNZhpyd204SvoeKF7cYLHo fD4d2WdwL8OZkzek8j5ZAzjmqmZqzQUACdj60OymD3ThneWUa2H91LJGXjlPDJAFNCQ34zilbOy qqUZmtpi4EPO+IT5s/mA3pv4JKY9Jwb7ebmGKw== X-Google-Smtp-Source: AGHT+IGyhcE/IuZZs8QulBbS6kDGMJgDPUGZRwi3YwBtd/IiuYNtNzwObPJBI62CcG4AJbpP58tp4w== X-Received: by 2002:a05:600c:45cc:b0:43d:fa59:be39 with SMTP id 5b1f17b1804b1-43ecfa19d6bmr74493645e9.33.1744009999121; Mon, 07 Apr 2025 00:13:19 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:18 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:13 +0200 Subject: [PATCH 04/12] gpio: exar: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-4-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2554; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=VBaLRwvXCHSMDlXyQDnnPc+JoISPQ5RIJj1Yyuoo2Rs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIsJh5mSBLL9JNqgm94zsMHoeoOktkEKaU7 V2KAnuiH7+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX cvaXD/4ub9soMp+EVeLGnbmKaoZNeP/e4NlLxD38WiXqNsu67ARWHZfjRxY2BrkgMXVjQc73eMA 0oie2U/HcF3/c12LooTmi5brOGQ+fCEyeJQ6VrhV1iPTeUIngkxnqEFSwhjaR3uOZXuBTagR9FE sWH2G2b2tA2dSDIRvZFAq8oagJNspszfKhWNs2a5Y0IUWweZ44MEWAr+vOs+Bglee4oSqzhF4gw L+dzjx1n0A9OV6yCTGJKkT+KE3pMTDPO5iA23NEtZJVkSt6Y8KFr+si/0Xef/BklhQactoHIOIl poLVGDC8YF/35IwvA8WO4TMKQYfIsf5a+yDotBKUHM+cNhf1CvFwFwW0RxBXnawszz/c2nGNTfW ObCZVfJqTLx3OqhlodGwV0RH7nMxqiQddS6k409LOqWQn0NvQ/n2tjISXlVffHCtiKNemayf6aQ aO0x7xQ4PKifW/1pqzo2Qz1c4IrjV0TeZfb6InVjbuDE/r8mJ1QA3F56CGcRkioDtuJwlWMm59K wrw7CeV2oxut2HnUIKiw7T1P8EBT/ZgvZOKNtvgZn1EBxdO4bhEmqY8O7kISkmlxTUET+x+nR66 Z5Erx5zbPnm6l0wBxcpkSjm635yxE+x8qQWpANIRNYqE6xIA0SSfJ+TdfOpqZqiCibCnpkcqXqD LGUtduA/iEYlDSw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-exar.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index d5909a4f0433..beb98286d13e 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -93,8 +93,8 @@ static int exar_get_value(struct gpio_chip *chip, unsigne= d int offset) return !!(regmap_test_bits(exar_gpio->regmap, addr, BIT(bit))); } =20 -static void exar_set_value(struct gpio_chip *chip, unsigned int offset, - int value) +static int exar_set_value(struct gpio_chip *chip, unsigned int offset, + int value) { struct exar_gpio_chip *exar_gpio =3D gpiochip_get_data(chip); unsigned int addr =3D exar_offset_to_lvl_addr(exar_gpio, offset); @@ -105,7 +105,7 @@ static void exar_set_value(struct gpio_chip *chip, unsi= gned int offset, * regmap_write_bits() forces value to be written when an external * pull up/down might otherwise indicate value was already set. */ - regmap_write_bits(exar_gpio->regmap, addr, BIT(bit), bit_value); + return regmap_write_bits(exar_gpio->regmap, addr, BIT(bit), bit_value); } =20 static int exar_direction_output(struct gpio_chip *chip, unsigned int offs= et, @@ -114,11 +114,13 @@ static int exar_direction_output(struct gpio_chip *ch= ip, unsigned int offset, struct exar_gpio_chip *exar_gpio =3D gpiochip_get_data(chip); unsigned int addr =3D exar_offset_to_sel_addr(exar_gpio, offset); unsigned int bit =3D exar_offset_to_bit(exar_gpio, offset); + int ret; =20 - exar_set_value(chip, offset, value); - regmap_clear_bits(exar_gpio->regmap, addr, BIT(bit)); + ret =3D exar_set_value(chip, offset, value); + if (ret) + return ret; =20 - return 0; + return regmap_clear_bits(exar_gpio->regmap, addr, BIT(bit)); } =20 static int exar_direction_input(struct gpio_chip *chip, unsigned int offse= t) @@ -209,7 +211,7 @@ static int gpio_exar_probe(struct platform_device *pdev) exar_gpio->gpio_chip.direction_input =3D exar_direction_input; exar_gpio->gpio_chip.get_direction =3D exar_get_direction; exar_gpio->gpio_chip.get =3D exar_get_value; - exar_gpio->gpio_chip.set =3D exar_set_value; + exar_gpio->gpio_chip.set_rv =3D exar_set_value; exar_gpio->gpio_chip.base =3D -1; exar_gpio->gpio_chip.ngpio =3D ngpios; exar_gpio->index =3D index; --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C644B226545 for ; Mon, 7 Apr 2025 07:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010003; cv=none; b=b2zdLCKmD/zueVeLU9yISwtDTM2LssbfFGV6Y/OnX7Ehf04w4j+n7SP9uPgrQzf9VGUFchzGxzm4o/4CTXy5UYy8LxOACRHkcHhsErGW9XvOP6Zi8jALNHdxLrCeahjup+6hDmg33TTpLmuxIzplfBhJ5SVvLJ5/I/pOXMxnQzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010003; c=relaxed/simple; bh=mlVNd4QzbWckE0pUZqiiANKAP30ys4cnmjE4RIMXci0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CelObB0juRlfusj2Z6NXFRcKSh3Jisq4E7wd/LvIjXK7HBfy5w7Sy7lKZbDgndw7vTF7VF1uQjUh3UZQ252I2NcmOTFgUbEDiaceXbjVuBFO3dxcbZZc+OS82gIdchPlmOkHlMw7HuxtkwuVBTxYj+FYK3hYymkz6kgAhdzh/xY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=MHYJpc5f; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="MHYJpc5f" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43690d4605dso25834075e9.0 for ; Mon, 07 Apr 2025 00:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010000; x=1744614800; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uGiQ86zVLb8JBWVTSCwg7M8Ca/EW2/+PddB7ADI5980=; b=MHYJpc5fDJ/qXwa0o/oh+gFKMpoQetwNZCVxw/J+N7xWlXmyVX8ZzG/A45bZg1kTWV wU9ByJ2RRCSD47gP0JY+sWWjKrVgnRTklrh37tj8OpAuUCymZ43p3b7Txm7DkFGtUCOT PS+BILJaIys5Sx1oNrDUaMiFA1ISjdivmXQywDK1KDEvxDP3kgchGHzWUXxNE95sjYEj fkveT571BZpoP0RISjGs35ec9srkBZeaW3o2/82KsLlPoC7Gt2RSujDU/1O/HpOS+Q1r Mxr1BUB+9wEoqlRqhBLoeLsw274km5277Ec7hmSCwZd22el1HXHzdm1SC0DNMDv3eDtV p+GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010000; x=1744614800; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uGiQ86zVLb8JBWVTSCwg7M8Ca/EW2/+PddB7ADI5980=; b=Eop/bztzo1wVcsqXKOmdpSzmjX20LSRVmVU0RfFl0bJvzleoQORnMNrW7A18qwOFMk wKZpctybqeUA8WfqgnjVbM6M9qONi4oGqxBKqf37JuKzADWraijqqIAab53SofL5PnQQ APNPCRuCyjm97kKeHLVedXJxaYiaubj5qdgczrhtHfhxm7YAw+wrEOfga50JD+knZGtz 5zCnXXd8BaFJR9pRdKaNoRLwdtqojMYZWO7LsSlRwsAGZxNALjHktU0eszwy6z19ROUK a2MLiQYxilRP/zTDbJa9uCCuKTT11H4ruXzL7S5UMKAVd4GSpaBT9bh5638BsdY1Zc1S hl9Q== X-Forwarded-Encrypted: i=1; AJvYcCVRkYTFwpsGZVWE9j3esFC3uY7UWcwWJSdWaTP+oTFm/2F/iz4fVTxpVzOvTG25qNOlPpQeU/8LQPlZkEs=@vger.kernel.org X-Gm-Message-State: AOJu0YzD8XOVOlQ7iaUBulmE0FHmfsKZxSmCsIq7qKuP5ZM66TNuAiLm Lr7kEKe+EEwdV+MJIgNwCPUOhoRAnc14vEyZgoH+THu0Cw6R6+GU5Qt7K+aLmTE= X-Gm-Gg: ASbGncsc9fpTc7k7Y403Nia46uYL4Jw71wfWJcSyFXKqbrU9AR9mv1Szm7Z+nBD7Jmc KP4UKSRT4fEI+77zqNF3ZmuL8a7EeOObuCUAHjqww6nIAE5Slr4zGj21+EXiB7qpKGJasCnq8UO 3OVVr/rTyQDMoo3yJbcUHhDCXJPnUe7lQgxhJo9eeANkC63bxgWngfG8qlRoNx0z6PoBGKx8dt+ 1HG2TDxJ6Kh5/PfRS7E3445QxS6PRanlQioYdRjgBqt6IUcD6siUdJ4y27WVjLE2Ud6jLQW9/0Y bC00lUw6P7SH89kvAd9bnJfG9St+iNgC8/6QlA== X-Google-Smtp-Source: AGHT+IFMnQWMuXkai5VCXN90Uk17NVhGiPupnkywvYdtceCZWC66wkfhrPo8RcuQDGcdn6iuyHqaJA== X-Received: by 2002:a05:600c:3487:b0:43c:f3e4:d6f6 with SMTP id 5b1f17b1804b1-43ecfa19260mr116571865e9.31.1744010000060; Mon, 07 Apr 2025 00:13:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:19 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:14 +0200 Subject: [PATCH 05/12] gpio: allow building port-mapped GPIO drivers with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-5-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=700; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ksPOnrqfUjMkoYZLGB0SWQFHhunit4ITjl2uJIRK0Yg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIDZLdYKCIe/P9+rZTbVOSO0B1bCxS4//IB 3GXgNF/C2uJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX ch/oEADNhrWFl02g6tVUm0/cA9jsOsiNTwNcnBwCuDN79Rt4qiexiZbteq21vXqTooFxS63bA72 W6G5cAh26pJlvvhYhprqALqd/sm25sgLImAiDn8SBb3XPsVMzwoqHvXl+th412fMREFfW963Y81 leLjIZ8M3Om09FS/7XTEMMc9n/qfiIJ8MRnJMvl5cliLlJ166xZwTwQBxn8ae4VIXrqPFDS6XDt elwBlZNgyBIt2SfNtfL4qy2uKZgLG+BWCcNo6++0KtsTa+eE01VR2EJIQbIVH1/WnSshLa7yAba 6vtjej0fx2nScSz2EuOe7j/pnDzj1zG3AvgwiZX5L7gtIVT6j37ekiPvjFJ3WnVkq5Jxt0nZ6gl v5Mh7qBhMkh7lASXOYYKOxUVF46ZzBD8h0ew0C/P83rbX7snnPZNzBB8fk2i09u2GUmGySdPWeQ YHB4EqZRol9OX7E6ETcjVj+u5reO7prWA/USytpHLzS7KLYeBQi8RSrEzrnLNNlKDSOvWLMukpc 7tUodVghIv0pVo2hTkRbLNe0smarjiKo0Aup06HfCpUfMolFZZr9Bxae+7wMEFZBZekmd4AoYxJ e3T5sv1CDezEySaexV8NhwaZ+nZJKILew4WcC+twGVIwpL6/poQqr3+ubwShlFHj/AIbgilIYP4 8NiXhKDPZMJEmdg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Extend the build coverage by allowing the port-mapped drivers to be build with COMPILE_TEST enabled. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index f2c39bbff83a..5bbc7f724a09 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -889,7 +889,7 @@ config GPIO_IDT3243X endmenu =20 menu "Port-mapped I/O GPIO drivers" - depends on X86 && HAS_IOPORT # I/O space access + depends on (X86 && HAS_IOPORT) || COMPILE_TEST # I/O space access =20 config GPIO_VX855 tristate "VIA VX855/VX875 GPIO" --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82507226CF1 for ; Mon, 7 Apr 2025 07:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; cv=none; b=YyblDos3O6WTU1cyJCd9PMYGxMZyCzkAeRoLJhaaYprF+zDQ08/xddGZZuCk6GOW7TEfUlNDndvgIjqkhxYqyfJQtUaWXwC9qUNo2OmF8ldhU5s1VubUQ8UuX5n5BRUOV4i5LtATixqSnPDLsYICvZYDEm1i0cHNcVc2MqJfIIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; c=relaxed/simple; bh=VbZuTeEShYmVixzs0kIfQZ57MYY5VstzY1jAzTWwLiE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SmxWS58/FYiDi2nNjBilsxVzOjyoFUGZVjqpnc+ukTvyqv8PnZOcswLXRXQqvEEg8jSB/cA3TTp+GT7JdsyA8/x+teEOR20kSC9g+tfPWeau+kdy1tOBub5FgFC0CenPHhTR79gziSQYVRqTr/IXG1AW3ZC2h3e0YiAvuC/Dg0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=0riiuzTW; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="0riiuzTW" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so39754275e9.3 for ; Mon, 07 Apr 2025 00:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010001; x=1744614801; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YSDY712S0/Wxg4mzs7difRDaGrtlnIVKA23tPccTlsI=; b=0riiuzTWIZrhgp56IlqIG0qCrZIHSCdjtAeA9ugADbOTZXDWPdJ4x4+KgM/vhsMlH0 lMsbQJ5gO9KUCkIUViznu0MGb0rOa8AbVyl63WfdbA6R9ml23efQWm0da7iiFRarNSB0 N4ZCGaioBoNutRBin17ZX+9wOjhwzZkEqfZawGBw8skmsAV6yrJ8ixl1aXOVEIa53EeQ 1uEkhAQfgNbNSyRcuyMZoA4cht3UpLyOj1j60SriPcqizzZaxOWlUOTxL79ezhX0mpKd O8ugHOKJopApn9WgZC6Ba77jrxwR76rljgkUCdK5IeCOiLW6cz8i7USPLrFKwOlHJOVl hgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010001; x=1744614801; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YSDY712S0/Wxg4mzs7difRDaGrtlnIVKA23tPccTlsI=; b=JKHZbcM+1HO65nmJImEaqvnZFcQfFKtynWx0gV+fqE3DT3FLSODbEcbtIpKxOUBidu AX0ntSDUNaJvvf7/i2DB87JIycVCjtFFJZWJGnJv0ghVKR7CD53spBYG4hzXUvqxctdR TfIElmnTBpJl9god+b80TvOON9TgusbeFsDZIfvXXc7PB+cpJc/lPMUb4Wgv7hnKE/i+ yAspAW2Fp8H+xbaswekgiij4Sb7eQ1XuRhkj4Eat6eis7dR52OAu9PMpgX491KJ1RNNJ BIB61IC74CUK4GufUhsfJsJDU/sQwfVnvGUd+DBGIEC1GjQAIpw8BgnO8nb5oxk6qZeb T7JQ== X-Forwarded-Encrypted: i=1; AJvYcCX4c7CqaqHY8Dmle5YhbLIdXFtI8BmQ7Fbo0w1Acc1fIu4vmPZiSnJXd9V3R0jPm2nuv54NLe5I5T5mfF0=@vger.kernel.org X-Gm-Message-State: AOJu0YwqPcOdJbYhD1A0k6A2XxcbL1YXCOFxE+mGlV1MJAk0lY3awTeT S538dv+aHMR18wccqDkNUELVunBtT28E5/fHFCmfzcsz/LAmwtXnc40X0HgjUrM= X-Gm-Gg: ASbGncupV40acyCYnWJJb7HvByZ7rnhXNtkwRihR9rf8SHblmtcUgXMcUutoNvEngrS nt9i7FWCMv4mIEz7YUMi/zO+3b/0CsAHy5OHScQ71QSKB432i0WrO4JMpQTPmkQlt5cm3Jy+VyY h6X6YipOT2mkK5qRV+C8jGWPk/v0+C9uHhmQtVpwnVP53LuXWUJHtyScIFnnHLRwRrLms6Kr4t4 eiyrz4DW5CHuRiL5jP3ZaLZG/ra1xnsoz4MXJyq2AX67Y6yAQj+V2D0nHLbCYkIqOUzHVK8pLhr UQBMjP1YfSsDj5vcZg1Z37fDH0+LWT2++4Sqlw== X-Google-Smtp-Source: AGHT+IFCPF3WdKv/HZWi0huYb++Hp4umiM8q5PvJ/9SfnEDEYHIn12Tjg/kKEV6/HcpEk87YT6PKfQ== X-Received: by 2002:a05:600c:a0a:b0:43d:3df:42d8 with SMTP id 5b1f17b1804b1-43ecf842bd2mr89719075e9.6.1744010000897; Mon, 07 Apr 2025 00:13:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:20 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:15 +0200 Subject: [PATCH 06/12] gpio: f7188: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-6-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2501; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=1b67qrjUPm1DOh124uZXcfJBUtrwb+Jww2K8ejW16NA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJQUhmhYV1wPhQ66erTJWK92WtSnk68vdCC H848tLz6NSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX coM3D/4uh4t6KFMWNiPcBjAHTAxxSutRwdhsxAOrRc903ShzmAwt20DNlXdasFgvS2DONygGWCM b/sKbNtOrXL2rxomUKGvZhKYliMxzJN1kw4NaDtWELBEfLGWCjb1EaoL1h5QstUbMx5MsLAmI9k Og6hCkTqVrfAvKos6ihvGVG06oINfTtRspW/0zhLVz3uboaSP4NoxEjln/DHiGPtOh23c5Vj/Rh LsbA+RlT1FZfMjHzoUm7tMC2HOGwqUi9hpitMS1DO6bHR0CsaAF86fjT01LBJu/iKPAAxVDzhF/ PNgbFp4VTqdcDi+LIcmn+o8CFKJF635apTB8Z/heElt78ohUO4j5rGUbTPexJvK9LWlDzrYTXJc JJlOozod4hWPtSch8qjkQq7ZNYpUEfuF/MtH3c6lz5zvSMKVhCSZwzlrR8EE0Dp87W4WIuqRKLz 1GlQkCv5MLnsGvpHAvZPJpEvGMHNfSaWwQdMQAD7vGf62ZRGwsKQuVvkdNmYNrcKHV+M4BUC0Sh Gj6crCBsmQH/PQy2lBbBoyALEURBT2mwmwyMW38NHdIbcTGlKmP9nqvrx0YYdnDbKQG7e99TPo7 /pe+YMOodLFD9mYLFDydKk/R3nK3aabXU/OFVZJGDPUtABuUUj/G8GWOC9WjIW9UTopbvaUKVci jvsB/2RCKq8EXFA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-f7188x.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c index 3875fd940ccb..dfcd3634f279 100644 --- a/drivers/gpio/gpio-f7188x.c +++ b/drivers/gpio/gpio-f7188x.c @@ -159,7 +159,8 @@ static int f7188x_gpio_direction_in(struct gpio_chip *c= hip, unsigned offset); static int f7188x_gpio_get(struct gpio_chip *chip, unsigned offset); static int f7188x_gpio_direction_out(struct gpio_chip *chip, unsigned offset, int value); -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue); +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value); static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset, unsigned long config); =20 @@ -172,7 +173,7 @@ static int f7188x_gpio_set_config(struct gpio_chip *chi= p, unsigned offset, .direction_input =3D f7188x_gpio_direction_in, \ .get =3D f7188x_gpio_get, \ .direction_output =3D f7188x_gpio_direction_out, \ - .set =3D f7188x_gpio_set, \ + .set_rv =3D f7188x_gpio_set, \ .set_config =3D f7188x_gpio_set_config, \ .base =3D -1, \ .ngpio =3D _ngpio, \ @@ -391,7 +392,8 @@ static int f7188x_gpio_direction_out(struct gpio_chip *= chip, return 0; } =20 -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { int err; struct f7188x_gpio_bank *bank =3D gpiochip_get_data(chip); @@ -400,7 +402,8 @@ static void f7188x_gpio_set(struct gpio_chip *chip, uns= igned offset, int value) =20 err =3D superio_enter(sio->addr); if (err) - return; + return err; + superio_select(sio->addr, sio->device); =20 data_out =3D superio_inb(sio->addr, f7188x_gpio_data_out(bank->regbase)); @@ -411,6 +414,8 @@ static void f7188x_gpio_set(struct gpio_chip *chip, uns= igned offset, int value) superio_outb(sio->addr, f7188x_gpio_data_out(bank->regbase), data_out); =20 superio_exit(sio->addr); + + return 0; } =20 static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset, --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64A9B226D17 for ; Mon, 7 Apr 2025 07:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010005; cv=none; b=Q/yPBsIXYNHvN8cKRERemPEyMutIeB3hA/WgI7N4pg66e8YmbziDjaBQtEDbFAhd0WIjEQyOrWzw2Co4dqstUkJ72bU7JNKGb9chHOhE7qI5rZaZHk8yTyS8mi6CTugm87yVva5lBPPhfPrVfBhkDbuFGYO6IgD5qVDPcB1ho7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010005; c=relaxed/simple; bh=oI8jFuu+5ewRpLVvmH1QLq08rzgici9rugihnGgwO8Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=srrp2qMuCFaZkShzekTHK7I1e/Lp/erelNW87VXGgAXT+Dbu1UE9y374cyOtoROTcpkLFhJti72/g7E9/HmGZ2H4ZSynmR4IACfV/nYwKBbwwI71soLJWoegvQw6Y0iuNfLdzVJq7dGGCKxLJ5EFkc4HI85H2coOWEhYzwaUqmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=K2zfGrKA; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="K2zfGrKA" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43d2d952eb1so26660445e9.1 for ; Mon, 07 Apr 2025 00:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010002; x=1744614802; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hB1zg5x6R3SiUZ85Ns06SDd5X1MvxEj0zH8XpRThS6M=; b=K2zfGrKAXfq9NcieZIw2LY8YgS+cIgn1g3lU47gra0WwfQOcDEQl5KBtiiLDUNpsdw W0/+OflitSQl9f9ot42059OvbNFyk9m2ndyItJXJNU5EWG6NTVOskmahrRFsU/qipLk1 ncp3BLM6dUoaFMMJDntjlsYUpj2Y3mfnuAS4dNlzCCfJw0xWEv5FYV5scf/HxKzvAbOn FXOx+KJo7ynuzv5lrrH8qs9iyDHOVehoBg7tIN6pTRJ3HF/HDqFJfPuPW+sGwewZUk0r zX1VYLejLplYwGCnUNI9obXelGyT3W5nCPceyYgbc8PSvJbwCJT0KCfs/h3sKnjlLmwi K1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010002; x=1744614802; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hB1zg5x6R3SiUZ85Ns06SDd5X1MvxEj0zH8XpRThS6M=; b=f8tekmMlgmpU7aDUqrsxhNqS1hKNSSs8/bcQNWoaMNdHDAmqnCqURdXWpY6MJ/ZlCy pXK9LEoPFcchIKYutMsRzdw1TtJ8FhLi7j/V/S01u2m7g/uyekCGwc0E1PjFrC6BkrZ0 hKvUTqjeAkq0CSjmpcB/XSOQ27SIPPCx507G8u6aYrXQ8GARFfMHM86piEhByXNfiyEh YW8vIuPpsbAS1cMeHSBQuc8Q8jvXR8bfO5fs4nqte5ZJIYC2Y4ye/FWQ7gS76Cbtki50 7Bbw6u5IeQb00o1OmMnu1DM0EIRySwsWN3gvsGBxO/QkRb0MSBGJvPSx1QvdP+nou4ix cLrA== X-Forwarded-Encrypted: i=1; AJvYcCX3SayF1DrKv+9CQIUn/QgYS3P8ecK/xo5o5m9uD0uFU5372Jmab/oKhfnwNxELCR0Rv0t44HzPy3k/YPs=@vger.kernel.org X-Gm-Message-State: AOJu0YzCUrmaE67xWXY3kDHwKIuxJNrT/w+49GqN4elM1623Ibac7qem +Z1RlXM58GKlAq1Z6YIV7A4QjxhRGimAqP1pf2zPw75neZQenDY+k0EGsOfwt88= X-Gm-Gg: ASbGncvDeEthu27Ukqn2HDTxH/l3rvgM5izolr1QFPqeJCCrCvshOSLlwDpbfQxCW2P zhz2xSnxRXcOFMBbooUc8PeRZtLRMrklB0nYzdaoWk7Tm4Cf/bO3Pl813ApyxsPRIzrt+4ZlVoR v93tN64On/VEj3ESU94wFVXHb3ZaOTZiqYu2iC/AURb3BV5CBZtw6Z+veU6dIT4e6RXmfaTJSo3 3LTF21qwA4F1Gdsv8d1+Wemnf1b7L3mnjOPUpu+6LmHWlTrrcjiPftE8xxkLobCWZ5SaTubc4bg 4yOtbiSjNrcADzBao+5ubq2VqN4w0yvIGDNhXNUINA3cVBwp X-Google-Smtp-Source: AGHT+IG+8TMtVOLwysJgLXWutF3235lf6J36NhuS+eEkLI9eABLh7Z4hMkr4mZwyVMSe8Wd+f1kxIA== X-Received: by 2002:a05:600c:a013:b0:43c:f8fc:f686 with SMTP id 5b1f17b1804b1-43ee0616fedmr85970475e9.3.1744010001770; Mon, 07 Apr 2025 00:13:21 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:21 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:16 +0200 Subject: [PATCH 07/12] gpio: graniterapids: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-7-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1568; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=dvZDsrn97I/vO7JgDNAuyR+iCv5I5MBwDV+ZdiZtp8A=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJG73Q4jjFPBt8Zb6Mg8jP4uTF4MLMf4ktG JGHxv+rP8GJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX cok6D/4nVkIJvxYEpyAaRfeyiuHoCE/wuSo+VCjbRPlpk7Ik/pHTuiz6bPepiV2lQVNRiCCu1Rk NXx7IJKLAEmTWc87kA5J1j3hrh/y+i7hiXuRmrXrmzCkV5a7eEQHlOU5FYQZysRDpMUT25cLX9s SHs5mvJPGwn3JqLaB/iih/QRxfKdVCLksRqIOnIl8BN/vzGXJKV8wI2PG1sItwDf7VWCirfbOlT 1gHRw2+U9MZdPvqagXGO/JAVEF+b3r3HBNeAmU8JUmw4AKSmxShpwZtbOnaHn9XoHVmhmSLzk+O VfHfhbF69znTkdOONBqlKh3xT5GYXh6lQo7fn9j7WUL5mWRCgU4baebZ1wpRdvm4OY+rFl6B2bp w+pNJH6K0Jrpg1zlDOxANl5p1GGdk/6Uwptk2SLDIuGY3yaTyYJO2kjZmoBMf+T+CoYDccBzZQB dddhPZGmobWvRwC6BPUVVPgLbMstcQJ8EvdxaBCZfNt/uNpqouCWIDPfACeWsSTt9VRfMK+lQ8a 3B715SVRQrChiPP565MmQGrqv6ZOc45Wy0WYGywbNihzG6/H5AOfdIrglPTXpBfiL3lN/h1gdpG s39skJWR3Pg6SVZ7UjTdEx4mpWRMUIpGAK1yG6Oo9SiopvVZSTgbZ+Labjy2K+r3a2CoD82gKUG G0XWtfPtH/eVi3Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-graniterapids.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniter= apids.c index ad6a045fd3d2..f25283e5239d 100644 --- a/drivers/gpio/gpio-graniterapids.c +++ b/drivers/gpio/gpio-graniterapids.c @@ -116,7 +116,7 @@ static int gnr_gpio_get(struct gpio_chip *gc, unsigned = int gpio) return !!(dw & GNR_CFG_DW_RXSTATE); } =20 -static void gnr_gpio_set(struct gpio_chip *gc, unsigned int gpio, int valu= e) +static int gnr_gpio_set(struct gpio_chip *gc, unsigned int gpio, int value) { u32 clear =3D 0; u32 set =3D 0; @@ -126,7 +126,7 @@ static void gnr_gpio_set(struct gpio_chip *gc, unsigned= int gpio, int value) else clear =3D GNR_CFG_DW_TXSTATE; =20 - gnr_gpio_configure_line(gc, gpio, clear, set); + return gnr_gpio_configure_line(gc, gpio, clear, set); } =20 static int gnr_gpio_get_direction(struct gpio_chip *gc, unsigned int gpio) @@ -159,7 +159,7 @@ static const struct gpio_chip gnr_gpio_chip =3D { .owner =3D THIS_MODULE, .request =3D gnr_gpio_request, .get =3D gnr_gpio_get, - .set =3D gnr_gpio_set, + .set_rv =3D gnr_gpio_set, .get_direction =3D gnr_gpio_get_direction, .direction_input =3D gnr_gpio_direction_input, .direction_output =3D gnr_gpio_direction_output, --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4607B227BB5 for ; Mon, 7 Apr 2025 07:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010006; cv=none; b=XDElyRiBhAvG7AQrjPIPfyBw/qmfUj72DUfk7g+C7u7jfio5ZFwKzYMH5wE1UEQBKixJnrl5u996ZDF9iLGWpSOw6gEYCgPCMuL/zrPtj7YpcvkHycLDYiC1FOE475KHUxOsX3onepkAHzNMoRZ33Wwa5ZnBWLE0tm8aTkNt4Z0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010006; c=relaxed/simple; bh=OB+Tod0EAAoKXa54jxrVo7r/BJieP2+52anKQowSyqM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cfBIw/PopmuQBGt0DjAdzWmAhS12s8oFeaulJf2kZNYWHASv4sFfdAhPRjSB6AtaHOC34P7Jyla9x0/YvXG3rHk0Ju6P6dT9vR08jXTMtjnXoX8f6+487g7Z16qYvBcHZTX38tH99iQnz0kDEMg6vI/pwKfZRoDICqhM1iEN2tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=aTviwnLy; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="aTviwnLy" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso24781795e9.0 for ; Mon, 07 Apr 2025 00:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010002; x=1744614802; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yEJk2fgoO6xuxOx17RjFVCvTWlWoQ9V0bp3uC3N9yno=; b=aTviwnLyRJmiJJ0EC89Ngk8e/gC9fZHxnRUuNB+ejhsA3xq63t2EeT/GLX7cvBAvbb exKQDXi097RqfNAmUvFVLAWl3xfVtZES5ZkFU/3Banjz4RwptzYctqtsElzR6dNmNsbJ o1yyfVkrO/eqZRfAf3/uL9XUSsc+u8ICTvzwlzhq00u7XqFAFICNgMqei2dOowPq9ir0 m740/zwpICXM5Bb7jVp0rFAV6u4BaqQGi7Tif/dXor+blBmsQnYCzzuSk4EiNpUVkv6t f9YWicoZv4fGAgcBq7ybL9s6OipqNRS/OY7L5ldKrdZMeM/6Vbu6NYlC0o2WHvxWFt1u c1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010002; x=1744614802; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yEJk2fgoO6xuxOx17RjFVCvTWlWoQ9V0bp3uC3N9yno=; b=vsYW0N74nvuarxL0vPKRVtISmUya8Qd7/Fz7MaAmDk4skdT/YaPz1Ah1zoXVZ+vZ51 0z8G/hyBrXTaVk9trzEKKzVICL1hCES0UzYkv44mb5IOqgSQhRzXlGE7jO+ip03TFiRE r6BBYy/sR+QeuXJdFfumKTrQKIT+vO/bm7WNwcrKGNqkPKB6T7nJm6C65xxfsvJt9YqA fWcK2n9V6DS5XSuuZVB5msQcnamZ+Z9yMszvYb3b9PrNFTaYRA2O6a3AXdTkXoeZzQ1G nnJlD8cM/tedPE6oRZnXhskOh5NPQRLL+tM5qY2lwhQCB7Imnpx4mDPVEECPJK0e76ct 2Htg== X-Forwarded-Encrypted: i=1; AJvYcCXkkeGK1w/vKE/CHerbaWZggiZJlWCiHZ9mootzsun6l2UINsLWCn+x2tmG8/O/FvtYye6d/m9gM9J5f40=@vger.kernel.org X-Gm-Message-State: AOJu0YyeS10wK+UCk1oDO2N821FGBFDceG3a7uhsXXWa4GyNhbInfl/s CFSLdH9R1U3J0mfnLxwD+nAAjN23Pb1SjiG2jhokYpvDEwxy2HkY9L2OiQyx+nI= X-Gm-Gg: ASbGncvGCU3vZNtgVn7YFx7vyRN0cJJ9qu1A9JYen7QC3S47pGz8ljhzt43CJEh7+2X zPCkQom7/cUGuMFpe/6ecW19HoUFD3aqaElV37jEVT+D7wPYtwOwWKjEMXdZwmWfQw5j5f2kQt/ Dc7n8wHQ5I7bXFwiY2en49y0Lyt2u8iUWVXUYbey+bplYBjvdzpLB/4Trqfc6cjZ+cZYEzWXVFP h4f/V5xtYpWzxFruHBokssqGpd2mJh/X++RthlewrvHTPnBNWWN2SZAZa+jWlGsPg6lfsrX4JTa 2gpd9Q/Q4BzmFLmpEoFuFWw8FfCqbhALyiHk8XtFcCBr4VWS X-Google-Smtp-Source: AGHT+IGQFtkqG3wC9PlTnS9PdEgWUDOmHi2iesezrUO2BuhVyGIBzJ/lLkwgSOkeE2y9buDTHgbKBQ== X-Received: by 2002:a05:600c:83c3:b0:43c:ed33:a500 with SMTP id 5b1f17b1804b1-43ec630446dmr144575625e9.10.1744010002619; Mon, 07 Apr 2025 00:13:22 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:22 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:17 +0200 Subject: [PATCH 08/12] gpio: gw-pld: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-8-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1261; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=B8G8UgFVEWwfpU6misTgZDHXnBftCijWCVk5K0R7qTw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJb3Oegu6ayXdu37b/nOtXGHZHU0peJ1XBm F0mOrZyysWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX crfGD/9I9fXNiLVMd5LIcVDpTYjoPujtaOJ/uuZhqNWwmdJOSOQ8F+hkoSWtHk8j7DzU2oOsoJC t/YwtpS3NfvLHFJJeF58vPQTvYjqSSRtBAsjytTZ6mxXSQ3Ts4rhISO9i/GVFvOPSnvB13AOQ0l lI8cLA6dpBvLmvqw0JMvUMWWCMYBQiosLvripXgLdur7vw10GOHnf4doIF7ViJCEFSupSzl8zIt devI/j+oaUnw0o178HxEDAO8341jx6IPfzTzIRwBtHC6o3q4/97KGs4o/bLuYUnFwfHru3V6WKc isQiT1FphGycPwrE0IpkgHdTadFloUAG/Qz9YjBVci3HxRoaVS9er7n8pLRMkH2PJf4wy/oVs+l eK/LouTu7Y+CkkkflWvFUBz2sNgyXbrwMlBgrKIeOcdUyqObX8PwUZHya6sHJFDm6m1mhmrP9+w R86UBf4qJgs3kmKH55AfKAVNJwePkrkBhEvSUsc14xUmtJHyVjGGvXPyteFQ3qJ73q3Mkm182vR OPOQ5d1NngUCNOqOYAP+aTQyEBH+/TKHGtHVRbofSars/K4zYiAIgwh7BYZcJ5RL+P8TmvWSByA cdekC4GPE/MzSiB6cXLjHYvCweUujad58sM2vSrRSKraM1HflRCeY0bmZ48u/QdyhZHi7PPqXDc 3YgPBpydQY4GAeA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-gw-pld.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-gw-pld.c b/drivers/gpio/gpio-gw-pld.c index 7e29a2d8de1a..a40ba99a3aea 100644 --- a/drivers/gpio/gpio-gw-pld.c +++ b/drivers/gpio/gpio-gw-pld.c @@ -62,9 +62,9 @@ static int gw_pld_output8(struct gpio_chip *gc, unsigned = offset, int value) return i2c_smbus_write_byte(gw->client, gw->out); } =20 -static void gw_pld_set8(struct gpio_chip *gc, unsigned offset, int value) +static int gw_pld_set8(struct gpio_chip *gc, unsigned int offset, int valu= e) { - gw_pld_output8(gc, offset, value); + return gw_pld_output8(gc, offset, value); } =20 static int gw_pld_probe(struct i2c_client *client) @@ -86,7 +86,7 @@ static int gw_pld_probe(struct i2c_client *client) gw->chip.direction_input =3D gw_pld_input8; gw->chip.get =3D gw_pld_get8; gw->chip.direction_output =3D gw_pld_output8; - gw->chip.set =3D gw_pld_set8; + gw->chip.set_rv =3D gw_pld_set8; gw->client =3D client; =20 /* --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C41322A1D4 for ; Mon, 7 Apr 2025 07:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010447; cv=none; b=VBCtUNDyQ7XOPVF+NbdDGhecHe4F/FJcTBlLe5xlG/oJQtnEjlKGq+gPWCY9fDRpE78Nfy81VhxBNK1GiR72TZbdacm6di517ptdilWp4hBwuEolTJtFM7CqhQYQl6DAG8oZjWyZc50gPncrxDxV4FuSzujQyb/Mg3o75NdsQCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010447; c=relaxed/simple; bh=n3y5S+O7kQ6BuzA99tkggUIPSJO+2r1CKhEXkaomFp0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r5T2KuaAFmRkOSNZpi8QYFQNVWLLKYPfZob7Cr0f3AEgXSHPXn3VwclZawabRuoXAkGJ7XWeePemHmT3917neEN/r5siUwKIFidhh9bjSRtwTY6SCb8oP3kH8iGOa8sBqddnUEWikNd/EW54IbSH3g0u2kszv0S0NHDKo5vW4d0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=npzSQQG8; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="npzSQQG8" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ac2bb7ca40bso361752766b.3 for ; Mon, 07 Apr 2025 00:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010444; x=1744615244; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xKdjaegSMAM/rqAxMCD9Qx149zQwzIx25XoQ9FIROmk=; b=npzSQQG85EDenDnVHcpm/jcQ8ifPEi3zqIcaqXCqdsCvuRiJe9y2A32HMGJIZzMbjR VkR3d5ZjiS1GxkjVe+GMTCuVzzsR56TfMWR2RXPO43Z8FdmSUAhAtsSuwVDwPdEGsPKA kCbvf2cPeQ6IRrHMx/F2jobkGvAltvqVA12eXKDG9as35O/cglxhhSRyDNAsKBq2YGA8 sKe0HQRY8DYsoRDii7AUIx2K4AGMxClJiHyAmjEHdQHy6sOozigxQ8o8KUJh+J1qX8Ve Vo/RfHypa8sojuVvFNTd25/oTLRLKefM9klkh6O0DKiUSAwXY/NdOfgLhD00zw7JB7XU qjBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010444; x=1744615244; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xKdjaegSMAM/rqAxMCD9Qx149zQwzIx25XoQ9FIROmk=; b=DmvQ/xrfN3r0OvzQyqG1y82pY9tWRTcJpvu7v1XgMs05rQdHFpdKsCnjWx3+0NHpt2 sZkb1gWC+piazc3gUwp2zz0dOPHBni8WVP4lARJR7313rr/zwWD4zkbUd789B0GpJswe 9d/cERmS9O5NSFBaVnaDVFIsbtSfVffHwrUDJqwkhQ+qLXLZzZOCX+mHQBBo1pOKg/tU BDlc2q2tw9tBLSV+oDnsgCDc1+97eWzEobzg/ayxWSmvsAWnRyADuE5d2nOQ9O9U3/kF HSi8iU54/CG9+JmIwJIeDTmxpSZrKM+Nm2zq8L7SuFbpJEw7TV/mOAZz+i0VQo1IOCN5 WEmw== X-Forwarded-Encrypted: i=1; AJvYcCVd8xwD956m1dACPBWpR06CQPuLaxbXJef/5vxy+S7k+Buh9thlNKjgOLPfKCFDGNS2IhNJw23LpFkpwZg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw90B4I7vcthcZ7YcnmJdx1BkGPMsTrXxGeBrU4wNJGj1rTsL9K J33V97HrYYEB21OT2doht0EqWudBnLmvw6Qs4OtKKGOg0YMtfTnD9V3D06gxDzJNPG2IDk10BfP TXyo= X-Gm-Gg: ASbGnctLWX9Zr88xX1O63BYqKSUR4lvbVlfAvEiOEvFo+E3zmBYMYfHlb36XNvXqfBu 5uG399unRxvj4U5KHkMbgIxEv6c5OBvuXEBD/PIJRWp4xEdcywyEMyeXWoRwHq5CxKlz+kSPsMs 2hUhqJ9VyO1aNiYSw7vcUoafAuXL3xovd7FSUxm/3G0Kfb6rVh5oxR/QFzHaavcVTDrmb6PfwqF ekNjWI+53k4GmTS2wW+YdcH2ieJ/bNDOo+B9vjCwn7uPz7hYGTTgt4O+nXGt1D0k9oxds7jVBBF 0RXlv3KO7pDctOZT36bKmWvBM5RYtIlki+NpzQ== X-Google-Smtp-Source: AGHT+IGVJL2F1/8I/lWwJ31vPm5jJXx6hPrzpL71kYNbYKzzALSjHc3IlX+0r79eE3W6Jj2Qgam/hA== X-Received: by 2002:a05:600c:3ecb:b0:43d:7588:66a5 with SMTP id 5b1f17b1804b1-43ecfa06563mr113287175e9.31.1744010003499; Mon, 07 Apr 2025 00:13:23 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:23 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:18 +0200 Subject: [PATCH 09/12] gpio: htc-egpio: enable building with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-9-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=682; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=KsRxiW0W4vPyxl96QeRBfnOsz6q4m3Ci9vZGWLs5JTM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJFjAf8szaIrgU5fOqH/7amZ26nGC766Hem EIDJGZEXr+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX cq6qEACSrOsrL/eTz+OWDhz4LW60zXJaDDg5Nuceeu5AW1ALzN/2p0KC/vTlpXXplL6RdF7BLRf 2hgVRiqsLE5E03qR0u/5QvjgXLpcIZLvA/diAZ4XpZ4snRlDvtCxE0PjAFuOHG5bY3TD5oJXRHZ AYjngYn1l+FQwvCZbDR1pEgQdgx11SkyUGQduyHYyYrYL1JqGwJpe6wGTNUHAUxAHQL3FvVnVCI 9kERiaMzIwJuLFc/Zl3M0+O67yijJGaMVWhLu4LuQ/lXL0WLApQGgc9ZfQJbflHt+N6v1ks4Hcn ckZx0oGiwVo2rrKoTI9s/LKhVzGqBocBtL6md2qZm/thsYmcxHiEAaoQyF1Hq28m7b6Nbd06T7L mPbAEcwvF66QinqBunjXweN2uCn4H2323sSgaQk2aD9ZCV17q72vySB1My7hgAGeylyutpAfM5y W7dYHtRhWpYpfdF0i0BVuv9A7TWKT6GoaWCKVezB9rGzX9a4JAniOrnnACa8w85M3GkxutuiqO1 0TmbiI1/mcptGer4guYOBZkhxl/oDwmc0/GA5d6DfPnXP5Bzp7l4C7GjsovTpIFNyrgRhm8fDhS WzOqAEi4kuFxf/EW59WI5sce39+te4RlicHYmTDxAJWuSfpOE/mKC11EQughtuzgyvQHJ1bBLFM gdvtyhemCdzldcw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Extend the build coverage by allowing to build the module with COMPILE_TEST enabled. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 5bbc7f724a09..decd150810b7 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1365,7 +1365,7 @@ config GPIO_DLN2 =20 config HTC_EGPIO bool "HTC EGPIO support" - depends on ARM + depends on ARM || COMPILE_TEST help This driver supports the CPLD egpio chip present on several HTC phones. It provides basic support for input --=20 2.45.2 From nobody Tue Dec 16 16:35:58 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F00225417 for ; Mon, 7 Apr 2025 07:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010025; cv=none; b=IXJSWKowPdLcFC01DclEWjsC4+v/xnqpLZBC9vDTapK1LvmmCKrDv5NBNf5dzlZIUOfkElxgzCC+voIM4r3p0hgOFjm2b+C5DBLGXXvHyvqDGjaHbchUUcIjhoSogqwTyu8DfnORMiM0ANskYR0gH18gsXDhhTs+2kKsqZE544k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010025; c=relaxed/simple; bh=2smVCm4Nk4w6RvDJ4CqdV/kiPrD8nX20fQhszPXa8tg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L2wMj0T/l9M46OmJkZcofVySzoD78IS+zIVC6bx1K0/1YG7nMv3XfwMsc97LDUOKDpdxbldyI9zg/NLj9R8OXWdnFV3hbqtkuqQj3zeS0c1y+9cPt1dbHQVzHipGp+ZDozwj5bh/yFINKePiJa64b5Gva2y+EN2+kZ33bNShW3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=PoK7OOs+; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="PoK7OOs+" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43edb40f357so16613275e9.0 for ; Mon, 07 Apr 2025 00:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010022; x=1744614822; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B3ZLoOGIRhYWLQwldcB7o4t1OYiqucFtR/EYliiQwSY=; b=PoK7OOs+P2NWjmc85gQg1kBwLJ6y2F5hikZcc0FQ3/cKYyCs+46C0NzfpK3VZ5CG3L WHOOOvhB5UNsDrMVWxeIO6IOwaQ0nPQnh6m7rgMIjKDN38cOjeXey/wogPxEGTVpm2wH 6x5sh4yizKVYJ6UL61ZXJYUN4R9PaMjQVtTeclErC/eTR4+/JIXIviXLMQWDg+tHSAml XAGf0mtqk/snwTqtmiinjnaV0wrOGNQ87SiKSWnxsjbIEgBBUru0bF02hlgCrJnBhWbZ +c4xJdF8shGONg9m6EwZyEGkQcYF0cZa22Vu6nNt09ojWBuoNe8jI+aFb9cc+9XpXvhX nX/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010022; x=1744614822; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B3ZLoOGIRhYWLQwldcB7o4t1OYiqucFtR/EYliiQwSY=; b=FhzSnP/Q8AG987EocTqSS7z8xJqzMQziWIrDOhj3jIW9SsUGfHCV0NWKyeisd4bazV Yex97VWpGoSJ3wSDibPZZ9xjafFlR2KJL6RFL5OlgUhnClXKIa7S5AMbFmWVTQS3U2TT 0N/5LS3A3sZCrOkXHlNsqMMGOtoUNWN27Ybmw/9z0tnTqDnNqC7jLZE3wdpOhxYe3dc4 akpPQ/Ms4/mecZkhBn52k8lkL/183zy9P3Fmhd4xNK+z3gWtI/xpE2QIOZfO9KMM38OO OLtEhA3U6uw4myATv1WH2BchcHHD+mLLM3kfL9Xxxv8tD+BXKSL57BpC/2Ad0fuTGmgC 6pGw== X-Forwarded-Encrypted: i=1; AJvYcCWCL5gCAePX7XFhN9r88QyGPypGweGymQ7nBbVGJON2nrFa31AUW8ZXvbbPpr7CsBsmSWiD9zxfBj/8b/A=@vger.kernel.org X-Gm-Message-State: AOJu0YwYKpU47hqjdqbWGfIZyRc+RFOgR3edx7GRJAAOIOyYc0KbM5A8 ACn+tbVnEK5h5o6//lKQ9GgTJ8bRREl5E4QbTJfco+mC+88pTcrtW5jhgidFXZk= X-Gm-Gg: ASbGncu71nUEbLFa9E19/ztf2DvHCUbLEGZCna0PQ5ssqPgrQF/Mi1pc6pGxhiQzEmS UPAcCQ7rHdotjnynvX23Xyes6EmSvBNqWHqQt2Zcx41b02b9GitHr52548uphHRpz/PJyEFWas0 3HQspvk1e4xA9doplL8wpZhCLaDrs11HvqOONv44mYm4katFFEZ49T5upC9lqDVhFPmFpo8Gl8k Fl91uQXMc3VQkyCY8ge/DbfE2PbVra76MlzYSCnxHzA+m4YiUZqOTsR41rw4NtC7a099tRRDNA3 1WLIPDQDrJFOAZPLrFqPpzxcAc/hYYcaovEv1WwiHt0ltw1c X-Google-Smtp-Source: AGHT+IHGaYmYpxNVnlyOG51iCDGtU+hWITXEbdFp5vavb6DlKfFZk7Ry0ytW0HLUXQjm/j4UfMjV/w== X-Received: by 2002:a05:600c:1e0e:b0:43c:f5e4:895e with SMTP id 5b1f17b1804b1-43ee0616fa2mr64246275e9.1.1744010022069; Mon, 07 Apr 2025 00:13:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:41 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:19 +0200 Subject: [PATCH 10/12] gpio: htc-egpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-10-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2113; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=/0ieRZabGPzeqDnW6NtaCAv65QiJcpFkSEoCNKaBrcI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sKCwFZg+pd2UMOnz6PapQrLb1sfFgqPsewe 18VkiXsPOuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CgAKCRARpy6gFHHX coIpD/9SQklsSGCPmSQA469tG2UiGGue5EihdJi/WdifoIEy2qA01bF80+nYDeSB7I7/5mEkTfM 2u350IQaN4ougKJsPGs9WkWp6N5gObAITokFjnbLXZE/8ooSpShmVBNBYgvMkF056aN81p5/1RS VGflKBLet3lS9VKp5SBbq3nr3v5Kuz7TJio2HQtBl06gonn/LBCcjTL/hxGVtBnbd/iHpEQBW1A TH2BoN1i/avF9XV1QXKwkJPHdauISYbaK5GbIzxeQX+hI+EkOMeKswMyLWYMBbgqdW10/UrUoHc q4vYEVK673bVlRiNamQFMImTBHtWM3yTZMFNf9qMjWhTxi+KNzMqlXeBnXzRuLbMpYoNwjvZCgO 6D8wtnM0RmtrzPKkTOmdSmQITxOVBsQzeX7WryVxwyvA1VTel/AskV+OysEySia1y8aMWFGPp+Q aY5RNmlQURlaS8sXyd1ukXqolnyJYhs7XHAJ+sp2iNCocr4xO0QgBy5AL+mZDQbWZ2/s8k2oXOj N1lSBX1mD7iJUqeJDM6K/it0PYcHtZuJslM6z0nIRswJMHV2pmzwxn+xC77N5T5VThA50jxy+lM IdV5eGgs61u8TzZyHk1NVbYVJFPEw85YAjgIgqtWa5W8K5ffIy2yh1Xb/wXVJuHPgc9tBoCbmQi GJ6rz6KPoPxJYcA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-htc-egpio.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-htc-egpio.c b/drivers/gpio/gpio-htc-egpio.c index a40bd56673fe..b1844a676c7c 100644 --- a/drivers/gpio/gpio-htc-egpio.c +++ b/drivers/gpio/gpio-htc-egpio.c @@ -170,7 +170,7 @@ static int egpio_direction_input(struct gpio_chip *chip= , unsigned offset) * Output pins */ =20 -static void egpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int egpio_set(struct gpio_chip *chip, unsigned int offset, int valu= e) { unsigned long flag; struct egpio_chip *egpio; @@ -198,6 +198,8 @@ static void egpio_set(struct gpio_chip *chip, unsigned = offset, int value) egpio->cached_values &=3D ~(1 << offset); egpio_writew((egpio->cached_values >> shift) & ei->reg_mask, ei, reg); spin_unlock_irqrestore(&ei->lock, flag); + + return 0; } =20 static int egpio_direction_output(struct gpio_chip *chip, @@ -206,12 +208,10 @@ static int egpio_direction_output(struct gpio_chip *c= hip, struct egpio_chip *egpio; =20 egpio =3D gpiochip_get_data(chip); - if (test_bit(offset, &egpio->is_out)) { - egpio_set(chip, offset, value); - return 0; - } else { - return -EINVAL; - } + if (test_bit(offset, &egpio->is_out)) + return egpio_set(chip, offset, value); + + return -EINVAL; } =20 static int egpio_get_direction(struct gpio_chip *chip, unsigned offset) @@ -324,7 +324,7 @@ static int __init egpio_probe(struct platform_device *p= dev) chip->parent =3D &pdev->dev; chip->owner =3D THIS_MODULE; chip->get =3D egpio_get; - chip->set =3D egpio_set; + chip->set_rv =3D egpio_set; chip->direction_input =3D egpio_direction_input; chip->direction_output =3D egpio_direction_output; chip->get_direction =3D egpio_get_direction; --=20 2.45.2 From nobody Tue Dec 16 16:35:59 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98BC9226165 for ; Mon, 7 Apr 2025 07:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010027; cv=none; b=RJ8UCDkPMQQHr7XeQGKbcQrOzqsSSvO9fzR9PdyacmEUdGFTB8kXI1wxX4Gnsdgs/AxTGGeazielgldkBJeK7ahiRnbamg9XunIM426WtVcspFCMBs55Flp5Y0eV6NdVMEVcSc6I/T9+zCRNb48ugfJ40k2oJjEVy9iW5mYe+fc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010027; c=relaxed/simple; bh=RMeEkXCBW8iv2Y+TFnm82PWhhfZrUm8Jf3ZdZTz0Iys=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FZGxbYVvqFc5ZmNbfezJ7m1u8dm92pR29EeEOfS6kXQ9m6vZDAeWv6v3bPKytA4dQnodu6QxPQWGW6SG+Blh279VhWLRLFWYNtI7ITObizORmClaRQyeuhzfQKbbpXV9zKe5qQgTwFHQi/DW++YJVyPcQ3UIx9cuoypWZVd5ODY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=gV7LuCbS; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="gV7LuCbS" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso39891625e9.1 for ; Mon, 07 Apr 2025 00:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010023; x=1744614823; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j6qJH3D3dcBUxqtqFwZKXZHZZ2wy5A88ZUffj6LjIWU=; b=gV7LuCbSC9NpzJvpFjFJw6BhfhnOVkD8h8Q17Pcm00gBwdyoOXzDGMTgSXgz3GTRBa pOAAagRz8A6TflbdJK1MVDAB6xUQUL9XS2ntIKSm68OkMR9axn5H/dk2kAWPnUCwYAKC 5Am24Huu2D7baoPC6NIJkWWGdEfmnHWIMREWNgOzqwwHr9iKM4NDKhQBvXX2ao1fxBeF 8y/fz6uCOxRdyEm3+uqkKCUUm+ngRhDjuYZSIVVcRdctjHVmG1IUYWgmIrkHRyi0U99j 5N5kDyCTSSCUVTMIQVPjoZceT7Nevh9sYq9jzgI30GOfzJGSvllywIm1MddgpOvl29A4 cBUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010023; x=1744614823; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j6qJH3D3dcBUxqtqFwZKXZHZZ2wy5A88ZUffj6LjIWU=; b=nFrlMiUB4RxfYpMMprlFi8sNpcD/w0XEiR2RvO7ifcqT+gf3g2DKZ+dUsS/7TtH6hA 3N0v6SV2QCaacIlmmIWXimZfJ2LE3O0rgR4pJirGVsRGhhs+XAaznprTEPg7NjBnVwav xNVxM7foIrioO3hPje/4eQBUV38WjFLVOGTWOf2KoQrx6vhcRlD+hwuG5Qg9dfqfv9Zo oN26DEauSoi8fgvyTgiloHwJ2ijLzfVPcOsPooggtjV179GUcvZbbLh8oM5gp8yCzdHU M1AQ1xrZVcpFPgPp65HMC5P+pb141AhdlI7L2REHAjcBmD05LFVpHoAYbWVr3GrAjfpZ EwnA== X-Forwarded-Encrypted: i=1; AJvYcCXxRECDcN8e0XgvSMvuU3OrhbVXqR1m6/maAPO/YDc2S9FSpGwta7pOAFCm6koRPxtVpyRwKqKPrqmLPd0=@vger.kernel.org X-Gm-Message-State: AOJu0YwLcmEdI9vn/P0cN+/1+mozrQWPAJe00do5XM4sdEmfUH64n3VV 7M/gvIga/qgqvAiVO9t770TT5X0dhMHSPAc8IQfQK/kU4flDM81h6twziXNQE90= X-Gm-Gg: ASbGncvxG5fwwasMFdecWKeZCpg5TXAqhDl2eISDAdMIKNVX1dK75BBxqTcb2dI7u+s omKIGCiB8hW3qO1gFXZBPTZIQWzb3ZzGx6Gwq6wmw+QfkoRXYxLCfMUuWCrVI8KHcHrgPp1FgGQ DCD/2CcweNv+BqE9CZ/2hyZyw/6jcpuzF+9XNQlkpYwyto8mdaJ/FR24s0YTL2DeBh0ChgFsXWR Zu/B4b2Oa0vcEJblDw+oSfX2QQtS8js3nfItQNk/SASnyR9uIhz0AwGJ0rMJ7Nv799JACm9PbpV IqHzjAOtCkoDhBQCPWbcbQNCf46Y896AomE23w== X-Google-Smtp-Source: AGHT+IGloGrcf25Z1YboLqoCvQQRV0Y4rY1PSNSCcByOr3ebw5HNYIigUdFfZam8QEEwbOxo77ft4g== X-Received: by 2002:a05:600c:46d0:b0:43c:e8a5:87a with SMTP id 5b1f17b1804b1-43ed0c6ba07mr105183105e9.16.1744010022878; Mon, 07 Apr 2025 00:13:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:42 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:20 +0200 Subject: [PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-11-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=743; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Y+UpgWZnyfT06S5T52WHDfnqlvKJzPXnZ8Z2mwrPslg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sKsbO4PjLSWfJMf5W3OYBOsPDhiWwXtL98H 1CAtL8sG8SJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CgAKCRARpy6gFHHX cjS1D/9gvmrt6260PHP7JoS6Rfa5lWXJ+VyA2eHE3JJP0cwS2nWIY/XzeKZyTFYKDhvOYh48DVB V6vMws3AnykW2vZJVtZELgRbWTsvHu/RWW/QJ1HGq2ooHeDB8c0pM1IBJVLFU0c/2UB8rct7Nvc UusLb3lAOAJPBgRwMarhEz/V5hVnQIoWGZnTsNNJOfMLzRsiHXjPp7Z/OvZy6tBwUBk28JEnlhr UHfeBk3qqStK/pndamJiFglWwDvaKjLLi2mMQvUw0OaZdzVU14vvDDASHOfsyO0iSf1uZ4CRVwK iFBlzwLS5C+xGNz2rFJiyzVpeWsEzaZalApiOOsd3l7oVF8KfCBMtkv3tNF4xcCjrwq1N3ud8RZ 9D/lSQ/pasMj5TgkiLPJHwTydDNyqwfch9Osdvgp840YOY9m7PnuPdamnJJc+Rt1fZL48kO5WtG SL+U59LCZBMe4rCBvVibslejYOsIqZ7BwPeVHt0ylLgrjxE2ZxoqhTh/+QVU/CQhCTT5f99pYh8 m6hb3qCZqy33eC1BbzWKcfVSzxAV4GCqZ4xjJvi9A74oh5e/BrgnIKWW4kXIAPU2yph61ZPJIXI 7WA62zzI/VfBXyjOM8XK5IqVr8Hu4uEqak+/zw+A4/gayo361M+jowTLhlMhyOvItc7ZAeomCPL kwfMJPPYVsnFehg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Extend the build coverage by allowing to build the module with COMPILE_TEST enabled. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index decd150810b7..c13b95813c6c 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -368,8 +368,7 @@ config GPIO_HLWD =20 config GPIO_ICH tristate "Intel ICH GPIO" - depends on X86 - depends on LPC_ICH + depends on (X86 && LPC_ICH) || COMPILE_TEST help Say yes here to support the GPIO functionality of a number of Intel ICH-based chipsets. Currently supported devices: ICH6, ICH7, ICH8 --=20 2.45.2 From nobody Tue Dec 16 16:35:59 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B36225A48 for ; Mon, 7 Apr 2025 07:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010027; cv=none; b=d/du+8v/Ljr9qnHbj11YTsJh4tYJlez0bnFkdHiPkk9uQu4TZAbKkxutCtQzSFdzOFkwq0SXcHDqiNRujJ5nnDpIusfkhrsi6DYkg/CKG6txFS9l9RGgSnmf6W3RgiF4sUKPXZBekDeFo4+KVhd3mBpI8s5wRTjCE4TVVPEOq6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010027; c=relaxed/simple; bh=ksgMNh86Gb5TqWWXr6fwh4KwzaC1B3egBIbaiSO69I0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W80/KfDs1BeKPAs2GZBg39qaAEz7Nd1OYXdFSpgL+OsCIsZtVVBQssrb34Og7tBYlO6E5G5b+mIGMHVBjPO/ZTO+kKTU9aMVsxUB1TEiWpgNR2zlnlaHD6GRZm/r+ShZstmpSq3af3yBE66DLo81fV5qZHzqXYdPJf5vlCJwHMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=PWc5nfmD; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="PWc5nfmD" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c266c1389so2777628f8f.1 for ; Mon, 07 Apr 2025 00:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010024; x=1744614824; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sauICvY2GNu/d0iZ8lKdFH04dL21IXhvdergpTZ3jAY=; b=PWc5nfmD7nwr3WNMqg495FRLblCz919oYOydqtk74HnctvYxhRstt/bHsxtp3/aYwt O3DxPyBDJhnjBPsoX9QG4iaNCwn6Hsz58AteG+FAMvTnaqvghHc8h7DHmwwW56OjqX3p UK7YJS/w5VGOthKX/i3yNiejDR9cSBzS6+MEpyHzcH+90i0Vm7gFeO65W8NHvNk2hHgE Dszm6nW0NiyjhmoLmC0GcWluALDSFaGKXMy+D4LolGrbuOFW5vaHFUcuX/xBqTZ2OuDe pkxW066H6g9KiTkLNZcdEcdiY5qcGUGhO3pK/42fXrlhAz4S0ButjPmTAIXdxJOMHuiE wyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010024; x=1744614824; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sauICvY2GNu/d0iZ8lKdFH04dL21IXhvdergpTZ3jAY=; b=B6ryqsWsiW03xEOlBqrP/zYm6KGoUDs5Q7rrzl0auyArblO69GawVszvXXZjPi5ez1 D0a77kbEqDplenjoxmdQq8HKwvj0n613QmImqos7r0xy5HA2BoDW3WbCPyKCMYuxz74L v6x+YqOa6oYorALFfPUf75KxPbn/GRYMRiwm6MNQEArK0FwUZVJ5ZTIEukzRHDVjcG3j FILGtQ7O9WH+eTQ5W7JKc3mJyld8c+AKoEOCfn2zPo1woBhJE4I7Ht0vDJqeY7cnNaWq +8en09iGnIFdpJzuXr4pU+uLJkd9kFLwQrWTLi7bvMraqSpouMZMA/irWKdMwJk3qaat e4Rw== X-Forwarded-Encrypted: i=1; AJvYcCXyCDgqGWH7D01zBRplEq0AlQjU0ayq4lIHT4fdwbKiRYzwZfutphP/mXkSrlbJy4Rmr1fItQ7D3VuPZOg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmb3db79Elpawk0FaVdbpYWj+Z76TwFaOJQFYvGSMui5+Shrr0 6CFUjPeIF53o4cRaGz2QRVid+UUtx0B2VwDVNh8srhPpR/WBXqiEL742NwdUkkE= X-Gm-Gg: ASbGncuN8/DuJnJnfz53dlZvsAEubZ3ZRfB2ODHhJ/VjAK2HMYb1Sfifh4gPvzcTqZE CKADjETabSujYZZvaituQusELTmXCYg78yRnGj107iKGk77yenmoXgD1chGtob5pYFL2Fu8enkU jMQkCti6fteVeV9x/r9x73HKLSjvivhAa1e+HxGwL5LJAp717m1ir62IZJXpxuDvN8hogR9A3As 2yHOznBkmxekZ/V4YZ4s51LtKRLfsecVUmmqXcUqqIMl+9aZJYgD22b1aWj0jhKZBZqGz9nklQ7 uXOBbXu3ka5ScTyF6fHmq5k5TRvjTOiz8uD/bEDgCF73uMe2 X-Google-Smtp-Source: AGHT+IET2/k8WYw907bVllamJF5bVLK+JZ/6K0xA/5CGjA1RriXq4TqZb/drjilOXTTBto1d3wZyuQ== X-Received: by 2002:a05:6000:186f:b0:39c:266c:136d with SMTP id ffacd0b85a97d-39d07bcce91mr9558796f8f.12.1744010023815; Mon, 07 Apr 2025 00:13:43 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:43 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:21 +0200 Subject: [PATCH 12/12] gpio: ich: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-12-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1945; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=i9kMgN5vraePIBzVin0YNojFDKLKAlftYcTP7Y1Nccg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sKeGi3udRSb1Sw3Ipb+p3w9GsXMiEnZljC6 RQzVFe+nVyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CgAKCRARpy6gFHHX cuyxD/4o1AmB9t89cQnAf0YyC9wdK7KdIRyopDsQc445ExB/wWNm3fbat43Kj4GGAoLd8KCjc1q PG1mHa4YpBjhmNvU6hg8wUfQyN3C1wf3jXBYHOn7Ts3mHDCVi9WOitafwSf27aYja3RW3lpXl6H nvEbH7KVjuFrjpnYgD4AsJc8mGcUSv+g3mAAk4PUVHEPK+3THey0qzmU1uL/mgxUkw7jnOjcIlt raDjndjF72lCBpjaWK0iQ/WrbKlePVhcMNAUyaN239U4NpX9R3E919D+KCx8ux/6ds6hoKbLqrh hBCHrqgXXLAuyrJVnq8X1aMpu/pvvVW6a6ei51TUDCieBdJ2kBpGQUvO+lTWYOf3y2kd2HPZUhm Fh1WSwnpKe6gaUdgD6e4wC5p2UhZ7KBJonc6vny36UEvo0dZGZrxdHg5UsLO5Tq6Oj6AHxY/ChZ hQMVZtKIZHc2Iqi8e+3BUKD6hbS9z1J6kh/LQpqpHRdO8VxWW0kt5s8js5IKQDpTQUDkpz7hAdk WZpbMj//rZrYjp/djyR5irUHQ7KwBS2RsvGa0TRmdwGgyECJfhrVsIXvZDkKAzWFOJPkQhalyJq sNB38EemKTWipHl6P4JsX8ObhIZvAZxMXGs1fXDfq4OIrKgOQiBQYBQjCKyedokBvd9AIDEBZ7R qgCDTPqepWM2tIQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-ich.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c index 0be9285efebc..67089b2423d8 100644 --- a/drivers/gpio/gpio-ich.c +++ b/drivers/gpio/gpio-ich.c @@ -175,12 +175,16 @@ static int ichx_gpio_direction_input(struct gpio_chip= *gpio, unsigned int nr) static int ichx_gpio_direction_output(struct gpio_chip *gpio, unsigned int= nr, int val) { + int ret; + /* Disable blink hardware which is available for GPIOs from 0 to 31. */ if (nr < 32 && ichx_priv.desc->have_blink) ichx_write_bit(GPO_BLINK, nr, 0, 0); =20 /* Set GPIO output value. */ - ichx_write_bit(GPIO_LVL, nr, val, 0); + ret =3D ichx_write_bit(GPIO_LVL, nr, val, 0); + if (ret) + return ret; =20 /* * Try setting pin as an output and verify it worked since many pins @@ -252,9 +256,9 @@ static int ich6_gpio_request(struct gpio_chip *chip, un= signed int nr) return ichx_gpio_request(chip, nr); } =20 -static void ichx_gpio_set(struct gpio_chip *chip, unsigned int nr, int val) +static int ichx_gpio_set(struct gpio_chip *chip, unsigned int nr, int val) { - ichx_write_bit(GPIO_LVL, nr, val, 0); + return ichx_write_bit(GPIO_LVL, nr, val, 0); } =20 static void ichx_gpiolib_setup(struct gpio_chip *chip) @@ -269,7 +273,7 @@ static void ichx_gpiolib_setup(struct gpio_chip *chip) chip->get =3D ichx_priv.desc->get ? ichx_priv.desc->get : ichx_gpio_get; =20 - chip->set =3D ichx_gpio_set; + chip->set_rv =3D ichx_gpio_set; chip->get_direction =3D ichx_gpio_get_direction; chip->direction_input =3D ichx_gpio_direction_input; chip->direction_output =3D ichx_gpio_direction_output; --=20 2.45.2