From nobody Tue Dec 16 16:28:10 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA3B514A639 for ; Mon, 7 Apr 2025 07:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009769; cv=none; b=SA8cBZ/6MdXzHHd+3oF2w0KE/4pVnTeBBQpFxcxF5TXIChHFXfri9aZl9t4tQwHECSWrbTib0ufr+Bd3WC9ybG9f9WFbZw1MHeJOX0c+skv9FYbtLD8ZR3U4/i1CrAXl3nG2JejMqJV0QPkA0IMICwqNPVoVT9yjVoVqfrUm8x0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009769; c=relaxed/simple; bh=QDLHMBZTpiBivDqp5pKtEBIW4NMS9LwrxmbdzYFamjk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pVKWAXGVoF7lp1TrjUbO1XlFTFh21c7SG4EqFi6R/ZYyM4MgrO60dbHKyfz91XlhxYzTwKi8fLrrzNwKn2ONyGFBwYcoxBK7iP53jdi2Ql5SQM7zMr0yCuWjHPB3dACKClPs3TPVPQrIbba+HRVQ+541Y3ihbqfExSJC8ZgXR58= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=YGaokiYn; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="YGaokiYn" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43d07ca6a80so19887445e9.1 for ; Mon, 07 Apr 2025 00:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009766; x=1744614566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1oJEkpaKzk7KM5O+yA10t99Sq6/Y0ezDYdwYB3ESkdY=; b=YGaokiYnQNNRQaZous63gK6mZCrRiczGNpihvLSBeSeP276SOW8ULpL9P3+y1e83PQ vwd6pbL46AIUdkZSKmeyopjHsfOiok91z/HYST40UwZ6/4ZjdmI9ncffITh2c4AYSgWa 1baBq00Yhd3elKt+6JJAdXIpPJ6HsHTIdbN0r4ivdWKF5Rw5Y9RjFgt4DCyEsep/eDVc kc5zZXxE9XQQ5kuZh6b+TpYpJxkHDAsepFDhUFrTn1b84GBBfUqLCSLHSS2d0jTd7zPW 923EgzBHZwuuuCmOjqP7T7Bbb715CwvYklSMMzFq1XvD3up91Y4MQjCk2eF5zkVZ1p7h xytg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009766; x=1744614566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1oJEkpaKzk7KM5O+yA10t99Sq6/Y0ezDYdwYB3ESkdY=; b=L/NtJPE2CrOXjNmHGpa74tdhhVAgRUFHQO4JWoYcaBBrfwvbAruN4oWsDxJWZvOT5O ieWDief+ifabKup1fg7vILJNxK5DBP2RemXMRrUF6Ib7AlpYvhD9W2UIbL+pBxG5Wmpl Fbi5eRswtkiHTtj+sZeFQOHg+Eg0MLweY+OueFOx4/KQR7gzbQENi1AwQSYVNb3SCaJr oDqDM/Ty+vkhvDDXvX5RFDZQ67WtywD1lT91agalV07YpPvWn9U2/+bOuJW0fcwYnaz3 OcV02AtGnL7i/H9lPlQqMxutRuKmPJp69MsslTzvIzuiUX+R+yuPUWe3d0EPTZ17Y64K +50Q== X-Forwarded-Encrypted: i=1; AJvYcCWl+RCHlWG4aEro2XL0HHK4vSppbK5p8yrE95NWMFxudd/YLRkdvRTXdEz9o99mflbaKSGmhs7QrJ05Zbo=@vger.kernel.org X-Gm-Message-State: AOJu0YzB3hSVKymY3gRCYoJN9PUmTbVBGbJCRrPVhWVEo+M8VIM2RATD zSKeCUMUZTEMeIq2MliQGXo98gbE4SiFqFlMV/tPuJSSsmV3gsr0Tc2U9MQykx4= X-Gm-Gg: ASbGncv6+2Ifb9H2HcKHTPSf+DH41xqBAxPjmz1gdKfafFLbX3bMvMNXvPXCEnHAMJW wqXxKjmEYT21pCXBCG1wsMD8R+wFjng37AYJnuCFSwXeVdvdQvj9+r1N50UjqFOwyI6YyAJxuDI sKmPnYPdHTuB5XIGapk+iigqKf88i4fgcT6m/yVVquSMMhY7fLl5KYf1dGBX/NZA60IGq4rXZy4 uawOWPc3FGHHiZTiRlPNtXRAzya1csfLY7IA47z9gWd46Da6RKGtUwrY614rM+qYDjDD8SzHXQX wDO9jrqKQcZY+rwzkr3PhaStQyruY/WH/R1w1y/Cm+gorrp6 X-Google-Smtp-Source: AGHT+IGFE6oyFiQ9CpLcLlV+haks6tvvNCLBB+aF4dXus3yMP1Llx4O8MohrwYM8rVwVT69R0foFDA== X-Received: by 2002:a05:600c:8719:b0:43c:f85d:1245 with SMTP id 5b1f17b1804b1-43ecf8e7321mr124503985e9.17.1744009766064; Mon, 07 Apr 2025 00:09:26 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:25 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:18 +0200 Subject: [PATCH 1/4] ARM: orion/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-arm-v1-1-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1612; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6854LsY/CEKL9LDW7nLKKhBRDGj/vD8F0/gksPec/Gs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83ojv0NTNspg6Wx5Fggczg/6It7m8U2gT0lPo rxrHkr6h86JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6IwAKCRARpy6gFHHX chutD/0cndTpas2Wdg5qBWP1Y3VKSiVXC6hIuu1om0Dd6+1pvJPesqjLF2JFC6zXuYLNkg0+5Jg rGlvPXMOI1t9FgiAdbgKurXOq+HFhT4k2qSnOquBOC/PNHNbPYOOlpJuZidhiPkiCKltu3o92pr K7HivuuUnrD3r2PaQXoLjhIhZ+jnddu7iDYZQQYgSjAF2FXJVs/TOgQY+fnL2rRRAXZ4kfA/ll7 6dbIgHm1IM735m+b5kQW+9UuDG14bt/y9uWTJbvgK+xvtRhl5k9jyTWi/P6P3K93ceJolsL+zdC WUj/jWB0+TrXlKsF57cr4miv9xpRtfcFOM68jyZJYP/8RT/B5CCxCMHxW7L7SpUkcHnwtwhj6p5 Iz9NnHrsLZdZsytg+wpvHk5roaSVuWDVE77oA8uClfW6LB+PcAYTI3kuSkoVRVI7dfSXJWSLVn/ ouOOd1MUVkGTz++pCGaCtcnKe176tnqXb5Wm5MNK93LUMpg2F7KMVNZUW0NBY47bKkYN3Wz9ANJ hLKVuAzR5UxbPRdG3dHLIKEHknx3vm0Ac7/z0V1wh99rz6jMLZWAHXAY+/BJPRpl9jTJQEazQ6e 7nKzWccg6Qhy55gudCDhtyMQvrJPacNqZJ+cdOXjly/IYjPEwBorwqoF/42IPiZqADwOvawnQ1U Ns/4rCW8lnZP6Rw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Lunn Reviewed-by: Linus Walleij --- arch/arm/plat-orion/gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c index 595e9cb33c1d..766036fdd792 100644 --- a/arch/arm/plat-orion/gpio.c +++ b/arch/arm/plat-orion/gpio.c @@ -211,7 +211,7 @@ orion_gpio_direction_output(struct gpio_chip *chip, uns= igned pin, int value) return 0; } =20 -static void orion_gpio_set(struct gpio_chip *chip, unsigned pin, int value) +static int orion_gpio_set(struct gpio_chip *chip, unsigned int pin, int va= lue) { struct orion_gpio_chip *ochip =3D gpiochip_get_data(chip); unsigned long flags; @@ -219,6 +219,8 @@ static void orion_gpio_set(struct gpio_chip *chip, unsi= gned pin, int value) spin_lock_irqsave(&ochip->lock, flags); __set_level(ochip, pin, value); spin_unlock_irqrestore(&ochip->lock, flags); + + return 0; } =20 static int orion_gpio_to_irq(struct gpio_chip *chip, unsigned pin) @@ -540,7 +542,7 @@ void __init orion_gpio_init(int gpio_base, int ngpio, ochip->chip.direction_input =3D orion_gpio_direction_input; ochip->chip.get =3D orion_gpio_get; ochip->chip.direction_output =3D orion_gpio_direction_output; - ochip->chip.set =3D orion_gpio_set; + ochip->chip.set_rv =3D orion_gpio_set; ochip->chip.to_irq =3D orion_gpio_to_irq; ochip->chip.base =3D gpio_base; ochip->chip.ngpio =3D ngpio; --=20 2.45.2 From nobody Tue Dec 16 16:28:10 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0AE225761 for ; Mon, 7 Apr 2025 07:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009770; cv=none; b=BT3gsrNdyk6XiG2HYu1mhiZ82QfEotIZ5h6Lc6pIxXKM0WBjP2vOpsCxfiZ4fKONeNLHzvWbBAlR4PsNjvNqUHiyOVV+U/I6G3EtzjI4DY6lPsmD/PCO8jK8apqY+uPV+hHQ0z3RS3hXrg4IaDMzMQdTb9oIzMyN89mkXekwN3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009770; c=relaxed/simple; bh=ozAN40jinl+xXLgyl7TwyrqEYX1yW7hYhTChwsJoIiM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jLcX5FRmUT/JIl9p7a7oaUnFLpqi9QOwqF2s9w9aRfw/OIzZUfCxx9wggYtMdIkpLKCvL4xBIwKGidCCJz0fbwEl2VgkZt3t6T8xD1iypIThw7g5SEBlbP254L5Dht2/LhjZT3z9w7um95cQnUOycr8D7kei82rYbRZZTFu5c3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Zq78gfjk; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Zq78gfjk" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso43859775e9.3 for ; Mon, 07 Apr 2025 00:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009767; x=1744614567; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P54VA/QfQ5VWCZa2DrfOM44F5qJ8PR9WzkkmyLvWpKo=; b=Zq78gfjkMdK17dFmwMiWgGWIjk4vEMM/LqKKh8VCfgXh3Uj/K4CGZ07sLe0Qkl2FxD UHUa3lBW2P7H3qph9EHUbpxCJ7Va1l7PgI8WkoqR0DKSTDnE6pf3FiwC373gKP13Stis tCOV7Ux774VYH5a5415qCH1u+zu9D/Omgg1cqCaDBIKWdi+hgQGEFIyOuh864PCg6Bqh dJ83o3QU/hKFjVIvBUrdOvZunHrbDN3aC9hB04ZBVgyalzIgiWGZ4+wGOSMnDmKeCxI8 KT/u5CASQeKFPPj2liovOnloK8xP5rTuxCxGFEkWog03/9JqdiZcIAEO/oHl+2uY36RS ry0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009767; x=1744614567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P54VA/QfQ5VWCZa2DrfOM44F5qJ8PR9WzkkmyLvWpKo=; b=HRa0qc8ouQ7+C13FyyHZed4WsUjFBJkm7HeoHAr1U8S2ckjzF15ZapEWlIxhQeEi0S OkBDeqPyN1kX1pEr9FmF9bJJv16TyVxbeuXY9gFEt7G6IPMMBs2QLPRBc084gZXJDHzO +XqB7QvbO/duRnaXurxAyQgI0+uGDHNKFz5+dP3fqQgeJlbfjOlyiWui1toJKjdtQ/Qq NTocCRPtLMBNN31ZkmSTOXzTUts9ica+8XplOmUoIItUYxjaFcGAid5mX0yaVgKYhIBg awNA638PmY9fZCuF8QEs1u3Ca0yWebdsNLc1pkur5cyWTL6m3/9LDR4NmC/g1Ad8U/eZ OV2g== X-Forwarded-Encrypted: i=1; AJvYcCUNbeLEyFG8Uu8+e7kqPaLRDJVqYrKEexJQ4AVzJDNoe8zeycfBYFsgwmECdd0LXFbfoibEAkMAEXHZB10=@vger.kernel.org X-Gm-Message-State: AOJu0YwbFzgmxbQ/EpUlWlkBzHIV2xGPcw+rK7NWlftmioXMqzsyUiKu beB/PoTZedb5KcNj5zVp41Gx6667lpRG/E/UXzs6iEbovxCcDF6XNzq95UJ1Q/E= X-Gm-Gg: ASbGncs8RLgWwCw2TNfHPjfHqioMPNLb4UovaYXy7cmbMXf+GTedVotNALmPX8Md+J6 OlcrYPHuT46s/+28uRxlvoAhbeW0XIsD8ow04DQ3tDHxJIUeuzwbgD0m3RhPSsASLqjnVZ0L1bb 8ZeG/k5b0WsdU4bVT1Vc8VLht1qca/M49fFbOYt+qYuLOdeIIoIV2Bf0IuvOHEvc8/MY1vPVetY yxJwwm84eEyWSXxgVStUrAzw+ImMlWp93CAyFIO5/5U3Mf23LR2nPI9Ykdyy1RfBjGlxlBKGNkW h1+O6Sicxl4dEfreviCh/ZJG7c437I8gWr9Q3g== X-Google-Smtp-Source: AGHT+IHlbYVaSeQ4i6pCJ+5QwB6SPB1j4w0/Dq7AFXUieSOfltPppg5yQl42lc4SWdhOL/4TY1MnaQ== X-Received: by 2002:a05:600c:1912:b0:43c:fcbc:9680 with SMTP id 5b1f17b1804b1-43ed0d98e11mr66774425e9.25.1744009767393; Mon, 07 Apr 2025 00:09:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:26 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:19 +0200 Subject: [PATCH 2/4] ARM: sa1100/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-arm-v1-2-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1726; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xsWx6NHlIxnhL6jtmZVFoxqhJ5i8IDr9WwAEXelZLcc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83ojCLYV8dzwcSNLnX4bkKX+gH1+RDkz/zjfu UvxHKlCXuyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6IwAKCRARpy6gFHHX chMGD/9WaglQntxBb+rFUYx9pTpsQhM2cuIhUhgxNCX/UTl/3szgAcD06UaZbzpECecUIUvcZcf xHvg9m/8zUqjvoulvOdHUUhu1M/64mJr08Mc59L7LYUNUP5DJgPZnDIFvclIIyXxgl2/R2TD2gb W1iJTaMePwcZgWSB00BZBRYxN/q8f/2O6XISU6cNUdJ0zYvgkW9M9tZhSzGQ65VB2MsoracdfiO Isfwpu60HyoH7bKqnCU3/NT3fn472ynWuWAOAKCLl5g5Bkv810i9mWpnLDn+db8t6hU86JhbldJ l/BNF2J2U4O74bHUDEVQwSDyvbHN1YOYCsTfOLgvQmlU7umqx+iCfPGsaqpp52oYItloneBpuWv HKWWkhv2YftZY44ytOEUa0y1HknhvANP18iKzjY+k4ZouGO45TXtsRrtHsYDOLk+c/DhqwwOmPF aDX2XQ3DsiwI6Jx3zvTNp5vT4FYSEwoSroABjT7ADXDkrS0mfbIwAAPYt60KWKhIQgj3OWAXJuM 0a7oF0P4c5rvq5KFVG9hl6GsbYufNkx6PVx+uslfrKQBjHZuV0EL7wCO8V6y10cEZBBeeUTTK+n kGGs5+XXX1fhdeD5Y3suIaahWADJWI5MkDd+0OajiUpvCEENwVBvEsmdNIW0nm3nk7OTSTKfVTD wjA0QNCPuSn2sHA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- arch/arm/common/sa1111.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 9846f30990f7..70dca9937644 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -563,7 +563,7 @@ static int sa1111_gpio_get(struct gpio_chip *gc, unsign= ed offset) return !!(readl_relaxed(reg + SA1111_GPIO_PXDRR) & mask); } =20 -static void sa1111_gpio_set(struct gpio_chip *gc, unsigned offset, int val= ue) +static int sa1111_gpio_set(struct gpio_chip *gc, unsigned int offset, int = value) { struct sa1111 *sachip =3D gc_to_sa1111(gc); unsigned long flags; @@ -574,6 +574,8 @@ static void sa1111_gpio_set(struct gpio_chip *gc, unsig= ned offset, int value) sa1111_gpio_modify(reg + SA1111_GPIO_PXDWR, mask, value ? mask : 0); sa1111_gpio_modify(reg + SA1111_GPIO_PXSSR, mask, value ? mask : 0); spin_unlock_irqrestore(&sachip->lock, flags); + + return 0; } =20 static void sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *= mask, @@ -613,7 +615,7 @@ static int sa1111_setup_gpios(struct sa1111 *sachip) sachip->gc.direction_input =3D sa1111_gpio_direction_input; sachip->gc.direction_output =3D sa1111_gpio_direction_output; sachip->gc.get =3D sa1111_gpio_get; - sachip->gc.set =3D sa1111_gpio_set; + sachip->gc.set_rv =3D sa1111_gpio_set; sachip->gc.set_multiple =3D sa1111_gpio_set_multiple; sachip->gc.to_irq =3D sa1111_gpio_to_irq; sachip->gc.base =3D -1; --=20 2.45.2 From nobody Tue Dec 16 16:28:10 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ADB7154C0D for ; Mon, 7 Apr 2025 07:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009771; cv=none; b=iEo5JENsIKFGrdqWJJgDF7qbwv96HWPdbDlvzFMC6LaPKBdIGd7HQrUjeIPEs5RVEcXusmnHuaSSiXqzZIZFMMGAt+tnHZcFiT9VZ65Mu4eE4mdaWlxgZVBEdrMkxog28IHNfcr8TSWa6nQbStU2itdA76dbJbwjGXkSTIWqyaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009771; c=relaxed/simple; bh=rI3gM6wyr+LS8B0fWYZHHkyFOI/0ZbvX5npXKPrWiT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NW30jaUxInaXp5Tswr5PGYsIjyzd6uFoQFnSqX6x1P1KglVcWr2bbKlZ8VL5STkXnFKavUs7VxLnHXNJeQhvnFZ5NN0hoEKeccJFb7BMJGhSYHNPvZnd16/9LAx+lbUccc82NGdOw/5jAz/Iblk69UakOAmCzhZH2mL4n6+wBv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=KHgeipwt; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="KHgeipwt" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39ac8e7688aso2929758f8f.2 for ; Mon, 07 Apr 2025 00:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009768; x=1744614568; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mKHBQhlPmU3j6804TJoiY+lijz2sviuHoc3u/Cr+n0I=; b=KHgeipwtVFv3mYwiYWPvfhiHqpBJmAGyZfKFvXY8oZkzOgMy/QO2HRRh1+K18Qcfc5 xdcoa1i4hh5T891v7nCR3UpuFpBuV0Y89WtlwTKBnL4XS+kkDE+BISts2656qHUN+kaS NHG+AAYXRyz/iLZ0EYtZbggOUdLNOfpyS2r9obCIGRnPa45IkwFLu2ej+wtMzu3Bu2Cd OzAJYNvP0ouX1784XnNg8UNuX3kDY2LpiOJvvVQ2H3ImA6yYdiDXmftsMG1m+gLXxWuo IXOzDijckEorrxQ+61Rvs6o59ij1qSc76q6+H5OcXzS5Sl0manicJrTdd4Wi3BtjSLK0 OFjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009768; x=1744614568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mKHBQhlPmU3j6804TJoiY+lijz2sviuHoc3u/Cr+n0I=; b=bSEZzlfiMjYBx2YrAzLS2heAlXezEGU06qij+1bBn92vTt2ZQUkSVKkqv5Mq7MEqX6 ULyHoPGyRawRKwfcGjl2iK4mXb+T1+gUBmMf9NxvP4+mlJTujE+V0fFnWrq2fdbyqBMu RIRGrWFzU6CC6hID3Uvm5GuFfQPBy9nmHr/yTvE7twirVTh7KSz27JzORUF+26rOsmEG pME9C/y+eDrdsgpdiWrQoaHhpJWlASeVII6nsIoWn72XxsWXXgLTkHwA9rzcZo4a1ixr OAOFJ5kRS7bB6lVa5vT1a8kgNuZwmmqEB7LO/yovkjBrpz1s+OrN6ll0HXZji9awJXlU Hfjg== X-Forwarded-Encrypted: i=1; AJvYcCUE1YVqbuDrNUP3HpbGJGANIoLd5xw7hRa1fqdhE3JryYvtY3DDWqW2YU04IyCG+zwCXAb50Q0uyUGqq+o=@vger.kernel.org X-Gm-Message-State: AOJu0YzIoBNTet27PLfrYZKHqYNuXzHIhEmj40rUmaT9G2Q+SdwTnNfR lgOjRj1qsHq6v+MzMg+gN1eypj36DXqABY76n8TMkp2lnxuEKAT8Nm4YlvY9sAo= X-Gm-Gg: ASbGncs3okekNyDlmftN/lywmUiUHb2shbn2yB037rHf3IArxB+Ys+qm66tLegeKLf3 utf/O2Yid/xuYDmSzOppMR2t/jHTvXuJ5EADcDo6Of29GxDIp1FzAd7u2VF3OFh13AUhuOzzvDz qSKVmfSYa9XQyvZSsyEpGKgTeWCnm3pjIG0/sYp43nzVq4dqkYlfNSEByQELQCg5AenJEQuOLIj byyUvqp3vmH/FMrMBjWkni/ZqiJEYg9PqMD11k319gDgmkeqtJ5TSNmo60eT/kevYnHekKpe3dW gIv3oYZXvH6wFU7CoU6QohS8K6Jo9sQpTAB6MP/f1Z4F9z6K X-Google-Smtp-Source: AGHT+IEOVwEvDvK/VaX877azSHwhGwB+qG3k0uZPl7enDJ5MXPhr/6Jl2r6haw04RdA5keAMOfMCAQ== X-Received: by 2002:a05:6000:440d:b0:399:7f44:5c74 with SMTP id ffacd0b85a97d-39d6fd06920mr4321098f8f.55.1744009768449; Mon, 07 Apr 2025 00:09:28 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:27 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:20 +0200 Subject: [PATCH 3/4] ARM: scoop/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-arm-v1-3-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1649; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ehKRyvYg5rUoJTMfe9/Qu0Sq86m2y/6ATgEJ9xwP4+c=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83ok4MKKf0abAA3OAYKfP6+RbRvjSZlJeEPjq onYoqwKNmOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6JAAKCRARpy6gFHHX cg+gEACBTJJGVlRuVE35u0vd0TPLco/EUqtFuji2MMq9tgOsFcm+6EyEyHEQWYwVXELmtyi+pgs v47ssFCyjuUpRiTQuoDAiz+kNGhhbedC/Y81QS9HhmIiqRr7+4or1ntC0EF6w5bDaCJ8czd5b1u r+uHTdRr3K0PH7leknEkF03e2e8FaUoC6DfVhGDgiKSNujP+zHMI7CTLP1CCLMw6Vni4z5rnZ+B DTtwtPu/nStaMeYbGVVXdRHMfuzLqGHhT/vURx7RlT8x4ozmQCC+hRgjMeokIALearKmc9fxYGB 6mLjyWbGDqlKg7ewiYLhs4/hVQqxrveH8fwxGUhqb9gu761NA6BXH6uqRGupXN1Yfb9bQBJDv0U 8egk07IK/MjZ3r1pBfvICWR7mPPe+WPaiEIZYJdVU0FZr3n5qbj5Cvx3cxDbMawDkChProIlGKB La8MSZeeryoNdDhNqBCuTQDl5LzdUCQEZgr6a750ft2Lx8NJRckIBa9+xlwydt5/Sed6G5FqBtj mb8BBh21dARgYpr76EntXsciH5RifmwOuKMO8WhVzLwM920GOuBCc0KnVZjgE3BBSRyLZnjsLEj S6Uy6Iibd+lHLM8ACyvhERmG9VK2xhyBVzAKzEjp7D8UMlGaSjXznkrvHdePu3ybRMH4hftvDol VtUkDFktum4jREg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- arch/arm/common/scoop.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c index 0b08b6621878..2d3ee76c8e17 100644 --- a/arch/arm/common/scoop.c +++ b/arch/arm/common/scoop.c @@ -63,7 +63,8 @@ static void __scoop_gpio_set(struct scoop_dev *sdev, iowrite16(gpwr, sdev->base + SCOOP_GPWR); } =20 -static void scoop_gpio_set(struct gpio_chip *chip, unsigned offset, int va= lue) +static int scoop_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct scoop_dev *sdev =3D gpiochip_get_data(chip); unsigned long flags; @@ -73,6 +74,8 @@ static void scoop_gpio_set(struct gpio_chip *chip, unsign= ed offset, int value) __scoop_gpio_set(sdev, offset, value); =20 spin_unlock_irqrestore(&sdev->scoop_lock, flags); + + return 0; } =20 static int scoop_gpio_get(struct gpio_chip *chip, unsigned offset) @@ -215,7 +218,7 @@ static int scoop_probe(struct platform_device *pdev) devptr->gpio.label =3D dev_name(&pdev->dev); devptr->gpio.base =3D inf->gpio_base; devptr->gpio.ngpio =3D 12; /* PA11 =3D 0, PA12 =3D 1, etc. up to PA22 = =3D 11 */ - devptr->gpio.set =3D scoop_gpio_set; + devptr->gpio.set_rv =3D scoop_gpio_set; devptr->gpio.get =3D scoop_gpio_get; devptr->gpio.direction_input =3D scoop_gpio_direction_input; devptr->gpio.direction_output =3D scoop_gpio_direction_output; --=20 2.45.2 From nobody Tue Dec 16 16:28:10 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F362D226170 for ; Mon, 7 Apr 2025 07:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009772; cv=none; b=E49FNGJmq2GLTosU9Cgkt2w4jsFTMCjuQ4AhTPu6bPe5QRGfj7FEgOjtnp/qEToFifj+u0lFLhP8x57Q1Cv3P7+fQ8N5bHWzOEwwT/JXFUUqApw23O1p7VtMC2donQ1gCEVjnKxOYs9mJgiAYipTvzM+XNrQUtB7VbFMGsNpdYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009772; c=relaxed/simple; bh=Xs8kT13TgDgVr1qQQSggiPnN5GRLN0/V9PojPokFU8s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nHtSKE9kifY8sS/D/pWKZ2gpheu/OlUHYceylgcoyOXc/i5tXqz2bVmXyCG8G98GCgl/4ld5QTPeDx1UReXdkxx27ZIqRx+Oo6jtewQtKY3Y8iVkZUgeqGdh3oaKSuA55tyBlgrPYyZR23ffDfr6920Tg1mshBKfLobvcbjpyMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=SLtCwcNi; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="SLtCwcNi" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43ede096d73so12713705e9.2 for ; Mon, 07 Apr 2025 00:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009769; x=1744614569; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HsaSC2HaVJRroJP0HwzWYTmvmXosq879cETOeyvqI4E=; b=SLtCwcNiO8bPbKD+/yFoDWx3A55MuLsnCvTZBtUQ0jDqPlYz4HkLJiIFjZH7UkC5Er SVliZDQZQ7L4zNAdx9CE92503bWyi0XYQ6HFIYW12764b44d8+vRjm0fpjJ25VNb6O8J 3SZGgRDWctv5ix8GZ9gobuLf/2BZLKiP9q0Ja/X13uNQ7V216yOGFHguDMWVRxc6dDoK RFMC98xUZIXjc2upNQ/f3KMkpNXKCKr6mkSvzzTjxEKHTyXV+eQKq//PW7hVshTYdAjq CghiMQSm31bBEHeqrEb1CWGDwFuzjq3zj02ZelfmR/dR7G67ILR4NincTc46y+ihXjUA ODSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009769; x=1744614569; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HsaSC2HaVJRroJP0HwzWYTmvmXosq879cETOeyvqI4E=; b=BkhU4yF1e/UQbbV3pyp0nITW580AAGNaNoQCMlrGF3A5i2fuT54LnQ0NozfPIppTwn kVYKyf6crme6MHrX6qBo5IXhHtL6CrtpjUjGOdook1kByfjzIl3XlLza2z1gV0UNaTsW s3U69CEvgSQo6RA9iOWoGzoYx6KJBYxga+soQTj9KHyAvdwKyOLSAP81S+S2I/IXGXpA +hmToYNzJI7HcLm9ErX411dy2HdkYvjE8SzrZTOQd1ifF33Q2YEXZa5L7iXheaFVSpZp U6G2G8IhkZ5vPd/oHy3BNABlzfJqu25cwy37KeLeUAhYhQUFRHymqrX0orHX72iGuTsH dW9g== X-Forwarded-Encrypted: i=1; AJvYcCUbYUW3vd+pfXdxSMsJGTiL0uEj3fvvSUvq2Wj3u6ykCxzRM5w/0RVsYLX5ap5I9ZrEZPyGAkFyd4UoT0c=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp8qvOSeTGxgL9U0dJOOkYYU8kzJHDw9zogIzLWnEp9+h4/wIg K0mqE1iFsJyo8xax+kxYGojHWRM01v6ppwREwgV9xsE64bS6MeGRdHM0DclvbZI= X-Gm-Gg: ASbGnctOQsDRa2PWENTy4L/IoL53gnMBD5p0XYED9MlwxDCNr8T+0tf7aBX655hPD56 KIvHz0nrr1iWPHQbH2U1gW8m09t+MHqfho0ri+7t91Pakmuy5vvhYJvgwkJLt6VLO9B9iUR2mvu 6TBBPGGYnheNbyFVbPXRMDxAIHYT1MoDPh8tPJtQTfc7koLWkx6iv+UlWuSylro4htwohPEY7Zo skkaCOWftIssyefhpHkIo0DB5EqOyDb4f04QvafXeebxtCRVPp2M47FHokBJ3zrwrXVdl4O+3s2 DciPKUJZBhoF/eizoeUaQ0IIxCTvBjPAKYmUwQ== X-Google-Smtp-Source: AGHT+IFoq+Y3x3L+TzUAPfnpayxhMl0EXTH8ChvoeKZsiBjolFAg72wzCsqeqv6HGqtEWqKDzyAzpA== X-Received: by 2002:a05:600c:5394:b0:43e:bdf7:7975 with SMTP id 5b1f17b1804b1-43ed0db4aa5mr81239825e9.32.1744009769231; Mon, 07 Apr 2025 00:09:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:28 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:21 +0200 Subject: [PATCH 4/4] ARM: s3c/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-gpiochip-set-rv-arm-v1-4-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1523; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=abv30zYA5XuyGwoeP1ru48ZEwjgixTtNG3nmu6YE3a4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83oktedBQx8pZUxbFWhdPQr1mhvAceAMNekvM eg9/SFm5bCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6JAAKCRARpy6gFHHX cr4uD/920+W4HTn/DythHwMtCVrHef5JpB0YFglUyOJ4l+wrZNhV0VZcDRiw3F4l9uygDSEhyso biZUtfnWodZkYBVGq/dILl7oXl7vF8oWyBJBOzWK3dQxlFdzjiwjxS61wFDTiJtDqrwoHDBGvTP cdZzcOKwYrcWrxD1m8tsHEr4sYBaocCBaMA2DwOBsmTMuwLcnEhYE5HaoI7qjMdz+F5QjH+F5lT F4ogzhuGDbEZ6J5R06tmUkVr48izLrPyCCplJRhaREIq62mx+mTilrFqFpqxB2iDdfr46vmCzuJ 7xIvHs5P4COrgPm6/I5bKr+h3+1VzO7HQFBoDKY2Xuzejttwa3sTTD2RzFuKJiHYYkQM0Oxw178 Evb4gwQE/VxyQWocnlavibF52tIaBu3yLnHlf677OVaESjEllEOiw4lWfYVjj0vfVMDeR1OMO1/ +KBoC+MsYFiv2hkzvDRonuAMQITxCp1ygc3x2w6s9X7KYWS1CkudDWlCs/NRSMobunZUcYUkspl nsvorsS0oxCLJ07Oetc1JL7Q7A9uln5YELWlRQEIIT8hUBtLX7zVdJtvH6QwPqg5flDaNLjrTz/ O4tqaQq1mIozfl75z4Xn3k4+O6OudAZzvKN7VnXBJAK8HhrKrll2cDu2DajhxBcH61elXnqtFyn KFr7Ne2L2ryXdeA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- arch/arm/mach-s3c/gpio-samsung.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-sams= ung.c index 87daaa09e2c3..ea496958f488 100644 --- a/arch/arm/mach-s3c/gpio-samsung.c +++ b/arch/arm/mach-s3c/gpio-samsung.c @@ -430,8 +430,8 @@ static int samsung_gpiolib_4bit2_output(struct gpio_chi= p *chip, return 0; } =20 -static void samsung_gpiolib_set(struct gpio_chip *chip, - unsigned offset, int value) +static int samsung_gpiolib_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct samsung_gpio_chip *ourchip =3D to_samsung_gpio(chip); void __iomem *base =3D ourchip->base; @@ -447,6 +447,8 @@ static void samsung_gpiolib_set(struct gpio_chip *chip, __raw_writel(dat, base + 0x04); =20 samsung_gpio_unlock(ourchip, flags); + + return 0; } =20 static int samsung_gpiolib_get(struct gpio_chip *chip, unsigned offset) @@ -515,7 +517,7 @@ static void __init samsung_gpiolib_add(struct samsung_g= pio_chip *chip) if (!gc->direction_output) gc->direction_output =3D samsung_gpiolib_2bit_output; if (!gc->set) - gc->set =3D samsung_gpiolib_set; + gc->set_rv =3D samsung_gpiolib_set; if (!gc->get) gc->get =3D samsung_gpiolib_get; =20 --=20 2.45.2