From nobody Tue Feb 10 00:59:21 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECF511F791A for ; Mon, 7 Apr 2025 15:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744038674; cv=none; b=Shiq0sgwtDtzIx3ELMfVeiUqfX5s4dFe3w6xHzRWld49yjjN4XIRZpjsHgoJEW29jmBOYxRq+lHL6N6FfbWjvYDrEpYLSORiXOuEC/r5VbWb40BOu2fAP5NZYkYMDSnbqxZ8j79buk/WFgYaxA6QoVGGxIj9y2zCDC+7oijIL+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744038674; c=relaxed/simple; bh=oaS6Po7R+cg+gJ6q7cqgSpb16Fo8ijum1OmXH8rf4TE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QJiVoqir6X1wSEOOPVnS/tVBGf6JiUqsAfMWGZ1RYnHU0uVpKL0ctpKXqr2KwxA4T3e5qMDDH1vNIeWayZ4xj89KzOzSNlK533DPkoeiKE584iJDi2MB3H6aXW52x3GGpruIbyHX+WekNenK+s6t1ae2iNwFzC3OzAQ6t0rBBvo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EJBAfHd2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EJBAfHd2" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5378dn6k001263 for ; Mon, 7 Apr 2025 15:11:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2dg8MLoyMdO4bnciC488h9CAEdYdwBoAJfBSIFF1DXs=; b=EJBAfHd2tPpYvhW/ L5x9CMmR9sxSO104dBmdeVMBZNEmjod0Dzqb9vXTyqKGibfwIBwKnsAI6rpCJwhg Cb8yuZQ15D6lEwYO9cyFcjp5LSp3SmAUX4VK4tw5D9XgAwnD2yhM2q1tZmDEloAI 8WsyHYGBaMSpjtJyYLycipSlW9og0DfyyxsXInEftiOAP3OSYuY5sr3mtM20JyTf PmZmKrQWYRDdjZj7c2B4WYZ/lQfRCXYUjo4tRffB1Cw97dZXQYlcUs+Kx+IRTGzg pToY9WexAFxVh+7Ao84pQf0HggV+52oWYlMTIiU0oDgVTtrvVyNsm3kTv5pzSdNT qQWGbQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twfkcjtu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 07 Apr 2025 15:11:06 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c53e316734so828172385a.2 for ; Mon, 07 Apr 2025 08:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744038665; x=1744643465; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2dg8MLoyMdO4bnciC488h9CAEdYdwBoAJfBSIFF1DXs=; b=NvuK34UNTkNDe6OFP/mWh62sj9cH0dF/2I0YmsQoONI1ueS0BvWYjDad0rEE9bDuuk RyKmCqBvlZZlVFeV7DvgceXYYZVhHfdfsVnVNkCIMPP2fIDK4TYzoigPa9INsPoN9tal /bHp/IpuOfSAqu3STSP2JlWcpnDXVjHFzpy8WxvUMa2e5W4Bg73F5k0v6Yd2YbrgFzE+ R8z9qHiWQ7vr9HEeayyVipuQB5F2iZeraWM7RVuhntndQ0OULkPURgDXUkwMZSIEvQiy jrdT8r6erXg8bRiBS88DnGYVmmHbhi2dcA+qm/Xp3uFxXrnvr+tL8JAsy7gAWppng98i +9fQ== X-Forwarded-Encrypted: i=1; AJvYcCWWPocpf+M6SqQEUEUg/3vH6Atlel+97CipPYpd9TRaAXy7RTBHlmZQfgHhz90zoI9/d8uJ+/mDHOnLcac=@vger.kernel.org X-Gm-Message-State: AOJu0YzkOqOfjaCt2s6TidqPGcpaUkxQHYN5vCjK40IzrpyrtkDsgdpr GeWw9m5Ru+Yvp901CwCkg8JsT0wnRpdJoEhSYUINll8jccoanW1x1xbt6W+SidveVflaeGfkrVl RngT03iHWNRgjlpJNBA0V37f3e1m0wQ9QXqR2h5q9AaLayu3LDcuARfGekdxDy1w= X-Gm-Gg: ASbGncuwSoygw5h7HgqWTIgqdWNfDACDzuKhFE+IRfNxCsMJdsvDU5OSlAwMxLZQLQF 0MeU7KN+VvR+aj/6YTdDGPPt0TYJ7Jb3IhpOmFqxUXf+LoQjkEJVPS+5UyHvJYKeLZtwu030Kqd anvgUQRJgSEundZn/2wK9BhBvYt+TAgVWN6Yo2RCzbh2oH6AWmo69eJbZ/lozmGGb3Y6hHQ1Ea1 OgPn6N01ZU7+Svj46jJraLZGIJnJtxUt/Sn5aI5m+A/8intPJls5LKu9KwTO+tGXEGFELfTBzqv oDUZ+V4NPTiVMtY1D7h4pZaRVcbRYCXptVJgRmXXZ3w/L/K7LF4cidFpdzJ8BuPeBoAWHIrXwuz EYAuGKlg1x7a9LgOmA++V3zv3cWss X-Received: by 2002:a05:620a:3908:b0:7c5:3c62:804c with SMTP id af79cd13be357-7c775a0fefcmr1906201485a.21.1744038665219; Mon, 07 Apr 2025 08:11:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDlJRYmAoin8RKcPtomZTWpx/eM/BRNf+B6vRyttUb2e1lAlCh/h5v9AMfZuwT13z+HVbcFg== X-Received: by 2002:a05:620a:3908:b0:7c5:3c62:804c with SMTP id af79cd13be357-7c775a0fefcmr1906194285a.21.1744038664674; Mon, 07 Apr 2025 08:11:04 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54c1e635becsm1312572e87.127.2025.04.07.08.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 08:11:02 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 07 Apr 2025 18:10:58 +0300 Subject: [PATCH v5 01/11] drm/bridge: move private data to the end of the struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250407-drm-hdmi-connector-cec-v5-1-04809b10d206@oss.qualcomm.com> References: <20250407-drm-hdmi-connector-cec-v5-0-04809b10d206@oss.qualcomm.com> In-Reply-To: <20250407-drm-hdmi-connector-cec-v5-0-04809b10d206@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1928; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=oaS6Po7R+cg+gJ6q7cqgSpb16Fo8ijum1OmXH8rf4TE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn8+sDBPrxcJmfZPhNdN842fpYMxj7J8nlN1ioL 70Hx3z+0/SJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ/PrAwAKCRCLPIo+Aiko 1RohCACfAxxhoIw9G7469v4BcpdAOjvEAiBG0ASIgfXb6OMbyhi4he+gtbgczPRs7gyvF0Ts4up cNwmrHfHkqpUQTABWTPK4eVPzOCPkFW+HawfYEpl32hpmDpxBLC2IlXBOHi5KIGcNypLrRQp3Kd FXOI4YI9pzTI9nF12WAu2G20oKSMI3sZu4DSbK0pWggbr0Jtq95gPNMvBnZGO/EG+i4qAdE20Wf QXt/B0mldnwC080GR/NxFCUnZ8mVfs5GDQn01yV6IzllPGK+jz5g1V3ctWLvnSaggKZh8zFuXDY I1aAgeHeWM29/4xl9VKR50VWwn/RsG9vn/Ill1Zq28MzV53k X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: VjrqqHDCuosLsnf4SfJ5IE6LZSYjBTUg X-Proofpoint-ORIG-GUID: VjrqqHDCuosLsnf4SfJ5IE6LZSYjBTUg X-Authority-Analysis: v=2.4 cv=b7Oy4sGx c=1 sm=1 tr=0 ts=67f3eb0a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=Am12PNO99IVxJwGJ:21 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=V95sz_wBBgzcx4ufKaUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-07_04,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 mlxscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504070106 WHen adding HDMI fields I didn't notice the private: declaration for HPD fields. Move private fields to the end of the struct drm_bride to have clear distinction between private and public fields. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov --- include/drm/drm_bridge.h | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 4e418a29a9ff9d014d6ac0910a5d9bcf7118195e..286f6fb3fe2b80f237db85dc845= 9430dc82337e2 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -977,21 +977,6 @@ struct drm_bridge { * @ddc: Associated I2C adapter for DDC access, if any. */ struct i2c_adapter *ddc; - /** private: */ - /** - * @hpd_mutex: Protects the @hpd_cb and @hpd_data fields. - */ - struct mutex hpd_mutex; - /** - * @hpd_cb: Hot plug detection callback, registered with - * drm_bridge_hpd_enable(). - */ - void (*hpd_cb)(void *data, enum drm_connector_status status); - /** - * @hpd_data: Private data passed to the Hot plug detection callback - * @hpd_cb. - */ - void *hpd_data; =20 /** * @vendor: Vendor of the product to be used for the SPD InfoFrame @@ -1043,6 +1028,22 @@ struct drm_bridge { * not used. */ int hdmi_audio_dai_port; + + /** private: */ + /** + * @hpd_mutex: Protects the @hpd_cb and @hpd_data fields. + */ + struct mutex hpd_mutex; + /** + * @hpd_cb: Hot plug detection callback, registered with + * drm_bridge_hpd_enable(). + */ + void (*hpd_cb)(void *data, enum drm_connector_status status); + /** + * @hpd_data: Private data passed to the Hot plug detection callback + * @hpd_cb. + */ + void *hpd_data; }; =20 static inline struct drm_bridge * --=20 2.39.5