From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6815C1A0B0E for ; Sun, 6 Apr 2025 19:50:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969030; cv=none; b=ES8zI7k+GR/WR7Pw8f0i4B/COgPOEqaOR42jF2m6agNafsKMYpZlgg1+LtTiEdMwmxR2/Q4oKxHag+FE+OJzftJ1BMuPDZQQqEkMzuOW01+LMKBXdotJ+lL3CYbxABi0RuoSVEIc3SMTNq1knAxVIRpscFofgBhVPLc9l6Eql7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969030; c=relaxed/simple; bh=lVX9gDSjYyL88HlwbYeVCE4D3bdTh5t0UN2VPaWosuA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fti3cp6uTfY32mQVoDO536Q3AQJZhtsTzR29MtnJncsXSHWNqCQxMuCLaLD6BOVTg+DKsoo22cljZoF/0XLXGJvocVwp9bScA/+nw7aGm044GV3H7fFR4d6uEerR5pe8Pklh04SJlLV6XELn7+errCFiG7BnYAz+0yt8bBoJ7ss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Goh28jVq; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Goh28jVq" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39ab85402c9so447209f8f.2 for ; Sun, 06 Apr 2025 12:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969027; x=1744573827; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AYyOGvMtr2olklUFal7Pv6grs8vJ7iFTWyWW2GDk7oM=; b=Goh28jVq2cZWV/dfH/PVF+aTGpZabIhIHuTZb0rtfwMFwCwkYJb1AMGamYPCAP6WRl RWTbaBMrsX52kKNu/5YGQ89wB4TgAzICF+9ua8JOLKv5iGFKqiGylDfoIjWG/4Yp6v9G Gdtsctdd90z6VWJ1k5RKSjaHiooKM8Tnxz38AwckY7jmGtTW55e6vo7msxM69p0XTUxZ toopDDX6Lj/U1YCXELcB+q5Szt4OyWBDQV3/a6D6wzs+D4lxgr6Z7zImQywx7Obkr+wA yfyDMDgsMRbFsSUadiVlHE/MZrHkw5v5wX3hWC7ssUnbSEm+TlTWMRhULDlap0xoJtE8 WzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969027; x=1744573827; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AYyOGvMtr2olklUFal7Pv6grs8vJ7iFTWyWW2GDk7oM=; b=MEj6eqHUslD1KiiBtHMF138qC9+hNbWAmk5JpCXyBNWlMbaPe4x70z5wfDj/tRNFNl 3UDHbqI24bwazeT4Ythe2anoEqrSSClii5EQ2R+SUNJBq+o+8ZL0unmCKq316kX1gGRw ZIppGVyPCQimTR8aqWR7iPv726f42ye34uthfI55p1nAq5n7rLrMrcutBOp1XsM5QsQ2 SaBAehDY5JJZhtG+t7WKw0pwvFCeyL2NaRPdy7uYGR/gHiySvC8EKCFouGBzP8S2DDES ffjHS0S6HSpKcSqbyDYP7nKM+Ra2S9315HJ0G1/mUKrIISp8dFXojyDo9JfI0civJMfg VrSQ== X-Gm-Message-State: AOJu0YxeFbDR4uo5UX7QVE/u2iYehwm0JGxOAxyqv8NCCdnETVE2Wrf5 DtpHGDRtBFtMfPnccX8fT/ohvmbKsA0A46AMTPkGEn+8hZ67TQivzt4Apgjadms= X-Gm-Gg: ASbGncsb9hcTEqcShf1Pro1fKxq7oM7by28eLA6fPs1OGeh32Gu3iUiHMbkqhUvbqsP QExPkD4Ngg740S6a/yCoRWwAbIiRAx3+cZoL8Q21MF8S08O1skllygWvPmX5Db6c38U2Owk/ZDF 2RDkHETeykAtkWEbmBmdxQU8SCIicyEJ6/TPUZvxV+jAXIFHmbnQ+A/9Lm2mivY3lzeexBHbljs UU9qGcfB9vjG6UPty+rBLbr4cxYYcTRs17LFZJl/yOmkk45nwrInYxiML+JkfpX4DGJyGejVW9B R9uzqrLHDu+pJ43jZUAW26Gv6jsRmqF9pM589xq56Z+LvZqlzG0mkmxLHex6aMU= X-Google-Smtp-Source: AGHT+IEBtWLQ26wYm2Ac+98+IMKLTggihCv9ZU5gkzhyVxSqqSeYKxF5OfHc/JdpLP7+LJk1jY7Y+w== X-Received: by 2002:a05:600c:1c93:b0:439:88bb:d00b with SMTP id 5b1f17b1804b1-43ecfa02814mr28929145e9.5.1743969026724; Sun, 06 Apr 2025 12:50:26 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:25 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:09 +0200 Subject: [PATCH 1/8] mfd: 88pm886: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-1-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=917; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=lVX9gDSjYyL88HlwbYeVCE4D3bdTh5t0UN2VPaWosuA=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr2LtIrIdHB+r6kobp+0sfhyJbSMSHY/XE8U 9IcObbOqwyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La9gAKCRDBN2bmhouD 14sBD/9EMepXnRWheaplHT4ZK75kU0fzxj/I2Idpgbx8/Q3nTfoP+dbDnNcl6ohNvEseyJsKSps FVqXnHZqcEQAYgZm+N+HN7hZAUq5Ypt8efm2Y6EEUXSramp1aEhY4inEkY9/7Fd8m08b3feUQFS snfER9dwXFmqDEh6mF56M9p2yHhuV1Dm2lscNQ/rI7NpxDzQrESR0a3Gb+uUWpSt+u9fK0qKcjZ 9kfIbKKssVMdQ8wSdt5yPvgb/+YWVXYY03S+1Ba1wjXR6dDlAzTUB8PKVV46uvYjaH2a5zofVx/ JXcxbyxGDcjtlD6CaJZW86GxcM8ZGUWr+fHFGssQIPLt4siC6H+tEmTSEluCT4dR42HgH8YO4qo RTXxP1yxtxHNBTxUURjt+aa53PAFmM3lA20BAM45nJSPmubmrSh5VYZ26pxPdie1hhNIfdJx7K5 KS3frXk+Ose7ODDJoRawQxwgNF3g6LNHoMw0cHt4lqt3LGbDeyYVmwyqcK4WLGrv753nA8kOGFH 0R8cknJLdybh+vBH5dWdsH3Sz7Qbr/ugexrt390iemyqtoQrwkfe6HfAgE4y5H1Jq1CCTQTHog5 bRnh28wbb7bfW0xTYcjc0hSOoSYKjnfmuJtpTnhyBpt47ckgWDd1zLmgzA1QKlDg6c5OjPnIY/c svRye6jKd4pf8Sg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Karel Balej --- drivers/mfd/88pm886.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c index 891fdce5d8c12474e5e01152ca5fec8c88470b63..177878aa32f86eb59705ba6a120= 5eea43142d920 100644 --- a/drivers/mfd/88pm886.c +++ b/drivers/mfd/88pm886.c @@ -124,7 +124,11 @@ static int pm886_probe(struct i2c_client *client) if (err) return dev_err_probe(dev, err, "Failed to register power off handler\n"); =20 - device_init_wakeup(dev, device_property_read_bool(dev, "wakeup-source")); + if (device_property_read_bool(dev, "wakeup-source")) { + err =3D devm_device_init_wakeup(dev); + if (err) + return dev_err_probe(dev, err, "Failed to init wakeup\n"); + } =20 return 0; } --=20 2.45.2 From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1C911A8418 for ; Sun, 6 Apr 2025 19:50:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969031; cv=none; b=Rx0Byjv65NUXsof4rkEmdtkTaSAFIrpXgBYq5jkCQG68wwmRL7Ndkdhe/OtyBD4AoSOIFtWHKVmuLHIaMrugzMv2l1WFgIJz5WvryNhPxm0e8sWxWhC3xoSkbvcg2FCenTuehhpCC+R+SF26YP6UUXbyPDFbIWLQLAIyX73aTFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969031; c=relaxed/simple; bh=OZBR51ofCbjDiq/dkmja/3ZQr/zVoxD7dJJE48cM7ps=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FOLV1p5cmkgG/eY0/fz0D77PAncs3McrKxYsnwrN+wT2AAMs5nV/cf2gZAEhQcItVHQvJtDvor+a8zz7FXEbMRKVHHa6THixUY583mCJ21+bJRLwH11FNU+n9Qk0EV+Ar/ahAAzWATSWUdxv06U+DAwvFNp+BG0ByKb9pG/FwjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rJW0Aovu; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rJW0Aovu" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3978ef9a778so502705f8f.0 for ; Sun, 06 Apr 2025 12:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969028; x=1744573828; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=InqHjFd6eIjileja4QJEXvFJJbSRcU7acJPNoaodKbI=; b=rJW0AovuaY0WPT/JzVnVUtbgJBcfXvSifBI05Tgxr/Qhnt3AtS0VjMpH2K6tfWGTi3 6FPL9lzTk8/N3y/NiDAgbT0TVXEjeN+3KE5cBdRTRaR6JHpwk+r0sj1L84Mq8B9WFSyn yX2EWS2uHqVce1Tt/z7SdeV5bWM0PPvOTX5jZMf+BBzzMXCGmGKwHgnEwlhuyXh2m/8G 0o5R8hFh+ToC4DKxp/lwMYrHavjGYRoYcKf3iYwCeBOgbV/O2iSGFf/gdDiN06zV1yH5 YI5E02vr9nkAquFcaEUyfvg6yYBXe9mhcm7fVQIyn9fGt18MX3PnhFOWxI9qI/i60PoL 2KiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969028; x=1744573828; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=InqHjFd6eIjileja4QJEXvFJJbSRcU7acJPNoaodKbI=; b=sHJEkpf6rSBGfpFWWERsrsg5Zk+ejFVfFUtGfQsxcZ3FOJkSTjvzQkhQ2RxEwlJPxM plh59RlBlRHzJEtwujJfWwQg9bcRxM/QrzumuViBuWu//cxTtbHQOTo+jdAHOc0RFimD dIRG1JZb09D5Z8HnKCBLcdy7XZVNBpMXf6WP3JM9mJXyuFBEuGuYJLOLaLRS+Vm979UR YYpoC83TaXqITk8N2ImJdbkK5B1zZ86mHWmffZXdnWTY3WbiBaJRz/zrSwsv3l9UCx6H x7S0TaHisX8f/j97HrtkGxonvmyWdw81AQuQdwRym8eHm79QdfoEBVTDpdZv/1LYSWvg XYxw== X-Gm-Message-State: AOJu0Yy1UoVF0vMnvvk+hMKySUfhfz8+Fdj034HY2NIH8UyoYiZ9Ebek goycepvgwX9UnbGClMu/mMLMDgzzr9NkQtD1ixFjOz8qE/toi+UbFxBviXeOjun2z5++bIx9t23 z X-Gm-Gg: ASbGncuUEeriDFw00nnlxWhF3lwOr4ukVBggaW7EMntc3YEKRUulDt9TBxRPOKUnib9 Bqjt4WbxpWowtERwub+55EHw3LPf9KPmFziU04EwEQX1p6hMa5nOW9V956Ib/tmSY5cntCeZj7J 7sWHOT3T2kHPpx4CdemLaarD/UP7uEPKVskvWiZD/erIHT1mx2JNy8ZoI4zrcFtvthlpVjzi5Er J30ZbCZr5NLXMpEJMN5UEBkJFpCypTmTpjtwbG8uO/4ycUyKdKum3p4jneupolVglTSUuOtkwCp tJKSTgem9IhPpiq7QDl3rIW9QSsBAKIpNrE5MKtzLjZ1bCf8ttyGe6ytaUM4TEU= X-Google-Smtp-Source: AGHT+IGrb5pMPoxaLOXALLl/mUYk8Q/ETOdSbGVyu1Hq4xg7ltPIcwQoXNzMTZ+Th6fOifSH0KHjNA== X-Received: by 2002:a5d:59ae:0:b0:391:2acc:aadf with SMTP id ffacd0b85a97d-39cb35bd538mr3357646f8f.6.1743969028106; Sun, 06 Apr 2025 12:50:28 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:27 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:10 +0200 Subject: [PATCH 2/8] mfd: as3722: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-2-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=827; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=OZBR51ofCbjDiq/dkmja/3ZQr/zVoxD7dJJE48cM7ps=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr30Eqe0yuwrzWkwQUn4o+4oAPoYgTtdOl1a honUSdswzOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La9wAKCRDBN2bmhouD 11yTEACV+TSe/z68unVWWchtJRrUG1QZRBIN+GoI973XQ00Hb/CIVqeb+f9tUMxaAFe4P3ZmLTV MlF5WoB7hwSSd6sFWRcIMyLTr3ObeeGtWDg0wwasFC+o7KvcjFoVnCTnSLqdvDNktXBxqU+WAjQ QIwOhgpWqCevukyInCMIwopv4uHsCEkFzpwgoDlSDAP69FsOHUz7kUTnmaBU5gfboBOdYlM/jth yGOlGzEQeiZ5/9YP0SEcQSCyi+TSarAueh0sxYE896lGzInFY0/kWLCkfYwxu6W+7FBlYhIkaov Q3MUJ9zN7JQzf5mQV9j1An0eU5yF7XxvvEbge3Y/v3BRcBSmWop0o7LsMagIYBt8S20r+TMsZWP SNA6rFrlyMJcrUvyamoghnBV9Dt1UGG22lUnJhi5wBzl5E+LKcyoNGgztn7yDcZw9cPH4DEesRQ CpUCckj0tk9fuqIVv8g7lSVXl++E91k4pir2XW6OuoLQ0tW37bLw2BpeWFv1vz5HGRNRh0gOOSz pX+SquolIuYW6iz86cpsHsDZ53Zu1M9P0+ho/Yem6IGxDCXnBHX2JK824LJBOEnSqLVHxpMXpRD 38oieaz+IHUNSGr33PNLxhBkTM7eXOdCd97gMx8VqlEREvvh63rVvLtdsjPEMWmpKr+4YQI9SVn JuaGvEQwW0Rq5Wg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/as3722.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/as3722.c b/drivers/mfd/as3722.c index 6c0d89b0c7e3faa2f82a265df245c6abc6617e48..7ab6fcc9c27c8f8284d5e2a7bf4= 291d582b9ca22 100644 --- a/drivers/mfd/as3722.c +++ b/drivers/mfd/as3722.c @@ -394,7 +394,9 @@ static int as3722_i2c_probe(struct i2c_client *i2c) return ret; } =20 - device_init_wakeup(as3722->dev, true); + ret =3D devm_device_init_wakeup(as3722->dev); + if (ret) + return dev_err_probe(as3722->dev, ret, "Failed to init wakeup\n"); =20 dev_dbg(as3722->dev, "AS3722 core driver initialized successfully\n"); return 0; --=20 2.45.2 From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E622F1ACEDE for ; Sun, 6 Apr 2025 19:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969033; cv=none; b=Cg/sYFpslAQgiaedD5pH22pMSUAgd1uFVi6F6+umuKXHCLD3mh/GCrTBYCgPhQWBS5KWItDEQO6dGPPX4ERsH9WQOxjePn3YYpJM3JwH5md/vTPjt83Sv3kAWaMzS3RwIV79XQ7RtmbkSxGbIeOVAHPm1dIE2+JyVazR6JLEKkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969033; c=relaxed/simple; bh=7E3lHXVCsgJOkQ7AaPEKNlLTmxxbGsbpfYEKauuK9hk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aFP75WOokBnCvsM2Y3qqZkxCnriTWXQcNwy88GJ88+uZX28X7+DHIBEDCqwGK2XxddmQDdwbj6vF8XcSNJgASRRrjbNL/UtQHqhvWmsbqgXbb7ZQFi6WGWV264nJGbg/ngXQ6f7ZgBmCeGQ1Fw6xLHcjHs240jVyifpwgojtOKY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=A/NHdnbd; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A/NHdnbd" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39973c72e8cso400091f8f.0 for ; Sun, 06 Apr 2025 12:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969030; x=1744573830; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VR97euHE162ApOlfxWuhoAZeFnhz9Q18WWSjNJsmRcQ=; b=A/NHdnbditwDch8uCa9jbR2tnHEbVteQ3oBNr9ktgflABJNFU1UvqbwVmIHM1EOd9N 9FjD0t7009TACnVcWCTtTchSF+4roU6uz/ANDjdj1WHXIVEsPnO7mZe1alGN6C7Go/KV Vc0FxuGhHNnscc5S+YI7sJOxeWvmzXK9PpHHno3zizE2MI9zfeL8Dd/GH7TapcHVk4y9 xuSoOiCFLEmaRpWppAGnscbY9+9e6NGDPrzmQpxtUUpcWtOzo5rLoz2l6nGnhOQgCuqT U/NophUNsIXA4zjA4cg1IkfyQzPa2ngixJO+GLtpZ+q7oVloOAfWw6Jz39gc2S/w20+O 5JeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969030; x=1744573830; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VR97euHE162ApOlfxWuhoAZeFnhz9Q18WWSjNJsmRcQ=; b=MUACwBMWzf3FqNu2iW2V1Y2DJg1go2FwJvvQ6UB0JBocWVm2ljVsQzDFVnAaV5O4sm q5CHu2KFmzmT2EuHfus7bwjC90XW9wVrjTSoZe997teOpEcEndrKEkWFC0lh4LnUWjx+ ovwgHlWNmCJzQwPtSJU2QSZNpttbfHV9DsgtGOmAtFEciHQNfZRHzDC2jCA1g50dCH6v Jm5WQvTRNoyeKDo0oTCG2BVV0CLiwO1xjeMJmlr1nkekZpxUOQk0QWIdo9gVRVchSFyq SWz3kvUyZ2KUZQYMFR055/OnlWKvk+xKbab66Vs8D2fFDRIDBHYCvscply7tFATDXb14 pX9Q== X-Gm-Message-State: AOJu0Yx/e1otX2zJQVLGwr6vxQICKkMgIv+GmWZYPwceYrJ1HIQUpcJO eb1PTnadnVSyfPkC9j/KTal38pzTYk/29iB9UMqUurtdQwVf+bCQNvDic03z3LlYq8JWt+v7v/X 4 X-Gm-Gg: ASbGncs9Lk9tWwWpcw7rLfzmK2uwjBbIpTCkWo0gEaCLIVLSAr2MZkkr2VHk6yUQSSg l+ohjBjTiPo2hNMzqrrBrKufw71XsQJzzxF2vtlaQ2zONUxAPiABo8CKFgc1AU6qmESCCQLGm8+ fD7hKxrOm0S0PTOiOdblXnRnwCqk0A1kBQNJ05baMFD/bJZBEDIGFZEVqA7H1DAt4ZF7p7hhSQ1 z5Pg/mLHtzpU/gdwbDtytdtEbxnj7RA9sCUxssSUWEyThM8ER8klNp+TvZzrd5V8fw1DgwohwDs JPx5fQ7r2Owczx44bJ3A+vgcwnn4KoYbW5wYz8XCcYMNNV3Q2yL6G9PizG6i9Vg= X-Google-Smtp-Source: AGHT+IEtbLNMWw4XaETfOT1ZVrJRsoA6YQ4JX3rCVHW3wWScVhJbyysTJPCmndulqnls/c6HijzdPw== X-Received: by 2002:a05:600c:45d0:b0:43d:2318:ed7f with SMTP id 5b1f17b1804b1-43ecf57e769mr34648875e9.0.1743969030323; Sun, 06 Apr 2025 12:50:30 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:29 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:11 +0200 Subject: [PATCH 3/8] mfd: max14577: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-3-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=798; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=7E3lHXVCsgJOkQ7AaPEKNlLTmxxbGsbpfYEKauuK9hk=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr3ROW9QB8peMNUt0PvVNsXHegREeVqqwtYJ RV5ejDG4dmJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La9wAKCRDBN2bmhouD 13S/D/wPqpX4uT5yfTWz0Gu2YhI1/k6Xhy3CoEseQGJPBNQqkVSIvj2pNNtsG2YsuaYdAhB8e3U +5FEco5rUvBuJ8NQOtNzNjHFU2gNei8OUaW8U4aw2meFoaAIjTHZM0z5ZrWKUx5+EBDhfTzJH/M PqPWHmXkS/3EtilpaITZpFm7tyF27nMSLTjx3wni9vvYGvtL/eWarscK9lCA+UXrX/oGkuC2MLQ aZj/rrrWbjaHcXa8TYmMO8Tw7gHQMx8nMGwojJMqOixni7Gh8whWFaSVt54IoP/itQ1Qz9OF2tg H6r3onywTVWs/uUm9LtZYmi9L6zqcqCrlrKKwKsUUQLty9iRwAw2CzJ5FbU65nXkZS64J7awumE YmF6YK25RrYN8WIVUDwOtA+03ufB9iEMu4iFvu209zNYVpfGXDEcoTXa+3PNur54bWFZFkA2nxN PxC38C/sGPRoonPFT6IL/7rmakrDHI7DPn6lwrdAgXNsrl4ZiAvrTKJKnSzyS8iif5qqwGh0VqV tojzupb2rlHCzTc1SXdRo7cj8nopzZTkWvUXHwKHelsCSguBzozL53dh9MFgAf2pBjlKpDlT+nU iKPrOuycEmUTK/o2Ety2c3Enf3RPKKMAlOb5j09QxsPVFpOUIzBF2/OOO1qZEoDnTX9OpZGcX+F g1NzWNGZPsdJClw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/max14577.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index 6fce79ec2dc64682ef4d85f22d762ec8e2ce1adb..7e7e8af9af224660557e76c2b80= d92b05c86d202 100644 --- a/drivers/mfd/max14577.c +++ b/drivers/mfd/max14577.c @@ -456,6 +456,7 @@ static void max14577_i2c_remove(struct i2c_client *i2c) { struct max14577 *max14577 =3D i2c_get_clientdata(i2c); =20 + device_init_wakeup(max14577->dev, false); mfd_remove_devices(max14577->dev); regmap_del_irq_chip(max14577->irq, max14577->irq_data); if (max14577->dev_type =3D=3D MAXIM_DEVICE_TYPE_MAX77836) --=20 2.45.2 From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46CAB1B4223 for ; Sun, 6 Apr 2025 19:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969035; cv=none; b=nSpTrTNts1hyFzelVuQvPbFVa5J4sjXsiwNlaFYasmkCpXkh01Plct86bxNHyXzvQPcm/mIlIGzI4vTTXfzPnaeCfd6kCz/shO0gVgGxddImxCAeQD3wTX/d70XKOo6gXKHwgIkComTgiFyFLI1QPQN9kg5pLHih775+JO94BHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969035; c=relaxed/simple; bh=a9qheLkJ9G/a0gSpyASbiRRdDdncTZ0T8HcY8kFp15I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M6V756yFtK9P8d210l3p/2sv50/s13eBj3sgkuo8fMJmBoo0hZLITzWKqNZgncP1HZfO0NEPu7XlJKuF1/0Ot+PE3j1HAou2jH+Zy/3UYb8SOv8b0Pyb/WQq4BhWJwaCasR1qugLaOea6aZfdeZKGq4ztclpsI0mtQRb/ESnQ2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GXwX43MG; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GXwX43MG" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3912b75c0f2so498308f8f.0 for ; Sun, 06 Apr 2025 12:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969031; x=1744573831; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZDkiZVmg4AIfX8pESt1JXnk8CGq+bjZDxSINRLpNjsQ=; b=GXwX43MGn+irBKyMc0jT5DBkrgmAjgNtlRXt8b73D0BjzzJI7793qLLuIqoy9Qp7lC LbZ6qvBgCg0fleuN/x6KGA492igoT//xaJ+G1wKCruEZoWVncBb1F2js/G61gFXXHjmJ G4m7ZYNNsmgWtK4a2g95ARRjRm+DDy0J/+N/gdbExgBaGmdPhqbK0iUXlLN2yOD6Np1G ZFAkvDdC4Bt3BeBDhn7OS7drhQ3tkGcD2vWQLmyBuW5fw+Lm2KOxHg26ExcIKwx4F5ud kj6PpQtQLopBGRDDS3cVo0+hWf2fmKx3NrlHzxHEUkruyNBzh95oRlUNzVM6/Q0kBaY6 bQJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969031; x=1744573831; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZDkiZVmg4AIfX8pESt1JXnk8CGq+bjZDxSINRLpNjsQ=; b=ZnfQnw+OZXTQ3GfauJNkdPK0oPGWHyRyjkWq58gFQ2o+M4j4PCvAceLLaDL8G0+DkJ UhF5i2j76LKSXHQlewIelLJoDb3PdEHjtItU/pTco79LAXF7ki14knJmCUJ6lfnhPvAY H2V2kwxrm7iqPd12gjLf43u/7rETEcxK1gJGAnASkQS8/sj2icZE7oN72jH+UKVeu3ia 2RHecGdKU/nL/izM0Y4s4rwBIXo/r7lnH0Xqx17Ni45qL9L/85qzOgeydHa25Pts54ac KqkGQAdx8CxkOfJfhAS6EmkV/QK4c9eOt49pvCeXRt+43pDyVhrN9INKB8y79BJyxYXO MSLg== X-Gm-Message-State: AOJu0YwwZnzwfs4ihwZ/X88d64d3ZC0FsRzREFrygtIUCxuZmJNL4vQa yAtNu7lqyNEZZupyfqJJVVMsrRKC69xs1XRXK/itDLXaRvTRKsqxFtG5nCpTgmQ= X-Gm-Gg: ASbGncv4WoIhaoVlIzokd0BWsdDxuIOWnkOoIPxFezgT0wTuSXlVnVDaxxp2ZWtrEg1 onHkG3+1b2WQHRM+oBZhObO+W2zkHOGkk9NjQTSRzwJaem/2x5HrI8QKmC1IeowyYWg9EPF7aQD 7SkpCVBfWhSVwl/WeCMVGaY3kCAzrF4ATHmmHSaxispTPiQumPUwR6AnNxSskzYEoGlm8+FT0pU aIoK0iRidvmZMeOzCnu/8X7bah6+EgkC8F7tw6nzJllfF1SQufhQES7Kb+6gAC8YT3tqi6Sx6AA +gMLgod76G2By5ErZDasvRG9cACdjBnbfl4dCRFEGhB/rtT+pAxa1yEKYy6/V1U= X-Google-Smtp-Source: AGHT+IHLrtMclK8VcZgIu5o7LMvtyM3oVnyeACZFIOpwCRqYoq9QiN4CsiiISvWSu47uMhHgmdiXmA== X-Received: by 2002:a05:600c:35c2:b0:43b:c962:ad29 with SMTP id 5b1f17b1804b1-43ecf81e058mr30045245e9.1.1743969031565; Sun, 06 Apr 2025 12:50:31 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:31 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:12 +0200 Subject: [PATCH 4/8] mfd: max77541: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-4-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=785; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=a9qheLkJ9G/a0gSpyASbiRRdDdncTZ0T8HcY8kFp15I=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr4AV7Y4qG43E9u6J2PWTGEE8to4nntaI6ya qZwORfWCa6JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La+AAKCRDBN2bmhouD 1wxND/9qo7JsMiyvaVPUtWqdVDMzJMgEyq9td+m7R0bAAg+rPqBziSVJyoxvfPavvBlhMh5iLxP 3OAD+AKBqJKONv15meWcd8JAuoIOrdMK2XNAWXRe9DubIpaSHi+HhA0yTgrlN59FWZEbKyOY7va cE/xYgiVIii/ojRkSubeakK6A1bhzBL3FruTCCFyy08Hw4szbsbJytcDClDYHaIPch0ZKsBQbIr XGvpIR7oaeyr3C1WGi78Cc9pM+eV8N8NEij5c0Sgw2/GbWxkua+kfP1uDxpLGbql9XSLxwTGdXK 2xquKOg2y4tSwFXd1sf2JogrpGJoPpSnzOoPd5SGBw0d0rv59LbzMDK/6ZV0F3PtHml5tqxbRKj 4+/PDN50j7o5vDxY8o5kj98fi3DRjLO8CH8E6lnALMqeW4TxXVFXbwzawNmn9u3xf12mOcaKhZu 5YQ4kBZLHgB0UCWi/6HSOAixoTKLNrZGSWwOdQpJzWtRf1jRW1wwSD9eH6R3JEAOkUPWwZL2mGe 7d9lzPlClC1dHit7y6sjk6RsATVuvzqx279+owl0N3fg9+e9OxQKxeknPV7+/XMGAavzbK4qAzK ys5Nok0FktnYBhFf5OLe5EEkJNdBlx4xF6XaomkXyx/ybK60Z/nT6MNq91NVVH3CnRiFpJmB+X2 aB2ny2dvLWgKBMw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/max77541.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max77541.c b/drivers/mfd/max77541.c index d77c31c86e4356f5c19eb0e1d958d1e2f360f4cb..f91b4f5373ce938ccdab2d47303= 9540aeb408b1d 100644 --- a/drivers/mfd/max77541.c +++ b/drivers/mfd/max77541.c @@ -152,7 +152,7 @@ static int max77541_pmic_setup(struct device *dev) if (ret) return dev_err_probe(dev, ret, "Failed to initialize IRQ\n"); =20 - ret =3D device_init_wakeup(dev, true); + ret =3D devm_device_init_wakeup(dev); if (ret) return dev_err_probe(dev, ret, "Unable to init wakeup\n"); =20 --=20 2.45.2 From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83066218584 for ; Sun, 6 Apr 2025 19:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969037; cv=none; b=nQKIQwtXFGMA3wLKbO92JvgOzsYynsZRwfb+qpNY70Zd5831ZLnDzGv5FLuOUtUHnSwW/o8aWSz7NE2Y3MymMWbRxj3lq6jXyzmlYavhdY+oW01YbOnR8hnZqV61QZ0m6rl6bGbO+BsBjSx8aMkHpVwiDUuaIFEI1PvUjPrVrLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969037; c=relaxed/simple; bh=JGGWrG4absQUDWmRbcKC4qXfgvzU72WUJzF0YeEqSjc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qE4LhM9mcaAKZNh5sIMz+HhrSsLaGN+4klftqbris3GLzO4HID7sLsfc4pKC7fZdLltSzQjy+SCz4dHiIKd1JLYd4havByJ7o088jy6sXvW8BAQk5ZCH7IOqbHjQks8HJHXUC1SZz3ITVHJQVLFUapVX3fnY4s7OhvtS9H3TVZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mZdYI48t; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mZdYI48t" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cfe99f2a7so3217795e9.2 for ; Sun, 06 Apr 2025 12:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969034; x=1744573834; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6V7osuV6lovwu0xN384fR/yvO6h1FfTw5XdE2hnaBMI=; b=mZdYI48t3V22asfGDRK9Pl5/ic7LEjlyZyqSPcfFF8gILgNCpFajKXCawf6NjrkHmG rj0JpWtw76bf9mFC6Xhn0SVFBgX2rtIkivpQTfVguWGym4Y2neprwThoQUkkUdhzMt6s MR+xPAz4fF6FPGdOTaeZBSwAm1waD5PheRI2dOW24cgkozAgwURS8qNiaQ810UwMY+W9 fI8jzGPXktM0PaSUbT62WLFsMfvaCEG7vl3+XkO8WTwxlEfF4IJ22h9QFSOHrSvy2872 NS7P2AjeYvog90w3EzEa/M/uhQfUWVAupGsOrXNHHOAa9YPSpEzqzJ7VoGqJtzeKUQ3s pjGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969034; x=1744573834; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6V7osuV6lovwu0xN384fR/yvO6h1FfTw5XdE2hnaBMI=; b=n8AFYXrcHjWHaZAtiSMborBet2YJb6ubaEj2IKMXOi2GFvyHL+4otnYbt/gCbt3EhZ ztFTzf2PsivRYvgL1jzyrI15OwdAp6fA5ILExinHcsZJJfZVKjlZx8JWfIured1/UjAE K+CCzN7STNW1DN0Wn8ecYGIinAedFOxlGrejghRiv/gJLIo18aYn3QBK7PKEZAsNjx6Y cunBEuv+yf+L66/UKqE4eYD8IsK2dvLGp6PLaOGJEoNuGNN3amhlos8tTQxvyqJAq4gJ NuW18dW5vCI2v81MN1B7a+QOZRv6eDqqIZ6jNY1MJ8Ch9+GVQiayLuGaoGd8PEXqe+vO IkZQ== X-Gm-Message-State: AOJu0Yw2KZsXtLEpS86jvQEZGXK1YV65ZBFxP6Mm0OKRmsUNUXko36lD Y5EtWS2Uf+XIaimefj6eqbgFmzZMOTesWhHNPFCTMYgspc5bUDNB/MFllJjm2qw= X-Gm-Gg: ASbGncvQJ5NhthAbybWA14pZrej8wKBGfWPK1xRW7dKwwRRA8QqoGHqSMlxe2C2+M/I QEBV3JYbqG7EW3Bi/9TMdp/WQQaVw5vFn+cT5LMCuFDdwX9FjgA4mn1tLkT20PwtHkHbPg/MfaD 5EKq7xnuv+UYhgKWcIptj1BKIfL+JMPvI4FlJ1ZZaMmMT2uPyF7WE1gJ64quT+mr7yrieB43R0b BF0XkQro7W2N9hINZHQIlKrIN6u8sYiW2UL656vAi+y68ecahKb+HZ2D8qLezZDRyGG7vzoo0+Q yAhFMf7cjjaRbHKKgqw0RedMskRhm+sfzP7l93qUqHXTFTSFQpCVjTkb7za19ts= X-Google-Smtp-Source: AGHT+IGgzNK2npnlRNa+wPYD4/voMS34S6t/YpwmY2KhFc8g7SgC0GLpOsJxH1fI5JY5ItovfSkDAA== X-Received: by 2002:a5d:59ac:0:b0:391:2a9a:47a6 with SMTP id ffacd0b85a97d-39cb3595265mr3076887f8f.4.1743969033715; Sun, 06 Apr 2025 12:50:33 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:33 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:13 +0200 Subject: [PATCH 5/8] mfd: max77705: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-5-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=810; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=JGGWrG4absQUDWmRbcKC4qXfgvzU72WUJzF0YeEqSjc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr5H5hFgsx7YapzOJe/iMliWoB0ayQn2moZK T4gYym7oxKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La+QAKCRDBN2bmhouD 17RJD/98Z5aTZjNuITrUPDHZaMEx/JdRNkIfLvJ5ErWEr/bWhuoqlmLUb01B/5FGEdNcfA8AXBB Y3axWMt+mob9U7FDmqQlpCyRb8OwYun4twwoFsMhaksJ7gZ9l2rwxSwfkgRA+3xzanjZVxbu+15 DcX54i72iRLw+wB2Sinl7kHj8of1v0pbdUnZyKK9oZA++US7AE9b8G3VN91aPOBmflRQMLOQAqW qPC4dPTvIdgbw/R0h+ckmUnQCpM+QQEAUQRuLpJpHhM++lAK0cy64+TmjG7/HCXyq9RpUeaou7A P4bV7y0q64n6H1tSxyd3nOfVS6mvOnrxutnRnsWsKsbF3Ubncss7GXs6ccVrI87OFRs2mrlXmDi 2T1gwmpzNf97fSGv8iL1NfcuBfTZoIGLvrN7ARoqH9R4pGPiQUr8GIjwNXiTcEOC8aFPyENsI1U kAiTF0mhgDHsZcB8in45OZQLgzkcMSDe6bYzErvuViNGdYJHcCNW6W4cL8Br4Qr6q49NfnXFfUO L87YB7u+M+rNYhlNKau6vQbo9XP/70WE493fZey/7Y7qEQp427LsVuRJPCkfQgCrY85hwGBMwfE bzee13woXUu8R9Qp9gVqism7dNOLxZmqjdTtF10CMTiucvUimJpjacJd/r66mMeplithOMGkHUy Y2s6kublX5R/1bw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/max77705.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/max77705.c b/drivers/mfd/max77705.c index 60c457c21d952c2ad485f29619e014f5b85a2087..6b263bacb8c28d980e890777452= db58be84d7338 100644 --- a/drivers/mfd/max77705.c +++ b/drivers/mfd/max77705.c @@ -131,7 +131,9 @@ static int max77705_i2c_probe(struct i2c_client *i2c) if (ret) return dev_err_probe(dev, ret, "Failed to register child devices\n"); =20 - device_init_wakeup(dev, true); + ret =3D devm_device_init_wakeup(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to init wakeup\n"); =20 return 0; } --=20 2.45.2 From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF09218EBF for ; Sun, 6 Apr 2025 19:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969038; cv=none; b=ZRuLcx/sM/gP5lDvoF7JJEnlmk3bTlEr94HJb6gTxV6+ZYwhZZzrAJojMUt3oHbzJtLEmNnszPzzJvLHc3rTk8Lwx0WYjYr1pQpqs0S0/fjYXn3wFrBF8HkU8NSOClEuaTIuCYFeOM24Weqsp72ybbYRdMIR2igar7VRoZsmsxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969038; c=relaxed/simple; bh=38gA1wmDJiq2MveQQz3Y0vrR4PLJuhZIhh5UC/GMSyU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GYZfjw1/9cLPW/qe5vAmioJ0PdLYQu1GZZDS0H9Gq/e5l80kCrqjB6z6CwQdfLYchugi/trs+SA2jx8nHdZY87JXxknikXKb8fEHmDHl5+3jP/cVl4mGt+q8oJ/XOXyMMWqwbiuA14ljyNmuT1Jap1/Ibtgil+gH8KEdW/6mC78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Db/uOpcY; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Db/uOpcY" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-391295490c8so467153f8f.3 for ; Sun, 06 Apr 2025 12:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969035; x=1744573835; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KtUvKVwGlfNDMMI8xmsqOHk11vgUZVIptVfUJSQ2KJU=; b=Db/uOpcYo6cEGPEzh783amsVXacfv1zsnGpJlK9D+RwMb5C0knwG6vfoRUdoSfpKO7 I9GoG7Qvde5z1aSgfGsI/sZLbN0qDu5+43LDwoaAqzAo4XGMjqYY1I/JG7l+iBEG1fZp /fM+XuNVAI87DAlJUaukJ0Q7h/gniu+9Jw+a+tERnXZO20hTe9PSpf70X8UxrU8fl6bW ZozrDx9f8SG6wiZCETDVEIG1wKx1LapKR6EEEeaCdAItTFSial4Lw0jjxoFa+bF+YdX2 DqZtMEYygCJiCtjfAERHBOItAfaNgmU32dAkwHYLJlaNcQ4fs9jTrmpkeLvqLn3FVmyw PjWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969035; x=1744573835; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KtUvKVwGlfNDMMI8xmsqOHk11vgUZVIptVfUJSQ2KJU=; b=Z5putUslLNwh+Qku2laD32aWX989KoFHD+uTB83XeKpjOWxTDWtJksdjFIYJoOKbDK cdK8BtKlRS0ZUgkJhWIx8cQ6MNIP+9NIRP2oTlQMGWDjcbNjrTt5SvZXA5vU/JFz0M0k 7rj71MB5/vNqT9JO6BcZ8N3WwgeIRe6aR83csm3SU1NxjGyPq+quSTgVj2OoEUHl5Zlk JP3P5cf0zo5KlQgSr90Fiu0tPdsaFp9EXdCwuJNmC4vjgZIQEM/jvnlD8lc9L8F2cYWj 1l6iW8VlrF+iUoLsE78f98cvOpYE0RefbwjF7vPsMnNDt8FYRu+HvulhaQKQ2RjEjYyA vM0Q== X-Gm-Message-State: AOJu0YykU92mhl7wedKcrord0d521deKRC3HP3E+GJRlmqer4AsMhmWN U7HPYltbTHNk0L2r3F9Xg5keNymDmgyVooJJg+YtPYHDetFaPKH8CRyPwFvxapU= X-Gm-Gg: ASbGncv8xa8TggeLcnkvhKPV2/TGAVGyi9xAdwmLoT2RJfSD23l0O2RmhRuAypelCMf mA5Xk73gWYN9xnpu1V3BdnEdeejQpQLfjigHoZPvoBKtkSkgFYxWYDn3KKdFR1DqQIK1ZPkLxIv jh6Gi8fqJ+Pyyt06ua56gyPrISljJqNooPwh7L9tivKffDbzV1ZWC/0wXYIXrEgEaQhaylXiM/y xFvzqlGn2EONP8sUtx4t2fL0xtG6Om39FtjT3BgSO1sy/CNXW+sEIT0XHIP/2h+A+yQaUHe8dc7 ZA0hYTrLplX0yKlZegASOue5LsU6m6zbrm1JXVIRoGCk7JTs5bs0h4pnxI2vucQ= X-Google-Smtp-Source: AGHT+IEnX2F1PQ7D2a3X+bMNU6jbxchHfi7I1dMv42d5su9NoaQH7MxGFAlEKmja0QRxfr5R/PRY0g== X-Received: by 2002:a5d:588b:0:b0:39c:12ce:1046 with SMTP id ffacd0b85a97d-39cb35a2333mr3395305f8f.6.1743969035003; Sun, 06 Apr 2025 12:50:35 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:34 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:14 +0200 Subject: [PATCH 6/8] mfd: max8925: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-6-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=763; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=38gA1wmDJiq2MveQQz3Y0vrR4PLJuhZIhh5UC/GMSyU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr6cHIk3YuQVDxcuznmbRzkZvhsaSrDwxx0h sKUjJTVZyaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La+gAKCRDBN2bmhouD 1zx5D/9WCjoI9qKUcLn6EJ3lpeu4rIeBJuhcrLRFNpURy7uC+zLyLGdFx5c6syawcY93sjxpmSc DnKHWKqGMRUe+6oHoraEIgLU03jv7cmXDhIITl43eISPLiChpr/MuRqf9WrujU2coOsow28aJOW rkYdLTxiLrxXd7gY0mWmAz0Y6yqEoz5lxUiHF9SQp82uxIHMLPuwEPFspyO3nA4iD4fPkyyr2B9 tz3g6b8UcOadPpaJQPWNmiWAH+Suld7Jp2Z0NHwk59qhAnqw8paSdk3JilFWeJFn73U4Ineya7Z 6E7rO68AksKoIYoC/wuFhxBDFJSwpvgKn0eIDANkz5uPKpePxooW4xS9q/74k2/WqQRE6VZtcwf 2E7IkVAkGRQnpvnMlSLCZKdVG0yRD/GzOx9KM3i/p+NVd8XyP/8M3ck3uxpnTDiIuZgdscW1m5y 0Lds1wj1vSD68lSs/ZPNQ1CtnG03cqPjpL8dGp/CKYwNqndrFRmLagrbkVRGZEEf6JoVJrd4aXl qlIXPFHSn8Gl26vsYCzw3fArOyq0qzXKomGFWVCvDOQRFub9ILV5QCWasLsVEBxnvcICdnuO5f/ JEmq+D9N6jiZkgJHTOyqwvh7TWaIQUuq+v3JVT0403TaUJoGnlBzCEfLNfK+RWeS2mXULTXd1nc RGKZeArmLsMb43w== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/max8925-i2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c index 556aea7ec0a0473edc9291cae0c82fe9b4ecb346..ab19ff0c786732be53e58a0162d= 2658650d88f47 100644 --- a/drivers/mfd/max8925-i2c.c +++ b/drivers/mfd/max8925-i2c.c @@ -201,6 +201,7 @@ static void max8925_remove(struct i2c_client *client) struct max8925_chip *chip =3D i2c_get_clientdata(client); =20 max8925_device_exit(chip); + device_init_wakeup(&client->dev, false); i2c_unregister_device(chip->adc); i2c_unregister_device(chip->rtc); } --=20 2.45.2 From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C8D021E0AD for ; Sun, 6 Apr 2025 19:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969040; cv=none; b=AhEXQC6pjIutxn01aKAEMmp2fqHEGTRRorI3V4HW6r/n4sRzpq/J5CdzofBlheTUNtH1okwpa8tNhFNEMunWFB6dGjed6/EkImhEM2UOKlsn/Kf592Y8zNMQXEsLPNuwCKzguuvoWsNI0iqgk8MILZhuEdL0f/vLJfnBchhlOA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969040; c=relaxed/simple; bh=PqhR2u/yGxy/oelp6gW7dR/9DhcPRUQZkAsbiQsmD60=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U7wGXdTW2lhL54jcT/Z/OG3veyzX2j2NPlYFMOSCHDHlrVij6aux+yeNI+u5wpDftT/XECkMV+IDCxZiTZgDa20f5Zpy39qyiyC+wLHQuH/ridK4ZFS8bsoU2kyVr7L7oQ7e0EAiYAzJvzQ8bsbKED1Gey7GHGgZURVzQ272Ujw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RqKGMdQM; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RqKGMdQM" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43d72b749dcso3815915e9.1 for ; Sun, 06 Apr 2025 12:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969037; x=1744573837; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UJd1xPX19vqrxzx7wek489USM3/BRbbH7R9o+Cf1Fms=; b=RqKGMdQMpiL250FP6CBC+lfYDJ4H1sM0XVkPjPkyE93hUUdOmd/MAdYS32961nuZBo DDiBpXmUlm0xypPDmuQgKu400bj3ucj000hmkgqvWUWuVAaRTpyT1CbKUuNvn5xeFLzt 9lubYX+6Xn0Ewm37jVWlF2PeQFexHhm1Y55r9xQLYw0k7tnTa9UeBMkzojr6VP7+DC9I hQ3YKgMbz0DeM80vh9HvulnXTFq5ZuNw4kT/LfLEiqdNUiTAz0Ao06ml43AhBPRH09NI dDCsIlFSlhCTwsTtwm764Zbz3a54FE/QOf7Xf0loD28EWwusjg3vDCfkUhw5DjjKRMbs qcGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969037; x=1744573837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UJd1xPX19vqrxzx7wek489USM3/BRbbH7R9o+Cf1Fms=; b=iMrgrJGIQLG5/L3CXpujDHr5z7Q2pr7TZmTozyRxRIIUUWDOktruRb4gS92pSTZRjy xtTksmlKrDf6hOn8xyuIWswgK6UruHGSd1W7COPyNFnUQT9r+7S8Xn65cuIUxiepNRuu ZGctd1LTu7D3VEaYFQcktfJigYSt7fCc5rYEr3ql5j5hd3ukZq4IQniNZH2if/RoqoWl o7/j0Gj5soZ55zk7BqZMLUZ4lGd7KCjFdKctwBc0TFdJsGWOxnYjLG8zm9WCFGMnDKNR 8Fmx1uI0KjbyriQGZwtTcrUMzUqqVzyTsljsKQdG04109mwL29AazaRNPTIQ2S3lCul4 32Ig== X-Gm-Message-State: AOJu0YzE4H1K0NMCGzY3NK628bz+vG9cjZ+L03BlsFGJ5Z/dRGMyOSZN VuEZhOQQuCHRFwcniEzC3ZCnYcxcZPGHoYMKdmop8t6DOrraMQ8ZjtHInkxxh7I= X-Gm-Gg: ASbGnct0iR9ZTvvaTlgtXW2wtCvdJ15CKIB1yZxlL6AAV7Pk9oRc47jq1k+OIKHs5VR PkfSc37k6D3x/e5fhV7vtYjfy2cFTB9Av1SPxyB8FTNU9rWfTiPcsBNoZ4DEIar6+9141yyw5GA FPnV1QRvUS4m+qS6lD9so+ZMZYMFxCQRjypliAxquJZqXqS4DOwvRpSNRDzmPeIc1iUFR1Ulpdp vNjOA9hgVIVwK6/A2GBOi5HWXnSKgW+KUW1O4esdZeUVP3ZaBeTx643WVr4dKe/XLF7Cf9Iu8iI nBZzxn7ko5Gow/0BMqEs9abtDMr8Yv7EeEpKDmEn0Jy6c/wyRtiXE4ZZCOgDH+M= X-Google-Smtp-Source: AGHT+IFdEF2v1BVmlavYslv7/3zMmZ34jleJS3IPAfEVH6nOf1Gy3bjd13qv8AM40K43+6NpvPAFfw== X-Received: by 2002:a05:6000:290a:b0:39c:1258:2c32 with SMTP id ffacd0b85a97d-39cba94c47emr2834985f8f.16.1743969037290; Sun, 06 Apr 2025 12:50:37 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:35 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:15 +0200 Subject: [PATCH 7/8] mfd: rt5033: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-7-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=801; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=PqhR2u/yGxy/oelp6gW7dR/9DhcPRUQZkAsbiQsmD60=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr7icFakcAhetNxA5r8+JC00HGpkyg1FxX/V AYjtqQZfFOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La+wAKCRDBN2bmhouD 14RWD/9yQ89eWw/K9bGHYd+h1MoJxTjk0W/WdnU2u8pJI5HmzwLMmRLd1OPRbrbhBaSiGVVUO4P b7/aTFBUBzmVeM4si4BNYv1zOk55DMh6Kzic4ZfDCs5fX+2fzhBuAw25X0ab0j1p2kduMRRtlZH mkN0G2cdEZpDiRpnA3BDxhcrb3HGe+IVS0kLJgx4N6/xPWW1MSqtYg6fokFJXgxETOq3bQuzmdB efxtc67W2glqmLcRs60txPvwnJdzGctNUCEbS9kASkac/UF1LVVJMgqCDi5PHRM4dk7THOzWIlE Tr2n5UaQHH+HZ3xN8FQyYo4+JWVKZ2C7c555M5Ap+L/3un9hOPlklF0syDDmtzfwfJCTNtFXiDz YKTMnyORw8gPmRdkJV23iFnTc55m3lc66S99kOjOGmXfruXthbP5i07TKUre9Wr9iZeT16CAa4T MndA1f0FjM8DpQs2BnPCulttg11jT3wSB2B0c+wRqpIBYPAyD46N2vXnkVmza5pMaA2JylzonC8 AVDE2vAqHh6IrYXwgV7LwXTo/ySP3cW2s4H/na2yrgnDcLbXPcffXmzvcV78rGm4oImBHft5pyi 6intRO9dZExukyQ4HYqkuTQ37Ganzao5hEYdgHOQ526xqKfv6UIp6bwywi6aATwQw/pwoZ6sIL0 nfgohLpV/PlDYgg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/rt5033.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index 84ebc96f58e48d3b55abab75d64efde2fdb02f66..2204bf1c5a51a864b1ca2cb1be4= 5272d65630d15 100644 --- a/drivers/mfd/rt5033.c +++ b/drivers/mfd/rt5033.c @@ -98,7 +98,11 @@ static int rt5033_i2c_probe(struct i2c_client *i2c) return ret; } =20 - device_init_wakeup(rt5033->dev, rt5033->wakeup); + if (rt5033->wakeup) { + ret =3D devm_device_init_wakeup(rt5033->dev); + if (ret) + return dev_err_probe(rt5033->dev, ret, "Failed to init wakeup\n"); + } =20 return 0; } --=20 2.45.2 From nobody Mon Feb 9 10:38:58 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B16221547 for ; Sun, 6 Apr 2025 19:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969042; cv=none; b=VDPuwWNHlczY3KGZP2Fg2RDEyS+x24esvoGpDeoTG4jvaj3SmbhDg+YBNk+3oDom0l3oJGzrfsm/N7vRh8udbfxx3LwH7EgLVQTBBcj3u7NSI3oysdamHyymxwQu7DroeNKRYLF5fh+MPj7GW2w41EwyqZy/23W/+CRhpb7nzoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969042; c=relaxed/simple; bh=qgwnfNaPgh28TeCWIJFlF1vcUDQSOH8u0MAvqLNbbtw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CNtnQXXFJNLlVncPdGP3CqEUuySXf127iKEdMfn9k/voFZp5AbcPXIsFSHNmSqZAI0j6pZefJngpCrVpIaktRZKbvtyu4qwdarB2Mixhb4xFBSEgXBarJoiz0afgovahky5KyQ1uDzAcNJursLocyTj/J3Y79bIg5RJf8e9RRUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ySB+csN5; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ySB+csN5" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3912622c9c0so390159f8f.3 for ; Sun, 06 Apr 2025 12:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969039; x=1744573839; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SuTrfYAeGVce5bHvq1EVj+HtLFV5THzxv9MGSXWz3uE=; b=ySB+csN5wKr2wURugssVX18mRUCK5FCjrN3jD+XXdYYS5dTGvoBFOquUWreUL7imDO cGpNBaGATn4Ue0tHhdFnL6BgmiOadtOWV44L1d8sROkQ5gwbQVV7gcGrkVUmUhm/5o13 R+MKk94/Zws+sNwDaQscpDzOqtVBZiSEwcnlmz6fR38TmpeijofJh+wEQ3fOwSoq9bL6 Ag6dFW07aJ+49VKRRApZ6eBFZyI3yaQCDFDD2YzzkthrdDxWE8XEuwMCpb/qjTlufYXh /Dv5LIDVKgomLOv65GFZ+R9WiONGA2flKbWrujiLpfCIjs08mlxx+hVYKeQoOCvQJx9q 8IJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969039; x=1744573839; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SuTrfYAeGVce5bHvq1EVj+HtLFV5THzxv9MGSXWz3uE=; b=j2cQiMd9fj5KrawBs9eYYz8GWEo8zvvt6iwbQU0JctsD1dGwXnoMk/Nj5uz5zICpIR aadztFMOrFblc+3Tf28PAMI17fdJ6j264TawRo7/FG2HXP3yYL6PoKA9Bv3wXjgKQXGr v0kif+NBR5wXxDywnlpn78zYpPfe4FSmSHVhy/ZSS53WF2EwQcVx2aLSVr89yN1AVRqB 2La5k2GI9H2OM7sRmfctX+Lcb0Tvc+tDzklqsI+6SpBRE4Q2Wzw4WWEV9cWt2Q5HF4VX l9h9xWBuBU0CpoRSK+hs3BYgIHUFN69eJ1S4swTdBbHy+uYp7Bup5TSQmYFGMaOOu787 qz5w== X-Gm-Message-State: AOJu0YwpbatgBJf661d93F3n8h4Pq14fSFBaMEyGcPBhMIfNdGo7WWy1 Kx0Zvt0v0bJHHfiqRJf6MUN8BjtSjxekbdbbzel5oJKavfKccXcIQ7dblK4kqU1Q6D7Y/4NMynN B X-Gm-Gg: ASbGncvWabZ7hf0cXQexG0myGhGqmJh63k+3mCAHFR8cSypb1E/GJV9KGKKaDPg1hZv voPTVdBVH/JcJBV70OT2oCXv/tv37rzvSWIEdxvu+EVx+GEvZKqILULOyJtYNk7OTpxZAOyd1fq iwliQhGBJH5r15PjtHzhUpQ3DzDN42PajfQHrFirO6iLQL5l+cDqtuE96BXvKXbJE7Nmzdq9C8p MtwX2B4wrEtvrt0QIgEqPftDo7yIiljPhFJ0KYk+6g5sfGaGvroBzV0Tw7uhqI7+lgw+Zgvhr80 mcXwAyy5b0aApTtDdmbQIA0P2sgFr3udkbD/LewbW1ZkFYY48psoShdjCqH5fM8= X-Google-Smtp-Source: AGHT+IGuakwp2z1XwyIAuX8ThV+BWCEbAlCZJtTCEONf7fbkwqui/HqUMuEEH8aKC8tcF1ckxlRG+g== X-Received: by 2002:a05:600c:1d03:b0:439:9a40:aa27 with SMTP id 5b1f17b1804b1-43ecf9c6b4dmr32207635e9.5.1743969038726; Sun, 06 Apr 2025 12:50:38 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b69c4sm10053842f8f.43.2025.04.06.12.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 12:50:38 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 21:50:16 +0200 Subject: [PATCH 8/8] mfd: sprd-sc27xx: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250406-mfd-device-wakekup-leak-v1-8-318e14bdba0a@linaro.org> References: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-0-318e14bdba0a@linaro.org> To: Karel Balej , Lee Jones , Chanwoo Choi , Krzysztof Kozlowski , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=800; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=qgwnfNaPgh28TeCWIJFlF1vcUDQSOH8u0MAvqLNbbtw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8tr8FRvU4NEsoAsOgcLe3zTTZS29WOpDemdKF m5agwsbL+OJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/La/AAKCRDBN2bmhouD 1+V8D/9bw6AbucxOFqt9SxfuI13mPt8OM4ZFDlD28s97deRQVFRBuCcm3n1hLVzcrh/gmdWJixt gtTWKJRgrERIXCi3fWQYvY9iAKVJ8n+uvFjezbq2j06b2inHMl0QBdeRoOj3sOOjYsjiEFJvK3J EGdEPy9Lbiyl4IAlL+vwRRtELP6JtDz2tS1dqr2SGPY4sBjbiK65vrnAemgRZV/zwGAM3hgwwHo 3xv1FVpjI/ZuPUK4vq+NRwTQmC0kKc4HfGDf6eXwuuqGFgCfjXCYpi72FWhvGUttKZxEylCzCty k+iwgVm8ekNc5DDT888YnV3eAtQXeAwO6i7swy8tKjMXhC5EN17H+E1117BmCYCk0UV8MYA8NWU bEOZ2jRt13hbbZUv3IG6sJsKkz+MZAo0UK4CJZQV1K11FjC/BhA1jiE4UrXlPIK1FjAo6/SxZaO 9uaA7YRQRbnchR0iA2Kj+FlGZf1vgo4/U79eKIHZS4pknWcbGhpewcthRiC59BJC1B2gJYlOm+9 ELkoW8TuyGVIYJfpyUmNJre1d7BOnLpHNM4cC8I/zmmKfrEQtxcnuAtnOpeME62qq3mB/XGgI1G eGNoCC0sIn0F3L4VbKdBQdK6rOyvTJT4yK+BLV9DSHPcHwwAcgO8LGzQeNO8XEP6HcFcWD+meW3 s2b2lyYFWl+LTNQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Baolin Wang --- drivers/mfd/sprd-sc27xx-spi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index 7186e2108108f0d779bfe72d476fa333194c23ca..d6b4350779e6aecfa19d9fa21b9= 174447d589e33 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -210,7 +210,10 @@ static int sprd_pmic_probe(struct spi_device *spi) return ret; } =20 - device_init_wakeup(&spi->dev, true); + ret =3D devm_device_init_wakeup(&spi->dev); + if (ret) + return dev_err_probe(&spi->dev, ret, "Failed to init wakeup\n"); + return 0; } =20 --=20 2.45.2