From nobody Tue Apr 8 12:57:07 2025 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0B8870825 for ; Sat, 5 Apr 2025 14:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743863664; cv=none; b=NPx7jhGovBiE1U9QK+eE2QfMGXy9U+eOhiie3Fq381GTRXnHakh8aPvk4ykwpm71YoMIMpuokZS4BJRl8DAI/qZD84q6ZEYOSrtkep8yNv9HL/POjtPJ8Ic9p++L0IeOaaD36UjuE2irX3a9pumj2pitFR+M/Revni9igrG8xV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743863664; c=relaxed/simple; bh=dfmumo5haEZjBqDujLKNN2Ikj572t97r/iEAFhQZp9s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IBvFufowwTeSjRFGULPdLhwp3z6TZ73Iz07tvknQkt2Y46PDxxd3pdCX8KNoJ8AMbtGYBXlalv7AcmaTe2av7hThoyBUfaFhSNjUvbP36l3ey8PZxuAVi3IogzTFiGe3oI2iDNh5xtiNPctXn9OMu2loMDWQrXoc3WpIowWPq04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [221.222.48.127]) by APP-05 (Coremail) with SMTP id zQCowACn3gZcP_FnV_ZHBg--.47430S2; Sat, 05 Apr 2025 22:34:05 +0800 (CST) From: Wentao Liang To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Wentao Liang Subject: [PATCH v2] mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl_cmd() Date: Sat, 5 Apr 2025 22:33:47 +0800 Message-ID: <20250405143348.2477-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.42.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACn3gZcP_FnV_ZHBg--.47430S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZry3ZF4fCryUZr18Xw1xGrg_yoWkKFb_GF 1avr9Fy3yYyw1xZFn5Ar4kA3sIqr4kurnYqwsIvr43G3y3uF18Wa4kZr1Ygr40yF48tF15 A3ySvF4Fq3WkGjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4kFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_ Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJV WxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUehL0UU UUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCRADA2fxOpwG7AAAsD Content-Type: text/plain; charset="utf-8" The bcm47xxnflash_ops_bcm4706_cmd_ctrl() calls bcm47xxnflash_ops_bcm4706_ctl_cmd() without printing error message. A proper implementation can be found in bcm47xxnflash_ops_bcm4706_write(). Add error log to the bcm47xxnflash_ops_bcm4706_ctl_cmd() to prevent silent failure. Signed-off-by: Wentao Liang --- drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c b/drivers/mtd= /nand/raw/bcm47xxnflash/ops_bcm4706.c index 6487dfc64258..c89129588bb6 100644 --- a/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c +++ b/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c @@ -182,7 +182,8 @@ static void bcm47xxnflash_ops_bcm4706_cmd_ctrl(struct n= and_chip *nand_chip, if (cmd !=3D NAND_CMD_RESET) code |=3D NCTL_CSA; =20 - bcm47xxnflash_ops_bcm4706_ctl_cmd(b47n->cc, code); + if (bcm47xxnflash_ops_bcm4706_ctl_cmd(b47n->cc, code)) + pr_err("%s ctl_cmd didn't work!\n", __func__); } =20 /* Default nand_select_chip calls cmd_ctrl, which is not used in BCM4706 */ --=20 2.42.0.windows.2