From nobody Sat Feb 7 10:08:40 2026 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18BD31B0F30 for ; Fri, 4 Apr 2025 22:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743805265; cv=none; b=JrI6/EvANGdFa2lTrTElqSTRqfBGhgkw0A3M/o2zHOYvQo3dxDMPjfuK2uYvDyWGDbPRDcpKHloFRMVXEuWfBxVovLnwU6DB03cnLdbNStA7u0sE5NMnF1bGSO4OdzLw8DrpSs8+2H8ahmffPCuuqDdkXfetozQhraY4BHlDlxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743805265; c=relaxed/simple; bh=3uH4tvjBPnx4gaa48u4FI/xGYUeMBE3CMNtQzPHoCho=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sQhF4WdDtluocO6qwvErTwK5uZJyDx9OcRbKfvgxyzx0z9m/3wNu8Sdb6HJq1o3QW/8hEqRXuplFZnrLViIX8iAFWWmyywvreF32m8E96PrmES9T0fro+cxB9PRY7QDGGH9UDPgsvfEtxw6X/YFGQHwutKU18/lgntyQpnXms7Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=IfMKQsbO; arc=none smtp.client-ip=209.85.161.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="IfMKQsbO" Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-603f3d42ae8so1013850eaf.3 for ; Fri, 04 Apr 2025 15:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1743805263; x=1744410063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xamkw/RUwYxipIOX+uMdTaYq5cvNETr/5FWqKWKdeVg=; b=IfMKQsbOaeDFl/3uBjBDMLqRXZQOjkvSC98W/m6tCV/pdU7r9F7CI0goKu5crMy9sY 30El0uimCGU3440eza5GfSXdWRwKzUQ9U/xy/OCXt99QaQBPLJPZU4m7G/iVDaz+91Qt /tqdRFpn85divMq1KDEqE40gx1weqFZFhtGus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743805263; x=1744410063; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xamkw/RUwYxipIOX+uMdTaYq5cvNETr/5FWqKWKdeVg=; b=hQlQj24x6L5/cnCQWe6qkJ2qwzAphB9qFPdHA3Cs2PKL+Lmk6oRDCxwgPwxtRaZNFz 9jlRvrUMqnPuqohOpj1fG/WBlhQ7E73rAideoEGgehoGpPn+6ZZGC/Vv/Ei1kUsyjg4w DehViwLf2Jfc4EpsiRhCCMJchZ6xXacsSlWNe/45w75qdkHi9AhKXiQQMMwpV0DT4t31 Atr4KKJwQvCCfE5RTX9KXObsuQ5uHNVD+f18GSGjL0eZdBQ9oY809+wLiLadGZoAhJTG RcInBByLlNTuoTnQGjjDyOduQbPnWUJ9RP7WSCR/6srIcQu8P535xqp7TxdZr4vHdUN8 WYqQ== X-Forwarded-Encrypted: i=1; AJvYcCVststLh/XoD7t+XFHGdT1Fx5Jyo5sib97sdFjC08EDAV3EmcZWAoPIY6hcSyLQ23zJ+hOUPGSTd3jJpUo=@vger.kernel.org X-Gm-Message-State: AOJu0YxNHQ20DssBmqpUgM/mk1dA9XFA7xJEfl8OoYE/JUVqumwQOBlc nOOz4Yad25j+Zt9WeSWhErsEHUQUIaL7G9MFWYT7B3jG2qD+OWzYZp1UTmgEwQ== X-Gm-Gg: ASbGncvNPPit/++r85gO5AJaU+EsM8/BsOX4SSVjnI+ud6sfZtxjSghvXXLt1tBcdob 1N+j9eDF/fbv+NgvEyrzWGeZjEcD1xgzUTpk6v6W2xSNJ3VY551l5iH5tiuhwl7rZcJNQb75ocI y5b//1v5utqfgo19pADUvlqugzHWcwNhZjkXRoTaio2HEXxXCGpst9YLlufaSQuVWfijd/ARK+P R7Cu+iW1TbOMkE+EzIg+zC5wYz45EL51ipmnm0Oeh/m2fltJ4PCY94zly0RBip/gGS98TkzQndL FZUH1CqgJK8HeTBp+cNwKqvntBWju6LEq0+fSwVx4Oj3ZyBuZzGt01LvMF9N00pKNm9Qwg/TH74 31WL3xOQk+ndhGyYdZ/VtfwduFc+w+R2A X-Google-Smtp-Source: AGHT+IESTRjSnWyC9WDOv1hPrH3U08GYxtzRt8s/ZObcxIFkr+VWmQta8Ev9xBUxRfYgV1fRGYUFTw== X-Received: by 2002:a05:6871:a017:b0:29e:2594:81e with SMTP id 586e51a60fabf-2cca191ff13mr2585503fac.13.1743805262998; Fri, 04 Apr 2025 15:21:02 -0700 (PDT) Received: from stbirv-lnx-1.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2cc84b30cd0sm925451fac.38.2025.04.04.15.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 15:21:02 -0700 (PDT) From: justin.chen@broadcom.com To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: florian.fainelli@broadcom.com, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, jassisinghbrar@gmail.com, bcm-kernel-feedback-list@broadcom.com, Justin Chen Subject: [PATCH v3 1/2] dt-bindings: mailbox: Add support for bcm74110 Date: Fri, 4 Apr 2025 15:20:57 -0700 Message-Id: <20250404222058.396134-2-justin.chen@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404222058.396134-1-justin.chen@broadcom.com> References: <20250404222058.396134-1-justin.chen@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Justin Chen Add devicetree YAML binding for brcmstb bcm74110 mailbox used for communicating with a co-processor. Signed-off-by: Justin Chen --- v3 Added list for interrupts. Corrected dts example. Fixed ordering and naming. v2 Renamed brcm,brcm_{tx|rx} to brcm,{tx|rx}. Removed brcm,shmem node. Not necessary to keep in dt. Fixed example and added scmi node. .../bindings/mailbox/brcm,bcm74110-mbox.yaml | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,bcm74110= -mbox.yaml diff --git a/Documentation/devicetree/bindings/mailbox/brcm,bcm74110-mbox.y= aml b/Documentation/devicetree/bindings/mailbox/brcm,bcm74110-mbox.yaml new file mode 100644 index 000000000000..d6084ed23126 --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/brcm,bcm74110-mbox.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mailbox/brcm,bcm74110-mbox.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM74110 Mailbox + +maintainers: + - Justin Chen + - Florian Fainelli + +description: Broadcom mailbox hardware first introduced with 74110 + +properties: + compatible: + enum: + - brcm,bcm74110-mbox + + reg: + maxItems: 1 + + interrupts: + minItems: 1 + items: + - description: RX doorbell and watermark interrupts + - description: TX doorbell and watermark interrupts + + "#mbox-cells": + const: 2 + description: + The first cell is channel type and second cell is shared memory slot + + brcm,rx: + $ref: /schemas/types.yaml#/definitions/uint32 + description: RX Mailbox number + + brcm,tx: + $ref: /schemas/types.yaml#/definitions/uint32 + description: TX Mailbox number + +required: + - compatible + - reg + - interrupts + - "#mbox-cells" + - brcm,rx + - brcm,tx + +additionalProperties: false + +examples: + - | + #include + #include + + mailbox@a552000 { + compatible =3D "brcm,bcm74110-mbox"; + reg =3D <0xa552000 0x1104>; + interrupts =3D , + ; + #mbox-cells =3D <0x2>; + brcm,rx =3D <0x7>; + brcm,tx =3D <0x6>; + }; --=20 2.34.1 From nobody Sat Feb 7 10:08:40 2026 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C501C21C18C for ; Fri, 4 Apr 2025 22:21:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743805268; cv=none; b=ZZ3TnB16NvjDkMN1iys7ko56yPucHNCk82cm2uaQFLWsaY112g7gk1Q42qSqiWSSxiF6y7/3OUj09bLf5q+qmQdI5twZ0uNTknimp5SFlTZqMmn3ku2Ola6FuOkNzfrrrGbRRNH1gPgMH4fYx/GpfyHRPnBdFvctKpN8feXnpGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743805268; c=relaxed/simple; bh=k2n40i8r6II5+C2o4Q77eBl/mbYHSAzslu/UcC5yrfA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=W3fq5TCH274tBA0OqBuzaddc6V7c0jn8AQIkpNUfl/VoEdIeg3s5+TPqgUbcwPOy/ZcyN6fMTQcTR8flV6Pz+tM75EfYGbxI7Ayasl0xlJ0FcuUDnPYVQ/uQtqSeS+zoGwdzBDZEXTCVEfXzEXJ2isW4DBTIGsvGj36NOlNUT3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=YsCW+2cA; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="YsCW+2cA" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2c6f27599abso695359fac.2 for ; Fri, 04 Apr 2025 15:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1743805265; x=1744410065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jmnvaoKJQldwzES3KQPtK3LIQ+L26wvxRfM8fDUbYxg=; b=YsCW+2cAKnltITBbF47+D5bCux0iKTANftZVydVUh9KUM6A7orTu1lGFHSHDZmJtH+ +jv+UMfRQ3xTKlTEespFwK4gnDoVNCaSiHkqCI5BVURRo0UdeKprst8CTQuH2fc9OD5m kRCfWLDnzr6JtQuL79pBvr/KnOACtSr3s1iMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743805265; x=1744410065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jmnvaoKJQldwzES3KQPtK3LIQ+L26wvxRfM8fDUbYxg=; b=nFR+ypICXzFmeiuTE/TDoy2rq7ehyF5vMLcBXZhlmn1qcdaNu2vUmv3mzBJwx0OKkc eBA4WuVdUSXNIaLgpuYGWGK5Mo8SlEGD2brAgZTGR6AQWRByGC6Kmm/ZIR0IWOa18QPK TNYsUvKi81DxW73IuhTYJpoNogu8AH6n8uFlu0EE+QPjfs0XnHEcdCsYLKze7qRA8va2 iyh2HPg5pL9bqxTAibNoMi1j9FQbilS5zZjKuJS2+whfGl0sM89lXjLDrMcq4zPpUm2S yYeI9tLRpzlMQ8E0q8gWyaT0UJ1SNeHa9CL8iAToe/n0zXmk8SzVTK41FO5utv98Vw2R innA== X-Forwarded-Encrypted: i=1; AJvYcCV9BzdL6CgdPhugk9raOqe2YDs+NSc7I/OoHY7kTpuk8436LdeLvejaTsa+ojuY+0jwtzFO28VuMgOeL1M=@vger.kernel.org X-Gm-Message-State: AOJu0YyaIK4jSNOmOUZboKR/F7SVpp3IQZYxTS7WBG/HC5eHs8m9fQDB sXOXGxrhD5r9OFbLlaeOzd6d+ly+8p8fTJ2lthpLXNW0409Cd6bK875mVJ0S6g== X-Gm-Gg: ASbGnctKxIJecaZKR1pHf6bpmV3OP7UUgIP6tL2tD62X0cr+KhEPgnC6Y32pJ8mJqBC 4dhBtm6v3lSGASnvWEKTt0EIpqaGlz+8JNCDtVLCHm0b8MVA2I12TWkcogAEBgQq97YGC78jvuC 0fd4I2Q6gA0XrFnMbNmA882XmD8RfLT+FlO5UFZM1yFELCIUtwF2bGMAJn+GGfSNKcNEA02QwX/ 6NWoDQSh3zCo7L2uiIEcPufDOQ52NUpPgNr9oacbZCyonBgjnACquyw/tj1CdLgDbXlRwgMBEfK glnGIJsW7lMTXAVXd3VUpo9LfLci135vR2iRzwXjHz1rmHxBaLA2qqUGdNvBHYU4mGSmTy/tL80 /y01XAPeTHOTyvyQAsL/vJw== X-Google-Smtp-Source: AGHT+IHSrXpBn5yAsG0UGw4xZdYNJ0YL4NI2GBtZd7xpyMc/SONrrPuanboERZO5CQzgBpfFvE1OgA== X-Received: by 2002:a05:6871:d3c1:b0:2c2:4e19:1cdf with SMTP id 586e51a60fabf-2cc9e7fcde0mr2898262fac.25.1743805264571; Fri, 04 Apr 2025 15:21:04 -0700 (PDT) Received: from stbirv-lnx-1.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2cc84b30cd0sm925451fac.38.2025.04.04.15.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 15:21:03 -0700 (PDT) From: justin.chen@broadcom.com To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: florian.fainelli@broadcom.com, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, jassisinghbrar@gmail.com, bcm-kernel-feedback-list@broadcom.com, Justin Chen Subject: [PATCH v3 2/2] mailbox: Add support for bcm74110 Date: Fri, 4 Apr 2025 15:20:58 -0700 Message-Id: <20250404222058.396134-3-justin.chen@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404222058.396134-1-justin.chen@broadcom.com> References: <20250404222058.396134-1-justin.chen@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Justin Chen The bcm74110 mailbox driver is used to communicate with a co-processor for various power management and firmware related tasks. Signed-off-by: Justin Chen --- v3 No changes v2 Fixed minor formatting issues Fixed error check of platform_get_irq() Removed offsetted base iomem vars. Instead we just offset directly from base. Removed shmem variable. Hardcode it instead. drivers/mailbox/Kconfig | 10 + drivers/mailbox/Makefile | 2 + drivers/mailbox/bcm74110-mailbox.c | 655 +++++++++++++++++++++++++++++ 3 files changed, 667 insertions(+) create mode 100644 drivers/mailbox/bcm74110-mailbox.c diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig index ed52db272f4d..6fe3356ddde5 100644 --- a/drivers/mailbox/Kconfig +++ b/drivers/mailbox/Kconfig @@ -330,4 +330,14 @@ config THEAD_TH1520_MBOX kernel is running, and E902 core used for power management among other things. =20 +config BCM74110_MAILBOX + tristate "Brcmstb BCM74110 Mailbox" + depends on ARCH_BRCMSTB || COMPILE_TEST + default ARCH_BRCMSTB + help + Broadcom STB mailbox driver present starting with brcmstb bcm74110 + SoCs. The mailbox is a communication channel between the host + processor and coprocessor that handles various power management task + and more. + endif diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile index 9a1542b55539..eb2e8f55bd15 100644 --- a/drivers/mailbox/Makefile +++ b/drivers/mailbox/Makefile @@ -70,3 +70,5 @@ obj-$(CONFIG_QCOM_CPUCP_MBOX) +=3D qcom-cpucp-mbox.o obj-$(CONFIG_QCOM_IPCC) +=3D qcom-ipcc.o =20 obj-$(CONFIG_THEAD_TH1520_MBOX) +=3D mailbox-th1520.o + +obj-$(CONFIG_BCM74110_MAILBOX) +=3D bcm74110-mailbox.o diff --git a/drivers/mailbox/bcm74110-mailbox.c b/drivers/mailbox/bcm74110-= mailbox.c new file mode 100644 index 000000000000..04600f2b075e --- /dev/null +++ b/drivers/mailbox/bcm74110-mailbox.c @@ -0,0 +1,655 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Broadcom BCM74110 Mailbox Driver + * + * Copyright (c) 2025 Broadcom + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define BCM_MBOX_BASE(sel) ((sel) * 0x40) +#define BCM_MBOX_IRQ_BASE(sel) (((sel) * 0x20) + 0x800) + +#define BCM_MBOX_CFGA 0x0 +#define BCM_MBOX_CFGB 0x4 +#define BCM_MBOX_CFGC 0x8 +#define BCM_MBOX_CFGD 0xc +#define BCM_MBOX_CTRL 0x10 +#define BCM_MBOX_CTRL_EN BIT(0) +#define BCM_MBOX_CTRL_CLR BIT(1) +#define BCM_MBOX_STATUS0 0x14 +#define BCM_MBOX_STATUS0_NOT_EMPTY BIT(28) +#define BCM_MBOX_STATUS0_FULL BIT(29) +#define BCM_MBOX_STATUS1 0x18 +#define BCM_MBOX_STATUS2 0x1c +#define BCM_MBOX_WDATA 0x20 +#define BCM_MBOX_RDATA 0x28 + +#define BCM_MBOX_IRQ_STATUS 0x0 +#define BCM_MBOX_IRQ_SET 0x4 +#define BCM_MBOX_IRQ_CLEAR 0x8 +#define BCM_MBOX_IRQ_MASK_STATUS 0xc +#define BCM_MBOX_IRQ_MASK_SET 0x10 +#define BCM_MBOX_IRQ_MASK_CLEAR 0x14 +#define BCM_MBOX_IRQ_TIMEOUT BIT(0) +#define BCM_MBOX_IRQ_NOT_EMPTY BIT(1) +#define BCM_MBOX_IRQ_FULL BIT(2) +#define BCM_MBOX_IRQ_LOW_WM BIT(3) +#define BCM_MBOX_IRQ_HIGH_WM BIT(4) + +#define BCM_LINK_CODE0 0xbe0 +#define BCM_LINK_CODE1 0xbe1 +#define BCM_LINK_CODE2 0xbe2 + +enum { + BCM_MSG_FUNC_LINK_START =3D 0, + BCM_MSG_FUNC_LINK_STOP, + BCM_MSG_FUNC_SHMEM_TX, + BCM_MSG_FUNC_SHMEM_RX, + BCM_MSG_FUNC_SHMEM_STOP, + BCM_MSG_FUNC_MAX, +}; + +enum { + BCM_MSG_SVC_INIT =3D 0, + BCM_MSG_SVC_PMC, + BCM_MSG_SVC_SCMI, + BCM_MSG_SVC_DPFE, + BCM_MSG_SVC_MAX, +}; + +struct bcm74110_mbox_msg { + struct list_head list_entry; +#define BCM_MSG_VERSION_MASK GENMASK(31, 29) +#define BCM_MSG_VERSION 0x1 +#define BCM_MSG_REQ_MASK BIT(28) +#define BCM_MSG_RPLY_MASK BIT(27) +#define BCM_MSG_SVC_MASK GENMASK(26, 24) +#define BCM_MSG_FUNC_MASK GENMASK(23, 16) +#define BCM_MSG_LENGTH_MASK GENMASK(15, 4) +#define BCM_MSG_SLOT_MASK GENMASK(3, 0) + +#define BCM_MSG_SET_FIELD(hdr, field, val) \ + do { \ + hdr &=3D ~BCM_MSG_##field##_MASK; \ + hdr |=3D FIELD_PREP(BCM_MSG_##field##_MASK, val); \ + } while (0) + +#define BCM_MSG_GET_FIELD(hdr, field) \ + FIELD_GET(BCM_MSG_##field##_MASK, hdr) + u32 msg; +}; + +struct bcm74110_mbox_chan { + struct bcm74110_mbox *mbox; + bool en; + int slot; + int type; +}; + +struct bcm74110_mbox { + struct platform_device *pdev; + void __iomem *base; + + int tx_chan; + int rx_chan; + int rx_irq; + struct list_head rx_svc_init_list; + spinlock_t rx_svc_list_lock; + + struct mbox_controller controller; + struct bcm74110_mbox_chan *mbox_chan; +}; + +#define BCM74110_OFFSET_IO_WRITEL_MACRO(name, offset_base) \ +static void bcm74110_##name##_writel(struct bcm74110_mbox *mbox,\ + u32 val, u32 off) \ +{ \ + writel_relaxed(val, mbox->base + offset_base + off); \ +} +BCM74110_OFFSET_IO_WRITEL_MACRO(tx, BCM_MBOX_BASE(mbox->tx_chan)); +BCM74110_OFFSET_IO_WRITEL_MACRO(irq, BCM_MBOX_IRQ_BASE(mbox->rx_chan)); + +#define BCM74110_OFFSET_IO_READL_MACRO(name, offset_base) \ +static u32 bcm74110_##name##_readl(struct bcm74110_mbox *mbox, \ + u32 off) \ +{ \ + return readl_relaxed(mbox->base + offset_base + off); \ +} +BCM74110_OFFSET_IO_READL_MACRO(tx, BCM_MBOX_BASE(mbox->tx_chan)); +BCM74110_OFFSET_IO_READL_MACRO(rx, BCM_MBOX_BASE(mbox->rx_chan)); +BCM74110_OFFSET_IO_READL_MACRO(irq, BCM_MBOX_IRQ_BASE(mbox->rx_chan)); + +static inline struct bcm74110_mbox *bcm74110_mbox_from_cntrl( + struct mbox_controller *cntrl) +{ + return container_of(cntrl, struct bcm74110_mbox, controller); +} + +static void bcm74110_rx_push_init_msg(struct bcm74110_mbox *mbox, u32 val) +{ + struct bcm74110_mbox_msg *msg; + + msg =3D kzalloc(sizeof(*msg), GFP_ATOMIC); + if (!msg) + return; + + INIT_LIST_HEAD(&msg->list_entry); + msg->msg =3D val; + + spin_lock(&mbox->rx_svc_list_lock); + list_add_tail(&msg->list_entry, &mbox->rx_svc_init_list); + spin_unlock(&mbox->rx_svc_list_lock); +} + +static void bcm74110_rx_process_msg(struct bcm74110_mbox *mbox) +{ + struct device *dev =3D &mbox->pdev->dev; + struct bcm74110_mbox_chan *chan_priv; + struct mbox_chan *chan; + u32 msg, status; + int type; + + do { + msg =3D bcm74110_rx_readl(mbox, BCM_MBOX_RDATA); + status =3D bcm74110_rx_readl(mbox, BCM_MBOX_STATUS0); + + dev_dbg(dev, "rx: [{req=3D%lu|rply=3D%lu|srv=3D%lu|fn=3D%lu|length=3D%lu= |slot=3D%lu]\n", + BCM_MSG_GET_FIELD(msg, REQ), BCM_MSG_GET_FIELD(msg, RPLY), + BCM_MSG_GET_FIELD(msg, SVC), BCM_MSG_GET_FIELD(msg, FUNC), + BCM_MSG_GET_FIELD(msg, LENGTH), BCM_MSG_GET_FIELD(msg, SLOT)); + + type =3D BCM_MSG_GET_FIELD(msg, SVC); + switch (type) { + case BCM_MSG_SVC_INIT: + bcm74110_rx_push_init_msg(mbox, msg); + break; + case BCM_MSG_SVC_PMC: + case BCM_MSG_SVC_SCMI: + case BCM_MSG_SVC_DPFE: + chan =3D &mbox->controller.chans[type]; + chan_priv =3D chan->con_priv; + if (chan_priv->en) + mbox_chan_received_data(chan, NULL); + else + dev_warn(dev, "Channel not enabled\n"); + break; + default: + dev_warn(dev, "Unsupported msg received\n"); + } + } while (status & BCM_MBOX_STATUS0_NOT_EMPTY); +} + +static irqreturn_t bcm74110_mbox_isr(int irq, void *data) +{ + struct bcm74110_mbox *mbox =3D data; + u32 status; + + status =3D bcm74110_irq_readl(mbox, BCM_MBOX_IRQ_STATUS); + + bcm74110_irq_writel(mbox, 0xffffffff, BCM_MBOX_IRQ_CLEAR); + + if (status & BCM_MBOX_IRQ_NOT_EMPTY) + bcm74110_rx_process_msg(mbox); + else + dev_warn(&mbox->pdev->dev, "Spurious interrupt\n"); + + return IRQ_HANDLED; +} + +static void bcm74110_mbox_mask_and_clear(struct bcm74110_mbox *mbox) +{ + bcm74110_irq_writel(mbox, 0xffffffff, BCM_MBOX_IRQ_MASK_SET); + bcm74110_irq_writel(mbox, 0xffffffff, BCM_MBOX_IRQ_CLEAR); +} + +static int bcm74110_rx_pop_init_msg(struct bcm74110_mbox *mbox, u32 func_t= ype, + u32 *val) +{ + struct bcm74110_mbox_msg *msg, *msg_tmp; + unsigned long flags; + bool found =3D false; + + spin_lock_irqsave(&mbox->rx_svc_list_lock, flags); + list_for_each_entry_safe(msg, msg_tmp, &mbox->rx_svc_init_list, + list_entry) { + if (BCM_MSG_GET_FIELD(msg->msg, FUNC) =3D=3D func_type) { + list_del(&msg->list_entry); + found =3D true; + break; + } + } + spin_unlock_irqrestore(&mbox->rx_svc_list_lock, flags); + + if (!found) + return -EINVAL; + + *val =3D msg->msg; + kfree(msg); + + return 0; +} + +static void bcm74110_rx_flush_msg(struct bcm74110_mbox *mbox) +{ + struct bcm74110_mbox_msg *msg, *msg_tmp; + LIST_HEAD(list_temp); + unsigned long flags; + + spin_lock_irqsave(&mbox->rx_svc_list_lock, flags); + list_splice_init(&mbox->rx_svc_init_list, &list_temp); + spin_unlock_irqrestore(&mbox->rx_svc_list_lock, flags); + + list_for_each_entry_safe(msg, msg_tmp, &list_temp, list_entry) { + list_del(&msg->list_entry); + kfree(msg); + } +} + +#define BCM_DEQUEUE_TIMEOUT_MS 30 +static int bcm74110_rx_pop_init_msg_block(struct bcm74110_mbox *mbox, u32 = func_type, + u32 *val) +{ + int ret, timeout =3D 0; + + do { + ret =3D bcm74110_rx_pop_init_msg(mbox, func_type, val); + + if (!ret) + return 0; + + /* TODO: Figure out what is a good sleep here. */ + usleep_range(1000, 2000); + timeout++; + } while (timeout < BCM_DEQUEUE_TIMEOUT_MS); + + dev_warn(&mbox->pdev->dev, "Timeout waiting for service init response\n"); + return -ETIMEDOUT; +} + +static int bcm74110_mbox_create_msg(int req, int rply, int svc, int func, + int length, int slot) +{ + u32 msg =3D 0; + + BCM_MSG_SET_FIELD(msg, REQ, req); + BCM_MSG_SET_FIELD(msg, RPLY, rply); + BCM_MSG_SET_FIELD(msg, SVC, svc); + BCM_MSG_SET_FIELD(msg, FUNC, func); + BCM_MSG_SET_FIELD(msg, LENGTH, length); + BCM_MSG_SET_FIELD(msg, SLOT, slot); + + return msg; +} + +static int bcm74110_mbox_tx_msg(struct bcm74110_mbox *mbox, u32 msg) +{ + int val; + + /* We can potentially poll with timeout here instead */ + val =3D bcm74110_tx_readl(mbox, BCM_MBOX_STATUS0); + if (val & BCM_MBOX_STATUS0_FULL) { + dev_err(&mbox->pdev->dev, "Mailbox full\n"); + return -EINVAL; + } + + dev_dbg(&mbox->pdev->dev, "tx: [{req=3D%lu|rply=3D%lu|srv=3D%lu|fn=3D%lu|= length=3D%lu|slot=3D%lu]\n", + BCM_MSG_GET_FIELD(msg, REQ), BCM_MSG_GET_FIELD(msg, RPLY), + BCM_MSG_GET_FIELD(msg, SVC), BCM_MSG_GET_FIELD(msg, FUNC), + BCM_MSG_GET_FIELD(msg, LENGTH), BCM_MSG_GET_FIELD(msg, SLOT)); + + bcm74110_tx_writel(mbox, msg, BCM_MBOX_WDATA); + + return 0; +} + +#define BCM_MBOX_LINK_TRAINING_RETRIES 5 +static int bcm74110_mbox_link_training(struct bcm74110_mbox *mbox) +{ + int ret, retries =3D 0; + u32 msg =3D 0, orig_len =3D 0, len =3D BCM_LINK_CODE0; + + do { + switch (len) { + case 0: + retries++; + dev_warn(&mbox->pdev->dev, + "Link train failed, trying again... %d\n", + retries); + if (retries > BCM_MBOX_LINK_TRAINING_RETRIES) + return -EINVAL; + len =3D BCM_LINK_CODE0; + fallthrough; + case BCM_LINK_CODE0: + case BCM_LINK_CODE1: + case BCM_LINK_CODE2: + msg =3D bcm74110_mbox_create_msg(1, 0, BCM_MSG_SVC_INIT, + BCM_MSG_FUNC_LINK_START, + len, BCM_MSG_SVC_INIT); + break; + default: + break; + } + + bcm74110_mbox_tx_msg(mbox, msg); + + /* No response expected for LINK_CODE2 */ + if (len =3D=3D BCM_LINK_CODE2) + return 0; + + orig_len =3D len; + + ret =3D bcm74110_rx_pop_init_msg_block(mbox, + BCM_MSG_GET_FIELD(msg, FUNC), + &msg); + if (ret) { + len =3D 0; + continue; + } + + if ((BCM_MSG_GET_FIELD(msg, SVC) !=3D BCM_MSG_SVC_INIT) || + (BCM_MSG_GET_FIELD(msg, FUNC) !=3D BCM_MSG_FUNC_LINK_START) || + (BCM_MSG_GET_FIELD(msg, SLOT) !=3D 0) || + (BCM_MSG_GET_FIELD(msg, RPLY) !=3D 1) || + (BCM_MSG_GET_FIELD(msg, REQ) !=3D 0)) { + len =3D 0; + continue; + } + + len =3D BCM_MSG_GET_FIELD(msg, LENGTH); + + /* Make sure sequence is good */ + if (len !=3D (orig_len + 1)) { + len =3D 0; + continue; + } + } while (1); + + return -EINVAL; +} + +static int bcm74110_mbox_tx_msg_and_wait_ack(struct bcm74110_mbox *mbox, u= 32 msg) +{ + int ret; + u32 recv_msg; + + ret =3D bcm74110_mbox_tx_msg(mbox, msg); + if (ret) + return ret; + + ret =3D bcm74110_rx_pop_init_msg_block(mbox, BCM_MSG_GET_FIELD(msg, FUNC), + &recv_msg); + if (ret) + return ret; + + /* + * Modify tx message to verify rx ack. + * Flip RPLY/REQ for synchronous messages + */ + if (BCM_MSG_GET_FIELD(msg, REQ) =3D=3D 1) { + BCM_MSG_SET_FIELD(msg, RPLY, 1); + BCM_MSG_SET_FIELD(msg, REQ, 0); + } + + if (msg !=3D recv_msg) { + dev_err(&mbox->pdev->dev, "Found ack, but ack is invalid\n"); + return -EINVAL; + } + + return 0; +} + +/* Each index points to 0x100 of HAB MEM. IDX size counts from 0 */ +#define BCM_MBOX_HAB_MEM_IDX_START 0x30 +#define BCM_MBOX_HAB_MEM_IDX_SIZE 0x0 +static int bcm74110_mbox_shmem_init(struct bcm74110_mbox *mbox) +{ + u32 msg =3D 0; + int ret; + + msg =3D bcm74110_mbox_create_msg(1, 0, BCM_MSG_SVC_INIT, + BCM_MSG_FUNC_SHMEM_STOP, + 0, BCM_MSG_SVC_INIT); + ret =3D bcm74110_mbox_tx_msg_and_wait_ack(mbox, msg); + if (ret) + return -EINVAL; + + msg =3D bcm74110_mbox_create_msg(1, 0, BCM_MSG_SVC_INIT, + BCM_MSG_FUNC_SHMEM_TX, + BCM_MBOX_HAB_MEM_IDX_START, + BCM_MBOX_HAB_MEM_IDX_SIZE); + ret =3D bcm74110_mbox_tx_msg_and_wait_ack(mbox, msg); + if (ret) + return -EINVAL; + + msg =3D bcm74110_mbox_create_msg(1, 0, BCM_MSG_SVC_INIT, + BCM_MSG_FUNC_SHMEM_RX, + BCM_MBOX_HAB_MEM_IDX_START, + BCM_MBOX_HAB_MEM_IDX_SIZE); + ret =3D bcm74110_mbox_tx_msg_and_wait_ack(mbox, msg); + if (ret) + return -EINVAL; + + return 0; +} + +static int bcm74110_mbox_init(struct bcm74110_mbox *mbox) +{ + int ret =3D 0; + + /* Disable queues tx/rx */ + bcm74110_tx_writel(mbox, 0x0, BCM_MBOX_CTRL); + + /* Clear status & restart tx/rx*/ + bcm74110_tx_writel(mbox, BCM_MBOX_CTRL_EN | BCM_MBOX_CTRL_CLR, + BCM_MBOX_CTRL); + + /* Unmask irq */ + bcm74110_irq_writel(mbox, BCM_MBOX_IRQ_NOT_EMPTY, BCM_MBOX_IRQ_MASK_CLEAR= ); + + ret =3D bcm74110_mbox_link_training(mbox); + if (ret) { + dev_err(&mbox->pdev->dev, "Training failed\n"); + return ret; + } + + return bcm74110_mbox_shmem_init(mbox); +} + +static int bcm74110_mbox_send_data(struct mbox_chan *chan, void *data) +{ + struct bcm74110_mbox_chan *chan_priv =3D chan->con_priv; + u32 msg; + + switch (chan_priv->type) { + case BCM_MSG_SVC_PMC: + case BCM_MSG_SVC_SCMI: + case BCM_MSG_SVC_DPFE: + msg =3D bcm74110_mbox_create_msg(1, 0, chan_priv->type, 0, + 128 + 28, chan_priv->slot); + break; + default: + return -EINVAL; + }; + + return bcm74110_mbox_tx_msg(chan_priv->mbox, msg); +} + +static int bcm74110_mbox_chan_startup(struct mbox_chan *chan) +{ + struct bcm74110_mbox_chan *chan_priv =3D chan->con_priv; + + chan_priv->en =3D true; + + return 0; +} + +static void bcm74110_mbox_chan_shutdown(struct mbox_chan *chan) +{ + struct bcm74110_mbox_chan *chan_priv =3D chan->con_priv; + + chan_priv->en =3D false; +} + +static const struct mbox_chan_ops bcm74110_mbox_chan_ops =3D { + .send_data =3D bcm74110_mbox_send_data, + .startup =3D bcm74110_mbox_chan_startup, + .shutdown =3D bcm74110_mbox_chan_shutdown, +}; + +static void bcm74110_mbox_shutdown(struct platform_device *pdev) +{ + struct bcm74110_mbox *mbox =3D dev_get_drvdata(&pdev->dev); + u32 msg; + + msg =3D bcm74110_mbox_create_msg(1, 0, BCM_MSG_SVC_INIT, + BCM_MSG_FUNC_LINK_STOP, + 0, 0); + + bcm74110_mbox_tx_msg_and_wait_ack(mbox, msg); + + /* Even if we don't receive ACK, lets shut it down */ + + bcm74110_mbox_mask_and_clear(mbox); + + /* Disable queues tx/rx */ + bcm74110_tx_writel(mbox, 0x0, BCM_MBOX_CTRL); + + /* Flush queues */ + bcm74110_rx_flush_msg(mbox); +} + +static struct mbox_chan *bcm74110_mbox_of_xlate(struct mbox_controller *cn= trl, + const struct of_phandle_args *p) +{ + struct bcm74110_mbox *mbox =3D bcm74110_mbox_from_cntrl(cntrl); + struct device *dev =3D &mbox->pdev->dev; + struct bcm74110_mbox_chan *chan_priv; + int slot, type; + + if (p->args_count !=3D 2) { + dev_err(dev, "Invalid arguments\n"); + return ERR_PTR(-EINVAL); + } + + type =3D p->args[0]; + slot =3D p->args[1]; + + switch (type) { + case BCM_MSG_SVC_PMC: + case BCM_MSG_SVC_SCMI: + case BCM_MSG_SVC_DPFE: + if (slot > BCM_MBOX_HAB_MEM_IDX_SIZE) { + dev_err(dev, "Not enough shared memory\n"); + return ERR_PTR(-EINVAL); + } + chan_priv =3D cntrl->chans[type].con_priv; + chan_priv->slot =3D slot; + chan_priv->type =3D type; + break; + default: + dev_err(dev, "Invalid channel type: %d\n", type); + return ERR_PTR(-EINVAL); + }; + + return &cntrl->chans[type]; +} + +static int bcm74110_mbox_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct bcm74110_mbox *mbox; + int i, ret; + + mbox =3D devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL); + if (!mbox) + return -ENOMEM; + + mbox->pdev =3D pdev; + platform_set_drvdata(pdev, mbox); + + mbox->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(mbox->base)) + return dev_err_probe(dev, PTR_ERR(mbox->base), "Failed to iomap\n"); + + ret =3D of_property_read_u32(dev->of_node, "brcm,tx", &mbox->tx_chan); + if (ret) + return dev_err_probe(dev, ret, "Failed to find tx channel\n"); + + ret =3D of_property_read_u32(dev->of_node, "brcm,rx", &mbox->rx_chan); + if (ret) + return dev_err_probe(dev, ret, "Failed to find rx channel\n"); + + mbox->rx_irq =3D platform_get_irq(pdev, 0); + if (mbox->rx_irq < 0) + return mbox->rx_irq; + + INIT_LIST_HEAD(&mbox->rx_svc_init_list); + spin_lock_init(&mbox->rx_svc_list_lock); + bcm74110_mbox_mask_and_clear(mbox); + + ret =3D devm_request_irq(dev, mbox->rx_irq, bcm74110_mbox_isr, + IRQF_NO_SUSPEND, pdev->name, mbox); + if (ret) + return dev_err_probe(dev, ret, "Failed to request irq\n"); + + mbox->controller.ops =3D &bcm74110_mbox_chan_ops; + mbox->controller.dev =3D dev; + mbox->controller.num_chans =3D BCM_MSG_SVC_MAX; + mbox->controller.of_xlate =3D &bcm74110_mbox_of_xlate; + mbox->controller.chans =3D devm_kcalloc(dev, BCM_MSG_SVC_MAX, + sizeof(*mbox->controller.chans), + GFP_KERNEL); + if (!mbox->controller.chans) + return -ENOMEM; + + mbox->mbox_chan =3D devm_kcalloc(dev, BCM_MSG_SVC_MAX, + sizeof(*mbox->mbox_chan), + GFP_KERNEL); + if (!mbox->mbox_chan) + return -ENOMEM; + + for (i =3D 0; i < BCM_MSG_SVC_MAX; i++) { + mbox->mbox_chan[i].mbox =3D mbox; + mbox->controller.chans[i].con_priv =3D &mbox->mbox_chan[i]; + } + + ret =3D devm_mbox_controller_register(dev, &mbox->controller); + if (ret) + return ret; + + ret =3D bcm74110_mbox_init(mbox); + if (ret) + return ret; + + return 0; +} + +static const struct of_device_id bcm74110_mbox_of_match[] =3D { + { .compatible =3D "brcm,bcm74110-mbox", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, bcm74110_mbox_of_match); + +static struct platform_driver bcm74110_mbox_driver =3D { + .driver =3D { + .name =3D "bcm74110-mbox", + .of_match_table =3D bcm74110_mbox_of_match, + }, + .probe =3D bcm74110_mbox_probe, + .shutdown =3D bcm74110_mbox_shutdown, +}; +module_platform_driver(bcm74110_mbox_driver); + +MODULE_AUTHOR("Justin Chen "); +MODULE_DESCRIPTION("BCM74110 mailbox driver"); +MODULE_LICENSE("GPL"); --=20 2.34.1