From nobody Sun Feb 8 10:47:28 2026 Received: from mx0a-000eb902.pphosted.com (mx0a-000eb902.pphosted.com [205.220.165.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E43D42A87; Fri, 4 Apr 2025 21:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.212 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743802246; cv=fail; b=AXyN5OcivHq8bUrR5T4LCWCXpKWsw+5rHnjQXw8dFzpMSm3aliyHVInALn9xbTSKHDxLsxZ1DYt29aflJLeY895l669MoJFLQUMSMSbG+97jxH7hO7Tw0ShNt7hFmyIA8eMdXfrhnFdmZzV/EddGTA8tTQanDwQ12h8yFLgDZo0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743802246; c=relaxed/simple; bh=XM3dOazz43rZPbCsqT9puVxPWfvszfcpK+89Kia9vuM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tGprwwZp0pVvAljaMdq7te0ABnQcseQRVOtkg3KSCNXiGy07H+lBtpxdHYIwLT0vUNAh9xiJUdW+HMIeiZTkS3sxd6olo1QFg1Nhf1otCE+61ZRLoIxt9vdAtJoBHV2n2gMGSRVlplooXFZhKp6W1c5T2QnUXIqxXTT/hP5KyCY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com; spf=pass smtp.mailfrom=garmin.com; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=isDS4dzP; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=cg08M1hw; arc=fail smtp.client-ip=205.220.165.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garmin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="isDS4dzP"; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="cg08M1hw" Received: from pps.filterd (m0220296.ppops.net [127.0.0.1]) by mx0a-000eb902.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 534JdLIw001644; Fri, 4 Apr 2025 16:30:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps1; bh=omzWv JQSukc9hdCdAw33YKN3d6zs6MkXWGwcKyx6Zms=; b=isDS4dzPbHZ4RoUYrYUHd 2cad0/leM5dVFsT+tJtHa4IIdTrQ5RFRgPYHZdhXy/4eY6fOXi2JotWk2oZb/FZx jtklH4I4tzCvYQHQB9BvuDht1q3FF49umAlURkABVZXTCgU3ijBTkUzame/cYLd9 mKbXiC1hLMoBHjej6UseS3MLOZNyIKQWkCotVCSvkLLeCyWfVfYPij9KzKLae5HC UhX5c9owPR2TlfQSE4BK6cYqdoz5IyDzFeq7ILtOHO0W2sbgwZa1wqz4cDLzqWf9 hhWpl7Cjkf6zGqPZDFW8UZ7mwQciNMuuY37CTq9H1kVyTw5sSOmrolOVnwnoa7Ze w== Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazlp17010006.outbound.protection.outlook.com [40.93.6.6]) by mx0a-000eb902.pphosted.com (PPS) with ESMTPS id 45tkkc8bru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Apr 2025 16:30:28 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sUEpLvUUlB1AIY4f2uaoiIWpswazz1ocgJyHmQsV73+UvOc7mxostTbKUZsDniWwi/5Yep9yUkT0B07vIDPRa1TDDIliDcZm8FmHLYALvPKb6mI7O2vAOM/Y2XtV6FFqIcCKiOSnA05NidFr3LFGvopBSyka/iVtYm89HPld9I4c1DZH+t++ajM84ZkkPf4cRdnJe6ISTmulbA6bGPC1ULOeOEdBwwJp1xu/7s3aYd8S9SHODewLakV2Nn0RiYHSVX+Yw1LrWmYSysP7mxh8AHSOVI7eiRwHETBwLj+vfGr6ZbPFA8O5aMEa7Hkwy053gsG51NLWlh0vBqtgkphoGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=omzWvJQSukc9hdCdAw33YKN3d6zs6MkXWGwcKyx6Zms=; b=AZGO2QQijcqP+pwJAmxfoprTKVNGTl8T61yqOLpL5HVM4LS0aCd8cEEP+gE2BRIVSfxm0JdjHKWQhP8OTVpAxhtxzVMnU+wPaEPm4/MY+UXqKQSUkJHvx6JhKMjbQvPgBiWl09v6kxGNc+SyyEMADvGnIggo8MEdI20m4Ir7/0AxAcuLpabYMeFn//NSOoxc3fNjHbmvqS4AS7YiK42EGzLVPvME5lK0glW6TAFzOj7slEhaqsZop8GX1Y+2BRHKH9M2V6c+ueCm/saTWahY2Fiv0CbKCjMai315Jepi4l4j1r0l4R8H3vKfRfVlS83PipoRAS0RGUXUd/gMYLrNYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 204.77.163.244) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=garmin.com; dmarc=pass (p=reject sp=quarantine pct=100) action=none header.from=garmin.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=omzWvJQSukc9hdCdAw33YKN3d6zs6MkXWGwcKyx6Zms=; b=cg08M1hw+tg4U/it2UZChMuCuJ+oYdtuDd5QDoSu/rE3Rr4igDScCHFQSyJm3niH9zmyG/RghAg+nidR7MfuxIaC7f2BZzYWb2vojtLxK6n2yjNPxyuhoFV+9OZPdN7bWXqM9JJwa4004h71X4pYUifRg79E0AUlDt+3rAyq3kym+qzE9aWDd/NMYNSTbGNoydCgGp23qjMz9Ipx/AcLzyL4C2FSNdWG6w6do+iUSpQ7Z5Ex5d+RZlBgLt6GPiA8+nxxeNhHXQxONP0ysiK5l9VhKjSQpAhjOwtzRc9lVj4yvT0Sjne0qwzPrUUBpyrsKKRou5TMZJaY1L6jbzI50g== Received: from BLAPR03CA0073.namprd03.prod.outlook.com (2603:10b6:208:329::18) by DM6PR04MB6633.namprd04.prod.outlook.com (2603:10b6:5:24a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.27; Fri, 4 Apr 2025 21:30:26 +0000 Received: from BN2PEPF0000449E.namprd02.prod.outlook.com (2603:10b6:208:329:cafe::98) by BLAPR03CA0073.outlook.office365.com (2603:10b6:208:329::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8583.41 via Frontend Transport; Fri, 4 Apr 2025 21:30:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 204.77.163.244) smtp.mailfrom=garmin.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=garmin.com; Received-SPF: Pass (protection.outlook.com: domain of garmin.com designates 204.77.163.244 as permitted sender) receiver=protection.outlook.com; client-ip=204.77.163.244; helo=edgetransport.garmin.com; pr=C Received: from edgetransport.garmin.com (204.77.163.244) by BN2PEPF0000449E.mail.protection.outlook.com (10.167.243.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Fri, 4 Apr 2025 21:30:25 +0000 Received: from OLAWPA-EXMB2.ad.garmin.com (10.5.144.14) by cv1wpa-edge3 (10.60.4.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 4 Apr 2025 16:30:05 -0500 Received: from cv1wpa-exmb4.ad.garmin.com (10.5.144.74) by OLAWPA-EXMB2.ad.garmin.com (10.5.144.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 4 Apr 2025 16:30:06 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by CV1WPA-EXMB4.ad.garmin.com (10.5.144.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 4 Apr 2025 16:30:04 -0500 Received: from CAR-4RCMR33.ad.garmin.com (10.5.209.17) by smtp.garmin.com (10.5.144.71) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 4 Apr 2025 16:30:03 -0500 From: Joseph Huang To: CC: Joseph Huang , Joseph Huang , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Roopa Prabhu , Nikolay Aleksandrov , Simon Horman , , Subject: [Patch v3 net-next 1/3] net: bridge: mcast: Add offload failed mdb flag Date: Fri, 4 Apr 2025 17:29:33 -0400 Message-ID: <20250404212940.1837879-2-Joseph.Huang@garmin.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250404212940.1837879-1-Joseph.Huang@garmin.com> References: <20250404212940.1837879-1-Joseph.Huang@garmin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449E:EE_|DM6PR04MB6633:EE_ X-MS-Office365-Filtering-Correlation-Id: a12e33cf-e393-44b3-50c7-08dd73bfea2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VZsRF6Im5s92xDqhCnZnbixbxSfB8/VKbdTIiHaisqFxVkzNI/diTN0gDSXK?= =?us-ascii?Q?HDjLtvZdaVYLiUs1eCmzwVNfIozSbXHYhNq0mO2cMvAud3Uv/tDaj78fLMGY?= =?us-ascii?Q?5YNOgWWhasfLLUFt3kBHgEXQhpdE9Cdi1hJUNLvZXBLS9WQypwo/kYPm5I8e?= =?us-ascii?Q?JUy1V6rt1fU27LmPBqYCZf0wOx1t3hyLChGY00bTfFervNOVb+RK0jTHq7t0?= =?us-ascii?Q?ncKuOEHbjanYFq7lgB9DM85t2BJMGWqlakV154rKjVM3G+JkpbzIksfWaOWW?= =?us-ascii?Q?l+ryOvnMZV7AmW6SDKqQ8HzSj63eqz5KvugOGZ8GnuEWBLCS1SZmSQ8SS1o4?= =?us-ascii?Q?8pM18VREyaoOv+er+WiKguJa/DygKXxpCzdKkejsiF8I4/AGeSJmHI1K8TXe?= =?us-ascii?Q?JqPJpBeg38yOCidUBBKPgJdsPeDZ5/OcWe6WnMXWlmUVBp9XnqvF2bz4TkvI?= =?us-ascii?Q?6DswXqA9j0D6XzkWuAzajsHhSGU7uf/ZgPp27+1uaDGY/QW/mnxBH+lHAkOl?= =?us-ascii?Q?QpkkyD7y6BlK/x/fKrY/Ze8MHQ6hr1QwVkVut0El9tgZiAQ1bX1GaX8z8h2I?= =?us-ascii?Q?o6osq0DpLLiJTsx9wRvRyTR6lLNp3eQlPf5Kg3GRxaGKETvjwX5OT0kkwnsA?= =?us-ascii?Q?0TNw401w7VSNMzLZsRx/kX6x6wq+MZqfb50lO2LVUUWKGjsBmbjuwNKWB4fB?= =?us-ascii?Q?JBnqDEFfldRYWO0MRpugOSa3UUiFuDb6dUKO7KYNl1398BFjzyIVVaC9ces/?= =?us-ascii?Q?t/uAljbSBYqEe2Qpfym9iWwK7+SP2AwTPUy9IGkRCiiMg3m9mH8v5P1muwlH?= =?us-ascii?Q?TOkOrWu7+MykKL8a7wvnMvI9LdIBUOVLNoVDR0nx+KWIySx/F/yPf9aUszp7?= =?us-ascii?Q?D6gnuIjSY/1Fjg8hw3znk1bU5ux1AIwORWaFsBEqMgFw9GsEiKRQH/D2O1i6?= =?us-ascii?Q?prMZlea05vH0o0pqz0TN6ZLXPPCUMi2oOHFronNT6wWYjtEE6uZ6TuwpVciS?= =?us-ascii?Q?MHzEg9uAf16ZAAjtC3YaGM5DVRuHKJTCa9BSPPer2tkUJ2VR0B/f89y0Z6Uc?= =?us-ascii?Q?NZULtaNgRvjWpUrm1EuPVcLXRkGkxC29vzH5pbb6bBgEkCHdPEhlYV1RD+nu?= =?us-ascii?Q?h4WqddNZirFAsjUtMTZvmJpu4J+rONjEoehGKuoZe10Hevwhkbd39rWdj1OB?= =?us-ascii?Q?yDSfs8BMDRHd80mG6fxMTCiOizDXWtbai9kFdAkfGMD1b684czNoQ+n+xioL?= =?us-ascii?Q?I0utFcVQbty84lIbFkhYAUUeWW3t885ts+VZPbAkaYl9xFtNOTIFRDT66TJ/?= =?us-ascii?Q?FC6iZm0SCmH2cnhlKiCNDrrb0iyKJzdsiYLaHwC3Zz5r8PO4FKvGR6S3M3XR?= =?us-ascii?Q?19hVnfz/SB69cfyutGuEi5oYQLBUtJoznd2hOR4GX9z6txMpSw4+IOukPsiM?= =?us-ascii?Q?7VWwlu2AVYbs9seeGF9vsllL6++wsRsfwk/OpKYavKpKC4cXuAupZ67nTuUt?= =?us-ascii?Q?WLmQQgDSd5EK+2BiN0KN7hhmFsD8RLneeVOm?= X-Forefront-Antispam-Report: CIP:204.77.163.244;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:edgetransport.garmin.com;PTR:extedge.garmin.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1102; X-OriginatorOrg: garmin.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2025 21:30:25.9480 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a12e33cf-e393-44b3-50c7-08dd73bfea2c X-MS-Exchange-CrossTenant-Id: 38d0d425-ba52-4c0a-a03e-2a65c8e82e2d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38d0d425-ba52-4c0a-a03e-2a65c8e82e2d;Ip=[204.77.163.244];Helo=[edgetransport.garmin.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6633 X-Proofpoint-GUID: U4gbENSVkl4-mDs9tO3z66hUaoVON_N_ X-Proofpoint-ORIG-GUID: U4gbENSVkl4-mDs9tO3z66hUaoVON_N_ X-Authority-Analysis: v=2.4 cv=drnbC0g4 c=1 sm=1 tr=0 ts=67f04f74 cx=c_pps a=ox8Ej8V6LcPVg4qe/Ko28Q==:117 a=YA0UzX50FYCGjWi3QxTvkg==:17 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=XR8D0OoHHMoA:10 a=qm69fr9Wx_0A:10 a=NbHB2C0EAAAA:8 a=nTqqLMH9PYxWBGmw_pQA:9 cc=ntf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_09,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=940 priorityscore=1501 malwarescore=0 mlxscore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc=notification route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2502280000 definitions=main-2504040147 Content-Type: text/plain; charset="utf-8" Add MDB_FLAGS_OFFLOAD_FAILED and MDB_PG_FLAGS_OFFLOAD_FAILED to indicate that an attempt to offload the MDB entry to switchdev has failed. Signed-off-by: Joseph Huang Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 9 +++++---- net/bridge/br_mdb.c | 2 ++ net/bridge/br_private.h | 20 +++++++++++++++----- net/bridge/br_switchdev.c | 9 +++++---- 4 files changed, 27 insertions(+), 13 deletions(-) diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h index a5b743a2f775..f2a6de424f3f 100644 --- a/include/uapi/linux/if_bridge.h +++ b/include/uapi/linux/if_bridge.h @@ -699,10 +699,11 @@ struct br_mdb_entry { #define MDB_TEMPORARY 0 #define MDB_PERMANENT 1 __u8 state; -#define MDB_FLAGS_OFFLOAD (1 << 0) -#define MDB_FLAGS_FAST_LEAVE (1 << 1) -#define MDB_FLAGS_STAR_EXCL (1 << 2) -#define MDB_FLAGS_BLOCKED (1 << 3) +#define MDB_FLAGS_OFFLOAD (1 << 0) +#define MDB_FLAGS_FAST_LEAVE (1 << 1) +#define MDB_FLAGS_STAR_EXCL (1 << 2) +#define MDB_FLAGS_BLOCKED (1 << 3) +#define MDB_FLAGS_OFFLOAD_FAILED (1 << 4) __u8 flags; __u16 vid; struct { diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 1a52a0bca086..0639691cd19b 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -144,6 +144,8 @@ static void __mdb_entry_fill_flags(struct br_mdb_entry = *e, unsigned char flags) e->flags |=3D MDB_FLAGS_STAR_EXCL; if (flags & MDB_PG_FLAGS_BLOCKED) e->flags |=3D MDB_FLAGS_BLOCKED; + if (flags & MDB_PG_FLAGS_OFFLOAD_FAILED) + e->flags |=3D MDB_FLAGS_OFFLOAD_FAILED; } =20 static void __mdb_entry_to_br_ip(struct br_mdb_entry *entry, struct br_ip = *ip, diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 1054b8a88edc..5f9d6075017e 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -306,11 +306,12 @@ struct net_bridge_fdb_flush_desc { u16 vlan_id; }; =20 -#define MDB_PG_FLAGS_PERMANENT BIT(0) -#define MDB_PG_FLAGS_OFFLOAD BIT(1) -#define MDB_PG_FLAGS_FAST_LEAVE BIT(2) -#define MDB_PG_FLAGS_STAR_EXCL BIT(3) -#define MDB_PG_FLAGS_BLOCKED BIT(4) +#define MDB_PG_FLAGS_PERMANENT BIT(0) +#define MDB_PG_FLAGS_OFFLOAD BIT(1) +#define MDB_PG_FLAGS_FAST_LEAVE BIT(2) +#define MDB_PG_FLAGS_STAR_EXCL BIT(3) +#define MDB_PG_FLAGS_BLOCKED BIT(4) +#define MDB_PG_FLAGS_OFFLOAD_FAILED BIT(5) =20 #define PG_SRC_ENT_LIMIT 32 =20 @@ -1343,6 +1344,15 @@ br_multicast_ctx_matches_vlan_snooping(const struct = net_bridge_mcast *brmctx) =20 return !!(vlan_snooping_enabled =3D=3D br_multicast_ctx_is_vlan(brmctx)); } + +static inline void +br_multicast_set_pg_offload_flags(struct net_bridge_port_group *p, + bool offloaded) +{ + p->flags &=3D ~(MDB_PG_FLAGS_OFFLOAD | MDB_PG_FLAGS_OFFLOAD_FAILED); + p->flags |=3D (offloaded ? MDB_PG_FLAGS_OFFLOAD : + MDB_PG_FLAGS_OFFLOAD_FAILED); +} #else static inline int br_multicast_rcv(struct net_bridge_mcast **brmctx, struct net_bridge_mcast_port **pmctx, diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index 7b41ee8740cb..57e1863edf93 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -505,8 +505,8 @@ static void br_switchdev_mdb_complete(struct net_device= *dev, int err, void *pri struct net_bridge_port *port =3D data->port; struct net_bridge *br =3D port->br; =20 - if (err) - goto err; + if (err =3D=3D -EOPNOTSUPP) + goto notsupp; =20 spin_lock_bh(&br->multicast_lock); mp =3D br_mdb_ip_get(br, &data->ip); @@ -516,11 +516,12 @@ static void br_switchdev_mdb_complete(struct net_devi= ce *dev, int err, void *pri pp =3D &p->next) { if (p->key.port !=3D port) continue; - p->flags |=3D MDB_PG_FLAGS_OFFLOAD; + + br_multicast_set_pg_offload_flags(p, !err); } out: spin_unlock_bh(&br->multicast_lock); -err: +notsupp: kfree(priv); } =20 --=20 2.49.0 From nobody Sun Feb 8 10:47:28 2026 Received: from mx0a-000eb902.pphosted.com (mx0a-000eb902.pphosted.com [205.220.165.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4EA91A072C; Fri, 4 Apr 2025 21:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.212 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743802250; cv=fail; b=kSa2ka1wCN+ykg5zpxgnf5ik1TedkRvHkJOJ4melbZOKyKJmSqlramRReTiWJaB52uujIvjSBX47nrSkvD5heyn7/yzSL9GlgfZwehytSBfl0TU0Q5mszmM0nLhloQAMePEApiOahJFhmqTzkhf8UE7q50rqpweWQhwQhZ6dRCg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743802250; c=relaxed/simple; bh=WvwId8o0Y3S60WLzDglZJS3tCzTqCdRNHXEE8v4td1U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lshu3tKUJMHsShi19liFAKzKyMCq39+10CLPg7qgD3J1kQNwlU+Vha40pAO8cXHB1FElCMpI5oPgO/AMpLGIiA4+Qn9DnibA5nHkhRoTQDlNhXVKGFMIkddjJDsQFHnse8qx2cvgzrIIr2sg76nWe3FIV4gHStBnBi6cELu1DG8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com; spf=pass smtp.mailfrom=garmin.com; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=hSJe7cJD; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=T5+RwHTo; arc=fail smtp.client-ip=205.220.165.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garmin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="hSJe7cJD"; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="T5+RwHTo" Received: from pps.filterd (m0220295.ppops.net [127.0.0.1]) by mx0a-000eb902.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 534JXBmL025122; Fri, 4 Apr 2025 16:30:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps1; bh=f0v4p PXThLv2NUyDcTSdxRWJMQ8/3WX67gNvjLsQXqs=; b=hSJe7cJDq9wWKeX+cHmhL qPCf3FVletm83bGzrJH19Ordrm9FoVpUPYL1BFlqJWgGQqPTx5z6XIUujtlduQj9 OZwxFq6hfAYarl+dx0dTfNn3bvOaeH+XempBZ5A8yf19GnIDr1NCYEvMOf4pfFhz HzzUvS/Treg/gBBeBHVzAY/za5W6viH1Hnh7/3ZlKO38roikn6JV9O0FHgbuxziE YJX2wurJgPp8KWNGTzxpchwt2xRTNxpzZmhyoPmT95AAxhteFPncROTNHbACJBQN 7Hzm1Tyn/cVpmAf4HFdi/HI/wpo2jbSqtZqSIjzoM04AAqeNRSkabGDTYj8h+9u5 A== Received: from sj2pr03cu002.outbound.protection.outlook.com (mail-westusazlp17013077.outbound.protection.outlook.com [40.93.1.77]) by mx0a-000eb902.pphosted.com (PPS) with ESMTPS id 45swpejjxa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Apr 2025 16:30:29 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wzS2B1ecOvC9GaatXvYwiVaPuo2HJvpSNYqtgOsMXEnWJUa7oON5QZFZOhsNsnaa7f5PvDsJP9t/M7DnED6fsv59DhGPQWgkCV6aWbEXUSK7x97ejgfDlhjN+yNfyUkEjZcwSZV2LkZ2XykIydVAanMaRnlTZoKdEM1EqTsDZNLhqN9Km/wJNQ73B6RXbbjOjY6r7N/w/u+UbL6ON/XtKuMOar2aLhU8ocsAyVOC8YhJVBW0gNjLZhpS1uFEKcvuJMEhS1cIOjPfX2cLZmaZIo7GIUXHeBH/Z1Wv1N33mc0sn2BPCGM5u3ObEjAM6otgjQ61+qTuDFNgp5bQ/R7x6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f0v4pPXThLv2NUyDcTSdxRWJMQ8/3WX67gNvjLsQXqs=; b=Cl8cpccjITw8q6FTYInWwLYfLphDKiEUVkY6W4ErUsF9n1r/D55slHURAHasG2EUNhi3Tu/ZxSSMbviOvuAsY92aIgJf3xfRNntyiXCRGFE+3AVW685kzHdy4k3wGsvR4HTnZT6kUjqbQsFXKTsEGvB9+HCZ67w/KuG6ffIxJK2yE4klXlQqLSF/TGGaR6PxfS5KwCUMYg6728NmXzLx4s3uvhvAWKeSNXFEsj+xVXCWcYmUBtOP0LPnLz42S4V0aDH6c/HcycgYdYJ6EgjsK3QtEe26k3dYKosPnV/UZM3CT85Pid9wI+k4J2Ylo02fESvu46tER8bmw9HOsTDAjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 204.77.163.244) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=garmin.com; dmarc=pass (p=reject sp=quarantine pct=100) action=none header.from=garmin.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f0v4pPXThLv2NUyDcTSdxRWJMQ8/3WX67gNvjLsQXqs=; b=T5+RwHTokvqoafvV/sxw6E2kvC3lS8OxBpER53+btaoPq+EDrlf+oLs6tOnJUDRNaZwib0xds63TDvSIzEuUuRh7P6ks9K0WzDG/w9tjR0QnkoKT6wS4ginv9D2SWTN6tLYAx46r9iH+AkgBA7Pa2albt5JUZm4b2+e1qsRRRYl/QYNuzS0km6OLY4cHoEZEipFsFWdfOPEPMCJSCMS6ases40i/m+U7Uz1PIq8AAK5VJD01l/AtZ7HVRZEczcYIGf3wc9QtvP0P6svdDiNZVrIKhgMlAb/Rddti5SYZ7FrJH0wfjLtvGDpzwG6U+BtHT0nMQdEceIlyOkXr9swtzA== Received: from CH2PR05CA0033.namprd05.prod.outlook.com (2603:10b6:610::46) by LV8PR04MB9114.namprd04.prod.outlook.com (2603:10b6:408:268::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.42; Fri, 4 Apr 2025 21:30:26 +0000 Received: from CH1PEPF0000AD7E.namprd04.prod.outlook.com (2603:10b6:610:0:cafe::be) by CH2PR05CA0033.outlook.office365.com (2603:10b6:610::46) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8632.9 via Frontend Transport; Fri, 4 Apr 2025 21:30:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 204.77.163.244) smtp.mailfrom=garmin.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=garmin.com; Received-SPF: Pass (protection.outlook.com: domain of garmin.com designates 204.77.163.244 as permitted sender) receiver=protection.outlook.com; client-ip=204.77.163.244; helo=edgetransport.garmin.com; pr=C Received: from edgetransport.garmin.com (204.77.163.244) by CH1PEPF0000AD7E.mail.protection.outlook.com (10.167.244.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Fri, 4 Apr 2025 21:30:26 +0000 Received: from kc3wpa-exmb4.ad.garmin.com (10.65.32.84) by cv1wpa-edge1 (10.60.4.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 4 Apr 2025 16:30:08 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by kc3wpa-exmb4.ad.garmin.com (10.65.32.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Fri, 4 Apr 2025 16:30:10 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by CV1WPA-EXMB1.ad.garmin.com (10.5.144.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 4 Apr 2025 16:30:09 -0500 Received: from CAR-4RCMR33.ad.garmin.com (10.5.209.17) by smtp.garmin.com (10.5.144.71) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 4 Apr 2025 16:30:08 -0500 From: Joseph Huang To: CC: Joseph Huang , Joseph Huang , Nikolay Aleksandrov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Roopa Prabhu , Simon Horman , , Subject: [Patch v3 net-next 2/3] net: bridge: Add offload_fail_notification bopt Date: Fri, 4 Apr 2025 17:29:34 -0400 Message-ID: <20250404212940.1837879-3-Joseph.Huang@garmin.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250404212940.1837879-1-Joseph.Huang@garmin.com> References: <20250404212940.1837879-1-Joseph.Huang@garmin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7E:EE_|LV8PR04MB9114:EE_ X-MS-Office365-Filtering-Correlation-Id: b0cf6f07-9e09-4c9e-241f-08dd73bfea3b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1DLlE2VRVp69ufz3CtraBQvHLYMtnTfXr5zJrNoH0LpTV9UIc3FOgUqXmYsj?= =?us-ascii?Q?iO1rwfCRCKLud+vSrUtxGhVtiBAFVaL38FvXa/bNYsLtxXL6swSIV6CuTdYL?= =?us-ascii?Q?KtojKxUD1h2Q3kTG1GzEZe371btGHBfIzM436csVVseWTTFlLAWd5RlPnXR6?= =?us-ascii?Q?VN5A43egqX09w1guqEzR4/G9xK+0X5ezRBxruUa068cq79hEzYyAjNX71x4q?= =?us-ascii?Q?8z1YWIVlpFHmpgfMg4XxPji8vtrPi7GDQypoz9Wk7qf6ETx2W990VDpEaWl6?= =?us-ascii?Q?eo4jAzvXzWJx5Pq2BIQNauKRkGz4OXvvEQ71TeyHepIlk2R4RRGLdyk6BjNC?= =?us-ascii?Q?9DuJv2Ozs9ry51WPj6SmX0v7sQlCBJj9n+KZrFPcQWBVoR69/8Y381w9BcEq?= =?us-ascii?Q?5OuDS8nINLSiSK/Iul3sZQ8VcuhXXXNF5AO/KUtKY4X7u7o5DTjntNI+Rd94?= =?us-ascii?Q?/LF10+oVrsHtw98VutVlAIW7tW2oCDPMXgETpNdZfexBM9HVbcxI+oaZYVqL?= =?us-ascii?Q?0ErEy/PCBIpnZKvFKdrCho2TsRcWVcfzDJvtWXV7rFqk8NgPDybOKD/AB7Zj?= =?us-ascii?Q?YkZ9WuRn7v8xeXdc1lvt+O68UlFMCqLotVkkbVYVyK1H7DZPBVv2/FTlQLOR?= =?us-ascii?Q?Qu8516WGunxh/vKu6F+i9KU81i2R03PIcYDwFZvHpf50ven8ziZXICFxeyQ/?= =?us-ascii?Q?27rcdLnBP2fjUibosqQgSvQO5JFwekK8xLXXvIxAdfZKpxRVbC4tzG5m4t8z?= =?us-ascii?Q?8cVXujXLwk3TOEkqHhe57+nrUIfMiHsQbt7O3GkAzBIvcnc6iqacPWXeCq+m?= =?us-ascii?Q?mEzba30BGhGJ8fZ07zJp/DoIiNyCxe+bq6aUk1ej1bmWsnlsaWObN1WpSE6D?= =?us-ascii?Q?gz+2pXtp+kegXsfcIY9No2QnLAy5dnohcVYwbNUdDIDUXQgbBHeHDLgNsmFp?= =?us-ascii?Q?zaTBy+6igim1e36rmVp9CIGwGXzFa1qXXFTnVBN08vnHdfIgVdvoYf51TBRy?= =?us-ascii?Q?Prjtpsuc7WYeZX8hlSkMnF3eyh5Vzi/nnKvcr84JZstJiC+KTSFRCITT1jT/?= =?us-ascii?Q?Wz4kZ4QIZfZkT55JZ3aO+ZQ4Gr7OIJ/ZBAyOgSLxV4G/+Wl1DVo9bEJgHXb+?= =?us-ascii?Q?jIkC2o0dFd5KiY4ifql+9WzU7F5KuERF206cf8gufKhO13HSLD3UI8vFNQUV?= =?us-ascii?Q?bJeBFmbvLprkQ4F3nIu5CNfXtVK9JMUuoi8voEzKTUVUJz5R0PvO6fxA0Dh7?= =?us-ascii?Q?H7aLaby0sIIVGpAPohcA26XxVwk8dDOllxQ6gRZIxlTHewGQh0WW4zQ3dHkY?= =?us-ascii?Q?6mVrgSQD6qyjOIzseRmuQwsoireFYZM4q9Kksswjh8b8c3+1OXXSg1UQyttu?= =?us-ascii?Q?4sjaPogrm3YIMispnjC/9mqY1rxToFjAuTUWovMBBtJ+F70wHaUGgRHzOS5a?= =?us-ascii?Q?sime/hu4zqk0bh37SE0SYp7VOZUbT64exWJi9Q9szdLcNghDSFb4bwzxPcPQ?= =?us-ascii?Q?EN+us9vTUiKjGthLVwcPpRDpxFnH1K5RJRBt?= X-Forefront-Antispam-Report: CIP:204.77.163.244;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:edgetransport.garmin.com;PTR:extedge.garmin.com;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1102; X-OriginatorOrg: garmin.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2025 21:30:26.1389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0cf6f07-9e09-4c9e-241f-08dd73bfea3b X-MS-Exchange-CrossTenant-Id: 38d0d425-ba52-4c0a-a03e-2a65c8e82e2d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38d0d425-ba52-4c0a-a03e-2a65c8e82e2d;Ip=[204.77.163.244];Helo=[edgetransport.garmin.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR04MB9114 X-Proofpoint-ORIG-GUID: gcZltM3PboxpcpzVWimYwIYD53qb352h X-Authority-Analysis: v=2.4 cv=ZtrtK87G c=1 sm=1 tr=0 ts=67f04f75 cx=c_pps a=1Ha7URm6ceckcZ/uwdfrUQ==:117 a=YA0UzX50FYCGjWi3QxTvkg==:17 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=XR8D0OoHHMoA:10 a=qm69fr9Wx_0A:10 a=NbHB2C0EAAAA:8 a=vr0dFHqqAAAA:8 a=KDSQBeb26tfA5DPfL6IA:9 a=P4ufCv4SAa-DfooDzxyN:22 cc=ntf X-Proofpoint-GUID: gcZltM3PboxpcpzVWimYwIYD53qb352h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_09,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=792 impostorscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc=notification route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2502280000 definitions=main-2504040147 Content-Type: text/plain; charset="utf-8" Add BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION bool option. Signed-off-by: Joseph Huang Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 1 + net/bridge/br.c | 5 +++++ net/bridge/br_private.h | 1 + 3 files changed, 7 insertions(+) diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h index f2a6de424f3f..73876c0e2bba 100644 --- a/include/uapi/linux/if_bridge.h +++ b/include/uapi/linux/if_bridge.h @@ -831,6 +831,7 @@ enum br_boolopt_id { BR_BOOLOPT_NO_LL_LEARN, BR_BOOLOPT_MCAST_VLAN_SNOOPING, BR_BOOLOPT_MST_ENABLE, + BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION, BR_BOOLOPT_MAX }; =20 diff --git a/net/bridge/br.c b/net/bridge/br.c index 183fcb362f9e..25dda554ca5b 100644 --- a/net/bridge/br.c +++ b/net/bridge/br.c @@ -284,6 +284,9 @@ int br_boolopt_toggle(struct net_bridge *br, enum br_bo= olopt_id opt, bool on, case BR_BOOLOPT_MST_ENABLE: err =3D br_mst_set_enabled(br, on, extack); break; + case BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION: + br_opt_toggle(br, BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION, on); + break; default: /* shouldn't be called with unsupported options */ WARN_ON(1); @@ -302,6 +305,8 @@ int br_boolopt_get(const struct net_bridge *br, enum br= _boolopt_id opt) return br_opt_get(br, BROPT_MCAST_VLAN_SNOOPING_ENABLED); case BR_BOOLOPT_MST_ENABLE: return br_opt_get(br, BROPT_MST_ENABLED); + case BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION: + return br_opt_get(br, BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION); default: /* shouldn't be called with unsupported options */ WARN_ON(1); diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 5f9d6075017e..02188b7ff8e6 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -484,6 +484,7 @@ enum net_bridge_opts { BROPT_VLAN_BRIDGE_BINDING, BROPT_MCAST_VLAN_SNOOPING_ENABLED, BROPT_MST_ENABLED, + BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION, }; =20 struct net_bridge { --=20 2.49.0 From nobody Sun Feb 8 10:47:28 2026 Received: from mx0b-000eb902.pphosted.com (mx0b-000eb902.pphosted.com [205.220.177.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E386D21B9C1; Fri, 4 Apr 2025 21:30:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.212 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743802254; cv=fail; b=KvCVatYwMzisYWTfA8JbSxnS4N8itZS6yPuIDcq8DR2fwa91KK2rqg6QVa6ScI7NuH+Xs01mY8p9Wxq8+WWeeHxu5pMuINIZOr86XO7wrDasU2zFPp2JZyzktRbtMKkXOry84YenBs/N19HJn8tWjCb9QFDTo5jgNkTF0zd8+gA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743802254; c=relaxed/simple; bh=LZMIX6LakFDTCMDfclJjSO9kGdNm178VrV5mOSjpM10=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NM2SlujPwtEqkO6KuyLF75Sw3mFEu4ZlwygYuXGtPwZ87M6mrtivNIEGCQllmEfBnNrG2OkPLQqlxpS9Q1iM0BOBlyebC1N5QGAl4BXndotZyZsViEMCqd41Yr+Ri3weINLHvSzIdQx29j22WhWuRc8qJ+2zcK/QM6BW38Mi+Rw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com; spf=pass smtp.mailfrom=garmin.com; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=IaFoUpaZ; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=mqSWVcq4; arc=fail smtp.client-ip=205.220.177.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garmin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="IaFoUpaZ"; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="mqSWVcq4" Received: from pps.filterd (m0220299.ppops.net [127.0.0.1]) by mx0a-000eb902.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 534LUSaS022954; Fri, 4 Apr 2025 16:30:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps1; bh=8AUWH CHxc4k0LCiSfOoNEOs/ffORgCtZfPclg6hJkuw=; b=IaFoUpaZl6/9xNrOEY/jc sQsPxhjWQHiV1F4Bef7ZS1pjlX57GkxPgh4a0hpwmVbMXhr5H4J0SiEfsB+92Xb3 tYOft/g4My1k/IlpIs1XQIe/RaTOCnf/B9iJ/ygynWtYTt98FlKEVXik9GzgHWnS bh/SrlQNXfhFRGOBto8ea0wROEgi/AkiYe/eSYssuW+Ewga0hyaUzdBIF7QQan0A tRVtxYe+POzSbnj7zw73x48CyF5hIZFWQJP3rJBI/YFKrnbw1Rssa/W9nhdPD+xT paRFQ7Gaiqktm70U5z/LEl24rNp6a+tCRPX2//EbfMR+4j81apjwd7JRGuM6iUa7 A== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azlp17010019.outbound.protection.outlook.com [40.93.12.19]) by mx0a-000eb902.pphosted.com (PPS) with ESMTPS id 45tnsn04ey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Apr 2025 16:30:38 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IFwwluStuxOIQ46ZPPvBYmrliq0p3vcZe1L4QuINtLW7XRV8Oig2daYFtVToTMzxcLgM1X9NweO1SFfpPooJjybkFRV/mPcntVHZ8C5AxkgPzXPK8sqE7UfCfyesBV7Drw5PvnmCghlHowh138nO2yBHy2U6ebtVnoxhxg/9MSTVOt8fDD9RT/FaYbnJytTf1bPzkbM5WLrQo8ohWcfZpmcp0bQcoWl6gw5cvHmRDP4Wv+ZGi5+oAO/QVnHjpc11nvVoeF2iZ2WSolU/UDttTTDOA1x+/HD3CF5grh7w2i7A4iipbwrU/zAE5NhdMx4OCPc3yjnGg77KBUP7Rbpclg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8AUWHCHxc4k0LCiSfOoNEOs/ffORgCtZfPclg6hJkuw=; b=AUn2SHYWb2Mi3FOdaB7Wihrc1cKWnGMDn9Rh1gbAv4cdV3ZZbSFPpULU6/D15Fp2uZt+DCGMcNUVB0+mBBcjVuymsF6hye6EzKoCXvWbn/X/E1GynDXGcD3PB5aYaog7ibIy067SkU6CNBdCZt+1Zi1PWoAiK5CbMkUCOzF9aGasxwZzGHBehr0Nrdmq4C2bCoIiDr4L7pRnCPfKOe+JWItIDbb9aqvJ7ybnRKSIHOZzIjwrNoHVeOfpTHQi1d/t0nL+m3RCIM3CgrcNSSUTCJjFTG2HFPLOpWIOGTHYZUeQ0XQBgDH11j4ZeTp8bezALDV45ARog6uxpWEV/FWQYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 204.77.163.244) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=garmin.com; dmarc=pass (p=reject sp=quarantine pct=100) action=none header.from=garmin.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8AUWHCHxc4k0LCiSfOoNEOs/ffORgCtZfPclg6hJkuw=; b=mqSWVcq4ab8tjGCVuLpkaP3Wg3hXN8W7ukShwLHugUQNXoWhW2Nb83aepem9rUFY0ij0aqY6/AOV5dfs+KuI40wDGFvdOUjWBCrSR3+ICFBYJBGCpphbhyHdzAvSeqsBTIQQFoz7jsfEIpyHo1KeMko6L6DwHOyXIU1ee66PzxqujM7Q2NNPJB9SdCIbzz3Hojtk1uT98d5W5hJRvbumTtvMSoLj9dVnixGtc2rXIvxpLHqWUazgjRcVHyssn4QhgP+y+26HACp1n+Iidd+0Oy+dOhx7SEaGNQSmop/d9Op8fGvvTVJwTmZIlw2xcr/LV8cHtSkjBaYLugrWc+ydYw== Received: from SJ0PR05CA0078.namprd05.prod.outlook.com (2603:10b6:a03:332::23) by CH2PR04MB6984.namprd04.prod.outlook.com (2603:10b6:610:94::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.50; Fri, 4 Apr 2025 21:30:36 +0000 Received: from MWH0EPF000971E2.namprd02.prod.outlook.com (2603:10b6:a03:332:cafe::61) by SJ0PR05CA0078.outlook.office365.com (2603:10b6:a03:332::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8632.8 via Frontend Transport; Fri, 4 Apr 2025 21:30:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 204.77.163.244) smtp.mailfrom=garmin.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=garmin.com; Received-SPF: Pass (protection.outlook.com: domain of garmin.com designates 204.77.163.244 as permitted sender) receiver=protection.outlook.com; client-ip=204.77.163.244; helo=edgetransport.garmin.com; pr=C Received: from edgetransport.garmin.com (204.77.163.244) by MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Fri, 4 Apr 2025 21:30:36 +0000 Received: from cv1wpa-exmb6.ad.garmin.com (10.5.144.76) by cv1wpa-edge1 (10.60.4.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 4 Apr 2025 16:30:14 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by cv1wpa-exmb6.ad.garmin.com (10.5.144.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Fri, 4 Apr 2025 16:30:16 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by CV1WPA-EXMB1.ad.garmin.com (10.5.144.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 4 Apr 2025 16:30:13 -0500 Received: from CAR-4RCMR33.ad.garmin.com (10.5.209.17) by smtp.garmin.com (10.5.144.71) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 4 Apr 2025 16:30:12 -0500 From: Joseph Huang To: CC: Joseph Huang , Joseph Huang , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Roopa Prabhu , Nikolay Aleksandrov , Simon Horman , , Subject: [Patch v3 net-next 3/3] net: bridge: mcast: Notify on mdb offload failure Date: Fri, 4 Apr 2025 17:29:35 -0400 Message-ID: <20250404212940.1837879-4-Joseph.Huang@garmin.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250404212940.1837879-1-Joseph.Huang@garmin.com> References: <20250404212940.1837879-1-Joseph.Huang@garmin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E2:EE_|CH2PR04MB6984:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ff66032-7fd1-417d-2be5-08dd73bff03e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|7416014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zIREL8bHujchMTZ2DkaxYFg/Q+AG6FYma3bYwJpW8koojeXGTZO6a19/7xLF?= =?us-ascii?Q?HwDz/ruiAU5rxewTY6AaJXe8ncHvO3O094v2j8Lj3R1OHWD/JyncZTCNLWRl?= =?us-ascii?Q?o789dQTwD0T82GgKXxWVq35LO8aewtoxCZj2KNOBPKM0ZvPVI0JM+sWTDkgO?= =?us-ascii?Q?uS6mRIaQ87fSzI+wIn9ciPfNKZgc8gV8I3jd6I9D6Sk6txLSXJKHa+RQ7HJw?= =?us-ascii?Q?XOm2M/cbX/9YD2rjcX3QMXRJevAR3FeRSNR5cQanOYMhYgF1Gx7Sp6mCJXyj?= =?us-ascii?Q?n489Z3ezim8YwZ99xLdAjO2bZ2oCydDIs7Oqgf2uKO2Wrt6nTEFG93Q90pcK?= =?us-ascii?Q?aLALQkz7e2gU9cDuEK2/8JLRD/K0HuaXhQu3w/Lg2OYMXxqTxZi1wZQTnrg0?= =?us-ascii?Q?8riV7Mx040oBBeLvt7Lp+DE7/xqiSi01XvR+1gWighvQf/dOQuv1ChyfzEe3?= =?us-ascii?Q?4cEtVxBSZwbYJIIfIozwjHU8DzJ3y5pI8DgSDi0ekONJtvm3BUx+NGpmqygs?= =?us-ascii?Q?/m3nxDGB342t0rFk5+X68ic4Q1VCgewXIzBaKfwfgz1SWnSWwIsQKcXzmDdl?= =?us-ascii?Q?j8GYVjrKlwqrjbpNdPLiH4+B4Urh2+evquwFEYSU/uz0/fIl4qesRiB3OzVn?= =?us-ascii?Q?I+HbTnfVRqzz30QRx3fruv5R8tVlfQl2zzE5tQkBLbjv6hnYftU98SLFJcBZ?= =?us-ascii?Q?No8IXHBXKHZJrOKF9Jg/PQi03RfAbH/5VqPevPpZ2RxrKkFbXabvUp8OQFUB?= =?us-ascii?Q?7g0MRTFq8PfY3QQ6TKSiFL2hR1jM/V+PIj5u2Tytj+3X/VqI9UT67tX+dpml?= =?us-ascii?Q?867BacZRkMEKLagrThO0bpu3/k4eoqNZmPP1FCkgcVbMsUucEVy4cwMQfUKK?= =?us-ascii?Q?iJZlCTiDYBwdJIbMtMZvN5vBOiQJml7RF9weT1xGUPFIAH+Diu7Fm6L+knky?= =?us-ascii?Q?Wc+FnioypWsxUDqsa7wgOy3ljG9x6P0WLlNVSmMFhVW+IzplHQuIcdCkVUIW?= =?us-ascii?Q?rmSTUWHEdwHkFXV/G7G4KTosITtvl5S16q6Xv1YMXxGKT5OnvZBUpk4Kz6iw?= =?us-ascii?Q?qtrEefXIJGM9+elSm2WsaFOrBbHPrh5sx7Jg7wsez+tpcgdQMzyoKDWmWs/p?= =?us-ascii?Q?RjZbpxTkZC8SZnKSMM0gz9lYyyCL4rJEYNZUTRpZOxCfWWGpP0BfKfIvVV8v?= =?us-ascii?Q?wkNi20fQmx43bRJcsFywV8hwtaykBNhESaHLhDvALMZKl083v4iirsE4KRkH?= =?us-ascii?Q?t0p9+eYS3mTBO4ArO7/iNou1pjUuqj2S5hsB08YLhu77FVZGP83UYmJRuFiV?= =?us-ascii?Q?30FCPp9d65lJTZBUsQnhDu8p9ESM6LO4AEJVEcQvXwX30KTaXxwMIBirR/+p?= =?us-ascii?Q?rVFwtrXMOh+s/9AwoaurWgI5Ymy8tXQRJtZdImZsKAtBVHqC3cUaAstsstWw?= =?us-ascii?Q?3QAbHyex8qLrYWmcEtDa3ur9Z1HYGhnMw1nZ3iXDFNJjV7L9VLHGsZy8MUpf?= =?us-ascii?Q?apNSnf1F7Deot1I=3D?= X-Forefront-Antispam-Report: CIP:204.77.163.244;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:edgetransport.garmin.com;PTR:extedge.garmin.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(7416014)(1800799024)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: garmin.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2025 21:30:36.0688 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ff66032-7fd1-417d-2be5-08dd73bff03e X-MS-Exchange-CrossTenant-Id: 38d0d425-ba52-4c0a-a03e-2a65c8e82e2d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38d0d425-ba52-4c0a-a03e-2a65c8e82e2d;Ip=[204.77.163.244];Helo=[edgetransport.garmin.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000971E2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6984 X-Proofpoint-ORIG-GUID: nBNQO1VNAU9iw9LOfsInxe3Vje5_ZLzc X-Authority-Analysis: v=2.4 cv=OvZPyz/t c=1 sm=1 tr=0 ts=67f04f7e cx=c_pps a=b4GTUaH8bIYRMqSiyTmTYA==:117 a=YA0UzX50FYCGjWi3QxTvkg==:17 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=XR8D0OoHHMoA:10 a=qm69fr9Wx_0A:10 a=NbHB2C0EAAAA:8 a=LF5D9LMcPqa3_lnOtKMA:9 cc=ntf X-Proofpoint-GUID: nBNQO1VNAU9iw9LOfsInxe3Vje5_ZLzc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_09,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc=notification route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2502280000 definitions=main-2504040147 Content-Type: text/plain; charset="utf-8" Notify user space on mdb offload failure if mdb_offload_fail_notification is enabled. Signed-off-by: Joseph Huang Acked-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 26 +++++++++++++++++++++----- net/bridge/br_private.h | 9 +++++++++ net/bridge/br_switchdev.c | 4 ++++ 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 0639691cd19b..5f53f387d251 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -519,16 +519,17 @@ static size_t rtnl_mdb_nlmsg_size(const struct net_br= idge_port_group *pg) rtnl_mdb_nlmsg_pg_size(pg); } =20 -void br_mdb_notify(struct net_device *dev, - struct net_bridge_mdb_entry *mp, - struct net_bridge_port_group *pg, - int type) +static void __br_mdb_notify(struct net_device *dev, + struct net_bridge_mdb_entry *mp, + struct net_bridge_port_group *pg, + int type, bool notify_switchdev) { struct net *net =3D dev_net(dev); struct sk_buff *skb; int err =3D -ENOBUFS; =20 - br_switchdev_mdb_notify(dev, mp, pg, type); + if (notify_switchdev) + br_switchdev_mdb_notify(dev, mp, pg, type); =20 skb =3D nlmsg_new(rtnl_mdb_nlmsg_size(pg), GFP_ATOMIC); if (!skb) @@ -546,6 +547,21 @@ void br_mdb_notify(struct net_device *dev, rtnl_set_sk_err(net, RTNLGRP_MDB, err); } =20 +void br_mdb_notify(struct net_device *dev, + struct net_bridge_mdb_entry *mp, + struct net_bridge_port_group *pg, + int type) +{ + __br_mdb_notify(dev, mp, pg, type, true); +} + +void br_mdb_flag_change_notify(struct net_device *dev, + struct net_bridge_mdb_entry *mp, + struct net_bridge_port_group *pg) +{ + __br_mdb_notify(dev, mp, pg, RTM_NEWMDB, false); +} + static int nlmsg_populate_rtr_fill(struct sk_buff *skb, struct net_device *dev, int ifindex, u16 vid, u32 pid, diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 02188b7ff8e6..fc43ccc06ccb 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -1005,6 +1005,8 @@ int br_mdb_hash_init(struct net_bridge *br); void br_mdb_hash_fini(struct net_bridge *br); void br_mdb_notify(struct net_device *dev, struct net_bridge_mdb_entry *mp, struct net_bridge_port_group *pg, int type); +void br_mdb_flag_change_notify(struct net_device *dev, struct net_bridge_m= db_entry *mp, + struct net_bridge_port_group *pg); void br_rtr_notify(struct net_device *dev, struct net_bridge_mcast_port *p= mctx, int type); void br_multicast_del_pg(struct net_bridge_mdb_entry *mp, @@ -1354,6 +1356,13 @@ br_multicast_set_pg_offload_flags(struct net_bridge_= port_group *p, p->flags |=3D (offloaded ? MDB_PG_FLAGS_OFFLOAD : MDB_PG_FLAGS_OFFLOAD_FAILED); } + +static inline bool +br_mdb_should_notify(const struct net_bridge *br, u8 changed_flags) +{ + return br_opt_get(br, BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION) && + (changed_flags & MDB_PG_FLAGS_OFFLOAD_FAILED); +} #else static inline int br_multicast_rcv(struct net_bridge_mcast **brmctx, struct net_bridge_mcast_port **pmctx, diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index 57e1863edf93..bbdf6a3ba941 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -504,6 +504,7 @@ static void br_switchdev_mdb_complete(struct net_device= *dev, int err, void *pri struct net_bridge_mdb_entry *mp; struct net_bridge_port *port =3D data->port; struct net_bridge *br =3D port->br; + u8 old_flags; =20 if (err =3D=3D -EOPNOTSUPP) goto notsupp; @@ -517,7 +518,10 @@ static void br_switchdev_mdb_complete(struct net_devic= e *dev, int err, void *pri if (p->key.port !=3D port) continue; =20 + old_flags =3D p->flags; br_multicast_set_pg_offload_flags(p, !err); + if (br_mdb_should_notify(br, old_flags ^ p->flags)) + br_mdb_flag_change_notify(br->dev, mp, p); } out: spin_unlock_bh(&br->multicast_lock); --=20 2.49.0