From nobody Tue Dec 16 23:43:22 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C751BC9F4 for ; Fri, 4 Apr 2025 11:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743767818; cv=none; b=g2SxJs9eWUNHlI8TF+S5J+dIsG9klnGQ2hYxh1oKlsN6Bs7Bj9K0YlH1vCRp41x2M1hIYZV4s6hUTbe5Ac8f7Ajc5z4ndPEXSObYahh7DcLJh/O9MJmWYbieCvjs9w+v1vhgHf/rtOw1knNEeiQuF19deg0Z07Vb5Rl6EdysAq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743767818; c=relaxed/simple; bh=PDZ8wopAz0p6dRYwWVh9TziS/j8jc0WTBI7vNoZgTPg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Q76VNc9SFpukqAzrq2xPDTgCmzYTN4xYUn75m/Zc8la0RfafsOoSapNB9skHxd92fpWj18VjFm0+5DH9N+srCT81zKwOO26/oyIBZukudIIQaf8nKpCTDCviIFe217ceIGNCEjlKMA4T7Jfzs1AqGeAxZd/WNYNUyPH0xz+Qe7Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=9elements.com; spf=pass smtp.mailfrom=9elements.com; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b=PUMQG8so; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=9elements.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=9elements.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b="PUMQG8so" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39727fe912cso932674f8f.3 for ; Fri, 04 Apr 2025 04:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1743767813; x=1744372613; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=doiI8VQYK1ufpJ8YlTdC9R6WZr99FG3ISjHW2FSinYk=; b=PUMQG8soi16HrQk0BkopQQjfrFjQdYudXQRisBysJuKFHO4AZDrWZJXBn6JFl2mPJj DXUFM+r7PyGRa7SVK3d0pFWG64RZTuEnKfSHSiVx0AoKZ3QhZFO8L9MGnAaJYj6m4ufn lvDlVcx0E0pdcm/ZRUou3sBQ3gu4Pa04OYcdklwC9YYtBmw7us3xHWRZsSGfNvWxN0J1 veoC7XT60MWN93YSYE1q60++TGnTRyze89LPbF8rRYQvAGclr/gUX1z6Mz2xQGbCKCmS qooaTucXYRLSN06jPdHzoi9nTjDJU4QXXOH4l20iAzuDc2yecCzzncrXSkns4VZ/FDd5 TebQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743767813; x=1744372613; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=doiI8VQYK1ufpJ8YlTdC9R6WZr99FG3ISjHW2FSinYk=; b=Zl0zFwWODFTOXaxF+lWncHp3N1wBtHSlSzQnPdd2eo/rJHVS/69qxEPo426sOPG2jA NX02XgQK2KzXVJOiwlrx5/jWU/X6Ffytv2KwSunvjpWLyyWBlYsjljESD6Y1Y3PnJPBW +8D/IvgqZ+kkCYsDDfur3laxLhXH7MPOL6omYizqdHlX/T+PE5crAEHsVXq0HvWUEGX5 gXvt0M/PlFde3ZG2j5Nq6toUN9d1dC/P78KeJ8dhJa93gAVPzYXvko62d5Vl8x4JSISN WNMTNsGq7lfMZgUp43K6E7b4UoiVQa277lUxvyLgKbhsfgbUOqCv4Gj2TQk7ovx2AsV3 ZMmQ== X-Forwarded-Encrypted: i=1; AJvYcCUp8JF7PXFdNx6r2FT3T0az0NP3UBA90YYbNmSFainoSfhwCQF3lHTIrIrEgmHIneNjOtT4NAWlB/8Btgk=@vger.kernel.org X-Gm-Message-State: AOJu0YyawTmPWOmq6jKV5Yi9ECcluYDL9N6dER1Yf2nWSmTVQ5AbIyUs vXWYx0HUf9S2YEnQ60PgjMfp97pjgHIzbI7J8FFIchuoajXwHmJGJPWurLhNU+A= X-Gm-Gg: ASbGncss+rSznOm31Q4oxm6c5/KA/P1ewxJDc3MG700KroHf9H25zrfzGBLpg86HBJK uteKWhvEWOdL59oijie8GwIshCic6KMqVL5nwfFGL1QS32b6/RaVyKwWNhvnnsFeGWKWfvMGqWn xBRFEsLTHW4xCI6D9/6P7T2bpyfWvMK8CPsOsxYCsl5qf/ztpFqCvWjdN/exXi7/P9+cRxAbXNl E1SHD6cDrQ1B/pIaBRT1D5+cE/v3w5Z/ewZkLv5wr5Qe9OOS7ajaNa0d65r5rk4dF6oDATKTE4U m4EKU7tEYbxgBVJDzNp7oMVvFdidWBoWBzY5g6fT+mtjnfQWtDzpz3ODHlsCLTUS2hLvEqR8Xxw RasfC4zGnzgMD4xEh+tUSb9Q= X-Google-Smtp-Source: AGHT+IEeD0LudfIMzIZ39+meQ1M9f+OiYAkIG6t3WyDlnjQ7l93eVXpcifm9jo92oB6MspeMv7DRSA== X-Received: by 2002:a05:6000:220f:b0:391:2f2f:818 with SMTP id ffacd0b85a97d-39cb35b24famr2899682f8f.9.1743767813392; Fri, 04 Apr 2025 04:56:53 -0700 (PDT) Received: from stroh80.lab.9e.network (ip-078-094-000-050.um19.pools.vodafone-ip.de. [78.94.0.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30226f1fsm4236219f8f.95.2025.04.04.04.56.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 04:56:52 -0700 (PDT) From: Your Name X-Google-Original-From: Your Name To: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Naresh Solanki Subject: [RESEND PATCH v2] hwmon: (max6639) : Allow setting target RPM Date: Fri, 4 Apr 2025 17:26:45 +0530 Message-ID: <20250404115646.2000563-1-you@example.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Naresh Solanki Currently, during startup, the fan is set to its maximum RPM by default, which may not be suitable for all use cases. This patch introduces support for specifying a target RPM via the Device Tree property "target-rpm". Changes: - Added `target_rpm` field to `max6639_data` structure to store the target RPM for each fan channel. - Modified `max6639_probe_child_from_dt()` to read the `"target-rpm"` property from the Device Tree and set `target_rpm` accordingly. - Updated `max6639_init_client()` to use `target_rpm` to compute the initial PWM duty cycle instead of defaulting to full speed (120/120). Behavior: - If `"target-rpm"` is specified, the fan speed is set accordingly. - If `"target-rpm"` is not specified, the previous behavior (full speed at startup) is retained. This allows better control over fan speed during system initialization. Signed-off-by: Naresh Solanki --- Changes in v2: - Pre-init target_rpm[] to 4000 RPM - Validate if target_rpm[] is within configured range. --- drivers/hwmon/max6639.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/max6639.c b/drivers/hwmon/max6639.c index 32b4d54b2076..a06346496e1d 100644 --- a/drivers/hwmon/max6639.c +++ b/drivers/hwmon/max6639.c @@ -80,6 +80,7 @@ struct max6639_data { /* Register values initialized only once */ u8 ppr[MAX6639_NUM_CHANNELS]; /* Pulses per rotation 0..3 for 1..4 ppr */ u8 rpm_range[MAX6639_NUM_CHANNELS]; /* Index in above rpm_ranges table */ + u32 target_rpm[MAX6639_NUM_CHANNELS]; =20 /* Optional regulator for FAN supply */ struct regulator *reg; @@ -563,6 +564,10 @@ static int max6639_probe_child_from_dt(struct i2c_clie= nt *client, if (!err) data->rpm_range[i] =3D rpm_range_to_reg(val); =20 + err =3D of_property_read_u32(child, "target-rpm", &val); + if (!err) + data->target_rpm[i] =3D val; + return 0; } =20 @@ -573,6 +578,7 @@ static int max6639_init_client(struct i2c_client *clien= t, const struct device_node *np =3D dev->of_node; struct device_node *child; int i, err; + u8 target_duty; =20 /* Reset chip to default values, see below for GCONFIG setup */ err =3D regmap_write(data->regmap, MAX6639_REG_GCONFIG, MAX6639_GCONFIG_P= OR); @@ -586,6 +592,8 @@ static int max6639_init_client(struct i2c_client *clien= t, /* default: 4000 RPM */ data->rpm_range[0] =3D 1; data->rpm_range[1] =3D 1; + data->target_rpm[0] =3D 4000; + data->target_rpm[1] =3D 4000; =20 for_each_child_of_node(np, child) { if (strcmp(child->name, "fan")) @@ -639,8 +647,12 @@ static int max6639_init_client(struct i2c_client *clie= nt, if (err) return err; =20 - /* PWM 120/120 (i.e. 100%) */ - err =3D regmap_write(data->regmap, MAX6639_REG_TARGTDUTY(i), 120); + /* Set PWM based on target RPM if specified */ + if (data->target_rpm[i] > rpm_ranges[data->rpm_range[i]]) + data->target_rpm[i] =3D rpm_ranges[data->rpm_range[i]]; + + target_duty =3D 120 * data->target_rpm[i] / rpm_ranges[data->rpm_range[i= ]]; + err =3D regmap_write(data->regmap, MAX6639_REG_TARGTDUTY(i), target_duty= ); if (err) return err; } base-commit: 2115cbeec8a3ccc69e3b7ecdf97b4472b0829cfc --=20 2.42.0