From nobody Sun Feb 8 08:48:50 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ACAD18C32C for ; Fri, 4 Apr 2025 09:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743758261; cv=none; b=ZPabeevkSx9kkG2rkcM++AEdkvAuIXljfW4ZqzRed2yofh0xThEel/hN2c8Suqr715bBnpjNyqpPbUeRHROfWR3SNhXzBWtvYYAcTgk84gHl/ROCz9DKy0EDt3Jv2GZf7VIUEi42ZY3bpev2Tf/3woQcGVRchTuzacvTWgNFLGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743758261; c=relaxed/simple; bh=Bhskp+8KUmzT6+yWnWxUIv+I1Ci7IWHGxaZ5DAc6aF4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V6pUT+nWXFZU2m2oiFo1Ql53up3OD5Mb1Kc4f+LnLv3pYiCxxgNoRxxFUBqhU83iCRQ5Y4W1Xp+pGD0NcDgXbt7Ot6R4a831cX4f5kiSA5Ob/TvzRNsMI7vJp+kAa8sPlfl96zugFvj12gOGjtJrQVCTfmcaz/qMhQ5NXPn2iYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eVwoe1Tj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eVwoe1Tj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743758257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jdt0UC5Y+YSICWNN9M7UpOd4+QGCXUQrqY/ZjKnsARY=; b=eVwoe1Tj2WqBHOxOkbYoIPW5/bF6LonIN9vxlytsn9zWy7zFzVSvHeIuQLfvCa+a18Trgo tCPO+ITFYNIDAaVHjP6kjx/A5X9qlIkvrCNiXT6pYoi4T23ki/fSXZSwlWL06Xy+/IHk5+ ypjVuCN84pl6DNi3xU5olj4SmwwTGEY= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484--ECH5bjcOsq6GdHO_6ZNiA-1; Fri, 04 Apr 2025 05:17:36 -0400 X-MC-Unique: -ECH5bjcOsq6GdHO_6ZNiA-1 X-Mimecast-MFC-AGG-ID: -ECH5bjcOsq6GdHO_6ZNiA_1743758256 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-af423fb4f0eso1303052a12.0 for ; Fri, 04 Apr 2025 02:17:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743758255; x=1744363055; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jdt0UC5Y+YSICWNN9M7UpOd4+QGCXUQrqY/ZjKnsARY=; b=jZeXogKFeMSTdlC2L/DESe7d9qSHf9a0cI64n82HSKGUxfcgaK2kz+CWbojENqD+4K 2gpZyZei6y5vZky6FhqlCWAwIifXLwWEUx5rey1QVLxv+glSxdzCmKAbtdjUP1kW14rd 8c/NzKqMj7EIKOEy0HnaIl1BW9S+oTr23zhodgh6ii5mnub4YAZ3cJy7wLyXDz2L020E 67xREW+qJRGeOZSvvsda61a24VEwPP4nkVKSuZiU8cYTXAKVHcdzShVIXRXY6G2eT6i7 8jXZ83n3MUtittk/2XsKmhIt8AJlsm5KJXSR6qHbHC90bZ+Yjtd/qMvqz3wjDKsepS0G 45Qw== X-Forwarded-Encrypted: i=1; AJvYcCVFDS8iWW7oXii8Fe52c0td2OHhpErc2EPSuunPeQFIQF+eXSJeHbSmIDc56vT56tPvMgZG4opah54315o=@vger.kernel.org X-Gm-Message-State: AOJu0YyhngdP2wVcFSECAec2C5KTbs80mIqzr6+3bRJCf6M9IkfkjAjN +sY/vEEcbDPCwc3BLz3zNgVdLxhKudM7+POFAPXJPBW/4YlspkWY1jAI9Rgzlb4oNn4VeLeJZ5F r0TS9qblu6y96eAmHia8vcHScA2Zy4k7SKnA587oe+NDKspW5OqyiTfXrSnS5OQjv8vsBFkMR X-Gm-Gg: ASbGncv+U7iubGznFOnjugnjyK4tMuYp0a6QJljA3OTZzxrVpo7XAMUCBg1k6adaquw G2rLnhSjNa741Z6hzBSMCpJ0JRJOk5YPMaXo4HEAqWKrZZbwYfpDY9QiZsSoFLQ5LoSvyY3p+36 G+V5gsuw8gs+r8eAP0XyVOQFptk8M/iV0PI9Ffeo+uVgL8TVtt+pj3HqfwB2s68DKkzoYhIkimN /tzDgs6YWSewUttzHDgV+/FpFCYkHNnxxt6InCiydvZL09zMzaa7h7H28SxWMxanDfrAN9MUQAP QrgRlE21H0pq/9vr X-Received: by 2002:a05:6a20:2d14:b0:1f5:55b7:1bb4 with SMTP id adf61e73a8af0-201045a6c2dmr4306806637.11.1743758255241; Fri, 04 Apr 2025 02:17:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4cF4AJ9IrgwOr6kkgUgDT+AZY2Wj7fW+I4Ga378jGkThhOH+aHldzacKBbkECHVRoyItLUQ== X-Received: by 2002:a05:6a20:2d14:b0:1f5:55b7:1bb4 with SMTP id adf61e73a8af0-201045a6c2dmr4306786637.11.1743758254905; Fri, 04 Apr 2025 02:17:34 -0700 (PDT) Received: from zeus.elecom ([240b:10:83a2:bd00:6e35:f2f5:2e21:ae3a]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc3fd411sm2432493a12.52.2025.04.04.02.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 02:17:34 -0700 (PDT) From: Ryosuke Yasuoka To: airlied@redhat.com, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: Ryosuke Yasuoka , virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/qxl: Remove unused argument from qxl_alloc_release_reserved Date: Fri, 4 Apr 2025 18:16:51 +0900 Message-ID: <20250404091654.1664838-1-ryasuoka@redhat.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The `size` argument in the `qxl_alloc_release_reserved` function is currently unused and has no effect on the function's logic. So remove this argument to clean up the code. No functional changes are expected. Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/qxl/qxl_display.c | 9 +++------ drivers/gpu/drm/qxl/qxl_draw.c | 3 +-- drivers/gpu/drm/qxl/qxl_drv.h | 5 ++--- drivers/gpu/drm/qxl/qxl_ioctl.c | 7 +------ drivers/gpu/drm/qxl/qxl_release.c | 8 +++----- 5 files changed, 10 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_di= splay.c index 70aff64ced87..c0c65efbfa32 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -496,8 +496,7 @@ static int qxl_primary_apply_cursor(struct qxl_device *= qdev, if (!qcrtc->cursor_bo) return 0; =20 - ret =3D qxl_alloc_release_reserved(qdev, sizeof(*cmd), - QXL_RELEASE_CURSOR_CMD, + ret =3D qxl_alloc_release_reserved(qdev, QXL_RELEASE_CURSOR_CMD, &release, NULL); if (ret) return ret; @@ -541,8 +540,7 @@ static int qxl_primary_move_cursor(struct qxl_device *q= dev, if (!qcrtc->cursor_bo) return 0; =20 - ret =3D qxl_alloc_release_reserved(qdev, sizeof(*cmd), - QXL_RELEASE_CURSOR_CMD, + ret =3D qxl_alloc_release_reserved(qdev, QXL_RELEASE_CURSOR_CMD, &release, NULL); if (ret) return ret; @@ -714,8 +712,7 @@ static void qxl_cursor_atomic_disable(struct drm_plane = *plane, struct qxl_cursor_cmd *cmd; int ret; =20 - ret =3D qxl_alloc_release_reserved(qdev, sizeof(*cmd), - QXL_RELEASE_CURSOR_CMD, + ret =3D qxl_alloc_release_reserved(qdev, QXL_RELEASE_CURSOR_CMD, &release, NULL); if (ret) return; diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c index 3a3e127ce297..b4c41545fb06 100644 --- a/drivers/gpu/drm/qxl/qxl_draw.c +++ b/drivers/gpu/drm/qxl/qxl_draw.c @@ -64,8 +64,7 @@ static struct qxl_rect *drawable_set_clipping(struct qxl_= device *qdev, static int alloc_drawable(struct qxl_device *qdev, struct qxl_release **release) { - return qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable), - QXL_RELEASE_DRAWABLE, release, NULL); + return qxl_alloc_release_reserved(qdev, QXL_RELEASE_DRAWABLE, release, NU= LL); } =20 static void diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index cc02b5f10ad9..fbc15338ae3c 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.h +++ b/drivers/gpu/drm/qxl/qxl_drv.h @@ -372,9 +372,8 @@ int qxl_alloc_surface_release_reserved(struct qxl_devic= e *qdev, enum qxl_surface_cmd_type surface_cmd_type, struct qxl_release *create_rel, struct qxl_release **release); -int qxl_alloc_release_reserved(struct qxl_device *qdev, unsigned long size, - int type, struct qxl_release **release, - struct qxl_bo **rbo); +int qxl_alloc_release_reserved(struct qxl_device *qdev, int type, + struct qxl_release **release, struct qxl_bo **rbo); =20 int qxl_push_command_ring_release(struct qxl_device *qdev, struct qxl_release = *release, diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioct= l.c index 506ae1f5e099..5e0321b6f319 100644 --- a/drivers/gpu/drm/qxl/qxl_ioctl.c +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c @@ -171,12 +171,7 @@ static int qxl_process_single_command(struct qxl_devic= e *qdev, if (!reloc_info) return -ENOMEM; =20 - ret =3D qxl_alloc_release_reserved(qdev, - sizeof(union qxl_release_info) + - cmd->command_size, - release_type, - &release, - &cmd_bo); + ret =3D qxl_alloc_release_reserved(qdev, release_type, &release, &cmd_bo); if (ret) goto out_free_reloc; =20 diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_re= lease.c index 05204a6a3fa8..52c444a482be 100644 --- a/drivers/gpu/drm/qxl/qxl_release.c +++ b/drivers/gpu/drm/qxl/qxl_release.c @@ -279,13 +279,11 @@ int qxl_alloc_surface_release_reserved(struct qxl_dev= ice *qdev, return 0; } =20 - return qxl_alloc_release_reserved(qdev, sizeof(struct qxl_surface_cmd), - QXL_RELEASE_SURFACE_CMD, release, NULL); + return qxl_alloc_release_reserved(qdev, QXL_RELEASE_SURFACE_CMD, release,= NULL); } =20 -int qxl_alloc_release_reserved(struct qxl_device *qdev, unsigned long size, - int type, struct qxl_release **release, - struct qxl_bo **rbo) +int qxl_alloc_release_reserved(struct qxl_device *qdev, int type, + struct qxl_release **release, struct qxl_bo **rbo) { struct qxl_bo *bo, *free_bo =3D NULL; int idr_ret; base-commit: e48e99b6edf41c69c5528aa7ffb2daf3c59ee105 --=20 2.48.1