From nobody Fri Apr 11 05:25:31 2025 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77B8B1F0E27 for ; Wed, 2 Apr 2025 20:16:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743624979; cv=none; b=jeooc5jc9A5FOaow7Qz5MZGKUNEHEAF8jS8s8ya5rchedeU/zLNhdXCTclq8aNZLOpjGkb+YB1wm8RbcdOMdtJGTllgyHECruTk2owjhdTm+I0UvAbz/U/fD1O+UC1SLp1FWl7i6YEGjMJ5UUVrUmhGPns2YuKhpfkuGz2ktF1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743624979; c=relaxed/simple; bh=NqnWpcdFkNGPmqWCPNT6GGaIm7Gc0q9VpwYczE12dRI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=YG5iQN68nUQyc7TDQVAHnld6pvW4SJBMSy8mFDRANVGgWodxxS3u3uhx/xj/9CehAdj/Zbz1trPEOa3wMX/zSR/vKlnyhWf4KzpuW811xkCwB9RxU3/Ggh4nyREd7Cl3krrBVtm8HgnS4xxrbjNerRR3QlHFGF9C+Vlx5l1llTI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oWXp68gG; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oWXp68gG" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2242f3fd213so1533165ad.1 for ; Wed, 02 Apr 2025 13:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743624978; x=1744229778; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=GVMZzaRI0SYaZ9HIFXqjbn9kAaASuQl6uCuXVUyZL/Q=; b=oWXp68gGcpbatrX/v+U5Sy6YtXo2PXM3WnBs4mDHIwt8mRrjegp4QVIh8xQ9chB6ZX zgXjXG3whyF7b0TiDPPzdOdZ5Ffe5JcJ6WOJMZnUQOX6r8keR7uFKGtf1r8cPFVgCwD2 xMhvxZbwMOIn4WKY5F/eoLFd1/aXuci4s3qVLiBjD11psFFVOaL5CyI3sJa3eauL/l49 VmBXVn9iXCroJ/O6nCTytYHsw7cCkR15IQDjA2FNkEhsvJjAwxpg1KnkNu54KegJP9q4 T1JKUOIH/DK8RKpBbCZ7F8QaLX8CRUxtPXIQabjLofs8KBDAzXFSXnTaGchouvs5squl /Bzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743624978; x=1744229778; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GVMZzaRI0SYaZ9HIFXqjbn9kAaASuQl6uCuXVUyZL/Q=; b=Fnf+ZVVPfdO8pJFtvgYf+5Ii/JnsZ9e52llXnyCfAaP2vhbuUDEGX+t9ErBhAH0j4J cUtK5XNErJWrD585XP5pbDSbp7QV9zWrsYjzyp54Rwp/+byQY6GVrK+UaQIn9cOD2kDO xAQIqRXdoBQCyDt8ayt6Pq6AyMNbc74BJqjR8TLZX/UDPXt71DOf9Afn2YMNVbTpp+Gu Jy8oInGWR3/JNPoStyE5YrOTTKrmWkRXutPO93bZ5fdVfzmyhb5zkG/RxMyXEbxDaXwR XBkdA9nq8GvWTcqKgjXzjS8/q7yFun0QIzP4zOR5pE5+kS+wZELediqbFyP0QAo7dtrE qAFw== X-Forwarded-Encrypted: i=1; AJvYcCXeZ8Y+maAEg3SiXbpDDK5Qf3G9+QGy8Wm4ubMfLecPBdE/B+t49TBIR4t9y/uAZcJu/zrjcoYi5zD05ss=@vger.kernel.org X-Gm-Message-State: AOJu0YzKneYk/I282UL1Bp6qfLwW6ZFD7mG1sTi8m0/6Qr1KJPhusZ24 OHHhFCB1AUJvn0aLTZPzWiiXgoDkKK9kYBoiusTAbsLyItiqHYrbC5QT53pnRcu6HWi5aES2/tT 76ffVaw== X-Google-Smtp-Source: AGHT+IE9JQSaSNT9+T67Fkw2cDbYozJxAUfJ3kBmZZqgEDU9Xl9sBP5tq+Bq6erIy5pJoy1fkGy1uDx6xAaq X-Received: from plry12.prod.google.com ([2002:a17:902:b48c:b0:223:4788:2e83]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d586:b0:224:93e:b5d7 with SMTP id d9443c01a7336-22977e0fba2mr1340135ad.34.1743624977770; Wed, 02 Apr 2025 13:16:17 -0700 (PDT) Date: Wed, 2 Apr 2025 13:15:46 -0700 In-Reply-To: <20250402201549.4090305-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250402201549.4090305-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250402201549.4090305-3-irogers@google.com> Subject: [PATCH v3 2/5] perf stat: Remove print_mixed_hw_group_error From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Howard Chu , Dominique Martinet , Levi Yun , "Dr. David Alan Gilbert" , Andi Kleen , James Clark , Weilin Wang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" print_mixed_hw_group_error will print a warning when a group of events uses different PMUs. This isn't possible to happen as parse_events__sort_events_and_fix_groups will break groups when this happens, adding the warning at the start of perf of: WARNING: events were regrouped to match PMUs As the previous mixed group warning can never happen, remove the associated code. Signed-off-by: Ian Rogers --- tools/perf/util/stat-display.c | 31 ------------------------------- tools/perf/util/stat.h | 1 - 2 files changed, 32 deletions(-) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index 1115efb380fb..aab3697aed63 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -798,30 +798,6 @@ static void abs_printout(struct perf_stat_config *conf= ig, print_cgroup(config, os, evsel->cgrp); } =20 -static bool is_mixed_hw_group(struct evsel *counter) -{ - struct evlist *evlist =3D counter->evlist; - u32 pmu_type =3D counter->core.attr.type; - struct evsel *pos; - - if (counter->core.nr_members < 2) - return false; - - evlist__for_each_entry(evlist, pos) { - /* software events can be part of any hardware group */ - if (pos->core.attr.type =3D=3D PERF_TYPE_SOFTWARE) - continue; - if (pmu_type =3D=3D PERF_TYPE_SOFTWARE) { - pmu_type =3D pos->core.attr.type; - continue; - } - if (pmu_type !=3D pos->core.attr.type) - return true; - } - - return false; -} - static bool evlist__has_hybrid_pmus(struct evlist *evlist) { struct evsel *evsel; @@ -886,8 +862,6 @@ static void printout(struct perf_stat_config *config, s= truct outstate *os, if (counter->supported) { if (!evlist__has_hybrid_pmus(counter->evlist)) { config->print_free_counters_hint =3D 1; - if (is_mixed_hw_group(counter)) - config->print_mixed_hw_group_error =3D 1; } } } @@ -1587,11 +1561,6 @@ static void print_footer(struct perf_stat_config *co= nfig) " echo 0 > /proc/sys/kernel/nmi_watchdog\n" " perf stat ...\n" " echo 1 > /proc/sys/kernel/nmi_watchdog\n"); - - if (config->print_mixed_hw_group_error) - fprintf(output, - "The events in group usually have to be from " - "the same PMU. Try reorganizing the group.\n"); } =20 static void print_percore(struct perf_stat_config *config, diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h index 2fda9acd7374..1bcd7634bf47 100644 --- a/tools/perf/util/stat.h +++ b/tools/perf/util/stat.h @@ -100,7 +100,6 @@ struct perf_stat_config { int times; int run_count; int print_free_counters_hint; - int print_mixed_hw_group_error; const char *csv_sep; struct stats *walltime_nsecs_stats; struct rusage ru_data; --=20 2.49.0.504.g3bcea36a83-goog