From nobody Thu May 15 10:22:18 2025
Received: from mail.crpt.ru (mail1.crpt.ru [91.236.205.1])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B2523875A
for <linux-kernel@vger.kernel.org>; Wed, 2 Apr 2025 14:12:45 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=91.236.205.1
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743603172; cv=none;
b=n31gfYmod6nwuK7jMdHARpQzGm9gNkXdolPRueixabl/TNniwY5J4ZXsMRqMAoqrhFqfQOPEVPBe/DN3g2rQJoasE/PXXqu/E5wptSAElZ7biiEu1pBEsaw2A2k0fB/oXbPz6TjrE/wJjAOA2A3pyrN2+sswJGf8F6PYXlIS488=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743603172; c=relaxed/simple;
bh=LW6r9FmmgL8wgSDH1rANqK2rFnzYBzbw9u9WPWj5At8=;
h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version;
b=hfA4H2MswuVVzCqW0ydewGHMvMwgwK+AUGzsUfuD/tgXPfZIrbt3PDP4uX7cv2cBSyngxwGfsHvBTW2rd/tlPqbPrjSnyDJNiOmsqzIbjOLcf/Yj26Sk2bKpK1eSd59GKPrITE5KZV7jj5dLyD2Gc4WRSgSJqgOd/qTiOn4aj5Q=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=crpt.ru;
spf=pass smtp.mailfrom=crpt.ru;
dkim=pass (2048-bit key) header.d=crpt.ru header.i=@crpt.ru
header.b=FJsoM969; arc=none smtp.client-ip=91.236.205.1
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=crpt.ru
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=crpt.ru
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=crpt.ru header.i=@crpt.ru
header.b="FJsoM969"
Received: from mail.crpt.ru ([192.168.60.3])
by mail.crpt.ru with ESMTP id 532ECOEp031968-532ECOEr031968
(version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=OK);
Wed, 2 Apr 2025 17:12:24 +0300
Received: from EX2.crpt.local (192.168.60.4) by ex1.crpt.local (192.168.60.3)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Wed, 2 Apr
2025 17:12:25 +0300
Received: from EX2.crpt.local ([192.168.60.4]) by EX2.crpt.local
([192.168.60.4]) with mapi id 15.01.2507.044; Wed, 2 Apr 2025 17:12:25 +0300
From: =?utf-8?B?0JLQsNGC0L7RgNC+0L/QuNC9INCQ0L3QtNGA0LXQuQ==?=
<a.vatoropin@crpt.ru>
To: Felix Kuehling <Felix.Kuehling@amd.com>
CC: =?utf-8?B?0JLQsNGC0L7RgNC+0L/QuNC9INCQ0L3QtNGA0LXQuQ==?=
<a.vatoropin@crpt.ru>, Alex Deucher <alexander.deucher@amd.com>,
=?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= <christian.koenig@amd.com>, David Airlie
<airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: [PATCH v3] drm/amdkfd: Change svm_range_get_info return type
Thread-Topic: [PATCH v3] drm/amdkfd: Change svm_range_get_info return type
Thread-Index: AQHbo9lC4BY/VWq2e0yOP4nLCPzxPA==
Date: Wed, 2 Apr 2025 14:12:25 +0000
Message-ID: <20250402141219.372650-1-a.vatoropin@crpt.ru>
Accept-Language: ru-RU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-kse-serverinfo: EX1.crpt.local, 9
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: Clean, bases: 2/17/2025 9:52:00 AM
x-kse-attachment-filter-triggered-rules: Clean
x-kse-attachment-filter-triggered-filters: Clean
x-kse-bulkmessagesfiltering-scan-result: protection disabled
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-FEAS-Client-IP: 192.168.60.3
X-FE-Policy-ID: 2:4:0:SYSTEM
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=crpt.ru; s=crpt.ru;
c=relaxed/relaxed;
h=from:to:cc:subject:date:message-id:content-type:mime-version;
bh=LW6r9FmmgL8wgSDH1rANqK2rFnzYBzbw9u9WPWj5At8=;
b=FJsoM969Fh78xU6SpjBQxzC2WiTfbku1m8KnjnVhzN8HHu3dvLlxZ1Zh5BRhtESs4MFM/f9Okn2s
38oZrzigKPyv1NVND7bPRHh/wyMJmGHvoT6d5z3QlHp7vbKm/dmYU4JIMZLalA6c86cmjT06SYyn
kN69oxLJ7Y9d/9s1MoyNCvFMXd70WkMPP0ST5qyqcTuNWGKFoJ6vC9H5oWxFPuDM+KenzvZbSNcr
JozRUPFdDXNL1SJRG7s2bFJ1U1dt7BNbdnmAsEpbW3h68idMgJ07WlSUtPUUs8LvWE4gj9koLrHG
7tZuh4dSAND2ux/DbGQUL32kgiwWocdd7PNb9Q==
From: Andrey Vatoropin <a.vatoropin@crpt.ru>
Static analysis shows that pointer "svms" cannot be NULL because it points
to the object "struct svm_range_list". Remove the extra NULL check. It is
meaningless and harms the readability of the code.
In the function svm_range_get_info() there is no possibility of failure.
Therefore, the caller of the function svm_range_get_info() does not need
a return value. Change the function svm_range_get_info() return type from
"int" to "void".=20
Since the function svm_range_get_info() has a return type of "void". The
caller of the function svm_range_get_info() does not need a return value.
Delete extra code.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
---
v1 -> v2: also change return type of svm_range_get_info() per Felix Kuehlin=
g suggestion
v2 -> v3: deleted extra code in the function kfd_criu_checkpoint_svm()
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 +---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 9 ++-------
drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 11 +++++------
3 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd=
/amdkfd/kfd_chardev.c
index 1e9dd00620bf..a2149afa5803 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -2039,9 +2039,7 @@ static int criu_get_process_object_info(struct kfd_pr=
ocess *p,
=20
num_events =3D kfd_get_num_events(p);
=20
- ret =3D svm_range_get_info(p, &num_svm_ranges, &svm_priv_data_size);
- if (ret)
- return ret;
+ svm_range_get_info(p, &num_svm_ranges, &svm_priv_data_size);
=20
*num_objects =3D num_queues + num_events + num_svm_ranges;
=20
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amd=
kfd/kfd_svm.c
index 100717a98ec1..ebdbbb620b11 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -4076,8 +4076,8 @@ int kfd_criu_restore_svm(struct kfd_process *p,
return ret;
}
=20
-int svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
- uint64_t *svm_priv_data_size)
+void svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
+ uint64_t *svm_priv_data_size)
{
uint64_t total_size, accessibility_size, common_attr_size;
int nattr_common =3D 4, nattr_accessibility =3D 1;
@@ -4089,8 +4089,6 @@ int svm_range_get_info(struct kfd_process *p, uint32_=
t *num_svm_ranges,
*svm_priv_data_size =3D 0;
=20
svms =3D &p->svms;
- if (!svms)
- return -EINVAL;
=20
mutex_lock(&svms->lock);
list_for_each_entry(prange, &svms->list, list) {
@@ -4132,7 +4130,6 @@ int svm_range_get_info(struct kfd_process *p, uint32_=
t *num_svm_ranges,
=20
pr_debug("num_svm_ranges %u total_priv_size %llu\n", *num_svm_ranges,
*svm_priv_data_size);
- return 0;
}
=20
int kfd_criu_checkpoint_svm(struct kfd_process *p,
@@ -4149,8 +4146,6 @@ int kfd_criu_checkpoint_svm(struct kfd_process *p,
struct mm_struct *mm;
=20
svms =3D &p->svms;
- if (!svms)
- return -EINVAL;
=20
mm =3D get_task_mm(p->lead_thread);
if (!mm) {
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.h b/drivers/gpu/drm/amd/amd=
kfd/kfd_svm.h
index 6ea23c78009c..01c7a4877904 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
@@ -184,8 +184,8 @@ void schedule_deferred_list_work(struct svm_range_list =
*svms);
void svm_range_dma_unmap_dev(struct device *dev, dma_addr_t *dma_addr,
unsigned long offset, unsigned long npages);
void svm_range_dma_unmap(struct svm_range *prange);
-int svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
- uint64_t *svm_priv_data_size);
+void svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
+ uint64_t *svm_priv_data_size);
int kfd_criu_checkpoint_svm(struct kfd_process *p,
uint8_t __user *user_priv_data,
uint64_t *priv_offset);
@@ -237,13 +237,12 @@ static inline int svm_range_schedule_evict_svm_bo(
return -EINVAL;
}
=20
-static inline int svm_range_get_info(struct kfd_process *p,
- uint32_t *num_svm_ranges,
- uint64_t *svm_priv_data_size)
+static inline void svm_range_get_info(struct kfd_process *p,
+ uint32_t *num_svm_ranges,
+ uint64_t *svm_priv_data_size)
{
*num_svm_ranges =3D 0;
*svm_priv_data_size =3D 0;
- return 0;
}
=20
static inline int kfd_criu_checkpoint_svm(struct kfd_process *p,
--=20
2.43.0