From nobody Thu Apr 10 23:42:16 2025 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63AD21DEFE1; Tue, 1 Apr 2025 13:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.216.63.40 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743512925; cv=none; b=Hd+AEF4mztIw8jccfBvJQASKVPay2hLAKiCh0OmHTYWuMVMZSgoCzC90I7ZoLSsnptE22mewUUYHpeEFwhJDrG+HycdLrVuX0soPFJYkTgIDuMPS5CvlRhg2cViEVicCEbQXAQ/zkgRsZ4mu1bwMkVypl0i5V30e4T84RrQaR9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743512925; c=relaxed/simple; bh=S+agUJgSrUzpGrHcbOgJHhEsC/kJDDEKzWcSrxXuDEg=; h=Date:Message-ID:In-Reply-To:References:Mime-Version:From:To:Cc: Subject:Content-Type; b=VNs/q3bpld0LdNK79XKpJTEiLubcRotYWeXjkaiLFXq3SQI8eOv/nFNNmPYZA9T0W66YsLVoj1X6AEqwDAuLK7oTW26iV7uV/5D4TJZu8psylvZLYr5Xv1+KO4ajYH0Juk4+n+DwpXig3s545yPeumEGSxfmk5HCCL5bfiqPh3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=63.216.63.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4ZRpGY23Wkz8R046; Tue, 1 Apr 2025 21:08:37 +0800 (CST) Received: from xaxapp05.zte.com.cn ([10.99.98.109]) by mse-fl1.zte.com.cn with SMTP id 531D8aVx051287; Tue, 1 Apr 2025 21:08:36 +0800 (+08) (envelope-from shao.mingyin@zte.com.cn) Received: from mapi (xaxapp02[null]) by mapi (Zmail) with MAPI id mid32; Tue, 1 Apr 2025 21:08:40 +0800 (CST) Date: Tue, 1 Apr 2025 21:08:40 +0800 (CST) X-Zmail-TransId: 2afa67ebe558030-12f2d X-Mailer: Zmail v1.0 Message-ID: <20250401210840146_IyrV3zlejzz3eAnDmMSB@zte.com.cn> In-Reply-To: <20250401210730615ULucEmQClX13Q7svZwHsD@zte.com.cn> References: 20250401210730615ULucEmQClX13Q7svZwHsD@zte.com.cn Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , , , , , , Subject: =?UTF-8?B?W1BBVENIIDEvM10gUkRNQS9jb3JlOiBDb252ZXJ0IHRvIHVzZSBFUlJfQ0FTVCgp?= X-MAIL: mse-fl1.zte.com.cn 531D8aVx051287 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 67EBE555.001/4ZRpGY23Wkz8R046 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li Haoran As opposed to open-code, using the ERR_CAST macro clearly indicates that this is a pointer to an error value and a type conversion was performed. Signed-off-by: Li Haoran Signed-off-by: Shao Mingyin --- drivers/infiniband/core/mad_rmpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/mad_rmpp.c b/drivers/infiniband/core/m= ad_rmpp.c index 8af0619a39cd..b4b10e8a6495 100644 --- a/drivers/infiniband/core/mad_rmpp.c +++ b/drivers/infiniband/core/mad_rmpp.c @@ -158,7 +158,7 @@ static struct ib_mad_send_buf *alloc_response_msg(struc= t ib_mad_agent *agent, ah =3D ib_create_ah_from_wc(agent->qp->pd, recv_wc->wc, recv_wc->recv_buf.grh, agent->port_num); if (IS_ERR(ah)) - return (void *) ah; + return ERR_CAST(ah); hdr_len =3D ib_get_mad_data_offset(recv_wc->recv_buf.mad->mad_hdr.mgmt_cl= ass); msg =3D ib_create_send_mad(agent, recv_wc->wc->src_qp, --=20 2.25.1 From nobody Thu Apr 10 23:42:16 2025 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8085F203711; Tue, 1 Apr 2025 13:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.216.63.40 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743512974; cv=none; b=mM19VQ4PjW0LdC1FttD0dtfMWz//j7CWmm12hTlXOm1O/nx6JJ72GF095r/GfCfvVQB5vkKTdpPJ6H+p/6nvgGkCjk4eeY0YCtjyVD+qouhet533ccnEUSM5JkzE9v9462QCKZMzrQCjn12NJirGf4iNhY22Cbs3I/ctKUd31vA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743512974; c=relaxed/simple; bh=YMnuogFThrQHE7n/MTT5sL09pZzfi6UQTqBGG6a+7zM=; h=Date:Message-ID:In-Reply-To:References:Mime-Version:From:To:Cc: Subject:Content-Type; b=VP7vZg+SjNy3dBPcMDCQOooHWVvLXNHHbZunaVUHP7HZnYZgXmcEr922w/j3p5Boam0+LGBaNAt79lXKciepGxNBXzTXr6PnxZIm8jPwfuLwh/W1Qcjir2H+/8w/CBfL5FL7mKLoy7bd1h3gRfekf2dYOa0pwn4uF98zCK6PT/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=63.216.63.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4ZRpHV3Yh0z8R03x; Tue, 1 Apr 2025 21:09:26 +0800 (CST) Received: from xaxapp04.zte.com.cn ([10.99.98.157]) by mse-fl1.zte.com.cn with SMTP id 531D9JMx051597; Tue, 1 Apr 2025 21:09:19 +0800 (+08) (envelope-from shao.mingyin@zte.com.cn) Received: from mapi (xaxapp05[null]) by mapi (Zmail) with MAPI id mid32; Tue, 1 Apr 2025 21:09:23 +0800 (CST) Date: Tue, 1 Apr 2025 21:09:23 +0800 (CST) X-Zmail-TransId: 2afc67ebe583ffffffffed1-12dcf X-Mailer: Zmail v1.0 Message-ID: <202504012109233981_YPVbd4wQzmAzP3tA5IG@zte.com.cn> In-Reply-To: <20250401210730615ULucEmQClX13Q7svZwHsD@zte.com.cn> References: 20250401210730615ULucEmQClX13Q7svZwHsD@zte.com.cn Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , , , , , , Subject: =?UTF-8?B?W1BBVENIIDIvM10gUkRNQS91dmVyYnM6IENvbnZlcnQgdG8gdXNlIEVSUl9DQVNUKCk=?= X-MAIL: mse-fl1.zte.com.cn 531D9JMx051597 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 67EBE586.000/4ZRpHV3Yh0z8R03x Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li Haoran As opposed to open-code, using the ERR_CAST macro clearly indicates that this is a pointer to an error value and a type conversion was performed. Signed-off-by: Li Haoran Signed-off-by: Shao Mingyin --- drivers/infiniband/core/uverbs_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core= /uverbs_cmd.c index 3c3bb670c805..bc9fe3ceca4d 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -193,7 +193,7 @@ _ib_uverbs_lookup_comp_file(s32 fd, struct uverbs_attr_= bundle *attrs) fd, attrs); if (IS_ERR(uobj)) - return (void *)uobj; + return ERR_CAST(uobj); uverbs_uobject_get(uobj); uobj_put_read(uobj); --=20 2.25.1 From nobody Thu Apr 10 23:42:16 2025 Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA51C2C6; Tue, 1 Apr 2025 13:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=183.62.165.209 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743513028; cv=none; b=JmOBBnkQfI9jFSMVaPVWfduLk0K/LueMPyZYZnf1joxvBuNLzKyK7G0pKQUBT4E1wy16NW7IeIM371uXPp9MbrAgrBqmXRHONMcByqqTLqPQ5iJMrzkqZ7sroHcCac5ucEbiKgM3eInRKgDE+3GhaKvAjfLx1lKaxnh6ul4yMBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743513028; c=relaxed/simple; bh=bZuhi5tp57vT1KrIZMO2TFV5Dty6u7hau5PtT9IEqvc=; h=Date:Message-ID:In-Reply-To:References:Mime-Version:From:To:Cc: Subject:Content-Type; b=AFWQfbI3JX2X5Y4Al3B7t+BIYXfQeZUfusBjPW/rFstkiM/eG3NldPVWRYK5hVxBZLcdbDJ1i23bua5jf3/iRUGqUrbn8RCeRc6GD0vbD74Y445rUcyBu7zw92/howFg6VHAWEiOr0tYxfH4V2IS7o3S3nEwA0N79xuYTWISLWs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=183.62.165.209 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4ZRpJW1cMZz501bv; Tue, 1 Apr 2025 21:10:19 +0800 (CST) Received: from xaxapp02.zte.com.cn ([10.88.97.241]) by mse-fl1.zte.com.cn with SMTP id 531DABTE052557; Tue, 1 Apr 2025 21:10:11 +0800 (+08) (envelope-from shao.mingyin@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid32; Tue, 1 Apr 2025 21:10:15 +0800 (CST) Date: Tue, 1 Apr 2025 21:10:15 +0800 (CST) X-Zmail-TransId: 2af967ebe5b7478-18370 X-Mailer: Zmail v1.0 Message-ID: <20250401211015750qxOfU9XZ8QgKizM1Lcyq2@zte.com.cn> In-Reply-To: <20250401210730615ULucEmQClX13Q7svZwHsD@zte.com.cn> References: 20250401210730615ULucEmQClX13Q7svZwHsD@zte.com.cn Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , , , , , , Subject: =?UTF-8?B?W1BBVENIIDMvM10gUkRNQS9jb3JlOiBDb252ZXJ0IHRvIHVzZSBFUlJfQ0FTVCgp?= X-MAIL: mse-fl1.zte.com.cn 531DABTE052557 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 67EBE5BB.000/4ZRpJW1cMZz501bv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li Haoran As opposed to open-code, using the ERR_CAST macro clearly indicates that this is a pointer to an error value and a type conversion was performed. Signed-off-by: Li Haoran Signed-off-by: Shao Mingyin --- drivers/infiniband/core/verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verb= s.c index c5e78bbefbd0..75fde0fe9989 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -572,7 +572,7 @@ struct ib_ah *rdma_create_ah(struct ib_pd *pd, struct r= dma_ah_attr *ah_attr, GFP_KERNEL : GFP_ATOMIC); if (IS_ERR(slave)) { rdma_unfill_sgid_attr(ah_attr, old_sgid_attr); - return (void *)slave; + return ERR_CAST(slave); } ah =3D _rdma_create_ah(pd, ah_attr, flags, NULL, slave); rdma_lag_put_ah_roce_slave(slave); --=20 2.25.1