From nobody Mon Feb 9 09:40:10 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B4B21577D for ; Tue, 1 Apr 2025 18:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531889; cv=none; b=KKKhbUawoFKk+sxUOygcD4zcdlU/BO66+MUTsRMkwbw/ApKVWLnTM41+pwyynzsjqeuOsPPs7Qm07hexcEBt+w7yXSngfz/mOzZL11OXdoqwDrlId4x1sTAe7o/Tb26RFssFZHZejuFgftjC3XelGSVpMtgKfNZlx89UN3+g3Mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531889; c=relaxed/simple; bh=bs+hau3BfGPgjfML6AAaTQNI5hHZ1yXB3kHmZBCp/iY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=DgQhnRVg8vLrdmysN3KtNKyIUsLABUh4tg4i7o8DcQkm2VuM2pu8foFswROzzjs06rl4aIs6NmJVFRO+XJcuxekUYvHsZbG1D4udUrxvdrw9vu/kuZbeRlbw9TzJHUf6ltUN1iCVzUBOD8BeLtK3SZ8dgY+6QKUNT4dcI8pXdAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=sBpfMxEw; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sBpfMxEw" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2262051205aso84426935ad.3 for ; Tue, 01 Apr 2025 11:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743531887; x=1744136687; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Lwp5jWQnZd0R1nLl4eHrnW+r9QoCXnSEZWGom8Yr2/Q=; b=sBpfMxEwfd1NRT+Y+pAIN3UbmexwO1YefWWSh6dzfKVBdfH5ho7RwVChIKFABnWzpV f0kA0ctbdxzXjbbYXrKxo2YH7+f0TbTars33RzFp9CuhFPHP58ZH3SMrPRbouO6WL4yt /C7zqzT0PoLLZ1DHYDhpeoM7UTK3R4OIoaP3leNYewwzTeq1xGkPB5AOHJo8KBt6ESZo 7bMm9COb95W3S3ocqLz/7ajttBHVcLL/+YiCKWB8nugLX8vtTs2eB7k4YD0kHjB54/lB V5nIPTDkJCy2XTo8uOfJkNaw23sTIkITp2yGq6DyCYs+k2RK01b0opXJUtCp2qCHirDI cxVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743531887; x=1744136687; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lwp5jWQnZd0R1nLl4eHrnW+r9QoCXnSEZWGom8Yr2/Q=; b=CXAn+M3gjGiyWvtmyuQsJmymc3TBMDw0TYLPqp7vShIWhZnKG5BOfoIjGspUZCT4ML 7yMmCeCDaeTVcd+esA2brtZomvS5mDH8WWlcFAUMXkV80kkVkHjXc3RzooXz5tl6Y6TW hqUC/P747thrGYwE7I5ummTZqknhCVdhIbybthY3AGI4sSP3Yga7cNtzKOAY7Z08PJhp nzDaaTSiyYYGN4nGV4ZMM/lCVCF2Y8DxEbprHl4CL8SombWkdjCXpxn+A5SvHWyta0Gc F++ap/1Rn8DyQkcxwGs0tWgvX+6n10Ubigx6gIBiuc8iIPWUo/bZRCFM7BtF2pznCXse enWg== X-Forwarded-Encrypted: i=1; AJvYcCWh2S85YtymNGlIXeiq5EI9KEFanAN8kcPX0/pvrYpI3EVDgCho83r7EDmD80CJj7mCin3nmR+iv+JzYaU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7ivVyBt3JemDjLU4a188Y88/63IvO6QCR8CYbFsHsr/kZLoTp 2AdNm1M6p2L0MA/K5KDmOJZS0itbdR9p1bIG+TmFvTbvWA4ZZWzJAbXNcO62Gtn5TD9dLRtGaaV trQ/jcg== X-Google-Smtp-Source: AGHT+IFzLtYxGxyTxV1rkwdh9UBSEEBVvK00y1AbRI2exTnDGJCaOS8iSdXoMves7V2W+aK2MyJ5/OHSrlvi X-Received: from plbbh9.prod.google.com ([2002:a17:902:a989:b0:223:49f0:9077]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d54f:b0:224:584:6f07 with SMTP id d9443c01a7336-2292f9e63damr210311785ad.37.1743531886714; Tue, 01 Apr 2025 11:24:46 -0700 (PDT) Date: Tue, 1 Apr 2025 11:23:03 -0700 In-Reply-To: <20250401182347.3422199-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250401182347.3422199-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250401182347.3422199-6-irogers@google.com> Subject: [PATCH v1 05/48] tools lib: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Yury Norov , Rasmus Villemoes , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/lib/api/fs/fs.c | 4 ++-- tools/lib/bitmap.c | 2 +- tools/lib/string.c | 6 +++--- tools/lib/vsprintf.c | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c index edec23406dbc..2c4677901de9 100644 --- a/tools/lib/api/fs/fs.c +++ b/tools/lib/api/fs/fs.c @@ -349,7 +349,7 @@ int filename__read_str(const char *filename, char **buf= , size_t *sizep) { struct io io; char bf[128]; - int err; + ssize_t err; =20 io.fd =3D open(filename, O_RDONLY); if (io.fd < 0) @@ -363,7 +363,7 @@ int filename__read_str(const char *filename, char **buf= , size_t *sizep) } else err =3D 0; close(io.fd); - return err; + return (int)err; } =20 int filename__write_int(const char *filename, int value) diff --git a/tools/lib/bitmap.c b/tools/lib/bitmap.c index 2178862bb114..87bd15e3968e 100644 --- a/tools/lib/bitmap.c +++ b/tools/lib/bitmap.c @@ -32,7 +32,7 @@ size_t bitmap_scnprintf(unsigned long *bitmap, unsigned i= nt nbits, char *buf, size_t size) { /* current bit is 'cur', most recently seen range is [rbot, rtop] */ - unsigned int cur, rbot, rtop; + size_t cur, rbot, rtop; bool first =3D true; size_t ret =3D 0; =20 diff --git a/tools/lib/string.c b/tools/lib/string.c index 3126d2cff716..638e75b63538 100644 --- a/tools/lib/string.c +++ b/tools/lib/string.c @@ -182,7 +182,7 @@ char *strreplace(char *s, char old, char new) return s; } =20 -static void *check_bytes8(const u8 *start, u8 value, unsigned int bytes) +static void *check_bytes8(const u8 *start, u8 value, size_t bytes) { while (bytes) { if (*start !=3D value) @@ -206,7 +206,7 @@ void *memchr_inv(const void *start, int c, size_t bytes) { u8 value =3D c; u64 value64; - unsigned int words, prefix; + size_t words, prefix; =20 if (bytes <=3D 16) return check_bytes8(start, value, bytes); @@ -216,7 +216,7 @@ void *memchr_inv(const void *start, int c, size_t bytes) value64 |=3D value64 << 16; value64 |=3D value64 << 32; =20 - prefix =3D (unsigned long)start % 8; + prefix =3D (size_t)start % 8; if (prefix) { u8 *r; =20 diff --git a/tools/lib/vsprintf.c b/tools/lib/vsprintf.c index 8780b4cdab21..62028a5eea7e 100644 --- a/tools/lib/vsprintf.c +++ b/tools/lib/vsprintf.c @@ -8,7 +8,7 @@ int vscnprintf(char *buf, size_t size, const char *fmt, va_= list args) int i =3D vsnprintf(buf, size, fmt, args); ssize_t ssize =3D size; =20 - return (i >=3D ssize) ? (ssize - 1) : i; + return (i >=3D ssize) ? (int)(ssize - 1) : i; } =20 int scnprintf(char * buf, size_t size, const char * fmt, ...) @@ -21,7 +21,7 @@ int scnprintf(char * buf, size_t size, const char * fmt, = ...) i =3D vsnprintf(buf, size, fmt, args); va_end(args); =20 - return (i >=3D ssize) ? (ssize - 1) : i; + return (i >=3D ssize) ? (int)(ssize - 1) : i; } =20 int scnprintf_pad(char * buf, size_t size, const char * fmt, ...) @@ -40,5 +40,5 @@ int scnprintf_pad(char * buf, size_t size, const char * f= mt, ...) buf[i] =3D 0x0; } =20 - return (i >=3D ssize) ? (ssize - 1) : i; + return (i >=3D ssize) ? (int)(ssize - 1) : i; } --=20 2.49.0.504.g3bcea36a83-goog