From nobody Sun May 11 11:16:53 2025
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C61D202965;
Tue, 1 Apr 2025 12:18:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=192.198.163.7
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743509935; cv=none;
b=IL9SwfR5AZULaJoi0FLDD0klVyKkPmuiwhbspZMwm/voWyHKuExf5cZ6p4fq2cKockB3rzXGsZBT4W8kJmpc0UIeFTTVrZcgKvnNQBUMnwFl0L0rlVds0s+0a+bruLYmq8LXiZ7AdCsR5sozm1qikA7CwkUHeCgdZ5jMAp4+KMM=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743509935; c=relaxed/simple;
bh=qMks4yyxcsdFFFFIp4ZE81kxinfaQlXtFyDSszriyh8=;
h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:
MIME-Version;
b=sBa+tkuWw/QZBte0fvjvVmc7Vrfnae0A/LisIbbVUXcOVnThPXtNA7T2Fh/MP/Fh485ioRrk1SQegAFubd9wcpjb3caX6RlEJPHrJDTDPaMECR3hRp5O3LJqlG5bTs33N6l3nHh6dxowZmyDyBqP0zO/88KIXtViltA6t6w/Ztk=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com;
spf=pass smtp.mailfrom=intel.com;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b=UaIexSN6; arc=none smtp.client-ip=192.198.163.7
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=intel.com
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b="UaIexSN6"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1743509933; x=1775045933;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=qMks4yyxcsdFFFFIp4ZE81kxinfaQlXtFyDSszriyh8=;
b=UaIexSN6OeOWsIR56cs7Zmb+0+uYN55BbxyqmByUZ8HV5Jvyoxz2jje8
TkYCrcOOPdTqUSCuaYfWxOgdskNNdt4gnfNqTHJy4tBoH4A5raiOioclc
aEa3AwL1S/Y82GDfNMSI3vSvD8mvNH2aXM5B5bYZgcWaAFWJ6986Bg7Xd
GJDhGZGItw9RZXXTt9uQQ5mg5tAFCe81y+zcaIKiejP0KA36XhF76Ra4u
BVhClXqyR52kD19yrm3gGwgTT9v9FBjdsJy8Lkp4Nz3yI70TJeg0C2CAH
nugIwna6/Z8sfIArXQZqfcbPOxmZfKNf42l2z0uB0MzPX4t9kL1jWW+7I
w==;
X-CSE-ConnectionGUID: hJyn4n5QSKGIIvesj7nO+Q==
X-CSE-MsgGUID: j/gxMD51TMiIXM6K16fl3Q==
X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="70186945"
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="70186945"
Received: from orviesa004.jf.intel.com ([10.64.159.144])
by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:18:53 -0700
X-CSE-ConnectionGUID: FLKO6xFIRkSTSCD4li7oKw==
X-CSE-MsgGUID: /zPIWQYITWqWdiJYY+cBCA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="131373417"
Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost)
([10.245.246.7])
by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:18:49 -0700
From: Jani Nikula <jani.nikula@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: jani.nikula@intel.com,
Masahiro Yamada <masahiroy@kernel.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kbuild@vger.kernel.org,
dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/5] drm: place header test files in .hdrtest subdirectories
Date: Tue, 1 Apr 2025 15:18:26 +0300
Message-Id: <20250401121830.21696-2-jani.nikula@intel.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250401121830.21696-1-jani.nikula@intel.com>
References: <20250401121830.21696-1-jani.nikula@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
The header tests track whether headers have been checked using empty
*.hdrtest files in the build tree. This pollutes the build directories,
as the files live in the same "name space" as the real output files,
messing with TAB completion among other things.
Hide the disgusting turds by placing them in .hdrtest subdirectories.
Change the quiet command output to simply $< instead of trying to decode
roughly the same from the increasingly complicated $@.
Note that it would be somewhat nicer to have the basename of the
.hdrtest files be dot-prefixed instead of using subdirectories. However,
it's challenging to come up with a pattern rule for that, as we can list
headers to test in the subdirectories of $(src) too, without requiring
Makefiles and kbuild to descend to each of them.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/r/CAHk-=3DwjMrqzuUmH-mFbR_46EWEFS=3DbB=3DJ7=
h9ABMVy56Vi81PKQ@mail.gmail.com
Fixes: 62ae45687e43 ("drm: ensure drm headers are self-contained and pass k=
ernel-doc")
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Cc: linux-kbuild@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/Makefile | 6 +++---
include/drm/Makefile | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index ed54a546bbe2..1666ea55bd24 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -230,14 +230,14 @@ hdrtest-files :=3D \
$(shell cd $(src) && find display lib -name '*.h')
=20
always-$(CONFIG_DRM_HEADER_TEST) +=3D \
- $(patsubst %.h,%.hdrtest, $(hdrtest-files))
+ $(patsubst %.h,.hdrtest/%.hdrtest, $(hdrtest-files))
=20
# Include the header twice to detect missing include guard.
-quiet_cmd_hdrtest =3D HDRTEST $(patsubst %.hdrtest,%.h,$@)
+quiet_cmd_hdrtest =3D HDRTEST $<
cmd_hdrtest =3D \
$(CC) $(c_flags) -fsyntax-only -x c /dev/null -include $< -include $<; \
$(srctree)/scripts/kernel-doc -none $(if $(CONFIG_WERROR)$(CONFIG_DRM_WE=
RROR),-Werror) $<; \
touch $@
=20
-$(obj)/%.hdrtest: $(src)/%.h FORCE
+$(obj)/.hdrtest/%.hdrtest: $(src)/%.h FORCE
$(call if_changed_dep,hdrtest)
diff --git a/include/drm/Makefile b/include/drm/Makefile
index a7bd15d2803e..a7593987909b 100644
--- a/include/drm/Makefile
+++ b/include/drm/Makefile
@@ -5,14 +5,14 @@ hdrtest-files :=3D \
$(shell cd $(src) && find * -name '*.h' 2>/dev/null)
=20
always-$(CONFIG_DRM_HEADER_TEST) +=3D \
- $(patsubst %.h,%.hdrtest, $(hdrtest-files))
+ $(patsubst %.h,.hdrtest/%.hdrtest, $(hdrtest-files))
=20
# Include the header twice to detect missing include guard.
-quiet_cmd_hdrtest =3D HDRTEST $(patsubst %.hdrtest,%.h,$@)
+quiet_cmd_hdrtest =3D HDRTEST $<
cmd_hdrtest =3D \
$(CC) $(c_flags) -fsyntax-only -x c /dev/null -include $< -include $<; \
$(srctree)/scripts/kernel-doc -none $(if $(CONFIG_WERROR)$(CONFIG_DRM_WE=
RROR),-Werror) $<; \
touch $@
=20
-$(obj)/%.hdrtest: $(src)/%.h FORCE
+$(obj)/.hdrtest/%.hdrtest: $(src)/%.h FORCE
$(call if_changed_dep,hdrtest)
--=20
2.39.5
From nobody Sun May 11 11:16:53 2025
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E185202965;
Tue, 1 Apr 2025 12:19:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=192.198.163.7
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743509942; cv=none;
b=P4+bXO1kWAGpy93VJhuv6ZFvS8frrxm9ZDGlPj6+1b58CgDXlXNY/ni0ox9UeL+tBCzUpnoC5RlB4zaqqO7CMQEkAzlUQHgGc9580VYRgDBql4G8/GnniaOlHgGpfe5e+nzhGYV3JkGKb8P9E2MxuVov6pIHM+T5OC7vgaTBBw8=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743509942; c=relaxed/simple;
bh=jT6ExL+POLRIZkDCDeOJqvP819AIWXO6Td1/S/GF2sE=;
h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:
MIME-Version;
b=W0odqNivQEFAkOrqL8zJo8Jdb0xRHg/XeIcygU2JpYzwqZAqKFK0gJMAKTrMJq6k4o0tr9FmJUmIV2a0GhDshPK4HZ+NYHJ2wQ7fttDZSGKt4cv09HpKVFAsM+y6nNaVzvkso+7sNQSSQfS3CiER4OQovzF3DD9DeE3b7s2uImA=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com;
spf=pass smtp.mailfrom=intel.com;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b=e96vg1qO; arc=none smtp.client-ip=192.198.163.7
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=intel.com
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b="e96vg1qO"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1743509940; x=1775045940;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=jT6ExL+POLRIZkDCDeOJqvP819AIWXO6Td1/S/GF2sE=;
b=e96vg1qOnf+yI08bnplalZT5109ylK+NHpEgbclOLcYu+xFzKooLupgj
D3gzRC7tGTjd56ZVvKTg5QvnIOpILeDfhgGHzH6zr4OWCwcT4nB0+58QD
WMi1e4j8ZZV1MTE1EMJaxohYXNkvWmmWog//J8Kd22jicHT24cc6lEbVi
g8OQ03V3wFnl0WqmaTw/pivypKQzVnwoECoLySwH1tRESQDqN4tj6izLR
I0LVbzU2KSfas4CIRwKzAQAQiR5UkZqJzT/IN9I4Ag7iRI+N+ew9LWktq
VzUD+ZUtcOl+jHXs0YDGKP/xLnNZdKp0+sjz+MESC/o2FKh8jHaPLit4w
A==;
X-CSE-ConnectionGUID: 7RlreNkMRUWBb9AjImlOyQ==
X-CSE-MsgGUID: ZtRMCsfHTQmnFVWGcl0UDw==
X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="70186971"
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="70186971"
Received: from orviesa004.jf.intel.com ([10.64.159.144])
by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:19:00 -0700
X-CSE-ConnectionGUID: 2eNsLzwHTH2xvgeR6joxnA==
X-CSE-MsgGUID: 0OVOkFVaQSKzuJtY65XBNw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="131373437"
Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost)
([10.245.246.7])
by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:18:56 -0700
From: Jani Nikula <jani.nikula@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: jani.nikula@intel.com,
Lucas De Marchi <lucas.demarchi@intel.com>,
Masahiro Yamada <masahiroy@kernel.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kbuild@vger.kernel.org,
dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/5] drm/xe: place header test files in .hdrtest
subdirectories
Date: Tue, 1 Apr 2025 15:18:27 +0300
Message-Id: <20250401121830.21696-3-jani.nikula@intel.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250401121830.21696-1-jani.nikula@intel.com>
References: <20250401121830.21696-1-jani.nikula@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
The header tests track whether headers have been checked using empty
*.hdrtest files in the build tree. This pollutes the build directories,
as the files live in the same "name space" as the real output files,
messing with TAB completion among other things.
Hide the disgusting turds by placing them in .hdrtest subdirectories.
Change the quiet command output to simply $< instead of trying to decode
roughly the same from the increasingly complicated $@.
Note that it would be somewhat nicer to have the basename of the
.hdrtest files be dot-prefixed instead of using subdirectories. However,
it's challenging to come up with a pattern rule for that, as we can list
headers to test in the subdirectories of $(src) too, without requiring
Makefiles and kbuild to descend to each of them.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/r/CAHk-=3DwjMrqzuUmH-mFbR_46EWEFS=3DbB=3DJ7=
h9ABMVy56Vi81PKQ@mail.gmail.com
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Cc: linux-kbuild@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/xe/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 9699b08585f7..2029c3b5aa5c 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -327,12 +327,12 @@ ifneq ($(CONFIG_DRM_XE_DISPLAY),y)
endif
=20
always-$(CONFIG_DRM_XE_WERROR) +=3D \
- $(patsubst %.h,%.hdrtest, $(shell cd $(src) && find * -name '*.h' $(hdrte=
st_find_args)))
+ $(patsubst %.h,.hdrtest/%.hdrtest, $(shell cd $(src) && find * -name '*.h=
' $(hdrtest_find_args)))
=20
-quiet_cmd_hdrtest =3D HDRTEST $(patsubst %.hdrtest,%.h,$@)
+quiet_cmd_hdrtest =3D HDRTEST $<
cmd_hdrtest =3D $(CC) -DHDRTEST $(filter-out $(CFLAGS_GCOV), $(c_fla=
gs)) -S -o /dev/null -x c /dev/null -include $<; touch $@
=20
-$(obj)/%.hdrtest: $(src)/%.h FORCE
+$(obj)/.hdrtest/%.hdrtest: $(src)/%.h FORCE
$(call if_changed_dep,hdrtest)
=20
uses_generated_oob :=3D $(addprefix $(obj)/, $(xe-y))
--=20
2.39.5
From nobody Sun May 11 11:16:53 2025
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26570202965;
Tue, 1 Apr 2025 12:19:07 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=192.198.163.7
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743509948; cv=none;
b=J/QVsjESppwniCwi6jEwDz+ZX/j/9n6QPEY0CA6pTsPkClOgJXuuaGlY2qyAEuGAdb8w0sWaei66gQiEBEByutvoi2QQA3QcFP+Rlg4efQIabluHG6TLTHGh62UdrZUfopHCy/W+8MAkW5rfJA4HBtFBqMhY9sjVQfpeic0GvxM=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743509948; c=relaxed/simple;
bh=kqy+pDKqPTt6DnS1U2G2+KSZGBj9TgpE+/PhWyhKPZM=;
h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:
MIME-Version;
b=NBZzUmei/onBitYb0BvbchK51ILbmrwJFW62Lyawhmre5hPd8+UeFuZiP8bEiTOkUmVpT7G1Fl2QkXh+xZoUGjAl8mVDgB943lzoPaJtDN+l1yGhMbB5305xa3Lj455lY1tVvtAZmLfuuojEggqlIpni7i1dsDmzKQHIf8gMnT4=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com;
spf=pass smtp.mailfrom=intel.com;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b=H3Mwxk9q; arc=none smtp.client-ip=192.198.163.7
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=intel.com
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b="H3Mwxk9q"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1743509947; x=1775045947;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=kqy+pDKqPTt6DnS1U2G2+KSZGBj9TgpE+/PhWyhKPZM=;
b=H3Mwxk9qS998qpX3wwlohRO9JQDJr0nBzMR7x/LrojsPnRb4EZBj1yf2
Q1gTKBHJrw6zw0xKWhEWMX7iWN2GEjZP9wtTsEK+RZipP6lxdehgYEJaR
WLZbu2lmb/KkdX62/plS+Gr6XLRoHg13Ja1eSTx81LjMlSYWEsZp24P5m
9DJUVM/qS3iX+FVi47Il85UGk3kpDjhPaqJ2ZmRPMhRjDMZI852WhS1pl
JMBNBCTCClNVdditQrelz2pKCF3B56+K3UHeQ3XZH27pKr0IeXC2KSnTo
W521ZXxxrrzXxNV4IITlvaIes0uNzUAbWeocM+aVtl2EvyhrXrDgBYJkh
Q==;
X-CSE-ConnectionGUID: AibCOSZdQh2r9PMzJeXE3Q==
X-CSE-MsgGUID: EWxy3LR1RQyk9OF6/v0FCw==
X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="70186980"
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="70186980"
Received: from orviesa004.jf.intel.com ([10.64.159.144])
by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:19:07 -0700
X-CSE-ConnectionGUID: ZEI6qYuTQtOOhUT4okRwJQ==
X-CSE-MsgGUID: qydX8mSjSjyTNh1ep3pLzQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="131373448"
Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost)
([10.245.246.7])
by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:19:03 -0700
From: Jani Nikula <jani.nikula@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: jani.nikula@intel.com,
Masahiro Yamada <masahiroy@kernel.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kbuild@vger.kernel.org,
dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/5] drm/i915: place header test files in .hdrtest
subdirectories
Date: Tue, 1 Apr 2025 15:18:28 +0300
Message-Id: <20250401121830.21696-4-jani.nikula@intel.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250401121830.21696-1-jani.nikula@intel.com>
References: <20250401121830.21696-1-jani.nikula@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
The header tests track whether headers have been checked using empty
*.hdrtest files in the build tree. This pollutes the build directories,
as the files live in the same "name space" as the real output files,
messing with TAB completion among other things.
Hide the disgusting turds by placing them in .hdrtest subdirectories.
Change the quiet command output to simply $< instead of trying to decode
roughly the same from the increasingly complicated $@.
Note that it would be somewhat nicer to have the basename of the
.hdrtest files be dot-prefixed instead of using subdirectories. However,
it's challenging to come up with a pattern rule for that, as we can list
headers to test in the subdirectories of $(src) too, without requiring
Makefiles and kbuild to descend to each of them.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/r/CAHk-=3DwjMrqzuUmH-mFbR_46EWEFS=3DbB=3DJ7=
h9ABMVy56Vi81PKQ@mail.gmail.com
Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Cc: linux-kbuild@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/i915/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index ed05b131ed3a..a8ffe5c74962 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -418,12 +418,12 @@ no-header-test :=3D \
display/intel_vbt_defs.h
=20
always-$(CONFIG_DRM_I915_WERROR) +=3D \
- $(patsubst %.h,%.hdrtest, $(filter-out $(no-header-test), \
+ $(patsubst %.h,.hdrtest/%.hdrtest, $(filter-out $(no-header-test), \
$(shell cd $(src) && find * -name '*.h')))
=20
-quiet_cmd_hdrtest =3D HDRTEST $(patsubst %.hdrtest,%.h,$@)
+quiet_cmd_hdrtest =3D HDRTEST $<
cmd_hdrtest =3D $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o=
/dev/null -x c /dev/null -include $<; \
$(srctree)/scripts/kernel-doc -none -Werror $<; touch $@
=20
-$(obj)/%.hdrtest: $(src)/%.h FORCE
+$(obj)/.hdrtest/%.hdrtest: $(src)/%.h FORCE
$(call if_changed_dep,hdrtest)
--=20
2.39.5
From nobody Sun May 11 11:16:53 2025
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3A47202C43;
Tue, 1 Apr 2025 12:19:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=198.175.65.18
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743509955; cv=none;
b=E58RnALWqRUddpM2QORb4v59W3JN8paoayDFlA1PcDBI56h8w2coUy465DbBt3dtyfdij9V5Vyi5LhNvG9moojS9kLKeCThAi1lFSn/ql2LcpRGWCaQhUJ8bRI0SzgmwhbV7qxkbre6UeN8PFqDqWu+mE9oxovJ0V9Kq/KT18wM=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743509955; c=relaxed/simple;
bh=TFzN17CpzAgXFVrWu0W8hh/yV1WzMbFtltLzk/8/ZTQ=;
h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:
MIME-Version;
b=fyeWQFPRKk/SKC2uij+mfHqppz8NS3Qg57KcRZnubv4GmD0DktvbIjqqbbAu/1nAl7iR++20lju/OA/pNOE9Es7ymfH5ycPhc5m00NRMtWp8taDgUdqFSJEoq04lk8NaJYItaNtctUqCo4g+g8mMOFzve45AhIX+8na/kU6NY0k=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com;
spf=pass smtp.mailfrom=intel.com;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b=lcIqLApK; arc=none smtp.client-ip=198.175.65.18
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=intel.com
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b="lcIqLApK"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1743509954; x=1775045954;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=TFzN17CpzAgXFVrWu0W8hh/yV1WzMbFtltLzk/8/ZTQ=;
b=lcIqLApKKmK0Z5o4jOXwd7flIhTmcIC6dSum4kbjVJt/UuLdwhIHY3gY
qBYs8+Gi5XnfJtoiLheJvuOp5tRCOPUhSu6R0KkmxRtzQXN3CSG4+NKdF
kOxOUQNSpGONoq5tKSqv7b/7Z5sZigytuaqR1NcVk5gnHq+SgbjpsI8Iz
Z1je3ZP+PjEmLgsW7he1Z3E7FyksIlZjyYOmQwrAWXuDXa7intVJU/lJe
BCom/HRvrRyGI3+jdglwH9/nKH0lfwuRiVE0TMv9THKKqmMfY3Mm0lcl8
hjMqbWIJVXcpT0R6bBOidvaLTRWZj5hd4aoxKTJfq7OX5wbPBh7QZZrgj
w==;
X-CSE-ConnectionGUID: mrKuhlYqQdaarQjWydBFMQ==
X-CSE-MsgGUID: SXXT1EB6SwWH/jv0WvI/yg==
X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="44981735"
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="44981735"
Received: from fmviesa001.fm.intel.com ([10.60.135.141])
by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:19:13 -0700
X-CSE-ConnectionGUID: uuGqDkIjS5imSGGyJCXT/A==
X-CSE-MsgGUID: QrIX/9gaTQGGnEU7Cm054Q==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="157365129"
Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost)
([10.245.246.7])
by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:19:10 -0700
From: Jani Nikula <jani.nikula@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: jani.nikula@intel.com,
Masahiro Yamada <masahiroy@kernel.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kbuild@vger.kernel.org,
dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/5] kbuild: hdrtest: place header test files in .hdrtest
subdirectories
Date: Tue, 1 Apr 2025 15:18:29 +0300
Message-Id: <20250401121830.21696-5-jani.nikula@intel.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250401121830.21696-1-jani.nikula@intel.com>
References: <20250401121830.21696-1-jani.nikula@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
The header tests track whether headers have been checked using empty
*.hdrtest files in the build tree. This pollutes the build directories,
as the files live in the same "name space" as the real output files,
messing with TAB completion among other things.
Hide the disgusting turds by placing them in .hdrtest subdirectories.
Note that it would be somewhat nicer to have the basename of the
.hdrtest files be dot-prefixed instead of using subdirectories. However,
it's challenging to come up with a pattern rule for that, as we can list
headers to test in the subdirectories of $(src) too, without requiring
Makefiles and kbuild to descend to each of them.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/r/CAHk-=3DwjMrqzuUmH-mFbR_46EWEFS=3DbB=3DJ7=
h9ABMVy56Vi81PKQ@mail.gmail.com
Fixes: fcbb8461fd23 ("kbuild: remove header compile test")
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Cc: linux-kbuild@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
---
usr/include/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/usr/include/Makefile b/usr/include/Makefile
index e3d6b03527fe..4fb574fd3fec 100644
--- a/usr/include/Makefile
+++ b/usr/include/Makefile
@@ -71,7 +71,7 @@ endif
# asm-generic/*.h is used by asm/*.h, and should not be included directly
no-header-test +=3D asm-generic/%
=20
-always-y :=3D $(patsubst $(obj)/%.h,%.hdrtest, $(shell find $(obj) -name '=
*.h' 2>/dev/null))
+always-y :=3D $(patsubst $(obj)/%.h,.hdrtest/%.hdrtest, $(shell find $(obj=
) -name '*.h' 2>/dev/null))
=20
# Include the header twice to detect missing include guard.
quiet_cmd_hdrtest =3D HDRTEST $<
@@ -81,7 +81,7 @@ quiet_cmd_hdrtest =3D HDRTEST $<
$(PERL) $(src)/headers_check.pl $(obj) $<; \
touch $@
=20
-$(obj)/%.hdrtest: $(obj)/%.h FORCE
+$(obj)/.hdrtest/%.hdrtest: $(obj)/%.h FORCE
$(call if_changed_dep,hdrtest)
=20
# Since GNU Make 4.3, $(patsubst $(obj)/%/,%,$(wildcard $(obj)/*/)) works.
--=20
2.39.5
From nobody Sun May 11 11:16:53 2025
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDE2A203703;
Tue, 1 Apr 2025 12:19:19 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=198.175.65.18
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743509961; cv=none;
b=SCh/IxsFiBLqnopHiBhXDYOKakBtAjfHWWnrzCWKfU2nkcILjTdj/A0OuUSrlEhPn4RD5x8E8PiKPiycdigpBepE87Qcqi5oco+1SNKJSegiEP12ln1jF/Kl40WqgC2q2K3rbPNI9GkGJGheEyHArXP+WxDCEuCvWEze2lQmH4M=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743509961; c=relaxed/simple;
bh=k+JFvSQ26FarxrRAOquTbPWkCD8Pzve2Gh9zf2uf7Ew=;
h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:
MIME-Version;
b=IOFKtBily58FAsPmyhcNVGkxevjbOl+sQWRYA9MhEw44E+QnyygYS4pOvO6DOTdrcpR1YWN7nwprAzeYrtO5DGrK/WEG4xjHmRVYkAv9dPSGvxzZOoLRxSOQnfxUWks2kalLkrEcAW3vs0qu2vcQuT+fBp00+hlRpHHfg8RlAAA=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com;
spf=pass smtp.mailfrom=intel.com;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b=jbX1VpJy; arc=none smtp.client-ip=198.175.65.18
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=intel.com
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com
header.b="jbX1VpJy"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1743509960; x=1775045960;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=k+JFvSQ26FarxrRAOquTbPWkCD8Pzve2Gh9zf2uf7Ew=;
b=jbX1VpJy3JZalOIPMZ67A88AXrC4zSXIw0WCCsV+MigyAVAtRAmzwObw
dO6eEyDy4M/C7IPtS+T4ysDSZ4UHU65sTA8KqvOPZk8KlyulBmL+rvfOT
k2wcr/Rfy1ilyFBT2Dg7sgupFvjjOcm5irmvETIMclu/hZuHwd9OSkrsw
ve7MaWvdlAbQCD2cfPpU1cAzCONKdnYkpxjFL3CGKnrToeIPm2nglXfLL
+u6fNXulV3Vq2wfh9QTfnaObbe1FZJBu6eiLW1axJy5fVkf0/k5uMBUQ7
117LWJZ7jXu2gkY30uzG2fzhgTBQUpeoUlC4T2XtAXBnos9BJTjeS9eNq
A==;
X-CSE-ConnectionGUID: XpDjFH4nT5aorGRAWtuzug==
X-CSE-MsgGUID: FqyWUx5CSCy3JFHZdm5Dzg==
X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="44981761"
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="44981761"
Received: from fmviesa001.fm.intel.com ([10.60.135.141])
by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:19:20 -0700
X-CSE-ConnectionGUID: O3fed8/ISRavwWB0+7AiGA==
X-CSE-MsgGUID: X3cpC3b2Skq3VReLpCGmUQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.14,293,1736841600";
d="scan'208";a="157365168"
Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost)
([10.245.246.7])
by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Apr 2025 05:19:16 -0700
From: Jani Nikula <jani.nikula@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: jani.nikula@intel.com,
Masahiro Yamada <masahiroy@kernel.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kbuild@vger.kernel.org,
dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: [PATCH 5/5] drm: add config option for extra build-time checks
Date: Tue, 1 Apr 2025 15:18:30 +0300
Message-Id: <20250401121830.21696-6-jani.nikula@intel.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250401121830.21696-1-jani.nikula@intel.com>
References: <20250401121830.21696-1-jani.nikula@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
The DRM subsystem contains additional build-time checks, primarily aimed
at DRM developers and CI systems. The checks may be overzealous. They
may slow down or fail the build altogether. They may create excessive
dependency files in the build tree. They should not be enabled for
regular builds, and certainly not forced on unsuspecting developers
running an allyesconfig or allmodconfig build.
Add config DRM_DISABLE_EXTRA_BUILD_CHECKS, enabled by default as well as
by allyesconfig/allmodconfig, hiding the extra checks from anyone but
people who intentionally opt-in for the checks.
For example, to enable header tests:
$ scripts/config --disable CONFIG_DRM_DISABLE_EXTRA_BUILD_CHECKS --enable C=
ONFIG_DRM_HEADER_TEST
$ make olddefconfig
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/r/CAHk-=3DwjcdfrDTjzm6J6T-3fxtVyBG7a_0BXc2=
=3DmgOuM6KPFnCg@mail.gmail.com
Fixes: 62ae45687e43 ("drm: ensure drm headers are self-contained and pass k=
ernel-doc")
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Cc: linux-kbuild@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/Kconfig | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 2cba2b6ebe1c..5a3fce9ef998 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -489,9 +489,26 @@ config DRM_PRIVACY_SCREEN
bool
default n
=20
+# Reversed option to disable on allyesconfig/allmodconfig builds
+config DRM_DISABLE_EXTRA_BUILD_CHECKS
+ bool "Disable DRM subsystem extra build-time checks"
+ default y
+ help
+ The DRM subsystem contains additional build-time checks, primarily
+ aimed at DRM developers and CI systems. The checks may be
+ overzealous. They may slow down or fail the build altogether. They may
+ create excessive dependency files in the tree. They should not be
+ enabled for regular builds, and thus they are disabled by default.
+
+# Proxy config to allow simple "depends on DRM_EXTRA_BUILD_CHECKS"
+config DRM_EXTRA_BUILD_CHECKS
+ bool
+ depends on DRM && EXPERT && DRM_DISABLE_EXTRA_BUILD_CHECKS=3Dn
+ default !DRM_DISABLE_EXTRA_BUILD_CHECKS
+
config DRM_WERROR
bool "Compile the drm subsystem with warnings as errors"
- depends on DRM && EXPERT
+ depends on DRM_EXTRA_BUILD_CHECKS
depends on !WERROR
default n
help
@@ -505,7 +522,7 @@ config DRM_WERROR
=20
config DRM_HEADER_TEST
bool "Ensure DRM headers are self-contained and pass kernel-doc"
- depends on DRM && EXPERT && BROKEN
+ depends on DRM_EXTRA_BUILD_CHECKS
default n
help
Ensure the DRM subsystem headers both under drivers/gpu/drm and
--=20
2.39.5