From nobody Fri Dec 19 19:57:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 516611DF987 for ; Mon, 31 Mar 2025 10:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417554; cv=none; b=RebXv1m2HvjYnvvr5SdbuI5k0BNe2wDTdHjHqaPy/64pe4u0ITAIacZajiY8hWbmevRiPOO2ZM74PTN55oMIFHRcgdO6/ogMBRmeyODf81HRbITdZPRdLLVyy7kM6bFMxgLAIHsOHrKjpIPJzC/9rK18t1EOFdvJktyftn7PON0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417554; c=relaxed/simple; bh=MzD9Ad6mK9r4fxgZHo9dfRHlp4OQUEWf4LOVIPBSNt4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VSqH401hd7/JGewqd+2RA3UracUCrPKBpADzbRtTC088OspTIocoraoldYrc2HSxeARJ2M3YvRMOCWl7zAl/8iQSsQHVzkmOUfIX5zLgBYxky8reJgRGs1uvfuOygKQ2SW8kmgmgqoAtYa3v+GU+dqF1QEWZuFK5Nc61aOYeIAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HPr1WDM/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HPr1WDM/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743417551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lpoVdmq8NVnUnZOD3EnO3m6uLwgKHTodPmRunL4I+rs=; b=HPr1WDM/coCSVfGej/elVwyS0P6GpDqh4w9vtSmxYrLPVqOTURVjg9th2iSOcwqXozwrZZ S2VokU4clg+EnN4C6ragDvJWHptjFf5TLqr12WSEuCCTKNUdxiZJC4CobUfRVHzx9pI1f0 5KoyqBp9uGtEXr9UVN52JMGB9b9hZRk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-y1eGEtc_PUKbkRIOXcwGHg-1; Mon, 31 Mar 2025 06:39:10 -0400 X-MC-Unique: y1eGEtc_PUKbkRIOXcwGHg-1 X-Mimecast-MFC-AGG-ID: y1eGEtc_PUKbkRIOXcwGHg_1743417549 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d007b2c79so35426825e9.2 for ; Mon, 31 Mar 2025 03:39:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743417549; x=1744022349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lpoVdmq8NVnUnZOD3EnO3m6uLwgKHTodPmRunL4I+rs=; b=A9Jx/KgR3ZBCs1BilkPe7Unk1THBfaN10OlnoEh482X1KbgTxRuWJYR/MM0c+05+n2 CXL6ube1CoVcChuw8ojXzUDQYsLN52rVztNcYH5wCFZpwFI9erhvx2kL0PZqRhajZ0jr QpzmW41GN75jj0BRbltIFIftaKetLDeap2JQhUUqCQpmyIxzx27piUkMtS5GRoVy/wBZ LNYHHIabKk07KP7UjPPcUQYnzYD9jM4Y1pXGlPAuBVyGivU6dLP5MFbk+EgMeL/j5PBY 247+UxCA13vMH+WQEg+woXBF2qRUw7lWENJ1s3FRh+NHuZlvwmcV05sqThK/TITUCYn8 ujUQ== X-Gm-Message-State: AOJu0Yx8tIbaizPbHP1F8E8/sPtuHF9t9R+wGf+dV9GyUlllnI3qaadP XJ4oJLjWnKJpHbXM2aOsep2sdVrrC6MVgLs5exIPPfO8AwG3CLZXJEguunVDqPVuUar55LUedYB yyXbudN7WsueT/UPJWUkbzmAHfhl7HovD8yYfG4nA2CE3F7ao9oEs9aDhilEwqw== X-Gm-Gg: ASbGncu0A8kfgD9/P0adkv+XMm9sisCoKot+m/tIiB1Xg0JhHg6c+/Ot9yY1uk4qAoi wnlG3v7R0m3w6MToQF1VyVg2IbJzr7hpmalvHpLkLV26MShZ5NJWWNS6DtqPbHcfr1tcW6qHHLY tATaqag4kH7Ew5QCN0q9AWZCJLxxlRspF4UR//CFY1dC9J9hkCqbEVe9PZjEP+g5aGUVK+9zXQY BP2BEbhRLogGHbTJiz2LHVTtKYT4UXLYrwuKzYY5LNcqwzj3R6RxEuo5a6iav5fBgCcIjnq/MBL uHSt+mYk6QHWOyQTEGgkeCe05R+xPgropAye6zESHeYrsc82afGWLwcezJ2ZS2tg2Q== X-Received: by 2002:a05:6000:1789:b0:39a:ca59:a61d with SMTP id ffacd0b85a97d-39c1211d6dfmr5299650f8f.47.1743417548866; Mon, 31 Mar 2025 03:39:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnDaOaSL/ZAtEwyINcAEfHHyImiDBDT1PrwoAIb4V41DPAx+sWTZRY3pHU+AggxpwblWc/Rg== X-Received: by 2002:a05:6000:1789:b0:39a:ca59:a61d with SMTP id ffacd0b85a97d-39c1211d6dfmr5299623f8f.47.1743417548376; Mon, 31 Mar 2025 03:39:08 -0700 (PDT) Received: from stex1.redhat.com (host-87-12-25-55.business.telecomitalia.it. [87.12.25.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d900008d8sm116115905e9.33.2025.03.31.03.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 03:39:07 -0700 (PDT) From: Stefano Garzarella To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , James Bottomley , Dave Hansen , Borislav Petkov , linux-integrity@vger.kernel.org, Peter Huewe , Ingo Molnar , linux-coco@lists.linux.dev, Dov Murik , Thomas Gleixner , Joerg Roedel , x86@kernel.org, Dionna Glaze , Tom Lendacky , Claudio Carvalho , "H. Peter Anvin" , Stefano Garzarella Subject: [PATCH v5 1/4] x86/sev: add SVSM vTPM probe/send_command functions Date: Mon, 31 Mar 2025 12:38:54 +0200 Message-ID: <20250331103900.92701-2-sgarzare@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250331103900.92701-1-sgarzare@redhat.com> References: <20250331103900.92701-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Stefano Garzarella Add two new functions to probe and send commands to the SVSM vTPM. They leverage the two calls defined by the AMD SVSM specification [1] for the vTPM protocol: SVSM_VTPM_QUERY and SVSM_VTPM_CMD. Expose these functions to be used by other modules such as a tpm driver. [1] "Secure VM Service Module for SEV-SNP Guests" Publication # 58019 Revision: 1.00 Co-developed-by: James Bottomley Signed-off-by: James Bottomley Co-developed-by: Claudio Carvalho Signed-off-by: Claudio Carvalho Reviewed-by: Tom Lendacky Reviewed-by: Jarkko Sakkinen Signed-off-by: Stefano Garzarella --- v5: - added stubs when !CONFIG_AMD_MEM_ENCRYPT [Dionna] - added Jarkko's R-b v4: - added Tom's R-b - added functions documentation [Jarkko] - simplified TPM_SEND_COMMAND check [Tom/Jarkko] v3: - removed link to the spec because those URLs are unstable [Borislav] - squashed "x86/sev: add SVSM call macros for the vTPM protocol" patch in this one [Borislav] - slimmed down snp_svsm_vtpm_probe() [Borislav] - removed features check and any print related [Tom] --- arch/x86/include/asm/sev.h | 9 ++++++ arch/x86/coco/sev/core.c | 59 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+) diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h index ba7999f66abe..ba7a0a327afb 100644 --- a/arch/x86/include/asm/sev.h +++ b/arch/x86/include/asm/sev.h @@ -384,6 +384,10 @@ struct svsm_call { #define SVSM_ATTEST_SERVICES 0 #define SVSM_ATTEST_SINGLE_SERVICE 1 =20 +#define SVSM_VTPM_CALL(x) ((2ULL << 32) | (x)) +#define SVSM_VTPM_QUERY 0 +#define SVSM_VTPM_CMD 1 + #ifdef CONFIG_AMD_MEM_ENCRYPT =20 extern u8 snp_vmpl; @@ -481,6 +485,9 @@ void snp_msg_free(struct snp_msg_desc *mdesc); int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req, struct snp_guest_request_ioctl *rio); =20 +bool snp_svsm_vtpm_probe(void); +int snp_svsm_vtpm_send_command(u8 *buffer); + void __init snp_secure_tsc_prepare(void); void __init snp_secure_tsc_init(void); =20 @@ -524,6 +531,8 @@ static inline struct snp_msg_desc *snp_msg_alloc(void) = { return NULL; } static inline void snp_msg_free(struct snp_msg_desc *mdesc) { } static inline int snp_send_guest_request(struct snp_msg_desc *mdesc, struc= t snp_guest_req *req, struct snp_guest_request_ioctl *rio) { return -ENODEV; } +static inline bool snp_svsm_vtpm_probe(void) { return false; } +static inline int snp_svsm_vtpm_send_command(u8 *buffer) { return -ENODEV;= } static inline void __init snp_secure_tsc_prepare(void) { } static inline void __init snp_secure_tsc_init(void) { } =20 diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index b0c1a7a57497..efb43c9d3d30 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2625,6 +2625,65 @@ static int snp_issue_guest_request(struct snp_guest_= req *req, struct snp_req_dat return ret; } =20 +/** + * snp_svsm_vtpm_probe() - Probe if SVSM provides a vTPM device + * + * This function checks that there is SVSM and that it supports at least + * TPM_SEND_COMMAND which is the only request we use so far. + * + * Return: true if the platform provides a vTPM SVSM device, false otherwi= se. + */ +bool snp_svsm_vtpm_probe(void) +{ + struct svsm_call call =3D {}; + + /* The vTPM device is available only if a SVSM is present */ + if (!snp_vmpl) + return false; + + call.caa =3D svsm_get_caa(); + call.rax =3D SVSM_VTPM_CALL(SVSM_VTPM_QUERY); + + if (svsm_perform_call_protocol(&call)) + return false; + + /* Check platform commands contains TPM_SEND_COMMAND - platform command 8= */ + return call.rcx_out & BIT_ULL(8); +} +EXPORT_SYMBOL_GPL(snp_svsm_vtpm_probe); + +/** + * snp_svsm_vtpm_send_command() - execute a vTPM operation on SVSM + * @buffer: A buffer used to both send the command and receive the respons= e. + * + * This function executes a SVSM_VTPM_CMD call as defined by + * "Secure VM Service Module for SEV-SNP Guests" Publication # 58019 Revis= ion: 1.00 + * + * All command request/response buffers have a common structure as specifi= ed by + * the following table: + * Byte Size =C2=A0=C2=A0 =C2=A0In/Out=C2=A0=C2=A0=C2=A0=C2=A0D= escription + * Offset=C2=A0=C2=A0=C2=A0=C2=A0(Bytes) + * 0x000=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0In=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0Platform command +=C2=A0*=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0Out=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Platform command respons= e size + * + * Each command can build upon this common request/response structure to c= reate + * a structure specific to the command. + * See include/linux/tpm_svsm.h for more details. + * + * Return: 0 on success, -errno on failure + */ +int snp_svsm_vtpm_send_command(u8 *buffer) +{ + struct svsm_call call =3D {}; + + call.caa =3D svsm_get_caa(); + call.rax =3D SVSM_VTPM_CALL(SVSM_VTPM_CMD); + call.rcx =3D __pa(buffer); + + return svsm_perform_call_protocol(&call); +} +EXPORT_SYMBOL_GPL(snp_svsm_vtpm_send_command); + static struct platform_device sev_guest_device =3D { .name =3D "sev-guest", .id =3D -1, --=20 2.49.0 From nobody Fri Dec 19 19:57:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27D71E1DF1 for ; Mon, 31 Mar 2025 10:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417558; cv=none; b=Xh8boP9TivqilyP+/4GvLyI/i0YXg0t68cNXZFlRgmEHiAc1es5P9pGULzrEnnUPJ5a/XRhqFuH3O9NPl4dWHnkIYcPDC3DUBpZuwNxliQvi/c26Y5Vwt10vzIhjsHN07s+y56uyIzVK6yItNuwPGDfViOvFxOuLxPcWpNL8sOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417558; c=relaxed/simple; bh=JanhuPR/iml68kEFk6VsdfPYwqYcdQYvtjajdTMi5bI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MuOLRL5mwV8PQT50JW8vqWKb/sOAfTe4siio5k1MGcHAcTg34BiGj9lr+bYfJLy82m9lo9wPJs4ZmiW69EAeZCIGNhLrMjcpxX2sLy7/7Kk2BwOgbTvznkFSNw4l8a0xiYsUBqR8+PsovGl6YxXkjgQW6MlzIGnlMi4oGM9vapg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fIshL1yd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fIshL1yd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743417555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cwx8PB++1jPTpqj+0lA5MhEHp2F2B5hQ/5H2FoJu9E=; b=fIshL1ydBeFVhdgGMTrAn2kTMKgniTv1/mSILZAoJCxIDlyDc0LQ+hmLuwzRkxrkVrpQCA HmB5mzDT61yFJjPDPx9m8WhFy+UyFqGXQYwqMxXIASdxCcMMwone4XyrntMH0yy8vvzmEE syPrpWCt7sf1iSlNMDMbdYzDa0mtWVQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-NyPLrLj1PvC_wh9Xz4wsiw-1; Mon, 31 Mar 2025 06:39:14 -0400 X-MC-Unique: NyPLrLj1PvC_wh9Xz4wsiw-1 X-Mimecast-MFC-AGG-ID: NyPLrLj1PvC_wh9Xz4wsiw_1743417554 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3913aaf1e32so2483187f8f.0 for ; Mon, 31 Mar 2025 03:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743417554; x=1744022354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9cwx8PB++1jPTpqj+0lA5MhEHp2F2B5hQ/5H2FoJu9E=; b=qkJsm2bNQP/wPLm6i6mep0DxIRQuX7hpOEA8CmGEdAw17GsfjKDwC1VUKWH2OA4x// gCTBqy6rezskJpCXozvHISO5Jvcdb2/CqAVkBI+TCtCQaCftgzS3RxTgThHPaE2MCa3e o7XWR+yzInWGRGp35Kmo3NwNF9awhSciY9DEmXcvpOH1WdDxd5nPMv72tnMn+P6M2mY2 p+vdHTFLUZfIEaOwgzAjEWGs6r3dQ8zKFH5c+vTefhV3dvy/9VxJRb8ucbMLBOvQg4fL LO5ULbYkqWsCs0ypzjaeii181PxQFwlbDVT0XkUhkEubyvJmXDp8yoQ0wF1LJ5PcOzuN L4Yg== X-Gm-Message-State: AOJu0YwaEyFWsZdvadJQsdvLX4b0tiwUldOhDGmFISatvRoCQ/yo47ok e2+sEr6tIfEE4qrGSgPT72o+0knmD1E7siQ9bpeihXNrVzaa/QZwTj0/mZnbDDtmVE0PF3V+TDC n++MWzHp8VeqoGei2xvnjYHAtSktS6OHJSRpjy6rrfUVPyu9Vdv74R2xkl1tTag== X-Gm-Gg: ASbGncvVxCeyR4Plwu0wQTlCBnYwPPOM2R8DNvKzLhzGvKr59/rCzYrf3OWgFFsiHAA yFicYB0GjENtLgBuDgnyWOi5XyV7tdH0iWnrnsmODgBaviwSaLgGAvLbc6Id24X63SMGxdg6dTb bd4kG4BP6E4aKbO2lvtMVq0Src+bDfWcEZsvIR+a8oKCZi0o3BSTwr+sRN9XA538Lhejlg3irFh 5HZi8h6pO0lWa8HM4WOs6RIzQ6gkYkCo9G7j1PrG7JWNnhmqPpuC2fBiDYRWNPeP5dLpncicN9i 1wD4AGfYmw6sYCGfjLsHk6rbt2OJw5cLQpaqKwm+k/8es3s2hCtYghZgBaq7NipWAw== X-Received: by 2002:a05:6000:290f:b0:390:f552:d291 with SMTP id ffacd0b85a97d-39c120dc53emr8370174f8f.22.1743417553607; Mon, 31 Mar 2025 03:39:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFsoB89UBurLAVASbUoQ/cK98O2vrnpvAMoMpoqAdUnbLHZg7VaZ3OwNXdLnVYlU6Ca4bi/A== X-Received: by 2002:a05:6000:290f:b0:390:f552:d291 with SMTP id ffacd0b85a97d-39c120dc53emr8370129f8f.22.1743417553104; Mon, 31 Mar 2025 03:39:13 -0700 (PDT) Received: from stex1.redhat.com (host-87-12-25-55.business.telecomitalia.it. [87.12.25.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b6589e4sm11068910f8f.10.2025.03.31.03.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 03:39:12 -0700 (PDT) From: Stefano Garzarella To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , James Bottomley , Dave Hansen , Borislav Petkov , linux-integrity@vger.kernel.org, Peter Huewe , Ingo Molnar , linux-coco@lists.linux.dev, Dov Murik , Thomas Gleixner , Joerg Roedel , x86@kernel.org, Dionna Glaze , Tom Lendacky , Claudio Carvalho , "H. Peter Anvin" , Stefano Garzarella Subject: [PATCH v5 2/4] svsm: add header with SVSM_VTPM_CMD helpers Date: Mon, 31 Mar 2025 12:38:55 +0200 Message-ID: <20250331103900.92701-3-sgarzare@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250331103900.92701-1-sgarzare@redhat.com> References: <20250331103900.92701-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Stefano Garzarella Helpers for the SVSM_VTPM_CMD calls used by the vTPM protocol defined by the AMD SVSM spec [1]. The vTPM protocol follows the Official TPM 2.0 Reference Implementation (originally by Microsoft, now part of the TCG) simulator protocol. [1] "Secure VM Service Module for SEV-SNP Guests" Publication # 58019 Revision: 1.00 Co-developed-by: James Bottomley Signed-off-by: James Bottomley Co-developed-by: Claudio Carvalho Signed-off-by: Claudio Carvalho Reviewed-by: Jarkko Sakkinen Signed-off-by: Stefano Garzarella --- v5: - added Jarkko's R-b v4: - used svsm_vtpm_ prefix consistently [Jarkko] - removed __packed where not needed [Jarkko] - expanded headers to avoid obfuscation [Jarkko] - used `buf` instead of `inbuf`/`outbuf` [Jarkko] - added more documentation quoting the specification - removed TPM_* macros since we only use TPM_SEND_COMMAND in one place and don't want dependencies on external headers, but put the value directly as specified in the AMD SVSM specification - header renamed in tpm_svsm.h so it will fall under TPM DEVICE DRIVER section [Borislav, Jarkko] v3: - renamed header and prefix to make clear it's related to the SVSM vTPM protocol - renamed fill/parse functions [Tom] - removed link to the spec because those URLs are unstable [Borislav] --- include/linux/tpm_svsm.h | 149 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 149 insertions(+) create mode 100644 include/linux/tpm_svsm.h diff --git a/include/linux/tpm_svsm.h b/include/linux/tpm_svsm.h new file mode 100644 index 000000000000..38e341f9761a --- /dev/null +++ b/include/linux/tpm_svsm.h @@ -0,0 +1,149 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2023 James.Bottomley@HansenPartnership.com + * Copyright (C) 2025 Red Hat, Inc. All Rights Reserved. + * + * Helpers for the SVSM_VTPM_CMD calls used by the vTPM protocol defined b= y the + * AMD SVSM spec [1]. + * + * The vTPM protocol follows the Official TPM 2.0 Reference Implementation + * (originally by Microsoft, now part of the TCG) simulator protocol. + * + * [1] "Secure VM Service Module for SEV-SNP Guests" + * Publication # 58019 Revision: 1.00 + */ +#ifndef _TPM_SVSM_H_ +#define _TPM_SVSM_H_ + +#include +#include +#include + +#define SVSM_VTPM_MAX_BUFFER 4096 /* max req/resp buffer size */ + +/** + * struct svsm_vtpm_request - Generic request for single word command + * @cmd: The command to send + * + * Defined by AMD SVSM spec [1] in section "8.2 SVSM_VTPM_CMD Call" - + * Table 15: vTPM Common Request/Response Structure + * Byte Size =C2=A0=C2=A0 =C2=A0In/Out=C2=A0=C2=A0=C2=A0=C2=A0D= escription + * Offset=C2=A0=C2=A0=C2=A0=C2=A0(Bytes) + * 0x000=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0In=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0Platform command +=C2=A0*=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0Out=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Platform command respons= e size + */ +struct svsm_vtpm_request { + u32 cmd; +}; + +/** + * struct svsm_vtpm_response - Generic response + * @size: The response size (zero if nothing follows) + * + * Defined by AMD SVSM spec [1] in section "8.2 SVSM_VTPM_CMD Call" - + * Table 15: vTPM Common Request/Response Structure + * Byte Size =C2=A0=C2=A0 =C2=A0In/Out=C2=A0=C2=A0=C2=A0=C2=A0D= escription + * Offset=C2=A0=C2=A0=C2=A0=C2=A0(Bytes) + * 0x000=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0In=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0Platform command +=C2=A0*=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0Out=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Platform command respons= e size + * + * Note: most TCG Simulator commands simply return zero here with no indic= ation + * of success or failure. + */ +struct svsm_vtpm_response { + u32 size; +}; + +/** + * struct svsm_vtpm_cmd_request - Structure for a TPM_SEND_COMMAND request + * @cmd: The command to send (must be TPM_SEND_COMMAND) + * @locality: The locality + * @buf_size: The size of the input buffer following + * @buf: A buffer of size buf_size + * + * Defined by AMD SVSM spec [1] in section "8.2 SVSM_VTPM_CMD Call" - + * Table 16: TPM_SEND_COMMAND Request Structure + * Byte Size Meaning + * Offset=C2=A0=C2=A0=C2=A0=C2=A0(Bytes) + * 0x000=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Platform command (8) + * 0x004=C2=A0=C2=A0=C2=A0=C2=A0=C2=A01=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Locality (must-be-0) + * 0x005=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0TPM Command size (in bytes) + * 0x009=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Variable=C2=A0=C2=A0=C2=A0TPM Co= mmand + * + * Note: the TCG Simulator expects @buf_size to be equal to the size of the + * specific TPM command, otherwise an TPM_RC_COMMAND_SIZE error is returne= d. + */ +struct svsm_vtpm_cmd_request { + u32 cmd; + u8 locality; + u32 buf_size; + u8 buf[]; +} __packed; + +/** + * struct svsm_vtpm_cmd_response - Structure for a TPM_SEND_COMMAND respon= se + * @buf_size: The size of the output buffer following + * @buf: A buffer of size buf_size + * + * Defined by AMD SVSM spec [1] in section "8.2 SVSM_VTPM_CMD Call" - + * Table 17: TPM_SEND_COMMAND Response Structure + * Byte Size Meaning + * Offset=C2=A0=C2=A0=C2=A0=C2=A0(Bytes) + * 0x000=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Response size (in bytes) + * 0x004=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Variable=C2=A0=C2=A0=C2=A0Respon= se + */ +struct svsm_vtpm_cmd_response { + u32 buf_size; + u8 buf[]; +}; + +/** + * svsm_vtpm_cmd_request_fill() - Fill a TPM_SEND_COMMAND request to be se= nt to SVSM + * @req: The struct svsm_vtpm_cmd_request to fill + * @locality: The locality + * @buf: The buffer from where to copy the payload of the command + * @len: The size of the buffer + * + * Return: 0 on success, negative error code on failure. + */ +static inline int +svsm_vtpm_cmd_request_fill(struct svsm_vtpm_cmd_request *req, u8 locality, + const u8 *buf, size_t len) +{ + if (len > SVSM_VTPM_MAX_BUFFER - sizeof(*req)) + return -EINVAL; + + req->cmd =3D 8; /* TPM_SEND_COMMAND */ + req->locality =3D locality; + req->buf_size =3D len; + + memcpy(req->buf, buf, len); + + return 0; +} + +/** + * svsm_vtpm_cmd_response_parse() - Parse a TPM_SEND_COMMAND response rece= ived from SVSM + * @resp: The struct svsm_vtpm_cmd_response to parse + * @buf: The buffer where to copy the response + * @len: The size of the buffer + * + * Return: buffer size filled with the response on success, negative error + * code on failure. + */ +static inline int +svsm_vtpm_cmd_response_parse(const struct svsm_vtpm_cmd_response *resp, u8= *buf, + size_t len) +{ + if (len < resp->buf_size) + return -E2BIG; + + if (resp->buf_size > SVSM_VTPM_MAX_BUFFER - sizeof(*resp)) + return -EINVAL; // Invalid response from the platform TPM + + memcpy(buf, resp->buf, resp->buf_size); + + return resp->buf_size; +} + +#endif /* _TPM_SVSM_H_ */ --=20 2.49.0 From nobody Fri Dec 19 19:57:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC81D1E25F2 for ; Mon, 31 Mar 2025 10:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417564; cv=none; b=U19d4kkyN47Z+UgBtqLXProoF1fSCSrEm/C1PeBSP6lxqN5/Li/Z2ESIX67e9PzX0MRzjoVSxJnqsmQcISQdYW6QDk23nlDthM0s8/NaDNRFU7w+7lAMLcsHRn9YBjVilufwUcUsdaVGfHhJWWwamcmMIgrwmHlhjhPQLNNsjSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417564; c=relaxed/simple; bh=qNUkPEAOFr9s3u9+1N+R65n8ZIruRlp2N14UPTd/oTk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U4nMCDRFKAHfmE4ncR7nOogcSSljm1CgPcGM/y/QxCV/WMIKJLB30Svkjy9E43oNeKHANcS9UIwHUtzkKp+QP/r6wzmKtfOTCVPbYjd6gzrCVJfzRiaSf1JLveBhF9bKEO0WbaJHsc5sk+TsihVEQs2UFqABiLNqKfiFJGhiniM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gUn4Iw6g; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gUn4Iw6g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743417561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VLNaodPChg0Hvto5PGR4xI34k649VIS6rrR+H3wA3Bw=; b=gUn4Iw6g7TSGv8C3Mnab6CfnPzPLIFvkwxrfBiwjP77w+H0S4jzaogQLPshrFlEj3P6YQ0 EPRr9Xxr7NtHIlhfWVqfdE4uRsovK8val3gYECjiYhklXe27TVetHrdS5qSX4UMU3f2wsg Yyv9dxkeeZfprQBNTp0KwIvCbMouv9c= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-ctKu4Uo_Otu3CHwDeTazwA-1; Mon, 31 Mar 2025 06:39:20 -0400 X-MC-Unique: ctKu4Uo_Otu3CHwDeTazwA-1 X-Mimecast-MFC-AGG-ID: ctKu4Uo_Otu3CHwDeTazwA_1743417559 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43941ad86d4so21866875e9.2 for ; Mon, 31 Mar 2025 03:39:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743417559; x=1744022359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VLNaodPChg0Hvto5PGR4xI34k649VIS6rrR+H3wA3Bw=; b=D94cUr6M7iKDrQETROZpQU+f+YA1dhMC0e9tYD+RkJCxOFWB4+V/ghmAvOQVdLuo2+ vO9egZQ4IUS+tbSIj4xpPmEj9TD8sT0ZYBXV/0j8DR8vqTR1ec9IF9HXlALbGkeouZN1 eWDw/9rqy0DN25uRNXWEav+flPCgLtttIwmj6c6sScZO4yqnpRfKLFS/nLkC6GxPYnSw GwXK+XGI7LS4Z+iXaAZjCKocd/zFI8uPYRfQRPHulvQ37SLVQ1fodvLXl91ex3hOyq8X diB6w0MgYec70VUC7p4pVc/TA/uEsc3givFLJ4EbrdQ84EjyLFtVU1rBbqlvJa8GtHTe Ok3Q== X-Gm-Message-State: AOJu0Yy10TEzawuMlhDoe36NQ/olmCH9RbAwvMOlILJdqBRtYNZ4xb15 U2wVtBb+/Yb5hVTaBrHspuVUcnPJtRasIIOWYIBFa3eWL2Y88pfOu3DRdP1pUVw0JTIlGyM4+na ldgR/WRuaujljH57XYWt5ee4gY342/qTDtPinHOsoPZf4sR1IdgnLknJUIjbSLg== X-Gm-Gg: ASbGncvsrgpXpTmz4c7W4oeIa4E1wlsZDibmnosNbg93vp0pY0Ga3XZLZj+xnVeR9jw PTds7vZB312mZQ7JhezG16aLHmtdM3f5E4juvHfiBM/gckvGnWANrhS784bqXZqv36s3ZXY+XrG 0Ny5ufOUylUus39VHCfw4oqs3WgRZi8Eygai0XcOKjm3LJg8KVMgCAeCu0vO8a9TCB7E33UO4w7 tyg03f1bqWKqVPxF6Dc+st0kmKWoW0++j3FW+ZN9AzB3xgkrPTTLFsAdipaszvgyAx/SjHb2Rtm E7KWt173i0tvnBDifFNP2eNcHgS71tSOtm/WDlUqXe/jTghPXdpGIfZVCV55Fl0a7Q== X-Received: by 2002:a05:600c:310c:b0:43c:f0ae:da7 with SMTP id 5b1f17b1804b1-43db6220338mr59426665e9.7.1743417559204; Mon, 31 Mar 2025 03:39:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+WzP2dz1EIJQGOldj+zQL43EnPVTY9MCareNEo3aP+vhWVaYm2IxGbFuiRK4ytEpi7g7kLg== X-Received: by 2002:a05:600c:310c:b0:43c:f0ae:da7 with SMTP id 5b1f17b1804b1-43db6220338mr59426235e9.7.1743417558576; Mon, 31 Mar 2025 03:39:18 -0700 (PDT) Received: from stex1.redhat.com (host-87-12-25-55.business.telecomitalia.it. [87.12.25.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82e6adf6sm159151665e9.15.2025.03.31.03.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 03:39:17 -0700 (PDT) From: Stefano Garzarella To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , James Bottomley , Dave Hansen , Borislav Petkov , linux-integrity@vger.kernel.org, Peter Huewe , Ingo Molnar , linux-coco@lists.linux.dev, Dov Murik , Thomas Gleixner , Joerg Roedel , x86@kernel.org, Dionna Glaze , Tom Lendacky , Claudio Carvalho , "H. Peter Anvin" , Stefano Garzarella Subject: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver Date: Mon, 31 Mar 2025 12:38:56 +0200 Message-ID: <20250331103900.92701-4-sgarzare@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250331103900.92701-1-sgarzare@redhat.com> References: <20250331103900.92701-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefano Garzarella Add driver for the vTPM defined by the AMD SVSM spec [1]. The specification defines a protocol that a SEV-SNP guest OS can use to discover and talk to a vTPM emulated by the Secure VM Service Module (SVSM) in the guest context, but at a more privileged level (VMPL0). The new tpm-svsm platform driver uses two functions exposed by x86/sev to verify that the device is actually emulated by the platform and to send commands and receive responses. The device cannot be hot-plugged/unplugged as it is emulated by the platform, so we can use module_platform_driver_probe(). The probe function will only check whether in the current runtime configuration, SVSM is present and provides a vTPM. This device does not support interrupts and sends responses to commands synchronously. In order to have .recv() called just after .send() in tpm_try_transmit(), the .status() callback returns 0, and both .req_complete_mask and .req_complete_val are set to 0. [1] "Secure VM Service Module for SEV-SNP Guests" Publication # 58019 Revision: 1.00 Signed-off-by: Stefano Garzarella --- v5: - removed cancel/status/req_* ops after rebase on master that cotains commit 980a573621ea ("tpm: Make chip->{status,cancel,req_canceled} opt") v4: - moved "asm" includes after the "linux" includes [Tom] - allocated buffer separately [Tom/Jarkko/Jason] v3: - removed send_recv() ops and followed the ftpm driver implementing .status, .req_complete_mask, .req_complete_val, etc. [Jarkko] - removed link to the spec because those URLs are unstable [Borislav] --- drivers/char/tpm/tpm_svsm.c | 135 ++++++++++++++++++++++++++++++++++++ drivers/char/tpm/Kconfig | 10 +++ drivers/char/tpm/Makefile | 1 + 3 files changed, 146 insertions(+) create mode 100644 drivers/char/tpm/tpm_svsm.c diff --git a/drivers/char/tpm/tpm_svsm.c b/drivers/char/tpm/tpm_svsm.c new file mode 100644 index 000000000000..04c532421ff2 --- /dev/null +++ b/drivers/char/tpm/tpm_svsm.c @@ -0,0 +1,135 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2025 Red Hat, Inc. All Rights Reserved. + * + * Driver for the vTPM defined by the AMD SVSM spec [1]. + * + * The specification defines a protocol that a SEV-SNP guest OS can use to + * discover and talk to a vTPM emulated by the Secure VM Service Module (S= VSM) + * in the guest context, but at a more privileged level (usually VMPL0). + * + * [1] "Secure VM Service Module for SEV-SNP Guests" + * Publication # 58019 Revision: 1.00 + */ + +#include +#include +#include +#include + +#include + +#include "tpm.h" + +struct tpm_svsm_priv { + void *buffer; + u8 locality; +}; + +static int tpm_svsm_send(struct tpm_chip *chip, u8 *buf, size_t len) +{ + struct tpm_svsm_priv *priv =3D dev_get_drvdata(&chip->dev); + int ret; + + ret =3D svsm_vtpm_cmd_request_fill(priv->buffer, priv->locality, buf, len= ); + if (ret) + return ret; + + /* + * The SVSM call uses the same buffer for the command and for the + * response, so after this call, the buffer will contain the response + * that can be used by .recv() op. + */ + return snp_svsm_vtpm_send_command(priv->buffer); +} + +static int tpm_svsm_recv(struct tpm_chip *chip, u8 *buf, size_t len) +{ + struct tpm_svsm_priv *priv =3D dev_get_drvdata(&chip->dev); + + /* + * The internal buffer contains the response after we send the command + * to SVSM. + */ + return svsm_vtpm_cmd_response_parse(priv->buffer, buf, len); +} + +static struct tpm_class_ops tpm_chip_ops =3D { + .flags =3D TPM_OPS_AUTO_STARTUP, + .recv =3D tpm_svsm_recv, + .send =3D tpm_svsm_send, +}; + +static int __init tpm_svsm_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct tpm_svsm_priv *priv; + struct tpm_chip *chip; + int err; + + if (!snp_svsm_vtpm_probe()) + return -ENODEV; + + priv =3D devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + /* + * The maximum buffer supported is one page (see SVSM_VTPM_MAX_BUFFER + * in tpm_svsm.h). + */ + priv->buffer =3D (void *)devm_get_free_pages(dev, GFP_KERNEL, 0); + if (!priv->buffer) + return -ENOMEM; + + /* + * FIXME: before implementing locality we need to agree what it means + * for the SNP SVSM vTPM + */ + priv->locality =3D 0; + + chip =3D tpmm_chip_alloc(dev, &tpm_chip_ops); + if (IS_ERR(chip)) + return PTR_ERR(chip); + + dev_set_drvdata(&chip->dev, priv); + + err =3D tpm2_probe(chip); + if (err) + return err; + + err =3D tpm_chip_register(chip); + if (err) + return err; + + dev_info(dev, "SNP SVSM vTPM %s device\n", + (chip->flags & TPM_CHIP_FLAG_TPM2) ? "2.0" : "1.2"); + + return 0; +} + +static void __exit tpm_svsm_remove(struct platform_device *pdev) +{ + struct tpm_chip *chip =3D platform_get_drvdata(pdev); + + tpm_chip_unregister(chip); +} + +/* + * tpm_svsm_remove() lives in .exit.text. For drivers registered via + * module_platform_driver_probe() this is ok because they cannot get unbou= nd + * at runtime. So mark the driver struct with __refdata to prevent modpost + * triggering a section mismatch warning. + */ +static struct platform_driver tpm_svsm_driver __refdata =3D { + .remove =3D __exit_p(tpm_svsm_remove), + .driver =3D { + .name =3D "tpm-svsm", + }, +}; + +module_platform_driver_probe(tpm_svsm_driver, tpm_svsm_probe); + +MODULE_DESCRIPTION("SNP SVSM vTPM Driver"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:tpm-svsm"); diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig index fe4f3a609934..dddd702b2454 100644 --- a/drivers/char/tpm/Kconfig +++ b/drivers/char/tpm/Kconfig @@ -234,5 +234,15 @@ config TCG_FTPM_TEE help This driver proxies for firmware TPM running in TEE. =20 +config TCG_SVSM + tristate "SNP SVSM vTPM interface" + depends on AMD_MEM_ENCRYPT + help + This is a driver for the AMD SVSM vTPM protocol that a SEV-SNP guest + OS can use to discover and talk to a vTPM emulated by the Secure VM + Service Module (SVSM) in the guest context, but at a more privileged + level (usually VMPL0). To compile this driver as a module, choose M + here; the module will be called tpm_svsm. + source "drivers/char/tpm/st33zp24/Kconfig" endif # TCG_TPM diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile index 2b004df8c04b..9de1b3ea34a9 100644 --- a/drivers/char/tpm/Makefile +++ b/drivers/char/tpm/Makefile @@ -45,3 +45,4 @@ obj-$(CONFIG_TCG_CRB) +=3D tpm_crb.o obj-$(CONFIG_TCG_ARM_CRB_FFA) +=3D tpm_crb_ffa.o obj-$(CONFIG_TCG_VTPM_PROXY) +=3D tpm_vtpm_proxy.o obj-$(CONFIG_TCG_FTPM_TEE) +=3D tpm_ftpm_tee.o +obj-$(CONFIG_TCG_SVSM) +=3D tpm_svsm.o --=20 2.49.0 From nobody Fri Dec 19 19:57:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8047E1E2823 for ; Mon, 31 Mar 2025 10:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417570; cv=none; b=Ppv7FiCtyADPHTHf369gVv3Q+iRNu/JsU5/07MnC2Zu4wB+Hp84UtEFTMl4fUpMJ746jg8NWjNvS98dCtxQXCmQa65a7BWZtD/TUZHVLnqXqPJaPfzSUNaIdJagU1Ivlz8uv6sBlx44CCmFRTrDvHuJgtB2nN0CawGc/uSujY1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743417570; c=relaxed/simple; bh=VSwSVqTTPnbOpmlHq9MOfH3OWqH+XBMIsW4BP4w9E5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sfEta+Rh1WgimIbtaqnvkjArsx6Cny8aiwjwtIY+3lT5qLcVwQdzVLEerCeWoK70X5ozU7DrNG9VbQb1dhbZjxGCRuglIzByzba47gcRUBATwCo9pOuaYdhqWGVnVGLJwADWmGFxKbEZ/Z5BKnDLE4HWtXXMXLT5Dnt8w31QQUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GZObhcvX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GZObhcvX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743417567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4fxR3joWDLb15zwEwdHZI3rgw4qmSYJti26bFJQ+VcA=; b=GZObhcvXyfF7iA8YydQsQvJbOc3FP9u7DpQdwron7cXoc0RbR34FoF17jT2exALcjMJZ0s hxeaTcSPxzmKqXDElD9m4e27WdPNuuMmv0CH3G8C06TnN4qqa1DNBIFn2qRo66VpMgfYu3 BobWCpL1S9pNbnMIJpF30FAnBgDrwoo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-a6EVyczlOWeZeDLLVrW6SA-1; Mon, 31 Mar 2025 06:39:25 -0400 X-MC-Unique: a6EVyczlOWeZeDLLVrW6SA-1 X-Mimecast-MFC-AGG-ID: a6EVyczlOWeZeDLLVrW6SA_1743417564 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43ea256f039so3125485e9.0 for ; Mon, 31 Mar 2025 03:39:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743417563; x=1744022363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4fxR3joWDLb15zwEwdHZI3rgw4qmSYJti26bFJQ+VcA=; b=Z7NPVjhI/S2EALaUW/k8Cc9WIo6gV41c/Jb1dm7kG6ylsRZDh/DDt/kMV7zbrU9qpW KPXDWfEULvwh7XIF1iowhloB6lyMfhocFOe6V489UWf5kw89MkyaiyAj39Kzy3edfhZq sinl8bNVP3q8HpNx93u18YyheClWVh1qHx5PtlqjYHTfRcHCnhFwhZtsPuWbLjduX4D7 cSlim13KLheZ3Cy7LaNI0713fmHzWUu+947kdubjXl5K2A7nEVy3tHTw6F6J5iRsW6YX OP1DiivRanaBY0kH3FDMC+AYEIBI4rAfnwnMgLsjLrzJY9gymKqOCAX/tWL73XC9LVz2 as6A== X-Gm-Message-State: AOJu0Yyzfljfpy0gCgVvkzjlr8SzMr5GtO/rlIB+dGkHPmSQQtFFNqnS FNXs6ncrlQiQH78nm7MznXO1vfQAKism1XF68q95YzOZxOkK+Vu5fTSabu0Xht6r5q0uYQd+eoW G5lk949GcYJeIPaBblOawR2+Z/HyS1eqWX1J5oCLk1xLwdaxyyH1PjV28cO9D70q57kQ7pSPL X-Gm-Gg: ASbGncuRnJ+SCRR4t7oeEMJv0+bxbJijU7mdOjvVUMpomZYGy6gQEUblRciJMdpUZSh TCou8lOtWFhZSEIXRamQhLFsbBBIMs9nhsm6/upchthNqoGA29rmHyFm+2iZWMJ8ecaFcOkuwjs 2Z59YMiFRXffuZ3ah3GkL1aUPdufFMg4HFeL/D2tEWGDlpoLM0WRZ50teVdIBmzdcXlmgx2p0UN wjuZ0xiafbaX6I2cFbx9CRTrShbEiuDKvdVngTAFuI2Pq4h2WTly5nH7ZLkXpMYeyst+CnPY2Wi wlps3fFAgwFj3fBKHulrOJuTLJeLDWqyWUJ4LmN99Aa9+6zOaOQ5czPJthdAQZdf0w== X-Received: by 2002:a05:600c:1d83:b0:43c:f64c:447f with SMTP id 5b1f17b1804b1-43db62bf772mr81331255e9.29.1743417563544; Mon, 31 Mar 2025 03:39:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSEY2IAvMlONrWW/ecIZqpU4KW8seEtaraLsrYv8QTUi3aO8abB8sFiMZjGmzhLkOrU2UPdg== X-Received: by 2002:a05:600c:1d83:b0:43c:f64c:447f with SMTP id 5b1f17b1804b1-43db62bf772mr81330855e9.29.1743417563067; Mon, 31 Mar 2025 03:39:23 -0700 (PDT) Received: from stex1.redhat.com (host-87-12-25-55.business.telecomitalia.it. [87.12.25.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b66363fsm11273542f8f.36.2025.03.31.03.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 03:39:22 -0700 (PDT) From: Stefano Garzarella To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , James Bottomley , Dave Hansen , Borislav Petkov , linux-integrity@vger.kernel.org, Peter Huewe , Ingo Molnar , linux-coco@lists.linux.dev, Dov Murik , Thomas Gleixner , Joerg Roedel , x86@kernel.org, Dionna Glaze , Tom Lendacky , Claudio Carvalho , "H. Peter Anvin" , Stefano Garzarella Subject: [PATCH v5 4/4] x86/sev: register tpm-svsm platform device Date: Mon, 31 Mar 2025 12:38:57 +0200 Message-ID: <20250331103900.92701-5-sgarzare@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250331103900.92701-1-sgarzare@redhat.com> References: <20250331103900.92701-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefano Garzarella SNP platform can provide a vTPM device emulated by SVSM. The "tpm-svsm" device can be handled by the platform driver added by the previous commit in drivers/char/tpm/tpm_svsm.c Register the device unconditionally. The support check (e.g. SVSM, cmd) is in snp_svsm_vtpm_probe(), keeping all logic in one place. This function is called during the driver's probe along with other setup tasks like memory allocation. Signed-off-by: Stefano Garzarella Reviewed-by: Tom Lendacky --- v4: - explained better why we register it anyway in the commit message --- arch/x86/coco/sev/core.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index efb43c9d3d30..acbd9bc526b1 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2689,6 +2689,11 @@ static struct platform_device sev_guest_device =3D { .id =3D -1, }; =20 +static struct platform_device tpm_svsm_device =3D { + .name =3D "tpm-svsm", + .id =3D -1, +}; + static int __init snp_init_platform_device(void) { if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP)) @@ -2697,6 +2702,9 @@ static int __init snp_init_platform_device(void) if (platform_device_register(&sev_guest_device)) return -ENODEV; =20 + if (platform_device_register(&tpm_svsm_device)) + return -ENODEV; + pr_info("SNP guest platform device initialized.\n"); return 0; } --=20 2.49.0