From nobody Wed Dec 17 11:46:50 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A3902343C0 for ; Fri, 28 Mar 2025 13:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743168677; cv=none; b=fpHXj6nhOlTfrinc2qY7ISyqiE7hMWyBbi98/a+zOsAOZsES7nFi/2cglZwFqwb429Cj3iacC0XKLxKgPo4a9+vZf2KGwPdjIZj8hBnL9wp5rG2GDfCXopmsFj03TeWFUd2Su03nz+UB/3kzzWQNvmLjrYACgfxJyCA2WyD069s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743168677; c=relaxed/simple; bh=ZQXUgJ+++iTVY6rSOqr6bNKwQtS/wOW8Ul9zOtzlYzw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G/EDCui4SyhChzu+BrRjqJGt8IWcEL/fyeJ9Qd8hBjcSoBc+seKYv1qn/6gMt8LMTGf2iHIddqNM2k3QzhdTMEnPWYVZ86KofTrjFfT+3SyLnyR25FVbjGa7mMtT89yKQT/9Zrb5vfvxUi7yWBW635D+2xos31S2LGEC6l6o9bM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V2Z7n55V; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V2Z7n55V" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5e677f59438so3356838a12.2 for ; Fri, 28 Mar 2025 06:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743168667; x=1743773467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/FZ2sB+aGjDu2Ign5/fbJkQ1EFpiN/+kFXshKweSgHY=; b=V2Z7n55VPpjKfdYrymM/gN/wSeF1LASJbvSlEqY1KjF+eTL5aYOygWCE+USvhc7M14 Zk1ryejVR9J83vMTq9GVEauzD7ClDZjpqsOPHey6zsiFAGTjNQ702f1l+wMcdgIRQPEY 5bnTFsRf1cnbJa8T5JZhmKZoMvLbRH4OoPAk6rw4gRzhoL2nbUkOm690A4vxXAsODyTt HA+T762iMmCTNtAm2y+4etuuKnOEiDZhWdHs+iigBQfQCLMC1P7rvT/Ad0Trorn9rR7j wOFtwt4agWTiXbMt73xIm62yMUGw/Fn3TowscdygePpBAhQTH8IGxPDtB0R9xYN+KCPM ddTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743168667; x=1743773467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/FZ2sB+aGjDu2Ign5/fbJkQ1EFpiN/+kFXshKweSgHY=; b=dkbhTKtXQZFce90SD8ilCHd2dJCRRp6xRP4uGWG09zVMm6eoetWDK17LZcL2gfZYHA 7Krr4CpBRKQmsQxY8tJLbSknVvt1bOJiEpAS2ti6L+UUtxRu+c9sgcu19iK05zpilQ3k zx2nxi4bLGoGFtUePHooba3g+QNGTMPE0hNOKT3mtIqYN5KkSCpoIlaFTlHnFYwyns1V Hw1wkZ/Kgf5GuO8V8t8+tgV9U309DHVMWvOGTLEVnxaGXdHs+C3mfMfwpfxN2fVKPRL8 XuEbh7vmxYA6qxMM37l2Q5Vb/xm+JJCwDccDAUn0k2tmJQ1xnls24Qvxc/l8g28Vll9J oOAA== X-Forwarded-Encrypted: i=1; AJvYcCVjllBkT213J6ksi/c2w33Me3l1MWTlv+Z3vf+rbz2xmjIwpO4reTf5dJiQs28vDATonv7BsRNzJt7vY0g=@vger.kernel.org X-Gm-Message-State: AOJu0YyM/+vR7/0Ov7n75Uw5m6AHTFtg4NJIcBV5h/nbpwHxnjJdkwHn 9enyUChkfUdSubF4/QKb1Gc1KMH03c4/pPzJOPyDr7TuhKtiX/I5khYz3X9Wp04= X-Gm-Gg: ASbGnct+hPXeiLge1ISoJQ+h1n9cg165EMo8hFgQEiExyk2TXnP8TWDXYVPqtV4k/nV 05CNCzTzH7phRA14ZVSDAGqt5Y7WiCh/ge8Pvc20f+nqyXRTElkb5C5N4o5kyWarvU1kfh90frF O4VChlBnzuRzFeK/92LSL7ZUip4niyfU7VAXO+lcG32j6cG3YK2v+BuTPQ5Mun27XTeFpkAjWhD Ptv0ih+N+x6gToLnedurZaoHsrgaKVyyctJTDu8SRQL3nEkBO2BVJkAQ9mwFFRlXU+j79akmeJV WYbaYqA9cARQfZuP7bTjJFTtgIT+2uFsYAWMouKp8E3TD+Baxrwx9i1gR09lOeDD22a1KH/QRmK Wxn0duJMHWKOzDwgzWXp2ngm7y119 X-Google-Smtp-Source: AGHT+IGSqptnzxioWGgvH+TeC2OAU/4Feh5tQVATT2tVY9LlKpIN77ufnNqeM2yiIzKx/dF//iDlTw== X-Received: by 2002:a05:6402:1d4a:b0:5e5:dea5:3eb2 with SMTP id 4fb4d7f45d1cf-5ed8e388e5emr8163387a12.11.1743168666968; Fri, 28 Mar 2025 06:31:06 -0700 (PDT) Received: from puffmais.c.googlers.com (8.239.204.35.bc.googleusercontent.com. [35.204.239.8]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5edc17e01f7sm1355284a12.79.2025.03.28.06.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 06:31:06 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Mar 2025 13:29:11 +0000 Subject: [PATCH v2 25/32] rtc: s5m: cache value of platform_get_device_id() during probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250328-s2mpg10-v2-25-b54dee33fb6b@linaro.org> References: <20250328-s2mpg10-v2-0-b54dee33fb6b@linaro.org> In-Reply-To: <20250328-s2mpg10-v2-0-b54dee33fb6b@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 platform_get_device_id() is called mulitple times during probe. This makes the code harder to read than necessary. Just get the ID once, which also trims the lengths of the lines involved. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s5m.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index db5c9b641277213aa1371776c63e2eda3f223465..53c76b0e4253a9ba225c3c723d3= 5d9182d071607 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -637,6 +637,8 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *in= fo) static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx =3D dev_get_drvdata(pdev->dev.parent); + const struct platform_device_id * const id =3D + platform_get_device_id(pdev); struct s5m_rtc_info *info; struct i2c_client *i2c; const struct regmap_config *regmap_cfg; @@ -646,7 +648,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) if (!info) return -ENOMEM; =20 - switch (platform_get_device_id(pdev)->driver_data) { + switch (id->driver_data) { case S2MPS15X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; @@ -670,7 +672,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) default: return dev_err_probe(&pdev->dev, -ENODEV, "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); + id->driver_data); } =20 i2c =3D devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, @@ -686,7 +688,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) =20 info->dev =3D &pdev->dev; info->s5m87xx =3D s5m87xx; - info->device_type =3D platform_get_device_id(pdev)->driver_data; + info->device_type =3D id->driver_data; =20 if (s5m87xx->irq_data) { info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); --=20 2.49.0.472.ge94155a9ec-goog