From nobody Fri Dec 19 13:57:09 2025 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011042.outbound.protection.outlook.com [52.101.70.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C26B2A1B2; Wed, 26 Mar 2025 13:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742994927; cv=fail; b=I+NuPvXRxz95QkD0RZdjm5F+smjmAgQS0C9BBK/9tEo1K7NnVt4o8+tTDP+GPgonrSwukvd10cJsYDSSEjtFGisPCtJhLUPVVTHDeRHguCU2S6vWgwzcc+TYW+jTPQ1blgOQg2/msB79mTF5tq5WKt1/6EDDdsPPYWV+HHTKzKg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742994927; c=relaxed/simple; bh=Pm965ZxSgm5Tut4qEUOzWZLw8EGX2bIp+SF6P82dPPk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=XZo/Y2oPf9A0Yc/Xp+Z64XNu/tF2Mjwh9sU2Bb7XnLQ++m1YiMP377JyWg60JEceyOvibyWlJJJKxYbUqjklI00f9nZnERssCfyYHzm+YQmYn3EgA/WCA2/yEwjTQ0Of3HkD3Tn9ptn+1aTWzxdX/T7pk41OludiFjm6FaWGGU8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=dSNwDcJ3; arc=fail smtp.client-ip=52.101.70.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="dSNwDcJ3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Low9D1eLP+1Jpf+59KEu02LwRi9BgpukUjdjkZFsm2iUsn3jUNNJEScloDSAybHpGk1edAMHkuYs+AyNAqQUEcgbrKSoOUkn4qB8qkfqs+p84imQ+plKtJU43aoaNNqd8YNxdvNu5DDJ+cdm4FZsa3bMbywn3o6UShBAbFIjqO6J3ELkhUK4mJtorgbnTkm5nUIYASnsE2o3iWrArz1DOVW+SqzhNg8HOxNcLr4StDZ62UZ9C2cOPwlm1g5on5EwZPsxglp4+qWEH4SP/O22la4iWhBHRVZsu5K1CGxV8YRR8IeXUIl930QrxiQklOV/Qe2Vz8zh4iW3oXaLJsf0ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0NNIVASCpH3oRkwaJ1bFkhvuRoDwnmM2RaDPlfcOJ9M=; b=nr2uyn0GwZ+XYsE0d4hILof4Qnrgq3bE9TRmEElhNanbepA3QWRPa2tEIAsE/uqs7Jkb6nXEZwl4c1aSbDnbYj71I8k7fuK5fO/bG1obLO9rt3Sd5bRRzjzov1Qb/l42W91o1+3otW2c5lT+QPlHAf8MY1/Qsj/OhQsBkmeLKpXewbXqpUwaM+NIokZBJGp13u8nMnKdGf1FI7l6cJe8GWu+61zKYnjBRDYKUv/gdqHZVbMbA1zR3j9q3oUtpQyV7B/GmpTttcZKwlTzyI5CIJ4tNrzHDdtrYsw845BKEE26UQHuoLnRkQmwQDoibkONLpcrUm9gI1H9cigQvuBflg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0NNIVASCpH3oRkwaJ1bFkhvuRoDwnmM2RaDPlfcOJ9M=; b=dSNwDcJ3Z4RGwWUF1QpNvjR0lCIkp5CbY+SPuGEsnmjRsTIgRaW6pboiNa3QiONBSTkhNsLeeKzcSxDmkSSv+5FAl4flBPryxeSUONIvcE55Mbw0aT21BDs26d73czNkieHE41V86uALJ3X3lgIXDSZXvP3eJ+i/JnF9LOayZ+otgEGa35OfqDmm4Fi8KeD6ncpxeeBYPaqP55m/mkB6MCyhIor5uAeAHQom046qXgK/lsh8XDm/XW+D7qJFE2xMWSbng1o/7LynjB3dW5xjt+6mnLyi3ZG5XdTrj6WF/IKyWnr5i0KusGIfHoZJkIoucz4/2fAjmYP5xmeRrj+EIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8604.eurprd04.prod.outlook.com (2603:10a6:20b:43b::21) by AM9PR04MB8828.eurprd04.prod.outlook.com (2603:10a6:20b:40b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Wed, 26 Mar 2025 13:15:20 +0000 Received: from AM9PR04MB8604.eurprd04.prod.outlook.com ([fe80::e751:223e:aa3d:5827]) by AM9PR04MB8604.eurprd04.prod.outlook.com ([fe80::e751:223e:aa3d:5827%5]) with mapi id 15.20.8534.043; Wed, 26 Mar 2025 13:15:20 +0000 From: Pankaj Gupta Date: Thu, 27 Mar 2025 00:08:02 +0530 Subject: [PATCH v14 6/6] firmware: drivers: imx: adds miscdev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250327-imx-se-if-v14-6-2219448932e4@nxp.com> References: <20250327-imx-se-if-v14-0-2219448932e4@nxp.com> In-Reply-To: <20250327-imx-se-if-v14-0-2219448932e4@nxp.com> To: Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Pankaj Gupta Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1743014302; l=39847; i=pankaj.gupta@nxp.com; s=20240523; h=from:subject:message-id; bh=Pm965ZxSgm5Tut4qEUOzWZLw8EGX2bIp+SF6P82dPPk=; b=yuiJb5xfVPbrwD4Mr7thRP4fjl5EAYpZJPL960xGqRWHNzbtuw2WjrS06/6W7AD1tYTgqcUeV HLCFJZubj3GB4OSvka+/Mpm5zWPR0eu04yH/Ebr1mW13xkHDoGa4I/9 X-Developer-Key: i=pankaj.gupta@nxp.com; a=ed25519; pk=OA0pBQoupy5lV0XfKzD8B0OOBVB6tpAoIf+0x1bYGRg= X-ClientProxiedBy: SG2P153CA0047.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::16) To AM9PR04MB8604.eurprd04.prod.outlook.com (2603:10a6:20b:43b::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8604:EE_|AM9PR04MB8828:EE_ X-MS-Office365-Filtering-Correlation-Id: dd4781b2-5084-4f98-320c-08dd6c6841b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ay9SQnRWYU1PdStLMEZFblExZ1lHTlRaV2VmQ2x0Z0xtSUMvcVAzQndTbWsv?= =?utf-8?B?ZmdXM25uUlRhekFTYzNpbnQ0ZWs0Vm9JekVKdTVjTUpMYmxIN2daL2xmWHNI?= =?utf-8?B?WlozZHJzRElVUEQzczdBVm9aS2NPYmpMY1ZMV2tWSHV2eERjTkluZWZYUUdZ?= =?utf-8?B?bUQ5cGVhd05hRVYzZXJ4OElRVG95NUg4YTlwek1JTHljelhMem45NmFYbFRF?= =?utf-8?B?QXNsTSsxVG5MT1FUd0ducURVeXJmamJEVHVBRUxhdHRrZk9EN1QzYU9Bb3JI?= =?utf-8?B?VDM3b3BKeGlmZUkxUmNGSCtnbzZ3eE1kWEhFOE5BeXUveDJvZ1NKYi9hZzlW?= =?utf-8?B?T0hqTnhFOW9OcjdObW1mUjVPNlRad3ZNOVpHU2RMRlV3c0Y3V0I1QjNtbmpE?= =?utf-8?B?YjVQQ3BHby9RaUdTMytYVldFWDJob29DWG8vZEQ0REJRRmFoa3JYT2NiWkI3?= =?utf-8?B?WENBSlF6eExMTzVSNkwxM2VPUS9RTmxZNTN6QjBpWU5hNllvbTlwb09MRlBh?= =?utf-8?B?M2d5ZHhOd20vS0ZGNXo3U1BYdXNpTVIwVUc1MldpTmxPNDZMY2tkQmh5RUpN?= =?utf-8?B?MHhmQlNCbDFpMVJ3M3dHemZCYU9Edk83aDFiZ1doQXhDK0tlZTlyNE4wVG5i?= =?utf-8?B?YUtDSERZN2RIQ3JCSmlhZ3lzZnUrek5uYkhuendnMjhqWUFDa1R4UzQ1NW5s?= =?utf-8?B?amQxZlRsbnpiU1J3LzN0NWtHY3RxNyt0STZUQTFhYlVoYm82eEp2V1BBN093?= =?utf-8?B?T083SnNUNmt4SlJTM3pKWUFoTnFrSGZvNDY1M2xTYnNKcVVMc0NUVnd1N3M3?= =?utf-8?B?SnpSNEtIdEVEN1RqektiWWR3KzJsT0tEclc2OXdJSStqR2JvVTV4cnRtUi9T?= =?utf-8?B?bzhjQmhSQjB2Y0Z5QzdJYUZyUkU1UWVQZlk1WjVwZ1lieDdsSGVmeUxmWFdM?= =?utf-8?B?ZnNZZWhtTWdpTjUxTHhBVkVON29QOEtXV2hHMXF0UVBpd2ZEZ2p1QjVEZUtv?= =?utf-8?B?dHFqOU12bzBYZyt2bkhOVGU3ckRNR1lVZmNuZjlVY09CNDNCSGFCNkhTYkdJ?= =?utf-8?B?d1I5OHdLNzN0bFlITlprSFAyS2dBbGpqUnZBMTJkZS9rb3ZaRktpdXNGQzEx?= =?utf-8?B?NDFLZThnREFFSVVXdEpWYUJaU0h3N1VNMlJhNkV5Y0hmWG5ub1ZvcDVSZ20r?= =?utf-8?B?cDRuTUhYYnF2Q21jblM5WEZOZ0pzVHdORUdlVnY1VWFzVTZzVUJOL0hDTkVD?= =?utf-8?B?TndrYkNLYzAza0dadEVLK3IrNnlzL3UrNnhDV3d5U25HMjFWTlNxM2pxWWZY?= =?utf-8?B?T0RaVVpxNFpaSEdhT2h0WWNkS2g4aklJWTNnMWU2R2JydFBqL3g0cmkwVlRU?= =?utf-8?B?MG56TS93Y09oZ05PdkkzWC9QOWl0Q1VjMHpUM2lxSTFJc0Y4ajZFaW94MVdK?= =?utf-8?B?YVZMVVAxaUJZZStydFJYZ0FRcHA5bmJueUJKNzNRZU1teVNzekJCbWFVVnRY?= =?utf-8?B?YmlhUzRlVzRmcmlqL04yT0F4aklMWkxQOFVneEtqRCtaVnBQTkY0bERYWmx4?= =?utf-8?B?QWJ3bSs4OE5MMHJUSG40SW9uWUR2SVJVMURSempZYStxMVhVV2VQWFBvcXVR?= =?utf-8?B?d2V6ZitmTnJKbmJKQm9MOE1kOGNhZGdZZ1EwbjVIWUtCNk56S1A5dFcwazRN?= =?utf-8?B?Y2pZRFBNNzQ4QVUxbGtNMWR4Q0xaQjlXT2g1ZWVSWnMxUjgzWW5XWVgwaWM0?= =?utf-8?B?Q2tIWmlMbi8xYTVGYnJUV29YaEhUdTV5MDcvOG9LTTdvK3huQVJGRkZOOWw1?= =?utf-8?B?TFBXelJJWkFXaWE5M1NRQlFiSUFrQithZktMZW5lOUZBaFdkeW0wc1pQWVhU?= =?utf-8?B?aU1oOE9QeWpWU2NOYURHZ0pvQTEwMUd2WWxqMklmRkh6TDBEZkgwcXhtckJI?= =?utf-8?B?QlNyaU0yaDdZYmIydG1EWTY3RElyTzlkeUhhMy9reUUxRjIyVVdTK3FvMDU3?= =?utf-8?B?dzZVaGVOQnZBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8604.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3c5VUFiVVJ1cXRvTDl4YytFa21TbCs3a3JsUitVQUJGRlJXaEtpV09jUFJW?= =?utf-8?B?R3RjeFh2aGErb3pIRGRqckpRWXZNdkVUMnRXNUNZSVYyamk5VUlKZ2xuckc1?= =?utf-8?B?ZVdSOUcyR0wyeElkd09TdVRmYWErVHoxdU9MNU1ZQ0ZqdmtpYXBIWEdMRE0x?= =?utf-8?B?eFpLa2kzcVEyd2ZPc09rQTNWUUFCaEpIWHVabGIzTlFQOWZhOU5SdWJoNldw?= =?utf-8?B?MnpGYzNjbUJJOVliZ050ejRmZlgxaW9zRzZ4a25nL2pHcWJGb3dqZDJSTXVN?= =?utf-8?B?c05TYkVkTmxkRUNzT05pZi80Y2g1Q0g5clUyUzFaYy95bzdTWm84bW50dDlh?= =?utf-8?B?SEpnUFpLcGpGRTZyL1NOcnhIWGw5TVNHNzMxdkM1L0VrVGk5cFBibExRT2Y0?= =?utf-8?B?bVhpSHMvWURNZ21aV25CSURnYkszbFVqbmlPZXFMemphQjFwWjE4bXE4L3JH?= =?utf-8?B?RmlWNjIraWt4cE1LUlVZTThYOXpuY0ZocGwyTU5QVlY2eFBrL1ViQnZYbi9H?= =?utf-8?B?TTkvWHlqZE9VMWd3M3Faak9uV2FWNGg1ZG1qcG4vcGREcDc4Z25CS2JySzVM?= =?utf-8?B?dHYvQjZBZ0JMcWdvV01mdHZzY09DNWs0Qm5nRkV4Ry9leXBWSkYvL1cwRjFp?= =?utf-8?B?VlpwYkJCNmU1aWlzYnNwNWo0K25hMDVjenoyd2dBeklCcWFWSUFJdml3QnFz?= =?utf-8?B?NDh2Ymd4M1pTdkZPbXJFVzFyNjdyMnY5QTBFWktidk41Y0dqK2tqbjBzR2ln?= =?utf-8?B?Q3VKdzV3eXQyN0ZvakEyWjliakZPdnBQemZ1eC84Mkl3THRsc09ILzBQTkRh?= =?utf-8?B?eHdtRVZ4VWdZdlJodWlWUG5sZnM5U3FuYWpzdUU0b29CMmVHaitwK1pTSVRS?= =?utf-8?B?Wk9HVk5jYU0zYlU5WitJZ3ZwYUtlN3ZjQ09nZ3JXM3BsZ1EyY2M4bVk0RHg2?= =?utf-8?B?SklMb3J2Y1poVDdnYnZSeGJFMW1HZUpQSlV2dk85SFQ1Mmo5bi9sQWYrb00v?= =?utf-8?B?RkcyY1RqaVZ6TitjcUFYbXcyMnhnR0pFQVNIRHRsOUZmVzFveTBhdmZIbk51?= =?utf-8?B?UXdrN3BVdm9XT1RRMTRVbW5qTmJyOUswS2hnMVRWcTU2YmloQlJTK3NjNjZ1?= =?utf-8?B?WGp5aGU2L3NyR1NYNldaV0kyanFJVGs2OWxSVkxwK2cxVmJIRXB2L2JpMXM5?= =?utf-8?B?Rk9PL1VzZ01VSlNuMWZsR3haL1hUWU9YZVZaalJhRDZkNjQ0VTRNekZmSlB1?= =?utf-8?B?ZmREQzJjclFJdGF4U2t6RlhLdjZQbVNHZnVycnBFcXJGNklPY2Rvd3ZXeTg4?= =?utf-8?B?RDZWOU50UkJ1VnorMis5cXRFeFYxUzIvVjgxejNtUXdSa0FxS2dXODM1ZCtw?= =?utf-8?B?MU9xWUhhYWowSE4xTVJ3aEZKMStmcmgyUzRXYWhueFpocWNsS0h2Um5EVUtF?= =?utf-8?B?VFBmNzRqVzR4R2t4bDZRVDZaejhjT3lTZWVYSGVRZzJiQ0lTdWZaTVpVTWlh?= =?utf-8?B?SUZKTzRHWDBwWE9Jd3VWT25NeTh6aldrQ0ZXYUVTUmxtVmdrSW11QkN1eGEw?= =?utf-8?B?NzFHOHE3cktDU1VZcUNjdmxOcU9DZmc4cDFNVGVtWi9OSitqRTdKTUdseUtW?= =?utf-8?B?MU95eTFvNEVCWG9NSExYVWZtWVRyRVlTNWl0a2trOGg1MFpCY045VFo3a00z?= =?utf-8?B?S2hYbjRvRVNYSkdiMUJranE3NlRrOUJuUllTaUhSVVRvMHJxU01TRWMxM1oz?= =?utf-8?B?ZVNPekxRNFU5dXBMOTRuNTAybnhHTlRCRDNkWHFMb1JNMW8vV1hDWmZIUDA2?= =?utf-8?B?R1FYRi9IN2tGcmg0eVNzNUx4SFo0cTFRVWxNaFdtTGpNa0ZUU0tmTWh4ZTgz?= =?utf-8?B?VENmbWhESWl5ZUppLzBtYzhGdlg3MjVUNURmV3VNU2JMS0Q0bWdZcUMyYnFk?= =?utf-8?B?NzF0aGZ2V3lpK1RQeFlMcStVdkIvWndiaSt3ZktEQjlyZjBFdVp0amNLWVFV?= =?utf-8?B?eWdCMFVJNnl0cnBLVmtCcDQ1RkkzTG1rVmtYMFgwbG5GVXIxUjZVN1F5TTYx?= =?utf-8?B?TjBFMjZUQVU2OVRSeDVLb1JjRSs5YW9EQTVzUFpCd1FTRGpBenB4dFlxL2R3?= =?utf-8?Q?YLxWJwCCGODOhiDvAWJ1b8fj6?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd4781b2-5084-4f98-320c-08dd6c6841b7 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8604.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2025 13:15:20.8418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q0HhWxyUWb12JkdeAkeo8EudUqjTgd8IOgVeY72iUT0u1PPrA2vgv65R5et1s3ASCiBAg1vYm8LFRPbc7+cHgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8828 Adds the driver for communication interface to secure-enclave, for exchanging messages with NXP secure enclave HW IP(s) like EdgeLock Enclave from: - User-Space Applications via character driver. ABI documentation for the NXP secure-enclave driver. User-space library using this driver: - i.MX Secure Enclave library: -- URL: https://github.com/nxp-imx/imx-secure-enclave.git, - i.MX Secure Middle-Ware: -- URL: https://github.com/nxp-imx/imx-smw.git Signed-off-by: Pankaj Gupta --- changes from v13 to v14 - moved definition of func se_load_firmware, from 4/6 patch to this patch. - split init_device_context to init_misc_device_context. - Different value of se_rcv_msg_timeout is required to be set. Receiving th= e response of 4K RSA operation can to take upto 3 minutes. This long value cannot be set during Linux: boot-up and suspend-resume. Hence, it will be set to default small-value during Linux: boot-up and su= spend-resume. - func se_dev_ctx_cpy_out_data(), in either case: do_cpy true or false, the= clean-up needs to be done and it is implemented like wise. Once do_cpy is false, no need to continue copy to user buffer. But contin= ue to do clean-up. hence cannot return. And every dev-ctx operation is done after taking the lock. Hence, two ope= rations with same dev-ctx is not possible in parallel. - func "init_device_context", for 0th misc dev_ctx, which is created at the= time of probe, the device memory management is required. hence there is a = difference. - func "init_device_context", dev_er is replaced with return dev_err_probe. - func "init_device_context", devm_add_action is replaced by devm_add_actio= n_reset. - removed type-cast from func se_ioctl_get_se_soc_info_handler(). - used scoped_cond_guard(mutex, _intr, return -EBUSY, &) - combined dev_err & dev_dbg to one dev_err in se_if_fops_read(). - removed the structure member "se_shared_mem_mgmt->secure_mem". --- Documentation/ABI/testing/se-cdev | 43 ++ drivers/firmware/imx/ele_common.c | 70 +++- drivers/firmware/imx/ele_common.h | 8 +- drivers/firmware/imx/se_ctrl.c | 797 ++++++++++++++++++++++++++++++++++= +++- drivers/firmware/imx/se_ctrl.h | 34 ++ include/uapi/linux/se_ioctl.h | 101 +++++ 6 files changed, 1024 insertions(+), 29 deletions(-) diff --git a/Documentation/ABI/testing/se-cdev b/Documentation/ABI/testing/= se-cdev new file mode 100644 index 000000000000..dad39ffd245a --- /dev/null +++ b/Documentation/ABI/testing/se-cdev @@ -0,0 +1,43 @@ +What: /dev/_mu[0-9]+_ch[0-9]+ +Date: Mar 2025 +KernelVersion: 6.8 +Contact: linux-imx@nxp.com, pankaj.gupta@nxp.com +Description: + NXP offers multiple hardware IP(s) for secure enclaves like EdgeLock- + Enclave(ELE), SECO. The character device file descriptors + /dev/_mu*_ch* are the interface between userspace NXP's secure- + enclave shared library and the kernel driver. + + The ioctl(2)-based ABI is defined and documented in + [include]. + ioctl(s) are used primarily for: + - shared memory management + - allocation of I/O buffers + - getting mu info + - setting a dev-ctx as receiver to receive all the commands from FW + - getting SoC info + - send command and receive command response + + The following file operations are supported: + + open(2) + Currently the only useful flags are O_RDWR. + + read(2) + Every read() from the opened character device context is waiting on + wait_event_interruptible, that gets set by the registered mailbox call= back + function, indicating a message received from the firmware on message- + unit. + + write(2) + Every write() to the opened character device context needs to acquire + mailbox_lock before sending message on to the message unit. + + close(2) + Stops and frees up the I/O contexts that were associated + with the file descriptor. + +Users: https://github.com/nxp-imx/imx-secure-enclave.git, + https://github.com/nxp-imx/imx-smw.git + crypto/skcipher, + drivers/nvmem/imx-ocotp-ele.c diff --git a/drivers/firmware/imx/ele_common.c b/drivers/firmware/imx/ele_c= ommon.c index f75a8237e353..7978772f034d 100644 --- a/drivers/firmware/imx/ele_common.c +++ b/drivers/firmware/imx/ele_common.c @@ -6,6 +6,8 @@ #include "ele_base_msg.h" #include "ele_common.h" =20 +u32 se_rcv_msg_timeout =3D SE_RCV_MSG_DEFAULT_TIMEOUT; + /* * se_add_msg_chksum() - to calculate checksum word by word. * @@ -38,32 +40,52 @@ u32 se_add_msg_chksum(u32 *msg, u32 msg_len) return chksum; } =20 -int ele_msg_rcv(struct se_if_priv *priv, +void set_se_rcv_msg_timeout(u32 val) +{ + se_rcv_msg_timeout =3D val; +} + +int ele_msg_rcv(struct se_if_device_ctx *dev_ctx, struct se_clbk_handle *se_clbk_hdl) { - int err =3D 0; + struct se_if_priv *priv =3D dev_ctx->priv; + unsigned int wait; + int ret; =20 do { - err =3D wait_for_completion_interruptible(&se_clbk_hdl->done); - if (err =3D=3D -ERESTARTSYS) { - if (priv->waiting_rsp_clbk_hdl.rx_msg) { + wait =3D priv->cmd_receiver_clbk_hdl.dev_ctx =3D=3D dev_ctx ? + MAX_SCHEDULE_TIMEOUT : msecs_to_jiffies(se_rcv_msg_timeout); + + ret =3D wait_for_completion_interruptible_timeout(&se_clbk_hdl->done, wa= it); + + if (ret =3D=3D -ERESTARTSYS) { + if (priv->waiting_rsp_clbk_hdl.dev_ctx) { priv->waiting_rsp_clbk_hdl.signal_rcvd =3D true; continue; } + ret =3D -EINTR; + break; + } + if (ret =3D=3D 0) { + ret =3D -ETIMEDOUT; dev_err(priv->dev, - "Err[0x%x]:Interrupted by signal.\n", err); - err =3D -EINTR; + "Fatal Error: SE interface: %s%d, hangs indefinitely.\n", + get_se_if_name(priv->if_defs->se_if_type), + priv->if_defs->se_instance_id); break; } - } while (err !=3D 0); + ret =3D se_clbk_hdl->rx_msg_sz; + break; + } while (ret < 0); =20 - return err ? err : se_clbk_hdl->rx_msg_sz; + return ret; } =20 -int ele_msg_send(struct se_if_priv *priv, +int ele_msg_send(struct se_if_device_ctx *dev_ctx, void *tx_msg, int tx_msg_sz) { + struct se_if_priv *priv =3D dev_ctx->priv; struct se_msg_hdr *header =3D tx_msg; int err; =20 @@ -73,7 +95,8 @@ int ele_msg_send(struct se_if_priv *priv, */ if (header->size << 2 !=3D tx_msg_sz) { dev_err(priv->dev, - "User buf hdr: 0x%x, sz mismatced with input-sz (%d !=3D %d).", + "%s: User buf hdr: 0x%x, sz mismatced with input-sz (%d !=3D %d).", + dev_ctx->devname, *(u32 *)header, header->size << 2, tx_msg_sz); return -EINVAL; @@ -81,7 +104,9 @@ int ele_msg_send(struct se_if_priv *priv, =20 err =3D mbox_send_message(priv->tx_chan, tx_msg); if (err < 0) { - dev_err(priv->dev, "Error: mbox_send_message failure.\n"); + dev_err(priv->dev, + "%s: Error: mbox_send_message failure.", + dev_ctx->devname); return err; } =20 @@ -100,21 +125,24 @@ int ele_msg_send_rcv(struct se_if_device_ctx *dev_ctx, =20 guard(mutex)(&priv->se_if_cmd_lock); =20 + priv->waiting_rsp_clbk_hdl.dev_ctx =3D dev_ctx; priv->waiting_rsp_clbk_hdl.rx_msg_sz =3D exp_rx_msg_sz; priv->waiting_rsp_clbk_hdl.rx_msg =3D rx_msg; =20 - err =3D ele_msg_send(priv, tx_msg, tx_msg_sz); + err =3D ele_msg_send(dev_ctx, tx_msg, tx_msg_sz); if (err < 0) return err; =20 - err =3D ele_msg_rcv(priv, &priv->waiting_rsp_clbk_hdl); + err =3D ele_msg_rcv(dev_ctx, &priv->waiting_rsp_clbk_hdl); =20 if (priv->waiting_rsp_clbk_hdl.signal_rcvd) { err =3D -EINTR; priv->waiting_rsp_clbk_hdl.signal_rcvd =3D false; dev_err(priv->dev, - "Err[0x%x]:Interrupted by signal.\n", err); + "%s: Err[0x%x]:Interrupted by signal.\n", + dev_ctx->devname, err); } + priv->waiting_rsp_clbk_hdl.dev_ctx =3D NULL; =20 return err; } @@ -160,7 +188,8 @@ void se_if_rx_callback(struct mbox_client *mbox_cl, voi= d *msg) if (header->tag =3D=3D priv->if_defs->cmd_tag) { se_clbk_hdl =3D &priv->cmd_receiver_clbk_hdl; dev_dbg(dev, - "Selecting cmd receiver for mesg header:0x%x.", + "Selecting cmd receiver:%s for mesg header:0x%x.", + se_clbk_hdl->dev_ctx->devname, *(u32 *)header); =20 /* Pre-allocated buffer of MAX_NVM_MSG_LEN @@ -169,7 +198,8 @@ void se_if_rx_callback(struct mbox_client *mbox_cl, voi= d *msg) */ if (rx_msg_sz > MAX_NVM_MSG_LEN) { dev_err(dev, - "CMD-RCVER NVM: hdr(0x%x) with different sz(%d !=3D %d).\n", + "%s: CMD-RCVER NVM: hdr(0x%x) with different sz(%d !=3D %d).\n", + se_clbk_hdl->dev_ctx->devname, *(u32 *)header, rx_msg_sz, se_clbk_hdl->rx_msg_sz); =20 @@ -180,13 +210,15 @@ void se_if_rx_callback(struct mbox_client *mbox_cl, v= oid *msg) } else if (header->tag =3D=3D priv->if_defs->rsp_tag) { se_clbk_hdl =3D &priv->waiting_rsp_clbk_hdl; dev_dbg(dev, - "Selecting resp waiter for mesg header:0x%x.", + "Selecting resp waiter:%s for mesg header:0x%x.", + se_clbk_hdl->dev_ctx->devname, *(u32 *)header); =20 if (rx_msg_sz !=3D se_clbk_hdl->rx_msg_sz && check_hdr_exception_for_sz(priv, header)) { dev_err(dev, - "Rsp to CMD: hdr(0x%x) with different sz(%d !=3D %d).\n", + "%s: Rsp to CMD: hdr(0x%x) with different sz(%d !=3D %d).\n", + se_clbk_hdl->dev_ctx->devname, *(u32 *)header, rx_msg_sz, se_clbk_hdl->rx_msg_sz); =20 diff --git a/drivers/firmware/imx/ele_common.h b/drivers/firmware/imx/ele_c= ommon.h index a6bf93f0048f..dc7da69c0f92 100644 --- a/drivers/firmware/imx/ele_common.h +++ b/drivers/firmware/imx/ele_common.h @@ -12,10 +12,14 @@ =20 #define IMX_ELE_FW_DIR "imx/ele/" =20 +#define SE_RCV_MSG_DEFAULT_TIMEOUT 5000 +#define SE_RCV_MSG_LONG_TIMEOUT 5000000 + +void set_se_rcv_msg_timeout(u32 val); u32 se_add_msg_chksum(u32 *msg, u32 msg_len); -int ele_msg_rcv(struct se_if_priv *priv, +int ele_msg_rcv(struct se_if_device_ctx *dev_ctx, struct se_clbk_handle *se_clbk_hdl); -int ele_msg_send(struct se_if_priv *priv, +int ele_msg_send(struct se_if_device_ctx *dev_ctx, void *tx_msg, int tx_msg_sz); int ele_msg_send_rcv(struct se_if_device_ctx *dev_ctx, diff --git a/drivers/firmware/imx/se_ctrl.c b/drivers/firmware/imx/se_ctrl.c index 144a727bbfe0..9dbe866b7b13 100644 --- a/drivers/firmware/imx/se_ctrl.c +++ b/drivers/firmware/imx/se_ctrl.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #include "ele_base_msg.h" #include "ele_common.h" @@ -31,8 +32,6 @@ #define MAX_SOC_INFO_DATA_SZ 256 #define MBOX_TX_NAME "tx" #define MBOX_RX_NAME "rx" -#define SE_TYPE_STR_HSM "hsm" -#define SE_TYPE_ID_HSM 0x2 =20 struct se_fw_img_name { const u8 *prim_fw_nm_in_rfs; @@ -118,6 +117,24 @@ static const struct of_device_id se_match[] =3D { {}, }; =20 +char *get_se_if_name(u8 se_if_id) +{ + switch (se_if_id) { + case SE_TYPE_ID_DBG: return SE_TYPE_STR_DBG; + case SE_TYPE_ID_HSM: return SE_TYPE_STR_HSM; + } + + return NULL; +} + +static uint32_t get_se_soc_id(struct se_if_priv *priv) +{ + const struct se_soc_info *se_info =3D + device_get_match_data(priv->dev); + + return se_info->soc_id; +} + static struct se_fw_load_info *get_load_fw_instance(struct se_if_priv *pri= v) { return &var_se_info.load_fw; @@ -191,31 +208,785 @@ static int get_se_soc_info(struct se_if_priv *priv, = const struct se_soc_info *se return 0; } =20 -static int init_misc_device_context(struct se_if_priv *priv, int ch_id, - struct se_if_device_ctx **new_dev_ctx) +static int load_firmware(struct se_if_priv *priv, const u8 *se_img_file_to= _load) +{ + const struct firmware *fw =3D NULL; + phys_addr_t se_fw_phyaddr; + u8 *se_fw_buf; + int ret; + + if (!se_img_file_to_load) { + dev_err(priv->dev, "FW image is not provided."); + return -EINVAL; + } + ret =3D request_firmware(&fw, se_img_file_to_load, priv->dev); + if (ret) + return ret; + + dev_info(priv->dev, "loading firmware %s\n", se_img_file_to_load); + + /* allocate buffer to store the SE FW */ + se_fw_buf =3D dma_alloc_coherent(priv->dev, fw->size, + &se_fw_phyaddr, GFP_KERNEL); + if (!se_fw_buf) + return -ENOMEM; + + memcpy(se_fw_buf, fw->data, fw->size); + ret =3D ele_fw_authenticate(priv, se_fw_phyaddr); + if (ret < 0) { + dev_err(priv->dev, + "Error %pe: Authenticate & load SE firmware %s.\n", + ERR_PTR(ret), + se_img_file_to_load); + ret =3D -EPERM; + } + + dma_free_coherent(priv->dev, + fw->size, + se_fw_buf, + se_fw_phyaddr); + + release_firmware(fw); + + return ret; +} + +static int se_load_firmware(struct se_if_priv *priv) +{ + struct se_fw_load_info *load_fw =3D get_load_fw_instance(priv); + int ret =3D 0; + + if (!load_fw->is_fw_tobe_loaded) + return 0; + + if (load_fw->imem.state =3D=3D ELE_IMEM_STATE_BAD) { + ret =3D load_firmware(priv, load_fw->se_fw_img_nm->prim_fw_nm_in_rfs); + if (ret) { + dev_err(priv->dev, "Failed to load boot firmware."); + return -EPERM; + } + } + + ret =3D load_firmware(priv, load_fw->se_fw_img_nm->seco_fw_nm_in_rfs); + if (ret) { + dev_err(priv->dev, "Failed to load runtime firmware."); + return -EPERM; + } + + load_fw->is_fw_tobe_loaded =3D false; + + return ret; +} + +static int init_se_shared_mem(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_if_priv *priv =3D dev_ctx->priv; + + INIT_LIST_HEAD(&se_shared_mem_mgmt->pending_out); + INIT_LIST_HEAD(&se_shared_mem_mgmt->pending_in); + + /* + * Allocate some memory for data exchanges with S40x. + * This will be used for data not requiring secure memory. + */ + se_shared_mem_mgmt->non_secure_mem.ptr =3D + dma_alloc_coherent(priv->dev, + MAX_DATA_SIZE_PER_USER, + &se_shared_mem_mgmt->non_secure_mem.dma_addr, + GFP_KERNEL); + if (!se_shared_mem_mgmt->non_secure_mem.ptr) + return -ENOMEM; + + se_shared_mem_mgmt->non_secure_mem.size =3D MAX_DATA_SIZE_PER_USER; + se_shared_mem_mgmt->non_secure_mem.pos =3D 0; + + return 0; +} + +static void cleanup_se_shared_mem(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_if_priv *priv =3D dev_ctx->priv; + + /* Free non-secure shared buffer. */ + dma_free_coherent(priv->dev, MAX_DATA_SIZE_PER_USER, + se_shared_mem_mgmt->non_secure_mem.ptr, + se_shared_mem_mgmt->non_secure_mem.dma_addr); + + se_shared_mem_mgmt->non_secure_mem.ptr =3D NULL; + se_shared_mem_mgmt->non_secure_mem.dma_addr =3D 0; + se_shared_mem_mgmt->non_secure_mem.size =3D 0; + se_shared_mem_mgmt->non_secure_mem.pos =3D 0; +} + +/* Need to copy the output data to user-device context. + */ +static int se_dev_ctx_cpy_out_data(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_if_priv *priv =3D dev_ctx->priv; + struct se_buf_desc *b_desc, *temp; + bool do_cpy =3D true; + + list_for_each_entry_safe(b_desc, temp, &se_shared_mem_mgmt->pending_out, = link) { + // TBD + if (b_desc->usr_buf_ptr && b_desc->shared_buf_ptr && do_cpy) { + dev_dbg(priv->dev, + "Copying output data to user."); + if (do_cpy && copy_to_user(b_desc->usr_buf_ptr, + b_desc->shared_buf_ptr, + b_desc->size)) { + dev_err(priv->dev, + "Failure copying output data to user."); + do_cpy =3D false; + } + } + + if (b_desc->shared_buf_ptr) + memset(b_desc->shared_buf_ptr, 0, b_desc->size); + + list_del(&b_desc->link); + kfree(b_desc); + } + + return do_cpy ? 0 : -EFAULT; +} + +/* + * Clean the used Shared Memory space, + * whether its Input Data copied from user buffers, or + * Data received from FW. + */ +static void se_dev_ctx_shared_mem_cleanup(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct list_head *pending_lists[] =3D {&se_shared_mem_mgmt->pending_in, + &se_shared_mem_mgmt->pending_out}; + struct se_buf_desc *b_desc, *temp; + int i; + + for (i =3D 0; i < 2; i++) { + list_for_each_entry_safe(b_desc, temp, + pending_lists[i], link) { + if (b_desc->shared_buf_ptr) + memset(b_desc->shared_buf_ptr, 0, b_desc->size); + + list_del(&b_desc->link); + kfree(b_desc); + } + } + se_shared_mem_mgmt->non_secure_mem.pos =3D 0; +} + +static int add_b_desc_to_pending_list(void *shared_ptr_with_pos, + struct se_ioctl_setup_iobuf *io, + struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_buf_desc *b_desc =3D NULL; + + b_desc =3D kzalloc(sizeof(*b_desc), GFP_KERNEL); + if (!b_desc) + return -ENOMEM; + + b_desc->shared_buf_ptr =3D shared_ptr_with_pos; + b_desc->usr_buf_ptr =3D io->user_buf; + b_desc->size =3D io->length; + + if (io->flags & SE_IO_BUF_FLAGS_IS_INPUT) { + /* + * buffer is input: + * add an entry in the "pending input buffers" list so + * that copied data can be cleaned from shared memory + * later. + */ + list_add_tail(&b_desc->link, &se_shared_mem_mgmt->pending_in); + } else { + /* + * buffer is output: + * add an entry in the "pending out buffers" list so data + * can be copied to user space when receiving Secure-Enclave + * response. + */ + list_add_tail(&b_desc->link, &se_shared_mem_mgmt->pending_out); + } + + return 0; +} + +/* interface for managed res to unregister a character device */ +static void if_misc_deregister(void *miscdevice) +{ + misc_deregister(miscdevice); +} + +static int init_device_context(struct se_if_priv *priv, int ch_id, + struct se_if_device_ctx **new_dev_ctx) { struct se_if_device_ctx *dev_ctx; int ret =3D 0; =20 - dev_ctx =3D devm_kzalloc(priv->dev, sizeof(*dev_ctx), GFP_KERNEL); + dev_ctx =3D kzalloc(sizeof(*dev_ctx), GFP_KERNEL); =20 if (!dev_ctx) return -ENOMEM; =20 + dev_ctx->devname =3D kasprintf(GFP_KERNEL, "%s%d_ch%d", + get_se_if_name(priv->if_defs->se_if_type), + priv->if_defs->se_instance_id, + ch_id); + if (!dev_ctx->devname) { + kfree(dev_ctx); + return -ENOMEM; + } + + mutex_init(&dev_ctx->fops_lock); dev_ctx->priv =3D priv; + *new_dev_ctx =3D dev_ctx; + + list_add_tail(&dev_ctx->link, &priv->dev_ctx_list); + priv->active_devctx_count++; + + ret =3D init_se_shared_mem(dev_ctx); + if (ret < 0) { + kfree(dev_ctx->devname); + kfree(dev_ctx); + *new_dev_ctx =3D NULL; + } + + return ret; +} + +static int init_misc_device_context(struct se_if_priv *priv, int ch_id, + struct se_if_device_ctx **new_dev_ctx, + const struct file_operations *se_if_fops) +{ + struct se_if_device_ctx *dev_ctx; + int ret =3D 0; + + dev_ctx =3D devm_kzalloc(priv->dev, sizeof(*dev_ctx), GFP_KERNEL); + + if (!dev_ctx) + return -ENOMEM; =20 dev_ctx->devname =3D devm_kasprintf(priv->dev, GFP_KERNEL, "%s%d_ch%d", - SE_TYPE_STR_HSM, + get_se_if_name(priv->if_defs->se_if_type), priv->if_defs->se_instance_id, ch_id); if (!dev_ctx->devname) return -ENOMEM; =20 + mutex_init(&dev_ctx->fops_lock); + + dev_ctx->priv =3D priv; *new_dev_ctx =3D dev_ctx; =20 + dev_ctx->miscdev =3D devm_kzalloc(priv->dev, sizeof(*dev_ctx->miscdev), G= FP_KERNEL); + if (!dev_ctx->miscdev) { + *new_dev_ctx =3D NULL; + return -ENOMEM; + } + + dev_ctx->miscdev->name =3D dev_ctx->devname; + dev_ctx->miscdev->minor =3D MISC_DYNAMIC_MINOR; + dev_ctx->miscdev->fops =3D se_if_fops; + dev_ctx->miscdev->parent =3D priv->dev; + ret =3D misc_register(dev_ctx->miscdev); + if (ret) + return dev_err_probe(priv->dev, ret, "Failed to register misc device."); + + ret =3D devm_add_action_or_reset(priv->dev, if_misc_deregister, + dev_ctx->miscdev); + if (ret) + return dev_err_probe(priv->dev, ret, + "Failed to add action to the misc-dev."); return ret; } =20 +static int se_ioctl_cmd_snd_rcv_rsp_handler(struct se_if_device_ctx *dev_c= tx, + u64 arg) +{ + struct se_ioctl_cmd_snd_rcv_rsp_info cmd_snd_rcv_rsp_info =3D {0}; + struct se_api_msg *tx_msg __free(kfree) =3D NULL; + struct se_api_msg *rx_msg __free(kfree) =3D NULL; + struct se_if_priv *priv =3D dev_ctx->priv; + int err =3D 0; + + if (copy_from_user(&cmd_snd_rcv_rsp_info, (u8 __user *)arg, + sizeof(cmd_snd_rcv_rsp_info))) { + dev_err(priv->dev, + "%s: Failed to copy cmd_snd_rcv_rsp_info from user\n", + dev_ctx->devname); + err =3D -EFAULT; + goto exit; + } + + if (cmd_snd_rcv_rsp_info.tx_buf_sz < SE_MU_HDR_SZ) { + dev_err(priv->dev, + "%s: User buffer too small(%d < %d)\n", + dev_ctx->devname, + cmd_snd_rcv_rsp_info.tx_buf_sz, + SE_MU_HDR_SZ); + err =3D -ENOSPC; + goto exit; + } + + rx_msg =3D kzalloc(cmd_snd_rcv_rsp_info.rx_buf_sz, GFP_KERNEL); + if (!rx_msg) { + err =3D -ENOMEM; + goto exit; + } + + tx_msg =3D memdup_user(cmd_snd_rcv_rsp_info.tx_buf, + cmd_snd_rcv_rsp_info.tx_buf_sz); + if (IS_ERR(tx_msg)) { + err =3D PTR_ERR(tx_msg); + goto exit; + } + + if (tx_msg->header.tag !=3D priv->if_defs->cmd_tag) { + err =3D -EINVAL; + goto exit; + } + + if (tx_msg->header.ver =3D=3D priv->if_defs->fw_api_ver && + get_load_fw_instance(priv)->is_fw_tobe_loaded) { + err =3D se_load_firmware(priv); + if (err) { + dev_err(priv->dev, "Could not send the message as FW is not loaded."); + err =3D -EPERM; + goto exit; + } + } + set_se_rcv_msg_timeout(SE_RCV_MSG_LONG_TIMEOUT); + + err =3D ele_msg_send_rcv(dev_ctx, + tx_msg, + cmd_snd_rcv_rsp_info.tx_buf_sz, + rx_msg, + cmd_snd_rcv_rsp_info.rx_buf_sz); + if (err < 0) + goto exit; + + dev_dbg(priv->dev, + "%s: %s %s\n", + dev_ctx->devname, + __func__, + "message received, start transmit to user"); + + /* We may need to copy the output data to user before + * delivering the completion message. + */ + err =3D se_dev_ctx_cpy_out_data(dev_ctx); + if (err < 0) + goto exit; + + /* Copy data from the buffer */ + print_hex_dump_debug("to user ", DUMP_PREFIX_OFFSET, 4, 4, + rx_msg, + cmd_snd_rcv_rsp_info.rx_buf_sz, false); + + if (copy_to_user(cmd_snd_rcv_rsp_info.rx_buf, rx_msg, + cmd_snd_rcv_rsp_info.rx_buf_sz)) { + dev_err(priv->dev, + "%s: Failed to copy to user\n", + dev_ctx->devname); + err =3D -EFAULT; + } + +exit: + + /* shared memory is allocated before this IOCTL */ + se_dev_ctx_shared_mem_cleanup(dev_ctx); + + if (copy_to_user((void __user *)arg, &cmd_snd_rcv_rsp_info, + sizeof(cmd_snd_rcv_rsp_info))) { + dev_err(priv->dev, + "%s: Failed to copy cmd_snd_rcv_rsp_info from user\n", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +static int se_ioctl_get_mu_info(struct se_if_device_ctx *dev_ctx, + u64 arg) +{ + struct se_if_priv *priv =3D dev_ctx->priv; + struct se_ioctl_get_if_info if_info; + struct se_if_node *if_node; + int err =3D 0; + + if_node =3D container_of(priv->if_defs, typeof(*if_node), if_defs); + + if_info.se_if_id =3D 0; + if_info.interrupt_idx =3D 0; + if_info.tz =3D 0; + if_info.did =3D 0; + if_info.cmd_tag =3D priv->if_defs->cmd_tag; + if_info.rsp_tag =3D priv->if_defs->rsp_tag; + if_info.success_tag =3D priv->if_defs->success_tag; + if_info.base_api_ver =3D priv->if_defs->base_api_ver; + if_info.fw_api_ver =3D priv->if_defs->fw_api_ver; + + dev_dbg(priv->dev, + "%s: info [se_if_id: %d, irq_idx: %d, tz: 0x%x, did: 0x%x]\n", + dev_ctx->devname, + if_info.se_if_id, if_info.interrupt_idx, + if_info.tz, if_info.did); + + if (copy_to_user((u8 __user *)arg, &if_info, sizeof(if_info))) { + dev_err(priv->dev, + "%s: Failed to copy mu info to user\n", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +/* + * Copy a buffer of data to/from the user and return the address to use in + * messages + */ +static int se_ioctl_setup_iobuf_handler(struct se_if_device_ctx *dev_ctx, + u64 arg) +{ + struct se_shared_mem *shared_mem =3D NULL; + struct se_ioctl_setup_iobuf io =3D {0}; + int err =3D 0; + u32 pos; + + if (copy_from_user(&io, (u8 __user *)arg, sizeof(io))) { + dev_err(dev_ctx->priv->dev, + "%s: Failed copy iobuf config from user\n", + dev_ctx->devname); + return -EFAULT; + } + + dev_dbg(dev_ctx->priv->dev, + "%s: io [buf: %p(%d) flag: %x]\n", + dev_ctx->devname, + io.user_buf, io.length, io.flags); + + if (io.length =3D=3D 0 || !io.user_buf) { + /* + * Accept NULL pointers since some buffers are optional + * in FW commands. In this case we should return 0 as + * pointer to be embedded into the message. + * Skip all data copy part of code below. + */ + io.ele_addr =3D 0; + goto copy; + } + + /* No specific requirement for this buffer. */ + shared_mem =3D &dev_ctx->se_shared_mem_mgmt.non_secure_mem; + + /* Check there is enough space in the shared memory. */ + dev_dbg(dev_ctx->priv->dev, + "%s: req_size =3D %d, max_size=3D %d, curr_pos =3D %d", + dev_ctx->devname, + round_up(io.length, 8u), + shared_mem->size, shared_mem->pos); + + if (shared_mem->size < shared_mem->pos || + round_up(io.length, 8u) > (shared_mem->size - shared_mem->pos)) { + dev_err(dev_ctx->priv->dev, + "%s: Not enough space in shared memory\n", + dev_ctx->devname); + return -ENOMEM; + } + + /* Allocate space in shared memory. 8 bytes aligned. */ + pos =3D shared_mem->pos; + shared_mem->pos +=3D round_up(io.length, 8u); + io.ele_addr =3D (u64)shared_mem->dma_addr + pos; + + memset(shared_mem->ptr + pos, 0, io.length); + if ((io.flags & SE_IO_BUF_FLAGS_IS_INPUT) || + (io.flags & SE_IO_BUF_FLAGS_IS_IN_OUT)) { + /* + * buffer is input: + * copy data from user space to this allocated buffer. + */ + if (copy_from_user(shared_mem->ptr + pos, io.user_buf, + io.length)) { + dev_err(dev_ctx->priv->dev, + "%s: Failed copy data to shared memory\n", + dev_ctx->devname); + return -EFAULT; + } + } + + err =3D add_b_desc_to_pending_list(shared_mem->ptr + pos, + &io, + dev_ctx); + if (err < 0) + dev_err(dev_ctx->priv->dev, + "%s: Failed to allocate/link b_desc.", + dev_ctx->devname); + +copy: + /* Provide the EdgeLock Enclave address to user space only if success.*/ + if (copy_to_user((u8 __user *)arg, &io, sizeof(io))) { + dev_err(dev_ctx->priv->dev, + "%s: Failed to copy iobuff setup to user.", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +/* IOCTL to provide SoC information */ +static int se_ioctl_get_se_soc_info_handler(struct se_if_device_ctx *dev_c= tx, + u64 arg) +{ + struct se_ioctl_get_soc_info soc_info; + int err =3D -EINVAL; + + soc_info.soc_id =3D get_se_soc_id(dev_ctx->priv); + soc_info.soc_rev =3D var_se_info.soc_rev; + + err =3D copy_to_user((u8 __user *)arg, (u8 *)(&soc_info), sizeof(soc_info= )); + if (err) { + dev_err(dev_ctx->priv->dev, + "%s: Failed to copy soc info to user\n", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +/* + * File operations for user-space + */ + +/* Write a message to the MU. */ +static ssize_t se_if_fops_write(struct file *fp, const char __user *buf, + size_t size, loff_t *ppos) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_api_msg *tx_msg __free(kfree) =3D NULL; + struct se_if_priv *priv =3D dev_ctx->priv; + int err; + + dev_dbg(priv->dev, + "%s: write from buf (%p)%zu, ppos=3D%lld\n", + dev_ctx->devname, + buf, size, ((ppos) ? *ppos : 0)); + + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + if (dev_ctx !=3D priv->cmd_receiver_clbk_hdl.dev_ctx) + return -EINVAL; + + if (size < SE_MU_HDR_SZ) { + dev_err(priv->dev, + "%s: User buffer too small(%zu < %d)\n", + dev_ctx->devname, + size, SE_MU_HDR_SZ); + return -ENOSPC; + } + + tx_msg =3D memdup_user(buf, size); + if (IS_ERR(tx_msg)) + return PTR_ERR(tx_msg); + + print_hex_dump_debug("from user ", DUMP_PREFIX_OFFSET, 4, 4, + tx_msg, size, false); + + err =3D ele_msg_send(dev_ctx, tx_msg, size); + + return err; + } +} + +/* + * Read a message from the MU. + * Blocking until a message is available. + */ +static ssize_t se_if_fops_read(struct file *fp, char __user *buf, + size_t size, loff_t *ppos) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_if_priv *priv =3D dev_ctx->priv; + int err; + + dev_dbg(priv->dev, + "%s: read to buf %p(%zu), ppos=3D%lld\n", + dev_ctx->devname, + buf, size, ((ppos) ? *ppos : 0)); + + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + if (dev_ctx !=3D priv->cmd_receiver_clbk_hdl.dev_ctx) { + err =3D -EINVAL; + goto exit; + } + + err =3D ele_msg_rcv(dev_ctx, &priv->cmd_receiver_clbk_hdl); + if (err < 0) { + dev_err(priv->dev, + "%s: Err[0x%x]:Interrupted by signal." + "Current active dev-ctx count =3D %d.", + dev_ctx->devname, err, + dev_ctx->priv->active_devctx_count); + goto exit; + } + + /* We may need to copy the output data to user before + * delivering the completion message. + */ + err =3D se_dev_ctx_cpy_out_data(dev_ctx); + if (err < 0) + goto exit; + + /* Copy data from the buffer */ + print_hex_dump_debug("to user ", DUMP_PREFIX_OFFSET, 4, 4, + priv->cmd_receiver_clbk_hdl.rx_msg, + priv->cmd_receiver_clbk_hdl.rx_msg_sz, + false); + + if (copy_to_user(buf, priv->cmd_receiver_clbk_hdl.rx_msg, + priv->cmd_receiver_clbk_hdl.rx_msg_sz)) { + dev_err(priv->dev, + "%s: Failed to copy to user\n", + dev_ctx->devname); + err =3D -EFAULT; + } else { + err =3D priv->cmd_receiver_clbk_hdl.rx_msg_sz; + } +exit: + priv->cmd_receiver_clbk_hdl.rx_msg_sz =3D 0; + + se_dev_ctx_shared_mem_cleanup(dev_ctx); + + return err; + } +} + +/* Open a character device. */ +static int se_if_fops_open(struct inode *nd, struct file *fp) +{ + struct miscdevice *miscdev =3D fp->private_data; + struct se_if_device_ctx *misc_dev_ctx; + struct se_if_device_ctx *dev_ctx; + struct se_if_priv *priv; + int err =3D 0; + + priv =3D dev_get_drvdata(miscdev->parent); + misc_dev_ctx =3D priv->priv_dev_ctx; + + scoped_cond_guard(mutex_intr, return -EBUSY, &misc_dev_ctx->fops_lock) { + priv->dev_ctx_mono_count++; + err =3D init_device_context(priv, + priv->dev_ctx_mono_count ? + priv->dev_ctx_mono_count + : priv->dev_ctx_mono_count++, + &dev_ctx); + if (err) + dev_err(priv->dev, + "Failed[0x%x] to create device contexts.\n", + err); + else + fp->private_data =3D dev_ctx; + + return err; + } +} + +/* Close a character device. */ +static int se_if_fops_close(struct inode *nd, struct file *fp) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_if_priv *priv =3D dev_ctx->priv; + + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + /* check if this device was registered as command receiver. */ + if (priv->cmd_receiver_clbk_hdl.dev_ctx =3D=3D dev_ctx) { + priv->cmd_receiver_clbk_hdl.dev_ctx =3D NULL; + kfree(priv->cmd_receiver_clbk_hdl.rx_msg); + priv->cmd_receiver_clbk_hdl.rx_msg =3D NULL; + } + + se_dev_ctx_shared_mem_cleanup(dev_ctx); + cleanup_se_shared_mem(dev_ctx); + + priv->active_devctx_count--; + list_del(&dev_ctx->link); + + kfree(dev_ctx->devname); + kfree(dev_ctx); + } + + return 0; +} + +/* IOCTL entry point of a character device */ +static long se_ioctl(struct file *fp, unsigned int cmd, unsigned long arg) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_if_priv *priv =3D dev_ctx->priv; + int err; + + /* Prevent race during change of device context */ + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + switch (cmd) { + case SE_IOCTL_ENABLE_CMD_RCV: + if (!priv->cmd_receiver_clbk_hdl.dev_ctx) { + if (!priv->cmd_receiver_clbk_hdl.rx_msg) { + priv->cmd_receiver_clbk_hdl.rx_msg =3D + kzalloc(MAX_NVM_MSG_LEN, + GFP_KERNEL); + if (!priv->cmd_receiver_clbk_hdl.rx_msg) { + err =3D -ENOMEM; + break; + } + } + priv->cmd_receiver_clbk_hdl.rx_msg_sz =3D MAX_NVM_MSG_LEN; + priv->cmd_receiver_clbk_hdl.dev_ctx =3D dev_ctx; + err =3D 0; + } else { + err =3D -EBUSY; + } + break; + case SE_IOCTL_GET_MU_INFO: + err =3D se_ioctl_get_mu_info(dev_ctx, arg); + break; + case SE_IOCTL_SETUP_IOBUF: + err =3D se_ioctl_setup_iobuf_handler(dev_ctx, arg); + break; + case SE_IOCTL_GET_SOC_INFO: + err =3D se_ioctl_get_se_soc_info_handler(dev_ctx, arg); + break; + case SE_IOCTL_CMD_SEND_RCV_RSP: + err =3D se_ioctl_cmd_snd_rcv_rsp_handler(dev_ctx, arg); + break; + default: + err =3D -EINVAL; + dev_dbg(priv->dev, + "%s: IOCTL %.8x not supported\n", + dev_ctx->devname, + cmd); + } + } + + return (long)err; +} + +/* Char driver setup */ +static const struct file_operations se_if_fops =3D { + .open =3D se_if_fops_open, + .owner =3D THIS_MODULE, + .release =3D se_if_fops_close, + .unlocked_ioctl =3D se_ioctl, + .read =3D se_if_fops_read, + .write =3D se_if_fops_write, +}; + /* interface for managed res to free a mailbox channel */ static void if_mbox_free_channel(void *mbox_chan) { @@ -247,6 +1018,7 @@ static int se_if_request_channel(struct device *dev, =20 static void se_if_probe_cleanup(void *plat_dev) { + struct se_if_device_ctx *dev_ctx, *t_dev_ctx; struct platform_device *pdev =3D plat_dev; struct se_fw_load_info *load_fw; struct device *dev =3D &pdev->dev; @@ -271,6 +1043,13 @@ static void se_if_probe_cleanup(void *plat_dev) load_fw->imem.buf =3D NULL; } =20 + if (priv->dev_ctx_mono_count) { + list_for_each_entry_safe(dev_ctx, t_dev_ctx, &priv->dev_ctx_list, link) { + list_del(&dev_ctx->link); + priv->active_devctx_count--; + } + } + /* No need to check, if reserved memory is allocated * before calling for its release. Or clearing the * un-set bit. @@ -334,6 +1113,7 @@ static int se_if_probe(struct platform_device *pdev) "Unable to get sram pool =3D %s.", if_node->pool_name); } + INIT_LIST_HEAD(&priv->dev_ctx_list); =20 if (if_node->reserved_dma_ranges) { ret =3D of_reserved_mem_device_init(dev); @@ -342,7 +1122,7 @@ static int se_if_probe(struct platform_device *pdev) "Failed to init reserved memory region."); } =20 - ret =3D init_misc_device_context(priv, 0, &priv->priv_dev_ctx); + ret =3D init_misc_device_context(priv, 0, &priv->priv_dev_ctx, &se_if_fop= s); if (ret) return dev_err_probe(dev, ret, "Failed[0x%x] to create device contexts.", @@ -374,7 +1154,7 @@ static int se_if_probe(struct platform_device *pdev) } } dev_info(dev, "i.MX secure-enclave: %s%d interface to firmware, configure= d.", - SE_TYPE_STR_HSM, + get_se_if_name(priv->if_defs->se_if_type), priv->if_defs->se_instance_id); =20 return ret; @@ -391,6 +1171,7 @@ static int se_suspend(struct device *dev) struct se_fw_load_info *load_fw; int ret =3D 0; =20 + set_se_rcv_msg_timeout(SE_RCV_MSG_DEFAULT_TIMEOUT); load_fw =3D get_load_fw_instance(priv); =20 if (load_fw->imem_mgmt) diff --git a/drivers/firmware/imx/se_ctrl.h b/drivers/firmware/imx/se_ctrl.h index f0893c5c9145..bd50caa4f135 100644 --- a/drivers/firmware/imx/se_ctrl.h +++ b/drivers/firmware/imx/se_ctrl.h @@ -14,6 +14,7 @@ #define SE_MSG_WORD_SZ 0x4 =20 #define RES_STATUS(x) FIELD_GET(0x000000ff, x) +#define MAX_DATA_SIZE_PER_USER (65 * 1024) #define MAX_NVM_MSG_LEN (256) #define MESSAGING_VERSION_6 0x6 #define MESSAGING_VERSION_7 0x7 @@ -21,6 +22,7 @@ struct se_clbk_handle { struct completion done; bool signal_rcvd; + struct se_if_device_ctx *dev_ctx; u32 rx_msg_sz; /* Assignment of the rx_msg buffer to held till the * received content as part callback function, is copied. @@ -35,10 +37,38 @@ struct se_imem_buf { u32 state; }; =20 +struct se_buf_desc { + u8 *shared_buf_ptr; + void __user *usr_buf_ptr; + u32 size; + struct list_head link; +}; + +struct se_shared_mem { + dma_addr_t dma_addr; + u32 size; + u32 pos; + u8 *ptr; +}; + +struct se_shared_mem_mgmt_info { + struct list_head pending_in; + struct list_head pending_out; + + struct se_shared_mem non_secure_mem; +}; + /* Private struct for each char device instance. */ struct se_if_device_ctx { struct se_if_priv *priv; + struct miscdevice *miscdev; const char *devname; + + /* process one file operation at a time. */ + struct mutex fops_lock; + + struct se_shared_mem_mgmt_info se_shared_mem_mgmt; + struct list_head link; }; =20 /* Header of the messages exchange with the EdgeLock Enclave */ @@ -87,6 +117,10 @@ struct se_if_priv { const struct se_if_defines *if_defs; =20 struct se_if_device_ctx *priv_dev_ctx; + struct list_head dev_ctx_list; + u32 active_devctx_count; + u32 dev_ctx_mono_count; }; =20 +char *get_se_if_name(u8 se_if_id); #endif diff --git a/include/uapi/linux/se_ioctl.h b/include/uapi/linux/se_ioctl.h new file mode 100644 index 000000000000..29a9b1ec5ec3 --- /dev/null +++ b/include/uapi/linux/se_ioctl.h @@ -0,0 +1,101 @@ +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Cla= use*/ +/* + * Copyright 2025 NXP + */ + +#ifndef SE_IOCTL_H +#define SE_IOCTL_H + +#include + +#define SE_TYPE_STR_DBG "dbg" +#define SE_TYPE_STR_HSM "hsm" +#define SE_TYPE_ID_UNKWN 0x0 +#define SE_TYPE_ID_DBG 0x1 +#define SE_TYPE_ID_HSM 0x2 +/* IOCTL definitions. */ + +struct se_ioctl_setup_iobuf { + void __user *user_buf; + __u32 length; + __u32 flags; + __u64 ele_addr; +}; + +struct se_ioctl_shared_mem_cfg { + __u32 base_offset; + __u32 size; +}; + +struct se_ioctl_get_if_info { + __u8 se_if_id; + __u8 interrupt_idx; + __u8 tz; + __u8 did; + __u8 cmd_tag; + __u8 rsp_tag; + __u8 success_tag; + __u8 base_api_ver; + __u8 fw_api_ver; +}; + +struct se_ioctl_cmd_snd_rcv_rsp_info { + __u32 __user *tx_buf; + int tx_buf_sz; + __u32 __user *rx_buf; + int rx_buf_sz; +}; + +struct se_ioctl_get_soc_info { + __u16 soc_id; + __u16 soc_rev; +}; + +/* IO Buffer Flags */ +#define SE_IO_BUF_FLAGS_IS_OUTPUT (0x00u) +#define SE_IO_BUF_FLAGS_IS_INPUT (0x01u) +#define SE_IO_BUF_FLAGS_USE_SEC_MEM (0x02u) +#define SE_IO_BUF_FLAGS_USE_SHORT_ADDR (0x04u) +#define SE_IO_BUF_FLAGS_IS_IN_OUT (0x10u) + +/* IOCTLS */ +#define SE_IOCTL 0x0A /* like MISC_MAJOR. */ + +/* + * ioctl to designated the current fd as logical-reciever. + * This is ioctl is send when the nvm-daemon, a slave to the + * firmware is started by the user. + */ +#define SE_IOCTL_ENABLE_CMD_RCV _IO(SE_IOCTL, 0x01) + +/* + * ioctl to get the buffer allocated from the memory, which is shared + * between kernel and FW. + * Post allocation, the kernel tagged the allocated memory with: + * Output + * Input + * Input-Output + * Short address + * Secure-memory + */ +#define SE_IOCTL_SETUP_IOBUF _IOWR(SE_IOCTL, 0x03, \ + struct se_ioctl_setup_iobuf) + +/* + * ioctl to get the mu information, that is used to exchange message + * with FW, from user-spaced. + */ +#define SE_IOCTL_GET_MU_INFO _IOR(SE_IOCTL, 0x04, \ + struct se_ioctl_get_if_info) +/* + * ioctl to get SoC Info from user-space. + */ +#define SE_IOCTL_GET_SOC_INFO _IOR(SE_IOCTL, 0x06, \ + struct se_ioctl_get_soc_info) + +/* + * ioctl to send command and receive response from user-space. + */ +#define SE_IOCTL_CMD_SEND_RCV_RSP _IOWR(SE_IOCTL, 0x07, \ + struct se_ioctl_cmd_snd_rcv_rsp_info) +#endif --=20 2.43.0