From nobody Fri Dec 19 13:46:25 2025 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11335256C79 for ; Wed, 26 Mar 2025 19:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743017813; cv=none; b=B9Tg7VluIF+FWwE8KWQl5Y9jxjkr5Z9RMuuDWOUzp7ldTCKycA6npU2KDFJPRwzrxdNGI5YOPKSnlB3u7OsQAIoeEOtaZFkc4mqxB+eUsO7sAvNF4fRN2L8Tqqd+lKCEOpGzCoJa/z84ujo7EP7iE3iSNcS1aK6nfIlsztXTvWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743017813; c=relaxed/simple; bh=slWjk6xRtGd8NNju/WBuTxaV0TwQqzjL7gF/Ou93OfM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OSHNjADHyt+61B46eoUv1jj0JOEXLQtl8iNbat28kffb5hKcuAenc1wuhDoByQFPa9/Hp1G6KrRsod2GLelO/g3iYFQ6hjVs+vMQNsH3Nd9u47g3lJDUK/Bkgzc2BXjm4+ep9/967uepUO0sV1e1ATQ69Wcrmz3lfOEW/UJPiow= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=q3a9184v; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="q3a9184v" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743017810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5odBDyCnSOvFrnA2jtebnIHNWBzNYLPFh+CwM5nazO8=; b=q3a9184voIe5GsqRhMGkZQ0UPkLdi9HGGr0JOQicgYw70KPVVx/KvcT17k4mOf20w0/EvI AecPV/21ppxUUvhWnb4kgfYS3k6ddxv0dydzDgz3iHc1Yu3P2KEWJy5KdhLeJC3ceW1WYi D7JhS2IORRRce3HpX4CtFyLpUyoQr1w= From: Yosry Ahmed To: Sean Christopherson Cc: Paolo Bonzini , Jim Mattson , Maxim Levitsky , Vitaly Kuznetsov , Rik van Riel , Tom Lendacky , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: [RFC PATCH 03/24] KVM: SVM: Add helpers to set/clear ASID flush in VMCB Date: Wed, 26 Mar 2025 19:35:58 +0000 Message-ID: <20250326193619.3714986-4-yosry.ahmed@linux.dev> In-Reply-To: <20250326193619.3714986-1-yosry.ahmed@linux.dev> References: <20250326193619.3714986-1-yosry.ahmed@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Incoming changes will add more code paths that set tlb_ctl to TLB_CONTROL_FLUSH_ASID, and will eliminate the use of TLB_CONTROL_FLUSH_ALL_ASID except as fallback when FLUSHBYASID is not available. Introduce set/clear helpers to set tlb_ctl to TLB_CONTROL_FLUSH_ASID or TLB_CONTROL_DO_NOTHING. Opportunistically move the TLB_CONTROL_* definitions to arch/x86/kvm/svm/svm.h as they are not used outside of arch/x86/kvm/svm/. Signed-off-by: Yosry Ahmed Reviewed-by: Maxim Levitsky --- arch/x86/include/asm/svm.h | 5 ----- arch/x86/kvm/svm/nested.c | 2 +- arch/x86/kvm/svm/sev.c | 2 +- arch/x86/kvm/svm/svm.c | 4 ++-- arch/x86/kvm/svm/svm.h | 15 +++++++++++++++ 5 files changed, 19 insertions(+), 9 deletions(-) diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h index 9b7fa99ae9513..a97da63562eb3 100644 --- a/arch/x86/include/asm/svm.h +++ b/arch/x86/include/asm/svm.h @@ -171,11 +171,6 @@ struct __attribute__ ((__packed__)) vmcb_control_area { }; =20 =20 -#define TLB_CONTROL_DO_NOTHING 0 -#define TLB_CONTROL_FLUSH_ALL_ASID 1 -#define TLB_CONTROL_FLUSH_ASID 3 -#define TLB_CONTROL_FLUSH_ASID_LOCAL 7 - #define V_TPR_MASK 0x0f =20 #define V_IRQ_SHIFT 8 diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index 834b67672d50f..11b02a0340d9e 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -681,7 +681,7 @@ static void nested_vmcb02_prepare_control(struct vcpu_s= vm *svm, /* Done at vmrun: asid. */ =20 /* Also overwritten later if necessary. */ - vmcb02->control.tlb_ctl =3D TLB_CONTROL_DO_NOTHING; + vmcb_clr_flush_asid(vmcb02); =20 /* nested_cr3. */ if (nested_npt_enabled(svm)) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 0bc708ee27887..d613f81addf1c 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -3479,7 +3479,7 @@ int pre_sev_run(struct vcpu_svm *svm, int cpu) return 0; =20 sd->sev_vmcbs[asid] =3D svm->vmcb; - svm->vmcb->control.tlb_ctl =3D TLB_CONTROL_FLUSH_ASID; + vmcb_set_flush_asid(svm->vmcb); vmcb_mark_dirty(svm->vmcb, VMCB_ASID); return 0; } diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 28a6d2c0f250f..0e302ae9a8435 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -4006,7 +4006,7 @@ static void svm_flush_tlb_asid(struct kvm_vcpu *vcpu) * VM-Exit (via kvm_mmu_reset_context()). */ if (static_cpu_has(X86_FEATURE_FLUSHBYASID)) - svm->vmcb->control.tlb_ctl =3D TLB_CONTROL_FLUSH_ASID; + vmcb_set_flush_asid(svm->vmcb); else svm->current_vmcb->asid_generation--; } @@ -4373,7 +4373,7 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_= vcpu *vcpu, svm->nested.nested_run_pending =3D 0; } =20 - svm->vmcb->control.tlb_ctl =3D TLB_CONTROL_DO_NOTHING; + vmcb_clr_flush_asid(svm->vmcb); vmcb_mark_all_clean(svm->vmcb); =20 /* if exit due to PF check for async PF */ diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index d4490eaed55dd..d2c49cbfbf1ca 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -409,6 +409,21 @@ static inline bool vmcb_is_dirty(struct vmcb *vmcb, in= t bit) return !test_bit(bit, (unsigned long *)&vmcb->control.clean); } =20 +#define TLB_CONTROL_DO_NOTHING 0 +#define TLB_CONTROL_FLUSH_ALL_ASID 1 +#define TLB_CONTROL_FLUSH_ASID 3 +#define TLB_CONTROL_FLUSH_ASID_LOCAL 7 + +static inline void vmcb_set_flush_asid(struct vmcb *vmcb) +{ + vmcb->control.tlb_ctl =3D TLB_CONTROL_FLUSH_ASID; +} + +static inline void vmcb_clr_flush_asid(struct vmcb *vmcb) +{ + vmcb->control.tlb_ctl =3D TLB_CONTROL_DO_NOTHING; +} + static __always_inline struct vcpu_svm *to_svm(struct kvm_vcpu *vcpu) { return container_of(vcpu, struct vcpu_svm, vcpu); --=20 2.49.0.395.g12beb8f557-goog