From nobody Fri Dec 19 10:46:26 2025 Received: from mail.crpt.ru (mail1.crpt.ru [91.236.205.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B267A937 for ; Wed, 26 Mar 2025 06:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.236.205.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742968907; cv=none; b=aQrhq8xWuzadkK+UCR+0Yu0bPwpl+9EbukULc8VY0Zc1mglfCCOgXVI19BP4MFqIF6Kxfvo5j5eV+SwUoO2My1+LFFPXbsOhuCpfNoMSYkkiM4IpBs4S3SaA9o8YGiX46rjrCNLKqjurYkfnsZmG/fFI8du6G1Pe+Z888qHZggg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742968907; c=relaxed/simple; bh=SMaYKshq3acZS99u+26mBuayTpIg9iiDJLeo1mA0VVw=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=EthuEmTFjqeXn2GG0yEqBOIKJzbVTa0m+BVl6uH3WCPt7PqGuK3ijYTNztieHsvxuY+z4VafAY2QAuOKLGWzPbw+cZ51BFsCMqWbTT7cqI4EBcEIkB5g2V+SezUO2PoZek/umOYUYPCMjpV8O339tPtGPMy8qwecXVoQRrvnM+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=crpt.ru; spf=pass smtp.mailfrom=crpt.ru; dkim=pass (2048-bit key) header.d=crpt.ru header.i=@crpt.ru header.b=CllUNNpr; arc=none smtp.client-ip=91.236.205.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=crpt.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=crpt.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=crpt.ru header.i=@crpt.ru header.b="CllUNNpr" Received: from mail.crpt.ru ([192.168.60.4]) by mail.crpt.ru with ESMTP id 52Q61Joa020126-52Q61Joc020126 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=OK); Wed, 26 Mar 2025 09:01:19 +0300 Received: from EX2.crpt.local (192.168.60.4) by ex2.crpt.local (192.168.60.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Wed, 26 Mar 2025 09:01:19 +0300 Received: from EX2.crpt.local ([192.168.60.4]) by EX2.crpt.local ([192.168.60.4]) with mapi id 15.01.2507.044; Wed, 26 Mar 2025 09:01:19 +0300 From: =?utf-8?B?0JLQsNGC0L7RgNC+0L/QuNC9INCQ0L3QtNGA0LXQuQ==?= To: Kenneth Feng CC: =?utf-8?B?0JLQsNGC0L7RgNC+0L/QuNC9INCQ0L3QtNGA0LXQuQ==?= , Alex Deucher , =?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , David Airlie , Simona Vetter , Sunil Khatri , Jesse Zhang , Tim Huang , Boyuan Zhang , "chr[]" , Yang Wang , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: [PATCH] drm/amdgpu: Remove the redundant NULL check for the 'dte_data' object Thread-Topic: [PATCH] drm/amdgpu: Remove the redundant NULL check for the 'dte_data' object Thread-Index: AQHbnhR++EzAa3ZlHUaU6nruSXfbmA== Date: Wed, 26 Mar 2025 06:01:19 +0000 Message-ID: <20250326060059.15335-1-a.vatoropin@crpt.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-kse-serverinfo: EX2.crpt.local, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 3/25/2025 10:34:00 PM x-kse-attachment-filter-triggered-rules: Clean x-kse-attachment-filter-triggered-filters: Clean x-kse-bulkmessagesfiltering-scan-result: protection disabled Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-FEAS-Client-IP: 192.168.60.4 X-FE-Policy-ID: 2:4:0:SYSTEM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=crpt.ru; s=crpt.ru; c=relaxed/relaxed; h=from:to:cc:subject:date:message-id:content-type:mime-version; bh=SMaYKshq3acZS99u+26mBuayTpIg9iiDJLeo1mA0VVw=; b=CllUNNprfqAVkUe2LfYNfFiPe7WMQzwbnbuJtW0m+s8PkL+AJkIj+8zMRaAVBLiGsiJDtTrEFnJe EsS7DF4vmctwRzwIqkiUzmST1HJouD36NU6huwOlk87t+qWFiPQvDDWgcAIh2Udaw7X9LY/RczJ6 T7eCVTeT4zU+rJqyLF/QxMNF/GOM6zz0y5QyT+jLDA2nmMJK2Pw2cf6+/UP23nzI54UoHKFxiCCB yAh0hEYvgylQbezRe7VFC46DeAmZpz+A4Fzvz3trCHSnDssFEe6HSoPbLA/z1W8Uxzv1dayWoLgz tHKH/9A1WnnIWfdfa94EFaNhirsQHC/C+Ho4DQ== From: Andrey Vatoropin Static analysis shows that pointer "dte_data" cannot be NULL because it=20 points to the object "struct si_dte_data". Remove the extra NULL check. It is meaningless and harms the readability of the code. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Andrey Vatoropin --- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c b/drivers/gpu/drm/a= md/pm/legacy-dpm/si_dpm.c index d6dfe2599ebe..32e6a815e609 100644 --- a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c @@ -2567,9 +2567,6 @@ static int si_initialize_smc_dte_tables(struct amdgpu= _device *adev) u8 tdep_count; u32 i; =20 - if (dte_data =3D=3D NULL) - si_pi->enable_dte =3D false; - if (si_pi->enable_dte =3D=3D false) return 0; =20 --=20 2.43.0