From nobody Fri Dec 19 12:01:41 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8A31F5433 for ; Wed, 26 Mar 2025 16:23:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006233; cv=none; b=YxRa1pOtOI8HsakPpJqLFSRET8ozMKmxipTQ4Osl18TQMozbkAWY3VnlCbFjjPjl+qJGnOWvkScfnZKUGiDQEQ1BdmsT0qU0im+zgoHkN+dCV6quFrwOAqVgQUXqZzOeeiJZB67meNfsJKJAbLSv8xj5PyHfgp6mhbkB4m1oGOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006233; c=relaxed/simple; bh=PeEgCfBvUgiOjdlm8XMEYe+at2eqiLHn8dkuleqfmAU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WwzBupPZxT+2QxXjjK9V8YqVGlL0JtVC0Z2VdIA1MaI9WbFJQtSApClbhf2mEc2mwzCt+qyhTsohCLwmx/hUYD+h/2q5wDq9qaJhBz23oXAFmrp9ZlOGOSDpAqf8QF5vuNJoUWZc0z69tI0rVhqdW7FRdRgRORjuFOI8emCBI90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=RRRbODCm; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="RRRbODCm" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ac29af3382dso1186143266b.2 for ; Wed, 26 Mar 2025 09:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1743006230; x=1743611030; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G9tCKOxWlZzVo+LW0OfZaKnD5ARH/KKbqzp36dlNLJM=; b=RRRbODCm2LHcPlpkQaQqOc/Puj2Or9Bj5XdulAevFh0ud/qukCO75P+4YPpZJbn/iq 9SkpVndWh1PAh9YPIgLEhHoDRyv8QSUYPwNRFiAHqyGir6030Qa9kLCOBO0ZBrg4rwlx KYVucIlPZVexwY0o6PiBpke4W+MECeWkDvY+NabYNdiAInVxlJXL3nlthuMEdEtV3OP0 PwmhUSDCVi9QlAy8jdomeOgzfvJ3ZgGJ4W5OLld0lNjsPmn+MniJO56pVB0jlA0IYSVz LsBg7gc3cVZ/i0PpBk6DSwmsBHOy/0pZ8U4Dh5woYvDnihRIvWP1g57FJQ0vJtbpLdCJ iyQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743006230; x=1743611030; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G9tCKOxWlZzVo+LW0OfZaKnD5ARH/KKbqzp36dlNLJM=; b=ZuWIngdQQYJmUmtZynh2mN0rti3l9g40dt92irgzRoX10MQw6PhXo6Lj9MMVfobxkC +fK3U0aFysm7Hv7hRXiYnUH6YqP3GJIuc4anJNCV9XMAeUzkqUltWoAXqCTkX07aJEu+ QGDkOASnrVBs++nFOVcVv151x01IdQI8fGwMWFWDNzvnKyk8Np1gJqviVo+VrV7hcjNH MUmKUftf+i5apvyMVkmmA0u7XL2ZUD2Qj7T2w8IUp7mIt3F+EfkyItAvVRH6l5CZ5+qW g5MeQ/Jt1G4fKV/cykWYZD6zt4CcmzdjOUlYKnQfn29K6gMnP6V4V2ISFM7F8IxFi4G2 L+Bg== X-Forwarded-Encrypted: i=1; AJvYcCXssI+RmacQPmMMf4m5yJzDWCL7cAbqWMUYwibVEh0Bn1Ib1nUVCD2xikq9/lmcX3JJBmQScJemzPYKles=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb1xVswkZhnLAlEn3J45JxZRojy/TAq1VDqvF5ye/sSBvjZrjb ARa6mAfnfxZ50X7IRWS30rdw3fbT+C3Tw+Mc+0Ty+aA7g2bbzNYxvF45Du/viLQ= X-Gm-Gg: ASbGnct2F4p+hFA9nDe+jgbcqBOlTCML/qhPmXmUJWD/DXfxLWU9XllVFS8zlFmMTII 1JtCR+rNQQLJ6D2sry0XbkSD9Y4nVv414OfxF9k7O72m3EiCqWLnGniaG4veGdU08dKx8yNIgnt Zfn7iSoe1F5uoDaZ1T1nI3m3rRb3SZea+WYmq55YNpXr/IY79DFJNuF6adkZUSkObUNa2U1gxHR 82EvsqrCBwTa68t4xgcTOFp8cOJQsQ6+JMbcFZ6Ly4ZflIE2EBX5cAw+kUWNtQm7DNZnOv7DEaj 1oEcgp0CjQeFfPtV9UaWIU5KafwL637QEoorJCL3UmJGHfgnz/1AggkWuQ== X-Google-Smtp-Source: AGHT+IFR7MKgek1aYBM8pLPyUk2XklCCGA9XeiQoGfN17QwCt+mtrdcAqb3TA1eUWqsMBXRD9Qv/5A== X-Received: by 2002:a17:906:794a:b0:ac2:dfcf:3e09 with SMTP id a640c23a62f3a-ac6fb100848mr1832966b.43.1743006230250; Wed, 26 Mar 2025 09:23:50 -0700 (PDT) Received: from [127.0.1.1] ([91.90.172.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac6f0f498ecsm76678866b.135.2025.03.26.09.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 09:23:50 -0700 (PDT) From: Lukasz Czechowski Date: Wed, 26 Mar 2025 17:22:56 +0100 Subject: [PATCH 1/5] usb: misc: onboard_usb_dev: fix support for Cypress HX3 hubs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250326-onboard_usb_dev-v1-1-a4b0a5d1b32c@thaumatec.com> References: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> In-Reply-To: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , quentin.schulz@cherry.de, stable@vger.kernel.org X-Mailer: b4 0.13.0 The Cypress HX3 USB3.0 hubs use different PID values depending on the product variant. The comment in compatibles table is misleading, as the currently used PIDs (0x6504 and 0x6506 for USB 3.0 and USB 2.0, respectively) are defaults for the CYUSB331x, while CYUSB330x and CYUSB332x variants use different values. Based on the datasheet [1], update the compatible usb devices table to handle different types of the hub. The change also includes vendor mode PIDs, which are used by the hub in I2C Master boot mode, if connected EEPROM contains invalid signature or is blank. This allows to correctly boot the hub even if the EEPROM will have broken content. Number of vcc supplies and timing requirements are the same for all HX variants, so reuse existing onboard_hub_pdata. [1] https://www.infineon.com/dgdl/Infineon-HX3_USB_3_0_Hub_Consumer_Industr= ial-DataSheet-v22_00-EN.pdf?fileId=3D8ac78c8c7d0d8da4017d0ecb53f644b8 Table 9. PID Values Fixes: b43cd82a1a40 ("usb: misc: onboard-hub: add support for Cypress HX3 U= SB 3.0 family") Cc: stable@vger.kernel.org Signed-off-by: Lukasz Czechowski --- drivers/usb/misc/onboard_usb_dev.c | 10 ++++++++-- drivers/usb/misc/onboard_usb_dev.h | 6 ++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_= usb_dev.c index 75ac3c6aa92d..f5372dfa241a 100644 --- a/drivers/usb/misc/onboard_usb_dev.c +++ b/drivers/usb/misc/onboard_usb_dev.c @@ -569,8 +569,14 @@ static void onboard_dev_usbdev_disconnect(struct usb_d= evice *udev) } =20 static const struct usb_device_id onboard_dev_id_table[] =3D { - { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB33{0,1,2}x/CYUSB230x 3= .0 HUB */ - { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB33{0,1,2}x/CYUSB230x 2= .0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6500) }, /* CYUSB330x 3.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6502) }, /* CYUSB330x 2.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6503) }, /* CYUSB33{0,1}x 2.0 HUB, Vend= or Mode */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB331x 3.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB331x 2.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6507) }, /* CYUSB332x 2.0 HUB, Vendor M= ode */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6508) }, /* CYUSB332x 3.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x650a) }, /* CYUSB332x 2.0 HUB */ { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6570) }, /* CY7C6563x 2.0 HUB */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.= 0 HUB */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB 2.= 0 HUB */ diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_= usb_dev.h index 317b3eb99c02..17696f7c5e43 100644 --- a/drivers/usb/misc/onboard_usb_dev.h +++ b/drivers/usb/misc/onboard_usb_dev.h @@ -104,8 +104,14 @@ static const struct of_device_id onboard_dev_match[] = =3D { { .compatible =3D "usb451,8027", .data =3D &ti_tusb8020b_data, }, { .compatible =3D "usb451,8140", .data =3D &ti_tusb8041_data, }, { .compatible =3D "usb451,8142", .data =3D &ti_tusb8041_data, }, + { .compatible =3D "usb4b4,6500", .data =3D &cypress_hx3_data, }, + { .compatible =3D "usb4b4,6502", .data =3D &cypress_hx3_data, }, + { .compatible =3D "usb4b4,6503", .data =3D &cypress_hx3_data, }, { .compatible =3D "usb4b4,6504", .data =3D &cypress_hx3_data, }, { .compatible =3D "usb4b4,6506", .data =3D &cypress_hx3_data, }, + { .compatible =3D "usb4b4,6507", .data =3D &cypress_hx3_data, }, + { .compatible =3D "usb4b4,6508", .data =3D &cypress_hx3_data, }, + { .compatible =3D "usb4b4,650a", .data =3D &cypress_hx3_data, }, { .compatible =3D "usb4b4,6570", .data =3D &cypress_hx2vl_data, }, { .compatible =3D "usb5e3,608", .data =3D &genesys_gl850g_data, }, { .compatible =3D "usb5e3,610", .data =3D &genesys_gl852g_data, }, --=20 2.43.0 From nobody Fri Dec 19 12:01:41 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19DFD1F5850 for ; Wed, 26 Mar 2025 16:23:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006235; cv=none; b=ozcwKk618NIyyKnAtFLJ11NO6BjlfkEk3gXgf+DhqS0sVgft0LQRAJdxdsqLiMtbFCRrz/Yqaf6HPmi+ZppzU9Wf3ODkEd3ROKVyhTO/lWkcn6GcIkNbciK8YMCAEmL/+zoz7KwFUiKDQXMFbtavs1WnD+ez1N10ZzFL9txqTco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006235; c=relaxed/simple; bh=qgZT/BBWMA235GCVCrIy5Wv1qr+OiVKxM6mDIVHCULs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XhkcbkdmTac2QjuNVa7FMM/GYLFUnVBdtm8ga9WfndIxTRtjfWe25nTFnEl8znedNbWCDFmI+x2MkWWK5mwWHz8tX7ZhVAkXt9Vq/ZoYWzGmYCyKBICh1qgdsFVd+PMss//ZoMu1ZpLCFsJp3f5Q/TNR5DdfJSUuFRXdU1tQLsY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=keGNTtuP; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="keGNTtuP" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ab78e6edb99so974722366b.2 for ; Wed, 26 Mar 2025 09:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1743006231; x=1743611031; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TIHXHkF/8pZLgK+rwXO3tbSWnw+8GWfU/CEp6SLN7PM=; b=keGNTtuPrAf1NxIYmURHTRV+BnL5YmifOhs0/pBDY3y/+Wejzb/Hom8xIjlantJVAk lfWm46d1GA6MVEa+I2QJhKuuQjKjvYhSWbT9Xo5cYP3K/tc9RSadjLt4d+YwaNmbgoL2 Q85wMFEscLjrF6sPTj6OCTcakcCwnJYC5jprRURQwDlEPaANPyXBUPyYH/243hodLQUi fhAV45pT+mUZyZdJFI1gqFhiW2kd6Dtimihfgaa0b/mpJY5lzfkLKtCD38d08ybZ0sPr 0iSdl6jmCWr0rcLJ3rMiHZZwFQR2q3V3M+WuBBDGDRin69y9MmG2dXbmN1fyal+MuKgF 9pZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743006231; x=1743611031; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TIHXHkF/8pZLgK+rwXO3tbSWnw+8GWfU/CEp6SLN7PM=; b=exr3uTj6gnf7JobyYaitW9R1oGTtWJMTik1izttmCWNtXwwNL0f2DgXyCEbMaMDIEg wICeABPSy2i5uey6uS4nOoF+dVwO1hn/omPgSBD6bv7zezmm9BZAuUIo96p6cgTVMFXi HBKLcjpLkufX6jTd17ZsvOiRWqsb6epHFcPu1tu4EO6ygBzKuuPtvtpBU0n6Aw8NztAf xYxvVy58w5L5I988VL3s9U9s+hCSBf3Qa98GBpM4cCBCL3+fm0JmvJP+KSs527AOhWiq C0lgCZRwUvc4sEI9EpsY+dQ0z3mt8KleCDQlUgEPkb98jQH/5ZR5SYhMwX12If5UY0gd QLrw== X-Forwarded-Encrypted: i=1; AJvYcCUDNGvHubaeyXZ/hmyojf26SQPit528JZcATUmKBKQEtoYEgO9RGgQzwoYDzVVlHG88oyPYeQoxVEtp2JU=@vger.kernel.org X-Gm-Message-State: AOJu0YzH74q4kcJ3TNDAYtjFjoDxMsM5scYQiuhaIP8mhmlugoNkBG5I f6BOHxXTHcA/OJMzeFCexjY9Qy8Nt71a0Lssq5kwUU8LwuburJgHwubOKlGM+n4= X-Gm-Gg: ASbGncsHf0iCEa2wgYYlAV4noF8c2SwyLsIeiG4WI9N4CPgHSJN9T/Z4PQGne/OOi2M xZ7ZltmStOLFeRw1mbrO25PbbkvIE+t5yOOOESf6Q0xCXgTF46rXdLNxT7FdEE8/TxcslzLyNjB oiw8CWky7CklNtCKuA4mpT0WYJjnFhphZ3xeOzTpHYdznJz4sKoclytvV+szr0Oji27wI9imeff ENSaMvvjNKNX8WHFkPziFElUwtt0z7bl07l6MAYrpdUZhdlQ98KPMDMEgjRyLCbdD0niD+kgW7i xgJjtqwjmU2/BdybE1ezzipzSfsjTNwvSc8c/DuZ12nB4Eht8UTQyN91pA== X-Google-Smtp-Source: AGHT+IGX6YIZqj3EMmg9fstP7Tv4f5XMwVql68RmQX1PGbQYAIwS++PJhhjAX5oAjP1/BAdfxlVIAA== X-Received: by 2002:a17:907:968b:b0:abf:733f:5c42 with SMTP id a640c23a62f3a-ac6fae5fc76mr5632266b.8.1743006231199; Wed, 26 Mar 2025 09:23:51 -0700 (PDT) Received: from [127.0.1.1] ([91.90.172.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac6f0f498ecsm76678866b.135.2025.03.26.09.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 09:23:50 -0700 (PDT) From: Lukasz Czechowski Date: Wed, 26 Mar 2025 17:22:57 +0100 Subject: [PATCH 2/5] dt-bindings: usb: cypress,hx3: Add support for all variants Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250326-onboard_usb_dev-v1-2-a4b0a5d1b32c@thaumatec.com> References: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> In-Reply-To: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , quentin.schulz@cherry.de, stable@vger.kernel.org X-Mailer: b4 0.13.0 The Cypress HX3 hubs use different default PID value depending on the variant. Update compatibles list. Fixes: 1eca51f58a10 ("dt-bindings: usb: Add binding for Cypress HX3 USB 3.0= family") Cc: stable@vger.kernel.org # 6.6 Cc: stable@vger.kernel.org # Backport of the patch in this series fixing pr= oduct ID in onboard_dev_id_table and onboard_dev_match in drivers/usb/misc/= onboard_usb_dev.{c,h} driver Signed-off-by: Lukasz Czechowski --- Documentation/devicetree/bindings/usb/cypress,hx3.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml b/Docum= entation/devicetree/bindings/usb/cypress,hx3.yaml index 1033b7a4b8f9..f0b93002bd02 100644 --- a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml +++ b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml @@ -15,8 +15,14 @@ allOf: properties: compatible: enum: + - usb4b4,6500 + - usb4b4,6502 + - usb4b4,6503 - usb4b4,6504 - usb4b4,6506 + - usb4b4,6507 + - usb4b4,6508 + - usb4b4,650a =20 reg: true =20 --=20 2.43.0 From nobody Fri Dec 19 12:01:41 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DE41F6694 for ; Wed, 26 Mar 2025 16:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006236; cv=none; b=ijt6hprDzzuJ9HaYvNpO/XxlSeRfEd1NzSGiQKJ0n0ORk9LV9bIudUMf8rndWIfSXupzRamiKbEyhy5K2s0Gl7g3pB/eRbRjA7gYN7SCG0yH7FvM91McpEhl2WFWpDQT2J/gwwSLfuNp67f6HhBGkNWUoUnA5PDx7yhlbuR9jx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006236; c=relaxed/simple; bh=Xyyjf1iVpsBKHBeKbA3NYgJgRAsD7ncLZzoytlF9COg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sGAbcegGezk0xk4DtiA0W6dtT3b63yTvIQ3XYqOL5Kn4z8LSF39TT1nhmbRQyta1eydr1gt0z3eIuwiyZTeNz7UXSpHtM4qmJPPzO2lNPaSMYJfp1891mNnqnrJr43GkmTsiEa7Zz6ckDCqc4sjCgh23EtydolgoqFiGf12hAhs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=SRaiq7bV; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="SRaiq7bV" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5e5dce099f4so9509340a12.1 for ; Wed, 26 Mar 2025 09:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1743006232; x=1743611032; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gDeO2nIfMOICmbdN4iB492bLj9a77KMSQWKqvg2E0aY=; b=SRaiq7bVYUgs2L8R3vlFonRrbUENE5holF9mpWbPXwWNurc+TZ00EF9oPPa9csnlwz iUJ/1bReYeEoU8BjG3WZPeygIoIPaKRYja//oDhx6bCTpTbs4FrEL5fY+7oRVLAga/5f 7wLL3K4s+IXOxLAi1cWYo+7OjGm4Fy61GucasgLu/znPcEunI4Pi2RMNkzId0EW0X37/ BK0Jn/kjf5CjVgLqy2pq341IIAInb60PIng6XnmGC8/BT8UQZyBZWqKKjgibfvzR2TaB s9VRmUew2mcv7WL9MTpDBgNOye5+ZJsHw0kFsXpdit5IldPysWo6wgnJNZlulAf64fwd 3lXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743006232; x=1743611032; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gDeO2nIfMOICmbdN4iB492bLj9a77KMSQWKqvg2E0aY=; b=MAQX213aC/QNAnuBNP89Unuab3Y15Rm2eqLeqcrqrJ+sMQnYv0/37i9sYiZWT/3xte WZIPJRUVOuErrtan5iA3KmsTqrfBbpyPgxHi3PcPlCyeq70N8+LEF46M4e8zrKcgWItI +N532LIAl3cIcKmoDkPj1j+4b3Y2n2bnTMpf84H8mBs6Vq+Ir2rj/6JiHfRQksZlXr09 JQZBWMFfEKrY11cL4cJK9Viq5vOq4iejdojywKVU2Zrgrm02btZUmTN8u4nEcb9mO44r iaGZRYVeAhuI21t06+EDl+riArOcEhYaiviDYuCQjMIHa7O0Bfyj0C7QLwQTm4vKZDsf vZCA== X-Forwarded-Encrypted: i=1; AJvYcCVeRKr8AWPY1OC9W1kshEjioO7wJcJZt8ekhcHit67dq23i7C8S4OL8NE67N7MQ+Jq8VawKiGUaYdjfjAg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9RvZ+4URdwIGcxZB7qJTczkLxDsiQBvkgkqmysh+R9l+Z1p20 kbQVLA+tkTMSm/SH4QOEfKRComx9kBFhzt5zN90AoEi6uFjLn05blYPW8URUDU4= X-Gm-Gg: ASbGncu2O0+G9MSWPi9tB2w29PGZ0hcA9N7haXuN/Y6gmg5ZKk2ZkiM4LFzqUpGraxE n8rI8nXWVHhVcvluzjJx+jFD3uHGDnh0R5XzKeCc2lvj31yXVwwas6qa2gxoqRcYB/OJaQI6Vff CQZPj9Wy1JUoDk8Sva4DG+3+Yv5A6knIjs1rZAj+Yxi/F9zTQtNYup6Y0mBNuMBHxcCQvnpgEJn i4mz4NYhn4Q1pUtJtqhgHpLxejKY4I9oPvnsJhIhvpZ3h+IbqYT7daqcGgY7l9MHT7tZMuoJ4UV VIXHNfbr+wO1T0epU/X+elEQ0JimIlUSmdyROqqREQHVF38kbdUJkKti7A== X-Google-Smtp-Source: AGHT+IEc7BN+I9AuEBYkJp/jaWFUpD0J6wfKpFX9npNAzocR2TXh01hPKMJxC/w2Hwxq2f61h0F3IQ== X-Received: by 2002:a17:906:6a04:b0:ac0:6e7d:cd0b with SMTP id a640c23a62f3a-ac6faf0b809mr4040966b.34.1743006232177; Wed, 26 Mar 2025 09:23:52 -0700 (PDT) Received: from [127.0.1.1] ([91.90.172.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac6f0f498ecsm76678866b.135.2025.03.26.09.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 09:23:51 -0700 (PDT) From: Lukasz Czechowski Date: Wed, 26 Mar 2025 17:22:58 +0100 Subject: [PATCH 3/5] arm64: dts: rockchip: fix internal USB hub instability on RK3399 Puma Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250326-onboard_usb_dev-v1-3-a4b0a5d1b32c@thaumatec.com> References: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> In-Reply-To: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , quentin.schulz@cherry.de, stable@vger.kernel.org X-Mailer: b4 0.13.0 Currently, the onboard Cypress CYUSB3304 USB hub is not defined in the device tree, and hub reset pin is provided as vcc5v0_host regulator to usb phy. This causes instability issues, as a result of improper reset duration. The fixed regulator device requests the GPIO during probe in its inactive state (except if regulator-boot-on property is set, in which case it is requested in the active state). Considering gpio is GPIO_ACTIVE_LOW for Puma, it means it=E2=80=99s driving it high. Then the regulator gets enabled (because regulator-always-on property), which drives it to its active state, meaning driving it low. The Cypress CYUSB3304 USB hub actually requires the reset to be asserted for at least 5 ms, which we cannot guarantee right now since there's no delay in the current config, meaning the hub may sometimes work or not. We could add delay as offered by fixed-regulator but let's rather fix this by using the proper way to model onboard USB hubs. Define hub_2_0 and hub_3_0 nodes, as the onboard Cypress hub consist of two 'logical' hubs, for USB2.0 and USB3.0. Use the 'reset-gpios' property of hub to assign reset pin instead of using regulator. Rename the vcc5v0_host regulator to cy3304_reset to be more meaningful. The vdd-supply and vdd2-supply properties in hub nodes were skipped, because hub power supplies are always enabled based on HW design. Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Cc: stable@vger.kernel.org # 6.6 Cc: stable@vger.kernel.org # Backport of the patch in this series fixing pr= oduct ID in onboard_dev_id_table and onboard_dev_match in drivers/usb/misc/= onboard_usb_dev.{c,h} driver Signed-off-by: Lukasz Czechowski --- arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 33 ++++++++++++++++-------= ---- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boo= t/dts/rockchip/rk3399-puma.dtsi index 995b30a7aae0..3a9049372e12 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi @@ -60,16 +60,6 @@ vcc3v3_sys: regulator-vcc3v3-sys { vin-supply =3D <&vcc5v0_sys>; }; =20 - vcc5v0_host: regulator-vcc5v0-host { - compatible =3D "regulator-fixed"; - gpio =3D <&gpio4 RK_PA3 GPIO_ACTIVE_LOW>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&vcc5v0_host_en>; - regulator-name =3D "vcc5v0_host"; - regulator-always-on; - vin-supply =3D <&vcc5v0_sys>; - }; - vcc5v0_sys: regulator-vcc5v0-sys { compatible =3D "regulator-fixed"; regulator-name =3D "vcc5v0_sys"; @@ -521,8 +511,8 @@ pmic_int_l: pmic-int-l { }; }; =20 - usb2 { - vcc5v0_host_en: vcc5v0-host-en { + usb { + cy3304_reset: cy3304-reset { rockchip,pins =3D <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>; }; @@ -591,7 +581,6 @@ u2phy1_otg: otg-port { }; =20 u2phy1_host: host-port { - phy-supply =3D <&vcc5v0_host>; status =3D "okay"; }; }; @@ -603,6 +592,24 @@ &usbdrd3_1 { &usbdrd_dwc3_1 { status =3D "okay"; dr_mode =3D "host"; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&cy3304_reset>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + hub_2_0: hub@1 { + compatible =3D "usb4b4,6502"; + reg =3D <1>; + peer-hub =3D <&hub_3_0>; + reset-gpios =3D <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>; + }; + + hub_3_0: hub@2 { + compatible =3D "usb4b4,6500"; + reg =3D <2>; + peer-hub =3D <&hub_2_0>; + reset-gpios =3D <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>; + }; }; =20 &usb_host1_ehci { --=20 2.43.0 From nobody Fri Dec 19 12:01:41 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 020701F791C for ; Wed, 26 Mar 2025 16:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006236; cv=none; b=Lo3vtHiuyRSJgxftnSKfV+uFivPiObXECHvv5591UpZ9KEEuBkq08eB+35HjIIFgaTS+B0oQ+Jl45POvWjXxX7hugheOr1KzkUfkxSvsdyqHf+hhVh8pOOaxhO00RfuctIGEzsySU88ZkweDeseiONf89xXMOvHLBoUaFGwvyFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006236; c=relaxed/simple; bh=sbUdINhLsUhhAyV0mvnO02l63FQfC+wlrb8lw8RlunI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MOi3HILD/Cyu+jid3zMuR7htQIGRuywTjt2NAbZdb7jGNFDJdRBin9neza6sKUm6CDjRz2T0s6Cvev99ouFvtUqmW+idlKrD14J8bNeS+UUx9pITIfFlvVLmpc697f2xn/mIzVdiwXCiLb5JZo3Il/c+OsXtMmyaVuDSiF9mJIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=oe34fiHG; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="oe34fiHG" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ac34257295dso1434035766b.2 for ; Wed, 26 Mar 2025 09:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1743006233; x=1743611033; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rLyts1UbCS80soWAIK/VLH5pGMtL6M9HaPrhO/pX88s=; b=oe34fiHG3kkHN9Y77t8+woUpON5Tf3n0OYlG6JrkYsP69+LDaujhzmXyUbXOdt6xFI xVODB/v5msQ3nmXC/Jsc5bx3gFVWYX4YZi2VCVrYRyypbNCg1VqEAu2x2+Gw9DmTRVzW bByApbbVQ6DK/Clcx5h5ESF3ngQDYjsSfDm9bO8C3Js+rNFpTa/QisPfZ0gXizbgtan0 cwfNgKaGaCEBM1LjT4EQ9kHzoXS1b11/EgC/8TskzwNr/1bsZ1Ud0O90gHlNfUBLzF8p ExMu9LBpO/zJYQdmvrE72v4ySnPiJOuNfwQqozNkZFuqHglvqS1A5lbmlw4HA2rEfbmZ 2KzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743006233; x=1743611033; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rLyts1UbCS80soWAIK/VLH5pGMtL6M9HaPrhO/pX88s=; b=QQtaHy+0cUhYJYUxfbeLTnX1VSd+MvHdYxINof8Mv9gSkGZwQSR8Bb3+uudS0zdBBp Uw+rqtaJDAh94J0ThOAJbFQFeF7LMoIRCJrFj8NGfovCkUaIIhZn0EcbJrPI4PS3mkR7 MOZ9prbuOe6SNO9XAW/A7I+hklOt+6Evwg5dadKQgD3nmQvA2yb1mehMLB/GIcl2bh4B ho9OEHRckL35YBjEyNXX3K9WaMgLUU0vvsf+gJ/hJDt3RYq47GxFOMZm5dDN52iUJLbp klxAfINlfNz2AJ3fYZqD2rWqasazxvooAeJcdsy32kAwx1o1wd4GfUNc5WmAT0cZ38WO fDmg== X-Forwarded-Encrypted: i=1; AJvYcCXfnQluJ6aghczm03Shs1JftIpcj14aMxAPaVYzS/4gxzEG5/KrkD9D2gTogr22sAVInZAh1UfRAskQeYQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxd2nE699qfcjJo/lffbISWPTiaFBO/xiJNW18RwOWGD3AtrDSq jlFcil/GqZfeyplTzX4/YQZU6XvI2KNQd4kJq9yEXFleA9qnlFILGdJAOXXekYQ= X-Gm-Gg: ASbGncsVIm5KSiKhJQcLQtTeo2LFEexwyFz9yUEuZeErb6Q6JsMCZazRZhaloOHZ+oE 52L6Nfl28le/c2tN685lAGwVdtFwHkL2Uy8FNthOciMpWmTPeRke3s6xK8+nc761d8GURA+n6fY SEDYWm1H6lm9BIE8yoPWXUYVASLdisiBhctYmdRjVDY05Wzer11KIF24u96P32s65gt6PgO8YOJ S31hHaXE2dobgz1ent8it6vEcO6yRM9C32H7uVMcdfO95yE6T4HHTDB7vDFml3LgxaGrLoZwtnT xeDtmKji54Q3GbV22OCWcbnStNgTggYzaR8/9xyYRWIA+VP8DoYcPYuqMA== X-Google-Smtp-Source: AGHT+IGuL6Nt4ApMHrsVVJxTN8kmsE+fO+syqOdRHUYnjFPTrq5knLFF6NaAbaKnyWcocuiQ/Tst8w== X-Received: by 2002:a17:906:4fd4:b0:ac6:b639:5a1c with SMTP id a640c23a62f3a-ac6faefef90mr4899766b.22.1743006233086; Wed, 26 Mar 2025 09:23:53 -0700 (PDT) Received: from [127.0.1.1] ([91.90.172.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac6f0f498ecsm76678866b.135.2025.03.26.09.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 09:23:52 -0700 (PDT) From: Lukasz Czechowski Date: Wed, 26 Mar 2025 17:22:59 +0100 Subject: [PATCH 4/5] arm64: dts: rockchip: disable unrouted USB controllers and PHY on RK3399 Puma Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250326-onboard_usb_dev-v1-4-a4b0a5d1b32c@thaumatec.com> References: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> In-Reply-To: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , quentin.schulz@cherry.de X-Mailer: b4 0.13.0 From: Quentin Schulz The u2phy1_host port is the part of the USB PHY1 (namely the HOST1_DP/DM lanes) which routes directly to the USB2.0 HOST controller[1]. The other lanes of the PHY are routed to the USB3.0 OTG controller (dwc3), which we do use. The HOST1_DP/DM lanes aren't routed on RK3399 Puma so let's simply disable the USB2.0 controllers and associated part in USB2.0 PHY. No intended functional change. [1] https://rockchip.fr/Rockchip%20RK3399%20TRM%20V1.3%20Part2.pdf Chapter 2 USB2.0 PHY Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Signed-off-by: Quentin Schulz Signed-off-by: Lukasz Czechowski --- arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boo= t/dts/rockchip/rk3399-puma.dtsi index 3a9049372e12..d0d867374b3f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi @@ -579,10 +579,6 @@ &u2phy1 { u2phy1_otg: otg-port { status =3D "okay"; }; - - u2phy1_host: host-port { - status =3D "okay"; - }; }; =20 &usbdrd3_1 { @@ -611,11 +607,3 @@ hub_3_0: hub@2 { reset-gpios =3D <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>; }; }; - -&usb_host1_ehci { - status =3D "okay"; -}; - -&usb_host1_ohci { - status =3D "okay"; -}; --=20 2.43.0 From nobody Fri Dec 19 12:01:41 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35D51F8922 for ; Wed, 26 Mar 2025 16:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006238; cv=none; b=Y9BZUlMcv46upNEX+cXmb0/B/ZsvuClCcsAWHmrgGLtFwJ+wUXAxktKQFYvPu4rusophRuJVIrtL/Y+t1t/XsijYCExWDYNp/UsjNtc/lc60BfREs7krg87CDAoUcgyOjCYO8Jwcgm1MgKp6pwdGJOY52SM/V6z5ULh5druIiuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743006238; c=relaxed/simple; bh=Grwt7YtWLNjsqzrKfnGrX2o+xxC08oKmj2pdJH3EBws=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W7+tiDQMmowRNQWkWV3Zim46EuQwV9yjBXtxhaLBRwFIpgApuje7rfSXoQznwM4YJP3jIXSyDns0NHaOxX2w8SpGbomOMSuEfFYo6d/T9iu4ea4j3CqPILejG72raojKk39JVRLJT3hhVqqGepQ5zeY0x2RMAT2IcU4232cvSWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=jDNjIUar; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="jDNjIUar" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ac339f53df9so299924366b.1 for ; Wed, 26 Mar 2025 09:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1743006234; x=1743611034; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wDm6vwX/7MhCy38Oh0zCGpwppmmiRhE1IJH2tHqDN4w=; b=jDNjIUarMLMw2GSrmWZH7FiiRCngOP7ppmDqjZgYqt8Sq+kGperT4MXftWz+JJmrx5 V6vaoIMmC6QSZuofFFwVLvlN7kC7wrZQTyJS/XBByqToMrk2UUcgFX9LOi8RvOTWzgLk SJPcAMaiZC127Fp3VFckSq63Y321c30TcnBSFsn67PEaKTPBStQvaem2h49Wkic2Tg1k EpHhVxouNCM+F61SwuBW3DYvum+7I11sHsCzk0fuzobTj48z00hXZhblKs9+vbp8ppiu 44p42S12RzHtQxZdNZ3WSjINIW7WXUqIX0ojnexsDXvNA5supYiYGTz+gMBOwYfGUEZu 9ncA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743006234; x=1743611034; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wDm6vwX/7MhCy38Oh0zCGpwppmmiRhE1IJH2tHqDN4w=; b=SWa2DKP9Xr1jhc86BYFAQBWfTc11MvmmYBsfrE4YmH1EkbeKLuLdaWlIYQhLjku0y8 aI6N0YokOS74uSk9NcX7MHr4RoTosQH4lKjMOJPpjQbBOp6kEAkqFP8dTq/F+FjvKBlw bT4ei25pDBVeHGcxCUJ0agq/09/dFK2tRVjI1HzhUavMQ6FJVbtoPRChc1qbGLHocexT D0ZoxL3nPq/Rh7Hkwwe/66rlTlrg37EahYJVY6s0do1gYoC2zNen42cR5gdK8ZReJcFy 1BCYXSjVZFX6VRWNQ5VOCQTMvnx7kHlS9IqQfcOJXa+Vbn+BOBTg1zXYUTui7JBOlIoU L/XA== X-Forwarded-Encrypted: i=1; AJvYcCW+eVEEWfVeDin/cq5KjeXy3ZOgaInqFY7R4xrHBU/M9FMqCSFKR0TW2dEvaNMcFRDTCdpa8z1brAYGeKY=@vger.kernel.org X-Gm-Message-State: AOJu0YxMuOi4nbrhvmAmO3xT2jcnAIY7NXYBnDi2ZNWAnYLsu1E9LFnI rHeOu92cDUSN5VflTDtJaYsJbvj9SLEbciFUVW2mNDkBJ5aQSLG7mOGhvRuhMc8= X-Gm-Gg: ASbGncvOHCTiWw0dbylcR0B7rZ79vJlCszjJFPm6S+eyTg/FGI+Er7iwLupFKPw5jV3 rk3Y3dPgDVCOxjMphXFKSdtM1Jkq8mo3pIIsQkaY8YdPoos6VkMmVtUDw0CypFlfvwOasVoT6Mm 9QbpwIYjcrrV3c+17qm7NtN4rSFGZ7UatfcJ36CKJnjOU0O7yTJW0dyacQQVcBD3xlKfHeJU3RB V5to0I2Yip2hZ8/wmcj9Xot+b0Ejq3JDPzt9PlwbKawsUHivDLvc4LIunkRzOY6aa8fdzBtqt60 Hh9A9oUidj9WYsT7pOpKVGgaRKp0yEKNxClNWCj4+ibj8YxuIw29u/mpjg== X-Google-Smtp-Source: AGHT+IGQDtjWme6NCVpAtHSgi92qK4szwj72LFKXUSvl2zwfLCr6eOS0xs1KhoWnEmaFlvUG1YBTXQ== X-Received: by 2002:a17:907:2ce6:b0:ac3:446f:20cb with SMTP id a640c23a62f3a-ac6fb14f3f5mr1655966b.43.1743006233972; Wed, 26 Mar 2025 09:23:53 -0700 (PDT) Received: from [127.0.1.1] ([91.90.172.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac6f0f498ecsm76678866b.135.2025.03.26.09.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 09:23:53 -0700 (PDT) From: Lukasz Czechowski Date: Wed, 26 Mar 2025 17:23:00 +0100 Subject: [PATCH 5/5] arm64: dts: rockchip: disable unrouted USB controllers and PHY on RK3399 Puma with Haikou Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250326-onboard_usb_dev-v1-5-a4b0a5d1b32c@thaumatec.com> References: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> In-Reply-To: <20250326-onboard_usb_dev-v1-0-a4b0a5d1b32c@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , quentin.schulz@cherry.de X-Mailer: b4 0.13.0 From: Quentin Schulz The u2phy0_host port is the part of the USB PHY0 (namely the HOST0_DP/DM lanes) which routes directly to the USB2.0 HOST controller[1]. The other lanes of the PHY are routed to the USB3.0 OTG controller (dwc3), which we do use. The HOST0_DP/DM lanes aren't routed on RK3399 Puma so let's simply disable the USB2.0 controllers. USB3 OTG has been known to be unstable on RK3399 Puma Haikou for a while, one of the recurring issues being that only USB2 is detected and not USB3 in host mode. Reading the justification above and seeing that we are keeping u2phy0_host in the Haikou carrierboard DTS probably may have bothered you since it should be changed to u2phy0_otg. The issue is that if it's switched to that, USB OTG on Haikou is entirely broken. I have checked the routing in the Gerber file, the lanes are going to the expected ball pins (that is, NOT HOST0_DP/DM). u2phy0_host is for sure the wrong part of the PHY to use, but it's the only one that works at the moment for that board so keep it until we figure out what exactly is broken. No intended functional change. [1] https://rockchip.fr/Rockchip%20RK3399%20TRM%20V1.3%20Part2.pdf Chapter 2 USB2.0 PHY Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Signed-off-by: Quentin Schulz Signed-off-by: Lukasz Czechowski --- arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm= 64/boot/dts/rockchip/rk3399-puma-haikou.dts index 947bbd62a6b0..93cefacc7a01 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts @@ -292,14 +292,6 @@ &uart2 { status =3D "okay"; }; =20 -&usb_host0_ehci { - status =3D "okay"; -}; - -&usb_host0_ohci { - status =3D "okay"; -}; - &vopb { status =3D "okay"; }; --=20 2.43.0