From nobody Thu Dec 18 06:17:48 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8CEA257AFF for ; Tue, 25 Mar 2025 12:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905845; cv=none; b=d8etnJK7IQwVQdKabLncgoBB7+q2lY4xZVBUn2c51X0sbj0OefAVoJiY83D15AYIWI6/XoTfMpLI1FK9Q1gDcj1a/r3EXbgHKkKX5LLt+bdZ0pOeYvjokU2NhGI/aj7l24n6jCEQUTjuNcTG+Kt2PxlXqjWXnG6ldTF9KH8/Fj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905845; c=relaxed/simple; bh=C6NTSl0+Rao98kSjPlvJlJr9IoIUUdvL89mpuJUpsPw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VEuA+yVfWXTyfx1Jwofwkup+BZ0GWnKAslUgVTE4hS6PjYGLaTR1uPRvvWuM5fv+OVxC3I9klLtAuCigoJTmX/hpQ432CXkfUc7gHxucVdrEAlHaPuhLhO1AyxM0InfFfB5FJeyKb05/4M8BfiofLNzvech1eQZt8c4ED7Mvmqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LvU8TgVN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LvU8TgVN" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vXGn032652 for ; Tue, 25 Mar 2025 12:30:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Djrd/4JquWX DbU+icEttWqizSKPX1yxwU0bvPWCgU/w=; b=LvU8TgVNJsQgO4qNIXXeQyYTk0o g41uEQteuyHtcgDITr2HwMbcs4g7kouzJPWmO+2pI6/sZySrhtUkv94xrAfi9SD0 1iAjuAZXSSfrFE1m6BA7aQV6K+evsHUcaYQcBKCtTYwQPqDUyqSSHy3K1qFOR3wE ZFac0vkKUioFTWz8jvrnLtyqCTi6z/D6ltBvLlyyW+mKEAGrNyp36VyavVllM5D0 ReE1j7LpUmSPAG4CVSkb2Vj7PR6q8YCP/rBnv3WKJQRHOeAi7RlbPKFmUwtcEslm PISAvteaO0j4CzzrF4QZc5h7F7TIffW4OH+453Zyu0AX3NsovLtRHyJy3uw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45kmd31fuv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:42 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2240a96112fso153049905ad.2 for ; Tue, 25 Mar 2025 05:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905835; x=1743510635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Djrd/4JquWXDbU+icEttWqizSKPX1yxwU0bvPWCgU/w=; b=K5d2g2LEuVnrA+NeNsiOigIy4jEGy6riW/YUoiL32dh1VMZlA3ZG14SO9bzi5Rf1Pz 2mk8dKA2GyJJGOGnZYvAX31fRXsJ8JW/wKM4I8s9W1zONV+Qmu/Fmjw1rI0nKpdZJiNA /VrlKb1ogOqhfJo94tR4QOESdqtdtfHhgDdHEoMMyhr3EaTB6WXDBb7shZ1jGhx3UyJa tMBUOZWB+ZvAxJy98Wdq4Nmj0feEfmYM9D+SiiR1Juj7zllhwk5VrfkOGnt9dBl5sN1n 3o+itDohKIS8Z1saEipcwmFZ9At60gftMC7B6qAbcxZlzh0z02iqk3i9A6tGZHiOEgDr JC7g== X-Forwarded-Encrypted: i=1; AJvYcCWNIKGC9+u0t0PHq0WVLGwFWZd/Gf46tsteIvv+dNu47+AhvAJss/N/dEGe1jwYiHU/daiGXl1ZMdDq1bk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzrq4e3wEzRpaAHbIEKvuOQKjkL1WYA7DuRQxaUshkiWhHPjhga 1EY3FWFjy7L7JnnqFbSEtOR1dOH4RV9RNUMYcO1C4pG6IL92BImUcsiZzC7v8nOsgnILuKvk4A3 xeEPNDz8ACsHkcKlMP8Fic0XOWBxjGYWeMPzcc7FqB3Dk2zQUfeWG7qW7JKEJWTU= X-Gm-Gg: ASbGncuRoUGYnLwUPjp7Z+4ocBJ0nsALXyTt+z+t0cPtAQ6bQOknNJU3YRphhVRkvqO Hz0uDLhFrnVCnBaKkl4drOd+rb4ZVBjaHZOUAv3eRFrkAIMlDahq6V/DGnb0+9ZiXTKOWD2EeNf xWmucO1uv0gWD1Jocv3Pb9yz7R5+9XBGZ3i987LNXYj3I7VIvVxoPA8/PDjsCIdTwNc3ubKKorj sp20IPuvfYJavejclsjIAZ0hdssTABnb71eKRrVPMlE0Zw7kKN5omRg1JdVlpL5DJJT2tPGd90g tTwoSQ4xYvqK0ZgETjd5Rf27Iyd5HMqzasefTKPL4C6E X-Received: by 2002:a05:6a00:a90:b0:736:5664:53f3 with SMTP id d2e1a72fcca58-739059ffb6bmr24496349b3a.15.1742905834134; Tue, 25 Mar 2025 05:30:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1+SzHyug7TlpcnU1WYoJKsScRaV4mu1kQkM4jvBkv9SbhqL2kTaoaLZnX/fcxB9EwTIMLnA== X-Received: by 2002:a05:6a00:a90:b0:736:5664:53f3 with SMTP id d2e1a72fcca58-739059ffb6bmr24495709b3a.15.1742905828883; Tue, 25 Mar 2025 05:30:28 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:28 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v1 1/5] arm64: dts: qcom: sm8150: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:15 +0530 Message-Id: <20250325123019.597976-2-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: aeBmnc98JqTpYIYD3GWYAa3C3jRQgTdl X-Proofpoint-ORIG-GUID: aeBmnc98JqTpYIYD3GWYAa3C3jRQgTdl X-Authority-Analysis: v=2.4 cv=P646hjAu c=1 sm=1 tr=0 ts=67e2a1f2 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=EUspDBNiAAAA:8 a=2mEde68aHbpXMYUSS8oA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 phishscore=0 mlxlogscore=822 priorityscore=1501 bulkscore=0 mlxscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 Content-Type: text/plain; charset="utf-8" During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Prashanth K Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qco= m/sm8150.dtsi index 4dbda54b47a5..4477ec14ab1d 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -3657,6 +3657,7 @@ usb_1_dwc3: usb@a600000 { interrupts =3D ; iommus =3D <&apps_smmu 0x140 0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; @@ -3736,6 +3737,7 @@ usb_2_dwc3: usb@a800000 { interrupts =3D ; iommus =3D <&apps_smmu 0x160 0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; --=20 2.25.1 From nobody Thu Dec 18 06:17:48 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0634E26772C for ; Tue, 25 Mar 2025 12:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905836; cv=none; b=RhWDE1peettDZKmWSAROgEzQiaTCq2fVTH3qWfFcTNX0JKpFqXHIT3j3bpE5rVnkBo0HzHDQ8wspRaioXPEf6SMIe6Is/kIcFE8tOgizozwTnszhrF+Imn9nLfDradQ8l8KyHoGD2CeamGL+lLgZg23Q4+Zr486k2FmpCqC9Foo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905836; c=relaxed/simple; bh=EWJKXkB8LgOYgPO2GqjsxkANuQt2ed1jlqMbsU/LlwI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eD9GRsVLMNXC9pcGKScBjxJ3IW4LkU5eoMhx1Fq1jpJKlpsVUrItgCzL/J+rOV3VFhmDPICLH1JTq+V6Ra04yrpdm+e+qpPnfmr4CrtG2uCCyJlCgnQQQ8pDpzwj5vkJzLDh5nL9RENlsEN1r9ubY/XDD1qvhIOg9RZsIDYfYTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B7z/Rtql; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B7z/Rtql" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vXlI002343 for ; Tue, 25 Mar 2025 12:30:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=/EQM6DEoDUu 6zxmdeqRLQ9xyT8MDYjKcZBBXwIJ855Y=; b=B7z/RtqluDa1rImIos/tyMn+Tt/ YhNGPX6sxI4vRWKSlSTbR/BNhIKdpOsdgqjrNozsWKFozs8fKQczvvmjgFfJ23KQ GX5N74aCFVJ5+9Mn+UTULOhThkXvMC+BtSfbpKSr6I3vXJaa02wzH7M4IAn96yFF HtvQ46Lygqt7/it1K3qOK+KUo6UIW+0A3CrFU7sW2wlM4kTtNgn8YDCy30hszN11 rtHzW4ts8HN9erkSmOEwbPTQJq9hb25988OUh4CIPuHQBhS0VdcKtn0IfhQzPqkM pkBCFpHvBloXhHIhvZll/XXR7f1KELvsUdO/zynaphcX/NZBBR5GuHJ1PxQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45kmd4hfjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:33 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2ff6aaa18e8so8443679a91.1 for ; Tue, 25 Mar 2025 05:30:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905833; x=1743510633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/EQM6DEoDUu6zxmdeqRLQ9xyT8MDYjKcZBBXwIJ855Y=; b=hhyni2o96SWnOdr+gSFHC36TGlZQDiYaLoHsevZUmtwi7nsVU/l/XYN94oYeh1Kxai b2/lyDUeOYsOyTRJaq+lITC/rQoH9gh0YQB1vn0azskw0hP0O327hZ8fU+TTOrxVl2tl SEYDy0aSgIInIz/gDPNQHGwWY1ECtdXGXqVJNnX5RwIbR9xNd2IE4XYtbYeETFa/UgE2 gyWj37AI2Us7IBQWXUFLQNACv3glzrpeN7+H3xBhLgdZcD+0sbLwD7fJv3qkA3VlZAuD w+p7XVAEALQlcSIi50ldREiz6xRjskIRbmH/TjbUY4y2OM8ddllaQXAok8zWiBp14YjP 9y4g== X-Forwarded-Encrypted: i=1; AJvYcCXq/tfp+FW4NvUK1TLTSexTPST/JlAGxoamEvPHU+9QW8ZJsUoT9TCdopKfm/0SDDsFQePCedIHvKtmdBc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7O7ft+0rI0mG4N2w0OkQFhReB74C6NvQp4HOrT3/wmf5jiDyL bWc0OCCL7PhjW1PXn5EjCKhKxCXY3ljx2tl0Q0O1nnNoqgO3+QgDxsxh0WczsdsV2lK50XqUugK tnhmBApYWDy5VLo8zmNED64hf7ZmXqxGo6FqzzDGzRXOqXSXXvi+Gfs5Nj891Wh0= X-Gm-Gg: ASbGncsYdq1tLHTQ6D2Sz+pfYtW7pn2JhbwuK/49IsEp/qalV6kvX5uvn5ienyxQDPX l5tYHwCshHQzfqz2CQrP/RBfAec9X+ScRUC44dCl8G7evgd74sVObu7MpmK1B3EJdsyKFaXT3Wq 9vNvo9OcD8/ffxAaiYlJD1F1nGZIw0RQ1bqY/K8dChTC4sCk9Z4K5HdEIrY5vSB7XWAmFi4YrqV pIslevAkJLrxXxtVKXICukQQIVBLXQm8jNLcU6KmBO/ijsyagGWg7ojHwR5ZQK1CMJEbiN+ERBW RGMVW0uV0S1i7O8dCV9bDAV5bV6iI2jY5h4TJPehA3m2 X-Received: by 2002:a05:6a00:1301:b0:736:5e28:cfba with SMTP id d2e1a72fcca58-739059ffb1amr28507106b3a.18.1742905832860; Tue, 25 Mar 2025 05:30:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHouuf4m/7aas0Ea6VvKqkVXtocGxmnrkYVDOh+y2Z/ngsR4dy9YmGQThpYoaWuqqdjbhek2w== X-Received: by 2002:a05:6a00:1301:b0:736:5e28:cfba with SMTP id d2e1a72fcca58-739059ffb1amr28507042b3a.18.1742905832325; Tue, 25 Mar 2025 05:30:32 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:31 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v1 2/5] arm64: dts: qcom: sm8350: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:16 +0530 Message-Id: <20250325123019.597976-3-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 6OgnRFbn6JoOL0L32BTdwBCcvj4IzGUa X-Proofpoint-GUID: 6OgnRFbn6JoOL0L32BTdwBCcvj4IzGUa X-Authority-Analysis: v=2.4 cv=QLZoRhLL c=1 sm=1 tr=0 ts=67e2a1ea cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=EUspDBNiAAAA:8 a=tc1TWAvYerzeY2VvnAsA:9 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=819 mlxscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 bulkscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250087 Content-Type: text/plain; charset="utf-8" During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Prashanth K Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qco= m/sm8350.dtsi index 5f93cae01b06..a4fc3657ff87 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -2651,6 +2651,7 @@ usb_1_dwc3: usb@a600000 { interrupts =3D ; iommus =3D <&apps_smmu 0x0 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; @@ -2729,6 +2730,7 @@ usb_2_dwc3: usb@a800000 { interrupts =3D ; iommus =3D <&apps_smmu 0x20 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; --=20 2.25.1 From nobody Thu Dec 18 06:17:48 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5839267B16 for ; Tue, 25 Mar 2025 12:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905844; cv=none; b=U+rQXMhGBDC/AVJfCkEgd4lLMwYLwr5hGHr/nHLzyyfc1Vaj94PVSTXowTiXzwXKTtVYJOtl+P1fCN8RaHqkuSavRAVRYlaZ/Lew4KKGYVDtwLASWLyIzC/16JSW50ync8z2Ou+54OzCPvagSKcazlYWFFJ7u4sexc1xN/bkJ60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905844; c=relaxed/simple; bh=qilpJ4cjtgqnPO881wZb0am06aM3yLc86r4tD6NpndY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Br7A6/hDFHfxqxMxrJVzhjNF/mIrLpzX+NQyZcj/I0Fw5AS1MPnoIwDbED/xn20anYyE74C9sQrD6+z2rUHo2omPnnpFSdbVhfk9H4GJnKRbQwNDWC26Kpijq9YLnDmakor7QFD+1h1yYHxFV8HEBEQl2UOhR5y5QzghlcJy+/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F5w7HHvw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F5w7HHvw" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vV6n002243 for ; Tue, 25 Mar 2025 12:30:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=kPZJqI1uck7 luBRZQDPnKRItuLHLZb+DfwEFnWKYwSI=; b=F5w7HHvwDkZ3EyRhcsddClWWlmL De0g3Jcbk4D4bVmXNhtsmorgoOqS6m9lVda2Je1j83GIh7fHQ1jn0DXMeaVrg3J5 GN9j2GX7oFp4n9gZ/6JmvG380HDgEeN3xBkwFP04iMlm5L96mperhwyBook28AhN ioSV92aMVC7ly/oVzEk/NJh8xajXKEIRlgAhDOORBgDFCEE8LNotrBaG5R7OaKBa dVW7g/IhoRkJdCRMj4adIcBk5eLLwRpSB/7/7dJ5fmkXp7hbw3iSjalRWMkF1y3f 85oROW7yZJqge/mnpf6M70z05UxJb9xefOf4HFMZqHS0iph0KJczU6KhjYA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45hn9wfs8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:41 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-225429696a9so144978635ad.1 for ; Tue, 25 Mar 2025 05:30:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905836; x=1743510636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kPZJqI1uck7luBRZQDPnKRItuLHLZb+DfwEFnWKYwSI=; b=TrzS+72XdqzByKP1cwrmbzN3lGYeeZe7IbQqiYgA4QEoCSJFSxJog7UvjJ3dFuoFz0 PLnu++4bZUWPk/Nug8MLu7Qn1IdYSXyQJl017dIHcIFv1GFYqo4dsSXig4+XXEYUbtD5 ncGBEDug3uyF96Rb0Q84grVd4BYvCn36nGvHEiVP6hEXb91ZDA37Z/6yFDQmFfqsGHgB vht1goGgoKsuAZjVeviMvMPUY+gWRYvlsELETO0CYmpxgG8F5FohxbliUcEUEOtHT4+x ZEzFQgvTSK7JvreBzrYv7Xoo6B58mxy2SeXlBzGlhviCwEX/9npv6QGZUY4He3xUe3ru +ikA== X-Forwarded-Encrypted: i=1; AJvYcCXzMhsa9M14lmw9DSKGdliiRM0f2fSSknY0O1pTmhGX3s4YAIKD5NXObz1M7GBmllw/WGKI4DN/ix09qPI=@vger.kernel.org X-Gm-Message-State: AOJu0YzU2BAghsKFjMJJ6Mvh8ZI6vdRhOrhCRy9O2wpn+YD0qrBGaAhG dTfilj2RDsb2U3emTmLRuY+KcObk6Pcxq5c4WoADtOGZrJO8CbiHG/UGo+3IItaJurxkDGWHXsz CpvJ+JekFHTgZGSeiLOjeGf5w81aUg1h2qTvtD6wZT9LKrIRPDahdrty8vD9Cfr8= X-Gm-Gg: ASbGncvCjU+EQke3xQU7gl+KZoI5pLadLRVHuSOY/PTXagXBicYp57FXV/fTmTIN9Xn s0A04e+FftAusWMYoH36iEzFFs3agK5Yv9tsJzZL63I9GJqW1sKam7TqtXKArDfVPv+9MnDAq3u FEplwaK32yiPbo8ekTIwP5vQzFllmGP6poD7F4FueEBhNI/YlNK3M0O/O/2zCQJEyDHy29rDyMQ /zOpiRAg5LOQvbUpis2MiT7xtdQNJoL3mvwx16V4WrHpqdabeF/A0z4pCGs1P1p5CSFyZoaHn/8 EFPbXcm/OaICJjJGaLnIfQov9Fs0y6ZNAil30mUwswMH X-Received: by 2002:a05:6a00:8017:b0:736:4536:26cc with SMTP id d2e1a72fcca58-73905a2786bmr29132411b3a.23.1742905836248; Tue, 25 Mar 2025 05:30:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcDgZuM5dlRYn7F5OTGm0QqT+WC/cQOltrUZIrZSAh8E4Gc4dpW0xBXL4OpnIbD0hldQ5kFw== X-Received: by 2002:a05:6a00:8017:b0:736:4536:26cc with SMTP id d2e1a72fcca58-73905a2786bmr29132315b3a.23.1742905835547; Tue, 25 Mar 2025 05:30:35 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:35 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v1 3/5] arm64: dts: qcom: sm8450: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:17 +0530 Message-Id: <20250325123019.597976-4-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: iM05OUo51xig-n4Zuitgui28FKmk-E4e X-Proofpoint-ORIG-GUID: iM05OUo51xig-n4Zuitgui28FKmk-E4e X-Authority-Analysis: v=2.4 cv=CPoqXQrD c=1 sm=1 tr=0 ts=67e2a1f1 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=EUspDBNiAAAA:8 a=1HEuz3GWIXJSLhVaKDMA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=883 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 Content-Type: text/plain; charset="utf-8" During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Prashanth K Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index 0b36f4cd4497..58c98bffee17 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5461,6 +5461,7 @@ usb_1_dwc3: usb@a600000 { interrupts =3D ; iommus =3D <&apps_smmu 0x0 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; --=20 2.25.1 From nobody Thu Dec 18 06:17:48 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06A9267B15 for ; Tue, 25 Mar 2025 12:30:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905844; cv=none; b=nNEN5WAwHVJ6X8SSNoydUyyLHn+ydFNHvkUJ4CjJxu+wiA0fIBKeu5oUSPqcBCKUPYnB/gDnb6sAwCtmn5hqwget1WFoyKsIiZLN71jnI//imq4ISyyCqnahxCSu0gSzO6YchpqeM4WlVupUscwqS8JzNRoKmfLwn7Fe+DammZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905844; c=relaxed/simple; bh=ByapJwSaA2JYsoTiCefCg7xWdc4BAw+unYZtlLMXgXc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QmY3C81FXSdXzCGSDrILDPCuOkyrOFrwSLf7KBzqs2zDfVv+Fk3oNvQu2WGOvoU9p3wrehpr1Wrl52M7X1OYLLkLhpnZZqvPKaj3ZgE4hlyC7/XhKzaZh4/7Y3ncOtOdsn3RPfZ+u1G5fs9zBjO7LFd7qSpr8H+qnEbXH7jAWU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qf+BZY1Q; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qf+BZY1Q" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vVeY008305 for ; Tue, 25 Mar 2025 12:30:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=c4cq5PoeUBT cNntuXgA7GanwXybPSAE6G2RvKQ8Ix2E=; b=Qf+BZY1QkL1WcKl23uKV7ZgMd4x tDxHOc0s0gHSInMrJ0OKi6Tmtncd4igBZ73aIHx7uLJEVA33SJrkXCUrSReCLxsi 5Ben+vnxK0eCTuH6vfO369c5Ak/e1QBoZjpgQNKvl+WQYlbgl0M+nOpD4g3vkt8k 2396zDHSE41TmceC4cLPddq/0LAC2pxm3bHnPZKNlxbEzYB2HzmjpronV4Hrvjtm R/g8RUhqjNDzJ+LOhipu0/Mv9ZjLE2krnnXLYzIsHkJtvQcRGsJKnqAInV0SVkei yC18CGrx+CN8rzdcA16ocloZnK5GxXVcPb7YsW97I3BbW/xQgsooZXTn2rw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45kjjf1qeg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:40 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2242f3fd213so88164435ad.1 for ; Tue, 25 Mar 2025 05:30:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905840; x=1743510640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c4cq5PoeUBTcNntuXgA7GanwXybPSAE6G2RvKQ8Ix2E=; b=evM397OLzlFMVV/CMJ7fPvHE9D1Ij1snrBIDYmwuCeLbKumeTEQDGYlwNNjt8tCXqD JhC5qBWZl9Ol0bWNFR2erDLHjMUHuy3dZEX6nM/Vr7jeaGX8OLSkR5j5taikFlHfFUdj sBXx36qg/8Ql0+s/Xqcn8QXwzw4o4EwZuGrOFpJAO8bp54Dgf39/q6lhJW+sDqmqidSt qKQwk6Qwj5hqkK82Uzm6HLxTLHEbXsgw4d1nUCBdEfIa849IZGmg43ogRzpkJMN1HO0e CcAhftzBpsimjQm7X9b1RMTtoqAXO6k326uaumz0912m8pFzU4M+fKCO2VC3Kpih2/mZ 9pNg== X-Forwarded-Encrypted: i=1; AJvYcCVflfXeecv/d94nV2aL7Z9FRwv8/ekiMUT7eX3YSGE/tJKFpU5IITa21EtCcApxyhOgTuUj1Vzj+D7L3a8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj4bSGT8jqRzuzWVKUgYewJOhgGdF6z1/AM6PZBkGZwWoHUZU2 k/CY5A+f13AfEL4gULI5/k1Rb4nvguQJHbhZ31NVNYeZ5rBsGMfr+fGqIB1zh2JR5ZCb43Od/2s iEViiM+RXqFG0GFRLP1f57qoQKafF6uLAI0/dFRGM5kkOigF3Eo0YfkgddG2C+/o= X-Gm-Gg: ASbGncvFJBd38sgrtrqff46iJZ6DjZc6DdBEClL1RZh2u5Svpxxn7g3MjFj6MN2RbUi BucG9LUEE4oQUShd/dNvnbr4YEhAUouVfnUCgoltMgr3v+P2kCzZBz9jGHRrEvuqV9c8SV+hkAp Lk9p0kbHO/1OvenMS3x1YwfmVwGOnMBhyC1LHfGOXP1R7VQWe13UarzjAoyjJjtKT8N5TkoQemO Myjm6ALxvVGlnQY7c21HA2o+6tA/BvDEmfsfCk1+7j38PxtnHibN1ix5UmN7+uFnc8cIjBJQ4qr aJyRQNqpCbvNXnnfX1agHlrxRYeZbjuAUPfT7YN22/1W X-Received: by 2002:a05:6a00:3d0a:b0:736:4d05:2e2e with SMTP id d2e1a72fcca58-739059667damr27448231b3a.6.1742905839733; Tue, 25 Mar 2025 05:30:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQch3AWha2DTxlzFMtC4JDwLKFF9RrWxn4KNzLCG3jKZZdV4T/Tl4Cj9iV3polzJ105XA7xQ== X-Received: by 2002:a05:6a00:3d0a:b0:736:4d05:2e2e with SMTP id d2e1a72fcca58-739059667damr27448188b3a.6.1742905839174; Tue, 25 Mar 2025 05:30:39 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:38 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pratham Pratap , Prashanth K Subject: [PATCH v1 4/5] arm64: dts: qcom: qcs615: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:18 +0530 Message-Id: <20250325123019.597976-5-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: Ieunol7x4qrCpUhMH2v14Fx_x5WOLfGF X-Authority-Analysis: v=2.4 cv=Hol2G1TS c=1 sm=1 tr=0 ts=67e2a1f0 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=xQyWRTzcSYSkOWr2IqcA:9 a=1OuFwYUASf3TG4hYMiVC:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: Ieunol7x4qrCpUhMH2v14Fx_x5WOLfGF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=834 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 Content-Type: text/plain; charset="utf-8" From: Pratham Pratap During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Pratham Pratap Signed-off-by: Prashanth K Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcs615.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qco= m/qcs615.dtsi index edfb796d8dd3..7c377f3402c1 100644 --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi @@ -3600,6 +3600,7 @@ usb_1_dwc3: usb@a600000 { snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,has-lpm-erratum; snps,hird-threshold =3D /bits/ 8 <0x10>; @@ -3661,6 +3662,7 @@ usb_2_dwc3: usb@a800000 { phy-names =3D "usb2-phy"; =20 snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,has-lpm-erratum; snps,hird-threshold =3D /bits/ 8 <0x10>; --=20 2.25.1 From nobody Thu Dec 18 06:17:48 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678E8267B9B for ; Tue, 25 Mar 2025 12:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905855; cv=none; b=VtC5tgMcfV9nADz7qKb7Yo5SR5Vq0Q0t8yvJVLkOaSRiZ4rLKCi6P7rsbKcT/AY9i5ju3ILhVqMWJDDwVC2Fkt8c0xvKqfDhA/Qjq38+komouKjNFFLt9cI32GDTh1l8one0x+uW43oMar8aZR9O+qQOGNHkHWrtbns1G8vyh5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905855; c=relaxed/simple; bh=OPB2Ai+uZO0JN8fesuuuEH/Ql4KaJvx16g8TbS7kDy4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SXKkv0lVnJYNTP++VnzMgScn98h3UsPC8YnMLG5EkMsAZMyRR/Eww2IMYibDmCtsnyHHPfsvgWQGwznRHVvJncqQ6jfrKOHYk3iSO4Io4p6vzcY+VGob3fBm+LbjGxMapifEMZ98Sc1BqNF6ejme2froK0WI2MzjJnkf398R9Ks= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mmbIRFMd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mmbIRFMd" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vsOR021964 for ; Tue, 25 Mar 2025 12:30:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cV8GYTdiXT0 TDERwijtWAGMsmtXi/MaMGlqd90S9WIg=; b=mmbIRFMdx00S3E2liQsOzGgqEvK P02eDegng3MohXPNrX+G8pFatT25bPvV4fZHo7HnAcrWNQD4oYG+GZXR8ZPSR2Iq HvVRP3U8jC3to5/PnTQZ18Pl2NPUNI29qTLvB9rKOkEofGX/TyT/3WJIqZom9JqQ Cqls5Q7ivmwc9mHoC8e3F6U7cJzGv6P4t4kHryfdHRrZH9ads+aENE6cjVrFbp0E JOMlZSW5PtuNZC83vWHkXgwzKS6+KIJvz1OESstOfZPx5SeOUFiyshOWP330uX7I zRjgoVyjL+CsvPuUREou/jx82Vx8jOsIeo23EuBwtV0HyTDtyeB258C3DWA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45hmhk7tsa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:52 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2240a960f9cso91437225ad.0 for ; Tue, 25 Mar 2025 05:30:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905843; x=1743510643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cV8GYTdiXT0TDERwijtWAGMsmtXi/MaMGlqd90S9WIg=; b=FsAtukQsgH4j/F5qtPxX/aZMKQqyUOdlks2NDBZjwpCAHA+aNntt30gK97YFZVt6uv pN7qCLkHMr7LJQCdyt5QqvHQAfsqgBWG091a7I1qhlGa31YN+EcwjwEctY0HzZ21gIVX HeWqT5WJ0pFRts/PonHksmJRxYGUwv0yqfokNZZWlMnz3LRv4LOlNZspuzQxsNaSC6TU oVmxeTnagIvfGUk4lXqgvqeiE3OB5MqbZDx5sWIYQTQYbDneP5gCodCniecCZwvnFe+U 1jw16uyh8ZbjPdLxlCRccf9qXZoMamoNTAJDN4wB2o826r+oPegGg5XzNS66+7TEyCyO A9eA== X-Forwarded-Encrypted: i=1; AJvYcCVSUixiMvIRO5mAynKpoPLNW9deBunuoDmQjBHABia0581+6LlAbxTE1xQ9SdFUhJlddHk1H+W3/0k4HUA=@vger.kernel.org X-Gm-Message-State: AOJu0YyEOD5SU4RT/c0QYG956cHNdNAqZL9ajMN2GipJW8ksIDZt+Zxb uAP0pTuvHAykoc2kmBOebm5EDj3rapN1K/XnIngU7c5cwMAGzbQnrCbegnPUiHoHfs80JMU9AsP EtnN/arm5XMtPfmQbu2fo6qTEI21nwFtGEcpZuykk5bDeXzfspxO64xptEAv2IGn15X2ddfU= X-Gm-Gg: ASbGncv3R4bWaCjrxTZFWl7zCT5uaSrR6aN35NvZuw3kCrfmtiqivSZBMShm2HbUjBf EkwPPcZRDR8X5Se1vDiWtN/UXT9hsFS98Qopb/95jagyBFvkCh31sQcPZe7zwL2LnT0bqCSaBE5 m1vwPH9FEbDpa/nEk7xHqVAccgBMRxX0d5a6R+/19MRNyTFh0N7ePVRgxnqK1KMD+7mOiflOcTH Sk5Ck4zQI/XCGe4TFlSyHDUeUXTFhGEGoGFrEhOOvLjCYQgeit3y/4nWKSS+K31EWu1qeqEnVLr wRYj8EwwyEYVe+JzGyLqLd/k0umrSJv/4MziJCfufi1G X-Received: by 2002:a05:6a00:c92:b0:736:3c77:31fd with SMTP id d2e1a72fcca58-73905a364b0mr22153567b3a.23.1742905843272; Tue, 25 Mar 2025 05:30:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjMUj1TLOsrYDkG5M5EtFQfcFnxQW3340OpNyCVSxp8cds6pRnYowPm6jrN3KQxqvr/9ZaFg== X-Received: by 2002:a05:6a00:c92:b0:736:3c77:31fd with SMTP id d2e1a72fcca58-73905a364b0mr22153500b3a.23.1742905842630; Tue, 25 Mar 2025 05:30:42 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:42 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pratham Pratap , Prashanth K Subject: [PATCH v1 5/5] arm64: dts: qcom: qdu1000: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:19 +0530 Message-Id: <20250325123019.597976-6-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=C4PpyRP+ c=1 sm=1 tr=0 ts=67e2a1fc cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=1HEuz3GWIXJSLhVaKDMA:9 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 4KWfPd20lQOR0AePSDLW2CKjHII0lTQr X-Proofpoint-ORIG-GUID: 4KWfPd20lQOR0AePSDLW2CKjHII0lTQr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=896 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 Content-Type: text/plain; charset="utf-8" From: Pratham Pratap During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Pratham Pratap Signed-off-by: Prashanth K Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qdu1000.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qc= om/qdu1000.dtsi index f973aa8f7477..b3c673e24726 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi @@ -1022,6 +1022,7 @@ usb_1_dwc3: usb@a600000 { =20 iommus =3D <&apps_smmu 0xc0 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; --=20 2.25.1