From nobody Fri Dec 19 00:35:28 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BC2E433A8 for ; Tue, 25 Mar 2025 11:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742903169; cv=none; b=AR5Wl7rR8mtw9Vm74HTArI7w4I4X4RNN0V7OkFMLDxelWE3fKOhU7R6ZymIKZQp5j6BtRkBgqevjEs2bu4ui/N8KD1N4nUe7os8DDsQ5pj0T1oSEVwqrHQx7ujA1om0mMSlS2L9GD3RhAVEe1e6Tn9+06sIdgEvRliMrrsMOwNk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742903169; c=relaxed/simple; bh=3I6YOEEevm7Iddu9Wu3uhmlaf4D1s7KW/SvZf1lAK98=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Qc1ndHhH0zkloCl83r2piWt9Gh9THz5NTSxUt48LnNIB3seSPMsYClVHdrYfWsfqbvp+vr9U0Akufqgn7YQRnff17+IWIvHk6KNvlzy6fnjHgw4rbZVTeQEr1M1pNE+6hJKdwq1x7FjhsHCGfYd74zayVkve6KO+xs6pmPuVdj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VZuvQZo0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZuvQZo0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cf034d4abso58912835e9.3 for ; Tue, 25 Mar 2025 04:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742903165; x=1743507965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QM6yckbMzLuQtYcD19Hf+kaqNYJs8oHRxuA6VUZJjFY=; b=VZuvQZo0regIewOmEmcqDhJ8v807sBkxtWTAZ/VPK3VBGnZSQBPLi5HbJY5cf0ragZ 9DTdLaUFqCiYKLyzV9+8Elzb8LnUIaHSg4nTCla/szo1PNRkE7IO2QMIx0/QhYcPwMSZ xLPlu8HI+Ob337ZlDZ6ce7S1nYisWQZYROpIoAb3dnBrhF57LvOIOAS/4GiGM3iU/Kcq vYpuYG0iDcrOq/FpagazYq9046bpZ0IgCGP4O+hsBQaeQpP5JFmjImoJxGeKoJkpP3aQ C7qXxvhu0zcGi/LMiDSQGMi9+W4WfVlkSsmE1rOFZKafwRPChp4/Iuqjd7vrW5Ip+jeA kUgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742903165; x=1743507965; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QM6yckbMzLuQtYcD19Hf+kaqNYJs8oHRxuA6VUZJjFY=; b=jFNu1JYa/bEQQIsZa2YkSaORLbpbH/J7xxhXXzxOSPc7jVxFpuS9QDOLV+Or8wFd4m oS8PzLJ7IJNwixOzZZAvOATBxn49LQ+tbPA/jM7PZ96Te1p7+vxDnlf1PZh1RP9JZ5Zx Gxm0E8z0p3iWru+1HkgClLO2FYCM0N6F0ibquNfF/ekml0n6X6pxVdGbHlnIM5Nm5yxG L1YYgFqr67PzC0bRvGCEmUiKARhHGyMRZhHUZBqZqTYScOCscaxltgzwIQ4A7l10VQds tRhbKP92l0vjcsWoYijbNGlzexA9KqiDVhgsIXSFl7EfahSrOpHJ4NHsdM6y6KmLXNw8 TmIA== X-Forwarded-Encrypted: i=1; AJvYcCUibnkqEqWHqDqgWmnZwoi7SM/hJ4oLl0AYl0/kyb/+aOw+U8Fit9q6SfBP3Xfj08w++uKrMTWZKkj00wI=@vger.kernel.org X-Gm-Message-State: AOJu0YwvZJOhQCEXj3ca3oIUIWssfgs+RjRzNyKQgqqiymlip/WKpZAT YR+LcgSWOEx6R2cPrxPKHrfAd1NCR5mEVZ91tHOyW8AARtCl9CUx X-Gm-Gg: ASbGncvkmUrtXQ1TO+JlatAMMs9SQMlJ85JxdUegMcYghRURHYB0IRw2B0Z9viXSg2S WR/ozi7BvhtcP+QFOHJFX98QALKi4hEkZOkFra+g5BQBVr+9/5SGo8TwWNh7sB4n9SZkLQuwKB+ 8gCBoiOKR5sNWoWOnhLqn8aqjsizJE3sZKl7ZDNvrjIwfTy+VFgYwHFK/oKqrP76R1Z9xxcpnfQ lTJrojOQ/LvTkxOFqyXzXTXwZJC8UgpJwCAvdBs7G55DfKQLzhkYPS/byke3uZfIv+rWFY99mZE qqdinMy+lrBMaz9lTwFRyh4UMDpDo2IjpjIyyLng+w== X-Google-Smtp-Source: AGHT+IG1gg+2VMW6S40TL5SGmizmMHwcdq3j/bUWa544XwDYu50O4TXneCJnlGDTs3FUGeIlvjDRfQ== X-Received: by 2002:a05:600c:4e41:b0:43d:1824:aadc with SMTP id 5b1f17b1804b1-43d50a3632emr167118635e9.29.1742903164542; Tue, 25 Mar 2025 04:46:04 -0700 (PDT) Received: from pc.. ([197.155.71.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d6ddf2974sm12782885e9.0.2025.03.25.04.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 04:46:04 -0700 (PDT) From: Erick Karanja To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev Cc: philipp.g.hortmann@gmail.com, davidzalman.101@gmail.com, vivek6429.ts@gmail.com, viro@zeniv.linux.org.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Erick Karanja Subject: [PATCH v2] staging: rtl8723bs: Rename variables v2 Date: Tue, 25 Mar 2025 14:45:52 +0300 Message-ID: <20250325114552.45393-1-karanja99erick@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable `supportRateNum` to `support_rate_num` and variable `supportRate` to `support_rate` to adhere to Linux kernel coding standards by using snake_case instead of CamelCase. Fixes checkpatch.pl warning: CHECK: Avoid CamelCase: v2: Fixes checkpatch.pl warning: CHECK: Avoid CamelCase: Signed-off-by: Erick Karanja --- drivers/staging/rtl8723bs/core/rtw_ap.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index 50022bb5911e..d46a04b9a05e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -370,7 +370,7 @@ void add_RATid(struct adapter *padapter, struct sta_inf= o *psta, u8 rssi_level) void update_bmc_sta(struct adapter *padapter) { unsigned char network_type; - int supportRateNum =3D 0; + int support_rate_num =3D 0; unsigned int tx_ra_bitmap =3D 0; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; @@ -396,9 +396,9 @@ void update_bmc_sta(struct adapter *padapter) /* psta->dot118021XPrivacy =3D _NO_PRIVACY_;//!!! remove it, because it = has been set before this. */ =20 /* prepare for add_RATid */ - supportRateNum =3D rtw_get_rateset_len((u8 *)&pcur_network->supported_ra= tes); + support_rate_num =3D rtw_get_rateset_len((u8 *)&pcur_network->supported_= rates); network_type =3D rtw_check_network_type((u8 *)&pcur_network->supported_r= ates, - supportRateNum, + support_rate_num, pcur_network->configuration.ds_config ); if (is_supported_tx_cck(network_type)) { @@ -817,8 +817,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 = *pbuf, int len) u16 cap, ht_cap =3D false; uint ie_len =3D 0; int group_cipher, pairwise_cipher; - u8 channel, network_type, supportRate[NDIS_802_11_LENGTH_RATES_EX]; - int supportRateNum =3D 0; + u8 channel, network_type, support_rate[NDIS_802_11_LENGTH_RATES_EX]; + int support_rate_num =3D 0; u8 OUI1[] =3D {0x00, 0x50, 0xf2, 0x01}; u8 WMM_PARA_IE[] =3D {0x00, 0x50, 0xf2, 0x02, 0x01, 0x01}; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; @@ -883,7 +883,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 = *pbuf, int len) =20 pbss_network->configuration.ds_config =3D channel; =20 - memset(supportRate, 0, NDIS_802_11_LENGTH_RATES_EX); + memset(support_rate, 0, NDIS_802_11_LENGTH_RATES_EX); /* get supported rates */ p =3D rtw_get_ie( ie + _BEACON_IE_OFFSET_, @@ -892,8 +892,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 = *pbuf, int len) (pbss_network->ie_length - _BEACON_IE_OFFSET_) ); if (p) { - memcpy(supportRate, p + 2, ie_len); - supportRateNum =3D ie_len; + memcpy(support_rate, p + 2, ie_len); + support_rate_num =3D ie_len; } =20 /* get ext_supported rates */ @@ -904,11 +904,12 @@ int rtw_check_beacon_data(struct adapter *padapter, u= 8 *pbuf, int len) pbss_network->ie_length - _BEACON_IE_OFFSET_ ); if (p) { - memcpy(supportRate + supportRateNum, p + 2, ie_len); - supportRateNum +=3D ie_len; + memcpy(support_rate + support_rate_num, p + 2, ie_len); + support_rate_num +=3D ie_len; } =20 - network_type =3D rtw_check_network_type(supportRate, supportRateNum, chan= nel); + network_type =3D rtw_check_network_type(support_rate, support_rate_num, + channel); =20 rtw_set_supported_rate(pbss_network->supported_rates, network_type); =20 --=20 2.43.0