From nobody Fri Dec 19 08:56:22 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D654D255E3E for ; Tue, 25 Mar 2025 08:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742889782; cv=none; b=O4ui6zj2wNPCtG8miTR/VtoLvpLlL2nkg3gM2iMfF88XeWU10C7BeKxz0y2ni8/9K9HDr5wkftTB6Pl2v7KMunUJLvffXMj8DJAI+Q/9I0EtT2Dh8esjmZjzq3o3+LBitvwkGGAqaZNIsnHMWc+ZbFEAaO9xC6+9hiWfUlBCb9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742889782; c=relaxed/simple; bh=uFJtcwIQ1CrXzPB2yfec+q99KZjeh90NRZivuV++Rmk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r+mLYrJZKBtooCCEWwHX4nU66/EPAm0m6jYsEtLhGBHVB+lx/qsBT0cNeHiLE3XO+JHPJnetL8szfb2NW1yb7dIe1x/zkWogbB2HDYywWtOismmjP0Wd1zlGyibHwxKki8523lFhLnqxI93BlwuOwLr93IWE5hXVoDUCaCkp85M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZXNBuKx0; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZXNBuKx0" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so9836439a12.0 for ; Tue, 25 Mar 2025 01:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742889779; x=1743494579; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1ZlhvhiNMPHxjTtYHGw42ITvKgA++Bx2WHTs5Yktipk=; b=ZXNBuKx00maYWet5xlpPrGkZ769b8MT6Vp0PGeh57w8j14q9waMXGF1yM5dMqgXUB9 5yDsijMNPpifWJ6NsRnCw5sZwVpEuPniaUjdF5tEY+k4MXuS1sCWJP+IgcAn2gWFTzWi CBPx4YXuRM1rrOm0KC7eODmh4lz9cTWLw9GKeypo3Jw12iXVRAhpSpEBSDo5IudeWg7Z mfN6+B8A+NrVvVix9v83aQvIg5lq5i74DMVx514oxiCv/3dqaBGsBH5Cw6f3DcJDcR4G Yb2VxZeob9/+Py5u5WXQf4RYrBkwg22/KVThpF5eFdry8ChTb9OjuPd/X0OXQyljJaCM yIUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742889779; x=1743494579; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ZlhvhiNMPHxjTtYHGw42ITvKgA++Bx2WHTs5Yktipk=; b=bOCHwFl5/KXPL6PlciDSRrqpVdeI+UjsQeHQrMYobgQ7QVr5v2azks5257C7SOQtas pSTjODhGxe81zR6w9oSK0kLX6F0P0X3OdJb5i55ZsJaiPsSny+FBLJqC8cRy0qDIdU7+ aFZ3mbBaR88J9BWwTEkb3CjfNwW4munYFozO/g5hA5GyeEO5gyKYPV5CAD0V0SbsnprW 9seIXMKxusqZMlYpPnUj6g/rDYJnzDzTlw5Gc4miQnLuXdJSCIsAO6Iz/ReDgPX2xcac lWKybCVT4jPGCyA0q3AGAxhSnxaXb28t9gmYgi6VsOtMbtIdBJIxgR13vqkjD4JYJA4d zVsQ== X-Forwarded-Encrypted: i=1; AJvYcCVi3GqWYgv2IuBCox9OTdeP7fyU60eKbsubHXeOf2+MVO7Fo80q5Dpwi+8D4tyY3yh+cLkGL0WXzwJPnqg=@vger.kernel.org X-Gm-Message-State: AOJu0YzB7PYHraHIAVWxQDudMIw7COIYaAvcjshOjQ0AlOJGTGbi6znB OikKoQ28KK+6gFw09b4bJD6nIkXNpMaEb78eG7SHOC1ozK0Mz9Nqh3f8WJE2RhE= X-Gm-Gg: ASbGncuhbC/B7TSv7BEAAetHPGwWVu+mf6FdO64283AetfvtsFayI9fPlrWIM1g837D yyCQxX0dw46pQ7tmQvqwXOa5GVsbT7yxdcxxmMMJtCXxNlMR2c3gBW+6zvBUlloZN3UvnZPenOD 2kKQThVklqMtryILHVd41cXwq7SS2SemAnjjJ0TkDe5iJ19J+5WP+o58i8n28QueELGR4W5+eiH J2AO7i15JKMv5znv7d+VWOXI64ApD8iUGxKroXgaUHhp/2nwFs/6rTPYWb7Uoe0OWGVrgmuhp0T rI8Wkgyy2n6F8uk5VkJB0/ieNWWR6IEO5LktykSYfOnukdtC+9eISJlnUYNSu8CgR37bFNYk3ul xyb17aTlekhEP7hFLh9XIOXpTnjqq X-Google-Smtp-Source: AGHT+IG21siUTHpsNWmOw9HSinFH+IPchBRopZy6E02ZeHpcuR24cp0e214ayW7RohQFDNFgVeLdYw== X-Received: by 2002:a05:6402:5209:b0:5db:7353:2b5c with SMTP id 4fb4d7f45d1cf-5ebccde2614mr12334411a12.11.1742889773910; Tue, 25 Mar 2025 01:02:53 -0700 (PDT) Received: from puffmais.c.googlers.com (8.239.204.35.bc.googleusercontent.com. [35.204.239.8]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ebccfb004fsm7446785a12.40.2025.03.25.01.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 01:02:53 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 25 Mar 2025 08:02:29 +0000 Subject: [PATCH v5 6/6] nvmem: max77759: add Maxim MAX77759 NVMEM driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250325-max77759-mfd-v5-6-69bd6f07a77b@linaro.org> References: <20250325-max77759-mfd-v5-0-69bd6f07a77b@linaro.org> In-Reply-To: <20250325-max77759-mfd-v5-0-69bd6f07a77b@linaro.org> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , Kees Cook , "Gustavo A. R. Silva" Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hardening@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This driver exposes the non volatile memory using the platform device registered by the core MFD driver. Reviewed-by: Srinivas Kandagatla Signed-off-by: Andr=C3=A9 Draszik --- v5: * follow API updates of max77759 core driver v2: * align sentinel in max77759_nvmem_of_id[] with other max77759 drivers (Christophe) --- MAINTAINERS | 1 + drivers/nvmem/Kconfig | 12 ++++ drivers/nvmem/Makefile | 2 + drivers/nvmem/max77759-nvmem.c | 156 +++++++++++++++++++++++++++++++++++++= ++++ 4 files changed, 171 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a1abc3fa52a9713da19a1d8d4f625fd9aeee06b3..e3e92ce1518140293069d1d544c= 37b20dd5c5b95 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14575,6 +14575,7 @@ S: Maintained F: Documentation/devicetree/bindings/*/maxim,max77759*.yaml F: drivers/gpio/gpio-max77759.c F: drivers/mfd/max77759.c +F: drivers/nvmem/max77759-nvmem.c F: include/linux/mfd/max77759.h =20 MAXIM MAX77802 PMIC REGULATOR DEVICE DRIVER diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index 8671b7c974b933e147154bb40b5d41b5730518d2..3de07ef524906ad24a89e58abdf= e93529a83c80f 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig @@ -154,6 +154,18 @@ config NVMEM_LPC18XX_OTP To compile this driver as a module, choose M here: the module will be called nvmem_lpc18xx_otp. =20 +config NVMEM_MAX77759 + tristate "Maxim Integrated MAX77759 NVMEM Support" + depends on MFD_MAX77759 + default MFD_MAX77759 + help + Say Y here to include support for the user-accessible storage found + in Maxim Integrated MAX77759 PMICs. This IC provides space for 30 + bytes of storage. + + This driver can also be built as a module. If so, the module + will be called nvmem-max77759. + config NVMEM_MESON_EFUSE tristate "Amlogic Meson GX eFuse Support" depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile index 5b77bbb6488bf89bfb305750a1cbf4a6731a0a58..a9d03cfbbd27e68d40f8c330e72= e20378b12a481 100644 --- a/drivers/nvmem/Makefile +++ b/drivers/nvmem/Makefile @@ -34,6 +34,8 @@ obj-$(CONFIG_NVMEM_LPC18XX_EEPROM) +=3D nvmem_lpc18xx_eep= rom.o nvmem_lpc18xx_eeprom-y :=3D lpc18xx_eeprom.o obj-$(CONFIG_NVMEM_LPC18XX_OTP) +=3D nvmem_lpc18xx_otp.o nvmem_lpc18xx_otp-y :=3D lpc18xx_otp.o +obj-$(CONFIG_NVMEM_MAX77759) +=3D nvmem-max77759.o +nvmem-max77759-y :=3D max77759-nvmem.o obj-$(CONFIG_NVMEM_MESON_EFUSE) +=3D nvmem_meson_efuse.o nvmem_meson_efuse-y :=3D meson-efuse.o obj-$(CONFIG_NVMEM_MESON_MX_EFUSE) +=3D nvmem_meson_mx_efuse.o diff --git a/drivers/nvmem/max77759-nvmem.c b/drivers/nvmem/max77759-nvmem.c new file mode 100644 index 0000000000000000000000000000000000000000..48727cdfd392bd686a524202f97= 52a19def9b115 --- /dev/null +++ b/drivers/nvmem/max77759-nvmem.c @@ -0,0 +1,156 @@ +// SPDX-License-Identifier: GPL-2.0-only +// +// Copyright 2020 Google Inc +// Copyright 2025 Linaro Ltd. +// +// NVMEM driver for Maxim MAX77759 + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MAX77759_NVMEM_OPCODE_HEADER_LEN 3 +/* + * NVMEM commands have a three byte header (which becomes part of the comm= and), + * so we need to subtract that. + */ +#define MAX77759_NVMEM_SIZE (MAX77759_MAXQ_OPCODE_MAXLENGTH \ + - MAX77759_NVMEM_OPCODE_HEADER_LEN) + +struct max77759_nvmem { + struct device *dev; + struct max77759 *max77759; +}; + +static bool max77759_nvmem_is_valid(unsigned int offset, size_t bytes) +{ + return (offset + bytes - 1 <=3D MAX77759_NVMEM_SIZE); +} + +static int max77759_nvmem_reg_read(void *priv, unsigned int offset, + void *val, size_t bytes) +{ + struct max77759_nvmem *nvmem =3D priv; + DEFINE_FLEX(struct max77759_maxq_command, cmd, cmd, length, + MAX77759_NVMEM_OPCODE_HEADER_LEN); + DEFINE_FLEX(struct max77759_maxq_response, rsp, rsp, length, + MAX77759_MAXQ_OPCODE_MAXLENGTH); + int ret; + + if (!max77759_nvmem_is_valid(offset, bytes)) { + dev_err(nvmem->dev, "outside NVMEM area: %u / %zu\n", + offset, bytes); + return -EINVAL; + } + + cmd->cmd[0] =3D MAX77759_MAXQ_OPCODE_USER_SPACE_READ; + cmd->cmd[1] =3D offset; + cmd->cmd[2] =3D bytes; + rsp->length =3D bytes + MAX77759_NVMEM_OPCODE_HEADER_LEN; + + ret =3D max77759_maxq_command(nvmem->max77759, cmd, rsp); + if (ret < 0) + return ret; + + if (memcmp(cmd->cmd, rsp->rsp, MAX77759_NVMEM_OPCODE_HEADER_LEN)) { + dev_warn(nvmem->dev, "protocol error (read)\n"); + return -EIO; + } + + memcpy(val, &rsp->rsp[MAX77759_NVMEM_OPCODE_HEADER_LEN], bytes); + + return 0; +} + +static int max77759_nvmem_reg_write(void *priv, unsigned int offset, + void *val, size_t bytes) +{ + struct max77759_nvmem *nvmem =3D priv; + DEFINE_FLEX(struct max77759_maxq_command, cmd, cmd, length, + MAX77759_MAXQ_OPCODE_MAXLENGTH); + DEFINE_FLEX(struct max77759_maxq_response, rsp, rsp, length, + MAX77759_MAXQ_OPCODE_MAXLENGTH); + int ret; + + if (!max77759_nvmem_is_valid(offset, bytes)) { + dev_err(nvmem->dev, "outside NVMEM area: %u / %zu\n", + offset, bytes); + return -EINVAL; + } + + cmd->cmd[0] =3D MAX77759_MAXQ_OPCODE_USER_SPACE_WRITE; + cmd->cmd[1] =3D offset; + cmd->cmd[2] =3D bytes; + memcpy(&cmd->cmd[MAX77759_NVMEM_OPCODE_HEADER_LEN], val, bytes); + cmd->length =3D bytes + MAX77759_NVMEM_OPCODE_HEADER_LEN; + rsp->length =3D cmd->length; + + ret =3D max77759_maxq_command(nvmem->max77759, cmd, rsp); + if (ret < 0) + return ret; + + if (memcmp(cmd->cmd, rsp->rsp, cmd->length)) { + dev_warn(nvmem->dev, "protocol error (write)\n"); + return -EIO; + } + + return 0; +} + +static int max77759_nvmem_probe(struct platform_device *pdev) +{ + struct nvmem_config config =3D { + .dev =3D &pdev->dev, + .name =3D dev_name(&pdev->dev), + .id =3D NVMEM_DEVID_NONE, + .type =3D NVMEM_TYPE_EEPROM, + .ignore_wp =3D true, + .size =3D MAX77759_NVMEM_SIZE, + .word_size =3D sizeof(u8), + .stride =3D sizeof(u8), + .reg_read =3D max77759_nvmem_reg_read, + .reg_write =3D max77759_nvmem_reg_write, + }; + struct max77759_nvmem *nvmem; + + nvmem =3D devm_kzalloc(&pdev->dev, sizeof(*nvmem), GFP_KERNEL); + if (!nvmem) + return -ENOMEM; + + nvmem->dev =3D &pdev->dev; + nvmem->max77759 =3D dev_get_drvdata(pdev->dev.parent); + + config.priv =3D nvmem; + + return PTR_ERR_OR_ZERO(devm_nvmem_register(config.dev, &config)); +} + +static const struct of_device_id max77759_nvmem_of_id[] =3D { + { .compatible =3D "maxim,max77759-nvmem", }, + { } +}; +MODULE_DEVICE_TABLE(of, max77759_nvmem_of_id); + +static struct platform_driver max77759_nvmem_driver =3D { + .driver =3D { + .name =3D "max77759-nvmem", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, + .of_match_table =3D max77759_nvmem_of_id, + }, + .probe =3D max77759_nvmem_probe, +}; + +module_platform_driver(max77759_nvmem_driver); + +MODULE_AUTHOR("Andr=C3=A9 Draszik "); +MODULE_DESCRIPTION("NVMEM driver for Maxim MAX77759"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:max77759-nvmem"); --=20 2.49.0.395.g12beb8f557-goog