From nobody Mon Feb 9 13:36:48 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011058.outbound.protection.outlook.com [52.101.70.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C42913A41F; Mon, 24 Mar 2025 02:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783289; cv=fail; b=d4dwqMzOKLmDXkSCLg+va1n+Qs9ISargpIf7U3LfPA3mOMvBjEWtoCSqq3XwaFrdkKurQ7JgQQ9Y2prCEt16238HKbDfmMZxj5pV8+/0tss2fqBEQD1StNGKRSpJsAa8VwfMUOCSJDAsR5L85GFhuDUrFlUqldg1ck6qTX1RhR8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783289; c=relaxed/simple; bh=4vNLP2c/6BCyUYt7t9hrt/lv306brQJy9Ej0gzwLyXA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=CIr6VCzt/2otvCg/nAtDUHZ2Z9teS1WSeIBfDbP03xf9rL1mdz1uOLGBqCQd2oRK6e1LeYj4FesgfbvnkXPHbOdMZXoMXIuyOLTMDdPDXYLire32dPM7kFcM0/ye/Z0UMmgWuAbgqmnFHlybRObr9wHkMffvfWMoq/sfnBJD0hM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ts8MrnCL; arc=fail smtp.client-ip=52.101.70.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ts8MrnCL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F8G03xcj23xeet0BvdEoJpVieUv4gC8z+mN81e25K4FP88RH5ZxyQKZeByajy1mq/nF+nNz7H7MTtBBpiYq41qyxp+rf/H2caXCkaioiIulayh3w7Yd3HXU8RzcGYpQSFyt+rEdeJxC2IREfD/Iqim16F02nEg/fNiFItYmC7Aiytki9CqM2pcAQ+EIVfz8UPlJ8dzQpeb9ltNMdx2W8+Ms4ZzmVQ2hcPiVmHcKykQOsBk8PMmA+jLu9r4nnoRSfmZfPLOvB1cUJNrrUxKTSfF515M93Uw+ZT8cZTN7N5lY9FLinp4rpNwFk+YpgjzDVmFKtcVb9C02j8SdLjFWSfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r5rPs26f71GhOEMbPESTDzq/rS9rRl+5n49VPh/g3II=; b=f7UtMoFcIdO9yx9+5BIYBJSW3E1qDfK1vogKZOMVRhDxlkUVYaskv9gnpkQoz+dqcdhf0zXwrFRU3TKvWbA7QHgrlMRb/ukmqqf7L9WCi9mo1fIJviJG0Kvyau3LjlrgLjpZ/+HWmeEx6GJZZfSPxbah15gN9UXhCEKbnpD3t3kKhdZRdwGFd2IHS7YmxYfmCdz9Q3/yVCLcLLEA0ExqsaayvBQBezPQTEboKawOOuhKfzdc2wxhDbT1mQPcWp05GVhUT3QCDmGAKuxdIA8XFaY5l0FKk0nCGbSQ21OqkYt/lCBHVX4tYtrMYRKBouK9bN9bAPuLTPJPxtrDYSbXRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r5rPs26f71GhOEMbPESTDzq/rS9rRl+5n49VPh/g3II=; b=ts8MrnCLwyrJFScXtblsK/AUnQnzj00ewl5dRjIYI1MgyAXBy+bAvMWqEpNsb9shpCuEx9vJMD6TQ1fdDvCQrMq0DGQIjdRHG5urUAkhqnjirzT5uC3aH3xb7rohmxnxMXGYtHGyA/isGe4PNHciLZB+YUy3v/wOctEA+xpmYx2wRcnUY2EE4cGO6d3hRDHGaXdpqDMFev5des8Qx9ypKCPwahsJsv6ltJJ3u2TBIwBbPQ4rdAJEehcd0R5NC4Zvg4CNZL10Cn33qZxpKIBO9aJY3Hno0uVoaiOozJC9uB9+RVcoXfxh3ImyOot4kkhgjFxQMgnHZ+mSh1BtcUqygA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7019.eurprd04.prod.outlook.com (2603:10a6:10:12b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:05 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:05 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:54 +0800 Subject: [PATCH 1/3] ASoC: codec: wcd939x: Convert to GPIO descriptors Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250324-wcd-gpiod-v1-1-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2462; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=SJchHRw4zZPQnugS+LAJqb6eMZ2l9bEbL+5vU36pmZA=; b=LzpZI5/I7MT5AcdPpMCfdi2XhaKUCRl4VIVwSOVAtllci7LletnO/DUG9E6G9SmPt3LILgjfN UDZ6imaNW8/DEjdoVKtwk4VRVn3TsrWIB4M7EeSPDZ9qIXXEFVfXXgg X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7019:EE_ X-MS-Office365-Filtering-Correlation-Id: fda346e4-6efa-40ed-8a31-08dd6a7b821a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZGc0aEQvSHc1bHVvb1lDSVpkRC9kQURSRU1HcDhxZFZUSmZMSUM3NW5mek1k?= =?utf-8?B?TWt1WVI4eUNYZWgxd0lGMHJEVUUwaXVwbmNEVDdpOVFha1VtRHNIOUFKWlZv?= =?utf-8?B?ajU5S2YwcFFGa1Z2aFdWN1lyanZ5bHlUeXFCV2FOQWJYcGUxRXZWL0hxOVFu?= =?utf-8?B?NE9HZE90aDZOaXBJc1pHbHFnMWxyd2JWVnFEdTd1d0t6T1czaGo3MW84Wm1l?= =?utf-8?B?ZE9mYVBBcE9uMmt2NG9CRUw0MGtrbWE4ZmIxTHhKUkNIRzU1OSt5YUFtMzlw?= =?utf-8?B?VDZUVmhtYmQ3bXU5dGpscm5HOFBzOUFpZ21OMXMra3NWZ282QW50bE90WEsx?= =?utf-8?B?WFNxOTdwWmRsdDd4TUgvL1FTdVZWS2JLS2hmYVQ3QlBlRWkway9LUWt0N25j?= =?utf-8?B?eEhlRWNCdmw3V1lvSHAzaFVpbWFmT1QrNElxdG95YndyRURCZDRkRkh0a2NO?= =?utf-8?B?eXlyNjBZVjdyaUg1RzF6V2VUR0ovdTE2b1NGc01GUktwMXJEMEZxQnBod0d1?= =?utf-8?B?RDRsODlFS2JuRTVRRlNIOGlEd09FRUE4OVFOY3Bza0tUZUdQbWhUbTRCUXRl?= =?utf-8?B?cFJhRFBQWVB2KzhTa1RmYUxRdDVscGZlWDE2UzNJcWYrVzFKS0kwNm84V0VC?= =?utf-8?B?aGVJNnZuSCtvZ1lSVDRENDlqN1N5NUpqalM0ZlgyUzJIQ3RESVZMb2JVMjhN?= =?utf-8?B?UmxYL1pQZkZWVENObHNUQ3Z0QTl0MFJzQ2dFT200S3lINVM4c3dDM0N1NzZH?= =?utf-8?B?TUxSOUJWUmJEalA1a3pwdkc5dUg4NjdLYWRvWE56eDdUMUhaWnNHajJxSkZx?= =?utf-8?B?RHdmOGcrVHdmcDlPT2U4dnFISmhMTzZMZ0RHUkh4RmdiV2xGLzErcE5XY3hX?= =?utf-8?B?M0I3VHRrcWlrZ1BBeHFpeWUvQUVjNDZBS2tYRSs4MzU5SEdZajY0U3ZBQys3?= =?utf-8?B?L2NpZmdiNzl1clJGV2YzWXZodDJSNll3MFpXWnVtRzRxZVlxQ21mKy9adm1N?= =?utf-8?B?TGNqcTRwUkF3OWhRcUpNNEdFRFp2eCtjdXVOTWtMdnVlV2VwWkU0MnlGaENw?= =?utf-8?B?bEpFZnlnQUx4NEUyeFhxZGk4bmlNNXJLTllTem55ZkV5ZXlhNElzbnp2RVN6?= =?utf-8?B?cTVmOXJEOUdVRFN6OXVlSVIwem1KakcvWHZ4dXNySGdpMnBNdXhjYmhYT2ZW?= =?utf-8?B?Q3hmSE54MngxaHBxME9nSVlQbFdaN3lHbDBVbWo2Y3JuWlJub1hCLzVKMS9a?= =?utf-8?B?Rkd4OVdka28xQzJILzFZYUUzazl6VUU2bGY2VU9nTEpzdXhwcm1kR2tJVmk3?= =?utf-8?B?YU0yYzM4MmVJMlpydlhBVUNOTUlOSmdJV3BmRWtXVUhHVVJOYVBkaFdiMkRF?= =?utf-8?B?NWZiekprVkgvc250MDI3NERnR2hsRzdZSjN1MmgxZXV2VmdoUFpjRStqUWFF?= =?utf-8?B?U3B2bG5PWk1CT0FXTHVZbVdwSjlmTE1kV2pOUjd5Znc5V2hFSzYyTEV3OUJ0?= =?utf-8?B?YUcvaDhXc0s0UUpCVnNmc01OdmRZd2N6Z3FzUGpkbkg3Q05vcG9ObGpTdFF4?= =?utf-8?B?MUc4MXd4bDVrc3U4MVBmM2lzUnI2a0txOElvcUZBNGE5QlVXa1RKcFY2YytL?= =?utf-8?B?V01OdlI3Q201WTlaUmd6Q0s4bkVGTm1SMlZGdWRoTTFSOUZMTnBwRnlFdG91?= =?utf-8?B?dEx2K1BBTkErRnBvWTJoTU5qcEFTdGdyT09lNUVDbndtc2NOSFZWeGlNWUR1?= =?utf-8?B?VVp4YytDOTZPY1FpVWhpeStiYlpZQytYcEhFL0x1TnBCUkgrdEtHcWNRWWpD?= =?utf-8?B?WDg2MUFZdEdiY2U1ZkxTeHJTMU8vck9XeG1aVi8wRVJaWUZpelRCTEUzQVli?= =?utf-8?B?d0g5eHFXODVGRUpFMFI2K2ttOTZIcHhkaGwwUlcrU2VoeTZBWTZIeGhxa0Ez?= =?utf-8?Q?GQhzIAbqUD/iWNVWvg2Ubfe7dwL+KokJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(7416014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0VxUXk0cW5TQUlJbFY3TEpVR1RDcCszUWM5Nk11VXdiUFlOM0x0S3B2dTJ1?= =?utf-8?B?eHdBdk9rckd2WGdCdGdyRVI3Q1FiL1cvaWowcWxWTG1uc2dJQk5BdzdFeFVy?= =?utf-8?B?ZlZuVHRMaHhWakFpN3hkckZNcHhSN0FHSFJ3cTJyVWoraFkrdkpZbTVUZ0Zu?= =?utf-8?B?UVF2d1RLZ2toTVpINTVzYzQ3bWttcjY0czZWa09xbEVQanE0TGErY2FEVjVB?= =?utf-8?B?TVhjMEc1amE4cTJXWEVESWR0enlyY2JzUTlyNHAvL2VDalBHMVprUDhsaGMz?= =?utf-8?B?R2lsYnRrcmZVQm1XbGs0S005VXdXNldYaUR5WmVCdDUxeXRidE8rT241ekVJ?= =?utf-8?B?WE1TZlppZ0ZuV2JnTUJxWU5LUlZwZGhsRm96RCt3OVZzY01XdFVHYktxK3Vk?= =?utf-8?B?ZVlSL0J5OGhVaWgvQ01TTGVXT1hWTGcwUktCdUxzVHVrenhtN2J1UWo5ZWVH?= =?utf-8?B?MkFFTWMyTmNxaU9rNDlPVStFOCtob2VaZjJyUGFveVdCNlh1VVFiVGhFN1Zt?= =?utf-8?B?cGtLVDlHb0o2cUlRc3FnakF4bWF0SnRHblZIbHYrTk9LOXhyQVhHbTUxL2o2?= =?utf-8?B?emJjRGIyeHBlWk9XOTJwQ1Y5ZndwYzJ0SEg4a1MrTVpqUzdaY1hqdUhFMThY?= =?utf-8?B?SmVkM2tiT0RDT3daUmp2TzdnKzJML1Ard1M0MmlaM28vUW5rc3c1bVIzUk4x?= =?utf-8?B?eWY5VCtCUGp3RGJHYmZCS2owTWZxOVdVbjdtL0FMVUlaUXlDVnBOWGJrcVk1?= =?utf-8?B?SUdPaUU1TXZ2eHlQdkZlaHlkbHJOREY0Mi85RVM0R25peVF3ME5CYlowaUtN?= =?utf-8?B?TTZPUnphUUN5clhtdVBZM2pmWjRtRlIrZ2I0LzRlNk1Nd3NtaTRFTDE5UW9p?= =?utf-8?B?eUF3K1drRWMwcXBpZGR4MlVvZTRmc0FCWXpEYmIyNHlsc3BxWnFIOFFpNGl0?= =?utf-8?B?a3l0MDBkNGNBNW8rNFY1MDJrbkxneTltbCtYLzFJblNucDJlZG05S1BSQ0JU?= =?utf-8?B?MW9SMml2MHg3WlNSU0dYeHZITHdFWHRyWUVDQjd6SWUxZDNSNlhaa21LQlcy?= =?utf-8?B?a0xaYzg2QitFSEg4ejFpWHMyTWZxRHo5T2tsd1Z4S3p0WWQ4M29ZVFU2NUV2?= =?utf-8?B?ZTNrQms0ZnRYTDlHWjMzVVdyaDJOSXlBaFB2V0JYZlRpUm5XVHZsQUdDUlpT?= =?utf-8?B?WC9DRkNsZFJRQXI4cWhsUjhObDZuUHFpTmcwVE94NUxqVVZRQUhaUGloMTFV?= =?utf-8?B?dURJTythSzBndy9YQi9TbUJHeDFZRmEvUlNFM3AwU2RDS3o0ckVLUHpEVUJI?= =?utf-8?B?QzZEdWY3cy9HeFpnajJ0RWlqWHVYU0xrQ25HUzVSVmJUWk9XYk1RR2ZsWHFs?= =?utf-8?B?cHBoOTBKbkNoNG5IVmdDdEkydmlRWnM0ZnlXZzdLNkVaL2d5cTREc2lIdi94?= =?utf-8?B?cVdjNS80VGlYb01sVzRJaEZiS1NiRGVXc1FiOEpkWVFZRmxZTTRVdWlMUmMy?= =?utf-8?B?OGJneTA3TEZBUEI2dzQvZElDZlpDb3ZHd3Z3ZXdOekRjQlpwY2laL3FheVRG?= =?utf-8?B?OGh3Y09LTWVIdmRZWkxvMzdBZ1dPeGhTUnAyYUpPQWpNOXhSK3JKd1M4bTgz?= =?utf-8?B?MVZlNGlPNFdQL2RuQTJ3RlRpZUlhVTQ0cDlGTHh5N2xtU2pCYmRRSzFQVE5O?= =?utf-8?B?UGZoYVdpMTU5NHBEVXFiYVBiYm5WbjdnSndxL1lzZFpCczdsRzFmdjBuc2pO?= =?utf-8?B?K0xQV1BGOXVHUk5OdGRHN0hpNUowMnlhZmpJVHJWdWl4NFZ1b2tXdVhsY3BF?= =?utf-8?B?Ly9rWlZyMWs4RzdYMkRIaTNTaHlqMkJWOGRJdGcyYXpYOVlyK1hDUUMzSnF4?= =?utf-8?B?ellwbm5wVUU5bkdsUmV3Q0RkYmdPbUM2dEZDcEp2SjNhci92NnFTQllKN09q?= =?utf-8?B?aEVuSHU0S3RBTG1Jenl1b1dnMzFPem01OFJadGZTOFJSVTlBQzhaWEFNWHp0?= =?utf-8?B?cktZbWpsM0hPc016dU9OdGkvdERCQmZWYldKODFYTGI4bmZzdlFMZm04SWZJ?= =?utf-8?B?aDBwRTBXUis2eWUvdnFlT05KSnF2YUw5bFp1ai90KzMwbWkwQU1xY3oyZ3FO?= =?utf-8?Q?AwFempxVLOb/mg0psFIESRQK6?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fda346e4-6efa-40ed-8a31-08dd6a7b821a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:05.4001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nRfZikDnDqaFid/eS3G6cCko0IObfhWKLEcTC+v21/zvDevUUqcvGHoB5GpH+c939pkM6mHe/G4gLLrfsrMVrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7019 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- sound/soc/codecs/wcd939x.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 0a87a79772da6c0ed3c7dd7d098e949b9cead2a4..f8d7d03f84fcbca57826dd43e92= 81aff5b225525 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -201,7 +200,7 @@ struct wcd939x_priv { u32 hph_mode; u32 tx_mode[TX_ADC_MAX]; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; u32 micb1_mv; u32 micb2_mv; u32 micb3_mv; @@ -3239,10 +3238,11 @@ static int wcd939x_populate_dt_data(struct wcd939x_= priv *wcd939x, struct device #endif /* CONFIG_TYPEC */ int ret; =20 - wcd939x->reset_gpio =3D of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd939x->reset_gpio < 0) - return dev_err_probe(dev, wcd939x->reset_gpio, - "Failed to get reset gpio\n"); + wcd939x->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd939x->reset_gpio)) { + ret =3D PTR_ERR(wcd939x->reset_gpio); + return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); + } =20 wcd939x->supplies[0].supply =3D "vdd-rxtx"; wcd939x->supplies[1].supply =3D "vdd-io"; @@ -3290,10 +3290,10 @@ static int wcd939x_populate_dt_data(struct wcd939x_= priv *wcd939x, struct device =20 static int wcd939x_reset(struct wcd939x_priv *wcd939x) { - gpio_direction_output(wcd939x->reset_gpio, 0); + gpiod_set_value(wcd939x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd939x->reset_gpio, 1); + gpiod_set_value(wcd939x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30); =20 --=20 2.37.1 From nobody Mon Feb 9 13:36:48 2026 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D2D176AA1; Mon, 24 Mar 2025 02:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783295; cv=fail; b=TWvFwnQDQEVGsJ3Cc+EzcweOlGnCbhhAeRBM3HqxSCu+affCbvFEVbs32MsQAdJRj2ZmwaMxMkAYQdPDRt/kzpixOq1Z76ZvZehpn0Ql3DirVnM9Cps+5CA0dcWIhnvLSQiawxWEOwhNgIn49CZ/8OvdaFsDAHh9q7Fs1juVQqk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783295; c=relaxed/simple; bh=KBxeSXnXKIjfokub+bLhLidG9dyvfKY3BY7BhN7WgKw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qNjms2FOW4TaZVE6vT/G6vQZdC/n3KsO3XzbXwtviHrDAv/p8wbnM5DU0AILqmje6lPjQX9HFaCXdsC5/uGtMwrjORwzJvyjGtudjyMxkZGz2wErjpsOIeyIQ7nAmYThWeHQKr7PgYFTl7jlyffUcUaZXkPyqTEuZ2pDl4Y5VxU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Y1jZiPAi; arc=fail smtp.client-ip=40.107.21.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Y1jZiPAi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hv3CcZJCiqnCWFeGmQRGXOaMOrn/QaXDj/rteDAAYtAd5+knpJVUTG80EiQxTBuyibH0877nkIlz0L68FfdA0zJ9G2XxwlQaTZxYLRxA9refANoJUawcy+DIyoTbh8iPAarTyVlMbKpZzNYNVc7prVyGktGi5KnMp56vTlD8dL/LlBfUak6xcgZ9L7BJ6N/pdMXfEn9oV7bAGjET5ywQ7L3OvRQmQMiEZZ4YqNJDKfmV6n7jrVrvQCbedt369Cn2aNKO2I3Vht2nE7rJvdyK+/GZ9dKs0r27HKxa2RU0+LzGQZb0kefuqv5HdJTygr4rp2bBbHB4i1w/PN1OYtaArg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J1aHxFRghZpOloeIDuKT6dsTXgOvoW/mciMTe63j39Y=; b=vdx65RNE3D+nXVn2y0FTHMZF0pU5pb0QQKG3L44zU0apf7PcmPzSSY8YC28BHvXhiIFcLL4nCIZ6opfGILae36/rlwFfF1DnbhpPOlvxMfK5c0HesWQWxBxxvOVaEJZbZvipz3kig072ZkYJwHV5SHQxiuIvWjlh4vxxxjMgQWHu45r1Omr3LAZ79Szed27rZhtgpMEqzGJ3e/UQ344ptFeC/4qFrXh2OSDtvR8gBhboxXLVishhwt4DCrEBAqTb9DZemX5wqE9DJLa0uPsS0LGpGkq2+Egxb3Op8G2u9aAAhqg7O7v9hjFu3uclEkErq2yFmKI8K8yppnn020H3AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1aHxFRghZpOloeIDuKT6dsTXgOvoW/mciMTe63j39Y=; b=Y1jZiPAiulZEq+6J5VrxhlMZ+9tKkJpAZDtTPFivKcuKxJn3rOKXgpOe5C5odjSp+2tLa3x2PxBVmQLC/Qzy+jCpupBxwib2K70WtSpoVyKKwMIquCZzQLJK/679wDDNeLKKJIWAIv1tRbOlVO3nl+FgJom+E8QUG1GuclJHu2rAnq4C71sRBbd73morBzSVui7kqA/UiHJWFKVk3J55GjkG4kPOHDuqEuL4dXs+K/iYZ5dvQxo4GncGj+1gB0W3omWFIJh7Q85jAdLS1wEFDyht4XKmTX28E29W6OYcfVFtVUxOudKL8cmsjgUL3TxGiww5QJ10ha8k8bTxW2FrkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:09 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:09 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:55 +0800 Subject: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250324-wcd-gpiod-v1-2-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2428; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=vXU5oXYDT7pq3hwycqWjcyFZmAO8bXnWtI77J5aaCG8=; b=Fm36vZcx4B+KH/INgDc/rnJ6v+ZEwNV1LwL/9wre18nc6M5z1AONBCk/rurqhQJ214wwBGfvZ N/Dy2rcijNYC8G3Y3Uxc745Lzi17uhHqntYxJyYKfDHVUl3k8B65VBn X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7036:EE_ X-MS-Office365-Filtering-Correlation-Id: affe3574-8ef1-4e6d-080a-08dd6a7b844e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bTkzT3NJOVpGd0YxOVFiaGtPWW1vckZtbUtSOFFzRnBLem9WMSthWTJnVFAz?= =?utf-8?B?aUpFTkhnejdXRjlONnU4YmZjZmxjRm9vc05OWkttN1dNVUEwckN0MHZtSGlq?= =?utf-8?B?dklia0lNVXdXOGNXYkxROUdTcVVOMHNORENqSS9RZlRpb2xYbXNuVE9pRFBm?= =?utf-8?B?K2lwdzBtUEZSVG4zN1RWMVM3NlUwY3M1Y0xreGh6VHhab3U3U0JIZWxnR1ho?= =?utf-8?B?NFlZajN0Z3lPYkF1ay9pMU42ZXRlV0czdmtDTEtsOXp3TGpUWkJrN1Z2Rm81?= =?utf-8?B?WFgyZWlWdzBxbEdySmt3UzhXaitqaGQwVkxEZEJDNk0rUCs3a1hISlhWTjlO?= =?utf-8?B?VUtIMllxaHdIcUFmcGtGL213TVhOMzBsNTVlUzUyS3IrQ3I3UEZHMWpwc01r?= =?utf-8?B?ZnlyQ0dDZXd1dFNkWFFFdEhmYzlNR1NmNTlTVnZnYitQcHk4UG5LUVZuZlUx?= =?utf-8?B?cHduVWxlYmVJdUw2di9VRlJMNDhLR0JSK2RSVHduN2tESlFoQzFwQjNDK3Rj?= =?utf-8?B?blp4cDRWRzF4R0tTVExTTy9NZEpnbFcxY0VhU0liblY5LzFrMmpmdHY1ZWdF?= =?utf-8?B?WTNMUlZ1VmZLZUYyRittWG9NUnJ4REIxWlUvT0dKdGxFZzNSRzU1SUJiNWEr?= =?utf-8?B?eFFSem4xRTFROE1vTEY0MFh6ZEVwdG5iQTJodTYyZ2ZiQnl6bldWM25wKzdG?= =?utf-8?B?SHlubTZsVEVicjRKcVJ5d0Q4Y01wWEZpeUpNQzdLV0NTT3hlTHNadWFrQ1Bz?= =?utf-8?B?Q0FIa25GWDZMSmtEcnYvRWJ5aGNaUndQM1VBRFhOc2hzMVpZR21Nd2M5enFl?= =?utf-8?B?RE0xRTlRSURTdVdDcFhqdUJxYXdETFhwaiszUjFWRGRyeHQzc3lua245bE9F?= =?utf-8?B?R2F1ajB0VHhicXVDVklnL3g0bHp6N09OYlpXRit1ZW1xTTYvY2kxUFVOd3I1?= =?utf-8?B?dUExaGRpK0N1S2Q3NFo0WTVaVVRtM2ZsUWtCbGEweVMvTDRFbDErM1VUOXZV?= =?utf-8?B?S2lhYTZ6UG1LeExuREJ4QkJjZ3BCSFlkM0JKdXJuOEkzbFI3ODZkVXMrODJL?= =?utf-8?B?NEIrTUxvM3NGZ0k0RzVkd0dvT1BNRUFUNWlRYldhK3VQc2R3ckw0RkF4bjc0?= =?utf-8?B?ZWFqclU5d0l0WFV4aDY4c1BXWXk2SVVKTE5aY2VIWURaRWVRdnExVHBEOTJU?= =?utf-8?B?QUdnSFhHTjJ5THFHL1Rwa1M4bjNJbllXODVBTzUwdFprNG9zSzhNUmVYdXV6?= =?utf-8?B?U1B5eXNKTVJNWjJBTTVoT1YyVE1haWJzVWpPQTBORWFNK00ydkJ1SkVtODY0?= =?utf-8?B?M0xvUTJoMmQrQ1BwWHZjVmFicVlEUHE4SkxPOHJXb1EzZEJ6WURrMHMrREFv?= =?utf-8?B?TVNhYXNnYk5sNEVQOS9tdm1KQ0NNYVhVcm1ndUsvYW5SNHkrbjR1WmNNUnhI?= =?utf-8?B?Z3JmQkgzT1YxN1pBUGUzbkRVeDgyTTFPUkw1RkRmL1RIK2RCOFFrL0hHV3dm?= =?utf-8?B?RGQ1bkU3eGFzWG1oUGFRMUJzV2lhNkUrdXkwZUlQTXdKa1dqUkdXejlscFFv?= =?utf-8?B?bDZZL3hWNm5pQjRHaGVCaFFjaHlrSGRvTlBvZ1kvZ0RtU245K0J4aGxjeXgr?= =?utf-8?B?ZFUwNzZ4NHNUU3oycE5FK0JSMms0WXR3Vzg1R1dGYTBHdWpPdDJxbXR3UUJ5?= =?utf-8?B?Q0w2Y3RKUEJ0NzU0Tjc1WUhNanJnL2tTUnBzK3JtLzJOMWpvai94RVFReHUr?= =?utf-8?B?cnJRUW56MFFBaWhlT3dROXZPRjVoZGdha0pVWEw1Z0JMVmtkaXRsS0p4bVNm?= =?utf-8?B?THdxNDMzWFBzUnY5cUNKYWpTYXcwcDNQc2tBS2VXSnlHbm9YOUxCbzYvR3Zn?= =?utf-8?B?bUM0My9FYmF2bVVyaE5DZGZyRmlGcXJ1M0RyS0NRWEN4a3FxSnhRZUlvek9n?= =?utf-8?Q?/5rt18eTMLTYmwqwZHvmHb3+6KlkNSvs?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0RFMDRheDIxZ050NVJFK1EwMTJYU2ttK0dVMUYxMnZRTVE0UisrRzdRL3I2?= =?utf-8?B?Z2VYMUNjOTBkd3pXa0R2ZWpSUDMzcS9sQ0VsbFRIcXptWUN3ODJVMk0wejZX?= =?utf-8?B?Yjk2eUNTK3RoeUJSdzVLeDg0WU5tTHM5Mmw1SnV4Tld0NFJoLzc5aUJGNVY0?= =?utf-8?B?WlE4VThzcERDbWtsTFhhQWlZR0Y4WXVYdkEyZEVNaDltd3JWU1VNQ1RyYXdC?= =?utf-8?B?M25BM2NBTVk2azBJcjhvL096RnI0enpEcFVMdGsrbTluSU0rdE1vRWkwc1Rx?= =?utf-8?B?Y2gwdVJ6RU9MMThTZHVNVXMvTnVaMllObHdDMVpSK0FoNDBFOTgzQ0dqU1k5?= =?utf-8?B?ZlpndHJaeSticVYzbzFwZzFTMko2VHR6SGMrMFJWR2Rlei9SYTA2M0lSYnRq?= =?utf-8?B?ZmE4QTl1VUMvNm91d0s3aFQweFdQdVV3YXZsOGJLTjd6V05DNFlEQVh0bmIz?= =?utf-8?B?WTZuaUorSi9SZVJlSVFIUkx5UmpNUVBYeVJJemQzQUVKWnVNdGgwby9JcWZE?= =?utf-8?B?NmVWYjJxSVl3cDRNT1JHR1paTTIrRWg1eExOaXdxMHFiYTBESzBPQ3NrT1BZ?= =?utf-8?B?Q1lJL3dDUXFQMFhGOTIwODBKYkVCQllzYVBHRlZuQmtRV3RmbjJoOUhsOFc0?= =?utf-8?B?amdORTJ1N0phRXZoVDZSWlFSVzdtQTVxVXNnRXk2VVlzUmRRK2wrSFNSM2Jo?= =?utf-8?B?bm01dmx0cFB5YzFoWkQzMEFJNUlJNzgyTWhBOGxybTdsV2dUazU1aXB3ZitF?= =?utf-8?B?aWFHclU5UVZ0UnhoekFySHNWTm4zR01XQ1VmQkNybUdLQlk0SmhRNEhEa09L?= =?utf-8?B?MDJIbEZBUmxqUTBsRThFVkpVR0QvMzMyZVhjVU02US9TOStmcFhaUWswK1I0?= =?utf-8?B?c3VON2c4cnpFMjJoVEhlTEdhMW01Y1hpTDN2eEJ6L0R2NHRLb2VJTTkwc0tu?= =?utf-8?B?R3JjZkJscC95cEpHY1ZoSTNLdGMvMzlxNzFoZ3orVzlMY2VDYm5pNXdSbTNR?= =?utf-8?B?b3JnVWhMQXZvNmFHQkYycjNxUU1LUWFNS2FvUDh0L25UYmFTN1EzQVVTUmt3?= =?utf-8?B?L2ZsY2xodTdTT3hJaFFSbUpyb0NtNkdneEtRQjcrUUVSOW5BRllvN1M4WnNL?= =?utf-8?B?RDVSejhwa2J5QlcxZXkvUjhtcXFNYytGc0ZpK3lUUXFyRkVteXRhdUNGMXlE?= =?utf-8?B?WTlaUSthR1pmODkrN3VBMGRrSitQb2VoaTV4enJPUHpqbkYxOTR3dzZ2QkRn?= =?utf-8?B?eStMcWx1dEVzWG1qQy91QlJhYnRuN2hzUmRRb0h5NklCd0ZUTy9mTDhUSzhw?= =?utf-8?B?bjNHSTlQaHBvaXRMQ015Q0RKUDBjNnNKQnYyaXZhNmxac2dyUlNEbHJCN2VF?= =?utf-8?B?aFoyYk0xTHhqZG9MdFVjUWRLTGpSRllSWHd3WmVVRzdqakR2U0o0N2h3S3Jw?= =?utf-8?B?Z2dTZ1JPUFgvdzJ2MjZDaUZQWkVqRkRtMWV3OXdYcExoQ0VSdWw4MHZpYjdC?= =?utf-8?B?MjI4Uy83blZMdHdtWlZ4YVl5YktCRVFvN2FXOVladWJhTW5YNkNhSkROaTVm?= =?utf-8?B?T2Q3d3pmZlQxNWh6WXRBOGtRZzhSVHF1SFU1RTk5KzltS3dpTExBTDB5OXVo?= =?utf-8?B?QWZIdXhLbkdmdW9jOXpzUExIc3FhU3FsNHRXdHZZL1JuN09OcVVqVi9YR0J4?= =?utf-8?B?NFU2UjBydlIzMXRvZkgvUlRaUU1IMHc0YzBmczBtRDh2dHpoUUdzL3M1YkZD?= =?utf-8?B?VXN1ekxiWUpwRERBcFVpTzBPTlZUVmExRU13VXhKcG9CcEFHUWdvOSt0T01Q?= =?utf-8?B?Z2o5ZHdUODFvRTZGOTVxMDIxUHVKNkwxaFdQN25xQzJGRmFEZHZGaUZsTnVD?= =?utf-8?B?Y2pHU256NGUwNUNha3U3ZEhYZk1WZGtGVGVQNWhsWm5QNFkzNjR1N1hyNVNP?= =?utf-8?B?Q3p5OEMxZHg1VHZreFBIdjl2cXZoOE5YZSsyVzBjREZ1MElaeDFrOWNlUmxY?= =?utf-8?B?cTJRaHZxSWlKcEdUaVN4aGpqKzRiSkg1VWU4anpjK3kwMFFhNlpZTkVJVjBp?= =?utf-8?B?anVvUld5OFJwU01VV2V0Z3RnUWg0c2psUWN2ak5JSlZrRTZ3Q2JtbFJuTkMz?= =?utf-8?Q?7OY2MBGYxVTjOHxfOLUeLGIsa?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: affe3574-8ef1-4e6d-080a-08dd6a7b844e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:09.0778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ris/F3gmZ4u7INJ0utGpETmaefcL1brK8NOdsIC/7b1rRKJhToeBO+qzKsndpWY0bN9KVuEYtC1jOf/y0bts/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- sound/soc/codecs/wcd938x.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 1ae498c323912ed799dcc033e7777936d90c9284..c70da29406f36883e4926eca40a= b5ba5df02c383 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -171,7 +170,7 @@ struct wcd938x_priv { int flyback_cur_det_disable; int ear_rx_path; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; struct gpio_desc *us_euro_gpio; u32 micb1_mv; u32 micb2_mv; @@ -3251,9 +3250,9 @@ static int wcd938x_populate_dt_data(struct wcd938x_pr= iv *wcd938x, struct device struct wcd_mbhc_config *cfg =3D &wcd938x->mbhc_cfg; int ret; =20 - wcd938x->reset_gpio =3D of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd938x->reset_gpio < 0) - return dev_err_probe(dev, wcd938x->reset_gpio, + wcd938x->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd938x->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd938x->reset_gpio), "Failed to get reset gpio\n"); =20 wcd938x->us_euro_gpio =3D devm_gpiod_get_optional(dev, "us-euro", @@ -3297,10 +3296,10 @@ static int wcd938x_populate_dt_data(struct wcd938x_= priv *wcd938x, struct device =20 static int wcd938x_reset(struct wcd938x_priv *wcd938x) { - gpio_direction_output(wcd938x->reset_gpio, 0); + gpiod_set_value(wcd938x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd938x->reset_gpio, 1); + gpiod_set_value(wcd938x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30); =20 --=20 2.37.1 From nobody Mon Feb 9 13:36:48 2026 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26C717E473; Mon, 24 Mar 2025 02:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783298; cv=fail; b=IgjpdFxl+7q1b5l/mYRmZaUS9eGs1QsdqpdSWsLPqTXTJ7SEc8cHssJPFlpUZ9i0eT42jMGR0Pf6baQ0JFIXfWZSAJibVCzwa82qj0AN+HKgSOGdGaUmMuhMV5u4AxqMBYNjKc1w69x4+Ry6KjvKoE6Dibihqck2evk4GIb3gbQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783298; c=relaxed/simple; bh=pCZv3a4HKoCo6tTULZ/T7f7WdQ66pPWFRweWebAtzs4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iSHSwTsPvvRARiDs6+BN4aJ83vivs6IbabLQTkw14W0A4Bky8xOxCEdMW5wP+K/6h1oiYzdQ5Td+M2pt++hhV09UtkuDhJ/pEFoQm+8v0fOsbFua+IO6lQhSgoEvChxxiuDyTfEpuxOdaFYmrfFtSSB2gLjeesRqVpBjjAnUfkI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=WLyvwy/S; arc=fail smtp.client-ip=40.107.21.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="WLyvwy/S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AUUVZgP4OQxAswXYC189NgbCIi5Y39RDPEVl4A8ugCAhQc1bXradaiwr9/dzGX2wY9Kr+1npfNEja3Z127vdv3mhTF7YgzgK90TEHXf6grH3HdHoN4PQmfxU+fQnSDgpzRMN1CGWcNjsGTj+V8RMrmTR77aSbxHZoFSRQdsMEZUGuzNnGaj2hHGXoeqUIISzIs3YLia2lGo7risFfcZpGfP0ehiiEenS/gEsWmLKxgJxp32Ne510TM7z3URxLwYeDNE9qHnHcDMBLNxPm4+Z3YIjD11WcR31xq9cuO2fAOugOLHjp6QP5MCtw8HVFoaNW7SDWe0z8ZL6CcDeIaCvIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FEUv2j/WYz/0UQb2CW3Xs6/R7GSMOigLx14jpL/CkgM=; b=Y4Qpvfee18JIlw6LeyAwunNR6+YYv8g56i1X26QNy0YX/IuCALU5KxCfuiZpgAxnuM/DBrZjJbyiSXHxJU6GqPyY7sBFvG14/LUNOqKASx7QN10uxgrOZTSS4k76JdcQjwkMXrRfH6FhWU8mvAiXpP64ejFZZXgGe2L8SBhlz/xo36EAqHvbQx64AdFuW+/PHDownbsqu/CTkDQYco82eEzfTO5L54DLCwbKpmuORyMAK9KAX1knAc7LVHjCodet1JsXJWk9dbxWJMCQ8Csv4uXdgDEoAgMl3ktZ/uYilJ8L0dK8yO6u6UjoXzQGf9pzi6080GGUr9FOzswPylsqVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FEUv2j/WYz/0UQb2CW3Xs6/R7GSMOigLx14jpL/CkgM=; b=WLyvwy/SvAHUsf7DOPTp2FXnOCOzIHy2hGcjx0YqDYCxnUtGSQPK+oltOOThi8LysbnxHd+7VcWbtMHqdOPwxu61sFjiwKqyIi7weQ1uEtfCZGctuLqrGDLKTrAzozDOoZ9DK7gqjk8gWEZs3OPLhlitwwwtMX3fchDqrIwuu/5QRX8WD9Nan9ns3z0ntXs5v2ISBtud+QQL4dNdEI0WkX3HECsoBM0oiFl0G/kvwOuhOWEvRfmS4OuTtXal8c20S5lzI04PsDoa3uG+hFgtEDui5XHF/XCUpm6nQMlxJf5l/ymWnsa52NvPYyarh3kuJcB4A115Ux8hOJp4mvOjgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:12 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:12 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:56 +0800 Subject: [PATCH 3/3] ASoC: codec: wcd9335: Convert to GPIO descriptors Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250324-wcd-gpiod-v1-3-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2351; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=w2kpHxzjhH5lUjvoGiVgliajpRhAKVQmnpgnfgKcfec=; b=cAGNjIfPTUMhCpIm+mGG29Y5M1UIfDYSN+SrEJSSkVz6KCJoFPCz/it6mQv89YFQUdWfJJgxo fPWTcDbkUwqDJzovc3BBRbZYE5i7iz9NHTOBedXOYeHnbmgkooSTeeg X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7036:EE_ X-MS-Office365-Filtering-Correlation-Id: 463e1f84-9e43-45b7-6f5b-08dd6a7b8676 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WFdiaDdiYSswa2lSMndaYmxsNzRuNjhrN21WN3dsTVc1TDRaeFl6UlQ0K3pK?= =?utf-8?B?a3phU053anlKU3AzRkJlSmc1YS82STNHRWNMdG5wVXRKMGRHRmZpU2pTb3Jz?= =?utf-8?B?MlAvMDVGS0tLQ0hvT0hraWFLZHRlaVBtSGNGeDNOZG1WQTRjU2t3dGtzNmlB?= =?utf-8?B?YVBvWVJ3WUNlc1dkVHlCWm5qY2VkdWhwck1jZHZYWG1MVnoybzI0NWQ3MG43?= =?utf-8?B?NTJTMzJrSGtGZ2hhQU5TZGVabHJiWWh1cFhJeTZoL1BwQk5EWk1vN3EzWkt0?= =?utf-8?B?cXJxWTJzZjlkcGNxemFJMUZHK01idzFyQmpIL041T2N5ZjJRbVVoeUxueDFO?= =?utf-8?B?aFVqU2o5c1h1L1d1a09POVg0VVExMDNjdGZkRFpUUWo2Y0JkT3pGclVqNExw?= =?utf-8?B?Vkp5Ylpsdlg1ajZublFFZCtGNnZlVDZUdXJwVlJjWTliU1h2UVdFQ0VOc1Zv?= =?utf-8?B?c3pWK3V4bkpYSmRUQWY2b1RtZWtkR0dkVkJ4RWxNckpPdUVsQVFHc3hpYlJN?= =?utf-8?B?S3VLeEcxSWNtRFBUaHZWQmNqaWsxdE1iY2hMa0VQUWFtY3kycGNJdjJUUzlw?= =?utf-8?B?ODBteVBaamVHczhIam1FWmtGcU9SK2k1bm5CQWVrUmx0VWpwdWdBVmI2TDB1?= =?utf-8?B?cUlKRlhCdmhmQ0JSU256cE5RMDJ5R21teEFwL1VuQ0JGL21YSWg2b2luQjlz?= =?utf-8?B?REl5cWxMQ0NnbEhyanBOZktmZU5uSnl1MXdBTWQ2R3d2S0Q4Mm1lRW1aVXpl?= =?utf-8?B?Y29aRkZPNlRseW5leGd1R1UwYWUxUUFCZDZDZWFTU2tqak1YYWoxU0hscnlQ?= =?utf-8?B?UStGdXlCSW1DN2YvNU04K3N5Unk3RjJQTmN2alZ2M3VvdUJoUnVLeGo3WWhQ?= =?utf-8?B?VkF5dDdNWnh2YU04LzkwYmsvTjNTZVFMTFpsd2hWYTNJMU8vaEpCZTJtR2hz?= =?utf-8?B?VEpQVUVqalNlN2xNdkMvTUloSkdHRENjTnNTWmRuN3htNFdRSkZnZVhoWHcy?= =?utf-8?B?VXYvSFpxY2xSWG5OWDFqY29GOWtYYWFKSHVTd1R4ZjJmNWFWc0dibnV3bWJG?= =?utf-8?B?Rlp1dlQ1aUlxK3JIazQ0b2pUYmE2NVdGdERCSTFQRk1Hdk05ZGZTbVZOcy9r?= =?utf-8?B?R1ZZYUVKYW5hNkNsYnJ2eFdKYnRDTTNQM2o1VFJrZ3RoZWU4RU5BckZEME00?= =?utf-8?B?STdSa2l1MlV4Rzl0a1cyVFkvTFByTVN0S2Q5aUZXYmV3R2w2RU9zZlJBZXdB?= =?utf-8?B?OTJxYXpxQ3dvQXQ0S2pwQjJtMi9BNnF6eUhPTGl4cFpLVzhlaHREU3RBSDBX?= =?utf-8?B?T1R5QlJjVzZxWEFlYktqcFhrRTdFUXZGMWltN3VxekhBUnovQVY2K0wyWEtX?= =?utf-8?B?TWxGWFZIdGRIdS8wUlZnMXMrUUhHN1loeExPZzdaVDBmNjErUnVnT1F1aVVp?= =?utf-8?B?Y1JvM2c5R3ZLSkd0U1FiSHhIR1F4WEduL1Z5TG1MUkJMTlhjWVFWYzl4YnpF?= =?utf-8?B?Y2FJUkQvSkg5UWN3MGxEMmhkcUVHSHNTdWsvbXVWa1VBanJiWU5rWmFtYlhH?= =?utf-8?B?bTZleHFRV2QzTUE1ZHdWWjJsSEpqZ01rZ01mSm1JODJkc3ozTTkyZk0wVnJT?= =?utf-8?B?WHdScHFtc1hvRlRVdkVrcWYvS3o5c01MOFlxenRmRUVXMWprcDEwT2RjL05R?= =?utf-8?B?RWhmUEFJR2Qxa3hIR3lpY3dsbWkvT0lERU5NbzVueDhiSDlueXZqOTlFR0da?= =?utf-8?B?TTFUVU1VckVHbnZXZENlREZOYTZqM3JObEN2WlhkTG9NZ3I4c3hDMmZZek5Q?= =?utf-8?B?eU1tL1RZajRIZUwvMkI1Rlp5Nno3S2hPYm1CbFdxZi9UR0x2ODlINEdmQVgv?= =?utf-8?B?eFQzU2VRYTRWLzZIc3NaV3F1amZzS2doRlJ0em90SkU0QStGd0VUTXFmY1hH?= =?utf-8?Q?4rKgJJTr/AKEcYWgfdWcUrMIpqpMPp8m?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1VWZERNdUo5YURMaFZUdm1YZjFEeW5UdnJpODk2MGJ0NmFXL1NIRmoyUk03?= =?utf-8?B?RkUxVys5ekVRMFZmekVGZU9hTWdOZVdlL3J3SktrVUowLzhncStBK1F5OWQ4?= =?utf-8?B?elhPSlJTblA5c25TK2tUNXdIOEVoMDFCdDN1UHUrRGpUOThuTTZnMnNqMzdr?= =?utf-8?B?TFlMOGhqTU15MHBobUR4cjNBbXVRYTZxYTRFVHdkUXJ0blZ2QUxyR1JHbkh3?= =?utf-8?B?WmR5REwySUhubnhRZlM2Zkt0WXBkZ0tyQ2RFRGd1WEdvNWpRVGlpN3h2MEw3?= =?utf-8?B?bGJ1ekRXaUxNaVppVCt6dWRvZGl3SjNHT2xmd1M2ZVBqbWN2Vk05bWFOSEFQ?= =?utf-8?B?T3dRQkVjbFlxVzlNRnh0WEZGUHloVUtSTU1YSUVUSzl1TFFtZFpiWDl0VFpW?= =?utf-8?B?R1JFS1h5MTlMcXBNaWFJUWJGK3VXbVQ3UTFOS3hJUlF1M3pnVUJwQzgrbGth?= =?utf-8?B?N21zNVhBQmlBcVVybVpLdVhuOVV1K2s0dDN4WVpSWnA1bGw0ZXVHMmVtRWtK?= =?utf-8?B?ais3VWdyVXBtemJjbTViT2FzRzZaalAyWHVlZGI1d213ZEthVHhrL1VVYTVV?= =?utf-8?B?TDBRaVpqcjhVK2JMUWprNWZOSjAvL0tNc2kwSzI1VXAzeFRqZENWQTJLb1RO?= =?utf-8?B?Z05oVDQ3OWpnbW5oTDZJVU9GRHFuOEc1L05HVmN6Zm5nU1dmYUdSUUNpdTMr?= =?utf-8?B?TFcyaDlHYVRQTm1PRkJaaytGbUxXRjR4TkdBOUxwOWlkQzRneHkvVHNWUVZ4?= =?utf-8?B?RnBXVXA0TzNvVDJhSEZlS2o4V1Rxei9yeXhIaHVGSlhteVYyY012ZnFjSHNx?= =?utf-8?B?bzBYWUtpV1RsYWFTaUNjQVJJWFBKNWY0N1hHWGNlaFI0RjkrS0NmSUNvank2?= =?utf-8?B?eTFNd1F0bThpVkZJRlA3ck9xTG40RFNTRFd2eVMyWnVGbWhOWjk3dnhTODVr?= =?utf-8?B?NHgvbHRSMXhMNmRJcnE4ZDgzVTNiNFFXVmdSYUZvL0p0dzFhaHJqY2ZRei9V?= =?utf-8?B?c3VWQzFmSWtoYWFGZzFZbUNBRmEvMXVYV0s3YU5MbGJPNmo3SHcyVzhJcFdC?= =?utf-8?B?QUl4TTdzVDBML3VlQVRWNVpDbE83NFdSVjQ1OFFWTXNZU2lvdnh5bkhjS2x2?= =?utf-8?B?SGQ4dmZldFZJcURjNzJTeE9UQTRUUkV0R0NyWmp5ZE5MdkFNelVwTmdRdklk?= =?utf-8?B?VDdGcDRPS0dOZ0RzbHZ3a0FldDFHUnpXWHJ5WC9ZZkJRRzVTVlhwdDBiNHQx?= =?utf-8?B?NS92SVRFaVFPUWFyV3NQY09keFpHMzdQSW1hN1ZCSVJQV3ROOHoxOWZrc05a?= =?utf-8?B?bElOZm5Ib0tPSzVMMnNpL3BkbXk1VnFYRjFNK2RvMTJ2KysvUDA2dUhVU0Iv?= =?utf-8?B?NXRoVXJLak1zZStSdC80alI1bE16Z2RXKzlvdHNWSkQyUDY2Z1VTd3Y2TnE0?= =?utf-8?B?V3l3Ti9UN2hWNzArN1BBOGd0Y0tMWjhqSFN0cDVBNHZyWlJiUGVXcUhKS1dP?= =?utf-8?B?Q1JtSWFEeEo2MjU2SjY2UEE3SjQ2SWpnMHRhRUtMbVYzZWpNZnMzMk1ZUURV?= =?utf-8?B?OEk3VWFweDU4d0krMWt4N3BXalIxeDh1a0kzVk9HRi9SZlZFQXM0bVczVXhF?= =?utf-8?B?c0JMeE9Ud21aY3pHYytyQkE5d29ZdTYzcnpSaFRuc0h5YTg0dVN2VWgxdTFZ?= =?utf-8?B?ZjNMWm9hcFFSb0hiWmVNOHBzZ0xOUGdzUCtHbHBXc0YySmxVSjYySmt1MFV3?= =?utf-8?B?bkNtVHJRVVdhVUZ2bko0MFJEQ2VBU2k5cS9HV3VmQzdLSDVkSFkwdUx2UUVB?= =?utf-8?B?dVh4WC9VaHJmK2pKZHVmaC96WkFtTG9SakVrbndqODlrUGdCcUwyNGZ4VEhH?= =?utf-8?B?NzZjNVVqUEtJbGVTS1JpYzk3dHpRNmtIUnN4eENyUExndTBzdHYzYVh2cDNP?= =?utf-8?B?dkRQMkdRT2pzWmhpWGhGckxIR2VmM0R5QkxLRWFaK3VaZi92SmRWd3dRSXk5?= =?utf-8?B?UDFpRllOQlU1T2VPUXhKY2RneHFVVWZEOXNVMnRDYm1oeGtiTTY3UnpiKzBx?= =?utf-8?B?azNvQjFibks4NEVTVHJEQ0d6Tk9hZmhqSHJEdEwxS0JpelhsS0VoWU0vQ2Nw?= =?utf-8?Q?Ysxb2dQLjuRMfDHrz1Q8ML4if?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 463e1f84-9e43-45b7-6f5b-08dd6a7b8676 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:12.7704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iI80whXRIhgrKnK3pEedIMobPZdhw3Sw+ROkGO8bhZHmgU52gR5OJ7kxGGjFCFOJM0JpFYPuOOrYp0E7R5BD+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- sound/soc/codecs/wcd9335.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 7cef43bb2a8800971604b0e1ac55aac26c5919bd..90cf4f79cbde5f704549d41771f= 085574045ff46 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include @@ -331,7 +331,7 @@ struct wcd9335_codec { int comp_enabled[COMPANDER_MAX]; =20 int intr1; - int reset_gpio; + struct gpio_desc *reset_gpio; struct regulator_bulk_data supplies[WCD9335_MAX_SUPPLY]; =20 unsigned int rx_port_value[WCD9335_RX_MAX]; @@ -4975,12 +4975,11 @@ static const struct regmap_irq_chip wcd9335_regmap_= irq1_chip =3D { static int wcd9335_parse_dt(struct wcd9335_codec *wcd) { struct device *dev =3D wcd->dev; - struct device_node *np =3D dev->of_node; int ret; =20 - wcd->reset_gpio =3D of_get_named_gpio(np, "reset-gpios", 0); - if (wcd->reset_gpio < 0) - return dev_err_probe(dev, wcd->reset_gpio, "Reset GPIO missing from DT\n= "); + wcd->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd->reset_gpio), "Reset GPIO missing = from DT\n"); =20 wcd->mclk =3D devm_clk_get(dev, "mclk"); if (IS_ERR(wcd->mclk)) @@ -5023,9 +5022,9 @@ static int wcd9335_power_on_reset(struct wcd9335_code= c *wcd) */ usleep_range(600, 650); =20 - gpio_direction_output(wcd->reset_gpio, 0); + gpiod_set_value(wcd->reset_gpio, 1); msleep(20); - gpio_set_value(wcd->reset_gpio, 1); + gpiod_set_value(wcd->reset_gpio, 0); msleep(20); =20 return 0; --=20 2.37.1