From nobody Mon Feb 9 07:23:43 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98FFF1DE3A7 for ; Sat, 22 Mar 2025 23:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742686148; cv=none; b=OmODdZwS9RsKg82DTsO8jHZ0j3+muDL4RY3OpjcWqoUgRNuMZZKq8POCnv8sgJWXkYrbU6txUCpYEIBSX0ir+yO5G7n0Y2o2OhAiq1bxN6z+RbvxILF69ngpWUAR+Wom60POP5V5LzSpLAsTswxOHjX0q4pL4iyrZ/7uebaF8Po= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742686148; c=relaxed/simple; bh=OhhVGWpcSFG4gipijq1AzZCC0xlnH6g6N0gsuYd0QGI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-type; b=jmPUKk3gaoLeTptOCTJVG8X9LvcAmUKfwlVH9SoUKlkuorH128QJ2AawCx52XRhxRsu//cz1lO2O3nRqK2lDQzGFrIIqvD27Ny3zG8aCM7wDHmW5N5/epkCgxZbA2Vxw6zJr3GtSEKV4l1SitoCGMvIUapL3S1/C3Wk6OulY5d8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BhB73TIB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BhB73TIB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742686145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=625UNCZM4QGRK3cVKqtvQTiUqdD7+p90TqpeI7OzcGs=; b=BhB73TIBli0NY9sMi3BQKKqdDIQ5N7WjImPxgdXlfEPi2dPib+qgaQ6rYXIfCfL4H/ks8A jsEM5Ol+ZG7gaUgyyFlUz4vPIcCuAXcYIoHtvWxFbK+CjgXiXXOYZaVh1ktIQGrAJA0sig URN/yVxaiDRKIZVVbtm8OWaRs5jjDJ0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-m2y5PiuGM1ybCcbv38OcJg-1; Sat, 22 Mar 2025 19:29:02 -0400 X-MC-Unique: m2y5PiuGM1ybCcbv38OcJg-1 X-Mimecast-MFC-AGG-ID: m2y5PiuGM1ybCcbv38OcJg_1742686141 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EF630180035C; Sat, 22 Mar 2025 23:29:00 +0000 (UTC) Received: from jmeneghi-thinkpadp1gen3.rmtusnh.csb (unknown [10.22.80.230]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C31AF180A802; Sat, 22 Mar 2025 23:28:58 +0000 (UTC) From: John Meneghini To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me Cc: loberman@redhat.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, emilne@redhat.com, jmeneghi@redhat.com, bgurney@redhat.com Subject: [PATCH v2 1/3] nvme-multipath: change the NVME_MULTIPATH config option Date: Sat, 22 Mar 2025 19:28:46 -0400 Message-ID: <20250322232848.225140-2-jmeneghi@redhat.com> In-Reply-To: <20250322232848.225140-1-jmeneghi@redhat.com> References: <20250322232848.225140-1-jmeneghi@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" Fix up the NVME_MULTIPATH config description so that it accurately describes what it does. Signed-off-by: John Meneghini Tested-by: John Meneghini Reviewed-by: Christoph Hellwig --- drivers/nvme/host/Kconfig | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index 10e453b2436e..d47dfa80fb95 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -18,10 +18,15 @@ config NVME_MULTIPATH bool "NVMe multipath support" depends on NVME_CORE help - This option enables support for multipath access to NVMe - subsystems. If this option is enabled only a single - /dev/nvmeXnY device will show up for each NVMe namespace, - even if it is accessible through multiple controllers. + This option controls support for multipath access to NVMe + subsystems. If this option is enabled support for NVMe multipath + access is included in the kernel. If this option is disabled support + for NVMe multipath access is excluded from the kernel. When this + option is disabled each controller/namespace receives its + own /dev/nvmeXnY device entry and NVMe multipath access is + not supported. + + If unsure, say Y. =20 config NVME_VERBOSE_ERRORS bool "NVMe verbose error reporting" --=20 2.48.1 From nobody Mon Feb 9 07:23:43 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 429CE1EF370 for ; Sat, 22 Mar 2025 23:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742686150; cv=none; b=LpNG+oMlfa+f5e+FsSusXpQmqXHvF/N1NiAc8BPIniT5WuNzo6wsMV1huKpL6n3NUkLceE3ptOj1roexE7rFzxbW35ap7Rqn2y5RgwCxXXrkC88nDO4QF+0M8FbqSjKbcdUcjMF0EQjHCw1pbIwtKtQdUrIKw8BK2QWL3dtDHYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742686150; c=relaxed/simple; bh=7ihAxwPsAqpSNUyD+ZlZX4Bc8YSv1vgcmJ8XAXcCu3Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-type; b=c3eQzZw2MUzYbQEGNvmIhGlDM/lS4mBL3A8L4wNQEYg8MChUg1ZJRnd2ywzPKlMLzHVuV8xlS5KawzJbloyLrgB9tg0C703a2dUP6pdvc6Bbp8OgXGhiZvdYGh+qkdlMtMoNwyzNb6zIEdTS3sri51TZcgfwgHTWNc4QzepM1+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iElE6diM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iElE6diM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742686148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=95vARJpK8cN2Fns4HX6JH0We9Ct8sqPV6rO+P5EgzGU=; b=iElE6diM+808jQ78SHaNzThp4csaAixoUIiOxErvSKIUWQD4AuEbINE9amBcxBCS5N4PPt xraFO6edG3wgoBKSiRPL9/UGOWrgJGMhOXvkRt6r2JtMUihnarAAp9u6sPcXod5SNgudhi BEn4JkTtvsSAlIA0Sgj/CmFUA2+0QJ4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-TgRwl_51OHWc1S5qIG9mQw-1; Sat, 22 Mar 2025 19:29:04 -0400 X-MC-Unique: TgRwl_51OHWc1S5qIG9mQw-1 X-Mimecast-MFC-AGG-ID: TgRwl_51OHWc1S5qIG9mQw_1742686143 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 09EEA195E92A; Sat, 22 Mar 2025 23:29:03 +0000 (UTC) Received: from jmeneghi-thinkpadp1gen3.rmtusnh.csb (unknown [10.22.80.230]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1EAD7180A802; Sat, 22 Mar 2025 23:29:00 +0000 (UTC) From: John Meneghini To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me Cc: loberman@redhat.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, emilne@redhat.com, jmeneghi@redhat.com, bgurney@redhat.com Subject: [PATCH v2 2/3] nvme-multipath: add the NVME_MULTIPATH_PARAM config option Date: Sat, 22 Mar 2025 19:28:47 -0400 Message-ID: <20250322232848.225140-3-jmeneghi@redhat.com> In-Reply-To: <20250322232848.225140-1-jmeneghi@redhat.com> References: <20250322232848.225140-1-jmeneghi@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" The new CONFIG_NVME_MULTIPATH_PARAM option controls the core_nvme.multipath parameter. When CONFIG_NVME_MULTIPATH_PARAM=3Dn the multipath parameter is removed from the kernel and nvme multipathing is permanently enabled. When NVME_MULTIPATH_PARAM=3Dy the nvme multipath parameter is added to the kernel and nvme multipath support is controlled by the core_nvme.multipath parameter. By default CONFIG_NVME_MULTIPATH_PARAM=3Dy Signed-off-by: John Meneghini Tested-by: John Meneghini Reviewed-by: Bryan Gurney --- drivers/nvme/host/Kconfig | 13 +++++++++++++ drivers/nvme/host/multipath.c | 3 ++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index d47dfa80fb95..c8458b10c83f 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -28,6 +28,19 @@ config NVME_MULTIPATH =20 If unsure, say Y. =20 +config NVME_MULTIPATH_PARAM + bool "NVMe multipath param" + depends on NVME_CORE && NVME_MULTIPATH + default y + help + This option controls the inclusion of the NVMe core module + "multipath" parameter. If this option is disabled the + nvme_core.multipath parameter is excluded from the kernel. + If this option is enabled the nvme_core.multipath parameter + is included in the kernel. + + If unsure, say Y. + config NVME_VERBOSE_ERRORS bool "NVMe verbose error reporting" depends on NVME_CORE diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 6b12ca80aa27..cad76de2830a 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -10,10 +10,11 @@ #include "nvme.h" =20 bool multipath =3D true; +#ifdef CONFIG_NVME_MULTIPATH_PARAM module_param(multipath, bool, 0444); MODULE_PARM_DESC(multipath, "turn on native support for multiple controllers per subsystem"); - +#endif static const char *nvme_iopolicy_names[] =3D { [NVME_IOPOLICY_NUMA] =3D "numa", [NVME_IOPOLICY_RR] =3D "round-robin", --=20 2.48.1 From nobody Mon Feb 9 07:23:43 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67A471DE3A7 for ; Sat, 22 Mar 2025 23:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742686152; cv=none; b=ct8a4pRBxHoNb/4rT56aNJAi5DnI8pzc8bQSiC010MxMomZV9hlPrpnNPUcLVzSF0u7QpOc95/dzNaJu26g3O1jg8Y9rUaDsjD0KzbymRWoGaFWhInyFaV8fN0w3uDUNCnZFSSV6TtKGLTRw6LvTUy0tyU9fYdkggAMLMcK3ERg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742686152; c=relaxed/simple; bh=lllit0NMMQY/u2TIPZPEii8FutUN6LEKYoD6+HLrsgU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-type; b=WkDc4YcCYWA91Xk+JwLns7Iqw/Qe3CuenZdFiTADPRgi9VhGDetMeBxRZhleOlhiZmUC2U4tvXom2r81xe+5XvWobqaN07w5Zp2cgv0h4CQ20/p1ItnwTFzsM679E4sO34ilXDcZb49HX/FBMTW1Uj5b22aNWgLeCt4VdpQRhJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L+7dWk89; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L+7dWk89" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742686150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3dHTI/nP8LMuZ8lpB+l5y9cpis9uyfq0/6jTpKt1DVU=; b=L+7dWk89dtY+BYezouXh7YMbXwnAOeM3SceVPfCI1nreCiKLQv5pqsmU90oEE1HTTxY4S/ t3XF/oaje1y7iQ0PNmdq1wahi7RczUpTYkguya0DIE94pRnFqjfNbbBkQzvSShq6P7bHbu Bn2yfWarTnjWzcL4sBVvSkjRt6ZjEQQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-cPjFTpHhPh6jDJhKOJXHCg-1; Sat, 22 Mar 2025 19:29:07 -0400 X-MC-Unique: cPjFTpHhPh6jDJhKOJXHCg-1 X-Mimecast-MFC-AGG-ID: cPjFTpHhPh6jDJhKOJXHCg_1742686145 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A1B75180049D; Sat, 22 Mar 2025 23:29:05 +0000 (UTC) Received: from jmeneghi-thinkpadp1gen3.rmtusnh.csb (unknown [10.22.80.230]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 30167180B487; Sat, 22 Mar 2025 23:29:03 +0000 (UTC) From: John Meneghini To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me Cc: loberman@redhat.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, emilne@redhat.com, jmeneghi@redhat.com, bgurney@redhat.com Subject: [PATCH v2 3/3] nvme: update the multipath warning in nvme_init_ns_head Date: Sat, 22 Mar 2025 19:28:48 -0400 Message-ID: <20250322232848.225140-4-jmeneghi@redhat.com> In-Reply-To: <20250322232848.225140-1-jmeneghi@redhat.com> References: <20250322232848.225140-1-jmeneghi@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" The new NVME_MULTIPATH_PARAM config option requires updates to the warning message in nvme_init_ns_head(). Signed-off-by: John Meneghini Tested-by: John Meneghini --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 870314c52107..b2bd8e1673ac 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3824,7 +3824,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, stru= ct nvme_ns_info *info) "Found shared namespace %d, but multipathing not supported.\n", info->nsid); dev_warn_once(ctrl->device, - "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprec= ated and will be removed in Linux 6.0.\n"); + "Shared namespace support requires core_nvme.multipath=3DY.\n"); } } =20 --=20 2.48.1