From nobody Wed Dec 17 12:10:11 2025 Received: from mx.swemel.ru (mx.swemel.ru [95.143.211.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A68B21F17EB for ; Fri, 21 Mar 2025 10:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.143.211.150 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742554365; cv=none; b=NLpqYsgDFci4drRzOb6rNYkwsAijHPnh4JTpEh8fDaRf0wz+YxXv9sK9J3eU8ykwcs4Db+2R8wqhcNSHs9unvGaujBXGOZYC5M2DTiHLTEcF/cYgIjveqUBI+vIMehM2TwQDhCaJ56eIjftIkT6aouLeFS3BIFBjFGYo6bDvCOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742554365; c=relaxed/simple; bh=arM2P0BqqOLwmqD5UyzLygYFgCoLIP9JlIa2W0xeKSo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K5ODD43pTdclyKO4V3mYtBfWFRn9KLeAUjIA8XsaWMhKP0aGM1WBftY0MtCd2JlQ+ROYjDqlQRsBHz7ZzkLXUhL+ADl6KoneT1XDBS0GWe9DZ3ZysuivmxDUEX29JzeJpyTlHneaRIOAmGxJV47jRyOOJRuVVkw1eH08z+irX/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=swemel.ru; spf=pass smtp.mailfrom=swemel.ru; dkim=pass (1024-bit key) header.d=swemel.ru header.i=@swemel.ru header.b=qYsti1BO; arc=none smtp.client-ip=95.143.211.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=swemel.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=swemel.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=swemel.ru header.i=@swemel.ru header.b="qYsti1BO" From: Denis Arefev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1742554360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU/JcHwDnP3QhY6ZpYqh86qRIlavKskpUsk2dt6mvLU=; b=qYsti1BOpbwSEu3jnaF8AotVFXZL95h0urNJC1Spu2nCDYOiGw/g68JvbiQM0VovQQUm4s TEOCpsLpokE27ffGL7j7X37pzpCqfuzh9t/e1F49xlX8qdjoxKmxnSQ145TtxMNdofRkTm Qu+Vrv4V4E1tJr9tEYoXdzggvFRDlr0= To: Kenneth Feng Cc: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Lijo Lazar , Ma Jun , Kun Liu , Boyuan Zhang , Tim Huang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH 2/5] drm/amd/pm: Prevent division by zero Date: Fri, 21 Mar 2025 13:52:32 +0300 Message-ID: <20250321105239.10096-3-arefev@swemel.ru> In-Reply-To: <20250321105239.10096-1-arefev@swemel.ru> References: <20250321105239.10096-1-arefev@swemel.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The user can set any speed value. If speed is greater than UINT_MAX/8, division by zero is possible. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: b64625a303de ("drm/amd/pm: correct the address of Arcturus fan relat= ed registers") Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gp= u/drm/amd/pm/swsmu/smu11/arcturus_ppt.c index 8aa61a9f7778..453952cdc353 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c @@ -1267,6 +1267,9 @@ static int arcturus_set_fan_speed_rpm(struct smu_cont= ext *smu, uint32_t crystal_clock_freq =3D 2500; uint32_t tach_period; =20 + if (!speed || speed > UINT_MAX/8) + return -EINVAL; + tach_period =3D 60 * crystal_clock_freq * 10000 / (8 * speed); WREG32_SOC15(THM, 0, mmCG_TACH_CTRL_ARCT, REG_SET_FIELD(RREG32_SOC15(THM, 0, mmCG_TACH_CTRL_ARCT), --=20 2.43.0