From nobody Sun Sep 7 23:50:49 2025 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4238F21ABA2 for ; Wed, 19 Mar 2025 21:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742420701; cv=none; b=noIWTElTVtEUdTa9ediHm+yfYbHfhW6EcvcP2ml16z60CdIMKeeaBT1gb67EDyvCk2xdgkRssyC+gXEiuRmYqNw4ptIkGMgP84JCeJH3s5laTJUbnzLBAQ3kPRI6vYTGbczaU+EimWdpDK6phrIzhNlmi8jPwzTqwEXdAsNcH6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742420701; c=relaxed/simple; bh=LXpHn3TdtsfnEHxi6iNJpiDVg89ttNCNCcLW0QdofyQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MGjppnAqZCudbKl+Zyhx1A0AwHsmOCbo5gVxYekAEIOStpXfUjnrhSA1dHvKstuSW2Lf8iulwkpuupDbeat6e/WsQa7B+Nh6+u0Rs96NovYORBzT/l302rCFsDeJ0hAAnLmQKHvanUdouXbo+He+wu9ei1M3ZI4zJylPPAqEW6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=lB/SSJjW; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="lB/SSJjW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be; t=1742420694; bh=9X1F/xfetnSLnkEq2u6eu/eFYJz8Nx38UqeZ/11Mabw=; b=lB/SSJjW21kNo2esZOL9KZQabetGtjVd0DrRJZw+O+4irfCaELd7VBXJFA2Lg06RcX7Tfhkg2 HvbadssJSy53Z1mUQHssfi8ePvzEgrxeAfB6ecK8KBssrtn3eJ874vQQbe0BWOfcihbcIcGSazl WETPHmnIL8zdC6Jo7GAG3qjSj0Sgot3Ki6qgDJBEmrF1mbiSJhOzdpS2+nPPQZnnvJS5EVIZQYk 2zpc7H0PAiQkvg1I7+eYDjlLIGvVM+7TK69ibMydO/gwEnnLmt7gsoLHl1jwMCm8G4tWYmOCzZm Np9qciP2adAiVqSRP77FfB3p2bvvglsT0kYc6ntXucyg== X-Forward-Email-ID: 67db3ac9cf4d592372b9942d X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 0.4.40 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Jonas Karlman To: Heiko Stuebner , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Wu , Yao Zi , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman , linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH net-next v3 4/5] net: stmmac: dwmac-rk: Add integrated_phy_powerdown operation Date: Wed, 19 Mar 2025 21:44:08 +0000 Message-ID: <20250319214415.3086027-5-jonas@kwiboo.se> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250319214415.3086027-1-jonas@kwiboo.se> References: <20250319214415.3086027-1-jonas@kwiboo.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rockchip RK3528 (and RV1106) has a different integrated PHY compared to the integrated PHY on RK3228/RK3328. Current powerup/down operation is not compatible with the integrated PHY found in these newer SoCs. Add a new integrated_phy_powerdown operation and change the call chain for integrated_phy_powerup to prepare support for the integrated PHY found in these newer SoCs. Signed-off-by: Jonas Karlman Reviewed-by: Andrew Lunn --- Changes in v3: - No change Changes in v2: - New patch --- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 26 +++++++++++-------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/e= thernet/stmicro/stmmac/dwmac-rk.c index 0321befed0d3..3673abd65302 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -33,6 +33,7 @@ struct rk_gmac_ops { void (*set_clock_selection)(struct rk_priv_data *bsp_priv, bool input, bool enable); void (*integrated_phy_powerup)(struct rk_priv_data *bsp_priv); + void (*integrated_phy_powerdown)(struct rk_priv_data *bsp_priv); bool php_grf_required; bool regs_valid; u32 regs[]; @@ -104,11 +105,8 @@ struct rk_priv_data { #define RK_GRF_CON2_MACPHY_ID HIWORD_UPDATE(0x1234, 0xffff, 0) #define RK_GRF_CON3_MACPHY_ID HIWORD_UPDATE(0x35, 0x3f, 0) =20 -static void rk_gmac_integrated_phy_powerup(struct rk_priv_data *priv) +static void rk_gmac_integrated_ephy_powerup(struct rk_priv_data *priv) { - if (priv->ops->integrated_phy_powerup) - priv->ops->integrated_phy_powerup(priv); - regmap_write(priv->grf, RK_GRF_MACPHY_CON0, RK_MACPHY_CFG_CLK_50M); regmap_write(priv->grf, RK_GRF_MACPHY_CON0, RK_GMAC2PHY_RMII_MODE); =20 @@ -129,7 +127,7 @@ static void rk_gmac_integrated_phy_powerup(struct rk_pr= iv_data *priv) } } =20 -static void rk_gmac_integrated_phy_powerdown(struct rk_priv_data *priv) +static void rk_gmac_integrated_ephy_powerdown(struct rk_priv_data *priv) { regmap_write(priv->grf, RK_GRF_MACPHY_CON0, RK_MACPHY_DISABLE); if (priv->phy_reset) @@ -368,6 +366,8 @@ static void rk3228_integrated_phy_powerup(struct rk_pri= v_data *priv) { regmap_write(priv->grf, RK3228_GRF_CON_MUX, RK3228_GRF_CON_MUX_GMAC_INTEGRATED_PHY); + + rk_gmac_integrated_ephy_powerup(priv); } =20 static const struct rk_gmac_ops rk3228_ops =3D { @@ -375,7 +375,8 @@ static const struct rk_gmac_ops rk3228_ops =3D { .set_to_rmii =3D rk3228_set_to_rmii, .set_rgmii_speed =3D rk3228_set_rgmii_speed, .set_rmii_speed =3D rk3228_set_rmii_speed, - .integrated_phy_powerup =3D rk3228_integrated_phy_powerup, + .integrated_phy_powerup =3D rk3228_integrated_phy_powerup, + .integrated_phy_powerdown =3D rk_gmac_integrated_ephy_powerdown, }; =20 #define RK3288_GRF_SOC_CON1 0x0248 @@ -601,6 +602,8 @@ static void rk3328_integrated_phy_powerup(struct rk_pri= v_data *priv) { regmap_write(priv->grf, RK3328_GRF_MACPHY_CON1, RK3328_MACPHY_RMII_MODE); + + rk_gmac_integrated_ephy_powerup(priv); } =20 static const struct rk_gmac_ops rk3328_ops =3D { @@ -608,7 +611,8 @@ static const struct rk_gmac_ops rk3328_ops =3D { .set_to_rmii =3D rk3328_set_to_rmii, .set_rgmii_speed =3D rk3328_set_rgmii_speed, .set_rmii_speed =3D rk3328_set_rmii_speed, - .integrated_phy_powerup =3D rk3328_integrated_phy_powerup, + .integrated_phy_powerup =3D rk3328_integrated_phy_powerup, + .integrated_phy_powerdown =3D rk_gmac_integrated_ephy_powerdown, }; =20 #define RK3366_GRF_SOC_CON6 0x0418 @@ -1802,16 +1806,16 @@ static int rk_gmac_powerup(struct rk_priv_data *bsp= _priv) =20 pm_runtime_get_sync(dev); =20 - if (bsp_priv->integrated_phy) - rk_gmac_integrated_phy_powerup(bsp_priv); + if (bsp_priv->integrated_phy && bsp_priv->ops->integrated_phy_powerup) + bsp_priv->ops->integrated_phy_powerup(bsp_priv); =20 return 0; } =20 static void rk_gmac_powerdown(struct rk_priv_data *gmac) { - if (gmac->integrated_phy) - rk_gmac_integrated_phy_powerdown(gmac); + if (gmac->integrated_phy && gmac->ops->integrated_phy_powerdown) + gmac->ops->integrated_phy_powerdown(gmac); =20 pm_runtime_put_sync(&gmac->pdev->dev); =20 --=20 2.49.0