From nobody Wed Dec 17 05:26:51 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61643254B1D for ; Wed, 19 Mar 2025 11:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742384346; cv=none; b=WHRZ0okhL6qz/ngnU86TFf9RihLKeHo8o0dmTjKgaXqI3si0U5QHK2TEpLl4MxlRDQRlGz2Meb9hk4BnrA710jB5JVv83ucYwtBH3nvlViLL4YDaGeS7SwGhO9p8iyQgtrdWcatF891BhYZU/T48FGJrw/vhBhjKlw1nsFpy9UE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742384346; c=relaxed/simple; bh=/ViqIW2rQ9pRcpWe1ja+iMw9gioppsGYG5b7wTCDJeo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T1+WRzZdOLkvMeekThQM2CkTEh789v0hyZmxiUB/P8YAKiY4Lk0+d+Gnphu19H4NCI+NR7WrBFnrG0T3SmjRRKxFI11lEOj+S38NatCLT1e1IO9PYC2dRgfTi8Hm5mernUPSmhT3HHZALiRZVzawA5jUs8EvSn6LoesEjGCcl8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=pass smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=zd9NL1P+; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="zd9NL1P+" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-224171d6826so37657875ad.3 for ; Wed, 19 Mar 2025 04:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1742384344; x=1742989144; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Oc66l7/d0Jjz8FMmOmNrv+ltKHYwWToN6Hiwa3da7k0=; b=zd9NL1P+4ywYlDJ63dfHRsO2AwDf8hX7nrwIKHAMEE5MfhNe4dSLPe84Is1/fucQoS NsBXqfVC1AUdxfoz6flEoqftiqx43HVtH01JdbG80K1zAhA+elDqG2NUvon7cyPre0wa vuTmOfP7TCV5eD7wPh/dWHoTuogKF3PZo3f/UzxEj2XhsQIGJeUnyhHd3Ze7jeWZROiA 1CzRU5XiZX5qph5UW6ughOlDsYYr/KF1XTJC73ORncAqL+Pymcj5VvHcMylXtHO/ueaX BuMMoBNDJUXiggYu5VkKsI2SRlgx5ZZFRnyoBgt/x7fXaG3FlM9yTWLde56dZmI1Oka4 4s5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742384344; x=1742989144; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oc66l7/d0Jjz8FMmOmNrv+ltKHYwWToN6Hiwa3da7k0=; b=wAj8AyxL8OD95L/icQzWKprJmb3+xSm/KPCQoePDY883CipfK+EDunLVLKXV0H4Is6 WilV/ovNXvI9ZepBsUg5LhORKSkInu0S6QtSj6mD32jRO4EjZvvWAu4VjdZuZ//ov/p4 LSWwMnywYOTuBBR/oGLhOHXCDSKzQNfV5KlIWNsCsCyTPzIZx2WEevAPp9YrHGDa/Tky R9TjG02OvCzWA68kkXTBmeXfkkkN28AazWlaARRtxOpqrzonyuR9Om9cNI+Kmo9q6rt2 rAFj+oVzBSKVmxb/cQDrWsB0bgjUpfFZUXZhJBbAfLGRi6zn9+z/83tm3vrXDUZOZJ4M XEmw== X-Forwarded-Encrypted: i=1; AJvYcCVe4FrN8z3b93SdMAoBlMWcI+I8GtCP93Uyrrk7iyvfA3Ilxq1lWFDsVfbNCGsnaqDDJf+WwSG7kG0diJE=@vger.kernel.org X-Gm-Message-State: AOJu0YwZbqfGKacz36UzXER3zp508zPu2Jn6MLLnjp7EVOGW5rv+IryY qci0PKWNZSwbf2HUvyzBMWFHGHf9YXFvkW7H88qAQY4mWpoxoli1UoBOX3g+z1M= X-Gm-Gg: ASbGncsLQaB0xeQrVE8RWaAFcUOSVGDFK72ryXI1srTyhSiCWuwfsU/aSXgSFLEYF3l R9uGEuEip/O7G/obXkudIRhk2s6akRVshccXZcpXPp7Xakp16LO/46FucPULOLW23GO3mmj1UNS SkjYZHoSmdN4m0sNyL0wAo/yFcCzqBNflIICmADJBJHwzBccik8KmEUlchtv7Wstj4qT+FmwnIa sZ9d0WpRocP6nzf5zywiQMtI2nw17NPs/WFg8rvE6xMFiHJ9QvIi8Zhfl2JjAkho1QkU+CSXn/H R8M1qfFP758H4gmofWlziSMle/xV25uow7zAQjIoeXhVg2Qp X-Google-Smtp-Source: AGHT+IGSv0AJ8KwpE6fQl4DpNJB/7VkQwjj59TCcKQRqKU8wam5+t3NXf5mYBQBcpLosGuAKvIYqVA== X-Received: by 2002:a17:903:1790:b0:224:283f:a9ef with SMTP id d9443c01a7336-2264981d654mr33063775ad.6.1742384344597; Wed, 19 Mar 2025 04:39:04 -0700 (PDT) Received: from localhost ([157.82.207.107]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-225c6bd5ce5sm111657845ad.252.2025.03.19.04.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Mar 2025 04:39:04 -0700 (PDT) From: Akihiko Odaki Date: Wed, 19 Mar 2025 20:38:55 +0900 Subject: [PATCH 1/2] KVM: arm64: Trace values with kvm_sys_access Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250319-trace-v1-1-0fff03204efa@daynix.com> References: <20250319-trace-v1-0-0fff03204efa@daynix.com> In-Reply-To: <20250319-trace-v1-0-0fff03204efa@daynix.com> To: Marc Zyngier , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, devel@daynix.com, Akihiko Odaki X-Mailer: b4 0.15-dev-edae6 Tracing values written to or read from system registers. Signed-off-by: Akihiko Odaki --- arch/arm64/kvm/sys_regs.c | 24 ++++++++++++++---------- arch/arm64/kvm/trace_handle_exit.h | 6 ++++-- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index 14f66c7a4545..362e2758d101 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -3994,23 +3994,27 @@ static void perform_access(struct kvm_vcpu *vcpu, struct sys_reg_params *params, const struct sys_reg_desc *r) { - trace_kvm_sys_access(*vcpu_pc(vcpu), params, r); + bool skip; =20 /* Check for regs disabled by runtime config */ if (sysreg_hidden(vcpu, r)) { kvm_inject_undefined(vcpu); - return; + skip =3D false; + } else { + /* + * Not having an accessor means that we have configured a trap + * that we don't know how to handle. This certainly qualifies + * as a gross bug that should be fixed right away. + */ + BUG_ON(!r->access); + + /* Skip instruction if instructed so */ + skip =3D r->access(vcpu, params, r); } =20 - /* - * Not having an accessor means that we have configured a trap - * that we don't know how to handle. This certainly qualifies - * as a gross bug that should be fixed right away. - */ - BUG_ON(!r->access); + trace_kvm_sys_access(*vcpu_pc(vcpu), params, r); =20 - /* Skip instruction if instructed so */ - if (likely(r->access(vcpu, params, r))) + if (likely(skip)) kvm_incr_pc(vcpu); } =20 diff --git a/arch/arm64/kvm/trace_handle_exit.h b/arch/arm64/kvm/trace_hand= le_exit.h index f85415db7713..b0308d95304d 100644 --- a/arch/arm64/kvm/trace_handle_exit.h +++ b/arch/arm64/kvm/trace_handle_exit.h @@ -88,6 +88,7 @@ TRACE_EVENT(kvm_sys_access, =20 TP_STRUCT__entry( __field(unsigned long, vcpu_pc) + __field(u64, regval) __field(bool, is_write) __field(const char *, name) __field(u8, Op0) @@ -99,6 +100,7 @@ TRACE_EVENT(kvm_sys_access, =20 TP_fast_assign( __entry->vcpu_pc =3D vcpu_pc; + __entry->regval =3D params->regval; __entry->is_write =3D params->is_write; __entry->name =3D reg->name; __entry->Op0 =3D reg->Op0; @@ -109,10 +111,10 @@ TRACE_EVENT(kvm_sys_access, __entry->Op2 =3D reg->Op2; ), =20 - TP_printk("PC: %lx %s (%d,%d,%d,%d,%d) %s", + TP_printk("PC: %lx %s (%d,%d,%d,%d,%d) %llx %s", __entry->vcpu_pc, __entry->name ?: "UNKN", __entry->Op0, __entry->Op1, __entry->CRn, - __entry->CRm, __entry->Op2, + __entry->CRm, __entry->Op2, __entry->regval, __entry->is_write ? "write" : "read") ); =20 --=20 2.48.1 From nobody Wed Dec 17 05:26:51 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D28B4255E40 for ; Wed, 19 Mar 2025 11:39:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742384351; cv=none; b=FIWFdWz1p/kg1cdRgAuk8/fJdC3K3ut8ePOhd3ypEmR3jyzjNYjWAUsPSesyHOLMOnY8baZqSutITFSj41jqcRrhj6z3NZHH7FVYmLTiFy+aJ2FtBv+IhJGEqCgPuUPwpozv04kyLmPcshQ6Hop2TahxDfX59E3CZ9aUwZAkAco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742384351; c=relaxed/simple; bh=wSsvSlNkNr2nAKIQx6vbdaSycDEUcJGLMq0k1Pp9xg8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uB2c9GQn3HFsICnSck0Jo6QnhZNNWP1tZmDmU12oTLQb116nV7xKYKlj3lOy7Y91VlscWaX0AAdF0Go/LE9gQ0mHTnhVnpSydRS0FtgtnXA0qTBwmteKRr31pyQ1igsJE0l0c7nXUFnnYmLZuM/O/uivb0PmrethJGr8kzat7D8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=pass smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=HL+eylqX; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="HL+eylqX" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-225477548e1so117982415ad.0 for ; Wed, 19 Mar 2025 04:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1742384349; x=1742989149; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BJsAUn2tJ/N0GZBEAi0IEG/qBVORqD8jC/NmJGn5En4=; b=HL+eylqXX7DQgtbL+gzbqQ5nNgu+gfxX9388OsxUiPBZJedp4uEZrlEZwxuo9MlULW AlusvmNBWhrK2E8ZB8NMxswRQxiqB30tVKs4cJqIO3Mdp6AJd2ziSTUpqqh0KWD/NNlb veYCU6O77UbF8P35ypeU7g02eQikjlpLcMD6xYwgS27YUAHfE4o6xtMp+EKlzFCOz/sJ Yo7c5Bk32dLf2oBduXaPOFGSW2KIeYIyMx4bK/vLwkc31FeWcVoVGCPGHFFi9HN5LYhX 3uSd5gMk/vvLp4Z9oQDeWnn5hdzAXzs5uJch5e8Tso8QBKIlVvBRNK1GevpEEjhNNC+F e5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742384349; x=1742989149; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BJsAUn2tJ/N0GZBEAi0IEG/qBVORqD8jC/NmJGn5En4=; b=YYrcLiMNEUffi8WEBKPAynKvrp8vS0bqr9VMfQ3v2ABsdgwwynCEd0uliOam5uTeX7 RvVQpzO8Gu6xuoHXQRQ2m0qfnbbqFGNJGAgHwoE8hwQB/vh/WpP3lSNTG8AjwdebHVSM 7C2z106IVH1pe4IMTbUoEtVh2IAzHNjXA2JaXYSvOv6LUsk/V065EWDJolRqGOChGbmq vhHi8M17z+wlZkxnHO4ZL72fmOw/Rs14dmrmLfDr1OL3TI4UJHg9n/JZkFL4BM1nsIP/ CPLMOYwyxcYTFN1fqe0pFlwC8/1G7oXK7twv46RYzXzeYZZd4kZkbEsjc46BdduQC3i9 UahA== X-Forwarded-Encrypted: i=1; AJvYcCU59vWunoUHGib814esq3d69zvbWCEtzokJUoFLX1J+iczjxyQPukprMJmL7fXLIBsOijO/Bgjg/KLTeP8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0W+vYsW7KJLYFlzSSca05/fYkiG37Ifr2x69+wyhWgLyRl2WQ jPN+wYu2kGemX3I+/S3xBeHeP06pyR3F6pqYT352Sax5nP/IPVHwDmLptiR4dyg= X-Gm-Gg: ASbGnctzllnvyR9ZhBbTNVQYRnl8JG9HtGsDLSUdF1IZxJvfE6GLyePSFKP1xNeQL6V FDGkpAlOq4ckplD90XePK3au9UtHZVU4mh64PCbQZJBqhvEVEVwqMTdMwhB73mmYx/+ATKrrY3m YyWhk2ve9NveLdpn04VIoydyiDcj8+sMimmL2fGJSI0y1g3zdbUJnyxHH+X8YnCd67rXQ7csJMc uTzXmSWwWPEHrpfnSBGDux6qqj3EClaljhArvKDhQDQxoLw2jFOtvcUaCVe5qIth1uPsQlP6CfI DehTyRPhq0jxBRIi7a1+wE7gwRH5kd0vG4iPSTbgQ4RqHLks X-Google-Smtp-Source: AGHT+IGfWVdcLoiaUgIHbjMMUMvA2v0l8u40e6hMqGpDW/wkNrA/pWWYq1nd4axTz9YOadVt/J2Xdg== X-Received: by 2002:a17:903:32c3:b0:211:e812:3948 with SMTP id d9443c01a7336-22649580acdmr35244335ad.0.1742384349386; Wed, 19 Mar 2025 04:39:09 -0700 (PDT) Received: from localhost ([157.82.207.107]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-225c68887fcsm111347295ad.39.2025.03.19.04.39.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Mar 2025 04:39:09 -0700 (PDT) From: Akihiko Odaki Date: Wed, 19 Mar 2025 20:38:56 +0900 Subject: [PATCH 2/2] KVM: arm64: Trace SMC in a way similar to HVC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250319-trace-v1-2-0fff03204efa@daynix.com> References: <20250319-trace-v1-0-0fff03204efa@daynix.com> In-Reply-To: <20250319-trace-v1-0-0fff03204efa@daynix.com> To: Marc Zyngier , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, devel@daynix.com, Akihiko Odaki X-Mailer: b4 0.15-dev-edae6 KVM handles SMCCC calls from virtual EL2 that use the SMC instruction since commit bd36b1a9eb5a ("KVM: arm64: nv: Handle SMCs taken from virtual EL2"). Copy the tracepoint for HVC to the SMC handler to trace SMCCC calls whether they come from either HVC or SMC. Signed-off-by: Akihiko Odaki --- arch/arm64/kvm/handle_exit.c | 3 +++ arch/arm64/kvm/trace_handle_exit.h | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c index 512d152233ff..087880b645be 100644 --- a/arch/arm64/kvm/handle_exit.c +++ b/arch/arm64/kvm/handle_exit.c @@ -55,6 +55,9 @@ static int handle_hvc(struct kvm_vcpu *vcpu) =20 static int handle_smc(struct kvm_vcpu *vcpu) { + trace_kvm_smc_arm64(*vcpu_pc(vcpu), vcpu_get_reg(vcpu, 0), + kvm_vcpu_hvc_get_imm(vcpu)); + /* * Forward this trapped smc instruction to the virtual EL2 if * the guest has asked for it. diff --git a/arch/arm64/kvm/trace_handle_exit.h b/arch/arm64/kvm/trace_hand= le_exit.h index b0308d95304d..a3a0e0a46c60 100644 --- a/arch/arm64/kvm/trace_handle_exit.h +++ b/arch/arm64/kvm/trace_handle_exit.h @@ -46,6 +46,26 @@ TRACE_EVENT(kvm_hvc_arm64, __entry->vcpu_pc, __entry->r0, __entry->imm) ); =20 +TRACE_EVENT(kvm_smc_arm64, + TP_PROTO(unsigned long vcpu_pc, unsigned long r0, unsigned long imm), + TP_ARGS(vcpu_pc, r0, imm), + + TP_STRUCT__entry( + __field(unsigned long, vcpu_pc) + __field(unsigned long, r0) + __field(unsigned long, imm) + ), + + TP_fast_assign( + __entry->vcpu_pc =3D vcpu_pc; + __entry->r0 =3D r0; + __entry->imm =3D imm; + ), + + TP_printk("SMC at 0x%016lx (r0: 0x%016lx, imm: 0x%lx)", + __entry->vcpu_pc, __entry->r0, __entry->imm) +); + /* * The dreg32 name is a leftover from a distant past. This will really * output a 64bit value... --=20 2.48.1